- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR3187: winemac.drv: Give Apple GPUs device IDs
by Zebediah Figura (＠zfigura) 29 Jun '23

29 Jun '23

> MoltenVK has its own scheme for assigning a PCI device ID to the AGX GPUs. I wonder if it wouldn't be worth attempting to emulate that in case apps try to match the ID from Vulkan to this one. Or retrieve the devices from Vulkan (as winex11) if Vulkan is available? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3187#note_37353

1 0

[PATCH 0/5] MR258: hlsl: Replace bare list pointers with hlsl_block, part 2.
by Zebediah Figura (＠zfigura) 29 Jun '23

29 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/258

3 11

[PATCH 0/2] MR3198: combase: Pass the correct destination context when unmarshaling using the standard marshaler.
by Connor McAdams (＠cmcadams) 29 Jun '23

29 Jun '23

This fixes an issue I ran into in UI Automation using an interface proxy marshaled with `MSHCTX_INPROC`. `CoUnmarshalInterface` always passes `MSHCTX_LOCAL` when the standard marshaler, regardless of what was passed to `CoMarshalInterface`. When passing an interface that uses the free threaded marshaler as an argument to a method on the proxy retrieved from `CoUnmarshalInterface`, it passes `MSHCTX_LOCAL` when trying to marshal, which the results in the free threaded marshaler trying to create a proxy/stub which fails. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3198

3 3

Re: [PATCH v2 0/1] MR3187: winemac.drv: Give Apple GPUs device IDs
by Brendan Shanks (＠bshanks) 29 Jun '23

29 Jun '23

> Do we need things built on 10.14 to run on M1 Macs (which don't support 32-bit)? If not, I can just ifdef it out in that case. Otherwise, I can try defining those symbols manually. I think an ifdef (`#if defined(MAC_OS_X_VERSION_10_15) && MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_15`) should be fine, especially with Metal nobody should be expecting full functionality when building against old SDKs and then deploying to new ones. (it would be nice if we could use `@available`, but that requires Xcode 9) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3187#note_37348

1 0

Re: [PATCH v2 0/1] MR3187: winemac.drv: Give Apple GPUs device IDs
by Evan Tang (＠etang-cw) 29 Jun '23

29 Jun '23

> MoltenVK has its own scheme for assigning a PCI device ID to the AGX GPUs. I wonder if it wouldn't be worth attempting to emulate that in case apps try to match the ID from Vulkan to this one. [They used to, but now they just use the device feature set plus the OS version](https://github.com/KhronosGroup/MoltenVK/commit/df043487e4711fe61e…. I'm a bit worried about sticking the OS version on top like they do, since PCI device IDs are normally 16-bit, but maybe that would work out fine? > This is also producing a build failiure on macOS 10.14 Do we need things built on 10.14 to run on M1 Macs (which don't support 32-bit)? If not, I can just ifdef it out in that case. Otherwise, I can try defining those symbols manually. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3187#note_37342

1 0

[PATCH v10 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 29 Jun '23

29 Jun '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v10: comdlg32: Enable visual styles when showing IFileDialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

4 7

[PATCH v7 0/6] MR2944: winewayland.drv: part 4: First window contents on screen
by Alexandros Frantzis (＠afrantzis) 29 Jun '23

29 Jun '23

The goal of this MR is to set up the minimum necessary infrastructure to display the contents of some simple, software rendered windows. This involves two major steps: 1. Associate a window with a Wayland surface and give it the `xdg_toplevel` role, so that the compositor can display it. We also have to implement the required initial `xdg_surface` configuration sequence to be able to safely (i.e., without the compositor disconnecting us with an error) attach buffers to the surface in step (2). 2. Implement the `window_surface` interface for the Wayland driver. For now we provide a simple (and suboptimal) `window_surface_flush` implementation: for each flush we create a new `wl_shm` buffer, copy the whole window contents (ignoring damaged bounds for now) into it and attach it to the target Wayland surface. In the next MR I will optimize this implementation in multiple ways: a. implement a buffer queue to avoid constantly allocating new buffers b. respect the damaged bounds of the `window_surface` to minimize copying of data from the `window_surface` to the SHM buffer (and also for correctness) c. communicate damaged surface regions to the compositor to (potentially) allow more efficient texture uploads. With this MR many (software-rendered) applications can now display dynamic content on screen. We can't interact with the apps yet, but we do get to enjoy `notepad` in all its blinking-cursor glory. Thanks! -- v7: winewayland.drv: Do not commit buffers to unconfigured surfaces. winewayland.drv: Implement a simple window_surface flush. https://gitlab.winehq.org/wine/wine/-/merge_requests/2944

2 9

[PATCH 0/1] MR3197: win32u: Update the display cache when virtual desktop mode changes.
by Rémi Bernon (＠rbernon) 29 Jun '23

29 Jun '23

We update the cache in NtUserCreateDesktopEx, as it may change existing thread desktop flags, but we need to do it as well when a new desktop is created while still detached, then attached to a thread through NtUserSetThreadDesktop. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55146 This is the case when forcing virtual desktop mode with new desktop creation by running `explorer /desktop=test,1024x768 winecfg` for instance. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3197

2 1

[PATCH 0/1] MR3190: kernelbase: Check if locale is NULL before using it in Internal_EnumDateFormats().
by Zhiyi Zhang (＠zhiyi) 29 Jun '23

29 Jun '23

Initialize the calendars variable after checking if locale is NULL before using it to avoid NULL pointer references. Fix a Excel 2016 crash when formatting dates with the custom format 'ddd'. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3190

3 2

[PATCH v8 0/4] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 29 Jun '23

29 Jun '23

-- v8: vkd3d-shader/tpf: Add support for writing 'resinfo' instruction. vkd3d-shader/tpf: Add support for writing 'sampleinfo' instruction. vkd3d-shader/hlsl: Parse GetDimensions() method. tests: Add some tests for GetDimensions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

2 4

[PATCH v2 0/8] MR3177: wine{alsa,coreaudio,oss,pulse}: Match GetAudioEndpoint implementations.
by Davide Beatrici (＠davidebeatrici) 29 Jun '23

29 Jun '23

-- v2: winepulse: Refactor get_device_name_from_guid() to allocate memory dynamically. wineoss: Refactor get_device_name_from_guid() to allocate memory dynamically. winecoreaudio: Refactor get_device_name_from_guid() to allocate memory dynamically. winealsa: Refactor get_device_name_from_guid() to allocate memory dynamically. winepulse: Return E_UNEXPECTED with invalid dataflow in GetAudioEndpoint. wineoss: Return E_UNEXPECTED with invalid dataflow in GetAudioEndpoint. winecoreaudio: Return E_UNEXPECTED with invalid dataflow in GetAudioEndpoint. https://gitlab.winehq.org/wine/wine/-/merge_requests/3177

3 11

[PATCH v2 0/5] MR250: vkd3d-shader/hlsl: Declare vars individually when parsing declarations.
by Francisco Casas (＠fcasas) 29 Jun '23

29 Jun '23

In a declaration with multiple variables, the variables must be created before the initializer of the next variable is parsed. This is required for initializers such as: ``` float a = 1, b = a, c = b + 1; ``` The solution is to parse the type information in the same rule as the first variable ('a' in this case) so that it can be declared before the parser reaches the initializer for the following variables. To initialize the following variables, the type information is passed along from the first variable's struct parse_variable_def to the next and so on. --- Solves https://bugs.winehq.org/show_bug.cgi?id=54484, pointed out by @nsivov. -- v2: vkd3d-shader/hlsl: Declare vars individually when parsing struct declarations. vkd3d-shader/hlsl: Declare vars individually when parsing regular declarations. vkd3d-shader/hlsl: Split declare_vars(). tests: Test multiple variable initializers. tests: Test semantics in uniform variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/250

4 9

[PATCH 0/2] MR3195: oleaut32: OaBuildVersion - Fix return for available windows versions
by Alistair Leslie-Hughes (＠alesliehughes) 29 Jun '23

29 Jun '23

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=54257 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3195

2 2

Re: [PATCH v2 0/1] MR3187: winemac.drv: Give Apple GPUs device IDs
by Huw Davies (＠huw) 29 Jun '23

29 Jun '23

This is also producing a build failiure on macOS 10.14 ``` gcc -m32 -c -o dlls/winemac.drv/cocoa_display.o dlls/winemac.drv/cocoa_display.m -Idlls/winemac.drv -Iinclude -D__WINESRC__ \ -DWINE_UNIX_LIB -Wall -pipe -fno-stack-protector -fno-strict-aliasing \ -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Winit-self -Wno-pragma-pack \ -Wstrict-prototypes -Wtype-limits -Wvla -Wwrite-strings -Wpointer-arith -gdwarf-4 -fPIC \ -fasynchronous-unwind-tables -O2 -g -Wno-deprecated-declarations -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 dlls/winemac.drv/cocoa_display.m:273:94: warning: instance method '-supportsFamily:' not found (return type defaults to 'id') [-Wobjc-method-access] if (!gpu->device_id && [device respondsToSelector:@selector(supportsFamily:)] && [device supportsFamily:MTLGPUFamilyApple1]) ^~~~~~~~~~~~~~ dlls/winemac.drv/cocoa_display.m:273:109: error: use of undeclared identifier 'MTLGPUFamilyApple1' if (!gpu->device_id && [device respondsToSelector:@selector(supportsFamily:)] && [device supportsFamily:MTLGPUFamilyApple1]) ^ dlls/winemac.drv/cocoa_display.m:275:9: error: use of undeclared identifier 'MTLGPUFamily' MTLGPUFamily highest = MTLGPUFamilyApple1; ^ dlls/winemac.drv/cocoa_display.m:279:13: error: use of undeclared identifier 'MTLGPUFamily' MTLGPUFamily next = highest + 1; ^ dlls/winemac.drv/cocoa_display.m:280:25: warning: instance method '-supportsFamily:' not found (return type defaults to 'id') [-Wobjc-method-access] if ([device supportsFamily:next]) ^~~~~~~~~~~~~~ dlls/winemac.drv/cocoa_display.m:280:40: error: use of undeclared identifier 'next' if ([device supportsFamily:next]) ^ dlls/winemac.drv/cocoa_display.m:281:17: error: use of undeclared identifier 'highest' highest = next; ^ dlls/winemac.drv/cocoa_display.m:281:27: error: use of undeclared identifier 'next' highest = next; ^ dlls/winemac.drv/cocoa_display.m:285:26: error: use of undeclared identifier 'highest'; did you mean 'sigset'? gpu->device_id = highest; ^~~~~~~ sigset /usr/include/signal.h:99:22: note: 'sigset' declared here void (* _Nullable sigset(int, void (* _Nullable)(int)))(int); ^ dlls/winemac.drv/cocoa_display.m:285:24: warning: incompatible pointer to integer conversion assigning to 'uint32_t' (aka 'unsigned int') from 'void (* _Nullable (int, void (* _Nullable)(int)))(int)' [-Wint-conversion] gpu->device_id = highest; ^ ~~~~~~~ ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3187#note_37303

1 0

[PATCH 0/1] MR3194: explorer: Fix command-line parameter parsing.
by Rémi Bernon (＠rbernon) 29 Jun '23

29 Jun '23

Fixes: 5b11157ecf787e545062000ab6afd1c55ee8dacc Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55141 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3194

2 1

[PATCH v2 0/3] MR251: vkd3d: Fix a few resource leaks here and there
by Giovanni Mascellani (＠giomasce) 29 Jun '23

29 Jun '23

-- v2: vkd3d: Release op data when destroying the queue. vkd3d: Always emit an error when failing to reserve for the op array. vkd3d: Release the op mutex on allocation failure. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/251

2 3

[PATCH v2 0/4] MR2822: wined3d: Recreate swapchain textures in wined3d_swapchain_resize_buffers().
by Zebediah Figura (＠zfigura) 29 Jun '23

29 Jun '23

-- v2: wined3d: Remove no longer used arguments from wined3d_texture_update_desc(). wined3d: Recreate swapchain textures in wined3d_swapchain_resize_buffers(). wined3d: Factor out a swapchain_create_texture() helper. dxgi: Do not create a d3d11 swapchain object for the implicit swapchain. https://gitlab.winehq.org/wine/wine/-/merge_requests/2822

3 5

[PATCH 0/5] MR3192: winegstreamer: More media source creation cleanup.
by Rémi Bernon (＠rbernon) 29 Jun '23

29 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3192

2 5

[PATCH v2 0/5] MR3162: Chromium sandbox fixes
by Zhiyi Zhang (＠zhiyi) 29 Jun '23

29 Jun '23

This series of patches enable Adobe PDF Reader 11 protected mode, which is essentially a Chromium sandbox, to work properly. -- v2: server: Allow creating a real explorer desktop window for invisible window stations. user32/tests: Test that an actual desktop window should be created on invisible window stations. win32u: Use the window station name to check if an application is running as a service. user32/tests: Test monitor information with an invisible window station. win32u: Create explorer with the thread effective access token. https://gitlab.winehq.org/wine/wine/-/merge_requests/3162

2 5

Re: [PATCH v2 0/1] MR3187: winemac.drv: Give Apple GPUs device IDs
by Chip Davis (＠cdavis5e) 29 Jun '23

29 Jun '23

Ah, dammit, I wish I had caught this sooner. MoltenVK has its own scheme for assigning a PCI device ID to the AGX GPUs. I wonder if it wouldn't be worth attempting to emulate that in case apps try to match the ID from Vulkan to this one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3187#note_37247

1 0

[PATCH v5 0/6] MR3007: Draft: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker (＠bernhardu) 29 Jun '23

29 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: (d4a7440a) - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: (6a69c680) - Fix typo in commit message. - Modified format strings. - v5: (47784feb) - Move test to own test function. - Move check to wine_server_add_data. - v6: (8c641d09) - Move check to NtDeviceIoControlFile - Add (at least temporary) tests to compare with NtDeviceIoControlFile and NtFsControlFile. -- v5: kernel32/tests: Add test for IOCTL_STORAGE_GET_DEVICE_NUMBER. ntdll: Add validation for input and output buffers in NtDeviceIoControlFile. ntoskrnl.exe: Allow sending a null input buffer to the driver. ntoskrnl.exe: Add todo_wine_if to test_ioctl_buffers. ntoskrnl.exe: Remove buffer assignments in test_ioctl_buffers. ntoskrnl.exe: Add test_ioctl_buffers by Zebediah Figura. https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

4 9

[PATCH v3 0/2] MR3186: ntdll/unix: Skip address conversion for TCP sockets in try_send().
by Ally Sommers (＠dropbear) 29 Jun '23

29 Jun '23

On Windows, `sendto()` ignores its destination parameters when provided with a connection-based socket (currently only SOCK_STREAM), even if they contain invalid data. This patch implements this behavior. -- v3: ws2_32/tests: Add test for sendto() and recvfrom() on TCP sockets. https://gitlab.winehq.org/wine/wine/-/merge_requests/3186

4 7

[PATCH 0/2] MR256: vkd3d-shader/hlsl: Support evaluated expressions for sample count in...
by Nikolay Sivov (＠nsivov) 29 Jun '23

29 Jun '23

vkd3d-shader/hlsl: Support evaluated expressions for sample count in multisampled textures declarations. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/256

3 3

[PATCH v31 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 29 Jun '23

29 Jun '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v31: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 8

Re: [PATCH v5 0/1] MR19: maintainers: New file. - closed
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

This merge request was closed by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/19

1 0

Re: [PATCH v5 0/1] MR19: maintainers: New file.
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

Yeah, I don't particularly remember what I was trying to do with this... it may have been an attempt to formalize the list of HLSL maintainers and/or avoid the need for Henri to sign off on those patches. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/19#note_37232

1 0

Re: [PATCH v5 0/1] MR19: maintainers: New file.
by Henri Verbeet (＠hverbeet) 28 Jun '23

28 Jun '23

It's probably as good a time as any to revisit this. I don't think the project is quite large enough to really need this at this point; I think "git log" paints a fairly decent picture of who touches which code, and Wine essentially did fine without a maintainers file for the first two decades or so too. I could certainly be convinced the project would benefit from having this, but right now this feels a bit like a solution in search of a problem to me. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/19#note_37231

1 0

Re: [PATCH v2 0/1] MR52: configure: Allow linking against static SPIRV-Tools.
by Henri Verbeet (＠hverbeet) 28 Jun '23

28 Jun '23

I think that's a libtool/automake thing. The vkd3d-compiler target will get the -lSPIRV-Tools-shared flag from libvkd3d-shader.la, but not the -L flag with the additional path, so ld won't know where to find libSPIRV-Tools-shared.so unless you e.g. set an appropriate LD_LIBRARY_PATH. Adding @SPIRV_TOOLS_LIBS@ to vkd3d_compiler_LDADD (and DEMOS_LDADD) avoids the issue at build time, but you'll still need to set LD_LIBRARY_PATH to run the resulting executable. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/52#note_37229

1 0

[PATCH 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 28 Jun '23

28 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

3 8

Re: [PATCH v5 0/1] MR19: maintainers: New file.
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

Sorry, accidentally pushed to the wrong branch. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/19#note_37225

1 0

Re: [PATCH v2 0/1] MR3143: windowscodecs: Fake success in SetMetadataByName - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3143

1 0

Re: [PATCH v2 0/1] MR3187: winemac.drv: Give Apple GPUs device IDs - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3187

1 0

Re: [PATCH v3 0/1] MR3014: winegstreamer: Fix double free on error path in media_source_constructor (scan-build). - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3014

1 0

Re: [PATCH v5 0/2] MR3161: Dsdmo effects - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3161

1 0

Re: [PATCH v2 0/3] MR3178: explorer: Set virtual desktop primary adapter display settings. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3178

1 0

[PATCH v2 0/3] MR255: vkd3d-shader: Scan for the maximum temporary register in d3dbc and emit a spirv temp array accordingly.
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

``` On Margate Sands. I can connect Nothing with nothing. ``` -- v2: vkd3d-shader/d3dbc: Scan for the maximum temporary register index. vkd3d-shader: Record a global temporary count per sm4 shader. vkd3d-shader/dxbc: Remove redundant zero-initialization of the vkd3d_shader_desc structure. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/255

2 4

Re: [PATCH v2 0/7] MR3180: Hidden macro removal - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3180

1 0

Re: [PATCH v2 0/5] MR3179: winegstreamer: More media source creation cleanup. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3179

1 0

Re: [PATCH v3 0/1] MR3185: bcrypt: Add RC4 algorithm stub. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3185

1 0

Re: [PATCH v2 0/2] MR3183: winscard: Implement SCARD_AUTOALLOCATE for multi-string return values. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3183

1 0

Re: [PATCH v3 0/1] MR3184: win32u: Don't affect nonclient area unless requested. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3184

1 0

Re: [PATCH v4 0/1] MR3182: include: Fix spelling error when define InterlockedDecrementSizeT(). - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3182

1 0

Re: [PATCH v2 0/1] MR52: configure: Allow linking against static SPIRV-Tools. - closed
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

This merge request was closed by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/52

1 0

Re: [PATCH v2 0/1] MR52: configure: Allow linking against static SPIRV-Tools.
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

I hate Markdown. Again. Here's the error, in readable form: ``` elizabeth@ledyba:~/git/vkd3d64$ make make all-am make[1]: Entering directory '/home/elizabeth/git/vkd3d64' CCLD vkd3d-compiler /usr/bin/ld: warning: libSPIRV-Tools-shared.so, needed by ./.libs/libvkd3d-shader.so, not found (try using -rpath or -rpath-link) /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvContextCreate' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvContextDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvTextDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvDiagnosticDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvBinaryToText' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvValidateBinary' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:1510: vkd3d-compiler] Error 1 make[1]: Leaving directory '/home/elizabeth/git/vkd3d64' make: *** [Makefile:1157: all] Error 2 ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/52#note_37198

1 0

Re: [PATCH v2 0/1] MR52: configure: Allow linking against static SPIRV-Tools.
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

> > Shared SPIRV-Tools is not shipped by Debian Bullseye, and is broken if built manually. > > Is that a regression? I'm using a build of shared SPIRV-Tools I made myself, and it seems to work fine, although it's an older (v2019.5) version. Okay, I think I remember / have reproduced the problem I was encountering. If I build spirv-tools with a prefix that doesn't put it in $PATH, and then try to build vkd3d, I get this: elizabeth@ledyba:~/git/vkd3d64$ make make all-am make[1]: Entering directory '/home/elizabeth/git/vkd3d64' CCLD vkd3d-compiler /usr/bin/ld: warning: libSPIRV-Tools-shared.so, needed by ./.libs/libvkd3d-shader.so, not found (try using -rpath or -rpath-link) /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvContextCreate' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvContextDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvTextDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvDiagnosticDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvBinaryToText' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvValidateBinary' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:1510: vkd3d-compiler] Error 1 make[1]: Leaving directory '/home/elizabeth/git/vkd3d64' make: *** [Makefile:1157: all] Error 2 I don't really understand linking enough to know whose fault this is, although I suspect it's the fault of spirv-tools, which is generally just a mess. Either way I don't think this patch is the right thing to do, so I'm going to close this. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/52#note_37197

1 0

Re: [PATCH v3 0/1] MR217: include: Use WIN32_LEAN_AND_MEAN to exlude non-required headers - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/217

1 0

Re: [PATCH v7 0/1] MR125: vkd3d: Print the thread id in trace messages. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/125

1 0

Re: [PATCH v18 0/5] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44

1 0

Re: [PATCH v3 0/1] MR248: tests: Move HLSL tests to a subdirectory. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/248

1 0

Re: [PATCH v3 0/1] MR233: vkd3d-shader: Unify static string arrays initialization pattern. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/233

1 0

Re: [PATCH v6 0/5] MR230: hlsl: Replace bare list pointers with hlsl_block, part 1. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/230

1 0

[PATCH v2 0/1] MR3188: winevulkan: Keep deferred operation function params alive.
by Georg Lehmann (＠DadSchoorse) 28 Jun '23

28 Jun '23

The Vulkan spec says: Parameters to the command requesting a deferred operation may be accessed by the implementation at any time until the deferred operation enters the complete state Pointer parameters must not be modified (e.g. reallocated/freed). This fixes a regression in Doom Eternal with ray tracing enabled with drivers that actually support deferred operations (e.g. nvidia, amdvlk). -- v2: winevulkan: Keep deferred operation function params alive. https://gitlab.winehq.org/wine/wine/-/merge_requests/3188

2 1

[PATCH 0/1] MR3188: winevulkan: Keep deferred operation function params alive.
by Georg Lehmann (＠DadSchoorse) 28 Jun '23

28 Jun '23

The Vulkan spec says: Parameters to the command requesting a deferred operation may be accessed by the implementation at any time until the deferred operation enters the complete state Pointer parameters must not be modified (e.g. reallocated/freed). This fixes a regression in Doom Eternal with ray tracing enabled with drivers that actually support deferred operations (e.g. nvidia, amdvlk). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3188

2 1

[PATCH 0/1] MR3143: windowscodecs: Fake success in SetMetadataByName
by Fabian Maurer (＠DarkShadow44) 28 Jun '23

28 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55101 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3143

3 2

[PATCH v7 0/1] MR2710: ntdll: Implement efficiency class reporting for intel hybrid CPUs.
by Torge Matthies (＠tmatthies) 28 Jun '23

28 Jun '23

Signed-off-by: Torge Matthies <tmatthies(a)codeweavers.com> -- v7: ntdll: Implement efficiency class reporting for intel hybrid CPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2710

2 2

[PATCH 0/1] MR3187: winemac.drv: Give Apple GPUs device IDs
by Evan Tang (＠etang-cw) 28 Jun '23

28 Jun '23

There are [registry keys we don't set if a device doesn't have a device ID](https://gitlab.winehq.org/wine/wine/-/blob/98b73b5c32fa82218081f0e7668f…. Diablo IV refuses to start if you don't have them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3187

2 1

[PATCH v2 0/1] MR3014: winegstreamer: Fix double free on error path in media_source_constructor (scan-build).
by Alex Henrie (＠alexhenrie) 28 Jun '23

28 Jun '23

-- v2: winegstreamer: Fix double free on error path in media_source_constructor (scan-build). https://gitlab.winehq.org/wine/wine/-/merge_requests/3014

3 2

[PATCH v3 0/3] MR245: vkd3d-shader/hlsl: Add support for 'break' and 'continue' jumps in loops.
by Nikolay Sivov (＠nsivov) 28 Jun '23

28 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader/tpf: Write 'continue' instruction. vkd3d-shader/hlsl: Parse 'continue' statement. vkd3d-shader/hlsl: Allow 'break' instructions in loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/245

4 5

[PATCH v30 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 28 Jun '23

28 Jun '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v30: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

4 12

[PATCH 0/4] MR250: vkd3d-shader/hlsl: Declare vars individually when parsing declarations.
by Francisco Casas (＠fcasas) 28 Jun '23

28 Jun '23

In a declaration with multiple variables, the variables must be created before the initializer of the next variable is parsed. This is required for initializers such as: ``` float a = 1, b = a, c = b + 1; ``` The solution is to parse the type information in the same rule as the first variable ('a' in this case) so that it can be declared before the parser reaches the initializer for the following variables. To initialize the following variables, the type information is passed along from the first variable's struct parse_variable_def to the next and so on. --- Solves https://bugs.winehq.org/show_bug.cgi?id=54484, pointed out by @nsivov. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/250

3 8

[PATCH v2 0/1] MR3185: bcrypt: Add RC4 algorithm stub.
by Hans Leidekker (＠hans) 28 Jun '23

28 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55160 -- v2: bcrypt: Add RC4 algorithm stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/3185

2 1

[PATCH 0/1] MR3185: bcrypt: Add RC4 algorithm stub.
by Hans Leidekker (＠hans) 28 Jun '23

28 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55160 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3185

3 7

[PATCH 0/2] MR255: vkd3d-shader: Scan for the maximum temporary register in d3dbc and emit a spirv temp array accordingly.
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/255

4 7

[PATCH v2 0/1] MR217: include: Use WIN32_LEAN_AND_MEAN to exlude non-required headers
by Alistair Leslie-Hughes (＠alesliehughes) 28 Jun '23

28 Jun '23

Reference https://bugs.winehq.org/show_bug.cgi?id=54985 From the line we see the mingw version used causes an In file included from /usr/share/mingw-w64/include/unknwnbase.h:47, [ 935s] from /usr/share/mingw-w64/include/objidlbase.h:439, [ 935s] from include/combaseapi.h:29, [ 935s] from include/objbase.h:267, [ 935s] from include/ole2.h:25, [ 935s] from /usr/share/mingw-w64/include/wtypes.h:13, [ 935s] from include/winscard.h:22, [ 935s] from include/windows.h:68, [ 935s] from libs/vkd3d/include/private/vkd3d_common.h:23, [ 935s] from libs/vkd3d/libs/vkd3d-shader/vkd3d_shader_private.h:49, [ 935s] from libs/vkd3d/libs/vkd3d-shader/preproc.y:24, [ 935s] from libs/vkd3d/libs/vkd3d-shader/preproc.l:23: [ 935s] /usr/share/mingw-w64/include/wtypesbase.h:148:16: error: redefinition of 'struct _SECURITY_ATTRIBUTES' [ 935s] 148 | typedef struct _SECURITY_ATTRIBUTES { The included file winscard.h seemed a little odd. The vkd3d isn't going to use this. Adding the define WIN32_LEAN_AND_MEAN to the Makefile.in (in wine), produce the following warnings. /home/alesliehughes/wine/libs/vkd3d/include/private/vkd3d_common.h:75:5: warning: implicit declaration of function ‘abort’ [-Wimplicit-function-declaration] 75 | abort(); | ^~~~~ /home/alesliehughes/wine/libs/vkd3d/include/private/vkd3d_common.h:258:14: warning: implicit declaration of function ‘atoi’ [-Wimplicit-function-declaration] 258 | *major = atoi(version); Adding header <stdlib.h> removed all the warnings. -- v2: include: Avoid including unnecessary Windows headers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/217

3 6

[PATCH v6 0/1] MR125: vkd3d: Print the thread id in trace messages.
by Conor McCarthy (＠cmccarthy) 28 Jun '23

28 Jun '23

-- v6: vkd3d: Print the thread id in trace messages. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/125

3 2

Re: [PATCH v17 0/5] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks. - approved
by Henri Verbeet (＠hverbeet) 28 Jun '23

28 Jun '23

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44

1 0

[PATCH 0/3] MR251: vkd3d: Fix a few resource leaks here and there
by Giovanni Mascellani (＠giomasce) 28 Jun '23

28 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/251

4 5

[PATCH v2 0/1] MR248: tests: Move HLSL tests to a subdirectory.
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

This probably can be seen as pointless moving, but I at least appreciate the structure. Besides structure, part of my motivation here is that I will soon want to introduce tests for d3d assembly. I'd also like to stop once and for all the inconsistency between whether tests have "hlsl" prefixed or not. -- v2: tests: Move HLSL tests to a subdirectory. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/248

3 3

[PATCH v2 0/1] MR233: vkd3d-shader: Unify static string arrays initialization pattern.
by Nikolay Sivov (＠nsivov) 28 Jun '23

28 Jun '23

-- v2: vkd3d-shader: Unify static string arrays initialization pattern. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/233

3 2

[PATCH v5 0/5] MR230: hlsl: Replace bare list pointers with hlsl_block, part 1.
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

This introduces temporary helpers block_to_list and list_to_block. The job of block_to_list(), at least, could be done by simply writing "&block->instrs" everywhere instead. Using the helper instead ensures that all of these instances will eventually be converted. -- v5: vkd3d-shader/hlsl: Store the fields of struct parse_if_body as hlsl_block pointers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/230

3 7

[PATCH v5 0/1] MR125: vkd3d: Print the thread id in trace messages.
by Conor McCarthy (＠cmccarthy) 28 Jun '23

28 Jun '23

-- v5: vkd3d: Print the thread id in trace messages. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/125

4 3

[PATCH 0/1] MR3184: win32u: Don't affect nonclient area unles requested.
by Arek Hiler (＠ivyl) 28 Jun '23

28 Jun '23

Overwatch 2 calls `FlashWindowEx()` with `dwFlags = FLASHW_TRAY | FLASHW_TIMERNOFG` whenever you join an online game or respawn after getting killed. Without this MR the call causes us to send `WM_NCACTIVATE` with `wparam = FALSE`. This confuses the game and it stops reading controller input until you Alt+Tab out and back in to "reactivate" the nonclient area. `WM_NCACTIVATE` should be only sent when there's `FLASHW_CAPTION` or `FLASHW_STOP` specified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3184

3 2

Re: [PATCH v2 0/1] MR3172: vkd3d: Import upstream release 1.8
by Nikolay Sivov (＠nsivov) 28 Jun '23

28 Jun '23

Sampler issue is about using t.Sample(s, ...) notation on pre-SM4 profiles. It has to use texture objects for samplers declarations, generic sampler object could be reused. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3172#note_37120

1 0

[PATCH v16 0/5] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks.
by Conor McCarthy (＠cmccarthy) 28 Jun '23

28 Jun '23

Block records are not processed; only the bitcode is validated. -- v16: vkd3d-shader/dxil: Read and validate global abbreviated operands. vkd3d-shader/dxil: Read and validate local abbreviated operands. vkd3d-compiler: Introduce a dxbc-dxil source type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44

3 6

[PATCH 0/2] MR3183: winscard: Implement SCARD_AUTOALLOCATE for multi-string return values.
by Hans Leidekker (＠hans) 28 Jun '23

28 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55137 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3183

2 2

Re: [PATCH v2 0/1] MR3172: vkd3d: Import upstream release 1.8
by Nikolay Sivov (＠nsivov) 28 Jun '23

28 Jun '23

There are two issues with hlsl_d3d9 tests. One in test_samplers() is about sampler dimension not being updated from "generic", and another one in test_fail() that works with vkd3d now but shouldn't. For the second one I submitted https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/256. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3172#note_37109

1 0

[PATCH 0/1] MR3182: include: Fix spelling error when define InterlockedDecrementSizeT().
by xin xu (＠xuxin12345) 28 Jun '23

28 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3182

3 2

[PATCH 0/1] MR3181: include: fix spelling error when define InterlockedDecrementSizeT()
by xin xu (＠xuxin12345) 28 Jun '23

28 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3181

2 2

[PATCH v29 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 28 Jun '23

28 Jun '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v29: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

4 12

[PATCH 0/7] MR3180: Hidden macro removal
by Alistair Leslie-Hughes (＠alesliehughes) 28 Jun '23

28 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3180

2 7

[PATCH 0/5] MR3179: winegstreamer: More media source creation cleanup.
by Rémi Bernon (＠rbernon) 28 Jun '23

28 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3179

2 5

[PATCH 0/5] MR3177: wine{alsa,coreaudio,oss,pulse}: Match GetAudioEndpoint implementations.
by Davide Beatrici (＠davidebeatrici) 28 Jun '23

28 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3177

4 15

[PATCH 0/3] MR3178: explorer: Set virtual desktop primary adapter display settings.
by Rémi Bernon (＠rbernon) 28 Jun '23

28 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55146 When virtual desktop mode is used, the current host display mode is still written to the registry, before the desktop is created and virtual desktop mode decided. When it matches the virtual screen size it also triggers the virtual desktop fullscreen detection and the window is resized to cover the entire screen. Instead, when virtual desktop is used, update the current display mode to match the desktop window size. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3178

2 3

Re: [PATCH v3 0/2] MR3170: twinapi.appcore: Add RegisterAppConstrainedChangeNotification() stub. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3170

1 0

Re: [PATCH v6 0/1] MR3111: opengl32: Implement filtering on all the ChoosePixelFormat() flags that are ignored when unset - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111

1 0

Re: [PATCH v4 0/2] MR3053: opengl32: Do not expose ARB_buffer_storage on wow64. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3053

1 0

Re: [PATCH v2 0/1] MR3173: winegcc: Disable exporting all symbols on mingw targets. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3173

1 0

Re: [PATCH v2 0/1] MR3174: ieframe: Don't use DECLSPEC_HIDDEN. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3174

1 0

Re: [PATCH v2 0/3] MR3175: Direct Play Remove hidden macro - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3175

1 0

Re: [PATCH v2 0/3] MR3176: mfmediaengine/tests: Notification handling cleanup. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3176

1 0

Re: [PATCH v2 0/1] MR3033: d3d11/tests: Use more aligned offsets in test_clear_buffer_unordered_access_view(). - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3033

1 0

Re: [PATCH v2 0/1] MR3150: win32u: Detect a missed WM_LBUTTONUP in the size/move loop. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3150

1 0

Re: [PATCH v2 0/3] MR3156: Misc: Remove superfluous casts to self - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3156

1 0

Re: [PATCH v4 0/6] MR3100: winegstreamer: More media source cleanup. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3100

1 0

Re: [PATCH v4 0/9] MR3122: Implement FileDispositionInformationEx - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3122

1 0

Re: [PATCH v2 0/2] MR3068: d3d1*/tests: Read back directly from the mipmap texture in test_generate_mips(). - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3068

1 0

Re: [PATCH v3 0/2] MR3169: Revert "crypt32: Do not create persistent container in CRYPT_CreateKeyProv()." - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3169

1 0

Re: [PATCH v4 0/1] MR3016: dbghelp: Allocate real_path with the CRT and copy it to the module heap. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3016

1 0

Re: [PATCH v7 0/10] MR2855: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Release, AddRef, QueryInterface into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2855

1 0

Re: [PATCH v5 0/1] MR2837: wined3d: rename shader_extract_from_dxbc to wined3d_shader_extract_from_dxbc - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2837

1 0

2025

2024

2023

2022

wine-gitlab