- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR249: tests: Add another test for register reservation. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/249

1 0

Re: [PATCH v3 0/1] MR247: tests: Cast abs() result to unsigned int in compare_float(). - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/247

1 0

Re: [PATCH v3 0/7] MR232: vkd3d-shader/hlsl: Fold a few missing constant operations. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/232

1 0

Re: [PATCH v2 0/1] MR246: vkd3d-shader: Remove extra newlines from compiler messages. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/246

1 0

Re: [PATCH v3 0/1] MR242: configure: Pass the correct number of parameters for the __atomic_exchange_n() check. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/242

1 0

Re: [PATCH v2 0/2] MR237: vkd3d-shader/hlsl: Make sample count optional for SM4.1+. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/237

1 0

Re: [PATCH v6 0/8] MR216: vkd3d: Prepare for tiled resource support. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/216

1 0

Re: [PATCH v10 0/4] MR211: vkd3d-shader/hlsl: Support clip() intrinsic. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211

1 0

Re: [PATCH v6 0/3] MR200: vkd3d-shader: Signature reflection API. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/200

1 0

Re: [PATCH v5 0/1] MR171: Initialize a pointer for MSVC. - approved
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/171

1 0

[PATCH v11 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 27 Jun '23

27 Jun '23

The test has a little inspiration from the SDK samples. -- v11: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

3 3

[PATCH v10 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 27 Jun '23

27 Jun '23

The test has a little inspiration from the SDK samples. -- v10: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

3 5

[PATCH v9 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 27 Jun '23

27 Jun '23

The test has a little inspiration from the SDK samples. -- v9: mfmediaengine: Add support for inserting video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

3 13

[PATCH v5 0/10] MR2993: Draft: comdlg32: IFileDialog navigation bar control. Part 1.
by Vladislav Timonin (＠vt) 27 Jun '23

27 Jun '23

Redo of !1857, as suggested, the plan is to split original MR in half, breadcrumbs in first (this) MR, and address edit in another. The changes are mostly cleanup (formatting, renaming, unused variables, missing free). Visually, it hasn't changed from original MR, part 1 changes are: ![](/uploads/42fa717ce6f7adb40d6b0dcbbe0878fa/changes-1-3.png) And part 2: ![](/uploads/cbdaa2d4b5b8945587e1f761a4609a08/changes-2.png) Part 2 branch can be found [here](https://gitlab.winehq.org/vt/wine/-/commits/fd-navbar-part2). Requires !2068, otherwise if application doesn't request comctl v6 (e.g. qapitrace), navigation bar will look like this: ![no-comctl-v6](/uploads/03e6a8b6dcf827114157e79640e49fea/no-comctl-v6.png) Closes: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=54812 - https://bugs.winehq.org/show_bug.cgi?id=50338 (partially? fully with address edit?) MR changes: - v2 - Changed the gap between buttons to be scaled with DPI - v3 - DPI scale the gap in layout calculation in breadcrumbs commit missed it earlier - remove padding from layout calculation `GetWindowRect` was unintentionally returning double padding, 4px from `hspacing` in `itemdlg.c:update_layout`, and another 4px from somewhere else - drop `comdlg32: Keep IExplorerBrowser in IFileDialog focused after Backspace.` hack - retain IExplorerBrowser view focus in IFileDialog when creating new view - redirect navigation bar buttons focus back to the previous window - v4 - rename background to frame - calculate overflow button width into separate variable, [will come in handy in part 2](https://gitlab.winehq.org/vt/wine/-/commit/998b6987500edda02d6a9177c7da2… - simplify show-at-least-N-crumbs logic - drop `comdlg32: Prevent arrow navigation of IFileDialog navigation bar buttons.` - drop `comdlg32: Don't paint focus rect in IFileDialog navigation bar buttons.` - add tab navigation - avoid taking button focus by sending `VK_SPACE` instead Description edits: - v2 - Updated the changes image (by splitting it) - Added MR changes - v3 - Added description edits - Updated the changes image again (forgot the overflow button change) -- v5: comdlg32: Avoid taking focus on LMB click in IFileDialog navigation bar buttons. comdlg32: Add tab navigation to IFileDialog navigation bar. comdlg32: Retain IExplorerBrowser view focus in IFileDialog when creating new view. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add inner border to breadcrumbs in IFileDialog navigation bar. comdlg32: Always show at least 2 crumbs in IFileDialog navigation bar. comdlg32: Reuse address breadcrumbs in IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar control. https://gitlab.winehq.org/wine/wine/-/merge_requests/2993

2 11

[PATCH 0/1] MR252: vkd3d-shader/hlsl: Add constant folding for 'rcp'.
by Nikolay Sivov (＠nsivov) 27 Jun '23

27 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/252

2 1

[PATCH 0/1] MR227: vkd3d-shader/hlsl: Initialize some unused constant values to a sentinel.
by Zebediah Figura (＠zfigura) 27 Jun '23

27 Jun '23

I feel lukewarm about this, but it did help me find 974528cbe and 7b476573f. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/227

4 8

[PATCH v2 0/15] MR3157: include: Introduce wine_dbgstr_h and debugstr_h.
by Alex Henrie (＠alexhenrie) 27 Jun '23

27 Jun '23

These replace Wine's 14 copies of debugstr_hstring. -- v2: wintypes: Replace debugstr_hstring with wine_dbgstr_h. windows.ui: Replace debugstr_hstring with wine_dbgstr_h. windows.system.profile.systemmanufacturers: Replace debugstr_hstring with wine_dbgstr_h. windows.perception.stub: Replace debugstr_hstring with wine_dbgstr_h. windows.networking: Replace debugstr_hstring with wine_dbgstr_h. windows.media.speech/tests: Replace debugstr_hstring with debugstr_h. windows.media.devices: Replace debugstr_hstring with wine_dbgstr_h. https://gitlab.winehq.org/wine/wine/-/merge_requests/3157

5 23

[PATCH 0/1] MR3033: d3d11/tests: Use more aligned offsets in test_clear_buffer_unordered_access_view().
by Zebediah Figura (＠zfigura) 27 Jun '23

27 Jun '23

Creating a view with an unaligned offset is legal in d3d and apparently works, both on Windows and Linux, but may violate the Vulkan specification: VUID-VkBufferViewCreateInfo-offset-00926(ERROR / SPEC): msgNum: -833749292 - Validation Error: [ VUID-VkBufferViewCreateInfo-offset-00926 ] Object 0: handle = 0x3c000000003c, type = VK_OBJECT_TYPE_BUFFER; | MessageID = 0xce4dfed4 | vkCreateBufferView(): VkBufferViewCreateInfo offset (36) must be a multiple of VkPhysicalDeviceLimits::minTexelBufferOffsetAlignment (16). The Vulkan spec states: offset must be a multiple of VkPhysicalDeviceLimits::minTexelBufferOffsetAlignment (https://www.khronos.org/registry/vulkan/specs/1.2-khr-extensions/html/vkspe…) Without any reason to test unaligned buffer views here, just resolve this by changing the test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3033

5 5

[PATCH 0/3] MR3176: mfmediaengine/tests: Notification handling cleanup.
by Nikolay Sivov (＠nsivov) 27 Jun '23

27 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3176

2 3

[PATCH 0/1] MR249: tests: Add another test for register reservation.
by Nikolay Sivov (＠nsivov) 27 Jun '23

27 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/249

6 5

[PATCH v2 0/1] MR247: tests: Cast abs() result to unsigned int in compare_float().
by Zebediah Figura (＠zfigura) 27 Jun '23

27 Jun '23

-- v2: tests: Use compare_uint() in compare_float(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/247

4 4

[PATCH v2 0/7] MR232: vkd3d-shader/hlsl: Fold a few missing constant operations.
by Giovanni Mascellani (＠giomasce) 27 Jun '23

27 Jun '23

Mostly a rage reaction to being fed up by warnings in logs. -- v2: vkd3d-shader/hlsl: Fold logical expressions. vkd3d-shader/hlsl: Fold floating point minimum expressions. vkd3d-shader/hlsl: Fold floating point maximum expressions. vkd3d-shader/hlsl: Fold greater-than-or-equal comparisons. vkd3d-shader/hlsl: Fold less-than comparisons. vkd3d-shader/hlsl: Fold equality comparisons. vkd3d-shader/hlsl: Sort constant folding helpers alphabetically. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/232

4 11

[PATCH 0/3] MR3164: gdi32: Don't use DECLSPEC_HIDDEN.
by Jacek Caban (＠jacek) 27 Jun '23

27 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3164

5 6

[PATCH 0/3] MR3175: Direct Play Remove hidden macro
by Alistair Leslie-Hughes (＠alesliehughes) 27 Jun '23

27 Jun '23

Remove the DECLSPEC_HIDDEN from Direct Play DLL's. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3175

2 3

[PATCH 0/1] MR3174: ieframe: Don't use DECLSPEC_HIDDEN.
by Jacek Caban (＠jacek) 27 Jun '23

27 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3174

2 1

[PATCH 0/1] MR3173: winegcc: Disable exporting all symbols on mingw targets.
by Jacek Caban (＠jacek) 27 Jun '23

27 Jun '23

Mingw targets export all symbols by default if there is no explicit export. We generate export table in winebuild and don't use explicit exports. This may make linker generate an unused export-all table. Spotted by Gabriel Ivăncescu in !3109. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3173

2 1

[PATCH 0/2] MR3172: vkd3d: Import upstream release 1.8
by Alexandre Julliard (＠julliard) 27 Jun '23

27 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3172

4 3

[PATCH 0/2] MR3068: d3d1*/tests: Read back directly from the mipmap texture in test_generate_mips().
by Zebediah Figura (＠zfigura) 27 Jun '23

27 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3068

3 3

Re: [PATCH v4 0/1] MR2837: wined3d: rename shader_extract_from_dxbc to wined3d_shader_extract_from_dxbc - approved
by Jan Sikorski (＠jsikorski) 27 Jun '23

27 Jun '23

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2837

1 0

[PATCH v2 0/2] MR3169: Revert "crypt32: Do not create persistent container in CRYPT_CreateKeyProv()."
by Paul Gofman (＠gofman) 27 Jun '23

27 Jun '23

This reverts commit a19c8712917042361208b8a4a0a503e06815d20a. It turns out commit a19c8712917042361208b8a4a0a503e06815d20a is wrong and causing regressions. Crypt provider info is actually stored in certificate and that is the only place where, e. g., secur32 can get private key from. It turns out that Street Fightet 6 which is creating a great amount of temporary certificates and growing cert storage does the same on Windows, with the only difference that on Windows those certificates are stored on disk and not in registry. -- v2: crypt32/tests: Test CertCreateSelfSignCertificate() without provider info. https://gitlab.winehq.org/wine/wine/-/merge_requests/3169

3 4

[PATCH 0/3] MR3159: winex11: Use CRT allocations and wide strings in systray.c.
by Rémi Bernon (＠rbernon) 27 Jun '23

27 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3159

2 5

[PATCH v2 0/4] MR3171: explorer: Use individual windows for systray icons.
by Rémi Bernon (＠rbernon) 27 Jun '23

27 Jun '23

The point here is to make the default implementation close to winex11, supporting a standalone systray window, and then refactor the interface to remove the duplicated code from the user drivers. -- v2: explorer: Display the individual systray icon windows. explorer: Create individual windows for the systray icons. explorer: Split systray add/remove from show/hide_icon. explorer: Remove unnecessary displayed icon array. https://gitlab.winehq.org/wine/wine/-/merge_requests/3171

2 5

[PATCH v3 0/1] MR3016: dbghelp: Allocate real_path with the CRT and copy it to the module heap.
by Alex Henrie (＠alexhenrie) 27 Jun '23

27 Jun '23

Fixes both a memory leak and an alloc/free mismatch, and the module heap is the most appropriate place to hold the variable long-term. -- v3: dbghelp: Allocate real_path with the CRT and copy it to the module heap. https://gitlab.winehq.org/wine/wine/-/merge_requests/3016

3 3

[PATCH 0/5] MR3171: explorer: Use individual windows for systray icons.
by Rémi Bernon (＠rbernon) 27 Jun '23

27 Jun '23

The point here is to make the default implementation close to winex11, supporting a standalone systray window, and then refactor the interface to remove the duplicated code from the user drivers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3171

3 6

[PATCH v6 0/10] MR2855: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Release, AddRef, QueryInterface into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 27 Jun '23

27 Jun '23

-- v6: wineoss: Use mmdevapi's AudioClient's QueryInterface. winecoreaudio: Use mmdevapi's AudioClient's QueryInterface. winealsa: Use mmdevapi's AudioClient's QueryInterface. winepulse: Move AudioClient's QueryInterface into mmdevapi. wineoss: Use mmdevapi's AudioClient's Release, AddRef. winecoreaudio: Use mmdevapi's AudioClient's Release, AddRef. winealsa: Use mmdevapi's AudioClient's Release, AddRef. winepulse: Move AudioClient's Release, AddRef into mmdevapi. winepulse: Refactor AudioClient's Release to match other drivers. winecoreaudio: Refactor AudioClient's Release to match other drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/2855

4 12

[PATCH v2 0/2] MR3170: twinapi.appcore: Add RegisterAppConstrainedChangeNotification() stub.
by Mohamad Al-Jaf (＠maljaf) 27 Jun '23

27 Jun '23

Needed for Age of Wonders 4. I came across a post saying this game crashes: https://www.reddit.com/r/Lutris/comments/136f9s2/age_of_wonders_4_unexpecte… ``` wine: Call from 0000000174013E8E to unimplemented function twinapi.appcore.RegisterAppConstrainedChangeNotification, aborting wine: Unimplemented function twinapi.appcore.RegisterAppConstrainedChangeNotification called at address 0000000174013E8E (thread 0114), starting debugger... ``` The Proton version works fine so this seems to be either the GOG version or the other non-steam ones. -- v2: twinapi.appcore: Add UnregisterAppConstrainedChangeNotification() stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/3170

3 4

[PATCH v4 0/1] MR125: vkd3d: Print the thread id in trace messages.
by Conor McCarthy (＠cmccarthy) 27 Jun '23

27 Jun '23

-- v4: vkd3d: Print the thread id in trace messages. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/125

2 1

[PATCH 0/2] MR3170: twinapi.appcore: Add RegisterAppConstrainedChangeNotification() stub.
by Mohamad Al-Jaf (＠maljaf) 27 Jun '23

27 Jun '23

Needed for Age of Wonders 4. I came across a post saying this game crashes: https://www.reddit.com/r/Lutris/comments/136f9s2/age_of_wonders_4_unexpecte… ``` wine: Call from 0000000174013E8E to unimplemented function twinapi.appcore.RegisterAppConstrainedChangeNotification, aborting wine: Unimplemented function twinapi.appcore.RegisterAppConstrainedChangeNotification called at address 0000000174013E8E (thread 0114), starting debugger... ``` The Proton version works fine so this seems to be either the GOG version or the other non-steam ones. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3170

3 3

[PATCH 0/1] MR248: tests: Move HLSL tests to a subdirectory.
by Zebediah Figura (＠zfigura) 27 Jun '23

27 Jun '23

This probably can be seen as pointless moving, but I at least appreciate the structure. Besides structure, part of my motivation here is that I will soon want to introduce tests for d3d assembly. I'd also like to stop once and for all the inconsistency between whether tests have "hlsl" prefixed or not. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/248

4 6

[PATCH 0/15] MR3157: include: Introduce wine_dbgstr_h and debugstr_h.
by Alex Henrie (＠alexhenrie) 27 Jun '23

27 Jun '23

These replace Wine's 14 copies of debugstr_hstring. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3157

3 17

[PATCH v4 0/2] MR3161: Dsdmo effects
by Alistair Leslie-Hughes (＠alesliehughes) 26 Jun '23

26 Jun '23

Reference that attempt to create these. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33326 -- v4: dsdmo: Add Flanger effect stub dsdmo: Add Chorus effect stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3161

2 2

[PATCH 0/1] MR3169: Revert "crypt32: Do not create persistent container in CRYPT_CreateKeyProv()."
by Paul Gofman (＠gofman) 26 Jun '23

26 Jun '23

This reverts commit a19c8712917042361208b8a4a0a503e06815d20a. It turns out commit a19c8712917042361208b8a4a0a503e06815d20a is wrong and causing regressions. Crypt provider info is actually stored in certificate and that is the only place where, e. g., secur32 can get private key from. It turns out that Street Fightet 6 which is creating a great amount of temporary certificates and growing cert storage does the same on Windows, with the only difference that on Windows those certificates are stored on disk and not in registry. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3169

3 3

[PATCH v3 0/2] MR3161: Dsdmo effects
by Alistair Leslie-Hughes (＠alesliehughes) 26 Jun '23

26 Jun '23

Reference that attempt to create these. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33326 -- v3: dsdmo: Add Flanger effect stub dsdmo: Add Chord effect stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3161

3 3

Re: [PATCH v2 0/1] MR3166: dbghelp/tests: Don't call directly SymSetExtendedOption(). - approved
by Alexandre Julliard (＠julliard) 26 Jun '23

26 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3166

1 0

Re: [PATCH v2 0/3] MR3164: gdi32: Don't use DECLSPEC_HIDDEN. - approved
by Alexandre Julliard (＠julliard) 26 Jun '23

26 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3164

1 0

Re: [PATCH v2 0/2] MR3146: Implement dbghelp.SymSrvGetFileIndexInfo for PDB files (DS format). - approved
by Alexandre Julliard (＠julliard) 26 Jun '23

26 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3146

1 0

Re: [PATCH v2 0/1] MR3147: winemac.drv: Don't expect an internal driver message to set last error. - approved
by Alexandre Julliard (＠julliard) 26 Jun '23

26 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3147

1 0

Re: [PATCH v2 0/3] MR3158: explorer: Use CRT allocations, wide strings and non-prefixed trace macros. - approved
by Alexandre Julliard (＠julliard) 26 Jun '23

26 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3158

1 0

Re: [PATCH v3 0/1] MR3154: cmd: Fix 'if exist' with a directory/ as a parameter. - approved
by Alexandre Julliard (＠julliard) 26 Jun '23

26 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3154

1 0

Re: [PATCH v2 0/1] MR3145: ntdll: Inherit ConsoleHandle only by CUI processes. - approved
by Alexandre Julliard (＠julliard) 26 Jun '23

26 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3145

1 0

Re: [PATCH v3 0/7] MR3152: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 26 Jun '23

26 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3152

1 0

Re: [PATCH v2 0/1] MR3140: mfplat: Use QueryPerformanceCounter in MFGetSystemTime. - approved
by Alexandre Julliard (＠julliard) 26 Jun '23

26 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3140

1 0

Re: [PATCH v2 0/1] MR3148: widl: Don't crash on nameless structs - approved
by Alexandre Julliard (＠julliard) 26 Jun '23

26 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3148

1 0

[PATCH v3 0/2] MR3053: opengl32: Do not expose ARB_buffer_storage on wow64.
by Zebediah Figura (＠zfigura) 26 Jun '23

26 Jun '23

We don't properly support persistent mapping, so don't pretend to support ARB_buffer_storage. -- v3: opengl32: Do not report a GL version higher than 4.3 on wow64. https://gitlab.winehq.org/wine/wine/-/merge_requests/3053

4 8

[PATCH v5 0/1] MR3111: opengl32: Implement filtering on all the ChoosePixelFormat() flags that are ignored when unset
by Damjan Jovanovic (＠dj) 26 Jun '23

26 Jun '23

When any of these flags: - PFD_DRAW_TO_WINDOW - PFD_DRAW_TO_BITMAP - PFD_SUPPORT_GDI - PFD_SUPPORT_OPENGL are set on the PIXELFORMATDESCRIPTOR parameter to ChoosePixelFormat(), the returned pixel format must also have them set, but when they are unset, the returned pixel format may or may not have them set. Also add support for filtering on all these flags. In particular, the lack of filtering on PFD_SUPPORT_GDI, was causing (at least) Java 1.3 to fail to initialize graphics, because we were returning a pixel format without the PFD_SUPPORT_GDI flag it asked for. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=7767 -- v5: opengl32: Implement filtering on all the ChoosePixelFormat() flags that are ignored when unset https://gitlab.winehq.org/wine/wine/-/merge_requests/3111

2 1

[PATCH v4 0/1] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Damjan Jovanovic (＠dj) 26 Jun '23

26 Jun '23

Java (1.3 at least) calls ChoosePixelFormat() with the PFD_SUPPORT_GDI flag set and expects the returned PIXELFORMATDESCRIPTOR to have that flag set. If it doesn't, an exception is thrown and it fails to initialize graphics. If no PIXELFORMATDESCRIPTOR is returned instead, it falls back to an alternative rendering method and proceeds further. Therefore, when the PFD_SUPPORT_GDI flag is specified, treat it as a mandatory requirement, and only return a PIXELFORMATDESCRIPTOR on which it is set, if any. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=7767 Closes #7767 -- v4: opengl32: Implement filtering on all the ChoosePixelFormat() flags that are ignored when unset https://gitlab.winehq.org/wine/wine/-/merge_requests/3111

3 3

[PATCH 0/1] MR233: vkd3d-shader: Unify static string arrays initialization pattern.
by Nikolay Sivov (＠nsivov) 26 Jun '23

26 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/233

4 5

[PATCH 0/1] MR246: vkd3d-shader: Remove extra newlines from compiler messages.
by Nikolay Sivov (＠nsivov) 26 Jun '23

26 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/246

5 4

[PATCH v2 0/1] MR242: configure: Include an atomic ordering parameter when checking __atomic_exchange_n() support.
by Conor McCarthy (＠cmccarthy) 26 Jun '23

26 Jun '23

-- v2: configure: Pass the correct number of parameters for the __atomic_exchange_n() check. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/242

4 4

[PATCH 0/2] MR237: vkd3d-shader/hlsl: Make sample count optional for SM4.1+.
by Nikolay Sivov (＠nsivov) 26 Jun '23

26 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/237

6 6

[PATCH v5 0/8] MR216: vkd3d: Prepare for tiled resource support.
by Conor McCarthy (＠cmccarthy) 26 Jun '23

26 Jun '23

-- v5: vkd3d: Append CopyTileMappings() commands to the command queue op array. vkd3d: Append UpdateTileMappings() commands to the command queue op array. vkd3d: Add missing const attributes to ID3D12CommandQueue::UpdateTileMappings() parameters. vkd3d: Validate plane count for tiled textures. vkd3d: Validate tiled resources tier for 3D textures. vkd3d: Validate tiled resources support during reserved resource creation. vkd3d: Always pass null heap properties to vkd3d_create_image() for sparse images. vkd3d: Check sparse image format is supported. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/216

3 9

[PATCH v9 0/4] MR211: vkd3d-shader/hlsl: Support clip() intrinsic.
by Nikolay Sivov (＠nsivov) 26 Jun '23

26 Jun '23

-- v9: vkd3d-shader/hlsl: Handle 'texkill' discard type for sm4+. vkd3d-shader/hlsl: Parse clip() function. tests: Add some tests for clip(). vkd3d-shader/hlsl: Add a parameter for jump nodes and use it for 'discard'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211

4 7

[PATCH v5 0/3] MR200: vkd3d-shader: Signature reflection API.
by Zebediah Figura (＠zfigura) 26 Jun '23

26 Jun '23

There are two parts to this: - First, a way to retrieve any signature from a DXBC shader. This is, I gather, generally useful for reflection, and it can be used as one source with which to implement d3d10 and d3d11 shader reflection APIs. The rest of those APIs will need much more data to be exposed from d3d shaders, and while I was originally planning to expose that all in a single "vkd3d_shader_d3d_shader_info" structure, I think that signatures at least are a reasonable enough subset to have a dedicated structure. Moreover, I did not want to block sm1 support on too much API design. - Second, signatures synthesized from sm1 byte code. This is conceptually a bit weird, because sm1 does not have signatures, but in terms of how these APIs are used by Wine (or other translation layers, as evidenced not least by the Vulkan test shader runner, which I have locally adapted for sm1 but not submitted yet) it fits rather nicely. Because this is new API, it of course deserves plenty of discussion, especially the sm1 part. Several open questions which occurred to me while writing are: 1. Should we fix the mask (and used mask) for sm1 signatures as 0xf rather than 0? SPIR-V cares about this in order to declare I/O variables, which makes some amount of sense. In fact I have a patch in my local tree to change this, specifically for that purpose. However, we could also normalize it later. 2. If we do fix the mask as nonzero, should single-component semantics (fog, depth, etc...) be declared as 0x1 instead of 0xf? 3. Should BLENDINDICES get a UINT type? It's float in shader instructions (well, kind of, although in practice it's used as an array index of course), but the vertex attribute type is in practice "supposed" to be integer. Part 1 of a series to implement sm1 -> spirv translation in vkd3d-shader, brought to you by late nights spent coding and rereading The Waste Land. Ganga was sunken, and the limp leaves Waited for rain, while the black clouds Gathered far distant, over Himavant. -- v5: vkd3d-shader: Synthesize signatures for d3dbc shaders. vkd3d-shader: Introduce an API to retrieve all signatures from DXBC shaders. vkd3d-shader: Introduce documented semantics for the target type and other data passed to vkd3d_shader_scan(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/200

3 5

[PATCH v4 0/1] MR171: Initialize a pointer for MSVC.
by Stefan Dösinger (＠stefan) 26 Jun '23

26 Jun '23

MSVC is too stupid to see that line 3058 will not run unless n_variants has been set together with variants in the switch statement below. -- v4: vkd3d-shader/hlsl: Make sure variants is initialized in declare_predefined_types(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/171

3 2

[PATCH v15 0/5] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks.
by Conor McCarthy (＠cmccarthy) 26 Jun '23

26 Jun '23

Block records are not processed; only the bitcode is validated. -- v15: vkd3d-shader/dxil: Read and validate global abbreviated operands. vkd3d-shader/dxil: Read and validate local abbreviated operands. vkd3d-compiler: Introduce a dxbc-dxil source type. include: Introduce a function to detect the DXBC source type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44

3 6

[PATCH 0/1] MR3166: dbghelp/tests: Don't call directly SymSetExtendedOption().
by eric pouech (＠epo) 26 Jun '23

26 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55128 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3166

2 1

[PATCH 0/5] MR3162: Chromium sandbox fixes
by Zhiyi Zhang (＠zhiyi) 26 Jun '23

26 Jun '23

This series of patches enable Adobe PDF Reader 11 protected mode, which is essentially a Chromium sandbox, to work properly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3162

4 8

[PATCH v2 0/1] MR111: vkd3d-shader/hlsl: Improve handling of "technique" tokens.
by Nikolay Sivov (＠nsivov) 26 Jun '23

26 Jun '23

This change only implements case-sensitivity of technique keywords and related checks when corresponding profile is used. My immediate plan is to add some synthetic type for technique variables, for example as {object, void}, then add named techniques as variables. This is useful because these names are participating in global scope, and should not collide with normal variables. After that "pass_list" will be split, at least in two variants because of how much d3d9 syntax differs. Some trivial changes will be need later to have some top level fx compilation helper that considers only fx objects and calls ps/vs/gs compiler to create inner shader blobs on same original source. -- v2: vkd3d-shader/hlsl: Improve handling of "technique" tokens. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/111

2 2

[PATCH v2 0/1] MR3163: gdiplus: Remove unused argument in get_font_hfont
by David Kahurani (＠kahurani) 26 Jun '23

26 Jun '23

StringFormat argument to get_font_hfont is unused and looks largely irrelevant to the font. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v2: gdiplus: Remove unused argument in get_font_hfont https://gitlab.winehq.org/wine/wine/-/merge_requests/3163

3 4

[PATCH 0/6] MR3165: dxgi: Do not let the D3D12 swapchain directly access the low level Vulkan queue in vkd3d (first part).
by Giovanni Mascellani (＠giomasce) 26 Jun '23

26 Jun '23

Later patches are on https://gitlab.winehq.org/giomasce/wine/-/commits/chianti, though they still require some cleanup and cosmetic changes. Currently the D3D12 swapchain accesses the low level Vulkan queue backing a vkd3d `ID3D12CommandQueue` using the `vkd3d_acquire_vk_queue()` call in order to submit frames for presentation. This causes a number of bugs because `vkd3d_acquire_vk_queue()` lets the caller submit to the Vulkan queue even if some operations are enqueued in the vkd3d internal op queue, which can lead to a frame being presented even if drawing work on it isn't finished (and not even queued, from the viewpoint of Vulkan!). In order to fix this, I propose to introduce to add a few calls to vkd3d (currently [in this branch](https://gitlab.winehq.org/giomasce/vkd3d/-/commits/mongibello)), to allow the caller to enqueue calls to `vkQueueSubmit()` and `vkQueuePresentKHR()` through the vkd3d internal queue. The D3D12 swapchain would then use this new API instead of directly calling `vkQueueSubmit()` and `vkQueuePresentKHR()` as it does now. Patches in this MR don't implement those changes yet, but prepare the ground with some tests and light refactoring. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165

2 6

[PATCH v3 0/6] MR3100: winegstreamer: More media source cleanup.
by Rémi Bernon (＠rbernon) 26 Jun '23

26 Jun '23

-- v3: winegstreamer: Lookup stream handler result using a dedicated helper. winegstreamer: Rename winegstreamer_stream_handler to stream_handler. winegstreamer: Create and destroy result entries using dedicated helpers. winegstreamer: Lookup stream descriptors before starting streams. winegstreamer: Keep a reference on the media source start descriptor. maintainers: Assume GStreamer media source maintainership. https://gitlab.winehq.org/wine/wine/-/merge_requests/3100

2 6

[PATCH 0/1] MR247: tests: Cast abs() result to unsigned int in compare_float().
by Zebediah Figura (＠zfigura) 26 Jun '23

26 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/247

5 5

[PATCH v2 0/2] MR3161: Dsdmo effects
by Alistair Leslie-Hughes (＠alesliehughes) 26 Jun '23

26 Jun '23

Reference that attempt to create these. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33326 -- v2: dsdmo: Add Flanger effect stub dsdmo: Add Chord effect stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3161

3 3

[PATCH 0/1] MR3107: dhtmled: Don't export dhtml_edit_create or release_typelib.
by Alex Henrie (＠alexhenrie) 26 Jun '23

26 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3107

3 3

[PATCH v3 0/9] MR3122: Implement FileDispositionInformationEx
by Joel Holdsworth (＠jhol) 26 Jun '23

26 Jun '23

This MR supercedes !1895 and !3073 as a solution to bug [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771). Rather than fixing the problem of Wine's inability to modify the attributes of read-only files, this patch set instead implements `FileDispositionInformationEx` which the Msys2 and Cygwin runtime libriries can use to avoid needing to modify attributes. All the flags of `FileDispositionInformationEx` are implemented with the exception of `FILE_DISPOSITION_FORCE_IMAGE_SECTION_CHECK`. This MR improves upon !3073 by implementing `FILE_DISPOSITION_POSIX_SEMANTICS` and `FILE_DISPOSITION_ON_CLOSE` where the previous MR only implemented `FILE_DISPOSITION_DELETE` and `FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE`. -- v3: ntdll: Implement FILE_DISPOSITION_POSIX_SEMANTICS server: Replace unlink member of closed_fd with disp_flags ntdll/tests: Add tests for FILE_DISPOSITION_POSIX_SEMANTICS ntdll: Implement FILE_DISPOSITION_ON_CLOSE ntdll/tests: Add tests for FILE_DISPOSITION_ON_CLOSE ntdll: Implement FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE ntdll/tests: Add tests for FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE ntdll: Initial implementation of FileDispositionInformationEx include: Define FILE_DISPOSITION_INFORMATION_EX and friends https://gitlab.winehq.org/wine/wine/-/merge_requests/3122

2 10

Re: [PATCH v4 0/1] MR2837: wined3d: rename shader_extract_from_dxbc to wined3d_shader_extract_from_dxbc
by Henri Verbeet (＠hverbeet) 26 Jun '23

26 Jun '23

For what it's worth, no objection to this change per se from my side. Is this somehow caused by vkd3d's shader_extract_from_dxbc() no longer being static since 804e315b6? (Also, "vkd3d", no "vk3d3".) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2837#note_36783

1 0

[PATCH 0/1] MR3163: gdiplus: Removed unused argument in get_font_hfont
by David Kahurani (＠kahurani) 26 Jun '23

26 Jun '23

StringFormat argument to get_font_hfont is unused and looks largely irrelevant to the font. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3163

2 1

[PATCH v9 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 26 Jun '23

26 Jun '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v9: comdlg32: Enable visual styles when showing IFileDialog. comdlg32: Return E_UNEXPECTED if IFileDialog is already shown. https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

3 4

[PATCH 0/2] MR3161: Dsdmo effects
by Alistair Leslie-Hughes (＠alesliehughes) 26 Jun '23

26 Jun '23

Reference that attempt to create these. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33326 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3161

3 3

[PATCH v3 0/2] MR240: vkd3d-shader: Add constant folding for the 'dot' operation.
by Nikolay Sivov (＠nsivov) 26 Jun '23

26 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader: Add constant folding for 'dp2add' operation. vkd3d-shader: Add constant folding for the 'dot' operation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/240

3 8

[PATCH 0/1] MR3148: widl: Don't crash on nameless structs
by Fabian Maurer (＠DarkShadow44) 26 Jun '23

26 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49772 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3148

3 2

[PATCH 0/1] MR3149: widl: Don't crash if an interface is missing an uuid
by Fabian Maurer (＠DarkShadow44) 26 Jun '23

26 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55123 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3149

3 2

[PATCH 0/3] MR3158: explorer: Use CRT allocations, wide strings and non-prefixed trace macros.
by Rémi Bernon (＠rbernon) 26 Jun '23

26 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3158

3 4

[PATCH 0/1] MR3155: shell32: Make sure wcmd has enough space to hold the string.
by Jiajin Cui (＠jin-king1) 26 Jun '23

26 Jun '23

If the length of wszApplicationName exceeds 1024, it will cause an error when writing to the subsequent stack space after exceeding the wcmd space, Wcmd needs to be modified to dynamic allocation. Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3155

3 3

[PATCH 0/3] MR3156: Misc: Remove superfluous casts to self
by Michael Stefaniuc (＠mstefani) 26 Jun '23

26 Jun '23

Plus a bonus whitespace fix patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3156

3 4

[PATCH v2 0/1] MR3016: dbghelp: Allocate real_path with the CRT and copy it to the module heap.
by Alex Henrie (＠alexhenrie) 26 Jun '23

26 Jun '23

Fixes both a memory leak and an alloc/free mismatch, and the module heap is the most appropriate place to hold the variable long-term. -- v2: dbghelp: Allocate real_path with the CRT and copy it to the module heap. https://gitlab.winehq.org/wine/wine/-/merge_requests/3016

3 3

[PATCH 0/1] MR242: configure: Include an atomic ordering parameter when checking __atomic_exchange_n() support.
by Conor McCarthy (＠cmccarthy) 25 Jun '23

25 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/242

4 3

[PATCH v4 0/2] MR200: vkd3d-shader: Signature reflection API.
by Zebediah Figura (＠zfigura) 25 Jun '23

25 Jun '23

There are two parts to this: - First, a way to retrieve any signature from a DXBC shader. This is, I gather, generally useful for reflection, and it can be used as one source with which to implement d3d10 and d3d11 shader reflection APIs. The rest of those APIs will need much more data to be exposed from d3d shaders, and while I was originally planning to expose that all in a single "vkd3d_shader_d3d_shader_info" structure, I think that signatures at least are a reasonable enough subset to have a dedicated structure. Moreover, I did not want to block sm1 support on too much API design. - Second, signatures synthesized from sm1 byte code. This is conceptually a bit weird, because sm1 does not have signatures, but in terms of how these APIs are used by Wine (or other translation layers, as evidenced not least by the Vulkan test shader runner, which I have locally adapted for sm1 but not submitted yet) it fits rather nicely. Because this is new API, it of course deserves plenty of discussion, especially the sm1 part. Several open questions which occurred to me while writing are: 1. Should we fix the mask (and used mask) for sm1 signatures as 0xf rather than 0? SPIR-V cares about this in order to declare I/O variables, which makes some amount of sense. In fact I have a patch in my local tree to change this, specifically for that purpose. However, we could also normalize it later. 2. If we do fix the mask as nonzero, should single-component semantics (fog, depth, etc...) be declared as 0x1 instead of 0xf? 3. Should BLENDINDICES get a UINT type? It's float in shader instructions (well, kind of, although in practice it's used as an array index of course), but the vertex attribute type is in practice "supposed" to be integer. Part 1 of a series to implement sm1 -> spirv translation in vkd3d-shader, brought to you by late nights spent coding and rereading The Waste Land. Ganga was sunken, and the limp leaves Waited for rain, while the black clouds Gathered far distant, over Himavant. -- v4: vkd3d-shader: Synthesize signatures for d3dbc shaders. vkd3d-shader: Introduce an API to retrieve all signatures from DXBC shaders. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/200

2 3

[PATCH v2 0/7] MR3152: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 25 Jun '23

25 Jun '23

-- v2: wineoss: Use mmdevapi's AudioClient's Initialize. winecoreaudio: Use mmdevapi's AudioClient's Initialize. winealsa: Use mmdevapi's AudioClient's Initialize. winepulse: Move AudioClient's Initialize into mmdevapi. wineoss: Use standard allocator in AudioClient's Initialize. winecoreaudio: Use standard allocator in AudioClient's Initialize. winealsa: Use standard allocator in AudioClient's Initialize. https://gitlab.winehq.org/wine/wine/-/merge_requests/3152

3 8

[PATCH 0/1] MR3098: regedit: Fix memory leak on error path in RenameKey (scan-build).
by Alex Henrie (＠alexhenrie) 25 Jun '23

25 Jun '23

parentPath is allocated before parentKey. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3098

3 3

[PATCH v2 0/1] MR3154: cmd: Fix 'if exist' with a directory/ as a parameter.
by Maarten De Braekeleer (＠maarten) 24 Jun '23

24 Jun '23

'if exists' takes a parameter which can be directory, directory/, directory/. directory\ or directory\. for example, and should equate to true if the directory exists. The syntax directory\ is explicitly rejected by FindFirstFile and hence was not working - look for this specific case, and if found append a '.'. Follow-up commit of bc9d68bcbee5c9d4f4582f766a4f552870385361 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55130 -- v2: cmd: Fix 'if exist' with a directory/ as a parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/3154

2 2

[PATCH 0/1] MR3154: cmd: Fix 'if exist' with a directory/ as a parameter.
by Maarten DB (＠maarten) 24 Jun '23

24 Jun '23

'if exists' takes a parameter which can be directory, directory/, directory/. directory\ or directory\. for example, and should equate to true if the directory exists. The syntax directory\ is explicitly rejected by FindFirstFile and hence was not working - look for this specific case, and if found append a '.'. Follow-up commit of bc9d68bcbee5c9d4f4582f766a4f552870385361 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55130 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3154

4 3

[PATCH 0/7] MR3152: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 24 Jun '23

24 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3152

4 9

[PATCH 0/1] MR3140: mfplat: Use QueryPerformanceCounter in MFGetSystemTime.
by Rémi Bernon (＠rbernon) 24 Jun '23

24 Jun '23

This fixes some playback issues on sleep / resume cycles. Afaics it is also apparently the same clock source as native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3140

4 3

[PATCH v3 0/3] MR200: vkd3d-shader: Signature reflection API.
by Zebediah Figura (＠zfigura) 23 Jun '23

23 Jun '23

There are two parts to this: - First, a way to retrieve any signature from a DXBC shader. This is, I gather, generally useful for reflection, and it can be used as one source with which to implement d3d10 and d3d11 shader reflection APIs. The rest of those APIs will need much more data to be exposed from d3d shaders, and while I was originally planning to expose that all in a single "vkd3d_shader_d3d_shader_info" structure, I think that signatures at least are a reasonable enough subset to have a dedicated structure. Moreover, I did not want to block sm1 support on too much API design. - Second, signatures synthesized from sm1 byte code. This is conceptually a bit weird, because sm1 does not have signatures, but in terms of how these APIs are used by Wine (or other translation layers, as evidenced not least by the Vulkan test shader runner, which I have locally adapted for sm1 but not submitted yet) it fits rather nicely. Because this is new API, it of course deserves plenty of discussion, especially the sm1 part. Several open questions which occurred to me while writing are: 1. Should we fix the mask (and used mask) for sm1 signatures as 0xf rather than 0? SPIR-V cares about this in order to declare I/O variables, which makes some amount of sense. In fact I have a patch in my local tree to change this, specifically for that purpose. However, we could also normalize it later. 2. If we do fix the mask as nonzero, should single-component semantics (fog, depth, etc...) be declared as 0x1 instead of 0xf? 3. Should BLENDINDICES get a UINT type? It's float in shader instructions (well, kind of, although in practice it's used as an array index of course), but the vertex attribute type is in practice "supposed" to be integer. Part 1 of a series to implement sm1 -> spirv translation in vkd3d-shader, brought to you by late nights spent coding and rereading The Waste Land. Ganga was sunken, and the limp leaves Waited for rain, while the black clouds Gathered far distant, over Himavant. -- v3: vkd3d-shader: Synthesize signatures for d3dbc shaders. vkd3d-shader: Introduce an API to retrieve all signatures from DXBC shaders. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/200

4 20

Re: [PATCH v6 0/8] MR3112: wine{alsa,coreaudio,oss,pulse}: Refactor AudioClient's Initialize.
by Davide Beatrici (＠davidebeatrici) 23 Jun '23

23 Jun '23

On Fri Jun 23 06:52:48 2023 +0000, Huw Davies wrote: > Yes. !3152 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3112#note_36697

1 0

Re: [PATCH v2 0/1] MR3144: tools/winedump: Tidy up print out in minidumps. - approved
by Alexandre Julliard (＠julliard) 23 Jun '23

23 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3144

1 0

Re: [PATCH v2 0/9] MR3142: jscript: Misc fixes & improvements, part 2. - approved
by Alexandre Julliard (＠julliard) 23 Jun '23

23 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3142

1 0

Re: [PATCH v6 0/8] MR3112: wine{alsa,coreaudio,oss,pulse}: Refactor AudioClient's Initialize. - approved
by Alexandre Julliard (＠julliard) 23 Jun '23

23 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3112

1 0

Re: [PATCH v3 0/2] MR3129: dbghelp/test: Add explicit tests about loading ELF modules. - approved
by Alexandre Julliard (＠julliard) 23 Jun '23

23 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3129

1 0

2025

2024

2023

2022

wine-gitlab