- wine-gitlab - winehq.org

Re: [PATCH v6 0/2] MR3133: msi: handle newlines within field elements in MsiDatabaseImportA/MsiDatabaseExportA - approved
by Alexandre Julliard (＠julliard) 23 Jun '23

23 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3133

1 0

Re: [PATCH v4 0/1] MR3137: wbemdisp: Support DISPATCH_PROPERTYGET in Obejct Invoke - approved
by Alexandre Julliard (＠julliard) 23 Jun '23

23 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3137

1 0

Re: [PATCH v4 0/4] MR3128: sapi: Implement some basic SpVoice functions. - approved
by Alexandre Julliard (＠julliard) 23 Jun '23

23 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3128

1 0

[PATCH v2 0/5] MR245: vkd3d-shader/hlsl: Add support for 'break' and 'continue' jumps in loops.
by Nikolay Sivov (＠nsivov) 23 Jun '23

23 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/tpf: Write 'continue' instruction. vkd3d-shader: Insert loop iterator block before 'continue' jumps. vkd3d-shader/hlsl: Parse 'continue' statement. vkd3d-shader: Keep loop iterator instructions as a block. vkd3d-shader/hlsl: Allow 'break' instructions in loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/245

3 10

[PATCH 0/1] MR3150: win32u: Detect a missed WM_LBUTTONUP in the size/move loop.
by Tim Clem (＠tclem) 23 Jun '23

23 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3150

2 1

[PATCH 0/1] MR3147: winemac.drv: Don't expect an internal driver message to set last error.
by Tim Clem (＠tclem) 23 Jun '23

23 Jun '23

NtUserMessageCall(..., NtUserSendDriverMessage) does not ensure the validity of the hwnd, so this check will incorrectly fail if the last error was ERROR_INVALID_WINDOW_HANDLE by coincidence. The notify_owner call immediately following this code will catch a destroyed owner hwnd. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3147

3 2

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Damjan Jovanovic (＠dj) 23 Jun '23

23 Jun '23

On Fri Jun 23 19:02:05 2023 +0000, Davide Beatrici wrote: > I would expect the same behavior for `PFD_DRAW_TO_BITMAP` though. Aren't > both the same flag "class"? I guess we need more tests to be sure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36674

1 0

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Davide Beatrici (＠davidebeatrici) 23 Jun '23

23 Jun '23

On Fri Jun 23 18:54:52 2023 +0000, Damjan Jovanovic wrote: > I don't think it works like that. If the flag is set, it only returns a > PIXELFORMATDESCRIPTOR with the flag set, but if it is clear, then the > returned PIXELFORMATDESCRIPTOR can have the flag set or cleared. I would expect the same behavior for `PFD_DRAW_TO_BITMAP` though. Aren't both the same flag "class"? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36673

1 0

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Damjan Jovanovic (＠dj) 23 Jun '23

23 Jun '23

On Fri Jun 23 18:48:33 2023 +0000, Davide Beatrici wrote: > For consistency: > ```suggestion:-0+0 > if ((ppfd->dwFlags & PFD_SUPPORT_GDI) != (format.dwFlags & PFD_SUPPORT_GDI)) > ``` I don't think it works like that. If the flag is set, it only returns a PIXELFORMATDESCRIPTOR with the flag set, but if it is clear, then the returned PIXELFORMATDESCRIPTOR can have the flag set or cleared. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36672

1 0

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Davide Beatrici (＠davidebeatrici) 23 Jun '23

23 Jun '23

Davide Beatrici (@davidebeatrici) commented about dlls/opengl32/wgl.c: > continue; > } > > + if ((ppfd->dwFlags & PFD_SUPPORT_GDI) && !(format.dwFlags & PFD_SUPPORT_GDI)) For consistency: ```suggestion:-0+0 if ((ppfd->dwFlags & PFD_SUPPORT_GDI) != (format.dwFlags & PFD_SUPPORT_GDI)) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36671

1 0

[PATCH 0/1] MR1045: include: Add wine/winrt.h and define IInspectable helpers there.
by Paul Gofman (＠gofman) 23 Jun '23

23 Jun '23

And use that instead of duplicating those helpers across the tree. Besides removing existing duplicates, I am planning to add yet another WinRT dll (gamepad) and we will likely add more in the future, each of those can use that, as well as potentially more common helpers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1045

5 6

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting. - closed
by Rémi Bernon (＠rbernon) 23 Jun '23

23 Jun '23

This merge request was closed by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311

1 0

[PATCH v2 0/9] MR3122: Implement FileDispositionInformationEx
by Joel Holdsworth (＠jhol) 23 Jun '23

23 Jun '23

This MR supercedes !1895 and !3073 as a solution to bug [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771). Rather than fixing the problem of Wine's inability to modify the attributes of read-only files, this patch set instead implements `FileDispositionInformationEx` which the Msys2 and Cygwin runtime libriries can use to avoid needing to modify attributes. All the flags of `FileDispositionInformationEx` are implemented with the exception of `FILE_DISPOSITION_FORCE_IMAGE_SECTION_CHECK`. This MR improves upon !3073 by implementing `FILE_DISPOSITION_POSIX_SEMANTICS` and `FILE_DISPOSITION_ON_CLOSE` where the previous MR only implemented `FILE_DISPOSITION_DELETE` and `FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE`. -- v2: ntdll: Implement FILE_DISPOSITION_POSIX_SEMANTICS server: Replace unlink member of closed_fd with disp_flags ntdll/tests: Add tests for FILE_DISPOSITION_POSIX_SEMANTICS https://gitlab.winehq.org/wine/wine/-/merge_requests/3122

3 12

[PATCH 0/2] MR3146: Implement dbghelp.SymSrvGetFileIndexInfo for PDB files (DS format).
by eric pouech (＠epo) 23 Jun '23

23 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3146

2 2

[PATCH v2 0/1] MR3022: kernelbase: In AllocConsole(), dispose existing unix console.
by eric pouech (＠epo) 23 Jun '23

23 Jun '23

Unix consoles (created from initial process) are inherited by child processes for various reasons, like keeping std handles bound to that unix console. This differs from Windows as the default for a GUI is not to have console attached. If a GUI programs asks for a console, it will succeed on Windows but fail under Wine as the Unix console is still present. So, allow AllocConsole() to succeed when called from a GUI program and tied to a Unix console. (don't do it for CUI as they are already attached to a console). This fixes Scrap Mechanic when run with '-dev' option. (based on suggestion from Zhiyi Zhang) Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: kernelbase: Only inherit consoles for CUI processes. https://gitlab.winehq.org/wine/wine/-/merge_requests/3022

3 9

[PATCH 0/1] MR3145: ntdll: Inherit ConsoleHandle only by CUI processes.
by Jacek Caban (＠jacek) 23 Jun '23

23 Jun '23

Based on !3022. We could also consider applying that logic to `get_initial_console`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3145

3 3

[PATCH 0/9] MR3142: jscript: Misc fixes & improvements, part 2.
by Gabriel Ivăncescu (＠insn) 23 Jun '23

23 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3142

4 11

[PATCH 0/1] MR3144: tools/winedump: Tidy up print out in minidumps.
by eric pouech (＠epo) 23 Jun '23

23 Jun '23

- adjust hex/decimal print out - use internal helpers Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3144

2 1

[PATCH v3 0/1] MR239: vkd3d-shader/codegen: Skip register allocation for unused object variables.
by Nikolay Sivov (＠nsivov) 23 Jun '23

23 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader/codegen: Skip register allocation for unused object variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/239

4 7

[PATCH v5 0/8] MR3112: wine{alsa,coreaudio,oss,pulse}: Refactor AudioClient's Initialize.
by Davide Beatrici (＠davidebeatrici) 23 Jun '23

23 Jun '23

-- v5: winepulse: Refactor AudioClient's Initialize to match other drivers. wineoss: Use create_stream's channel count in AudioClient's Initialize. winecoreaudio: Use create_stream's channel count in AudioClient's Initialize. winealsa: Use create_stream's channel count in AudioClient's Initialize. winepulse: Use mmdevapi's set_stream_volumes. wineoss: Use mmdevapi's set_stream_volumes. winecoreaudio: Use mmdevapi's set_stream_volumes. winealsa: Use mmdevapi's set_stream_volumes. https://gitlab.winehq.org/wine/wine/-/merge_requests/3112

3 9

[PATCH v2 0/2] MR3129: dbghelp/test: Add explicit tests about loading ELF modules.
by eric pouech (＠epo) 23 Jun '23

23 Jun '23

Perhaps next time ELF loader is modified, it'll be noticed if it breaks things. See: - https://bugs.winehq.org/show_bug.cgi?id=55058 - https://bugs.winehq.org/show_bug.cgi?id=55096 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: dbghelp: Fix reading Wine loader's base address. dbghelp/test: Add explicit tests about loading ELF modules. https://gitlab.winehq.org/wine/wine/-/merge_requests/3129

2 3

[PATCH v5 0/2] MR3133: msi: handle newlines within field elements in MsiDatabaseImportA/MsiDatabaseExportA
by David Kahurani (＠kahurani) 23 Jun '23

23 Jun '23

Address the issues around bug 54532 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54532 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v5: msi: Convert newlines to alternate representation when exporting msi: Reject shorter/longer lines in MsiDatabaseImportA https://gitlab.winehq.org/wine/wine/-/merge_requests/3133

3 3

[PATCH 0/4] MR243: hlsl: Fix register allocation when unused reserved variables are involved.
by Zebediah Figura (＠zfigura) 23 Jun '23

23 Jun '23

Fixes: f8338ef08953686298bb31315a19e6044325bb49 -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/243

4 7

[PATCH 0/1] MR236: vkd3d-shader/d3dbc: Fix struct declarations in the CTBA.
by Francisco Casas (＠fcasas) 23 Jun '23

23 Jun '23

This commit is part of a series of commits intended to remove all uses of hlsl_type_get_regset(). However, I think it deserves to be upstreamed sooner since it solves a rather important SM1 regression (explained below) introduced in e0031d2a1f40792ac85619a495bf5197f248b0e1 . --- In SM1 we can expect all variables to always belong to a single regset. structs in particular, should always be allocated to HLSL_REGSET_NUM, since they are only allowed if all their components are numeric. We are not covering the structs case because of the use of hlsl_type_get_regset(), which is currently not defined for structs. So the current shader ```hlsl struct { float4 a; float4 b; } apple; float4 main() : sv_target { return apple.a + apple.b; } ``` fails with ``` vkd3d/libs/vkd3d-shader/hlsl.c:224: Aborting, reached unreachable code. ``` The solution is to iterate over all regsets to find the one where the variable is allocated (if any), and ignore all others. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/236

4 9

[PATCH v4 0/2] MR3133: msi: handle newlines within field elements in MsiDatabaseImportA/MsiDatabaseExportA
by David Kahurani (＠kahurani) 23 Jun '23

23 Jun '23

Address the issues around bug 54532 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54532 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v4: msi: Convert newlines to alternate representation when exporting msi: Reject shorter/longer lines in MsiDatabaseImportA https://gitlab.winehq.org/wine/wine/-/merge_requests/3133

3 4

[PATCH v3 0/1] MR3137: wbemdisp: Support DISPATCH_PROPERTYGET in Obejct Invoke
by Alistair Leslie-Hughes (＠alesliehughes) 23 Jun '23

23 Jun '23

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=55053 -- v3: wbemdisp: Support DISPATCH_PROPERTYGET in Object Invoke https://gitlab.winehq.org/wine/wine/-/merge_requests/3137

3 2

[PATCH v3 0/4] MR3128: sapi: Implement some basic SpVoice functions.
by Shaun Ren (＠shaunren) 23 Jun '23

23 Jun '23

-- v3: sapi: Implement ISpVoice::Set/GetVolume. sapi: Implement ISpVoice::Set/GetRate. sapi: Implement ISpVoice::Set/GetVoice. https://gitlab.winehq.org/wine/wine/-/merge_requests/3128

3 7

Re: [PATCH v4 0/12] MR3112: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Huw Davies (＠huw) 23 Jun '23

23 Jun '23

On Fri Jun 23 06:47:37 2023 +0000, Davide Beatrici wrote: > Sounds good. `malloc()` and `free()` are preferred, right? Yes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3112#note_36617

1 0

Re: [PATCH v4 0/12] MR3112: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 23 Jun '23

23 Jun '23

On Fri Jun 23 06:46:32 2023 +0000, Huw Davies wrote: > This is changing the allocator for `vols`, so you'll need commits that > change that first. > As this MR is already too long, let's split this into a new one and > leave the first seven or eight commits here. Sounds good. `malloc()` and `free()` are preferred, right? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3112#note_36613

1 0

Re: [PATCH v4 0/12] MR3112: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Huw Davies (＠huw) 23 Jun '23

23 Jun '23

Huw Davies (@huw) commented about dlls/winealsa.drv/mmdevdrv.c: > - params.duration = duration; > - params.period = period; > - params.fmt = fmt; > - params.channel_count = &channel_count; > - params.stream = &stream; > - > - ALSA_CALL(create_stream, &params); > - > - free(name); > - > - if(FAILED(params.result)){ > - sessions_unlock(); > - return params.result; > - } > - > - This->vols = HeapAlloc(GetProcessHeap(), 0, channel_count * sizeof(float)); This is changing the allocator for `vols`, so you'll need commits that change that first. As this MR is already too long, let's split this into a new one and leave the first seven or eight commits here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3112#note_36612

1 0

Re: [PATCH v2 0/1] MR3138: configure: Use -fvisibility=hidden when building with msvcrt and cross compiler is not available. - approved
by Alexandre Julliard (＠julliard) 22 Jun '23

22 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3138

1 0

Re: [PATCH v2 0/1] MR3141: secur32: Add support for sending TLS alerts. - approved
by Alexandre Julliard (＠julliard) 22 Jun '23

22 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3141

1 0

Re: [PATCH v2 0/10] MR3134: mshtml: More ref leak fixes. - approved
by Alexandre Julliard (＠julliard) 22 Jun '23

22 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3134

1 0

Re: [PATCH v2 0/1] MR3135: ntdll: Treat read faults on readable pages as write faults on macOS. - approved
by Alexandre Julliard (＠julliard) 22 Jun '23

22 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3135

1 0

Re: [PATCH v2 0/1] MR3136: win32u: Avoid SEGV in QueryDisplayConfig when run as service. - approved
by Alexandre Julliard (＠julliard) 22 Jun '23

22 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3136

1 0

Re: [PATCH v2 0/7] MR244: Release 1.8. - approved
by Alexandre Julliard (＠julliard) 22 Jun '23

22 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/244

1 0

[PATCH 0/7] MR244: Release 1.8.
by Henri Verbeet (＠hverbeet) 22 Jun '23

22 Jun '23

This series includes !236 and !243, mostly to avoid any potential ambiguity around their order relative to the release commit. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/244

6 9

[PATCH v3 0/12] MR3112: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 22 Jun '23

22 Jun '23

-- v3: wineoss: Use mmdevapi's AudioClient's Initialize. winecoreaudio: Use mmdevapi's AudioClient's Initialize. winealsa: Use mmdevapi's AudioClient's Initialize. winepulse: Move AudioClient's Initialize into mmdevapi. winepulse: Refactor AudioClient's Initialize to match other drivers. wineoss: Use create_stream's channel count in AudioClient's Initialize. winecoreaudio: Use create_stream's channel count in AudioClient's Initialize. winealsa: Use create_stream's channel count in AudioClient's Initialize. https://gitlab.winehq.org/wine/wine/-/merge_requests/3112

3 14

[PATCH v3 0/2] MR3133: msi: handle newlines within field elements in MsiDatabaseImportA/MsiDatabaseExportA
by David Kahurani (＠kahurani) 22 Jun '23

22 Jun '23

Address the issues around bug 54532 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54532 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v3: msi: Convert newlines to alternate representation when exporting https://gitlab.winehq.org/wine/wine/-/merge_requests/3133

3 5

[PATCH v2 0/1] MR3137: wbemdisp: Support DISPATCH_PROPERTYGET in Obejct Invoke
by Alistair Leslie-Hughes (＠alesliehughes) 22 Jun '23

22 Jun '23

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=55053 -- v2: wbemdisp: Support DISPATCH_PROPERTYGET in Obejct Invoke https://gitlab.winehq.org/wine/wine/-/merge_requests/3137

3 2

[PATCH 0/1] MR3141: secur32: Add support for sending TLS alerts.
by Hans Leidekker (＠hans) 22 Jun '23

22 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55086 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3141

3 2

[PATCH 0/10] MR3134: mshtml: More ref leak fixes.
by Gabriel Ivăncescu (＠insn) 22 Jun '23

22 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3134

3 11

[PATCH 0/1] MR3138: configure: Use -fvisibility=hidden when building with msvcrt and cross compiler is not available.
by Jacek Caban (＠jacek) 22 Jun '23

22 Jun '23

Currently, in PE modules, DECLSPEC_HIDDEN is useful only when cross compiler is missing. This makes non-PE build behavior more similar to proper PE builds, no longer requiring extra attention to support those configurations. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3138

2 1

[PATCH 0/1] MR3137: wbemdisp: Support DISPATCH_PROPERTYGET in Obejct Invoke
by Alistair Leslie-Hughes (＠alesliehughes) 22 Jun '23

22 Jun '23

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=55053 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3137

3 2

[PATCH 0/1] MR3136: win32u: Avoid SEGV in QueryDisplayConfig when run as service.
by Tatsuyuki Ishi (＠ishitatsuyuki) 22 Jun '23

22 Jun '23

The virtual_monitor used for non-interactive service executions do not have an adapter set. Avoid segfaulting and poisoning the mutex in such cases. /cc @rbernon -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3136

3 3

[PATCH v8 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 21 Jun '23

21 Jun '23

The test has a little inspiration from the SDK samples. -- v8: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

3 3

[PATCH v7 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 21 Jun '23

21 Jun '23

The test has a little inspiration from the SDK samples. -- v7: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

4 23

Re: [PATCH v2 0/1] MR3126: configure: Build x86_64 PE code with mcmodel=small. - approved
by Alexandre Julliard (＠julliard) 21 Jun '23

21 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3126

1 0

Re: [PATCH v10 0/8] MR2942: jscript: Misc fixes and improvements. - approved
by Alexandre Julliard (＠julliard) 21 Jun '23

21 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

1 0

Re: [PATCH v4 0/2] MR3120: win32u: Move virtual desktop display settings logic from winex11. - approved
by Alexandre Julliard (＠julliard) 21 Jun '23

21 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3120

1 0

Re: [PATCH v4 0/2] MR3121: cmd: Fix handling of PATH separator edge-cases - approved
by Alexandre Julliard (＠julliard) 21 Jun '23

21 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3121

1 0

Re: [PATCH v2 0/1] MR3123: crypt32: Do not create persistent container in CRYPT_CreateKeyProv(). - approved
by Alexandre Julliard (＠julliard) 21 Jun '23

21 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3123

1 0

Re: [PATCH v2 0/5] MR2982: dxgi: Refactor D3D12 swapchain (second part) - approved
by Alexandre Julliard (＠julliard) 21 Jun '23

21 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2982

1 0

[PATCH v2 0/5] MR3119: uiautomationcore: Add support for raising serverside events.
by Connor McAdams (＠cmcadams) 21 Jun '23

21 Jun '23

-- v2: uiautomationcore: Add support for invoking serverside event callbacks. uiautomationcore: Create a new node when raising serverside events. uiautomationcore: Add partial support for raising serverside events. uiautomationcore: Introduce custom uia_event_args structure. uiautomationcore: Introduce UI Automation event thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/3119

3 8

[PATCH 0/1] MR3135: ntdll: Treat read faults on readable pages as write faults on macOS.
by Tim Clem (＠tclem) 21 Jun '23

21 Jun '23

Working around a Rosetta bug on Apple Silicon - faults for certain instructions (e.g. lock cmpxchg8b) are misreported, which can break VPROT_WRITEWATCH handling. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3135

2 1

[PATCH 0/2] MR3133: msi: handle newlines within field elements in MsiDatabaseImportA/MsiDatabaseExportA
by David Kahurani (＠kahurani) 21 Jun '23

21 Jun '23

Address the issues around bug 54532 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54532 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3133

3 3

[PATCH v2 0/2] MR3133: msi: handle newlines within field elements in MsiDatabaseImportA/MsiDatabaseExportA
by David Kahurani (＠kahurani) 21 Jun '23

21 Jun '23

Address the issues around bug 54532 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54532 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v2: msi: Convert newlines to alternate representation when exporting https://gitlab.winehq.org/wine/wine/-/merge_requests/3133

2 2

[PATCH v9 0/8] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu (＠insn) 21 Jun '23

21 Jun '23

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- v9: jscript: Get rid of the function instance in arguments obj. jscript: Start from the last argument when adding them to named locals. jscript: Store detached args into a scope's specialized buffer. jscript: Don't use iface_to_jsdisp where it's not necessary to grab it. jscript: Get rid of jsobj in scope_chain_t. jscript: Fix function leak in scope_init_locals. jscript: Fix addressing invalid memory if ref is an argument. jscript: Correctly implement context for indirect eval calls in ES5+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

3 10

[PATCH 0/1] MR3126: configure: Build x86_64 PE code with mcmodel=small.
by Rémi Bernon (＠rbernon) 21 Jun '23

21 Jun '23

Saving a huge number of .refptr indirections for all extern symbols. Proton is using this for a while now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3126

3 3

[PATCH v6 0/6] MR2944: winewayland.drv: part 4: First window contents on screen
by Alexandros Frantzis (＠afrantzis) 21 Jun '23

21 Jun '23

The goal of this MR is to set up the minimum necessary infrastructure to display the contents of some simple, software rendered windows. This involves two major steps: 1. Associate a window with a Wayland surface and give it the `xdg_toplevel` role, so that the compositor can display it. We also have to implement the required initial `xdg_surface` configuration sequence to be able to safely (i.e., without the compositor disconnecting us with an error) attach buffers to the surface in step (2). 2. Implement the `window_surface` interface for the Wayland driver. For now we provide a simple (and suboptimal) `window_surface_flush` implementation: for each flush we create a new `wl_shm` buffer, copy the whole window contents (ignoring damaged bounds for now) into it and attach it to the target Wayland surface. In the next MR I will optimize this implementation in multiple ways: a. implement a buffer queue to avoid constantly allocating new buffers b. respect the damaged bounds of the `window_surface` to minimize copying of data from the `window_surface` to the SHM buffer (and also for correctness) c. communicate damaged surface regions to the compositor to (potentially) allow more efficient texture uploads. With this MR many (software-rendered) applications can now display dynamic content on screen. We can't interact with the apps yet, but we do get to enjoy `notepad` in all its blinking-cursor glory. Thanks! -- v6: winewayland.drv: Do not commit buffers to unconfigured surfaces. winewayland.drv: Implement a simple window_surface flush. https://gitlab.winehq.org/wine/wine/-/merge_requests/2944

3 9

[PATCH v3 0/9] MR3048: Media.speech improvements.
by eric pouech (＠epo) 21 Jun '23

21 Jun '23

This series adds a couple of features to WinRT's media.speech: - IVoiceInformation, and synthetizer's options are present (mainly use to store information, not yet to make fully use of it) - add a dummy implementation (1 single voice); that should be extended in future series by using ISpVoice instead - add a couple of more tests to go with implementation (the serie should prevent MS Flight simulator to crash on first connection. Crash is due to exception handling of C# generated exceptions from E_NOTIMPL with some X11 related critical resources). A+ -- v3: windows.media.speech: Implement get/put voice on synthesizer. windows.media.speech: Select a default voice in synthesizer. windows.media.speech: Add more tests about default voice. windows.media.speech: Finish implementation of voice information view. windows.media.speech/tests: Add tests about vector view's content. windows.media.speech: Add basic implementation of IVoiceInformation. windows.media.speech: Add more tests about IVoiceInformation. windows.media.speech: Add basic implementation on synthesizer options. windows.media.speech: Add a couple of synthesizer's options tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3048

3 19

[PATCH 0/5] MR3119: uiautomationcore: Add support for raising serverside events.
by Connor McAdams (＠cmcadams) 21 Jun '23

21 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3119

3 10

[PATCH 0/1] MR3123: crypt32: Do not create persistent container in CRYPT_CreateKeyProv().
by Paul Gofman (＠gofman) 21 Jun '23

21 Jun '23

The way CryptAcquireContext is currently used for temporary internal context in CertCreateSelfSignCertificate(), there is always a unique container created and persisted in registry (thus resulting in ever growing registry while an app repeatedly creates ephemeral certs with CertCreateSelfSignCertificate). The unique container name doesn't go anywhere outside of CRYPT_CreateKeyProv, and the crypt context is only used internally in CertCreateSelfSignCertificate() to generate the key and extract the key data (and put that to certificate store), so using a non-persistent context should be better. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3123

3 2

[PATCH v8 0/8] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu (＠insn) 21 Jun '23

21 Jun '23

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- v8: jscript: Get rid of the function instance in arguments obj. jscript: Start from the last argument when adding them to named locals. jscript: Store detached args into a scope's specialized buffer. jscript: Don't use iface_to_jsdisp where it's not necessary to grab it. jscript: Get rid of jsobj in scope_chain_t. jscript: Fix function leak in scope_init_locals. jscript: Fix addressing invalid memory if ref is an argument. jscript: Correctly implement context for indirect eval calls in ES5+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

3 9

[PATCH v5 0/6] MR2944: winewayland.drv: part 4: First window contents on screen
by Alexandros Frantzis (＠afrantzis) 21 Jun '23

21 Jun '23

The goal of this MR is to set up the minimum necessary infrastructure to display the contents of some simple, software rendered windows. This involves two major steps: 1. Associate a window with a Wayland surface and give it the `xdg_toplevel` role, so that the compositor can display it. We also have to implement the required initial `xdg_surface` configuration sequence to be able to safely (i.e., without the compositor disconnecting us with an error) attach buffers to the surface in step (2). 2. Implement the `window_surface` interface for the Wayland driver. For now we provide a simple (and suboptimal) `window_surface_flush` implementation: for each flush we create a new `wl_shm` buffer, copy the whole window contents (ignoring damaged bounds for now) into it and attach it to the target Wayland surface. In the next MR I will optimize this implementation in multiple ways: a. implement a buffer queue to avoid constantly allocating new buffers b. respect the damaged bounds of the `window_surface` to minimize copying of data from the `window_surface` to the SHM buffer (and also for correctness) c. communicate damaged surface regions to the compositor to (potentially) allow more efficient texture uploads. With this MR many (software-rendered) applications can now display dynamic content on screen. We can't interact with the apps yet, but we do get to enjoy `notepad` in all its blinking-cursor glory. Thanks! -- v5: winewayland.drv: Do not commit buffers to unconfigured surfaces. winewayland.drv: Implement a simple window_surface flush. https://gitlab.winehq.org/wine/wine/-/merge_requests/2944

3 11

[PATCH 0/1] MR2507: vbscript: Add additional types for stack_pop_bool.
by Jason Millard (＠jsm174) 21 Jun '23

21 Jun '23

I have found some scripts where comparisons that use floats and OLECOLOR directly fail. For example: ``` If Light005.State Then ' State is a float V_R4 End If If Light005.Colorfull Then ' Colorfull is an OLECOLOR VT_UI4 End If ``` This is because `stack_pop_bool` does not handle `VT_R4` and `VT_UI4` and returns `E_NOTIMPL`. This adds additional types to `stack_pop_bool` similar to `VARIANT_Coerce`. Fixes https://bugs.winehq.org/show_bug.cgi?id=54731 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2507

4 7

[PATCH 0/5] MR2982: dxgi: Refactor D3D12 swapchain (second part)
by Giovanni Mascellani (＠giomasce) 21 Jun '23

21 Jun '23

Second and last part of https://gitlab.winehq.org/wine/wine/-/merge_requests/2930. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2982

4 7

[PATCH v2 0/2] MR240: vkd3d-shader: Add constant folding for the 'dot' operation.
by Nikolay Sivov (＠nsivov) 21 Jun '23

21 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader: Add constant folding for 'dp2add' operation. vkd3d-shader: Add constant folding for the 'dot' operation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/240

4 5

[PATCH 0/1] MR3129: dbghelp/test: Add explicit tests about loading ELF modules.
by eric pouech (＠epo) 21 Jun '23

21 Jun '23

Perhaps next time ELF loader is modified, it'll be noticed if it breaks things. See: - https://bugs.winehq.org/show_bug.cgi?id=55058 - https://bugs.winehq.org/show_bug.cgi?id=55096 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3129

2 2

Re: [PATCH v2 0/1] MR3104: win32u: Add DriverVersion string for GPUs to registry
by Michael Skorokhodov (＠Samsuper) 21 Jun '23

21 Jun '23

On Wed Jun 21 09:30:59 2023 +0000, Zhiyi Zhang wrote: > I think it will be better if you can report different driver versions > for different vendors. For example, NVIDIA, AMD, and Intel drivers > should have different versions. You can use gpu->vendor_id to > differentiate them. For other vendors, either report a 1.0.0 version or > simply don't add this property. It might be good, but that variable doesn't contain any ID, only zero. I tried running games and applications. Probably, it could work in ValveSoftware/Wine when they update their repository. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3104#note_36443

1 0

[PATCH 0/1] MR3130: win32u: Use SessionId for non-interactive check instead of WSF_VISIBLE.
by Tatsuyuki Ishi (＠ishitatsuyuki) 21 Jun '23

21 Jun '23

Both window station visibility and session id are related to services being spawned in a non-interactive session, however the process window station can be manually set by the application while the session id can not be. The enumerated display config should not change even in the case of a window station update, hence testing for SessionId == 0 is more reliable here. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55074 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3130

4 7

[PATCH v2 0/12] MR3112: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 21 Jun '23

21 Jun '23

-- v2: wineoss: Use mmdevapi's AudioClient's Initialize. winecoreaudio: Use mmdevapi's AudioClient's Initialize. winealsa: Use mmdevapi's AudioClient's Initialize. winepulse: Move AudioClient's Initialize into mmdevapi. winepulse: Refactor AudioClient's Initialize to match other drivers. wineoss: Use create_stream's channel count in AudioClient's Initialize. winecoreaudio: Use create_stream's channel count in AudioClient's Initialize. winealsa: Use create_stream's channel count in AudioClient's Initialize. winepulse: Use mmdevapi's set_stream_volumes. wineoss: Use mmdevapi's set_stream_volumes. winecoreaudio: Use mmdevapi's set_stream_volumes. winealsa: Use mmdevapi's set_stream_volumes. https://gitlab.winehq.org/wine/wine/-/merge_requests/3112

4 14

[PATCH v3 0/5] MR224: tests: Test coarse and fine derivates and demand less precision from ddx() and ddy().
by Francisco Casas (＠fcasas) 21 Jun '23

21 Jun '23

On my Nvidia GeForce GTX 1050 Ti `ddxddy.shader_test` doesn't pass because of considerably different numeric results. As Giovanni pointed out, this is because my GPU uses the fine derivate and not the coarse derivate to implement ddx() and ddy(). For this reason, the result for ddx|ddy() is quantized so that the test passes if the GPU uses either coarse or fine derivates. Additionally, tests for both ddx_coarse|ddy_coarse() and ddx_fine|ddy_fine() are added, that expect a more precise result. -- v3: vkd3d-shader/hlsl: Support fine derivates. vkd3d-shader/hlsl: Support coarse derivates. tests: Quantize regular and coarse derivate test results. tests: Make ddx() and ddy() test behave correctly for shader models < 4. tests: Test coarse and fine derivates. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/224

3 7

[PATCH v2 0/4] MR3128: sapi: Implement some basic SpVoice functions.
by Shaun Ren (＠shaunren) 21 Jun '23

21 Jun '23

-- v2: sapi: Implement ISpVoice::Set/GetVolume. sapi: Implement ISpVoice::Set/GetRate. sapi: Implement ISpVoice::Set/GetVoice. sapi: Implement ISpVoice::SetOutput. https://gitlab.winehq.org/wine/wine/-/merge_requests/3128

3 5

[PATCH 0/1] MR1305: ntdll: The maximum length for a path is MAX_PATH.
by Jiajin Cui (＠jin-king1) 21 Jun '23

21 Jun '23

see "https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-li…". Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1305

3 3

[PATCH 0/1] MR1306: win32u: When the window is not visible but has WS_VISIBLE flag, we should update the vis rgn.
by Jiajin Cui (＠jin-king1) 21 Jun '23

21 Jun '23

When the child window and the parent window are no longer in the same process, the parent window shadow does not update the vis rgn of the child window and modify the WS_VISIBLE style of the child window. so we need to update the vis rgn when another process gets the DC of the child window. Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1306

2 2

[PATCH 0/8] MR3112: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 21 Jun '23

21 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3112

3 11

[PATCH 0/4] MR3128: sapi: Implement some basic SpVoice functions.
by Shaun Ren (＠shaunren) 21 Jun '23

21 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3128

3 5

[PATCH 0/4] MR3127: sapi: Implement some ISpVoice functions.
by Shaun Ren (＠shaunren) 21 Jun '23

21 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3127

3 6

[PATCH v7 0/3] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 21 Jun '23

21 Jun '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v7: ws2_32/tests: Fix incorrect test (bug #47560) ws2_32/tests: Remove todo_wine from now-successful tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

3 5

Re: [PATCH v2 0/1] MR3104: win32u: Add DriverVersion string for GPUs to registry
by Zhiyi Zhang (＠zhiyi) 21 Jun '23

21 Jun '23

I think it will be better if you can report different driver versions for different vendors. For example, NVIDIA, AMD, and Intel drivers should have different versions. You can use gpu->vendor_id to differentiate them. For other vendors, either report a 1.0.0 version or simply don't add this property. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3104#note_36398

1 0

[PATCH v4 0/6] MR2944: winewayland.drv: First window contents on screen
by Alexandros Frantzis (＠afrantzis) 21 Jun '23

21 Jun '23

The goal of this MR is to set up the minimum necessary infrastructure to display the contents of some simple, software rendered windows. This involves two major steps: 1. Associate a window with a Wayland surface and give it the `xdg_toplevel` role, so that the compositor can display it. We also have to implement the required initial `xdg_surface` configuration sequence to be able to safely (i.e., without the compositor disconnecting us with an error) attach buffers to the surface in step (2). 2. Implement the `window_surface` interface for the Wayland driver. For now we provide a simple (and suboptimal) `window_surface_flush` implementation: for each flush we create a new `wl_shm` buffer, copy the whole window contents (ignoring damaged bounds for now) into it and attach it to the target Wayland surface. In the next MR I will optimize this implementation in multiple ways: a. implement a buffer queue to avoid constantly allocating new buffers b. respect the damaged bounds of the `window_surface` to minimize copying of data from the `window_surface` to the SHM buffer (and also for correctness) c. communicate damaged surface regions to the compositor to (potentially) allow more efficient texture uploads. With this MR many (software-rendered) applications can now display dynamic content on screen. We can't interact with the apps yet, but we do get to enjoy `notepad` in all its blinking-cursor glory. Thanks! -- v4: winewayland.drv: Do not commit buffers to unconfigured surfaces. winewayland.drv: Implement a simple window_surface flush. winewayland.drv: Introduce window_surface for Wayland. winewayland.drv: Ensure Wayland surface handlers don't access invalid data. winewayland.drv: Basic Wayland toplevel surface support. https://gitlab.winehq.org/wine/wine/-/merge_requests/2944

4 17

[PATCH v6 0/2] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 21 Jun '23

21 Jun '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v6: ws2_32/tests: Remove todo_wine from now-successful tests. server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

3 3

Re: [PATCH v5 0/2] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 20 Jun '23

20 Jun '23

Yes, once I add `SOCK_CONNECTING` to the allowed states for `getpeername()` to succeed. I then get the same output as on Windows 10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3074#note_36391

1 0

[PATCH 0/1] MR3091: include: Avoid redefinitions of __fastcall on FreeBSD
by Gerald Pfeifer (＠gerald) 20 Jun '23

20 Jun '23

After commit b337c5b1a1757b2abbc90a7c6955d64242861ab9 builds on FreeBSD see 115 instances of include/windef.h:60: warning: "__fastcall" redefined which comes from <stdio.h> including <sys/cdefs.h> which in turns has #define __fastcall __attribute__((__fastcall__)) Simply #undef-ining __fastcall like we do for some other cases already addresses this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3091

4 4

Re: [PATCH v2 0/1] MR3108: ws2_32: Don't export num_startup. - approved
by Alexandre Julliard (＠julliard) 20 Jun '23

20 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3108

1 0

Re: [PATCH v2 0/1] MR3110: crypt32: Don't export CRYPT_CopyReversed. - approved
by Alexandre Julliard (＠julliard) 20 Jun '23

20 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3110

1 0

Re: [PATCH v3 0/1] MR3097: sane: Fix use after free in create_item (scan-build). - approved
by Alexandre Julliard (＠julliard) 20 Jun '23

20 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3097

1 0

Re: [PATCH v2 0/4] MR3115: imm32: Fixes for comp string on character deletion and result commit. - approved
by Alexandre Julliard (＠julliard) 20 Jun '23

20 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3115

1 0

Re: [PATCH v2 0/5] MR3118: Implement dbghelp.SymSrvGetFileIndexesInfo(). - approved
by Alexandre Julliard (＠julliard) 20 Jun '23

20 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3118

1 0

Re: [PATCH v4 0/1] MR3117: loader: Set the visibility of symbols in preloader to "hidden". (#55091) - approved
by Alexandre Julliard (＠julliard) 20 Jun '23

20 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3117

1 0

Re: [PATCH v2 0/3] MR3116: oleaut32/recinfo: Use correct allocator for the record data. - approved
by Alexandre Julliard (＠julliard) 20 Jun '23

20 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3116

1 0

Re: [PATCH v2 0/1] MR3099: wbemprox: Fix memory leak on error path in enum_key (scan-build). - approved
by Alexandre Julliard (＠julliard) 20 Jun '23

20 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3099

1 0

[PATCH v28 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 20 Jun '23

20 Jun '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v28: ws2_32/tests: Add test for AF_UNIX sockets. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

4 15

[PATCH 0/1] MR3106: apisetschema: Add api-ms-win-core-com-l2-1-1
by Fabian Maurer (＠DarkShadow44) 20 Jun '23

20 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55075 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3106

4 7

[PATCH 0/9] MR3122: Implement FileDispositionInformationEx
by Joel Holdsworth (＠jhol) 20 Jun '23

20 Jun '23

This MR supercedes !1895 and !3073 as a solution to bug [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771). Rather than fixing the problem of Wine's inability to modify the attributes of read-only files, this patch set instead implements `FileDispositionInformationEx` which the Msys2 and Cygwin runtime libriries can use to avoid needing to modify attributes. All the flags of `FileDispositionInformationEx` are implemented with the exception of `FILE_DISPOSITION_FORCE_IMAGE_SECTION_CHECK`. This MR improves upon !3073 by implementing `FILE_DISPOSITION_POSIX_SEMANTICS` and `FILE_DISPOSITION_ON_CLOSE` where the previous MR only implemented `FILE_DISPOSITION_DELETE` and `FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3122

3 11

[PATCH v3 0/2] MR3121: cmd: Fix handling of PATH separator edge-cases
by Liam Middlebrook (＠liam-middlebrook) 20 Jun '23

20 Jun '23

Some new tests and a fix for a bug I hit recently with cmd.exe's handling of PATH. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55097 -- v3: cmd: Fix empty-strings between PATH separators cmd/tests: Add tests for PATH separator https://gitlab.winehq.org/wine/wine/-/merge_requests/3121

2 2

[PATCH v2 0/2] MR3121: cmd: Fix handling of PATH separator edge-cases
by Liam Middlebrook (＠liam-middlebrook) 20 Jun '23

20 Jun '23

Some new tests and a fix for a bug I hit recently with cmd.exe's handling of PATH. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55097 -- v2: cmd: Fix empty-strings between PATH separators cmd/tests: Add tests for PATH separator https://gitlab.winehq.org/wine/wine/-/merge_requests/3121

3 5

[PATCH v3 0/2] MR3120: win32u: Move virtual desktop display settings logic from winex11.
by Rémi Bernon (＠rbernon) 20 Jun '23

20 Jun '23

-- v3: win32u: Move virtual desktop display settings logic from winex11. win32u: Split default UpdateDisplayDevices implementation to a helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/3120

3 4

[PATCH 0/2] MR3121: cmd: Fix handling of PATH separator edge-cases
by Liam Middlebrook (＠liam-middlebrook) 20 Jun '23

20 Jun '23

Some new tests and a fix for a bug I hit recently with cmd.exe's handling of PATH. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55097 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3121

3 3

2025

2024

2023

2022

wine-gitlab