- wine-gitlab - winehq.org

[PATCH v2 0/1] MR3097: sane: Fix use after free in create_item (scan-build).
by Alex Henrie (＠alexhenrie) 20 Jun '23

20 Jun '23

realloc may free lead_static. -- v2: sane: Fix use after free in create_item (scan-build). https://gitlab.winehq.org/wine/wine/-/merge_requests/3097

3 3

[PATCH v6 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 20 Jun '23

20 Jun '23

The test has a little inspiration from the SDK samples. -- v6: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

4 17

[PATCH 0/4] MR3115: imm32: Fixes for comp string on character deletion and result commit.
by Rémi Bernon (＠rbernon) 20 Jun '23

20 Jun '23

I believe this fixes some bad behavior, and it includes one fix from https://gitlab.winehq.org/wine/wine/-/merge_requests/2698 to avoid duplicated entries (though doesn't supersedes that MR). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3115

4 7

Re: [PATCH v2 0/1] MR3104: win32u: Add DriverVersion string for GPUs to registry
by Michael Skorokhodov (＠Samsuper) 20 Jun '23

20 Jun '23

@julliard Hi! Can you please review this MR? About the purpose of the changes: https://github.com/ValveSoftware/wine/pull/191 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3104#note_36306

1 0

[PATCH v2 0/9] MR3048: Media.speech improvements.
by eric pouech (＠epo) 20 Jun '23

20 Jun '23

This series adds a couple of features to WinRT's media.speech: - IVoiceInformation, and synthetizer's options are present (mainly use to store information, not yet to make fully use of it) - add a dummy implementation (1 single voice); that should be extended in future series by using ISpVoice instead - add a couple of more tests to go with implementation (the serie should prevent MS Flight simulator to crash on first connection. Crash is due to exception handling of C# generated exceptions from E_NOTIMPL with some X11 related critical resources). A+ -- v2: windows.media.speech: Implement get/put voice on synthesizer. windows.media.speech: Implement default voice. windows.media.speech: Add more tests about voice selection. windows.media.speech: Finish implement the voice information view. windows.media.speech/tests: Added tests about vector view's content. windows.media.speech: Add basic implementation of IVoiceInformation. windows.media.speech: Add more tests about IVoiceInformation. windows.media.speech: Add basic implementation on synthesizer options. windows.media.speech: Adding a couple of synthesizer's options tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3048

3 10

[PATCH v2 0/2] MR3120: win32u: Move virtual desktop display settings logic from winex11.
by Rémi Bernon (＠rbernon) 20 Jun '23

20 Jun '23

-- v2: win32u: Move virtual desktop display settings logic from winex11. win32u: Split default UpdateDisplayDevices implementation to a helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/3120

2 3

Re: [PATCH v5 0/4] MR3073: Implement FileDispositionInformationEx and FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE - closed
by Joel Holdsworth (＠jhol) 20 Jun '23

20 Jun '23

This merge request was closed by Joel Holdsworth. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3073

1 0

[PATCH v2 0/5] MR224: tests: Test coarse and fine derivates and demand less precision from ddx() and ddy().
by Francisco Casas (＠fcasas) 20 Jun '23

20 Jun '23

On my Nvidia GeForce GTX 1050 Ti `ddxddy.shader_test` doesn't pass because of considerably different numeric results. As Giovanni pointed out, this is because my GPU uses the fine derivate and not the coarse derivate to implement ddx() and ddy(). For this reason, the result for ddx|ddy() is quantized so that the test passes if the GPU uses either coarse or fine derivates. Additionally, tests for both ddx_coarse|ddy_coarse() and ddx_fine|ddy_fine() are added, that expect a more precise result. -- v2: vkd3d-shader/hlsl: Fine derivates support. vkd3d-shader/hlsl: Coarse derivates support. tests: Quantize ddx() and ddy() test. tests: Make ddx() and ddy() test behave correctly for shader models < 4. tests: Test coarse and fine derivates. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/224

5 11

[PATCH 0/5] MR3118: Implement dbghelp.SymSrvGetFileIndexesInfo().
by eric pouech (＠epo) 20 Jun '23

20 Jun '23

Implements SymSrvGetFileIndexesInfo() for PE images. (.dbg and .pdb are still to be done). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3118

2 5

[PATCH v3 0/1] MR3117: loader: Set the visibility of symbols in preloader to "hidden". (#55091)
by Jinoh Kang (＠iamahuman) 20 Jun '23

20 Jun '23

Today, the preloader is linked with -fPIE in spite of the fact that the preloader is a non-PIE statically linked binary. This is due to a limitation in tools/makedep that makes it difficult to specify CFLAGS for each individual object file's recipe. This can seemingly cause problems with some GOTPCREL(X) relocations inside the preloader. Since preloader does not link to the system library directly, there is no need for a Global Offset Table (GOT). However, a few extern (non-static) function symbols are declared, the use of which makes GCC emit instructions that references those symbols by indirection through GOT. The linker then tries to optimize such instructions to eliminate GOT references, which can fail due to various reasons. This stands in contradiction with Jinoh Kang's suggestion (in bug 55050) that "-fPIE is harmless even when applied to an object linked into non-PIE executables." The claim is theoretically true since position-independent code can in principle be relocated to any address (fixed or dynamic); however, it fails due to some peculiar practical issues, which is arguably a limitation in the linker's implementation (since it can be worked around with -Wl,--no-relax without issues). Fix this by eliminating GOT usage by setting the default visibility of non-static declarations to "hidden". Assuming GCC's medium code model (-mcmodel=medium; default code model for x86_64), this suppresses any unnecessary PLT or GOT relocations for defined symbols, and provides opportunity for GCC to optimize the code better. Fixes: 78ed343842dcd8ffb95c416420953e121959d40d Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55091 cc/ @epo -- v3: loader: Set the visibility of symbols in preloader to "hidden". https://gitlab.winehq.org/wine/wine/-/merge_requests/3117

2 2

[PATCH 0/1] MR3117: loader: Set the visibility of symbols in preloader to "hidden". (#55095)
by Jinoh Kang (＠iamahuman) 20 Jun '23

20 Jun '23

Today, the preloader is linked with -fPIE in spite of the fact that the preloader is a non-PIE statically linked binary. This is due to a limitation in tools/makedep that makes it difficult to specify CFLAGS for each individual object file's recipe. This can seemingly cause problems with some GOTPCREL(X) relocations inside the preloader. Since preloader does not link to the system library directly, there is no need for Global Offset Tables (GOT). However, a few extern (non-static) function symbols are declared, the use of which makes GCC emit instructions that references those symbols by indirection through GOT. The linker then tries to optimize such instructions to eliminate GOT references, which can fail due to various reasons. This stands in contradiction with Jinoh Kang's suggestion (in bug 55050) that "-fPIE is harmless even when applied to an object linked into non-PIE executables." The claim is theoretically true since position-independent code can in principle be relocated to any address (fixed or dynamic); however, it fails due to some peculiar practical issues, which is arguably a limitation in the linker's implementation (since it can be worked around --no-relax without issues). Fix this by eliminating GOT usage by setting the default visibility of non-static declarations to "hidden". Assuming GCC's medium code model (-mcmodel=medium; default code model for x86_64), this suppresses any unnecessary PLT or GOT relocations for defined symbols, and provides opportunity for GCC to optimize the code better. Fixes: 78ed343842dcd8ffb95c416420953e121959d40d Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55095 cc/ @epo -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3117

2 2

[PATCH v2 0/1] MR239: vkd3d-shader/codegen: Skip register allocation for unused object variables.
by Nikolay Sivov (＠nsivov) 20 Jun '23

20 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/codegen: Skip register allocation for unused object variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/239

3 3

[PATCH v7 0/9] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu (＠insn) 20 Jun '23

20 Jun '23

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- v7: jscript: Store ref to the function code instead of the function instance jscript: Start from the last argument when adding them to named locals. jscript: Store detached locals into a scope's specialized buffer. jscript: Detach the frame's scope before inserting eval() variables into it. jscript: Don't use iface_to_jsdisp where it's not necessary to grab it. jscript: Get rid of jsobj in scope_chain_t. jscript: Fix function leak in scope_init_locals. jscript: Fix addressing invalid memory if ref is an argument. jscript: Correctly implement context for indirect eval calls in ES5+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

3 16

[PATCH v4 0/2] MR2875: shell32: add support for balloon icon copying
by Cherser-s (＠Cherser-s) 20 Jun '23

20 Jun '23

Currently shell32 only transfers the plain icon for `Shell_NotifyIcon` calls, ignoring balloon icons. This patch allows transferring both images to explorer.exe tray. -- v4: shell32: add support for balloon icon copying shell32: refactor notify_icon for multiple icons https://gitlab.winehq.org/wine/wine/-/merge_requests/2875

2 2

[PATCH 0/3] MR3116: oleaut32/recinfo: Use correct allocator for the record data.
by Nikolay Sivov (＠nsivov) 20 Jun '23

20 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3116

2 3

[PATCH 0/1] MR217: include: Use WIN32_LEAN_AND_MEAN to exlude non-required headers
by Alistair Leslie-Hughes (＠alesliehughes) 20 Jun '23

20 Jun '23

Reference https://bugs.winehq.org/show_bug.cgi?id=54985 From the line we see the mingw version used causes an In file included from /usr/share/mingw-w64/include/unknwnbase.h:47, [ 935s] from /usr/share/mingw-w64/include/objidlbase.h:439, [ 935s] from include/combaseapi.h:29, [ 935s] from include/objbase.h:267, [ 935s] from include/ole2.h:25, [ 935s] from /usr/share/mingw-w64/include/wtypes.h:13, [ 935s] from include/winscard.h:22, [ 935s] from include/windows.h:68, [ 935s] from libs/vkd3d/include/private/vkd3d_common.h:23, [ 935s] from libs/vkd3d/libs/vkd3d-shader/vkd3d_shader_private.h:49, [ 935s] from libs/vkd3d/libs/vkd3d-shader/preproc.y:24, [ 935s] from libs/vkd3d/libs/vkd3d-shader/preproc.l:23: [ 935s] /usr/share/mingw-w64/include/wtypesbase.h:148:16: error: redefinition of 'struct _SECURITY_ATTRIBUTES' [ 935s] 148 | typedef struct _SECURITY_ATTRIBUTES { The included file winscard.h seemed a little odd. The vkd3d isn't going to use this. Adding the define WIN32_LEAN_AND_MEAN to the Makefile.in (in wine), produce the following warnings. /home/alesliehughes/wine/libs/vkd3d/include/private/vkd3d_common.h:75:5: warning: implicit declaration of function ‘abort’ [-Wimplicit-function-declaration] 75 | abort(); | ^~~~~ /home/alesliehughes/wine/libs/vkd3d/include/private/vkd3d_common.h:258:14: warning: implicit declaration of function ‘atoi’ [-Wimplicit-function-declaration] 258 | *major = atoi(version); Adding header <stdlib.h> removed all the warnings. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/217

5 7

[PATCH v4 0/4] MR3073: Implement FileDispositionInformationEx and FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE
by Joel Holdsworth (＠jhol) 20 Jun '23

20 Jun '23

This MR supercedes !1895 as a solution to bug [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771). Rather than fixing the problem of Wine's inability to modify the attributes of read-only files, this patch set instead implements `FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE` which the Msys2 and Cygwin runtime libriries can use to avoid needing to modify attributes. -- v4: ntdll: Implemented FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE ntdll/tests: Added tests for FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE ntdll: Initial implementation of FileDispositionInformationEx include: Defined FILE_DISPOSITION_INFORMATION_EX and friends https://gitlab.winehq.org/wine/wine/-/merge_requests/3073

3 8

[PATCH v23 0/6] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) 20 Jun '23

20 Jun '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v23: winesni.drv: add dbus watch instead of using plain unix fds and flush winesni.drv: replaced the dbus connection logic with a single connection per each SNI object winesni.drv: wrap functions with pthread mutex locking winesni.drv: implement basic balloon notification support explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 7

[PATCH 0/2] MR3105: Add a few additional nullchecks (Coverity)
by Fabian Maurer (＠DarkShadow44) 20 Jun '23

20 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3105

3 3

[PATCH 0/1] MR3099: wbemprox: Fix memory leak on error path in enum_key (scan-build).
by Alex Henrie (＠alexhenrie) 20 Jun '23

20 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3099

4 3

[PATCH v8 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 20 Jun '23

20 Jun '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v8: comdlg32: Enable visual styles when showing IFileDialog. comdlg32: Return E_UNEXPECTED if IFileDialog is already shown https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

2 3

[PATCH v4 0/4] MR1710: mf: Discard end of presentation on IMFMediaSession_Stop.
by Rémi Bernon (＠rbernon) 20 Jun '23

20 Jun '23

MR !607 was trying to fix an issue with Life Is Strange Remastered, but although it fixed some race conditions with presentation end, the issue it was trying to fix is still there. The game calls IMFMediaSession_Stop while the presentation is ending, expects that command to quickly execute, interrupting the presentation end and emitting a MESessionStopped event instead of the MESessionEnded. Delaying the Stop command and emitting the MESessionEnded event breaks the game assumptions and it crashes. -- v4: mf: Discard end of presentation on IMFMediaSession_Stop. mf/tests: Test IMFMediaSession_Stop command near presentation end. mf/tests: Test Start / Pause / Stop IMFMEdiaSession events. mf/tests: Split wait_media_event helper into wait_next_media_event. https://gitlab.winehq.org/wine/wine/-/merge_requests/1710

3 10

[PATCH v2 0/5] MR2782: mf/tests: Test byte stream handler resolution time and media source presentation descriptor.
by Rémi Bernon (＠rbernon) 20 Jun '23

20 Jun '23

This tests that the resolution should be quick enough to not trigger an Unreal Engine race condition. This also checks the determinism of the media source presentation descriptor stream ordering, as well as the stream selection updates when the media source is started. -- v2: mf/tests: Test media source presentation stream descriptor update. winegstreamer: Keep a reference on the media source start descriptor. mf/tests: Test media sources stream descriptors attributes. mf/tests: Test media sources with multiple audio/video streams. mf/tests: Test byte stream handler to media source resolution time. https://gitlab.winehq.org/wine/wine/-/merge_requests/2782

3 12

[PATCH v2 0/5] MR3004: mf/session: Pull more samples from upstream if MFT has pending requests.
by Rémi Bernon (＠rbernon) 20 Jun '23

20 Jun '23

This will be required for MFT decoder transforms to work. They don't usually produce an output sample on every pushed input sample, and the session may need to request more sample from upstream and push them into the transform or it will not get any output and get stuck. -- v2: mf/session: Request more data from upstream when requests are still pending. mf/session: Process pending transform nodes samples in a loop. mf/session: Move transform node ProcessInput calls to a separate helper. mf/session: Use helpers to push and pop samples for transform streams. mf/session: Use local variables to access transform node streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/3004

2 7

[PATCH 0/1] MR3114: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt.
by Zhao Yi (＠Zhaoyi) 20 Jun '23

20 Jun '23

Add a check condition for whether the type is slLink. Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

2 1

[PATCH v9 0/1] MR2413: comctl32/listview: Reset the value of bNoItemMetrics in LISTVIEW_DeleteAllItems().
by Zhao Yi (＠Zhaoyi) 20 Jun '23

20 Jun '23

Reset the valuse of bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems() to Fix "2345 picture viewer" not displaying all files. Signed-off-by: Zhao Yi <zhaoyi(a)uniontech.com> -- v9: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt. https://gitlab.winehq.org/wine/wine/-/merge_requests/2413

2 2

[PATCH v7 0/2] MR2413: comctl32: Fix the problem that listview cannot display all files.
by Zhao Yi (＠Zhaoyi) 20 Jun '23

20 Jun '23

Log: The flag that bNoItemMetrics should be reset to TRUE after calling LISTVIEW_DeleteAllItems(). Signed-off-by: Zhao Yi <zhaoyi(a)uniontech.com> -- v7: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt. https://gitlab.winehq.org/wine/wine/-/merge_requests/2413

3 3

[PATCH 0/3] MR3113: comctl32/listview: Reset the value of bNoItemMetrics in LISTVIEW_DeleteAllItems().
by Zhao Yi (＠Zhaoyi) 20 Jun '23

20 Jun '23

Reset the valuse of bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems() to Fix "2345 picture viewer" not displaying all files. Signed-off-by: Zhao Yi <zhaoyi(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3113

3 4

Re: [PATCH v6 0/1] MR2413: comctl32: Fix the problem that listview cannot display all files.
by Zhao Yi (＠Zhaoyi) 20 Jun '23

20 Jun '23

update commit message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2413#note_36214

1 0

Re: [PATCH v5 0/2] MR3074: Move getpeername() implementation to wineserver
by Damjan Jovanovic (＠dj) 20 Jun '23

20 Jun '23

Would this also help bug 47560, where on Windows getpeername() succeeds on a non-blocking TCP socket between connect() and actually connecting, but fails on Linux with ENOTCONN? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3074#note_36211

1 0

[PATCH 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Damjan Jovanovic (＠dj) 20 Jun '23

20 Jun '23

Java (1.3 at least) calls ChoosePixelFormat() with the PFD_SUPPORT_GDI flag set and expects the returned PIXELFORMATDESCRIPTOR to have that flag set. If it doesn't, an exception is thrown and it fails to initialize graphics. If no PIXELFORMATDESCRIPTOR is returned instead, it falls back to an alternative rendering method and proceeds further. Therefore, when the PFD_SUPPORT_GDI flag is specified, treat it as a mandatory requirement, and only return a PIXELFORMATDESCRIPTOR on which it is set, if any. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=7767 Closes #7767 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111

2 2

[PATCH 0/1] MR3110: crypt32: Don't export CRYPT_CopyReversed.
by Alex Henrie (＠alexhenrie) 20 Jun '23

20 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3110

2 1

[PATCH 0/1] MR3108: ws2_32: Don't export num_startup.
by Alex Henrie (＠alexhenrie) 20 Jun '23

20 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3108

2 1

[PATCH 0/1] MR239: vkd3d-shader/codegen: Skip register allocation for unused object variables.
by Nikolay Sivov (＠nsivov) 20 Jun '23

20 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/239

4 4

[PATCH v4 0/1] MR3007: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker (＠bernhardu) 19 Jun '23

19 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: (d4a7440a) - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: (6a69c680) - Fix typo in commit message. - Modified format strings. - v5: (47784feb) - Move test to own test function. - Move check to wine_server_add_data. -- v4: ntdll: Avoid requests with null pointer but invalid size. https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

3 3

Re: [PATCH v2 0/3] MR3101: winegstreamer: Remove callback from wg_allocator and lazily allocate unix memory. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3101

1 0

Re: [PATCH v2 0/1] MR3102: winegstreamer: Remove colorimetry and chroma-site from wg_format caps. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3102

1 0

Re: [PATCH v3 0/5] MR3066: uiautomationcore: Initial patches for serverside event support. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3066

1 0

Re: [PATCH v2 0/1] MR3093: gdiplus: Allow NULL format in GdipAddPathString - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3093

1 0

Re: [PATCH v2 0/1] MR3084: advpack: Check the return value of adv_install in DoInfInstallW (scan-build). - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3084

1 0

Re: [PATCH v2 0/1] MR3086: conhost: Use correct pointer type in edit_line_transpose_words (scan-build). - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3086

1 0

Re: [PATCH v3 0/1] MR3095: ntoskrnl.exe: Add Ke386QueryIoAccessMap stub. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3095

1 0

Re: [PATCH v2 0/1] MR3087: wininet: Don't overallocate in urlcache_encode_url_alloc (scan-build). - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3087

1 0

Re: [PATCH v2 0/1] MR3088: urlmon: Don't export urlmon_instance. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3088

1 0

Re: [PATCH v3 0/4] MR3090: wine{alsa,coreaudio,oss,pulse}: Move stream_release into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3090

1 0

Re: [PATCH v3 0/1] MR3089: hhctrl: Initialize item->items to NULL in parse_index_sitemap_object (scan-build). - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3089

1 0

Re: [PATCH v2 0/1] MR3083: comctl32: Remove duplicate declarations of MONTHCAL functions. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3083

1 0

Re: [PATCH v2 0/1] MR3081: comdlg32: Don't use GetProcAddress for SHSimpleIDListFromPath. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3081

1 0

Re: [PATCH v2 0/1] MR3079: gdiplus: Refactor and add comments for easier understanding - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3079

1 0

Re: [PATCH v2 0/1] MR3092: include: Add flags in D3D11_RESOURCE_MISC_FLAG. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3092

1 0

Re: [PATCH v3 0/2] MR3077: atl: Convert REG_DWORD to a correct type. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3077

1 0

Re: [PATCH v2 0/1] MR3082: combase: Don't export hProxyDll or rpc_execute_call. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3082

1 0

Re: [PATCH v2 0/1] MR3080: xaudio2/tests: Fix the IID_IXAudio28 declaration. - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3080

1 0

Re: [PATCH v2 0/1] MR238: vkd3d-shader/spirv: Take ownership of the shader signatures in spirv_compiler_create(). - approved
by Alexandre Julliard (＠julliard) 19 Jun '23

19 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/238

1 0

[PATCH 0/3] MR3101: winegstreamer: Remove callback from wg_allocator and lazily allocate unix memory.
by Rémi Bernon (＠rbernon) 19 Jun '23

19 Jun '23

Allocating large amount of unix memory for not using them when we write directly to the client sample is costly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3101

3 4

[PATCH 0/1] MR3102: winegstreamer: Remove colorimetry and chroma-site from wg_format caps.
by Rémi Bernon (＠rbernon) 19 Jun '23

19 Jun '23

They are set by default and will force color conversions we may not want in the wg_transform videoconvert. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3102

3 2

[PATCH v2 0/5] MR3066: uiautomationcore: Initial patches for serverside event support.
by Connor McAdams (＠cmcadams) 19 Jun '23

19 Jun '23

-- v2: uiautomationcore: Implement UiaEventAddWindow. uiautomationcore: Add support for advising providers of events on serverside events. uiautomationcore: Prevent creation of duplicate serverside events. uiautomationcore: Add support for creating serverside events. uiautomationcore/tests: Add tests for cross-process events. https://gitlab.winehq.org/wine/wine/-/merge_requests/3066

3 9

[PATCH 0/1] MR3104: win32u: Add DriverVersion string for GPUs to registry
by Michael Skorokhodov (＠Samsuper) 19 Jun '23

19 Jun '23

Some applications (e.g. UE4) requires the DriverVersion string in the registry. The string is taken from `dlls/wbemprox/builtin.c` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3104

2 1

[PATCH 0/1] MR3097: sane: Fix use after free in create_item (scan-build).
by Alex Henrie (＠alexhenrie) 19 Jun '23

19 Jun '23

realloc may free lead_static. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3097

3 2

[PATCH 0/1] MR3093: gdiplus: Allow NULL format in GdipAddPathString
by David Kahurani (＠kahurani) 19 Jun '23

19 Jun '23

GdipAddPathString accepts NULL for format and presumably uses the default format for formating Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3093

3 2

[PATCH v3 0/4] MR3073: Implement FileDispositionInformationEx and FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE
by Joel Holdsworth (＠jhol) 19 Jun '23

19 Jun '23

This MR supercedes !1895 as a solution to bug [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771). Rather than fixing the problem of Wine's inability to modify the attributes of read-only files, this patch set instead implements `FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE` which the Msys2 and Cygwin runtime libriries can use to avoid needing to modify attributes. -- v3: ntdll: Implemented FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE ntdll/tests: Added tests for FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE ntdll: Initial implementation of FileDispositionInformationEx include: Defined FILE_DISPOSITION_INFORMATION_EX and friends https://gitlab.winehq.org/wine/wine/-/merge_requests/3073

3 5

[PATCH v2 0/5] MR3100: winegstreamer: More media source cleanup.
by Rémi Bernon (＠rbernon) 19 Jun '23

19 Jun '23

-- v2: winegstreamer: Lookup stream handler result using a dedicated helper. winegstreamer: Rename winegstreamer_stream_handler to stream_handler. winegstreamer: Create and destroy result entries using dedicated helpers. winegstreamer: Lookup stream descriptors before starting streams. winegstreamer: Keep a reference on the media source start descriptor. https://gitlab.winehq.org/wine/wine/-/merge_requests/3100

2 6

[PATCH v7 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 19 Jun '23

19 Jun '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v7: comdlg32: Enable visual styles when showing IFileDialog. comdlg32: Return E_UNEXPECTED if IFileDialog is already shown https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

2 2

[PATCH v6 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 19 Jun '23

19 Jun '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v6: comdlg32: Enable visual styles when showing IFileDialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

4 5

[PATCH v5 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 19 Jun '23

19 Jun '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v5: comdlg32: Enable visual styles when showing IFileDialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

4 8

[PATCH v2 0/1] MR3095: ntoskrnl.exe: Implement a minimal Ke386QueryIoAccessMap() stub.
by Olivier F. R. Dierick (＠olivierfrdierick) 19 Jun '23

19 Jun '23

Simply print a FIXME, instead of triggering the display of a terminal window to show 'call to unimplemented function' debugging info. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54380 -- v2: ntoskrnl.exe: Add Ke386QueryIoAccessMap stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/3095

2 2

[PATCH 0/1] MR238: vkd3d-shader/spirv: Take ownership of the shader signatures in spirv_compiler_create().
by Conor McCarthy (＠cmccarthy) 19 Jun '23

19 Jun '23

Fixes leakage of the replacement elements in shader_signature_merge(). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/238

4 3

[PATCH v6 0/3] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) 19 Jun '23

19 Jun '23

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.26, the last non-reforged release), and is consistent with the standard 32bit build. But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code. -- v6: Fixup: assert struct sizes with bool/enum Fixup: designated initializers winegstreamer: Implement Wow64 entrypoints in the Unix library. https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

3 4

[PATCH 0/1] MR3087: wininet: Don't overallocate in urlcache_encode_url_alloc (scan-build).
by Alex Henrie (＠alexhenrie) 19 Jun '23

19 Jun '23

The URL is encoded in UTF-8, not UTF-16. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3087

3 2

[PATCH 0/1] MR3088: urlmon: Don't export urlmon_instance.
by Alex Henrie (＠alexhenrie) 19 Jun '23

19 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3088

3 2

[PATCH 0/5] MR3100: winegstreamer: More media source cleanup.
by Rémi Bernon (＠rbernon) 19 Jun '23

19 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3100

2 5

[PATCH v2 0/1] MR3096: ntdll: Add NtGetNextProcess stub.
by Alex Henrie (＠alexhenrie) 19 Jun '23

19 Jun '23

The stub is enough for TokenViewer.exe to start up and display its user interface. Based on a patch by Nikolay Sivov. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45119 -- v2: ntdll: Add NtGetNextProcess stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/3096

3 4

[PATCH 0/1] MR3095: ntoskrnl.exe: Implement a minimal Ke386QueryIoAccessMap() stub.
by Olivier F. R. Dierick (＠olivierfrdierick) 19 Jun '23

19 Jun '23

Simply print a FIXME, instead of triggering the display of a terminal window to show 'call to unimplemented function' debugging info. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54380 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3095

3 4

[PATCH 0/1] MR3096: ntdll: Add NtGetNextProcess stub.
by Alex Henrie (＠alexhenrie) 19 Jun '23

19 Jun '23

The stub is enough for TokenViewer.exe to start up and display its user interface. Based on a patch by Nikolay Sivov. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45119 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3096

4 3

[PATCH v21 0/6] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 18 Jun '23

18 Jun '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v21: winesni.drv: add dbus watch instead of using plain unix fds and flush https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 6

[PATCH 0/1] MR240: vkd3d-shader: Add constant folding for the 'dot' operation.
by Nikolay Sivov (＠nsivov) 18 Jun '23

18 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/240

2 1

[PATCH v20 0/6] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 18 Jun '23

18 Jun '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v20: winesni.drv: add dbus watch instead of using plain unix fds and flush https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 6

[PATCH v19 0/6] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 18 Jun '23

18 Jun '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v19: winesni.drv: add dbus watch instead of using plain unix fds and flush https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 7

[PATCH v2 0/4] MR3090: wine{alsa,coreaudio,oss,pulse}: Move stream_release into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 18 Jun '23

18 Jun '23

-- v2: wineoss: Use mmdevapi's stream_release. winecoreaudio: Use mmdevapi's stream_release. https://gitlab.winehq.org/wine/wine/-/merge_requests/3090

3 5

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 18 Jun '23

18 Jun '23

On Fri Jun 16 17:31:25 2023 +0000, Zebediah Figura wrote: > Do we need to bother with the client thread here? (Could we potentially > make the client socket nonblocking instead?) No; making the client socket nonblocking with `ioctlsocket()` causes it to instantly return with `WSAEWOULDBLOCK`. [Microsoft's documentation](https://learn.microsoft.com/en-us/windows/win32/winsock/wind… notes: > It is normal for WSAEWOULDBLOCK to be reported as the result from calling connect on a nonblocking SOCK_STREAM socket, since some time must elapse for the connection to be established. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_36050

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 18 Jun '23

18 Jun '23

On Fri Jun 16 17:31:21 2023 +0000, Zebediah Figura wrote: > Can the length be less than the whole size of sun_path? As always we > should test for this. Windows 10 does not throw an error if the length is less than `sizeof(struct sockaddr_un)`; it successfully created a socket when I passed a length of `sizeof(addr.sun_family) + strlen(addr.sun_path) - 1` (minus), though the path was truncated by one character. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_36049

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 18 Jun '23

18 Jun '23

On Fri Jun 16 17:31:21 2023 +0000, Zebediah Figura wrote: > I don't think the {} construction is portable. We have offsetof() for > this anyway. It's portable for C99 if I hadn't forgotten to include the `0` (and C23 as-is), but Wine does use C89. I'll replace it with an `offsetof()`. It's worth noting that this entire initializer is only portable for C99 due to the use of designators. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_36048

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 18 Jun '23

18 Jun '23

On Fri Jun 16 17:31:27 2023 +0000, Zebediah Figura wrote: > Similarly this isn't going to work without converting from Unix to win32 paths. In addition to the size mismatch issue, if the conversion must be lossless, it's not practical to provide a Windows path for a Unix one, since relativity, UNC prefixes, etc. would probably change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_36047

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 18 Jun '23

18 Jun '23

On Fri Jun 16 17:31:20 2023 +0000, Zebediah Figura wrote: > This can't work, though; we need to convert it to Unix first. (Or print > a FIXME and fail for DGRAM sockets.) > Linux man-pages call out returning sizeof(sockaddr_un) as okay on Linux, > but is it portable? We may want to return strlen()+1 just to be safe. Converting the path cannot realistically be done due to size differences for the same path: ``` $ echo -n 'C:\tmp\foo.sock' | wc -c 15 $ winepath 'C:\tmp\foo.sock' | tr -d '\n' | wc -c 47 ``` For the same reason as needing to change directories to actually bind and connect, path translation in these functions and their server equivalents is not feasible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_36046

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 18 Jun '23

18 Jun '23

On Fri Jun 16 17:31:23 2023 +0000, Zebediah Figura wrote: > We shouldn't need this anymore now that we're pssing the real unix path, right? This is still needed because we need to change directories to the Unix path. We can't use the provided Unix path directly because the Unix path length can be larger than the Windows path due to the wineprefix, and that length may exceed `sizeof(sun_path)` even if the Windows path length does not. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_36045

1 0

[PATCH v2 0/1] MR3089: hhctrl: Initialize item->items to NULL in parse_index_sitemap_object (scan-build).
by Alex Henrie (＠alexhenrie) 18 Jun '23

18 Jun '23

Initializing to NULL makes it more clear that the initial value is only used as a parameter to realloc. -- v2: hhctrl: Initialize item->items to NULL in parse_index_sitemap_object (scan-build). https://gitlab.winehq.org/wine/wine/-/merge_requests/3089

3 2

[PATCH 0/1] MR3089: hhctrl: Simplify allocation size in parse_index_sitemap_object (scan-build).
by Alex Henrie (＠alexhenrie) 18 Jun '23

18 Jun '23

sizeof(IndexSubItem) is more clear than 2 * sizeof(void *) and it avoids any questions about struct padding. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3089

3 5

[PATCH v18 0/5] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 17 Jun '23

17 Jun '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v18: winesni.drv: replaced the dbus connection logic with a single connection per each SNI object winesni.drv: wrap functions with pthread mutex locking winesni.drv: implement basic balloon notification support explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 5

[PATCH 0/1] MR3083: comctl32: Remove duplicate declarations of MONTHCAL functions.
by Alex Henrie (＠alexhenrie) 17 Jun '23

17 Jun '23

MONTHCAL_MonthLength and MONTHCAL_CalculateDayOfWeek are already declared in dlls/comctl32/comctl32.h. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3083

4 3

[PATCH v5 0/3] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) 17 Jun '23

17 Jun '23

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.26, the last non-reforged release), and is consistent with the standard 32bit build. But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code. -- v5: Fixup: assert struct sizes with bool/enum Fixup: designated initializers winegstreamer: Implement Wow64 entrypoints in the Unix library. https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

2 4

[PATCH v4 0/1] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) 17 Jun '23

17 Jun '23

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.24, the last non-reforged release), and is consistent with the standard 32bit build. But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code. -- v4: winegstreamer: Implement Wow64 entrypoints in the Unix library. https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

4 6

[PATCH v4 0/10] MR2993: comdlg32: IFileDialog navigation bar control. Part 1.
by Vladislav Timonin (＠vt) 17 Jun '23

17 Jun '23

Redo of !1857, as suggested, the plan is to split original MR in half, breadcrumbs in first (this) MR, and address edit in another. The changes are mostly cleanup (formatting, renaming, unused variables, missing free). Visually, it hasn't changed from original MR, part 1 changes are: ![](/uploads/42fa717ce6f7adb40d6b0dcbbe0878fa/changes-1-3.png) And part 2: ![](/uploads/cbdaa2d4b5b8945587e1f761a4609a08/changes-2.png) Part 2 branch can be found [here](https://gitlab.winehq.org/vt/wine/-/commits/fd-navbar-part2). Requires !2068, otherwise if application doesn't request comctl v6 (e.g. qapitrace), navigation bar will look like this: ![no-comctl-v6](/uploads/03e6a8b6dcf827114157e79640e49fea/no-comctl-v6.png) Closes: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=54812 - https://bugs.winehq.org/show_bug.cgi?id=50338 (partially? fully with address edit?) MR changes: - v2 - Changed the gap between buttons to be scaled with DPI - v3 - DPI scale the gap in layout calculation in breadcrumbs commit missed it earlier - remove padding from layout calculation `GetWindowRect` was unintentionally returning double padding, 4px from `hspacing` in `itemdlg.c:update_layout`, and another 4px from somewhere else - drop `comdlg32: Keep IExplorerBrowser in IFileDialog focused after Backspace.` hack - retain IExplorerBrowser view focus in IFileDialog when creating new view - redirect navigation bar buttons focus back to the previous window Description edits: - v2 - Updated the changes image (by splitting it) - Added MR changes - v3 - Added description edits - Updated the changes image again (forgot the overflow button change) -- v4: comdlg32: Avoid taking focus on LMB click in IFileDialog navigation bar buttons. comdlg32: Add tab navigation to IFileDialog navigation bar. comdlg32: Retain IExplorerBrowser view focus in IFileDialog when creating new view. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add inner border to breadcrumbs in IFileDialog navigation bar. comdlg32: Always show at least 2 crumbs in IFileDialog navigation bar. comdlg32: Reuse address breadcrumbs in IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/2993

3 14

[PATCH v2 0/1] MR2348: comdlg32: Add parent dir button to "Item" file dialog.
by Florian Will (＠w-flo) 17 Jun '23

17 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=29912 Now it looks like this (this patch adds the separator & "up" button): ![Bildschirmfoto_vom_2023-03-08_13-34-36](/uploads/cd30de5b3fa5f39accb4dd14a3f54421/Bildschirmfoto_vom_2023-03-08_13-34-36.png) -- v2: comdlg32: Add parent dir button to "Item" file dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/2348

2 5

[PATCH 0/1] MR3081: comdlg32: Don't use GetProcAddress for SHSimpleIDListFromPath.
by Alex Henrie (＠alexhenrie) 17 Jun '23

17 Jun '23

The function is exported by name from shell32 and declared in a public header. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3081

4 3

[PATCH 0/1] MR3079: gdiplus: Refactor and add comments for easier understanding
by Fabian Maurer (＠DarkShadow44) 17 Jun '23

17 Jun '23

Hopefully useful for people like me who had a hard time understanding what was going on. Especially with the rearranged divison and the simplification I had a hard time seeing why that does what it does Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3079

3 2

[PATCH 0/1] MR3092: include: Add flags in D3D11_RESOURCE_MISC_FLAG.
by Andrey Gusev (＠agusev) 17 Jun '23

17 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3092

2 1

[PATCH 0/4] MR3090: wine{alsa,coreaudio,oss,pulse}: Move stream_release into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 17 Jun '23

17 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3090

3 5

[PATCH v2 0/2] MR3077: atl: Convert REG_DWORD to a correct type.
by Jactry Zeng (＠jactry) 17 Jun '23

17 Jun '23

-- v2: atl: Convert REG_DWORD to a correct type. atl/tests: Move regular DWORD tests into a loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3077

2 2

[PATCH 0/1] MR3082: combase: Don't export hProxyDll or rpc_execute_call.
by Alex Henrie (＠alexhenrie) 17 Jun '23

17 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3082

3 2

[PATCH 0/1] MR3080: xaudio2/tests: Fix the IID_IXAudio28 declaration.
by Zebediah Figura (＠zfigura) 17 Jun '23

17 Jun '23

This was accidentally copied from the 2.9 version instead in 14c44d0b0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3080

3 2

2025

2024

2023

2022

wine-gitlab