- wine-gitlab - winehq.org

Re: [PATCH v3 0/6] MR2949: winegstreamer: Refactor media source stream creation. - approved
by Alexandre Julliard (＠julliard) 16 Jun '23

16 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2949

1 0

Re: [PATCH v2 0/1] MR3054: msi: Fix memory leaks in HANDLE_CustomType23 (scan-build). - approved
by Alexandre Julliard (＠julliard) 16 Jun '23

16 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3054

1 0

Re: [PATCH v2 0/1] MR3041: winhttp: Fix memory leak on error path in request_get_codepage (scan-build). - approved
by Alexandre Julliard (＠julliard) 16 Jun '23

16 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3041

1 0

Re: [PATCH v2 0/1] MR3037: msi: Fix double free on error paths in TransformView_Create (scan-build). - approved
by Alexandre Julliard (＠julliard) 16 Jun '23

16 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3037

1 0

Re: [PATCH v2 0/1] MR3036: msi: Fix memory leak on error path in MSI_OpenPackageW (scan-build). - approved
by Alexandre Julliard (＠julliard) 16 Jun '23

16 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3036

1 0

Re: [PATCH v4 0/1] MR3013: wusa: Zero out identity on error path in read_identity. - approved
by Alexandre Julliard (＠julliard) 16 Jun '23

16 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3013

1 0

Re: [PATCH v4 0/5] MR3062: wine{alsa,coreaudio,oss,pulse}: Move get_application_name into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 16 Jun '23

16 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3062

1 0

Re: [PATCH v3 0/1] MR3011: wldap32: Clean up LDAP_OPT_API_INFO. - approved
by Alexandre Julliard (＠julliard) 16 Jun '23

16 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3011

1 0

[PATCH 0/5] MR3066: uiautomationcore: Initial patches for serverside event support.
by Connor McAdams (＠cmcadams) 16 Jun '23

16 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3066

3 9

[PATCH 0/1] MR3077: atl: Convert REG_DWORD to a correct type.
by Jactry Zeng (＠jactry) 16 Jun '23

16 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3077

3 2

[PATCH v6 0/9] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu (＠insn) 16 Jun '23

16 Jun '23

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- v6: jscript: Store ref to the function code instead of the function instance jscript: Start from the last argument when adding them to named locals. jscript: Store detached locals into a scope's specialized buffer. jscript: Detach the frame's scope before inserting eval() variables into it. jscript: Don't use iface_to_jsdisp where it's not necessary to grab it. jscript: Get rid of jsobj in scope_chain_t. jscript: Fix function leak in scope_init_locals. jscript: Fix addressing invalid memory if ref is an argument. jscript: Correctly implement context for indirect eval calls in ES5+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

3 10

[PATCH v3 0/4] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Gabriel Ivăncescu (＠insn) 16 Jun '23

16 Jun '23

When we are clipping (due to fullscreen), certain operations are bugged (such as creating another window on top, grabbing the window during a size-move operation, changing mouse capture, etc) so we must temporarily unclip first. Seems unclipping it temporarily during such operation is enough to fix this. This probably wasn't very obvious in practice because most times "fullscreen" means a single non-resizeable window with no menus and so on (e.g. fullscreen games), but that's not always the case. -- v3: win32u: Don't clip while capturing mouse pointer. winex11: Ungrab clipping window when capturing mouse pointer. winex11: Don't clip while doing move/resize dragging. winex11: Don't clip while creating X Window. https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

3 13

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about dlls/ntdll/unix/socket.c: > } > #endif > > + case AF_UNIX: > + { > + struct WS_sockaddr_un win = {0}; > + > + if (wsaddrlen < sizeof(win)) return -1; > + win.sun_family = WS_AF_UNIX; > + memcpy( win.sun_path, uaddr->un.sun_path, sizeof(win.sun_path) ); > + memcpy( wsaddr, &win, sizeof(win) ); > + return sizeof(win); Similarly this isn't going to work without converting from Unix to win32 paths. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35928

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/sock.c: > + ok(!memcmp((char[108]){0}, outAddr.sun_path, sizeof(addr.sun_path)), > + "getsockname returned incorrect path '%s' for provided path '%s'\n", > + outAddr.sun_path, > + addr.sun_path); > + > + memset(&outAddr, 0, sizeof(outAddr)); > + ret = getsockname(server, (SOCKADDR *)&outAddr, &(int){sizeof(outAddr)}); > + ok(!ret, "Could not get info on Unix socket: %lu\n", GetLastError()); > + ok(!memcmp(addr.sun_path, outAddr.sun_path, sizeof(addr.sun_path)), > + "getsockname returned incorrect path '%s' for provided path '%s'\n", > + outAddr.sun_path, > + addr.sun_path); > + > + memset(&outAddr, 0, sizeof(outAddr)); > + ret = getpeername(listener, (SOCKADDR *)&outAddr, &(int){sizeof(outAddr)}); > + ok(ret == -1, "Got info on Unix socket: %lu\n", GetLastError()); If we're testing that something returns an error we should test the value of GetLastError() as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35927

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/sock.c: > + > + client = socket(AF_UNIX, SOCK_STREAM, 0); > + ok(client != INVALID_SOCKET, "Failed to create second Unix socket: %lu\n", > + GetLastError()); > + > + clientThread = CreateThread(NULL, 0, test_afunix_client_connect_thread, > + &(struct afunix_thread_param){ client, addr }, 0, NULL); > + ok(clientThread != NULL, "CreateThread failed unexpectedly: %ld\n", GetLastError()); > + server = accept(listener, NULL, NULL); > + ok(server != INVALID_SOCKET, "Could not accept Unix socket connection: %lu\n", > + GetLastError()); > + > + WaitForSingleObject(clientThread, 1000); > + > + memset(&outAddr, 0, sizeof(outAddr)); > + ret = getsockname(listener, (SOCKADDR *)&outAddr, &(int){sizeof(outAddr)}); Here and elsewhere, we should actually test the returned length. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35926

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/sock.c: > + ok(listener != INVALID_SOCKET, "Could not create Unix socket: %lu\n", > + GetLastError()); > + > + ret = bind(listener, (SOCKADDR *)&addr, sizeof(SOCKADDR_UN)); > + ok(!ret, "Could not bind Unix socket: %lu\n", GetLastError()); > + > + ret = listen(listener, 1); > + ok(!ret, "Could not listen on Unix socket: %lu\n", GetLastError()); > + > + client = socket(AF_UNIX, SOCK_STREAM, 0); > + ok(client != INVALID_SOCKET, "Failed to create second Unix socket: %lu\n", > + GetLastError()); > + > + clientThread = CreateThread(NULL, 0, test_afunix_client_connect_thread, > + &(struct afunix_thread_param){ client, addr }, 0, NULL); > + ok(clientThread != NULL, "CreateThread failed unexpectedly: %ld\n", GetLastError()); Do we need to bother with the client thread here? (Could we potentially make the client socket nonblocking instead?) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35924

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/sock.c: > + > + ret = listen(listener, 1); > + ok(!ret, "Could not listen on Unix socket: %lu\n", GetLastError()); > + > + client = socket(AF_UNIX, SOCK_STREAM, 0); > + ok(client != INVALID_SOCKET, "Failed to create second Unix socket: %lu\n", > + GetLastError()); > + > + clientThread = CreateThread(NULL, 0, test_afunix_client_connect_thread, > + &(struct afunix_thread_param){ client, addr }, 0, NULL); > + ok(clientThread != NULL, "CreateThread failed unexpectedly: %ld\n", GetLastError()); > + server = accept(listener, NULL, NULL); > + ok(server != INVALID_SOCKET, "Could not accept Unix socket connection: %lu\n", > + GetLastError()); > + > + WaitForSingleObject(clientThread, 1000); If you're going to use a thread you should check this return value; if it fails then that means we have a bug in the implementation. We're also missing a CloseHandle(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35925

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about server/sock.c: > { > const struct afd_connect_params *params = get_req_data(); > const struct WS_sockaddr *addr; > - union unix_sockaddr unix_addr; > + union unix_sockaddr unix_addr, win_addr; This win_addr variable looks unused? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35922

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about server/sock.c: > } > unix_len = sizeof(unix_addr); > if (!getsockname( acceptfd, &unix_addr.addr, &unix_len )) > - acceptsock->addr_len = sockaddr_from_unix( &unix_addr, &acceptsock->addr.addr, sizeof(acceptsock->addr) ); > + { > + unix_len = sizeof(unix_addr); This second assignment to "unix_len" looks unused? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35923

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about server/sock.c: > if (unix_addr.addr.sa_family == AF_INET && !memcmp( &unix_addr.in.sin_addr, magic_loopback_addr, 4 )) > unix_addr.in.sin_addr.s_addr = htonl( INADDR_LOOPBACK ); > > + if (sock->family == WS_AF_UNIX && *((char *)(params + 1) + params->addr_len)) > + { > + char *unix_path = (char *)(params + 1) + params->addr_len; > + char unix_path_copy[PATH_MAX]; > + strcpy(unix_path_copy, unix_path); > + if (chdir( dirname( unix_path_copy ) ) == -1) > + { > + set_error( sock_get_ntstatus( errno ) ); > + return; > + } > + memcpy( unix_addr.un.sun_path, basename( unix_path ), sizeof(unix_addr.un.sun_path) ); We shouldn't need this anymore now that we're pssing the real unix path, right? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35921

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about dlls/ws2_32/socket.c: > > if (!(sync_event = get_sync_event())) return -1; > > - params = malloc( sizeof(int) + len ); > - ret_addr = malloc( len ); > + if (addr->sa_family == AF_UNIX && *addr->sa_data) Accessing sa_data in this way is convenient, but looks wrong. I'd rather just see the cast to sockaddr_un written out anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35919

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about dlls/ws2_32/socket.c: > > free( params ); > free( ret_addr ); > + if (unix_path) > + free( unix_path ); You can skip the if here; free() does it for you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35920

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about dlls/ntdll/unix/socket.c: > break; > } > > + if (unix_addr.addr.sa_family == AF_UNIX) > + { > + status = STATUS_NOT_SUPPORTED; We should print a FIXME here as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35916

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about dlls/ws2_32/socket.c: > .dwMessageSize = UINT_MAX, > .szProtocol = L"SPX II", > }, > + { > + .dwServiceFlags1 = XP1_GUARANTEED_DELIVERY | XP1_GUARANTEED_ORDER | XP1_IFS_HANDLES, > + .dwProviderFlags = PFL_MATCHES_PROTOCOL_ZERO, > + .ProviderId = {0xa00943d9, 0x9c2e, 0x4633, {0x9b, 0x59, 0x00, 0x57, 0xa3, 0x16, 0x09, 0x94}}, > + .dwCatalogEntryId = 1007, > + .ProtocolChain.ChainLen = 1, > + .iVersion = 2, > + .iAddressFamily = AF_UNIX, > + .iMaxSockAddr = sizeof(struct sockaddr_un), > + .iMinSockAddr = sizeof(struct sockaddr_un) - sizeof((struct sockaddr_un){}.sun_path), I don't think the {} construction is portable. We have offsetof() for this anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35917

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about dlls/ws2_32/socket.c: > } > break; > > + case AF_UNIX: > + if (len < sizeof(struct sockaddr_un)) > + { > + SetLastError( WSAEFAULT ); > + return -1; > + } > + break; Can the length be less than the whole size of sun_path? As always we should test for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35918

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about dlls/ntdll/unix/socket.c: > return sizeof(uaddr->in6); > } > > + case WS_AF_UNIX: > + { > + struct WS_sockaddr_un win = {0}; > + > + if (wsaddrlen < sizeof(win)) return 0; > + memcpy( &win, wsaddr, sizeof(win) ); > + uaddr->un.sun_family = AF_UNIX; > + memcpy( uaddr->un.sun_path, win.sun_path, sizeof(win.sun_path) ); > + return sizeof(uaddr->un); This can't work, though; we need to convert it to Unix first. (Or print a FIXME and fail for DGRAM sockets.) Linux man-pages call out returning sizeof(sockaddr_un) as okay on Linux, but is it portable? We may want to return strlen()+1 just to be safe. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35915

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 16 Jun '23

16 Jun '23

Zebediah Figura (@zfigura) commented about server/sock.c: > if (unix_addr.addr.sa_family == AF_INET && !memcmp( &unix_addr.in.sin_addr, magic_loopback_addr, 4 )) > unix_addr.in.sin_addr.s_addr = htonl( INADDR_LOOPBACK ); > > + if (sock->family == WS_AF_UNIX && *((char *)(params + 1) + params->addr_len)) I'd prefer "(char *)addr" instead of "(char *)(params + 1)". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35905

1 0

[PATCH v5 0/10] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu (＠insn) 16 Jun '23

16 Jun '23

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- v5: jscript: Store ref to the function code instead of the function instance jscript: Start from the last argument when adding them to named locals. jscript: Store detached locals into a scope's specialized buffer. jscript: Detach the frame's scope before inserting eval() variables into it. jscript: Use the scope's dispex as the default variable obj. jscript: Don't use iface_to_jsdisp where it's not necessary to grab it. jscript: Get rid of jsobj in scope_chain_t. jscript: Fix function leak in scope_init_locals. jscript: Fix addressing invalid memory if ref is an argument. jscript: Correctly implement context for indirect eval calls in ES5+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

3 15

[PATCH 0/1] MR3078: winevulkan: Update to VK spec version 1.3.254.
by Georg Lehmann (＠DadSchoorse) 16 Jun '23

16 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3078

2 1

[PATCH v2 0/6] MR2949: winegstreamer: Refactor media source stream creation.
by Rémi Bernon (＠rbernon) 16 Jun '23

16 Jun '23

-- v2: winegstreamer: Pass the stream descriptor to media_stream_create. winegstreamer: Introduce new init_audio_media_types helper. winegstreamer: Introduce new init_video_media_types helper. winegstreamer: Factor the creation of the first stream media type. winegstreamer: Pass a struct wg_parser_stream to media_stream_create. winegstreamer: Introduce new stream_descriptor_set_tag helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/2949

3 8

[PATCH 0/8] MR3048: Media.speech improvements.
by eric pouech (＠epo) 16 Jun '23

16 Jun '23

This series adds a couple of features to WinRT's media.speech: - IVoiceInformation, and synthetizer's options are present (mainly use to store information, not yet to make fully use of it) - add a dummy implementation (1 single voice); that should be extended in future series by using ISpVoice instead - add a couple of more tests to go with implementation (the serie should prevent MS Flight simulator to crash on first connection. Crash is due to exception handling of C# generated exceptions from E_NOTIMPL with some X11 related critical resources). A+ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3048

4 38

[PATCH v7 0/4] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 16 Jun '23

16 Jun '23

-- v7: vkd3d-shader/tpf: Add support for writing 'resinfo' instruction. vkd3d-shader/tpf: Add support for writing 'sampleinfo' instruction. vkd3d-shader/hlsl: Parse GetDimensions() method. tests: Add some tests for GetDimensions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

2 5

[PATCH 0/1] MR3054: msi: Fix memory leaks in HANDLE_CustomType23 (scan-build).
by Alex Henrie (＠alexhenrie) 16 Jun '23

16 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3054

3 2

[PATCH 0/1] MR3041: winhttp: Fix memory leak on error path in request_get_codepage (scan-build).
by Alex Henrie (＠alexhenrie) 16 Jun '23

16 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3041

3 2

[PATCH 0/1] MR3037: msi: Fix double free on error paths in TransformView_Create (scan-build).
by Alex Henrie (＠alexhenrie) 16 Jun '23

16 Jun '23

If TransformView_Create returns an error, it should not return a pointer that table_load_transform will try to free. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3037

3 2

[PATCH 0/1] MR3036: msi: Fix memory leak on error path in MSI_OpenPackageW (scan-build).
by Alex Henrie (＠alexhenrie) 16 Jun '23

16 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3036

3 2

[PATCH v3 0/1] MR3013: wusa: Fix double free on error path in read_components (scan-build).
by Alex Henrie (＠alexhenrie) 16 Jun '23

16 Jun '23

If read_identity returns FALSE, it has already called clear_identity. This is the same problem as in merge request !2970. Unfortunately I did not notice at first that the problem was present in two places. -- v3: wusa: Zero out identity on error path in read_identity. https://gitlab.winehq.org/wine/wine/-/merge_requests/3013

3 3

[PATCH v3 0/5] MR3062: wine{alsa,coreaudio,oss,pulse}: Move get_application_name into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 16 Jun '23

16 Jun '23

-- v3: wineoss: Call mmdevapi's get_application_name. winecoreaudio: Call mmdevapi's get_application_name. winealsa: Call mmdevapi's get_application_name. winepulse: Move get_application_name into mmdevapi. winepulse: Move AudioClient's Initialize's exclusive mode check into unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/3062

3 7

[PATCH 0/3] MR3076: win32u: Use a specific flag instead of shrinking the clip rect.
by Rémi Bernon (＠rbernon) 16 Jun '23

16 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55047 Shrinking the clipping rect to make sure we do not ignore the grab causes some issues. Instead, pass the set_cursor flags to the WM_WINE_CLIPCURSOR message, and introduce a new fullscreen window clipping flag. As described in the WineHQ bug, an alternative fix would be to keep the shrink but disable fullscreen grabs entirely when the option is disabled [*]. This would break the tests when the option is on but it is not the default. I think that this approach with a flag is better as it doesn't modify the clipping rect. [*] I don't think they are doing anything but I'm maybe missing something. Maybe grabbing the cursor over the entire virtual screen is preventing the cursor from going over host dock bars or something like that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3076

2 3

[PATCH v2 0/1] MR3011: wldap32: Clean up LDAP_OPT_API_INFO.
by Alex Henrie (＠alexhenrie) 16 Jun '23

16 Jun '23

Fix memory leaks on error paths, don't call memset unnecessarily, and ensure that all output fields are initialized. -- v2: wldap32: Clean up LDAP_OPT_API_INFO. https://gitlab.winehq.org/wine/wine/-/merge_requests/3011

3 4

[PATCH v2 0/5] MR3062: wine{alsa,coreaudio,oss,pulse}: Move get_application_name into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 16 Jun '23

16 Jun '23

-- v2: wineoss: Call mmdevapi's get_application_name. winecoreaudio: Call mmdevapi's get_application_name. winealsa: Call mmdevapi's get_application_name. winepulse: Move get_application_name into mmdevapi. winepulse: Move AudioClient's Initialize's exclusive mode check into unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/3062

3 10

[PATCH v2 0/1] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) 16 Jun '23

16 Jun '23

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.24, the last non-reforged release), and is consistent with the standard 32bit build. But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code. -- v2: winegstreamer: Implement Wow64 entrypoints in the Unix library. https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

3 3

[PATCH 0/1] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) 16 Jun '23

16 Jun '23

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.24, the last non-reforged release), and is consistent with the standard 32bit build. But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

3 2

Re: [PATCH v2 0/1] MR3072: winex11: Replace the clipping message HWND with a BOOL flag. - approved
by Alexandre Julliard (＠julliard) 15 Jun '23

15 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3072

1 0

Re: [PATCH v2 0/2] MR3071: winex11: Fix and simplify virtual desktop grabs and retries. - approved
by Alexandre Julliard (＠julliard) 15 Jun '23

15 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3071

1 0

Re: [PATCH v2 0/2] MR3070: win32u: Fix the DF_WINE_CREATE_DESKTOP desktop flag usage. - approved
by Alexandre Julliard (＠julliard) 15 Jun '23

15 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3070

1 0

Re: [PATCH v2 0/1] MR3069: wininet: Free temporary buffer in InternetQueryOptionW loop. - approved
by Alexandre Julliard (＠julliard) 15 Jun '23

15 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3069

1 0

Re: [PATCH v3 0/1] MR3060: mmdevapi: Don't redefine stream_handle (gcc 4.3) - approved
by Alexandre Julliard (＠julliard) 15 Jun '23

15 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3060

1 0

Re: [PATCH v2 0/1] MR2995: rpcrt4: Don't use GetProcAddress for ole32 functions. - approved
by Alexandre Julliard (＠julliard) 15 Jun '23

15 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2995

1 0

Re: [PATCH v2 0/1] MR3063: winegstreamer: Implement Flush for WMV decoder DMO. - approved
by Alexandre Julliard (＠julliard) 15 Jun '23

15 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3063

1 0

[PATCH v5 0/6] MR2698: winex11: Avoid breaking XIM XFilterEvent / XmbLookupString sequence.
by Rémi Bernon (＠rbernon) 15 Jun '23

15 Jun '23

-- v5: winex11: Report empty preedit string when result string is committed. winex11: Avoid breaking XIM sequence when merging mouse motion events. winex11: Avoid breaking XIM sequence when merging ConfigureNotify events. winex11: Introduce new handle_delayed_event helper. winex11: Move call_event_handler function around. winex11: Remove unnecessary process_events helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/2698

3 9

Re: [PATCH v7 0/2] MR2958: mf: Various refcount leak fixes for session. - approved
by Alexandre Julliard (＠julliard) 15 Jun '23

15 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2958

1 0

[PATCH v3 0/2] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 15 Jun '23

15 Jun '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v3: ws2_32/tests: Remove todo_wine from now-successful tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

2 2

[PATCH v9 0/10] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon (＠rbernon) 15 Jun '23

15 Jun '23

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v9: ntdll: Avoid writing to invalid memory in i386 unix dispatcher. ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Avoid marking freed block header as undefined for valgrind. ntdll: Force HEAP_TAIL_CHECKING_ENABLED flag with valgrind. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. ntdll: Maintain a PE module link map and expose it to GDB. ntdll: Pass a UNICODE_STRING to load_builtin and virtual_map_image. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

3 11

[PATCH v24 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 15 Jun '23

15 Jun '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v24: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

2 7

[PATCH v23 0/56] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 15 Jun '23

15 Jun '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v23: kernel32/tests: Extend console inheritance tests. shell32: Don't show size for inaccessible drives in My Computer. shell32: Show >4GB values in size columns of My Computer. win32u: Remove duplicated d3dkmdt.h include. user32: Remove no longer used setupapi import. winex11: Set the window cursor immediately in SetCursor. wineandroid: Set the window cursor immediately in SetCursor. win32u: Notify drivers of cursor changes on WM_WINE_SETCURSOR. win32u: Add a hwnd parameter to SetCursor driver entry points. server: Introduce and send new WM_WINE_SETCURSOR hardware message. server: Keep track of the current desktop cursor handle. server: Update desktop cursor window when cursor pos changes. ntdll: Make only the necessary pages writable in the ARM64EC code map. ntdll: Load modules with a high base address in high memory. ntdll: Allocate 64-bit and kernel stacks in high memory. ntdll: Support the lower memory limit in MEM_ADDRESS_REQUIREMENTS. server: Also enforce the size of varargs data structures. kernel32/tests: Fix the PROCESS_BASIC_INFORMATION exit status type. wineoss: Implement main_loop in unixlib. winecoreaudio: Implement main_loop in unixlib. winealsa: Implement main_loop in unixlib. winepulse: Move main loop logic into mmdevapi. uiautomationcore: Unconditionally match all events registered on the desktop node with a scope of subtree. uiautomationcore: Implement UiaRaiseAutomationEvent. uiautomationcore: Add support for cloning UiaCondition structures. uiautomationcore: Clone UiaCacheRequest structure passed to UiaAddEvent. uiautomationcore: Store all events in an event list. wineps.drv: Use afm FamilyName instead of FullName. win32u: Cleanup naming and log messages for QueryDisplayConfig. win32u: Move QueryDisplayConfig from user32. win32u: Move fullscreen window cursor clipping from winex11. winex11: Move clip_fullscreen_window foreground check inside it. win32u: Add a clipping_cursor member to user_thread_info. win32u: Add a clipping_reset member to user_thread_info. win32u: Move grab_pointer registry option from winex11. winex11: Remove now unnecessary WM_X11DRV_CLIP_CURSOR_NOTIFY. imm32: Avoid resizing IMCC to zero-size buffer. winepulse: Return E_NOTIMPL when the property is not found. winepulse: Don't overwrite the result in the insufficient buffer case. wow64: Don't force wow64 dlls to load at low addresses. winegcc: Fix an uninitialized variable warning in the PE build. loader: Make the loader position-independent on 64-bit. makefiles: Define WINE_UNIX_LIB for all files that are built for Unix. include: Remove redundant __WINE_USE_MSVCRT checks. windows.media.speech: Fix memory leak on error path in session_worker_thread_cb (scan-build). server: Use hardware message category when checking filter. server: Pass the message code to get_hardware_msg_bit. user32: Add GetSystemDpiForProcess export. ntdll: Allow RtlAllocateHeap to crash with invalid handle. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

1 0

[PATCH v2 0/4] MR3073: Draft: Implement FileDispositionInformationEx and FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE
by Joel Holdsworth (＠jhol) 15 Jun '23

15 Jun '23

This MR supercedes !1895 as a solution to bug [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771). Rather than fixing the problem of Wine's inability to modify the attributes of read-only files, this patch set instead implements `FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE` which the Msys2 and Cygwin runtime libriries can use to avoid needing to modify attributes. -- v2: ntdll: Implemented FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE ntdll/tests: Added tests for FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE https://gitlab.winehq.org/wine/wine/-/merge_requests/3073

2 5

[PATCH 0/4] MR3073: Draft: Implement FileDispositionInformationEx and FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE
by Joel Holdsworth (＠jhol) 15 Jun '23

15 Jun '23

This MR supercedes !1895 as a solution to bug [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771). Rather than fixing the problem of Wine's inability to modify the attributes of read-only files, this patch set instead implements `FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE` which the Msys2 and Cygwin runtime libriries can use to avoid needing to modify attributes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3073

3 5

[PATCH v2 0/1] MR3060: mmdevapi: Don't redefine stream_handle (gcc 4.3)
by Fabian Maurer (＠DarkShadow44) 15 Jun '23

15 Jun '23

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v2: mmdevapi: Don't redefine stream_handle (gcc 4.3) https://gitlab.winehq.org/wine/wine/-/merge_requests/3060

4 4

[PATCH v4 0/6] MR2698: winex11: Avoid breaking XIM XFilterEvent / XmbLookupString sequence.
by Rémi Bernon (＠rbernon) 15 Jun '23

15 Jun '23

-- v4: winex11: Report empty preedit string when result string is committed. winex11: Avoid breaking XIM sequence when merging mouse motion events. winex11: Avoid breaking XIM sequence when merging ConfigureNotify events. winex11: Introduce new handle_delayed_event helper. winex11: Move call_event_handler function around. winex11: Remove unnecessary process_events helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/2698

3 8

[PATCH v3 0/5] MR2698: winex11: Avoid breaking XIM XFilterEvent / XmbLookupString sequence.
by Rémi Bernon (＠rbernon) 15 Jun '23

15 Jun '23

-- v3: winex11: Make sure HIMC is opened before sending IME updates. winex11: Avoid breaking XIM XFilterEvent / XmbLookupString sequence. winex11: Call (get|free)_event_data within call_event_handler. winex11: Stop merging MotionNotify events. winex11: Stop merging RawMotion events. https://gitlab.winehq.org/wine/wine/-/merge_requests/2698

4 17

[PATCH 0/1] MR3069: wininet: Free temporary buffer in InternetQueryOptionW loop.
by Daniel Lehman (＠dlehman25) 15 Jun '23

15 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3069

3 2

[PATCH 0/1] MR3072: winex11: Replace the clipping message HWND with a BOOL flag.
by Rémi Bernon (＠rbernon) 15 Jun '23

15 Jun '23

We don't need the window anymore, it was only used to send ClipCursor notifications. This improves cursor clipping performance a lot as it avoids re-creating a window every time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3072

3 2

[PATCH 0/2] MR3071: winex11: Fix and simplify virtual desktop grabs and retries.
by Rémi Bernon (＠rbernon) 15 Jun '23

15 Jun '23

Reverting things a bit to how it was before the move to win32u, and avoid modifying the Win32 clipping rect when handling host-specific events like keyboard grabs. This temporarily releases the winex11 cursor grabs, while keeping the Win32 state unchanged and unnotified, and restores the state later when either keyboard is ungrabbed or the virtual desktop window is focused again. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55046 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3071

2 2

[PATCH 0/2] MR3070: win32u: Fix the DF_WINE_CREATE_DESKTOP desktop flag usage.
by Rémi Bernon (＠rbernon) 15 Jun '23

15 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3070

2 2

[PATCH 0/5] MR3062: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 15 Jun '23

15 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3062

3 6

[PATCH 0/1] MR234: vkd3d-shader/hlsl: Partially implement Load() for the Buffer object.
by Nikolay Sivov (＠nsivov) 15 Jun '23

15 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/234

5 8

[PATCH 0/1] MR3063: winegstreamer: Implement Flush for WMV decoder DMO.
by Ziqing Hui (＠zhui) 14 Jun '23

14 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3063

5 4

[PATCH v17 0/5] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 14 Jun '23

14 Jun '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v17: winesni.drv: replaced the dbus connection logic with a single connection per each SNI object winesni.drv: wrap functions with pthread mutex locking winesni.drv: implement basic balloon notification support explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 6

[PATCH v6 0/2] MR2958: mf: Various refcount leak fixes for session.
by Bernhard Kölbl (＠besentv) 14 Jun '23

14 Jun '23

-- v6: mf: Don't leak sink in session_get_renderer_node_service(). mf: Clear queued topologies on session shutdown. https://gitlab.winehq.org/wine/wine/-/merge_requests/2958

3 5

Re: [PATCH v3 0/1] MR3065: commdlg: Fix dialog template parser when caption starts with a DBCS character. - approved
by Alexandre Julliard (＠julliard) 14 Jun '23

14 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3065

1 0

Re: [PATCH v2 0/1] MR3039: shell32: Fix memory leak on error path in FolderItems_Constructor (scan-build). - approved
by Alexandre Julliard (＠julliard) 14 Jun '23

14 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3039

1 0

Re: [PATCH v2 0/1] MR3064: scrrun/dictionary: Compare key values in addition to their hashes. - approved
by Alexandre Julliard (＠julliard) 14 Jun '23

14 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3064

1 0

Re: [PATCH v3 0/4] MR3052: sapi: Finish implementing basic functionality for SpMMAudioOut. - approved
by Alexandre Julliard (＠julliard) 14 Jun '23

14 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3052

1 0

[PATCH v2 0/2] MR3053: opengl32: Do not expose ARB_buffer_storage on wow64.
by Zebediah Figura (＠zfigura) 14 Jun '23

14 Jun '23

We don't properly support persistent mapping, so don't pretend to support ARB_buffer_storage. -- v2: opengl32: Do not report a GL version higher than 4.3 on wow64. opengl32: Do not expose ARB_buffer_storage on wow64. https://gitlab.winehq.org/wine/wine/-/merge_requests/3053

4 5

[PATCH v5 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 14 Jun '23

14 Jun '23

The test has a little inspiration from the SDK samples. -- v5: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

4 10

[PATCH v3 0/2] MR3061: libs/jxr: Compile with ansi flag to avoid typedef redefinitions (gcc 4.3)
by Fabian Maurer (＠DarkShadow44) 14 Jun '23

14 Jun '23

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v3: wmphoto: Define ansi flag for JXRGlue to avoid typedef redefinitions (gcc 4.3) libs/jxr: Compile with ansi flag to avoid typedef redefinitions (gcc 4.3) https://gitlab.winehq.org/wine/wine/-/merge_requests/3061

3 5

[PATCH v4 0/5] MR2958: mf: Various refcount leak fixes for session.
by Bernhard Kölbl (＠besentv) 14 Jun '23

14 Jun '23

-- v4: mf: Don't shutdown sink activation objects in the media session. mf: Don't make stream sink shutdown dependent on IMFActivate presence in node. mf: Don't leak sink in session_get_renderer_node_service(). mf: Clear queued topologies on session shutdown. mf/tests: Add tests for samplegrabber shutdown state. https://gitlab.winehq.org/wine/wine/-/merge_requests/2958

4 11

[PATCH 0/1] MR3039: shell32: Fix memory leak on error path in FolderItems_Constructor (scan-build).
by Alex Henrie (＠alexhenrie) 14 Jun '23

14 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3039

4 3

[PATCH v2 0/8] MR3050: msvcrt: Switch to using snames for create_locinfo.
by Victor Hermann Chiletto (＠vitorhnn) 14 Jun '23

14 Jun '23

This MR attempts to bring Wine's handling of `setlocale` and `_create_locale` more in line with the behavior of native >= `msvcr110`. It does this by replacing the usage of the LCID based `GetLocaleInfo` with the sname based `GetLocaleInfoEx`. `GetLocaleInfo` doesn't support neutral locales, even on native, which causes problems with neutral Chinese locales like `zh-Hans` and `zh-Hant`. It also improves the accuracy of the internal `__lc_locale_name_func`, as tests indicate that it returns `LOCALE_SNAME`s instead of ISO 639 language names. Potential future improvements: * Modifying the generation of the `pclmap` and `pcumap` fields of `threadlocaleinfostruct` to work on WCHARs. * I've done some changes to `__thread_data` which make it not fully match native, I'll submit a follow up which fixes this. -- v2: msvcrt: Skip exhaustive locale search with valid snames. make_unicode: rename Hong Kong SAR China to Hong Kong SAR to match native behavior. msvcrt: Remap synonyms to snames. msvcrt: Use snames instead of LCIDs in create_locinfo. msvcrt: Convert locale_to_LCID to snames. msvcrt: Use GetLocaleInfoEx to compare locale info. msvcr120/tests: Check ___lc_locale_name_func with neutral Chinese locales. msvcr110/tests: Add tests for new behaviors with Chinese locales. https://gitlab.winehq.org/wine/wine/-/merge_requests/3050

3 16

[PATCH 0/1] MR3060: mmdevapi: Don't redefine stream_handle (gcc 4.3)
by Fabian Maurer (＠DarkShadow44) 14 Jun '23

14 Jun '23

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3060

3 2

[PATCH v2 0/4] MR3052: sapi: Finish implementing basic functionality for SpMMAudioOut.
by Shaun Ren (＠shaunren) 14 Jun '23

14 Jun '23

-- v2: sapi: Implement ISpMMSysAudio::EventHandle. sapi: Implement ISpMMSysAudio::Write. sapi: Free completed buffers asynchronously in SpMMAudio. https://gitlab.winehq.org/wine/wine/-/merge_requests/3052

3 6

[PATCH v16 0/4] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 14 Jun '23

14 Jun '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v16: winesni.drv: wrap functions with pthread mutex locking winesni.drv: implement basic balloon notification support explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 5

[PATCH 0/1] MR3064: scrrun/dictionary: Compare key values in addition to their hashes.
by Nikolay Sivov (＠nsivov) 14 Jun '23

14 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3064

2 1

[PATCH v15 0/4] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 13 Jun '23

13 Jun '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v15: winesni.drv: wrap functions with pthread mutex locking winesni.drv: implement basic balloon notification support explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 5

[PATCH v3 0/2] MR2740: winemenubuilder: Create .desktop files for programs that open URIs
by Alex Henrie (＠alexhenrie) 13 Jun '23

13 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=22904 -- v3: winecfg: Mention protocol associations. winemenubuilder: Create .desktop files for programs that open URIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2740

4 11

[PATCH v2 0/2] MR3061: libs/jxr: Compile with ansi flag to avoid typedef redefinitions (gcc 4.3)
by Fabian Maurer (＠DarkShadow44) 13 Jun '23

13 Jun '23

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v2: wmphoto: Define ansi flag for JXRGlue to avoid typedef redefinitions (gcc 4.3) https://gitlab.winehq.org/wine/wine/-/merge_requests/3061

2 2

Re: [PATCH v3 0/1] MR3057: kernel32/tests: Extend console inheritance tests. - approved
by Alexandre Julliard (＠julliard) 13 Jun '23

13 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3057

1 0

Re: [PATCH v2 0/2] MR3046: shell32: Show >4GB values in size columns of My Computer. - approved
by Alexandre Julliard (＠julliard) 13 Jun '23

13 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3046

1 0

Re: [PATCH v2 0/2] MR3056: user32: Remove no longer used setupapi import. - approved
by Alexandre Julliard (＠julliard) 13 Jun '23

13 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3056

1 0

Re: [PATCH v2 0/7] MR3055: win32u: Use a hardware message to notify user driver of cursor handle and window changes. - approved
by Alexandre Julliard (＠julliard) 13 Jun '23

13 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3055

1 0

Re: [PATCH v7 0/4] MR3027: wine{alsa,coreaudio,oss,pulse}: Implement main loop logic in mmdevapi. - approved
by Alexandre Julliard (＠julliard) 13 Jun '23

13 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027

1 0

[PATCH 0/2] MR3061: libs/jxr: Compile with ansi flag to avoid typedef redefinitions (gcc 4.3)
by Fabian Maurer (＠DarkShadow44) 13 Jun '23

13 Jun '23

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3061

3 3

[PATCH v3 0/11] MR2993: comdlg32: IFileDialog navigation bar control. Part 1.
by Vladislav Timonin (＠vt) 13 Jun '23

13 Jun '23

Redo of !1857, as suggested, the plan is to split original MR in half, breadcrumbs in first (this) MR, and address edit in another. The changes are mostly cleanup (formatting, renaming, unused variables, missing free). Visually, it hasn't changed from original MR, part 1 changes are: ![](/uploads/42fa717ce6f7adb40d6b0dcbbe0878fa/changes-1-3.png) And part 2: ![](/uploads/cbdaa2d4b5b8945587e1f761a4609a08/changes-2.png) Part 2 branch can be found [here](https://gitlab.winehq.org/vt/wine/-/commits/fd-navbar-part2). Requires !2068, otherwise if application doesn't request comctl v6 (e.g. qapitrace), navigation bar will look like this: ![no-comctl-v6](/uploads/03e6a8b6dcf827114157e79640e49fea/no-comctl-v6.png) Closes: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=54812 - https://bugs.winehq.org/show_bug.cgi?id=50338 (partially? fully with address edit?) MR changes: - v2 - Changed the gap between buttons to be scaled with DPI Description edits: - v2 - Updated the changes image (by splitting it) - Added MR changes - v3 - Added description edits - Updated the changes image again (forgot the overflow button change) -- v3: comdlg32: Redirect IFileDialog navigation bar buttons focus back to the previous window. comdlg32: Retain IExplorerBrowser view focus in IFileDialog when creating new view. comdlg32: Prevent arrow navigation of IFileDialog navigation bar buttons. comdlg32: Don't paint focus rect in IFileDialog navigation bar buttons. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add inner border to breadcrumbs in IFileDialog navigation bar. comdlg32: Always show at least 2 crumbs in IFileDialog navigation bar. comdlg32: Reuse address breadcrumbs in IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/2993

3 17

[PATCH v8 0/5] MR211: vkd3d-shader/hlsl: Support clip() intrinsic.
by Nikolay Sivov (＠nsivov) 13 Jun '23

13 Jun '23

-- v8: vkd3d-shader/hlsl: Handle 'texkill' jump type. vkd3d-shader/hlsl: Parse clip() function. tests: Add some tests for clip(). vkd3d-shader: Make some helpers available from hlsl.c. vkd3d-shader/hlsl: Add a parameter for jump nodes and use it for 'discard'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211

3 8

[PATCH 0/1] MR3038: ntdll: Fix memory leak on file not found in NtQuery(Full)AttributesFile (scan-build).
by Alex Henrie (＠alexhenrie) 13 Jun '23

13 Jun '23

nt_to_unix_file_name doesn't really consider STATUS_NO_SUCH_FILE to be an error, and it's not the only error that that function can return. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3038

3 3

[PATCH v2 0/1] MR3057: kernel32/tests: Extend console inheritance tests.
by eric pouech (＠epo) 13 Jun '23

13 Jun '23

- defining what the std handles are before inheriting them - checking access to parent console from child through std handles Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: kernel32/tests: Extend console inheritance tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3057

3 4

[PATCH 0/1] MR3057: kernel32/tests: Extend console inheritance tests.
by eric pouech (＠epo) 13 Jun '23

13 Jun '23

- defining what the std handles are before inheriting them - checking access to parent console from child through std handles Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3057

3 2

[PATCH 0/1] MR3022: kernelbase: In AllocConsole(), dispose existing unix console.
by eric pouech (＠epo) 13 Jun '23

13 Jun '23

Unix consoles (created from initial process) are inherited by child processes for various reasons, like keeping std handles bound to that unix console. This differs from Windows as the default for a GUI is not to have console attached. If a GUI programs asks for a console, it will succeed on Windows but fail under Wine as the Unix console is still present. So, allow AllocConsole() to succeed when called from a GUI program and tied to a Unix console. (don't do it for CUI as they are already attached to a console). This fixes Scrap Mechanic when run with '-dev' option. (based on suggestion from Zhiyi Zhang) Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3022

4 7

[PATCH v4 0/8] MR216: vkd3d: Prepare for tiled resource support.
by Conor McCarthy (＠cmccarthy) 13 Jun '23

13 Jun '23

-- v4: vkd3d: Append CopyTileMappings() commands to the command queue op array. vkd3d: Append UpdateTileMappings() commands to the command queue op array. vkd3d: Add missing const attributes to ID3D12CommandQueue::UpdateTileMappings() parameters. vkd3d: Validate plane count for tiled textures. vkd3d: Validate tiled resources tier for 3D textures. vkd3d: Validate tiled resources support during reserved resource creation. vkd3d: Always pass null heap properties to vkd3d_create_image() for sparse images. vkd3d: Check sparse image format is supported. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/216

3 14

2025

2024

2023

2022

wine-gitlab