- wine-gitlab - winehq.org

[PATCH v6 0/4] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 13 Jun '23

13 Jun '23

-- v6: vkd3d-shader/tpf: Add support for writing 'resinfo' instruction. vkd3d-shader/tpf: Add support for writing 'sampleinfo' instruction. vkd3d-shader/hlsl: Parse GetDimensions() method. tests: Add some tests for GetDimensions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

2 4

[PATCH 0/2] MR3056: user32: Remove no longer used setupapi import.
by Jacek Caban (＠jacek) 13 Jun '23

13 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3056

2 2

[PATCH v3 0/5] MR230: hlsl: Replace bare list pointers with hlsl_block, part 1.
by Zebediah Figura (＠zfigura) 13 Jun '23

13 Jun '23

This introduces temporary helpers block_to_list and list_to_block. The job of block_to_list(), at least, could be done by simply writing "&block->instrs" everywhere instead. Using the helper instead ensures that all of these instances will eventually be converted. -- v3: vkd3d-shader/hlsl: Store the fields of struct parse_if_body as hlsl_block pointers. vkd3d-shader/hlsl: Store the "instrs" field of struct parse_initializer as a hlsl_block pointer. vkd3d-shader/hlsl: Merge the "discard_statement" rule into "jump_statement". vkd3d-shader/hlsl: Use add_unary_arithmetic_expr() in the subtraction rule. vkd3d-shader/hlsl: Factor out add_binary_expr_merge(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/230

3 7

[PATCH 0/7] MR3055: win32u: Use a hardware message to notify user driver of cursor handle and window changes.
by Rémi Bernon (＠rbernon) 13 Jun '23

13 Jun '23

Instead of synchronizing the cursor in winex11 whenever the mouse moves. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3055

3 8

[PATCH 0/1] MR3051: imm32: When IME composition is done, send WM_IME_COMPOSITION for the...
by Masahito Suzuki (＠firelzrd) 13 Jun '23

13 Jun '23

imm32: When IME composition is done, send WM_IME_COMPOSITION for the composition text before sending it for the result text -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3051

3 5

[PATCH v6 0/4] MR3027: wine{alsa,coreaudio,oss,pulse}: Implement main loop logic in mmdevapi.
by Davide Beatrici (＠davidebeatrici) 13 Jun '23

13 Jun '23

-- v6: wineoss: Implement main_loop in unixlib. winecoreaudio: Implement main_loop in unixlib. winealsa: Implement main_loop in unixlib. winepulse: Move main loop logic into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/3027

4 13

[PATCH 0/1] MR3035: mmdevapi: Fix "use-before-init" in set_driver_prop_value.
by Torge Matthies (＠tmatthies) 13 Jun '23

13 Jun '23

Signed-off-by: Torge Matthies <tmatthies(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3035

4 7

Re: [PATCH v2 0/2] MR3045: winepulse: get_prop_value fixes.
by Davide Beatrici (＠davidebeatrici) 13 Jun '23

13 Jun '23

On Tue Jun 13 06:50:51 2023 +0000, Huw Davies wrote: > > @huw How did you spot the issue? > See !3035 Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3045#note_35580

1 0

Re: [PATCH v2 0/2] MR3045: winepulse: get_prop_value fixes.
by Huw Davies (＠huw) 13 Jun '23

13 Jun '23

> @huw How did you spot the issue? See !3035 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3045#note_35576

1 0

[PATCH 0/4] MR3052: sapi: Finish implementing basic functionality for SpMMAudioOut.
by Shaun Ren (＠shaunren) 13 Jun '23

13 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3052

3 7

[PATCH 0/2] MR3053: opengl32: Do not expose ARB_buffer_storage on wow64.
by Zebediah Figura (＠zfigura) 12 Jun '23

12 Jun '23

We don't properly support persistent mapping, so don't pretend to support ARB_buffer_storage. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3053

2 2

[PATCH v2 0/1] MR3049: user32: Ignore invalid parameters in DrawTextEx when HDC is invalid
by Fabian Maurer (＠DarkShadow44) 12 Jun '23

12 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47089 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v2: user32: Ignore invalid parameters in DrawTextEx when HDC is invalid https://gitlab.winehq.org/wine/wine/-/merge_requests/3049

3 3

Re: [PATCH v2 0/2] MR3045: winepulse: get_prop_value fixes.
by Davide Beatrici (＠davidebeatrici) 12 Jun '23

12 Jun '23

For reference, this was part of !658. @huw How did you spot the issue? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3045#note_35545

1 0

Re: [PATCH v6 0/5] MR2988: uiautomationcore: Add support for raising in-process events. - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2988

1 0

Re: [PATCH v3 0/1] MR3032: wineps.drv: Use afm FamilyName instead of FullName - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3032

1 0

Re: [PATCH v8 0/2] MR2957: win32u: Move QueryDisplayConfig from user32. - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2957

1 0

Re: [PATCH v3 0/6] MR3021: win32u: Move ClipCursor logic out of winex11. - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3021

1 0

Re: [PATCH v2 0/1] MR3044: imm32: Avoid resizing IMCC to zero-size buffer. - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3044

1 0

Re: [PATCH v2 0/2] MR3045: winepulse: get_prop_value fixes. - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3045

1 0

Re: [PATCH v3 0/1] MR3042: windows.media.speech: Fix memory leak on error path in session_worker_thread_cb (scan-build). - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3042

1 0

Re: [PATCH v2 0/2] MR3043: server: Fix hardware message filter check for non-mouse messages. - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3043

1 0

Re: [PATCH v2 0/1] MR3031: user32: Add GetSystemDpiForProcess export. - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3031

1 0

Re: [PATCH v4 0/1] MR3030: ntdll: Allow RtlAllocateHeap to crash with invalid handle - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030

1 0

Re: [PATCH v2 0/1] MR231: vkd3d-shader/spirv: Retrieve input sysvals from the signature for geometry shaders as well. - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/231

1 0

Re: [PATCH v2 0/3] MR228: vkd3d-shader: Handle static constants in array size expressions. - approved
by Alexandre Julliard (＠julliard) 12 Jun '23

12 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/228

1 0

[PATCH 0/8] MR3050: msvcrt: Switch to using snames for create_locinfo.
by Victor Hermann Chiletto (＠vitorhnn) 12 Jun '23

12 Jun '23

This MR attempts to bring Wine's handling of `setlocale` and `_create_locale` more in line with the behavior of native >= `msvcr110`. It does this by replacing the usage of the LCID based `GetLocaleInfo` with the sname based `GetLocaleInfoEx`. `GetLocaleInfo` doesn't support neutral locales, even on native, which causes problems with neutral Chinese locales like `zh-Hans` and `zh-Hant`. It also improves the accuracy of the internal `__lc_locale_name_func`, as tests indicate that it returns `LOCALE_SNAME`s instead of ISO 639 language names. Potential future improvements: * Modifying the generation of the `pclmap` and `pcumap` fields of `threadlocaleinfostruct` to work on WCHARs. * I've done some changes to `__thread_data` which make it not fully match native, I'll submit a follow up which fixes this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3050

3 9

[PATCH 0/1] MR3049: user32: Ignore invalid parameters in DrawTextEx when HDC is invalid
by Fabian Maurer (＠DarkShadow44) 12 Jun '23

12 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47089 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3049

3 2

[PATCH 0/2] MR3045: winepulse: get_prop_value fixes.
by Huw Davies (＠huw) 12 Jun '23

12 Jun '23

Fixes regressions caused by 13fa7a57df0d. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3045

3 3

[PATCH 0/1] MR3040: services: Fix use after free on error path in service_start (scan-build).
by Alex Henrie (＠alexhenrie) 12 Jun '23

12 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3040

3 4

[PATCH v3 0/9] MR209: vkd3d-shader/hlsl: Broaden resources support v2, part 3.
by Francisco Casas (＠fcasas) 12 Jun '23

12 Jun '23

Mainly promoting single object components to variables for SM 5.0's RDEF block and lowering combined samplers to separate sampler+texture objects for SM 4. Following patches (including prepending uniform copies resource components within struct parameters) in: https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6c -- v3: vkd3d-shader/hlsl: Don't allocate all texture registers for synthetic separated samplers. vkd3d-shader/hlsl: Lower combined samplers to separate sampler and texture objects for SM4. vkd3d-shader/hlsl: Separate tracking of sampler_dim and usage for object components. vkd3d-shader/hlsl: Introduce hlsl_new_synthetic_var_named(). vkd3d-shader/hlsl: Check is_uniform instead of HLSL_STORAGE_UNIFORM when validating object refs. tests: Add lowering combined samplers tests. vkd3d-shader/hlsl: Handle resource components individually for SM 5.0. vkd3d-shader/tpf: Introduce struct extern_resource. vkd3d-shader/hlsl: Allow derefs to provide the data_type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/209

5 17

[PATCH 0/7] MR232: vkd3d-shader/hlsl: Fold a few missing constant operations.
by Giovanni Mascellani (＠giomasce) 12 Jun '23

12 Jun '23

Mostly a rage reaction to being fed up by warnings in logs. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/232

3 8

[PATCH v2 0/5] MR230: hlsl: Replace bare list pointers with hlsl_block, part 1.
by Zebediah Figura (＠zfigura) 12 Jun '23

12 Jun '23

This introduces temporary helpers block_to_list and list_to_block. The job of block_to_list(), at least, could be done by simply writing "&block->instrs" everywhere instead. Using the helper instead ensures that all of these instances will eventually be converted. -- v2: vkd3d-shader/hlsl: Store the fields of struct parse_if_body as hlsl_block pointers. vkd3d-shader/hlsl: Store the "instrs" field of struct parse_initializer as a hlsl_block pointer. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/230

2 6

[PATCH 0/5] MR230: hlsl: Replace bare list pointers with hlsl_block, part 1.
by Zebediah Figura (＠zfigura) 12 Jun '23

12 Jun '23

This introduces temporary helpers block_to_list and list_to_block. The job of block_to_list(), at least, could be done by simply writing "&block->instrs" everywhere instead. Using the helper instead ensures that all of these instances will eventually be converted. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/230

4 8

[PATCH v5 0/4] MR3027: wine{alsa,coreaudio,oss,pulse}: Implement main loop logic in mmdevapi.
by Davide Beatrici (＠davidebeatrici) 12 Jun '23

12 Jun '23

-- v5: wineoss: Implement main_loop in unixlib. winecoreaudio: Implement main_loop in unixlib. winealsa: Implement main_loop in unixlib. winepulse: Move main loop logic into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/3027

4 9

[PATCH v5 0/5] MR2988: uiautomationcore: Add support for raising in-process events.
by Connor McAdams (＠cmcadams) 12 Jun '23

12 Jun '23

-- v5: uiautomationcore: Unconditionally match all events registered on the desktop node with a scope of subtree. uiautomationcore: Implement UiaRaiseAutomationEvent. uiautomationcore: Add support for cloning UiaCondition structures. uiautomationcore: Clone UiaCacheRequest structure passed to UiaAddEvent. uiautomationcore: Store all events in an event list. https://gitlab.winehq.org/wine/wine/-/merge_requests/2988

3 6

[PATCH v3 0/5] MR2944: winewayland.drv: First window contents on screen
by Alexandros Frantzis (＠afrantzis) 12 Jun '23

12 Jun '23

The goal of this MR is to set up the minimum necessary infrastructure to display the contents of some simple, software rendered windows. This involves two major steps: 1. Associate a window with a Wayland surface and give it the `xdg_toplevel` role, so that the compositor can display it. We also have to implement the required initial `xdg_surface` configuration sequence to be able to safely (i.e., without the compositor disconnecting us with an error) attach buffers to the surface in step (2). 2. Implement the `window_surface` interface for the Wayland driver. For now we provide a simple (and suboptimal) `window_surface_flush` implementation: for each flush we create a new `wl_shm` buffer, copy the whole window contents (ignoring damaged bounds for now) into it and attach it to the target Wayland surface. In the next MR I will optimize this implementation in multiple ways: a. implement a buffer queue to avoid constantly allocating new buffers b. respect the damaged bounds of the `window_surface` to minimize copying of data from the `window_surface` to the SHM buffer (and also for correctness) c. communicate damaged surface regions to the compositor to (potentially) allow more efficient texture uploads. With this MR many (software-rendered) applications can now display dynamic content on screen. We can't interact with the apps yet, but we do get to enjoy `notepad` in all its blinking-cursor glory. Thanks! -- v3: winewayland.drv: Implement a simple window_surface flush. winewayland.drv: Introduce window_surface for Wayland. winewayland.drv: Ensure Wayland surface handlers don't access invalid data. winewayland.drv: Basic Wayland toplevel surface support. winewayland.drv: Introduce per-window driver data. https://gitlab.winehq.org/wine/wine/-/merge_requests/2944

3 23

[PATCH v4 0/8] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu (＠insn) 12 Jun '23

12 Jun '23

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- v4: jscript: Store ref to the function code instead of the function instance jscript: Start from the last argument when adding them to named locals. jscript: Always store the passed arguments into the argument obj, if not jscript: Don't use iface_to_jsdisp where it's not necessary to grab it. jscript: Get rid of jsobj in scope_chain_t. jscript: Move arguments_obj from the frame to the base scope. jscript: Fix addressing invalid memory if ref is an argument. jscript: Correctly implement context for indirect eval calls in ES5+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

3 11

[PATCH v3 0/5] MR2988: uiautomationcore: Add support for raising in-process events.
by Connor McAdams (＠cmcadams) 12 Jun '23

12 Jun '23

-- v3: uiautomationcore: Unconditionally match all events registered on the desktop node with a scope of subtree. uiautomationcore: Implement UiaRaiseAutomationEvent. uiautomationcore: Add support for cloning UiaCondition structures. uiautomationcore: Clone UiaCacheRequest structure passed to UiaAddEvent. uiautomationcore: Store all events in an event list. https://gitlab.winehq.org/wine/wine/-/merge_requests/2988

3 8

[PATCH v2 0/5] MR2988: uiautomationcore: Add support for raising in-process events.
by Connor McAdams (＠cmcadams) 12 Jun '23

12 Jun '23

-- v2: uiautomationcore: Unconditionally match all events registered on the desktop node with a scope of subtree. uiautomationcore: Implement UiaRaiseAutomationEvent. uiautomationcore: Add support for cloning UiaCondition structures. uiautomationcore: Clone UiaCacheRequest structure passed to UiaAddEvent. uiautomationcore: Store all events in an event list. https://gitlab.winehq.org/wine/wine/-/merge_requests/2988

3 11

[PATCH 0/1] MR231: vkd3d-shader/spirv: Retrieve input sysvals from the signature for geometry shaders as well.
by Zebediah Figura (＠zfigura) 12 Jun '23

12 Jun '23

This only affects clip and cull distances. The HLSL compiler emits these using dcl_input, but the previous shader (vertex or TES) will write them as a SPIRV builtin, and hence we want to read this as a SPIRV builtin as well. This fixes validation errors in Wine's test_clip_distance(). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/231

3 2

[PATCH 0/3] MR228: vkd3d-shader: Handle static constants in array size expressions.
by Nikolay Sivov (＠nsivov) 12 Jun '23

12 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/228

5 6

[PATCH v2 0/1] MR3032: wineps.drv: Use afm FamilyName instead of FullName
by Fabian Maurer (＠DarkShadow44) 12 Jun '23

12 Jun '23

Fixes a regression introduced by a6cb10bba2d05ceca6ba5b1411c450d38defdbb4 The old logic also used FamilyName, and some applications depend on that Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54993 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54980 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v2: wineps.drv: Use afm FamilyName instead of FullName https://gitlab.winehq.org/wine/wine/-/merge_requests/3032

4 4

[PATCH 0/2] MR3046: shell32: Show >4GB values in size columns of My Computer.
by Vladislav Timonin (＠vt) 12 Jun '23

12 Jun '23

As per title, the size columns in My Computer are not showing correct values. MR changes them as follows: ![](/uploads/055ff7ed1a4c95524ca108985acb4ee1/changes.png) The D: to H: here are card adapter drives and DVD drive. Turns out they shouldn't show any size at all, and were probably showing whatever uninitialized memory was in `ULARGE_INTEGER`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3046

2 2

[PATCH 0/1] MR3044: imm32: Avoid resizing IMCC to zero-size buffer.
by Rémi Bernon (＠rbernon) 12 Jun '23

12 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55027 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3044

3 2

[PATCH v2 0/1] MR3042: windows.media.speech: Fix memory leak on error path in session_worker_thread_cb (scan-build).
by Alex Henrie (＠alexhenrie) 12 Jun '23

12 Jun '23

-- v2: windows.media.speech: Fix memory leak on error path in session_worker_thread_cb (scan-build). https://gitlab.winehq.org/wine/wine/-/merge_requests/3042

3 2

[PATCH 0/2] MR3043: server: Fix hardware message filter check for non-mouse messages.
by Rémi Bernon (＠rbernon) 12 Jun '23

12 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3043

2 2

[PATCH 0/1] MR3042: windows.media.speech: Fix memory leak on error path in session_worker_thread_cb (scan-build).
by Alex Henrie (＠alexhenrie) 12 Jun '23

12 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3042

2 1

[PATCH 0/1] MR3032: wineps.drv: Use afm FamilyName instead of FullName
by Fabian Maurer (＠DarkShadow44) 11 Jun '23

11 Jun '23

Fixes a regression introduced by a6cb10bba2d05ceca6ba5b1411c450d38defdbb4 The old logic also used FamilyName, and some applications depend on that Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54993 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54980 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3032

3 2

[PATCH v7 0/2] MR2957: win32u: Move QueryDisplayConfig from user32.
by Tatsuyuki Ishi (＠ishitatsuyuki) 11 Jun '23

11 Jun '23

This allows access to the in-process cached monitor list and reduces the number of registry calls issued for QueryDisplayConfig (in case of no change) from `4 x monitors` to `1`. -- v7: win32u: Cleanup naming and log messages for QueryDisplayConfig. win32u: Move QueryDisplayConfig from user32. https://gitlab.winehq.org/wine/wine/-/merge_requests/2957

4 8

[PATCH 0/1] MR3031: user32: Add GetSystemDpiForProcess export.
by Etaash Mathamsetty (＠etaash.mathamsetty) 11 Jun '23

11 Jun '23

The JetBrains dotPeek installer calls this function through user32, instead of win32u. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3031

2 2

Re: [PATCH v3 0/1] MR3030: ntdll: Allow RtlAllocateHeap to crash with invalid handle - approved
by Rémi Bernon (＠rbernon) 11 Jun '23

11 Jun '23

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030

1 0

Re: [PATCH v3 0/1] MR3030: ntdll: Allow RtlAllocateHeap to crash with invalid handle
by Rémi Bernon (＠rbernon) 11 Jun '23

11 Jun '23

On Sun Jun 11 02:48:44 2023 +0000, Fabian Maurer wrote: > There is exception handling: > ``` > #include "wine/exception.h" > __TRY > { > } > __EXCEPT_PAGE_FAULT > { > } > __ENDTRY > ``` > Though maybe there is a reason that is not used in tests, maybe one of > the devs can chime in. It needs compiler support. I don't think you will be able to write a test for this easily, manually checking that it actually crashes on Windows is enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030#note_35373

1 0

Re: [PATCH v6 0/2] MR2957: win32u: Move QueryDisplayConfig from user32. - approved
by Rémi Bernon (＠rbernon) 11 Jun '23

11 Jun '23

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2957

1 0

[PATCH 0/1] MR3016: dbghelp: Fix memory leak on error path in pe_load_native_module (scan-build).
by Alex Henrie (＠alexhenrie) 11 Jun '23

11 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3016

3 4

[PATCH v4 0/2] MR2957: win32u: Move QueryDisplayConfig from user32.
by Tatsuyuki Ishi (＠ishitatsuyuki) 11 Jun '23

11 Jun '23

This allows access to the in-process cached monitor list and reduces the number of registry calls issued for QueryDisplayConfig (in case of no change) from `4 x monitors` to `1`. -- v4: win32u: Cleanup naming and log messages for QueryDisplayConfig. win32u: Move QueryDisplayConfig from user32. https://gitlab.winehq.org/wine/wine/-/merge_requests/2957

2 3

Re: [PATCH v3 0/1] MR3030: ntdll: Allow RtlAllocateHeap to crash with invalid handle
by Fabian Maurer (＠DarkShadow44) 11 Jun '23

11 Jun '23

On Sun Jun 11 02:34:19 2023 +0000, Etaash Mathamsetty wrote: > If I added the test, it would just crash the test program. In other > tests they simply just add a win_skip in these cases, but then there's > no point in having a test in my opinion, since it's just going to get skipped. > Not sure what to do about RtlReAllocateHeap unfortunately. There is exception handling: ``` #include "wine/exception.h" __TRY { } __EXCEPT_PAGE_FAULT { } __ENDTRY ``` Though maybe there is a reason that is not used in tests, maybe one of the devs can chime in. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030#note_35348

1 0

Re: [PATCH v3 0/1] MR3030: ntdll: Allow RtlAllocateHeap to crash with invalid handle
by Etaash Mathamsetty (＠etaash.mathamsetty) 11 Jun '23

11 Jun '23

On Sun Jun 11 02:32:59 2023 +0000, Fabian Maurer wrote: > FWIW, there seems to be a difference between 32bit and 64bit Growtopia. > 32bit Growtopia launches normally, while 64bit crashes without the fix. > Btw, what about RtlReAllocateHeap? Should that behavior be consistent? I > don't know what the Wine consensus is. > Also, since it's pretty counter intuitive, would you mind adding tests? > Just a suggestions from a random contributor, though. :smile: If I added the test, it would just crash the test program. In other tests they simply just add a win_skip in these cases, but then there's no point in having a test in my opinion, since it's just going to get skipped. Not sure what to do about RtlReAllocateHeap -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030#note_35347

1 0

[PATCH v2 0/10] MR2993: comdlg32: IFileDialog navigation bar control. Part 1.
by Vladislav Timonin (＠vt) 10 Jun '23

10 Jun '23

Redo of !1857, as suggested, the plan is to split original MR in half, breadcrumbs in first (this) MR, and address edit in another. The changes are mostly cleanup (formatting, renaming, unused variables, missing free). Part two branch can be found [here](https://gitlab.winehq.org/vt/wine/-/commits/fd-navbar-part2). Visually, it hasn't changed: ![](/uploads/37038708b7500cda4f0cffde8981e58c/changes.png) Requires !2068, otherwise if application doesn't request comctl v6 (e.g. qapitrace), navigation bar will look like this: ![no-comctl-v6](/uploads/03e6a8b6dcf827114157e79640e49fea/no-comctl-v6.png) Closes: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=54812 - https://bugs.winehq.org/show_bug.cgi?id=50338 (partially? fully with address edit?) -- v2: comdlg32: Prevent arrow navigation of IFileDialog navigation bar buttons. comdlg32: Don't paint focus rect in IFileDialog navigation bar buttons. comdlg32: Keep IExplorerBrowser in IFileDialog focused after Backspace. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add inner border to breadcrumbs in IFileDialog navigation bar. comdlg32: Always show at least 2 crumbs in IFileDialog navigation bar. comdlg32: Reuse address breadcrumbs in IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar control. https://gitlab.winehq.org/wine/wine/-/merge_requests/2993

3 18

Re: [PATCH v3 0/1] MR3030: ntdll: Allow RtlAllocateHeap to crash with invalid handle
by Fabian Maurer (＠DarkShadow44) 10 Jun '23

10 Jun '23

FWIW, there seems to be a difference between 32bit and 64bit Growtopia. 32bit Growtopia launches normally, while 64bit crashes without the fix. Btw, what about RtlReAllocateHeap? Should that behavior be consistent? I don't know what the Wine consensus is. Also, since it's pretty counter intuitive, would you mind adding tests? Just a suggestions from a random contributor, though. :smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030#note_35326

1 0

[PATCH v4 0/1] MR3006: gdiplus: Improve performance of drawing, by reducing not needed calculations
by Bartosz Kosiorek (＠gang65) 10 Jun '23

10 Jun '23

-- v4: https://gitlab.winehq.org/wine/wine/-/merge_requests/3006

2 2

[PATCH 0/1] MR3029: ntdll: fix incorrect implement of __wine_syscall_dispatcher_return on x86_64
by Fan WenJie (＠fanwenjie) 10 Jun '23

10 Jun '23

Signed-off-by: fanwenjie <fanwj(a)mail.ustc.edu.cn> On unixlib, macro WINAPI means nothing. In windef.h ``` #ifdef WINE_UNIX_LIB # define __stdcall # define __cdecl # define __fastcall #elif !defined(_MSC_VER) && !defined(__MINGW32__) ``` ``` extern void WINAPI DECLSPEC_NORETURN __wine_syscall_dispatcher_return( void *frame, ULONG_PTR retval ) DECLSPEC_HIDDEN; ``` equals ``` extern void __attribute__((sysv_abi)) DECLSPEC_NORETURN __wine_syscall_dispatcher_return( void *frame, ULONG_PTR retval ) DECLSPEC_HIDDEN; ``` But implementation of __wine_syscall_dispatcher_return is ms_abi on x86_64, the patch fixed it -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3029

4 4

Re: [PATCH v9 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor. - approved
by Alexandre Julliard (＠julliard) 09 Jun '23

09 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941

1 0

Re: [PATCH v2 0/1] MR3008: mmdevapi: Handle CreateThread() failure in AudioClient's Start. - approved
by Alexandre Julliard (＠julliard) 09 Jun '23

09 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3008

1 0

Re: [PATCH v3 0/1] MR3020: riched20: Update paragraph position in marked tree. - approved
by Alexandre Julliard (＠julliard) 09 Jun '23

09 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3020

1 0

Re: [PATCH v5 0/4] MR2992: sapi: Implement basic functionality for SpMMAudioOut. - approved
by Alexandre Julliard (＠julliard) 09 Jun '23

09 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2992

1 0

Re: [PATCH v2 0/1] MR3026: xaudio2/tests: Fix the IID_IXAPO query. - approved
by Alexandre Julliard (＠julliard) 09 Jun '23

09 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3026

1 0

Re: [PATCH v3 0/3] MR3010: mf/tests: Split wmv decoder DMO tests. - approved
by Alexandre Julliard (＠julliard) 09 Jun '23

09 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3010

1 0

[PATCH v2 0/1] MR3030: ntdll: Raise exception when handle is NULL in RtlAllocateHeap.
by Etaash Mathamsetty (＠etaash.mathamsetty) 09 Jun '23

09 Jun '23

Growtopia crashes if we don't raise an exception with a NULL handle. -- v2: ntdll: Allow RtlAllocateHeap to crash with invalid handle. https://gitlab.winehq.org/wine/wine/-/merge_requests/3030

2 2

Re: [PATCH v4 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 09 Jun '23

09 Jun '23

On Fri Jun 9 11:59:33 2023 +0000, Huw Davies wrote: > There's a lot of new things going on here and in subsequent commits. > They need to be split like you've just done for the main_loop bits. > It may be better to reduce the scope of this MR to just the main_loop stuff. Agreed, `Initialize()` carries a lot of stuff with it and as a result the changes lines are way too many. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35279

1 0

Re: [PATCH v4 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 09 Jun '23

09 Jun '23

> (and in the next commit) I'm wondering why the OSS failure was not reported, are we not testing for *BSD on CI? > But also there seem to be a lot of small pointless differences (mainly in whitespace) between the new implementations in the non-pulse drivers and the existing one in the pulse driver. That means the merge commits have unnecessary changes. Right, the non-pulse drivers also have a different code style (e.g. opening bracket attached to `if`) I would like to adhere to, for consistency. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35278

1 0

[PATCH 0/1] MR3030: ntdll: Raise exception when handle is NULL in RtlAllocateHeap.
by Etaash Mathamsetty (＠etaash.mathamsetty) 09 Jun '23

09 Jun '23

Growtopia crashes if we don't raise an exception with a NULL handle. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030

3 3

Re: [PATCH v6 0/5] MR207: vkd3d-shader/hlsl: Support non-constant offset dereferences, part 1
by Ethan Lee (＠flibitijibibo) 09 Jun '23

09 Jun '23

On Sat Jun 3 01:01:55 2023 +0000, Francisco Casas wrote: > In the meantime I have realized some things that needed changes in the > following patches, which I now keep in https://gitlab.winehq.org/fcasas/vkd3d/-/commits/nonconst-offsets-4 Rebased my `nonconst-offsets` branch more time with the remaining patches - all came out clean except the 2 extras which just needed a quick update for the latest ir_node cleanups. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/207#note_35272

1 0

[PATCH v3 0/7] MR216: vkd3d: Prepare for tiled resource support.
by Conor McCarthy (＠cmccarthy) 09 Jun '23

09 Jun '23

-- v3: vkd3d: Append CopyTileMappings() commands to the command queue op array. vkd3d: Append UpdateTileMappings() commands to the command queue op array. vkd3d: Add missing const attributes to ID3D12CommandQueue::UpdateTileMappings() parameters. vkd3d: Validate plane count for tiled textures. vkd3d: Validate tiled resources tier for 3D textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/216

3 15

Re: [PATCH v4 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Huw Davies (＠huw) 09 Jun '23

09 Jun '23

Huw Davies (@huw) commented about dlls/mmdevapi/client.c: > extern void sessions_unlock(void) DECLSPEC_HIDDEN; > > +extern HRESULT get_audio_session(const GUID *sessionguid, IMMDevice *device, UINT channels, > + struct audio_session **out) DECLSPEC_HIDDEN; > extern struct audio_session_wrapper *session_wrapper_create(struct audio_client *client) DECLSPEC_HIDDEN; > > +static HANDLE main_loop_thread; > + > +void stop_main_loop(void) > +{ > + if (main_loop_thread) { > + WaitForSingleObject(main_loop_thread, INFINITE); > + CloseHandle(main_loop_thread); > + } > +} > + There's a lot of new things going on here and in subsequent commits. They need to be split like you've just done for the main_loop bits. It may be better to reduce the scope of this MR to just the main_loop stuff. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35263

1 0

Re: [PATCH v4 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Huw Davies (＠huw) 09 Jun '23

09 Jun '23

Huw Davies (@huw) commented about dlls/winecoreaudio.drv/mmdevdrv.c: > + > DeleteCriticalSection(&g_sessions_lock); > break; > } > return TRUE; > } > > +static DWORD CALLBACK main_loop_func(void *event) > +{ > + struct main_loop_params params; > + > + SetThreadDescription(GetCurrentThread(), L"coreaudio_main"); > + > + params.event = event; > + > + ALSA_CALL(main_loop, &params); ```suggestion:-0+0 UNIX_CALL(main_loop, &params); ``` (and in the next commit) But also there seem to be a lot of small pointless differences (mainly in whitespace) between the new implementations in the non-pulse drivers and the existing one in the pulse driver. That means the merge commits have unnecessary changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35262

1 0

[PATCH v3 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 09 Jun '23

09 Jun '23

-- v3: wineoss: Use mmdevapi's AudioClient's Initialize. winecoreaudio: Use mmdevapi's AudioClient's Initialize. winealsa: Use mmdevapi's AudioClient's Initialize. winepulse: Move AudioClient's Initialize into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/3027

3 9

[PATCH v2 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 09 Jun '23

09 Jun '23

-- v2: wineoss: Use mmdevapi's AudioClient's Initialize. winecoreaudio: Use mmdevapi's AudioClient's Initialize. winealsa: Use mmdevapi's AudioClient's Initialize. winepulse: Move AudioClient's Initialize into mmdevapi. wineoss: Implement main_loop in unixlib. winecoreaudio: Implement main_loop in unixlib. winealsa: Implement main_loop in unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/3027

3 11

[PATCH 0/4] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 09 Jun '23

09 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027

4 8

[PATCH v8 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 09 Jun '23

09 Jun '23

This is to prevent NULL pointers when creating a TextService with no rows in it. This NULL pointers doesn't happen when creating a richedit windows, because it sets an empty text when the richedit window procedure handles the WM_CREATE event. -- v8: riched20: Call ME_UpdateRepaint instead of editor_ensure_visible in set_selection. https://gitlab.winehq.org/wine/wine/-/merge_requests/2941

3 2

[PATCH 0/5] MR3028: Add more tests for IShellFolder_ParseDisplayName() and add localized strings for CLSID_Printers and CLSID_Internet.
by Jactry Zeng (＠jactry) 09 Jun '23

09 Jun '23

[5/5] is actually not relevant to this serial, but my next serial will depend on it, so I submit it by the way first, so that I can avoid maintaining too many patches locally. :D -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3028

2 5

[PATCH 0/1] MR3008: mmdevapi: Handle CreateThread() failure in AudioClient's Start.
by Davide Beatrici (＠davidebeatrici) 09 Jun '23

09 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3008

4 3

[PATCH v2 0/1] MR3020: riched20: Update paragraph position in marked tree.
by Daniel Lehman (＠dlehman25) 09 Jun '23

09 Jun '23

nCharOfs is the key for paragraphs added to the marked tree If it is updated, re-add the entry to update its position -- v2: riched20: Update paragraph position in marked tree. https://gitlab.winehq.org/wine/wine/-/merge_requests/3020

3 3

[PATCH v4 0/4] MR2992: sapi: Implement basic functionality for SpMMAudioOut.
by Shaun Ren (＠shaunren) 09 Jun '23

09 Jun '23

-- v4: sapi: Implement ISpMMSysAudio::Get/SetFormat. include: Add sperror error code SPERR_UNSUPPORTED_FORMAT. sapi: Add GUIDs SPDFID_Text/WaveFormatEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/2992

3 6

[PATCH 0/1] MR3026: xaudio2/tests: Fix the IID_IXAPO query.
by Zebediah Figura (＠zfigura) 09 Jun '23

09 Jun '23

This was missed in 14c44d0b0a2fc0ead5bc75615864ff850a44c4d5. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55016 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3026

3 2

[PATCH v2 0/3] MR3010: mf/tests: Split wmv decoder DMO tests.
by Ziqing Hui (＠zhui) 09 Jun '23

09 Jun '23

-- v2: mf/tests: Split size info tests from test_wmv_decoder_media_object. https://gitlab.winehq.org/wine/wine/-/merge_requests/3010

4 5

Re: [PATCH v2 0/5] MR3023: msvcr100: Use Context::Block() in more places + bug fixes - approved
by Alexandre Julliard (＠julliard) 08 Jun '23

08 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3023

1 0

Re: [PATCH v2 0/1] MR3017: regedit: Fix memory leak on error path in GetItemPath (scan-build). - approved
by Alexandre Julliard (＠julliard) 08 Jun '23

08 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3017

1 0

Re: [PATCH v2 0/1] MR3019: msi: Release record instead of free. - approved
by Alexandre Julliard (＠julliard) 08 Jun '23

08 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3019

1 0

Re: [PATCH v2 0/1] MR3018: msi: Fix memory leak on error path in MSI_ProcessMessage (scan-build). - approved
by Alexandre Julliard (＠julliard) 08 Jun '23

08 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3018

1 0

Re: [PATCH v2 0/1] MR3015: winhttp: Fix double free on error path in queue_task (scan-build). - approved
by Alexandre Julliard (＠julliard) 08 Jun '23

08 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3015

1 0

Re: [PATCH v3 0/8] MR3009: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported, GetCurrentPadding, GetStreamLatency, GetBufferSize into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 08 Jun '23

08 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3009

1 0

Re: [PATCH v2 0/1] MR3012: rpcrt4: Replace RPCRT4_strndupA with strdup. - approved
by Alexandre Julliard (＠julliard) 08 Jun '23

08 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3012

1 0

Re: [PATCH v2 0/1] MR226: vkd3d-shader/hlsl: Fold redudant casts again after lower narrowing casts. - approved
by Alexandre Julliard (＠julliard) 08 Jun '23

08 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/226

1 0

Re: [PATCH v4 0/7] MR223: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 7. - approved
by Alexandre Julliard (＠julliard) 08 Jun '23

08 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/223

1 0

[PATCH v7 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

This is to prevent NULL pointers when creating a TextService with no rows in it. This NULL pointers doesn't happen when creating a richedit windows, because it sets an empty text when the richedit window procedure handles the WM_CREATE event. -- v7: riched20: Call ME_UpdateRepaint instead of editor_ensure_visible in set_selection. https://gitlab.winehq.org/wine/wine/-/merge_requests/2941

2 1

[PATCH 0/1] MR2887: winegstreamer: Make sure threads are not waiting for event_cond object.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

First we set the EOS state, so the wait_parser_stream_buffer function doesn't call pthread_cond_wait again. Then we must call pthread_cond_signal to make sure that no one is waiting for it, if we don't do that, there is the possibility of hanging wg_parser_disconnect at the free_stream call, because pthread_cond_destroy will hang when the cond object is being waited by other threads. Specifically this helps to fix a hang in some applications, specially Unreal Engine games when changing sources too fast in a MediaPlayer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2887

3 6

[PATCH v6 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

This is to prevent NULL pointers when creating a TextService with no rows in it. This NULL pointers doesn't happen when creating a richedit windows, because it sets an empty text when the richedit window procedure handles the WM_CREATE event. -- v6: riched20: Call ME_UpdateRepaint instead of editor_ensure_visible in set_selection. https://gitlab.winehq.org/wine/wine/-/merge_requests/2941

2 1

[PATCH v3 0/5] MR219: vkd3d-shader: Implement tex2Dproj().
by Nikolay Sivov (＠nsivov) 08 Jun '23

08 Jun '23

-- v3: vkd3d-shader/hlsl: Implement texCUBEproj(). vkd3d-shader/d3dbc: Disallow 1D sampler types when writing sampler declaration. vkd3d-shader/hlsl: Implement tex3Dproj(). vkd3d-shader/hlsl: Implement tex1Dproj(). vkd3d-shader/hlsl: Implement tex2Dproj(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/219

2 5

[PATCH v7 0/5] MR211: vkd3d-shader/hlsl: Support clip() intrinsic.
by Nikolay Sivov (＠nsivov) 08 Jun '23

08 Jun '23

-- v7: vkd3d-shader/hlsl: Handle 'texkill' jump type. vkd3d-shader/hlsl: Parse clip() function. tests: Add some tests for clip(). vkd3d-shader: Make some helpers available from hlsl.c. vkd3d-shader/hlsl: Add a parameter for jump nodes and use it for 'discard'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211

2 6

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

On Thu Jun 8 10:13:38 2023 +0000, Huw Davies wrote: > Yes. See the existing tests in `dlls/riched20/tests/txtsrv.c`. We > don't currently do much testing on which `ITextHost` members get called, > but at least there's already an implementation there to get you started. From what I see when reading the trace calls with `WINETEST_DEBUG` set, windows calls two times TxViewChange, I suppose the first time it's called by the SetText call, and then the second one is called by EM_SETSEL, in wine we don't call it. There are also other functions from the TextHost that get called and we don't do it in wine, so I'm going to write tests for it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35179

1 0

2025

2024

2023

2022

wine-gitlab