- wine-gitlab - winehq.org

[PATCH v2 0/5] MR219: vkd3d-shader: Implement tex2Dproj().
by Nikolay Sivov (＠nsivov) 08 Jun '23

08 Jun '23

-- v2: vkd3d-shader/hlsl: Implement texCUBEproj(). vkd3d-shader/d3dbc: Disallow 1D sampler types when writing sampler declaration. vkd3d-shader/hlsl: Implement tex3Dproj(). vkd3d-shader/hlsl: Implement tex1Dproj(). vkd3d-shader/hlsl: Implement tex2Dproj(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/219

4 13

[PATCH v3 0/1] MR3007: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker (＠bernhardu) 08 Jun '23

08 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: - Fix typo in commit message. - Modified format strings. -- v3: ntdll: Avoid requests with null pointer but invalid size. https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

3 3

[PATCH 0/3] MR3024: win32u: Introduce a new rawinput dedicated thread.
by Rémi Bernon (＠rbernon) 08 Jun '23

08 Jun '23

Currently only used to keep rawinput devices updated without iterating the entire list on every change. This thread will then let us solve several problems: * Solve issues with input not being polled if/when applications aren't checking their messages. This removes the need for polling messages in DInput, which is known to confuse and break DOSBOX. * Solve some issues with ll-hook deadlocks between hooking threads and the thread that is currently polling for inputs. * Useful to process internal messages and implement some user driver mechanisms. It can for instance already process WM_WINE_CLIPCURSOR messages, instead of relying on the foreground thread. * Similarly, for cursor icon changes, wineserver can notify it on cursor window changes and request the cursor icon to be updated from the user driver, instead of having to check the window the cursor is located in to change its icon on every mouse move. * Ultimately make it possible to drop the __wine_send_input PE export, the thread can read HID reports from devices that a process has registered for, and send WM_INPUT messages accordingly. This has some drawbacks though, as reading NT devices currently involves much more wineserver roundtrips than `__wine_send_input`. There's evidence that Windows uses a similar thread to process hardware events (as described in https://devblogs.microsoft.com/oldnewthing/20140213-00/?p=1773), although it's probably a system-wide kernel thread. I considered reading X11 input from a per-prefix dedicated thread (for instance in explorer.exe) or dedicated process, but having one thread per-process has several advantages. The rawinput device registration state is done per-process and according to https://gitlab.winehq.org/wine/wine/-/merge_requests/2120 it also needs to post notifications that are process specific. It also keeps the guarantee that each process will read the inputs from the window it has created, and not from some other windows, although the message dispatch may decide to send the message to another process later, it avoids having to listen to input on other processes windows. It can then be seen as an intermediate step towards having a per-prefix thread, if that's something we end up needing. Moving from a per-process thread to a per-prefix thread should be easier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3024

3 5

[PATCH v2 0/1] MR3013: wusa: Fix memory leak on error path in read_components (scan-build).
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

If read_identity returns FALSE, it has already called clear_identity. This is the same problem as in merge request !2970. Unfortunately I did not notice at first that the problem was present in two places. -- v2: wusa: Fix double free on error path in read_components (scan-build). https://gitlab.winehq.org/wine/wine/-/merge_requests/3013

2 2

[PATCH v3 0/1] MR2957: win32u: Move QueryDisplayConfig from user32.
by Tatsuyuki Ishi (＠ishitatsuyuki) 08 Jun '23

08 Jun '23

This allows access to the in-process cached monitor list and reduces the number of registry calls issued for QueryDisplayConfig (in case of no change) from `4 x monitors` to `1`. -- v3: win32u: Move QueryDisplayConfig from user32. https://gitlab.winehq.org/wine/wine/-/merge_requests/2957

3 23

[PATCH 0/5] MR3023: msvcr100: Use Context::Block() in more places + bug fixes
by Piotr Caban (＠piotr) 08 Jun '23

08 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3023

3 6

[PATCH v3 0/8] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu (＠insn) 08 Jun '23

08 Jun '23

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- v3: jscript: Store ref to the function code instead of the function instance jscript: Don't allocate arguments buffer separately from the arguments obj. jscript: Properly implement duplicated argument names in functions. jscript: Don't use iface_to_jsdisp where it's not necessary to grab it. jscript: Get rid of jsobj in scope_chain_t. jscript: Move arguments_obj from the frame to the base scope. jscript: Fix addressing invalid memory if ref is an argument. jscript: Correctly implement context for indirect eval calls in ES5+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

3 11

[PATCH v3 0/2] MR3006: gdiplus: Improve performance of drawing, by reducing not needed calculations
by Bartosz Kosiorek (＠gang65) 08 Jun '23

08 Jun '23

-- v3: gdiplus: move pointer calculation outside inner loop for alpha_blend_bmp_pixels gdiplus: reduce number of calculations for matrix rotation https://gitlab.winehq.org/wine/wine/-/merge_requests/3006

3 3

[PATCH v5 0/3] MR1259: gitlab: Run some tests with nulldrv driver.
by Rémi Bernon (＠rbernon) 08 Jun '23

08 Jun '23

Allowing the job to fail to avoid failing the pipeline. Some new tests are failing with it, and some are succeeding todo_wine. -- v5: gitlab: Run user32 32-bit tests with nulldrv driver. user32/tests: Update todos specific to the X11 display driver. user32/tests: Check graphics driver and add todos for nulldrv. https://gitlab.winehq.org/wine/wine/-/merge_requests/1259

2 5

[PATCH 0/1] MR226: vkd3d-shader/hlsl: Fold redudant casts again after lower narrowing casts.
by Francisco Casas (＠fcasas) 08 Jun '23

08 Jun '23

lower_narrowing_casts() currently creates a new cast calling hlsl_new_cast(). This cast may be redudant, but it is not folded, which is making SM1 emit an unnecessary fixme in some shaders: Aborting due to not yet implemented feature: SM1 "cast" expression. Other passes that call hlsl_new_cast() are lower_int_division() and lower_int_modulus(), so the new fold_redudant_casts() pass is called after these as well. This is the only thing left required for the HLSL compiler to properly compile the SONIC CD shaders. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/226

5 4

[PATCH v3 0/7] MR223: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 7.
by Zebediah Figura (＠zfigura) 08 Jun '23

08 Jun '23

BORING -- v3: vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_constant(). vkd3d-shader/hlsl: Pass a hlsl_constant_value pointer to hlsl_new_constant(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_bit_or(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_bit_and(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_bit_xor(). vkd3d-shader/hlsl: Only read used coordinates in encode_texel_offset_as_aoffimmi(). vkd3d-shader/hlsl: Use the writemask to map the coords swizzle for load instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/223

3 8

[PATCH 0/2] MR224: tests: Test coarse and fine derivates and demand less precision from ddx() and ddy().
by Francisco Casas (＠fcasas) 08 Jun '23

08 Jun '23

On my Nvidia GeForce GTX 1050 Ti `ddxddy.shader_test` doesn't pass because of considerably different numeric results. As Giovanni pointed out, this is because my GPU uses the fine derivate and not the coarse derivate to implement ddx() and ddy(). For this reason, the result for ddx|ddy() is quantized so that the test passes if the GPU uses either coarse or fine derivates. Additionally, tests for both ddx_coarse|ddy_coarse() and ddx_fine|ddy_fine() are added, that expect a more precise result. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/224

4 6

[PATCH v6 0/5] MR211: vkd3d-shader/hlsl: Support clip() intrinsic.
by Nikolay Sivov (＠nsivov) 08 Jun '23

08 Jun '23

-- v6: vkd3d-shader/hlsl: Handle 'texkill' jump type. vkd3d-shader/hlsl: Parse clip() function. tests: Add some tests for clip(). vkd3d-shader: Make some helpers available from hlsl.c. vkd3d-shader/hlsl: Add a parameter for jump nodes and use it for 'discard'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211

3 9

[PATCH 0/1] MR2995: rpcrt4: Don't use GetProcAddress for ole32 functions.
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

It's more elegant to put ole32 in the DELAYIMPORTS. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2995

3 2

[PATCH v5 0/4] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 08 Jun '23

08 Jun '23

-- v5: vkd3d-shader/tpf: Add support for writing 'resinfo' instruction. vkd3d-shader/tpf: Add support for writing 'sampleinfo' instruction. vkd3d-shader/hlsl: Parse GetDimensions() method. tests: Add some tests for GetDimensions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

4 8

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Huw Davies (＠huw) 08 Jun '23

08 Jun '23

On Thu Jun 8 10:01:18 2023 +0000, Santino Mazza wrote: > In this API the callbacks are the `Tx` functions from `ITextHost`, right? Yes. See the existing tests in `dlls/riched20/tests/txtsrv.c`. We don't currently do much testing on which `ITextHost` members get called, but at least there's already an implementation there to get you started. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35115

1 0

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

On Thu Jun 8 09:55:30 2023 +0000, Huw Davies wrote: > > I couldn't debug it too much, because the crash happens only in the > ITextHost implementation from a microsoft forms dll. > Ah, so it may be related to which host callbacks get called. I think > we're going to need some tests that look at that. In this API the callbacks are the `Tx` functions from `ITextHost`, right? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35114

1 0

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Huw Davies (＠huw) 08 Jun '23

08 Jun '23

> I couldn't debug it too much, because the crash happens only in the ITextHost implementation from a microsoft forms dll. Ah, so it may be related to which host callbacks get called. I think we're going to need some tests that look at that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35113

1 0

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

On Thu Jun 8 09:52:58 2023 +0000, Huw Davies wrote: > That'll mean that the host's `TxViewChange` method would get called - > we'd need a test to see if that's the case. It still seems like we're > hiding the problem. What crash did you see when using `ME_WrapMarkedParagraphs()`? I couldn't debug it too much, because the crash happens only in the ITextHost implementation from a microsoft forms dll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35112

1 0

[PATCH 0/1] MR3019: msi: Release record instead of free.
by Daniel Lehman (＠dlehman25) 08 Jun '23

08 Jun '23

../dlls/msi/dialog.c:4476:11: warning: attempt to call free on non-heap object 'hdr' [-Wfree-nonheap-object] free( &rec->hdr ); ^ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3019

3 2

[PATCH 0/1] MR3018: msi: Fix memory leak on error path in MSI_ProcessMessage (scan-build).
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3018

3 2

[PATCH 0/1] MR3015: winhttp: Fix double free on error path in queue_task (scan-build).
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

queue_task cannot free the struct because it doesn't know whether the struct contains pointers to other dynamically allocated memory that also needs to be freed (as is the case with struct send_request). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3015

3 2

[PATCH 0/1] MR3013: wusa: Fix memory leak on error path in read_components (scan-build).
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

If read_identity returns FALSE, it has already called clear_identity. This is the same problem as in merge request !2970. Unfortunately I did not notice at first that the problem was present in two places. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3013

3 2

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Huw Davies (＠huw) 08 Jun '23

08 Jun '23

That'll mean that the host's `TxViewChange` method would get called - we'd need a test to see if that's the case. It still seems like we're hiding the problem. What crash did you see when using `ME_WrapMarkedParagraphs()`? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35104

1 0

[PATCH v2 0/8] MR3009: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported, GetCurrentPadding, GetStreamLatency, GetBufferSize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 08 Jun '23

08 Jun '23

-- v2: wineoss: Use mmdevapi's AudioClient's GetCurrentPadding, GetStreamLatency, GetBufferSize. winecoreaudio: Use mmdevapi's AudioClient's GetCurrentPadding, GetStreamLatency, GetBufferSize. winealsa: Use mmdevapi's AudioClient's GetCurrentPadding, GetStreamLatency, GetBufferSize. winepulse: Move AudioClient's GetCurrentPadding, GetStreamLatency, GetBufferSize into mmdevapi. wineoss: Use mmdevapi's AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported. winecoreaudio: Use mmdevapi's AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported. winealsa: Use mmdevapi's AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported. winepulse: Move AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/3009

3 9

[PATCH 0/1] MR3011: wldap32: Clean up LDAP_OPT_API_INFO.
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

Fix memory leaks on error paths, don't call memset unnecessarily, and ensure that all output fields are initialized. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3011

3 4

[PATCH v2 0/6] MR3021: win32u: Move ClipCursor logic out of winex11.
by Rémi Bernon (＠rbernon) 08 Jun '23

08 Jun '23

I wasn't completely sure what to do with the registry key. Keeping "Wine/X11 Driver" is a bit odd, but it also makes sure we stay backward compatible. Changing it would require more changes elsewhere and maybe it could be done later, if / when more options are moved. -- v2: win32u: Move fullscreen window cursor clipping from winex11. winex11: Move clip_fullscreen_window foreground check inside it. win32u: Add a clipping_cursor member to user_thread_info. win32u: Add a clipping_reset member to user_thread_info. win32u: Move grab_pointer registry option from winex11. winex11: Remove now unnecessary WM_X11DRV_CLIP_CURSOR_NOTIFY. https://gitlab.winehq.org/wine/wine/-/merge_requests/3021

2 7

[PATCH 0/6] MR3021: win32u: Move ClipCursor logic out of winex11.
by Rémi Bernon (＠rbernon) 08 Jun '23

08 Jun '23

I wasn't completely sure what to do with the registry key. Keeping "Wine/X11 Driver" is a bit odd, but it also makes sure we stay backward compatible. Changing it would require more changes elsewhere and maybe it could be done later, if / when more options are moved. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3021

3 7

[PATCH 0/3] MR3010: mf/tests: Split wmv decoder DMO tests.
by Ziqing Hui (＠zhui) 08 Jun '23

08 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3010

4 6

[PATCH 0/1] MR3020: riched20: Update paragraph position in marked tree.
by Daniel Lehman (＠dlehman25) 08 Jun '23

08 Jun '23

nCharOfs is the key for paragraphs added to the marked tree If it is updated, re-add the entry to update its position -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3020

4 3

[PATCH 0/8] MR3009: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported, GetCurrentPadding, GetStreamLatency, GetBufferSize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 08 Jun '23

08 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3009

3 10

[PATCH 0/1] MR3012: rpcrt4: Replace RPCRT4_strndupA with strdup.
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3012

3 2

Re: [PATCH v3 0/4] MR2992: sapi: Implement basic functionality for SpMMAudioOut.
by Huw Davies (＠huw) 08 Jun '23

08 Jun '23

Huw Davies (@huw) commented about dlls/sapi/uuid.c: > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include "initguid.h" > + > +DEFINE_GUID(SPDFID_Text, 0x7ceef9f9, 0x3d13, 0x11d2, 0x9e, 0xe7, 0x00, 0xc0, 0x4f, 0x79, 0x73, 0x96); > +DEFINE_GUID(SPDFID_WaveFormatEx, 0xc31adbae, 0x527f, 0x4ff5, 0xa2, 0x30, 0xf6, 0x2b, 0xb6, 0x1f, 0xf7, 0x0c); Adding a new source file just for the guids seems a bit of an overkill. Can't we just add these to another file? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2992#note_35072

1 0

[PATCH 0/1] MR3017: regedit: Fix memory leak on error path in GetItemPath (scan-build).
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3017

2 1

[PATCH 0/1] MR3014: winegstreamer: Fix double free on error path in media_source_constructor (scan-build).
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3014

2 1

[PATCH v2 0/4] MR2992: sapi: Implement basic functionality for SpMMAudioOut.
by Shaun Ren (＠shaunren) 08 Jun '23

08 Jun '23

-- v2: sapi: Implement ISpMMSysAudio::Get/SetFormat. include: Add sperror error code SPERR_UNSUPPORTED_FORMAT. sapi: Add GUIDs SPDFID_Text/WaveFormatEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/2992

2 4

[PATCH 0/3] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 07 Jun '23

07 Jun '23

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

4 12

[PATCH v2 0/1] MR3007: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker (＠bernhardu) 07 Jun '23

07 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: - Fix typo in commit message. -- v2: ntdll: Avoid requests with null pointer but invalid size. https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

3 4

Re: [PATCH v5 0/10] MR2994: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's SetEventHandle, Reset, Stop, Start into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 07 Jun '23

07 Jun '23

On Wed Jun 7 06:54:43 2023 +0000, Davide Beatrici wrote: > I've actually thought about both points. > I will add `CreateThread()`'s failure handling in a subsequent merge request. !3008 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2994#note_35032

1 0

Re: [PATCH v2 0/1] MR3003: mf/tests: Remove duplicate call to MFStartup(). - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3003

1 0

Re: [PATCH v2 0/1] MR3005: localspl: Don't pass original document name to cupsStartDocument. - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3005

1 0

Re: [PATCH v7 0/4] MR2918: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl. - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2918

1 0

Re: [PATCH v4 0/6] MR2981: win32u: Move asynchronous ClipCursor processing out of winex11. - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2981

1 0

Re: [PATCH v5 0/10] MR2994: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's SetEventHandle, Reset, Stop, Start into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2994

1 0

Re: [PATCH v2 0/1] MR3000: vbscript: Fix memory leak on error path in alloc_vbscode (scan-build). - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3000

1 0

Re: [PATCH v2 0/1] MR2997: wininet: Fix memory leaks on error paths in INTERNET_LoadProxySettings (scan-build). - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2997

1 0

Re: [PATCH v2 0/1] MR2999: vbscript: Fix memory leak on error path in RegExp2_Execute (scan-build). - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2999

1 0

Re: [PATCH v2 0/1] MR2998: jscript: Fix memory leak on error path in regexp_string_match (scan-build). - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2998

1 0

Re: [PATCH v3 0/1] MR3002: wldap32: Fix memory leak on error path in ldap_start_tls_sW (scan-build). - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3002

1 0

Re: [PATCH v2 0/1] MR3001: hhctrl: Fix memory leak on error path in resolve_filename (scan-build). - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3001

1 0

Re: [PATCH v2 0/1] MR2996: dnsapi: Fix memory leak on error path in do_query_netbios (scan-build). - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2996

1 0

Re: [PATCH v3 0/1] MR2980: kerberos: Fix memory leaks in (wow64_)query_ticket_cache (scan-build). - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2980

1 0

Re: [PATCH v6 0/5] MR207: vkd3d-shader/hlsl: Support non-constant offset dereferences, part 1 - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/207

1 0

[PATCH v4 0/4] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 07 Jun '23

07 Jun '23

-- v4: vkd3d-shader/tpf: Add support for writing 'resinfo' instruction. vkd3d-shader/tpf: Add support for writing 'sampleinfo' instruction. vkd3d-shader/hlsl: Parse GetDimensions() method. tests: Add some tests for GetDimensions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

3 8

[PATCH 0/1] MR3007: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker (＠bernhardu) 07 Jun '23

07 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: - Fix typo in commit message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

2 1

Re: [PATCH v2 0/2] MR3006: gdiplus: Improve performance of drawing, by reducing not needed calculations
by Alex Henrie (＠alexhenrie) 07 Jun '23

07 Jun '23

Alex Henrie (@alexhenrie) commented about dlls/gdiplus/graphics.c: > } > } > > +/* Creates rotated and translated identity matrix. > + * Equvalent (but much faster) of the: > + * GdipSetMatrixElements(&matrix, 1.0, 0.0, 0.0, 1.0, 0.0, 0.0); > + * GdipRotateMatrix(&matrix, angle, MatrixOrderAppend); > + * GdipTranslateMatrix(&matrix, dx, dy, MatrixOrderAppend); */ > +inline void create_rotated_translated_identity_matrix(GpMatrix *matrix, REAL angle, REAL dx, REAL dy) This function should be `static` and not `inline`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3006#note_34990

1 0

[PATCH 0/1] MR3003: mf/tests: Remove duplicate call to MFStartup().
by Bernhard Kölbl (＠besentv) 07 Jun '23

07 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3003

3 4

[PATCH 0/1] MR3005: localspl: Don't pass original document name to cupsStartDocument.
by Piotr Caban (＠piotr) 07 Jun '23

07 Jun '23

It's used by the function to find document content type. Fixes regression introduced by e164b8cefb9dfbf0af5b83e176a386eb2c490d6b. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3005

3 2

[PATCH v4 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 07 Jun '23

07 Jun '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v4: comdlg32: Enable visual styles when showing IFileDialog. comdlg32: Return E_UNEXPECTED if IFileDialog is already shown https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

4 5

[PATCH v5 0/5] MR207: vkd3d-shader/hlsl: Support non-constant offset dereferences, part 1
by Francisco Casas (＠fcasas) 07 Jun '23

07 Jun '23

Indexing with non-constants offsets requires relative addressing in SM4. In assembly, this is written like in the following example: ``` x1[r1.x + 3] ``` The first part of this patch series only includes support for indexing vectors with non-constant indexes. Following patches in https://gitlab.winehq.org/fcasas/vkd3d/-/commits/nonconst-offsets-3. --- Non-constant indexing of vectors cannot be implemented with relative addressing in SM4 because this indexation cannot be performed at the level of register-components, only whole registers. Mathematical operations must be used instead. For floats, the native compiler seems to index an identity matrix, to get the i-th column, and then proceedes to compute the dot product between that column and the vector. For ints, bit operations seem to be performed. While probably less efficient, this implementation complies with the type-checking at the IR level and when writing bytecode. -- v5: vkd3d-shader/hlsl: Support non-constant vector indexing. vkd3d-shader/hlsl: Lower dot for non-float types. vkd3d-shader/hlsl: Introduce transform_derefs(). tests: Test indexing temps. tests: Test non-constant vector indexing. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/207

4 8

[PATCH v2 0/2] MR225: vkd3d-shader/tpf: Read complete swizzle/mask info from parameter tokens.
by Conor McCarthy (＠cmccarthy) 07 Jun '23

07 Jun '23

-- v2: vkd3d-shader/tpf: Read complete swizzle/mask info for dst params. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/225

3 3

[PATCH v2 0/7] MR223: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 7.
by Zebediah Figura (＠zfigura) 07 Jun '23

07 Jun '23

BORING -- v2: vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_constant(). vkd3d-shader/hlsl: Pass a hlsl_constant_value pointer to hlsl_new_constant(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_bit_or(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_bit_and(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_bit_xor(). vkd3d-shader/hlsl: Only read used coordinates in encode_texel_offset_as_aoffimmi(). vkd3d-shader/hlsl: Use the writemask to map the coords swizzle for load instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/223

4 12

[PATCH v5 0/1] MR211: vkd3d-shader/hlsl: Support clip() intrinsic.
by Nikolay Sivov (＠nsivov) 07 Jun '23

07 Jun '23

-- v5: vkd3d-shader/hlsl: Support clip() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211

5 12

[PATCH 0/5] MR3004: mf/session: Pull more samples from upstream if MFT has pending requests.
by Rémi Bernon (＠rbernon) 07 Jun '23

07 Jun '23

This will be required for MFT decoder transforms to work. They don't usually produce an output sample on every pushed input sample, and the session may need to request more sample from upstream and push them into the transform or it will not get any output and get stuck. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3004

2 5

[PATCH v6 0/4] MR2918: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl.
by Zebediah Figura (＠zfigura) 07 Jun '23

07 Jun '23

-- v6: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/2918

2 5

Re: [PATCH v16 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 07 Jun '23

07 Jun '23

> I don't know why the pipeline fails. The author name and email are set on all eight commits: It may be because you have a merge commit; that probably needs to be removed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_34951

1 0

[PATCH v3 0/1] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 07 Jun '23

07 Jun '23

-- v3: vkd3d-shader: Implement GetDimensions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

5 12

Re: [PATCH v16 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 07 Jun '23

07 Jun '23

I don't know why the pipeline fails. The author name and email are set on all eight commits: ``` $ git clone https://gitlab.winehq.org/dropbear/wine.git && cd wine ... $ git checkout afunix Branch 'afunix' set up to track remote branch 'afunix' from 'origin'. Switched to a new branch 'afunix' $ git log --oneline --author="dropbear.sh(a)gmail.com" --pretty=format:"%h %an <%ae> %s" c0fdbf09008 Ally Sommers <dropbear.sh(a)gmail.com> Merge branch wine:master into afunix 44e2032ce58 Ally Sommers <dropbear.sh(a)gmail.com> ws2_32/tests: Add test for AF_UNIX sockets. 668d655c7a6 Ally Sommers <dropbear.sh(a)gmail.com> server: Fix getsockname() and accept() on AF_UNIX sockets. 418bd0cb66f Ally Sommers <dropbear.sh(a)gmail.com> server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. 50985b2b9bf Ally Sommers <dropbear.sh(a)gmail.com> server: Allow for deletion of socket files. a12834a6a76 Ally Sommers <dropbear.sh(a)gmail.com> ws2_32: Add support for AF_UNIX sockets. 85b6afe3e2b Ally Sommers <dropbear.sh(a)gmail.com> ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ab6e1c5d48d Ally Sommers <dropbear.sh(a)gmail.com> ws2_32: Add afunix.h header. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_34940

1 0

[PATCH v3 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 07 Jun '23

07 Jun '23

The test has a little inspiration from the SDK samples. -- v3: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

3 3

[PATCH v3 0/6] MR2981: win32u: Move asynchronous ClipCursor processing out of winex11.
by Rémi Bernon (＠rbernon) 07 Jun '23

07 Jun '23

This uses a new hardware message with Wine internal WM_WINE_CLIPCURSOR message, to notify the foreground window of ClipCursor calls, or resets. It could possibly have used posted messages, like is done to request the desktop to release the clipping rectangle but I figured that a hardware message could be appropriate and is possibly the preferred mechanism to notify the foreground window. We use QS_RAWINPUT for convenience here, as to automatically release the hardware message, and because this message is somewhat low-level. It could be anything, and maybe QS_MOUSEMOVE, but we'd have to then manually call accept_hardware_message from win32u. The desktop posted message is kept, as there's no guarantee that the foreground window will be processing its hardware messages when we need, and/or that the desktop window is foreground. -- v3: winex11: Remove now unnecessary ClipCursor forwarding to foreground thread. win32u: Asynchronously apply or reset ClipCursor from the hardware message. server: Queue a hardware WM_WINE_CLIPCURSOR message to the foreground thread. server: Use a separate helper to merge WM_MOUSEMOVE messages. server: Use the helper to reset the clip rect when the desktop size changes. win32u: Add a reset parameter to WM_WINE_CLIPCURSOR and driver ClipCursor. https://gitlab.winehq.org/wine/wine/-/merge_requests/2981

4 12

[PATCH 0/1] MR3000: vbscript: Fix memory leak on error path in alloc_vbscode (scan-build).
by Alex Henrie (＠alexhenrie) 07 Jun '23

07 Jun '23

release_vbscode doesn't do anything if ref is 0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3000

4 3

[PATCH 0/1] MR2997: wininet: Fix memory leaks on error paths in INTERNET_LoadProxySettings (scan-build).
by Alex Henrie (＠alexhenrie) 07 Jun '23

07 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2997

4 3

[PATCH v4 0/10] MR2994: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's SetEventHandle, Reset, Stop, Start into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 07 Jun '23

07 Jun '23

-- v4: wineoss: Use mmdevapi's AudioClient's Start. winecoreaudio: Use mmdevapi's AudioClient's Start. winealsa: Use mmdevapi's AudioClient's Start. winepulse: Move AudioClient's Start into mmdevapi. winecoreaudio: Lock sessions in AudioClient's Start. winepulse: Lock sessions in AudioClient's Start. https://gitlab.winehq.org/wine/wine/-/merge_requests/2994

3 12

[PATCH 0/1] MR2999: vbscript: Fix memory leak on error path in RegExp2_Execute (scan-build).
by Alex Henrie (＠alexhenrie) 07 Jun '23

07 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2999

3 2

[PATCH 0/1] MR2998: jscript: Fix memory leak on error path in regexp_string_match (scan-build).
by Alex Henrie (＠alexhenrie) 07 Jun '23

07 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2998

3 2

[PATCH v5 0/4] MR2918: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl.
by Zebediah Figura (＠zfigura) 07 Jun '23

07 Jun '23

-- v5: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/2918

4 7

[PATCH 0/4] MR2992: sapi: Implement basic functionality for SpMMAudioOut.
by Shaun Ren (＠shaunren) 07 Jun '23

07 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2992

4 6

[PATCH v3 0/10] MR2994: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's SetEventHandle, Reset, Stop, Start into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 07 Jun '23

07 Jun '23

-- v3: wineoss: Use mmdevapi's AudioClient's Start. winecoreaudio: Use mmdevapi's AudioClient's Start. winealsa: Use mmdevapi's AudioClient's Start. winepulse: Move AudioClient's Start into mmdevapi. winecoreaudio: Lock sessions in AudioClient's Start. winepulse: Lock sessions in AudioClient's Start. https://gitlab.winehq.org/wine/wine/-/merge_requests/2994

4 14

[PATCH v2 0/1] MR3002: wldap32: Fix memory leak on error path in ldap_start_tls_sW (scan-build).
by Alex Henrie (＠alexhenrie) 07 Jun '23

07 Jun '23

-- v2: wldap32: Fix memory leak on error path in ldap_start_tls_sW (scan-build). https://gitlab.winehq.org/wine/wine/-/merge_requests/3002

3 2

[PATCH 0/1] MR3001: hhctrl: Fix memory leak on error path in resolve_filename (scan-build).
by Alex Henrie (＠alexhenrie) 07 Jun '23

07 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3001

3 2

[PATCH 0/1] MR2996: dnsapi: Fix memory leak on error path in do_query_netbios (scan-build).
by Alex Henrie (＠alexhenrie) 07 Jun '23

07 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2996

3 2

[PATCH v15 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 07 Jun '23

07 Jun '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v15: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

2 7

[PATCH v2 0/9] MR2994: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's SetEventHandle, Reset, Stop, Start into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 07 Jun '23

07 Jun '23

-- v2: wineoss: Use mmdevapi's AudioClient's Start. winecoreaudio: Use mmdevapi's AudioClient's Start. winealsa: Use mmdevapi's AudioClient's Start. winepulse: Move AudioClient's Start into mmdevapi. winepulse: Lock sessions and handle CreateThread failure in AudioClient's Start. https://gitlab.winehq.org/wine/wine/-/merge_requests/2994

3 12

[PATCH v2 0/1] MR2980: kerberos: Fix memory leaks in (wow64_)query_ticket_cache (scan-build).
by Alex Henrie (＠alexhenrie) 07 Jun '23

07 Jun '23

-- v2: kerberos: Fix memory leaks in (wow64_)query_ticket_cache (scan-build). https://gitlab.winehq.org/wine/wine/-/merge_requests/2980

3 3

[PATCH 0/10] MR2993: comdlg32: IFileDialog navigation bar control. Part 1.
by Vladislav Timonin (＠vt) 07 Jun '23

07 Jun '23

Redo of !1857, as suggested, the plan is to split original MR in half, breadcrumbs in first (this) MR, and address edit in another. The changes are mostly cleanup (formatting, renaming, unused variables, missing free). Part two branch can be found [here](https://gitlab.winehq.org/vt/wine/-/commits/fd-navbar-part2). Visually, it hasn't changed: ![](/uploads/37038708b7500cda4f0cffde8981e58c/changes.png) Requires !2068, otherwise if application doesn't request comctl v6 (e.g. qapitrace), navigation bar will look like this: ![no-comctl-v6](/uploads/03e6a8b6dcf827114157e79640e49fea/no-comctl-v6.png) Closes: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=54812 - https://bugs.winehq.org/show_bug.cgi?id=50338 (partially? fully with address edit?) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2993

3 11

[PATCH 0/2] MR225: vkd3d-shader/tpf: Read complete swizzle/mask info from parameter tokens.
by Conor McCarthy (＠cmccarthy) 07 Jun '23

07 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/225

2 2

[PATCH 0/9] MR2994: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's SetEventHandle, Reset, Stop, Start into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 06 Jun '23

06 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2994

2 9

[PATCH v13 0/12] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 06 Jun '23

06 Jun '23

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - ~~first crumb is always moved here~~ - removes the split, if there are no items in the menu - hidden crumbs are moved here - left ~~or right~~ click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v13: comdlg32: Add Ctrl+Backspace delete word to IFileDialog address edit. comdlg32: Use path word break in IFileDialog address edit. comctl32: Fix PathWordBreakProc. comdlg32: Keep IExplorerBrowser in IFileDialog focused after Backspace. fixup: comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar. comdlg32: Enable visual styles when showing IFileDialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

6 22

[PATCH v2 0/5] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 06 Jun '23

06 Jun '23

The test has a little inspiration from the SDK samples. -- v2: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. mf: Don't make stream sink shutdown dependent on IMFActivate presence in node. mf: Don't leak sink in session_get_renderer_node_service(). mf: Clear queued topologies on session shutdown. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

4 17

[PATCH 0/5] MR2988: uiautomationcore: Add support for raising in-process events.
by Connor McAdams (＠cmcadams) 06 Jun '23

06 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2988

3 14

Re: [PATCH v2 0/1] MR2984: wineusb: Fix memory leaks on error paths in usb_submit_urb (scan-build). - approved
by Alexandre Julliard (＠julliard) 06 Jun '23

06 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2984

1 0

Re: [PATCH v2 0/1] MR2989: winex11: Ignore BadWindow errors caused by XConfigureWindow. - approved
by Alexandre Julliard (＠julliard) 06 Jun '23

06 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2989

1 0

Re: [PATCH v2 0/1] MR2991: Ignore Thumb flag when parsing ARM syscall number - approved
by Alexandre Julliard (＠julliard) 06 Jun '23

06 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2991

1 0

Re: [PATCH v2 0/1] MR2983: winevulkan: Include function name in asserts. - approved
by Alexandre Julliard (＠julliard) 06 Jun '23

06 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2983

1 0

Re: [PATCH v2 0/2] MR2987: msvcr100: Use Context blocking in event class and wait(). - approved
by Alexandre Julliard (＠julliard) 06 Jun '23

06 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2987

1 0

Re: [PATCH v2 0/1] MR2990: make_unicode: Don't use Türkiye as it can't be encoded in some locales. - approved
by Alexandre Julliard (＠julliard) 06 Jun '23

06 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2990

1 0

Re: [PATCH v7 0/10] MR2908: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's GetService into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 06 Jun '23

06 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2908

1 0

Re: [PATCH v3 0/1] MR2976: msvcrt: Use 'else if' in _wgetcwd. - approved
by Alexandre Julliard (＠julliard) 06 Jun '23

06 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2976

1 0

Re: [PATCH v2 0/1] MR2985: localspl: Fix memory leak in lpr_start_doc (scan-build). - approved
by Alexandre Julliard (＠julliard) 06 Jun '23

06 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2985

1 0

Re: [PATCH v4 0/2] MR2883: evr: Respect RGB format stride in GetCurrentImage. - approved
by Alexandre Julliard (＠julliard) 06 Jun '23

06 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2883

1 0

2025

2024

2023

2022

wine-gitlab