- wine-gitlab - winehq.org

[PATCH 0/1] MR2984: wineusb: Fix memory leaks on error paths in usb_submit_urb (scan-build).
by Alex Henrie (＠alexhenrie) 06 Jun '23

06 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2984

3 2

[PATCH v2 0/9] MR209: vkd3d-shader/hlsl: Broaden resources support v2, part 3.
by Francisco Casas (＠fcasas) 06 Jun '23

06 Jun '23

Mainly promoting single object components to variables for SM 5.0's RDEF block and lowering combined samplers to separate sampler+texture objects for SM 4. Following patches (including prepending uniform copies resource components within struct parameters) in: https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6c -- v2: vkd3d-shader/hlsl: Don't allocate all texture registers for synthetic separated samplers. vkd3d-shader/hlsl: Lower combined samplers to separate sampler and texture objects for SM4. vkd3d-shader/hlsl: Separate tracking of sampler_dim and usage for object components. vkd3d-shader/hlsl: Introduce hlsl_new_synthetic_var_named(). vkd3d-shader/hlsl: Check is_uniform instead of HLSL_STORAGE_UNIFORM when validating object refs. tests: Add lowering combined samplers tests. vkd3d-shader/hlsl: Handle resource components individually for SM 5.0. vkd3d-shader/tpf: Introduce struct extern_resource. vkd3d-shader/hlsl: Allow derefs to provide the data_type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/209

6 37

[PATCH 0/1] MR2991: Ignore Thumb flag when parsing ARM syscall number
by André Zwing (＠AndreRH) 06 Jun '23

06 Jun '23

Carried this a while in Hangover now -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2991

2 1

[PATCH 0/1] MR2983: winevulkan: Include function name in asserts.
by Joshua Ashton (＠joshua) 06 Jun '23

06 Jun '23

It is really useful to see at a glance what function is segfaulting/crashing here when debugging games/apps. This code is generated, and when generating WineVulkan against different Vulkan spec versions, etc it may be misleading that the Line: referred to by the assert dialog does not match what is generated locally on a different machine for the same Wine version/commit. Signed-off-by: Joshua Ashton <joshua(a)froggi.es> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2983

3 2

[PATCH 0/1] MR2959: include: Add windows.ui.xaml.hosting.desktopwindowxamlsource.idl file.
by Biswapriyo Nath (＠Biswa96) 06 Jun '23

06 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2959

2 2

[PATCH v3 0/1] MR2773: include: Add xamlom.idl file.
by Biswapriyo Nath (＠Biswa96) 06 Jun '23

06 Jun '23

-- v3: include: Add xamlom.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/2773

3 8

[PATCH 0/1] MR2990: make_unicode: Don't use Türkiye as it can't be encoded in some locales.
by Piotr Caban (＠piotr) 06 Jun '23

06 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2990

2 1

[PATCH 0/1] MR2989: winex11: Ignore BadWindow errors caused by XConfigureWindow.
by Akihiro Sagawa (＠sgwaki) 06 Jun '23

06 Jun '23

This typically happens when resizing a D3D child window. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54810 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2989

2 1

[PATCH 0/2] MR2987: msvcr100: Use Context blocking in event class and wait().
by Piotr Caban (＠piotr) 06 Jun '23

06 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2987

2 2

[PATCH v4 0/4] MR2918: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl.
by Zebediah Figura (＠zfigura) 06 Jun '23

06 Jun '23

-- v4: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/2918

4 9

[PATCH v6 0/10] MR2908: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's GetService into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 06 Jun '23

06 Jun '23

To be merged after !2907. -- v6: wineoss: Use mmdevapi's AudioClient's GetService. winecoreaudio: Use mmdevapi's AudioClient's GetService. winealsa: Use mmdevapi's AudioClient's GetService. winepulse: Move AudioClient's GetService into mmdevapi. winepulse: Lock sessions in AudioClient's GetService. wineoss: Use mmdevapi's session_wrapper_create. winecoreaudio: Use mmdevapi's session_wrapper_create. winealsa: Use mmdevapi's session_wrapper_create. winepulse: Move session_wrapper_create into mmdevapi. winepulse: Always initialize ref to 1 in session wrapper. https://gitlab.winehq.org/wine/wine/-/merge_requests/2908

3 11

[PATCH 0/1] MR2986: kernelbase: Allow AllocConsole() to proceed if the current console is...
by Zhiyi Zhang (＠zhiyi) 06 Jun '23

06 Jun '23

I am not sure how to add a proper test in this case because we run tests in a console. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2986

2 3

[PATCH v2 0/1] MR2976: msvcrt: Use 'else if' in _wgetcwd.
by Alex Henrie (＠alexhenrie) 06 Jun '23

06 Jun '23

Fixes a scan-build warning. -- v2: msvcrt: Use 'else if' in _wgetcwd. https://gitlab.winehq.org/wine/wine/-/merge_requests/2976

3 3

[PATCH v2 0/6] MR2981: win32u: Move asynchronous ClipCursor processing out of winex11.
by Rémi Bernon (＠rbernon) 06 Jun '23

06 Jun '23

This uses a new hardware message with Wine internal WM_WINE_CLIPCURSOR message, to notify the foreground window of ClipCursor calls, or resets. It could possibly have used posted messages, like is done to request the desktop to release the clipping rectangle but I figured that a hardware message could be appropriate and is possibly the preferred mechanism to notify the foreground window. We use QS_RAWINPUT for convenience here, as to automatically release the hardware message, and because this message is somewhat low-level. It could be anything, and maybe QS_MOUSEMOVE, but we'd have to then manually call accept_hardware_message from win32u. The desktop posted message is kept, as there's no guarantee that the foreground window will be processing its hardware messages when we need, and/or that the desktop window is foreground. -- v2: winex11: Remove now unnecessary ClipCursor forwarding to foreground thread. win32u: Asynchronously apply or reset ClipCursor from the hardware message. server: Queue a hardware WM_WINE_CLIPCURSOR message to the foreground thread. server: Use a separate helper to merge WM_MOUSEMOVE messages. server: Use the helper to reset the clip rect when the desktop size changes. win32u: Add a reset parameter to WM_WINE_CLIPCURSOR and driver ClipCursor. https://gitlab.winehq.org/wine/wine/-/merge_requests/2981

3 8

[PATCH v3 0/4] MR2958: mf: Various refcount leak fixes for session.
by Bernhard Kölbl (＠besentv) 06 Jun '23

06 Jun '23

-- v3: mfmediaengine/tests: Add refcount check for final release of media engine. https://gitlab.winehq.org/wine/wine/-/merge_requests/2958

4 8

[PATCH v5 0/10] MR2908: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's GetService into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 06 Jun '23

06 Jun '23

To be merged after !2907. -- v5: wineoss: Use mmdevapi's AudioClient's GetService. winecoreaudio: Use mmdevapi's AudioClient's GetService. winealsa: Use mmdevapi's AudioClient's GetService. winepulse: Move AudioClient's GetService into mmdevapi. winepulse: Lock sessions in AudioClient's GetService. wineoss: Use mmdevapi's session_wrapper_create. winecoreaudio: Use mmdevapi's session_wrapper_create. winealsa: Use mmdevapi's session_wrapper_create. winepulse: Move session_wrapper_create into mmdevapi. winepulse: Always initialize ref to 1 in session wrapper. https://gitlab.winehq.org/wine/wine/-/merge_requests/2908

3 13

[PATCH 0/6] MR2949: winegstreamer: Refactor media source stream creation.
by Rémi Bernon (＠rbernon) 06 Jun '23

06 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2949

3 8

[PATCH 0/1] MR2985: localspl: Fix memory leak in lpr_start_doc (scan-build).
by Alex Henrie (＠alexhenrie) 06 Jun '23

06 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2985

3 2

Re: [PATCH v2 0/2] MR37: vkd3d-shader: Add some DXIL support. - closed
by Conor McCarthy (＠cmccarthy) 06 Jun '23

06 Jun '23

This merge request was closed by Conor McCarthy. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/37

1 0

[PATCH v3 0/2] MR2883: evr: Respect RGB format stride in GetCurrentImage.
by Rémi Bernon (＠rbernon) 06 Jun '23

06 Jun '23

This fixes some upside-down videos in Secret of Mana. The game plays a NV12 video using MF session and EVR, then calls GetCurrentImage to get the frame RGB data and display it itself. -- v3: evr: Respect RGB format stride in GetCurrentImage. evr/tests: Test IMFVideoDisplayControl_GetCurrentImage orientation. https://gitlab.winehq.org/wine/wine/-/merge_requests/2883

3 5

[PATCH v4 0/11] MR2908: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's GetService into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 05 Jun '23

05 Jun '23

To be merged after !2907. -- v4: wineoss: Use mmdevapi's AudioClient's GetService. winecoreaudio: Use mmdevapi's AudioClient's GetService. winealsa: Use mmdevapi's AudioClient's GetService. winepulse: Move AudioClient's GetService into mmdevapi. wineoss: Use mmdevapi's session_wrapper_create. winecoreaudio: Use mmdevapi's session_wrapper_create. winealsa: Use mmdevapi's session_wrapper_create. winepulse: Move session_wrapper_create into mmdevapi. wineoss: Set session wrapper reference count correctly on creation. winecoreaudio: Set session wrapper reference count correctly on creation. winealsa: Set session wrapper reference count correctly on creation. https://gitlab.winehq.org/wine/wine/-/merge_requests/2908

4 14

[PATCH 0/2] MR199: Draft: tests: Make ddxddy.shader_test pass for different GPUs.
by Francisco Casas (＠fcasas) 05 Jun '23

05 Jun '23

On my Nvidia GeForce GTX 1050 Ti this test is not passing because of considerably different numeric results. As Giovanni pointed out, this is because my GPU uses the fine derivate and not the coarse derivate to implement ddx() and ddy(). Testing both ddx_coarse()|ddy_coarse() and ddx_fine()|ddy_fine() on the WARP driver shows that both these derivates are the same in coordinates where both X and Y are even, i.e. the first pixel of each 2x2 quad. So the test was modified to only probe on these coordinates. The new expected values were obtained from running the test using the WARP driver, and ulps adjusted for my GPU. However, this MR is marked as a draft because I would like to know if the test passes on other GPUs. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/199

3 6

[PATCH 0/7] MR2956: Draft: Use libjpeg-turbo for JPEG decoding
by Torge Matthies (＠tmatthies) 05 Jun '23

05 Jun '23

TODO: Fall back to `#undef WITH_SIMD` build if nasm/yasm is not found. JPEG decoding became much slower after a6ac035a7454c92bec367b2cd3021f8b98d4d807 because Wine no longer used the host libjpeg, which was usually provided by libjpeg-turbo. Use libjpeg-turbo in Wine instead of plain libjpeg. This adds a dependency on nasm or yasm to compile the i386/x86_64 assembly code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2956

3 12

Re: [PATCH v2 0/1] MR2966: comdlg32: Avoid crash in RemoveControlItem. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2966

1 0

Re: [PATCH v2 0/1] MR2955: winegstreamer: Fix check for non-zero padding in mf_media_type_from_wg_format_video(). - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2955

1 0

Re: [PATCH v2 0/1] MR2964: configure: stash host LDFLAGS when configuring cross-compilers - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2964

1 0

Re: [PATCH v4 0/1] MR2934: sapi: Add SpMMAudioOut stub. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2934

1 0

Re: [PATCH v3 0/2] MR2963: mf/tests: Test input and ouput type for WMA decoder DMO. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2963

1 0

Re: [PATCH v2 0/1] MR2974: conhost: Fix memory leak on error path in edit_line_move_to_history (scan-build). - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2974

1 0

Re: [PATCH v2 0/1] MR2978: jscript: Remove unnecessary call to malloc in strbuf_ensure_size. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2978

1 0

Re: [PATCH v2 0/1] MR2979: jscript: Fix memory leak on error path in String_replace (scan-build). - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2979

1 0

Re: [PATCH v2 0/1] MR2977: wbemprox: Fix memory leak on error path in create_view (scan-build). - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2977

1 0

Re: [PATCH v2 0/1] MR2975: msi: Fix memory leak in ready_media (scan-build). - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2975

1 0

Re: [PATCH v2 0/1] MR2973: msi: Make TransformView_Create static. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2973

1 0

Re: [PATCH v2 0/1] MR2972: msi: Return ERROR_OUTOFMEMORY if calloc fails in TransformView_Create (scan-build). - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2972

1 0

Re: [PATCH v2 0/1] MR2971: mscms: Fix double free on error path in EnumColorProfilesA (scan-build). - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2971

1 0

Re: [PATCH v2 0/1] MR2970: wusa: Fix double free on error path in read_update_package (scan-build). - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2970

1 0

Re: [PATCH v2 0/2] MR2967: msvcr100: Use Context blocking functions in critical_section class. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2967

1 0

Re: [PATCH v2 0/1] MR2960: kernelbase: Comment out DECLSPEC_HOTPATCH for ConvertThreadToFiber. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2960

1 0

Re: [PATCH v2 0/2] MR2962: ntdll: Simplify critical section timeout logic. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2962

1 0

Re: [PATCH v2 0/1] MR2961: wow32: Use spec file imports. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2961

1 0

Re: [PATCH v2 0/4] MR2931: uiautomationcore: Introduce helper function source file and more provider event adviser support. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2931

1 0

Re: [PATCH v2 0/1] MR222: vkd3d-shader/hlsl: Fix sampler type used for samplerCUBE. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/222

1 0

Re: [PATCH v3 0/1] MR220: vkd3d-shader/d3d-asm: Fix 3D sampler declaration instruction name. - approved
by Alexandre Julliard (＠julliard) 05 Jun '23

05 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/220

1 0

[PATCH 0/1] MR2966: comdlg32: Avoid crash in RemoveControlItem.
by Bernhard Übelacker (＠bernhardu) 05 Jun '23

05 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51640 First submission: https://www.winehq.org/pipermail/wine-devel/2021-December/202984.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2966

3 2

[PATCH 0/5] MR2981: win32u: Move asynchronous ClipCursor processing out of winex11.
by Rémi Bernon (＠rbernon) 05 Jun '23

05 Jun '23

This uses a new hardware message with Wine internal WM_WINE_CLIPCURSOR message, to notify the foreground window of ClipCursor calls, or resets. It could possibly have used posted messages, like is done to request the desktop to release the clipping rectangle but I figured that a hardware message could be appropriate and is possibly the preferred mechanism to notify the foreground window. We use QS_RAWINPUT for convenience here, as to automatically release the hardware message, and because this message is somewhat low-level. It could be anything, and maybe QS_MOUSEMOVE, but we'd have to then manually call accept_hardware_message from win32u. The desktop posted message is kept, as there's no guarantee that the foreground window will be processing its hardware messages when we need, and/or that the desktop window is foreground. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2981

3 8

[PATCH 0/1] MR222: vkd3d-shader/hlsl: Fix sampler type used for samplerCUBE.
by Nikolay Sivov (＠nsivov) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/222

6 5

[PATCH v2 0/1] MR220: vkd3d-shader/d3d-asm: Fix 3D sampler declaration instruction name.
by Nikolay Sivov (＠nsivov) 05 Jun '23

05 Jun '23

-- v2: vkd3d-shader/d3d-asm: Fix 3D sampler declaration instruction name. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/220

4 4

[PATCH 0/1] MR2976: msvcrt: Fix memory leak on error path in _wgetcwd (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2976

3 2

[PATCH 0/5] MR223: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 7.
by Zebediah Figura (＠zfigura) 05 Jun '23

05 Jun '23

BORING -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/223

3 6

Re: [PATCH v3 0/1] MR2934: sapi: Add SpMMAudioOut stub. - approved
by Huw Davies (＠huw) 05 Jun '23

05 Jun '23

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2934

1 0

[PATCH v14 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 05 Jun '23

05 Jun '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v14: ws2_32/tests: Add test for AF_UNIX sockets. server + ntdll/unix: Move getpeername() implementation to server. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 11

[PATCH 0/1] MR2980: kerberos: Fix memory leaks in (wow64_)query_ticket_cache (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2980

3 2

[PATCH 0/1] MR2974: conhost: Fix memory leak on error path in edit_line_move_to_history (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2974

3 2

[PATCH 0/1] MR2965: {server, ws2_32, ntdll}: Avoid using SOL_IPX to detect whether IPX is supported
by Billy Laws (＠bylaws) 05 Jun '23

05 Jun '23

4.18+ Linux kernels remove support for IPX but keep SOL_IPX defined, which causes compilation errors as wine unconditionally uses IPX structures if this is the case. Instead check for IPX_MTU to determine IPX support as it is defined within the ipx.h header itself. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2965

3 3

[PATCH 0/1] MR2978: jscript: Remove unnecessary call to malloc in strbuf_ensure_size.
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2978

3 2

[PATCH 0/1] MR2979: jscript: Fix memory leak on error path in String_replace (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2979

3 2

[PATCH v2 0/2] MR2963: mf/tests: Test input and ouput type for WMA decoder DMO.
by Ziqing Hui (＠zhui) 05 Jun '23

05 Jun '23

-- v2: mf/tests: Test output type for WMA decoder DMO. mf/tests: Test input type for WMA decoder DMO. https://gitlab.winehq.org/wine/wine/-/merge_requests/2963

3 3

[PATCH 0/1] MR2977: wbemprox: Fix memory leak on error path in create_view (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2977

3 2

[PATCH 0/1] MR2975: msi: Fix memory leak in ready_media (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

base_url was never freed, and can simply be enlarged instead of copying it to a new buffer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2975

3 2

[PATCH 0/1] MR2973: msi: Make TransformView_Create static.
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2973

3 2

[PATCH 0/1] MR2972: msi: Return ERROR_OUTOFMEMORY if calloc fails in TransformView_Create (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

Instead of ERROR_SUCCESS. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2972

3 2

[PATCH 0/1] MR2971: mscms: Fix double free on error path in EnumColorProfilesA (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

If fileW is not null, it is freed at the end of the function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2971

3 2

[PATCH 0/1] MR2970: wusa: Fix double free on error path in read_update_package (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

If read_identity returns FALSE, it has already called clear_identity. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2970

3 2

Re: [PATCH v2 0/5] MR2901: winegstreamer: Test and fix H264 timestamps and concatenated streams.
by Zebediah Figura (＠zfigura) 05 Jun '23

05 Jun '23

> It is not a matter of no-confidence, although I could argue that being told that my statements are non-sensical in several occasions isn't a great way to build confidence. I suspect I know at least one of the occasions you're referring to, and I'd like to apologize for that. It's never been my intent to demean or insult, and I'm sorry for having done so anyway. I will try to be more mindful of my language in the future. > I took maintainership of the wg_transform code, not just because I wrote most of it, but also in order to help with the bandwidth, and avoid bothering two persons on every single change. I believe I have taken every comment into account very carefully, and haven't bypassed your review or Nikolay's for MF related things, on any meaningful change. I appreciate the wish to reduce my workload, and I will gladly agree that my reviews have been acknowledged. As I've stated, though, I would still like the opportunity to perform those reviews on any winegstreamer changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2901#note_34600

1 0

[PATCH 0/1] MR2968: include: Annotate SHAlloc with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 04 Jun '23

04 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2968

3 2

[PATCH 0/1] MR2969: include: Annotate IoAllocate functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 04 Jun '23

04 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2969

2 1

[PATCH 0/2] MR2967: msvcr100: Use Context blocking functions in critical_section class.
by Piotr Caban (＠piotr) 04 Jun '23

04 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2967

2 2

[PATCH v12 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 03 Jun '23

03 Jun '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v12: ws2_32/tests: Add test for AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 11

[PATCH 0/1] MR2964: configure: stash host LDFLAGS when configuring cross-compilers
by Billy Laws (＠bylaws) 03 Jun '23

03 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2964

2 1

[PATCH 0/1] MR2960: kernelbase: Comment out DECLSPEC_HOTPATCH for ConvertThreadToFiber.
by Rémi Bernon (＠rbernon) 03 Jun '23

03 Jun '23

Should be fixing the constant MR failures, though I don't know how critical DECLSPEC_HOTPATCH is. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2960

5 6

[PATCH v2 0/4] MR2958: mf: Various refcount leak fixes for session.
by Bernhard Kölbl (＠besentv) 03 Jun '23

03 Jun '23

-- v2: mfmediaengine/tests: Add refcount checks for final release of media engine. https://gitlab.winehq.org/wine/wine/-/merge_requests/2958

3 6

[PATCH 0/2] MR2963: mf/tests: Test input and ouput type for WMA decoder DMO.
by Ziqing Hui (＠zhui) 03 Jun '23

03 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2963

3 5

[PATCH v2 0/1] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 03 Jun '23

03 Jun '23

-- v2: vkd3d-shader: Implement GetDimensions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

3 5

[PATCH 0/3] MR2958: mf: Various refcount leak fixes for session.
by Bernhard Kölbl (＠besentv) 03 Jun '23

03 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2958

3 5

[PATCH 0/2] MR219: vkd3d-shader: Implement text2Dproj().
by Nikolay Sivov (＠nsivov) 03 Jun '23

03 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/219

4 16

[PATCH 0/2] MR2962: ntdll: Simplify critical section timeout logic.
by Zebediah Figura (＠zfigura) 02 Jun '23

02 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2962

2 2

[PATCH 0/1] MR2961: wow32: Use spec file imports.
by Zebediah Figura (＠zfigura) 02 Jun '23

02 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2961

3 2

[PATCH 0/4] MR2931: uiautomationcore: Introduce helper function source file and more provider event adviser support.
by Connor McAdams (＠cmcadams) 02 Jun '23

02 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2931

3 5

[PATCH v3 0/4] MR2918: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl.
by Zebediah Figura (＠zfigura) 02 Jun '23

02 Jun '23

-- v3: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/2918

3 5

[PATCH v4 0/5] MR207: vkd3d-shader/hlsl: Support non-constant offset dereferences, part 1
by Francisco Casas (＠fcasas) 02 Jun '23

02 Jun '23

Indexing with non-constants offsets requires relative addressing in SM4. In assembly, this is written like in the following example: ``` x1[r1.x + 3] ``` The first part of this patch series only includes support for indexing vectors with non-constant indexes. Following patches in https://gitlab.winehq.org/fcasas/vkd3d/-/commits/nonconst-offsets-3. --- Non-constant indexing of vectors cannot be implemented with relative addressing in SM4 because this indexation cannot be performed at the level of register-components, only whole registers. Mathematical operations must be used instead. For floats, the native compiler seems to index an identity matrix, to get the i-th column, and then proceedes to compute the dot product between that column and the vector. For ints, bit operations seem to be performed. While probably less efficient, this implementation complies with the type-checking at the IR level and when writing bytecode. -- v4: vkd3d-shader/hlsl: Support non-constant vector indexing. vkd3d-shader/hlsl: Lower dot for non-float types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/207

3 6

Re: [PATCH v2 0/6] MR2930: dxgi: Refactor D3D12 swapchain (first part) - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2930

1 0

Re: [PATCH v2 0/4] MR2950: winex11, win32u, server: Tweak cursor clipping reset conditions. - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2950

1 0

Re: [PATCH v2 0/1] MR2952: winegstreamer: Pass a QWORD pointer to IMFByteStream_GetLength. - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2952

1 0

Re: [PATCH v4 0/5] MR2893: winegstreamer: Implement drain, flush and low-latency for the H264 decoder. - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2893

1 0

Re: [PATCH v6 0/3] MR2905: sapi: implement more token functionality. - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2905

1 0

Re: [PATCH v3 0/1] MR2954: iphlpapi/tests: Use ~0u instead of ~0ul in testGetIpNetTable. - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2954

1 0

Re: [PATCH v4 0/2] MR2866: server: Update parent window region when exposing previously invisible window. (#54949) - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2866

1 0

Re: [PATCH v3 0/4] MR2830: Reimplement dbghelp.EnumerateLoadedModules. - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2830

1 0

Re: [PATCH v3 0/2] MR2921: winebuild: Simplify some assembly in the 16-bit support routines. - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2921

1 0

Re: [PATCH v3 0/4] MR2919: winsock: Make more waits alertable. - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2919

1 0

Re: [PATCH v2 0/1] MR2953: bcrypt/tests: Don't allocate inside todo_wine and free outside of it. - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2953

1 0

Re: [PATCH v3 0/1] MR2946: iphlpapi: Add GetPerTcpConnectionEStats stub. - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2946

1 0

Re: [PATCH v3 0/1] MR2946: iphlpapi: Add GetPerTcpConnectionEStats stub. - approved
by Alexandre Julliard (＠julliard) 02 Jun '23

02 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2946

1 0

[PATCH 0/6] MR2930: dxgi: Refactor D3D12 swapchain (first part)
by Giovanni Mascellani (＠giomasce) 02 Jun '23

02 Jun '23

The D3D12 swapchain code is currently quite messy, probably because it was originally designed around the direct usage of the Vulkan swapchain images, then the support for user buffers was added, and the original design was later phased out. Currently the internal state can be divided in two different sets of objects: the "D3D12 side", which is visible to the `IDXGISwapChain` client and must be preserved at all times (except on the client's request, i.e., when `UpdateBuffers()` is called) and the "Vulkan side" which is private and can be destroyed and recreated more or less transparently (in case the Vulkan swapchain goes out of date or some settings are updated). This MR begins the process of de-intertwining the helpers that act on one or the other sides, so that the structure of the code is made clearer. The full patch set is at https://gitlab.winehq.org/giomasce/wine/-/commits/chianti. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2930

3 7

[PATCH v4 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 02 Jun '23

02 Jun '23

This is to prevent NULL pointers when creating a TextService with no rows in it. This NULL pointers doesn't happen when creating a richedit windows, because it sets an empty text when the richedit window procedure handles the WM_CREATE event. -- v4: riched20: Call ME_UpdateRepaint instead of editor_ensure_visible in set_selection. https://gitlab.winehq.org/wine/wine/-/merge_requests/2941

2 1

[PATCH v3 0/2] MR2941: riched20: Set empty text by default in CreateTextServices.
by Santino Mazza (＠tati1454) 02 Jun '23

02 Jun '23

This is to prevent NULL pointers when creating a standalone text service that doesn't have any text set and then using functions like EM_SETSEL. This NULL pointers doesn't happen when creating a richedit windows, because it sets an empty text when the richedit window procedure handles the WM_CREATE event. -- v3: riched20: Check if row is null in editor_ensure_visible. riched20: Return NULL if no row is found in row_from_cursor. https://gitlab.winehq.org/wine/wine/-/merge_requests/2941

3 4

[PATCH 0/1] MR2955: winegstreamer: Fix check for non-zero padding in mf_media_type_from_wg_format_video().
by Zhiyi Zhang (＠zhiyi) 02 Jun '23

02 Jun '23

Similar to 35f9091, IsRectEmpty() is the wrong way to check if padding is empty. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2955

3 3

[PATCH 0/1] MR2952: winegstreamer: Pass a QWORD pointer to IMFByteStream_GetLength.
by Alex Henrie (＠alexhenrie) 02 Jun '23

02 Jun '23

Fixes warnings on GCC 13. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2952

3 2

[PATCH v3 0/5] MR2893: winegstreamer: Implement drain, flush and low-latency for the H264 decoder.
by Rémi Bernon (＠rbernon) 02 Jun '23

02 Jun '23

-- v3: winegstreamer: Implement MF_LOW_LATENCY attribute and latency query. winegstreamer: Pass desired input queue length to wg_transform_create. winegstreamer: Pass desired output plane alignment to wg_transform_create. winegstreamer: Implement MFT_MESSAGE_COMMAND_FLUSH for the H264 decoder. winegstreamer: Implement MFT_MESSAGE_COMMAND_DRAIN for the H264 decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/2893

5 9

2025

2024

2023

2022

wine-gitlab