- wine-gitlab - winehq.org

Re: [PATCH v3 0/1] MR2934: sapi: Add SpMMAudioOut stub.
by Shaun Ren (＠shaunren) 02 Jun '23

02 Jun '23

On Fri Jun 2 17:22:54 2023 +0000, Huw Davies wrote: > Could you split this MR into two or three smaller ones? - just force > push the first few commits to this one, then, once this is merged, send > the next one. Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2934#note_34477

1 0

[PATCH v5 0/3] MR2905: sapi: implement more token functionality.
by Shaun Ren (＠shaunren) 02 Jun '23

02 Jun '23

-- v5: sapi: Implement token filtering and sorting in ISpObjectTokenEnumBuilder. https://gitlab.winehq.org/wine/wine/-/merge_requests/2905

3 4

[PATCH v2 0/5] MR2944: winewayland.drv: First window contents on screen
by Alexandros Frantzis (＠afrantzis) 02 Jun '23

02 Jun '23

The goal of this MR is to set up the minimum necessary infrastructure to display the contents of some simple, software rendered windows. This involves two major steps: 1. Associate a window with a Wayland surface and give it the `xdg_toplevel` role, so that the compositor can display it. We also have to implement the required initial `xdg_surface` configuration sequence to be able to safely (i.e., without the compositor disconnecting us with an error) attach buffers to the surface in step (2). 2. Implement the `window_surface` interface for the Wayland driver. For now we provide a simple (and suboptimal) `window_surface_flush` implementation: for each flush we create a new `wl_shm` buffer, copy the whole window contents (ignoring damaged bounds for now) into it and attach it to the target Wayland surface. In the next MR I will optimize this implementation in multiple ways: a. implement a buffer queue to avoid constantly allocating new buffers b. respect the damaged bounds of the `window_surface` to minimize copying of data from the `window_surface` to the SHM buffer (and also for correctness) c. communicate damaged surface regions to the compositor to (potentially) allow more efficient texture uploads. With this MR many (software-rendered) applications can now display dynamic content on screen. We can't interact with the apps yet, but we do get to enjoy `notepad` in all its blinking-cursor glory. Thanks! -- v2: winewayland.drv: Implement a simple window_surface flush. https://gitlab.winehq.org/wine/wine/-/merge_requests/2944

3 20

[PATCH v2 0/1] MR2954: iphlpapi/tests: Use ~0u instead of ~0ul in testGetIpNetTable.
by Alex Henrie (＠alexhenrie) 02 Jun '23

02 Jun '23

Fixes warnings on GCC 13. -- v2: iphlpapi/tests: Use ~0u instead of ~0ul in testGetIpNetTable. https://gitlab.winehq.org/wine/wine/-/merge_requests/2954

3 2

[PATCH 0/7] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu (＠insn) 02 Jun '23

02 Jun '23

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

3 15

[PATCH v3 0/2] MR2866: server: Update parent window region when exposing previously invisible window. (#54949)
by Jinoh Kang (＠iamahuman) 02 Jun '23

02 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54949 -- v3: server: Update parent window region when exposing previously invisible window. https://gitlab.winehq.org/wine/wine/-/merge_requests/2866

4 5

[PATCH v3 0/8] MR2908: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's GetService into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 02 Jun '23

02 Jun '23

To be merged after !2907. -- v3: wineoss: Use mmdevapi's AudioClient's GetService. winecoreaudio: Use mmdevapi's AudioClient's GetService. winealsa: Use mmdevapi's AudioClient's GetService. winepulse: Move AudioClient's GetService into mmdevapi. wineoss: Use mmdevapi's session_wrapper_create. winecoreaudio: Use mmdevapi's session_wrapper_create. winealsa: Use mmdevapi's session_wrapper_create. winepulse: Move session_wrapper_create into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2908

3 10

[PATCH 0/9] MR2934: sapi: Partially implement SpMMAudioOut.
by Shaun Ren (＠shaunren) 02 Jun '23

02 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2934

4 12

[PATCH v4 0/3] MR2905: sapi: implement more token functionality.
by Shaun Ren (＠shaunren) 02 Jun '23

02 Jun '23

-- v4: sapi: Implement token filtering and sorting in ISpObjectTokenEnumBuilder. sapi: Partially reimplement ISpObjectTokenEnumBuilder storing a token array. https://gitlab.winehq.org/wine/wine/-/merge_requests/2905

3 5

[PATCH v2 0/1] MR2957: win32u: Move QueryDisplayConfig from user32.
by Tatsuyuki Ishi (＠ishitatsuyuki) 02 Jun '23

02 Jun '23

This allows access to the in-process cached monitor list and reduces the number of registry calls issued for QueryDisplayConfig (in case of no change) from `4 x monitors` to `1`. -- v2: win32u: Move QueryDisplayConfig from user32. https://gitlab.winehq.org/wine/wine/-/merge_requests/2957

3 2

[PATCH 0/1] MR2957: win32u: Move QueryDisplayConfig from user32.
by Tatsuyuki Ishi (＠ishitatsuyuki) 02 Jun '23

02 Jun '23

This allows access to the in-process cached monitor list and reduces the number of registry calls issued for QueryDisplayConfig (in case of no change) from `4 x monitors` to `1`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2957

3 3

[PATCH v3 0/3] MR2274: ntdll: Add source file and line to debug traces.
by Rémi Bernon (＠rbernon) 02 Jun '23

02 Jun '23

-- v3: ntdll: Add return address information in __wine_debug_context. ntdll: Add file and line information in __wine_debug_context. ntdll: Introduce struct __wine_debug_context for extensible debug info. https://gitlab.winehq.org/wine/wine/-/merge_requests/2274

3 6

[PATCH 0/1] MR2953: bcrypt/tests: Don't allocate inside todo_wine and free outside of it.
by Alex Henrie (＠alexhenrie) 02 Jun '23

02 Jun '23

Fixes a warning on GCC 13. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2953

3 2

[PATCH v2 0/4] MR2830: Reimplement dbghelp.EnumerateLoadedModules.
by eric pouech (＠epo) 02 Jun '23

02 Jun '23

The aim of this serie is to (re)implement dbghelp.EnumerateLoadedModules in order to return correct 32bit & 64bit modules information for a 32bit debuggee from a 64bit debugger. - In this case, Wine ntdll (incorrectly) stores the paths in LdrData (for system modules) within the syswow64 directory while native stores them within the system32 directory (except for 32bit ntdll which Wine correctly stores within system32). - So now dbghelp implements the system32 => syswow64 path rewrite (for the relevant cases), which is currently used only for ntdll. - This allows: - to be transparent in dbghelp if ntdll is fixed to store the same path as native - the paths returned by dbghelp are consistent with native (in the 64bit debugger / 32bit debuggee case mentionned above) It must be noted that the remaining todo:s in tests are only for the case of a 32bit debugger / 32bit debuggee in (old|new) wow setup, where the returned paths are the (untouched from ntdll) paths, hence in syswow64 when native reports them from system32. - this patch doesn't modify the returned path, and we haven't noticed any issue so far - with redirection in place, access to the image files should be tranparent - so we can keep it as is (not fixing ntdll). -- v2: dbghelp: Reimplement EnumerateLoadedModules(). dbghelp/tests: Add more test wrt. modules's imagename handling. dbghelp/test: Review old-wow64 expected values. dbghelp/tests: Fix process kind detection on old Windows machines. https://gitlab.winehq.org/wine/wine/-/merge_requests/2830

2 6

[PATCH 0/1] MR2954: iphlpapi/tests: Use (DWORD)-1 instead of ~0ul in testGetIpNetTable.
by Alex Henrie (＠alexhenrie) 02 Jun '23

02 Jun '23

Fixes warnings on GCC 13. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2954

4 5

[PATCH v2 0/1] MR2946: iphlpapi: Add GetPerTcpConnectionEStats stub.
by Alex Henrie (＠alexhenrie) 02 Jun '23

02 Jun '23

Based on a patch by Austin English. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52868 -- v2: iphlpapi: Add GetPerTcpConnectionEStats stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2946

3 3

[PATCH v11 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 02 Jun '23

02 Jun '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v11: ws2_32/tests: Add test for AF_UNIX sockets. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

4 10

[PATCH v2 0/4] MR2918: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl.
by Zebediah Figura (＠zfigura) 01 Jun '23

01 Jun '23

-- v2: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl. xaudio2: Create XAPO objects directly from CreateAudioVolumeMeter() and CreateAudioReverb(). xaudio2: Move CreateAudioVolumeMeter() and CreateAudioReverb() to xapo.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/2918

3 6

[PATCH v2 0/4] MR2919: winsock: Make more waits alertable.
by Paul Gofman (＠gofman) 01 Jun '23

01 Jun '23

-- v2: ws2_32: Test wait alertability in WSAGetOverlappedResult(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2919

3 5

[PATCH v2 0/2] MR2921: winebuild: Simplify some assembly in the 16-bit support routines.
by Zebediah Figura (＠zfigura) 01 Jun '23

01 Jun '23

-- v2: winebuild: Use the lretw mnemonic in wine_call_to_16(). winebuild: Use segment prefixes in 16-bit stack switching code instead of writing out byte values. https://gitlab.winehq.org/wine/wine/-/merge_requests/2921

2 3

[PATCH v2 0/1] MR2941: riched20: Set empty text by default in CreateTextServices.
by Santino Mazza (＠tati1454) 01 Jun '23

01 Jun '23

This is to prevent NULL pointers when creating a standalone text service that doesn't have any text set and then using functions like EM_SETSEL. This NULL pointers doesn't happen when creating a richedit windows, because it sets an empty text when the richedit window procedure handles the WM_CREATE event. -- v2: riched20: Set empty text by default in CreateTextServices. https://gitlab.winehq.org/wine/wine/-/merge_requests/2941

3 4

[PATCH v4 0/1] MR211: vkd3d-shader/hlsl: Support clip() intrinsic.
by Nikolay Sivov (＠nsivov) 01 Jun '23

01 Jun '23

-- v4: vkd3d-shader/hlsl: Support clip() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211

4 9

Re: [PATCH v2 0/1] MR2951: msvcr100: Fix next writer unblocking in reader_writer_lock::unlock. - approved
by Alexandre Julliard (＠julliard) 01 Jun '23

01 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2951

1 0

Re: [PATCH v2 0/3] MR2895: Get rid of some casts to self. - approved
by Alexandre Julliard (＠julliard) 01 Jun '23

01 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2895

1 0

Re: [PATCH v2 0/1] MR2933: kernelbase: Don't modify non-volatile regs in RaiseException() on x64. - approved
by Alexandre Julliard (＠julliard) 01 Jun '23

01 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2933

1 0

Re: [PATCH v3 0/2] MR2948: Xact fixes - approved
by Alexandre Julliard (＠julliard) 01 Jun '23

01 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2948

1 0

Re: [PATCH v2 0/1] MR2947: krnl386.exe16: Don't overflow when calculating size - approved
by Alexandre Julliard (＠julliard) 01 Jun '23

01 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2947

1 0

Re: [PATCH v2 0/1] MR2945: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 01 Jun '23

01 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2945

1 0

Re: [PATCH v2 0/5] MR2901: winegstreamer: Test and fix H264 timestamps and concatenated streams.
by Rémi Bernon (＠rbernon) 01 Jun '23

01 Jun '23

On Thu Jun 1 17:15:46 2023 +0000, Zebediah Figura wrote: > > Well I don't know that, it's been mostly a week without any activity > and it's not the first time winegstreamer MR have been left unnoticed. I > have been upstreaming winegstreamer patches for a big part of last year > and the slow iteration have been making it very difficult. We have > patches piling up in Proton once again, and diverging implementations > already. I would very much like to avoid getting in the same situation > as we've been. > It had been six days, which is nominally a bit slow, but the slowness > was largely due to (a) multiple winegstreamer patches from you in that > time [and while I appreciate smaller patch series, that doesn't mean > that I'm going to review three patch series all in the same day], (b) > the weekend, (c) a US holiday during which I wasn't doing any work, and > (d) patch 5/5 which does multiple things at once and was therefore hard > to read. > > I don't think these changes present any risk, they have been > thoroughly tested, by Paul and I, but also with a lot of Wine tests, and > the changes have been in Proton for a long while already. I also > maintain wg_transform and their client, so, although I'm happy to take > constructive comments, I'm ultimately going to be responsible for the changes. > As I've stated when the issue of maintainership was brought up last, I > still would very much like to be consulted on winegstreamer changes. > Whether they have been tested or not, I find that winegstreamer code has > been getting increasingly complex and difficult to maintain, in ways > that are fixable and in ways that aren't, and I see things that can be > improved in many incoming winegstreamer patches. > If you want to call for no-confidence in my maintainership, fine, but > please let's be clear about that and not abuse gitlab. It is not a matter of no-confidence, although I could argue that being told that my statements are non-sensical in several occasions isn't a great way to build confidence. Perhaps a matter of diverging opinions, but moreover it is a matter of trying hard to keep downstream from diverging. I took maintainership of the wg_transform code, not just because I wrote most of it, but also in order to help with the bandwidth, and avoid bothering two persons on every single change. I believe I have taken every comment into account very carefully, and haven't bypassed your review or Nikolay's for MF related things, on any meaningful change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2901#note_34369

1 0

[PATCH 0/1] MR2951: msvcr100: Fix next writer unblocking in reader_writer_lock::unlock.
by Piotr Caban (＠piotr) 01 Jun '23

01 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2951

2 1

Re: [PATCH v2 0/5] MR2901: winegstreamer: Test and fix H264 timestamps and concatenated streams.
by Zebediah Figura (＠zfigura) 01 Jun '23

01 Jun '23

> Well I don't know that, it's been mostly a week without any activity and it's not the first time winegstreamer MR have been left unnoticed. I have been upstreaming winegstreamer patches for a big part of last year and the slow iteration have been making it very difficult. We have patches piling up in Proton once again, and diverging implementations already. I would very much like to avoid getting in the same situation as we've been. It had been six days, which is nominally a bit slow, but the slowness was largely due to (a) multiple winegstreamer patches from you in that time [and while I appreciate smaller patch series, that doesn't mean that I'm going to review three patch series all in the same day], (b) the weekend, (c) a US holiday during which I wasn't doing any work, and (d) patch 5/5 which does multiple things at once and was therefore hard to read. > I don't think these changes present any risk, they have been thoroughly tested, by Paul and I, but also with a lot of Wine tests, and the changes have been in Proton for a long while already. I also maintain wg_transform and their client, so, although I'm happy to take constructive comments, I'm ultimately going to be responsible for the changes. As I've stated when the issue of maintainership was brought up last, I still would very much like to be consulted on winegstreamer changes. Whether they have been tested or not, I find that winegstreamer code has been getting increasingly complex and difficult to maintain, in ways that are fixable and in ways that aren't, and I see things that can be improved in many incoming winegstreamer patches. If you want to call for no-confidence in my maintainership, fine, but please let's be clear about that and not abuse gitlab. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2901#note_34367

1 0

Re: [PATCH v2 0/5] MR2901: winegstreamer: Test and fix H264 timestamps and concatenated streams.
by Rémi Bernon (＠rbernon) 01 Jun '23

01 Jun '23

On Thu Jun 1 16:21:55 2023 +0000, Zebediah Figura wrote: > > Rémi Bernon removed review request for @zfigura May 31, 2023, 10:57 AM > Please don't do that. > In this case it's fine since I've reviewed the patch and was going to > sign off on it anyway. Well I don't know that, it's been mostly a week without any activity and it's not the first time winegstreamer MR have been left unnoticed. I have been upstreaming winegstreamer patches for a big part of last year and the slow iteration have been making it very difficult. We have patches piling up in Proton once again, and diverging implementations already. I would very much like to avoid getting in the same situation as we've been. I don't think these changes present any risk, they have been thoroughly tested, by Paul and I, but also with a lot of Wine tests, and the changes have been in Proton for a long while already. I also maintain wg_transform and their client, so, although I'm happy to take constructive comments, I'm ultimately going to be responsible for the changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2901#note_34365

1 0

[PATCH 0/3] MR2895: Get rid of some casts to self.
by Michael Stefaniuc (＠mstefani) 01 Jun '23

01 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2895

3 5

Re: [PATCH v2 0/5] MR2901: winegstreamer: Test and fix H264 timestamps and concatenated streams.
by Zebediah Figura (＠zfigura) 01 Jun '23

01 Jun '23

> Rémi Bernon removed review request for @zfigura May 31, 2023, 10:57 AM Please don't do that. In this case it's fine since I've reviewed the patch and was going to sign off on it anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2901#note_34362

1 0

[PATCH 0/4] MR2950: winex11, win32u, server: Tweak cursor clipping reset conditions.
by Rémi Bernon (＠rbernon) 01 Jun '23

01 Jun '23

Moving some out of winex11 and better matching native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2950

3 5

[PATCH 0/1] MR220: vkd3d-shader/asm: Fix 3D samples declaration instruction name.
by Nikolay Sivov (＠nsivov) 01 Jun '23

01 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/220

4 3

[PATCH 0/1] MR2947: krnl386.exe16: Don't overflow when calculating size
by Alistair Leslie-Hughes (＠alesliehughes) 01 Jun '23

01 Jun '23

The application again the bug, passed 1 as the elem parameter which doubled the memory being allocated. When it overflowed (became negative), the value was passed into GlobalAlloc16 which then failed. GlobalAlloc16 takes a DWORD parameter, so the value isn't going to be truncated. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53092 Original patch by github user cracyc for winevdm. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2947

2 1

[PATCH 0/1] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 01 Jun '23

01 Jun '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

3 6

[PATCH v2 0/4] MR2908: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's GetService into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 01 Jun '23

01 Jun '23

To be merged after !2907. -- v2: wineoss: Use mmdevapi's AudioClient's GetService. winecoreaudio: Use mmdevapi's AudioClient's GetService. winealsa: Use mmdevapi's AudioClient's GetService. winepulse: Move AudioClient's GetService into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2908

4 7

[PATCH v2 0/5] MR2893: winegstreamer: Implement drain, flush and low-latency for the H264 decoder.
by Rémi Bernon (＠rbernon) 01 Jun '23

01 Jun '23

-- v2: winegstreamer: Implement MF_LOW_LATENCY attribute and latency query. winegstreamer: Pass desired input queue length to wg_transform_create. winegstreamer: Pass desired output plane alignment to wg_transform_create. winegstreamer: Implement MFT_MESSAGE_COMMAND_FLUSH for H264 decoder. winegstreamer: Implement MFT_MESSAGE_COMMAND_DRAIN for H264 decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/2893

3 7

[PATCH 0/1] MR2946: iphlpapi: Add GetPerTcpConnectionEStats stub.
by Alex Henrie (＠alexhenrie) 01 Jun '23

01 Jun '23

Based on a patch by Austin English. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52868 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2946

3 2

[PATCH 0/1] MR2945: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 31 May '23

31 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2945

2 1

Re: [PATCH v2 0/1] MR2943: loader: In macOS preloader, reserve top-down heap space for Wow64. - approved
by Alexandre Julliard (＠julliard) 31 May '23

31 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2943

1 0

Re: [PATCH v2 0/3] MR2939: user32/tests: Add more tests for ClipCursor. - approved
by Alexandre Julliard (＠julliard) 31 May '23

31 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2939

1 0

Re: [PATCH v2 0/5] MR2901: winegstreamer: Test and fix H264 timestamps and concatenated streams. - approved
by Alexandre Julliard (＠julliard) 31 May '23

31 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2901

1 0

Re: [PATCH v2 0/1] MR2940: user32: Remove now unused virtual screen helpers. - approved
by Alexandre Julliard (＠julliard) 31 May '23

31 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2940

1 0

[PATCH v2 0/4] MR2936: win32u: Preparatory changes for ClipCursor.
by Rémi Bernon (＠rbernon) 31 May '23

31 May '23

-- v2: win32u: Use WM_WINE_CLIPCURSOR / TRUE for empty clipping rect. win32u: Add a separate function to process WM_WINE_CLIPCURSOR. win32u: Move cursor clipping functions to input.c. win32u: Move some window functions to window.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/2936

3 5

Re: [PATCH v4 0/4] MR2907: wine{alsa,coreaudio,oss,pulse}: Move AudioClient2 into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 31 May '23

31 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2907

1 0

Re: [PATCH v3 0/1] MR2925: iphlpapi: Add GetCurrentThreadCompartmentId stub. - approved
by Alexandre Julliard (＠julliard) 31 May '23

31 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2925

1 0

Re: [PATCH v3 0/4] MR2936: win32u: Preparatory changes for ClipCursor. - approved
by Alexandre Julliard (＠julliard) 31 May '23

31 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2936

1 0

Re: [PATCH v2 0/1] MR2937: server: Use get_hardware_msg_bit consistently to classify messages. - approved
by Alexandre Julliard (＠julliard) 31 May '23

31 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2937

1 0

Re: [PATCH v2 0/2] MR2938: win32u: Don't use CDECL for gdi_dc_funcs entries. - approved
by Alexandre Julliard (＠julliard) 31 May '23

31 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2938

1 0

Re: [PATCH v2 0/1] MR2935: include: Fix the use of __getReg for aarch64/msvc mode - approved
by Alexandre Julliard (＠julliard) 31 May '23

31 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2935

1 0

Re: [PATCH v2 0/1] MR2935: include: Fix the use of __getReg for aarch64/msvc mode - approved
by Alexandre Julliard (＠julliard) 31 May '23

31 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2935

1 0

[PATCH 0/1] MR2935: include: Fix the use of __getReg for aarch64/msvc mode
by Martin Storsjö (＠mstorsjo) 31 May '23

31 May '23

Clang requires the __getReg function to be declared in addition to be declared as an intrinsic with the pragma. This fixes the following error: ../wine/include/winnt.h:2412:27: error: call to undeclared library function '__getReg' with type 'unsigned long long (int)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] return (struct _TEB *)__getReg(18); ^ ../wine/include/winnt.h:2412:27: note: include the header <intrin.h> or explicitly provide a declaration for '__getReg' 1 error generated. Signed-off-by: Martin Storsjö <martin(a)martin.st> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2935

4 4

[PATCH 0/5] MR2944: winewayland.drv: First window contents on screen
by Alexandros Frantzis (＠afrantzis) 31 May '23

31 May '23

The goal of this MR is to set up the minimum necessary infrastructure to display the contents of some simple, software rendered windows. This involves two major steps: 1. Associate a window with a Wayland surface and give it the `xdg_toplevel` role, so that the compositor can display it. We also have to implement the required initial `xdg_surface` configuration sequence to be able to safely (i.e., without the compositor disconnecting us with an error) attach buffers to the surface in step (2). 2. Implement the `window_surface` interface for the Wayland driver. For now we provide a simple (and suboptimal) `window_surface_flush` implementation: for each flush we create a new `wl_shm` buffer, copy the whole window contents (ignoring damaged bounds for now) into it and attach it to the target Wayland surface. In the next MR I will optimize this implementation in multiple ways: a. implement a buffer queue to avoid constantly allocating new buffers b. respect the damaged bounds of the `window_surface` to minimize copying of data from the `window_surface` to the SHM buffer (and also for correctness) c. communicate damaged surface regions to the compositor to (potentially) allow more efficient texture uploads. With this MR many (software-rendered) applications can now display dynamic content on screen. We can't interact with the apps yet, but we do get to enjoy `notepad` in all its blinking-cursor glory. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2944

3 6

[PATCH 0/1] MR2943: loader: In macOS preloader, reserve top-down heap space for Wow64.
by Tim Clem (＠tclem) 31 May '23

31 May '23

This region is currently only reserved for 32-bit processes, which puts Wow64 at a disadvantage. The larger address space means it's not often an issue, but it's better to be explicit. Adding the reservation also causes ntdll/unix/virtual.c to consider that region first when making Wow64 allocations, before continuing through to the lower reservations. (And that's important for, e.g., changes like MR !2879.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2943

2 1

[PATCH 0/1] MR2879: loader: In macOS preloader, don't unmap the reservation for builtin DLLs.
by Tim Clem (＠tclem) 31 May '23

31 May '23

This seems to be a holdover from when ntdll was a Mach-O winelib binary, so the reservation needed to be removed before it was dlopen'd. Now that it's PE, unmapping the reservation is unnecessary and leaves time for the system to reclaim it, thus requiring the potentially problematic relocation of ntdll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2879

4 9

[PATCH 0/4] MR2928: xmllite/writer: Implement more APIs
by David Kahurani (＠kahurani) 31 May '23

31 May '23

Implements or at least tries to implement: WriteName WriteQualifiedName WriteNmToken WriteEntityRef Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2928

3 11

[PATCH 0/1] MR2941: riched20: Set empty text by default in CreateTextServices.
by Santino Mazza (＠tati1454) 31 May '23

31 May '23

This is to prevent NULL pointers when creating a standalone text service that doesn't have any text set and then using functions like EM_SETSEL. This NULL pointers doesn't happen when creating a richedit windows, because it sets an empty text when the richedit window procedure handles the WM_CREATE event. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941

3 2

[PATCH 0/1] MR2940: user32: Remove now unused virtual screen helpers.
by Rémi Bernon (＠rbernon) 31 May '23

31 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2940

2 1

[PATCH 0/3] MR2939: user32/tests: Add more tests for ClipCursor.
by Rémi Bernon (＠rbernon) 31 May '23

31 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2939

2 3

[PATCH 0/2] MR2938: win32u: Don't use CDECL for gdi_dc_funcs entries.
by Jacek Caban (＠jacek) 31 May '23

31 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2938

4 4

[PATCH v3 0/4] MR2907: wine{alsa,coreaudio,oss,pulse}: Move AudioClient2 into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 31 May '23

31 May '23

To be merged after !2906. -- v3: wineoss: Use mmdevapi's AudioClient2. winecoreaudio: Use mmdevapi's AudioClient2. winealsa: Use mmdevapi's AudioClient2. winepulse: Move AudioClient2 into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2907

3 5

[PATCH v2 0/1] MR2925: iphlpapi: Add GetCurrentThreadCompartmentId stub.
by Alex Henrie (＠alexhenrie) 31 May '23

31 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54599 -- v2: iphlpapi: Add GetCurrentThreadCompartmentId stub and a test. https://gitlab.winehq.org/wine/wine/-/merge_requests/2925

3 3

[PATCH 0/1] MR2937: server: Use get_hardware_msg_bit consistently to classify messages.
by Rémi Bernon (＠rbernon) 31 May '23

31 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2937

3 2

[PATCH 0/4] MR2936: win32u: Preparatory changes for ClipCursor.
by Rémi Bernon (＠rbernon) 31 May '23

31 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2936

2 4

[PATCH 0/1] MR2933: kernelbase: Don't modify non-volatile regs in RaiseException() on x64.
by Paul Gofman (＠gofman) 31 May '23

31 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2933

3 2

Re: [PATCH v2 0/1] MR2927: imm32: Query the new input context in ImmAssociateContextEx / IACE_DEFAULT. - approved
by Alexandre Julliard (＠julliard) 30 May '23

30 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2927

1 0

Re: [PATCH v2 0/1] MR2932: dbghelp: Better handle very long C++ qualified identifiers in dwarf. - approved
by Alexandre Julliard (＠julliard) 30 May '23

30 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2932

1 0

Re: [PATCH v3 0/1] MR2915: mshtml: Allow protocols with no ports when checking target origin. - approved
by Alexandre Julliard (＠julliard) 30 May '23

30 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2915

1 0

Re: [PATCH v4 0/4] MR2906: wine{alsa,coreaudio,oss,pulse}: Move AudioClient3 into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 30 May '23

30 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2906

1 0

Re: [PATCH v2 0/1] MR2929: ntdll: Get rid of hacks for direct unix calls. - approved
by Alexandre Julliard (＠julliard) 30 May '23

30 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2929

1 0

Re: [PATCH v2 0/5] MR2924: jscript: RegExp fixes and improvements. - approved
by Alexandre Julliard (＠julliard) 30 May '23

30 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2924

1 0

Re: [PATCH v2 0/9] MR2923: explorer: Get rid of the wine_create_desktop entry point. - approved
by Alexandre Julliard (＠julliard) 30 May '23

30 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2923

1 0

Re: [PATCH v2 0/1] MR2926: winevulkan: Update to VK spec version 1.3.251. - approved
by Alexandre Julliard (＠julliard) 30 May '23

30 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2926

1 0

Re: [PATCH v2 0/2] MR2913: server: Small refactoring around clip cursor internal message. - approved
by Alexandre Julliard (＠julliard) 30 May '23

30 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2913

1 0

Re: [PATCH v2 0/2] MR2909: Xact corrections - approved
by Alexandre Julliard (＠julliard) 30 May '23

30 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2909

1 0

Re: [PATCH v2 0/5] MR2904: ntdll: Support VM placeholders (part 2 of 2) - approved
by Alexandre Julliard (＠julliard) 30 May '23

30 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2904

1 0

[PATCH v3 0/3] MR2905: sapi: implement more token functionality.
by Shaun Ren (＠shaunren) 30 May '23

30 May '23

-- v3: sapi: Implement token filtering and sorting in ISpObjectTokenEnumBuilder. https://gitlab.winehq.org/wine/wine/-/merge_requests/2905

3 7

[PATCH v3 0/5] MR207: vkd3d-shader/hlsl: Support non-constant offset dereferences, part 1
by Francisco Casas (＠fcasas) 30 May '23

30 May '23

Indexing with non-constants offsets requires relative addressing in SM4. In assembly, this is written like in the following example: ``` x1[r1.x + 3] ``` The first part of this patch series only includes support for indexing vectors with non-constant indexes. Following patches in https://gitlab.winehq.org/fcasas/vkd3d/-/commits/nonconst-offsets-3. --- Non-constant indexing of vectors cannot be implemented with relative addressing in SM4 because this indexation cannot be performed at the level of register-components, only whole registers. Mathematical operations must be used instead. For floats, the native compiler seems to index an identity matrix, to get the i-th column, and then proceedes to compute the dot product between that column and the vector. For ints, bit operations seem to be performed. While probably less efficient, this implementation complies with the type-checking at the IR level and when writing bytecode. -- v3: vkd3d-shader/hlsl: Support non-constant vector indexing. vkd3d-shader/hlsl: Lower dot for non-float types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/207

4 13

[PATCH v2 0/1] MR2915: mshtml: Allow protocols with no ports when checking target origin.
by Gabriel Ivăncescu (＠insn) 30 May '23

30 May '23

-- v2: mshtml: Handle protocols with no ports when checking target origin. https://gitlab.winehq.org/wine/wine/-/merge_requests/2915

3 2

[PATCH 0/1] MR2932: dbghelp: Better handle very long C++ qualified identifiers in dwarf.
by eric pouech (＠epo) 30 May '23

30 May '23

This fixes some crashes especially when dealing with very long C++ names (like template classes). Fortunately, dwarf internals don't require type lookup by name (eg. on forward declaration), so the impact of thrashing some names is limited. It's very likely native doesn't store directly these very long names (it could either store the qualified mangled name - which can be way shorter for template classes - or use the names in lexical hierarchy: both boil down to storing less information, and recompute it (unmangle or class hierarchy walk) upon request). But this would need a proper C++ support in dbghelp. Not for today. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2932

2 1

[PATCH 0/1] MR2915: mshtml: Allow protocols with no ports when checking target origin.
by Gabriel Ivăncescu (＠insn) 30 May '23

30 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2915

3 4

[PATCH v3 0/4] MR2906: wine{alsa,coreaudio,oss,pulse}: Move AudioClient3 into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 30 May '23

30 May '23

-- v3: wineoss: Use mmdevapi's AudioClient3. winecoreaudio: Use mmdevapi's AudioClient3. winealsa: Use mmdevapi's AudioClient3. winepulse: Move AudioClient3 into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2906

3 6

[PATCH 0/1] MR2929: ntdll: Get rid of hacks for direct unix calls.
by Jacek Caban (＠jacek) 30 May '23

30 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2929

2 1

[PATCH 0/2] MR2913: server: Small refactoring around clip cursor internal message.
by Rémi Bernon (＠rbernon) 30 May '23

30 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2913

2 3

[PATCH 0/5] MR2924: jscript: RegExp fixes and improvements.
by Gabriel Ivăncescu (＠insn) 30 May '23

30 May '23

The first patch is unrelated and a fix to a dumb mistake; I had forgotten that toggle() is a method and methods can have NULL output pointers (when return value is not needed), unlike getters. Sorry for the noise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2924

4 7

[PATCH 0/9] MR2923: explorer: Get rid of the wine_create_desktop entry point.
by Rémi Bernon (＠rbernon) 30 May '23

30 May '23

The `DF_WINE_CREATE_DESKTOP` desktop flag will allow win32u to check whether virtual desktop mode is used or not, and move more code out of winex11. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2923

3 10

[PATCH 0/1] MR2927: imm32: Query the new input context in ImmAssociateContextEx / IACE_DEFAULT.
by Rémi Bernon (＠rbernon) 30 May '23

30 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54991 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2927

2 1

[PATCH v3 0/1] MR171: Initialize a pointer for MSVC.
by Stefan Dösinger (＠stefan) 30 May '23

30 May '23

MSVC is too stupid to see that line 3058 will not run unless n_variants has been set together with variants in the switch statement below. -- v3: vkd3d-shader/hlsl: Make sure variants is initialized in declare_predefined_types(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/171

4 4

[PATCH v2 0/7] MR216: vkd3d: Prepare for tiled resource support.
by Conor McCarthy (＠cmccarthy) 30 May '23

30 May '23

-- v2: vkd3d: Append CopyTileMappings() commands to the command queue op array. vkd3d: Append UpdateTileMappings() commands to the command queue op array. vkd3d: Add missing const attributes to ID3D12CommandQueue::UpdateTileMappings() parameters. vkd3d: Validate plane count for tiled textures. vkd3d: Validate tiled resources tier for 3D textures. vkd3d: Always pass null heap properties to vkd3d_create_image() for sparse images. vkd3d: Check sparse image format is supported. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/216

2 8

[PATCH 0/1] MR2926: winevulkan: Update to VK spec version 1.3.251.
by Georg Lehmann (＠DadSchoorse) 30 May '23

30 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2926

2 1

[PATCH 0/1] MR2925: iphlpapi: Add GetCurrentThreadCompartmentId stub.
by Alex Henrie (＠alexhenrie) 30 May '23

30 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54599 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2925

3 2

Re: [PATCH 0/3] MR260: ntdll: Improve xstate validation in NtGetContextThread()
by Olivia/Isabelle Mahadevan (＠doubledge-spec) 30 May '23

30 May '23

would really like an update on this -- https://gitlab.winehq.org/wine/wine/-/merge_requests/260#note_34114

1 0

Re: [PATCH v13 0/5] MR2555: ntdll: Support ISOLATIONAWARE_MANIFEST_RESOURCE_ID (#18889) - approved
by Alexandre Julliard (＠julliard) 29 May '23

29 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2555

1 0

Re: [PATCH v2 0/5] MR2922: win32u: Use syscall interface for all exports. - approved
by Alexandre Julliard (＠julliard) 29 May '23

29 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2922

1 0

Re: [PATCH v8 0/5] MR2870: gdiplus: Support playing back pen custom end line cap. - approved
by Alexandre Julliard (＠julliard) 29 May '23

29 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2870

1 0

Re: [PATCH v5 0/1] MR2865: gdiplus: Handle Windows style newline. - approved
by Alexandre Julliard (＠julliard) 29 May '23

29 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2865

1 0

Re: [PATCH v2 0/8] MR2920: ole32: Use CRT functions for monikers. - approved
by Alexandre Julliard (＠julliard) 29 May '23

29 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2920

1 0

2025

2024

2023

2022

wine-gitlab