- wine-gitlab - winehq.org

Re: [PATCH v4 0/5] MR2722: dsound: Doppler shift (part 2) - approved
by Alexandre Julliard (＠julliard) 23 May '23

23 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2722

1 0

Re: [PATCH v2 0/6] MR2876: wineps: Fix some font related crashes and add AbortPrinter implementation - approved
by Alexandre Julliard (＠julliard) 23 May '23

23 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2876

1 0

Re: [PATCH v2 0/1] MR2880: win32u: Propagate WM_MOUSEHWHEEL to the parent window in DefWindowProc(). - approved
by Alexandre Julliard (＠julliard) 23 May '23

23 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2880

1 0

Re: [PATCH v3 0/5] MR205: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 5. - approved
by Alexandre Julliard (＠julliard) 23 May '23

23 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/205

1 0

Re: [PATCH v13 0/2] MR184: vkd3d-shader/hlsl: Add support for SampleGrad() method - approved
by Alexandre Julliard (＠julliard) 23 May '23

23 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/184

1 0

[PATCH 0/2] MR542: configure: Build with -mimpure-text if available when building with -fno-PIC.
by Zebediah Figura (＠zfigura) 23 May '23

23 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/542

4 6

[PATCH 0/1] MR2886: winedump: Recognize RISC-V PEs
by André Zwing (＠AndreRH) 23 May '23

23 May '23

(According to the PE specification) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2886

2 1

[PATCH v11 0/4] MR2864: gdiplus: Improve performance of GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 23 May '23

23 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Improve performance of GdipDrawImagePointsRect by: 1. avoiding multiplication and use addition where it is possible. 2. avoid calculating `GdipInvertMatrix` if it is not used. 3. avoid not needed TransformMatrixPoints I divided MR to several commits, to better undestand what is going on. Application for testing (it needs logo.jpg file): [gdiplusdrawimagepoints.exe](/uploads/545ff7d8ab1d60386366f64999346825/gdiplusdrawimagepoints.exe) --… [View More]

3 5

[PATCH v4 0/3] MR2833: wined3d: Optimize lights handling.
by Paul Gofman (＠gofman) 23 May '23

23 May '23

This fixes a performance regression introduced during state redesign shortly after Wine 5.0. Some games create a great amount of lights (around 1000 and growing) and touch them quite often. That results in each light being relayed to CS thread before each draw which is taking a great amount of time (performance drop in Nosferatu: The Wrath of Malachi from ~150 fps to ~10-15 at start location; that's with another unrelated regression related to streaming buffer management sorted out). It is … [View More]

3 5

[PATCH 0/5] MR2881: winegstreamer: Implement Discontinuity and GetInputStatus for WMV decoder DMO.
by Ziqing Hui (＠zhui) 23 May '23

23 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2881

4 7

[PATCH v2 0/2] MR2849: comdlg32: Make item dialog and file access dialogs a bit more HiDPI friendly.
by Jactry Zeng (＠jactry) 23 May '23

23 May '23

Toolbar buttons won't adjust its size to fit the DPI setting. This two patches set a DPI-considered size to those buttons to make them look better in HiDPI. Here are some comparisons on Wine with 192 DPI: ![get_open_file_before](/uploads/3e786396666fd84d824a4fa1e881d712/get_open_file_before.png) vs ![get_open_file_after](/uploads/f6f3ed910e026d94635ba9cae8f1cc81/get_open_file_after.png) ![item_dialog_before](/uploads/936fab928adb54a3bdf055190332c30d/item_dialog_before.png) vs ![… [View More]

3 4

[PATCH v2 0/5] MR205: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 5.
by Zebediah Figura (＠zfigura) 23 May '23

23 May '23

Pass struct hlsl_constant_value to folding functions, in preparation for creating the destination constant instruction from that value. -- v2: vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_nequal(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_mul(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_add(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_neg(). … [View More]

3 6

[PATCH v4 0/5] MR2870: gdiplus: Support playing back pen custom end line cap.
by Zhiyi Zhang (＠zhiyi) 23 May '23

23 May '23

Fix Cafe Stella (SteamID: 1829980) Flowchart crashes once there are 2 things on it. -- v4: gdiplus: Support playing back pen custom end line cap. gdiplus: Support playing back pen custom start line cap. gdiplus: Support recording pen custom end line cap. gdiplus: Support recording pen custom start line cap. gdiplus/tests: Add pen custom line cap record and play back tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2870

3 7

[PATCH 0/1] MR2885: qcap/tests: Remove duplicated tests for allocator identity.
by Zebediah Figura (＠zfigura) 23 May '23

23 May '23

We test once above that the source does not use the existing allocator, but then implicitly release the allocator we are testing against (when the source assigns a new allocator to the sink). As a result, these ok() statements were testing that newly allocated allocators had a different address than the original allocator, which of course sometimes fails. Since we don't need to perform this test more than once anyway, just get rid of the offending ok() statements. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2885

2 1

[PATCH v5 0/6] MR2712: winewayland.drv: part 3: Handle dynamic wl_output events
by Alexandros Frantzis (＠afrantzis) 23 May '23

23 May '23

This MR introduces the driver mechanisms to handle dynamic events from the Wayland compositor, using wl_output events as the guiding use case (i.e., we want to update the win32u display settings when the host settings change). In this design we create a dedicated thread to read and dispatch Wayland events received from the compositor. If a Wayland event handler wants some code to be run in the context of a particular HWND's thread, it can add an internal event to a custom queue we have for … [View More]

3 10

[PATCH 0/4] MR2884: uiautomationcore: Add support for creating/destroying HUIAEVENTs.
by Connor McAdams (＠cmcadams) 23 May '23

23 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2884

3 5

Re: [PATCH v4 0/1] MR1919: winex11.drv: Fix compilation error: variable set but not used [-Werror=unused-but-set-variable]. - closed
by Bartosz Kosiorek (＠gang65) 23 May '23

23 May '23

This merge request was closed by Bartosz Kosiorek. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1919

1 0

[PATCH v7 0/5] MR2555: ntdll: Support ISOLATIONAWARE_MANIFEST_RESOURCE_ID (#18889)
by Jinoh Kang (＠iamahuman) 23 May '23

23 May '23

From Microsoft documentation, [Using Side-by-Side Assemblies as a Resource][sxs-rsrc] outlines the significance of each reserved manifest resource ID. Further investigation reveals the following: 1. `CREATEPROCESS_MANIFEST_RESOURCE_ID` (value: `1`): This is used for process-wide initial (`NULL`) activation context. - **Usage documentation**: [Enabling an Assembly in an Application Without Extensions](https://learn.microsoft.com/en-us/windows/win32/sbscs/enabling-… - **Intended … [View More]container module type**: EXE only. - **Lifetime of the associated activation context**: Alive until the process is terminated. Owned by system (NTDLL). - **Isolation-aware**: No. 2. `ISOLATIONAWARE_MANIFEST_RESOURCE_ID` (value: `2`): This is used to specify the assembly manifest that the loader (Ldr) uses to resolve static imports. Also, this is used by isolation-aware wrappers defined in `*.inl` files included in the Windows SDK (`include\um`) when the `ISOLATION_AWARE_ENABLED` macro is defined as a nonzero value. - **Usage documentation**: [Enabling an Assembly in an Application Hosting a DLL, Extension, or Control Panel](https://learn.microsoft.com/en-us/windows/win32/sbscs/enabling-an-as… - **Intended container module type**: EXE and DLL. - **Lifetime of the associated activation context**: Alive until the module is unloaded (e.g., via `FreeLibrary`). Owned by system (NTDLL). - **Isolation-aware**: Yes. 3. `ISOLATIONAWARE_NOSTATICIMPORT_MANIFEST_RESOURCE_ID` (value: `3`): Ignored by the loader when resolving static imports. This is used by isolation-aware API wrappers defined in `*.inl` files included in the Windows SDK (`include\um`) when the `ISOLATION_AWARE_ENABLED` macro is defined as a nonzero value. - **Usage documentation**: [IsolationAwareCleanup function][IsolationAwareCleanup] - **Intended container module type**: EXE and DLL. - **Lifetime of the associated activation context**: Alive until the application calls [`IsolationAwareCleanup`][IsolationAwareCleanup][^ia-cleanup-note]. Owned by the isolation-aware API wrapper library (part of the Windows SDK, rather than being a system DLL). - **Isolation-aware**: Yes. The `ISOLATION_AWARE_ENABLED` macro is documented in [Isolating Components][sxs-ic] as well as [Specifying a Default Activation Context][sxs-def-actctx]. When `ISOLATION_AWARE_ENABLED` macro is defined as a nonzero value, then the isolation-aware API wrapper library is enabled. The isolation-aware API wrapper library is responsible for: - Creating (lazily) and destroying activation context (in `IsolationAwareCleanup`), if the manifest resource ID is `ISOLATIONAWARE_NOSTATICIMPORT_MANIFEST_RESOURCE_ID`.[^actctx-lifetime-remark] - Note: the isolation-aware API wrapper library does not manage the activation context's lifetime and delegates the responsibility to the system loader if the manifest resource ID is `ISOLATIONAWARE_MANIFEST_RESOURCE_ID`. - Intercepting Win32 API calls for automatic activation context activation. Each API wrapper activates the "isolation-aware" activation context (obtaining one if it did not exist) before calling the original procedure, and deactivates it before returning. The isolation-aware wrappers may be either be defined inline, or compiled into static libraries that are linked into the final application executable. From the information above as well as the tests included in this merge request, we can infer the following: 1. Although side-by-side awareness is a cross-cutting concern, the *activation* of activation contexts itself is *not* usually performed automatically by the system for the application (with the sole exception of process-wide activation context associated with `CREATEPROCESS_MANIFEST_RESOURCE_ID`, and static import resolution). 2. `ISOLATIONAWARE_NOSTATICIMPORT_MANIFEST_RESOURCE_ID` is treated like any other resource ID (from `0x0004` to `0xffff`) as far as the loader is concerned. 3. The resource ID of the manifest only concerns how the module containing the manifest intends to use the manifest. In fact, for DLLs that do not *statically* import symbols from side-by-side assemblies, the three resource IDs above are basically equivalent. A DLL can elect not to use manifest resources at all, and manage activation context and library loading by itself. This is why I believe that this merge request is sufficient in completing the isolation-aware component support in Wine; the heavy lifting is done in the application side, not the system. **EDIT**: Fix a few typos and unclear wording. --- [^ia-cleanup-note]: According to the documentation, the application is presumably responsible for calling `IsolationAwareCleanup` from `DllMain` on `fdwReason = DLL_PROCESS_DETACH`. [^actctx-lifetime-remark]: [IsolationAwareCleanup § Remarks](https://learn.microsoft.com/en-us/previous-versions/windows/deskto…, from Microsoft documentation. [sxs-rsrc]: https://learn.microsoft.com/en-us/windows/win32/sbscs/using-side-by-side-as… [IsolationAwareCleanup]: https://learn.microsoft.com/en-us/previous-versions/windows/desktop/legacy/… [sxs-ic]: https://learn.microsoft.com/en-us/windows/win32/sbscs/isolating-components [sxs-def-actctx]: https://learn.microsoft.com/en-us/windows/win32/sbscs/specifying-a-default-… Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=18889 -- v7: ntdll: Don't hard-code DLL manifest resource ID when looking up dependency assembly. kernel32/tests: Test loading assembly manifest resource inside dependencies. ntdll: Move ACTCTX lpResourceName validation to RtlCreateActivationContext. kernel32/tests: Test setting lpResourceName to NULL for CreateActCtxW. kernel32/tests: Remove test for ACTCTX_FLAG_HMODULE_VALID with hModule = NULL case. https://gitlab.winehq.org/wine/wine/-/merge_requests/2555 [View Less]

2 5

[PATCH v10 0/5] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks.
by Conor McCarthy (＠cmccarthy) 23 May '23

23 May '23

Block records are not processed; only the bitcode is validated. -- v10: vkd3d-shader/dxil: Read and validate global abbreviated operands. vkd3d-shader/dxil: Read and validate local abbreviated operands. vkd3d-compiler: Introduce dxbc-dxil and dxbc-auto source types. vkd3d-shader/dxbc: Introduce an option to autodetect the DXBC source type. vkd3d-shader/dxil: Read and validate DXIL bitcode unabbreviated blocks. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44

3 7

[PATCH v10 0/5] MR2864: gdiplus: Improve performance of GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 23 May '23

23 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Improve performance of GdipDrawImagePointsRect by: 1. avoiding multiplication and use addition where it is possible. 2. avoid calculating `GdipInvertMatrix` if it is not used. 3. avoid not needed TransformMatrixPoints I divided MR to several commits, to better undestand what is going on. Application for testing (it needs logo.jpg file): [gdiplusdrawimagepoints.exe](/uploads/545ff7d8ab1d60386366f64999346825/gdiplusdrawimagepoints.exe) --… [View More]

2 5

[PATCH v12 0/2] MR184: vkd3d-shader/hlsl: Add support for SampleGrad() method
by Ethan Lee (＠flibitijibibo) 23 May '23

23 May '23

~~This one's marked as a draft, as there seems to be a blocker with the method parameters.~~ ~~The first commit totally works, _if_ the ddx/ddy parameters are literals - they do _not_ work when passing a variable of any kind. The test comes from tests/d3d12.c, so I'm mostly just trying to migrate that to the HLSL test suite, but it currently hits an assert before we get to the resource load (which does eventually work) and I'm not sure what's causing it:~~ ``` vkd3d-compiler: libs/vkd3d-… [View More]

3 4

[PATCH v4 0/6] MR2712: winewayland.drv: part 3: Handle dynamic wl_output events
by Alexandros Frantzis (＠afrantzis) 23 May '23

23 May '23

This MR introduces the driver mechanisms to handle dynamic events from the Wayland compositor, using wl_output events as the guiding use case (i.e., we want to update the win32u display settings when the host settings change). In this design we create a dedicated thread to read and dispatch Wayland events received from the compositor. If a Wayland event handler wants some code to be run in the context of a particular HWND's thread, it can add an internal event to a custom queue we have for … [View More]

3 9

[PATCH v3 0/1] MR2869: winepulse: Implement is_format_supported in unixlib.
by Davide Beatrici (＠davidebeatrici) 23 May '23

23 May '23

-- v3: winepulse: Implement is_format_supported in unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2869

3 3

[PATCH 0/7] MR2882: d2d: Improve GDI interop support
by Nikolay Sivov (＠nsivov) 23 May '23

23 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2882

2 7

[PATCH v3 0/3] MR2868: wine{alsa,coreaudio,oss}: Implement get_device_period in unixlib.
by Davide Beatrici (＠davidebeatrici) 23 May '23

23 May '23

-- v3: wineoss: Implement get_device_period in unixlib. winecoreaudio: Implement get_device_period in unixlib. winealsa: Implement get_device_period in unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2868

3 4

[PATCH v3 0/5] MR2722: dsound: Doppler shift (part 2)
by Anton Baskanov (＠baskanov) 23 May '23

23 May '23

-- v3: dsound: Avoid division by zero when calculating Doppler shift. dsound: Change the speed of sound to 360. dsound: Enable Doppler shift. dsound/tests: Add tests for Doppler shift. dsound: Store the frequency of 3D buffers separately. https://gitlab.winehq.org/wine/wine/-/merge_requests/2722

3 7

[PATCH v9 0/4] MR2864: gdiplus: Improve performance of GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 23 May '23

23 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Improve performance of GdipDrawImagePointsRect by: 1. avoiding multiplication and use addition where it is possible. 2. avoid calculating `GdipInvertMatrix` if it is not used It gives noticible speed improvement. I divided MR to several commits, to better undestand what is going on. Application for testing (it needs logo.jpg file): [gdiplusdrawimagepoints.exe](/uploads/545ff7d8ab1d60386366f64999346825/gdiplusdrawimagepoints.exe) -- … [View More]

3 5

[PATCH v2 0/1] MR2869: winepulse: Implement is_format_supported in unixlib.
by Davide Beatrici (＠davidebeatrici) 23 May '23

23 May '23

-- v2: winepulse: Implement is_format_supported in unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2869

3 3

[PATCH v2 0/6] MR2722: dsound: Doppler shift (part 2)
by Anton Baskanov (＠baskanov) 23 May '23

23 May '23

-- v2: dsound: Avoid division by zero when calculating Doppler shift. dsound/tests: Test Doppler shift with zero distance. dsound: Change the speed of sound to 360. dsound: Enable Doppler shift. dsound/tests: Add tests for Doppler shift. dsound: Store the frequency of 3D buffers separately. https://gitlab.winehq.org/wine/wine/-/merge_requests/2722

3 11

[PATCH v2 0/3] MR2868: wine{alsa,coreaudio,oss}: Implement get_device_period in unixlib.
by Davide Beatrici (＠davidebeatrici) 23 May '23

23 May '23

-- v2: wineoss: Implement get_device_period in unixlib. winecoreaudio: Implement get_device_period in unixlib. winealsa: Implement get_device_period in unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2868

3 4

[PATCH 0/6] MR2876: wineps: Fix some font related crashes and AbortPrinter implementation
by Piotr Caban (＠piotr) 23 May '23

23 May '23

All of the patches were written for [bug 54956](https://bugs.winehq.org/show_bug.cgi?id=54956). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2876

3 7

[PATCH 0/1] MR2880: win32u: Propagate WM_MOUSEHWHEEL to the parent window in DefWindowProc().
by Brendan Shanks (＠bshanks) 23 May '23

23 May '23

This enables horizontal scrolling gestures/wheels (tested on macOS) in applications like IrfanView which handle WM_MOUSEHWHEEL. Support will need to be added to common controls for horizontal scrolling to work in programs like Wine's explorer or regedit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2880

2 1

[PATCH v8 0/4] MR2864: gdiplus: Improve performance of GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 23 May '23

23 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Improve performance of GdipDrawImagePointsRect by: 1. avoiding multiplication and use addition where it is possible. 2. avoid calculating `GdipInvertMatrix` if it is not used It gives noticible speed improvement. I divided MR to several commits, to better undestand what is going on. Application for testing (it needs logo.jpg file): [gdiplusdrawimagepoints.exe](/uploads/545ff7d8ab1d60386366f64999346825/gdiplusdrawimagepoints.exe) -- … [View More]

2 5

[PATCH v7 0/4] MR2864: gdiplus: Improve performance of GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 23 May '23

23 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Improve performance of GdipDrawImagePointsRect by: 1. avoiding multiplication and use addition where it is possible. 2. avoid calculating `GdipInvertMatrix` if it is not used It gives noticible speed improvement. I divided MR to several commits, to better undestand what is going on. Application for testing (it needs logo.jpg file): [gdiplusdrawimagepoints.exe](/uploads/545ff7d8ab1d60386366f64999346825/gdiplusdrawimagepoints.exe) -- … [View More]

3 6

[PATCH v6 0/4] MR2864: gdiplus: Improve performance of GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 23 May '23

23 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Improve performance of GdipDrawImagePointsRect by: 1. avoiding multiplication and use addition where it is possible. 2. avoid calculating `GdipInvertMatrix` if it is not used It gives noticible speed improvement. I divided MR to several commits, to better undestand what is going on. Application for testing (it needs logo.jpg file): [gdiplusdrawimagepoints.exe](/uploads/545ff7d8ab1d60386366f64999346825/gdiplusdrawimagepoints.exe) -- … [View More]

2 5

[PATCH v3 0/5] MR206: vkd3d-shader/hlsl: Implement SampleCmp() method.
by Nikolay Sivov (＠nsivov) 22 May '23

22 May '23

-- v3: vkd3d-shader/tpf: Write out comparison mode sampler declarations and corresponding sampling instruction. vkd3d-shader/hlsl: Parse SampleCmp() method. vkd3d-shader/hlsl: Parse SamplerComparisonState objects. vkd3d-shader/hlsl: Use a function table for object methods handlers. vkd3d-shader/hlsl: Move object type checks to methods handlers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/206

2 5

Re: [PATCH v2 0/5] MR2878: qcap: Audio capture filter implementation, part 4 of 4. - approved
by Alexandre Julliard (＠julliard) 22 May '23

22 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2878

1 0

Re: [PATCH v2 0/2] MR2877: uiautomationcore: A bug fix, and some header definitions. - approved
by Alexandre Julliard (＠julliard) 22 May '23

22 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2877

1 0

Re: [PATCH v7 0/1] MR2850: gdiplus: Fix GdipGetGenericFontFamily functions according to native gdiplus.dll - approved
by Alexandre Julliard (＠julliard) 22 May '23

22 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2850

1 0

Re: [PATCH v2 0/1] MR2871: winhttp: Fix a test failure. - approved
by Alexandre Julliard (＠julliard) 22 May '23

22 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2871

1 0

Re: [PATCH v2 0/2] MR2872: dinput: More BuildActionMap and work thread fixes. - approved
by Alexandre Julliard (＠julliard) 22 May '23

22 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2872

1 0

Re: [PATCH v3 0/1] MR2867: imm32: Don't erroneously start composition when handling IMC_SETOPENSTATUS. (#54965) - approved
by Alexandre Julliard (＠julliard) 22 May '23

22 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2867

1 0

Re: [PATCH v13 0/9] MR193: vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations. - approved
by Alexandre Julliard (＠julliard) 22 May '23

22 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/193

1 0

Re: [PATCH v6 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs(). - approved
by Alexandre Julliard (＠julliard) 22 May '23

22 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203

1 0

Re: [PATCH v12 0/1] MR135: vkd3d-shader/hlsl: Add support for sample index argument in Load(). - approved
by Alexandre Julliard (＠julliard) 22 May '23

22 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/135

1 0

[PATCH 0/5] MR2878: qcap: Audio capture filter implementation, part 4 of 4.
by Zebediah Figura (＠zfigura) 22 May '23

22 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2878

3 6

[PATCH v3 0/3] MR2833: wined3d: Optimize lights handling.
by Paul Gofman (＠gofman) 22 May '23

22 May '23

This fixes a performance regression introduced during state redesign shortly after Wine 5.0. Some games create a great amount of lights (around 1000 and growing) and touch them quite often. That results in each light being relayed to CS thread before each draw which is taking a great amount of time (performance drop in Nosferatu: The Wrath of Malachi from ~150 fps to ~10-15 at start location; that's with another unrelated regression related to streaming buffer management sorted out). It is … [View More]

3 5

[PATCH 0/2] MR2877: uiautomationcore: A bug fix, and some header definitions.
by Connor McAdams (＠cmcadams) 22 May '23

22 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2877

3 3

[PATCH v14 0/3] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 22 May '23

22 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v14: winesni.drv: implement basic balloon notification support explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 5

[PATCH v3 0/5] MR2870: gdiplus: Support playing back pen custom end line cap.
by Zhiyi Zhang (＠zhiyi) 22 May '23

22 May '23

Fix Cafe Stella (SteamID: 1829980) Flowchart crashes once there are 2 things on it. -- v3: gdiplus: Support playing back pen custom end line cap. gdiplus: Support playing back pen custom start line cap. gdiplus: Support recording pen custom end line cap. gdiplus: Support recording pen custom start line cap. https://gitlab.winehq.org/wine/wine/-/merge_requests/2870

3 7

[PATCH 0/1] MR2869: winepulse: Implement is_format_supported in unixlib.
by Davide Beatrici (＠davidebeatrici) 22 May '23

22 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2869

3 5

[PATCH 0/3] MR2868: wine{alsa,coreaudio,oss}: Implement get_device_period in unixlib.
by Davide Beatrici (＠davidebeatrici) 22 May '23

22 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2868

3 11

[PATCH 0/2] MR2875: shell32: add support for balloon icon copying
by Cherser-s (＠Cherser-s) 22 May '23

22 May '23

Currently shell32 only transfers the plain icon for `Shell_NotifyIcon` calls, ignoring balloon icons. This patch allows transferring both images to explorer.exe tray. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2875

2 2

[PATCH v13 0/4] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 22 May '23

22 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v13: configure: fix winesni.drv not getting disabled winesni.drv: implement basic balloon notification support https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 5

[PATCH v5 0/3] MR2864: gdiplus: Improve performance of GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 22 May '23

22 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Improve performance of GdipDrawImagePointsRect by: 1. avoiding multiplication and use addition where it is possible. 2. avoid calculating `GdipInvertMatrix` if it is not used It gives noticible speed improvement. I divided MR to several commits, to better undestand what is going on. -- v5: gdiplus: Improve performance of GdipDrawImagePointsRect gdiplus: Improve performance of GdipDrawImagePointsRect gdiplus: Improve … [View More]

3 5

[PATCH v6 0/1] MR2850: gdiplus: Fix GdipGetGenericFontFamily functions according to native gdiplus.dll
by Bartosz Kosiorek (＠gang65) 22 May '23

22 May '23

I have investigated `GdipGetGenericFontFamily*` functions from native gdiplus.dll. The result of investigation * GdipGetGenericFontFamilySansSerif: is taking first `"Microsoft Sans Serif"` font, then `Arial` [(here is the comparison)](http://www.identifont.com/differences?first=Microsoft+Sans+Ser…). The replacement for Arial is `"Liberation Sans"`. [(here is the comparison)](http://www.identifont.com/differences?first=Liberation+Sans&se…). If these fonts are not found then [`Tahoma` is … [View More]

4 5

[PATCH 0/1] MR2865: gdiplus: Handle Windows style newline.
by David Kahurani (＠kahurani) 22 May '23

22 May '23

gdip_format_string doesn't write newline characters. It writes line by line making sure to skip the newline characters. This means we can resolve this issue(at least as far gdiplus is concerned) without concerning ourselves with the issue in GetTextExtentExPointW(which should be dealt with as a different bug). This patch implements a fix but there might be possible improvements in the code so yeah, input is most welcome. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54962 Signed-off-by: … [View More]

3 3

[PATCH v12 0/3] MR181: vkd3d-shader: Normalise signatures and input/output registers to the Shader Model 6 pattern.
by Conor McCarthy (＠cmccarthy) 22 May '23

22 May '23

-- v12: vkd3d-shader/ir: Normalise signatures and input/output registers to the Shader Model 6 pattern. vkd3d-shader/ir: Eliminate struct vkd3d_shader_normaliser. vkd3d-shader/spirv: Support emitting multi-dimensional array variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/181

3 10

[PATCH v5 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Ethan Lee (＠flibitijibibo) 22 May '23

22 May '23

Found while running a bunch of D3D9 shaders through MojoShader's HLSL emitter. -- v5: vkd3d-shader/hlsl: Fold constant integral abs(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203

4 3

[PATCH v12 0/9] MR193: vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations.
by Nikolay Sivov (＠nsivov) 22 May '23

22 May '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v12: tests: Add RWBuffer writing test. tests: Add support for UAV buffers in the d3d11 runner. tests: Add support for UAV buffers to d3d12 runner. tests: Rename readback helper to be more generic. tests: Add support for UAV buffers in Vulkan runner. vkd3d-shader/hlsl: Improve UAV format type checking for buffer types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/193

4 10

[PATCH v11 0/1] MR135: vkd3d-shader/hlsl: Add support for sample index argument in Load().
by Nikolay Sivov (＠nsivov) 22 May '23

22 May '23

-- v11: vkd3d-shader/hlsl: Add support for sample index argument in Load(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/135

4 3

[PATCH v2 0/2] MR208: vkd3d-shader/hlsl: Fix liveness of temps within loops.
by Francisco Casas (＠fcasas) 22 May '23

22 May '23

Otherwise, it is possible that the register used by the temp is overridden by a subsequent instruction within the same loop. -- v2: vkd3d-shader/hlsl: Extend the liveness of nodes produced outside loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/208

5 12

[PATCH 0/5] MR205: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 5.
by Zebediah Figura (＠zfigura) 22 May '23

22 May '23

Pass struct hlsl_constant_value to folding functions, in preparation for creating the destination constant instruction from that value. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/205

4 7

[PATCH v11 0/2] MR184: vkd3d-shader/hlsl: Add support for SampleGrad() method
by Ethan Lee (＠flibitijibibo) 22 May '23

22 May '23

~~This one's marked as a draft, as there seems to be a blocker with the method parameters.~~ ~~The first commit totally works, _if_ the ddx/ddy parameters are literals - they do _not_ work when passing a variable of any kind. The test comes from tests/d3d12.c, so I'm mostly just trying to migrate that to the HLSL test suite, but it currently hits an assert before we get to the resource load (which does eventually work) and I'm not sure what's causing it:~~ ``` vkd3d-compiler: libs/vkd3d-… [View More]

4 4

[PATCH v2 0/2] MR2873: windows.gaming.input: Query IGameController interface in TryGetFactoryControllerFromGameController.
by Rémi Bernon (＠rbernon) 22 May '23

22 May '23

-- v2: windows.gaming.input: Query IGameController interface in TryGetFactoryControllerFromGameController. dinput/tests: Test that FromGameController also works with IRawGameController. https://gitlab.winehq.org/wine/wine/-/merge_requests/2873

2 3

[PATCH 0/2] MR2873: windows.gaming.input: Query IGameController interface in TryGetFactoryControllerFromGameController.
by Rémi Bernon (＠rbernon) 22 May '23

22 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2873

3 3

[PATCH v2 0/3] MR2833: wined3d: Optimize lights handling.
by Paul Gofman (＠gofman) 22 May '23

22 May '23

This fixes a performance regression introduced during state redesign shortly after Wine 5.0. Some games create a great amount of lights (around 1000 and growing) and touch them quite often. That results in each light being relayed to CS thread before each draw which is taking a great amount of time (performance drop in Nosferatu: The Wrath of Malachi from ~150 fps to ~10-15 at start location; that's with another unrelated regression related to streaming buffer management sorted out). It is … [View More]

3 4

[PATCH v2 0/1] MR2867: imm32: Don't erroneously start composition when handling IMC_SETOPENSTATUS.
by Jinoh Kang (＠iamahuman) 22 May '23

22 May '23

-- v2: imm32: Don't erroneously start composition when handling IMC_SETOPENSTATUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/2867

3 5

[PATCH 0/2] MR2872: dinput: More BuildActionMap and work thread fixes.
by Rémi Bernon (＠rbernon) 22 May '23

22 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54917 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54916 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2872

2 2

[PATCH 0/1] MR2871: winhttp: Fix a test failure.
by Hans Leidekker (＠hans) 22 May '23

22 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54960 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2871

2 1

[PATCH v2 0/5] MR2870: gdiplus: Support playing back pen custom end line cap.
by Zhiyi Zhang (＠zhiyi) 22 May '23

22 May '23

Fix Cafe Stella (SteamID: 1829980) Flowchart crashes once there are 2 things on it. -- v2: gdiplus: Support playing back pen custom end line cap. gdiplus: Support playing back pen custom start line cap. gdiplus: Support recording pen custom end line cap. gdiplus: Support recording pen custom start line cap. gdiplus/tests: Add pen custom line cap record and play back tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2870

2 5

[PATCH 0/5] MR2870: gdiplus: Support playing back pen custom end line cap.
by Zhiyi Zhang (＠zhiyi) 22 May '23

22 May '23

Fix Cafe Stella (SteamID: 1829980) Flowchart crashes once there are 2 things on it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2870

3 6

[PATCH v12 0/4] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 21 May '23

21 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v12: configure: fix winesni.drv not getting disabled winesni.drv: implement basic balloon notification support explorer: add winesni.drv tray implementation support winesni.drv: add KDE … [View More]

2 4

[PATCH v4 0/3] MR2864: gdiplus: Improve performance of GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 21 May '23

21 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Improve performance of GdipDrawImagePointsRect by: 1. avoiding multiplication and use addition where it is possible. 2. avoid calculating `GdipInvertMatrix` if it is not used It gives noticible speed improvement. I divided MR to several commits, to better undestand what is going on. -- v4: gdiplus: Improve performance of GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/2864

2 3

[PATCH v3 0/3] MR2864: gdiplus: Improve performance of GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 21 May '23

21 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Improve performance of GdipDrawImagePointsRect by: 1. avoiding multiplication and use addition where it is possible. 2. avoid calculating `GdipInvertMatrix` if it is not used It gives noticible speed improvement. I divided MR to several commits, to better undestand what is going on. -- v3: gdiplus: Improve performance of GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/2864

2 3

[PATCH v2 0/3] MR2864: gdiplus: Improve performance of GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 21 May '23

21 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Improve performance of GdipDrawImagePointsRect by: 1. avoiding multiplication and use addition where it is possible. 2. avoid calculating `GdipInvertMatrix` if it is not used It gives noticible speed improvement. I divided MR to several commits, to better undestand what is going on. -- v2: gdiplus: Improve performance of GdipDrawImagePointsRect gdiplus: Improve performance of GdipDrawImagePointsRect gdiplus: Improve … [View More]

2 3

[PATCH 0/1] MR2867: imm32: Don't erroneously start composition when handling IMC_SETOPENSTATUS.
by Jinoh Kang (＠iamahuman) 20 May '23

20 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2867

2 1

[PATCH v2 0/2] MR2866: server: Update parent window region when exposing previously invisible window. (#54949)
by Jinoh Kang (＠iamahuman) 20 May '23

20 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54949 -- v2: server: Update parent window region when exposing previously invisible window. user32/tests: Test for update region after showing a child window. https://gitlab.winehq.org/wine/wine/-/merge_requests/2866

2 2

[PATCH 0/2] MR2866: server: Update parent window region when exposing previously invisible window. (#54949)
by Jinoh Kang (＠iamahuman) 20 May '23

20 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54949 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2866

2 2

[PATCH 0/6] MR2722: dsound: Doppler shift (part 2)
by Anton Baskanov (＠baskanov) 20 May '23

20 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2722

4 15

[PATCH 0/3] MR2864: gdiplus: Improve performance of GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 20 May '23

20 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Improve performance of GdipDrawImagePointsRect by: 1. avoiding multiplication and use addition where it is possible. 2. avoid calculating `GdipInvertMatrix` if it is not used It gives noticible speed improvement. I divided MR to several commits, to better undestand what is going on. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2864

3 4

Re: [PATCH v5 0/1] MR2850: gdiplus: Fix GdipGetGenericFontFamily functions according to native gdiplus.dll
by Bartosz Kosiorek (＠gang65) 20 May '23

20 May '23

On Fri May 19 21:00:14 2023 +0000, Esme Povirk wrote: > My expectation is that, because Windows ships with Courier New, this > would never happen on real Windows. It doesn't matter what native does > when you run it on Wine or a Windows install without the font, because > application developers will never encounter that situation in testing > and aren't going to write applications expecting it. > It's not going to be fully accurate behavior regardless, so why not do > what … [View More]the function is supposed to do and give the application a monospace font? In Wine we have `Courier` font, which we could use: https://gitlab.winehq.org/wine/wine/-/tree/master/fonts I don't know what is the difference between Wine's `Courier` and Microsoft `Courier`. Here is the comparison of `Courier New` and `Courier`: http://www.identifont.com/differences?first=Courier&second=Courier+New&q=Go Here is git history of Courier font: ``` $ git log courier.ttf commit 40166848a7944383a4cfdaac9b18bd03fbb2b4f9 Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Thu Sep 28 00:23:42 2017 +0200 fonts: Increase the Em size to fix a build failure with freetype 2.8.1. Freetype 2.8.1 implemented the stricter Em bounds from OpenType 1.8.2 which require a minimum Em size of 16. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit 80a17baf20da4620394f8832f6221edf45b7a0f0 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jul 11 15:29:19 2013 +0200 fonts: Update fonts with a more recent fontforge. commit 994f74fb46285130cc63784449176c748cfdfaaf Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jul 11 11:54:28 2013 +0200 fonts: Add some missing Cyrillic glyphs to the Courier font. commit a926bfdb061ffcdc3c6f88b29fca614f9f12fa78 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jan 25 19:16:25 2012 +0100 fonts: Add some missing glyphs in the Courier font. commit 8330e11ca743c861c325bc772820a94ac2441c08 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Feb 20 15:17:20 2009 +0100 fonts: Re-generate fonts using the "official" fontforge version. commit 0f2cb23c7d5df22f9ff30e40afb4d6de03e03dae Author: Aurimas Fischer <aurimas(a)gmail.com> Date: Mon Mar 24 16:50:06 2008 +0200 fonts: Added/updated all (9x2) Lithuanian glyphs. commit 8ad6049ac642bf61d338e0c2094b9a0b9a2f51bd Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Mar 22 21:23:56 2008 +0100 fonts: Store the generated TrueType fonts in the repository, and rebuild them only in maintainer mode. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2850#note_33314 [View Less]

1 0

[PATCH 0/1] MR2863: explorer: Fix uninitialized variable warning.
by Davide Beatrici (＠davidebeatrici) 20 May '23

20 May '23

```c programs/explorer/desktop.c:104:16: warning: ‘hres’ may be used uninitialized in this function [-Wmaybe-uninitialized] 104 | return hres; | ^~~~ ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2863

2 1

[PATCH v11 0/9] MR193: vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations.
by Nikolay Sivov (＠nsivov) 19 May '23

19 May '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v11: tests: Add RWBuffer writing test. tests: Add support for UAV buffers in the d3d11 runner. tests: Add support for UAV buffers to d3d12 runner. tests: Rename readback helper to be more generic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/193

6 16

[PATCH v4 0/1] MR2850: gdiplus: Fix GdipGetGenericFontFamily functions according to native gdiplus.dll
by Bartosz Kosiorek (＠gang65) 19 May '23

19 May '23

I have investigated `GdipGetGenericFontFamily*` functions from native gdiplus.dll. The result of investigation * GdipGetGenericFontFamilySansSerif: is taking first `"Microsoft Sans Serif"` font, then `Arial` [(here is the comparison)](http://www.identifont.com/differences?first=Microsoft+Sans+Ser…). The replacement for Arial is `"Liberation Sans"`. [(here is the comparison)](http://www.identifont.com/differences?first=Liberation+Sans&se…). If these fonts are not found then [`Tahoma` is … [View More]

4 5

Re: [PATCH v2 0/1] MR2862: winemac: Explicitly link against Foundation.framework. - approved
by Alexandre Julliard (＠julliard) 19 May '23

19 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2862

1 0

Re: [PATCH v2 0/4] MR2861: dinput: Test and fix loading of action maps to the registry. - approved
by Alexandre Julliard (＠julliard) 19 May '23

19 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2861

1 0

Re: [PATCH v4 0/2] MR2314: user32/tests: Do not stop checking the message list when skipping an optional or unsupported message. - approved
by Alexandre Julliard (＠julliard) 19 May '23

19 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2314

1 0

Re: [PATCH v3 0/6] MR2823: qcap: Audio capture filter implementation, part 3. - approved
by Alexandre Julliard (＠julliard) 19 May '23

19 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2823

1 0

Re: [PATCH v2 0/1] MR2854: msmpeg2vdec: Add DllGetClassObject() stub. - approved
by Alexandre Julliard (＠julliard) 19 May '23

19 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2854

1 0

Re: [PATCH v2 0/5] MR2857: winex11: Move last IME entry points to imm32. - approved
by Alexandre Julliard (＠julliard) 19 May '23

19 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2857

1 0

Re: [PATCH v2 0/1] MR2860: gdi32: Mark objects as not used before clearing handles table in emf_reset. - approved
by Alexandre Julliard (＠julliard) 19 May '23

19 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2860

1 0

Re: [PATCH v2 0/8] MR2859: wineps: Don't use psdrv.h in unixlib and remove some fields from print_ctx - approved
by Alexandre Julliard (＠julliard) 19 May '23

19 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2859

1 0

[PATCH 0/1] MR2862: winemac: Explicitly link against Foundation.framework.
by Brendan Shanks (＠bshanks) 19 May '23

19 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2862

2 1

[PATCH v3 0/8] MR2712: winewayland.drv: part 3: Handle dynamic wl_output events
by Alexandros Frantzis (＠afrantzis) 19 May '23

19 May '23

This MR introduces the driver mechanisms to handle dynamic events from the Wayland compositor, using wl_output events as the guiding use case (i.e., we want to update the win32u display settings when the host settings change). In this design we create a dedicated thread to read and dispatch Wayland events received from the compositor. If a Wayland event handler wants some code to be run in the context of a particular HWND's thread, it can add an internal event to a custom queue we have for … [View More]

4 16

[PATCH v2 0/1] MR2498: msado15: Implement _Recordset Find
by Alistair Leslie-Hughes (＠alesliehughes) 19 May '23

19 May '23

Find only supports one Column to filter on. The parser for this will be the same for both Find/Filter with the only different is the Filter supports multiple columns. In trying to keep this patch small, only WSTR/BSTR/Integer have been supported. (The Common cases). -- v2: msado15: Implement _Recordset Find https://gitlab.winehq.org/wine/wine/-/merge_requests/2498

3 34

[PATCH v2 0/5] MR206: vkd3d-shader/hlsl: Implement SampleCmp() method.
by Nikolay Sivov (＠nsivov) 19 May '23

19 May '23

-- v2: vkd3d-shader/tpf: Write out comparison mode sampler declarations and corresponding sampling instruction. vkd3d-shader/hlsl: Parse SampleCmp() method. vkd3d-shader/hlsl: Parse SamplerComparisonState objects. vkd3d-shader/hlsl: Use a function table for object methods handlers. vkd3d-shader/hlsl: Move object type checks to methods handlers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/206

4 10

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 19 May '23

19 May '23

> If you mean setting `O_NONBLOCK` on `server`, that would cause `accept` to return `EWOULDBLOCK` or `EAGAIN`. No, I mean you can set O_NONBLOCK on "client", i.e. the socket that calls connect(). > By "clean up", do you mean only calling `WaitForSingleObject` on it, or is there more that I would need to do? Wait for it and close the handle. It should be unnecessary if you just use nonblocking i/o with the socket, though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33265

1 0

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 19 May '23

19 May '23

> ~~Yes,~~ `SO_REUSEADDR` is a valid option on AF_UNIX sockets and is supported by this patch. I'll add a test for it. It looks like this is only true for abstract AF_UNIX sockets, which are expressly unsupported due to Windows' own lack of support for them. Okay, I think I was assuming that "unbinding" meant doing the opposite of bind(), rather than "allowing other sockets to use that address". It'd be nice to have some tests for that functionality, then: * test that trying to use the … [View More]

1 0

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 19 May '23

19 May '23

On Fri May 19 04:17:50 2023 +0000, Ally Sommers wrote: > That's true, but `PATH_MAX` is 4096 on my system, while `sun_path` is a > `char[108]`. The path returned by `wine_get_unix_file_name` can very > easily exceed that. Thus a vararg is needed to conditionally pass the > Unix path to wineserver if we're dealing with an AF_UNIX socket. I still don't understand the issue. The sockaddr we pass to the server is already variable-sized. It's passed as variable-sized input data, using … [View More]

1 0

2025

2024

2023

2022

wine-gitlab