- wine-gitlab - winehq.org

[PATCH 0/1] MR2751: winemac.drv: Force a window in front of its peers if its level is decreased.
by Tim Clem (＠tclem) 05 May '23

05 May '23

Working around a macOS bug: -setLevel: is documented to move a window in front of its new peers, but that doesn't happen on Ventura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2751

2 1

[PATCH v9 0/8] MR188: vkd3d-shader/tpf: Add support for emitting sample_l instructions
by Ethan Lee (＠flibitijibibo) 05 May '23

05 May '23

From what I can tell, the recent work on SampleBias/SampleLevel did all of the work for us, we just need to take the same framework and include the case for the `sample_l` instruction. Tested with some shaders from the native Linux version of Little Racers STREET. -- v9: tpf: For sample_l/sample_b, set lod swizzle to SCALAR. vkd3d-shader/tpf: Add support for emitting sample_l instructions vkd3d-shader/hlsl: Add support for SampleGrad() method tests: Add a test for SampleGrad() method https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/188

3 9

[PATCH v8 0/6] MR188: vkd3d-shader/tpf: Add support for emitting sample_l instructions
by Ethan Lee (＠flibitijibibo) 05 May '23

05 May '23

From what I can tell, the recent work on SampleBias/SampleLevel did all of the work for us, we just need to take the same framework and include the case for the `sample_l` instruction. Tested with some shaders from the native Linux version of Little Racers STREET. -- v8: vkd3d-shader/tpf: For sample_l/sample_b, set lod swizzle to SCALAR. vkd3d-shader/tpf: Add support for emitting sample_l instructions tests: Add a test for SampleBias() with multiple mipmap levels. tests: Add a test for sampling from nonzero mipmap levels. tests: Add a test for loading from nonzero mipmap levels. tests/shader_runner: Add support for creating mipmapped textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/188

3 7

[PATCH v9 0/6] MR184: vkd3d-shader/hlsl: Add support for SampleGrad() method
by Ethan Lee (＠flibitijibibo) 05 May '23

05 May '23

~~This one's marked as a draft, as there seems to be a blocker with the method parameters.~~ ~~The first commit totally works, _if_ the ddx/ddy parameters are literals - they do _not_ work when passing a variable of any kind. The test comes from tests/d3d12.c, so I'm mostly just trying to migrate that to the HLSL test suite, but it currently hits an assert before we get to the resource load (which does eventually work) and I'm not sure what's causing it:~~ ``` vkd3d-compiler: libs/vkd3d-shader/tpf.c:3190: sm4_register_from_node: Assertion `instr->reg.allocated' failed. ``` ~~Seems like it's surprised when we try to load from the constant buffer maybe?~~ Fixed! -- v9: vkd3d-shader/hlsl: Add support for SampleGrad() method tests: Add a test for SampleGrad() method tests: Add a test for SampleBias() with multiple mipmap levels. tests: Add a test for sampling from nonzero mipmap levels. tests: Add a test for loading from nonzero mipmap levels. tests/shader_runner: Add support for creating mipmapped textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/184

3 7

[PATCH v2 0/6] MR2749: imm32/tests: Test some specific input vs message sequences.
by Rémi Bernon (＠rbernon) 05 May '23

05 May '23

Exposing the two different ways for IME to work: * synchronous mode, as implemented by the legacy IME engine (MS Korean IME uses this) with ImmProcessKey / ImeProcessKey followed by ImmTranslateMessage / ImeToAsciiEx call if it returns TRUE * asynchronous mode, as implemented by the MSCTF IME engine (MS Japanese IME uses this), where key input is hooked elsewhere and where WM_IME_NOTIFY messages with private wparam are used to notify the IME UI of composition updates. -- v2: imm32/tests: Test MS Japanese IME NIHONGO-NO sequence. imm32/tests: Test MS Korean IME GA-NA-DA sequence. imm32/tests: Add some missing local variables declarations. imm32/tests: Ignore some unknown WM_IME_NOTIFY messages. imm32/tests: Print human readable IME message names. imm32/tests: Adjust the ImmSetOpenStatus tests for MS Korean IME. https://gitlab.winehq.org/wine/wine/-/merge_requests/2749

3 7

[PATCH 0/6] MR2749: imm32/tests: Test some specific input vs message sequences.
by Rémi Bernon (＠rbernon) 05 May '23

05 May '23

Exposing the two different ways for IME to work: * synchronous mode, as implemented by the legacy IME engine (MS Korean IME uses this) with ImmProcessKey / ImeProcessKey followed by ImmTranslateMessage / ImeToAsciiEx call if it returns TRUE * asynchronous mode, as implemented by the MSCTF IME engine (MS Japanese IME uses this), where key input is hooked elsewhere and where WM_IME_NOTIFY messages with private wparam are used to notify the IME UI of composition updates. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2749

3 10

[PATCH v2 0/6] MR2741: sapi: Implement more ISpObjectToken functionality.
by Shaun Ren (＠shaunren) 05 May '23

05 May '23

-- v2: sapi: Implement ISpObjectToken::CreateInstance. sapi: Implement ISpObjectToken::Set/GetStringValue. sapi: Use ISpRegDataKey in object_token. sapi: Implement ISpRegDataKey::OpenKey. sapi: Ignore read_only in ISpRegDataKey::SetKey. sapi: Implement ISpRegDataKey::SetStringValue. https://gitlab.winehq.org/wine/wine/-/merge_requests/2741

4 10

Re: [PATCH v8 0/1] MR189: tests: Add a test for arrays with an expression as the index. - approved
by Giovanni Mascellani (＠giomasce) 05 May '23

05 May '23

This merge request was approved by Giovanni Mascellani. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/189

1 0

[PATCH v8 0/10] MR181: vkd3d-shader: Normalise signatures and input/output registers to the Shader Model 6 pattern.
by Conor McCarthy (＠cmccarthy) 05 May '23

05 May '23

-- v8: vkd3d-shader/ir: Normalise signatures and input/output registers to the Shader Model 6 pattern. vkd3d-shader/ir: Eliminate struct vkd3d_shader_normaliser. vkd3d-shader/spirv: Support emitting multi-dimensional array variables. vkd3d-shader/tpf: Validate input and output index ranges for default control point phases. vkd3d-shader/tpf: Remove an unnecessary carriage return from a parser error message. vkd3d-shader/tpf: Validate index range declarations. vkd3d-shader/tpf: Validate input/output registers. vkd3d-shader/tpf: Validate signature element masks. vkd3d-shader/tpf: Validate signature element register indices. vkd3d-shader/tpf: Validate input/output register index counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/181

2 10

[PATCH 0/1] MR2746: winepulse: Avoid accessing the product name after freeing it.
by Zebediah Figura (＠zfigura) 05 May '23

05 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2746

3 2

[PATCH v7 0/7] MR198: vkd3d-shader: Add more TPF validations.
by Conor McCarthy (＠cmccarthy) 05 May '23

05 May '23

Introduces an `idx_count` field to `struct vkd3d_shader_register`. Another patch set is needed for further validations and to use this field where applicable. -- v7: vkd3d-shader/tpf: Validate input and output index ranges for default control point phases. vkd3d-shader/tpf: Remove an unnecessary carriage return from a parser error message. vkd3d-shader/tpf: Validate index range declarations. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/198

2 8

[PATCH 0/4] MR2747: wine{alsa,coreaudio,oss,pulse}: Move ChannelAudioVolume into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 04 May '23

04 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2747

3 5

Re: [PATCH v4 0/2] MR2732: winecoreaudio: Implement per-channel volume control.
by Davide Beatrici (＠davidebeatrici) 04 May '23

04 May '23

On Thu May 4 21:24:15 2023 +0000, Davide Beatrici wrote: > @huw Does the code work as expected? @julliard I take that as a yes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2732#note_32048

1 0

Re: [PATCH v5 0/8] MR2733: imm32: Tests and fixes for ImmTranslateMessage - approved
by Alexandre Julliard (＠julliard) 04 May '23

04 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2733

1 0

Re: [PATCH v2 0/4] MR2734: winex11: Cleanup XIM preedit buffer handling logic. - approved
by Alexandre Julliard (＠julliard) 04 May '23

04 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2734

1 0

Re: [PATCH v2 0/1] MR2744: riched20: Update the editor IME position on GCS_RESULTSTR. - approved
by Alexandre Julliard (＠julliard) 04 May '23

04 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2744

1 0

Re: [PATCH v2 0/1] MR2745: winevulkan: Update to VK spec version 1.3.250. - approved
by Alexandre Julliard (＠julliard) 04 May '23

04 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2745

1 0

Re: [PATCH v2 0/4] MR2714: d3d8: Create swapchain textures from wined3d_swapchain_get_back_buffer() instead of using a callback. - approved
by Alexandre Julliard (＠julliard) 04 May '23

04 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2714

1 0

Re: [PATCH v4 0/2] MR2732: winecoreaudio: Implement per-channel volume control. - approved
by Alexandre Julliard (＠julliard) 04 May '23

04 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2732

1 0

[PATCH v7 0/1] MR189: tests: Add a test for arrays with an expression as the index.
by Ethan Lee (＠flibitijibibo) 04 May '23

04 May '23

See https://bugs.winehq.org/show_bug.cgi?id=54832 I'm starting to see this particular FIXME in quite a few games (Escape Goat 2, Murder Miners, and Little Racers STREET to name a few), and since I'm not sure how to fix this I figured I could at least provide a test for someone that knows more SM4 than me :P -- v7: tests: Add a test for arrays with an expression as the index. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/189

3 3

[PATCH v6 0/1] MR189: tests: Add a test for arrays with an expression as the index.
by Ethan Lee (＠flibitijibibo) 04 May '23

04 May '23

See https://bugs.winehq.org/show_bug.cgi?id=54832 I'm starting to see this particular FIXME in quite a few games (Escape Goat 2, Murder Miners, and Little Racers STREET to name a few), and since I'm not sure how to fix this I figured I could at least provide a test for someone that knows more SM4 than me :P -- v6: tests: Add a test for arrays with an expression as the index. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/189

3 2

[PATCH v11 0/11] MR159: vkd3d-shader/hlsl: Broaden resources support v2, part 2.
by Francisco Casas (＠fcasas) 04 May '23

04 May '23

Mainly comprises support for allocating arrays of resources, and loading from them, for both SM1 and SM4. -- v11: vkd3d-shader/hlsl: Introduce hlsl_calloc(). vkd3d-shader/hlsl: Support resource arrays when writting SM4. vkd3d-shader/hlsl: Write resource loads in SM1. vkd3d-shader/hlsl: Write sampler declarations in SM1. vkd3d-shader/hlsl: Track objects sampling dimension. vkd3d-shader/hlsl: Track object components usage and allocate registers accordingly. tests: Test objects as parameters. vkd3d-shader/hlsl: Skip object components when creating input/output copies. vkd3d-shader/hlsl: Add fixme for uniform copies for objects within structs. vkd3d-shader/hlsl: Support multiple-register variables in object regsets. tests: Add additional texture array register reservation tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/159

3 16

[PATCH v3 0/5] MR193: vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations.
by Nikolay Sivov (＠nsivov) 04 May '23

04 May '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: tests: Enable RWBuffer test. vkd3d-shader/hlsl: Improve UAV format type checking for buffer types. vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations. vkd3d-shader/hlsl: Add support for RWBuffer object. vkd3d-shader: Fix dcl_uav_typed_* formatting. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/193

3 7

[PATCH v7 0/8] MR181: vkd3d-shader: Normalise signatures and input/output registers to the Shader Model 6 pattern.
by Conor McCarthy (＠cmccarthy) 04 May '23

04 May '23

-- v7: vkd3d-shader/ir: Normalise signatures and input/output registers to the Shader Model 6 pattern. vkd3d-shader/tpf: Emit an error if an index range is declared for default control point phase input/output. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/181

2 8

[PATCH v6 0/7] MR198: vkd3d-shader: Add more TPF validations.
by Conor McCarthy (＠cmccarthy) 04 May '23

04 May '23

Introduces an `idx_count` field to `struct vkd3d_shader_register`. Another patch set is needed for further validations and to use this field where applicable. -- v6: vkd3d-shader/tpf: Emit an error if an index range is declared for default control point phase input/output. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/198

2 8

[PATCH v6 0/8] MR181: vkd3d-shader: Normalise signatures and input/output registers to the Shader Model 6 pattern.
by Conor McCarthy (＠cmccarthy) 04 May '23

04 May '23

-- v6: vkd3d-shader/ir: Normalise signatures and input/output registers to the Shader Model 6 pattern. vkd3d-shader/tpf: Validate input and output index ranges for default control point phases. vkd3d-shader/tpf: Remove an unnecessary carriage return from a parser error message. vkd3d-shader/tpf: Validate index range declarations. vkd3d-shader/tpf: Validate input/output registers. vkd3d-shader/tpf: Validate signature element masks. vkd3d-shader/tpf: Validate signature element register indices. vkd3d-shader/tpf: Validate input/output register index counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/181

2 8

[PATCH v2 0/2] MR2743: comctl32: Fix IME messages handling when EIMES_GETCOMPSTRATONCE flag is not set.
by Rémi Bernon (＠rbernon) 04 May '23

04 May '23

This fixes the behavior in notepad, with Japanese ibus-mozc IME, when typing "NIHONGO-SPACE-NO", or with Korean ibus-hangul when typing "GA-NA-DA". The latter still has an issue with the last character not appearing in the a composition but I believe it is unrelated to comctl32 and will be fixed by some future imm32 changes. -- v2: user32: Keep and display composition separate from the selection. comctl32/edit: Keep and display composition separate from the selection. https://gitlab.winehq.org/wine/wine/-/merge_requests/2743

3 5

[PATCH v5 0/7] MR198: vkd3d-shader: Add more TPF validations.
by Conor McCarthy (＠cmccarthy) 04 May '23

04 May '23

Introduces an `idx_count` field to `struct vkd3d_shader_register`. Another patch set is needed for further validations and to use this field where applicable. -- v5: vkd3d-shader/tpf: Validate input and output index ranges for default control point phases. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/198

2 7

[PATCH v4 0/6] MR198: vkd3d-shader: Add more TPF validations.
by Conor McCarthy (＠cmccarthy) 04 May '23

04 May '23

Introduces an `idx_count` field to `struct vkd3d_shader_register`. Another patch set is needed for further validations and to use this field where applicable. -- v4: vkd3d-shader/tpf: Remove an unnecessary carriage return from a parser error message. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/198

3 7

[PATCH 0/2] MR2743: comctl32: Fix IME messages handling when EIMES_GETCOMPSTRATONCE flag is not set.
by Rémi Bernon (＠rbernon) 04 May '23

04 May '23

This fixes the behavior in notepad, with Japanese ibus-mozc IME, when typing "NIHONGO-SPACE-NO", or with Korean ibus-hangul when typing "GA-NA-DA". The latter still has an issue with the last character not appearing in the a composition but I believe it is unrelated to comctl32 and will be fixed by some future imm32 changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2743

5 12

[PATCH 0/1] MR2744: riched20: Update the editor IME position on GCS_RESULTSTR.
by Rémi Bernon (＠rbernon) 04 May '23

04 May '23

So that a GCS_RESULTSTR followed by GCS_COMPSTR, without interruping the composition, begins inserting the new composition text after the result instead of before it. Fixing the same scenario as https://gitlab.winehq.org/wine/wine/-/merge_requests/2743 but in wordpad instead of notepad. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2744

3 2

[PATCH 0/5] MR2741: sapi: Implement more ISpObjectToken functionality.
by Shaun Ren (＠shaunren) 04 May '23

04 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2741

4 9

[PATCH v3 0/2] MR2679: msvcrt110: Add stub _Cancellation_beacon::_Cancellation_beacon()
by Vijay Kiran Kamuju (＠infyquest) 04 May '23

04 May '23

Required for Forza Horizon 4 and other games https://bugs.winehq.org/show_bug.cgi?id=54756 -- v3: msvcr120_app: Fix spec file for 0_Cancellation_beacon@details@Concurrency https://gitlab.winehq.org/wine/wine/-/merge_requests/2679

6 7

[PATCH v3 0/4] MR191: tests: Add more interesting HLSL tests for mipmap levels.
by Zebediah Figura (＠zfigura) 04 May '23

04 May '23

-- v3: tests: Add a test for SampleBias() with multiple mipmap levels. tests: Add a test for sampling from nonzero mipmap levels. tests: Add a test for loading from nonzero mipmap levels. tests/shader_runner: Add support for creating mipmapped textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/191

4 10

[PATCH 0/1] MR2745: winevulkan: Update to VK spec version 1.3.250.
by Georg Lehmann (＠DadSchoorse) 04 May '23

04 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2745

2 1

[PATCH 0/4] MR2714: d3d8: Create swapchain textures from wined3d_swapchain_get_back_buffer() instead of using a callback.
by Zebediah Figura (＠zfigura) 04 May '23

04 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2714

3 5

Re: [PATCH v2 0/2] MR2700: msxml3: Rename msxml3 to winexml and point msxml* to it.
by Loïc Rebmeister (＠Fox2Code) 04 May '23

04 May '23

I think this commit is great as it will reduce the maintenance cost of the different `msxml*` dlls by unifying work. If a version of a different `msxml*` act differently than the other version we can always do something like in `.spec` files: ``` @ stdcall -private DllGetClassObject(ptr ptr ptr) winexml.MSXML*_DllGetClassObject ``` But by checking: https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/msvcr120/Makefile.in Moving all code to `msxml` and using `PARENTSRC` would seems to be more in line with what wine is already doing. Either way is fine, the only thing that is sure is that splitting xml source work for each dll is not healthy, and code need to be cross merged in some way. Using a `winexml` is more memory efficient, but using `msxml` + `PARENTSRC` seems more application compatible, either way is fine for me. Also making `wine*` modules seems to become a recent common trend, see: https://gitlab.winehq.org/wine/wine/-/merge_requests/2298 @julliard I think you should make clearer guidelines about making `wine*.dll` modules, and proposing alternative to these modules in the guidelines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2700#note_31956

1 0

[PATCH 0/1] MR2740: winemenubuilder: Create .desktop files for programs that open URIs
by Alex Henrie (＠alexhenrie) 04 May '23

04 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=22904 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2740

4 4

[PATCH v3 0/2] MR2732: winecoreaudio: Implement per-channel volume control.
by Davide Beatrici (＠davidebeatrici) 04 May '23

04 May '23

Requires testing, as I only have access to a remote macOS machine. -- v3: mmdevapi: Remove unused "channel" member in set_volumes_params. winecoreaudio: Implement per-channel volume control. https://gitlab.winehq.org/wine/wine/-/merge_requests/2732

3 6

[PATCH v3 0/5] MR198: vkd3d-shader: Add more TPF validations.
by Conor McCarthy (＠cmccarthy) 04 May '23

04 May '23

Introduces an `idx_count` field to `struct vkd3d_shader_register`. Another patch set is needed for further validations and to use this field where applicable. -- v3: vkd3d-shader/tpf: Validate index range declarations. vkd3d-shader/tpf: Validate input/output registers. vkd3d-shader/tpf: Validate signature element masks. vkd3d-shader/tpf: Validate signature element register indices. vkd3d-shader/tpf: Validate input/output register index counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/198

2 5

[PATCH v5 0/2] MR2690: mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.
by Ziqing Hui (＠zhui) 04 May '23

04 May '23

The tests shows that, for sink writer created by MFCreateSinkWriterFromURL, we are not able to grab the media sink object immediately after the creation, unless the media sink object can be created without setting media type(MP3, ASF). -- v5: mfreadwrite/tests: Test GetService for MP4 sink writer. mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2690

3 4

[PATCH v2 0/4] MR198: vkd3d-shader: Add more TPF validations.
by Conor McCarthy (＠cmccarthy) 04 May '23

04 May '23

Introduces an `idx_count` field to `struct vkd3d_shader_register`. Another patch set is needed for further validations and to use this field where applicable. -- v2: vkd3d-shader/tpf: Validate input/output registers. vkd3d-shader/tpf: Validate signature element masks. vkd3d-shader/tpf: Validate signature element register indices. vkd3d-shader/tpf: Validate input/output register index counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/198

2 4

Re: [PATCH v6 0/2] MR2546: winegstreamer: Create extra decodebin to decode compressed stream.
by Ziqing Hui (＠zhui) 04 May '23

04 May '23

I do agree that it would be better to make the annoying GStreamer-Video-CRITICAL messages disappear. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2546#note_31943

1 0

Re: [PATCH v5 0/1] MR2713: kernelbase: Add GetPackagesByPackageFamily stub. - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2713

1 0

Re: [PATCH v2 0/1] MR2654: libs/vkd3d: Leave the command queue op mutex locked after a partial flush. - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2654

1 0

Re: [PATCH v2 0/1] MR2738: po: Update Dutch translation - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2738

1 0

Re: [PATCH v3 0/7] MR2719: winegstreamer: Cleanup media source streams and add synchronization. - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2719

1 0

Re: [PATCH v3 0/5] MR2737: ntdll: Fix return value of RtlInitializeSid(). - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2737

1 0

Re: [PATCH v3 0/1] MR2723: evr: Fix incorrect integral computation. - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2723

1 0

Re: [PATCH v3 0/1] MR2736: Reset presentation flags when session_clear_presentation is called. - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2736

1 0

Re: [PATCH v2 0/1] MR2735: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2735

1 0

[PATCH 0/8] MR2739: mfplat/buffer: Implement ContiguousCopyFrom() and ContiguousCopyTo().
by Giovanni Mascellani (＠giomasce) 03 May '23

03 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2739

2 8

Re: [PATCH v3 0/4] MR168: hlsl: ps_1_* outputs. - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/168

1 0

Re: [PATCH v5 0/4] MR197: vkd3d-shader: Maintenance patches - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/197

1 0

Re: [PATCH v4 0/2] MR182: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 2/2 (optional). - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/182

1 0

Re: [PATCH v4 0/3] MR194: Release vkd3d 1.7.1 - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/194

1 0

[PATCH v2 0/4] MR168: hlsl: ps_1_* outputs.
by Zebediah Figura (＠zfigura) 03 May '23

03 May '23

-- v2: vkd3d-shader/hlsl: Map the colour output for ps_1_* to r0. vkd3d-shader/hlsl: Rewrite the register allocator to allow allocating in multiple passes. vkd3d-shader/hlsl: Avoid leaking the allocator register map in allocate_const_registers(). vkd3d-shader/hlsl: Rename struct liveness to struct register_allocator. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/168

4 10

Re: [PATCH v2 0/4] MR174: Consolidate the TPF and d3dbc handling code.
by Henri Verbeet (＠hverbeet) 03 May '23

03 May '23

> FWIW, it's not necessarily that everything would go directly into v_s_i (clearly HLSL wouldn't), but sm1 and sm4 at least would. Contrary to what Henri said, I was actually of the impression that sm6 could deal directly with v_s_i without adding too much? Besides new opcodes and interfaces, I thought we didn't need much more than a new "SSA" register type. Well, there's the shader I/O signature and register normalisation work that Conor is currently working on, for example. I don't know if I'd qualify that as "much more", but it's essentially adapting the TPF frontend and SPIR-V backend to accommodate the DXIL frontend. It doesn't touch the representation of individual instructions much, so in that sense, sure. (Also, it ends up actually simplifying the SPIR-V backend by moving some transformations that aren't needed for DXIL to the common IR level where they're easier to do...) -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/174#note_31899

1 0

[PATCH v2 0/7] MR2719: winegstreamer: Cleanup media source streams and add synchronization.
by Rémi Bernon (＠rbernon) 03 May '23

03 May '23

Mostly a refresh of https://gitlab.winehq.org/wine/wine/-/merge_requests/1278, with a bit of cleanup. More to come. -- v2: winegstreamer: Remove unnecessary media source stream states. winegstreamer: Synchronize access to the media source from callbacks. winegstreamer: Synchronize concurrent access to the media stream. winegstreamer: Synchronize concurrent access to the media source. winegstreamer: Only break cyclic references in IMFMediaSource_Shutdown. winegstreamer: Keep a IMFMediaSource pointer in the media stream. winegstreamer: Query the wg_parser stream in media_stream_create. https://gitlab.winehq.org/wine/wine/-/merge_requests/2719

6 20

Re: [PATCH v2 0/4] MR174: Consolidate the TPF and d3dbc handling code.
by Zebediah Figura (＠zfigura) 03 May '23

03 May '23

> You mean that you'd have just `v_s_i` and every frontend and backend deals directly with it, including for very syntactical things like assembling and disassembling? I don't feel really convinced, it seems to me that you'd have to encode su much stuff in `v_s_i` that each time you need to change something (for example to allow for a new language) the changes can have repercussions in each other language frontend or backend. Yeah, that's the primary concern. It's mostly at this point weighing that against the idea of introducing new IRs and translation passes for everything, and also writing specific assemblers and disassemblers for everything, that makes me think keeping v_s_i as complex as it is isn't actually that bad. FWIW, it's not necessarily that everything would go directly into v_s_i (clearly HLSL wouldn't), but sm1 and sm4 at least would. Contrary to what Henri said, I was actually of the impression that sm6 could deal directly with v_s_i without adding too much? Besides new opcodes and interfaces, I thought we didn't need much more than a new "SSA" register type. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/174#note_31897

1 0

[PATCH v2 0/3] MR193: vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations.
by Nikolay Sivov (＠nsivov) 03 May '23

03 May '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations. vkd3d-shader/hlsl: Add support for RWBuffer object. vkd3d-shader: Fix dcl_uav_typed_* formatting. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/193

3 5

[PATCH v6 0/5] MR2555: ntdll: Support ISOLATIONAWARE_MANIFEST_RESOURCE_ID (#18889)
by Jinoh Kang (＠iamahuman) 03 May '23

03 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=18889 -- v6: ntdll: Don't hard-code DLL manifest resource ID when looking up dependency assembly. kernel32/tests: Test loading assembly manifest resource inside dependencies. ntdll: Move ACTCTX lpResourceName validation to RtlCreateActivationContext. kernel32/tests: Test setting lpResourceName to NULL for CreateActCtxW. kernel32/tests: Remove test for ACTCTX_FLAG_HMODULE_VALID with hModule = NULL case. https://gitlab.winehq.org/wine/wine/-/merge_requests/2555

5 14

[PATCH v4 0/4] MR197: vkd3d-shader: Maintenance patches
by Conor McCarthy (＠cmccarthy) 03 May '23

03 May '23

-- v4: tests/d3d12: Test register relative addressing in vertex and pixel shaders. vkd3d-shader: Introduce an internal shader signature structure. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/197

2 4

[PATCH 0/1] MR2738: po: Update Dutch translation
by Floris Renaud (＠jkfloris) 03 May '23

03 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2738

2 1

[PATCH v2 0/1] MR2723: evr: Fix incorrect integral computation.
by eric pouech (＠epo) 03 May '23

03 May '23

Note: typeof (int * unsigned) is unsigned. So: - on 64bit CPUs, where sizeof(int) = 4 < sizeof(void*) = 8, - when the result of the multiplication is supposed to be negative - there's no progation of the negative sign from 32bit to 64 bit integers Fixes a crash in Age of Empire II. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: evr: Fix incorrect integral computation. https://gitlab.winehq.org/wine/wine/-/merge_requests/2723

3 3

[PATCH v3 0/4] MR197: vkd3d-shader: Maintenance patches
by Conor McCarthy (＠cmccarthy) 03 May '23

03 May '23

-- v3: tests/d3d12: Test register relative addressing in vertex and pixel shaders. vkd3d-shader: Introduce an internal sm6 signature structure. vkd3d-shader/tpf: Return an error from vkd3d_shader_sm4_parser_create() if the parser failed. vkd3d-shader/d3dbc: Return an error from vkd3d_shader_sm1_parser_create() if the parser failed. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/197

4 8

[PATCH v2 0/5] MR2737: ntdll: Fix return value of RtlInitializeSid().
by Nikolay Sivov (＠nsivov) 03 May '23

03 May '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: ntdll/tests: Add some RtlValidSecurityDescriptor() tests. ntdll: Fix RtlValidSecurityDescriptor() return value. ntdll: Fix subauthority count check in RtlInitializeSid(). ntdll/tests: Add some tests for RtlInitializeSid(). ntdll: Fix return value of RtlInitializeSid(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2737

3 5

[PATCH v3 0/2] MR182: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 2/2 (optional).
by Francisco Casas (＠fcasas) 03 May '23

03 May '23

This patch makes index expressions on resources hlsl_ir_index nodes instead of hlsl_ir_resource_load nodes, because it is not known if they will be used later as the lhs of an hlsl_ir_resource_store. For now, the only benefit is consistency. -- v3: vkd3d-shader/hlsl: Don't keep the implicit mipmap level on hlsl_ir_index. vkd3d-shader/hlsl: Use hlsl_ir_index for resource access. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/182

3 3

[PATCH 0/4] MR198: vkd3d-shader: Add more TPF validations.
by Conor McCarthy (＠cmccarthy) 03 May '23

03 May '23

Introduces a `idx_count` field to `struct vkd3d_shader_register`. Another patch set is needed for further validations and to use this field where applicable. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/198

3 5

[PATCH v2 0/4] MR191: tests: Add more interesting HLSL tests for mipmap levels.
by Zebediah Figura (＠zfigura) 03 May '23

03 May '23

-- v2: tests: Add a test for SampleBias() with multiple mipmap levels. tests: Add a test for sampling from nonzero mipmap levels. tests: Add a test for loading from nonzero mipmap levels. tests/shader_runner: Add support for creating mipmapped textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/191

4 6

[PATCH v3 0/3] MR194: Release vkd3d 1.7.1
by Giovanni Mascellani (＠giomasce) 03 May '23

03 May '23

-- v3: Release 1.7.1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/194

5 4

[PATCH v8 0/6] MR184: vkd3d-shader/hlsl: Add support for SampleGrad() method
by Ethan Lee (＠flibitijibibo) 03 May '23

03 May '23

~~This one's marked as a draft, as there seems to be a blocker with the method parameters.~~ ~~The first commit totally works, _if_ the ddx/ddy parameters are literals - they do _not_ work when passing a variable of any kind. The test comes from tests/d3d12.c, so I'm mostly just trying to migrate that to the HLSL test suite, but it currently hits an assert before we get to the resource load (which does eventually work) and I'm not sure what's causing it:~~ ``` vkd3d-compiler: libs/vkd3d-shader/tpf.c:3190: sm4_register_from_node: Assertion `instr->reg.allocated' failed. ``` ~~Seems like it's surprised when we try to load from the constant buffer maybe?~~ Fixed! -- v8: vkd3d-shader/hlsl: Add support for SampleGrad() method tests: Add a test for SampleGrad() method tests: Add a test for SampleBias() with multiple mipmap levels. tests: Add a test for sampling from nonzero mipmap levels. tests: Add a test for loading from nonzero mipmap levels. tests/shader_runner: Add support for creating mipmapped textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/184

4 9

[PATCH v2 0/2] MR2732: winecoreaudio: Implement per-channel volume control.
by Davide Beatrici (＠davidebeatrici) 03 May '23

03 May '23

Requires testing, as I only have access to a remote macOS machine. -- v2: mmdevapi: Remove unused "channel" member in set_volumes_params. winecoreaudio: Implement per-channel volume control. https://gitlab.winehq.org/wine/wine/-/merge_requests/2732

3 4

[PATCH 0/2] MR2732: winecoreaudio: Implement per-channel volume control.
by Davide Beatrici (＠davidebeatrici) 03 May '23

03 May '23

Requires testing, as I only have access to a remote macOS machine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2732

3 7

[PATCH v2 0/1] MR2736: Draft: Reset presentation flags when session_clear_presentation is called.
by Santino Mazza (＠tati1454) 03 May '23

03 May '23

This prevents hangs when a program sets a new topology after stopping the current topology, because if we don't reset the flags to 0 the session will not subscribe to the events of the new topology sources. -- v2: mf/session: Reset presentation flags when session_clear_presentation is called. https://gitlab.winehq.org/wine/wine/-/merge_requests/2736

4 3

[PATCH v2 0/5] MR197: vkd3d-shader: Maintenance patches
by Conor McCarthy (＠cmccarthy) 03 May '23

03 May '23

-- v2: vkd3d-shader/tpf: Fail parsing if an input/output parameter order is > 2. tests/d3d12: Test register relative addressing in vertex and pixel shaders. vkd3d-shader: Introduce an internal sm6 signature structure. vkd3d-shader/tpf: Return an error from vkd3d_shader_sm4_parser_create() if the parser failed. vkd3d-shader/d3dbc: Return an error from vkd3d_shader_sm1_parser_create() if the parser failed. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/197

2 5

[PATCH 0/5] MR197: vkd3d-shader: Maintenance patches
by Conor McCarthy (＠cmccarthy) 03 May '23

03 May '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/197

2 5

[PATCH v7 0/6] MR188: vkd3d-shader/tpf: Add support for emitting sample_l instructions
by Ethan Lee (＠flibitijibibo) 03 May '23

03 May '23

From what I can tell, the recent work on SampleBias/SampleLevel did all of the work for us, we just need to take the same framework and include the case for the `sample_l` instruction. Tested with some shaders from the native Linux version of Little Racers STREET. -- v7: vkd3d-shader/tpf: For sample_l/sample_b, set lod swizzle to SCALAR. vkd3d-shader/tpf: Add support for emitting sample_l instructions tests: Add a test for SampleBias() with multiple mipmap levels. tests: Add a test for sampling from nonzero mipmap levels. tests: Add a test for loading from nonzero mipmap levels. tests/shader_runner: Add support for creating mipmapped textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/188

3 7

[PATCH 0/2] MR2736: Draft: Reset presentation flags when session_clear_presentation is called.
by Santino Mazza (＠tati1454) 03 May '23

03 May '23

This prevents hangs when a program sets a new topology after stopping the current topology, because if we don't reset the flags to 0 the session will not subscribe to the events of the new topology sources. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2736

4 5

[PATCH v9 0/10] MR159: vkd3d-shader/hlsl: Broaden resources support v2, part 2.
by Francisco Casas (＠fcasas) 02 May '23

02 May '23

Mainly comprises support for allocating arrays of resources, and loading from them, for both SM1 and SM4. -- v9: vkd3d-shader/hlsl: Support resource arrays when writting SM4. vkd3d-shader/hlsl: Write resource loads in SM1. vkd3d-shader/hlsl: Write sampler declarations in SM1. vkd3d-shader/hlsl: Track objects sampling dimension. vkd3d-shader/hlsl: Track object components usage and allocate registers accordingly. tests: Test objects as parameters. vkd3d-shader/hlsl: Skip object components when creating input/output copies. vkd3d-shader/hlsl: Add fixme for uniform copies for objects within structs. vkd3d-shader/hlsl: Support multiple-register variables in object regsets. tests: Add additional texture array register reservation tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/159

3 11

[PATCH 0/6] MR196: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 4.
by Zebediah Figura (＠zfigura) 02 May '23

02 May '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/196

2 6

[PATCH 0/3] MR2737: ntdll: Fix return value of RtlInitializeSid().
by Nikolay Sivov (＠nsivov) 02 May '23

02 May '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2737

3 4

[PATCH 0/1] MR2735: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 02 May '23

02 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2735

3 2

Re: [PATCH v3 0/1] MR2725: d3dx9: Fix dst pitch for compressed format in D3DXLoadSurfaceFromMemory(). - approved
by Alexandre Julliard (＠julliard) 02 May '23

02 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2725

1 0

Re: [PATCH v5 0/3] MR2727: hrtfapo: Add CreateHrtfApo() stub. - approved
by Alexandre Julliard (＠julliard) 02 May '23

02 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2727

1 0

Re: [PATCH v7 0/1] MR1009: winemenubuilder: Skip desktop integration for certain associations. - approved
by Alexandre Julliard (＠julliard) 02 May '23

02 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1009

1 0

Re: [PATCH v2 0/1] MR2701: ntdll: Decrement thread count from exit_thread and exit the process if needed. - approved
by Alexandre Julliard (＠julliard) 02 May '23

02 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2701

1 0

[PATCH v3 0/1] MR2689: findstr: Add basic functionality.
by Zhiyi Zhang (＠zhiyi) 02 May '23

02 May '23

Company of Heroes: Battle of Crete needs a functioning findstr.exe to exit properly. Freemake Video Converter 4.1 installer also needs this. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=35254 -- v3: findstr: Add basic functionality. https://gitlab.winehq.org/wine/wine/-/merge_requests/2689

3 2

[PATCH v5 0/4] MR2688: tasklist: Add basic functionality.
by Zhiyi Zhang (＠zhiyi) 02 May '23

02 May '23

Company of Heroes: Battle of Crete needs a functioning tasklist.exe to exit properly. -- v5: tasklist: Partially support '/fi' option. tasklist: Support '/fo' option. tasklist: Support '/nh' option. tasklist: Add basic functionality. https://gitlab.winehq.org/wine/wine/-/merge_requests/2688

3 5

Re: [PATCH v27 0/4] MR1148: ntdll: Mark created files beginning with a dot as not hidden. - approved
by Alexandre Julliard (＠julliard) 02 May '23

02 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

1 0

Re: [PATCH v2 0/1] MR192: vkd3d: Do not reset the descriptor heap count unless full or the command list is reset. - approved
by Alexandre Julliard (＠julliard) 02 May '23

02 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/192

1 0

Re: [PATCH v3 0/2] MR190: vkd3d-shader/hlsl: Implement asfloat(). - approved
by Alexandre Julliard (＠julliard) 02 May '23

02 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/190

1 0

Re: [PATCH v7 0/1] MR180: vkd3d-shader/hlsl: Partially implement static expressions evaluation. - approved
by Alexandre Julliard (＠julliard) 02 May '23

02 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/180

1 0

Re: [PATCH v5 0/5] MR176: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 3. - approved
by Alexandre Julliard (＠julliard) 02 May '23

02 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/176

1 0

Re: [PATCH v2 0/1] MR187: vkd3d-shader/d3d-asm: Rename trace.c to d3d_asm.c. - approved
by Alexandre Julliard (＠julliard) 02 May '23

02 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/187

1 0

Re: [PATCH v2 0/1] MR186: vkd3d-shader: Get rid of the unused vkd3d_shader_src_param_entry structure. - approved
by Alexandre Julliard (＠julliard) 02 May '23

02 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/186

1 0

Re: [PATCH v2 0/2] MR2700: msxml3: Rename msxml3 to winexml and point msxml* to it.
by Tim Clem (＠tclem) 02 May '23

02 May '23

On Tue May 2 20:07:50 2023 +0000, Alexandre Julliard wrote: > I'm not convinced that this justifies a Wine-specific module. > The usual solution for problems with native dlls is "don't do that", > i.e. fix the builtin so that native is not required. > It's hard to tell without more details, but in this case an app-specific > dll override may also be enough. That's fair. How would you feel if the guts were moved from msxml3 to msxml? Native overrides of msxml1 are presumably very uncommon (there's nothing in winetricks, e.g.), so it would basically accomplish the same independence of the msxml*.dlls. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2700#note_31794

1 0

[PATCH v8 0/10] MR159: vkd3d-shader/hlsl: Broaden resources support v2, part 2.
by Francisco Casas (＠fcasas) 02 May '23

02 May '23

Mainly comprises support for allocating arrays of resources, and loading from them, for both SM1 and SM4. -- v8: vkd3d-shader/hlsl: Support resource arrays when writting SM4. vkd3d-shader/hlsl: Write resource loads in SM1. vkd3d-shader/hlsl: Write sampler declarations in SM1. vkd3d-shader/hlsl: Track objects sampling dimension. vkd3d-shader/hlsl: Track object components usage and allocate registers accordingly. tests: Test objects as parameters. vkd3d-shader/hlsl: Skip object components when creating input/output copies. vkd3d-shader/hlsl: Add fixme for uniform copies for objects within structs. vkd3d-shader/hlsl: Support multiple-register variables in object regsets. tests: Add additional texture array register reservation tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/159

2 11

Re: [PATCH v3 0/1] MR499: server: Allow cancelling alerted asyncs.
by Zebediah Figura (＠zfigura) 02 May '23

02 May '23

> > > I'd propose that the constituent conditions of each flag be refactored into separate state variables first. Paradoxically, it may even help combine two or more binary flags into an enum as the semantics become more simpler. > > > > Probably, but it's not clear to me how exactly to improve them? > > I'm yet to come with a concrete proposal, but the basic idea is that they'll be decomposed until some subset of components can be condensed into a phase enum (or the like). > > We can already do this with `signaled` and `unknown_status`, for (a not really good) example. Having a phase enumeration would be great if we can make it work, but I'm not sure that we can really decompose anything that currently exists. Decomposing either of these two would require introducing new flags. Granted, those might have simpler meaning, but... > > > * `direct_result`: from Wine codebase, `a flag if we're passing result directly from request instead of APC`. > > > > The idea behind direct_result is that there are two paths for asyncs: > > > > * Requests that can be filled immediately. The idea here is then that we can do this in two server requests: one to send and/or retrieve the data, then the client can set iosb and/or output buffers, and then the second server request is done to trigger completion after the iosb and output buffers have been filled. This is the "direct_result" case. The prototypical example is a named pipe ioctl. The first request varies, but as you've observed, it's basically anything that calls create_request_async(), and then the request handler needs to not pend the async. > > Nit: "pend the async" may need some clarification. There are two possible interpretations to "pend an async": > > 1. Queueing an async for deferred asynchronous completion. > 1. Simply calling `set_async_pending(async)`. > > For case 2, `direct_result` can still be true if we terminate the async immediately afterwards. This is akin to calling `IoMarkIrpPending(Irp);` and immediately following it with a call to `IoCompleteRequest(Irp, IO_NO_INCREMENT);`. > > I'll assume that you meant case 1 here. Yes, that's what I meant. > > > * Requests that can't be filled immediately. In this case we use an APC to notify the client when the request is filled. This is the "!direct_result" case. The APC is a callback in a sense, but you can also look at it as two separate requests. As with the direct_result case, we need the server to return the iosb and output buffer (the APC arguments), then the client fills them, then it sends another request to the server (returning from the APC) that lets the server queue completion. > > > > > * The async was created via create_request_async(), and > > > > The other path is register_async, and I think that should just go away. The idea of register_async is that the client tries to do i/o, gets EWOULDBLOCK, and then sends an async to the server. It was once used for sockets, and now I believe only applies to some "special" unix file types: serial, char device, mailslot, probably also FIFO. Besides being kind of redundant, it has a fundamental problem, as we've discovered with sockets: inauspiciously timed I/O on a "ready" file can jump ahead of queued I/O. I think in general we want to replace it with something that looks like the socket path. > > I think that depends on whether the file object serializes I/O requests. If the file object can complete I/O requests in a nondeterministic order, then I don't think the approach merits extra round-tripping overhead. Well, it's serial devices and mailslots, which can probably be tested on Windows, and char/FIFO devices, which can't. But honestly, I'm not sure testing is worth the trouble. It'd be impossible to prove for sure that Windows queues I/O, but I think it's also the only sensible thing to do. Perhaps more importantly, I think the lesser number of paths we have for asyncs, the better. If we can eliminate one potential outlier by making them work like sockets, it'll be that much easier to work with the async logic. > Side note: what if `server_read_file` is blocked in an alertable wait for an async handle with `async->unknown_status == 1`, and the blocked thread is sent a user APC? I suppose the thread should not be alerted *until after* the driver returns from the dispatcher. Yeah, that part isn't really correct as-is. Perhaps more importantly, if the async returns success I don't think the thread should be alerted at all. It's probably not a huge deal, though, since FILE_SYNCHRONOUS_IO_ALERT is not actually exposed through kernel32. > > > That said, this logic seems questionable. It looks kind of like it exists to avoid calling async_set_result() twice, but that shouldn't be possible anyway. It should only be possible to reach async_satisfied() once. I guess a sufficiently misbehaving client could clone the async handle and then wait on it twice, though... and probably async_set_result() doesn't protect against being called multiple times... > > Yeah, `async_set_result` may need its own flag; perhaps `fully_completed` from your suggestion, `settled`, `finalized`, `completion_sent`, or `completion_notified`. That's possibly better. In this case I think the important thing is also to document what we're trying to protect against. > > > > * Any of: > > > * async_handoff() has not been called, or > > > > I'm not sure this is a meaningful state. Until we get to async_handoff() the async isn't *really* initialized. Honestly, it wouldn't be the craziest thing in the world to defer async creation until that point, possibly by building up some sort of parameters structure that we pass to read/write/ioctl fd callbacks instead of a whole async object. But I don't know, that may be more trouble than its worth. > > `queue_async(q, async);` may precede `async_handoff(async, ...);`. Since `queue_async` needs the async to be materialized, we would need to reorder these two calls. Indeed, queuing makes it nontrivial. Probably more trouble than its worth, then. > > > I suppose we could introduce some sort of bool helper instead of having a direct_result field. It seems relatively clear to me, or at least, not worse than its constitutent logic, but if someone less used to the code has a suggestion, that does deserve wait. It's worth pointing out though that given that part of the condition for whether something is a direct result is "was it ever unknown_status", we'd need another bool flag anyway. I guess then the logic would be as simple as "!was_unknown_status && initial_status != STATUS_PENDING". > > Rather, I want `direct_result` (or a similar flag) to mirror the client state: to be precise, whether the client side has went through the synchronous IOSB filling code section at the time of last state synchronization. Ideally, it should be strictly independent of the server or I/O operation state, so that the async code can be decomposed into an I/O state handling component and a client notification handling component. I don't think I understand what you're trying to do here, which is a bit concerning. > > > "signaled" is a kind of similar case, where you could in theory break it down into a collection of simpler bits, but not all of those simpler bits currently exist. Fundamentally, "signaled" is "blocking ? fully_completed : !unknown_status". > > Er, to be exact, it's `blocking ? fully_completed : (!unknown_status && initial_status_sent_to_client)`, where `initial_status_sent_to_client = irp_completion_deferred || fully_completed`. I guess that's true, though I wouldn't really describe/design it that way. If we reported the initial status directly from the first server request, then the answer to "is the async signaled?" is "it doesn't matter", but for consistency/simplicity I think it should be "yes" rather than "no". Yes, it's signaled, but nobody's waiting on it so it doesn't matter. > > > > * `async_wake_obj(async)` has been called when `async->unknown_status = 0`, or > > > > async_wake_obj() is horrid, because it's basically a leaky abstraction. There should be a better way to organize this, but I'm not really sure how. It kind of looks like we should wake up the async in async_set_initial_status(), but the problem is that ntoskrnl can either return the initial status of an IRP by itself but leave the IRP pending, or it can return the initial *and* final status of a complete IRP, and for the sake of efficiency I don't think we want to wake up the async in async_set_initial_status() in the latter case. That would basically result in a SIGUSR1 when we could just return the APC by interrupting the wait. It would *work* but it would be slower. > > It does not work, since the IOSB has not been filled by `APC_ASYNC_IO` from `set_irp_result` at the time of wake-up. > > What I suppose is that `async_wake_obj` should just be renamed to `async_commit_pending_status` or something similar. I don't think this is much of an improvement. It's still leaking the abstraction. > > > * (Regardless of `async->blocking`) `async_set_result(async, status, ...)` has been called with `async->terminated && (!async->alerted || status != STATUS_PENDING)`. > > > > Which is to say: the client finished processing an APC and didn't restart the async. > > An interesting bit in the condition above is that `STATUS_PENDING` is interpreted *differently* depending on the value of `async->alerted`. I think it's a little inconsistent; we should just have a "restart" boolean flag and fail entirely if `restart && !async->alerted`. Possibly, yes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/499#note_31791

1 0

[PATCH v2 0/1] MR2725: d3dx9: Fix dst pitch for compressed format in D3DXLoadSurfaceFromMemory().
by Paul Gofman (＠gofman) 02 May '23

02 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54901 The pitch is treated as a byte offset between the rows of blocks in tx_compress_dxtn(), so is the Pitch from _LockRect() so it doesn't need a fixup. That pitch has any effect only when dst texture stride is larger than width being compressed, that's why it was mostly not causing problems before. -- v2: d3dx9: Fix dst pitch for compressed format in D3DXLoadSurfaceFromMemory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2725

2 2

2025

2024

2023

2022

wine-gitlab