- wine-gitlab - winehq.org

Re: [PATCH v3 0/6] MR2633: mshtml: Use new Wine Gecko 2.47.4 features. - approved
by Alexandre Julliard (＠julliard) 12 Apr '23

12 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2633

1 0

Re: [PATCH v3 0/5] MR2634: winintest:internet InternetGetConnectedStateEx*() fixes - approved
by Alexandre Julliard (＠julliard) 12 Apr '23

12 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2634

1 0

Re: [PATCH v2 0/1] MR2635: wininet/tests: Fix the InternetErrorDlg() tests on Windows 10 1607. - approved
by Alexandre Julliard (＠julliard) 12 Apr '23

12 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2635

1 0

Re: [PATCH v2 0/11] MR2639: wineps: Support more spool file records. - approved
by Alexandre Julliard (＠julliard) 12 Apr '23

12 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2639

1 0

Re: [PATCH v8 0/1] MR2622: ntdll: Use log-linear bucketing for free lists. - approved
by Alexandre Julliard (＠julliard) 12 Apr '23

12 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2622

1 0

Re: [PATCH v2 0/6] MR155: Minor vkd3d_shader_parser related cleanups. - approved
by Alexandre Julliard (＠julliard) 12 Apr '23

12 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/155

1 0

Re: [PATCH v7 0/2] MR141: vkd3d-shader/ir: Normalise hull shader control point phase I/O. - approved
by Alexandre Julliard (＠julliard) 12 Apr '23

12 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/141

1 0

[PATCH 0/7] MR2640: winegstreamer: Factor some common helpers between wg_parser and wg_transform.
by Rémi Bernon (＠rbernon) 12 Apr '23

12 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2640

4 16

[PATCH v2 0/13] MR2636: wine{alsa,coreaudio,oss,pulse}: Move AudioSessionManager into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 12 Apr '23

12 Apr '23

-- v2: winepulse: Remove AudioSessionManager. wineoss: Remove AudioSessionManager. winecoreaudio: Remove AudioSessionManager. winealsa: Remove AudioSessionManager. mmdevapi: Switch to own AudioSessionManager. mmdevapi: Implement AudioSessionManager. mmdevapi: Import GetAudioSessionWrapper() from driver. https://gitlab.winehq.org/wine/wine/-/merge_requests/2636

3 16

[PATCH 0/1] MR2641: ws2_32: Skip non-address records in dns_only_query().
by Hans Leidekker (＠hans) 12 Apr '23

12 Apr '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54819 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2641

2 1

[PATCH 0/10] MR2638: d3dcompiler: Use the vkd3d-shader DXBC API.
by Matteo Bruni (＠Mystral) 12 Apr '23

12 Apr '23

Same as !2577 with a few additional patches at the front. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2638

3 11

[PATCH 0/14] MR2636: wine{alsa,coreaudio,oss,pulse}: Move AudioSessionManager into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 12 Apr '23

12 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2636

4 20

[PATCH v4 0/1] MR150: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops.
by Nikolay Sivov (＠nsivov) 12 Apr '23

12 Apr '23

-- v4: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/150

5 11

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Zebediah Figura (＠zfigura) 12 Apr '23

12 Apr '23

On Wed Apr 12 08:55:50 2023 +0000, Zhiyi Zhang wrote: > Does the following help? > ``` > [ > explicit_handle > ] > interface interface-name > { > ... > } > ``` > See https://learn.microsoft.com/en-us/windows/win32/midl/explicit-handle > and https://learn.microsoft.com/en-us/windows/win32/rpc/explicit-binding-handles I think in general, what you want is to add another call to run_client() with a new string, and handle that in client(). In general the flow should look pretty similar: create an RPC binding, run some tests with it [in this case you're using a different interface, so you don't want run_tests()]. You can duplicate the other tests while you're at it [authinfo, test_is_server_listening()] but it doesn't seem necessary. On the server side, you'll need to register the new server interface as well, in server(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29775

1 0

[PATCH v2 0/6] MR2633: mshtml: Use new Wine Gecko 2.47.4 features.
by Gabriel Ivăncescu (＠insn) 12 Apr '23

12 Apr '23

-- v2: mshtml/tests: Add tests for non-stringed url() with non-URL characters in CSS. mshtml: Implement ProgressEvent's initProgressEvent method. mshtml: Get rid of dispatch_nsevent_hook. mshtml: Implement `complete` prop for input elements. mshtml: Set dom.ipc.plugins.enabled to FALSE. mshtml: Tell wine-gecko about the IE compat document mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/2633

3 8

[PATCH v2 0/3] MR140: vkd3d-shader/hlsl: Handle SV_IsFrontFace semantic.
by Nikolay Sivov (＠nsivov) 12 Apr '23

12 Apr '23

-- v2: tests: Add a test for SV_IsFrontFace. tests: Disable culling in shader runners. vkd3d-shader/hlsl: Handle SV_IsFrontFace semantic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/140

4 8

Re: [PATCH v25 0/4] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 12 Apr '23

12 Apr '23

On Wed Apr 12 12:09:30 2023 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The tests also ran into some preexisting test failures. If you know how > to fix them that would be helpful. See the TestBot job for the details: > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=131819 > Your paranoid android. > === debian11 (32 bit report) === > ntdll: > directory.c:164: Test failed: file L".": expected (null) (10), got 12 > directory.c:164: Test failed: file L"..": expected (null) (10), got 12 > === debian11 (32 bit zh:CN report) === > ntdll: > directory.c:164: Test failed: file L".": expected (null) (10), got 12 > directory.c:164: Test failed: file L"..": expected (null) (10), got 12 > === debian11b (64 bit WoW report) === > ntdll: > directory.c:164: Test failed: file L".": expected (null) (10), got 12 > directory.c:164: Test failed: file L"..": expected (null) (10), got 12 > ``` will fix -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_29753

1 0

[PATCH v7 0/1] MR2622: ntdll: Use log-linear bucketing for free lists.
by Tatsuyuki Ishi (＠ishitatsuyuki) 12 Apr '23

12 Apr '23

Currently, the free list consists of a "small list" for sizes below 256, which are linearly spaced, and a "large list" which is manually split into a few chunks. This patch replaces it with a single log-linear policy, while expanding the range the large list covers. The old implementation had issues when a lot of large allocations happened. In this case, all the allocations went in the last catch-all bucket in the "large list", and what happens is: 1. The linked list grew in size over time, causing searching cost to skyrocket. 2. With the first-fit allocation policy, fragmentation was also making the problem worse. The new bucketing covers the entire range up until we start allocating large blocks, which will not enter the free list. It also makes the allocation policy closer to best-fit (although not exactly), reducing fragmentation. The increase in number of free lists does incur some cost when it needs to be skipped over, but the improvement in allocation performance outweighs it. For future work, these ideas (mostly from glibc) might or might not benefit performance: - Use an exact best-fit allocation policy. - Add a bitmap for freelist, allowing empty lists to be skipped with a single bit scan. For the benchmark, this drastically improves initial shader loading performance in Overwatch 2. In this workload 78k shaders are passed to DXVK for DXBC -> SPIRV translation, and for each shader a few allocation happens in the 4K – 100K range for the staging buffer. Before this patch, malloc consisted a whooping 43% of overhead. The overhead with log-linear bucketing is drastically lower, resulting in a ~2x improvement in loading time. Overhead for each `FREE_LIST_LINEAR_BITS` is as below: - 0: 7.7% - 1: 2.9% - 2: 1.3% - 3: 0.6% Since performance seems to scale linearly with increase in buckets (up to the point I have tested), I've opted for 3 (8 buckets per doubling) in the current revision of patch. Signed-off-by: Tatsuyuki Ishi <ishitatsuyuki(a)gmail.com> -- v7: ntdll: Use log-linear bucketing for free lists. https://gitlab.winehq.org/wine/wine/-/merge_requests/2622

4 4

[PATCH v4 0/4] MR1979: msvcrt: Remaining stubs for cm3
by Torge Matthies (＠tmatthies) 12 Apr '23

12 Apr '23

Based on !2524. This adds the remaining stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- v4: msvcr110: Implement _Context::_IsSynchronouslyBlocked. msvcr110: Add _Context::_IsSynchronouslyBlocked stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_dtor stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_ctor stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

2 6

[PATCH v3 0/4] MR1979: msvcrt: Remaining stubs for cm3
by Torge Matthies (＠tmatthies) 12 Apr '23

12 Apr '23

Based on !2524. This adds the remaining stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- v3: msvcr110: Implement _Context::_IsSynchronouslyBlocked. msvcr110: Add _Context::_IsSynchronouslyBlocked stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_dtor stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_ctor stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

3 6

[PATCH v2 0/5] MR2634: winintest:internet InternetGetConnectedStateEx*() fixes
by Francois Gouget (＠fgouget) 12 Apr '23

12 Apr '23

* Fix InternetGetConnectedStateEx() parameter checking. * InternetGetConnectedStateExA() must always null-terminate the state string. * Dump the state string if it is not as expected. * Remove a couple of redundant InternetGetConnectedStateEx*() tests. * Avoid an unnecessary lstrlenW() call in internet.c. -- v2: wininet/tests: Fix InternetGetConnectedStateEx() parameter checking. wininet: InternetGetConnectedStateExA() must always null-terminate the state string. wininet/tests: Dump the state string if it is not as expected. https://gitlab.winehq.org/wine/wine/-/merge_requests/2634

3 7

[PATCH 0/1] MR2635: wininet/tests: Fix the InternetErrorDlg() tests on Windows 10 1607.
by Francois Gouget (＠fgouget) 12 Apr '23

12 Apr '23

ERROR_INTERNET_SEC_CERT_WEAK_SIGNATURE is not supported on 1507, broken on 1607 and works as expected on 1709+. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54815 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2635

3 2

[PATCH v24 0/4] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 12 Apr '23

12 Apr '23

Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v24: ntdll: Set xattr in NtCreateFile if inferred and requested attributes don't match. ntdll: Only infer hidden attribute from file name if xattr is not present. ntdll: Handle hidden file names inside get_file_info instead of after it. ntdll/tests: Add test for file attributes of files with names beginning with a dot. https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

3 5

Re: [PATCH v25 0/4] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 12 Apr '23

12 Apr '23

On Wed Apr 5 15:02:41 2023 +0000, Alexandre Julliard wrote: > This doesn't make sense, it's using the wrong slashes and shouldn't be > necessary in the first place. Yup, this isn't necessary anymore and I forgot or accidentally dropped the change of the backslashes to forward slashes. The latest version of this MR now contains just a straightforward conversion of that function from working with nt paths to working with unix paths. The reason this conversion is necessary at all is because I'm moving the calls to this function to the `get_file_info` function, so that more places in the code use the correct file attributes (everything that uses `get_file_info` now automatically returns attributes of hidden files correctly), and so that the extended attribute can take precedence over the file name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_29732

1 0

Re: [PATCH v23 0/4] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 12 Apr '23

12 Apr '23

On Wed Apr 5 15:02:41 2023 +0000, Alexandre Julliard wrote: > Please don't add unrelated changes. I added this change because test-linux-32 failed this test but I removed the commit now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_29729

1 0

[PATCH v4 0/1] MR135: vkd3d-shader/hlsl: Add support for sample index argument in Load().
by Nikolay Sivov (＠nsivov) 12 Apr '23

12 Apr '23

-- v4: vkd3d-shader/hlsl: Add support for sample index argument in Load(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/135

3 2

[PATCH 0/11] MR2639: wineps: Support more spool file records.
by Piotr Caban (＠piotr) 12 Apr '23

12 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2639

3 12

[PATCH 0/6] MR155: Minor vkd3d_shader_parser related cleanups.
by Henri Verbeet (＠hverbeet) 12 Apr '23

12 Apr '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/155

2 6

[PATCH v6 0/2] MR141: vkd3d-shader/ir: Normalise hull shader control point phase I/O.
by Conor McCarthy (＠cmccarthy) 12 Apr '23

12 Apr '23

To simplify SM 6 support, insert a control point id relative address where needed, and declare control point phase inputs where missing. -- v6: vkd3d-shader/ir: Insert hull shader control point input declarations if no control point phase is defined. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/141

3 4

Re: [PATCH v5 0/2] MR2545: winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID
by Huw Davies (＠huw) 12 Apr '23

12 Apr '23

On Wed Apr 12 09:05:59 2023 +0000, Yeshun Ye wrote: > https://gitlab.winehq.org/yeyeshun/wine/-/jobs/15769 That's the run on linux. The above failures are from runs on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2545#note_29716

1 0

Re: [PATCH v5 0/2] MR2545: winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID
by Yeshun Ye (＠yeyeshun) 12 Apr '23

12 Apr '23

On Wed Apr 12 09:00:14 2023 +0000, Huw Davies wrote: > > I just run the test again without any change, and it passed. > I don't see that, could you post the link? https://gitlab.winehq.org/yeyeshun/wine/-/jobs/15769 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2545#note_29712

1 0

Re: [PATCH v5 0/2] MR2545: winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID
by Huw Davies (＠huw) 12 Apr '23

12 Apr '23

> I just run the test again without any change, and it passed. I don't see that, could you post the link? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2545#note_29706

1 0

[PATCH 0/8] MR2633: mshtml: Use new Wine Gecko 2.47.4 features.
by Gabriel Ivăncescu (＠insn) 12 Apr '23

12 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2633

4 12

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Zhiyi Zhang (＠zhiyi) 12 Apr '23

12 Apr '23

On Wed Apr 12 07:42:32 2023 +0000, Yeshun Ye wrote: > > The patch may fix an application, but that doesn't mean it's correct. > Yeah, I know that. > The problem is my test isn't just add an interface function to the > existing interface, I need to add a new interface without > 'implicit_handle'. I need to understand all the server test code of > rpcrt4 and insert my interface in a correct place, and start the server > and client at a right time. It's too hard, Visual Studio did this for me automatically. Does the following help? ``` [ explicit_handle ] interface interface-name { ... } ``` See https://learn.microsoft.com/en-us/windows/win32/midl/explicit-handle and https://learn.microsoft.com/en-us/windows/win32/rpc/explicit-binding-handles -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29703

1 0

[PATCH 0/9] MR2637: winex11: Use messages instead of user callbacks and handle them in the default IME UI window procedure.
by Rémi Bernon (＠rbernon) 12 Apr '23

12 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2637

3 10

[PATCH 0/1] MR146: vkd3d: Append a full memory barrier after the command list batch in ExecuteCommandLists().
by Conor McCarthy (＠cmccarthy) 12 Apr '23

12 Apr '23

The D3D12 spec guarantees that lists submitted in ExecuteCommandLists() will complete execution before any subsequent commands begin execution. Based on a vkd3d-proton patch by Hans-Kristian Arntzen. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/146

4 10

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Yeshun Ye (＠yeyeshun) 12 Apr '23

12 Apr '23

> The patch may fix an application, but that doesn't mean it's correct. Yeah, I know that. The problem is my test isn't just add an interface function to the existing interface, I need to add a new interface without 'implicit_handle'. I need to understand all the server test code of rpcrt4 and insert my interface in a correct place, and start the server and client at a right time. It's too hard, Visual Studio did this for me automatically. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29694

1 0

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Zhiyi Zhang (＠zhiyi) 12 Apr '23

12 Apr '23

On Wed Apr 12 07:11:24 2023 +0000, Yeshun Ye wrote: > I tried to add an interface like this: > ``` > [ > uuid(00000000-4114-0704-2301-000000000002) > ] > > interface IServer_Expilicit > { > void need_explicit_handle([in] handle_t binding, [in] unsigned int > protseq); > } > ``` > I added the code above to the file 'server_interp.idl', the function > code to 'server.c' like this: > ``` > void __cdecl s_need_explicit_handle(RPC_BINDING_HANDLE binding, unsigned > int protseq) > { > RPC_STATUS status; > ULONG pid; > winetest_push_context("%s", client_test_name); > ok(binding != NULL, "Got unexpected binding\n"); > trace("s_need_explicit_handle\n"); > if (protseq == RPC_PROTSEQ_LRPC) /* Other protocol sequences throw > exceptions */ > { > trace("RPC_PROTSEQ_LRPC\n"); > status = I_RpcBindingInqLocalClientPID(binding, &pid); > trace("I_RpcBindingInqLocalClientPID\n"); > ok(status == RPC_S_OK, "Got unexpected %ld.\n", status); > ok(pid == client_info.dwProcessId, "Got unexpected pid.\n"); > trace("pid=%x client_info.dwProcessId=%x\n", pid, client_info.dwProcessId); > } > winetest_pop_context(); > } > ``` > Then I don't know what to do next. For a generic test case, you can see https://source.winehq.org/git/wine.git/commitdiff/056dbb04dea4d0b990e0177f6… for an example. However, in this case, you need to add a test case specifically for your changes. To be honest, I don't understand your patch, that's why I asked for a test case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29693

1 0

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Yeshun Ye (＠yeyeshun) 12 Apr '23

12 Apr '23

On Wed Apr 12 06:56:41 2023 +0000, Zhiyi Zhang wrote: > Could you be more specific about your question? You can paste your code here. I tried to add an interface like this: ``` [ uuid(00000000-4114-0704-2301-000000000002) ] interface IServer_Expilicit { void need_explicit_handle([in] handle_t binding, [in] unsigned int protseq); } ``` I added the code above to the file 'server_interp.idl', the function code to 'server.c' like this: ``` void __cdecl s_need_explicit_handle(RPC_BINDING_HANDLE binding, unsigned int protseq) { RPC_STATUS status; ULONG pid; winetest_push_context("%s", client_test_name); ok(binding != NULL, "Got unexpected binding\n"); trace("s_need_explicit_handle\n"); if (protseq == RPC_PROTSEQ_LRPC) /* Other protocol sequences throw exceptions */ { trace("RPC_PROTSEQ_LRPC\n"); status = I_RpcBindingInqLocalClientPID(binding, &pid); trace("I_RpcBindingInqLocalClientPID\n"); ok(status == RPC_S_OK, "Got unexpected %ld.\n", status); ok(pid == client_info.dwProcessId, "Got unexpected pid.\n"); trace("pid=%x client_info.dwProcessId=%x\n", pid, client_info.dwProcessId); } winetest_pop_context(); } ``` Then I don't know what to do next. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29689

1 0

[PATCH v4 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Mohamad Al-Jaf (＠maljaf) 12 Apr '23

12 Apr '23

Needed for mingw Firefox build. The WIDL error points to the wrong function, specifically the one after it. include/windows.ui.composition.interop.idl:35:63: error: parameter 'swapchain' of function 'CreateCompositionSurfaceForHandle' cannot derive from void * HRESULT CreateCompositionSurfaceForSwapChain([in] IUnknown *swapchain, [out, retval] ICompositionSurface **result); ^ make[1]: *** [Makefile:163749: include/windows.ui.composition.interop.h] Error 1 -- v4: include: Add windows.ui.composition.interop.idl file. widl: Add support for WinRT HANDLE parameter type. https://gitlab.winehq.org/wine/wine/-/merge_requests/2620

4 7

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Zhiyi Zhang (＠zhiyi) 12 Apr '23

12 Apr '23

On Wed Apr 12 05:38:56 2023 +0000, Yeshun Ye wrote: > I'm sorry I tried again, but still failed. I just know that the > interface should not add 'implicit_handle(handle_t IXXX_HANDLE)' after > 'uuid(IXXX_UUID)'. > Can you help me add a simple interface in the testcases and tell me how > to call the interface function? Otherwise, all I can do is give up. Could you be more specific about your question? You can paste your code here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29687

1 0

[PATCH 0/6] MR2628: Some more shell32 improvements.
by Jactry Zeng (＠jactry) 12 Apr '23

12 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2628

4 15

Re: [PATCH v6 0/1] MR2565: mmdevapi: Implement function 'AEV_SetMasterVolumeLevelScalar'
by Yeshun Ye (＠yeyeshun) 12 Apr '23

12 Apr '23

On Wed Apr 12 05:47:11 2023 +0000, Huw Davies wrote: > There's too much going on in this commit / MR. The changes to the > drivers seem to be addressing a bug rather than implementing the > Endpoint Volume API. > Also, note that the values passed to the non-`Scalar` API are in > decibels, the `Scalar` API appears to be somewhere between linear and > logrithmic, and the `ISimpleAudioVolume` values are linear. > Does your app call the `Scalar` versions of the API? If so, a good > start would be to write some tests to figure out the mapping between > `Scalar` and non-`Scalar` by e.g. setting using one and retreiving that > value using the other. Yes, I'm fixing a bug of an application, not implementing the set of Endpoint Volume API. Do I really need to write some tests? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2565#note_29674

1 0

Re: [PATCH v5 0/2] MR2545: winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID
by Yeshun Ye (＠yeyeshun) 12 Apr '23

12 Apr '23

On Fri Apr 7 10:56:17 2023 +0000, Huw Davies wrote: > Did these failures get addressed? I don't see testbot runs for the > later versions of the commits in this MR. No, I think the function will never return 'MIXERR_INVALCONTROL', so I just run the test again without any change, and it passed. This failures maybe caused by a bug of testbot. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2545#note_29672

1 0

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Yeshun Ye (＠yeyeshun) 12 Apr '23

12 Apr '23

On Wed Apr 12 05:38:56 2023 +0000, Zhiyi Zhang wrote: > Hi Yeshun, you don't need to regularly rebase the MR on top of the > latest master. Because this area of code is largely undocumented, to > help this MR gets in, you need to add a test, even if it might not be > easy. I think you can use some of the example codes in NCALRPC_example. Thanks. I'm sorry I tried again, but still failed. I just know that the interface should not add 'implicit_handle(handle_t IXXX_HANDLE)' after 'uuid(IXXX_UUID)'. Can you help me add a simple interface in the testcases and tell me how to call the interface function? Otherwise, all I can do is give up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29671

1 0

[PATCH 0/5] MR2634: winintest:internet InternetGetConnectedStateEx*() fixes
by Francois Gouget (＠fgouget) 12 Apr '23

12 Apr '23

* Fix InternetGetConnectedStateEx() parameter checking. * InternetGetConnectedStateExA() must always null-terminate the state string. * Dump the state string if it is not as expected. * Remove a couple of redundant InternetGetConnectedStateEx*() tests. * Avoid an unnecessary lstrlenW() call in internet.c. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2634

2 5

[PATCH v3 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Mohamad Al-Jaf (＠maljaf) 11 Apr '23

11 Apr '23

Needed for mingw Firefox build. The WIDL error points to the wrong function, specifically the one after it. include/windows.ui.composition.interop.idl:35:63: error: parameter 'swapchain' of function 'CreateCompositionSurfaceForHandle' cannot derive from void * HRESULT CreateCompositionSurfaceForSwapChain([in] IUnknown *swapchain, [out, retval] ICompositionSurface **result); ^ make[1]: *** [Makefile:163749: include/windows.ui.composition.interop.h] Error 1 -- v3: include: Add windows.ui.composition.interop.idl file. widl: Add support for WinRT HANDLE parameter type. https://gitlab.winehq.org/wine/wine/-/merge_requests/2620

2 3

Re: [PATCH v5 0/2] MR2032: winex11: Allow replacing either context in wglShareLists.
by Alex Henrie (＠alexhenrie) 11 Apr '23

11 Apr '23

Thanks for the help Rémi! It looks like Alexandre was happy with the final product as well, or at least he trusts your judgment about it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2032#note_29663

1 0

Re: [PATCH v4 0/4] MR2626: wine{alsa,coreaudio,oss,pulse}: Move common mmdevdrv structs into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2626

1 0

Re: [PATCH v2 0/3] MR2632: gdi: Support stock brushes in EMR_FILLRGN and EMR_FRAMERGN. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2632

1 0

Re: [PATCH v2 0/5] MR2631: wineps: Handle more spool file records. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2631

1 0

Re: [PATCH v7 0/3] MR2496: Fix hang when a program calls IMFMediaSession_Start with an invalid source. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2496

1 0

Re: [PATCH v3 0/9] MR2627: imm32: Implement input context cache and use INPUTCONTEXT directly in some functions. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2627

1 0

Re: [PATCH v2 0/1] MR2625: winex11.drv: Fix bit shifts in pixel format description for RGBA formats. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2625

1 0

Re: [PATCH v2 0/5] MR2629: msvcrt: Use remaining math functions from the bundled musl library. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2629

1 0

Re: [PATCH v3 0/1] MR2591: include: _InterlockedExchangePointer and _InterlockedCompareExchangePointer... - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2591

1 0

Re: [PATCH v5 0/2] MR2032: winex11: Allow replacing either context in wglShareLists. - approved
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2032

1 0

[PATCH v3 0/4] MR2626: wine{alsa,coreaudio,oss,pulse}: Move common mmdevdrv structs into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 11 Apr '23

11 Apr '23

-- v3: winepulse: Use mmdevdrv structs from mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2626

3 5

[PATCH v3 0/1] MR2471: winegstreamer: In video_processor, activate a videoflip converter.
by eric pouech (＠epo) 11 Apr '23

11 Apr '23

The app I'm considering opens a video_processor on its own, with a NV12 format on input and a ARGB32 format on output. Tested on Windows: the samples are flipped vertically. While Wine keeps them untouched. So added a videoflip in the video processor to be activated when needed. Current activation is based on RGB vs non RGB input/output formats. Set as draft as if somehow related to MR!2159. Comments welcomed. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v3: winegstreamer: In video_processor, activate a videoflip converter. https://gitlab.winehq.org/wine/wine/-/merge_requests/2471

3 10

Re: [PATCH v2 0/1] MR2439: ntoskrnl: Free memory before pointer gets set to NULL.
by Zebediah Figura (＠zfigura) 11 Apr '23

11 Apr '23

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/ntoskrnl.c: > irp->Tail.Overlay.Thread = (PETHREAD)KeGetCurrentThread(); > irp->Tail.Overlay.OriginalFileObject = file; > irp->RequestorMode = UserMode; > + HeapFree( GetProcessHeap(), 0, context->in_buff ); > context->in_buff = NULL; I don't think we need to be deallocating the input buffer; we're not using it. Rather we should just remove the assignment to NULL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2439#note_29633

1 0

Re: [PATCH v2 0/1] MR2439: ntoskrnl: Free memory before pointer gets set to NULL.
by Zebediah Figura (＠zfigura) 11 Apr '23

11 Apr '23

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/ntoskrnl.c: > if (ret == WAIT_OBJECT_0) > { > HeapFree( GetProcessHeap(), 0, context.in_buff ); > + context.in_buff = NULL; > status = STATUS_SUCCESS; > goto done; This seems unrelated and unnecessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2439#note_29634

1 0

[PATCH v2 0/4] MR2626: wine{alsa,coreaudio,oss,pulse}: Move common mmdevdrv structs into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 11 Apr '23

11 Apr '23

-- v2: winepulse: Use mmdevdrv structs from mmdevapi. wineoss: Use mmdevdrv structs from mmdevapi. winecoreaudio: Use mmdevdrv structs from mmdevapi. winealsa: Move common mmdevdrv structs into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2626

3 7

[PATCH 0/3] MR2632: gdi: Support stock brushes in EMR_FILLRGN and EMR_FRAMERGN.
by Piotr Caban (＠piotr) 11 Apr '23

11 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2632

3 4

[PATCH 0/2] MR154: vkd3d-shader/hlsl: Fix numeric offset of object fields.
by Francisco Casas (＠fcasas) 11 Apr '23

11 Apr '23

While struct and array fields within a struct always push the next fields numeric offset to the next register boundary, objects alone don't. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/154

2 2

[PATCH 0/5] MR2631: wineps: Handle more spool file records.
by Piotr Caban (＠piotr) 11 Apr '23

11 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2631

3 6

[PATCH v6 0/3] MR2496: Fix hang when a program calls IMFMediaSession_Start with an invalid source.
by Santino Mazza (＠tati1454) 11 Apr '23

11 Apr '23

This fixes a bug when the session topology contains an invalid source, which makes the session thread to hang and stop executing commands. -- v6: mf/session: Handle error when a source fails to start. mf/session: Handle errors when subscribing to source's events. mf/tests: Test media session error handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/2496

4 6

[PATCH v4 0/1] MR2617: kernel32/tests: Fix test for ACTCTX_FLAG_HMODULE_VALID with hModule = NULL case.
by Jinoh Kang (＠iamahuman) 11 Apr '23

11 Apr '23

Today, the test scenario "ACTCTX_FLAG_HMODULE_VALID but hModule if not set" is broken and unreliable. This problem is not evident in WineHQ batch test runs; rather, the test failure seems to only be triggered when the kernel32:actctx test is run in isolation. When the flag ACTCTX_FLAG_HMODULE_VALID is specified in ACTCTX but hModule is set to NULL, CreateActCtxW() may encounter different failure modes depending on the test executable file. Error codes observed so far include ERROR_SXS_CANT_GEN_ACTCTX and ERROR_SXS_MANIFEST_TOO_BIG. It appears that the inconsistent failure was caused by Windows trying to interpret the main executable file of the current process as an XML manifest file. This fails due to one or more of the following reasons: - A valid PE executable that starts with the "MZ" signature is not a valid XML file. - The executable's size may exceed the limit imposed by the manifest parser. This is much more likely for binaries with debugging symbols. Meanwhile, winetest.exe bundles a stripped version of the test executable (kernel32_test-stripped.exe), which is often smaller than the original executable (not stripped). This probably explains why the problem was not visible in batch test runs. Fix this by changing the FullDllName of the main executable module's LDR_DATA_TABLE_ENTRY to the pathname of a temporary manifest file (valid or invalid) before testing. The testing is performed in a child process, since "corrupting" the internal state of a main test process is not desirable for achieving deterministic and reliable tests. Blocks !2555. -- v4: kernel32/tests: Fix test for ACTCTX_FLAG_HMODULE_VALID with hModule = NULL case. https://gitlab.winehq.org/wine/wine/-/merge_requests/2617

2 2

[PATCH v6 0/1] MR2622: ntdll: Use log-linear bucketing for free lists.
by Tatsuyuki Ishi (＠ishitatsuyuki) 11 Apr '23

11 Apr '23

Currently, the free list consists of a "small list" for sizes below 256, which are linearly spaced, and a "large list" which is manually split into a few chunks. This patch replaces it with a single log-linear policy, while expanding the range the large list covers. The old implementation had issues when a lot of large allocations happened. In this case, all the allocations went in the last catch-all bucket in the "large list", and what happens is: 1. The linked list grew in size over time, causing searching cost to skyrocket. 2. With the first-fit allocation policy, fragmentation was also making the problem worse. The new bucketing covers the entire range up until we start allocating large blocks, which will not enter the free list. It also makes the allocation policy closer to best-fit (although not exactly), reducing fragmentation. The increase in number of free lists does incur some cost when it needs to be skipped over, but the improvement in allocation performance outweighs it. For future work, these ideas (mostly from glibc) might or might not benefit performance: - Use an exact best-fit allocation policy. - Add a bitmap for freelist, allowing empty lists to be skipped with a single bit scan. For the benchmark, this drastically improves initial shader loading performance in Overwatch 2. In this workload 78k shaders are passed to DXVK for DXBC -> SPIRV translation, and for each shader a few allocation happens in the 4K – 100K range for the staging buffer. Before this patch, malloc consisted a whooping 43% of overhead. The overhead with log-linear bucketing is drastically lower, resulting in a ~2x improvement in loading time. Overhead for each `FREE_LIST_LINEAR_BITS` is as below: - 0: 7.7% - 1: 2.9% - 2: 1.3% - 3: 0.6% Since performance seems to scale linearly with increase in buckets (up to the point I have tested), I've opted for 3 (8 buckets per doubling) in the current revision of patch. Signed-off-by: Tatsuyuki Ishi <ishitatsuyuki(a)gmail.com> -- v6: ntdll: Use log-linear bucketing for free lists. https://gitlab.winehq.org/wine/wine/-/merge_requests/2622

2 2

[PATCH v5 0/1] MR2622: ntdll: Use log-linear bucketing for free lists.
by Tatsuyuki Ishi (＠ishitatsuyuki) 11 Apr '23

11 Apr '23

Currently, the free list consists of a "small list" for sizes below 256, which are linearly spaced, and a "large list" which is manually split into a few chunks. This patch replaces it with a single log-linear policy, while expanding the range the large list covers. The old implementation had issues when a lot of large allocations happened. In this case, all the allocations went in the last catch-all bucket in the "large list", and what happens is: 1. The linked list grew in size over time, causing searching cost to skyrocket. 2. With the first-fit allocation policy, fragmentation was also making the problem worse. The new bucketing covers the entire range up until we start allocating large blocks, which will not enter the free list. It also makes the allocation policy closer to best-fit (although not exactly), reducing fragmentation. The increase in number of free lists does incur some cost when it needs to be skipped over, but the improvement in allocation performance outweighs it. For future work, these ideas (mostly from glibc) might or might not benefit performance: - Use an exact best-fit allocation policy. - Add a bitmap for freelist, allowing empty lists to be skipped with a single bit scan. For the benchmark, this drastically improves initial shader loading performance in Overwatch 2. In this workload 78k shaders are passed to DXVK for DXBC -> SPIRV translation, and for each shader a few allocation happens in the 4K – 100K range for the staging buffer. Before this patch, malloc consisted a whooping 43% of overhead. The overhead with log-linear bucketing is drastically lower, resulting in a ~2x improvement in loading time. Overhead for each `FREE_LIST_LINEAR_BITS` is as below: - 0: 7.7% - 1: 2.9% - 2: 1.3% - 3: 0.6% Since performance seems to scale linearly with increase in buckets (up to the point I have tested), I've opted for 3 (8 buckets per doubling) in the current revision of patch. Signed-off-by: Tatsuyuki Ishi <ishitatsuyuki(a)gmail.com> -- v5: ntdll: Use log-linear bucketing for free lists. https://gitlab.winehq.org/wine/wine/-/merge_requests/2622

4 9

[PATCH v2 0/9] MR2627: imm32: Implement input context cache and use INPUTCONTEXT directly in some functions.
by Rémi Bernon (＠rbernon) 11 Apr '23

11 Apr '23

-- v2: imm32: Use INPUTCONTEXT directly in ImmSetConversionStatus. imm32: Use INPUTCONTEXT directly in ImmGetConversionStatus. imm32: Compare open status values in ImmSetOpenStatus. imm32: Cache INPUTCONTEXT values for every IME. imm32: Use INPUTCONTEXT directly in ImmSetOpenStatus. imm32: Use INPUTCONTEXT directly in ImmGetOpenStatus. imm32: Serialize ImeInquire / ImeDestroy calls. imm32/tests: Cleanup the cross thread IMC tests. imm32/tests: Reduce the number of IME installations. https://gitlab.winehq.org/wine/wine/-/merge_requests/2627

3 11

[PATCH v4 0/6] MR2577: d3dcompiler: Use the vkd3d-shader DXBC API.
by Henri Verbeet (＠hverbeet) 11 Apr '23

11 Apr '23

The main advantage is that this way we're getting valid DXBC checksums for DXBC blobs generated by d3dcompiler. See also https://bugs.winehq.org/show_bug.cgi?id=54464. -- v4: d3dcompiler: Use vkd3d_shader_parse_dxbc() in d3dcompiler_shader_reflection_init(). d3dcompiler: Use vkd3d_shader_parse_dxbc() in d3dcompiler_strip_shader(). d3dcompiler: Use vkd3d_shader_parse_dxbc() in d3dcompiler_get_blob_part(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2577

3 10

[PATCH 0/5] MR2629: msvcrt: Use remaining math functions from the bundled musl library.
by Alexandre Julliard (＠julliard) 11 Apr '23

11 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2629

3 6

[PATCH v3 0/1] MR2622: ntdll: Use log-linear bucketing for free lists.
by Tatsuyuki Ishi (＠ishitatsuyuki) 11 Apr '23

11 Apr '23

Currently, the free list consists of a "small list" for sizes below 256, which are linearly spaced, and a "large list" which is manually split into a few chunks. This patch replaces it with a single log-linear policy, while expanding the range the large list covers. The old implementation had issues when a lot of large allocations happened. In this case, all the allocations went in the last catch-all bucket in the "large list", and what happens is: 1. The linked list grew in size over time, causing searching cost to skyrocket. 2. With the first-fit allocation policy, fragmentation was also making the problem worse. The new bucketing covers the entire range up until we start allocating large blocks, which will not enter the free list. It also makes the allocation policy closer to best-fit (although not exactly), reducing fragmentation. The increase in number of free lists does incur some cost when it needs to be skipped over, but the improvement in allocation performance outweighs it. For future work, these ideas (mostly from glibc) might or might not benefit performance: - Use an exact best-fit allocation policy. - Add a bitmap for freelist, allowing empty lists to be skipped with a single bit scan. For the benchmark, this drastically improves initial shader loading performance in Overwatch 2. In this workload 78k shaders are passed to DXVK for DXBC -> SPIRV translation, and for each shader a few allocation happens in the 4K – 100K range for the staging buffer. Before this patch, malloc consisted a whooping 43% of overhead. The overhead with log-linear bucketing is drastically lower, resulting in a ~2x improvement in loading time. Overhead for each `FREE_LIST_LINEAR_BITS` is as below: - 0: 7.7% - 1: 2.9% - 2: 1.3% - 3: 0.6% Since performance seems to scale linearly with increase in buckets (up to the point I have tested), I've opted for 3 (8 buckets per doubling) in the current revision of patch. Signed-off-by: Tatsuyuki Ishi <ishitatsuyuki(a)gmail.com> -- v3: ntdll: Use log-linear bucketing for free lists. https://gitlab.winehq.org/wine/wine/-/merge_requests/2622

4 4

[PATCH v5 0/2] MR141: vkd3d-shader/ir: Normalise hull shader control point phase I/O.
by Conor McCarthy (＠cmccarthy) 11 Apr '23

11 Apr '23

To simplify SM 6 support, insert a control point id relative address where needed, and declare control point phase inputs where missing. -- v5: vkd3d-shader/ir: Insert hull shader control point input declarations if no control point phase is defined. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/141

2 2

[PATCH v4 0/2] MR2032: winex11: Allow replacing either context in wglShareLists.
by Alex Henrie (＠alexhenrie) 11 Apr '23

11 Apr '23

The deleted test is a bad test: The behavior is different on different drivers, for example, the test fails on the Windows 10 and 11 testbot machines that have AMD video cards. Furthermore, MSDN does not say that the destination context "must not" have any display lists yet but rather that it "should not" have any.[1] The Khronos OpenGL Wiki similarly advises against calling wglShareLists after the source or destination context has at least one object, but if you do, it only says that "there is a chance that wglShareLists will fail", not that it will necessarily fail.[2] Since there's no clear "right" behavior here, we can adopt the more permissive behavior that some programs expect, as long as it doesn't corrupt the context. [1] https://learn.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-wglsha… [2] https://www.khronos.org/opengl/wiki/Platform_specifics:_Windows#wglShareLis… Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=11436 -- v4: winex11: Allow replacing either context in wglShareLists. opengl32/tests: Make the wglShareLists tests comprehensive. https://gitlab.winehq.org/wine/wine/-/merge_requests/2032

3 6

[PATCH v2 0/1] MR2591: include: _InterlockedExchangePointer and _InterlockedCompareExchangePointer...
by Stefan Dösinger (＠stefan) 11 Apr '23

11 Apr '23

include: _InterlockedExchangePointer and _InterlockedCompareExchangePointer are intrinsics in x86 msvc. I fixed this issue in ad05f33d67, but a40973f20 regressed this again. I was carrying a patch for quite a while, feeling dejavu. The msvc ver of 1900 is taken from Boost's interlocked.hpp, which matches MSVC 2015 (toolset version v140). Boost has a comment that claims that in msvc 2012 those functions were defined in intrin.h, but those defines are broken with Microsoft's winnt.h. -- v2: include: x86 msvc has _InterlockedExchangePointer and _InterlockedCompareExchangePointer https://gitlab.winehq.org/wine/wine/-/merge_requests/2591

2 1

[PATCH 0/8] MR2627: imm32: Implement input context cache and use INPUTCONTEXT directly in some functions.
by Rémi Bernon (＠rbernon) 11 Apr '23

11 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2627

3 10

[PATCH v2 0/1] MR2622: ntdll: Use log-linear bucketing for free lists.
by Tatsuyuki Ishi (＠ishitatsuyuki) 11 Apr '23

11 Apr '23

Currently, the free list consists of a "small list" for sizes below 256, which are linearly spaced, and a "large list" which is manually split into a few chunks. This patch replaces it with a single log-linear policy, while expanding the range the large list covers. The old implementation had issues when a lot of large allocations happened. In this case, all the allocations went in the last catch-all bucket in the "large list", and what happens is: 1. The linked list grew in size over time, causing searching cost to skyrocket. 2. With the first-fit allocation policy, fragmentation was also making the problem worse. The new bucketing covers the entire range up until we start allocating large blocks, which will not enter the free list. It also makes the allocation policy closer to best-fit (although not exactly), reducing fragmentation. The increase in number of free lists does incur some cost when it needs to be skipped over, but the improvement in allocation performance outweighs it. For future work, these ideas (mostly from glibc) might or might not benefit performance: - Use an exact best-fit allocation policy. - Add a bitmap for freelist, allowing empty lists to be skipped with a single bit scan. Signed-off-by: Tatsuyuki Ishi <ishitatsuyuki(a)gmail.com> -- v2: ntdll: Use log-linear bucketing for free lists. https://gitlab.winehq.org/wine/wine/-/merge_requests/2622

5 8

[PATCH v2 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Mohamad Al-Jaf (＠maljaf) 11 Apr '23

11 Apr '23

Needed for mingw Firefox build. The WIDL error points to the wrong function, specifically the one after it. include/windows.ui.composition.interop.idl:35:63: error: parameter 'swapchain' of function 'CreateCompositionSurfaceForHandle' cannot derive from void * HRESULT CreateCompositionSurfaceForSwapChain([in] IUnknown *swapchain, [out, retval] ICompositionSurface **result); ^ make[1]: *** [Makefile:163749: include/windows.ui.composition.interop.h] Error 1 -- v2: include: Add windows.ui.composition.interop.idl file. widl: Add support for WinRT HANDLE parameter type. https://gitlab.winehq.org/wine/wine/-/merge_requests/2620

4 6

[PATCH v4 0/2] MR2546: winegstreamer: Create extra decodebin to decode compressed stream.
by Ziqing Hui (＠zhui) 11 Apr '23

11 Apr '23

-- v4: wingstreamer: Create extra decodebin to decode compressed stream. winegstreamer: Implement wg_format_from_caps_video_wmv. https://gitlab.winehq.org/wine/wine/-/merge_requests/2546

2 2

[PATCH 0/4] MR2626: wine{alsa,coreaudio,oss,pulse}: Move common mmdevdrv structs into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 11 Apr '23

11 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2626

3 11

[PATCH v4 0/2] MR141: vkd3d-shader/ir: Normalise hull shader control point phase I/O.
by Conor McCarthy (＠cmccarthy) 11 Apr '23

11 Apr '23

To simplify SM 6 support, insert a control point id relative address where needed, and declare control point phase inputs where missing. -- v4: vkd3d-shader/ir: Insert hull shader control point input declarations if no control point phase is defined. vkd3d-shader/ir: Normalise control point phase output registers to include the control point id. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/141

2 2

[PATCH v3 0/2] MR141: vkd3d-shader/ir: Normalise hull shader control point phase I/O.
by Conor McCarthy (＠cmccarthy) 11 Apr '23

11 Apr '23

To simplify SM 6 support, insert a control point id relative address where needed, and declare control point phase inputs where missing. -- v3: vkd3d-shader/ir: Insert hull shader control point input declarations if no control point phase is defined. vkd3d-shader/ir: Normalise control point phase output registers to include the control point id. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/141

2 2

[PATCH v2 0/2] MR141: vkd3d-shader/ir: Normalise hull shader control point phase I/O.
by Conor McCarthy (＠cmccarthy) 11 Apr '23

11 Apr '23

To simplify SM 6 support, insert a control point id relative address where needed, and declare control point phase inputs where missing. -- v2: vkd3d-shader/ir: Insert hull shader control point input declarations if no control point phase is defined. vkd3d-shader/ir: Normalise control point phase output registers to include the control point id. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/141

2 2

[PATCH v5 0/4] MR126: Handle map ranges if possible, or emit a warning.
by Conor McCarthy (＠cmccarthy) 11 Apr '23

11 Apr '23

-- v5: vkd3d: Pass an offset and size to d3d12_heap_unmap() in d3d12_resource_WriteToSubresource(). vkd3d: Call vkFlushMappedMemoryRanges() when unmapping of a heap is requested. vkd3d: Pass an offset and size to d3d12_heap_map() in d3d12_resource_ReadFromSubresource(). vkd3d: Call vkInvalidateMappedMemoryRanges() when a mapping is requested on a heap. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/126

4 7

[PATCH 0/1] MR2625: winex11.drv: Fix bit shifts in pixel format description for RGBA formats.
by Paul Gofman (＠gofman) 11 Apr '23

11 Apr '23

Fixes Combat Mission: Battle for Normandy (GL game) failing to initialize GL on start. Looks like the game depends specifically on cAlphaShift being 24 (seemingly without any other prior checks, simply surfing through gdi32.DescribePixelFormat). The shifts in winex11.drv are obviously wrong currently: alpha channel doesn't preceded BGR in BGRA format (which is also confirmed by the test). cAlphaShift is a bit trickier though, that is marked as unsupported on Deck. Here on real hardware AMD desktop it is 24 (and alpha bits are 8). That's not the case on one Testbot machine though (win11_nv64) where both cAlphaShift and cAlphaBits are 0. So I made the test to accept such case as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2625

2 1

[PATCH v3 0/2] MR2546: winegstreamer: Create extra decodebin to decode compressed stream.
by Ziqing Hui (＠zhui) 11 Apr '23

11 Apr '23

-- v3: wingstreamer: Create extra decodebin to decode compressed stream. winegstreamer: Implement wg_format_from_caps_video_wmv. https://gitlab.winehq.org/wine/wine/-/merge_requests/2546

3 5

[PATCH v2 0/10] MR148: vkd3d-shader/hlsl: Support semantics for array types.
by Francisco Casas (＠fcasas) 11 Apr '23

11 Apr '23

This is required by https://bugs.winehq.org/show_bug.cgi?id=54660 . -- v2: vkd3d-shader/hlsl: Error out when a semantic is used with multiple types. vkd3d-shader/hlsl: Error out when an output semantic is used more than once. vkd3d-shader/hlsl: Don't create semantic vars more than once. vkd3d-shader/hlsl: Report missing semantics in struct fields. vkd3d-shader/hlsl: Move get_array_size() and get_array_type() to hlsl.c. vkd3d-shader/hlsl: Support semantics for array types. tests: Test array types with semantics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/148

3 16

Re: [PATCH v3 0/1] MR2624: include: Fix IDirectXVideoDecoderService declaration in dxva2api.idl. - approved
by Alexandre Julliard (＠julliard) 10 Apr '23

10 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2624

1 0

Re: [PATCH v3 0/1] MR2569: mshtml: Wine Gecko 2.47.4 release. - approved
by Alexandre Julliard (＠julliard) 10 Apr '23

10 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2569

1 0

Re: [PATCH v2 0/13] MR2623: msvcrt: Use still more functions from the bundled musl library. - approved
by Alexandre Julliard (＠julliard) 10 Apr '23

10 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2623

1 0

Re: [PATCH v2 0/5] MR2621: Some IShellView improvements. - approved
by Alexandre Julliard (＠julliard) 10 Apr '23

10 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2621

1 0

Re: [PATCH v7 0/5] MR2587: Support MF DXGI device manager in h264 decoder - approved
by Alexandre Julliard (＠julliard) 10 Apr '23

10 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2587

1 0

Re: [PATCH v3 0/1] MR2619: mfplat: Handle more video subtypes in MFInitMediaTypeFromAMMediaType(). - approved
by Alexandre Julliard (＠julliard) 10 Apr '23

10 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2619

1 0

Re: [PATCH v5 0/4] MR2603: winecoreaudio: Move timer logic to unixlib, matching other drivers. - approved
by Alexandre Julliard (＠julliard) 10 Apr '23

10 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2603

1 0

Re: [PATCH v2 0/1] MR2611: iphlpapi: Fix the GAA_FLAG_INCLUDE_GATEWAYS constant name. - approved
by Alexandre Julliard (＠julliard) 10 Apr '23

10 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2611

1 0

Re: [PATCH v6 0/2] MR131: vkd3d: Persistently map host-visible heaps on creation. - approved
by Alexandre Julliard (＠julliard) 10 Apr '23

10 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/131

1 0

[PATCH v2 0/1] MR2624: include: Fix IDirectXVideoDecoderService declaration in dxva2api.idl.
by Biswapriyo Nath (＠Biswa96) 10 Apr '23

10 Apr '23

This matches the declaration with official documentation and fixes the following two compiler errors in apitrace project. d3d9trace.cpp:28469:59: error: invalid conversion from 'const DXVA2_ConfigPictureDecode*' to 'DXVA2_ConfigPictureDecode*' [-fpermissive] d3d9trace.cpp:28194:65: error: invalid conversion from 'void*' to 'IUnknown*' [-fpermissive] -- v2: include: Fix IDirectXVideoDecoderService declaration in dxva2api.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/2624

3 2

[PATCH 0/1] MR2624: include: Fix IDirectXVideoDecoderService declaration in dxva2api.idl.
by Biswapriyo Nath (＠Biswa96) 10 Apr '23

10 Apr '23

This matches the declaration with official documentation and fixes the following two compiler errors in apitrace project. d3d9trace.cpp:28469:59: error: invalid conversion from 'const DXVA2_ConfigPictureDecode*' to 'DXVA2_ConfigPictureDecode*' [-fpermissive] d3d9trace.cpp:28194:65: error: invalid conversion from 'void*' to 'IUnknown*' [-fpermissive] -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2624

2 1

[PATCH 0/13] MR2623: msvcrt: Use still more functions from the bundled musl library.
by Alexandre Julliard (＠julliard) 10 Apr '23

10 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2623

4 16

2025

2024

2023

2022

wine-gitlab