- wine-gitlab - winehq.org

[PATCH 0/2] MR2545: winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID
by Yeshun Ye (＠yeyeshun) 31 Mar '23

31 Mar '23

winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID winmm/tests: Add flags tests for mixerGetLineControlsA/W support MIXER_GETLINECONTROLSF_ONEBYID and MIXER_GETLINECONTROLSF_ONEBYTYPE Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2545

3 3

[PATCH v3 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Yeshun Ye (＠yeyeshun) 31 Mar '23

31 Mar '23

Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com> -- v3: rpcrt4: Pass the binding handle to server call function. https://gitlab.winehq.org/wine/wine/-/merge_requests/2305

2 1

[PATCH 0/2] MR2541: dinput: Misc janitorings
by Michael Stefaniuc (＠mstefani) 31 Mar '23

31 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2541

3 3

[PATCH v2 0/1] MR2537: include: Add windows.ui.core.idl file.
by Mohamad Al-Jaf (＠maljaf) 31 Mar '23

31 Mar '23

Needed for mingw Firefox build. It looks like CoreDispatcher was added as a forward declaration for `ICompositionObject`: https://searchfox.org/mozilla-central/source/taskcluster/scripts/misc/mingw… However, just having `interface ICoreDispatcher;` alone does not generate the IUnknown methods. I don't know if commenting out the functions is acceptable. -- v2: include: Add windows.ui.core.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/2537

3 4

[PATCH 0/1] MR2544: winedevice: Use the ntoskrnl channel.
by Zebediah Figura (＠zfigura) 31 Mar '23

31 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2544

2 1

[PATCH v17 0/6] MR1145: kernel32: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) 30 Mar '23

30 Mar '23

a hotfix for the recent release of Persona 5 Royal. -- v17: kernel32: Add semi-stub for RemoveDirectoryTransactedA/W(). kernel32: Add semi-stub for GetFileAttributesTransactedA/W(). kernel32: Add semi-stub for FindFirstFileTransactedA/W(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1145

2 6

[PATCH v16 0/6] MR1145: kernel32: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) 30 Mar '23

30 Mar '23

a hotfix for the recent release of Persona 5 Royal. -- v16: kernel32: Add semi-stub for RemoveDirectoryTransactedA/W(). kernel32: Add semi-stub for GetFileAttributesTransactedA/W(). kernel32: Add semi-stub for FindFirstFileTransactedA/W(). kernel32: Add semi-stub for DeleteFileTransactedA/W(). kernel32: Add semi-stub for CreateDirectoryTransactedA/W(). kernel32: Add semi-stub for CreateFileTransactedA/W(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1145

2 7

Re: [PATCH v15 0/6] MR1145: kernel32: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) 30 Mar '23

30 Mar '23

On Thu Mar 30 18:33:42 2023 +0000, Alexandre Julliard wrote: > Please don't use Hungarian notation, particularly when the other > parameters use the standard form. hungarian notation is the pus in front of MiniVersion if I am reading correctly? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1145#note_28475

1 0

[PATCH v2 0/1] MR2540: include: Define __has_attribute() if the compiler does not provide it.
by Zebediah Figura (＠zfigura) 30 Mar '23

30 Mar '23

Fixes: f4c3801495f4fe17a10e2f21339de3b511c78339 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54666 -- v2: include: Include corecrt.h in vadefs.h https://gitlab.winehq.org/wine/wine/-/merge_requests/2540

2 1

Re: [PATCH v3 0/1] MR2521: msado15: Handle DBTYPE_STR type when loading recordset data - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2521

1 0

Re: [PATCH v2 0/1] MR2538: include: Add DirectXAlphaMode enum. - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2538

1 0

Re: [PATCH v2 0/1] MR2534: dmsynth: Don't crash when Open() gets a DMUS_PORTPARAMS7 - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2534

1 0

Re: [PATCH v6 0/3] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests. - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

1 0

Re: [PATCH v4 0/11] MR2539: imm32: Introduce a default IME implementation. - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2539

1 0

Re: [PATCH v2 0/1] MR2468: ntdll: Don't report user (PE) stack via pthread_attr_setstack(). - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2468

1 0

Re: [PATCH v2 0/2] MR2527: Avoid using the comma operator - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2527

1 0

Re: [PATCH v2 0/3] MR2536: services: Change running service state once its process dies. - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2536

1 0

Re: [PATCH v7 0/2] MR2231: cfgmgr32: Implement CM_MapCrToWin32Err. - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2231

1 0

[PATCH v22 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 30 Mar '23

30 Mar '23

Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v22: ntdll/tests: Increase margins in timer merging tests. ntdll: Set xattr in NtCreateFile if inferred and requested attributes don't match. ntdll: Only infer hidden attribute from file name if xattr is not present. ntdll: Handle hidden file names inside get_file_info instead of after it. ntdll: Do not open-code hidden file handling in get_dir_data_entry. ntdll/tests: Add test for file attributes of files with names beginning with a dot. https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

3 9

[PATCH v4 0/6] MR2476: winewayland.drv: part 2: Display configuration enhancements
by Alexandros Frantzis (＠afrantzis) 30 Mar '23

30 Mar '23

This second MR in the Wayland series adds display configuration related enhancements, including providing more display information (like a proper/consistent name and position) to Wine and supporting GetCurrentDisplaySettings. To get additional information from the Wayland compositor we need to use a protocol from the wayland-protocols collection, so we introduce support in the build system for protocol .xml files. These changes are introduced on their own commit in the series, but we can squash it with the next commit, where the functionality is first used, if preferred. To be able to provide a consistent view of the display settings across all processes, this MR leverages the win32u CURRENT_SETTINGS storage mechanism (which was previously used only in the null driver). Thanks! -- v4: winewayland.drv: Infer and report Windows monitor positions. winewayland.drv: Use the output name reported by the compositor. tools: Support building Wayland protocol source files. winewayland.drv: Handle wl_output objects only in the desktop process. winewayland.drv: Support GetCurrentDisplaySettings. win32u: Support setting the registry mode using gdi_device_manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2476

3 7

[PATCH v5 0/6] MR2476: winewayland.drv: part 2: Display configuration enhancements
by Alexandros Frantzis (＠afrantzis) 30 Mar '23

30 Mar '23

This second MR in the Wayland series adds display configuration related enhancements, including providing more display information (like a proper/consistent name and position) to Wine and supporting GetCurrentDisplaySettings. To get additional information from the Wayland compositor we need to use a protocol from the wayland-protocols collection, so we introduce support in the build system for protocol .xml files. These changes are introduced on their own commit in the series, but we can squash it with the next commit, where the functionality is first used, if preferred. To be able to provide a consistent view of the display settings across all processes, this MR leverages the win32u CURRENT_SETTINGS storage mechanism (which was previously used only in the null driver). Thanks! -- v5: winewayland.drv: Infer and report Windows monitor positions. winewayland.drv: Use the output name reported by the compositor. tools: Support building Wayland protocol source files. winewayland.drv: Handle wl_output objects only in the desktop process. winewayland.drv: Support GetCurrentDisplaySettings. win32u: Support setting the registry mode using gdi_device_manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2476

2 6

Re: [PATCH v15 0/6] MR1145: kernel32: Implement various transacted file APIs.
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

Alexandre Julliard (@julliard) commented about dlls/kernel32/path.c: > return MoveFileWithProgressW(source, dest, progress, data, flags); > } > > +/************************************************************************* > + * CreateFileTransactedA (KERNEL32.@) > + */ > +HANDLE WINAPI DECLSPEC_HOTPATCH CreateFileTransactedA( LPCSTR name, DWORD access, DWORD sharing, > + LPSECURITY_ATTRIBUTES sa, DWORD creation, > + DWORD attributes, HANDLE template, > + HANDLE transaction, PUSHORT pusMiniVersion, > + PVOID pExtendedParameter ) > +{ Please don't use Hungarian notation, particularly when the other parameters use the standard form. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1145#note_28447

1 0

[PATCH 0/1] MR2540: include: Define __has_attribute() if the compiler does not provide it.
by Zebediah Figura (＠zfigura) 30 Mar '23

30 Mar '23

Fixes: f4c3801495f4fe17a10e2f21339de3b511c78339 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54666 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2540

3 2

[PATCH v3 0/6] MR2476: winewayland.drv: part 2: Display configuration enhancements
by Alexandros Frantzis (＠afrantzis) 30 Mar '23

30 Mar '23

This second MR in the Wayland series adds display configuration related enhancements, including providing more display information (like a proper/consistent name and position) to Wine and implementing GetCurrentDisplaySettings. To get additional information from the Wayland compositor we need to use a protocol from the wayland-protocols collection, so we introduce support in the build system for protocol .xml files. These changes are introduced on their own in the first commit in the series, but we can squash it with the next commit, where the functionality is first used, if preferred. To be able to provide a consistent view of the display settings across all processes, this MR adds a shared memory region containing an authoritative version of the Wayland output information (see the "winewayland.drv: Implement GetCurrentDisplaySettings." commit for more details). Thanks! -- v3: winewayland.drv: Infer and report Windows monitor positions. winewayland.drv: Use the output name reported by the compositor. tools: Support building Wayland protocol source files. winewayland.drv: Handle wl_output objects only in the desktop process. winewayland.drv: Support GetCurrentDisplaySettings. win32u: Support setting the registry mode using gdi_device_manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2476

2 7

[PATCH v3 0/11] MR2539: imm32: Introduce a default IME implementation.
by Rémi Bernon (＠rbernon) 30 Mar '23

30 Mar '23

-- v3: winemac: Use the default IME implementation for stubs. winex11: Use the default IME implementation for stubs. imm32: Return TRUE from ImmIsIME with any HKL. imm32: Add a default implementation for IME functions. imm32: Introduce new input_context_init helper. imm32: Select current IME on input contexts when needed. imm32: Send WM_IME_SELECT messages when IME is activated. imm32: Pass the HIMC to the IME UI window IMMGWL_IMC. win32u: Ignore some IME messages in default_window_proc. win32u: Ignore IME messages from IME UI windows in DefWindowProc. imm32/tests: Test DefWindowProc with IME UI messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/2539

3 16

[PATCH v5 0/3] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests.
by Alex Henrie (＠alexhenrie) 30 Mar '23

30 Mar '23

ctxt_handle is moved to the top of struct tlsw_session so that it can be easily retrieved via LDAP_OPT_X_TLS_SSL_CTX. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- v5: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests. wldap32: Return ~0u from ldap_modrdn* for any error. https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

3 4

[PATCH v4 0/2] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests.
by Alex Henrie (＠alexhenrie) 30 Mar '23

30 Mar '23

ctxt_handle is moved to the top of struct tlsw_session so that it can be easily retrieved via LDAP_OPT_X_TLS_SSL_CTX. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- v4: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

2 3

[PATCH v2 0/5] MR2532: kernebase: Implement GetConsoleOriginalTitleA/W
by Hugh McMaster (＠hmc) 30 Mar '23

30 Mar '23

This series of patches implements GetConsoleOriginalTitleA/W(). We re-use the existing logic of GetConsoleTitle, as it is the same for GetConsoleOriginalTitle. -- v2: kernel32/tests: Test GetConsoleOriginalTitleA/W() with empty title kernelbase: Implement GetConsoleOriginalTitleA() kernelbase: Implement GetConsoleOriginalTitleW() conhost: Save original console title on initialization kernel32/tests: Check return length of GetConsoleOriginalTitleA/W() https://gitlab.winehq.org/wine/wine/-/merge_requests/2532

4 7

[PATCH 0/1] MR2468: ntdll: Don't report user (PE) stack via pthread_attr_setstack().
by Jinoh Kang (＠iamahuman) 30 Mar '23

30 Mar '23

Today, NtCreateThreadEx() passes to pthread_attr_setstack() an address range that spans both the user (PE) stack and the kernel (Unix) stack. pthread_attr_setstack() accepts an address range that will be used as the initial stack area for the thread created by pthread_create(). It is often assumed that the initial stack will be available for the entire duration of the thread's lifetime. This assumption, however, conflicts with how Win32 fibers operate. Fiber APIs allow the thread's initial stack to be freed before the thread exits, or kept alive beyond the point of thread's termination. This allows the lifetime of the thread's initial stack to be shorter or longer than the originating thread's lifetime. This is possible because each fiber has its own stack and context, and ConvertThreadToFiber() transfers the current thread's stack to a new fiber. This specifically causes problems in Glibc v2.31 and earlier. These Glibc versions have a bug where madvise(2) with the MADV_DONTNEED flag is called on the initial stack area on thread exit, even when the stack was user-supplied (via pthread_attr_setstack). Therefore, the kernel may zero out any portion of the initial stack at any time after the originating thread terminates, even if the stack no longer belongs to the current thread (either freed and reallocated, or owned by a fiber). This may ultimately lead to memory corruption. Fix this by only passing the syscall (kernel) portion of the stack to pthread_attr_setstack(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2468

3 2

[PATCH 0/2] MR2527: Avoid using the comma operator
by Michael Stefaniuc (＠mstefani) 30 Mar '23

30 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2527

4 4

[PATCH v2 0/11] MR2539: imm32: Introduce a default IME implementation.
by Rémi Bernon (＠rbernon) 30 Mar '23

30 Mar '23

-- v2: winemac: Use the default IME implementation for stubs. winex11: Use the default IME implementation for stubs. imm32: Return TRUE from ImmIsIME with any HKL. imm32: Add a default implementation for IME functions. imm32: Introduce new input_context_init helper. imm32: Select current IME on input contexts when needed. imm32: Send WM_IME_SELECT messages when IME is activated. imm32: Pass the HIMC to the IME UI window IMMGWL_IMC. win32u: Ignore some IME messages in default_window_proc. win32u: Ignore IME messages from IME UI windows in DefWindowProc. imm32/tests: Test DefWindowProc with IME UI messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/2539

3 13

[PATCH 0/11] MR2539: imm32: Introduce a default IME implementation.
by Rémi Bernon (＠rbernon) 30 Mar '23

30 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2539

3 12

[PATCH v3 0/2] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests.
by Alex Henrie (＠alexhenrie) 30 Mar '23

30 Mar '23

ctxt_handle is moved to the top of struct tlsw_session so that it can be easily retrieved via LDAP_OPT_X_TLS_SSL_CTX. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- v3: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests. wldap32: Implement ldap_connect. https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

3 5

[PATCH v2 0/1] MR2471: winegstreamer: In video_processor, activate a videoflip converter.
by eric pouech (＠epo) 30 Mar '23

30 Mar '23

The app I'm considering opens a video_processor on its own, with a NV12 format on input and a ARGB32 format on output. Tested on Windows: the samples are flipped vertically. While Wine keeps them untouched. So added a videoflip in the video processor to be activated when needed. Current activation is based on RGB vs non RGB input/output formats. Set as draft as if somehow related to MR!2159. Comments welcomed. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: winegstreamer: In video_processor, activate a videoflip converter. https://gitlab.winehq.org/wine/wine/-/merge_requests/2471

5 8

[PATCH 0/1] MR2537: include: Add windows.ui.core.idl file.
by Mohamad Al-Jaf (＠maljaf) 30 Mar '23

30 Mar '23

Needed for mingw Firefox build. It looks like CoreDispatcher was added as a forward declaration for `ICompositionObject`: https://searchfox.org/mozilla-central/source/taskcluster/scripts/misc/mingw… However, just having `interface ICoreDispatcher;` alone does not generate the IUnknown methods. I don't know if commenting out the functions is acceptable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2537

3 2

[PATCH 0/1] MR2538: include: Add DirectXAlphaMode enum.
by Mohamad Al-Jaf (＠maljaf) 30 Mar '23

30 Mar '23

Needed for mingw Firefox build. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2538

2 1

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 30 Mar '23

30 Mar '23

On Tue Mar 28 19:15:43 2023 +0000, Matteo Bruni wrote: > Similarly here, better to get rid of the return entirely. The other tests also return early if they fail to create a temporary file, but ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28390

1 0

[PATCH 0/3] MR2536: services: Change running service state once its process dies.
by Paul Gofman (＠gofman) 30 Mar '23

30 Mar '23

Fixes Epic Online Services update hanging when the service needs to be restarted (a helper process is waiting for either service's mutex to be available or QueryServiceStatus to tell that the server is stopped after the service had just exited the process without notifying service control manager). It seems to me that using a job object is much simpler than the other ways (like waiting on multiple process handles and managing process addition and deletion in the waiters list). I tested that on real up to date Windows 10 machine and there the process has the job object which object has JOB_OBJECT_LIMIT_BREAKAWAY_OK | JOB_OBJECT_LIMIT_SILENT_BREAKAWAY_OK limit flags (and only those). That job has also the other service processes in it but not services.exe itself. However, for some reason on any Testbot machine that is not the case and IsProcessInJob() reports that the process doesn't have a job. But since I do see that job on a real machine I think using job object here is fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2536

2 3

[PATCH 0/7] MR2535: wined3d: Recreate swapchain textures in wined3d_swapchain_resize_buffers().
by Zebediah Figura (＠zfigura) 30 Mar '23

30 Mar '23

Stop changing their attributes in place. This is complex, somewhat brittle, and currently broken for the Vulkan backend. Restrict wined3d_texture_update_desc() to changing user memory and pitch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2535

3 8

[PATCH v6 0/2] MR2231: cfgmgr32: Implement CM_MapCrToWin32Err.
by Mohamad Al-Jaf (＠maljaf) 29 Mar '23

29 Mar '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53781 The Matrix Awakens MegaCity Unreal Engine 5.1 demo and Hogwarts Legacy call this. Duplicate Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54513 -- v6: cfgmgr32/tests: Add CM_MapCrToWin32Err tests. cfgmgr32: Implement CM_MapCrToWin32Err. https://gitlab.winehq.org/wine/wine/-/merge_requests/2231

3 4

[PATCH 0/1] MR989: d3d10core/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 29 Mar '23

29 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/989

6 6

[PATCH 0/1] MR2534: dmsynth: Don't crash when Open() gets a DMUS_PORTPARAMS7
by Michael Stefaniuc (＠mstefani) 29 Mar '23

29 Mar '23

Wrong sizeof check: pointer instead of referenced structure. Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=53704 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2534

3 2

Re: [PATCH v5 0/7] MR2485: d3d10/effect: Add support for more instructions. - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2485

1 0

Re: [PATCH v3 0/2] MR2489: include: Add Windows.System.DispatcherQueue definition. - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2489

1 0

Re: [PATCH v12 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme. - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

1 0

Re: [PATCH v4 0/11] MR2531: imm32: Test and improve IME UI window creation. - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2531

1 0

Re: [PATCH v2 0/1] MR2487: ddraw/tests: Make test_texture_wrong_caps() a bit clearer. - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2487

1 0

Re: [PATCH v4 0/3] MR2480: ddraw: SetSurfaceDesc() refactoring, part 6. - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2480

1 0

Re: [PATCH v3 0/5] MR2524: msvcrt: _StructuredTaskCollection cancelling - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2524

1 0

Re: [PATCH v2 0/1] MR2475: wined3d: Add GPU information for another Intel UHD 630 GPU. - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2475

1 0

Re: [PATCH v2 0/2] MR2473: d3d10core/tests, d3d11/tests: Add a broken() case for WARP in test_occlusion_query(). - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2473

1 0

Re: [PATCH v2 0/1] MR2530: wine.inf: Put the Clients key in the right place. - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2530

1 0

Re: [PATCH v2 0/1] MR2529: kernelbase: Remove special Wow64 handling for HKEY_CLASSES_ROOT. - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2529

1 0

Re: [PATCH v2 0/7] MR2528: taskkill: Support terminating child processes. - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2528

1 0

Re: [PATCH v2 0/2] MR2526: Remove redundant NULL checks before free - approved
by Alexandre Julliard (＠julliard) 29 Mar '23

29 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2526

1 0

[PATCH v4 0/7] MR2485: d3d10/effect: Add support for more instructions.
by Nikolay Sivov (＠nsivov) 29 Mar '23

29 Mar '23

-- v4: d3d10/tests: Add some tests for trigonometric functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/2485

3 9

[PATCH v2 0/1] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests.
by Alex Henrie (＠alexhenrie) 29 Mar '23

29 Mar '23

ctxt_handle is moved to the top of struct tlsw_session so that it can be easily retrieved via LDAP_OPT_X_TLS_SSL_CTX. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- v2: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

3 6

[PATCH 0/4] MR2532: kernebase: Implement GetConsoleOriginalTitleA/W
by Hugh McMaster (＠hmc) 29 Mar '23

29 Mar '23

This series of patches implements GetConsoleOriginalTitleA/W(). We re-use the existing logic of GetConsoleTitle, as it is the same for GetConsoleOriginalTitle. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2532

4 7

[PATCH 0/1] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests.
by Alex Henrie (＠alexhenrie) 29 Mar '23

29 Mar '23

ctxt_handle is moved to the top of struct tlsw_session so that it can be easily retrieved via LDAP_OPT_X_TLS_SSL_CTX. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

2 1

[PATCH v3 0/6] MR2485: d3d10/effect: Add support for more instructions.
by Nikolay Sivov (＠nsivov) 29 Mar '23

29 Mar '23

-- v3: d3d10/effect: Add support for 'iadd' instruction. d3d10/effect: Add support for 'imin' instruction. d3d10/effect: Add support for umin/umax instructions. d3d10/effect: Add support for asin/acos/atan instructions. d3d10/effect: Handle division by zero in 'udiv'. d3d10/effect: Add support for 'movc' instruction. https://gitlab.winehq.org/wine/wine/-/merge_requests/2485

3 8

[PATCH v3 0/11] MR2531: imm32: Test and improve IME UI window creation.
by Rémi Bernon (＠rbernon) 29 Mar '23

29 Mar '23

-- v3: imm32: Create the IME UI as child of the IME default window. imm32: Re-create the IME UI window when IME changes. imm32: Keep the IME UI window on the default input context. imm32: Update existing input contexts on layout change. imm32/tests: Test IME UI window and IME window presence. imm32/tests: Test IME UI creation with the installed IME. imm32/tests: Test ImmProcessKey with the installed IME. imm32: Ignore ImmProcessKey if hkl isn't the current layout. imm32: Cleanup ImmProcessKey variables and traces. imm32/tests: Ignore expected calls marked with todo. imm32/tests: Add explicit ImmLoadIME / ImmFreeLayout calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/2531

2 12

[PATCH v2 0/5] MR2486: D3D12 swapchain latency semaphore fixes
by Giovanni Mascellani (＠giomasce) 29 Mar '23

29 Mar '23

-- v2: dxgi/tests: Test the frame latency waitable more thoroughly. https://gitlab.winehq.org/wine/wine/-/merge_requests/2486

3 8

[PATCH v2 0/11] MR2531: imm32: Test and improve IME UI window creation.
by Rémi Bernon (＠rbernon) 29 Mar '23

29 Mar '23

-- v2: imm32: Create the IME UI as child of the IME default window. imm32: Re-create the IME UI window when IME changes. imm32: Keep the IME UI window on the default input context. imm32: Update existing input contexts on layout change. imm32/tests: Test IME UI window and IME window presence. imm32/tests: Test IME UI creation with the installed IME. imm32/tests: Test ImmProcessKey with the installed IME. imm32: Ignore ImmProcessKey if hkl isn't the current layout. imm32: Cleanup ImmProcessKey variables and traces. imm32/tests: Ignore expected calls marked with todo. imm32/tests: Add explicit ImmLoadIME / ImmFreeLayout calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/2531

3 13

[PATCH v3 0/2] MR131: vkd3d: Persistently map host-visible heaps on creation.
by Zebediah Figura (＠zfigura) 29 Mar '23

29 Mar '23

-- v3: tests: Add a test for readback map stability. vkd3d: Persistently map host-visible heaps on creation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/131

4 5

[PATCH 0/10] MR2531: imm32: Test and improve IME UI window creation.
by Rémi Bernon (＠rbernon) 29 Mar '23

29 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2531

3 12

[PATCH 0/1] MR2487: ddraw/tests: Make test_texture_wrong_caps() a bit clearer.
by Zebediah Figura (＠zfigura) 29 Mar '23

29 Mar '23

* Disable lighting, which affects rendering tests in non-obvious ways. * Show that the texture is explicitly never set in ddraw7. * Show that the diffuse color is rendered in ddraw4 and ddraw7, which is consistent with the texture being unset in ddraw7 and suggests that the same applies to ddraw4. This may or may not help with bug 54069, but if it does not, it hopefully will at least make the reason for failure clearer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2487

4 3

[PATCH v2 0/6] MR2485: d3d10/effect: Add support for more instructions.
by Nikolay Sivov (＠nsivov) 29 Mar '23

29 Mar '23

-- v2: d3d10/effect: Add support for 'iadd' instruction. d3d10/effect: Add support for 'imin' instruction. d3d10/effect: Add support for umin/umax instructions. d3d10/effect: Add support for asin/acos/atan instructions. d3d10/effect: Handle division by zero in 'udiv'. d3d10/effect: Add support for 'movc' instruction. https://gitlab.winehq.org/wine/wine/-/merge_requests/2485

3 9

Re: [PATCH v3 0/3] MR2480: ddraw: SetSurfaceDesc() refactoring, part 6. - approved
by Jan Sikorski (＠jsikorski) 29 Mar '23

29 Mar '23

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2480

1 0

[PATCH v2 0/5] MR2524: msvcrt: _StructuredTaskCollection cancelling
by Torge Matthies (＠tmatthies) 29 Mar '23

29 Mar '23

Some refactoring + implementation of `_StructuredTaskCollection::_Cancel` and `_StructuredTaskCollection::_IsCanceling`. -- v2: msvcr100: Implement _StructuredTaskCollection::_IsCanceling. msvcr100: Implement _StructuredTaskCollection canceling. msvcr100: Use enum for _StructuredTaskCollection status bits. msvcr100: Use enum for _StructuredTaskCollection return value. msvcr100: Only wake task collection waiters when finished >= count. https://gitlab.winehq.org/wine/wine/-/merge_requests/2524

3 7

[PATCH v8 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) 29 Mar '23

29 Mar '23

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by ~~only opening the file with write access where necessary~~ temporarily modifying file access permisions to allow the file to be opened. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v8: server: Allow to open files without permission bits. https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

6 12

[PATCH 0/1] MR2475: wined3d: Add GPU information for another Intel UHD 630 GPU.
by Zebediah Figura (＠zfigura) 29 Mar '23

29 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2475

3 3

[PATCH 0/2] MR2473: d3d10core/tests, d3d11/tests: Add a broken() case for WARP in test_occlusion_query().
by Zebediah Figura (＠zfigura) 29 Mar '23

29 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2473

3 3

[PATCH 0/1] MR2530: wine.inf: Put the Clients key in the right place.
by Sven Baars (＠sbaars) 29 Mar '23

29 Mar '23

See https://learn.microsoft.com/en-us/windows/win32/winprog64/shared-registry-k… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2530

2 1

[PATCH 0/1] MR2529: kernelbase: Remove special Wow64 handling for HKEY_CLASSES_ROOT.
by Sven Baars (＠sbaars) 29 Mar '23

29 Mar '23

The server always returns the same key now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2529

2 1

Re: [PATCH v7 0/3] MR2449: win32u: Add a few device GPU properties. - approved
by Zhiyi Zhang (＠zhiyi) 29 Mar '23

29 Mar '23

This merge request was approved by Zhiyi Zhang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

1 0

[PATCH 0/7] MR2528: taskkill: Support terminating child processes.
by Paul Gofman (＠gofman) 29 Mar '23

29 Mar '23

Needed for Epic Online Services updater which invokes taskkill with /T flag and fails to replace a file if that didn't actually killed the processes. There is apparently a bit of refactoring on the way, with most notably using toolhelp snapshot instead of EnumProcesses(). That is more convenient for finding child processes (instead of performing a separate query for parent pid), but I also think that is more consistent in general and gets rid of existing separate query for process name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2528

3 8

[PATCH 0/2] MR2526: Remove redundant NULL checks before free
by Michael Stefaniuc (＠mstefani) 28 Mar '23

28 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2526

3 3

[PATCH v5 0/2] MR2231: cfgmgr32: Implement CM_MapCrToWin32Err.
by Mohamad Al-Jaf (＠maljaf) 28 Mar '23

28 Mar '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53781 The Matrix Awakens MegaCity Unreal Engine 5.1 demo and Hogwarts Legacy call this. Duplicate Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54513 -- v5: cfgmgr32/tests: Add CM_MapCrToWin32Err tests. cfgmgr32: Implement CM_MapCrToWin32Err. https://gitlab.winehq.org/wine/wine/-/merge_requests/2231

3 10

Re: [PATCH v6 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys. - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

1 0

Re: [PATCH v2 0/11] MR2522: wineps: Add support for more spool file records - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2522

1 0

Re: [PATCH v6 0/1] MR2429: msvcrt100: Add stub implementation for _UnrealizedChore::CheckTaskCollection - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2429

1 0

Re: [PATCH v2 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC. - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520

1 0

Re: [PATCH v2 0/1] MR2519: wldap32: Stub out setting LDAP_OPT_REFERRAL_HOP_LIMIT. - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2519

1 0

Re: [PATCH v2 0/6] MR2518: Fixes and improvements for taskschd:scheduler - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2518

1 0

Re: [PATCH v3 0/3] MR2478: wined3d: Make video memory accounting a per-resource flag. - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2478

1 0

[PATCH 0/1] MR2525: wip
by Rémi Bernon (＠rbernon) 28 Mar '23

28 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2525

2 3

[PATCH 0/4] MR2523: uiautomationcore: Miscellaneous MSAA provider patches.
by Connor McAdams (＠cmcadams) 28 Mar '23

28 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2523

4 6

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) 28 Mar '23

28 Mar '23

I left a few comments on the tests. Otherwise, I quite like the patch series. Force-setting the extended attributes on visible-but-starting-with-a-dot files seems like a good compromise to fix the bug at hand without requiring a ton of attribute setting and I couldn't think of any better solution. This won't fix the case of Wine-created dot files when the show_dot_files option is enabled if the user then disables the option, which again seems like a good compromise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28247

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) 28 Mar '23

28 Mar '23

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > + > + status = pNtQueryInformationFile( h, &io, &info, sizeof(info), FileBasicInformation ); > + ok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + ok( info.FileAttributes & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", info.FileAttributes ); > + ok( !(info.FileAttributes & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", info.FileAttributes ); > + > + CloseHandle( h ); > + > + GetTempPathW( MAX_PATH, temppathW ); > + GetTempFileNameW( temppathW, L"foo", 0, filenameW ); > + h = CreateFileW( filenameW, GENERIC_READ | GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_FLAG_DELETE_ON_CLOSE, 0 ); > + ok( h != INVALID_HANDLE_VALUE, "failed to create temp file\n" ); > + if (h == INVALID_HANDLE_VALUE) return; > + > + GetTempFileNameW( temppathW, L".foo", 0, filenameW ); > + if (!rename_file( h, filenameW )) return; ```suggestion:-0+0 winetest_push_context("foo -> .foo"); rename_file( h, filenameW ); winetest_pop_context(); ``` Or something like that. Similarly for the other rename_file() call below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28246

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) 28 Mar '23

28 Mar '23

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > + if (!ret) return FALSE; > + > + size = offsetof( FILE_RENAME_INFORMATION, FileName ) + ntpath.Length; > + fri = HeapAlloc( GetProcessHeap(), 0, size ); > + lok( fri != NULL, "HeapAlloc failed\n" ); > + if (!fri) return FALSE; > + fri->ReplaceIfExists = TRUE; > + fri->RootDirectory = NULL; > + fri->FileNameLength = ntpath.Length; > + memcpy( fri->FileName, ntpath.Buffer, ntpath.Length ); > + pRtlFreeUnicodeString( &ntpath ); > + > + status = pNtSetInformationFile( h, &io, fri, size, FileRenameInformation ); > + HeapFree( GetProcessHeap(), 0, fri ); > + lok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + return status == STATUS_SUCCESS; Let's get rid of the return and make the function void. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28245

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) 28 Mar '23

28 Mar '23

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > + ok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + ok( attrs & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", attrs ); > + todo_wine ok( !(attrs & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", attrs ); > + > + status = pNtQueryInformationFile( h, &io, &info, sizeof(info), FileBasicInformation ); > + ok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + ok( info.FileAttributes & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", info.FileAttributes ); > + ok( !(info.FileAttributes & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", info.FileAttributes ); > + > + CloseHandle( h ); > + > + GetTempPathW( MAX_PATH, temppathW ); > + GetTempFileNameW( temppathW, L"foo", 0, filenameW ); > + h = CreateFileW( filenameW, GENERIC_READ | GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_FLAG_DELETE_ON_CLOSE, 0 ); > + ok( h != INVALID_HANDLE_VALUE, "failed to create temp file\n" ); > + if (h == INVALID_HANDLE_VALUE) return; Similarly here, better to get rid of the return entirely. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28244

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) 28 Mar '23

28 Mar '23

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > } > > +#define lok ok_(__FILE__, line) > +#define rename_file(h,f) rename_file_(__LINE__,(h),(f)) > +static BOOL rename_file_( int line, HANDLE h, const WCHAR *filename ) > +{ > + FILE_RENAME_INFORMATION *fri; > + UNICODE_STRING ntpath; > + IO_STATUS_BLOCK io; > + NTSTATUS status; > + BOOLEAN ret; > + ULONG size; > + > + ret = pRtlDosPathNameToNtPathName_U( filename, &ntpath, NULL, NULL ); > + lok( ret, "RtlDosPathNameToNtPathName_U failed\n" ); > + if (!ret) return FALSE; Please get rid of the ok() and if() {}, we can just assume that the RtlDosPathNameToNtPathName_U() call works correctly (i.e. if it fails we have bigger problems and arguably crashing and burning is better than reporting a failure and silently skipping the test). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28242

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) 28 Mar '23

28 Mar '23

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > +{ > + FILE_RENAME_INFORMATION *fri; > + UNICODE_STRING ntpath; > + IO_STATUS_BLOCK io; > + NTSTATUS status; > + BOOLEAN ret; > + ULONG size; > + > + ret = pRtlDosPathNameToNtPathName_U( filename, &ntpath, NULL, NULL ); > + lok( ret, "RtlDosPathNameToNtPathName_U failed\n" ); > + if (!ret) return FALSE; > + > + size = offsetof( FILE_RENAME_INFORMATION, FileName ) + ntpath.Length; > + fri = HeapAlloc( GetProcessHeap(), 0, size ); > + lok( fri != NULL, "HeapAlloc failed\n" ); > + if (!fri) return FALSE; Same here for this HeapAlloc() call with very small size. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28243

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) 28 Mar '23

28 Mar '23

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > CloseHandle( h ); > } > > +#define lok ok_(__FILE__, line) > +#define rename_file(h,f) rename_file_(__LINE__,(h),(f)) > +static BOOL rename_file_( int line, HANDLE h, const WCHAR *filename ) I'd avoid these line shenanigans, we now have test contexts to disambiguate ok() calls from different tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28241

1 0

[PATCH 0/5] MR2524: msvcrt: _StructuredTaskCollection cancelling
by Torge Matthies (＠tmatthies) 28 Mar '23

28 Mar '23

Some refactoring + implementation of `_StructuredTaskCollection::_Cancel` and `_StructuredTaskCollection::_IsCanceling`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2524

2 6

[PATCH v2 0/8] MR1979: msvcrt: Remaining implementations and stubs for cm3
by Torge Matthies (＠tmatthies) 28 Mar '23

28 Mar '23

Based on !2524. This adds the remaining stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- v2: msvcr110: Add _Context::_IsSynchronouslyBlocked stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_dtor stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_ctor stub. msvcr100: Implement _StructuredTaskCollection::_IsCanceling. msvcr100: Implement _StructuredTaskCollection canceling. msvcr100: Use enum for _StructuredTaskCollection status bits. msvcr100: Use enum for _StructuredTaskCollection return value. msvcr100: Only wake task collection waiters when finished >= count. https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

2 8

[PATCH 0/5] MR1979: msvcrt: Remaining implementations and stubs for cm3
by Torge Matthies (＠tmatthies) 28 Mar '23

28 Mar '23

This adds the remaining `_StructuredTaskCollection` functions and other stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

3 15

[PATCH v6 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) 28 Mar '23

28 Mar '23

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- v6: win32u: Set DEVPKEY_Device_RemovalPolicy for GPUs. win32u: Set DEVPKEY_Device_BusNumber for GPUs. win32u: Set DEVPKEY_Device_MatchingDeviceId for GPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

3 6

[PATCH v5 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.
by Sven Baars (＠sbaars) 28 Mar '23

28 Mar '23

I initially wanted to do the refactoring in a separate merge request, but since my merge request yesterday broke the tests, I decided to add the implementation into this commit as well. -- v5: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. kernelbase: Call create_key() from create_subkey(). kernelbase: Factor creating a subkey out of create_key(). kernelbase: Don't open Wow6432nodes from create_key(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

2 6

[PATCH v7 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) 28 Mar '23

28 Mar '23

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by ~~only opening the file with write access where necessary~~ temporarily modifying file access permisions to allow the file to be opened. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v7: server: Allow to open files without permission bits. https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

3 5

2025

2024

2023

2022

wine-gitlab