- wine-gitlab - winehq.org

[PATCH v14 0/4] MR84: vkd3d-shader/spirv: Merge all shader IR fork and join phases into a single phase.
by Conor McCarthy (＠cmccarthy) 01 Mar '23

01 Mar '23

Normalise the incoming vkd3d_shader_instruction IR to the shader model 6 pattern where only one patch constant function is emitted. This allows generation of a single patch constant function in SPIR-V. -- v14: vkd3d-shader/spirv: Declare the phase SPIR-V function in spirv_compiler_enter_shader_phase(). vkd3d-shader/spirv: Remove the hull shader phase array. vkd3d-shader/trace: Trace the normalised instruction array after tracing the input. vkd3d-shader/ir: Merge all shader IR fork and join phases into a single phase. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/84

3 6

[PATCH v6 0/4] MR94: Fix other synchronization problems
by Giovanni Mascellani (＠giomasce) 01 Mar '23

01 Mar '23

-- v6: vkd3d: Do not keep the CS queue locked while processing it. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/94

4 6

[PATCH v2 0/2] MR2308: mfreadwrite/reader: Release device manager in source_reader_release.
by Adrian Thiele (＠athiele) 01 Mar '23

01 Mar '23

-- v2: mfreadwrite/reader: Release device manager in source_reader_release. mfreadwrite/tests: Check refcount of device manager after release. https://gitlab.winehq.org/wine/wine/-/merge_requests/2308

3 3

[PATCH 0/1] MR112: include: Document that vkd3d_shader_signature may contain pointers into the input shader blob.
by Zebediah Figura (＠zfigura) 01 Mar '23

01 Mar '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/112

3 2

[PATCH 0/1] MR2308: mfreadwrite/reader: Release device manager in source_reader_release.
by Adrian Thiele (＠athiele) 01 Mar '23

01 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2308

4 5

[PATCH 0/1] MR2307: dlls/dwrite: Pass correct font key when adding glyph to cache.
by Philip Gruebele (＠pgruebele) 01 Mar '23

01 Mar '23

Without this fix, the font cache was filling up with lots of duplicate entries, and getting cache misses, thereby causing font-intensive applications to be very slow (e.g. AvalonEdit) . This fix provides 30x speed increase when processing glyphs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2307

3 2

[PATCH 0/7] MR106: vkd3d-shader/hlsl: packoffset() support.
by Francisco Casas (＠fcasas) 01 Mar '23

01 Mar '23

Support manually packing constant buffer elements through the `packoffset(·)` syntax. Support not included yet for simultaneously having semantics, `register(·)`, and `packoffset(·)`, for abnormalities such as: ```hlsl Texture2D tex; cbuffer buff { float4 a : packoffset(c0); sampler sam : packoffset(c0) : register(s1) : SEMANTIC; } float4 main() : sv_target { return tex.Sample(sam, float2(0, 0)) + a; } ``` but this motivated the addition of the `hlsl_ir_var.offset_reservation` field instead of reusing `hlsl_ir_var.reg_reservation`. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106

4 25

[PATCH 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Yeshun Ye (＠yeyeshun) 01 Mar '23

01 Mar '23

Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305

4 7

[PATCH v3 0/1] MR2306: msado15: Implement _Recordset Open
by Alistair Leslie-Hughes (＠alesliehughes) 01 Mar '23

01 Mar '23

-- v3: msado15: Implement _Recordset Open https://gitlab.winehq.org/wine/wine/-/merge_requests/2306

2 1

Re: [PATCH v7 0/1] MR2153: win32u: Invalidate all cached keys after input. - approved
by Rémi Bernon (＠rbernon) 01 Mar '23

01 Mar '23

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2153

1 0

[PATCH 0/1] MR2306: msado15: Implement _Recordset Open
by Alistair Leslie-Hughes (＠alesliehughes) 01 Mar '23

01 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2306

3 2

[PATCH v2 0/1] MR2306: msado15: Implement _Recordset Open
by Alistair Leslie-Hughes (＠alesliehughes) 01 Mar '23

01 Mar '23

-- v2: msado15: Implement _Recordset Open https://gitlab.winehq.org/wine/wine/-/merge_requests/2306

3 2

[PATCH 0/3] MR2304: widl: Add parameterized signatures for more basic types.
by Rémi Bernon (＠rbernon) 01 Mar '23

01 Mar '23

Related to https://gitlab.winehq.org/wine/wine/-/merge_requests/2292. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2304

5 8

[PATCH v3 0/1] MR2081: Support relocatable fontconfig cache
by catsout (＠catsout) 01 Mar '23

01 Mar '23

For flatpak: ``` bind mount: /run/host/fonts <- /usr/share/fonts /run/host/user-fonts <- ~/.local/share/fonts /run/host/fonts-cache <- /usr/lib/fontconfig/cache /run/host/user-fonts-cache <- ~/.cache/fontconfig ``` For fontconfig: https://bugs.freedesktop.org/show_bug.cgi?id=101889 https://github.com/flatpak/flatpak/issues/589 It supports relocatable cache. ``` FcConfigGetFontDirs( config ) -> /run/host/user-fonts/test,... FcDirCacheRead( /run/host/user-fonts/test, ... ) -> FcCacheCopySet -> pattern FcPatternGetString( pattern, FC_FILE, 0, &filename ) -> ~/.local/share/fonts/test/test.ttf ``` For wine: ``` FcPatternGetString -> unix_name -> add_unix_face( unix_name, ... ) ``` The valid file path for flatpak is `/run/host/user-fonts/test/test.ttf`. `~/.local/share/fonts/test/test.ttf` does not exist in flatpak sandbox. Add a check for this, and switch to right path. Test: ``` flatpak install org.winehq.Wine LANG=zh_CN.UTF-8 flatpak run org.winehq.Wine winecfg ``` ![image](/uploads/6679b2771e3400b02903faa308a1d1c5/image.png) -- v3: Support relocatable fontconfig cache https://gitlab.winehq.org/wine/wine/-/merge_requests/2081

3 7

[PATCH v5 0/1] MR2153: win32u: invalidate all cached keys after input
by Henry Goffin (＠AMZN-hgoffin) 28 Feb '23

28 Feb '23

This patch addresses an issue in Second Life and potentially other multi-threaded applications which process WM_KEYDOWN in one thread and then verify that the key is "still down" with GetAsyncKeyState from another thread. Wine uses a per-thread key cache, resulting in inconsistent views of key status. Caches are now invalidated when an input event is injected by the driver or via SendInput. -- v5: win32u: invalidate all cached keys after input https://gitlab.winehq.org/wine/wine/-/merge_requests/2153

3 4

Re: [PATCH v2 0/1] MR2290: shell32: Add support for Program Manager icons with arguments.
by Alex Henrie (＠alexhenrie) 28 Feb '23

28 Feb '23

Thanks Huw! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2290#note_25826

1 0

Re: [PATCH v2 0/1] MR2300: Turkish translation update - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2300

1 0

Re: [PATCH v4 0/1] MR2297: winex11: Assume that Xkb extension is available. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2297

1 0

Re: [PATCH v2 0/1] MR2301: maintainers: Add myself to the Audio I/O section. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2301

1 0

Re: [PATCH v4 0/2] MR2016: winex11: Take advantage of RTL_CONSTANT_STRING. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2016

1 0

Re: [PATCH v5 0/1] MR1377: dsound: Use CRT functions for memory allocation. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1377

1 0

Re: [PATCH v2 0/1] MR2257: mmdevapi/tests: WoW64 processes can read the properties from the registry. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2257

1 0

[PATCH v4 0/2] MR2279: riched20: Don't set para unless committing cursor move in ME_MoveCursorWords. (#54564)
by Jinoh Kang (＠iamahuman) 28 Feb '23

28 Feb '23

Introduce a temporary variable, `other_para`, so that we don't end up returning incorrect para (with stale run) inside the output cursor. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54564 -- v4: riched20: Don't set para unless committing cursor move in ME_MoveCursorWords. riched20/tests: Test for word movement across paragraph boundary. https://gitlab.winehq.org/wine/wine/-/merge_requests/2279

3 3

Re: [PATCH v3 0/3] MR2276: riched20/tests: Fix the EM_GETSELTEXT tests in Hindi on Windows. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2276

1 0

Re: [PATCH v2 0/1] MR2290: shell32: Add support for Program Manager icons with arguments. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2290

1 0

Re: [PATCH v3 0/1] MR2295: msado15: Free recordset filter on close. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2295

1 0

Re: [PATCH v4 0/1] MR110: vkd3d-shader: Make documentation for "messages" parameters self contained. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/110

1 0

Re: [PATCH v4 0/6] MR102: hlsl: Matrix majority, 2023 edition, part 2/2. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/102

1 0

[PATCH v4 0/1] MR2153: win32u: invalidate all cached keys after input
by Henry Goffin (＠AMZN-hgoffin) 28 Feb '23

28 Feb '23

This patch addresses an issue in Second Life and potentially other multi-threaded applications which process WM_KEYDOWN in one thread and then verify that the key is "still down" with GetAsyncKeyState from another thread. Wine uses a per-thread key cache, resulting in inconsistent views of key status. Caches are now invalidated when an input event is injected by the driver or via SendInput. -- v4: win32u: invalidate all cached keys after input https://gitlab.winehq.org/wine/wine/-/merge_requests/2153

2 1

Re: [PATCH v4 0/2] MR1924: ntoskrnl.exe/tests: Add KeInitializeDpc tests.
by Rémi Bernon (＠rbernon) 28 Feb '23

28 Feb '23

Rémi Bernon (@rbernon) commented about include/ddk/wdm.h: > typedef struct _KDPC { > - CSHORT Type; > - UCHAR Number; > - UCHAR Importance; > - LIST_ENTRY DpcListEntry; > + UCHAR Type; > + UCHAR Importance; > + volatile USHORT Number; > + SINGLE_LIST_ENTRY DpcListEntry; > + KAFFINITY ProcessorHistory; > PKDEFERRED_ROUTINE DeferredRoutine; > PVOID DeferredContext; > PVOID SystemArgument1; > PVOID SystemArgument2; > - PULONG_PTR Lock; > + PVOID DpcData; This doesn't seem to match `wdm.h` from SDK 10.0.19041.0 at least. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1924#note_25794

1 0

[PATCH v2 0/1] MR2153: win32u: invalidate all cached keys after input
by Henry Goffin (＠AMZN-hgoffin) 28 Feb '23

28 Feb '23

This patch addresses an issue in Second Life and potentially other multi-threaded applications which process WM_KEYDOWN in one thread and then verify that the key is "still down" with GetAsyncKeyState from another thread. Wine uses a per-thread key cache, resulting in inconsistent views of key status. Caches are now invalidated when an input event is injected by the driver or via SendInput. -- v2: win32u: invalidate all cached keys after input https://gitlab.winehq.org/wine/wine/-/merge_requests/2153

3 5

[PATCH 0/1] MR2302: gdiplus: Use FILE_SHARE_READ in GdipPrivateAddFontFile().
by w-flo (＠w-flo) 28 Feb '23

28 Feb '23

ZusiDisplay sometimes loads the same font file into two different PrivateFontCollections using two threads, so there is a race condition when the file is opened without the FILE_SHARE_READ sharing mode. The second call to GdipPrivateAddFontFile() might fail if the first one hasn't closed the file handle yet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2302

3 4

[PATCH v3 0/2] MR2016: winex11: Take advantage of RTL_CONSTANT_STRING.
by Alex Henrie (＠alexhenrie) 28 Feb '23

28 Feb '23

-- v3: winex11: Avoid calling RtlInitUnicodeString on a static constant. winex11: Use RTL_CONSTANT_STRING instead of reimplementing it. https://gitlab.winehq.org/wine/wine/-/merge_requests/2016

2 3

Re: [PATCH v2 0/2] MR2016: winex11: Take advantage of RTL_CONSTANT_STRING.
by Jacek Caban (＠jacek) 28 Feb '23

28 Feb '23

Jacek Caban (@jacek) commented about dlls/winex11.drv/desktop.c: > static void query_desktop_work_area( RECT *rc_work ) > { > static const WCHAR trayW[] = {'S','h','e','l','l','_','T','r','a','y','W','n','d'}; > - UNICODE_STRING str = { sizeof(trayW), sizeof(trayW), (WCHAR *)trayW }; > + UNICODE_STRING str = RTL_CONSTANT_STRING( trayW ); You'd need to null-terminate trayW for this to work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2016#note_25765

1 0

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Matteo Bruni (＠Mystral) 28 Feb '23

28 Feb '23

On Tue Feb 28 14:37:01 2023 +0000, Henri Verbeet wrote: > It's probably worth pointing out that this has quite some potential for > causing regressions in performance. swapchain_blit_gdi() is not fast, > and ideally we'd work on reducing the number of cases where it's needed. !2217 should avoid most of those cases I think, it probably makes sense to wait for that one to go in first. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_25759

1 0

[PATCH v4 0/5] MR2296: Always use the user images for the D3D12 swapchain
by Giovanni Mascellani (＠giomasce) 28 Feb '23

28 Feb '23

-- v4: dxgi: Reset the back buffer index to zero on ResizeBuffers(). dxgi/tests: Test that ResizeBuffers() resets the back buffer index to zero. dxgi: Always assume that a D3D12 swapchain always uses user images. dxgi: Immediately error out when creating a D3D12 swapchain on a non-immediate queue. dxgi/tests: Test that D3D12 swapchains can only be created on direct command queues. https://gitlab.winehq.org/wine/wine/-/merge_requests/2296

2 6

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Matteo Bruni (＠Mystral) 28 Feb '23

28 Feb '23

On Tue Feb 28 10:26:07 2023 +0000, Matteo Bruni wrote: > I guess we could add a WARN("Using pixel format %u already set on DC > %p.\n", current, dc); or something. Actually the WARN() in wined3d_context_gl_set_gl_context() is probably enough already, so disregard this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_25755

1 0

[PATCH v13 0/4] MR84: vkd3d-shader/spirv: Merge all shader IR fork and join phases into a single phase.
by Conor McCarthy (＠cmccarthy) 28 Feb '23

28 Feb '23

Normalise the incoming vkd3d_shader_instruction IR to the shader model 6 pattern where only one patch constant function is emitted. This allows generation of a single patch constant function in SPIR-V. -- v13: vkd3d-shader/spirv: Declare the phase SPIR-V function in spirv_compiler_enter_shader_phase(). vkd3d-shader/spirv: Remove the hull shader phase array. vkd3d-shader/trace: Trace the normalised instruction array after tracing the input. vkd3d-shader/ir: Merge all shader IR fork and join phases into a single phase. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/84

4 6

[PATCH v5 0/4] MR94: Fix other synchronization problems
by Giovanni Mascellani (＠giomasce) 28 Feb '23

28 Feb '23

-- v5: vkd3d: Do not keep the CS queue locked while processing it. vkd3d: Always enqueue CS operations, even if they can be executed right away. vkd3d: Hold the queue mutex when adding the queue to a blocked list. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/94

3 6

[PATCH v3 0/1] MR110: vkd3d-shader: Make documentation for "messages" parameters self contained.
by Giovanni Mascellani (＠giomasce) 28 Feb '23

28 Feb '23

Otherwise it's not clear which clauses in vkd3d_shader_compile() really apply to other functions. For example, many of the functions currently refering to vkd3d_shader_compile() don't even take a vkd3d_shader_compile_info parameter. -- v3: vkd3d-shader: Make documentation for "messages" parameters self contained. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/110

3 4

[PATCH v3 0/6] MR102: hlsl: Matrix majority, 2023 edition, part 2/2.
by Zebediah Figura (＠zfigura) 28 Feb '23

28 Feb '23

-- v3: vkd3d-shader/hlsl: Get rid of the check_invalid_matrix_modifiers() helper. vkd3d-shader/hlsl: Apply latent majority modifiers to typedefs as well. vkd3d-shader/hlsl: Do not set an initial latent matrix majority. vkd3d-shader/hlsl: Store the matrix majority as a type modifiers bitmask. vkd3d-shader/hlsl: Apply latent type modifiers to matrix array typedefs. tests: Add more tests for pack_matrix pragmas. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/102

3 8

[PATCH 0/1] MR2274: ntdll: Add source file and line to debug traces.
by Rémi Bernon (＠rbernon) 28 Feb '23

28 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2274

8 19

[PATCH v3 0/5] MR2296: Always use the user images for the D3D12 swapchain
by Giovanni Mascellani (＠giomasce) 28 Feb '23

28 Feb '23

-- v3: dxgi: Reset the back buffer index to zero on ResizeBuffers(). dxgi/tests: Test that ResizeBuffers() resets the back buffer index to zero. dxgi: Always assume that a D3D12 swapchain always uses user images. dxgi: Immediately error out when creating a D3D12 swapchain on a non-immediate queue. dxgi/tests: Test that D3D12 swapchains can only be created on direct command queues. https://gitlab.winehq.org/wine/wine/-/merge_requests/2296

3 6

Re: [PATCH v9 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 28 Feb '23

28 Feb '23

On Tue Feb 28 12:09:51 2023 +0000, Brendan Shanks wrote: > Thanks for this, I hadn't realized `IOPMCopyBatteryInfo` was so deprecated. > Looking at [Chromium's use of > `IOPSCopyPowerSources`](https://source.chromium.org/chromium/chromium/src/+/main:services/device/battery/battery_status_manager_mac.cc;drc=098756533733ea50b2dcb1c40d9a9e18d49febbe;l=127), > they first check that the source is present and internal, which seems > like a good idea. I changed it so it it does similar checks to Chromium and uses the first power source that works (and removed the internal battery check on kIOPSTypeKey since that is always true in that case already) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2283#note_25736

1 0

Re: [PATCH v9 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 28 Feb '23

28 Feb '23

On Mon Feb 27 20:50:31 2023 +0000, Brendan Shanks wrote: > The documentation for all these keys says that the type is > `kCFNumberIntType` (equivalent to SInt32, but it would be better to use > the documented type) Thanks, should be fixed now! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2283#note_25735

1 0

Re: [PATCH v9 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 28 Feb '23

28 Feb '23

On Mon Feb 27 20:50:31 2023 +0000, Brendan Shanks wrote: > You can `CFRelease(blob)` at this point, and then remove all the calls > from later in the function I believe it is still needed for `IOPSGetPowerSourceDescription`, but I released after it is no longer being called -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2283#note_25734

1 0

[PATCH v5 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 28 Feb '23

28 Feb '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- v5: d3d9: Disable instancing for not-indexed drawing d3d9/tests: Add test for not-indexed instancing drawing https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

3 3

[PATCH v8 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 28 Feb '23

28 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v8: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

2 1

[PATCH v2 0/5] MR2296: Always use the user images for the D3D12 swapchain
by Giovanni Mascellani (＠giomasce) 28 Feb '23

28 Feb '23

-- v2: dxgi: Reset the back buffer index to zero on ResizeBuffers(). dxgi/tests: Test that ResizeBuffers() resets the back buffer index to zero. dxgi: Always assume that a D3D12 swapchain always uses user images. dxgi: Immediately error out when creating a D3D12 swapchain on a non-immediate queue. dxgi/tests: Test that D3D12 swapchains can only be created on direct command queues. https://gitlab.winehq.org/wine/wine/-/merge_requests/2296

4 9

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Henri Verbeet (＠hverbeet) 28 Feb '23

28 Feb '23

It's probably worth pointing out that this has quite some potential for causing regressions in performance. swapchain_blit_gdi() is not fast, and ideally we'd work on reducing the number of cases where it's needed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_25724

1 0

[PATCH 0/1] MR2301: maintainers: Add myself to the Audio I/O section.
by Huw Davies (＠huw) 28 Feb '23

28 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2301

2 1

[PATCH v4 0/1] MR1377: dsound: Use CRT functions for memory allocation.
by Alex Henrie (＠alexhenrie) 28 Feb '23

28 Feb '23

The big win here is getting rid of the reimplementation of wcsdup. -- v4: dsound: Use CRT functions for memory allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1377

3 2

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Matteo Bruni (＠Mystral) 28 Feb '23

28 Feb '23

I left a small comment but, regardless, I think it's a step in the right direction (!2217 is another one). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_25714

1 0

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Matteo Bruni (＠Mystral) 28 Feb '23

28 Feb '23

Matteo Bruni (@Mystral) commented about dlls/wined3d/context_gl.c: > current = gl_info->gl_ops.wgl.p_wglGetPixelFormat(dc); > if (current == format) goto success; > > + if (current && !private) > + return FALSE; I guess we could add a WARN("Using pixel format %u already set on DC %p.\n", current, dc); or something. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_25713

1 0

[PATCH v4 0/4] MR94: Fix other synchronization problems
by Giovanni Mascellani (＠giomasce) 28 Feb '23

28 Feb '23

-- v4: vkd3d: Do not keep the CS queue locked while processing it. vkd3d: Always enqueue CS operations, even if they can be executed right away. vkd3d: Hold the queue mutex when adding the queue to a blocked list. vkd3d: Mention the correct mutex in a comment. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/94

4 13

[PATCH 0/1] MR2257: mmdevapi/tests: WoW64 processes can read the properties from the registry.
by Francois Gouget (＠fgouget) 28 Feb '23

28 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2257

3 2

[PATCH 0/5] MR1543: mmdevapi: Handle process_attach, process_detach and test_connect UNIX driver functions
by Davide Beatrici (＠davidebeatrici) 28 Feb '23

28 Feb '23

The goal is to eventually move all interfaces from each driver's `mmdevdrv.c` into `mmdevapi`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1543

5 12

[PATCH 0/1] MR1580: winex11.drv: Hide invisible owner windows that have visible owned windows in pager.
by Zhiyi Zhang (＠zhiyi) 28 Feb '23

28 Feb '23

Manual tests on XP, Win7 and Win10 show that such windows are not shown in pager. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1580

3 3

[PATCH v3 0/2] MR2279: riched20: Don't set para unless committing cursor move in ME_MoveCursorWords. (#54564)
by Jinoh Kang (＠iamahuman) 28 Feb '23

28 Feb '23

Introduce a temporary variable, `other_para`, so that we don't end up returning incorrect para (with stale run) inside the output cursor. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54564 -- v3: riched20: Don't set para unless committing cursor move in ME_MoveCursorWords. riched20/tests: Test for word movement across paragraph boundary. https://gitlab.winehq.org/wine/wine/-/merge_requests/2279

3 4

[PATCH v2 0/3] MR2276: riched20/tests: Fix the EM_GETSELTEXT tests in Hindi on Windows.
by Francois Gouget (＠fgouget) 28 Feb '23

28 Feb '23

-- v2: riched20/tests: Fix the EM_GETSELTEXT tests in Hindi on Windows. riched20/tests: EM_GETSELTEXT's wparam is not used and should be 0. riched32/tests: EM_GETSELTEXT's wparam is not used and should be 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2276

3 5

[PATCH 0/1] MR2300: Turkish translation update
by Serkan ÖNDER (＠serkan-maker) 28 Feb '23

28 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2300

2 1

[PATCH 0/1] MR2290: shell32: Add support for Program Manager icons with arguments.
by Alex Henrie (＠alexhenrie) 28 Feb '23

28 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52506 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2290

3 2

[PATCH v4 0/19] MR2291: win32u: replace calling unix functions by unix_call and remove callback unix_funcs
by Fan WenJie (＠fanwenjie) 28 Feb '23

28 Feb '23

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> calling unix funcions from PE must via unix_call, Because must switch fs register vaule and other context on wow64 mode. Currently calling some unix functions of win32u via function pointers. The patch modify the way of calling unix functions of win32u by unix_call -- v4: win32u: replace calling unix functions by unix_call and remove callback unix_funcs win32u: Use syscall interface for remaining functions. win32u: Use syscall interface for user functions. win32u: Use syscall interface for more GDI functions. win32u: Use syscall interface for more clipping functions. win32u: Use syscall interface for more font functions. win32u: Use syscall interface for more font functions. win32u: Use syscall interface for more GDI object functions. win32u: Use syscall interface for more DC functions. win32u: Use syscall interface for DIB functions. win32u: Use syscall interface for D3DKMT functions. win32u: Use syscall interface for more bitmap functions. win32u: Use syscall interface for bitblt functions. win32u: Use syscall interface for more path functions. win32u: Use syscall interface for more printer functions. win32u: Use syscall interface for more painting functions. win32u: Use syscall interface for more painting functions. win32u: Use syscall interface for NtGdiOpenDCW. gdi HACK: Disable printer drivers. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/2291

1 1

[PATCH v2 0/2] MR2245: dxgi: Implement IDXGIFactory2::CreateSwapChainForComposition().
by Zhiyi Zhang (＠zhiyi) 28 Feb '23

28 Feb '23

-- v2: dxgi: Implement IDXGIFactory2::CreateSwapChainForComposition(). dxgi/tests: Add composition swapchain tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2245

4 8

[PATCH 0/5] MR2298: winewinrt: Introduce new WinRT common module.
by Rémi Bernon (＠rbernon) 27 Feb '23

27 Feb '23

The idea I have is to use this module to declare class stubs until there is a good reason to split them to dedicated modules. WinRT modules aren't usually loaded directly, and instead the registry is queried to figure which module to load for which class. This would help avoiding unnecessary proliferation of stub WinRT modules, while at the same time allowing to factor WinRT foundation code (such as vector / async, etc...) between the modules that seem to deserve to be implemented separately. The relevant classes could then be split out to dedicated modules on a as-needed basis, when they get fleshed out. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2298

5 10

Re: [PATCH v3 0/1] MR2133: ntdll/tests: Minimize the stack size for test_tp_multi_wait(). - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2133

1 0

Re: [PATCH v4 0/6] MR2269: uiautomationcore: Test fixes and more COM helper methods. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2269

1 0

Re: [PATCH v2 0/1] MR2294: mscoree/tests: Trace the GetExitCodeProcess() error before it gets lost. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2294

1 0

Re: [PATCH v13 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

1 0

Re: [PATCH v2 0/3] MR2293: gdi32/tests: Fix the SetDeviceGammaRamp() tests on Windows 10 1909. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2293

1 0

Re: [PATCH v2 0/6] MR2285: Enhancements to dbghelp/tests. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2285

1 0

Re: [PATCH v3 0/2] MR2268: oleaut32: Allocate a full pointer when unmarshalling byref arrays. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2268

1 0

Re: [PATCH v4 0/1] MR2288: kernel32:locale: Fix the French GetNumberFormatEx() test on Windows 11. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2288

1 0

Re: [PATCH v2 0/1] MR2289: kernel32/tests: Fix the NtGetNlsSectionPtr() test on Windows 11. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2289

1 0

Re: [PATCH v2 0/1] MR2287: kernel32/tests: Fix the NLSVersion test on Windows 10 22H2. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2287

1 0

Re: [PATCH v2 0/1] MR2286: shell32: Add Shell_GetCachedImageIndexA/W exports. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2286

1 0

Re: [PATCH v2 0/1] MR2284: bcrypt: Remove unused fields from struct key_asymmetric32. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2284

1 0

Re: [PATCH v3 0/2] MR2270: kernelbase, kernel32: Fix WaitForThreadpoolIoCallbacks spec entries - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2270

1 0

Re: [PATCH v2 0/1] MR107: vkd3d-shader/hlsl: Don't map src swizzles for SM1 dp3 and dp4 ops. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/107

1 0

Re: [PATCH v3 0/1] MR108: vkd3d-shader: Do not pass client-given strings as printf()-style format strings. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/108

1 0

[PATCH v7 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 27 Feb '23

27 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v7: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

3 5

Re: [PATCH v2 0/1] MR2295: msado15: Free recordset filter on close. - approved
by Alistair Leslie-Hughes (＠alesliehughes) 27 Feb '23

27 Feb '23

This merge request was approved by Alistair Leslie-Hughes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2295

1 0

[PATCH v3 0/6] MR2269: uiautomationcore: Test fixes and more COM helper methods.
by Connor McAdams (＠cmcadams) 27 Feb '23

27 Feb '23

-- v3: uiautomationcore: Implement IUIAutomation::CheckNotSupported. uiautomationcore: Implement IUIAutomation reserved value retrieval methods. uiautomationcore: Implement IUIAutomation::IntNativeArrayToSafeArray. https://gitlab.winehq.org/wine/wine/-/merge_requests/2269

3 9

[PATCH 0/1] MR2294: mscoree/tests: Trace the GetExitCodeProcess() error before it gets lost.
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2294

3 2

[PATCH 0/1] MR107: vkd3d-shader/hlsl: Don't map src swizzles for SM1 dp3 and dp4 ops.
by Francisco Casas (＠fcasas) 27 Feb '23

27 Feb '23

Without this patch, dp3 and dp4 map src swizzles to the dst writemask, which is not correct. Before b84f560bdf59c35e093e51bfdf9a166c196d3a9b, these ops worked despite this, because the dst register had, incorrectly, the full writemask. To solve this problem, `write_sm1_binary_op_dot()` is introduced, similarly to `write_sm4_binary_op_dot()`. This was pointed out by @nsivov in https://bugs.winehq.org/show_bug.cgi?id=54522. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/107

5 6

[PATCH v3 0/1] MR2297: winex11: Assume that Xkb extension is available.
by Rémi Bernon (＠rbernon) 27 Feb '23

27 Feb '23

The extension is now part of Xlib. It might be disabled through the `XKB_DISABLE=1` environment variable (https://gitlab.freedesktop.org/xorg/lib/libx11/-/blob/master/src/xkb/XKBUse…) but I don't see why we have to support that case. I think assuming that it is always usable will make the keyboard code simpler, though I have no idea if it exists some environment without it nowadays. All recent desktop environment rely on Xkb to support keyboard layouts, especially when multiple layouts are configured (which are grouped four by four in a single X keyboard mapping, using Xkb groups). -- v3: winex11: Assume that Xkb extension is available. https://gitlab.winehq.org/wine/wine/-/merge_requests/2297

2 2

[PATCH 0/10] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) 27 Feb '23

27 Feb '23

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

7 21

[PATCH v2 0/1] MR110: vkd3d-shader: Make documentation for "messages" parameters self contained.
by Giovanni Mascellani (＠giomasce) 27 Feb '23

27 Feb '23

Otherwise it's not clear which clauses in vkd3d_shader_compile() really apply to other functions. For example, many of the functions currently refering to vkd3d_shader_compile() don't even take a vkd3d_shader_compile_info parameter. -- v2: vkd3d-shader: Make documentation for "messages" parameters self contained. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/110

2 1

[PATCH v3 0/4] MR94: Fix other synchronization problems
by Giovanni Mascellani (＠giomasce) 27 Feb '23

27 Feb '23

-- v3: vkd3d: Delete a misleading comment. vkd3d: Mention the correct mutex in a comment. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/94

4 11

[PATCH 0/1] MR2297: winex11: Assume that Xkb extension is available.
by Rémi Bernon (＠rbernon) 27 Feb '23

27 Feb '23

The extension is now part of Xlib. It might be disabled through the `XKB_DISABLE=1` environment variable (https://gitlab.freedesktop.org/xorg/lib/libx11/-/blob/master/src/xkb/XKBUse…) but I don't see why we have to support that case. I think assuming that it is always usable will make the keyboard code simpler, though I have no idea if it exists some environment without it nowadays. All recent desktop environment rely on Xkb to support keyboard layouts, especially when multiple layouts are configured (which are grouped four by four in a single X keyboard mapping, using Xkb groups). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2297

3 2

[PATCH v2 0/1] MR108: vkd3d: Do not pass client-given strings as printf()-style format strings.
by Giovanni Mascellani (＠giomasce) 27 Feb '23

27 Feb '23

-- v2: vkd3d-shader: Do not pass client-given strings as printf()-style format strings. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/108

3 2

[PATCH v2 0/6] MR102: hlsl: Matrix majority, 2023 edition, part 2/2.
by Zebediah Figura (＠zfigura) 27 Feb '23

27 Feb '23

-- v2: vkd3d-shader/hlsl: Get rid of the check_invalid_matrix_modifiers() helper. vkd3d-shader/hlsl: Apply latent majority modifiers to typedefs as well. vkd3d-shader/hlsl: Do not set an initial latent matrix majority. vkd3d-shader/hlsl: Store the matrix majority as a type modifiers bitmask. vkd3d-shader/hlsl: Apply latent type modifiers to matrix array typedefs. tests: Add more tests for pack_matrix pragmas. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/102

4 10

[PATCH 0/1] MR110: vkd3d-shader: Make documentation for "messages" parameters self contained.
by Giovanni Mascellani (＠giomasce) 27 Feb '23

27 Feb '23

Otherwise it's not clear which clauses in vkd3d_shader_compile() really apply to other functions. For example, many of the functions currently refering to vkd3d_shader_compile() don't even take a vkd3d_shader_compile_info parameter. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/110

4 3

[PATCH v2 0/1] MR2297: winex11: Assume that Xkb extension is available.
by Rémi Bernon (＠rbernon) 27 Feb '23

27 Feb '23

The extension is now part of Xlib. It might be disabled through the `XKB_DISABLE=1` environment variable (https://gitlab.freedesktop.org/xorg/lib/libx11/-/blob/master/src/xkb/XKBUse…) but I don't see why we have to support that case. I think assuming that it is always usable will make the keyboard code simpler, though I have no idea if it exists some environment without it nowadays. All recent desktop environment rely on Xkb to support keyboard layouts, especially when multiple layouts are configured (which are grouped four by four in a single X keyboard mapping, using Xkb groups). -- v2: winex11: Assume that Xkb extension is availabe. https://gitlab.winehq.org/wine/wine/-/merge_requests/2297

2 1

[PATCH v12 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 27 Feb '23

27 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v12: winspool: Check dmSize in IsValidDevmodeW() https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

2 1

[PATCH 0/5] MR2296: Chianti
by Giovanni Mascellani (＠giomasce) 27 Feb '23

27 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2296

2 5

[PATCH 0/1] MR2295: msado15: Free recordset filter on close.
by Akihiro Sagawa (＠sgwaki) 27 Feb '23

27 Feb '23

Introduced by commit 669107f6c5e54f520a846caec9649163675784a4. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2295

2 1

Re: [PATCH v3 0/1] MR2291: win32u: replace calling unix functions by unix_call and remove callback unix_funcs
by Jacek Caban (＠jacek) 27 Feb '23

27 Feb '23

The plan for those functions is to use syscall interface (not unixlib calls), see https://gitlab.winehq.org/jacek/wine/-/commits/wow/. We can't merge it yet because printer driver needs refactoring first (with current code, wineps.drv is a PE file that exposes GDI driver, so we still do some unixlib->PE calls in win32u). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2291#note_25557

1 0

[PATCH 0/3] MR2293: gdi32/tests: Fix the SetDeviceGammaRamp() tests on Windows 10 1909.
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2293

3 4

[PATCH v11 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 27 Feb '23

27 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v11: winspool: Check dmSize in IsValidDevmodeWw https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

4 4

2025

2024

2023

2022

wine-gitlab