- wine-gitlab - winehq.org

[PATCH v3 0/1] MR2288: kernel32:locale: Fix the French GetNumberFormatEx() test on Windows 11.
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

Windows 11 uses a narrow non-breaking space instead of a plain one when formatting numbers. This is probably more correct and maybe Wine should switch too. But marking the old result as broken() would require unbundling expect_wstr() which would be bothersome. So this commit just accepts both. -- v3: kernel32/tests: Fix the French GetNumberFormatEx() test on Windows 11. https://gitlab.winehq.org/wine/wine/-/merge_requests/2288

2 3

[PATCH v2 0/1] MR2133: Draft: ntdll/tests: Minimize the stack size for test_tp_multi_wait().
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- v2: ntdll/tests: Minimize the stack size for test_tp_multi_wait(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2133

2 2

Re: [PATCH v4 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Henri Verbeet (＠hverbeet) 27 Feb '23

27 Feb '23

There are some minor style and formatting issues in this series that I'm going to ignore for the moment. The test either doesn't test the changes in patch 2/2, or it fails before that patch. The larger issue with this series though is that it doesn't seem quite ideal to potentially set and restore the stream source frequency on each DrawPrimitive()/DrawPrimitiveUP() call, because of the resulting state invalidation. It may be time to move the d3d9-style instance count handling out of wined3d and track that entirely in d3d9. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2282#note_25548

1 0

[PATCH v3 0/2] MR2213: Draft: Debug GitLab's kernel32:heap failures in test_GlobalMemoryStatus()
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- v3: DEBUG kernel32:heap: Trace the GlobalMemoryStatus() results for the GitLab CI failures. https://gitlab.winehq.org/wine/wine/-/merge_requests/2213

3 4

[PATCH 0/1] MR2281: nsi: Simplify and better document NsiAllocateAndGetTable().
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2281

3 3

[PATCH v10 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 27 Feb '23

27 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v10: winspool: Check dmSize in IsValidDevmodeW https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

2 1

[PATCH v9 0/2] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 27 Feb '23

27 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v9: winspool: Check the alignment of dmSize in IsValidDevmodeW() winspool: Check dmSize in IsValidDevmodeW https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

4 4

[PATCH v2 0/2] MR2268: oleaut32: Allocate a full pointer when unmarshalling byref arrays.
by Rémi Bernon (＠rbernon) 27 Feb '23

27 Feb '23

Instead of the 4 bytes array wire size returned by get_type_size, which will truncate the pointer on 64-bit. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54562 -- v2: oleaut32: Allocate a full pointer when unmarshalling byref arrays. oleaut32/tests: Test VARIANT_UserUnmarshal allocation sizes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2268

3 4

[PATCH 0/1] MR2291: win32u: replace calling unix functions by unix_call and remove callback unix_funcs
by Fan WenJie (＠fanwenjie) 27 Feb '23

27 Feb '23

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> calling unix funcions from PE must via unix_call, Because must switch fs register vaule and other context on wow64 mode. Currently calling some unix functions of win32u via function pointers. The patch modify the way of calling unix functions of win32u by unix_call -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2291

2 1

Re: [PATCH v13 0/8] MR1628: ntdll: Implement Low Fragmentation Heap.
by Corey Hickey (＠bugfood) 27 Feb '23

27 Feb '23

Thank you for this. 27665f35e4da13bac1e4dd8948a65f484c9dadfa fixes a memory leak I was seeing in GTA San Andreas that had previously been introduced by 24432a24d5e922cbd824b0af8f7b0c66ff2b66e8. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1628#note_25506

1 0

[PATCH 0/1] MR2289: kernel32/tests: Fix the NtGetNlsSectionPtr() test on Windows 11.
by Francois Gouget (＠fgouget) 25 Feb '23

25 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2289

2 1

[PATCH v2 0/1] MR2288: kernel32:locale: Fix the French GetNumberFormatEx() test on Windows 11.
by Francois Gouget (＠fgouget) 25 Feb '23

25 Feb '23

Windows 11 uses a narrow non-breaking space instead of a plain one when formatting numbers. This is probably more correct and maybe Wine should switch too. But marking the old result as broken() would require unbundling expect_wstr() which would be bothersome. So this commit just accepts both. -- v2: kernel32:locale: Fix the French GetNumberFormatEx() test on Windows 11. https://gitlab.winehq.org/wine/wine/-/merge_requests/2288

2 2

[PATCH 0/1] MR2287: kernel32/tests: Fix the NLSVersion test on Windows 10 22H2.
by Francois Gouget (＠fgouget) 25 Feb '23

25 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2287

2 1

[PATCH 0/1] MR2286: shell32: Add Shell_GetCachedImageIndexA/W exports.
by Gijs Vermeulen (＠gverm) 25 Feb '23

25 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54581 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2286

2 1

[PATCH 0/6] MR2285: Enhancements to dbghelp/tests.
by eric pouech (＠epo) 25 Feb '23

25 Feb '23

This serie: - fixes a couple of tests failures on Windows 11 (Note: there are still other issues under Windows 11, mostly addressed by MR!2252) - introduce a couple of helpers to simplify current and yet to come test code - improves some existing tests -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2285

2 6

[PATCH v3 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 25 Feb '23

25 Feb '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- v3: d3d9: Disable instancing for not-indexed drawing d3d9/tests: Add test for not-indexed instancing drawing https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

3 3

[PATCH v2 0/2] MR2279: riched20: Don't set para unless committing cursor move in ME_MoveCursorWords. (#54564)
by Jinoh Kang (＠iamahuman) 25 Feb '23

25 Feb '23

Introduce a temporary variable, `other_para`, so that we don't end up returning incorrect para (with stale run) inside the output cursor. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54564 -- v2: riched20: Don't set para unless committing cursor move in ME_MoveCursorWords. riched20/tests: Test for word movement across paragraph boundary. https://gitlab.winehq.org/wine/wine/-/merge_requests/2279

2 4

[PATCH v3 0/4] MR2249: winscard: Add implementation of basic functionality.
by Konstantin Romanov (＠IncubusRK) 25 Feb '23

25 Feb '23

based on libpcsclite1 \ rework of [original code by Mounir IDRASSI](https://sourceforge.net/projects/scard4wine/) to use unixlib interface First step to resolve \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39113 \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=37495 \ It will probably also require the implementation of scarddlg. In order for the tests to work fully in a virtual environment without the appropriate hardware, I suggest using the project https://github.com/Jakuje/virt_cacard Example for setting up a build server (It is supposed to be Debian): ``` apt-get install -y pcscd vsmartcard-vpcd libpcsclite1 libpcsclite-dev libcacard-dev libsofthsm2 libnss3-tools gnutls-bin opensc service pcscd restart git clone https://github.com/Jakuje/virt_cacard cd virt_cacard ./autogen.sh && ./configure && make ./setup-softhsm2.sh ``` "Insert" smartcard before runing tests: \ `cd /path/to/virt_cacard && SOFTHSM2_CONF=softhsm2.conf ./virt_cacard &` Partial test can be done if installed vsmartcard-vpcd (only test create/release context and list aviable card readers): \ ``` apt-get install -y pcscd vsmartcard-vpcd service pcscd restart ``` -- v3: winscard: fix discards 'const' qualifier https://gitlab.winehq.org/wine/wine/-/merge_requests/2249

5 15

[PATCH 0/1] MR2284: bcrypt: Remove unused fields from struct key_asymmetric32.
by Sven Baars (＠sbaars) 25 Feb '23

25 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2284

2 1

[PATCH v6 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 25 Feb '23

25 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v6: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

2 2

[PATCH v5 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 25 Feb '23

25 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v5: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

2 1

[PATCH v4 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 25 Feb '23

25 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v4: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

2 1

[PATCH v3 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 25 Feb '23

25 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v3: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

2 2

[PATCH v2 0/2] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 25 Feb '23

25 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v2: Apply 1 suggestion(s) to 1 file(s) https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

3 2

[PATCH 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 25 Feb '23

25 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

3 4

[PATCH 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 25 Feb '23

25 Feb '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

2 3

Re: [PATCH v2 0/2] MR2280: bcrypt: Add wow64 support for PSS padding. - approved
by Alexandre Julliard (＠julliard) 24 Feb '23

24 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2280

1 0

Re: [PATCH v2 0/1] MR2278: mscoree/tests: Trace the error when a Windows API fails. - approved
by Alexandre Julliard (＠julliard) 24 Feb '23

24 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2278

1 0

Re: [PATCH v3 0/1] MR2277: winmm/tests: Ignore spurious WM_DWMCOLORIZATIONCOLORCHANGED messages. - approved
by Alexandre Julliard (＠julliard) 24 Feb '23

24 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2277

1 0

Re: [PATCH v2 0/1] MR2273: user32/tests: fixed size passed to ToUnicode - approved
by Alexandre Julliard (＠julliard) 24 Feb '23

24 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2273

1 0

Re: [PATCH v2 0/1] MR2272: winemac: Fix return type of ProcessEvents(). - approved
by Alexandre Julliard (＠julliard) 24 Feb '23

24 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2272

1 0

Re: [PATCH v2 0/1] MR2253: gdi32/tests: add some last error checks - approved
by Alexandre Julliard (＠julliard) 24 Feb '23

24 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2253

1 0

Re: [PATCH v7 0/1] MR2263: evr: Fix crash when clear input type for the mixer - approved
by Alexandre Julliard (＠julliard) 24 Feb '23

24 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

1 0

Re: [PATCH v2 0/1] MR2271: include: Add DBCOLUMNFLAGS_ enums values - approved
by Alexandre Julliard (＠julliard) 24 Feb '23

24 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2271

1 0

Re: [PATCH v2 0/1] MR2265: include: Allow overriding LANGID in module VERSIONINFO. - approved
by Alexandre Julliard (＠julliard) 24 Feb '23

24 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2265

1 0

[PATCH 0/2] MR2280: bcrypt: Add wow64 support for PSS padding.
by Sven Baars (＠sbaars) 24 Feb '23

24 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2280

3 3

[PATCH v2 0/6] MR2269: uiautomationcore: Test fixes and more COM helper methods.
by Connor McAdams (＠cmcadams) 24 Feb '23

24 Feb '23

-- v2: uiautomationcore: Implement IUIAutomation::CheckNotSupported. uiautomationcore: Implement IUIAutomation reserved value retrieval methods. uiautomationcore: Implement IUIAutomation::IntNativeArrayToSafeArray. uiautomationcore: Implement IUIAutomation::IntSafeArrayToNativeArray. https://gitlab.winehq.org/wine/wine/-/merge_requests/2269

3 9

[PATCH 0/1] MR2278: mscoree/tests: Trace the error when a Windows API fails.
by Francois Gouget (＠fgouget) 24 Feb '23

24 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2278

3 2

[PATCH 0/6] MR2269: uiautomationcore: Test fixes and more COM helper methods.
by Connor McAdams (＠cmcadams) 24 Feb '23

24 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2269

3 7

[PATCH 0/1] MR2279: riched20: Don't set para unless committing cursor move in ME_MoveCursorWords. (#54564)
by Jinoh Kang (＠iamahuman) 24 Feb '23

24 Feb '23

Introduce a temporary variable, `other_para`, so that we don't end up returning incorrect para (with stale run) inside the output cursor. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54564 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2279

2 1

[PATCH v5 0/8] MR2098: mshtml: Implement synchronous XMLHttpRequests.
by Gabriel Ivăncescu (＠insn) 24 Feb '23

24 Feb '23

wine-gecko does actually support synchronous XMLHttpRequests, even if they are deprecated, but unfortunately it is very broken compared to IE or all the other major browsers (more details [here](https://bugzilla.mozilla.org/show_bug.cgi?id=697151)). Thankfully, it still provides us with the event message loop, which is enough to fix it on mshtml side and act like IE. For sync XHRs, send() is supposed to block all script code, except for notifications sent to the sync XHR. This is because when send() blocks, no other piece of code in the script should execute other than the sync XHR handlers. Unfortunately, that's not the case in Gecko's broken implementation, which can execute handlers as if they were APCs while it's "blocked" in send(). Note that it doesn't actually block, though, because we still process the message loop (non-event related tasks such as navigation, paints, and other stuff), and that's normal. Gecko doesn't block everything related to script events, only some things on the document and timers, but that's far from enough and not even enough for our purposes since we use our own timer tasks. And not even message events are blocked, even though we *also* use our own message event dispatchers (but it doesn't block Gecko ones either). So what we have to do is we need to track all the timers and events dispatched that result in script handlers being executed, while "blocking" inside of a sync XHR send(), and queue them up to defer them to be dispatched later, after send() unblocks. But this is easier said that done. There are many corner cases to consider here, for example: * Events dispatched *synchronously* from within a sync XHR handler or other piece of code called from it. * Nested sync XHR send() calls (called during handler of another sync XHR). * Async XHRs having their events dispatched during a blocking sync XHR send() are complicated. `readyStateChange` for example needs to have the async XHR's readyState at the time it was sent, **not** at the time it was actually dispatched, since we're going to delay it and dispatch it later. It's similar with other XHR states, such as responseText (which can be partial). * Aborts of async XHRs during such handlers. These patches hopefully should address all the issues and, on a high level, work like this: * Track the `readyState` and `responseText` length manually, so we can override / force them to specific values. * "Snapshot" the async XHR at the time we encounter an event for it, and queue this event with such information. When later dispatching this event (after being deferred), we temporarily set the state of the async XHR to the snapshot. * To deal with nested event dispatches, keep track of a "dispatch depth" (everytime we dispatch an event we increase the depth, and when it returns we decrease it). * For sync XHRs, we note the depth when send() is called, and defer events at that depth, since they're dispatched during the "blocked" message loop and need to be delayed (except for sync XHR events, which is a special case since it must be dispatched synchronously). When it returns, we restore the previous blocking depth. -- v5: mshtml: Send all readystatechange events for synchronous XHRs in IE9 mshtml: Implement synchronous XMLHttpRequest. mshtml: Add separate task list for tasks dispatching events. mshtml: Track readyState in XHRs and report it manually. mshtml: Register all event handlers when creating the XMLHttpRequest. mshtml: Pass optional args to XMLHttpRequest.open() correctly. mshtml: Free the task after the destructor. mshtml: Use proper types for readystate_locked and readystate_pending. https://gitlab.winehq.org/wine/wine/-/merge_requests/2098

4 13

[PATCH 0/1] MR2273: user32/tests: fixed size passed to ToUnicode
by Marcus Meissner (＠msmeissn) 24 Feb '23

24 Feb '23

Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2273

3 2

[PATCH v2 0/1] MR2277: winmm/tests: Ignore spurious WM_DWMCOLORIZATIONCOLORCHANGED messages.
by Francois Gouget (＠fgouget) 24 Feb '23

24 Feb '23

-- v2: winmm/tests: Ignore spurious WM_DWMCOLORIZATIONCOLORCHANGED messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/2277

3 3

[PATCH v2 0/2] MR94: Fix other synchronization problems
by Giovanni Mascellani (＠giomasce) 24 Feb '23

24 Feb '23

-- v2: vkd3d: Do not keep the CS queue locked while processing it. vkd3d: Always enqueue CS operations, even if they can be executed right away. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/94

2 2

[PATCH 0/2] MR2276: riched20/tests: Fix the EM_GETSELTEXT tests in Hindi on Windows.
by Francois Gouget (＠fgouget) 24 Feb '23

24 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2276

2 2

[PATCH 0/3] MR94: Fix other synchronization problems
by Giovanni Mascellani (＠giomasce) 24 Feb '23

24 Feb '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/94

3 8

[PATCH v7 0/2] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 24 Feb '23

24 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v7: winspool: Check the alignment of dmSize in IsValidDevmodeW() https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

3 2

[PATCH v6 0/2] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 24 Feb '23

24 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v6: winspool: Check the alignment of dmSize in IsValidDevmodeW() https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

3 2

[PATCH v5 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 24 Feb '23

24 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v5: winspool: Check dmSize in IsValidDevmodeW https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

4 4

[PATCH 0/1] MR109: vkd3d-shader/hlsl: Improve handling of builtin alias type "matrix".
by Nikolay Sivov (＠nsivov) 24 Feb '23

24 Feb '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/109

2 1

[PATCH 0/1] MR2268: oleaut32: Allocate a full pointer when unmarshalling byref arrays.
by Rémi Bernon (＠rbernon) 24 Feb '23

24 Feb '23

Instead of the 4 bytes array wire size returned by get_type_size, which will truncate the pointer on 64-bit. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54562 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2268

3 2

[PATCH 0/1] MR2253: gdi32/tests: add some last error checks
by Ivan Chikish (＠nekotekina) 24 Feb '23

24 Feb '23

Related bug report: #54405 The game engine (FVP) does compare GetGlyphOutlineA result with zero and checks GetLastError in that case. Maybe I'm missing something but I believe the last error shouldn't be set for "empty" characters. I don't know why it was omitted in tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2253

3 2

[PATCH 0/5] MR2038: server: Track cursor handle and window changes.
by Rémi Bernon (＠rbernon) 24 Feb '23

24 Feb '23

The idea here is to track the cursor changes on the server side, ultimately [1] using a private message to notify user drivers of changes to apply, instead of tracking the changes in user drivers with throttle mechanisms. This would greatly simplify winex11 mouse message handling as we would not need to try syncing the window cursor on every mouse move, and ultimately it would also make it possible to have a single thread listening to input in the background. Currently the input thread needs to own the windows that are under the cursor to be able to set it. Having a single input thread (per-process at least, but ideally and ultimately per-prefix), will solve several issues with input not being received when the foreground thread isn't actively checking their message, as well as issues with DInput incorrectly checking window messages when it should not. [1] See https://gitlab.winehq.org/rbernon/wine/-/merge_requests/8/commits -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2038

3 9

[PATCH 0/1] MR1240: gitlab: Run related tests on every commit.
by Rémi Bernon (＠rbernon) 24 Feb '23

24 Feb '23

This restores the feature we had with the testbot running related on intermediate commits, though it only does it on Linux and it would be nice to have it on Windows too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1240

2 2

[PATCH 0/5] MR2062: winex11: Expose supported and configured keyboard layout in winecfg.
by Rémi Bernon (＠rbernon) 24 Feb '23

24 Feb '23

This adds a new Input tab to winecfg, moving the mouse grab settings there. Then this makes winex11 keyboard layout detection configurable as well, allowing the user to override the keyboard layout detection if for some reason it was incorrect. This isn't solving anything yet, but I then intend to make keyboard scancode detection configurable as well, and optional. As I described in https://www.winehq.org/pipermail/wine-devel/2020-October/175641.html, I believe that X11 keyboard keycode to scancode mapping is most of the time a fixed mapping, except in some rare cases. Trying to detect it from the keyboard layout will never work reliably, especially nowadays where keyboard layouts are completely made up from Linux IME (for instance a GNOME language settings with up to four keyboard layouts translates to a single Xkb mapping using groups for each layout). The X11 keycode are remapped only in some more rarely used implementations, such as XVNC and we should try to detect it only in such cases. Many Windows applications are depending on accurate scancodes, and making the mapping detection optional (and disabled by default) will solve all the issues we have in the most common case (https://bugs.winehq.org/show_bug.cgi?id=30984, https://bugs.winehq.org/show_bug.cgi?id=45605). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2062

2 7

[PATCH v4 0/4] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) 24 Feb '23

24 Feb '23

-- v4: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

3 5

[PATCH v6 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) 24 Feb '23

24 Feb '23

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- v6: evr: Fix crash when clear input type for the mixer https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

3 3

[PATCH 0/1] MR2272: winemac: Fix return type of ProcessEvents().
by Huw Davies (＠huw) 24 Feb '23

24 Feb '23

Introduced by commit a97fd9f29e7dbeee2dc06415a34a9f7669ea2e0d -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2272

2 1

[PATCH 0/1] MR2271: include: Add DBCOLUMNFLAGS_ enums values
by Alistair Leslie-Hughes (＠alesliehughes) 24 Feb '23

24 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2271

2 1

[PATCH v4 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 24 Feb '23

24 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v4: winspool: Check dmSize in IsValidDevmodeW https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

2 1

[PATCH v5 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) 24 Feb '23

24 Feb '23

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- v5: evr: Fix crash when clear input type for the mixer https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

2 1

[PATCH v7 0/2] MR76: vkd3d-shader/hlsl: Support rsqrt() and distance() intrinsics.
by Nikolay Sivov (＠nsivov) 23 Feb '23

23 Feb '23

-- v7: vkd3d-shader/hlsl: Support distance() intrinsic. vkd3d-shader/hlsl: Support rsqrt() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/76

3 4

Re: [PATCH v6 0/2] MR2114: kernelbase: Fix performance of beatmap search in osu! Stable. - approved
by Alexandre Julliard (＠julliard) 23 Feb '23

23 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2114

1 0

Re: [PATCH v10 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics::IsSupportedAsync(). - approved
by Alexandre Julliard (＠julliard) 23 Feb '23

23 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

1 0

Re: [PATCH v3 0/4] MR2267: msvcr80: Fix _(w)dupenv_s behavior with missing environment variable. - approved
by Alexandre Julliard (＠julliard) 23 Feb '23

23 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2267

1 0

Re: [PATCH v2 0/1] MR2264: ntdll: Avoid shrinking large heap block to small block. - approved
by Alexandre Julliard (＠julliard) 23 Feb '23

23 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2264

1 0

Re: [PATCH v5 0/5] MR2010: wined3d: More Vulkan feature checks. - approved
by Alexandre Julliard (＠julliard) 23 Feb '23

23 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2010

1 0

[PATCH v4 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- v4: evr: Fix crash when clear input type for the mixer https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

3 2

Re: [PATCH v4 0/11] MR103: DXBC handling API - approved
by Alexandre Julliard (＠julliard) 23 Feb '23

23 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/103

1 0

Re: [PATCH v3 0/1] MR105: vkd3d: Remove a double space in a comment. - approved
by Alexandre Julliard (＠julliard) 23 Feb '23

23 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/105

1 0

Re: [PATCH v7 0/3] MR101: vkd3d-shader/hlsl: Improvements to builtin typenames handling. - approved
by Alexandre Julliard (＠julliard) 23 Feb '23

23 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/101

1 0

Re: [PATCH v13 0/6] MR1445: kernelbase: Some refactoring of the open_key() and create_key() functions.
by Alexandre Julliard (＠julliard) 23 Feb '23

23 Feb '23

Alexandre Julliard (@julliard) commented about dlls/kernelbase/registry.c: > > static BOOL is_wow6432node( const UNICODE_STRING *name ) > { > - return (name->Length == 11 * sizeof(WCHAR) && !wcsnicmp( name->Buffer, L"Wow6432Node", 11 )); > + return (name->Length >= 11 * sizeof(WCHAR) && !wcsnicmp( name->Buffer, L"Wow6432Node", 11 )); This doesn't look right, we need an exact match. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1445#note_25333

1 0

[PATCH v6 0/2] MR76: vkd3d-shader/hlsl: Support rsqrt() and distance() intrinsics.
by Nikolay Sivov (＠nsivov) 23 Feb '23

23 Feb '23

-- v6: vkd3d-shader/hlsl: Support distance() intrinsic. vkd3d-shader/hlsl: Support rsqrt() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/76

5 10

[PATCH v3 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v3: winspool: Check dmSize in IsValidDevmodeW https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

2 1

[PATCH v2 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v2: winspool: Check dmSize in IsValidDevmodeW https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

3 4

[PATCH 0/2] MR2270: kernelbase, kernel32: Fix WaitForThreadpoolIoCallbacks spec entries
by Torge Matthies (＠tmatthies) 23 Feb '23

23 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2270

2 2

[PATCH v3 0/11] MR103: DXBC handling API
by Henri Verbeet (＠hverbeet) 23 Feb '23

23 Feb '23

Public API for parsing and serialising DXBC blobs. -- v3: vkd3d-shader/dxbc: Introduce API for serialising DXBC blobs. vkd3d-shader/dxbc: Introduce API for parsing DXBC blobs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/103

3 14

[PATCH v3 0/4] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) 23 Feb '23

23 Feb '23

-- v3: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. winegstreamer: Better handle framerate. winegstreamer: Add format field to wmv wg_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

3 7

[PATCH 0/1] MR108: vkd3d: Do not pass client-given strings as printf()-style format strings.
by Giovanni Mascellani (＠giomasce) 23 Feb '23

23 Feb '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/108

2 1

[PATCH v4 0/4] MR89: vkd3d-shader/hlsl: Improve support for logarithmic functions.
by Nikolay Sivov (＠nsivov) 23 Feb '23

23 Feb '23

-- v4: vkd3d-shader/hlsl: Support log() intrinsic. vkd3d-shader/hlsl: Support log10() intrinsic. vkd3d-shader/hlsl: Support log2() intrinsic. vkd3d-shader/hlsl: Write 'log' instruction for SM1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/89

3 7

[PATCH v2 0/1] MR105: vkd3d: Remove a double space in a comment.
by Zebediah Figura (＠zfigura) 23 Feb '23

23 Feb '23

-- v2: vkd3d: Remove a double space in a trace message. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/105

4 3

Re: [PATCH v6 0/3] MR101: vkd3d-shader/hlsl: Improvements to builtin typenames handling. - approved
by Henri Verbeet (＠hverbeet) 23 Feb '23

23 Feb '23

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/101

1 0

[PATCH v2 0/1] MR2067: wine32u: fix off-by-one bugs in MsgWaitForMultipleObjectsEx drivers
by Ivan Chikish (＠nekotekina) 23 Feb '23

23 Feb '23

When count = 0, returned value may become -1 which seems wrong in the case of successful process_events() call. Also MSDN suggests that `count` may be a valid return value in this case. When -1 is returned, it may cause SetLastError to -1 as well which is not a valid error code AFAIK. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54405 -- v2: wine32u: move count fixup out of MsgWaitForMultipleObjectsEx drivers https://gitlab.winehq.org/wine/wine/-/merge_requests/2067

4 5

[PATCH v2 0/4] MR2267: msvcr80: Fix _(w)dupenv_s behavior with missing environment variable.
by Rémi Bernon (＠rbernon) 23 Feb '23

23 Feb '23

-- v2: msvcrt: Fix _wdupenv_s behavior with missing env var. msvcrt: Fix _dupenv_s behavior with missing env var. msvcr80/tests: Test _wdupenv_s outcome with missing env var. msvcr80/tests: Test _dupenv_s outcome with missing env var. https://gitlab.winehq.org/wine/wine/-/merge_requests/2267

3 6

Re: [PATCH v6 0/3] MR101: vkd3d-shader/hlsl: Improvements to builtin typenames handling. - approved
by Giovanni Mascellani (＠giomasce) 23 Feb '23

23 Feb '23

This merge request was approved by Giovanni Mascellani. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/101

1 0

[PATCH v3 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- v3: evr: Fix crash when clear input type for the mixer https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

3 4

[PATCH v2 0/11] MR103: DXBC handling API
by Henri Verbeet (＠hverbeet) 23 Feb '23

23 Feb '23

Public API for parsing and serialising DXBC blobs. -- v2: vkd3d-shader/dxbc: Introduce API for serialising DXBC blobs. vkd3d-shader/dxbc: Introduce API for parsing DXBC blobs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/103

4 26

[PATCH 0/4] MR2267: msvcr80: Fix _(w)dupenv_s behavior with missing environment variable.
by Rémi Bernon (＠rbernon) 23 Feb '23

23 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2267

2 4

[PATCH v2 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- v2: evr: Fix crash when clear input type for the mixer https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

3 3

[PATCH v2 0/5] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) 23 Feb '23

23 Feb '23

-- v2: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. winegstreamer: Better handle framerate. winegstreamer: Add format field to wmv wg_format. winegstreamer: Implement wg_transform data read/write for DMO. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

3 9

[PATCH 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

3 2

[PATCH 0/1] MR2265: include: Allow overriding LANGID in module VERSIONINFO.
by Rémi Bernon (＠rbernon) 23 Feb '23

23 Feb '23

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/2221, this is required by `ImmInstallIME` and .ime modules. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2265

2 1

[PATCH 0/1] MR2264: ntdll: Avoid shrinking large heap block to small block.
by Rémi Bernon (＠rbernon) 23 Feb '23

23 Feb '23

Even though this is a waste of memory it seems to trip on some UAF with some games. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54475 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2264

2 1

[PATCH v4 0/5] MR2010: wined3d: More Vulkan feature checks.
by Zebediah Figura (＠zfigura) 23 Feb '23

23 Feb '23

-- v4: wined3d: Disable 64-bit integer support. wined3d: Require shader cull distance support to create a feature level 10.0 device. wined3d: Require shader clip distance support to create a feature level 10.0 device. wined3d: Require gather offset support to create a feature level 11.0 device. wined3d: Require fragment shader image stores and atomics to create a feature level 11.0 device. https://gitlab.winehq.org/wine/wine/-/merge_requests/2010

3 6

[PATCH 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

3 3

[PATCH v9 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics::IsSupportedAsync().
by Mohamad Al-Jaf (＠maljaf) 23 Feb '23

23 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v9: cryptowinrt/tests: Add IKeyCredentialManagerStatics::IsSupportedAsync() tests. cryptowinrt: Implement IKeyCredentialManagerStatics::IsSupportedAsync(). cryptowinrt: Import IAsyncOperation from windows.gaming.input. cryptowinrt: Stub IKeyCredentialManagerStatics interface. cryptowinrt: Add private.h file. cryptowinrt/tests: Add ICryptographicBufferStatics interface test. include: Add windows.security.credentials.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

2 8

[PATCH v12 0/4] MR84: vkd3d-shader/spirv: Merge all shader IR fork and join phases into a single phase.
by Conor McCarthy (＠cmccarthy) 23 Feb '23

23 Feb '23

Normalise the incoming vkd3d_shader_instruction IR to the shader model 6 pattern where only one patch constant function is emitted. This allows generation of a single patch constant function in SPIR-V. -- v12: vkd3d-shader/spirv: Declare the phase SPIR-V function in spirv_compiler_enter_shader_phase(). vkd3d-shader/spirv: Remove the hull shader phase array. vkd3d-shader/trace: Trace the normalised instruction array after tracing the input. vkd3d-shader/ir: Merge all shader IR fork and join phases into a single phase. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/84

2 5

[PATCH 0/1] MR2206: ntdll: Add ntdll_wcsstr function.
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2206

3 3

[PATCH 0/1] MR2204: ole32: Support HBITMAP format in DataCache_GetExtent and DataCache_Draw
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

Fix can't insert any HBITMAP in RichEdit control -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2204

3 4

[PATCH 0/4] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) 23 Feb '23

23 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

4 9

2025

2024

2023

2022

wine-gitlab