- wine-gitlab - winehq.org

[PATCH 0/1] MR3834: wpcap/tests: Accept another return value from pcap_can_set_rfmon().
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3834

3 2

[PATCH 0/2] MR7587: msvcr120: Add imaxdiv implementation.
by Piotr Caban (＠piotr) 16 Mar '25

16 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7587

2 2

[PATCH v9 0/7] MR7111: Draft: support building Wine with LTO
by Konstantin Demin (＠rockdrilla) 16 Mar '25

16 Mar '25

work is still in progress. todo: - ensure that all affected sources (i.e. C sources with any kind of assembly) are listed in either way for all architectures - test Wine built with LTO relevant bug reports: - https://bugs.winehq.org/show_bug.cgi?id=41712 - https://bugs.winehq.org/show_bug.cgi?id=51051 -- v9: LTO quirks configure: enable building Wine with LTO makedep: support skipping/disabling LTO makedep: support LTO builds winegcc: support LTO builds winebuild: support LTO builds tools: helper functions for LTO builds https://gitlab.winehq.org/wine/wine/-/merge_requests/7111

3 9

[PATCH 0/2] MR3833: iphlpapi/tests: Quadruple the buffer size in a GetAdaptersAddresses() test.
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

As shown by the testbot, doubling is not always sufficient. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3833

4 6

[PATCH 0/2] MR3822: user32/tests: Account for ignored messages during wait.
by Esme Povirk (＠madewokherd) 15 Mar '25

15 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53435 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3822

3 4

[PATCH 0/1] MR3818: Draft: urlmon: test http with auto redirect disabled, and CreateBinding
by Yuxuan Shui (＠yshui) 15 Mar '25

15 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3818

4 9

[PATCH 0/1] MR3817: ntdll/test: Updated link test to reflect Windows 11 behaviour.
by Joel Holdsworth (＠jhol) 15 Mar '25

15 Mar '25

Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3817

3 2

[PATCH 0/1] MR3801: user32/tests: Detect win7's broken GetQueueStatus behavior.
by Esme Povirk (＠madewokherd) 15 Mar '25

15 Mar '25

Unlike most of these user32:msg failures, this one is consistent. No bug report for this specifically but https://bugs.winehq.org/show_bug.cgi?id=53434 comments 3 and 4 has related info. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3801

3 2

[PATCH v2 0/1] MR3783: user32/tests: Register test_hvredraw class in temp desktop.
by Esme Povirk (＠madewokherd) 15 Mar '25

15 Mar '25

Windows v1709 has a bug that breaks GetClassLong on a different desktop from where the class was registered. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55539 -- v2: user32/tests: Register test_hvredraw class in temp desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3783

3 3

[PATCH 0/2] MR3788: iphlpapi/tests: Call GetAdaptersAddresses() in a loop.
by Hans Leidekker (＠hans) 15 Mar '25

15 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54588 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3788

4 4

[PATCH v5 0/2] MR7579: ntdll: Return STATUS_ACCESS_VIOLATION if ret_len is not writable
by Dylan Donnell (＠dy-tea) 15 Mar '25

15 Mar '25

Required for implementation correctness check in certain protection software. Thanks to mkrsym1 <mkrsym1(a)gmail.com> for the patch! -- v5: ntdll/tests: Add tests for ret_len on NtQueryInformationThread HideFromDebugger. https://gitlab.winehq.org/wine/wine/-/merge_requests/7579

3 4

[PATCH 0/3] MR7583: ntdll: Stop using chdir() in nt_to_unix_file_name().
by Brendan Shanks (＠bshanks) 14 Mar '25

14 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7583

3 4

Re: [PATCH v2 0/1] MR7574: advapi32: Avoid buffer underrun in split_domain_account (ASan). - approved
by Alexandre Julliard (＠julliard) 14 Mar '25

14 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7574

1 0

Re: [PATCH v2 0/4] MR7564: ntdll: Fix first trap instruction when setting eflags with SetThreadContext or returning from syscall. - approved
by Alexandre Julliard (＠julliard) 14 Mar '25

14 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7564

1 0

Re: [PATCH v2 0/5] MR7573: PDB rewrite #1 - approved
by Alexandre Julliard (＠julliard) 14 Mar '25

14 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7573

1 0

Re: [PATCH v10 0/7] MR7472: winebth.sys part 6: Add support for device inquiry/scanning. - approved
by Alexandre Julliard (＠julliard) 14 Mar '25

14 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7472

1 0

Re: [PATCH v3 0/1] MR7581: user32, win32u: Implement ordinal 2705 with a stub for NtUserIsChildWindowDpiMessageEnabled. - approved
by Alexandre Julliard (＠julliard) 14 Mar '25

14 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7581

1 0

Re: [PATCH v2 0/6] MR7580: advapi32: Move some functions to cryptsp and cryptbase. - approved
by Alexandre Julliard (＠julliard) 14 Mar '25

14 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7580

1 0

Re: [PATCH v2 0/1] MR7578: kernelbase: Add stub for GetCurrentApplicationUserModelId. - approved
by Alexandre Julliard (＠julliard) 14 Mar '25

14 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7578

1 0

Re: [PATCH v2 0/1] MR7572: imm32: Add a stub for CtfImmHideToolbarWnd. - approved
by Alexandre Julliard (＠julliard) 14 Mar '25

14 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7572

1 0

[PATCH v4 0/2] MR7579: ntdll: Return STATUS_ACCESS_VIOLATION if ret_len is not writable
by Dylan Donnell (＠dy-tea) 14 Mar '25

14 Mar '25

Required for implementation correctness check in certain protection software. Thanks to mkrsym1 <mkrsym1(a)gmail.com> for the patch! -- v4: ntdll/tests: Add tests for ret_len on NtQueryInformationThread HideFromDebugger. ntdll: Return STATUS_ACCESS_VIOLATION from NtQueryInformationThread ThreadHideFromDebugger if *ret_len is not writable. https://gitlab.winehq.org/wine/wine/-/merge_requests/7579

2 2

Re: [PATCH v2 0/1] MR7529: msxml3: Correct looping of Document Element properties. - approved
by Alistair Leslie-Hughes (＠alesliehughes) 14 Mar '25

14 Mar '25

This merge request was approved by Alistair Leslie-Hughes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7529

1 0

Re: [PATCH v2 0/1] MR7529: msxml3: Correct looping of Document Element properties.
by Alistair Leslie-Hughes (＠alesliehughes) 14 Mar '25

14 Mar '25

Confirming that the when there is a mix of namespaces and properties the count is out. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7529#note_97855

1 0

[PATCH v3 0/2] MR7579: ntdll: Return STATUS_ACCESS_VIOLATION if ret_len is not writable
by Dylan Donnell (＠dy-tea) 14 Mar '25

14 Mar '25

Required for implementation correctness check in certain protection software. Thanks to mkrsym1 <mkrsym1(a)gmail.com> for the patch! -- v3: ntdll: Add tests for ret_len on NtQueryInformationThread HideFromDebugger ntdll: Write ret_len before checking length https://gitlab.winehq.org/wine/wine/-/merge_requests/7579

3 3

[PATCH v10 0/6] MR7569: Draft: mfplat/tests: Add tests for Byte Stream Timestamps.
by Brendan McGrath (＠redmcg) 14 Mar '25

14 Mar '25

This MR adds tests to `mfplat` to illustrate the timestamp values output on the samples for the respective Byte Stream handlers. I have also included a fix for a bug in `winegstreamer` (and copied to `mfsrcsnk`) where a `NULL` value for the `pguidTimeFormat` parameter in `IMFMediaSource::Start` causes a segmentation fault. On Windows this is allowed. It is included in this MR as the `mfplat` tests pass NULL (so without this fix, the tests crash). -- v10: mfplat/tests: Add tests for Byte Stream Timestamps. https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

2 9

[PATCH v2 0/2] MR7581: user32, win32u: Implement ordinal 2705 with a stub for NtUserIsChildWindowDpiMessageEnabled.
by Tim Clem (＠tclem) 14 Mar '25

14 Mar '25

Office 2016/365 has started calling user32.2705 and crashing since it was added in 6e5f547a3907e6fdacf2de7debf9b22abfdaa14d. -- v2: user32: Forward ordinal 2705 to NtUserIsChildWindowDpiMessageEnabled. win32u: Add a stub for NtUserIsChildWindowDpiMessageEnabled. https://gitlab.winehq.org/wine/wine/-/merge_requests/7581

3 3

[PATCH v3 0/3] MR7575: cryptbase: Add dll.
by Louis Lenders (＠xe) 14 Mar '25

14 Mar '25

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=57962 -- v3: Revert "kernelbase: Add GetCurrentApplicationUserModelId." https://gitlab.winehq.org/wine/wine/-/merge_requests/7575

3 8

[PATCH 0/2] MR7581: user32, win32u: Implement ordinal 2705 with a stub for NtUserIsChildWindowDpiMessageEnabled.
by Tim Clem (＠tclem) 14 Mar '25

14 Mar '25

Office 2016/365 has started calling user32.2705 and crashing since it was added in 6e5f547a3907e6fdacf2de7debf9b22abfdaa14d. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7581

2 2

[PATCH v2 0/2] MR7579: ntdll: Return STATUS_ACCESS_VIOLATION if ret_len is not writable
by Dylan Donnell (＠dy-tea) 14 Mar '25

14 Mar '25

Required for implementation correctness check in certain protection software. Thanks to mkrsym1 <mkrsym1(a)gmail.com> for the patch! -- v2: ntdll: Write ret_len before checking length in ThreadHideFromDebugger https://gitlab.winehq.org/wine/wine/-/merge_requests/7579

3 4

[PATCH 0/1] MR7579: ntdll: Return STATUS_ACCESS_VIOLATION if ret_len is not writable
by Dylan Donnell (＠dy-tea) 14 Mar '25

14 Mar '25

Required for implementation correctness check in certain protection software. Thanks to mkrsym1 <mkrsym1(a)gmail.com> for the patch! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7579

4 6

[PATCH v9 0/7] MR7472: winebth.sys part 6: Add support for device inquiry/scanning.
by Vibhav Pant (＠vibhavp) 14 Mar '25

14 Mar '25

-- v9: bluetoothapis/tests: Add tests for BluetoothFindNextDevice. bluetoothapis: Implement BluetoothFindNextDevice. bluetoothapis/tests: Add tests for BluetoothFindFirstDevice, BluetoothFindDeviceClose. bluetoothapis: Implement BluetoothFindFirstDevice and BluetoothFindDeviceClose. https://gitlab.winehq.org/wine/wine/-/merge_requests/7472

3 9

[PATCH v8 0/3] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu (＠insn) 14 Mar '25

14 Mar '25

-- v8: server: Handle hardlinks and casefolding when renaming the same file. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

3 11

[PATCH 0/6] MR7580: advapi32: Move some functions to cryptsp and cryptbase.
by Elizabeth Figura (＠zfigura) 14 Mar '25

14 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7580

2 6

[PATCH 0/1] MR7578: kernelbase: Add stub for GetCurrentApplicationUserModelId.
by Louis Lenders (＠xe) 14 Mar '25

14 Mar '25

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=57964 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7578

2 1

[PATCH 0/1] MR7576: windowscodecs: Remove IWICWineDecoder interface.
by Nikolay Sivov (＠nsivov) 14 Mar '25

14 Mar '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7576

2 2

[PATCH v2 0/2] MR7575: cryptbase: Add dll.
by Louis Lenders (＠xe) 14 Mar '25

14 Mar '25

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=57962 -- v2: kernelbase: Add GetCurrentApplicationUserModelId. https://gitlab.winehq.org/wine/wine/-/merge_requests/7575

4 6

[PATCH 0/1] MR7575: cryptbase: Add dll.
by Louis Lenders (＠xe) 14 Mar '25

14 Mar '25

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=57962 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7575

3 2

[PATCH 0/1] MR7574: advapi32: Avoid buffer underrun in split_domain_account (ASan).
by Bernhard Übelacker (＠bernhardu) 14 Mar '25

14 Mar '25

When `split_domain_account` receives a `str->Buffer=L""` with `str->Length=0` the pointer `p` gets already set in the initial assignment two bytes before the allocated memory in line 1209. Therefore the `if (*p == '\\')` accesses invalid memory. ``` ================================================================= ==advapi32_test.exe==1208==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7e89077e01ee at pc 0x6fffff6bb20f bp 0x7ffffe1ff3e0 sp 0x7ffffe1ff428 READ of size 2 at 0x7e89077e01ee thread T0 #0 0x6fffff6bb20e in split_domain_account .../wine/dlls/advapi32/security.c:1212:9 #1 0x6fffff6babe5 in lookup_local_wellknown_name .../wine/dlls/advapi32/security.c:1271:5 #2 0x6fffff6affe0 in lookup_name .../wine/dlls/advapi32/lsa.c:404:11 #3 0x6fffff6b0bbf in LsaLookupSids .../wine/dlls/advapi32/lsa.c:644:17 #4 0x00014002688e in test_LsaLookupSids .../wine/dlls/advapi32/tests/lsa.c:379:14 #5 0x000140024b17 in func_lsa .../wine/dlls/advapi32/tests/lsa.c:514:5 #6 0x00014009f9ee in run_test .../wine/include/wine/test.h:765:5 #7 0x00014009f531 in main .../wine/include/wine/test.h:884:12 #8 0x0001400a0ea3 in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #9 0x6fffffc3565e in BaseThreadInitThunk .../wine/dlls/kernel32/thread.c:61:24 #10 0x6fffffdbbb1a in call_seh_handlers .../wine/dlls/ntdll/signal_x86_64.c:223:28 0x7e89077e01ee is located 2 bytes before 2-byte region [0x7e89077e01f0,0x7e89077e01f2) allocated by thread T0 here: #0 0x6ffffe84aa83 in HeapAlloc /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt\lib/asan/asan_malloc_win.cpp:230:3 #1 0x6ffffe44016b in msvcrt_heap_alloc .../wine/dlls/msvcrt/heap.c:71:12 #2 0x6ffffe440739 in malloc .../wine/dlls/msvcrt/heap.c:436:15 #3 0x6fffff6b0afa in LsaLookupSids .../wine/dlls/advapi32/lsa.c:636:24 #4 0x00014002688e in test_LsaLookupSids .../wine/dlls/advapi32/tests/lsa.c:379:14 #5 0x000140024b17 in func_lsa .../wine/dlls/advapi32/tests/lsa.c:514:5 #6 0x00014009f9ee in run_test .../wine/include/wine/test.h:765:5 #7 0x00014009f531 in main .../wine/include/wine/test.h:884:12 #8 0x0001400a0ea3 in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #9 0x6fffffc3565e in BaseThreadInitThunk .../wine/dlls/kernel32/thread.c:61:24 #10 0x6fffffdbbb1a in call_seh_handlers .../wine/dlls/ntdll/signal_x86_64.c:223:28 SUMMARY: AddressSanitizer: heap-buffer-overflow .../wine/dlls/advapi32/security.c:1212:9 in split_domain_account Shadow bytes around the buggy address: 0x7e89077dff00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7e89077dff80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7e89077e0000: fa fa 00 00 fa fa 02 fa fa fa 04 fa fa fa 02 fa 0x7e89077e0080: fa fa 04 fa fa fa 02 fa fa fa 04 fa fa fa 02 fa 0x7e89077e0100: fa fa 04 fa fa fa 02 fa fa fa 04 fa fa fa 00 00 =>0x7e89077e0180: fa fa fd fd fa fa fd fd fa fa fd fd fa[fa]02 fa 0x7e89077e0200: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x7e89077e0280: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x7e89077e0300: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x7e89077e0380: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x7e89077e0400: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==advapi32_test.exe==1208==ABORTING ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7574

2 1

[PATCH 0/5] MR7573: PDB rewrite #1
by eric pouech (＠epo) 14 Mar '25

14 Mar '25

This serie is the first of a long serie for rewriting the PDB debug format support in dbnghelp. For historical reasons, builtin dbghelp always fully loads every debug information (type, symbol...) for a given module, and transforms it into an internal representation (common to all debug formats: stabs, dwarf*, PDB...). This turns out to be slow and memory hungry. For example, using a chromium based DLL, where PDB file breaks the 4G size barrier, load time of debug info is ~80s, and requires ~20GB of virtual memory. Target of rewrite: - break monolothic approach in dbghelp to allow finer granularity in what's loaded (moving to a per compilation unit approach instead of full module) - reduce memory usage (for above example, current rewrite state is 20MB of virtual memory, and <4s of load time) - (potential) degradation of performance for some requests + may need to load/peruse additional information (not loaded at once) + request code hasn't been optimized for performance (on purpose), so that we can balance performance vs in-process memory (caching some more bits) We start with some series about cleanup, fixes, optimisation in dbghelp (that will favor all debug formats, not only PDB). This serie: - fixes a crash for .DBG file - fixes >4G PDB loading (so that we can measure improvements ;-) - introduces a new approach for internal vector representation (reduces memory usage), - some cleanup, -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7573

2 5

[PATCH v9 0/3] MR7542: ws2_32: Implement WSALookupService for Bluetooth device discovery.
by Vibhav Pant (＠vibhavp) 14 Mar '25

14 Mar '25

This MR adds an initial implementation of the winsock `WSALookupsService*` methods for performing Bluetooth device discovery (`LUP_CONTAINERS`). Pending !7472, the code will also eventually support performing device inquiry scans. -- v9: ws2_32: Implement WSALookupServiceNext for Bluetooth device discovery. https://gitlab.winehq.org/wine/wine/-/merge_requests/7542

3 5

[PATCH 0/1] MR7572: imm32: Add a stub for CtfImmHideToolbarWnd.
by Tim Clem (＠tclem) 14 Mar '25

14 Mar '25

Needed by the Guild Wars 2 installer. -- The installer fetches this with GetProcAddress. It was fine when the function was missing, but now tries to call the .spec stub added in 7a92a33b. See also !5479. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7572

3 2

[PATCH v9 0/6] MR7569: Draft: mfplat/tests: Add tests for Byte Stream Timestamps.
by Brendan McGrath (＠redmcg) 14 Mar '25

14 Mar '25

This MR adds tests to `mfplat` to illustrate the timestamp values output on the samples for the respective Byte Stream handlers. I have also included a fix for a bug in `winegstreamer` (and copied to `mfsrcsnk`) where a `NULL` value for the `pguidTimeFormat` parameter in `IMFMediaSource::Start` causes a segmentation fault. On Windows this is allowed. It is included in this MR as the `mfplat` tests pass NULL (so without this fix, the tests crash). -- v9: mfplat/tests: Add tests for Byte Stream Timestamps. mfsrcsnk: Allow NULL for time_format. winegstreamer: Allow NULL for time_format. mfplat/tests: Fix leak of media source. mfplat/tests: Fix leak of media events. mfplat/tests: Fix crash in MFShutdown on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

2 6

[PATCH v8 0/7] MR7472: winebth.sys part 6: Add support for device inquiry/scanning.
by Vibhav Pant (＠vibhavp) 14 Mar '25

14 Mar '25

-- v8: bluetoothapis/tests: Add tests for BluetoothFindNextDevice. bluetoothapis: Implement BluetoothFindNextDevice. bluetoothapis/tests: Add tests for BluetoothFindFirstDevice, BluetoothFindDeviceClose. bluetoothapis: Implement BluetoothFindFirstDevice and BluetoothFindDeviceClose. https://gitlab.winehq.org/wine/wine/-/merge_requests/7472

3 16

[PATCH v8 0/5] MR7569: Draft: mfplat/tests: Add tests for Byte Stream Timestamps.
by Brendan McGrath (＠redmcg) 14 Mar '25

14 Mar '25

This MR adds tests to `mfplat` to illustrate the timestamp values output on the samples for the respective Byte Stream handlers. I have also included a fix for a bug in `winegstreamer` (and copied to `mfsrcsnk`) where a `NULL` value for the `pguidTimeFormat` parameter in `IMFMediaSource::Start` causes a segmentation fault. On Windows this is allowed. It is included in this MR as the `mfplat` tests pass NULL (so without this fix, the tests crash). -- v8: mfplat/tests: Add tests for Byte Stream Timestamps. mfsrcsnk: Allow NULL for time_format. winegstreamer: Allow NULL for time_format. mfplat/tests: Fix leak of media source. mfplat/tests: Fix leak of media events. https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

2 5

[PATCH v7 0/3] MR7569: Draft: mfplat/tests: Add tests for Byte Stream Timestamps.
by Brendan McGrath (＠redmcg) 13 Mar '25

13 Mar '25

This MR adds tests to `mfplat` to illustrate the timestamp values output on the samples for the respective Byte Stream handlers. I have also included a fix for a bug in `winegstreamer` (and copied to `mfsrcsnk`) where a `NULL` value for the `pguidTimeFormat` parameter in `IMFMediaSource::Start` causes a segmentation fault. On Windows this is allowed. It is included in this MR as the `mfplat` tests pass NULL (so without this fix, the tests crash). -- v7: mfplat/tests: Add tests for Byte Stream Timestamps. https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

3 5

Re: [PATCH v4 0/1] MR7544: ieframe: Enter reallocation path one position earlier (ASan). - approved
by Alexandre Julliard (＠julliard) 13 Mar '25

13 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7544

1 0

Re: [PATCH v3 0/4] MR7541: comctl32/tests: Run LVM_GETORIGIN tests on v6. - approved
by Alexandre Julliard (＠julliard) 13 Mar '25

13 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7541

1 0

Re: [PATCH v2 0/1] MR7568: fusion: Use wide character string literals. - approved
by Alexandre Julliard (＠julliard) 13 Mar '25

13 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7568

1 0

Re: [PATCH v3 0/1] MR7566: wintypes: Add IBufferFactory stub. - approved
by Alexandre Julliard (＠julliard) 13 Mar '25

13 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7566

1 0

Re: [PATCH v2 0/1] MR7567: include: Add robuffer.idl. - approved
by Alexandre Julliard (＠julliard) 13 Mar '25

13 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7567

1 0

Re: [PATCH v4 0/7] MR7212: Improvement to winedump for debug information files. - approved
by Alexandre Julliard (＠julliard) 13 Mar '25

13 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7212

1 0

[PATCH 0/2] MR7555: Include: Add more tchar defines
by Alistair Leslie-Hughes (＠alesliehughes) 13 Mar '25

13 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7555

3 4

[PATCH v7 0/5] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu (＠insn) 13 Mar '25

13 Mar '25

-- v7: server: Handle destination file replaced by a directory after trying server: Avoid fstat when comparing inode/device for renaming. server: Handle hardlinks and casefolding when renaming the same file. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

3 7

[PATCH 0/4] MR7512: win32u: Introduce shared memory objects for windows.
by Rémi Bernon (＠rbernon) 13 Mar '25

13 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7512

5 28

[PATCH v7 0/3] MR7542: ws2_32: Implement WSALookupService for Bluetooth device discovery.
by Vibhav Pant (＠vibhavp) 13 Mar '25

13 Mar '25

This MR adds an initial implementation of the winsock `WSALookupsService*` methods for performing Bluetooth device discovery (`LUP_CONTAINERS`). Pending !7472, the code will also eventually support performing device inquiry scans. -- v7: ws2_32: Implement WSALookupServiceNext for Bluetooth device discovery. https://gitlab.winehq.org/wine/wine/-/merge_requests/7542

2 4

[PATCH v3 0/1] MR7544: ieframe: Enter reallocation path one position earlier (ASan).
by Bernhard Übelacker (＠bernhardu) 13 Mar '25

13 Mar '25

Trying to browse through the debugger.chm from an old windbg version with hh.exe, I encountered below ASan message. The reallocation path was not entered when `This->travellog.size < This->travellog.position+1`, with e.g. size == 4 and position == 3. Unfortunately the increment of position takes place a few lines later, therefore writing at index 4 of array with size 4. ``` ================================================================= ==hh.exe==316==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7e99833c9a80 at pc 0x6ffffe8490da bp 0x7ffffe1fea70 sp 0x7ffffe1feab0 WRITE of size 16 at 0x7e99833c9a80 thread T0 #0 0x6ffffe8490d9 in __asan_memset /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt\lib/asan/asan_interceptors_memintrinsics.cpp:67:3 #1 0x6ffffa7cb968 in update_travellog /home/bernhard/data/entwicklung/2025/wine\wine/dlls/ieframe/dochost.c:471:59 #2 0x6ffffa7caf09 in ClOleCommandTarget_Exec /home/bernhard/data/entwicklung/2025/wine\wine/dlls/ieframe/dochost.c:780:13 #3 0x6ffff929b38a in IOleCommandTarget_Exec /home/bernhard/data/entwicklung/2025/wine/wine-build/llvm-newwow64-asan-pe/obj\include\docobj.h:848:12 #4 0x6ffff929ad8c in notify_travellog_update /home/bernhard/data/entwicklung/2025/wine\wine/dlls/mshtml/persist.c:71:9 #5 0x6ffff929a82b in set_current_mon /home/bernhard/data/entwicklung/2025/wine\wine/dlls/mshtml/persist.c:108:17 #6 0x6ffff923abb7 in navigate_proc /home/bernhard/data/entwicklung/2025/wine\wine/dlls/mshtml/navigate.c:2155:9 #7 0x6ffff92d43df in hidden_proc /home/bernhard/data/entwicklung/2025/wine\wine/dlls/mshtml/task.c:398:17 #8 0x6ffffd3f3c8e in WINPROC_wrapper /home/bernhard/data/entwicklung/2025/wine\wine/dlls/user32/winproc.c:86:12 #9 0x6ffffd3f28c8 in call_window_proc /home/bernhard/data/entwicklung/2025/wine\wine/dlls/user32/winproc.c:111:15 #10 0x6ffffd3f2ab2 in dispatch_win_proc_params /home/bernhard/data/entwicklung/2025/wine\wine/dlls/user32/winproc.c #11 0x6ffffd3df4fb in dispatch_message /home/bernhard/data/entwicklung/2025/wine\wine/dlls/user32/message.c:804:14 #12 0x6ffffd3df5a1 in DispatchMessageW /home/bernhard/data/entwicklung/2025/wine\wine/dlls/user32/message.c:890:16 #13 0x6ffffdc63d8e in doWinMain /home/bernhard/data/entwicklung/2025/wine\wine/dlls/hhctrl.ocx/hhctrl.c:580:9 #14 0x000140001036 in WinMain /home/bernhard/data/entwicklung/2025/wine\wine/programs/hh/main.c:34:12 #15 0x00014000118f in main /home/bernhard/data/entwicklung/2025/wine\wine/dlls/msvcrt/crt_winmain.c:53:12 #16 0x0001400010b5 in mainCRTStartup /home/bernhard/data/entwicklung/2025/wine\wine/dlls/msvcrt/crt_main.c:58:11 #17 0x6fffffc3565e in BaseThreadInitThunk /home/bernhard/data/entwicklung/2025/wine\wine/dlls/kernel32/thread.c:61:24 #18 0x6fffffdbba1a in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004ba1a) 0x7e99833c9a80 is located 0 bytes after 64-byte region [0x7e99833c9a40,0x7e99833c9a80) allocated by thread T0 here: #0 0x6ffffe84a4a1 in malloc /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt\lib/asan/asan_malloc_win.cpp:80:3 #1 0x6ffffa7cb68b in update_travellog /home/bernhard/data/entwicklung/2025/wine\wine/dlls/ieframe/dochost.c:437:31 #2 0x6ffffa7caf09 in ClOleCommandTarget_Exec /home/bernhard/data/entwicklung/2025/wine\wine/dlls/ieframe/dochost.c:780:13 #3 0x6ffff929b38a in IOleCommandTarget_Exec /home/bernhard/data/entwicklung/2025/wine/wine-build/llvm-newwow64-asan-pe/obj\include\docobj.h:848:12 #4 0x6ffff929ad8c in notify_travellog_update /home/bernhard/data/entwicklung/2025/wine\wine/dlls/mshtml/persist.c:71:9 #5 0x6ffff929a82b in set_current_mon /home/bernhard/data/entwicklung/2025/wine\wine/dlls/mshtml/persist.c:108:17 #6 0x6ffff923abb7 in navigate_proc /home/bernhard/data/entwicklung/2025/wine\wine/dlls/mshtml/navigate.c:2155:9 #7 0x6ffff92d43df in hidden_proc /home/bernhard/data/entwicklung/2025/wine\wine/dlls/mshtml/task.c:398:17 #8 0x6ffffd3f3c8e in WINPROC_wrapper /home/bernhard/data/entwicklung/2025/wine\wine/dlls/user32/winproc.c:86:12 #9 0x6ffffd3f28c8 in call_window_proc /home/bernhard/data/entwicklung/2025/wine\wine/dlls/user32/winproc.c:111:15 #10 0x6ffffd3f2ab2 in dispatch_win_proc_params /home/bernhard/data/entwicklung/2025/wine\wine/dlls/user32/winproc.c #11 0x6ffffd3df4fb in dispatch_message /home/bernhard/data/entwicklung/2025/wine\wine/dlls/user32/message.c:804:14 #12 0x6ffffd3df5a1 in DispatchMessageW /home/bernhard/data/entwicklung/2025/wine\wine/dlls/user32/message.c:890:16 #13 0x6ffffdc63d8e in doWinMain /home/bernhard/data/entwicklung/2025/wine\wine/dlls/hhctrl.ocx/hhctrl.c:580:9 #14 0x000140001036 in WinMain /home/bernhard/data/entwicklung/2025/wine\wine/programs/hh/main.c:34:12 #15 0x00014000118f in main /home/bernhard/data/entwicklung/2025/wine\wine/dlls/msvcrt/crt_winmain.c:53:12 #16 0x0001400010b5 in mainCRTStartup /home/bernhard/data/entwicklung/2025/wine\wine/dlls/msvcrt/crt_main.c:58:11 #17 0x6fffffc3565e in BaseThreadInitThunk /home/bernhard/data/entwicklung/2025/wine\wine/dlls/kernel32/thread.c:61:24 #18 0x6fffffdbba1a in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004ba1a) SUMMARY: AddressSanitizer: heap-buffer-overflow /home/bernhard/data/entwicklung/2025/wine\wine/dlls/ieframe/dochost.c:471:59 in update_travellog Shadow bytes around the buggy address: 0x7e99833c9800: fd fd fd fd fd fd fd fa fa fa fa fa fd fd fd fd 0x7e99833c9880: fd fd fd fa fa fa fa fa fd fd fd fd fd fd fd fd 0x7e99833c9900: fa fa fa fa 00 00 00 00 00 00 00 fa fa fa fa fa 0x7e99833c9980: 00 00 00 00 00 00 00 fa fa fa fa fa fd fd fd fd 0x7e99833c9a00: fd fd fd fd fa fa fa fa 00 00 00 00 00 00 00 00 =>0x7e99833c9a80:[fa]fa fa fa fd fd fd fd fd fd fd fd fa fa fa fa 0x7e99833c9b00: 00 00 00 00 00 00 00 fa fa fa fa fa fd fd fd fd 0x7e99833c9b80: fd fd fd fa fa fa fa fa 00 00 00 00 00 00 00 fa 0x7e99833c9c00: fa fa fa fa 00 00 00 00 00 00 00 fa fa fa fa fa 0x7e99833c9c80: 00 00 00 00 00 00 00 fa fa fa fa fa fd fd fd fd 0x7e99833c9d00: fd fd fd fd fa fa fa fa fd fd fd fd fd fd fd fd Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ``` -- v3: ieframe: Enter reallocation path one position earlier (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/7544

3 4

[PATCH v2 0/4] MR7541: comctl32/tests: Run LVM_GETORIGIN tests on v6.
by Nikolay Sivov (＠nsivov) 13 Mar '25

13 Mar '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: comctl32/listview: Handle WM_VSCROLL(SB_TOP). comctl32/listview: Invert origin coordinate for LVM_GETORIGIN. comctl32/tests: Add a test for LVM_GETORIGIN returned coordinate. comctl32/tests: Run LVM_GETORIGIN tests on v6. https://gitlab.winehq.org/wine/wine/-/merge_requests/7541

3 6

[PATCH v6 0/3] MR7569: Draft: mfplat/tests: Add tests for Byte Stream Timestamps.
by Brendan McGrath (＠redmcg) 13 Mar '25

13 Mar '25

This MR adds tests to `mfplat` to illustrate the timestamp values output on the samples for the respective Byte Stream handlers. I have also included a fix for a bug in `winegstreamer` (and copied to `mfsrcsnk`) where a `NULL` value for the `pguidTimeFormat` parameter in `IMFMediaSource::Start` causes a segmentation fault. On Windows this is allowed. It is included in this MR as the `mfplat` tests pass NULL (so without this fix, the tests crash). -- v6: mfplat/tests: Add tests for Byte Stream Timestamps. https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

2 3

[PATCH v5 0/3] MR7569: Draft: mfplat/tests: Add tests for Byte Stream Timestamps.
by Brendan McGrath (＠redmcg) 13 Mar '25

13 Mar '25

This MR adds tests to `mfplat` to illustrate the timestamp values output on the samples for the respective Byte Stream handlers. I have also included a fix for a bug in `winegstreamer` (and copied to `mfsrcsnk`) where a `NULL` value for the `pguidTimeFormat` parameter in `IMFMediaSource::Start` causes a segmentation fault. On Windows this is allowed. It is included in this MR as the `mfplat` tests pass NULL (so without this fix, the tests crash). -- v5: mfplat/tests: Add tests for Byte Stream Timestamps. https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

2 3

[PATCH v4 0/3] MR7569: Draft: mfplat/tests: Add tests for Byte Stream Timestamps.
by Brendan McGrath (＠redmcg) 13 Mar '25

13 Mar '25

This MR adds tests to `mfplat` to illustrate the timestamp values output on the samples for the respective Byte Stream handlers. I have also included a fix for a bug in `winegstreamer` (and copied to `mfsrcsnk`) where a `NULL` value for the `pguidTimeFormat` parameter in `IMFMediaSource::Start` causes a segmentation fault. On Windows this is allowed. It is included in this MR as the `mfplat` tests pass NULL (so without this fix, the tests crash). -- v4: mfplat/tests: Add tests for Byte Stream Timestamps. https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

2 3

[PATCH v2 0/1] MR7566: wintypes: Add IBufferFactory stub.
by Mohamad Al-Jaf (＠maljaf) 13 Mar '25

13 Mar '25

Needed for ISystemIdentificationInfo::get_Id(). -- v2: wintypes: Add IBufferFactory stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/7566

3 3

[PATCH 0/1] MR7567: include: Add robuffer.idl.
by Mohamad Al-Jaf (＠maljaf) 13 Mar '25

13 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7567

3 2

[PATCH v3 0/7] MR7212: Improvement to winedump for debug information files.
by eric pouech (＠epo) 13 Mar '25

13 Mar '25

This series contain fixes for winedump for debug information: - it fixes a bunch of incorrect information dumping, - it fixes a case of crash for .DBG files, - it allows dumping very large PDB files (>4G) Note: for the later item, current tools' read_file() doesn't work with such large files. Instead of fixing read_file(), I opted for letting a dumper for a given file format to only use a fd to the target file, instead of forcing all dumpers to work from a full in-memory image of the target file. This is useful for PDB files, as their underlying storage requires to reassemble non-contiguous blocks, so this saves memory (the in-memory image of the target file) and one copy of the whole file. This means that all functions to guess the file format now uses a fd instead of the full image. -- v3: tools/winedump: Support dumping large PDB files (>4G). winedump,dbghelp: Remove flexible array member from PDB JG header. tools/winedump: Support more than 64K files in PDB DBI module source substream. tools/winedump: Don't miss hash entries in PDB files. tools/winedump: Don't miss PDB_SYMBOL_RANGE* in PDB files. tools/winedump: Use correct field when dumping CodeView symbols. tools/winedump: Use correct computation for first section out of a .DBG file. https://gitlab.winehq.org/wine/wine/-/merge_requests/7212

2 8

[PATCH v3 0/3] MR7569: Draft: mfplat/tests: Add tests for Byte Stream Timestamps.
by Brendan McGrath (＠redmcg) 13 Mar '25

13 Mar '25

This MR adds tests to `mfplat` to illustrate the timestamp values output on the samples for the respective Byte Stream handlers. I have also included a fix for a bug in `winegstreamer` (and copied to `mfsrcsnk`) where a `NULL` value for the `pguidTimeFormat` parameter in `IMFMediaSource::Start` causes a segmentation fault. On Windows this is allowed. It is included in this MR as the `mfplat` tests pass NULL (so without this fix, the tests crash). -- v3: mfplat/tests: Add tests for Byte Stream Timestamps. https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

2 3

[PATCH v2 0/3] MR7569: Draft: mfplat/tests: Add tests for Byte Stream Timestamps.
by Brendan McGrath (＠redmcg) 13 Mar '25

13 Mar '25

This MR adds tests to `mfplat` to illustrate the timestamp values output on the samples for the respective Byte Stream handlers. I have also included a fix for a bug in `winegstreamer` (and copied to `mfsrcsnk`) where a `NULL` value for the `pguidTimeFormat` parameter in `IMFMediaSource::Start` causes a segmentation fault. On Windows this is allowed. It is included in this MR as the `mfplat` tests pass NULL (so without this fix, the tests crash). -- v2: mfplat/tests: Add tests for Byte Stream Timestamps. https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

2 3

[PATCH 0/3] MR7569: mfplat/tests: Add tests for Byte Stream Timestamps.
by Brendan McGrath (＠redmcg) 13 Mar '25

13 Mar '25

This MR adds tests to `mfplat` to illustrate the timestamp values output on the samples for the respective Byte Stream handlers. I have also included a fix for a bug in `winegstreamer` (and copied to `mfsrcsnk`) where a `NULL` value for the `pguidTimeFormat` parameter in `IMFMediaSource::Start` causes a segmentation fault. On Windows this is allowed. It is included in this MR as the `mfplat` tests pass NULL (so without this fix, the tests crash). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

2 4

[PATCH v2 0/9] MR7160: Draft: Implement encoding for sink writer.
by Ziqing Hui (＠zhui) 13 Mar '25

13 Mar '25

Based on top of tests MR !7125. -- v2: mfreadwrite: Implement IMFSinkWriterEx. mfreadwrite: Implement create_transform. mfreadwrite: Implement sink_writer_SetInputMediaType. mfreadwrite: Rename update_media_type_from_upstream and make it non-static. mfreadwrite: Use a transform array for writer. mfreadwrite/tests: Test sample processing for mp4 sink writer. mfreadwrite/tests: Test getting transforms from mp4 sink writer. mfreadwrite/tests: Test AddStream and SetInputMediaType for mp4 sink writer. mfreadwrite/tests: Remove trivial if. https://gitlab.winehq.org/wine/wine/-/merge_requests/7160

4 18

[PATCH 0/9] MR7571: Draft: mfreadwrite: Implement transform creation. (Part 2)
by Ziqing Hui (＠zhui) 13 Mar '25

13 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7571

2 9

[PATCH 0/1] MR7398: winex11.drv: Don't add MWM_DECOR_BORDER to windows without a caption.
by Dmitry Timoshkov (＠dmitry) 13 Mar '25

13 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7398

2 2

[PATCH v2 0/7] MR7565: windows.system.profile.systemid: Stub ISystemIdentificationInfo::get_Source().
by Mohamad Al-Jaf (＠maljaf) 13 Mar '25

13 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55759 -- v2: windows.system.profile.systemid: Stub ISystemIdentificationInfo::get_Source(). windows.system.profile.systemid/tests: Add ISystemIdentificationInfo::get_Source() tests. windows.system.profile.systemid: Implement ISystemIdentificationStatics::GetSystemIdForPublisher(). windows.system.profile.systemid/tests: Add ISystemIdentificationStatics::GetSystemIdForPublisher() tests. windows.system.profile.systemid: Add ISystemIdentificationStatics stub. windows.system.profile.systemid: Add stub dll. include: Add Windows.System.Profile.SystemIdentification definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/7565

2 7

[PATCH v5 0/1] MR7560: Draft: gdiplus/tests: Extend millimiter test for GdipIsOutlineVisiblePathPoint.
by Bartosz Kosiorek (＠gang65) 13 Mar '25

13 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55717 -- v5: gdiplus/tests: Extend millimeter test for GdipIsOutlineVisiblePathPoint. https://gitlab.winehq.org/wine/wine/-/merge_requests/7560

2 2

[PATCH 0/1] MR7568: fusion: Use wide character string literals.
by Alex Henrie (＠alexhenrie) 13 Mar '25

13 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7568

2 1

[PATCH 0/1] MR7566: wintypes: Add IBufferFactory stub.
by Mohamad Al-Jaf (＠maljaf) 13 Mar '25

13 Mar '25

Needed for ISystemIdentificationInfo::get_Id(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7566

2 1

[PATCH 0/7] MR7565: windows.system.profile.systemid: Stub ISystemIdentificationInfo::get_Source().
by Mohamad Al-Jaf (＠maljaf) 13 Mar '25

13 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55759 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7565

2 7

Re: [PATCH v3 0/1] MR7323: wininet: Treat Expires value "-1" the same as "0"
by Yongjie Yao (＠yaoyongjie) 13 Mar '25

13 Mar '25

On Wed Mar 12 10:25:16 2025 +0000, Jacek Caban wrote: > Those are interesting findings, thanks. Could you please also check > what's the behavior for missing "Expires" header? It sounds like we > should change error handling in `HTTP_ProcessExpires`, I wonder if > `!expirationFound` branch there is right... Ok, I will try to check it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7323#note_97642

1 0

[PATCH v2 0/2] MR7563: mf/tests: Tests timestamp values on output samples from the H.264 and WMV MFT decoders.
by Brendan McGrath (＠redmcg) 13 Mar '25

13 Mar '25

These tests serve to illustrate the output sample time and duration values from their respective native MFT video decoders with respect to the following circumstances: 1. When no frame rate nor input sample timestamps are provided; 2. When a frame rate is provided but there are no sample timestamps; and 3. When a frame rate is provided, but the input sample timestamps disagree with this value It also highlights the gap in our implementation. However, I don't believe this can be fixed without first confirming the correct output from our IMFMediaStream implementations. -- v2: mf/tests: Test timestamps in WMV decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/7563

2 2

[PATCH 0/4] MR7564: ntdll: Fix first trap instruction when setting eflags with SetThreadContext or returning from syscall.
by Paul Gofman (＠gofman) 13 Mar '25

13 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7564

2 5

[PATCH 0/2] MR7563: mf/tests: Tests timestamp values on output samples from the H.264 and WMV MFT decoders.
by Brendan McGrath (＠redmcg) 13 Mar '25

13 Mar '25

These tests serve to illustrate the output sample time and duration values from their respective native MFT video decoders with respect to the following circumstances: 1. When no frame rate nor input sample timestamps are provided; 2. When a frame rate is provided but there are no sample timestamps; and 3. When a frame rate is provided, but the input sample timestamps disagree with this value It also highlights the gap in our implementation. However, I don't believe this can be fixed without first confirming the correct output from our IMFMediaStream implementations. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7563

2 2

[PATCH v4 0/1] MR7560: Draft: gdiplus/tests: Extend millimiter test for GdipIsOutlineVisiblePathPoint.
by Bartosz Kosiorek (＠gang65) 12 Mar '25

12 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55717 -- v4: gdiplus/tests: Extend millimeter test for GdipIsOutlineVisiblePathPoint. https://gitlab.winehq.org/wine/wine/-/merge_requests/7560

2 1

Re: [PATCH v3 0/2] MR7557: ntdll: Implement RtlGetFullPathName_UEx. - approved
by Alexandre Julliard (＠julliard) 12 Mar '25

12 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7557

1 0

Re: [PATCH v2 0/2] MR7537: setupapi: Fix id size handling in get_device_id_list(). - approved
by Alexandre Julliard (＠julliard) 12 Mar '25

12 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7537

1 0

Re: [PATCH v2 0/1] MR7551: win32u: Prevent remote drawing to ULW layered window. - approved
by Alexandre Julliard (＠julliard) 12 Mar '25

12 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7551

1 0

Re: [PATCH v2 0/1] MR7554: wuauserv: Use wide character string literal for "wuauserv". - approved
by Alexandre Julliard (＠julliard) 12 Mar '25

12 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7554

1 0

Re: [PATCH v2 0/1] MR7553: winecfg: Use wide character string literal for "Tahoma". - approved
by Alexandre Julliard (＠julliard) 12 Mar '25

12 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7553

1 0

Re: [PATCH v4 0/1] MR7357: rpcrt4: Avoid unsigned overflows in buffer validation. - approved
by Alexandre Julliard (＠julliard) 12 Mar '25

12 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7357

1 0

Re: [PATCH v2 0/1] MR7558: kernel32/tests: Flush pending APCs and close handles (ASan). - approved
by Alexandre Julliard (＠julliard) 12 Mar '25

12 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7558

1 0

Re: [PATCH v2 0/5] MR7511: opengl32: Stop generating wine/opengl_driver.h. - approved
by Alexandre Julliard (＠julliard) 12 Mar '25

12 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7511

1 0

Re: [PATCH v3 0/4] MR7538: winegstreamer: Implement type handler functions for media sink. - approved
by Alexandre Julliard (＠julliard) 12 Mar '25

12 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7538

1 0

[PATCH v5 0/3] MR7542: ws2_32: Implement WSALookupService for Bluetooth device discovery.
by Vibhav Pant (＠vibhavp) 12 Mar '25

12 Mar '25

This MR adds an initial implementation of the winsock `WSALookupsService*` methods for performing Bluetooth device discovery (`LUP_CONTAINERS`). Pending !7472, the code will also eventually support performing device inquiry scans. -- v5: ws2_32: Implement WSALookupServiceNext for Bluetooth device discovery. ws2_32: Implement WSALookupServiceBegin for Bluetooth device discovery. ws2_32/tests: Add tests for Bluetooth device discovery in WSALookupServiceBegin/Next. https://gitlab.winehq.org/wine/wine/-/merge_requests/7542

2 4

[PATCH v3 0/1] MR7560: Draft: gdiplus/tests: Extend millimiter test for GdipIsOutlineVisiblePathPoint.
by Bartosz Kosiorek (＠gang65) 12 Mar '25

12 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55717 -- v3: gdiplus/tests: Extend millimeter test for GdipIsOutlineVisiblePathPoint. https://gitlab.winehq.org/wine/wine/-/merge_requests/7560

2 1

[PATCH 0/2] MR7537: setupapi: Fix id size handling in get_device_id_list().
by Paul Gofman (＠gofman) 12 Mar '25

12 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7537

3 5

[PATCH 0/3] MR6925: d3dcompiler: Enable double-as-float option for older modules.
by Nikolay Sivov (＠nsivov) 12 Mar '25

12 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55448 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6925

4 14

[PATCH v2 0/1] MR7560: Draft: gdiplus/tests: Extend millimiter test for GdipIsOutlineVisiblePathPoint.
by Bartosz Kosiorek (＠gang65) 12 Mar '25

12 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55717 -- v2: gdiplus/tests: Extend millimiter test for GdipIsOutlineVisiblePathPoint. https://gitlab.winehq.org/wine/wine/-/merge_requests/7560

2 1

[PATCH 0/1] MR7560: Draft: gdiplus/tests: Extend millimiter test for GdipIsOutlineVisiblePathPoint.
by Bartosz Kosiorek (＠gang65) 12 Mar '25

12 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55717 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7560

2 1

[PATCH 0/1] MR7551: win32u: Prevent remote drawing to ULW layered window.
by Paul Gofman (＠gofman) 12 Mar '25

12 Mar '25

Fixes a regression introduced by 309daa5beef262333b8c5328018782401c3380a6 . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7551

3 4

[PATCH v3 0/1] MR7357: rpcrt4: Avoid unsigned overflows in buffer validation.
by Jacek Caban (＠jacek) 12 Mar '25

12 Mar '25

Fixes Clang 20 `-Wtautological-compare` warnings. Based on patch by William Horvath. -- v3: rpcrt4: Don't validate buffer in NDR marshaler. https://gitlab.winehq.org/wine/wine/-/merge_requests/7357

3 2

Re: [PATCH v27 0/1] MR6884: Iphlpapi.dll: Included SendARP
by Huw Davies (＠huw) 12 Mar '25

12 Mar '25

On Tue Mar 11 14:54:20 2025 +0000, Thi Garlet wrote: > @huw, looking at > [netioapi](https://gitlab.winehq.org/wine/wine/-/blob/master/include/netioap…, > I found some functions from [IP Helper > overview](https://learn.microsoft.com/en-us/windows-hardware/drivers/networ…, > but ResolveIpNetEntry2() is not there. > The SendARP() is workig, is something missing to merge ? > thanks Well the idea is you'd implement `ResolveIpNetEntry2()` and have `SendARP()` call it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6884#note_97547

1 0

[PATCH 0/5] MR7511: opengl32: Stop generating wine/opengl_driver.h.
by Rémi Bernon (＠rbernon) 12 Mar '25

12 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7511

5 8

[PATCH 0/1] MR7558: kernel32/tests: Flush pending APCs and close handles (ASan).
by Bernhard Übelacker (＠bernhardu) 12 Mar '25

12 Mar '25

ASan gets triggered in `test_read_write` because an APC gets executed while `test_async_file_errors` is already left, and therefore the `ovl` variable in is no longer at the stack. This patch tries to flush the APC before leaving the function `test_async_file_errors`. Also closes two handles opened inside this function. ``` ================================================================= ==508==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffffe1ea7f8 at pc 0x0001401a4933 bp 0x7ffffe1e2a80 sp 0x7ffffe1e2ac8 READ of size 8 at 0x7ffffe1ea7f8 thread T0 0208:fixme:file:server_get_file_info Unsupported info class e #0 0x0001401a4932 in FileIOComplete .../wine/dlls/kernel32/tests/file.c:3337:24 #1 0x6ffffacef75f in KiUserApcDispatcher (C:\windows\system32\ntdll.dll+0x17000f75f) #2 0x6ffffacedf53 in NtDelayExecution (C:\windows\system32\ntdll.dll+0x17000df53) #3 0x6ffffa6eec5f in SleepEx .../wine/dlls/kernelbase\sync.c:346:14 #4 0x00014015a0e3 in test_read_write .../wine/dlls/kernel32/tests/file.c:3451:5 #5 0x00014015a0e3 in func_file .../wine/dlls/kernel32/tests/file.c:6348:5 #6 0x0001404d7fa1 in run_test .../wine/include/wine/test.h:765:5 #7 0x0001404d7fa1 in main .../wine/include/wine/test.h:884:12 #8 0x0001404d9f8f in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #9 0x6ffffbfd4808 in BaseThreadInitThunk .../wine/dlls/kernel32\thread.c:61:5 #10 0x6ffffacefa1a in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17000fa1a) Address 0x7ffffe1ea7f8 is located in stack of thread T0 at offset 30232 in frame #0 0x00014013223f in func_file .../wine/dlls/kernel32/tests/file.c:6296 This frame has 205 object(s): [32, 292) 'cwd.i6426' (line 6001) [368, 628) 'temp_dir.i6427' (line 6001) [704, 964) 'cwd.i' (line 5922) ... [29536, 29796) 'filename.i2304' (line 3395) [29872, 30132) 'szFile.i' (line 3343) [30208, 30240) 'ovl.i' (line 3347) <== Memory access at offset 30232 is inside this variable [30272, 30276) 'count.i' (line 3364) [30288, 30296) 'h.i' (line 3246) ... [116896, 117156) 'temp_path' (line 6297) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-use-after-scope .../wine/dlls/kernel32/tests/file.c:3337:24 in FileIOComplete Shadow bytes around the buggy address: 0x7ffffe1ea500: f2 f2 f2 f2 f2 f2 f2 f2 00 00 00 00 00 00 00 00 0x7ffffe1ea580: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ea600: 00 00 00 00 00 00 00 00 04 f2 f2 f2 f2 f2 f2 f2 0x7ffffe1ea680: f2 f2 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x7ffffe1ea700: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 =>0x7ffffe1ea780: f8 f8 f8 f2 f2 f2 f2 f2 f2 f2 f2 f2 f8 f8 f8[f8] 0x7ffffe1ea800: f2 f2 f2 f2 f8 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f8 0x7ffffe1ea880: f8 f8 f2 f2 f2 f2 f8 f2 f8 f8 f8 f8 f8 f8 f8 f8 0x7ffffe1ea900: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x7ffffe1ea980: f8 f8 f8 f8 f8 f8 f8 f8 f2 f2 f2 f2 f2 f2 f2 f2 0x7ffffe1eaa00: f8 f2 f2 f2 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==508==ABORTING ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7558

2 1

Re: [PATCH v3 0/1] MR7323: wininet: Treat Expires value "-1" the same as "0"
by Jacek Caban (＠jacek) 12 Mar '25

12 Mar '25

On Wed Mar 12 10:25:16 2025 +0000, Yongjie Yao wrote: > I add 5 tests to test_http_connection(). > The first test sends "Expires: 0", the second test sends "Expires: -1", > the third test sends "Expires: 100", the fourth test sends "Expires: > invalid date", the fifth test sends "Expires: Thu, 06 Mar 2025 06:08:11 GMT". > The tests on actual windows 10 has output informations, such as: > ```null > http.c:6837: expires: 2025-03-06 06:14:13, current time: 2025-03-06 > 06:14:13, server response expires: 0 > http.c:6837: expires: 2025-03-06 06:14:14, current time: 2025-03-06 > 06:14:14, server response expires: -1 > http.c:6837: expires: 2025-03-06 06:14:14, current time: 2025-03-06 > 06:14:14, server response expires: 100 > http.c:6837: expires: 2025-03-06 05:14:15, current time: 2025-03-06 > 06:14:15, server response expires: invalid date > http.c:6837: expires: 2025-03-06 06:08:11, current time: 2025-03-06 > 06:14:15, server response expires: Thu, 06 Mar 2025 06:08:11 GMT > ``` > I think Windows treats all numbers as invalid values and sets the > expiration time to the current system time, while other invalid values > set the expiration time to one hour before the current system time, and > valid expiration times use the set expiration time. > In Wine, handling inconsistencies with Windows 10， We treat "0" as > "1601-01-01 00:00:00", and all other invalid values as 10 minutes after > the current system time. such as > ```coffeescript > http.c:6837: expires: 1601-01-01 00:00:00, current time: 2025-03-06 > 06:10:56, server response expires: 0 > 0118:err:wininet:HTTP_ParseDateAsAsctime unexpected weekday L"-1" > 0118:err:wininet:HTTP_ParseDate unexpected date format L"-1" > http.c:6837: expires: 2025-03-06 06:20:56, current time: 2025-03-06 > 06:10:57, server response expires: -1 > 0110:err:wininet:HTTP_ParseDateAsAsctime unexpected weekday L"100" > 0110:err:wininet:HTTP_ParseDate unexpected date format L"100" > http.c:6837: expires: 2025-03-06 06:20:56, current time: 2025-03-06 > 06:10:57, server response expires: 100 > 0118:err:wininet:HTTP_ParseDateAsAsctime unexpected weekday L"inv" > 0118:err:wininet:HTTP_ParseDate unexpected date format L"invalid date" > http.c:6837: expires: 2025-03-06 06:20:56, current time: 2025-03-06 > 06:10:58, server response expires: invalid date > http.c:6837: expires: 2025-03-06 06:08:10, current time: 2025-03-06 > 06:10:58, server response expires: Thu, 06 Mar 2025 06:08:11 GMT > ``` Those are interesting findings, thanks. Could you please also check what's the behavior for missing "Expires" header? It sounds like we should change error handling in `HTTP_ProcessExpires`, I wonder if `!expirationFound` branch there is right... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7323#note_97540

1 0

2025

2024

2023

2022

wine-gitlab