- wine-gitlab - winehq.org

[PATCH 0/1] MR2074: ws2_32: Provide same address order from gethostbyname() on consequent calls.
by Paul Gofman (＠gofman) 31 Jan '23

31 Jan '23

Fixes error connecting to servers in Life is Strange Remastered (due to timeout). When there are multiple IP addresses for a host name Linux gethostbyname() returns those in random order upon each call (meaning to provide server load balancing). On Windows the order of IP addresses is not determined as well but it is the same on consequent calls (changes after network resets and probably DNS timeout expiration). The game executes multiple http requests over TLS connection through its own libraries using only winsock from Wine. Upon executing each next request it calls gethostbyname() for the server DNS name and uses the first returned IP address. When that's different from the previous IP address used for established TLS connection it doesn't reuse the connection and establishes the connection from scratch which is very long process due to how the game does it (on Windows as well). One obvious way to make gethostbyname() behave like Windows would be to cache the results we get from host. But caching gethostbyname() results is tricky, there are already host-side caches which take into account DNS timeouts and network interfaces change. It is possible in theory to cache the result and then still call native gethostbyname() and keep the order if nothing else has changed in the reply, but it seems to me that would complicate things more than this patch does. The patch sorts the output by IP address randomly hashed with a random transform hash established only once per process run. So it will still provide load balancing between the IP addresses between different clients and different process instances while will be returning the same order of IP addresses on consequent calls. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2074

4 3

[PATCH 0/1] MR2073: scardsvr: Add stub service.
by Zebediah Figura (＠zfigura) 31 Jan '23

31 Jan '23

The Rutoken driver installer tries to start this service, and fails if it doesn't exist. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54396 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2073

3 2

[PATCH 0/4] MR2072: d3d pixel format tests
by Zebediah Figura (＠zfigura) 31 Jan '23

31 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2072

3 5

[PATCH 0/2] MR2071: include: Updates to difxapi.h.
by Zebediah Figura (＠zfigura) 31 Jan '23

31 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2071

2 2

[PATCH 0/1] MR2070: ntdll: Add stub for NtQueryInformationProcess( ProcessHandleTable ).
by Paul Gofman (＠gofman) 30 Jan '23

30 Jan '23

Fixes 2K Launcher failure on start (which is using Chromium) with Windows version set to 8.1+ in the prefix (although newer CEF versions don't have Win 7/8.0 fallback here at all). The failure happens in chromium/sandbox/win/src/win_utils.cc:GetCurrentProcessHandles(). The version which the launcher is using has a Win7 / 8.0 fallback if NtQueryInformationProcess( ProcessHandleTable ) but before going for fallback it asserts that the reported Windows version is less than 8.1 and the process crashes from assert's int3 exception. Newer versions of Chromium don't have Win7/8.0 fallback at all, so going to fail without ProcessHandleTable success regardless of prefix version if hit this path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2070

2 1

Re: [PATCH v2 0/5] MR2061: dinput: Move hook update to the input thread. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2061

1 0

Re: [PATCH v3 0/1] MR2063: dinput/tests: Dynamically allocate async operation handlers. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2063

1 0

Re: [PATCH v6 0/2] MR2051: include/msvcrt: Add noreturn attribute to _assert. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2051

1 0

Re: [PATCH v2 0/2] MR2065: ws2_32/tests: Fix some test failures on Windows 11. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2065

1 0

Re: [PATCH v2 0/1] MR2066: gdi32/tests: Mark another D3DKMTCheckOcclusion() test as flaky. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2066

1 0

Re: [PATCH v2 0/1] MR2060: po: Update Tamil translation - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2060

1 0

[PATCH v5 0/1] MR1977: comctl32: Fix PathWordBreakProc.
by Vladislav Timonin (＠vt) 30 Jan '23

30 Jan '23

Currently it doesn't work as expected, namely gets stuck on delimiter and caret is moved before the delimiter. Unnecessary more robust than Windows, which feels like doesn't do any checks at all. EDIT1: v2: return length in `WB_RIGHT` if its bigger than default return value of 0 on invalid values EDIT2: v3: don't test `WB_ISDELIMITER` with out of bounds indices, Windows doesn't check them and does out of bounds reads -- v5: comctl32: Fix PathWordBreakProc. https://gitlab.winehq.org/wine/wine/-/merge_requests/1977

2 4

Re: [PATCH v2 0/2] MR2058: winex11: Make some definitions hidden. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2058

1 0

Re: [PATCH v3 0/2] MR2055: win32u: Make more definitions hidden. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2055

1 0

Re: [PATCH v2 0/5] MR2056: ntdll: Make some definitions static or hidden. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2056

1 0

Re: [PATCH v2 0/1] MR2050: include: Remove __WINE_MALLOC from functions that shouldn't have it. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2050

1 0

Re: [PATCH v2 0/1] MR2052: tools: Include limits.h for PATH_MAX - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2052

1 0

[PATCH 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Nikolay Sivov (＠nsivov) 30 Jan '23

30 Jan '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74

6 15

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) 30 Jan '23

30 Jan '23

There is another things that bothers me: The while loop in parse_wave_form(): - WAVE file chunk order is fmt and then data - The last fmt or data chunk will "win"; doubt there are any dmusic related WAVE files with duplicate fmt or data chunks. But for now we can start with the while() loop: - No clue where those extra chunks are placed - We don't do anything with the WAV file; we just store it. Though we might run into memory issues with big WAV files. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22349

1 0

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) 30 Jan '23

30 Jan '23

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > + case FOURCC_LIST: { > + FIXME("Skipping LIST tag\n"); > + break; > + } > + case mmioFOURCC('I','S','F','T'): { > + FIXME("Skipping ISFT tag\n"); > + break; > + } > + case mmioFOURCC('f','a','c','t'): { > + FIXME("Skipping fact tag\n"); > + break; > + } > + } > + } > + > + return S_OK; The stream_next_chunk() in the while loop can fail too and you'll need to return that failure too. S_FALSE indicates "no more chunks". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22348

1 0

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) 30 Jan '23

30 Jan '23

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > > if (riff.type == DMUS_FOURCC_SEGMENT_FORM) > hr = parse_segment_form(This, stream, &riff); > - else { > - FIXME("WAVE form loading not implemented\n"); > - hr = S_OK; > - } > + else Please check that the RIFF has the proper type and add an else for the error case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22346

1 0

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) 30 Jan '23

30 Jan '23

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > return CONTAINING_RECORD(iface, IDirectMusicSegment8Impl, dmobj.IPersistStream_iface); > } > > +static HRESULT parse_wave_form(IDirectMusicSegment8Impl *This, IStream *stream, const struct chunk_entry *riff) > +{ > + HRESULT hr; > + struct chunk_entry chunk = {.parent = riff}; > + > + TRACE("Parsing segment wave in %p: %s\n", stream, debugstr_chunk(riff)); > + > + while ((hr = stream_next_chunk(stream, &chunk)) == S_OK) { > + switch (chunk.id) { > + case mmioFOURCC('f','m','t',' '): { > + if (FAILED(hr = stream_chunk_get_data(stream, &chunk, &This->wave_format, chunk.size))) Don't use the chunk.size there; use the sizeof the destination object, here sizeof(This->wave_format) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22347

1 0

[PATCH v5 0/3] MR65: hlsl: More function-related tests.
by Zebediah Figura (＠zfigura) 30 Jan '23

30 Jan '23

-- v5: tests: Test entry point semantics on function declarations. tests: Add more tests for early return from the entry point. tests: Add some tests for early return from user-defined functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/65

2 3

[PATCH 0/1] MR2068: Draft: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 30 Jan '23

30 Jan '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

3 2

[PATCH 0/1] MR2067: wine32u: fix off-by-one bugs in MsgWaitForMultipleObjectsEx drivers
by Ivan Chikish (＠nekotekina) 30 Jan '23

30 Jan '23

When count = 0, returned value may become -1 which seems wrong in the case of successful process_events() call. Also MSDN suggests that `count` may be a valid return value in this case. When -1 is returned, it may cause SetLastError to -1 as well which is not a valid error code AFAIK. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54405 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2067

4 7

[PATCH v5 0/2] MR2051: include/msvcrt: Add noreturn attribute to _assert.
by Jinoh Kang (＠iamahuman) 30 Jan '23

30 Jan '23

This informs the compiler that no code will ever run after an assertion failure (unless NDEBUG is defined), which increases accuracy of compiler warnings and static analyses. -- v5: include/msvcrt: Add noreturn attribute to _assert. include: Add noreturn attribute to RtlRaiseStatus. https://gitlab.winehq.org/wine/wine/-/merge_requests/2051

3 4

[PATCH 0/1] MR2066: gdi32/tests: Mark another D3DKMTCheckOcclusion() test as flaky.
by Hans Leidekker (＠hans) 30 Jan '23

30 Jan '23

It shows the same behavior as the one marked by commit 2d19baa6b576. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51313 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2066

3 2

[PATCH 0/2] MR2065: ws2_32/tests: Fix some test failures on Windows 11.
by Hans Leidekker (＠hans) 30 Jan '23

30 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2065

2 2

[PATCH 0/7] MR2064: Implement kernelbase.EnumProcessModulesEx
by eric pouech (＠epo) 30 Jan '23

30 Jan '23

This series implements kernelbase.EnumProcessModulesEx(). This series: - implements EnumProcessModulesEx() - ensure it passes a bunch of new tests - fix GetModuleBaseName, GetModuleFileNameEx, GetModuleInformation() to cope with HMODULES returned from EnumProcessModulesEx(). Notes: as EnumProcessModules() doesn't return the same list as Windows on a Wow64 setup, and that there's no use of EnumProcessModulesEx() in Wine code, this first series will implement EnumProcessModulesEx() and if accepted, it will be followed by a second serie which, firstly, adapt all places in Wine code with bad expectations on EnumProcessModules(), and secondly reimlement EnumProcessModules() using EnumProcessModulesEx(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2064

2 7

[PATCH v2 0/1] MR2063: dinput/tests: Dynamically allocate async operation handlers.
by Rémi Bernon (＠rbernon) 30 Jan '23

30 Jan '23

Instead of passing them from the stack. The async operation is executed in a thread pool, which might Release its reference asynchronously and call a stale function pointer if it is sequenced after the stack invalidation. -- v2: dinput/tests: Dynamically allocate async operation handlers. https://gitlab.winehq.org/wine/wine/-/merge_requests/2063

2 1

[PATCH v2 0/2] MR2055: win32u: Make more definitions hidden.
by Zebediah Figura (＠zfigura) 30 Jan '23

30 Jan '23

-- v2: win32u: Make set_visible_region() hidden. win32u: Make send_message_timeout() hidden. https://gitlab.winehq.org/wine/wine/-/merge_requests/2055

3 3

[PATCH 0/1] MR2059: combase: Generate apartment OXID in rpcss
by Aaron Hill (＠Aaron1011) 30 Jan '23

30 Jan '23

Currently, apartment OXIDs are generated using the process ID (and the thread ID for a single threaded-apartment). This means that if an apartment is destroyed and re-created (using `CoUninitialize` followed by `CoInitializeEx`), the newly created apartment will end up with the same OXID as the old apartment. However, testing shows that Windows will generate a *new* OXID when an apartment is created in the above manner. This patch uses `rpcss` to generate a new OXID. The current process id is combined with an incrementing counter stored in rpcss. This ensures that re-creating an apartment will not re-use an OXID. Additionally, this fixes an issue that caused the .NET 4.8 installer to become stuck during the downloading stage under Wine. The installer appears to perform the following actions: 1. Call `IBackgroundCopyJob_SetNotify` interface on a BITS job. This causes us to create a proxy (in the other process hosting 'qmgr') for the `IBackgroundCopyCallback` pointer passed as a parameter. 2. Trigger MTA apartment re-creation (in the process running the setup, *not* the process with the `IBackgroundCopyCallback` proxy) through `CoUninitialize` followed by `CoInitializeEx`. 3. Call `IBackgroundCopyJob_SetNotify` on a newly created job, but with the same `IBackgroundCopyCallback` pointer parameter. When we deserialize the pointer passed to `IBackgroundCopyJob_SetNotify`, we will end up re-using the same `proxy_manager` that we created for the previous `IBackgroundCopyCallback`. This is due to the fact that the OIDs happen to match (due to the fact that the .NET 4.8 setup appears to perform actions in the same order between the old and new apartments), and the apartment OXIDs match as explained above. above. As a result, we will use the old IPID when we send RPC packets using this `proxy_manager`. However, the new and old IPIDs will *never* match, since their generation process includes `RtlGenRandom`. This will cause a fault packet to be generated on the listening side of the RPC connection. By avoiding re-using OXIDs across re-created apartments, we ensure that the proxy side will never incorrectly re-use a stale `proxy_manager`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059

3 4

[PATCH 0/2] MR76: vkd3d-shader/hlsl: Support rsqrt() and distance() intrinsics.
by Nikolay Sivov (＠nsivov) 30 Jan '23

30 Jan '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/76

3 7

[PATCH 0/1] MR2057: winepulse: Make mult_alaw_sample() and mult_ulaw_sample() hidden.
by Zebediah Figura (＠zfigura) 30 Jan '23

30 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2057

3 2

[PATCH 0/5] MR2061: dinput: Move hook update to the input thread.
by Rémi Bernon (＠rbernon) 30 Jan '23

30 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2061

2 5

[PATCH v3 0/1] MR2045: d3d12core: Add stub DLL.
by Mohamad Al-Jaf (＠maljaf) 30 Jan '23

30 Jan '23

Forspoken checks for the existence of this DLL. -- v3: d3d12core: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2045

3 12

[PATCH 0/1] MR2060: po: Update Tamil translation
by K.B.Dharun Krishna (＠kbdharun) 30 Jan '23

30 Jan '23

I updated Tamil translation. Over the next couple of weeks, I will send PRs to complete the translation fully. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2060

2 1

[PATCH v6 0/2] MR2044: ntoskrnl.exe: Implement acquiring and releasing guarded mutexes
by Etaash Mathamsetty (＠etaash.mathamsetty) 30 Jan '23

30 Jan '23

according to MSDN they are implemented in the same way as a fast mutex. -- v6: ntoskrnl.exe: Implement KeReleaseGuardedMutex. https://gitlab.winehq.org/wine/wine/-/merge_requests/2044

3 3

[PATCH 0/2] MR2058: winex11: Make some definitions hidden.
by Zebediah Figura (＠zfigura) 29 Jan '23

29 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2058

2 2

[PATCH 0/3] MR2055: win32u: Make more definitions hidden.
by Zebediah Figura (＠zfigura) 29 Jan '23

29 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2055

4 5

[PATCH 0/5] MR2056: ntdll: Make some definitions static or hidden.
by Zebediah Figura (＠zfigura) 29 Jan '23

29 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2056

2 5

Re: [PATCH 0/1] MR112: Draft: Revert "dbghelp: Don't bother trying to initialize loader backend if we can't... - closed
by Jinoh Kang (＠iamahuman) 29 Jan '23

29 Jan '23

This merge request was closed by Jinoh Kang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/112

1 0

[PATCH v5 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) 29 Jan '23

29 Jan '23

Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. Also, fix Wine's RtlUniform() to match the new behavior accordingly. -- v5: ntdll: Fix integer overflow in RtlUniform. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 2

[PATCH v4 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) 29 Jan '23

29 Jan '23

Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. Also, fix Wine's RtlUniform() to match the new behavior accordingly. -- v4: ntdll: Fix integer overflow in RtlUniform. ntdll/tests: Update test_RtlUniform to match Windows Vista or later. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 3

[PATCH 0/1] MR2050: include: Remove __WINE_MALLOC from functions that shouldn't have it.
by Alex Henrie (＠alexhenrie) 29 Jan '23

29 Jan '23

According to the GCC documentation,[1] `__attribute__((malloc))` may not be used on functions that return memory that contains one or more valid pointers. [1] https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2050

3 4

[PATCH 0/1] MR2054: ntoskrnl.exe: Add stub for IoQueryFileDosDeviceName.
by Etaash Mathamsetty (＠etaash.mathamsetty) 29 Jan '23

29 Jan '23

battleye seems to be calling this function -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2054

2 1

[PATCH v2 0/1] MR2033: ntoskrnl: Add ExGetPreviousMode and test.
by Alex Henrie (＠alexhenrie) 28 Jan '23

28 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54378 -- v2: ntoskrnl: Add ExGetPreviousMode and test. https://gitlab.winehq.org/wine/wine/-/merge_requests/2033

2 2

[PATCH 0/1] MR1749: mshtml: Add head, title and body elements to about:blank.
by Santino Mazza (＠tati1454) 28 Jan '23

28 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1749

4 6

[PATCH v4 0/9] MR1628: Draft: ntdll: Implement Low Fragmentation Heap.
by Rémi Bernon (＠rbernon) 28 Jan '23

28 Jan '23

Not completely sure if it's worth having for 8.0, but opening this to share the target I'm trying to reach. -- v4: ntdll: Implement Low Fragmentation Heap. ntdll: Introduce per-thread free lists for heap blocks. ntdll: Introduce a new BLOCK_FLAG_SPLIT heap block flag. ntdll: Introduce a new subheap thread affinity field. ntdll: Introduce a new heap block_init_used helper. ntdll: Introduce a new heap free_list_init helper. ntdll: Count allocations and automatically enable LFH. ntdll: Implement HeapCompatibilityInformation. ntdll: Fix HeapWalk with empty uncommitted consecutive subheaps. https://gitlab.winehq.org/wine/wine/-/merge_requests/1628

3 11

[PATCH v3 0/2] MR2051: include/msvcrt: Add noreturn attribute to _assert.
by Jinoh Kang (＠iamahuman) 28 Jan '23

28 Jan '23

This informs the compiler that no code will ever run after an assertion failure (unless NDEBUG is defined), which increases accuracy of compiler warnings and static analyses. -- v3: include/msvcrt: Add noreturn attribute to _assert. include/msvcrt: Add noreturn attribute to RtlRaiseStatus. https://gitlab.winehq.org/wine/wine/-/merge_requests/2051

2 4

[PATCH 0/1] MR2033: ntoskrnl: Add ExGetPreviousMode stub.
by Alex Henrie (＠alexhenrie) 28 Jan '23

28 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54378 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2033

5 7

[PATCH v3 0/8] MR1628: Draft: ntdll: Implement Low Fragmentation Heap.
by Rémi Bernon (＠rbernon) 28 Jan '23

28 Jan '23

Not completely sure if it's worth having for 8.0, but opening this to share the target I'm trying to reach. -- v3: ntdll: Implement Low Fragmentation Heap. ntdll: Introduce per-thread free lists for heap blocks. ntdll: Introduce a new BLOCK_FLAG_SPLIT heap block flag. ntdll: Introduce a new subheap thread affinity field. ntdll: Introduce a new heap block_init_used helper. ntdll: Introduce a new heap free_list_init helper. ntdll: Count allocations and automatically enable LFH. ntdll: Implement HeapCompatibilityInformation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1628

4 11

[PATCH v2 0/1] MR2051: include/msvcrt: Add noreturn attribute to _assert.
by Jinoh Kang (＠iamahuman) 28 Jan '23

28 Jan '23

This informs the compiler that no code will ever run after an assertion failure (unless NDEBUG is defined), which increases accuracy of compiler warnings and static analyses. -- v2: include/msvcrt: Add noreturn attribute to _assert. https://gitlab.winehq.org/wine/wine/-/merge_requests/2051

3 2

[PATCH v6 0/4] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 28 Jan '23

28 Jan '23

## Summary Tests for UrlFixupW and semi stub function implementaion. ## Test results - Tests are 100% ok on my local WIN 10 pc. Wine test bot seems to be okay too. - Wine tests on debian machine | function type | result | | ------ | ------ | | stub | 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **200** failures), 0 skipped. | | semi stub| 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **100** failures), 0 skipped. | ## Todos For follow up merge request(s). - [ ] Add more tests for priority investigation, who url scheme fix up is working on windows. - [ ] Implement missing parts of fix up. ## Conclusion Semi stub implementation is an improvement to the existing solution. A grep showed that wine internals do not call this function, therefore it should not introduce any new bugs. Windows applications using/relying on the function should now work better, if not they may reveal already existing bugs. -- v6: shlwapi: fixup leading and trailing typos in UrlFixupW shlwapi: check for colon in UrlFixupW kernelbase: Restructure UrlFixupW() shlwapi/tests: Add tests for UrlFixupW. https://gitlab.winehq.org/wine/wine/-/merge_requests/1825

3 9

[PATCH v2 0/2] MR145: kernel32: Unstub MoveFileWithProgress, add test.
by James McDonnell (＠ElementalWarrior) 27 Jan '23

27 Jan '23

-- v2: kernel32/tests: Implement test calling CopyFileExA with progress callback kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW https://gitlab.winehq.org/wine/wine/-/merge_requests/145

4 22

[PATCH 0/1] MR2052: tools: Include limits.h for PATH_MAX
by Gerald Pfeifer (＠gerald) 27 Jan '23

27 Jan '23

PATH_MAX is used in FreeBSD-specific code in get_argv0_dir which otherwise fails. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2052

2 1

[PATCH 0/1] MR2051: include/msvcrt: Add noreturn attribute to _assert.
by Jinoh Kang (＠iamahuman) 27 Jan '23

27 Jan '23

This informs the compiler that no code will ever run after an assertion failure (unless NDEBUG is defined), which increases accuracy of compiler warnings and static analyses. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2051

2 2

Re: [PATCH v3 0/1] MR1255: gitlab: Run win64 tests instead of wow64. - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1255

1 0

Re: [PATCH v10 0/1] MR1444: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1444

1 0

Re: [PATCH v3 0/3] MR2049: Ntdll tests - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2049

1 0

Re: [PATCH v8 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders. - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682

1 0

Re: [PATCH v2 0/2] MR2048: vbscript: Return type mismatch for UBound and LBound on Empty and Null. - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2048

1 0

Re: [PATCH v15 0/6] MR1948: windows.media.speech: Recognition session work the second. - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1948

1 0

Re: [PATCH v2 0/6] MR2047: dinput: Keep track of input thread users using public refcounts. - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2047

1 0

Re: [PATCH v9 0/5] MR1588: Add windows.system.profile.systemmanufacturers DLL. - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

1 0

Re: [PATCH v2 0/1] MR2030: include: Add D3DKMT_ENUMADAPTERS2 structure - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2030

1 0

Re: [PATCH v3 0/2] MR2027: Add some media codec dll stubs - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2027

1 0

Re: [PATCH v6 0/6] MR1733: mshtml/jscript/vbscript: Implement SID_GetCaller and misc fixes. - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1733

1 0

Re: [PATCH v4 0/1] MR1965: d3d12/tests: Fix the expected dxgi adapter refcount check. - approved
by Alexandre Julliard (＠julliard) 27 Jan '23

27 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1965

1 0

[PATCH 0/1] MR2032: winex11: Allow replacing either context in wglShareLists.
by Alex Henrie (＠alexhenrie) 27 Jan '23

27 Jan '23

The deleted test is a bad test: The behavior is different on different drivers, for example, the test fails on the Windows 10 and 11 testbot machines that have AMD video cards. Furthermore, MSDN does not say that the destination context "must not" have any display lists yet but rather that it "should not" have any.[1] The Khronos OpenGL Wiki similarly advises against calling wglShareLists after the source or destination context has at least one object, but if you do, it only says that "there is a chance that wglShareLists will fail", not that it will necessarily fail.[2] Since there's no clear "right" behavior here, we can adopt the more permissive behavior that some programs expect, as long as it doesn't corrupt the context. [1] https://learn.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-wglsha… [2] https://www.khronos.org/opengl/wiki/Platform_specifics:_Windows#wglShareLis… Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=11436 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2032

4 4

[PATCH v3 0/1] MR2046: server: Annotate allocation functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 27 Jan '23

27 Jan '23

-- v3: server: Annotate allocation functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC). https://gitlab.winehq.org/wine/wine/-/merge_requests/2046

2 1

[PATCH v2 0/1] MR2046: server: Annotate allocation functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 27 Jan '23

27 Jan '23

-- v2: server: Annotate allocation functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC). https://gitlab.winehq.org/wine/wine/-/merge_requests/2046

4 7

[PATCH v2 0/3] MR2049: Ntdll tests
by Hans Leidekker (＠hans) 27 Jan '23

27 Jan '23

-- v2: ntdll/tests: Fix some Wow64 test failures on Windows 11. ntdll/tests: Fix path test failures on Windows 11. https://gitlab.winehq.org/wine/wine/-/merge_requests/2049

2 3

[PATCH v4 0/7] MR1844: win32u: Stub and test some pointer related syscalls.
by Rémi Bernon (＠rbernon) 27 Jan '23

27 Jan '23

Pretty much the same as https://gitlab.winehq.org/wine/wine/-/merge_requests/1843, but on win32u side, to figure and validate the syscall entry signatures. -- v4: win32u/tests: Test NtUserGetPointerInfoList syscall signature. win32u/tests: Test NtUserIsMouseInPointerEnabled syscall. win32u/tests: Test NtUserEnableMouseInPointer syscall. win32u: Stub NtUserGetPointerInfoList syscall. win32u: Stub NtUserIsMouseInPointerEnabled syscall. win32u: Move NtUserEnableMouseInPointer from user32. include: Declare some NtUser pointer related syscalls. https://gitlab.winehq.org/wine/wine/-/merge_requests/1844

4 10

[PATCH 0/2] MR2048: vbscript: Return type mismatch for UBound and LBound on Empty and Null.
by Robert Wilhelm (＠sloper42) 27 Jan '23

27 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54291 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2048

3 3

Re: [PATCH v14 0/6] MR1948: windows.media.speech: Recognition session work the second.
by Bernhard Kölbl (＠besentv) 27 Jan '23

27 Jan '23

rebased to fix the pipeline -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1948#note_22157

1 0

[PATCH 0/3] MR2049: Ntdll tests
by Hans Leidekker (＠hans) 27 Jan '23

27 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2049

3 4

[PATCH v7 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Nikolay Sivov (＠nsivov) 27 Jan '23

27 Jan '23

-- v7: d3dx9: Partially implement D3DXFillCubeTextureTX(). d3dx9: Fix ARGB texture fills with negative component values. d3dx9/tests: Add a helper to compare filled cube textures. d3dx9: Partially implement D3DXFillTextureTX(). d3dx9: Create parameter evaluator for texture shaders. d3dx9/preshader: Set input table size for texture shaders. https://gitlab.winehq.org/wine/wine/-/merge_requests/1682

3 8

[PATCH v3 0/5] MR1987: Draft: webservices/tests: Move firewall code to a common header.
by Hans Leidekker (＠hans) 27 Jan '23

27 Jan '23

-- v3: rpcrt4/tests: Use common code to set the firewall. wsdapi/tests: Use common code to set the firewall. dpnet/tests: Use common code to set the firewall. dplayx/tests: Use common code to set the firewall. webservices/tests: Move firewall code to a common header. https://gitlab.winehq.org/wine/wine/-/merge_requests/1987

3 8

[PATCH 0/1] MR2046: server: Annotate allocation functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 27 Jan '23

27 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2046

3 2

[PATCH v3 0/1] MR1965: d3d12/tests: Fix the expected dxgi adapter refcount check.
by Francois Gouget (＠fgouget) 27 Jan '23

27 Jan '23

-- v3: d3d12/tests: Don't check the refcount after releasing the dxgi adapter. https://gitlab.winehq.org/wine/wine/-/merge_requests/1965

4 5

[PATCH 0/6] MR2047: dinput: Keep track of input thread users using public refcounts.
by Rémi Bernon (＠rbernon) 27 Jan '23

27 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2047

2 6

[PATCH v13 0/6] MR1948: windows.media.speech: Recognition session work the second.
by Bernhard Kölbl (＠besentv) 27 Jan '23

27 Jan '23

First relevant commit: windows.media.speech: Add a worker thread to the recognition session. -- v13: windows.media.speech: Store recorded audio in a temporary ringbuffer. windows.media.speech: Partially implement the speech recognizer state. windows.media.speech: Add an audio capturing system. https://gitlab.winehq.org/wine/wine/-/merge_requests/1948

3 7

[PATCH v2 0/1] MR2045: d3d12core: Add stub DLL.
by Mohamad Al-Jaf (＠maljaf) 27 Jan '23

27 Jan '23

Forspoken checks for the existence of this DLL. -- v2: d3d12core: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2045

3 3

[PATCH v5 0/6] MR1733: mshtml/jscript/vbscript: Implement SID_GetCaller and misc fixes.
by Gabriel Ivăncescu (＠insn) 27 Jan '23

27 Jan '23

-- v5: vbscript: Implement SID_GetCaller for QueryService. vbscript: Add a ServiceProvider stub. jscript: Implement SID_GetCaller for QueryService. mshtml: Set SCRIPTPROP_ABBREVIATE_GLOBALNAME_RESOLUTION properly. mshtml: Defer populating the IActiveScript field until it's fully initialized. mshtml: Implement location props when there's no URI. https://gitlab.winehq.org/wine/wine/-/merge_requests/1733

4 8

[PATCH 0/1] MR2045: d3d12core: Add stub DLL.
by Mohamad Al-Jaf (＠maljaf) 27 Jan '23

27 Jan '23

Forspoken checks for the existence of this DLL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2045

3 3

Re: [PATCH v2 0/2] MR2044: ntoskrnl.exe: Implement acquiring and releasing guarded mutexes
by Etaash Mathamsetty (＠etaash.mathamsetty) 27 Jan '23

27 Jan '23

pipeline failing because of a user32 test -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2044#note_22118

1 0

[PATCH v9 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) 27 Jan '23

27 Jan '23

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v4: Don't reimplement SHBindToParent. -- v9: shell32/tests: Add SHBindToFolderIDListParent tests. shell32: Implement SHBindToFolderIDListParent. shell32: Fix error handling in SHBindToParent. shell32/tests: Test SHBindToParent last parameter behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/566

3 4

[PATCH 0/1] MR1167: wevtapi: Add EvtCreateBookmark stub.
by Mohamad Al-Jaf (＠maljaf) 27 Jan '23

27 Jan '23

The launcher of Warhammer 40,000: Darktide calls this function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1167

2 2

Re: [PATCH v2 0/1] MR2043: adsldp/test: Avoid test failures when the server is down. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2043

1 0

Re: [PATCH v10 0/3] MR1686: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _strdup, _wcsdup, _aligned_malloc - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1686

1 0

Re: [PATCH v2 0/1] MR2042: winhttp/tests: Fix test failures with the UTF-8 code page. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2042

1 0

Re: [PATCH v7 0/3] MR1918: Implement HTMLDocument_get_body and HTMLDocument_get_all for document fragments - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1918

1 0

Re: [PATCH v2 0/1] MR2040: ieframe/tests: Relax session count test. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2040

1 0

Re: [PATCH v2 0/1] MR2039: propsys: Add InitPropVariantFromStringVector(). - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2039

1 0

Re: [PATCH v3 0/3] MR2024: wbemprox: Implement Win32_Volume. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2024

1 0

Re: [PATCH v7 0/4] MR1801: secur32: schannel AcceptSecurityContext support - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1801

1 0

Re: [PATCH v4 0/1] MR1762: ktmw32: Use syscall interface for transaction objects stubs. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1762

1 0

Re: [PATCH v2 0/5] MR2031: win32u: Make more definition static or hidden. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2031

1 0

Re: [PATCH v2 0/1] MR2037: winevulkan: Update to VK spec version 1.3.240. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2037

1 0

2025

2024

2023

2022

wine-gitlab