- wine-gitlab - winehq.org

Re: [PATCH v10 0/3] MR1578: ntdll: TlsIndex should not actually contain tls indices - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1578

1 0

Re: [PATCH v2 0/1] MR1787: shell32: Handle memory allocation failure in parse_dde_command (cppcheck). - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1787

1 0

Re: [PATCH v2 0/1] MR1786: shell32: Handle memory allocation failure in Dde_OnRequest (cppcheck). - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1786

1 0

Re: [PATCH v3 0/1] MR1997: comctl32/header: Do not touch 'hwnd' field in HDM_LAYOUT. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1997

1 0

Re: [PATCH v2 0/1] MR2035: winebuild: Reorder the includes to avoid a build error on macOS. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2035

1 0

Re: [PATCH v2 0/5] MR2034: dinput: Introduce internal recounts. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2034

1 0

Re: [PATCH v2 0/1] MR2023: dplayx/tests: Skip tests when the dll is missing. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2023

1 0

Re: [PATCH v2 0/1] MR73: include: Fix incorrect UpdateTileMappings declaration. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/73

1 0

Re: [PATCH v3 0/5] MR72: vkd3d-shader/hlsl: Implement exp()/exp2() intrinsics. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/72

1 0

[PATCH v4 0/5] MR70: vkd3d-shader/hlsl: Make single-component swizzles retrieve a scalar and add more swizzle tests.
by Francisco Casas (＠fcasas) 26 Jan '23

26 Jan '23

Vectors cannot be used as array indexes, however, single-component swizzles (such as vec.x) can be used. This suggests that single-component swizzles should actually be scalars and not vectors of dimx = 1. It is worth noting that the use of swizzles on scalars should still be allowed. -- v4: vkd3d-shader/hlsl: Make single-component swizzles retrieve a scalar. tests: Add tests for assignments to self with swizzles. tests: Test swizzles on scalar values. tests: Test using single-component swizzles as indexes. tests: Combine all the swizzle tests in a single file. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/70

3 6

Re: [PATCH v10 0/2] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation. - approved
by Alexandre Julliard (＠julliard) 26 Jan '23

26 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

1 0

[PATCH v9 0/1] MR1444: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW
by James McDonnell (＠ElementalWarrior) 26 Jan '23

26 Jan '23

Call MoveFileWithProgress from MoveFileTransacted such that the stub functions. This enables saving for Affinity Photo. -- v9: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW. https://gitlab.winehq.org/wine/wine/-/merge_requests/1444

3 2

[PATCH v8 0/1] MR1444: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW
by James McDonnell (＠ElementalWarrior) 26 Jan '23

26 Jan '23

Call MoveFileWithProgress from MoveFileTransacted such that the stub functions. This enables saving for Affinity Photo. -- v8: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW https://gitlab.winehq.org/wine/wine/-/merge_requests/1444

2 1

Re: [PATCH v7 0/1] MR1444: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW
by Etaash Mathamsetty (＠etaash.mathamsetty) 26 Jan '23

26 Jan '23

Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/kernel32/path.c: > */ > BOOL WINAPI MoveFileTransactedW(const WCHAR *source, const WCHAR *dest, LPPROGRESS_ROUTINE progress, void *data, DWORD flags, HANDLE handle) > { > - FIXME("(%s, %s, %p, %p, %ld, %p)\n", debugstr_w(source), debugstr_w(dest), progress, data, flags, handle); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + TRACE("(%s, %s, %p, %p, %ld, %p)\n", debugstr_w(source), debugstr_w(dest), progress, data, flags, handle); > + if (handle) { the transaction parameter isn't optional, so I would just print a FIXME saying that this is a semi-stub instead -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1444#note_22057

1 0

[PATCH 0/1] MR2035: winebuild: Reorder the includes to avoid a build error on macOS.
by Huw Davies (＠huw) 26 Jan '23

26 Jan '23

"build.h" eventually includes <sys/queue.h> which contains a conflicting definition of LIST_INIT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2035

3 2

[PATCH 0/1] MR2043: adsldp/test: Avoid test failures when the server is down.
by Hans Leidekker (＠hans) 26 Jan '23

26 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2043

2 1

[PATCH 0/1] MR73: include: Fix incorrect UpdateTileMappings declaration.
by Zebediah Figura (＠zfigura) 26 Jan '23

26 Jan '23

Signed-off-by: Philip Rebohle <philip.rebohle(a)tu-dortmund.de> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/73

3 3

[PATCH v2 0/5] MR72: vkd3d-shader/hlsl: Implement exp()/exp2() intrinsics.
by Nikolay Sivov (＠nsivov) 26 Jan '23

26 Jan '23

-- v2: vkd3d-shader/tests: Add some exp()/exp2() tests. vkd3d-shader/hlsl: Support exp() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/72

4 7

Re: [PATCH v3 0/5] MR70: vkd3d-shader/hlsl: Make single-component swizzles retrieve a scalar and add more swizzle tests. - approved
by Henri Verbeet (＠hverbeet) 26 Jan '23

26 Jan '23

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/70

1 0

Re: [PATCH v9 0/2] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation. - approved
by Henri Verbeet (＠hverbeet) 26 Jan '23

26 Jan '23

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

1 0

[PATCH v4 0/3] MR65: hlsl: More function-related tests.
by Zebediah Figura (＠zfigura) 26 Jan '23

26 Jan '23

-- v4: tests: Test entry point semantics on function declarations. tests: Add more tests for early return from the entry point. tests: Add some tests for early return from user-defined functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/65

2 4

Re: [PATCH v3 0/5] MR70: vkd3d-shader/hlsl: Make single-component swizzles retrieve a scalar and add more swizzle tests. - approved
by Zebediah Figura (＠zfigura) 26 Jan '23

26 Jan '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/70

1 0

Re: [PATCH v9 0/2] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation. - approved
by Zebediah Figura (＠zfigura) 26 Jan '23

26 Jan '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

1 0

Re: [PATCH v9 0/2] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation.
by Zebediah Figura (＠zfigura) 26 Jan '23

26 Jan '23

> :arrow_up: Added explanatory comment. Does it look good? Yes, looks great :-) -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59#note_22039

1 0

[PATCH v2 0/5] MR1987: Draft: webservices/tests: Move firewall code to a common header.
by Hans Leidekker (＠hans) 26 Jan '23

26 Jan '23

-- v2: rpcrt4/tests: Use common code to set the firewall. wsdapi/tests: Use common code to set the firewall. dpnet/tests: Use common code to set the firewall. dplayx/tests: Use common code to set the firewall. webservices/tests: Move firewall code to a common header. https://gitlab.winehq.org/wine/wine/-/merge_requests/1987

5 13

[PATCH v3 0/7] MR1844: win32u: Stub and test some pointer related syscalls.
by Rémi Bernon (＠rbernon) 26 Jan '23

26 Jan '23

Pretty much the same as https://gitlab.winehq.org/wine/wine/-/merge_requests/1843, but on win32u side, to figure and validate the syscall entry signatures. -- v3: win32u/tests: Test NtUserGetPointerInfoList syscall signature. win32u/tests: Test NtUserIsMouseInPointerEnabled syscall. win32u/tests: Test NtUserEnableMouseInPointer syscall. win32u: Stub NtUserGetPointerInfoList syscall. win32u: Stub NtUserIsMouseInPointerEnabled syscall. win32u: Move NtUserEnableMouseInPointer from user32. include: Declare some NtUser pointer related syscalls. https://gitlab.winehq.org/wine/wine/-/merge_requests/1844

3 8

[PATCH v12 0/6] MR1948: windows.media.speech: Recognition session work the second.
by Bernhard Kölbl (＠besentv) 26 Jan '23

26 Jan '23

First relevant commit: windows.media.speech: Add a worker thread to the recognition session. -- v12: windows.media.speech: Store recorded audio in a temporary ringbuffer. windows.media.speech: Partially implement the speech recognizer state. windows.media.speech: Add an audio capturing system. windows.media.speech: Allow the recognition session worker to be paused. windows.media.speech/tests: Check if stopping the session resets the paused state. windows.media.speech: Add a worker thread to the recognition session. https://gitlab.winehq.org/wine/wine/-/merge_requests/1948

4 9

[PATCH 0/5] MR72: vkd3d-shader/hlsl: Implement exp()/exp2() intrinsics.
by Nikolay Sivov (＠nsivov) 26 Jan '23

26 Jan '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/72

3 7

[PATCH v6 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Nikolay Sivov (＠nsivov) 26 Jan '23

26 Jan '23

-- v6: d3dx9: Partially implement D3DXFillCubeTextureTX(). d3dx9: Fix ARGB texture fills with negative component values. d3dx9/tests: Add a helper to compare filled cube textures. d3dx9: Partially implement D3DXFillTextureTX(). d3dx9: Create parameter evaluator for texture shaders. d3dx9/preshader: Set input table size for texture shaders. https://gitlab.winehq.org/wine/wine/-/merge_requests/1682

3 8

[PATCH v3 0/3] MR65: hlsl: More function-related tests.
by Zebediah Figura (＠zfigura) 26 Jan '23

26 Jan '23

-- v3: tests: Test entry point semantics on function declarations. tests: Add more tests for early return from the entry point. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/65

5 8

[PATCH 0/1] MR2042: winhttp/tests: Fix test failures with the UTF-8 code page.
by Hans Leidekker (＠hans) 26 Jan '23

26 Jan '23

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=52936 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2042

2 1

[PATCH v2 0/2] MR2027: Add some media codec dll stubs
by Paul Gofman (＠gofman) 26 Jan '23

26 Jan '23

Gungrave G.O.R.E checks for the presence of these dlls before doing anything with MF. -- v2: msauddecmft: Add stub dll. msmpeg2vdec: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/2027

3 5

[PATCH v2 0/4] MR2036: comctl32: Always use unicode messages for subclass procedures.
by Rémi Bernon (＠rbernon) 26 Jan '23

26 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=43073 -- v2: comctl32: Skip restoring window proc if it has been modified. comctl32: Always use unicode messages for subclass procedures. comctl32: Save unicode window nature on SetWindowSubclass call. comctl32/tests: Test unicode nature of window subclasses. https://gitlab.winehq.org/wine/wine/-/merge_requests/2036

3 6

Re: [PATCH v9 0/3] MR1686: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _strdup, _wcsdup, _aligned_malloc - approved
by Piotr Caban (＠piotr) 26 Jan '23

26 Jan '23

This merge request was approved by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1686

1 0

[PATCH v4 0/5] MR1733: mshtml/jscript/vbscript: Implement SID_GetCaller and misc fixes.
by Gabriel Ivăncescu (＠insn) 26 Jan '23

26 Jan '23

-- v4: vbscript: Implement SID_GetCaller for QueryService. vbscript: Add a ServiceProvider stub. jscript: Implement SID_GetCaller for QueryService. mshtml: Set SCRIPTPROP_ABBREVIATE_GLOBALNAME_RESOLUTION properly. mshtml: Implement location props when there's no URI. https://gitlab.winehq.org/wine/wine/-/merge_requests/1733

3 7

[PATCH 0/1] MR2041: gdiplus: Correctly handle new lines.
by David Kahurani (＠kahurani) 26 Jan '23

26 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45698 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2041

3 2

[PATCH 0/1] MR993: ieframe/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 26 Jan '23

26 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/993

3 4

[PATCH 0/1] MR2040: ieframe/tests: Relax session count test.
by Jacek Caban (＠jacek) 26 Jan '23

26 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2040

2 1

[PATCH v6 0/3] MR1918: Draft: Implement HTMLDocument_get_body and HTMLDocument_get_all for document fragments
by Santino Mazza (＠tati1454) 26 Jan '23

26 Jan '23

This functions should also work with document fragments, in wine they only return NULL. -- v6: mshtml: Implement HTMLDocument_get_body for document fragments. mshtml: Use This->node for HTMLDocument_get_all. mshtml/tests: Test for get_all and get_body in document fragments. https://gitlab.winehq.org/wine/wine/-/merge_requests/1918

3 5

[PATCH 0/1] MR2039: propsys: Add InitPropVariantFromStringVector().
by Nikolay Sivov (＠nsivov) 26 Jan '23

26 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2039

3 2

[PATCH v11 0/6] MR1948: windows.media.speech: Recognition session work the second.
by Bernhard Kölbl (＠besentv) 26 Jan '23

26 Jan '23

First relevant commit: windows.media.speech: Add a worker thread to the recognition session. -- v11: windows.media.speech: Store recorded audio in a temporary ringbuffer. windows.media.speech: Partially implement the speech recognizer state. windows.media.speech: Add an audio capturing system. windows.media.speech: Allow the recognition session worker to be paused. windows.media.speech/tests: Check if stopping the session resets the paused state. windows.media.speech: Add a worker thread to the recognition session. https://gitlab.winehq.org/wine/wine/-/merge_requests/1948

4 11

[PATCH v2 0/7] MR1844: win32u: Stub and test some pointer related syscalls.
by Rémi Bernon (＠rbernon) 26 Jan '23

26 Jan '23

Pretty much the same as https://gitlab.winehq.org/wine/wine/-/merge_requests/1843, but on win32u side, to figure and validate the syscall entry signatures. -- v2: win32u/tests: Test NtUserGetPointerInfoList syscall signature. win32u/tests: Test NtUserIsMouseInPointerEnabled syscall. win32u/tests: Test NtUserEnableMouseInPointer syscall. win32u: Stub NtUserGetPointerInfoList syscall. win32u: Stub NtUserIsMouseInPointerEnabled syscall. win32u: Move NtUserEnableMouseInPointer from user32. include: Declare some NtUser pointer related syscalls. https://gitlab.winehq.org/wine/wine/-/merge_requests/1844

2 8

Re: [PATCH v3 0/5] MR70: vkd3d-shader/hlsl: Make single-component swizzles retrieve a scalar and add more swizzle tests. - approved
by Giovanni Mascellani (＠giomasce) 26 Jan '23

26 Jan '23

This merge request was approved by Giovanni Mascellani. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/70

1 0

[PATCH v2 0/3] MR2024: wbemprox: Implement Win32_Volume.
by Hans Leidekker (＠hans) 26 Jan '23

26 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54030 -- v2: wbemprox: Remove reg_ prefix from static functions. wbemprox: Implement GetBinaryValue() method. wbemprox: Implement Win32_Volume. https://gitlab.winehq.org/wine/wine/-/merge_requests/2024

3 5

Re: [PATCH v6 0/4] MR1801: secur32: schannel AcceptSecurityContext support - approved
by Hans Leidekker (＠hans) 26 Jan '23

26 Jan '23

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1801

1 0

[PATCH 0/2] MR2036: comctl32: Always use unicode messages for subclass procedures.
by Rémi Bernon (＠rbernon) 26 Jan '23

26 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=43073 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2036

3 4

Re: [PATCH v9 0/2] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation. - approved
by Giovanni Mascellani (＠giomasce) 26 Jan '23

26 Jan '23

This merge request was approved by Giovanni Mascellani. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

1 0

Re: [PATCH v9 0/2] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation.
by Giovanni Mascellani (＠giomasce) 26 Jan '23

26 Jan '23

On Wed Jan 25 16:39:04 2023 +0000, Francisco Casas wrote: > I don't think the problem is currently happening with regular > stores/loads, because when we do a replacement, we are removing the > whole instruction (and replacing all subsequent references to it), so > there is not the possibility of copy-prop doing an incorrect replacement > for the instruction being replaced a second time. > Writing directly > ``` > a = b; > b = c; > d = a; > ``` > could be misleading, since on regular stores what we have on the rhs is > an hlsl_src, a reference to another node, so it would be more accurate > to write it as: > ``` > 1 : load (b) > 2 : a = @1; > 3 : load (c) > 4 : b = @3; > 5 : load (a) > 6 : d = @5; > ``` > which would be transformed to > ``` > 1 : load (b) > 2 : a = @1; > 3 : load (c) > 4 : b = @3; > 5 : <deleted> > 6 : d = @1; > ``` Yes, you're right, I got confused. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59#note_21971

1 0

Re: [PATCH v2 0/1] MR1997: comctl32/header: Do not touch 'hwnd' field in HDM_LAYOUT.
by Nikolay Sivov (＠nsivov) 26 Jan '23

26 Jan '23

I have to point out that this issue was reported on #winehackers, presumably it was spotted while using listview.c code without the rest of wine's comctl32. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1997#note_21967

1 0

[PATCH 0/1] MR1855: makedep: Make output_filename more resilient
by Gerald Pfeifer (＠gerald) 26 Jan '23

26 Jan '23

In early November 2022 builds on FreeBSD 12/amd64 saw makedep core dump 1791 times due to it being invoked with a NULL pointer. Turns out it did not validate its input for being non-NULL, so add such a check and add a diagnostics. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1855

3 3

[PATCH 0/5] MR2031: win32u: Make more definition static or hidden.
by Zebediah Figura (＠zfigura) 26 Jan '23

26 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2031

3 6

[PATCH 0/1] MR2037: winevulkan: Update to VK spec version 1.3.240.
by Georg Lehmann (＠DadSchoorse) 26 Jan '23

26 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2037

2 1

[PATCH 0/2] MR2027: Add some media codec dll stubs
by Paul Gofman (＠gofman) 26 Jan '23

26 Jan '23

Gungrave G.O.R.E checks for the presence of these dlls before doing anything with MF. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2027

6 11

Re: [PATCH v2 0/1] MR1997: comctl32/header: Do not touch 'hwnd' field in HDM_LAYOUT. - approved
by Zhiyi Zhang (＠zhiyi) 26 Jan '23

26 Jan '23

This merge request was approved by Zhiyi Zhang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1997

1 0

[PATCH 0/5] MR2034: dinput: Introduce internal recounts.
by Rémi Bernon (＠rbernon) 26 Jan '23

26 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2034

2 5

[PATCH 0/1] MR2029: dmime: Store WAVE data when Loading.
by Alistair Leslie-Hughes (＠alesliehughes) 26 Jan '23

26 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029

3 2

[PATCH 0/1] MR2030: include: Add D3DKMT_ENUMADAPTERS2 structure
by Alistair Leslie-Hughes (＠alesliehughes) 26 Jan '23

26 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2030

2 1

[PATCH v10 0/1] MR1989: wininet: Allow UTC as a timezone.
by Etaash Mathamsetty (＠etaash.mathamsetty) 25 Jan '23

25 Jan '23

this should fix ubisoft connect outputting unknown timezone UTC in logs -- v10: https://gitlab.winehq.org/wine/wine/-/merge_requests/1989

2 1

Re: [PATCH v9 0/1] MR1989: wininet: Allow UTC as a timezone.
by Etaash Mathamsetty (＠etaash.mathamsetty) 25 Jan '23

25 Jan '23

seems like I got the wrong test again, and I don't know what to add tests to, so I will just remove them for now -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1989#note_21940

1 0

Re: [PATCH v2 0/4] MR65: hlsl: More function-related tests.
by Zebediah Figura (＠zfigura) 25 Jan '23

25 Jan '23

On Wed Jan 25 21:29:22 2023 +0000, Francisco Casas wrote: > Actually it seems that the chosen function depends on the version of the compiler! > fxc 9.29.952.3111 (`d3d_compiler43.dll`) seems to load the first > `main()`, while fxc 10.1 (`d3d_compiler47.dll`) seems to load the > second, at least for me. Indeed. Nice. Some further testing implies that 43 always picks the first function, and 47 always picks the last, i.e. the arguments don't matter. (Side note, that version number seems to come from the d3dcompiler dll, not fxc. At least, I get the same version number in native disassembly.) 46 behaves like 47. I think this is the first difference in behaviour we've found that we're actually going to want to put effort into emulating. We'll have to figure out a way to deal with it in the tests... -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/65#note_21934

1 0

Re: [PATCH v2 0/4] MR65: hlsl: More function-related tests.
by Francisco Casas (＠fcasas) 25 Jan '23

25 Jan '23

I think that the patch series is fine except for my two comments. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/65#note_21933

1 0

Re: [PATCH v2 0/1] MR64: hlsl: Write SM4 thread ID registers. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/64

1 0

Re: [PATCH v5 0/2] MR58: vkd3d-shader/hlsl: Reinterpret minimum precision types as their regular counterparts. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/58

1 0

Re: [PATCH v2 0/2] MR69: vkd3d-shader/hlsl: Add sqrt() support for SM1. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/69

1 0

Re: [PATCH v4 0/1] MR68: vkd3d-shader/hlsl: Support frac() intrinsic. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/68

1 0

Re: [PATCH v4 0/1] MR67: vkd3d: Store a struct d3d12_descriptor_heap pointer in each CBV/SRV/UAV descriptor. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/67

1 0

[PATCH 0/4] MR65: hlsl: More function-related tests.
by Zebediah Figura (＠zfigura) 25 Jan '23

25 Jan '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/65

3 6

Re: [PATCH v2 0/1] MR2026: ws2_32/test: Fix sockaddr buffer overflow in test_reuseaddr. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2026

1 0

Re: [PATCH v2 0/9] MR2021: include: Add more WinRT generic collections definitions. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2021

1 0

Re: [PATCH v2 0/5] MR2020: dinput: Some cleanup before fixing its background thread. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2020

1 0

Re: [PATCH v2 0/2] MR2022: oledb32: Heap corruption fixes. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2022

1 0

Re: [PATCH v2 0/1] MR2025: advapi32: Bump random buffer size. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2025

1 0

Re: [PATCH v3 0/3] MR2009: cryptnet: Also hash issuer cert for cache id. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2009

1 0

Re: [PATCH v2 0/3] MR1972: include: Add ctime_s and localtime_s. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1972

1 0

Re: [PATCH v2 0/5] MR2014: win32u: Make some symbols static or hidden. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2014

1 0

Re: [PATCH v2 0/5] MR2019: windows.gaming.input: Misc fixes for force feedback direction. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2019

1 0

Re: [PATCH v2 0/1] MR2018: include: Add _XHR enum values - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2018

1 0

Re: [PATCH v2 0/1] MR2013: ntdll: Use MemAvailable field for free RAM estimation if available. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2013

1 0

Re: [PATCH v3 0/4] MR1877: user32: Clipboard overflow and underflow fixes - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1877

1 0

Re: [PATCH v2 0/2] MR1867: Better handle ctrl-\ and ctrl-break in conhost.exe. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1867

1 0

Re: [PATCH v2 0/2] MR1798: Don't redefine typedefs - Initial work for gcc 4.3 support - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1798

1 0

Re: [PATCH v2 0/1] MR1781: inetcomm: Fix memory leak on realloc failure in copy_headers_to_buf (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1781

1 0

Re: [PATCH v2 0/1] MR1780: hhctrl: Handle memory allocation failure in SearchCHM_File (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1780

1 0

Re: [PATCH v2 0/1] MR1779: hhctrl: Handle memory allocation failure in ReadChmSystem (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1779

1 0

Re: [PATCH v2 0/1] MR1777: dbghelp: Handle memory allocation failure in image_locate_build_id_target (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1777

1 0

Re: [PATCH v2 0/1] MR1788: twain_32: Handle realloc failure in twain_add_onedriver (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1788

1 0

Re: [PATCH v2 0/2] MR1795: wldap32: Free resource in error case and return error code (Coverity) - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1795

1 0

Re: [PATCH v2 0/1] MR1782: mshtml: Handle memory allocation failure in set_statustext. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1782

1 0

Re: [PATCH v2 0/1] MR1785: msi: Fix memory leak on realloc failure in search_directory (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1785

1 0

Re: [PATCH v2 0/1] MR1784: msi: Fix memory leak on realloc failure in msi_get_window_text (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1784

1 0

Re: [PATCH v2 0/1] MR1783: msi: Fix memory leak on realloc failure in create_diff_row_query (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1783

1 0

Re: [PATCH v2 0/1] MR1790: winspool: Improve the grammar of a comment in get_servername_from_name. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1790

1 0

[PATCH v2 0/1] MR1255: gitlab: Run win64 tests instead of wow64.
by Rémi Bernon (＠rbernon) 25 Jan '23

25 Jan '23

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1241. -- v2: gitlab: Run dinput 64-bit tests in a dedicated job. https://gitlab.winehq.org/wine/wine/-/merge_requests/1255

4 8

[PATCH v8 0/5] MR1588: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) 25 Jan '23

25 Jan '23

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number or at least something like "Not Specified" and not NULL. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- v8: windows.system.profile.systemmanufacturers: Implement ISmbiosInformationStatics_get_SerialNumber. windows.system.profile.systemmanufacturers/tests: Add ISmbiosInformationStatics_get_SerialNumber tests. windows.system.profile.systemmanufacturers: Stub ISmbiosInformationStatics interface. windows.system.profile.systemmanufacturers: Add stub DLL. include: Add windows.system.profile.systemmanufacturers.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

3 7

[PATCH 0/1] MR2023: dplayx/tests: Skip tests when the dll is missing.
by Hans Leidekker (＠hans) 25 Jan '23

25 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2023

3 2

Re: [PATCH v3 0/5] MR2010: wined3d: More Vulkan feature checks.
by Zebediah Figura (＠zfigura) 25 Jan '23

25 Jan '23

On Wed Jan 25 20:25:14 2023 +0000, Zebediah Figura wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/2010/diffs?diff_id=29048&start_sha=8eae0afb08c6e06634aa471605d9f9800d3144c8#0e3bdc3483a2521905df15e2af3431db3ab47a56_2279_2278) Wow, okay, thank you SPIR-V for the excellent choices in naming. Sent a v3 with this changed to 11.0, thanks :-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2010#note_21856

1 0

[PATCH v2 0/5] MR2010: wined3d: More Vulkan feature checks.
by Zebediah Figura (＠zfigura) 25 Jan '23

25 Jan '23

-- v2: wined3d: Disable 64-bit integer support. wined3d: Require shader cull distance support to create a feature level 10.0 device. wined3d: Require shader clip distance support to create a feature level 10.0 device. wined3d: Require gather offset support to create a feature level 10.1 device. wined3d: Require fragment shader image stores and atomics to create a feature level 10.0 device. https://gitlab.winehq.org/wine/wine/-/merge_requests/2010

3 6

[PATCH 0/5] MR2010: wined3d: More Vulkan feature checks.
by Zebediah Figura (＠zfigura) 25 Jan '23

25 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2010

5 10

[PATCH v7 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 25 Jan '23

25 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v7: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

3 13

[PATCH v2 0/6] MR1964: dxgi: Catch nested SetFullscreenState invocations.
by Stefan Dösinger (＠stefan) 25 Jan '23

25 Jan '23

FFXIV depends on this. It calls SetFullscreenState when it receives WM_WINDOWPOSCHANGED. Through luck the recursion aborts after two calls. The user-visible bug is that after leaving fullscreen, the game's window is still TOPMOST because we overwrite the stored pre-fullscreen window flags. -- v2: dxgi/tests: Test nested SetFullscreenState from the same thread. dxgi/tests: Test nested fullscreen application from different thread. dxgi: Catch nested SetFullscreenState invocations. dxgi/tests: Run test_swapchain_window_messages on d3d12. dxgi/tests: Run test_resize_target_wndproc on d3d12 too. dxgi/tests: Fix UnregisterClass call in test_resize_target_wndproc. https://gitlab.winehq.org/wine/wine/-/merge_requests/1964

5 10