- wine-gitlab - winehq.org

[PATCH v5 0/1] MR1771: ntoskrnl.exe: Fake Success for MmMapIoSpace.
by Etaash Mathamsetty (＠etaash.mathamsetty) 09 Jan '23

09 Jan '23

originally created by Guy1524 -- v5: ntoskrnl.exe: Fake Success for MmMapIoSpace. https://gitlab.winehq.org/wine/wine/-/merge_requests/1771

2 1

[PATCH v3 0/4] MR1886: Fixing paste errors on edit control in Win10+.
by eric pouech (＠epo) 09 Jan '23

09 Jan '23

This series tries to fix WM_PASTE tests error on edit control (both user32 & comctl32). The test failures where systematic on a local Win10 for comctl32 (yet very rare on user32, perhaps one in 20 runs). Since the failures are not systematic, it ought to be a synchronisation / timing issue. Flushing the msg queue before starting the paste test cycle seems to fix the issue. - 0 occurence on comctl32 and user32 in 50 run (local VM) - 0 occurence on Testbot (comctl32) in 1 run. It's hard to be fully conclusive about bug resolution, but it's at least a step into the right direction. -- v3: comctl32/tests: Fix failing WM_PASTE tests for edit control on Win10+. comctl32/tests: Retry when opening the clipboard. user32/tests: Fix failing WM_PASTE tests for edit control on Win10+. user32/tests: Retry when opening the clipboard. https://gitlab.winehq.org/wine/wine/-/merge_requests/1886

3 9

[PATCH v6 0/1] MR1892: ntoskrnl.exe/tests: Add Driver Object Extension Tests.
by Etaash Mathamsetty (＠etaash.mathamsetty) 08 Jan '23

08 Jan '23

-- v6: ntoskrnl.exe/tests: Add Driver Object Extension Tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1892

2 1

[PATCH v5 0/1] MR1892: ntoskrnl.exe/tests: Add Driver Object Extension Tests.
by Etaash Mathamsetty (＠etaash.mathamsetty) 08 Jan '23

08 Jan '23

-- v5: ntoskrnl.exe/tests: Add Driver Object Extension Tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1892

3 3

[PATCH 0/1] MR1923: faudio: Purge and clear notifcations on ShutDown
by Alistair Leslie-Hughes (＠alesliehughes) 08 Jan '23

08 Jan '23

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=54264 cherry-picked upstraem 16f86bffec36b6e82e5c93d5f04ebc4ee4f980ab. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1923

2 1

[PATCH v10 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 08 Jan '23

08 Jan '23

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - ~~first crumb is always moved here~~ - removes the split, if there are no items in the menu - hidden crumbs are moved here - left ~~or right~~ click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v10: comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

4 12

[PATCH v3 0/1] MR1444: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW
by James McDonnell (＠ElementalWarrior) 08 Jan '23

08 Jan '23

Call MoveFileWithProgress from MoveFileTransacted such that the stub functions. This enables saving for Affinity Photo. -- v3: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW https://gitlab.winehq.org/wine/wine/-/merge_requests/1444

4 4

[PATCH v4 0/1] MR1892: ntoskrnl.exe/tests: Add Driver Object Extension Tests.
by Etaash Mathamsetty (＠etaash.mathamsetty) 08 Jan '23

08 Jan '23

-- v4: ntoskrnl.exe/tests: Add Driver Object Extension Tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1892

3 2

[PATCH 0/1] MR1239: winegstreamer: Pause streaming threads when seeking.
by Zhiyi Zhang (＠zhiyi) 08 Jan '23

08 Jan '23

The streaming threads and GST_Seeking_SetPositions() contend for the same flushing locks. GST_Seeking_SetPositions() needs to acquire all the flushing locks before doing the actual stream seeking, having the streaming threads fighting for the same locks will make GST_Seeking_SetPositions() wait for a unusually long time. This reduces PowerPoint 2016 video seeking time from ~5s to almost an instant and fixes a regression for Fallout 3. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53403 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1239

4 6

[PATCH v10 0/8] MR729: windows.media.speech: Initial recognition session work.
by Bernhard Kölbl (＠besentv) 06 Jan '23

06 Jan '23

-- v10: windows.media.speech: Allow the recognition session worker to be paused. windows.media.speech: Add a worker thread to the recognition session. https://gitlab.winehq.org/wine/wine/-/merge_requests/729

4 22

Re: [PATCH v2 0/2] MR1916: msvcirt: Fixes for streambuf::xsputn and ostream::opearator<< - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1916

1 0

Re: [PATCH v7 0/1] MR1908: msi: pSignatureSettings uninitialized - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908

1 0

Re: [PATCH v2 0/1] MR1909: comctl32/tests: Ignore some IME messages in monthcal tests. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1909

1 0

Re: [PATCH v2 0/1] MR1910: include: Add missing enum XHR_PROP_ values - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1910

1 0

Re: [PATCH v2 0/1] MR1911: xactengine3_7/tests: Skip tests when XACTEngine Initialization fails - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1911

1 0

Re: [PATCH v4 0/1] MR1878: comctl32/listview: Exclude header area in WM_NCPAINT. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1878

1 0

Re: [PATCH v2 0/1] MR1902: d2d1/tests: Fix memory leaks. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1902

1 0

Re: [PATCH v4 0/1] MR1884: d3d8: Filter out redundant buffer discards. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1884

1 0

Re: [PATCH v3 0/2] MR1880: mfplat/tests: Test MFGetStrideForBitmapInfoHeader for NV11. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1880

1 0

Re: [PATCH v2 0/3] MR1904: winegstreamer: Explicitly sleep in the streaming thread when flushing. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1904

1 0

Re: [PATCH v3 0/5] MR1901: dinput/tests: Add more W.G.I effect direction tests. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1901

1 0

Re: [PATCH v2 0/3] MR1891: Don't test functions directly when reporting GetLastError() - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1891

1 0

Re: [PATCH v2 0/1] MR1890: po: Update Dutch translation. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1890

1 0

Re: [PATCH v3 0/1] MR1881: comctl32/test: Adapt the edit tests for height to Win10+. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1881

1 0

Re: [PATCH v2 0/1] MR1882: comctl32/tests: Fix failing test on Windows in Arabic UTF-8. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1882

1 0

Re: [PATCH v4 0/3] MR1887: dinput: Return WHEEL_DELTA for the granularity of the mouse z-axis. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1887

1 0

Re: [PATCH v2 0/2] MR1875: regedit.exe redraw fixes - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1875

1 0

Re: [PATCH v2 0/1] MR1864: wined3d: Ignore DISCARD and NOOVERWRITE on buffers which are not GPU-accessible. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1864

1 0

Re: [PATCH v4 0/3] MR1865: wined3d: Load and invalidate every mipmap level when mapping the top mipmap level. - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1865

1 0

Re: [PATCH v2 0/1] MR1863: d3d11/tests: Do not test deferred contexts in test_dynamic_map_synchronization(). - approved
by Alexandre Julliard (＠julliard) 06 Jan '23

06 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1863

1 0

[PATCH v3 0/3] MR1918: Draft: Implement HTMLDocument_get_body and HTMLDocument_get_all for document fragments
by Santino Mazza (＠tati1454) 06 Jan '23

06 Jan '23

This functions should also work with document fragments, in wine they only return NULL. -- v3: mshtml: Implement HTMLDocument_get_body for document fragments. https://gitlab.winehq.org/wine/wine/-/merge_requests/1918

3 6

[PATCH v2 0/3] MR1918: Implement HTMLDocument_get_body and HTMLDocument_get_all for document fragments
by Santino Mazza (＠tati1454) 06 Jan '23

06 Jan '23

This functions should also work with document fragments, in wine they only return NULL. -- v2: mshtml: Implement HTMLDocument_get_body for document fragments. https://gitlab.winehq.org/wine/wine/-/merge_requests/1918

4 8

[PATCH 0/3] MR1918: Implement HTMLDocument_get_body and HTMLDocument_get_all for document fragments
by Santino Mazza (＠tati1454) 06 Jan '23

06 Jan '23

This functions should also work with document fragments, in wine they only return NULL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1918

3 5

[PATCH 0/2] MR1921: include: Add stdarg.h header.
by Jacek Caban (＠jacek) 06 Jan '23

06 Jan '23

stdarg.h is usually shipped with the compiler itself and that's what we currently use for non-mingw builds (including clang MSVC builds). This mostly works fine for us, but (in addition to GCC/clang), mingw-w64 also ships this header. This may be problematic in some cases, because it pulls _mingw.h, which may define things like _UCRT. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54263 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1921

2 2

[PATCH 0/1] MR1917: [PATCH] shell32/tests: Workaround moving cursor to (0,0) coordinates.
by Gabriel Ivăncescu (＠insn) 05 Jan '23

05 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1917

3 2

[PATCH v9 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 05 Jan '23

05 Jan '23

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - ~~first crumb is always moved here~~ - removes the split, if there are no items in the menu - hidden crumbs are moved here - left ~~or right~~ click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v9: comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

4 13

[PATCH v2 0/1] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation.
by Francisco Casas (＠fcasas) 05 Jan '23

05 Jan '23

copy_propagation_transform_object_load() currently retrieves true, which indicates that there was progress, even if the input dereference remains the same. This can happen repeatedly if an uninitialized object is copied onto itself, as in the tests added in this patch. This results on the compilation getting stuck on an endless loop. This patch checks if the deref didn't change, to retrieve false in that case. -- v2: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

4 7

[PATCH 0/2] MR1916: msvcirt: Fixes for streambuf::xsputn and ostream::opearator<<
by Piotr Caban (＠piotr) 05 Jan '23

05 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54180 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1916

2 2

[PATCH 0/1] MR1914: winex11: Simplify confusing condition and error messages in wglShareLists.
by Alex Henrie (＠alexhenrie) 05 Jan '23

05 Jan '23

Mathematically, ((a && b) || b) == b. Moreover, test_sharelists in dlls/opengl32/tests/opengl.c checks that wglShareLists can share lists from a source context that has been current. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1914

2 1

[PATCH v2 0/2] MR58: vkd3d-shader/hlsl: Reinterpret minimum precision types as their regular counterparts.
by Francisco Casas (＠fcasas) 05 Jan '23

05 Jan '23

Reinterpret min16float, min10float, min16int, min12int, and min16uint as their regular counterparts: float, float, int, int, uint, respectively. A proper implementation would require adding minimum precision indicators to all the dxbc-tpf instructions that use these types. Consider the output of fxc 10.1 with the following shader: ```hlsl uniform int i; float4 main() : sv_target { min16float4 a = {0, 1, 2, i}; min16int2 b = {4, i}; min10float3 c = {6.4, 7, i}; min12int d = 9.4; min16uint4x2 e = {14.4, 15, 16, 17, 18, 19, 20, i}; return mul(e, b) + a + c.xyzx + d; } ``` ``` ps_5_0 dcl_globalFlags refactoringAllowed | enableMinimumPrecision dcl_constantbuffer CB0[1], immediateIndexed dcl_output o0.xyzw dcl_temps 3 imad r0.xyz {min16u}, l(15, 17, 19, 0) {def32 as min16u}, cb0[0].xxxx {def32 as min16u}, l(56, 64, 72, 0) {def32 as min16u} utof r0.xyz {min16f}, r0.xyzx {min16u} imad r1.x {min16u}, cb0[0].x {def32 as min16u}, cb0[0].x {def32 as min16u}, l(80) {def32 as min16u} utof r0.w {min16f}, r1.x {min16u} mov r1.xyz {min16f}, l(0,1.000000,2.000000,0) {def32 as min16f} itof r1.w {min16f}, cb0[0].x add r0.xyzw {min16f}, r0.xyzw {min16f}, r1.xyzw {min16f} mov r2.y {min2_8f}, l(7.000000) {def32 as min2_8f} itof r2.z {min2_8f}, cb0[0].x add r0.yz {min16f}, r0.yyzy {min16f}, r2.yyzy {min2_8f as min16f} add r0.xyzw {min16f}, r0.xyzw {min16f}, l(15.400000, 9.000000, 9.000000, 15.400000) {def32 as min16f} mov o0.xyzw, r0.xyzw {min16f as def32} ret ``` However, if the graphics driver doesn't have minimum precision support, it ignores the minimum precision indicators and runs at 32-bit precision, which is equivalent as working with regular types. -- v2: vkd3d-shader/hlsl: Reinterpret minimum precision types as their regular counterparts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/58

4 9

[PATCH v8 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 05 Jan '23

05 Jan '23

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - ~~first crumb is always moved here~~ - removes the split, if there are no items in the menu - hidden crumbs are moved here - left ~~or right~~ click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v8: comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

3 21

Re: [PATCH v6 0/1] MR1908: msi: pSignatureSettings uninitialized
by Bernhard Kölbl (＠besentv) 05 Jan '23

05 Jan '23

On Thu Jan 5 12:10:54 2023 +0000, Philip Karlsson Gisslow wrote: > I see, I changed it now. Excellent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20369

1 0

Re: [PATCH v6 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) 05 Jan '23

05 Jan '23

On Thu Jan 5 12:04:49 2023 +0000, Bernhard Kölbl wrote: > Maybe something along the lines of: "msi: Initialize WINTRUST_DATA to > zero." ? I see, I changed it now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20368

1 0

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Bernhard Kölbl (＠besentv) 05 Jan '23

05 Jan '23

On Thu Jan 5 11:45:30 2023 +0000, Philip Karlsson Gisslow wrote: > Thank you for taking the time Bernhard, I am not sure what I am missing, > the dot after the first sentence? I really want to get this right as I > would be happy to help out contributing more going forward. Maybe something along the lines of: "msi: Initialize WINTRUST_DATA to zero." ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20364

1 0

[PATCH 0/4] MR1913: Fix winedbg module's search path.
by eric pouech (＠epo) 05 Jan '23

05 Jan '23

This series solves https://bugs.winehq.org/show_bug.cgi?id=54250 The two first patches address proper loading of modules in dbghelp. There are cases where the path sent in the dll load debug event isn't the real path to the loaded module. The two last patches are to expose the real path of the module for integration in when winedbg acts as a proxy to gdb. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1913

3 4

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) 05 Jan '23

05 Jan '23

On Thu Jan 5 11:43:46 2023 +0000, Bernhard Kölbl wrote: > Just wanna take the time to point out that the commit message isn't > matching Wine's requirements > https://wiki.winehq.org/Submitting_Patches#The_commit_message . Thank you for taking the time Bernhard, I am not sure what I am missing, the dot after the first sentence? I really want to get this right as I would be happy to help out contributing more going forward. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20363

1 0

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Bernhard Kölbl (＠besentv) 05 Jan '23

05 Jan '23

Just wanna take the time to point out that the commit message isn't matching Wine's requirements https://wiki.winehq.org/Submitting_Patches#The_commit_message . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20362

1 0

Re: [PATCH v5 0/1] MR1907: user32: Set 32-bit base address.
by Patrick Szczepański (＠PSzczepanski1996) 05 Jan '23

05 Jan '23

@gverm Okey, it's done - sorry for bunch of force-updated commits, I just noticed how wine-team is paying attention to details and I'm trying to fit into the rules. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1907#note_20361

1 0

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized - approved
by Hans Leidekker (＠hans) 05 Jan '23

05 Jan '23

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908

1 0

[PATCH v2 0/1] MR1912: winevulkan: Enable VK_EXT_hdr_metadata
by Joshua Ashton (＠joshua) 05 Jan '23

05 Jan '23

This works fine with the new struct conversions, and is needed for HDR with native Vulkan games such as Doom Eternal and games using HDR with DXVK and VKD3D-Proton. -- v2: winevulkan: Enable VK_EXT_hdr_metadata. https://gitlab.winehq.org/wine/wine/-/merge_requests/1912

2 1

Re: [PATCH v4 0/1] MR1907: user32: Set 32-bit base address.
by Gijs Vermeulen (＠gverm) 05 Jan '23

05 Jan '23

@PSzczepanski1996 You'll need to set the author of your commit to your real name as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1907#note_20357

1 0

[PATCH 0/1] MR1909: comctl32/tests: Ignore some IME messages in monthcal tests.
by Nikolay Sivov (＠nsivov) 05 Jan '23

05 Jan '23

Should fix test failures on some systems with enabled IME. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1909

3 2

[PATCH 0/1] MR1912: winevulkan: Enable VK_EXT_hdr_metadata
by Joshua Ashton (＠joshua) 05 Jan '23

05 Jan '23

This works fine with the new struct conversions, and is needed for HDR with native Vulkan games such as Doom Eternal and games using HDR with DXVK and VKD3D-Proton. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1912

2 1

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) 05 Jan '23

05 Jan '23

On Thu Jan 5 07:09:52 2023 +0000, Nikolay Sivov wrote: > @ripxorip please squash these commits locally and then force push to > have a single commit. Sure thing -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20355

1 0

[PATCH v3 0/3] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) 05 Jan '23

05 Jan '23

This field was not unitilized so it got a random value from the stack causing a later crash when it was dereferenced in Wintrust (SoftPubloadSignature). -- v3: Sends the correct pointer to memset https://gitlab.winehq.org/wine/wine/-/merge_requests/1908

3 4

[PATCH 0/1] MR1910: include: Add missing enum XHR_PROP_ values
by Alistair Leslie-Hughes (＠alesliehughes) 05 Jan '23

05 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1910

3 2

[PATCH 0/1] MR1911: xactengine3_7/tests: Skip tests when XACTEngine Initialization fails
by Alistair Leslie-Hughes (＠alesliehughes) 05 Jan '23

05 Jan '23

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=54151 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1911

2 1

[PATCH v2 0/2] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) 05 Jan '23

05 Jan '23

This field was not unitilized so it got a random value from the stack causing a later crash when it was dereferenced in Wintrust (SoftPubloadSignature). -- v2: Memset the struct to avoid exlicit initialization https://gitlab.winehq.org/wine/wine/-/merge_requests/1908

3 4

[PATCH 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) 05 Jan '23

05 Jan '23

This field was not unitilized so it got a random value from the stack causing a later crash when it was dereferenced in Wintrust (SoftPubloadSignature). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908

4 4

[PATCH 0/1] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation.
by Francisco Casas (＠fcasas) 04 Jan '23

04 Jan '23

copy_propagation_transform_object_load() currently retrieves true, which indicates that there was progress, even if the input dereference remains the same. This can happen repeatedly if an uninitialized object is copied onto itself, as in the tests added in this patch. This results on the compilation getting stuck on an endless loop. This patch checks if the deref didn't change, to retrieve false in that case. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

2 1

[PATCH v3 0/1] MR1878: comctl32/listview: Exclude header area in WM_NCPAINT.
by Vladislav Timonin (＠vt) 04 Jan '23

04 Jan '23

Depending on the theme, if there was a header, the border ends up painted lower than it should be, and clipped by the header. 7-Zip file manager, the reason why the offset was added in 5f0dcf79185941c4faff35d1cc9c758160f3a27d in the first place, still renders correctly. Before: ![before](/uploads/8321f45c657469278b2787edfa147b20/before.png) After: ![after](/uploads/013241f4cd3b893c7f4073b6a9fe8119/after.png) EDIT1: Actually compared screenshots of 7-Zip file manager and looks like the headers are now painted consistently after highlighting them. ![7zFM-before-hilite](/uploads/64fe3fb80002c847c2e9270337bab4e8/7zFM-before-hilite.png) ![7zFM-after-hilite](/uploads/4db4778c2ad6d27eddbd4a1202b41881/7zFM-after-hilite.png) -- v3: comctl32/listview: Exclude header area in WM_NCPAINT. https://gitlab.winehq.org/wine/wine/-/merge_requests/1878

4 4

[PATCH 0/1] MR1902: d2d1/tests: Fix memory leaks.
by Zhiyi Zhang (＠zhiyi) 04 Jan '23

04 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53995 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1902

3 2

[PATCH 0/1] MR1907: user32: Set 32-bit base address
by Patrick Szczepański (＠PSzczepanski1996) 04 Jan '23

04 Jan '23

For some reason NosTale is checking memory regions preventing it's own logic from calling system memory. It checks if the code is called under "0x70000000" range, but for some reason "user32.dll" is placed below this region (by Wine) causing mouse bug, graphical glitches and other memory-access related errors. This pull-request fixes the bug, because I wanted to be sure I tested it on two Linux machines, Steam Deck and one macOS device. Everything just works fine. Not sure if we should set only this dll base address or (according to reference image) set it for other dll libraries too. Also under Windows (I tested it too) it's randomized by ALSR - maybe we should do it the same way (and place library between range "0x70000000" - 0x80000000" for example). Reference: https://user-images.githubusercontent.com/21007545/210278824-29f42d90-aca4-… Resolves these issues: https://bugs.winehq.org/show_bug.cgi?id=49988 https://bugs.winehq.org/show_bug.cgi?id=42999 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1907

2 1

[PATCH 0/6] MR1903: mshtml: More ref leaks & misc fixes.
by Gabriel Ivăncescu (＠insn) 04 Jan '23

04 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1903

3 7

[PATCH v9 0/8] MR729: windows.media.speech: Initial recognition session work.
by Bernhard Kölbl (＠besentv) 04 Jan '23

04 Jan '23

-- v9: windows.media.speech: Allow the recognition session worker to be paused. https://gitlab.winehq.org/wine/wine/-/merge_requests/729

2 8

[PATCH v3 0/1] MR1884: d3d8: Filter out redundant buffer discards.
by Zebediah Figura (＠zfigura) 04 Jan '23

04 Jan '23

I was unable to write tests for this; it seems it doesn't consistently work on Windows. However, Rayman 3 seems to rely on it; it maps the same buffer twice immediately after creation, with DISCARD flags on both maps, and expects the same address to be returned. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53752 -- v3: d3d8: Filter out redundant buffer discards. https://gitlab.winehq.org/wine/wine/-/merge_requests/1884

3 3

[PATCH v2 0/2] MR1880: mfplat/tests: Test MFGetStrideForBitmapInfoHeader for NV11.
by Ziqing Hui (＠zhui) 04 Jan '23

04 Jan '23

-- v2: mfplat/tests: Add more RGB24 image size tests. mfplat/tests: Test MFGetStrideForBitmapInfoHeader for NV11. https://gitlab.winehq.org/wine/wine/-/merge_requests/1880

2 3

[PATCH v8 0/8] MR729: windows.media.speech: Initial recognition session work.
by Bernhard Kölbl (＠besentv) 03 Jan '23

03 Jan '23

-- v8: windows.media.speech: Allow the recognition session worker to be paused. windows.media.speech: Add a worker thread to the recognition session. https://gitlab.winehq.org/wine/wine/-/merge_requests/729

2 9

[PATCH v7 0/8] MR729: windows.media.speech: Initial recognition session work.
by Bernhard Kölbl (＠besentv) 03 Jan '23

03 Jan '23

-- v7: windows.media.speech: Add pausing to the recognition session worker. windows.media.speech: Add a worker thread to the recognition session. https://gitlab.winehq.org/wine/wine/-/merge_requests/729

2 8

[PATCH v6 0/8] MR729: windows.media.speech: Initial recognition session work.
by Bernhard Kölbl (＠besentv) 03 Jan '23

03 Jan '23

-- v6: windows.media.speech: Add pausing to the recognition session worker. windows.media.speech: Add a worker thread to the recognition session. windows.media.speech/tests: Test starting, stopping, pausing and resuming the recognition session. windows.media.speech/tests: Test the recognizer state. windows.media.speech: Return IAsyncAction from session_PauseAsync. windows.media.speech: Return IAsyncAction from session_StopAsync. windows.media.speech: Do not force calling convention on internal callbacks. windows.media.speech: Move constraints vector to the recognition session. https://gitlab.winehq.org/wine/wine/-/merge_requests/729

3 14

[PATCH 0/3] MR1904: winegstreamer: Explicitly sleep in the streaming thread when flushing.
by Zebediah Figura (＠zfigura) 03 Jan '23

03 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1904

2 3

[PATCH v3 0/6] MR53: vkd3d-shader/hlsl: transpose(), smoothstep(), and properly convert args of element-wise intrinsics.
by Francisco Casas (＠fcasas) 03 Jan '23

03 Jan '23

This patch series includes an implementation of the long-pending `transpose` intrinsic and the `smoothstep` intrinsic. While implementing `smoothstep` I realized that some intrinsics have different rules for the allowed data types than expressions: - Vectors and matrices at the same time are not allowed, regardless of their dimensions. Even if they have the same number of components. - Any combination of matrices is always allowed, even those when no matrix fits inside another, e.g.: `float2x3` is compatible with `float3x2`, resulting in `float2x2`. The common data type is the min on each dimension. This is the case for `max`, `pow`, `ldexp`, `clamp` and `smoothstep`; which suggest that it is the case for all intrinsics where the operation is applied element-wise. So this was corrected. A minor fix in `pow`'s type conversion is also included. -- v3: vkd3d-shader/hlsl: Use add_unary_arithmetic_expr() in intrinsic_pow(). vkd3d-shader/hlsl: Allow elementwise_intrinsic_convert_args() to also convert args to float. vkd3d-shader/hlsl: Convert elementwise intrinsics args to the proper common type. tests: Test for common type conversion for element-wise intrinsics. vkd3d-shader/hlsl: Support smoothstep() intrinsic. vkd3d-shader/hlsl: Support transpose() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/53

3 8

[PATCH v2 0/5] MR1901: dinput/tests: Add more W.G.I effect direction tests.
by Rémi Bernon (＠rbernon) 03 Jan '23

03 Jan '23

-- v2: dinput/tests: Test W.G.I condition effect with negative direction. dinput/tests: Test W.G.I periodic effect with negative direction. dinput/tests: Test W.G.I constant effect with negative direction. dinput/tests: Test W.G.I ramp effect with negative directions. dinput/tests: Reduce tests verbosity. https://gitlab.winehq.org/wine/wine/-/merge_requests/1901

2 6

[PATCH 0/5] MR1901: dinput/tests: Add more W.G.I effect direction tests.
by Rémi Bernon (＠rbernon) 03 Jan '23

03 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1901

3 6

[PATCH v2 0/1] MR1884: d3d8: Filter out redundant buffer discards.
by Zebediah Figura (＠zfigura) 03 Jan '23

03 Jan '23

I was unable to write tests for this; it seems it doesn't consistently work on Windows. However, Rayman 3 seems to rely on it; it maps the same buffer twice immediately after creation, with DISCARD flags on both maps, and expects the same address to be returned. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53752 -- v2: d3d8: Filter out redundant buffer discards. https://gitlab.winehq.org/wine/wine/-/merge_requests/1884

3 2

[PATCH v2 0/2] MR1886: Fixing paste errors on edit control in Win10+.
by eric pouech (＠epo) 02 Jan '23

02 Jan '23

This series tries to fix WM_PASTE tests error on edit control (both user32 & comctl32). The test failures where systematic on a local Win10 for comctl32 (yet very rare on user32, perhaps one in 20 runs). Since the failures are not systematic, it ought to be a synchronisation / timing issue. Flushing the msg queue before starting the paste test cycle seems to fix the issue. - 0 occurence on comctl32 and user32 in 50 run (local VM) - 0 occurence on Testbot (comctl32) in 1 run. It's hard to be fully conclusive about bug resolution, but it's at least a step into the right direction. -- v2: comctl32/tests: Fix failing WM_PASTE tests for edit control on Win10+. user32/tests: Fix failing WM_PASTE tests for edit control on Win10+. https://gitlab.winehq.org/wine/wine/-/merge_requests/1886

2 3

[PATCH 0/1] MR1900: dbghelp: In dwarf debug info, use the same name of anonymous UDT as pdb.
by eric pouech (＠epo) 02 Jan '23

02 Jan '23

It's hard coded by msvc in PDB information, so adapt dwarf to advertize the same. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1900

2 1

[PATCH v7 0/4] MR1578: ntdll: TlsIndex should not actually contain tls indices
by Evan Tang (＠etang-cw) 02 Jan '23

02 Jan '23

> (The TlsIndex field in the LDR_DATA_TABLE_ENTRY structure appears to be unused except as a flag that the module has TLS (being always set to -1), at least as far back as Windows XP. It is worth mentioning that the WINE implementation of implicit TLS incorrectly uses TlsIndex as the real module TLS index, so it may be unreliable to assume that it is always -1 if you care about working on WINE.) > > \- http://www.nynaeve.net/?p=186 and the "links to that article but still doesn't work in wine" award goes to... [the D runtime](https://github.com/dlang/dmd/blob/6bf60ea0eb174631ede0074a77d3898d…! (Admittedly, there aren't too many ways to do what they're trying to do.) With this, the D runtime will now work in Wine, even if in a dll loaded into an exe with no tls (which gets it the tls index 0) The changes to the debugger are a bit icky, a possible alternative is to find some other easily-debugger-accessible place to stuff the tls index. -- v7: TMP: Use module info for tls in winedbg winedbg: Track loaded modules https://gitlab.winehq.org/wine/wine/-/merge_requests/1578

3 6

[PATCH v3 0/4] MR1894: ntdll: heap verification improvements
by Jinoh Kang (＠iamahuman) 02 Jan '23

02 Jan '23

-- v3: ntdll: Remove redundant WARN_ON(heap) check. ntdll: Validate blocks in the heap pending free request list. ntdll: Validate subheap's owner heap when validating heap. https://gitlab.winehq.org/wine/wine/-/merge_requests/1894

3 5

[PATCH v2 0/4] MR1894: ntdll: heap verification improvements
by Jinoh Kang (＠iamahuman) 02 Jan '23

02 Jan '23

-- v2: ntdll: Remove redundant WARN_ON(heap) check. ntdll: Validate blocks in the heap pending free request list. ntdll: Validate subheap's owner heap when validating heap. ntdll: Check for delayed free block in heap_validate_ptr. https://gitlab.winehq.org/wine/wine/-/merge_requests/1894

3 6

[PATCH 0/3] MR1894: ntdll: heap verification improvements
by Jinoh Kang (＠iamahuman) 02 Jan '23

02 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1894

3 7

[PATCH v2 0/1] MR1885: conhost: Fix incorrect registry value name
by Hugh McMaster (＠hmc) 02 Jan '23

02 Jan '23

The correct value name is 'FontFamily'. -- v2: conhost: Migrate from FontPitchFamily to FontFamily https://gitlab.winehq.org/wine/wine/-/merge_requests/1885

3 3

[PATCH 0/4] MR1899: kernel32/tests: Call newer functions not on Windows XP or 2003 via function addresses (process)
by Hugh McMaster (＠hmc) 02 Jan '23

02 Jan '23

There are times when it is useful to test changes on the Windows XP and 2003 VMs, but the direct use of functions not on those platforms makes this impossible. Once applied, the kernel32 tests will run on the Windows XP and 2003 testbot VMs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1899

2 4

[PATCH 0/2] MR1898: kernel32/tests: Call newer functions not on Windows XP or 2003 via function addresses (fiber)
by Hugh McMaster (＠hmc) 02 Jan '23

02 Jan '23

There are times when it is useful to test changes on the Windows XP and 2003 VMs, but the direct use of functions not on those platforms makes this impossible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1898

2 2

[PATCH 0/3] MR1897: kernel32/tests: Call newer functions not on Windows XP or 2003 via function addresses (locale)
by Hugh McMaster (＠hmc) 02 Jan '23

02 Jan '23

There are times when it is useful to test changes on the Windows XP and 2003 VMs, but the direct use of functions not on those platforms makes this impossible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1897

2 3

[PATCH 0/7] MR1896: kernel32/tests: Call newer functions not on Windows XP or 2003 via function addresses (console)
by Hugh McMaster (＠hmc) 02 Jan '23

02 Jan '23

There are times when it is useful to test changes on the Windows XP and 2003 VMs, but the direct use of functions not on those platforms makes this impossible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1896

2 7

[PATCH 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) 01 Jan '23

01 Jan '23

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

2 3

[PATCH v7 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 31 Dec '22

31 Dec '22

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - first crumb is always moved here - removes the split, if there are no items in the menu - hidden crumbs are moved here - left or right click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v7: comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

4 9

[PATCH v2 0/2] MR1893: increase number of midi ports to 64
by Alexander (＠dreamer) 31 Dec '22

31 Dec '22

While this doesn't fully fix https://bugs.winehq.org/show_bug.cgi?id=50703 as we can read in the code comments ideally the number of devices is "unbound" it does resolve the immediate issue that I've been facing. Since the total number of ports displayed is both hardware + software it's incredibly easy to go beyond just 16. The increase to 64 helps a lot, but is still not perfect. We could also set it to 128 or 256, but it's still arbitrary. I think this would already be enough for the vast majority of cases, but I guess they also thought this with 16 ;) -- v2: update comment https://gitlab.winehq.org/wine/wine/-/merge_requests/1893

5 5

[PATCH v6 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 30 Dec '22

30 Dec '22

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - first crumb is always moved here - removes the split, if there are no items in the menu - hidden crumbs are moved here - left or right click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v6: comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

2 7

[PATCH 0/1] MR1893: increase number of midi ports to 64
by Alexander (＠dreamer) 30 Dec '22

30 Dec '22

While this doesn't fully fix https://bugs.winehq.org/show_bug.cgi?id=50703 as we can read in the code comments ideally the number of devices is "unbound" it does resolve the immediate issue that I've been facing. Since the total number of ports displayed is both hardware + software it's incredibly easy to go beyond just 16. The increase to 64 helps a lot, but is still not perfect. We could also set it to 128 or 256, but it's still arbitrary. I think this would already be enough for the vast majority of cases, but I guess they also thought this with 16 ;) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1893

3 3

[PATCH 0/1] MR1880: mfplat/tests: Test MFGetStrideForBitmapInfoHeader for NV11.
by Ziqing Hui (＠zhui) 30 Dec '22

30 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1880

3 2

[PATCH v2 0/1] MR1892: ntoskrnl.exe/tests: Add Driver Object Extension Tests.
by Etaash Mathamsetty (＠etaash.mathamsetty) 29 Dec '22

29 Dec '22

-- v2: ntoskrnl.exe/tests: Add Driver Object Extension Tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1892

3 2

[PATCH 0/1] MR1892: ntoskrnl.exe/tests: Add Driver Object Extension Tests.
by Etaash Mathamsetty (＠etaash.mathamsetty) 29 Dec '22

29 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1892

3 2

[PATCH v5 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 29 Dec '22

29 Dec '22

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - first crumb is always moved here - removes the split, if there are no items in the menu - hidden crumbs are moved here - left or right click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v5: comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

5 11

[PATCH 0/3] MR1891: Gle fixes
by André Zwing (＠AndreRH) 29 Dec '22

29 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1891

2 3

Re: [PATCH v4 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 29 Dec '22

29 Dec '22

On Wed Dec 28 23:08:08 2022 +0000, Vladislav Timonin wrote: > Just some padding so that the icon isn't so close to the text. Probably > could use a comment. > `dis->rcItem.left, dis->rcItem.top` on the left. > `dis->rcItem.left - (icon_width / 2), dis->rcItem.top` on the right. > ![overflow-icon](/uploads/bca861c60e2ee47bd3af6bbc80fa92f8/overflow-icon.png) Was pointed out that I shouldn't draw outside `rcItem` and can add padding in `WM_MEASUREITEM` instead. Should've read docs thoroughly enough ,_, ![overflow-icon-2](/uploads/c3468a6a90d9616ced0c9a760255899c/overflow-icon-2.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857#note_20183

1 0

Re: [PATCH v4 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 28 Dec '22

28 Dec '22

On Wed Dec 28 19:30:29 2022 +0000, Esme Povirk wrote: > Drawing outside of rcItem doesn't seem right. Why is this necessary? Just some padding so that the icon isn't so close to the text. Probably could use a comment. `dis->rcItem.left, dis->rcItem.top` on the left. `dis->rcItem.left - (icon_width / 2), dis->rcItem.top` on the right. ![overflow-icon](/uploads/bca861c60e2ee47bd3af6bbc80fa92f8/overflow-icon.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857#note_20182

1 0

Re: [PATCH v4 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 28 Dec '22

28 Dec '22

On Wed Dec 28 19:30:28 2022 +0000, Esme Povirk wrote: > I think you could remove the need for this by drawing the left border > outside the window. If you mean extending it to be painted under crumbs, it originally was, static control with `SS_GRAYFRAME` taking up full width. But that had issues with frame being painted over crumbs on initial dialog show. And right border trailing on resize that I was ignoring thinking it was caused by [54137](https://bugs.winehq.org/show_bug.cgi?id=54137). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857#note_20181

1 0

[PATCH 0/1] MR1890: po: Update Dutch translation.
by Floris Renaud (＠jkfloris) 28 Dec '22

28 Dec '22

- Avoid using the pronouns "u", "uw", "je" and "jouw" Signed-off-by: Floris Renaud <jkfloris(a)dds.nl> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1890

2 1

2025

2024

2023

2022

wine-gitlab