- wine-gitlab - winehq.org

Re: [PATCH v4 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Esme Povirk (＠madewokherd) 28 Dec '22

28 Dec '22

I haven't yet looked at "comdlg32: Add address edit to IFileDialog navigation bar." and the commit after it, as I've hit my mental limit for the day. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857#note_20179

1 0

Re: [PATCH v4 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Esme Povirk (＠madewokherd) 28 Dec '22

28 Dec '22

Esme Povirk (@madewokherd) commented about dlls/comdlg32/navbar.c: > hwnd, 0, COMDLG32_hInstance, NULL); > SetWindowSubclass(info->background_hwnd, NAVBAR_BACKGROUND_SubclassProc, 0, (DWORD_PTR)info); > > + info->overflow_hwnd = CreateWindowExW(0, WC_BUTTONW, NULL, For accessibility it'd be good to give this button a title. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857#note_20177

1 0

Re: [PATCH v4 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Esme Povirk (＠madewokherd) 28 Dec '22

28 Dec '22

Esme Povirk (@madewokherd) commented about dlls/comdlg32/navbar.c: > while (ILRemoveLastID(pidl)); > ILFree(pidl); > > + NAVBAR_OVERFLOW_Clear(info); > + > + /* move the first crumb to overflow menu, if there are at least 2 crumbs */ > + crumb1 = LIST_ENTRY(list_head(&new_crumbs), struct crumb, entry); > + if (crumb1 && crumb1->entry.next != &new_crumbs) > + { > + NAVBAR_OVERFLOW_Insert(info, crumb1->pidl, crumb1->display_name); > + DestroyWindow(crumb1->hwnd); > + > + list_remove(&crumb1->entry); I think removing items from the list like this is confusing. It also results in the need for a special case "preserving" the first crumb in the layout code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857#note_20178

1 0

Re: [PATCH v4 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Esme Povirk (＠madewokherd) 28 Dec '22

28 Dec '22

Esme Povirk (@madewokherd) commented about dlls/comdlg32/navbar.c: > + menu_item.hbmpItem = HBMMENU_CALLBACK; /* see NAVBAR_OVERFLOW_DrawIcon */ > + > + InsertMenuItemW(info->overflow_menu, -1, TRUE, &menu_item); > +} > + > +static void NAVBAR_OVERFLOW_Clear(NAVBAR_INFO *info) > +{ > + INT i, menu_item_count = GetMenuItemCount(info->overflow_menu); > + MENUITEMINFOW menu_item = {0}; > + > + menu_item.cbSize = sizeof(MENUITEMINFOW); > + menu_item.fMask = MIIM_DATA; > + > + for (i = 0; i < menu_item_count; i++) > + { > + /* deleting an item shifts further indices, so don't use `i` */ It would probably be simpler to delete the items from the end, and slightly more efficient because it removes the need to shift indices. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857#note_20175

1 0

Re: [PATCH v4 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Esme Povirk (＠madewokherd) 28 Dec '22

28 Dec '22

Esme Povirk (@madewokherd) commented about dlls/comdlg32/navbar.c: > + > +static LRESULT NAVBAR_OVERFLOW_DrawIcon(HWND hwnd, NAVBAR_INFO *info, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + DRAWITEMSTRUCT *dis = (DRAWITEMSTRUCT *)lparam; > + ITEMIDLIST *pidl = (ITEMIDLIST *)dis->itemData; > + SHFILEINFOW file_info = {0}; > + IImageList *icon_list; > + > + icon_list = (IImageList *)SHGetFileInfoW((const WCHAR *)pidl, 0, &file_info, sizeof(file_info), > + SHGFI_PIDL | SHGFI_ICON | SHGFI_SMALLICON | SHGFI_SHELLICONSIZE | SHGFI_SYSICONINDEX); > + if (icon_list) > + { > + int icon_width, icon_height; > + > + IImageList_GetIconSize(icon_list, &icon_width, &icon_height); > + DrawIconEx(dis->hDC, dis->rcItem.left - (icon_width / 2), dis->rcItem.top, Drawing outside of rcItem doesn't seem right. Why is this necessary? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857#note_20176

1 0

Re: [PATCH v4 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Esme Povirk (＠madewokherd) 28 Dec '22

28 Dec '22

Esme Povirk (@madewokherd) commented about dlls/comdlg32/navbar.c: > + PAINTSTRUCT ps; > + HDC hdc = BeginPaint(hwnd, &ps); > + RECT rc; > + HBRUSH old_brush; > + HBRUSH bg_brush = GetSysColorBrush(COLOR_BTNFACE); > + HBRUSH frame_brush = GetSysColorBrush(COLOR_3DSHADOW); > + > + GetClientRect(hwnd, &rc); > + > + /* clear background to avoid border trailing when resizing */ > + FillRect(hdc, &rc, bg_brush); > + > + /* draw the 1px frame */ > + FrameRect(hdc, &rc, frame_brush); > + > + /* erase the left border, retaining the top and bottom pixels */ I think you could remove the need for this by drawing the left border outside the window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857#note_20173

1 0

Re: [PATCH v4 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Esme Povirk (＠madewokherd) 28 Dec '22

28 Dec '22

Esme Povirk (@madewokherd) commented about dlls/comdlg32/navbar.c: > + SendMessageW(info->fwd_btn_hwnd, WM_SETFONT, (WPARAM)gui_font, FALSE); > + icon = ImageList_GetIcon(info->icons, ILI_FORWARD, ILD_NORMAL); > + SendMessageW(info->fwd_btn_hwnd, BM_SETIMAGE, (WPARAM)IMAGE_ICON, (LPARAM)icon); > + DestroyIcon(icon); > + > + SetWindowLongPtrW(hwnd, 0, (DWORD_PTR)info); > + > + return DefWindowProcW(hwnd, msg, wparam, lparam); > +} > + > +static LRESULT NAVBAR_Destroy(HWND hwnd, NAVBAR_INFO *info, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + SetWindowLongPtrW(hwnd, 0, 0); > + ImageList_Destroy(info->icons); > + DestroyWindow(info->back_btn_hwnd); > + DestroyWindow(info->fwd_btn_hwnd); The system will automatically destroy child windows, so I don't think this is needed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857#note_20174

1 0

Re: [PATCH v4 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Esme Povirk (＠madewokherd) 28 Dec '22

28 Dec '22

Esme Povirk (@madewokherd) commented about dlls/comdlg32/navbar.c: > + HWND container_hwnd; > + > + HIMAGELIST icons; > + > + HWND back_btn_hwnd; > + HWND fwd_btn_hwnd; > +} NAVBAR_INFO; > + > +static LRESULT NAVBAR_Create(HWND hwnd, NAVBAR_INFO *info, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + CREATESTRUCTW *cs = (CREATESTRUCTW*)lparam; > + INT x; > + HGDIOBJ gui_font = GetStockObject(DEFAULT_GUI_FONT); > + HICON icon; > + > + info = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(NAVBAR_INFO)); This ignores the pointer that was passed in. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857#note_20172

1 0

[PATCH v3 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 28 Dec '22

28 Dec '22

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - first crumb is always moved here - removes the split, if there are no items in the menu - hidden crumbs are moved here - left or right click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v3: comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

2 7

[PATCH v2 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 27 Dec '22

27 Dec '22

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - first crumb is always moved here - removes the split, if there are no items in the menu - hidden crumbs are moved here - left or right click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v2: comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

3 10

[PATCH 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 27 Dec '22

27 Dec '22

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - first crumb is always moved here - removes the split, if there are no items in the menu - hidden crumbs are moved here - left or right click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

4 8

[PATCH 0/2] MR1886: Fixing paste errors on edit control in Win10+.
by eric pouech (＠epo) 26 Dec '22

26 Dec '22

This series tries to fix WM_PASTE tests error on edit control (both user32 & comctl32). The test failures where systematic on a local Win10 for comctl32 (yet very rare on user32, perhaps one in 20 runs). Since the failures are not systematic, it ought to be a synchronisation / timing issue. Flushing the msg queue before starting the paste test cycle seems to fix the issue. - 0 occurence on comctl32 and user32 in 50 run (local VM) - 0 occurence on Testbot (comctl32) in 1 run. It's hard to be fully conclusive about bug resolution, but it's at least a step into the right direction. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1886

3 5

[PATCH 0/1] MR1885: conhost: Fix incorrect registry value name
by Hugh McMaster (＠hmc) 26 Dec '22

26 Dec '22

The correct value name is 'FontFamily'. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1885

3 2

[PATCH v2 0/3] MR1889: bthprops.cpl: Add BluetoothRegisterForAuthenticationEx stub.
by Mohamad Al-Jaf (＠maljaf) 26 Dec '22

26 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54112 -- v2: bthprops.cpl: Add BluetoothUnregisterAuthentication stub. bthprops.cpl: Add BluetoothRegisterForAuthenticationEx stub. include/bluetoothapis: Add BluetoothRegisterForAuthenticationEx prototype. https://gitlab.winehq.org/wine/wine/-/merge_requests/1889

2 4

[PATCH 0/3] MR1889: bthprops.cpl: Add BluetoothRegisterForAuthenticationEx stub.
by Mohamad Al-Jaf (＠maljaf) 26 Dec '22

26 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54112 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1889

2 3

[PATCH v2 0/1] MR1881: comctl32/test: Adapt the edit tests for height to Win10+.
by eric pouech (＠epo) 26 Dec '22

26 Dec '22

Starting with Win10, height of multiline edit controls no longer seems to be hardwired to a multiple of the font height (when larger than font height). - Adapt the tests accordingly (detecting how to compute the expected height of a control). - Extend the ranges of the tested heights. Note: - there may be another way to detect the model for height computation. - the range of heights tested stem from internal testing and is larger than existing testing. It could be reduced as a range, or picking values from a fixed set of values (if needed). Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52152 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- v2: comctl32/test: Adapt the edit tests for height to Win10+. https://gitlab.winehq.org/wine/wine/-/merge_requests/1881

3 4

[PATCH 0/1] MR1882: comctl32/tests: Fix failing test on Windows in Arabic UTF-8.
by eric pouech (＠epo) 24 Dec '22

24 Dec '22

Already fixed in user32/tests/edit.c by 614b7d7430e0ba60692a46e97f03b8b9600f0651 Apply same fix for equivalent test on comctl32/tests/edit.c Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52932 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1882

4 3

[PATCH v3 0/3] MR1887: dinput: Return WHEEL_DELTA for the granularity of the mouse z-axis.
by Tim Clem (＠tclem) 24 Dec '22

24 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53627 -- v3: dinput: Add granularity to object_properties. dinput: Create object_properties for each mouse axis. https://gitlab.winehq.org/wine/wine/-/merge_requests/1887

3 5

[PATCH 0/2] MR37: Add some DXIL support.
by Conor McCarthy (＠cmccarthy) 24 Dec '22

24 Dec '22

Tracing of very simple SM 6 shaders is possible with these patches; for example a pixel shader which returns a vector of constants. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/37

5 33

[PATCH v2 0/3] MR1887: dinput: Return WHEEL_DELTA for the granularity of the mouse z-axis.
by Tim Clem (＠tclem) 23 Dec '22

23 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53627 -- v2: dinput: Add granularity to object_properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/1887

2 3

[PATCH 0/3] MR1887: dinput: Return WHEEL_DELTA for the granularity of the mouse z-axis.
by Tim Clem (＠tclem) 23 Dec '22

23 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53627 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1887

3 4

[PATCH 0/1] MR1884: d3d8: Filter out redundant buffer discards.
by Zebediah Figura (＠zfigura) 23 Dec '22

23 Dec '22

I was unable to write tests for this; it seems it doesn't consistently work on Windows. However, Rayman 3 seems to rely on it; it maps the same buffer twice immediately after creation, with DISCARD flags on both maps, and expects the same address to be returned. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53752 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1884

3 3

[PATCH v17 0/3] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) 23 Dec '22

23 Dec '22

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v17: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

3 5

[PATCH v4 0/1] MR1492: Load and save application-specific console settings from the registry
by Hugh McMaster (＠hmc) 23 Dec '22

23 Dec '22

On Windows, application-specific settings are stored in the registry under HKCU\\Console\\<path_to_app>. Our implementation of conhost.exe does not know which process is connected to it, so we need to get the full process image name before loading any application-specific console settings. To do this, we extend the server protocol to pass the process Id of the connected console process to conhost.exe. Please run tools/make_requests before merging. -- v4: conhost: Load/Save console settings using the process path or window title https://gitlab.winehq.org/wine/wine/-/merge_requests/1492

4 8

[PATCH 0/2] MR1875: regedit.exe redraw fixes
by Jinoh Kang (＠iamahuman) 23 Dec '22

23 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1875

3 4

[PATCH 0/1] MR1864: wined3d: Ignore DISCARD and NOOVERWRITE on buffers which are not GPU-accessible.
by Zebediah Figura (＠zfigura) 23 Dec '22

23 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53863 This fixes a regression introduced by ebbcc10b0593948657b8e684c3a9be8ace1a5d25. Prior to that commit, buffers which were not CPU-accessible would not have the WINED3D_BUFFER_USE_BO flag set, and accordingly buffer_resource_sub_resource_map() would simply return the SYSMEM location, ignoring the DISCARD and NOOVERWRITE flags. However, the "accelerated" path in wined3d_cs_map_upload_bo() only checks for the DISCARD flag, assuming that it is only set for dynamic GPU-accessible buffers, and would subsequently try to allocate non-mappable memory and then map it. This commit avoids the accelerated path for such buffers, once again matching our old behaviour. According to [1], this also matches Windows: DISCARD on SYSTEMMEM buffers is ignored on both AMD and NVidia, and NOOVERWRITE is ignored on NVidia (but not AMD). [1] https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.org/messa… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1864

3 2

[PATCH v3 0/3] MR1865: wined3d: Load and invalidate every mipmap level when mapping the top mipmap level.
by Zebediah Figura (＠zfigura) 23 Dec '22

23 Dec '22

-- v3: wined3d: Load and invalidate every mipmap level when mapping the top mipmap level. d3d8/tests: Test uploading the whole mipmap chain in one map. d3d9/tests: Test uploading the whole mipmap chain in one map. https://gitlab.winehq.org/wine/wine/-/merge_requests/1865

4 6

[PATCH 0/1] MR1863: d3d11/tests: Do not test deferred contexts in test_dynamic_map_synchronization().
by Zebediah Figura (＠zfigura) 23 Dec '22

23 Dec '22

DISCARD maps on deferred contexts do not seem to offer the same synchronization guarantees as do DISCARD maps on the immediate context, at least not with respect to subsequent NOOVERWRITE maps on the immediate context. This is not particularly surprising, seeing as it is probably far more usual to only map a resource on one kind of context or the other. The test currently fails on Windows 11 on NVidia drivers, but it also fails on Mesa, for what I think are the same reasons. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52563 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54023 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1863

3 2

[PATCH 0/1] MR1881: comctl32/test: Adapt the edit tests for height to Win10+.
by eric pouech (＠epo) 23 Dec '22

23 Dec '22

Starting with Win10, height of multiline edit controls no longer seems to be hardwired to a multiple of the font height (when larger than font height). - Adapt the tests accordingly (detecting how to compute the expected height of a control). - Extend the ranges of the tested heights. Note: - there may be another way to detect the model for height computation. - the range of heights tested stem from internal testing and is larger than existing testing. It could be reduced as a range, or picking values from a fixed set of values (if needed). Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52152 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1881

3 4

[PATCH v2 0/1] MR1878: comctl32/listview: Draw border and background separately in WM_NCPAINT.
by Vladislav Timonin (＠vt) 23 Dec '22

23 Dec '22

Depending on the theme, if there was a header, the border ends up painted lower than it should be, and clipped by the header. 7-Zip file manager, the reason why the offset was added in 5f0dcf79185941c4faff35d1cc9c758160f3a27d in the first place, still renders correctly. Before: ![before](/uploads/8321f45c657469278b2787edfa147b20/before.png) After: ![after](/uploads/013241f4cd3b893c7f4073b6a9fe8119/after.png) EDIT1: Actually compared screenshots of 7-Zip file manager and looks like the headers are now painted consistently after highlighting them. ![7zFM-before-hilite](/uploads/64fe3fb80002c847c2e9270337bab4e8/7zFM-before-hilite.png) ![7zFM-after-hilite](/uploads/4db4778c2ad6d27eddbd4a1202b41881/7zFM-after-hilite.png) -- v2: comctl32/listview: Exclude header area in WM_NCPAINT. https://gitlab.winehq.org/wine/wine/-/merge_requests/1878

3 3

Re: [PATCH v2 0/1] MR1883: include: Add missing constants in d3d11.idl. - approved
by Alexandre Julliard (＠julliard) 22 Dec '22

22 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1883

1 0

Re: [PATCH v3 0/3] MR1876: d3d9/tests: Fix a few more test failures on Gitlab CI. - approved
by Alexandre Julliard (＠julliard) 22 Dec '22

22 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1876

1 0

Re: [PATCH v2 0/1] MR1879: ntdll/tests: Avoid testing the server pipe signaled state from the main thread. - approved
by Alexandre Julliard (＠julliard) 22 Dec '22

22 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1879

1 0

Re: [PATCH v2 0/2] MR1874: win32u: Honor CS_HREDRAW and CS_VREDRAW when resizing window. (#52903) - approved
by Alexandre Julliard (＠julliard) 22 Dec '22

22 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1874

1 0

[PATCH v2 0/3] MR1876: d3d9/tests: Fix a few more test failures on Gitlab CI.
by Alexandre Julliard (＠julliard) 22 Dec '22

22 Dec '22

-- v2: d3d9/tests: Fix some activation/focus test failures. https://gitlab.winehq.org/wine/wine/-/merge_requests/1876

4 6

[PATCH 0/1] MR1883: include: Add missing constants in d3d11.idl.
by Biswapriyo Nath (＠Biswa96) 22 Dec '22

22 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1883

3 2

[PATCH 0/3] MR1876: d3d9/tests: Fix a few more test failures on Gitlab CI.
by Alexandre Julliard (＠julliard) 22 Dec '22

22 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1876

4 6

[PATCH 0/4] MR1877: user32: Clipboard overflow and underflow fixes
by Francois Gouget (＠fgouget) 22 Dec '22

22 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1877

2 5

[PATCH 0/2] MR1874: win32u: Honor CS_HREDRAW and CS_VREDRAW when resizing window. (#52903)
by Jinoh Kang (＠iamahuman) 21 Dec '22

21 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52903 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1874

3 3

[PATCH v3 0/1] MR1166: ntdll: don't claim to have not found a library that is in place
by Konstantin Kharlamov (＠Hi-Angel) 21 Dec '22

21 Dec '22

When `import_dll` function gets `STATUS_DLL_NOT_FOUND` from `load_dll()`, it has no way of distinguishing whether it's a dependency for the dll wasn't found, or the dll itself is missing. That results in confusing ERR messages, where a dll is found, but wine claims it isn't. Fix this by moving the print to the actual place that is aware of whether it's the parent or the child dll haven't been found. Log before: 0024:err:module:import_dll Library lib2.dll (which is needed by L"Z:\\tmp\\lib1.dll") not found 0024:err:module:import_dll Library lib1.dll (which is needed by L"Z:\\tmp\\a.exe") not found Log after: 0024:err:module:load_dll Library L"lib2.dll" (which is needed by L"Z:\\tmp\\foo\\lib1.dll") not found 0024:err:module:import_dll Loading library lib2.dll (which is needed by L"Z:\\tmp\\foo\\lib1.dll") failed (error c0000135). 0024:err:module:import_dll Loading library lib1.dll (which is needed by L"Z:\\tmp\\foo\\a.exe") failed (error c0000135). -------- While it's just about prints, but it costed me hours of wandering *(because if I know where to find the dependency dll, but I see that the main dll is also "not found" despite being "right there", I have to research the latter problem that looks more complicated. But given enough resources applied, it then turns out to be a faux)*. As a fun fact, I am apparently not the only one to have stumbled upon. Here's a screenshot of a `#english` chat where I asked about a commit title correctness. It's the last place where you'd expect to find someone familiar with WINE, and yet here's a person that had to deal with that exact error as well: ![Screenshot_20221026_023411](/uploads/55552d7c335ef5ce0b507f61adacbb00/Screenshot_20221026_023411.png) So, I think it's kinda serious problem. -- v3: ntdll: don't claim to have not found a library that is in place https://gitlab.winehq.org/wine/wine/-/merge_requests/1166

2 3

[PATCH 0/1] MR1879: ntdll/tests: Avoid testing the server pipe signaled state from the main thread.
by Zebediah Figura (＠zfigura) 21 Dec '22

21 Dec '22

Although the test has never been observed to fail on Windows, I think the failure is genuinely a race in the test. File handles (like events) are signaled in order to mark that an I/O operation has completed. In this case the I/O operation includes manipulating data on both ends of the pipe, and as part of that may signal the other end. Internally, however, the file handle must logically happen *after* all of this processing has taken place, not least because (given the Windows I/O architecture) it is the job of the I/O manager, not the IRP handler. Since the purpose of the test is probably just to check that the file handle will be signaled after a synchronous I/O operation has completed, we may as well check it from the client thread, after we know for sure that it has. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54078 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1879

2 2

[PATCH v2 0/1] MR1853: mf: Request more samples for MFT when needed.
by Shaun Ren (＠shaunren) 21 Dec '22

21 Dec '22

When an upstream node has not given enough samples to the transform, we need to request more samples from it to avoid stalling the pipeline. This fixes an issue where the intro audio of the game Airborne Kingdom stops playing after a few seconds. -- v2: mf: Request more samples for transforms when needed. https://gitlab.winehq.org/wine/wine/-/merge_requests/1853

2 1

Re: [PATCH v3 0/2] MR1828: winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1828

1 0

Re: [PATCH v2 0/1] MR1868: Revert "qasf: Register ASF Reader filter media type." - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1868

1 0

Re: [PATCH v2 0/1] MR1872: wined3d: Do not explicitly check 3D depth/stencil capabilities in wined3d_check_device_format(). - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1872

1 0

Re: [PATCH v2 0/1] MR1873: kernel32/tests: Skip some console tests on w1064v1909. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1873

1 0

Re: [PATCH v2 0/2] MR1850: d3d9: Upload the relevant texture in d3d9_texture_gen_auto_mipmap(). - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1850

1 0

Re: [PATCH v2 0/1] MR1847: ddraw/tests: Release ddraw after device in test_texture_wrong_caps(). - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1847

1 0

Re: [PATCH v2 0/1] MR1871: shell32: Always set last error in Shell_NotifyIconW. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1871

1 0

Re: [PATCH v2 0/1] MR1870: urlmon/tests: Use gitlab.winehq.org host in can_do_https. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1870

1 0

Re: [PATCH v2 0/3] MR1869: dinput/tests: Add more force feedback envelope and duration tests. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1869

1 0

Re: [PATCH v3 0/2] MR1832: mfmediaengine: Pause the session in media_engine_Pause. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1832

1 0

Re: [PATCH v2 0/1] MR1866: mfplat/tests: Add MEDIASUBTYPE_RGB* and NV11 image size tests. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1866

1 0

[PATCH 0/1] MR1878: comctl32/listview: Draw border and background separately in WM_NCPAINT.
by Vladislav Timonin (＠vt) 21 Dec '22

21 Dec '22

Depending on the theme, if there was a header, the border ends up painted lower than it should be, and clipped by the header. 7-Zip file manager, the reason why the offset was added in 5f0dcf79185941c4faff35d1cc9c758160f3a27d in the first place, still renders correctly. Before: ![before](/uploads/8321f45c657469278b2787edfa147b20/before.png) After: ![after](/uploads/013241f4cd3b893c7f4073b6a9fe8119/after.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1878

2 1

[PATCH v2 0/2] MR1828: winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB.
by Rémi Bernon (＠rbernon) 21 Dec '22

21 Dec '22

The check was dropped in e392e0ac2846edc25610723c19d6a796372017e1, leaving the dwFlags variable unused. I have no idea if it was indeed unnecessary or if it was dropped by mistake but either we need to keep the check, or we should remove the variable. -- v2: winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB. opengl32/tests: Test wglChoosePixelFormatARB flags filters. https://gitlab.winehq.org/wine/wine/-/merge_requests/1828

3 3

[PATCH 0/1] MR1868: Revert "qasf: Register ASF Reader filter media type."
by Rémi Bernon (＠rbernon) 21 Dec '22

21 Dec '22

This reverts commit 4608e1e1257a377cd554a0e885368e3feb7d286f. The ASF Reader filter suffers from defects which are difficult to solve, and will require a better implementation of wmvcore in order to work correctly. In the meantime, revert the class registration so that the File Source filter is preferred instead. This will break games that tried to use the filter directly and which may have started to work correctly, but they are less frequent than the ones simply playing wmv videos with quartz. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53640 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53748 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54191 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1868

3 2

[PATCH 0/1] MR1872: wined3d: Do not explicitly check 3D depth/stencil capabilities in wined3d_check_device_format().
by Sven Baars (＠sbaars) 21 Dec '22

21 Dec '22

This reapplies the change from 67d0038e49323523b745c4a728069d8195273d23 that was reverted in 06b19322187e5ef8ffc06504c322ce9bcdaaa6ee, causing a regression. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53785 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1872

3 2

[PATCH 0/1] MR1873: kernel32/tests: Skip some console tests on w1064v1909.
by eric pouech (＠epo) 21 Dec '22

21 Dec '22

We get conhost.exe:tty failures on testbot: - not for version prior to w1064v1909 (these tests require pseudo-consoles, which are not implemented in these Windows version). - for w1064v1909 - not for W10 versions after w1064v1909. So, we assume that pseudo-console support is immature in this Windows version: skip all the remaining test at the first discrepancy point. I could have maintained a couple of unit tests for this Windows version, but decided not to: - it would make the code more complicated (*), - it doesn't bring value to Wine - it would be a pain to maintain. This patch fixes the (remaining) W10 part of bug below. Support for W11 will be handled in separate patch (and likely with properly integrating the results from W11, contrary to this patch). Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53465 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1873

2 1

[PATCH 0/2] MR1850: d3d9: Upload the relevant texture in d3d9_texture_gen_auto_mipmap().
by Zebediah Figura (＠zfigura) 21 Dec '22

21 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1850

3 3

[PATCH 0/1] MR1847: ddraw/tests: Release ddraw after device in test_texture_wrong_caps().
by Paul Gofman (＠gofman) 21 Dec '22

21 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54049 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1847

4 3

[PATCH 0/1] MR1871: shell32: Always set last error in Shell_NotifyIconW.
by Jacek Caban (＠jacek) 21 Dec '22

21 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1871

2 1

[PATCH 0/1] MR1870: urlmon/tests: Use gitlab.winehq.org host in can_do_https.
by Jacek Caban (＠jacek) 21 Dec '22

21 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1870

3 2

[PATCH 0/3] MR1869: dinput/tests: Add more force feedback envelope and duration tests.
by Rémi Bernon (＠rbernon) 21 Dec '22

21 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1869

2 3

[PATCH v3 0/1] MR1778: dwrite: Handle memory allocation failure in bidi_compute_bracket_pairs (cppcheck).
by Alex Henrie (＠alexhenrie) 21 Dec '22

21 Dec '22

-- v3: dwrite: Handle memory allocation failure in bidi_compute_bracket_pairs (cppcheck). https://gitlab.winehq.org/wine/wine/-/merge_requests/1778

4 3

[PATCH v2 0/2] MR1832: mfmediaengine: Pause the session in media_engine_Pause.
by Shaun Ren (＠shaunren) 21 Dec '22

21 Dec '22

-- v2: mfmediaengine: Pause the session in media_engine_Pause. https://gitlab.winehq.org/wine/wine/-/merge_requests/1832

3 3

[PATCH 0/3] MR1856: qasf: Unblock DSoundRender filter by sending a preroll sample on init.
by Rémi Bernon (＠rbernon) 21 Dec '22

21 Dec '22

The qasf change is a hack, but it solves the regressions and I don't think there's a good way to fix them otherwise. The proper fix is to implement wmvcore threading as in https://gitlab.winehq.org/wine/wine/-/merge_requests/1311, but that will be much more changes and is unsuitable for the code freeze. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53640 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53748 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1856

3 5

[PATCH 0/1] MR1866: mfplat/tests: Add MEDIASUBTYPE_RGB* and NV11 image size tests.
by Ziqing Hui (＠zhui) 21 Dec '22

21 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1866

3 2

[PATCH 0/2] MR1867: Better handle ctrl-\ and ctrl-break in conhost.exe.
by eric pouech (＠epo) 21 Dec '22

21 Dec '22

The first intend of this serie is that CUI app in non processed input mode should not die when using the ctrl-\ key stroke. This series: - implements ctrl-pause/break in conhost.exe (in processed mode) by generating the proper console event - maps for unix-console ctrl-\ into a ctrl-pause/break key stroke. Code change is relatively small, and fixes an annoying behavior in unix consoles (see bug report). The series could have been a bit smaller by not adding ctrl-break support in user32 console, but: - it's cleaner that way - it still requires the server changes (which may be perhaps the most questionnable here, esp. the termios change). So a valid (IMO) candidate for 8.0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1867

2 2

[PATCH v2 0/3] MR1865: wined3d: Load and invalidate every mipmap level when mapping the top mipmap level.
by Zebediah Figura (＠zfigura) 21 Dec '22

21 Dec '22

-- v2: wined3d: Load and invalidate every mipmap level when mapping the top mipmap level. d3d8/tests: Test uploading the whole mipmap chain in one map. d3d9/tests: Test uploading the whole mipmap chain in one map. https://gitlab.winehq.org/wine/wine/-/merge_requests/1865

3 4

[PATCH 0/3] MR1865: wined3d: Load and invalidate every mipmap level when mapping the top mipmap level.
by Zebediah Figura (＠zfigura) 21 Dec '22

21 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1865

3 4

Re: [PATCH v2 0/1] MR1862: jscript: Fix JSCaller Release refcount. - approved
by Alexandre Julliard (＠julliard) 20 Dec '22

20 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1862

1 0

Re: [PATCH v4 0/2] MR1851: winhttp: Only read server reply in send_request() if the whole request is available. - approved
by Alexandre Julliard (＠julliard) 20 Dec '22

20 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1851

1 0

Re: [PATCH v2 0/1] MR1852: winebus.sys: Declare a variable only when used - approved
by Alexandre Julliard (＠julliard) 20 Dec '22

20 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1852

1 0

Re: [PATCH v2 0/1] MR1848: wmc: Avoid uninitialized variable in init_argv0_dir - approved
by Alexandre Julliard (＠julliard) 20 Dec '22

20 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1848

1 0

Re: [PATCH v2 0/2] MR1861: d3d8/tests: Fix some test failures on Gitlab CI. - approved
by Alexandre Julliard (＠julliard) 20 Dec '22

20 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1861

1 0

Re: [PATCH v2 0/3] MR1854: httpapi: Allow passing NULL size to request reading functions. - approved
by Alexandre Julliard (＠julliard) 20 Dec '22

20 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1854

1 0

Re: [PATCH v2 0/1] MR1860: kerne32/tests: Silence a failing test on Win10+. - approved
by Alexandre Julliard (＠julliard) 20 Dec '22

20 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1860

1 0

Re: [PATCH v4 0/4] MR1839: mf/tests: Test SetOutputType for WMV decoder. - approved
by Alexandre Julliard (＠julliard) 20 Dec '22

20 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1839

1 0

Re: [PATCH v2 0/2] MR1846: Fix CUI output on Unix tty. - approved
by Alexandre Julliard (＠julliard) 20 Dec '22

20 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1846

1 0

Re: [PATCH v2 0/2] MR1858: win32u: Convert inter-process messages to Unicode. - approved
by Alexandre Julliard (＠julliard) 20 Dec '22

20 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1858

1 0

[PATCH 0/1] MR1862: jscript: Fix JSCaller Release refcount.
by Gabriel Ivăncescu (＠insn) 20 Dec '22

20 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1862

3 2

[PATCH v3 0/2] MR1851: winhttp: Only read server reply in send_request() if the whole request is available.
by Paul Gofman (＠gofman) 20 Dec '22

20 Dec '22

Fixes a regression introduced by aa8f97e8294b0618de0e8a45ff2adef0c4e516da. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54184 For the requests which involve additional data to be sent the application might use WinHttpWriteData() before WinHttpReceiveResponse() to pass the additional request data instead of providing the optional data to WinHttpSendRequest(). In that case server reply can't be read in send_request(). I believe the first patch straightens up state handling in receive_response() by introducing a single switch processing every incoming state and avoiding additional local variable (along with making WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE notification handling less obscure). -- v3: winhttp: Only read server reply in send_request() if the whole request is sent. winhttp: Handle state in a single switch in receive_response(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1851

3 7

[PATCH 0/2] MR1861: d3d8/tests: Fix some test failures on Gitlab CI.
by Alexandre Julliard (＠julliard) 20 Dec '22

20 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1861

3 4

[PATCH 0/1] MR1853: mf: Request more samples for MFT when needed.
by Shaun Ren (＠shaunren) 20 Dec '22

20 Dec '22

When an upstream node has not given enough samples to the transform, we need to request more samples from it to avoid stalling the pipeline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1853

3 2

[PATCH v2 0/3] MR1775: Fix a few gcc warnings
by Fabian Maurer (＠DarkShadow44) 20 Dec '22

20 Dec '22

Happens on gcc 12.2.0 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v2: dwrite/tests: Prevent "misleading indentation" warnings winedump: Prevent "format overflow" warning user.exe16: Prevent "uninitialized variable" warning https://gitlab.winehq.org/wine/wine/-/merge_requests/1775

3 6

[PATCH 0/2] MR1832: mfmediaengine: Pause the session in media_engine_Pause.
by Shaun Ren (＠shaunren) 20 Dec '22

20 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1832

3 4

[PATCH 0/1] MR1852: winebus.sys: Declare a variable only when used
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

udev_add_device declares a variable (product) even when it is not used on all platforms. Use the same condition for the declaration that already guards the code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1852

3 4

[PATCH 0/1] MR1860: kerne32/tests: Silence a failing test on Win10+.
by eric pouech (＠epo) 20 Dec '22

20 Dec '22

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1860

2 1

[PATCH v3 0/4] MR1839: mf/tests: Test SetOutputType for WMV decoder.
by Ziqing Hui (＠zhui) 20 Dec '22

20 Dec '22

-- v3: mf/tests: Test SetOutputType for WMV decoder. mf/tests: Use one input type for GetOutputType tests. mf/tests: Introduce check_dmo_set_input_type. mf/tests: Shorten test messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/1839

3 5

[PATCH 0/2] MR1846: Fix CUI output on Unix tty.
by eric pouech (＠epo) 20 Dec '22

20 Dec '22

While testing some Windows CUI app (hiew.exe from bug #54141), it appears that some console API allow to write all the possible control characters onto the console. This serie: - add tests for read/write test of these - fix 'unix' console to not send some of the control characters to the underlying tty, which would reinterpret them. This leads to unwanted display (ie hexdump of a file would insert real cr/lf when displaying dump of \r\n") -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1846

3 5

[PATCH 0/2] MR1858: win32u: Convert inter-process messages to Unicode.
by Jacek Caban (＠jacek) 20 Dec '22

20 Dec '22

It got lost in win32u conversion. In most cases, we may perform the conversion in user32, but trying to do that in inter-process would be weird. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1858

3 3

[PATCH v2 0/2] MR1851: winhttp: Only read server reply in send_request() if the whole request is available.
by Paul Gofman (＠gofman) 20 Dec '22

20 Dec '22

Fixes a regression introduced by aa8f97e8294b0618de0e8a45ff2adef0c4e516da. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54184 For the requests which involve additional data to be sent the application might use WinHttpWriteData() before WinHttpReceiveResponse() to pass the additional request data instead of providing the optional data to WinHttpSendRequest(). In that case server reply can't be read in send_request(). I believe the first patch straightens up state handling in receive_response() by introducing a single switch processing every incoming state and avoiding additional local variable (along with making WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE notification handling less obscure). -- v2: winhttp: Only read server reply in send_request() if the whole request is available. https://gitlab.winehq.org/wine/wine/-/merge_requests/1851

3 5

[PATCH 0/3] MR1854: httpapi: Allow passing NULL size to request reading functions.
by Zebediah Figura (＠zfigura) 20 Dec '22

20 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1854

2 3

Re: [PATCH v3 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

Yes, this now builds -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769#note_19905

1 0

Re: [PATCH v3 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase - closed
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769

1 0

Re: [PATCH v3 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

On Tue Dec 20 02:41:21 2022 +0000, Alexandre Julliard wrote: > This should be superseded by f69c11117ee56cb664bd0ade1392c5553ff2af30. Yes, after that commit this now builds fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769#note_19904

1 0

Re: [PATCH v4 0/66] MR1849: winebus.sys: Declare a variable only when used - closed
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

1 0

Re: [PATCH v2 0/0] MR1849: winebus.sys: Declare a variable only when used - closed
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

1 0

[PATCH 0/1] MR1849: winebus.sys: Declare a variable only when used
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

udev_add_device declares a variable (product) even when it is not used on all platforms. Use the same condition for the declaration that already guards the code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

2 4

Re: [PATCH v3 0/1] MR1421: include: add c++ header guards in pathcch
by Zhiyi Zhang (＠zhiyi) 20 Dec '22

20 Dec '22

Zhiyi Zhang (@zhiyi) commented about include/pathcch.h: > HRESULT WINAPI PathCchStripPrefix(WCHAR *path, SIZE_T size); > HRESULT WINAPI PathCchStripToRoot(WCHAR *path, SIZE_T size); > BOOL WINAPI PathIsUNCEx(const WCHAR *path, const WCHAR **server); > + > +#ifdef __cplusplus > +} > +#endif Please add a new line here -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1421#note_19897

1 0

2025

2024

2023

2022

wine-gitlab