- wine-gitlab - winehq.org

[PATCH 0/2] MR1851: winhttp: Only read server reply in send_request() if the whole request is available.
by Paul Gofman (＠gofman) 20 Dec '22

20 Dec '22

Fixes a regression introduced by aa8f97e8294b0618de0e8a45ff2adef0c4e516da. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54184 For the requests which involve additional data to be sent the application might use WinHttpWriteData() before WinHttpReceiveResponse() to pass the additional request data instead of providing the optional data to WinHttpSendRequest(). In that case server reply can't be read in send_request(). I believe the first patch straightens up state handling in receive_response() by introducing a single switch processing every incoming state and avoiding additional local variable (along with making WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE notification handling less obscure). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1851

2 2

[PATCH 0/1] MR1848: wmc: Avoid uninitialized variable in init_argv0_dir
by Gerald Pfeifer (＠gerald) 19 Dec '22

19 Dec '22

init_argv0_dir has conditional code for different operating systems. In case of FreeBSD a variable remains uninitialized in the error case, yet is then used. Fix that by handling the error case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1848

2 1

Re: [PATCH v2 0/1] MR1845: winhttp: Check for NULL lpszAutoConfigUrl in WinHttpGetProxyForUrl(). - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1845

1 0

Re: [PATCH v3 0/3] MR1824: Remove broken from some color tests that can also fail on Linux. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1824

1 0

Re: [PATCH v3 0/5] MR1843: user32: Add more EnableMouseInPointer / GetPointerType / GetPointerInfo tests. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1843

1 0

Re: [PATCH v5 0/7] MR1842: dinput/tests: Wait for each device interface to start / stop and misc test cleanup. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1842

1 0

Re: [PATCH v2 0/1] MR1840: ntdll: Only compile get_current_teb() on linux. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1840

1 0

Re: [PATCH v2 0/1] MR1837: wined3d: Recognize AMD as a vendor string - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1837

1 0

Re: [PATCH v2 0/3] MR1836: DMusic: Implement the IDirectMusicSegment8_Clone() and semi-stub the IDirectMusicChordMap_ComposeSegmentFromTemplate() methods. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1836

1 0

Re: [PATCH v2 0/1] MR1835: po: Update Japanese translation. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1835

1 0

Re: [PATCH v2 0/1] MR1833: libs/wine: Only define exe_link when needed - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1833

1 0

Re: [PATCH v2 0/1] MR1831: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1831

1 0

[PATCH 0/1] MR1845: winhttp: Check for NULL lpszAutoConfigUrl in WinHttpGetProxyForUrl().
by Paul Gofman (＠gofman) 19 Dec '22

19 Dec '22

Fixes a regression introduced by cbfe940a1eaf5e158de3127b1265462bfbfb70af. Might be related to https://bugs.winehq.org/show_bug.cgi?id=54055, I don't yet have the confirmation but this is something probably worth fixing regardless. lpszAutoConfigUrl is used whenever WINHTTP_AUTOPROXY_CONFIG_URL is specified, regardless of WINHTTP_AUTOPROXY_AUTO_DETECT presence. Before cbfe940a1eaf5e158de3127b1265462bfbfb70af NULL lpszAutoConfigUrl went directly to GetAddrInfoW(). Now with the timeout it is relayed to aync name resolution thread and might be crashing in wcsdup(). It doesn't happen all the time as we might not be reaching download_script() at all due to prior WinHttpDetectAutoProxyConfigUrl() legitimate failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1845

3 2

[PATCH v2 0/3] MR1824: Remove broken from some color tests that can also fail on Linux.
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

They fail on the Gitlab CI. An alternative would be to mark them todo_wine but it's not clear that there's anything we want to do here. -- v2: d3d9/tests: Mark some of the depth bias tests as todo. d3d9/tests: Mark a zero-size pixel test as todo. d3d8/tests: Mark a zero-size pixel test as todo. https://gitlab.winehq.org/wine/wine/-/merge_requests/1824

3 4

Re: [PATCH v3 0/1] MR1421: include: add c++ header guards in pathcch
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

Please use your full name in the git commit info, so that it matches your Gitlab account. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1421#note_19862

1 0

[PATCH 0/1] MR1837: wined3d: Recognize AMD as a vendor string
by Ryan Hendrickson (＠rhendric) 19 Dec '22

19 Dec '22

I have an AMD Ryzen 7 5700U, which when my system was running Mesa 22.0.4 identified itself in `glxinfo` as: ``` Vendor: AMD (0x1002) Device: AMD RENOIR (LLVM 13.0.1, DRM 3.47, 5.19.17) (0x164c) ``` After a recent system upgrade that took Mesa to 22.2.3, `glxinfo` now gives: ``` Vendor: AMD (0x1002) Device: RENOIR (renoir, LLVM 14.0.6, DRM 3.48, 6.0.12) (0x164c) ``` Wine programs also started reliably crashing on me, with the following message that did not appear before: ``` 0130:fixme:d3d:wined3d_guess_card_vendor Received unrecognized GL_VENDOR "AMD". Returning HW_VENDOR_NVIDIA. ``` I don't really know what I'm doing but that message suggested this patch to me, which does resolve the crashes and doesn't seem obviously wrong. Maybe there's some other table to which the new identifying information of this APU needs to be added, but keeping this check for future-proofing might still be a good idea in that case? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1837

4 5

[PATCH 0/2] MR1824: Remove broken from some color tests that can also fail on Linux.
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

They fail on the Gitlab CI. An alternative would be to mark them todo_wine but it's not clear that there's anything we want to do here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1824

4 6

[PATCH v3 0/8] MR1842: dinput/tests: Wait for each device interface to start / stop and misc test cleanup.
by Rémi Bernon (＠rbernon) 19 Dec '22

19 Dec '22

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53525 -- v3: dinput/tests: Remove unnecessary goto and label. dinput/tests: Wait for each device interface to start / stop. dinput/tests: Add a device count parameter to hid_device_(start|stop). dinput/tests: Use semaphores to count and notify rawinput messages. dinput/tests: Avoid using INFINITE timeouts. dinput/tests: Remove old physical joystick tests. dinput/tests: Unregister rawinput devices after tests. hidclass.sys: Make sure a desktop is created for the driver process. https://gitlab.winehq.org/wine/wine/-/merge_requests/1842

3 10

[PATCH 0/3] MR1844: win32u/tests: Add some pointer related syscall tests.
by Rémi Bernon (＠rbernon) 19 Dec '22

19 Dec '22

Pretty much the same as https://gitlab.winehq.org/wine/wine/-/merge_requests/1843, but on win32u side, to figure and validate the syscall entry signatures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1844

2 3

[PATCH v2 0/5] MR1843: user32: Add more EnableMouseInPointer / GetPointerType / GetPointerInfo tests.
by Rémi Bernon (＠rbernon) 19 Dec '22

19 Dec '22

Checking the expected basic behavior, for https://bugs.winehq.org/show_bug.cgi?id=51537 and https://bugs.winehq.org/show_bug.cgi?id=53847. -- v2: user32/tests: Test GetPointer(Frame)Info(History) behavior. user32/tests: Move old GetPointerType tests into test_GetPointerInfo. user32/tests: Test GetPointerInfo behavior with EnableMouseInPointer. user32/tests: Test IsMouseInPointerEnabled behavior. user32/tests: Test EnableMouseInPointer behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/1843

2 6

[PATCH v2 0/7] MR1842: dinput/tests: Wait for each device interface to start / stop and misc test cleanup.
by Rémi Bernon (＠rbernon) 19 Dec '22

19 Dec '22

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53525 -- v2: dinput/tests: Wait for each device interface to start / stop. dinput/tests: Add a device count parameter to hid_device_(start|stop). dinput/tests: Use semaphores to count and notify rawinput messages. dinput/tests: Avoid using INFINITE timeouts. dinput/tests: Remove old physical joystick tests. dinput/tests: Unregister rawinput devices after tests. hidclass.sys: Make sure a desktop is created for the driver process. https://gitlab.winehq.org/wine/wine/-/merge_requests/1842

3 10

[PATCH 0/7] MR1843: user32: Add more EnableMouseInPointer / GetPointerType / GetPointerInfo tests.
by Rémi Bernon (＠rbernon) 19 Dec '22

19 Dec '22

Checking the expected basic behavior, for https://bugs.winehq.org/show_bug.cgi?id=51537 and https://bugs.winehq.org/show_bug.cgi?id=53847. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1843

3 8

[PATCH v4 0/7] MR1842: dinput/tests: Wait for each device interface to start / stop and misc test cleanup.
by Rémi Bernon (＠rbernon) 19 Dec '22

19 Dec '22

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53525 -- v4: https://gitlab.winehq.org/wine/wine/-/merge_requests/1842

2 8

[PATCH 0/6] MR1842: dinput/tests: Wait for each device interface to start / stop and misc test cleanup.
by Rémi Bernon (＠rbernon) 19 Dec '22

19 Dec '22

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53525 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1842

4 9

[PATCH 0/1] MR1841: hidclass.sys: Make sure a desktop is created for the driver process.
by Rémi Bernon (＠rbernon) 19 Dec '22

19 Dec '22

This was previously automatically done when user32 was loaded, but since the move of __wine_send_input to win32u, we do not need to load it any more. Somehow it is still loaded when prefix is initialized or updated, and the dinput tests work in some cases, but not in some other. This makes sure we have a desktop or WM_INPUT messages won't be sent by wineserver. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1841

2 2

Re: [PATCH v2 0/2] MR1839: mf/tests: Test SetOutputType for WMV decoder.
by Rémi Bernon (＠rbernon) 19 Dec '22

19 Dec '22

On Mon Dec 19 11:04:02 2022 +0000, Ziqing Hui wrote: > Testbot complains about too much printing. Should I remove some tests? > For example, test only one input type for SetOutputType tests. I'd suggest to shorten the test messages, like for instance `SetOutputType returned unexpected hr 0x80004001 for flag 0.` shorten to `0x0: SetOutputType returned 0x80004001.` with wine_push_context for the flags, or as an even more extreme measure, if necessary, `0x0: got hr 0x80004001.`. If that's not enough then yes, you can probably think about removing some tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1839#note_19835

1 0

Re: [PATCH v2 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This should be superseded by f69c11117ee56cb664bd0ade1392c5553ff2af30. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769#note_19833

1 0

[PATCH 0/1] MR1840: ntdll: Only compile get_current_teb() on linux.
by Huw Davies (＠huw) 19 Dec '22

19 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1840

2 1

Re: [PATCH v2 0/2] MR1839: mf/tests: Test SetOutputType for WMV decoder.
by Ziqing Hui (＠zhui) 19 Dec '22

19 Dec '22

Testbot complains about too much printing. Should I remove some tests? For example, test only one input type for SetOutputType tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1839#note_19832

1 0

[PATCH 0/2] MR1839: mf/tests: Test SetOutputType for WMV decoder.
by Ziqing Hui (＠zhui) 19 Dec '22

19 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1839

3 3

[PATCH 0/1] MR1773: localui: Add additional safety check (Coverity)
by Fabian Maurer (＠DarkShadow44) 19 Dec '22

19 Dec '22

Should not change the logic, but makes Coverity happy and seems safer Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1773

3 7

[PATCH v5 0/7] MR51: vkd3d-shader/hlsl: Improve constant handling in copy prop, and extend the use of aoffimmi modifiers.
by Francisco Casas (＠fcasas) 19 Dec '22

19 Dec '22

If a hlsl_ir_load loads a variable whose components are stored from different instructions, copy propagation doesn't replace it. But if all these instructions are constants (which currently is the case for value constructors), the load can be replaced with a constant value, which is what the first patch of this series does. For instance, this shader: ``` sampler s; Texture2D t; float4 main() : sv_target { return t.Gather(s, float2(0.6, 0.6), int2(0, 0)); } ``` results in the following IR before applying the patch: ``` float | 6.00000024e-01 float | 6.00000024e-01 uint | 0 | = (<constructor-2>[@4].x @2) uint | 1 | = (<constructor-2>[@6].x @3) float2 | <constructor-2> int | 0 int | 0 uint | 0 | = (<constructor-5>[@11].x @9) uint | 1 | = (<constructor-5>[@13].x @10) int2 | <constructor-5> float4 | gather_red(resource = t, sampler = s, coords = @8, offset = @15) | return | = (<output-sv_target0> @16) ``` and this IR afterwards: ``` float2 | {6.00000024e-01 6.00000024e-01 } int2 | {0 0 } float4 | gather_red(resource = t, sampler = s, coords = @2, offset = @3) | return | = (<output-sv_target0> @4) ``` This is required to write texel_offsets as aoffimmi modifiers in the sm4 backend, since it expects the texel_offset arguments to be hlsl_ir_constant. This series also: * Allows Gather() methods to use aoffimmi modifiers instead of an additional source register (which is the only way allowed for shader model 4.1), when possible. * Adds support to texel_offsets in the Load() method via aoffimmi modifiers (the only allowed method). -- v5: vkd3d-shader/hlsl: Propagate swizzle chains. vkd3d-shader/hlsl: Replace swizzles with constants in copy prop. tests: Test constant propagation through swizzles. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/51

3 10

[PATCH 0/2] MR58: vkd3d-shader/hlsl: Reinterpret minimum precision types as their regular counterparts.
by Francisco Casas (＠fcasas) 19 Dec '22

19 Dec '22

Reinterpret min16float, min10float, min16int, min12int, and min16uint as their regular counterparts: float, float, int, int, uint, respectively. A proper implementation would require adding minimum precision indicators to all the dxbc-tpf instructions that use these types. Consider the output of fxc 10.1 with the following shader: ```hlsl uniform int i; float4 main() : sv_target { min16float4 a = {0, 1, 2, i}; min16int2 b = {4, i}; min10float3 c = {6.4, 7, i}; min12int d = 9.4; min16uint4x2 e = {14.4, 15, 16, 17, 18, 19, 20, i}; return mul(e, b) + a + c.xyzx + d; } ``` ``` ps_5_0 dcl_globalFlags refactoringAllowed | enableMinimumPrecision dcl_constantbuffer CB0[1], immediateIndexed dcl_output o0.xyzw dcl_temps 3 imad r0.xyz {min16u}, l(15, 17, 19, 0) {def32 as min16u}, cb0[0].xxxx {def32 as min16u}, l(56, 64, 72, 0) {def32 as min16u} utof r0.xyz {min16f}, r0.xyzx {min16u} imad r1.x {min16u}, cb0[0].x {def32 as min16u}, cb0[0].x {def32 as min16u}, l(80) {def32 as min16u} utof r0.w {min16f}, r1.x {min16u} mov r1.xyz {min16f}, l(0,1.000000,2.000000,0) {def32 as min16f} itof r1.w {min16f}, cb0[0].x add r0.xyzw {min16f}, r0.xyzw {min16f}, r1.xyzw {min16f} mov r2.y {min2_8f}, l(7.000000) {def32 as min2_8f} itof r2.z {min2_8f}, cb0[0].x add r0.yz {min16f}, r0.yyzy {min16f}, r2.yyzy {min2_8f as min16f} add r0.xyzw {min16f}, r0.xyzw {min16f}, l(15.400000, 9.000000, 9.000000, 15.400000) {def32 as min16f} mov o0.xyzw, r0.xyzw {min16f as def32} ret ``` However, if the graphics driver doesn't have minimum precision support, it ignores the minimum precision indicators and runs at 32-bit precision, which is equivalent as working with regular types. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/58

3 5

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Zebediah Figura (＠zfigura) 18 Dec '22

18 Dec '22

I've given a cursory review to the implementation, and supplied some inline feedback. Besides that, I think it would be a good idea to split up the commit more, and try to apply one fixup at a time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19811

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Zebediah Figura (＠zfigura) 18 Dec '22

18 Dec '22

Zebediah Figura (@zfigura) commented about dlls/kernelbase/path.c: > if (!url) > return E_FAIL; > > - srcLen = lstrlenW(url) + 1; > + /* > + * First check for known, valid and typo free scheme > + */ > + for (pos=1; pos<ARRAY_SIZE(url_scheme); pos++) > + { > + len = wcslen(url_scheme[pos]); > + if ( (len <= wcslen(url)) && (!_wcsnicmp(url, url_scheme[pos], len)) ) > + { > + /* > + * check if string fits into maxChars > + */ > + if (len+1 >= maxChars) This comment doesn't seem to tell us anything more than the following line does. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19810

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Zebediah Figura (＠zfigura) 18 Dec '22

18 Dec '22

Zebediah Figura (@zfigura) commented about dlls/kernelbase/path.c: > */ > HRESULT WINAPI UrlFixupW(PCWSTR url, PWSTR translatedUrl, DWORD maxChars) > { > - DWORD srcLen; > + DWORD srcLen, dstLen, len; > + DWORD colon_pos = 0, pos = 0; > + wchar_t *helper_str = NULL; > + PWSTR save_str = translatedUrl; We use WCHAR, not wchar_t. It'd also be nice to use a consistent style for all of variable names in this function (wrt snake case vs camel case). In new code I think we prefer snake case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19808

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Zebediah Figura (＠zfigura) 18 Dec '22

18 Dec '22

Zebediah Figura (@zfigura) commented about dlls/kernelbase/path.c: > + * First check for known, valid and typo free scheme > + */ > + for (pos=1; pos<ARRAY_SIZE(url_scheme); pos++) > + { > + len = wcslen(url_scheme[pos]); > + if ( (len <= wcslen(url)) && (!_wcsnicmp(url, url_scheme[pos], len)) ) > + { > + /* > + * check if string fits into maxChars > + */ > + if (len+1 >= maxChars) > + return S_FALSE; > + > + lstrcpynW(save_str, url_scheme[pos], len+1); > + url += len; > + goto scheme_done; Can we use a helper function to fix up the scheme instead of using a goto? This will probably also help make the function easier to follow, by virtue of being less monolithic. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19809

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Zebediah Figura (＠zfigura) 18 Dec '22

18 Dec '22

Zebediah Figura (@zfigura) commented about dlls/kernelbase/path.c: > - srcLen = lstrlenW(url) + 1; > + /* > + * First check for known, valid and typo free scheme > + */ > + for (pos=1; pos<ARRAY_SIZE(url_scheme); pos++) > + { > + len = wcslen(url_scheme[pos]); > + if ( (len <= wcslen(url)) && (!_wcsnicmp(url, url_scheme[pos], len)) ) > + { > + /* > + * check if string fits into maxChars > + */ > + if (len+1 >= maxChars) > + return S_FALSE; > + > + lstrcpynW(save_str, url_scheme[pos], len+1); We already know it fits, so this can just be memcpy(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19807

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Zebediah Figura (＠zfigura) 18 Dec '22

18 Dec '22

Zebediah Figura (@zfigura) commented about dlls/kernelbase/path.c: > + DWORD colon_pos = 0, pos = 0; > + wchar_t *helper_str = NULL; > + PWSTR save_str = translatedUrl; > > - FIXME("%s, %p, %ld stub\n", wine_dbgstr_w(url), translatedUrl, maxChars); > + const WCHAR *url_scheme[] = { L"", L"ftp:", L"https:", L"gopher:", L"mailto:", L"news:", > + L"nntp:", L"telnet:", L"wais:", L"file:", L"mk:", > + L"http:", L"shell:", L"snews:", L"local:", > + L"javascript:", L"vbscript:", L"about:", L"res:", > + L"ms-shell-rooted:", L"ms-shell-idlist:", L"hcp:"}; > + > + const WCHAR *url_scheme_short[] = { L"", L"ftp", L"https", L"gopher", L"mailto", L"snews", > + L"nntp", L"telnet", L"wais", L"file", L"mk", > + L"http", L"ms-shell-rooted", L"news", L"local", > + L"javascript", L"vbscript", L"about", L"res", > + L"ms-shell-idlist", L"shell", L"hcp"}; These are constant arrays, so should be "static const WCHAR *const". Also, it seems that one array is the same as the other without the final colon; can we avoid defining two arrays? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19806

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Zebediah Figura (＠zfigura) 18 Dec '22

18 Dec '22

Zebediah Figura (@zfigura) commented about dlls/kernelbase/path.c: > > -HRESULT WINAPI UrlFixupW(const WCHAR *url, WCHAR *translatedUrl, DWORD maxChars) > +/* > + * from Documentation: > + * https://docs.microsoft.com/en-us/windows/desktop/api/shlwapi/nf-shlwapi-url… > + * > + * UrlFixupW attempts to correct a URL whose protocol identifier is incorrect. > + * For example, htttp will be changed to http. > + * > + * LWSTDAPI UrlFixupW( > + * [in] PCWSTR pcszUrl, > + * [out] PWSTR pszTranslatedUrl, > + * DWORD cchMax > + * ); > +*/ > +HRESULT WINAPI UrlFixupW(PCWSTR url, PWSTR translatedUrl, DWORD maxChars) Without trying to get bogged down in style, this change is somewhat counterproductive; we tend to avoid P* typedefs in new code, and we also have been abandoning the use of "documentation" style headers, which rarely convey any useful information. (This also doesn't really belong in a commit which should only affect tests.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19805

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 18 Dec '22

18 Dec '22

On Sun Dec 18 23:01:30 2022 +0000, Zebediah Figura wrote: > Hi Thomas, thanks for the patch! > We want the tests to "pass" after every commit, i.e. have no failures. > That may mean, in this case, introducing the tests marked as todo, and > then later removing those todos. Ok. Got it. Will do it soon -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19804

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Zebediah Figura (＠zfigura) 18 Dec '22

18 Dec '22

Hi Thomas, thanks for the patch! We want the tests to "pass" after every commit, i.e. have no failures. That may mean, in this case, introducing the tests marked as todo, and then later removing those todos. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19803

1 0

[PATCH 0/4] MR1755: refcount return voiding
by Max Figura (＠maxfigura) 18 Dec '22

18 Dec '22

Setting the return type of various wined3d refcounting functions to void These patches modify: - wined3d_incref - wined3d_decref - wined3d_resource_incref - wined3d_resource_decref -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1755

4 9

[PATCH 0/3] MR1836: DMusic: Implement the IDirectMusicSegment8_Clone() and semi-stub the IDirectMusicChordMap_ComposeSegmentFromTemplate() methods.
by Michael Stefaniuc (＠mstefani) 18 Dec '22

18 Dec '22

Fixes https://bugs.winehq.org/show_bug.cgi?id=53941 Should be a fairly safe change as both methods were returning S_OK without touching the return pointer. Also Chicken Tournament is the first application in my collection that uses those methods. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1836

2 3

[PATCH 0/1] MR1835: po: Update Japanese translation.
by Akihiro Sagawa (＠sgwaki) 18 Dec '22

18 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1835

2 1

[PATCH 0/1] MR1834: include: Add recent DirectWrite API changes.
by Nikolay Sivov (＠nsivov) 17 Dec '22

17 Dec '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1834

2 1

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 17 Dec '22

17 Dec '22

On Sat Dec 17 10:41:32 2022 +0000, Etaash Mathamsetty wrote: > I also think you should squash c4e27bd0483c0a1fb872111b6c03b9ad240d85da > (mark tests as todo) and d02be967f9cca0805b5eeaef6a74b3ec51a67619 (add > tests) into one commit I can do so, but before semi stub implementation even more tests are failing. See description. Should i squash mark all tests as todo and remove the markers with semi stub commit? Thanks for your help. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19792

1 0

[PATCH 0/1] MR1833: libs/wine: Only define exe_link when needed
by Gerald Pfeifer (＠gerald) 17 Dec '22

17 Dec '22

Revision 24b26f8bd6a49c855eec417a6585d44c9458e3ec changed FreeBSD (and DragonFly) not to use /proc any longer. Hence we also do not need the exe_link variable on those two platforms, either. Avoid declaring it there. (This avoids a compiler warning about an unused variable with GCC 12.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1833

2 1

[PATCH 0/1] MR1831: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Gerald Pfeifer (＠gerald) 17 Dec '22

17 Dec '22

find_device_from_devnode was unnecessarily guarded by HAVE_SYS_INOTIFY_H, alas its use in process_monitor_event was not, so linking failed. Simply make find_device_from_devnode generally available. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1831

3 2

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 17 Dec '22

17 Dec '22

On Thu Dec 15 20:00:54 2022 +0000, Etaash Mathamsetty wrote: > you should mark them as todo in the code for the tests then I can do so, but before semi stub implementation even more tests are failing. See description. Should i squash mark all tests as todo and remove the markers with semi stub commit? Thanks for your help. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19782

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Dec '22

17 Dec '22

I also think you should squash c4e27bd0483c0a1fb872111b6c03b9ad240d85da (mark tests as todo) and d02be967f9cca0805b5eeaef6a74b3ec51a67619 (add tests) into one commit -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19781

1 0

Re: [PATCH v6 0/41] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Alex Henrie (＠alexhenrie) 17 Dec '22

17 Dec '22

On Sat Dec 17 00:00:58 2022 +0000, Gerald Pfeifer wrote: > Any chance you can cherry pick > https://gitlab.winehq.org/wine/wine/-/commit/6ddda5b130481c89dae3750597452f… > ? > Git/Gitlab and me are not friends yet, and I already spent hours > (literally!) on this. :-( You've just got to learn how to use Git. One way to fix your branch: `git pull -ri https://gitlab.winehq.org/wine/wine.git master` Change all but the first commit to "squash", edit the commit message until it looks right, and then force-push. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1810#note_19775

1 0

Re: [PATCH v6 0/41] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Gerald Pfeifer (＠gerald) 17 Dec '22

17 Dec '22

On Fri Dec 16 23:23:09 2022 +0000, Rémi Bernon wrote: > I don't have a strong opinion, although I tend to prefer having > variables declared in one place, especially for small functions like > this. In any case it's an unrelated and unnecessary change here. Any chance you can cherry pick https://gitlab.winehq.org/wine/wine/-/commit/6ddda5b130481c89dae3750597452f… ? Git/Gitlab and me are not friends yet, and I already spent hours (literally!) on this. :-( -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1810#note_19774

1 0

Re: [PATCH v6 0/41] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H - closed
by Gerald Pfeifer (＠gerald) 16 Dec '22

16 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1810

1 0

[PATCH v3 0/1] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Gerald Pfeifer (＠gerald) 16 Dec '22

16 Dec '22

find_device_from_devnode was guarded by HAVE_SYS_INOTIFY_H, alas its use in process_monitor_event was not, so linking failed. On the way reduce the scope of a variable (which makes sense per se and avoids introducing a compiler warning with this change). -- v3: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H https://gitlab.winehq.org/wine/wine/-/merge_requests/1810

3 4

Re: [PATCH 0/2] MR31: shell32: Only call HCR_GetFolderAttributes with simple pidls - closed
by Fabian Maurer (＠DarkShadow44) 16 Dec '22

16 Dec '22

This merge request was closed by Fabian Maurer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/31

1 0

Re: [PATCH 0/2] MR31: shell32: Only call HCR_GetFolderAttributes with simple pidls
by Fabian Maurer (＠DarkShadow44) 16 Dec '22

16 Dec '22

Obsolete now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/31#note_19768

1 0

Re: [PATCH v2 0/3] MR1830: Fixing some debugger tests when run on Windows. - approved
by Alexandre Julliard (＠julliard) 16 Dec '22

16 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1830

1 0

Re: [PATCH v3 0/2] MR1829: user32/tests: Don't expect WM_DISPLAYCHANGE with the default display mode. - approved
by Alexandre Julliard (＠julliard) 16 Dec '22

16 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1829

1 0

Re: [PATCH v2 0/3] MR1794: Improvements to ntdll.Rtl*ByteSwap(). - approved
by Alexandre Julliard (＠julliard) 16 Dec '22

16 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1794

1 0

Re: [PATCH v3 0/3] MR1826: shell32: Add partial ControlPanel GetAttributesOf implementation. - approved
by Alexandre Julliard (＠julliard) 16 Dec '22

16 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1826

1 0

[PATCH v4 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Nikolay Sivov (＠nsivov) 16 Dec '22

16 Dec '22

-- v4: d3dx9: Partially implement D3DXFillCubeTextureTX(). d3dx9: Fix ARGB texture fills with negative component values. d3dx9/tests: Add a helper to compare filled cube textures. d3dx9: Partially implement D3DXFillTextureTX(). d3dx9: Create parameter evaluator for texture shaders. d3dx9/preshader: Set input table size for texture shaders. https://gitlab.winehq.org/wine/wine/-/merge_requests/1682

2 6

[PATCH 0/1] MR1828: winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB.
by Rémi Bernon (＠rbernon) 16 Dec '22

16 Dec '22

The check was dropped in e392e0ac2846edc25610723c19d6a796372017e1, leaving the dwFlags variable unused. I have no idea if it was indeed unnecessary or if it was dropped by mistake but either we need to keep the check, or we should remove the variable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1828

3 3

[PATCH 0/3] MR1830: Fixing some debugger tests when run on Windows.
by eric pouech (＠epo) 16 Dec '22

16 Dec '22

Since test errors reported in MR!1823, I gave a spin at scheding some light on these errors. This series shall fix a couple of them, even there are still a couple standing (eg. https://testbot.winehq.org/JobDetails.pl?Key=127712). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1830

2 3

[PATCH v2 0/2] MR1829: user32/tests: Don't expect WM_DISPLAYCHANGE with the default display mode.
by Rémi Bernon (＠rbernon) 16 Dec '22

16 Dec '22

It looks like the behavior changes when only this test is run vs when it is run as part of the winetest suite. This is probably because ChangeDisplaySettingsExW only sends the message the first time it is called (since boot?). Having other tests run before it, one of them probably changed display settings already and we're not getting the message anymore. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53894 -- v2: user32/tests: Use %d to print last_bpp instead of %u. user32/tests: Don't expect WM_DISPLAYCHANGE with the default display mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/1829

2 2

[PATCH 0/1] MR1829: user32/tests: Don't expect WM_DISPLAYCHANGE with the default display mode.
by Rémi Bernon (＠rbernon) 16 Dec '22

16 Dec '22

It looks like the behavior changes when only this test is run vs when it is run as part of the winetest suite. This is probably because ChangeDisplaySettingsExW only sends the message the first time it is called (since boot?). Having other tests run before it, one of them probably changed display settings already and we're not getting the message anymore. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53894 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1829

3 2

[PATCH v2 0/3] MR1826: shell32: Add partial ControlPanel GetAttributesOf implementation.
by Piotr Caban (＠piotr) 16 Dec '22

16 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52394 -- v2: shell32: Fix SHChangeNotify test failures. shell32: Add partial ControlPanel GetAttributesOf implementation. shell32: Store NameSpace registry path in global variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/1826

2 3

[PATCH 0/9] MR895: msxml3/tests: Filter attributes tests by version.
by Daniel Lehman (＠dlehman25) 16 Dec '22

16 Dec '22

Based on patch from Damjan Jovanovic <damjan.jov(a)gmail.com> https://bugs.winehq.org/show_bug.cgi?id=53531 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/895

2 10

[PATCH 0/1] MR1827: ntdll: Add basic support for application configuration files
by Johnny Cai (＠jaihysc) 15 Dec '22

15 Dec '22

Some applications have a `<name>.exe.config` file with the element `<probing>` to specify additional directories to search for assemblies. As it is not handled in wine, these applications fail to load. To keep this commit simple, it only supports probing. The other parts of the application configuration file are unimplemented. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1827

2 1

[PATCH v2 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 15 Dec '22

15 Dec '22

## Summary Tests for UrlFixupW and semi stub function implementaion. ## Test results - Tests are 100% ok on my local WIN 10 pc. Wine test bot seems to be okay too. - Wine tests on debian machine | function type | result | | ------ | ------ | | stub | 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **200** failures), 0 skipped. | | semi stub| 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **100** failures), 0 skipped. | ## Todos For follow up merge request(s). - [ ] Add more tests for priority investigation, who url scheme fix up is working on windows. - [ ] Implement missing parts of fix up. ## Conclusion Semi stub implementation is an improvement to the existing solution. A grep showed that wine internals do not call this function, therefore it should not introduce any new bugs. Windows applications using/relying on the function should now work better, if not they may reveal already existing bugs. -- v2: shlwapi/tests: Mark tests as todo for UrlFixupW. https://gitlab.winehq.org/wine/wine/-/merge_requests/1825

2 3

Re: [PATCH v2 0/1] MR1823: dlls/kernel32/test: Fix a debugger test failing on Windows. - approved
by Alexandre Julliard (＠julliard) 15 Dec '22

15 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1823

1 0

Re: [PATCH v7 0/1] MR1774: urlmon: Pass correct parameter to realloc (Coverity) - approved
by Alexandre Julliard (＠julliard) 15 Dec '22

15 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1774

1 0

Re: [PATCH v3 0/1] MR1822: po: Update Catalan translation. - approved
by Alexandre Julliard (＠julliard) 15 Dec '22

15 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1822

1 0

Re: [PATCH v6 0/3] MR1820: bcrypt: Use privkey if pubkey is absent in key_asymmetric_encrypt(). - approved
by Alexandre Julliard (＠julliard) 15 Dec '22

15 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1820

1 0

Re: [PATCH v3 0/1] MR1821: bcrypt: Use volatile type cast to zero magic values before free. - approved
by Alexandre Julliard (＠julliard) 15 Dec '22

15 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1821

1 0

Re: [PATCH v2 0/1] MR1819: win32u: Set the width and height when creating a caret from an existing bitmap. - approved
by Alexandre Julliard (＠julliard) 15 Dec '22

15 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1819

1 0

Re: [PATCH v2 0/1] MR1816: win32u: Account for 16-bit instances in find_class(). - approved
by Alexandre Julliard (＠julliard) 15 Dec '22

15 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1816

1 0

Re: [PATCH v2 0/5] MR1818: jscript/mshtml: Ref leak fixes. - approved
by Alexandre Julliard (＠julliard) 15 Dec '22

15 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1818

1 0

[PATCH 0/2] MR1826: shell32: Add partial ControlPanel GetAttributesOf implementation.
by Piotr Caban (＠piotr) 15 Dec '22

15 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52394 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1826

2 2

[PATCH 0/2] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 15 Dec '22

15 Dec '22

## Summary Tests for UrlFixupW and semi stub function implementaion. ## Test results - Tests are 100% ok on my local WIN 10 pc. Wine test bot seems to be okay too. - Wine tests on debian machine | function type | result | | ------ | ------ | | stub | 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **200** failures), 0 skipped. | | semi stub| 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **100** failures), 0 skipped. | ## Todos For follow up merge request(s). - [ ] Add more tests for priority investigation, who url scheme fix up is working on windows. - [ ] Implement missing parts of fix up. ## Conclusion Semi stub implementation is an improvement to the existing solution. A grep showed that wine internals do not call this function, therefore it should not introduce any new bugs. Windows applications using/relying on the function should now work better, if not they may reveal already existing bugs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825

4 6

[PATCH v6 0/1] MR1774: urlmon: Pass correct parameter to realloc (Coverity)
by Fabian Maurer (＠DarkShadow44) 15 Dec '22

15 Dec '22

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v6: urlmon: Pass correct parameter to realloc and simplify code (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/1774

3 2

[PATCH v2 0/1] MR1822: po: Update Catalan translation.
by Alex Henrie (＠alexhenrie) 15 Dec '22

15 Dec '22

-- v2: po: Update Catalan translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1822

2 1

[PATCH v5 0/1] MR1774: urlmon: Pass correct parameter to realloc (Coverity)
by Fabian Maurer (＠DarkShadow44) 15 Dec '22

15 Dec '22

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v5: urlmon: Pass correct parameter to realloc and simplify code (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/1774

3 3

[PATCH 0/1] MR1823: dlls/kernel32/test: Fix a debugger test failing on Windows.
by eric pouech (＠epo) 15 Dec '22

15 Dec '22

Testing: kernel32:debugger, there's sometimes the following error: debugger.c:1760: Test failed: unexpected instruction pointer 778B2A0C Current test code has a workaround when this happens on last thread, but this is clearly not sufficient. Fix the test so that it grabs the thread context only in a place we're sure it's in stopped state at breakpoint instruction. (Current code likely catches cases where the thread is in bp signal handling). Rewrote the test to be in more logical order. Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53143 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1823

4 4

[PATCH v3 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Nikolay Sivov (＠nsivov) 15 Dec '22

15 Dec '22

-- v3: d3dx9: Partially implement D3DXFillCubeTextureTX(). d3dx9: Fix ARGB texture fills with negative component values. d3dx9/tests: Add a helper to compare filled cube textures. d3dx9: Partially implement D3DXFillTextureTX(). d3dx9: Create parameter evaluator for texture shaders. d3dx9/preshader: Set input table size for texture shaders. https://gitlab.winehq.org/wine/wine/-/merge_requests/1682

3 10

[PATCH v5 0/3] MR1820: bcrypt: Use privkey if pubkey is absent in key_asymmetric_encrypt().
by Paul Gofman (＠gofman) 15 Dec '22

15 Dec '22

-- v5: bcrypt/tests: Test BCRYPT_PAD_NONE encryption result in test_rsa_encrypt(). bcrypt: Set pubkey from privkey in key_asymmetric_import(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1820

4 6

[PATCH v2 0/1] MR1821: bcrypt: Use volatile type cast to zero magic values before free.
by Paul Gofman (＠gofman) 15 Dec '22

15 Dec '22

The compiler may optimize out the assignment before free and then second free on the bcrypt handle finds magic values in the freed memory. -- v2: bcrypt: Use SecureZeroMemory() to zero magic values before free. https://gitlab.winehq.org/wine/wine/-/merge_requests/1821

2 2

[PATCH 0/1] MR1821: bcrypt: Use volatile type cast to zero magic values before free.
by Paul Gofman (＠gofman) 15 Dec '22

15 Dec '22

The compiler may optimize out the assignment before free and then second free on the bcrypt handle finds magic values in the freed memory. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1821

4 3

[PATCH v4 0/3] MR1820: bcrypt: Use privkey if pubkey is absent in key_asymmetric_encrypt().
by Paul Gofman (＠gofman) 15 Dec '22

15 Dec '22

-- v4: bcrypt/tests: Test BCRYPT_PAD_NONE encryption result in test_rsa_encrypt(). bcrypt: Set pubkey from privkey in key_asymmetric_import(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1820

2 3

[PATCH v3 0/3] MR1820: bcrypt: Use privkey if pubkey is absent in key_asymmetric_encrypt().
by Paul Gofman (＠gofman) 15 Dec '22

15 Dec '22

-- v3: bcrypt/tests: Test BCRYPT_PAD_NONE encryption result in test_rsa_encrypt(). bcrypt: Use privkey if pubkey is absent in key_asymmetric_encrypt(). bcrypt: Return correct error from key_asymmetric_encrypt() if key is missing. https://gitlab.winehq.org/wine/wine/-/merge_requests/1820

2 4

[PATCH 0/5] MR1818: jscript/mshtml: Ref leak fixes.
by Gabriel Ivăncescu (＠insn) 15 Dec '22

15 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1818

3 6

[PATCH 0/1] MR1816: win32u: Account for 16-bit instances in find_class().
by Sven Baars (＠sbaars) 15 Dec '22

15 Dec '22

This mimics the condition in the server. Fixes a regression introduced by 9b9d818252fe1a47f3ca52d028dc10d52fa33597. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53384 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1816

3 2

[PATCH v2 0/2] MR1820: bcrypt: Use privkey if pubkey is absent in key_asymmetric_encrypt().
by Paul Gofman (＠gofman) 15 Dec '22

15 Dec '22

-- v2: bcrypt/tests: Test BCRYPT_PAD_NONE encryption result in test_rsa_encrypt(). bcrypt: Use privkey if pubkey is absent in key_asymmetric_encrypt(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1820

4 5

[PATCH v2 0/1] MR1778: dwrite: Handle memory allocation failure in bidi_compute_bracket_pairs (cppcheck).
by Alex Henrie (＠alexhenrie) 15 Dec '22

15 Dec '22

-- v2: dwrite: Handle memory allocation failure in bidi_compute_bracket_pairs (cppcheck). https://gitlab.winehq.org/wine/wine/-/merge_requests/1778

3 2

[PATCH 0/1] MR1819: win32u: Set the width and height when creating a caret from an existing bitmap.
by Zebediah Figura (＠zfigura) 15 Dec '22

15 Dec '22

This was omitted in b8732c80b11. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53485 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1819

3 2

[PATCH 0/1] MR1822: po: Update Catalan translation.
by Alex Henrie (＠alexhenrie) 15 Dec '22

15 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1822

2 1

[PATCH v4 0/1] MR1774: Coverity fixes
by Fabian Maurer (＠DarkShadow44) 15 Dec '22

15 Dec '22

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v4: https://gitlab.winehq.org/wine/wine/-/merge_requests/1774

3 4

[PATCH 0/2] MR1820: bcrypt: Use privkey if pubkey is absent in key_asymmetric_encrypt().
by Paul Gofman (＠gofman) 15 Dec '22

15 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1820

2 2

Re: [PATCH v2 0/1] MR1817: bcrypt: Do not error out for GNUTLS_ECC_CURVE_SECP384R1 in key_export_ecc(). - approved
by Alexandre Julliard (＠julliard) 14 Dec '22

14 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1817

1 0

Re: [PATCH v2 0/1] MR1805: dswave: Don't force a calling convention on internal functions. - approved
by Alexandre Julliard (＠julliard) 14 Dec '22

14 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1805

1 0

2025

2024

2023

2022

wine-gitlab