- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR1675: shell32: Don't use GetProcAddress for GetOpenFileName[AW]. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1675

1 0

Re: [PATCH v2 0/1] MR1678: include: Move wdbgexts.h from dbghelp to include. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1678

1 0

Re: [PATCH v2 0/1] MR1679: wiaservc: Remove unused function wiaservc_strdup. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1679

1 0

Re: [PATCH v2 0/1] MR1646: comctl32: Annotate (Re)Alloc with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1646

1 0

Re: [PATCH v3 0/3] MR1643: Wshom network script support - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1643

1 0

Re: [PATCH v2 0/1] MR1680: win32u: Use WMCHAR_MAP_SENDMESSAGE for NtUserSendMessage. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1680

1 0

Re: [PATCH v2 0/2] MR1673: qasf/asfreader: Do not store the media type passed to IFileSourceFilter::Load(). - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1673

1 0

Re: [PATCH v2 0/2] MR1667: winevulkan: Get rid of direct Unix calls. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1667

1 0

Re: [PATCH v2 0/1] MR1669: po: Update Dutch translation for joy.cpl. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1669

1 0

Re: [PATCH v2 0/1] MR1547: mmdevapi/tests: Mark some more capture tests as flaky. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1547

1 0

[PATCH v5 0/3] MR1662: winegstreamer: Map MF_SD_LANGUAGE to ISO 639-1 for QuickTime media.
by Shaun Ren (＠shaunren) 05 Dec '22

05 Dec '22

This behaviour is expected by games such as Borderlands 3. -- v5: mfplay/tests: Add tests for MF_SD_LANGUAGE. winegstreamer: Map MF_SD_LANGUAGE to ISO 639-1 for QuickTime media. https://gitlab.winehq.org/wine/wine/-/merge_requests/1662

3 4

Re: [PATCH v2 0/1] MR1663: wbemprox: Provide accurate SMBIOS serial number. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1663

1 0

Re: [PATCH v3 0/6] MR1672: localspl: Port handles and AddPritntProcessor support - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1672

1 0

Re: [PATCH v2 0/1] MR1671: wineps: Add print processor stub. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1671

1 0

Re: [PATCH v2 0/2] MR1670: winprint: bug fixes - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1670

1 0

[PATCH v2 0/1] MR1181: wpcap: Build pcap_address structure from IP_ADAPTER_UNICAST_ADDRESS.
by Hans Leidekker (＠hans) 05 Dec '22

05 Dec '22

-- v2: wpcap: Build pcap_address structure from IP_ADAPTER_UNICAST_ADDRESS. https://gitlab.winehq.org/wine/wine/-/merge_requests/1181

2 1

[PATCH v4 0/3] MR1662: winegstreamer: Map MF_SD_LANGUAGE to ISO 639-1.
by Shaun Ren (＠shaunren) 05 Dec '22

05 Dec '22

This behaviour is expected by games such as Borderlands 3. -- v4: mfplay/tests: Add tests for MF_SD_LANGUAGE. winegstreamer: Map MF_SD_LANGUAGE to ISO 639-1 for QuickTime media. https://gitlab.winehq.org/wine/wine/-/merge_requests/1662

2 4

[PATCH 0/2] MR1687: ncrypt: Implement NCryptExportKey() and NCryptSignHash().
by Hans Leidekker (＠hans) 05 Dec '22

05 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53966 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1687

2 2

Re: [PATCH v13 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jacek Caban (＠jacek) 05 Dec '22

05 Dec '22

I wasn't sure about allow_blocking handling while trying to review the patch patch, so I ended up writing a few more tests, see the attached [patch](/uploads/c88db6158ef0c07c447cd7968f4af3e2/test.diff). It looks like that part still needs closer look, it works on Windows: https://testbot.winehq.org/JobDetails.pl?Key=127208 but fails with this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1268#note_18696

1 0

[PATCH 0/1] MR54: vkd3d-shader/hlsl: Initialize static variables to 0 by default.
by Francisco Casas (＠fcasas) 05 Dec '22

05 Dec '22

We are currently not initializing static values to zero by default. Consider the following shader: ```hlsl static float4 va; float4 main() : sv_target { return va; } ``` we get the following output: ``` ps_5_0 dcl_output o0.xyzw dcl_temps 2 mov r0.xyzw, r1.xyzw mov o0.xyzw, r0.xyzw ret ``` where r1.xyzw is not initialized. This patch solves this by assigning the static variable the value of an uint 0, and thus, relying on complex broadcasts. This seems to be the behaviour of the the native compiler, since it retrieves the following error on a shader that lacks an initializer on a data type with object components: ``` error X3017: cannot convert from 'uint' to 'struct <unnamed>' ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/54

4 14

Re: [PATCH v3 0/1] MR1630: wineusb.sys: Add support for TransferBufferMDL. - approved
by Zebediah Figura (＠zfigura) 05 Dec '22

05 Dec '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1630

1 0

Re: [PATCH v4 0/3] MR1529: winegstreamer: Implement media_object_SetInputType for WMV decoder. - approved
by Zebediah Figura (＠zfigura) 05 Dec '22

05 Dec '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1529

1 0

[PATCH v3 0/3] MR1662: winegstreamer: Map MF_SD_LANGUAGE to ISO 639-1.
by Shaun Ren (＠shaunren) 05 Dec '22

05 Dec '22

This behaviour is expected by games such as Borderlands 3. -- v3: mfplay/tests: Add tests for MF_SD_LANGUAGE. https://gitlab.winehq.org/wine/wine/-/merge_requests/1662

3 5

[PATCH 0/6] MR1664: Actually start enabling long integral types in wined3d.
by eric pouech (＠epo) 05 Dec '22

05 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1664

3 7

[PATCH 0/1] MR1677: quartz/tests: Remove redundant null check from testfilter_JoinFilterGraph.
by Alex Henrie (＠alexhenrie) 05 Dec '22

05 Dec '22

On Windows, wcsdup(NULL) always returns NULL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1677

3 2

Re: [PATCH v4 0/3] MR1529: winegstreamer: Implement media_object_SetInputType for WMV decoder. - approved
by Rémi Bernon (＠rbernon) 05 Dec '22

05 Dec '22

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1529

1 0

[PATCH v3 0/3] MR1683: loader: Support GDB hooking, and expose ld.so and PE modules in a wine-specific link map.
by Rémi Bernon (＠rbernon) 05 Dec '22

05 Dec '22

This makes it possible to debug Wine application in GDB almost like any other Unix application. Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074. -- v3: ntdll: Maintain a PE module link map and expose it to GDB. https://gitlab.winehq.org/wine/wine/-/merge_requests/1683

2 5

[PATCH 0/8] MR1582: winhttp: Read server reply in send_request().
by Paul Gofman (＠gofman) 05 Dec '22

05 Dec '22

It turns out that WinHttpReceiveResponse() completes synchronously in async mode (unless recursive request for handling authorization or redirect is involved). Some apps depend on that and do not wait for WINHTTP_CALLBACK_STATUS_HEADERS_AVAILABLE, calling WinHttpQueryHeaders() or WinHttpWebSocketCompleteUpgrade() right after calling WinHttpReceiveResponse, relying on that to finish synchronously. My initial out of tree testing shows that no network communication is performed during WinHttpReceiveResponse() call (when recursive request is not involved). I tested that by inserting a wait between WinHttpSendRequest and WinHttpReceiveResponse and disabling network connection during the wait. WinHttpReceiveResponse still succeeds on Windows. I think the above means that the actual response receiving from server is performed during WinHttpSendRequest. WinHttpReceiveResponse is not a complete no-op however. As shown by the existing tests the notifications related to receiving response are still delivered during WinHttpReceiveResponse (albeit in the same thread). Also WinHttpReceiveResponse affects request state: querying headers or upgrading to websocket without calling WinHttpReceiveResponse does not succeed. When redirect is involved, all the WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE, WINHTTP_CALLBACK_STATUS_RESPONSE_RECEIVED and WINHTTP_CALLBACK_STATUS_REDIRECT notifications are delivered synchronously from the calling thread. Then, the new request send notifications and response receiving notifications are delivered from the new thread. An interesting case is when WinHttpReceiveResponse is called from SendRequest callbacks in async mode. If WinHttpReceiveResponse is called from WINHTTP_CALLBACK_STATUS_SENDING_REQUEST or WINHTTP_CALLBACK_STATUS_REQUEST_SENT (i. e., when request is not complete yet), calling WinHttpReceiveResponse() suddenly succeeds an shows the following message sequence (that is partially reflected in the tests I am adding): - calling WinHttpReceiveResponse from WINHTTP_CALLBACK_STATUS_SENDING_REQUEST (which is already called on the async thread on Win10, thread A). Win8 queues WINHTTP_CALLBACK_STATUS_SENDING_REQUEST synchronously and goes async a bit later. - WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE, thread A; - WinHttpReceiveResponse() returns to the caller WINHTTP_CALLBACK_STATUS_REQUEST_SENT callback; returning from user callback; - WINHTTP_CALLBACK_STATUS_REQUEST_SENT, thread A; - WINHTTP_CALLBACK_STATUS_SENDREQUEST_COMPLETE (another thread, although the sequence is probably synced; I am not implementing this part and calling this callback from the same thread A); - WINHTTP_CALLBACK_STATUS_RESPONSE_RECEIVED in thread A; - WINHTTP_CALLBACK_STATUS_HEADERS_AVAILABLE in thread A. So the receive_response() state RECEIVE_RESPONSE_SEND_INCOMPLETE is primarily needed to handle this case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1582

5 14

[PATCH v2 0/1] MR1685: wine.inf: Register winprint print processor.
by Piotr Caban (＠piotr) 05 Dec '22

05 Dec '22

I'm not sure what's the best way of registering print processor. The alternative is to register winprint in winspool when driver is added. -- v2: winprint: Register winprint print processor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1685

3 3

[PATCH v3 0/4] MR1635: jscript: Implement a Garbage Collector to deal with circular references.
by Gabriel Ivăncescu (＠insn) 05 Dec '22

05 Dec '22

Implement a basic GC based on the mark-and-sweep algorithm, without requiring manually specifying "roots", which vastly simplifies the management. For now, it is triggered every 30 seconds since it last finished, on a new object initialization. Better heuristics could be used in the future. The comments in the code should hopefully understand the high level logic of this approach without boilerplate details. I've tested it on FFXIV launcher (along with other patches from Proton to have it work) and it stops the massive memory leak successfully by itself, so at least it does its job properly. The last patch in the MR is just an optimization for a *very* common case. For artificial testing, one could use something like: ```javascript function leak() { var a = {}, b = {}; a.b = b; b.a = a; } ``` which creates a circular ref and will leak when the function returns. It also introduces and makes use of a "heap_stack", which prevents stack overflows on long chains. -- v3: jscript: Create the source function's 'prototype' prop object on demand. jscript: Run the garbage collector every 30 seconds on a new object jscript: Implement CollectGarbage(). jscript: Implement a Garbage Collector to deal with circular references. https://gitlab.winehq.org/wine/wine/-/merge_requests/1635

3 7

[PATCH 0/1] MR1680: win32u: Use WMCHAR_MAP_SENDMESSAGE for NtUserSendMessage.
by Sven Baars (＠sbaars) 05 Dec '22

05 Dec '22

This fixes a regression introduced by d42888f07c6e3e491c99bb5c8b62b568264e990c. Before this commit SendMessage* also used WMCHAR_MAP_SENDMESSAGE. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52877 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1680

3 2

[PATCH 0/1] MR1685: wine.inf: Register winprint print processor.
by Piotr Caban (＠piotr) 05 Dec '22

05 Dec '22

I'm not sure what's the best way of registering print processor. The alternative is to register winprint in winspool when driver is added. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1685

3 2

[PATCH v2 0/3] MR1683: loader: Support GDB hooking, and expose ld.so and PE modules in a wine-specific link map.
by Rémi Bernon (＠rbernon) 05 Dec '22

05 Dec '22

This makes it possible to debug Wine application in GDB almost like any other Unix application. Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074. -- v2: ntdll: Maintain a PE module link map and expose it to GDB. loader: Expose a shadow copy of ld.so link map to GDB. https://gitlab.winehq.org/wine/wine/-/merge_requests/1683

3 5

[PATCH 0/2] MR1667: winevulkan: Get rid of direct Unix calls.
by Jacek Caban (＠jacek) 05 Dec '22

05 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1667

4 5

[PATCH 0/1] MR1646: comctl32: Annotate (Re)Alloc with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 05 Dec '22

05 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1646

4 3

Re: [PATCH v4 0/1] MR1602: rpcrt4: Use standard C functions for memory allocation. - approved
by Huw Davies (＠huw) 05 Dec '22

05 Dec '22

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1602

1 0

Re: [PATCH v12 0/6] MR42: vkd3d-shader/hlsl: Some fixes.
by Giovanni Mascellani (＠giomasce) 05 Dec '22

05 Dec '22

Giovanni Mascellani (@giomasce) commented about tests/object-references.shader_test: > + Texture2D tex2; > + float3 aa; > +}; > + > +float4 main() : sv_target > +{ > + struct apple a = {tex, tex, 1.0, 2.0, 3.0}; > + > + a.aa += f; > + return a.aa.xyzx; > +} > + > +[test] > +uniform 0 float 10.0 > +todo draw quad > +todo probe (0, 0) rgba (11.0, 12.0, 13.0, 11.0) I just noticed that the the PE shader runner fails an assertion when running this test inside Wine, using `VKD3D_TEST_PLATFORM=windows` and native `d3dcompiler`: ``` Assertion failed: root_signature_desc.NumParameters <= ARRAY_SIZE(root_params), file ../vkd3d/tests/shader_runner_d3d12.c, line 227 ``` @fcasas, could you have a look? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/42#note_18636

1 0

[PATCH 0/3] MR1683: loader: Support GDB hooking, and expose ld.so and PE modules in a wine-specific link map.
by Rémi Bernon (＠rbernon) 05 Dec '22

05 Dec '22

This makes it possible to debug Wine application in GDB almost like any other Unix application. Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1683

3 4

[PATCH v2 0/8] MR1628: Draft: ntdll: Implement Low Fragmentation Heap.
by Rémi Bernon (＠rbernon) 05 Dec '22

05 Dec '22

Not completely sure if it's worth having for 8.0, but opening this to share the target I'm trying to reach. -- v2: ntdll: Implement Low Fragmentation Heap. ntdll: Introduce per-thread free lists for heap blocks. ntdll: Introduce a new BLOCK_FLAG_SPLIT heap block flag. ntdll: Introduce a new subheap thread affinity field. ntdll: Introduce a new heap block_init_used helper. ntdll: Introduce a new heap free_list_init helper. ntdll: Count allocations and automatically enable LFH. ntdll: Implement HeapCompatibilityInformation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1628

3 9

[PATCH v2 0/3] MR1643: Wshom network script support
by Robert Wilhelm (＠sloper42) 05 Dec '22

05 Dec '22

-- v2: wshom.ocx: Implement WshNetwork2_Invoke. wshom.ocx: Implement WshNetwork2_GetIDsOfNames. wshom.ocx: Downgrade FIXME to WARN for unsupported interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/1643

3 6

[PATCH 0/8] MR1684: d3d10/effect: Further improvements to expressions support.
by Nikolay Sivov (＠nsivov) 05 Dec '22

05 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1684

2 8

[PATCH 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Nikolay Sivov (＠nsivov) 05 Dec '22

05 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682

2 6

[PATCH 0/1] MR1547: mmdevapi/tests: Mark some more capture tests as flaky.
by Sven Baars (＠sbaars) 05 Dec '22

05 Dec '22

Two instances of these three tests failing can be found here: https://gitlab.winehq.org/sbaars/wine/-/jobs/5998 https://test.winehq.org/data/c937155ff6100c6ec2d8d1873dc7878041856e1a/linux… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1547

5 4

[PATCH v7 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) 05 Dec '22

05 Dec '22

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v4: Don't reimplement SHBindToParent. -- v7: shell32/tests: Add SHBindToFolderIDListParent tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 8

Re: [PATCH v2 0/3] MR1616: loader: In macOS preloader, manually set 'environ' to work around a bug in macOS 12 and later.
by Brendan Shanks (＠bshanks) 05 Dec '22

05 Dec '22

On Sat Dec 3 08:33:04 2022 +0000, Huw Davies wrote: > Yes, this is from the build dir. I'm setting > `DYLD_FALLBACK_LIBRARY_PATH` in `.winewrapper` to avoid the issue of > `/bin/sh` stripping the `DYLD_` variables, which worked before the > mentioned commit. Ah ok I've reproduced the problem, looking into it -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1616#note_18602

1 0

[PATCH 0/1] MR1679: wiaservc: Remove unused function wiaservc_strdup.
by Alex Henrie (＠alexhenrie) 05 Dec '22

05 Dec '22

This function has not been used since commit ee9698c55f647a3e9fea0ea71b2d01d6b91c430c. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1679

2 1

Re: [PATCH v4 0/1] MR1602: rpcrt4: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 05 Dec '22

05 Dec '22

The test crash was indeed unrelated and was fixed by commit e09c93de7bd4f27b41f572a4a79d9df190c63c6f. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1602#note_18598

1 0

[PATCH 0/1] MR1678: include: Move wdbgexts.h from dbghelp to include.
by Alex Henrie (＠alexhenrie) 05 Dec '22

05 Dec '22

This file is a public header in the Windows SDK. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1678

2 1

[PATCH 0/2] MR1676: winecfg: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 05 Dec '22

05 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1676

2 2

[PATCH 0/1] MR1675: shell32: Don't use GetProcAddress for GetOpenFileName[AW].
by Alex Henrie (＠alexhenrie) 05 Dec '22

05 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1675

3 2

[PATCH v2 0/1] MR1668: wineconsole: Let the created console's title be the command's name.
by eric pouech (＠epo) 04 Dec '22

04 Dec '22

The title was set to 'wineconsole.exe' instead of the name of the created process. conhost.exe loads its per application configuration from the console's title. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- v2: wineconsole: Set launched process name as created console title. https://gitlab.winehq.org/wine/wine/-/merge_requests/1668

2 2

[PATCH 0/1] MR1668: wineconsole: Let the created console's title be the command's name.
by eric pouech (＠epo) 04 Dec '22

04 Dec '22

The title was set to 'wineconsole.exe' instead of the name of the created process. conhost.exe loads its per application configuration from the console's title. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1668

3 2

[PATCH 0/2] MR1673: qasf/asfreader: Do not store the media type passed to IFileSourceFilter::Load().
by Zebediah Figura (＠zfigura) 03 Dec '22

03 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1673

2 2

[PATCH 0/1] MR1663: wbemprox: Provide accurate SMBIOS serial number.
by Mohamad Al-Jaf (＠maljaf) 03 Dec '22

03 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1663

3 2

[PATCH v2 0/6] MR1672: localspl: Port handles and AddPritntProcessor support
by Piotr Caban (＠piotr) 03 Dec '22

03 Dec '22

-- v2: localspl: Add AddPrintProcessor implementation. winspool: Implement print processor validation in AddPrinter. localspl: Support Port handles in EndDocPrinter. localspl: Partially support Port handles in StartDocPrinter. localspl: Support Port handles in WritePrinter. https://gitlab.winehq.org/wine/wine/-/merge_requests/1672

3 7

[PATCH 0/1] MR1671: wineps: Add print processor stub.
by Piotr Caban (＠piotr) 03 Dec '22

03 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1671

3 2

[PATCH 0/2] MR1670: winprint: bug fixes
by Piotr Caban (＠piotr) 03 Dec '22

03 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1670

3 3

[PATCH 0/6] MR1672: localspl: Port handles and AddPritntProcessor support
by Piotr Caban (＠piotr) 03 Dec '22

03 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1672

2 6

[PATCH 0/1] MR1669: po: Update Dutch translation for joy.cpl.
by Floris Renaud (＠jkfloris) 03 Dec '22

03 Dec '22

Signed-off-by: Floris Renaud <jkfloris(a)dds.nl> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1669

2 1

[PATCH v4 0/1] MR1638: ntoskrnl.exe: use KeQueryMaximumProcessorCountEx for KeQueryMaximumProcessorCount.
by Etaash Mathamsetty (＠etaash.mathamsetty) 03 Dec '22

03 Dec '22

this fixes a typo in one of my previously merged patches -- v4: ntoskrnl.exe: Use KeQueryMaximumProcessorCountEx for KeQueryMaximumProcessorCount. https://gitlab.winehq.org/wine/wine/-/merge_requests/1638

2 1

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Jacek Caban (＠jacek) 03 Dec '22

03 Dec '22

> Can we get rid of direct calls now? :wink: I sure hope so. :wink: I created !1667. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18564

1 0

Re: [PATCH v2 0/3] MR1616: loader: In macOS preloader, manually set 'environ' to work around a bug in macOS 12 and later.
by Huw Davies (＠huw) 03 Dec '22

03 Dec '22

On Sat Dec 3 04:33:26 2022 +0000, Brendan Shanks wrote: > Hmm, and this worked correctly before? Are you running from the build directory? > I didn't realize this before, but any DYLD_ environment variables will > be stripped when running from the build directory, because `./wine` or > `./wine64` is a shell script, and system binaries (including `/bin/sh`) > ignore/strip `DYLD_` env vars. But if you edit `wine`/`wine64` and > set/export `DYLD_FALLBACK_LIBRARY_PATH` inside the script, it works. > Or, if you install Wine and then run it from there, `wine`/`wine64` is a > binary, so `DYLD_FALLBACK_LIBRARY_PATH` works correctly. > I did some tests with the preloader and couldn't find any cases where it > loses or mishandles the environment variables. Yes, this is from the build dir. I'm setting `DYLD_FALLBACK_LIBRARY_PATH` in `.winewrapper` to avoid the issue of `/bin/sh` stripping the `DYLD_` variables, which worked before the mentioned commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1616#note_18558

1 0

[PATCH v3 0/1] MR1626: kernelbase: Workaround for linux-side redirection.
by Michel Zou (＠xantares) 03 Dec '22

03 Dec '22

Patch from @bernhardu Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51813 ``` 1016195.340:0114:0118:Call KERNEL32.GetFileType(00000014) ret=1022e621 1016195.340:0114:0118:Call ntdll.NtQueryVolumeInformationFile(00000014,0060f598,0060f590,00000008,00000004) ret=7b01f4a5 1016195.340:0114:0118:Ret ntdll.NtQueryVolumeInformationFile() retval=00000000 ret=7b01f4a5 1016195.340:0114:0118:Ret KERNEL32.GetFileType() retval=00000001 ret=1022e621 1016195.340:0114:0118:Call KERNEL32.GetFileInformationByHandle(00000014,0060f608) ret=1022e6ac 1016195.340:0114:0118:Call ntdll.NtQueryInformationFile(00000014,0060f508,0060f528,00000068,00000012) ret=7b01eacc 1016195.340:0114:0118:trace:file:NtQueryInformationFile (0x14,0x60f508,0x60f528,0x00000068,0x00000012) 1016195.340:0114:0118:Ret ntdll.NtQueryInformationFile() retval=c0000024 ret=7b01eacc 1016195.340:0114:0118:Call ntdll.RtlNtStatusToDosError(c0000024) ret=7b01eae3 1016195.340:0114:0118:Ret ntdll.RtlNtStatusToDosError() retval=00000006 ret=7b01eae3 1016195.340:0114:0118:Ret KERNEL32.GetFileInformationByHandle() retval=00000000 ret=1022e6ac ``` Allocation of the fd structure, fd->unix_name is set to NULL: ``` 1697 fd->unix_name = NULL; #0 alloc_fd_object () at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:1697 #1 0x000056259dd386d8 in create_anonymous_fd (fd_user_ops=fd_user_ops@entry=0x56259dda4900 <file_fd_ops>, unix_fd=unix_fd@entry=28, user=user@entry=0x56259f42db70, options=options@entry=32) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:2074 #2 0x000056259dd3b477 in create_file_for_fd (fd=28, access=1074790400, sharing=sharing@entry=3) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/file.c:152 #3 0x000056259dd3b874 in req_alloc_file_handle (req=0x56259f27b768, reply=0x7ffc518872e0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/file.c:730 #4 0x000056259dd594b3 in call_req_handler (thread=thread@entry=0x56259f27b620) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/request.c:309 ``` Because unix_name is not set no file information get returned: ``` 2780 if (fd->unix_name) #0 req_get_handle_unix_name (req=<optimized out>, reply=0x7ffc518872e0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:2780 #1 0x000056259dd594b3 in call_req_handler (thread=thread@entry=0x56259f432020) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/request.c:309 ... #0 wine_server_call (req_ptr=0x62fac0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/server.c:286 #1 0xf7b98514 in server_get_unix_name (handle=handle@entry=0x14, unix_name=unix_name@entry=0x62fb94) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/file.c:1776 #2 0xf7ba3b1f in NtQueryInformationFile (handle=0x14, io=0x60f568, ptr=0x60f588, len=104, class=FileAllInformation) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/file.c:4177 #3 0xf7bbd679 in __wine_syscall_dispatcher () at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/signal_i386.c:153 ... ``` https://github.com/python/cpython/blob/99fcf1505218464c489d419d4500f126b6d6… https://github.com/python/cpython/blob/99fcf1505218464c489d419d4500f126b6d6… -- v3: kernelbase: Workaround for linux-side redirection. https://gitlab.winehq.org/wine/wine/-/merge_requests/1626

3 15

Re: [PATCH v2 0/3] MR1616: loader: In macOS preloader, manually set 'environ' to work around a bug in macOS 12 and later.
by Brendan Shanks (＠bshanks) 03 Dec '22

03 Dec '22

On Sat Dec 3 04:33:26 2022 +0000, Huw Davies wrote: > commit 588e5554252 is preventing a 32-bit build on Mojave from finding > the 32-bit libfreetype.6.dylib which I have in a non-standard location. > I suspect that DYLD_FALLBACK_LIBRARY_PATH is somehow being lost. Hmm, and this worked correctly before? Are you running from the build directory? I didn't realize this before, but any DYLD_ environment variables will be stripped when running from the build directory, because `./wine` or `./wine64` is a shell script, and system binaries (including `/bin/sh`) ignore/strip `DYLD_` env vars. But if you edit `wine`/`wine64` and set/export `DYLD_FALLBACK_LIBRARY_PATH` inside the script, it works. Or, if you install Wine and then run it from there, `wine`/`wine64` is a binary, so `DYLD_FALLBACK_LIBRARY_PATH` works correctly. I did some tests with the preloader and couldn't find any cases where it loses or mishandles the environment variables. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1616#note_18544

1 0

[PATCH 0/3] MR1662: winegstreamer: Map MF_SD_LANGUAGE to ISO 639-1.
by Shaun Ren (＠shaunren) 03 Dec '22

03 Dec '22

This behaviour is expected by games such as Borderlands 3. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1662

3 4

[PATCH v5 0/6] MR1588: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) 03 Dec '22

03 Dec '22

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number or at least something like "Not Specified" and not NULL. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- v5: windows.system.profile.systemmanufacturers: Implement ISmbiosInformationStatics_get_SerialNumber. https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

5 10

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Alexandre Julliard (＠julliard) 03 Dec '22

03 Dec '22

> * direct call: 5761 > * unpatched Wine: 13933 > * ret.diff: 6823 (55% time spent in \__wine_unix_call_dispatcher, 29% in PE vkGetPhysicalDeviceProperties) > > Looks impressive! Thanks, committed as 0aae4b05633cb9b38eb37cc662f5a3aadb3ce108. Can we get rid of direct calls now? :wink: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18536

1 0

Re: [PATCH v3 0/5] MR1622: d3d10/effect: Add support for more instructions. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1622

1 0

Re: [PATCH v6 0/3] MR1542: winegstreamer: Get MF_SD_LANGUAGE and (for QT demuxer only) MF_SD_STREAM_NAME. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1542

1 0

Re: [PATCH v2 0/1] MR1654: mfplat: Clear the clsid pointer in MFTEnum to avoid invalid free. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1654

1 0

[PATCH v7 0/2] MR1618: gdiplus: improve performance of GdipScaleMatrix
by Bartosz Kosiorek (＠gang65) 02 Dec '22

02 Dec '22

-- v7: gdiplus: improve performance of matrix multiplication by unrolling loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/1618

4 10

Re: [PATCH v3 0/8] MR1659: localspl: Add support for Job handles. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1659

1 0

Re: [PATCH v2 0/1] MR1623: rpcrt4/tests: Don't use an array of pointers in test_conf_complex_struct. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1623

1 0

Re: [PATCH v2 0/1] MR1653: msvcrt: Use operator_delete to free _Condition_variable queue nodes. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1653

1 0

Re: [PATCH v2 0/1] MR1640: mshtml: Fix realloc size vs element count mixup. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1640

1 0

Re: [PATCH v2 0/1] MR1647: mshtml: Annotate nsalloc with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1647

1 0

Re: [PATCH v2 0/1] MR1644: include: Annotate SnmpUtilMem(Re)Alloc with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1644

1 0

Re: [PATCH v3 0/1] MR1645: include: Annotate ber_(alloc_t|bvdup|init) with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1645

1 0

Re: [PATCH v2 0/11] MR1649: configure,winemac: Various macOS cleanups - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1649

1 0

Re: [PATCH v3 0/1] MR1651: ntdll: Trace the name of critical sections which are released while not acquired. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1651

1 0

Re: [PATCH v3 0/8] MR1629: ntdll: Finish heap refactoring in preparation for LFH support. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1629

1 0

Re: [PATCH v2 0/1] MR1655: inetcomm: Allocate PROPVARIANT memory with CoTaskMemAlloc. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1655

1 0

Re: [PATCH v2 0/1] MR1656: user32: Avoid freeing invalid pointers in WIN_CreateWindowEx. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1656

1 0

Re: [PATCH v2 0/1] MR1657: kernel32/tests: Avoid releasing invalid path pointer. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1657

1 0

Re: [PATCH v2 0/1] MR1658: advapi32/tests: Only free GetSecurityInfo pointer on success. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1658

1 0

Re: [PATCH v2 0/1] MR1648: d3d9/tests: Do not test the alpha channel in test_multisample_get_front_buffer_data(). - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1648

1 0

Re: [PATCH v2 0/3] MR1650: wined3d: Misc patches. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1650

1 0

Re: [PATCH v2 0/1] MR1652: winspool: Define copy_file() only if CUPS is available. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1652

1 0

Re: [PATCH v2 0/5] MR1617: Some more preparation before enabling long types in wined3d. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1617

1 0

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Jinoh Kang (＠iamahuman) 02 Dec '22

02 Dec '22

> Would it help to return to the return address already on the PE stack? Are we sure it's never clobbered? > I guess that moving the ret address to rcx and push rcx / ret might be the same performance-wise as pushq 0x70(%rcx), ret. Yes, skipping rcx save will break existing tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18485

1 0

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Zebediah Figura (＠zfigura) 02 Dec '22

02 Dec '22

On Fri Dec 2 20:30:47 2022 +0000, **** wrote: > Paul Gofman replied on the mailing list: > ``` > On 12/2/22 14:25, Gabriel Ivăncescu (@insn) wrote: > > On Fri Dec 2 18:57:30 2022 +0000, Jacek Caban wrote: > >>> This should help a bit more, does it make a difference for you? > >> My previous test wasn't really good for measuring it. > >> I hacked a micro-benchmark, which confirms that the patch improves > >> performance a lot. It was visible when doing "real" Vulkan > >> vkGetPhysicalDeviceProperties calls in a loop, but even cleaner when I > >> changed it further to make Unix side to be no-op. It closes most of the > >> gap between direct call and __wine_unix_call_dispatcher. Times recorded > >> for no-op calls: > >> - direct call: 5761 > >> - unpatched Wine: 13933 > >> - ret.diff: 6823 (55% time spent in __wine_unix_call_dispatcher, 29% in > >> PE vkGetPhysicalDeviceProperties) > >> Looks impressive! > > @gofman This isn't about setting it in rcx or not, it's about > mispairing `call`s and `ret`s, which basically means 100% mispredicted > because CPUs are optimized for it, so it couldn't do any speculative > execution past the return before. > > > Yes, I figured that much. Yet the attached diff removes the return > address from rcx in wine_syscall_dispatcher(), so I thought it makes > sense to note that it will break things. > ``` Would it help to return to the return address already on the PE stack? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18480

3 2

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Gabriel Ivăncescu (＠insn) 02 Dec '22

02 Dec '22

On Fri Dec 2 18:57:30 2022 +0000, Jacek Caban wrote: > > This should help a bit more, does it make a difference for you? > My previous test wasn't really good for measuring it. > I hacked a micro-benchmark, which confirms that the patch improves > performance a lot. It was visible when doing "real" Vulkan > vkGetPhysicalDeviceProperties calls in a loop, but even cleaner when I > changed it further to make Unix side to be no-op. It closes most of the > gap between direct call and __wine_unix_call_dispatcher. Times recorded > for no-op calls: > - direct call: 5761 > - unpatched Wine: 13933 > - ret.diff: 6823 (55% time spent in __wine_unix_call_dispatcher, 29% in > PE vkGetPhysicalDeviceProperties) > Looks impressive! @gofman This isn't about setting it in rcx or not, it's about mispairing `call`s and `ret`s, which basically means 100% mispredicted because CPUs are optimized for it, so it couldn't do any speculative execution past the return before. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18478

2 1

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Jacek Caban (＠jacek) 02 Dec '22

02 Dec '22

> This should help a bit more, does it make a difference for you? My previous test wasn't really good for measuring it. I hacked a micro-benchmark, which confirms that the patch improves performance a lot. It was visible when doing "real" Vulkan vkGetPhysicalDeviceProperties calls in a loop, but even cleaner when I changed it further to make Unix side to be no-op. It closes most of the gap between direct call and __wine_unix_call_dispatcher. Times recorded for no-op calls: - direct call: 5761 - unpatched Wine: 13933 - ret.diff: 6823 (55% time spent in __wine_unix_call_dispatcher, 29% in PE vkGetPhysicalDeviceProperties) Looks impressive! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18474

1 0

[PATCH v2 0/5] MR1622: d3d10/effect: Add support for more instructions.
by Nikolay Sivov (＠nsivov) 02 Dec '22

02 Dec '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: d3d10/effect: Add 'frc' instruction support for expressions. d3d10/effect: Add 'rcp' instruction support for expressions. d3d10/effect: Add 'div' instruction support for expressions. d3d10/effect: Add 'ftob' instruction support for expressions. d3d10/effect: Partially implement updates through value expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1622

3 7

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by mbriar (＠mbriar) 02 Dec '22

02 Dec '22

> ret.diff > >This should help a bit more, does it make a difference for you? This does seem to help significantly, from 48000 up to 62000 ops/s. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18467

1 0

[PATCH v6 0/2] MR1618: gdiplus: improve performance of GdipScaleMatrix
by Bartosz Kosiorek (＠gang65) 02 Dec '22

02 Dec '22

-- v6: gdiplus: improve performance of matrix multiplication by unrolling loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/1618

3 4

[PATCH v2 0/4] MR1635: jscript: Implement a Garbage Collector to deal with circular references.
by Gabriel Ivăncescu (＠insn) 02 Dec '22

02 Dec '22

Implement a basic GC based on the mark-and-sweep algorithm, without requiring manually specifying "roots", which vastly simplifies the management. For now, it is triggered every 30 seconds since it last finished, on a new object initialization. Better heuristics could be used in the future. The comments in the code should hopefully understand the high level logic of this approach without boilerplate details. I've tested it on FFXIV launcher (along with other patches from Proton to have it work) and it stops the massive memory leak successfully by itself, so at least it does its job properly. The second patch in the MR is just an optimization for a *very* common case. For artificial testing, one could use something like: ```javascript function leak() { var a = {}, b = {}; a.b = b; b.a = a; } ``` which creates a circular ref and will leak when the function returns. It also introduces and makes use of a "heap_stack", which prevents stack overflows on long chains. -- v2: jscript: Create the source function's 'prototype' prop object on demand. jscript: Run the garbage collector every 30 seconds on a new object jscript: Implement CollectGarbage(). jscript: Implement a Garbage Collector to deal with circular references. https://gitlab.winehq.org/wine/wine/-/merge_requests/1635

2 4

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

On Fri Dec 2 16:22:01 2022 +0000, Jacek Caban wrote: > In a Vulkan sample that I previously used to measure the impact on > command buffers, I can see a really nice improvement. If I disable all > direct calls, overhead drops from __wine_syscall_dispatcher ~8% > (measured in Wine without your recent patches) to 1.05% (and <0.2% for > __wine_syscall_dispatcher, so not related to winevulkan). That compares > to 0.6% for direct Unix calls. FPS differences roughly match that. It > looks promising. [ret.diff](/uploads/4cc909db6cfc3d4029b8a8bcec669de5/ret.diff) This should help a bit more, does it make a difference for you? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18459

2 1

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Jacek Caban (＠jacek) 02 Dec '22

02 Dec '22

On Fri Dec 2 10:52:41 2022 +0000, mbriar wrote: > Hello, > I've compared a windows build of > [vkoverhead](https://github.com/zmike/vkoverhead) test case 92, which > uses descriptor buffers, on latest wine from git. I'm getting a score of > around 48000 operations per second without this patch, and around 84000 > with this patch using direct calls, so still almost a 2x difference. > FWIW, a linux build without using wine gets around 320000 in the same > test, all using the RADV vulkan driver. > I haven't tested it with actual games yet, but I expect it to still have > a noticeable effect on CPU-bound games with vkd3d-proton. In a Vulkan sample that I previously used to measure the impact on command buffers, I can see a really nice improvement. If I disable all direct calls, overhead drops from __wine_syscall_dispatcher ~8% (measured in Wine without your recent patches) to 1.05% (and <0.2% for __wine_syscall_dispatcher, so not related to winevulkan). That compares to 0.6% for direct Unix calls. FPS differences roughly match that. It looks promising. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18458

1 0

[PATCH v5 0/2] MR1618: gdiplus: improve performance of GdipScaleMatrix
by Bartosz Kosiorek (＠gang65) 02 Dec '22

02 Dec '22

-- v5: gdiplus: improve performance of matrix multiplication by unrolling loop. gdiplus: improve performance of GdipScaleMatrix https://gitlab.winehq.org/wine/wine/-/merge_requests/1618

3 4

2025

2024

2023

2022

wine-gitlab