- wine-gitlab - winehq.org

[PATCH v5 0/3] MR1542: winegstreamer: Get MF_SD_LANGUAGE and (for QT demuxer only) MF_SD_STREAM_NAME.
by Paul Gofman (＠gofman) 02 Dec '22

02 Dec '22

-- v5: mfplay/tests: Add MF_SD_LANGUAGE and MF_SD_STREAM_NAME value tests. winegstreamer: Extract stream name from QT demuxer private data. winegstreamer: Query stream tags and set MF_SD_LANGUAGE attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/1542

2 3

[PATCH v4 0/2] MR1618: gdiplus: improve performance of GdipScaleMatrix
by Bartosz Kosiorek (＠gang65) 02 Dec '22

02 Dec '22

-- v4: gdiplus: improve performance of matrix multiplication by unrolling loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/1618

5 8

[PATCH v3 0/1] MR1660: mstask: Don't assume a ONCE trigger is on the current day.
by Sven Baars (＠sbaars) 02 Dec '22

02 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52994 This fixes a regression. -- v3: mstask: Don't assume a ONCE trigger is on the current day. https://gitlab.winehq.org/wine/wine/-/merge_requests/1660

2 2

[PATCH v2 0/1] MR1660: mstask: Don't assume a ONCE trigger is on the current day.
by Sven Baars (＠sbaars) 02 Dec '22

02 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52994 This fixes a regression. -- v2: mstask: Don't assume a ONCE trigger is on the current day. https://gitlab.winehq.org/wine/wine/-/merge_requests/1660

3 3

[PATCH v4 0/3] MR1542: winegstreamer: Get MF_SD_LANGUAGE and (for QT demuxer only) MF_SD_STREAM_NAME.
by Paul Gofman (＠gofman) 02 Dec '22

02 Dec '22

-- v4: mfplay/tests: Add MF_SD_LANGUAGE and MF_SD_STREAM_NAME value tests. winegstreamer: Extract stream name from QT demuxer private data. winegstreamer: Query stream tags and set MF_SD_LANGUAGE attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/1542

3 5

[PATCH 0/2] MR1635: jscript: Implement a Garbage Collector to deal with circular references.
by Gabriel Ivăncescu (＠insn) 02 Dec '22

02 Dec '22

Implement a basic GC based on the mark-and-sweep algorithm, without requiring manually specifying "roots", which vastly simplifies the management. For now, it is triggered every 30 seconds since it last finished, on a new object initialization. Better heuristics could be used in the future. The comments in the code should hopefully understand the high level logic of this approach without boilerplate details. I've tested it on FFXIV launcher (along with other patches from Proton to have it work) and it stops the massive memory leak successfully by itself, so at least it does its job properly. The second patch in the MR is just an optimization for a *very* common case. For artificial testing, one could use something like: ```javascript function leak() { var a = {}, b = {}; a.b = b; b.a = a; } ``` which creates a circular ref and will leak when the function returns. It also introduces and makes use of a "heap_stack", which prevents stack overflows on long chains. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1635

3 4

[PATCH 0/1] MR1661: appwiz.cpl: Allow installation of add-ons to be skipped.
by Owen Rudge (＠orudge) 02 Dec '22

02 Dec '22

The pop-up dialog requesting installation of Mono can be an inconvenience when automating processes involving Wine. In some cases it's also helpful to be able to install a clean Wine prefix without having Mono auto-installed as part of the prefix initialisation. This MR adds environment variables allowing the user to prevent installation of the Mono and Gecko. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1661

2 1

[PATCH 0/1] MR1660: mstask: Don't assume a ONCE trigger is on the current day.
by Sven Baars (＠sbaars) 02 Dec '22

02 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52994 This fixes a regression. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1660

3 4

Re: [PATCH v2 0/3] MR1616: loader: In macOS preloader, manually set 'environ' to work around a bug in macOS 12 and later.
by Huw Davies (＠huw) 02 Dec '22

02 Dec '22

commit 588e5554252 is preventing a 32-bit build on Mojave from finding the 32-bit libfreetype.so which I have in a non-standard location. I suspect that DYLD_FALLBACK_LIBRARY_PATH is somehow being lost. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1616#note_18434

1 0

[PATCH v10 0/7] MR1445: kernelbase: Some refactoring of the open_key() and create_key() functions.
by Sven Baars (＠sbaars) 02 Dec '22

02 Dec '22

This is in preparation of implementing all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v10: kernelbase: Always try to open the Wow6432Node in create_key() kernelbase: Restructure the create_key() loop. kernelbase: Add a fast path to create_key(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

2 7

[PATCH 0/1] MR1654: mfplat: Clear the clsid pointer in MFTEnum to avoid invalid free.
by Rémi Bernon (＠rbernon) 02 Dec '22

02 Dec '22

If no MFT are enumerated the pointer is still later freed with `CoTaskMemFree` without being initialized. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1654

3 2

[PATCH v2 0/8] MR1659: localspl: Add support for Job handles.
by Piotr Caban (＠piotr) 02 Dec '22

02 Dec '22

-- v2: winspool: Call providor in ReadPrinter implementation. localspl: Add ReadPrinter implementation. localspl: Add support for Job handles. localspl: Rename job_t structure to job_info_t. localspl: Use separate structure to store printserver handles. localspl: Use separate structure to store XcvPort and XcvMonitor handles. https://gitlab.winehq.org/wine/wine/-/merge_requests/1659

3 10

[PATCH v2 0/3] MR1631: wineusb.sys: Implement DevClass compatible id for devices with multiple interfaces.
by Ivo Ivanov (＠logos128) 02 Dec '22

02 Dec '22

Also make the device instance id unique (at least to the bus), as required by MS. It is also easily addressable by other drivers. -- v2: wineusb.sys: Add usbver, revision, busnum and portnum to PDO's instance id. wineusb.sys: Implement DevClass compatible id for devices with multiple interfaces. wineusb.sys: Pass interface and interface_index from the event data to the usb device data. https://gitlab.winehq.org/wine/wine/-/merge_requests/1631

2 3

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by mbriar (＠mbriar) 02 Dec '22

02 Dec '22

On Fri Dec 2 10:52:41 2022 +0000, Alexandre Julliard wrote: > > I'm more optimistic about 8.0. Anyway, I wouldn't mind committing it > if we need to. At the same time, since there is an active work on the > final solution, we may as well wait a few days and see how it goes. Let > me defer that to Alexandre (I think he took over that optimization work). > I've committed some fixes inspired by Rémi's work. Hopefully that will > be good enough to avoid the direct calls, can you please give it a try? Hello, I've compared a windows build of [vkoverhead](https://github.com/zmike/vkoverhead) test case 92, which uses descriptor buffers, on latest wine from git. I'm getting a score of around 48000 operations per second without this patch, and around 84000 with this patch using direct calls, so still almost a 2x difference. FWIW, a linux build without using wine gets around 320000 in the same test, all using the RADV vulkan driver. I haven't tested it with actual games yet, but I expect it to still have a noticeable effect on CPU-bound games with vkd3d-proton. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18427

1 0

[PATCH 0/1] MR1653: msvcrt: Use operator_delete to free _Condition_variable queue nodes.
by Rémi Bernon (＠rbernon) 02 Dec '22

02 Dec '22

Fwiw, HeapAlloc / HeapFree are used elsewhere in this file, but I don't think they overlap with the _Condition_variable queue nodes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1653

3 2

[PATCH 0/1] MR1623: rpcrt4/tests: Don't use an array of pointers in test_conf_complex_struct.
by Alex Henrie (＠alexhenrie) 02 Dec '22

02 Dec '22

An array of pointers isn't conformant on 64-bit and will overrun the destination buffer when unmarshalling. Since the purpose of this function is to test a conformant FC_BOGUS_STRUCT, use one that is conformant on both 32-bit and 64-bit. The revised test coincidentally reveals that there is a problem with the padding or alignment after a marshalled 16-bit enum, which will need to be addressed separately. Co-authored-by: Zebediah Figura <z.figura12(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1623

4 3

[PATCH 0/1] MR1652: winspool: Define copy_file() only if CUPS is available.
by Zebediah Figura (＠zfigura) 02 Dec '22

02 Dec '22

Avoid unused function warnings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1652

4 3

[PATCH 0/1] MR1640: mshtml: Fix realloc size vs element count mixup.
by Rémi Bernon (＠rbernon) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1640

3 2

[PATCH 0/1] MR1647: mshtml: Annotate nsalloc with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1647

3 2

[PATCH 0/1] MR1648: d3d9/tests: Do not test the alpha channel in test_multisample_get_front_buffer_data().
by Zebediah Figura (＠zfigura) 02 Dec '22

02 Dec '22

This avoids test failures on radeonsi. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1648

3 2

[PATCH 0/3] MR1650: wined3d: Misc patches.
by Zebediah Figura (＠zfigura) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1650

3 4

[PATCH v2 0/1] MR1645: include: Annotate ber_(alloc_t|bvdup|init) with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 02 Dec '22

02 Dec '22

-- v2: include: Annotate ber_(alloc_t|bvdup|init) with __WINE_(DEALLOC|MALLOC). https://gitlab.winehq.org/wine/wine/-/merge_requests/1645

3 2

[PATCH 0/8] MR1659: localspl: Add support for Job handles.
by Piotr Caban (＠piotr) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1659

2 8

[PATCH 0/1] MR1658: advapi32/tests: Only free GetSecurityInfo pointer on success.
by Rémi Bernon (＠rbernon) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1658

2 1

[PATCH 0/1] MR1657: kernel32/tests: Avoid releasing invalid path pointer.
by Rémi Bernon (＠rbernon) 02 Dec '22

02 Dec '22

The `LdrGetDllPath` is expected to fail, there's no path pointer to release. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1657

2 1

[PATCH 0/1] MR1656: user32: Avoid freeing invalid pointers in WIN_CreateWindowEx.
by Rémi Bernon (＠rbernon) 02 Dec '22

02 Dec '22

When `lpszName` is NULL or when it is a resource ID we are possibly freeing uninitialized or stack pointer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1656

2 1

[PATCH 0/1] MR1655: inetcomm: Allocate PROPVARIANT memory with CoTaskMemAlloc.
by Rémi Bernon (＠rbernon) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1655

2 1

[PATCH v2 0/8] MR1629: ntdll: Finish heap refactoring in preparation for LFH support.
by Rémi Bernon (＠rbernon) 02 Dec '22

02 Dec '22

Cleaning up and splitting subheap creation helpers and free block merge logic. Should be the last refactoring needed before LFH specific changes, as implemented in https://gitlab.winehq.org/wine/wine/-/merge_requests/1628. -- v2: ntdll: Keep subheap parent heap pointer and check for mismatches. ntdll: Move the insertion of the first block out of create_subheap. ntdll: Split create_free_block into block_init_free / insert_free_block. ntdll: Merge prev and next free heap blocks in heap_free_block. ntdll: Split heap blocks before creating or resizing used block. ntdll: Clear BLOCK_FLAG_PREV_FREE flag out of shrink_used_block. ntdll: Move heap allocation and initialization into RtlCreateHeap. ntdll: Split heap region memory allocation to allocate_region helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/1629

2 9

Re: [PATCH v4 0/3] MR1529: winegstreamer: Implement media_object_SetInputType for WMV decoder.
by Ziqing Hui (＠zhui) 02 Dec '22

02 Dec '22

v4: Rebase on top of upstream/master -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1529#note_18393

1 0

[PATCH v4 0/6] MR1588: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) 02 Dec '22

02 Dec '22

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number or at least something like "Not Specified" and not NULL. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- v4: windows.system.profile.systemmanufacturers: Implement ISmbiosInformationStatics_get_SerialNumber. windows.system.profile.systemmanufacturers/tests: Add ISmbiosInformationStatics_get_SerialNumber tests. wbemprox: Provide accurate SMBIOS serial number. https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

3 9

[PATCH v2 0/1] MR1651: ntdll: Trace the name of critical sections which are released while not acquired.
by Zebediah Figura (＠zfigura) 02 Dec '22

02 Dec '22

-- v2: ntdll: Trace the name of critical sections which are released while not acquired. https://gitlab.winehq.org/wine/wine/-/merge_requests/1651

2 1

[PATCH 0/1] MR1651: ntdll: Add a thread information class to return the Unix thread and process IDs.
by Zebediah Figura (＠zfigura) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1651

2 2

[PATCH 0/3] MR1643: Wshom network script support
by Robert Wilhelm (＠sloper42) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1643

3 4

[PATCH 0/11] MR1649: configure,winemac: Various macOS cleanups
by Brendan Shanks (＠bshanks) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1649

2 11

[PATCH v3 0/1] MR872: winex11: Always initialize escape.drawable in X11DRV_GetDC().
by Zebediah Figura (＠zfigura) 02 Dec '22

02 Dec '22

-- v3: winex11: Always initialize escape.drawable in X11DRV_GetDC(). https://gitlab.winehq.org/wine/wine/-/merge_requests/872

3 3

[PATCH v2 0/1] MR1638: ntoskrnl.exe: use KeQueryMaximumProcessorCountEx for KeQueryMaximumProcessorCount.
by Etaash Mathamsetty (＠etaash.mathamsetty) 02 Dec '22

02 Dec '22

this fixes a typo in one of my previously merged patches -- v2: ntoskrnl.exe: use KeQueryMaximumProcessorCountEx for KeQueryMaximumProcessorCount. https://gitlab.winehq.org/wine/wine/-/merge_requests/1638

2 1

[PATCH v3 0/3] MR1529: winegstreamer: Implement media_object_SetInputType for WMV decoder.
by Ziqing Hui (＠zhui) 02 Dec '22

02 Dec '22

-- v3: winegstreamer: Implement media_object_SetInputType for WMV decoder. winegstreamer: Add WMV support to wg_format. mf/tests: Test IMediaObject_SetInputType for WMV decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/1529

2 4

[PATCH 0/1] MR1645: include: Annotate ber_(alloc_t|bvdup|init) with __WINE_(DEALLOC_MALLOC).
by Alex Henrie (＠alexhenrie) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1645

2 1

[PATCH 0/1] MR1644: include: Annotate SnmpUtilMem(Re)Alloc with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1644

2 1

[PATCH v2 0/1] MR1630: wineusb.sys: Add support for TransferBufferMDL.
by Ivo Ivanov (＠logos128) 02 Dec '22

02 Dec '22

-- v2: wineusb.sys: Add support for TransferBufferMDL. https://gitlab.winehq.org/wine/wine/-/merge_requests/1630

2 1

[PATCH 0/1] MR1630: wineusb.sys: Add support for TransferBufferMDL.
by Ivo Ivanov (＠logos128) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1630

3 5

[PATCH 0/1] MR1201: winecrt0: Move loading of __wine_unix_call to an inline function.
by Rémi Bernon (＠rbernon) 01 Dec '22

01 Dec '22

This improves performance of unix calls a little by removing one level of indirection and a branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1201

3 4

[PATCH v5 0/14] MR1324: Draft: ntdll: Use a faster code path for unix calls.
by Rémi Bernon (＠rbernon) 01 Dec '22

01 Dec '22

-- v5: ntdll: Inline __wine_unix_call(_fast) dispatch in the syscall dispatcher. ntdll: Restore frame in return path of the x86 syscall dispatchers. winecrt0: Inline PE __wine_unix_call(_fast) function calls. ntdll: Only save non-volatile FPU registers for -nofpu syscalls. opengl32: Use __wine_unix_call_fast instead of __wine_unix_call. ntdll: Introduce a new __wine_unix_call_fast syscall. ntdll: Use -nofpu for NtQueryPerformanceCounter and NtYieldExecution. winebuild: Introduce a new -nofpu syscall spec flag. ntdll: Add support for syscall flags in the service CounterTable. ntdll: Avoid double indirection to get x86_64 syscall_frame pointer. ntdll: Check SYSCALL_HAVE_WRFSGSBASE syscall flag only for wrfsbase. ntdll: Swap %eax and %edx registers in the i386 syscall dispatcher. ntdll: Check syscall table and syscall number before saving FPU. ntdll: Use named labels for jumps in the syscall dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1324

2 17

[PATCH v2 0/4] MR1437: ntdll: Cleanup and refactor the x86_64 and i386 syscall dispatchers.
by Rémi Bernon (＠rbernon) 01 Dec '22

01 Dec '22

In preparation for https://gitlab.winehq.org/wine/wine/-/merge_requests/1324. This also begins preparation for a slightly different route than what the MR currently takes, with syscall flags eventually stored in the CounterTable rather than overusing syscall number unused bits. To do that we're checking the syscall number and loading the syscall table (keeping it in %rbx/%ebx) earlier. This assumes that %rbx isn't modified in between, for instance by the eventual `SYS_arch_prctl` syscall, but I believe it is the case? -- v2: ntdll: Check SYSCALL_HAVE_WRFSGSBASE syscall flag only for wrfsbase. ntdll: Swap %eax and %edx registers in the i386 syscall dispatcher. ntdll: Check syscall table and syscall number before saving FPU. ntdll: Use named labels for jumps in the syscall dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1437

4 9

Re: [PATCH v2 0/1] MR1642: po: Update Lithuanian translation - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1642

1 0

Re: [PATCH v2 0/1] MR1641: mountmgr.sys: Allocate UNICODE_STRING buffers with RtlAllocateHeap. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1641

1 0

Re: [PATCH v2 0/2] MR1639: inetcomm: Fix some heap mismatches. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1639

1 0

Re: [PATCH v2 0/1] MR1632: taskschd: Use CRT functions for remaining heap allocations. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1632

1 0

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

> I'm more optimistic about 8.0. Anyway, I wouldn't mind committing it if we need to. At the same time, since there is an active work on the final solution, we may as well wait a few days and see how it goes. Let me defer that to Alexandre (I think he took over that optimization work). I've committed some fixes inspired by Rémi's work. Hopefully that will be good enough to avoid the direct calls, can you please give it a try? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18342

1 0

Re: [PATCH v2 0/1] MR1523: configure.ac: Log pkg-config error messages when it fails. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1523

1 0

Re: [PATCH v2 0/1] MR1634: mshtml: Rename EVENTID_INVALID to EVENTID_INVALID_ID. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1634

1 0

Re: [PATCH v3 0/2] MR1606: d3dx9/preshader: Handle input register table. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1606

1 0

Re: [PATCH v2 0/1] MR1636: msi: Use the wcsdup function instead of reimplementing it. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1636

1 0

Re: [PATCH v3 0/1] MR1619: user32: Add stub for GetPointerInfo(). - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1619

1 0

Re: [PATCH v6 0/3] MR1502: winevulkan: wow64 memory mapping using VK_EXT_external_memory_host - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1502

1 0

Re: [PATCH v2 0/1] MR1627: winevulkan: Fix handling pointers to pointer-size variables in 32-bit thunks. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1627

1 0

Re: [PATCH v2 0/1] MR1624: include: Define __stat64. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1624

1 0

Re: [PATCH v3 0/1] MR1510: winebus.sys: Use the device path instead of the udev_device pointer to match devices. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1510

1 0

Re: [PATCH v3 0/5] MR1608: localspl: Use providor for print jobs implementation - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1608

1 0

Re: [PATCH v2 0/1] MR1615: wineusb.sys: Do not close the device handle more than once. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1615

1 0

Re: [PATCH v2 0/3] MR1616: loader: In macOS preloader, manually set 'environ' to work around a bug in macOS 12 and later. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1616

1 0

Re: [PATCH v2 0/1] MR1621: include: Annotate WlanAllocateMemory with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1621

1 0

Re: [PATCH v3 0/1] MR1620: services: Use standard C functions for memory allocation. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1620

1 0

Re: [PATCH v2 0/6] MR1569: quartz/tests: More tests for MPEG layer-3 decoder. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1569

1 0

Re: [PATCH v2 0/1] MR1579: wmvcore/tests: Test subtype and formattype for IWMMediaProps. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1579

1 0

Re: [PATCH v3 0/7] MR1571: wmvcore: Move async reader to wmvcore and add more threading tests. - approved
by Alexandre Julliard (＠julliard) 01 Dec '22

01 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1571

1 0

[PATCH v6 0/1] MR1393: ntoskrnl.exe: Add semi-stub for KeIpiGenericCall.
by Etaash Mathamsetty (＠etaash.mathamsetty) 01 Dec '22

01 Dec '22

fixes bug: https://bugs.winehq.org/show_bug.cgi?id=48989 -- v6: ntoskrnl.exe: Add semi-stub for KeIpiGenericCall. https://gitlab.winehq.org/wine/wine/-/merge_requests/1393

2 1

[PATCH 0/1] MR1642: po: Update Lithuanian translation
by Aurimas Fišeras (＠AurimasF) 01 Dec '22

01 Dec '22

Update Lithuanian translation -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1642

2 1

[PATCH 0/1] MR1641: mountmgr.sys: Allocate UNICODE_STRING buffers with RtlAllocateHeap.
by Rémi Bernon (＠rbernon) 01 Dec '22

01 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1641

2 1

[PATCH 0/5] MR1622: d3d10/effect: Add support for more instructions.
by Nikolay Sivov (＠nsivov) 01 Dec '22

01 Dec '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1622

3 9

[PATCH 0/2] MR1639: inetcomm: Fix some heap mismatches.
by Rémi Bernon (＠rbernon) 01 Dec '22

01 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1639

2 2

[PATCH 0/1] MR1634: mshtml: Rename EVENTID_INVALID to EVENTID_INVALID_ID.
by Gabriel Ivăncescu (＠insn) 01 Dec '22

01 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1634

3 2

[PATCH 0/1] MR1638: ntoskrnl.exe: use KeQueryMaximumProcessorCountEx for KeQueryMaximumProcessorCount.
by Etaash Mathamsetty (＠etaash.mathamsetty) 01 Dec '22

01 Dec '22

this fixes a typo in one of my previously merged patches -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1638

2 1

[PATCH 0/1] MR1637: server: Fix buffer overrun in map_view handler.
by Alex Henrie (＠alexhenrie) 01 Dec '22

01 Dec '22

Because of padding at the end of the struct, sizeof(*view) is greater than offsetof(struct memory_view, name[0]). Change the allocation to overallocate slightly instead of underallocating slightly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1637

3 3

[PATCH v5 0/3] MR1502: Draft: winevulkan: wow64 memory mapping using VK_EXT_external_memory_host
by Jacek Caban (＠jacek) 01 Dec '22

01 Dec '22

This MR implements memory mapping for wow64 using VK_EXT_external_memory_host. This has some problems (more below), but overall, it looks promising as a stopgap. It passes D3D tests and works fine in general. For proper solution, we'd need a new Vulkan extension. I experimented with a prototype extension https://github.com/KhronosGroup/Vulkan-Docs/pull/1906 and it looks like we can make it work, my WIP implementation is here https://gitlab.winehq.org/jacek/wine/-/tree/vulkan-map-placed. However, it would be nice to have a fallback working on existing drivers as well. The main problem of this MR is that it breaks Vulkan spec. The main rule it breaks is that according to spec, we should explicitly specify that we plan to use external memory when creating VkBuffer or VkImage. The problem is that we don't know if we will until we bind memory to the buffer. I tried some workarounds for that (delaying actual buffer creation, recreating buffer when needed). I got it mostly working and passing tests without validation errors, but it was more invasive than I'd like and still had other problems. I'd rather avoid that if possible. After looking at Mesa sources, I think that the way this MR breaks the spec should be harmless for its drivers. I don't have the hardware to test with Nvidia. If it works there, I'm tempted to ignore spec violation for now, given that the right path forward is VK_EXT_map_memory_placed anyway. Performance-wise, this MR is sub-optimal because we're limited in what memory types we can use. However, I ran Unigine benchmarks on radv and the difference was marginal. In case of Heaven, it was even slightly faster on wow64, which could be explained by 64-bit Vulkan driver being generally slightly faster, but the difference is too small to draw any conclusion. The last patch is not meant for (eventual) merge, but it's nice for testing the concept. It makes it possible to force using external memory in any kind of Wine build to experiment with its effects without need for wow64. To test that, just set `WINEVULKAN_EXTERNAL_MEMORY` environment variable. -- v5: winevulkan: Use VK_EXT_external_memory_host extension to map memory on wow64. winevulkan: Wrap VkDeviceMemory. winevulkan: Don't try to unwrap missing optional handle struct members. https://gitlab.winehq.org/wine/wine/-/merge_requests/1502

3 7

[PATCH 0/1] MR1632: taskschd: Use CRT functions for remaining heap allocations.
by Rémi Bernon (＠rbernon) 01 Dec '22

01 Dec '22

Fixing heap mismatches introduced with !1466. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1632

3 2

[PATCH v2 0/2] MR1618: Draft: gdiplus: improve performance of GdipScaleMatrix
by Bartosz Kosiorek (＠gang65) 01 Dec '22

01 Dec '22

-- v2: gdiplus: improve performance of matrix multiplication by unrolling loop gdiplus: improve performance of GdipScaleMatrix https://gitlab.winehq.org/wine/wine/-/merge_requests/1618

2 2

[PATCH v16 0/5] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 01 Dec '22

01 Dec '22

Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v16: https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

3 8

[PATCH v2 0/2] MR1606: d3dx9/preshader: Move register table debug names to the rest of table info.
by Nikolay Sivov (＠nsivov) 01 Dec '22

01 Dec '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: d3dx9/effect: Split parameters data from effect object. d3dx9/preshader: Handle input register table. https://gitlab.winehq.org/wine/wine/-/merge_requests/1606

3 5

[PATCH 0/1] MR1636: msi: Use the wcsdup function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 01 Dec '22

01 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1636

3 2

[PATCH 0/1] MR1633: comctl32: Use strdupAW / strdupWA helpers for CRT allocs.
by Rémi Bernon (＠rbernon) 01 Dec '22

01 Dec '22

Fixing heap mismatches introduced with !1520. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1633

2 1

[PATCH 0/7] MR1629: ntdll: Finish heap refactoring in preparation for LFH support.
by Rémi Bernon (＠rbernon) 01 Dec '22

01 Dec '22

Cleaning up and splitting subheap creation helpers and free block merge logic. Should be the last refactoring needed before LFH specific changes, as implemented in https://gitlab.winehq.org/wine/wine/-/merge_requests/1628. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1629

3 9

[PATCH v2 0/1] MR1626: kernelbase: Workaround for linux-side redirection.
by Michel Zou (＠xantares) 01 Dec '22

01 Dec '22

Patch from @bernhardu Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51813 ``` 1016195.340:0114:0118:Call KERNEL32.GetFileType(00000014) ret=1022e621 1016195.340:0114:0118:Call ntdll.NtQueryVolumeInformationFile(00000014,0060f598,0060f590,00000008,00000004) ret=7b01f4a5 1016195.340:0114:0118:Ret ntdll.NtQueryVolumeInformationFile() retval=00000000 ret=7b01f4a5 1016195.340:0114:0118:Ret KERNEL32.GetFileType() retval=00000001 ret=1022e621 1016195.340:0114:0118:Call KERNEL32.GetFileInformationByHandle(00000014,0060f608) ret=1022e6ac 1016195.340:0114:0118:Call ntdll.NtQueryInformationFile(00000014,0060f508,0060f528,00000068,00000012) ret=7b01eacc 1016195.340:0114:0118:trace:file:NtQueryInformationFile (0x14,0x60f508,0x60f528,0x00000068,0x00000012) 1016195.340:0114:0118:Ret ntdll.NtQueryInformationFile() retval=c0000024 ret=7b01eacc 1016195.340:0114:0118:Call ntdll.RtlNtStatusToDosError(c0000024) ret=7b01eae3 1016195.340:0114:0118:Ret ntdll.RtlNtStatusToDosError() retval=00000006 ret=7b01eae3 1016195.340:0114:0118:Ret KERNEL32.GetFileInformationByHandle() retval=00000000 ret=1022e6ac ``` Allocation of the fd structure, fd->unix_name is set to NULL: ``` 1697 fd->unix_name = NULL; #0 alloc_fd_object () at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:1697 #1 0x000056259dd386d8 in create_anonymous_fd (fd_user_ops=fd_user_ops@entry=0x56259dda4900 <file_fd_ops>, unix_fd=unix_fd@entry=28, user=user@entry=0x56259f42db70, options=options@entry=32) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:2074 #2 0x000056259dd3b477 in create_file_for_fd (fd=28, access=1074790400, sharing=sharing@entry=3) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/file.c:152 #3 0x000056259dd3b874 in req_alloc_file_handle (req=0x56259f27b768, reply=0x7ffc518872e0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/file.c:730 #4 0x000056259dd594b3 in call_req_handler (thread=thread@entry=0x56259f27b620) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/request.c:309 ``` Because unix_name is not set no file information get returned: ``` 2780 if (fd->unix_name) #0 req_get_handle_unix_name (req=<optimized out>, reply=0x7ffc518872e0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:2780 #1 0x000056259dd594b3 in call_req_handler (thread=thread@entry=0x56259f432020) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/request.c:309 ... #0 wine_server_call (req_ptr=0x62fac0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/server.c:286 #1 0xf7b98514 in server_get_unix_name (handle=handle@entry=0x14, unix_name=unix_name@entry=0x62fb94) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/file.c:1776 #2 0xf7ba3b1f in NtQueryInformationFile (handle=0x14, io=0x60f568, ptr=0x60f588, len=104, class=FileAllInformation) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/file.c:4177 #3 0xf7bbd679 in __wine_syscall_dispatcher () at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/signal_i386.c:153 ... ``` https://github.com/python/cpython/blob/99fcf1505218464c489d419d4500f126b6d6… https://github.com/python/cpython/blob/99fcf1505218464c489d419d4500f126b6d6… -- v2: kernelbase: Workaround for linux-side redirection. https://gitlab.winehq.org/wine/wine/-/merge_requests/1626

4 3

[PATCH 0/3] MR1631: wineusb.sys: Implement DevClass compatible id for devices with multiple interfaces.
by Ivo Ivanov (＠logos128) 01 Dec '22

01 Dec '22

Also make the device instance id unique (at least to the bus), as required by MS. It is also easily addressable by other drivers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1631

2 3

[PATCH 0/15] MR1628: Draft: ntdll: Implement Low Fragmentation Heap.
by Rémi Bernon (＠rbernon) 01 Dec '22

01 Dec '22

Not completely sure if it's worth having for 8.0, but opening this to share the target I'm trying to reach. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1628

3 16

[PATCH 0/1] MR1627: winevulkan: Fix handling pointers to pointer-size variables in 32-bit thunks.
by Jacek Caban (＠jacek) 01 Dec '22

01 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1627

3 2

[PATCH v2 0/2] MR1559: ntoskrnl.exe: Prevent blocking if kernel timer is reset in DPC.
by Ivo Ivanov (＠logos128) 01 Dec '22

01 Dec '22

KeCancelTimer (which is called via KeSetTimerEx) would block indefinitely in the DPC, while waiting for the timer to complete. Which never happens, since the internal thread pool implementation never gets the chance to wake up the "finished_event" condition variable on the DPC exit in tp_object_execute(). -- v2: ntoskrnl.exe/tests: Test resetting a kernel timer in its DPC. ntoskrnl.exe: Prevent blocking if timer is reset in DPC. https://gitlab.winehq.org/wine/wine/-/merge_requests/1559

2 2

[PATCH v3 0/6] MR1588: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) 01 Dec '22

01 Dec '22

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number or at least something like "Not Specified" and not NULL. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- v3: windows.system.profile.systemmanufacturers: Implement ISmbiosInformationStatics_get_SerialNumber. windows.system.profile.systemmanufacturers/tests: Add ISmbiosInformationStatics_get_SerialNumber tests. wbemprox: Provide accurate SMBIOS serial number. https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

4 14

[PATCH 0/1] MR1626: kernelbase: Workaround for linux-side redirection.
by xantares (＠xantares) 01 Dec '22

01 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51813 ``` 1016195.340:0114:0118:Call KERNEL32.GetFileType(00000014) ret=1022e621 1016195.340:0114:0118:Call ntdll.NtQueryVolumeInformationFile(00000014,0060f598,0060f590,00000008,00000004) ret=7b01f4a5 1016195.340:0114:0118:Ret ntdll.NtQueryVolumeInformationFile() retval=00000000 ret=7b01f4a5 1016195.340:0114:0118:Ret KERNEL32.GetFileType() retval=00000001 ret=1022e621 1016195.340:0114:0118:Call KERNEL32.GetFileInformationByHandle(00000014,0060f608) ret=1022e6ac 1016195.340:0114:0118:Call ntdll.NtQueryInformationFile(00000014,0060f508,0060f528,00000068,00000012) ret=7b01eacc 1016195.340:0114:0118:trace:file:NtQueryInformationFile (0x14,0x60f508,0x60f528,0x00000068,0x00000012) 1016195.340:0114:0118:Ret ntdll.NtQueryInformationFile() retval=c0000024 ret=7b01eacc 1016195.340:0114:0118:Call ntdll.RtlNtStatusToDosError(c0000024) ret=7b01eae3 1016195.340:0114:0118:Ret ntdll.RtlNtStatusToDosError() retval=00000006 ret=7b01eae3 1016195.340:0114:0118:Ret KERNEL32.GetFileInformationByHandle() retval=00000000 ret=1022e6ac ``` Allocation of the fd structure, fd->unix_name is set to NULL: ``` 1697 fd->unix_name = NULL; #0 alloc_fd_object () at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:1697 #1 0x000056259dd386d8 in create_anonymous_fd (fd_user_ops=fd_user_ops@entry=0x56259dda4900 <file_fd_ops>, unix_fd=unix_fd@entry=28, user=user@entry=0x56259f42db70, options=options@entry=32) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:2074 #2 0x000056259dd3b477 in create_file_for_fd (fd=28, access=1074790400, sharing=sharing@entry=3) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/file.c:152 #3 0x000056259dd3b874 in req_alloc_file_handle (req=0x56259f27b768, reply=0x7ffc518872e0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/file.c:730 #4 0x000056259dd594b3 in call_req_handler (thread=thread@entry=0x56259f27b620) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/request.c:309 ``` Because unix_name is not set no file information get returned: ``` 2780 if (fd->unix_name) #0 req_get_handle_unix_name (req=<optimized out>, reply=0x7ffc518872e0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:2780 #1 0x000056259dd594b3 in call_req_handler (thread=thread@entry=0x56259f432020) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/request.c:309 ... #0 wine_server_call (req_ptr=0x62fac0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/server.c:286 #1 0xf7b98514 in server_get_unix_name (handle=handle@entry=0x14, unix_name=unix_name@entry=0x62fb94) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/file.c:1776 #2 0xf7ba3b1f in NtQueryInformationFile (handle=0x14, io=0x60f568, ptr=0x60f588, len=104, class=FileAllInformation) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/file.c:4177 #3 0xf7bbd679 in __wine_syscall_dispatcher () at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/signal_i386.c:153 ... ``` https://github.com/python/cpython/blob/99fcf1505218464c489d419d4500f126b6d6… https://github.com/python/cpython/blob/99fcf1505218464c489d419d4500f126b6d6… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1626

3 3

[PATCH 0/1] MR1624: include: Define __stat64.
by Alex Henrie (＠alexhenrie) 01 Dec '22

01 Dec '22

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1624

3 2

[PATCH v2 0/1] MR1510: winebus.sys: Use the device path instead of the udev_device pointer to match devices.
by Zebediah Figura (＠zfigura) 01 Dec '22

01 Dec '22

The latter is not guaranteed to be equal across events, and in practice may not be. -- v2: winebus.sys: Search for added devices by devnode path in process_monitor_event(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1510

3 4

[PATCH v2 0/5] MR1608: localspl: Use providor for print jobs implementation
by Piotr Caban (＠piotr) 01 Dec '22

01 Dec '22

-- v2: winspool: Use providor for WritePrinter implementation. winspool: Use providor for print jobs implementation. localspl: Fix error handling in ScheduleJob. localspl: Return error if cups port handle is used from different threads. localspl: Add cups port extension. https://gitlab.winehq.org/wine/wine/-/merge_requests/1608

2 6

Re: [PATCH v5 0/1] MR1553: msvcrt: Fix errno set on dup from read-only file.
by xantares (＠xantares) 01 Dec '22

01 Dec '22

thanks for the help @piotr -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1553#note_18209

1 0

[PATCH v3 0/3] MR1542: winegstreamer: Get MF_SD_LANGUAGE and (for QT demuxer only) MF_SD_STREAM_NAME.
by Paul Gofman (＠gofman) 01 Dec '22

01 Dec '22

-- v3: mfplay/tests: Add MF_SD_LANGUAGE and MF_SD_STREAM_NAME value tests. winegstreamer: Extract stream name from QT demuxer private data. winegstreamer: Query stream tags and set MF_SD_LANGUAGE attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/1542

4 6

Re: [PATCH v13 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) 01 Dec '22

01 Dec '22

On Wed Nov 30 14:42:28 2022 +0000, Jason Kuo wrote: > Oops, didn't noticed that, will fix in next version. Moved the changes to first commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1268#note_18195

1 0

[PATCH v2 0/1] MR1619: user32: Add stub for GetPointerInfo().
by Paul Gofman (＠gofman) 01 Dec '22

01 Dec '22

Required by Super Arcade Racing. GetPointerInfo() can only succeed if WM_POINTER message are received, which can happen if there is a pointer device or EnableMouseInPointer(TRUE) is called. We don't currently send any WM_POINTER messages (and EnableMouseInPointer is a stub), so I hope adding a always failing stub won't break anything. -- v2: user32: Add stub for GetPointerInfo(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1619

3 3

[PATCH 0/1] MR1621: include: Annotate WlanAllocateMemory with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 01 Dec '22

01 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1621

2 1

[PATCH v2 0/1] MR1620: services: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 01 Dec '22

01 Dec '22

-- v2: services: Use standard C functions for memory allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1620

2 1

[PATCH v6 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) 01 Dec '22

01 Dec '22

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v4: Don't reimplement SHBindToParent. -- v6: shell32/tests: Add SHBindToFolderIDListParent tests. shell32: Implement SHBindToFolderIDListParent. shell32: Fix error handling in SHBindToParent. shell32/tests: Test SHBindToParent last parameter behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/566

3 5

[PATCH 0/1] MR1620: services: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 01 Dec '22

01 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1620

2 1

2025

2024

2023

2022

wine-gitlab