- wine-gitlab - winehq.org

[PATCH 0/1] MR1510: winebus.sys: Use the device path instead of the udev_device pointer to match devices.
by Zebediah Figura (＠zfigura) 23 Nov '22

23 Nov '22

The latter is not guaranteed to be equal across events, and in practice may not be. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1510

3 2

Re: [PATCH v2 0/2] MR1508: winevulkan: Union conversion and 1.3.235 spec update.
by Jacek Caban (＠jacek) 23 Nov '22

23 Nov '22

Jacek Caban (@jacek) commented about dlls/winevulkan/vulkan_thunks.c: > return (void *)out; > } > > +static inline void convert_VkDeviceOrHostAddressKHR_win32_to_host(const VkDeviceOrHostAddressKHR32 *in, VkDeviceOrHostAddressKHR *out) > +{ > + if (!in) return; > + > + out->deviceAddress = in->deviceAddress; > + out->hostAddress = (void *)UlongToPtr(in->hostAddress); FWIW, this will not do the right thing on wow64 when the address is meant to be device address. It will override the upper part of deviceAddress. It was broken in a different way before that commit by not zeroing upper 32 bits when host address should be used, so it essentially depended on caller to initialize that part. Unfortunately, I don't see a good way of solving it properly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1508#note_17182

1 0

Re: [PATCH 0/1] MR99: winevulkan: Propagate access violation from the Unix side.
by Jacek Caban (＠jacek) 23 Nov '22

23 Nov '22

I guess this can be closed, we have 572dd0b466c54 now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/99#note_17180

1 0

[PATCH 0/1] MR1523: configure.ac: Log pkg-config error messages when it fails.
by eric pouech (＠epo) 23 Nov '22

23 Nov '22

While investigating https://bugs.winehq.org/show_bug.cgi?id=53953, it may be a good idea to log any pkg-config error messages instead of ignoring them. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1523

2 1

[PATCH v3 0/2] MR1492: Load and save application-specific console settings from the registry
by Hugh McMaster (＠hmc) 23 Nov '22

23 Nov '22

On Windows, application-specific settings are stored in the registry under HKCU\Console\<path_to_app>. Our implementation of conhost.exe does not know which process is connected to it, so we need to get the full process image name before loading any application-specific console settings. To do this, we extend the server protocol to pass the process Id of the connected console process to conhost.exe. Please run tools/make_requests before merging. -- v3: conhost: Load application-specific settings using the full process image name server: Send console process ID via get_next_console_request() https://gitlab.winehq.org/wine/wine/-/merge_requests/1492

3 6

[PATCH v5 0/5] MR1278: winegstreamer: Do not destroy condition variables when a thread is waiting on them.
by Giovanni Mascellani (＠giomasce) 23 Nov '22

23 Nov '22

It is possible that a stream is destroyed while another thread is waiting on event_empty_cond or event_cond. The waiting thread should have the opportunity to be rescheduled and exit the critical section before the condition variables and the mutex are destroyed. -- v5: winegstreamer: Synchronize media source async commands and shutdown. winegstreamer: Free the GStreamer buffer when freeing a WG parser stream. winegstreamer: Synchronize access to the media source from callbacks. winegstreamer: Synchronize concurrent access to the media stream. winegstreamer: Synchronize concurrent access to the media source. https://gitlab.winehq.org/wine/wine/-/merge_requests/1278

2 5

[PATCH v4 0/5] MR1278: winegstreamer: Do not destroy condition variables when a thread is waiting on them.
by Giovanni Mascellani (＠giomasce) 23 Nov '22

23 Nov '22

It is possible that a stream is destroyed while another thread is waiting on event_empty_cond or event_cond. The waiting thread should have the opportunity to be rescheduled and exit the critical section before the condition variables and the mutex are destroyed. -- v4: winegstreamer: Synchronize media source async commands and shutdown. winegstreamer: Free the GStreamer buffer when freeing a WG parser stream. winegstreamer: Synchronize access to the media source from callbacks. winegstreamer: Synchronize concurrent access to the media stream. winegstreamer: Synchronize concurrent access to the media source. https://gitlab.winehq.org/wine/wine/-/merge_requests/1278

3 9

[PATCH v2 0/2] MR1522: mfmediaengine: Volume change.
by Bernhard Kölbl (＠besentv) 23 Nov '22

23 Nov '22

-- v2: mfmediaengine: Pass volume changes to the audio renderer. https://gitlab.winehq.org/wine/wine/-/merge_requests/1522

3 3

[PATCH 0/1] MR1515: urlmon: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 23 Nov '22

23 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1515

3 2

[PATCH 0/6] MR1506: jscript: Pass correct 'this' to callbacks called by builtins & misc fixes.
by Gabriel Ivăncescu (＠insn) 23 Nov '22

23 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1506

4 8

[PATCH 0/1] MR1500: winspool: Correctly free data allocated with GdiConvertToDevmodeW.
by Piotr Caban (＠piotr) 23 Nov '22

23 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1500

3 2

[PATCH 0/1] MR1521: rpcss: Use I_Rpc(Free|Allocate) in MIDL_user_(allocate|free).
by Rémi Bernon (＠rbernon) 23 Nov '22

23 Nov '22

In ept_map, rpcss uses TowerConstruct to allocate tower array elements. The array is later released by the generated stub code, and each element is ultimately freed using MIDL_user_free. TowerConstruct always allocate memory using I_RpcAllocate, we must use I_RpcFree to free it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1521

2 1

[PATCH v3 0/7] MR1520: comctl32: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 23 Nov '22

23 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: comctl32/listview: Use CRT allocation functions. comctl32/button: Use CRT allocation functions. comctl32/propsheet: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1520

3 8

[PATCH v2 0/7] MR1520: comctl32: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 23 Nov '22

23 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: comctl32/listview: Use CRT allocation functions. comctl32/button: Use CRT allocation functions. comctl32/propsheet: Use CRT allocation functions. comctl32/imagelist: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1520

3 8

[PATCH 0/7] MR1520: comctl32: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 23 Nov '22

23 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1520

4 10

[PATCH v9 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) 23 Nov '22

23 Nov '22

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- v9: imm32: Prevent deadlock on unload https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

3 2

[PATCH 0/1] MR1512: vbscript/tests: Fix redim tests.
by Nikolay Sivov (＠nsivov) 23 Nov '22

23 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1512

4 3

[PATCH v2 0/4] MR1427: wined3d: Add a lower size bound for the streaming buffer allocation.
by Anton Baskanov (＠baskanov) 23 Nov '22

23 Nov '22

v2: Expose wined3d_streaming_buffer_map() and wined3d_streaming_buffer_unmap() for strided data upload. -- v2: wined3d: Add a lower size bound for the streaming buffer allocation. ddraw: Use the wined3d_streaming_buffer helpers to manage the streaming index buffer. ddraw: Use the wined3d_streaming_buffer helpers to manage the streaming vertex buffer. wined3d: Factor out and expose functions to map/unmap wined3d_streaming_buffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/1427

5 8

[PATCH 0/4] MR1511: ntdll: Various heap cleanups.
by Zebediah Figura (＠zfigura) 23 Nov '22

23 Nov '22

I noticed these while trying to debug heap corruption. Rémi, if you have queued heap patches, please feel free to defer these until those are done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1511

3 5

[PATCH v15 0/7] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Bartosz Kosiorek (＠gang65) 23 Nov '22

23 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v15: gdiplus: Add GdipSetCustomLineCapStrokeCaps implementation and usage. gdiplus: fix shape of CustomLineCap created by GdipCreateAdjustableArrowCap. gdiplus: Add support for widen path with GpCustomLineCap. gdiplus: use GpPointF for drawing in widen_closed_figure gdiplus: Add GdipSetCustomLineCapBaseInset implementation. gdiplus: Remove not used LineCustomCap parameter. gdiplus: Add GdipSetCustomLineCapBaseCap implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1297

2 7

[PATCH 0/1] MR1518: mfplat: Use the iswxdigit function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 23 Nov '22

23 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1518

3 3

[PATCH 0/1] MR1517: comsvcs: Use the iswxdigit function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 23 Nov '22

23 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1517

2 1

[PATCH 0/1] MR1516: combase: Use the iswxdigit function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 23 Nov '22

23 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1516

2 1

[PATCH 0/1] MR1514: dnsapi: Use the strdup and wcsdup functions instead of reimplementing them.
by Alex Henrie (＠alexhenrie) 23 Nov '22

23 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1514

2 1

[PATCH 0/1] MR1503: wineusb.sys: Move event handling to a single thread.
by Ivo Ivanov (＠logos128) 23 Nov '22

23 Nov '22

Also fixes a segmentation fault when exiting winedevice.exe. I can file a separate bug report, but it seems related to Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 On my system the core dump can be provoked when using the bus_udev backend in winebus.sys ("Enable SDL" 0). It creates two hid devices - a mouse and a keyboard. Since it resides in the same winedevice.exe process as wineusb.sys, something similar to the above bug occurs when handling the SIGQUIT signal. The actual crash happens in the libusb event thread while waiting in pthread_cond_wait(). I'm using this for months without any issues (with a device driver which uses wineusb.sys for device access, etc.). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1503

3 3

[PATCH 0/1] MR1513: oleaut32/safearray: Fix an error code when trying to redim fixed arrays.
by Nikolay Sivov (＠nsivov) 23 Nov '22

23 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1513

2 1

[PATCH v2 0/6] MR1423: winegstreamer: Implement profile_GetStreamByNumber, media_object_GetStreamCount, media_object_GetInputType for WMV decoder.
by Ziqing Hui (＠zhui) 23 Nov '22

23 Nov '22

These functions are needed by a steam game called Super Naughty Maid. It uses DMO wrapper filter to play WMV videos. -- v2: winegstreamer: Implement media_object_GetInputType for WMV decoder. mf/tests: Test IMediaObject_GetInputType for WMV decoder. winegstreamer: Implement media_object_GetStreamCount for WMV decoder. mf/tests: Test IMediaObject_GetStreamCount for WMV decoder. winegstreamer: Implement profile_GetStreamByNumber. https://gitlab.winehq.org/wine/wine/-/merge_requests/1423

5 12

[PATCH v3 0/5] MR1384: winegstreamer: Fix some quartz transform issues.
by Anton Baskanov (＠baskanov) 23 Nov '22

23 Nov '22

- v2: - Allocate 3 buffers instead of 100. - Add support for MFSampleExtension_Discontinuity. - v3: Destroy the queue instead of flusing it. -- v3: winegstreamer: Set the discontinuity flag in wg_transform. include: Add MFSampleExtension_Discontinuity to mfapi.h. winegstreamer: Allocate at least 3 buffers for MPEG audio in quartz parser. winegstreamer: Destroy the sample queue when stopping the quartz transform. winegstreamer: Hold the streaming lock while destroying wg_transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/1384

4 8

[PATCH 0/2] MR1504: win32u: Remove __wine_get_wgl_driver PE entry point.
by Jacek Caban (＠jacek) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1504

3 3

[PATCH v4 0/14] MR1447: mshtml: Implement performance.timing timestamps properly.
by Gabriel Ivăncescu (＠insn) 22 Nov '22

22 Nov '22

-- v4: mshtml: Implement performance.timing.msFirstPaint. mshtml: Implement performance.timing.loadEventStart & loadEventEnd. mshtml: Get rid of useless window check. mshtml: Implement performance.timing.domContentLoadedEventStart & End. mshtml: Implement performance.timing.domComplete. mshtml: Implement performance.timing.domInteractive. mshtml: Implement performance.timing.domLoading. mshtml: Implement performance.timing.responseStart & responseEnd. mshtml: Implement the remaining pre-response performance.timing props. mshtml: Implement performance.timing.unloadEventStart & unloadEventEnd. mshtml: Implement performance.timing.redirectStart. mshtml: Implement performance.timing.navigationStart. mshtml: Link the performance.timing from the window at creation. mshtml: Fix performance variant leak. https://gitlab.winehq.org/wine/wine/-/merge_requests/1447

4 17

[PATCH v3 0/1] MR1495: vbscript: Add support for redim byref.
by Jason Millard (＠jsm174) 22 Nov '22

22 Nov '22

fixes https://bugs.winehq.org/show_bug.cgi?id=53807 -- v3: vbscript: Add support for redim byref. https://gitlab.winehq.org/wine/wine/-/merge_requests/1495

4 4

[PATCH v2 0/1] MR1495: vbscript: Add support for redim byref.
by Jason Millard (＠jsm174) 22 Nov '22

22 Nov '22

fixes https://bugs.winehq.org/show_bug.cgi?id=53807 -- v2: vbscript: Add support for redim byref. https://gitlab.winehq.org/wine/wine/-/merge_requests/1495

4 3

[PATCH 0/1] MR1495: vbscript: add support for redim byref
by Jason Millard (＠jsm174) 22 Nov '22

22 Nov '22

fixes https://bugs.winehq.org/show_bug.cgi?id=53807 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1495

4 4

[PATCH v3 0/6] MR1445: kernelbase: Fixes for the shared Software\Classes registry and Wow6432Node registry in general.
by Sven Baars (＠sbaars) 22 Nov '22

22 Nov '22

This reimplements all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v3: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. ntdll: Add a KeyFlagsInformation query. https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

3 8

[PATCH v2 0/6] MR1445: kernelbase: Fixes for the shared Software\Classes registry and Wow6432Node registry in general.
by Sven Baars (＠sbaars) 22 Nov '22

22 Nov '22

This reimplements all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v2: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. ntdll: Add a KeyFlagsInformation query. kernelbase: Factor out the common parts of open_key() and create_key(). kernelbase: Reimplement create_key() using open_subkey(). kernelbase: Factor out opening a subkey. https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

3 7

[PATCH v13 0/7] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Bartosz Kosiorek (＠gang65) 22 Nov '22

22 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v13: gdiplus: Add GdipSetCustomLineCapStrokeCaps implementation and usage. gdiplus: fix shape of CustomLineCap created by GdipCreateAdjustableArrowCap. gdiplus: Add support for widen path with GpCustomLineCap. gdiplus: use GpPointF for drawing in widen_closed_figure gdiplus: Add GdipSetCustomLineCapBaseInset implementation. gdiplus: Remove not used LineCustomCap parameter. gdiplus: Add GdipSetCustomLineCapBaseCap implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1297

3 8

[PATCH v4 0/6] MR1301: Add ir50_32 video codec for winmm.
by Shaun Ren (＠shaunren) 22 Nov '22

22 Nov '22

This video codec is used by games such as Richman 4, and Zwei: The Arges Adventure. The decoder logic is based on code from the FFmpeg project. -- v4: loader/wine.inf: Enable ir50_32 video codec. ir50_32: Implement decompression to 24-bit RGB. ir50_32: Implement IV50_DecompressGetFormat. ir50_32: Implement IV50_DecompressQuery. ir50_32: Implement IV50_GetInfo. ir50_32: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/1301

4 9

[PATCH 0/3] MR1491: wined3d: Preparation to long types' migration.
by eric pouech (＠epo) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1491

4 5

[PATCH v13 0/2] MR841: ntoskrnl.exe: processor change callback stubs
by Etaash Mathamsetty (＠etaash.mathamsetty) 22 Nov '22

22 Nov '22

required for mrac anti cheat -- v13: ntoskrnl.exe: Add KeDeregisterProcessorChangeCallback stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/841

2 2

[PATCH v12 0/2] MR841: ntoskrnl.exe: processor change callback stubs
by Etaash Mathamsetty (＠etaash.mathamsetty) 22 Nov '22

22 Nov '22

required for mrac anti cheat -- v12: ntoskrnl.exe: Add KeDeregisterProcessorChangeCallback stub. ntoskrnl.exe: Add KeRegisterProcessorChangeCallback stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/841

2 2

Re: [PATCH v2 0/1] MR1507: dbghelp: Fix typos in codeview_is_type_forward(). - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1507

1 0

Re: [PATCH v2 0/2] MR1508: winevulkan: Union conversion and 1.3.235 spec update. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1508

1 0

Re: [PATCH v2 0/1] MR1505: vbscript: Fix a typo in variable name in LBound(). - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1505

1 0

Re: [PATCH v3 0/4] MR1485: kernelbase: Forward SetThreadIdealProcessor() to ntdll. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1485

1 0

Re: [PATCH v6 0/14] MR1447: mshtml: Implement performance.timing timestamps properly. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1447

1 0

Re: [PATCH v3 0/1] MR1461: ieframe: Use standard C functions for memory allocation. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1461

1 0

Re: [PATCH v4 0/1] MR1453: include: Add Stg functions declaration in propvarutil.h. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1453

1 0

Re: [PATCH v3 0/12] MR1470: kernel32: Add (Global|Local)ReAlloc tests and fix it. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1470

1 0

Re: [PATCH v2 0/1] MR1499: server: Set missing error status for get_process_image_name. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1499

1 0

Re: [PATCH v2 0/1] MR1497: xinputuap.dll: Add new dll. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1497

1 0

Re: [PATCH v2 0/1] MR1501: ntdll: Use system language as preferred, if user language is custom-unspecified. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1501

1 0

Re: [PATCH v3 0/1] MR1442: vbscript: Handle CP_UTF8 in Chr()/Asc(). - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1442

1 0

Re: [PATCH v4 0/1] MR1495: vbscript: Add support for redim byref. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1495

1 0

Re: [PATCH v2 0/2] MR1496: winebus.sys: Add more trace messages. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1496

1 0

Re: [PATCH v2 0/7] MR1490: comctl32: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1490

1 0

Re: [PATCH v2 0/2] MR1493: dinput: Prevent a potential array overflow error + remove redundant physical range values. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1493

1 0

Re: [PATCH v3 0/2] MR1474: gdi32: Get printer output file name in StartDoc. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1474

1 0

Re: [PATCH v3 0/3] MR1476: Implement GetGeoInfoEx - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1476

1 0

Re: [PATCH v2 0/1] MR1482: ucrtbase/tests: Put the calling convention inside the function pointer parentheses. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1482

1 0

Re: [PATCH v2 0/1] MR1464: oledlg: Use standard C functions for memory allocation in pastespl.c. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1464

1 0

Re: [PATCH v3 0/1] MR1486: shlwapi/tests: Use standard C functions for memory allocation in path.c. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1486

1 0

Re: [PATCH v2 0/1] MR1487: oledb32: Use standard C functions for memory allocation in rowpos.c. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1487

1 0

Re: [PATCH v3 0/1] MR1460: hhctrl: Handle memory allocation failure in GetChmString. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1460

1 0

Re: [PATCH v3 0/4] MR1466: taskschd: Remove function heap_strdupW. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1466

1 0

Re: [PATCH v2 0/1] MR1479: advapi32/tests: Avoid using GCC's typeof extension. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1479

1 0

Re: [PATCH v2 0/1] MR1481: windows.media.speech: Put the calling convention inside the function pointer parentheses. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1481

1 0

Re: [PATCH v2 0/1] MR1483: explorer: Put the calling convention inside the function pointer parentheses. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1483

1 0

Re: [PATCH v2 0/1] MR1484: kernel32/tests: Avoid using GCC's typeof extension. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1484

1 0

Re: [PATCH v2 0/1] MR1480: dinput/tests: Put the calling convention inside the function pointer parentheses. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1480

1 0

Re: [PATCH v2 0/1] MR1488: webservices: Remove unused function heap_realloc_zero. - approved
by Alexandre Julliard (＠julliard) 22 Nov '22

22 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1488

1 0

[PATCH 0/7] MR1490: comctl32: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 22 Nov '22

22 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1490

4 9

[PATCH 0/1] MR1509: ntdll: Make init_builtin_dll return a value on FreeBSD
by Gerald Pfeifer (＠gerald) 22 Nov '22

22 Nov '22

With commit 1d1690782b167f3ea24990c260665f71a0e70d1c init_builtin_dll gained a return value, alas the FreeBSD-specific code (under #ifdef) was not adjusted and still returned void. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1509

2 1

[PATCH v2 0/1] MR1442: Draft: vbscript: Handle CP_UTF8 in Chr()/Asc().
by Nikolay Sivov (＠nsivov) 22 Nov '22

22 Nov '22

-- v2: vbscript: Handle CP_UTF8 in Chr()/Asc(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1442

4 3

[PATCH v14 0/7] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Bartosz Kosiorek (＠gang65) 22 Nov '22

22 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v14: gdiplus: Add GdipSetCustomLineCapStrokeCaps implementation and usage. gdiplus: fix shape of CustomLineCap created by GdipCreateAdjustableArrowCap. gdiplus: Add support for widen path with GpCustomLineCap. gdiplus: use GpPointF for drawing in widen_closed_figure https://gitlab.winehq.org/wine/wine/-/merge_requests/1297

3 8

[PATCH v8 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) 22 Nov '22

22 Nov '22

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- v8: imm32: Prevent deadlock on unload https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

3 5

[PATCH v7 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) 22 Nov '22

22 Nov '22

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- v7: imm32: Prevent deadlock on unload https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

3 4

[PATCH 0/1] MR1505: vbscript: Fix a typo in variable name in LBound().
by Nikolay Sivov (＠nsivov) 22 Nov '22

22 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1505

3 2

[PATCH 0/2] MR1508: winevulkan: Union conversion and 1.3.235 spec update.
by Georg Lehmann (＠DadSchoorse) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1508

2 2

[PATCH v17 0/11] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 22 Nov '22

22 Nov '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. -- v17: include: Add a comment explaining why all kernel callbacks must be in user32. user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Route kernel callbacks through user32. winex11.drv: Pass a struct to x11drv_ime_set_result. winex11.drv: Pass a struct to x11drv_dnd_post_drop. winemac.drv: Route kernel callbacks through user32. wineandroid.drv: Route kernel callbacks through user32. opengl32: Route kernel callbacks through user32. winevulkan: Route kernel callbacks through user32. user32: Add NtUserDispatchCallback kernel callback. user.exe16: Move kernel callbacks to wow_callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

2 11

[PATCH 0/1] MR1507: dbghelp: Fix typos in codeview_is_type_forward().
by eric pouech (＠epo) 22 Nov '22

22 Nov '22

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1507

2 1

[PATCH v2 0/4] MR1485: kernelbase: Forward SetThreadIdealProcessor() to ntdll.
by Nikolay Sivov (＠nsivov) 22 Nov '22

22 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: kernelbase: Forward GetThreadIdealProcessorEx() to ntdll. kernelbase: Forward thread priority boost functions to ntdll. kernel32/tests: Remove workarounds for SetThreadIdealProcessor(). kernelbase: Forward SetThreadIdealProcessor() to ntdll. https://gitlab.winehq.org/wine/wine/-/merge_requests/1485

2 4

[PATCH v5 0/14] MR1447: mshtml: Implement performance.timing timestamps properly.
by Gabriel Ivăncescu (＠insn) 22 Nov '22

22 Nov '22

-- v5: mshtml: Implement performance.timing.msFirstPaint. mshtml: Implement performance.timing.loadEventStart & loadEventEnd. mshtml: Get rid of useless window check. mshtml: Implement performance.timing.domContentLoadedEventStart & End. mshtml: Implement performance.timing.domComplete. mshtml: Implement performance.timing.domInteractive. mshtml: Implement performance.timing.domLoading. mshtml: Implement performance.timing.responseStart & responseEnd. mshtml: Implement the remaining pre-response performance.timing props. mshtml: Implement performance.timing.unloadEventStart & unloadEventEnd. mshtml: Implement performance.timing.redirectStart. mshtml: Implement performance.timing.navigationStart. mshtml: Link the performance.timing from the window at creation. mshtml: Fix performance variant leak. https://gitlab.winehq.org/wine/wine/-/merge_requests/1447

2 15

[PATCH v2 0/1] MR1461: ieframe: Remove function heap_strdupW.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

-- v2: ieframe: Use standard C functions for memory allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1461

4 3

[PATCH 0/1] MR1488: webservices: Remove unused function heap_realloc_zero.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

This function has not been used since commit 105d16774432a6ab206896404ca644d9ee7e2b7e. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1488

4 3

[PATCH 0/4] MR1485: kernelbase: Forward SetThreadIdealProcessor() to ntdll.
by Nikolay Sivov (＠nsivov) 22 Nov '22

22 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1485

3 5

[PATCH 0/2] MR1493: dinput: Prevent a potential array overflow error + remove redundant physical range values.
by Ivo Ivanov (＠logos128) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1493

3 7

[PATCH v3 0/1] MR1453: include: Add Stg functions declaration in propvarutil.h.
by Biswapriyo Nath (＠Biswa96) 22 Nov '22

22 Nov '22

-- v3: include: Add Stg functions declaration in propvarutil.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/1453

2 1

[PATCH 0/1] MR1483: explorer: Put the calling convention inside the function pointer parentheses.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

As required by MSVC. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1483

3 2

[PATCH 0/1] MR1501: ntdll: Use system language as preferred, if user language is custom-unspecified.
by Nikolay Sivov (＠nsivov) 22 Nov '22

22 Nov '22

This is follow up for !1417, user language still could be set to unspecified due to later change to original MR to reset only the system locale. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1501

2 1

[PATCH 0/1] MR1497: xinputuap.dll: Add new dll.
by Rémi Bernon (＠rbernon) 22 Nov '22

22 Nov '22

Based on a patch by Yusuf Khan <yusisamerican(a)gmail.com>. Required for Halo Infinite. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1497

3 4

[PATCH 0/1] MR1499: server: Set missing error status for get_process_image_name.
by Rémi Bernon (＠rbernon) 22 Nov '22

22 Nov '22

This is supposedly fixing some games (Age of Empires II Definitive Edition) but I must say that I don't remember in which circumstances this happens. In any case the `get_process_image_name` request doesn't set any reply when `process->image` is NULL, and in which case it also doesn't set any error. Having an error status seems to be a correct fix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1499

2 1

[PATCH 0/2] MR1496: winebus.sys: Add more trace messages.
by Rémi Bernon (＠rbernon) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1496

2 2

[PATCH v2 0/1] MR1460: hhctrl: Handle memory allocation failure in GetChmString.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

-- v2: hhctrl: Handle memory allocation failure in GetChmString. https://gitlab.winehq.org/wine/wine/-/merge_requests/1460

3 2

[PATCH v6 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) 22 Nov '22

22 Nov '22

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- v6: imm32: Prevent deadlock on unload https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

4 4

[PATCH 0/1] MR1482: ucrtbase/tests: Put the calling convention inside the function pointer parentheses.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

As required by MSVC. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1482

3 2

[PATCH v2 0/2] MR1492: Load and save application-specific console settings from the registry
by Hugh McMaster (＠hmc) 22 Nov '22

22 Nov '22

On Windows, application-specific settings are stored in the registry under HKCU\Console\<path_to_app>. Our implementation of conhost.exe does not know which process is connected to it, so we need to get the full process image name before loading any application-specific console settings. To do this, we extend the server protocol to pass the process Id of the connected console process to conhost.exe. Please run tools/make_requests before merging. -- v2: conhost: Load application-specific settings using the full process image name https://gitlab.winehq.org/wine/wine/-/merge_requests/1492

2 2

[PATCH 0/2] MR1492: Load and save application-specific console settings from the registry
by Hugh McMaster (＠hmc) 22 Nov '22

22 Nov '22

On Windows, application-specific settings are stored in the registry under HKCU\Console\<path_to_app>. Our implementation of conhost.exe does not know which process is connected to it, so we need to get the full process image name before loading any application-specific console settings. To do this, we extend the server protocol to pass the process Id of the connected console process to conhost.exe. Please run tools/make_requests before merging. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1492

2 2

[PATCH v3 0/6] MR1301: Add ir50_32 video codec for winmm.
by Shaun Ren (＠shaunren) 22 Nov '22

22 Nov '22

This video codec is used by games such as Richman 4, and Zwei: The Arges Adventure. The decoder logic is based on code from the FFmpeg project. -- v3: loader/wine.inf: Enable ir50_32 video codec. ir50_32: Implement decompression to 24-bit RGB. ir50_32: Implement IV50_DecompressGetFormat. ir50_32: Implement IV50_DecompressQuery. ir50_32: Implement IV50_GetInfo. ir50_32: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/1301

3 7

[PATCH v2 0/2] MR1474: gdi32: Get printer output file name in StartDoc.
by Piotr Caban (＠piotr) 22 Nov '22

22 Nov '22

-- v2: gdi32: Get printer output file name in StartDoc. https://gitlab.winehq.org/wine/wine/-/merge_requests/1474

4 4

Re: [PATCH v8 0/3] MR1343: windows.media: Add WinRT Closed Captioning interface.
by Bernhard Kölbl (＠besentv) 22 Nov '22

22 Nov '22

On Tue Nov 22 10:05:37 2022 +0000, Mohamad Al-Jaf wrote: > Thanks for the detailed feedback and review @besentv and @rbernon. :) No problem. I actually intend to expand the Wiki article on WinRT programming but I currently don't have much time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1343#note_16909

1 0

2025

2024

2023

2022

wine-gitlab