- wine-gitlab - winehq.org

[PATCH v4 0/9] MR1448: hid: parser and HidP_SetUsageValue fix
by Matthew Tran (＠0e4ef622) 22 Nov '22

22 Nov '22

This fixes two things: * HID report descriptor parser enum for local items. Close inspection of page 40 of [Device Class Definition for HID 1.11](https://www.usb.org/document-library/device-class-definition-hid-111) reveals a jump between Designator Maximum (0101) and String Index (0111). This caused a controller of mine to not get recognized. * HidP_SetUsageValue for items that define multiple controls (with Report Count > 1). Attempting to set one value would result in HIDP_STATUS_BUFFER_TOO_SMALL. -- v4: hid: Fix HidP_(Get|Set)(Scaled)UsageValue with usage ranges and arrays. hid: Move (get|set)_usage_value around and use it for scaled values. winexinput.sys: Fix incorrect HID STRING_INDEX tag value. winebus.sys: Fix incorrect HID STRING_INDEX tag value. ntoskrnl.exe/tests: Fix incorrect HID STRING_INDEX tag value. hidparse.sys: Fix incorrect HID STRING_INDEX tag value. dinput/tests: Fix incorrect HID STRING_INDEX tag value. dinput/tests: Add more HidP_(Set|Get)UsageValue tests with array caps. dinput/tests: Add more tests for HidP_SetUsageValue. https://gitlab.winehq.org/wine/wine/-/merge_requests/1448

5 13

[PATCH 0/1] MR1481: windows.media.speech: Put the calling convention inside the function pointer parentheses.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

As required by MSVC. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1481

3 2

Re: [PATCH v2 0/1] MR1453: include: Add Stg functions declaration in propvarutil.h.
by Nikolay Sivov (＠nsivov) 22 Nov '22

22 Nov '22

This does not build, as indicated by failed CI pipeline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1453#note_16901

1 0

[PATCH v2 0/1] MR1478: jscript: Use CRT allocation functions.
by Gabriel Ivăncescu (＠insn) 22 Nov '22

22 Nov '22

-- v2: jscript: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1478

4 3

[PATCH v2 0/3] MR1476: Implement GetGeoInfoEx
by Santino Mazza (＠tati1454) 22 Nov '22

22 Nov '22

-- v2: kernelbase: Implement GetGeoInfoEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/1476

3 4

[PATCH v2 0/1] MR1486: shlwapi/tests: Use standard C functions for memory allocation in path.c.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

-- v2: shlwapi/tests: Use standard C functions for memory allocation in path.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/1486

2 1

[PATCH 0/1] MR1478: jscript: Use CRT allocation functions.
by Gabriel Ivăncescu (＠insn) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1478

4 3

[PATCH v5 0/3] MR1199: xmllite/writer : Implement a few APIs
by David Kahurani (＠kahurani) 22 Nov '22

22 Nov '22

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v5: xmllite/writer: Implement WriteSurrogateCharEntity. xmllite/writer: Implement WriteRawChars. xmllite/writer: Implement WriteChars. https://gitlab.winehq.org/wine/wine/-/merge_requests/1199

2 3

[PATCH 0/1] MR1480: dinput/tests: Put the calling convention inside the function pointer parentheses.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

I forgot that MSVC requires this, sorry. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1480

3 2

[PATCH 0/1] MR1486: shlwapi/tests: Use standard C functions for memory allocation in path.c.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1486

3 2

[PATCH v3 0/14] MR1447: mshtml: Implement performance.timing timestamps properly.
by Gabriel Ivăncescu (＠insn) 22 Nov '22

22 Nov '22

-- v3: mshtml: Implement performance.timing.msFirstPaint. mshtml: Implement performance.timing.loadEventStart & loadEventEnd. mshtml: Get rid of useless window check. mshtml: Implement performance.timing.domContentLoadedEventStart & End. mshtml: Implement performance.timing.domComplete. mshtml: Implement performance.timing.domInteractive. mshtml: Implement performance.timing.domLoading. mshtml: Implement performance.timing.responseStart & responseEnd. mshtml: Implement the remaining pre-response performance.timing props. mshtml: Implement performance.timing.unloadEventStart & unloadEventEnd. mshtml: Implement performance.timing.redirectStart. mshtml: Implement performance.timing.navigationStart. mshtml: Link the performance.timing from the window at creation. mshtml: Fix performance variant leak. https://gitlab.winehq.org/wine/wine/-/merge_requests/1447

3 15

Re: [PATCH v8 0/3] MR1343: windows.media: Add WinRT Closed Captioning interface.
by Mohamad Al-Jaf (＠maljaf) 22 Nov '22

22 Nov '22

Thanks for the detailed feedback and review @besentv and @rbernon. :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1343#note_16883

1 0

[PATCH 0/1] MR1487: oledb32: Use standard C functions for memory allocation in rowpos.c.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1487

2 1

[PATCH v5 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) 22 Nov '22

22 Nov '22

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- v5: imm32: Prevent deadlock on unload https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

3 3

[PATCH 0/1] MR1484: kernel32/tests: Avoid using GCC's typeof extension.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1484

2 1

[PATCH 0/3] MR1477: Search and load separate debug info from users's debuginfod cache directory.
by eric pouech (＠epo) 22 Nov '22

22 Nov '22

This serie allow to load alternate debug info from user's debuginfo cache. This series (as is) will not bring lots of value as: - no support for loading the missing debug info files (they should have been been loaded beforehand) - most of these files are in Dwarf5 format, that we don't support yet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1477

3 4

[PATCH 0/1] MR1479: advapi32/tests: Avoid using GCC's typeof extension.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1479

2 1

[PATCH v2 0/1] MR1459: dinput/tests: Avoid using GCC's typeof extension.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

typeof is not available in MSVC. -- v2: dinput/tests: Avoid using GCC's typeof extension. https://gitlab.winehq.org/wine/wine/-/merge_requests/1459

4 3

[PATCH v2 0/4] MR1466: taskschd: Remove function heap_strdupW.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

-- v2: taskschd: Remove unused function heap_strdupW. taskschd: Use standard C functions for memory allocation in task.c. taskschd: Use standard C functions for memory allocation in regtask.c. taskschd: Use standard C functions for memory allocation in folder_collection.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/1466

3 5

[PATCH 0/3] MR1476: Implement GetGeoInfoEx
by Santino Mazza (＠tati1454) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1476

3 4

[PATCH 0/1] MR990: comctl32/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/990

4 5

[PATCH 0/2] MR1474: gdi32: Get printer output file name in StartDoc.
by Piotr Caban (＠piotr) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1474

3 4

[PATCH v4 0/3] MR1046: MfMediaEngine invalid format handling.
by Bernhard Kölbl (＠besentv) 21 Nov '22

21 Nov '22

-- v4: mfmediaengine: Add a fallback when the set engine format cannot be used to init samplegrabber. mfmediaengine: Only accept engine formats which are render target compatible. https://gitlab.winehq.org/wine/wine/-/merge_requests/1046

3 4

[PATCH v7 0/12] MR1010: Draft: opengl32: Path towards wow64 support.
by Rémi Bernon (＠rbernon) 21 Nov '22

21 Nov '22

I was watching some random YouTube stream and then heard a voice telling me to do this. This can run wglgears on wow, though there's plenty of missing pieces which I don't have any idea how to fix (like buffer mapping, etc.). Opening it as a draft for now to show the whole thing, if it seems alright I'll send it in batches. -- v7: HACK: wined3d: Disable persistent buffer mapping. HACK: wined3d: Ignore D3DKMT open errors. winex11.drv: Avoid crashing on invalid pixel format pointer. opengl32: Use the +opengl debug channel everywhere. opengl32: Implement wow64 thunks for glMapBuffer (et al.). https://gitlab.winehq.org/wine/wine/-/merge_requests/1010

3 16

Re: [PATCH v3 0/1] MR1478: jscript: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1478

1 0

Re: [PATCH v5 0/9] MR1448: hid: parser and HidP_SetUsageValue fix - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1448

1 0

Re: [PATCH v2 0/3] MR1477: Search and load separate debug info from users's debuginfod cache directory. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1477

1 0

Re: [PATCH v5 0/3] MR1473: Support unmangling C++11 function's reference qualifiers. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1473

1 0

Re: [PATCH v2 0/2] MR1475: winprint: Implement RAW print processor. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1475

1 0

Re: [PATCH v3 0/1] MR1459: dinput/tests: Avoid using GCC's typeof extension. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1459

1 0

Re: [PATCH v4 0/1] MR1435: msxml3: Use standard C functions for memory allocation in saxreader.c. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1435

1 0

Re: [PATCH v2 0/1] MR1462: mshtml: Handle realloc failure in add_func_info. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1462

1 0

Re: [PATCH v2 0/1] MR1467: urlmon: Remove unused function heap_strdupWtoA. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1467

1 0

Re: [PATCH v3 0/1] MR1451: kernelbase: Add SetProcessInformation(). - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1451

1 0

Re: [PATCH v2 0/1] MR1450: xmllite/reader: Use consistent formatting for traces. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1450

1 0

Re: [PATCH v2 0/1] MR1452: win32u: Fix a memory leak. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1452

1 0

Re: [PATCH v3 0/1] MR1458: appwiz: Use standard C functions for memory allocation. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1458

1 0

Re: [PATCH v2 0/1] MR1463: oledb32: Handle memory allocation failure in rowpos_cp_Advise. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1463

1 0

Re: [PATCH v2 0/1] MR1457: adsldp: Use standard C functions for memory allocation in adsldp.c. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1457

1 0

Re: [PATCH v3 0/5] MR1472: opengl32: Complete wow64 thunks implementation. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1472

1 0

Re: [PATCH v4 0/1] MR1449: msado15: Avoid uninitialized variable warning in fields_get_Item - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1449

1 0

Re: [PATCH v8 0/3] MR1343: windows.media: Add WinRT Closed Captioning interface. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1343

1 0

Re: [PATCH v2 0/1] MR1416: comctl32/tests: Fix monthcal selection tests. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1416

1 0

Re: [PATCH v2 0/1] MR1471: dwrite: Avoid memcpy source overflow in GetFontAxisValues. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1471

1 0

Re: [PATCH v2 0/1] MR1465: secur32: Use the wcsdup function instead of reimplementing it. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1465

1 0

Re: [PATCH v2 0/1] MR1468: winhttp: Use the wcsdup function instead of reimplementing it. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1468

1 0

Re: [PATCH v2 0/1] MR1469: wldap32: Use the wcsdup function instead of reimplementing it. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1469

1 0

[PATCH v2 0/3] MR1046: Draft: MfMediaEngine invalid format handling.
by Bernhard Kölbl (＠besentv) 21 Nov '22

21 Nov '22

-- v2: mfmediaengine: Add a fallback when the set output format cannot be used to init samplegrabber. mfmediaengine: Only accept output formats which are render target compatible. mfmediaengine/tests: Test possible engine and output texture formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/1046

3 4

Re: [PATCH v3 0/2] MR49: Always declare UAV images as typed if atomic ops occur. - approved
by Alexandre Julliard (＠julliard) 21 Nov '22

21 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/49

1 0

[PATCH v3 0/3] MR1448: hid: parser and HidP_SetUsageValue fix
by Matthew Tran (＠0e4ef622) 21 Nov '22

21 Nov '22

This fixes two things: * HID report descriptor parser enum for local items. Close inspection of page 40 of [Device Class Definition for HID 1.11](https://www.usb.org/document-library/device-class-definition-hid-111) reveals a jump between Designator Maximum (0101) and String Index (0111). This caused a controller of mine to not get recognized. * HidP_SetUsageValue for items that define multiple controls (with Report Count > 1). Attempting to set one value would result in HIDP_STATUS_BUFFER_TOO_SMALL. -- v3: hid: Add tests for fixed HidP_SetUsageValue hid: Fix HidP_SetUsageValue for usage ranges hidparse.sys: Fix incorrect enum https://gitlab.winehq.org/wine/wine/-/merge_requests/1448

4 10

[PATCH v2 0/12] MR1470: kernel32: Add (Global|Local)ReAlloc tests and fix it.
by Rémi Bernon (＠rbernon) 21 Nov '22

21 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53474 -- v2: kernelbase: Only discard HLOCAL with LMEM_MOVEABLE and if not locked. kernel32: Return success from GlobalReAlloc with locked HGLOBAL pointer. kernelbase: Avoid moving locked HLOCAL pointer without LMEM_MOVEABLE. kernelbase: Handle LMEM_DISCARDABLE flag specifically in LocalReAlloc. kernelbase: Handle LMEM_MODIFY flag first in LocalReAlloc. kernelbase: Don't try in-place HeapReAlloc in LocalReAlloc. user32: Call GlobalReAlloc with GMEM_MOVEABLE flag. winemac.drv: Call GlobalReAlloc with GMEM_MOVEABLE flag. riched20: Call GlobalReAlloc with GMEM_MOVEABLE flag. ole32: Call GlobalReAlloc with GMEM_MOVEABLE flag. comdlg32: Call GlobalReAlloc with GMEM_MOVEABLE flag. kernel32/tests: Add more (Global|Local)ReAlloc tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1470

3 15

Re: [PATCH v12 0/9] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Esme Povirk (＠madewokherd) 21 Nov '22

21 Nov '22

It occurred to me that you might not be aware that you can forward-declare static functions, so you don't really need to move them. Just put a declaration like this: ``` static void widen_open_figure(const GpPointF *points, int start, int end, GpPen *pen, REAL pen_width, GpLineCap start_cap, GpLineCap end_cap, path_list_node_t **last_point); ``` Further up in the file. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16784

1 0

Re: [PATCH v12 0/9] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Esme Povirk (＠madewokherd) 21 Nov '22

21 Nov '22

On Sat Nov 19 00:10:03 2022 +0000, Esme Povirk wrote: > I suspect there are enough slow things we already have to do that it > won't really matter, but if we need to we can optimize it later. Resolving, this is fine for now and can be easily improved in the future. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16782

1 0

Re: [PATCH v12 0/9] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Esme Povirk (＠madewokherd) 21 Nov '22

21 Nov '22

On Fri Nov 18 20:11:22 2022 +0000, Esme Povirk wrote: > I'm not sure. Maybe widen_open_figure needs to be aware of the inset and > adjust the points it passes to width_joint. Or maybe the path needs to > be adjusted after GdipFlattenPath. > I think it depends on what happens when the path ends with a segment > that's shorter than the inset. Resolving this thread because this issue doesn't need to be taken care of for the MR to be accepted. It can be fixed later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16780

1 0

Re: [PATCH v12 0/9] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Esme Povirk (＠madewokherd) 21 Nov '22

21 Nov '22

On Wed Nov 9 18:25:51 2022 +0000, Bartosz Kosiorek wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/1297/diffs?diff_id=17873&start_sha=ec560a173011779aa36bdb3d54e0bd805a70a729#708701348c59d29ebde2b9d5cd4724966113ebf7_308_308) I'm going to resolve this as it's only an explanation of the change and not a problem with it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16779

1 0

Re: [PATCH v12 0/9] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Esme Povirk (＠madewokherd) 21 Nov '22

21 Nov '22

Esme Povirk (@madewokherd) commented about dlls/gdiplus/graphicspath.c: > + widen_closed_figure(tmp_points, 0, custom->pathdata.Count - 1, pen, pen_width, last_point); > + else > + widen_open_figure(tmp_points, 0, custom->pathdata.Count - 1, pen, pen_width, LineCapFlat, LineCapFlat, last_point); > + } > + else > + { > + for (INT i = 0; i < custom->pathdata.Count; i++) > + { > + // rotation of CustomCap according to line > + perp_dx = custom->pathdata.Points[i].X * cosa + (custom->pathdata.Points[i].Y - 1.0) * sina; > + perp_dy = custom->pathdata.Points[i].X * sina - (custom->pathdata.Points[i].Y - 1.0) * cosa; > + *last_point = add_path_list_node(*last_point, posx + perp_dx, > + posy + perp_dy, custom->pathdata.Types[i]); > + } > + } > + // FIXME: The line should be shorter, and it should ends up when Arrow/Cap is started draw This comment makes things more confusing, I think. I'd suggest something like `FIXME: The line should be adjusted by the inset value of the custom cap.`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16777

1 0

[PATCH v2 0/5] MR1472: opengl32: Complete wow64 thunks implementation.
by Rémi Bernon (＠rbernon) 21 Nov '22

21 Nov '22

There's a few missing thunks for some non-standard extension functions, but that probably doesn't matter. -- v2: opengl32: Use the +opengl debug channel everywhere. opengl32: Cast wow64 pointers in glGet(VertexAttrib)Pointerv. opengl32: Implement wow64 thunks for glMapBuffer (et al.). opengl32: Use manual win32 thunks for glMapBuffer (et al.). opengl32: Implement wow64 thunk for glGetString (et al.). https://gitlab.winehq.org/wine/wine/-/merge_requests/1472

3 7

[PATCH v2 0/13] MR1447: mshtml: Implement performance.timing timestamps properly.
by Gabriel Ivăncescu (＠insn) 21 Nov '22

21 Nov '22

-- v2: mshtml: Implement performance.timing.msFirstPaint. mshtml: Implement performance.timing.loadEventStart & loadEventEnd. mshtml: Get rid of useless window check. mshtml: Implement performance.timing.domContentLoadedEventStart & End. mshtml: Implement performance.timing.domComplete. mshtml: Implement performance.timing.domInteractive. mshtml: Implement performance.timing.domLoading. mshtml: Implement performance.timing.responseStart & responseEnd. mshtml: Implement the remaining pre-response performance.timing props. mshtml: Implement performance.timing.unloadEventStart & unloadEventEnd. mshtml: Implement performance.timing.redirectStart. mshtml: Implement performance.timing.navigationStart. mshtml: Store link to the inner window in HTMLPerformance. https://gitlab.winehq.org/wine/wine/-/merge_requests/1447

4 21

[PATCH v2 0/1] MR1455: dinput: Wait on event instead of thread on stop
by Fabian Maurer (＠DarkShadow44) 21 Nov '22

21 Nov '22

Since we stop the thread in DllMain, we always haev the loaderlock. Thread shutdown also requires the loader lock, so we will always time out So just wait until all cleanup is done, the thread itself can exit later Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52314 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v2: dinput: Wait on event instead of thread on stop https://gitlab.winehq.org/wine/wine/-/merge_requests/1455

4 7

[PATCH v3 0/1] MR1449: msado15: Avoid uninitialized variable warning in fields_get_Item
by Gerald Pfeifer (＠gerald) 21 Nov '22

21 Nov '22

This avoids the following warning by GCC 13: dlls/msado15/recordset.c:790:32: warning: 'i' may be used uninitialized -- v3: msado15: Avoid uninitialized variable warning in fields_get_Item https://gitlab.winehq.org/wine/wine/-/merge_requests/1449

4 3

[PATCH v4 0/3] MR1473: Support unmangling C++11 function's reference qualifiers.
by eric pouech (＠epo) 21 Nov '22

21 Nov '22

-- v4: ucrtbase: Handle undecoration of function's reference qualifiers (C++11). msvcrt: Rename modifier into qualifier. ucrtbase: Extend ucrtbase's undname tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1473

3 4

[PATCH v2 0/3] MR1473: Support unmangling C++11 function's reference qualifiers.
by eric pouech (＠epo) 21 Nov '22

21 Nov '22

-- v2: ucrtbase: Handle undecoration of function's reference qualifiers (C++11). msvcrt: Rename modifier into qualifier. ucrtbase: Extend ucrtbase's undname tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1473

3 5

[PATCH 0/3] MR1461: ieframe: Remove function heap_strdupW.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1461

4 7

[PATCH 0/3] MR1473: Support unmangling C++11 function's reference qualifiers.
by eric pouech (＠epo) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1473

3 4

[PATCH 0/6] MR1437: ntdll: Cleanup and refactor the x86_64 and i386 syscall dispatchers.
by Rémi Bernon (＠rbernon) 21 Nov '22

21 Nov '22

In preparation for https://gitlab.winehq.org/wine/wine/-/merge_requests/1324. This also begins preparation for a slightly different route than what the MR currently takes, with syscall flags eventually stored in the CounterTable rather than overusing syscall number unused bits. To do that we're checking the syscall number and loading the syscall table (keeping it in %rbx/%ebx) earlier. This assumes that %rbx isn't modified in between, for instance by the eventual `SYS_arch_prctl` syscall, but I believe it is the case? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1437

4 9

[PATCH 0/6] MR1472: opengl32: Complete wow64 thunks implementation.
by Rémi Bernon (＠rbernon) 21 Nov '22

21 Nov '22

There's a few missing thunks for some non-standard extension functions, but that probably doesn't matter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1472

3 7

[PATCH v4 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) 21 Nov '22

21 Nov '22

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- v4: imm32: Prevent deadlock on unload https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

4 3

[PATCH v4 0/3] MR1199: xmllite/writer : Implement a few APIs
by David Kahurani (＠kahurani) 21 Nov '22

21 Nov '22

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v4: xmllite/writer: Implement WriteSurrogateCharEntity. xmllite/writer: Implement WriteRawChars. xmllite/writer: Implement WriteChars. https://gitlab.winehq.org/wine/wine/-/merge_requests/1199

4 5

[PATCH v3 0/1] MR1435: msxml3: Use standard C functions for memory allocation in saxreader.c.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

-- v3: msxml3: Use standard C functions for memory allocation in saxreader.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/1435

4 3

[PATCH 0/1] MR1462: mshtml: Handle realloc failure in add_func_info.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1462

4 3

[PATCH 0/1] MR1467: urlmon: Remove unused function heap_strdupWtoA.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

This function was introduced in commit 59055c4d45c674c2a9dc2efcb8d0a973f870f3ac but never used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1467

4 3

[PATCH 0/12] MR1470: kernel32: Add (Global|Local)ReAlloc tests and fix it.
by Rémi Bernon (＠rbernon) 21 Nov '22

21 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53474 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1470

3 14

[PATCH 0/1] MR1471: dwrite: Avoid memcpy source overflow in GetFontAxisValues.
by Rémi Bernon (＠rbernon) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1471

4 3

[PATCH 0/2] MR1475: winprint: Implement RAW print processor.
by Piotr Caban (＠piotr) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1475

2 2

[PATCH 0/4] MR1427: wined3d: Add a lower size bound for the streaming buffer allocation.
by Anton Baskanov (＠baskanov) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1427

3 5

Re: [PATCH v3 0/3] MR1046: Draft: MfMediaEngine invalid format handling.
by Bernhard Kölbl (＠besentv) 21 Nov '22

21 Nov '22

v2: *Greatly reworked the tests. *Added additional check for valid formats. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1046#note_16675

1 0

[PATCH 0/1] MR1469: wldap32: Use the wcsdup function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1469

4 3

[PATCH 0/1] MR46: vkd3d-shader/spirv: Do not write the point size if shaderTessellationAndGeometryPointSize is disabled.
by Zebediah Figura (＠zfigura) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/46

3 4

[PATCH v2 0/2] MR49: Always declare UAV images as typed if atomic ops occur.
by Conor McCarthy (＠cmccarthy) 21 Nov '22

21 Nov '22

Atomic ops on images with Unknown type will cause SPIR-V validation failure, and assertion failure in Mesa debug builds. D3D12 allows atomics on typed buffers, and this requires a distinction to be made between UAV reads and atomic ops. -- v2: vkd3d-shader: Introduce DESCRIPTOR_INFO_FLAG_UAV_ATOMICS and always declare UAV images with known type for atomic ops. tests: Test a typed UAV buffer in test_atomic_instructions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/49

3 4

[PATCH 0/1] MR1468: winhttp: Use the wcsdup function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1468

4 3

[PATCH 0/1] MR1459: dinput/tests: Avoid using GCC's typeof extension.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

typeof is not available in MSVC. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1459

4 3

[PATCH v7 0/3] MR1343: windows.media: Add WinRT Closed Captioning interface.
by Mohamad Al-Jaf (＠maljaf) 21 Nov '22

21 Nov '22

This is my first time implementing an interface so thorough feedback would be appreciated. -- v7: windows.media: Implement IClosedCaptionPropertiesStatics interface. windows.media: Add stub DLL. include/windowscontracts: Bump contractversion to 14. https://gitlab.winehq.org/wine/wine/-/merge_requests/1343

5 7

[PATCH 0/1] MR1465: secur32: Use the wcsdup function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1465

4 3

[PATCH v2 0/1] MR1449: msado15: Avoid uninitialized variable use in fields_get_Item
by Gerald Pfeifer (＠gerald) 21 Nov '22

21 Nov '22

This avoids the following warning by GCC 13: dlls/msado15/recordset.c:790:32: warning: 'i' may be used uninitialized -- v2: msado15: Avoid uninitialized variable use in fields_get_Item https://gitlab.winehq.org/wine/wine/-/merge_requests/1449

4 7

[PATCH 0/3] MR1466: taskschd: Remove function heap_strdupW.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1466

3 4

[PATCH 0/1] MR1464: oledlg: Use standard C functions for memory allocation in pastespl.c.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1464

3 2

[PATCH 0/1] MR1416: comctl32/tests: Fix monthcal selection tests.
by eric pouech (＠epo) 21 Nov '22

21 Nov '22

Changed MCHITTESTINFO.cbSize to fall back to V1: From the rest of the tests, it looks like the extended size of MCHITTESTINFO requires loading common controls V6, which is only done afterwards in the tests. Improved lookup of an unselected day. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50097 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1416

3 2

[PATCH 0/1] MR1457: adsldp: Use standard C functions for memory allocation in adsldp.c.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1457

3 2

[PATCH 0/1] MR1463: oledb32: Handle memory allocation failure in rowpos_cp_Advise.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1463

2 1

[PATCH 0/1] MR1460: hhctrl: Handle memory allocation failure in GetChmString.
by Alex Henrie (＠alexhenrie) 21 Nov '22

21 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1460

2 1

[PATCH v11 0/2] MR841: ntoskrnl.exe: processor change callback stubs
by Etaash Mathamsetty (＠etaash.mathamsetty) 21 Nov '22

21 Nov '22

required for mrac anti cheat -- v11: ntoskrnl.exe: Add KeDeregisterProcessorChangeCallback stub. ntoskrnl.exe: Add KeRegisterProcessorChangeCallback stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/841

3 3

[PATCH v10 0/2] MR841: ntoskrnl.exe: processor change callback stubs
by Etaash Mathamsetty (＠etaash.mathamsetty) 21 Nov '22

21 Nov '22

required for mrac anti cheat -- v10: ntoskrnl.exe: Add KeDeregisterProcessorChangeCallback stub. ntoskrnl.exe: Add KeRegisterProcessorChangeCallback stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/841

3 3

Re: [PATCH v3 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) 21 Nov '22

21 Nov '22

Sorry, forget about the last versions, I mistook where the WM_DESTROY is coming from. It's not coming from imm32 DllMain. That means it simply ignores the deinitialization... Sorry about that. This is a new approach that should also fix the issue, this time preventing the loader lock that causes the issue in the first place. Not 100% sure if that's the right way to go about it, though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1456#note_16584

1 0

[PATCH v6 0/3] MR1343: windows.media: Add WinRT Closed Captioning interface.
by Mohamad Al-Jaf (＠maljaf) 21 Nov '22

21 Nov '22

This is my first time implementing an interface so thorough feedback would be appreciated. -- v6: windows.media: Implement IClosedCaptionPropertiesStatics interface. include/windowscontracts: Bump contractversion to 14. windows.media: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/1343

3 7

[PATCH v2 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) 20 Nov '22

20 Nov '22

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- v2: imm32: Prevent deadlock on unload https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

3 2

Re: [PATCH v2 0/1] MR1444: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW
by James McDonnell (＠ElementalWarrior) 20 Nov '22

20 Nov '22

On Sat Nov 19 18:56:07 2022 +0000, Etaash Mathamsetty wrote: > instead of saving the return value to a temp variable and returning the > temp variable, I think you could moving the FIXME before the call and > just return MoveFileWithProgressA, thus removing the need of the variable I thought about it. But having the fixme after provides feedback in the event something goes wrong inside of MoveFile... Although maybe that is no with the memory allocation thats going to be held onto for the life the the call. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1444#note_16564

1 0

[PATCH 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) 20 Nov '22

20 Nov '22

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

3 3

[PATCH 0/1] MR1455: dinput: Wait on event instead of thread on stop
by Fabian Maurer (＠DarkShadow44) 20 Nov '22

20 Nov '22

Since we stop the thread in DllMain, we always haev the loaderlock. Thread shutdown also requires the loader lock, so we will always time out So just wait until all cleanup is done, the thread itself can exit later Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52314 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1455

3 2

[PATCH v2 0/1] MR1451: kernelbase: Add SetProcessInformation().
by Nikolay Sivov (＠nsivov) 20 Nov '22

20 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53954 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: kernelbase: Add SetProcessInformation(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1451

2 1

[PATCH v2 0/2] MR1448: hid: parser and HidP_SetUsageValue fix
by Matthew Tran (＠0e4ef622) 20 Nov '22

20 Nov '22

This fixes two things: * HID report descriptor parser enum for local items. Close inspection of page 40 of [Device Class Definition for HID 1.11](https://www.usb.org/document-library/device-class-definition-hid-111) reveals a jump between Designator Maximum (0101) and String Index (0111). This caused a controller of mine to not get recognized. * HidP_SetUsageValue for items that define multiple controls (with Report Count > 1). Attempting to set one value would result in HIDP_STATUS_BUFFER_TOO_SMALL. -- v2: hid: Fix HidP_SetUsageValue for usage ranges https://gitlab.winehq.org/wine/wine/-/merge_requests/1448

4 4

2025

2024

2023

2022

wine-gitlab