- wine-gitlab - winehq.org

[PATCH 0/5] MR53: vkd3d-shader/hlsl: transpose(), smoothstep(), and properly convert args of element-wise intrinsics.
by Francisco Casas (＠fcasas) 28 Nov '22

28 Nov '22

This patch includes an implementation of the long-pending `transpose` intrinsic and the `smoothstep` intrinsic. While implementing `smoothstep` I realized that some intrinsics have different rules for the allowed data types than expressions: - Vectors and matrices at the same time are not allowed, regardless of their dimensions. Even if they have the same number of components. - Any combination of matrices is always allowed, even those when no matrix fits inside another, e.g.: `… [View More]

3 14

[PATCH 0/3] MR1575: include: Add __WINE_(DEALLOC|MALLOC) attributes to wine_get_(dos|unix)_file_name.
by Brendan Shanks (＠bshanks) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1575

4 5

[PATCH v3 0/1] MR1553: msvcrt: Fix errno set on dup from read-only file.
by xantares (＠xantares) 28 Nov '22

28 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53950 -- v3: msvcrt: Fix errno set on dup from read-only file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1553

3 2

[PATCH v2 0/3] MR1542: winegstreamer: Get MF_SD_LANGUAGE and (for QT demuxer only) MF_SD_STREAM_NAME.
by Paul Gofman (＠gofman) 28 Nov '22

28 Nov '22

-- v2: mfplay/tests: Add MF_SD_LANGUAGE and MF_SD_STREAM_NAME value tests. winegstreamer: Extract stream name from QT demuxer private data. winegstreamer: Query stream tags and set MF_SD_LANGUAGE attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/1542

3 5

[PATCH 0/1] MR1567: mountmgr: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1567

3 2

[PATCH 0/2] MR1576: ntdll: Get TEB from signal stack pointer in init_handler.
by Jacek Caban (＠jacek) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1576

2 2

[PATCH 0/8] MR1558: localspl: Start moving print job related code to localspl
by Piotr Caban (＠piotr) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1558

3 9

[PATCH v3 0/5] MR1554: win32u: Reset focused item when removing menu item
by Vladislav Timonin (＠vt) 28 Nov '22

28 Nov '22

Fixes an out of bounds access in `show_popup`. ```c if (menu->FocusedItem != NO_SELECTED_ITEM) { menu->items[menu->FocusedItem].fState &= ~(MF_HILITE|MF_MOUSESELECT); // <- can crash here menu->FocusedItem = NO_SELECTED_ITEM; } ``` Menu resets focused item on show, not on close. If items were later deleted, next time user opens the menu, menu can crash on out of bounds access and won't show up again, as menu thinks it's still on screen. In other words: - open split … [View More]

2 5

[PATCH 0/1] MR1573: winedump: Don't crash when dumping .dbg files.
by eric pouech (＠epo) 28 Nov '22

28 Nov '22

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1573

2 1

[PATCH 0/1] MR1572: ntdll: Detect ntdll module also by module path compatition.
by Jacek Caban (＠jacek) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1572

2 1

Re: [PATCH v6 0/2] MR1046: MfMediaEngine invalid format handling.
by Bernhard Kölbl (＠besentv) 28 Nov '22

28 Nov '22

v4: - Removed format checking via texture creation. - Reworked the tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1046#note_17672

1 0

[PATCH v2 0/3] MR1549: configure: Clang build fixes.
by Jacek Caban (＠jacek) 28 Nov '22

28 Nov '22

I recently noticed problems with building with clang in msvc mode when using my distro clang. It seems specific to its configuration, I think that it doesn't affect default clang. One problem is that --rtlib=libgcc is specified in /etc/clang, which causes clang to produce: ``` clang-15: error: unsupported runtime library 'libgcc' for platform 'MSVC' ``` I think it's a clang bug here: https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/… It should probably check for -… [View More]

3 5

[PATCH v5 0/3] MR1046: MfMediaEngine invalid format handling.
by Bernhard Kölbl (＠besentv) 28 Nov '22

28 Nov '22

-- v5: mfmediaengine: Add a fallback when the set engine format cannot be used to init samplegrabber. mfmediaengine: Only accept engine formats which are render target compatible. https://gitlab.winehq.org/wine/wine/-/merge_requests/1046

5 30

[PATCH 0/7] MR1571: wmvcore: Move async reader to wmvcore and add more threading tests.
by Rémi Bernon (＠rbernon) 28 Nov '22

28 Nov '22

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/1311, which will need to be updated according to pass the new tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1571

3 8

[PATCH 0/1] MR1562: wininet: Simplify memory allocation in HTTP_InsertCustomHeader.
by Alex Henrie (＠alexhenrie) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1562

3 2

[PATCH 0/1] MR1563: mshtml: Remove string constant macros from navigate.c.
by Alex Henrie (＠alexhenrie) 28 Nov '22

28 Nov '22

Having an extra layer of indirection here makes the code less clear. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1563

3 2

[PATCH 0/1] MR1561: vbscript: Support const private expressions.
by Robert Wilhelm (＠sloper42) 28 Nov '22

28 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53783 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1561

4 4

[PATCH 0/1] MR1551: SDL: Always make unique serial numbers
by Evan Tang (＠etang-cw) 28 Nov '22

28 Nov '22

Overcooked! All You Can Eat only adds new controllers if existing controller has the same serial as it. SDL GUIDs mark the model of controller, but don't differentiate between multiple controllers of the same model. This is especially bad with Steam virtual controllers, which all have the same GUID. Switch to using SDL_JoystickGetSerial if available, and otherwise combining the GUID with the controller index -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1551

4 4

[PATCH v3 0/10] MR1526: mshtml: Misc improvements.
by Gabriel Ivăncescu (＠insn) 28 Nov '22

28 Nov '22

For the `performance.navigation` props, I store them in the timing that's already linked from the window, to prevent adding more code around that just for 2 props, so it keeps it simple. -- v3: include/mshtml: Add IHTMLXDomainRequest and factory interfaces and classes. mshtml: Don't check for doc_node from the doc obj when it can't be NULL. mshtml: Return proper error for invalid selectors in IE8 mode. mshtml: Treat edit mode as a reload. mshtml: Implement performance.… [View More]

3 11

[PATCH v7 0/1] MR1522: mfmediaengine: Volume change.
by Bernhard Kölbl (＠besentv) 28 Nov '22

28 Nov '22

-- v7: mfmediaengine: Pass volume changes to media session. https://gitlab.winehq.org/wine/wine/-/merge_requests/1522

2 3

[PATCH 0/1] MR1565: wldap32: Use the strdup function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1565

3 2

[PATCH 0/12] MR1570: joy.cpl: Refactoring and fixes to prevent crash on exit.
by Rémi Bernon (＠rbernon) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1570

2 12

[PATCH 0/1] MR1568: winex11.drv: Support _KDE_NET_WM_STATE_SKIP_SWITCHER.
by Zhiyi Zhang (＠zhiyi) 28 Nov '22

28 Nov '22

KWin has a switcher that triggered by Alt+Tab that basically acts like a pager. And hiding items in the switcher is controlled by _KDE_NET_WM_STATE_SKIP_SWITCHER. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1568

2 1

[PATCH v4 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) 28 Nov '22

28 Nov '22

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v3: Fix failed test. Don't know how to change the subject version number. -- v4: shell32/tests: Add SHBindToFolderIDListParent tests. shell32: Implement SHBindToFolderIDListParent. shell32: Fix error handling in SHBindToParent. shell32/tests: Test SHBindToParent last parameter behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/566

3 8

[PATCH v2 0/4] MR1554: win32u: Reset focused item when removing menu item
by Vladislav Timonin (＠vt) 27 Nov '22

27 Nov '22

Fixes an out of bounds access in `show_popup`. ```c if (menu->FocusedItem != NO_SELECTED_ITEM) { menu->items[menu->FocusedItem].fState &= ~(MF_HILITE|MF_MOUSESELECT); // <- can crash here menu->FocusedItem = NO_SELECTED_ITEM; } ``` Menu resets focused item on show, not on close. If items were later deleted, next time user opens the menu, menu can crash on out of bounds access and won't show up again, as menu thinks it's still on screen. In other words: - open split … [View More]

3 7

[PATCH 0/2] MR1557: localspl: Add FILE: port monitor implementation
by Piotr Caban (＠piotr) 27 Nov '22

27 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1557

4 4

[PATCH v6 0/3] MR1199: xmllite/writer : Implement a few APIs
by David Kahurani (＠kahurani) 27 Nov '22

27 Nov '22

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v6: xmllite/writer: Implement WriteSurrogateCharEntity. xmllite/writer: Implement WriteRawChars. xmllite/writer: Implement WriteChars. https://gitlab.winehq.org/wine/wine/-/merge_requests/1199

4 6

[PATCH v5 0/1] MR1522: mfmediaengine: Volume change.
by Bernhard Kölbl (＠besentv) 27 Nov '22

27 Nov '22

-- v5: mfmediaengine: Pass volume changes to media session. https://gitlab.winehq.org/wine/wine/-/merge_requests/1522

3 3

[PATCH 0/1] MR1556: d3dcompiler: Implement D3DDisassemble() using vkd3d-shader.
by Nikolay Sivov (＠nsivov) 27 Nov '22

27 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46649 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1556

2 1

[PATCH 0/4] MR51: vkd3d-shader/hlsl: Improve constant handling in copy prop, and extend the use of aoffimmi modifiers.
by Francisco Casas (＠fcasas) 27 Nov '22

27 Nov '22

If a hlsl_ir_load loads a variable whose components are stored from different instructions, copy propagation doesn't replace it. But if all these instructions are constants (which currently is the case for value constructors), the load can be replaced with a constant value, which is what the first patch of this series does. For instance, this shader: ``` sampler s; Texture2D t; float4 main() : sv_target { return t.Gather(s, float2(0.6, 0.6), int2(0, 0)); } ``` results in the following … [View More]

4 19

[PATCH 0/3] MR1542: winegstreamer: Get MF_SD_LANGUAGE and (for QT demuxer only) MF_SD_STREAM_NAME.
by Paul Gofman (＠gofman) 27 Nov '22

27 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1542

3 7

[PATCH 0/3] MR1555: wshom.ocx: Add WShNetwork.
by Robert Wilhelm (＠sloper42) 26 Nov '22

26 Nov '22

First steps for https://bugs.winehq.org/show_bug.cgi?id=53971 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1555

2 3

[PATCH 0/1] MR1554: win32u: Reset focused item when removing menu item
by Vladislav Timonin (＠vt) 26 Nov '22

26 Nov '22

Fixes an out of bounds access in `show_popup`. ```c if (menu->FocusedItem != NO_SELECTED_ITEM) { menu->items[menu->FocusedItem].fState &= ~(MF_HILITE|MF_MOUSESELECT); // <- can crash here menu->FocusedItem = NO_SELECTED_ITEM; } ``` Menu resets focused item on show, not on close. If items were later deleted, next time user opens the menu, menu can crash on out of bounds access and won't show up again, as menu thinks it's still on screen. In other words: - open split … [View More]

3 4

[PATCH v2 0/1] MR1553: msvcrt: Fix errno set on dup from read-only file.
by xantares (＠xantares) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53950 -- v2: msvcrt: Fix errno set on dup from read-only file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1553

3 3

[PATCH 0/1] MR1553: msvcrt: Fix errno set on dup from read-only file.
by xantares (＠xantares) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53950 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1553

3 4

[PATCH v10 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v10: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

4 9

[PATCH 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Georg Lehmann (＠DadSchoorse) 26 Nov '22

26 Nov '22

It's as performance sensitive as descriptor updates. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552

2 1

[PATCH 0/1] MR1494: winebus.sys: Don't use SDL_HAPTIC_INFINITY when calling SDL_HapticRunEffect.
by Ivo Ivanov (＠logos128) 26 Nov '22

26 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1494

4 12

[PATCH v9 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v9: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 4

[PATCH v8 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v8: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 4

[PATCH v7 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v7: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 4

[PATCH v6 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v6: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 4

[PATCH v5 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v5: gdiplus: add support for LineCapArrowAnchor. gdiplus: fix position of Custom Cap when Scale is different that 1. gdiplus: add support for Custom Line Indent. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 4

[PATCH v4 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v4: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 4

[PATCH v3 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v3: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 4

[PATCH v4 0/6] MR1520: comctl32: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 26 Nov '22

26 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: comctl32/listview: Use CRT allocation functions. comctl32/button: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1520

4 9

[PATCH v2 0/3] MR1536: Preparation to long types migration (serie II)
by eric pouech (＠epo) 26 Nov '22

26 Nov '22

Migration a couple of bits to unsigned int. Note to Zebediah (mainly on second commit of this serie): - there is also a load of 'uint32_t flags' parameters that I didn't change (mainly not to change too many things) Is this something to consider? - I didn't touch the local variables either. Maybe it's something to consider also. -- v2: wined3d: Set location's type to uint32_t. wined3d: Set flags' type to uint32_t (internal definitions). wined3d: Set flags's type to … [View More]

3 5

[PATCH v10 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) 26 Nov '22

26 Nov '22

-- v10: wininet: Partially implement InternetSetFilePointer wininet/tests: Add InternetSetFilePointer tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1268

2 3

Re: Zebediah Figura : configure: Override PKG_CONFIG_LIBDIR instead of PKG_CONFIG_PATH for 32-bit builds on 64-bit hosts.
by Zebediah Figura 26 Nov '22

26 Nov '22

On 11/19/22 03:09, Eric Pouech wrote: > Le 18/11/2022 à 22:45, Alexandre Julliard a écrit : >> Module: wine >> Branch: master >> Commit: c7a97b5d5d56ef00a0061b75412c6e0e489fdc99 >> URL: >> https://gitlab.winehq.org/wine/wine/-/commit/c7a97b5d5d56ef00a0061b75412c6e… >> >> Author: Zebediah Figura <zfigura(a)codeweavers.com> >> Date: Thu Nov 17 19:32:39 2022 -0600 >> >> configure: Override PKG_CONFIG_LIBDIR … [View More]

1 0

Re: [PATCH v2 0/1] MR1546: programs/cmd: use OEM code page when reading a file - approved
by Alexandre Julliard (＠julliard) 25 Nov '22

25 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1546

1 0

Re: [PATCH v4 0/3] MR1550: misc: Fix some invalid frees of wine_get_dos_file_name. - approved
by Alexandre Julliard (＠julliard) 25 Nov '22

25 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1550

1 0

Re: [PATCH v3 0/1] MR1519: mshtml: Handle memory allocation failure in ConnectionPoint_Advise. - approved
by Alexandre Julliard (＠julliard) 25 Nov '22

25 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1519

1 0

Re: [PATCH v2 0/1] MR1544: wininet: Use standard C functions for memory allocation. - approved
by Alexandre Julliard (＠julliard) 25 Nov '22

25 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1544

1 0

Re: [PATCH v6 0/10] MR1537: windows.media: Partially implement caption properties. - approved
by Alexandre Julliard (＠julliard) 25 Nov '22

25 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1537

1 0

Re: [PATCH v3 0/8] MR1535: windows.gaming.input: Implement IForceFeedbackMotor_get_SupportedAxes + some fixes. - approved
by Alexandre Julliard (＠julliard) 25 Nov '22

25 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1535

1 0

Re: [PATCH v2 0/5] MR1540: localspl: Enable tests on modern Windows. - approved
by Alexandre Julliard (＠julliard) 25 Nov '22

25 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1540

1 0

Re: [PATCH v3 0/1] MR1541: winevulkan: Don't try to convert unions without selectors. - approved
by Alexandre Julliard (＠julliard) 25 Nov '22

25 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1541

1 0

[PATCH v2 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 25 Nov '22

25 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v2: gdiplus: add support for LineCapArrowAnchor. gdiplus: fix position of Custom Cap when Scale is different that 1. gdiplus: add support for Custom Line Indent. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 7

[PATCH 0/5] MR1454: wined3d patches
by Matteo Bruni (＠Mystral) 25 Nov '22

25 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1454

5 31

[PATCH 0/3] MR1549: configure: Clang build fixes.
by Jacek Caban (＠jacek) 25 Nov '22

25 Nov '22

I recently noticed problems with building with clang in msvc mode when using my distro clang. It seems specific to its configuration, I think that it doesn't affect default clang. One problem is that --rtlib=libgcc is specified in /etc/clang, which causes clang to produce: ``` clang-15: error: unsupported runtime library 'libgcc' for platform 'MSVC' ``` I think it's a clang bug here: https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/… It should probably check for -… [View More]

4 9

[PATCH v5 0/10] MR1537: windows.media: Partially implement caption properties.
by Mohamad Al-Jaf (＠maljaf) 25 Nov '22

25 Nov '22

As Wine currently does not have a way to set captions, returning the default value should suffice for most applications. It looks like Windows does not do error checking for the *value parameter. For the computed properties, they return E_INVALIDARG when all the captions are set as Default. But they return S_OK if any of the caption settings have been modified, regardless of whether a valid *value parameter is passed. I expected it to at least return the computed values for the default … [View More]

5 18

[PATCH 0/2] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 25 Nov '22

25 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 5

[PATCH v2 0/11] MR1526: mshtml: Misc improvements.
by Gabriel Ivăncescu (＠insn) 25 Nov '22

25 Nov '22

For the `performance.navigation` props, I store them in the timing that's already linked from the window, to prevent adding more code around that just for 2 props, so it keeps it simple. -- v2: include/mshtml: Add IHTMLXDomainRequest and factory interfaces and classes. mshtml: Don't check for doc_node from the doc obj when it can't be NULL. mshtml: Return proper error for invalid selectors in IE8 mode. mshtml: Treat edit mode as a reload. mshtml: Implement performance.… [View More]

4 18

[PATCH v2 0/3] MR1550: misc: Fix some invalid frees of wine_get_dos_file_name.
by Rémi Bernon (＠rbernon) 25 Nov '22

25 Nov '22

-- v2: winepath: Free wine_get_(dos|unix)_file_name memory with HeapFree. mshtml: Free wine_get_dos_file_name memory with HeapFree. appwiz.cpl: Free wine_get_dos_file_name memory with HeapFree. https://gitlab.winehq.org/wine/wine/-/merge_requests/1550

4 7

[PATCH v3 0/3] MR1550: misc: Fix some invalid frees of wine_get_dos_file_name.
by Rémi Bernon (＠rbernon) 25 Nov '22

25 Nov '22

-- v3: winepath: Free wine_get_(dos|unix)_file_name memory with HeapFree. mshtml: Free wine_get_dos_file_name memory with HeapFree. appwiz.cpl: Free wine_get_dos_file_name memory with HeapFree. https://gitlab.winehq.org/wine/wine/-/merge_requests/1550

3 4

[PATCH 0/3] MR1550: misc: Fix some invalid frees of wine_get_dos_file_name.
by Rémi Bernon (＠rbernon) 25 Nov '22

25 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1550

2 3

[PATCH 0/6] MR1548: ntdll: Relax heap locking to access block information.
by Rémi Bernon (＠rbernon) 25 Nov '22

25 Nov '22

We are currently locking the heap to iterate over the allocated regions, in order to check whether a pointer / block really belongs to one of them. This is not what native does it, as HeapFree / HeapReAlloc / HeapSize crashing on invalid pointers shows. This also makes it hard to improve the heap performance in multi-threaded scenarios. This series reduces the locking requirement by keeping the region header offset in each block, relaxing the pointer checks, and assuming a heap region stays … [View More]

2 6

[PATCH v2 0/1] MR1519: mshtml: Handle memory allocation failure in ConnectionPoint_Advise.
by Alex Henrie (＠alexhenrie) 25 Nov '22

25 Nov '22

-- v2: mshtml: Handle memory allocation failure in ConnectionPoint_Advise. https://gitlab.winehq.org/wine/wine/-/merge_requests/1519

3 2

[PATCH 0/1] MR1544: wininet: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 25 Nov '22

25 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1544

3 2

[PATCH v4 0/5] MR1445: kernelbase: Fixes for the shared Software\Classes registry and Wow6432Node registry in general.
by Sven Baars (＠sbaars) 25 Nov '22

25 Nov '22

This reimplements all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the … [View More]

3 7

[PATCH v4 0/10] MR1537: windows.media: Partially implement caption properties.
by Mohamad Al-Jaf (＠maljaf) 25 Nov '22

25 Nov '22

As Wine currently does not have a way to set captions, returning the default value should suffice for most applications. It looks like Windows does not do error checking for the *value parameter. For the computed properties, they return E_INVALIDARG when all the captions are set as Default. But they return S_OK if any of the caption settings have been modified, regardless of whether a valid *value parameter is passed. I expected it to at least return the computed values for the default … [View More]

3 14

[PATCH 0/1] MR1546: programs/cmd: use OEM code page when reading a file
by eric pouech (＠epo) 25 Nov '22

25 Nov '22

Calling GetConsoleCP() when ReadConsoleW() fails (potentially indicating that cmd.exe's instance isn't attached to a console) makes no sense. In details, since GetConsoleCP() returns 0 when not attached to a console to indicate error, we're in fact using CP_ACP. So fallback explicitely to OEM CP (which is the default for CUI programs). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1546

2 1

[PATCH v5 0/6] MR1301: Add ir50_32 video codec for winmm.
by Shaun Ren (＠shaunren) 25 Nov '22

25 Nov '22

This video codec is used by games such as Richman 4, and Zwei: The Arges Adventure. The decoder logic is based on code from the FFmpeg project. -- v5: loader/wine.inf: Enable ir50_32 video codec. ir50_32: Implement decompression to 24-bit and 15-bit RGB. https://gitlab.winehq.org/wine/wine/-/merge_requests/1301

5 11

[PATCH v3 0/10] MR1537: windows.media: Partially implement caption properties.
by Mohamad Al-Jaf (＠maljaf) 25 Nov '22

25 Nov '22

As Wine currently does not have a way to set captions, returning the default value should suffice for most applications. It looks like Windows does not do error checking for the *value parameter. For the computed properties, they return E_INVALIDARG when all the captions are set as Default. But they return S_OK if any of the caption settings have been modified, regardless of whether a valid *value parameter is passed. I expected it to at least return the computed values for the default … [View More]

3 12

[PATCH v2 0/10] MR1537: Draft: windows.media: Partially implement caption properties.
by Mohamad Al-Jaf (＠maljaf) 25 Nov '22

25 Nov '22

As Wine currently does not have a way to set captions, returning the default value should suffice for most applications. It looks like Windows does not do error checking for the *value parameter. For the computed properties, they return E_INVALIDARG when all the captions are set as Default. But they return S_OK if any of the caption settings have been modified, regardless of whether a valid *value parameter is passed. I expected it to at least return the computed values for the default … [View More]

2 12

[PATCH v4 0/1] MR1503: wineusb.sys: Move event handling to a single thread.
by Ivo Ivanov (＠logos128) 25 Nov '22

25 Nov '22

Also fixes a segmentation fault when exiting winedevice.exe. I can file a separate bug report, but it seems related to Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 On my system the core dump can be provoked when using the bus_udev backend in winebus.sys ("Enable SDL" 0). It creates two hid devices - a mouse and a keyboard. Since it resides in the same winedevice.exe process as wineusb.sys, something similar to the above bug occurs when handling the SIGQUIT signal. The actual crash … [View More]

2 1

[PATCH 0/5] MR1540: localspl: Enable tests on modern Windows.
by Piotr Caban (＠piotr) 25 Nov '22

25 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1540

3 6

Re: [PATCH v2 0/8] MR1489: DirectMusic: Don't force a calling convention on internal functions. - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1489

1 0

Re: [PATCH v3 0/2] MR1528: winhttp: Improve WinHttpGetProxyForUrl() execution time when wpad is not available - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1528

1 0

Re: [PATCH v3 0/7] MR1422: winhttp: Do not reference request from websocket. - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1422

1 0

Re: [PATCH v2 0/3] MR1534: vbscript: Handle another variant of LTE/GTE tokens. - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1534

1 0

Re: [PATCH v2 0/5] MR1538: ntdll: Rename some heap constants and small refactoring. - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1538

1 0

Re: [PATCH v3 0/5] MR1527: wmic: Support nicconfig alias. - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1527

1 0

Re: [PATCH v2 0/1] MR1530: mshtml: Use standard C functions for memory allocation. - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1530

1 0

Re: [PATCH v3 0/1] MR1531: pdh: Use standard C functions for memory allocation. - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1531

1 0

Re: [PATCH v2 0/1] MR1532: kernel32/profile: Trim spaces from section names on load. - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1532

1 0

Re: [PATCH v3 0/4] MR1427: wined3d: Add a lower size bound for the streaming buffer allocation. - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1427

1 0

[PATCH v2 0/1] MR1541: winevulkan: Don't try to convert unions without selectors.
by Jacek Caban (＠jacek) 24 Nov '22

24 Nov '22

-- v2: winevulkan: Don't try to convert unions without selectors. https://gitlab.winehq.org/wine/wine/-/merge_requests/1541

3 2

[PATCH 0/1] MR1541: winevulkan: Don't try to convert unions without selectors.
by Jacek Caban (＠jacek) 24 Nov '22

24 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1541

3 2

Re: [PATCH v2 0/2] MR1508: winevulkan: Union conversion and 1.3.235 spec update.
by Jacek Caban (＠jacek) 24 Nov '22

24 Nov '22

On Thu Nov 24 11:02:06 2022 +0000, Georg Lehmann wrote: > Yeah this is a bit unfortunate. Maybe we should just not support 32bit > ray tracing for now, if I recall correctly nvidia doesn't even support > it with their driver. Sure, 32bit ray tracing is probably not important on its own. But more generally, we can't reliably convert unions without selectors, so I'd suggest to express that in make_vulkan. I created !1541 that just skips them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1508#note_17374

1 0

[PATCH 0/8] MR1489: DirectMusic: Don't force a calling convention on internal functions.
by Alex Henrie (＠alexhenrie) 24 Nov '22

24 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1489

4 10

[PATCH 0/3] MR1536: Preparation to long types migration (serie II)
by eric pouech (＠epo) 24 Nov '22

24 Nov '22

Migration a couple of bits to unsigned int. Note to Zebediah (mainly on second commit of this serie): - there is also a load of 'uint32_t flags' parameters that I didn't change (mainly not to change too many things) Is this something to consider? - I didn't touch the local variables either. Maybe it's something to consider also. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1536

4 5

Re: [PATCH v2 0/1] MR1396: configure: On macOS, build the loader targeting 10.7 when preloader is used.
by Dean M Greer (＠Gcenx) 24 Nov '22

24 Nov '22

On Wed Nov 23 21:10:49 2022 +0000, Brendan Shanks wrote: > Yes, although I also reproduced it with a test app I built on Mojave. On > Mojave environ wasn’t NULL, on Monterey/Ventura it was. From searching this seems to be a known issues since macOS 11.1 https://www.gnu.org/software/gnulib/manual/html_node/environ.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1396#note_17364

1 0

[PATCH v3 0/4] MR1502: Draft: winevulkan: wow64 memory mapping using VK_EXT_external_memory_host
by Jacek Caban (＠jacek) 24 Nov '22

24 Nov '22

This MR implements memory mapping for wow64 using VK_EXT_external_memory_host. This has some problems (more below), but overall, it looks promising as a stopgap. It passes D3D tests and works fine in general. For proper solution, we'd need a new Vulkan extension. I experimented with a prototype extension https://github.com/KhronosGroup/Vulkan-Docs/pull/1906 and it looks like we can make it work, my WIP implementation is here https://gitlab.winehq.org/jacek/wine/-/tree/vulkan-map-placed. … [View More]

3 6

[PATCH v2 0/2] MR1528: winhttp: Improve WinHttpGetProxyForUrl() execution time when wpad is not available
by Paul Gofman (＠gofman) 24 Nov '22

24 Nov '22

Fixes Marvel Snap being unable to connect to servers (part of it, another part is wmic patches), and maybe improves wait times in many other apps. Typically "http://wpad/..." (which is commonly requested as lpszAutoConfigUrl for WinHttpGetProxyForUrl) is not available and WinHttpGetProxyForUrl() is hanging for a really long time resolving this name in download_script(). On Windows 10 here the name resolution timeout is about 9sec (and I could not find a way to configure it for a longer … [View More]

3 4

[PATCH v2 0/7] MR1422: winhttp: Do not reference request from websocket.
by Paul Gofman (＠gofman) 24 Nov '22

24 Nov '22

The initial motivation is to make WinHttpCloseHandle(request) with request previously upgraded to websocket deliver WINHTTP_CALLBACK_STATUS_HANDLE_CLOSING right away and not after websocket is closed much later (this late notification causes crash in Microsoft Flight Simulator). That happens so as the notification is sent when the object is destroyed, not when the handle is closed. This logic seems correct to me: when testing some more things involving closing handles and observing which … [View More]threads get the notifications I saw Windows delivering WINHTTP_CALLBACK_STATUS_HANDLE_CLOSING in the other threads, which suggests that the notification can be queued and delayed on Windows too in case there are pending operations involving the object. So the right thing to do seems to be to have just the separate websocket and do not reference request from it. It probably deserves a separate explanation why I am adding a refcounting to netconn and copying it to webscoket instead of just nullifying the netconn in request. Doing that way (just nullifying the netconn in request) immediately caused regression in Elden Ring which started failing in a convoluted way: it doesn't wait for WebSocketReceiveResponse() to complete and calls WebSocketCompleteUpgrade(). That currently succeeds in Wine due to some lack of validation. Then, after upgrade, async WebSocketReceiveResponse proceeds, but with NULL netconn it gets an error from prior WebSocketReceiveResponse in callback and fails the thing. The core problem here is that unless recursive request is involved WebSocketReceiveResponse is always sync on Windows and, as my testing goes, does not involve network communication at all. I. e., looks like the actual reply receiving should be done in WebSocketSendRequest, WebSocketReceiveResponse only sends notifications and possibly queues recursive reque sts. I have a WIP patches for that and_with the help of those and existing winhttp test I realized that removing connection from request is wrong even without convoluted story. We have an existing test in winhttp.c which performs second request / upgrade on a request already upgraded socket. The test as is succeeds even with NULL connection in request by that is by chance only (as we don't try to receive response from our in process server yet which is failing in this case). With connection removed request opens a new one which doesn't get processed by our server, while in the same test on Windows I see that request is actually received by server, suggesting that it uses all the same existing connection on Windows, and so we should keep the same connection in request. As a separate note, I suspect that we now can erroneously cache connection for request upgraded to websocket. But that happens not on request close but under different conditions and looks the same before and after present patches, so this should be probably checked and fixed separately. Patch "winhttp: Move read buffer to websocket." might look weird as introducing the buffer for the only purpose of preserve initial data. While I don't immediately see how that can be done simplier, I have another small excuse for that. Currently the logic of closing websocket handles does the correct thing WRT notifications and aborting the operation. Yet it is still racy a bit due to we use app's buffer in socket read calls. If we happen to receive some data already after we sent notifications but before the read operation is aborted it may write to already freed or otherwise reused app's buffer. It seems to me that the only clean way to deal with that later is to use our own read buffer and copy the data only when we are going to send non-abort completion notification. So this read buffer might have more use in the future. -- v2: winhttp: Do not reference request from socket. winhttp: Move read buffer to websocket. winhttp: Move flags to websocket header. winhttp: Store connection in websocket. winhttp: Send connection close notifications in finished_reading(). winhttp/tests: Avoid race condition on closing connection in server_thread(). winhttp: Add reference counting for connection. https://gitlab.winehq.org/wine/wine/-/merge_requests/1422 [View Less]

3 9

[PATCH 0/10] MR1526: mshtml: Misc improvements.
by Gabriel Ivăncescu (＠insn) 24 Nov '22

24 Nov '22

For the `performance.navigation` props, I store them in the timing that's already linked from the window, to prevent adding more code around that just for 2 props, so it keeps it simple. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1526

3 13

Re: [PATCH v2 0/2] MR1399: explorer: Use a valid taskbar position when the taskbar is hidden.
by Francois Gouget (＠fgouget) 24 Nov '22

24 Nov '22

For reference see bug https://bugs.winehq.org/show_bug.cgi?id=53963 This got fixed by MR!1524 in that the TestBot can again run the full test suite in Wine on dual-screen configurations (but I suspect there is still some underlying issue we are no longer triggering). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1399#note_17352

1 0

[PATCH v9 0/3] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) 24 Nov '22

24 Nov '22

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.or… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is used on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to … [View More]

3 4

[PATCH v2 0/8] MR1535: windows.gaming.input: Implement IForceFeedbackMotor_get_SupportedAxes + some fixes.
by Ivo Ivanov (＠logos128) 24 Nov '22

24 Nov '22

-- v2: windows.gaming.input: Assume that joysticks with single FFB axis are racing wheels. windows.gaming.input: Implement the number of FFB axes according to the SupportedAxes property. dinput/tests: Reduce the available FFB axes to X and Y in test_windows_gaming_input. windows.gaming.input: Set initial effect parameters within the CS. windows.gaming.input: Implement IForceFeedbackMotor_get_SupportedAxes. dinput: Always send both "Type Specific" and "Set Effect" … [View More]

4 10

2025

2024

2023

2022

wine-gitlab