- wine-gitlab - winehq.org

Re: [PATCH v3 0/2] MR1404: d2d1: Derive shared bitmap format from the source bitmap. - approved
by Alexandre Julliard (＠julliard) 17 Nov '22

17 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1404

1 0

Re: [PATCH v2 0/4] MR1402: dpnet: Remove function heap_strdupW. - approved
by Alexandre Julliard (＠julliard) 17 Nov '22

17 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1402

1 0

Re: [PATCH v2 0/1] MR1410: oleaut32/tests: Add a test for VT_NULL input for VarFormatDateTime(). - approved
by Alexandre Julliard (＠julliard) 17 Nov '22

17 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1410

1 0

Re: [PATCH v2 0/1] MR1407: msxml3: Remove unused function heap_strdupW. - approved
by Alexandre Julliard (＠julliard) 17 Nov '22

17 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1407

1 0

Re: [PATCH v2 0/1] MR1411: dwmapi: Fallback to 60Hz if the display frequency is invalid in get_display_frequency(). - approved
by Alexandre Julliard (＠julliard) 17 Nov '22

17 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1411

1 0

Re: [PATCH v2 0/1] MR1408: msi/tests: Correct a couple of failure messages in test_msirecord. - approved
by Alexandre Julliard (＠julliard) 17 Nov '22

17 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1408

1 0

[PATCH v2 0/1] MR1417: ntdll: Do not set system locales that resolve to custom-unspecified.
by Nikolay Sivov (＠nsivov) 17 Nov '22

17 Nov '22

This fixes a crash with .NET application running with such locales, for example en-DE. The crash happens early in initialization, due to failure to return preferred UI language, which happens because there is no LCID -> locale name conversion for custom locales. It doesn't affect just preferred language, but also system default language, and other derived values. -- v2: ntdll: Do not set system locales that resolve to custom-unspecified. https://gitlab.winehq.org/wine/wine/-/merge_requests/1417

2 2

[PATCH 0/1] MR1417: ntdll: Do not set system locales that resolve to custom-unspecified.
by Nikolay Sivov (＠nsivov) 17 Nov '22

17 Nov '22

This fixes a crash with .NET application running with such locales, for example en-DE. The crash happens early in initialization, due to failure to return preferred UI language, which happens because there is no LCID -> locale name conversion for custom locales. It doesn't affect just preferred language, but also system default language, and other derived values. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1417

4 3

[PATCH 0/1] MR1419: server: Take into account extra_size in get_rawinput_buffer
by Aric Stewart (＠aricstewart) 17 Nov '22

17 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1419

4 3

[PATCH 0/1] MR1421: kernelbase: add c++ header guards
by Vitor Ramos (＠VitorRamos) 17 Nov '22

17 Nov '22

pathcch is missing c++ header guars, which leads to missing symbols when trying to link using winebuild -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1421

3 2

[PATCH v3 0/7] MR1373: mshtml: Page-wide events implementation.
by Gabriel Ivăncescu (＠insn) 17 Nov '22

17 Nov '22

This implements some events related to document/window load and unload / visibility changes. The latter is related in that native partially implements it, and only sends it when it is minimized or restored from being minimized, not on navigation or anything else. The main issue for me is the visibilitychange patch. Since we don't control the container hwnd, and it can even be in another process, there is no way to be notified cleanly when it changes its minimization state. We can't subclass it either, as the tests show, it's not subclassed. I implemented it now using an internal timer that polls for that, since it was the least invasive and works in all cases, including other process hwnd. Hooks wouldn't be able to do that, and are also more invasive IMO. I'm hoping for better ideas, though. -- v3: mshtml: Implement pagehide event. mshtml: Implement unload event. mshtml: Implement pageshow event. mshtml: Add visibilitychange event stub. mshtml: Dispatch Gecko events to the window if there's no node. mshtml: Do not register Gecko load event handler twice. mshtml: Allow EVENT_BIND_TO_TARGET to bind to the window. https://gitlab.winehq.org/wine/wine/-/merge_requests/1373

4 11

[PATCH v5 0/21] MR1191: Draft: msvcm: add missing function implementation to fix crashes
by Bartosz Kosiorek (＠gang65) 17 Nov '22

17 Nov '22

After applying these patches, the applications Athenas ASS MHFU v3.42b and miniDSP/IL-DSP runs without crash, and working correctly. Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=47304 Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=34537 Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=32091 -- v5: Revert "msvcm90: add _Getgloballocale implementation." Revert "msvcm90: add _Addstd implementation." msvcm90: add _Addstd implementation. msvcm90: add _Getgloballocale implementation. msvcm90: add _Clocptr_func implementation. msvcm90: add _Sync_func implementation. msvcm90: add _Index_func implementation. msvcm90: add _Init_ctor, _Init_dtor, _Init_locks_ctor, _Init_locks_dtor implementation. msvcm90: add _Init_cnt_func implementation. msvcm90: add _Id_func implementation. msvcm90: add _Id_cnt_func implementation. msvcm90: add _Fpz_func implementation. msvcm90: add _BADOFF_func implementation. msvcm90: add _Wcerr_func implementation. msvcm90: add _Wclog_func implementation. msvcm90: add _Wcout_func implementation. msvcm90: add _Cerr_func implementation. msvcm90: add _Clog_func implementation. msvcm90: add _Cout_func implementation. msvcm90: add _Wcin_func implementation. msvcm90: add _Cin_func implementation. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/1191

2 3

[PATCH v2 0/2] MR1340: d3dcompiler: Print message output with ERR().
by Zebediah Figura (＠zfigura) 17 Nov '22

17 Nov '22

Currently it's not obvious when the HLSL compiler fails, either due to a missing feature or incorrectly coded error check, which can unnecessarily complicate debugging. It's legal for well-behaved programs to try to compile invalid shaders, but that should be a rare enough case that it's worth printing it to Wine debug output regardless. -- v2: d3dcompiler: Print message output with ERR() in D3DPreprocess(). d3dcompiler: Print message output with ERR() in D3DCompile2(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1340

3 3

Re: [PATCH v2 0/0] MR1364: win32u: Correctly report count in GetRawInputBuffer - closed
by Aric Stewart (＠aricstewart) 17 Nov '22

17 Nov '22

This merge request was closed by Aric Stewart. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1364

1 0

[PATCH 0/1] MR1420: winex11: Print a winediag err if XComposite is missing.
by Zebediah Figura (＠zfigura) 17 Nov '22

17 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1420

2 1

[PATCH 0/1] MR1418: msvcm: use stubs to avoid Athenas ASS and IL-DSP crash.
by Bartosz Kosiorek (＠gang65) 17 Nov '22

17 Nov '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=34537 Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=47304 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1418

2 1

[PATCH v4 0/3] MR1231: Improve delete-on-close and delete disposition for files.
by eric pouech (＠epo) 17 Nov '22

17 Nov '22

This series improves Wine's support for delete-on-close flag and delete disposition information on files: - adapts tests for Windows 10 - extend and fix some tests - implement some missing features in ntdll & server -- v4: ntdll: Extend file tests about delete-on-close and disposition. ntdll: Fix share mode for some delete-on-close/delete disposition tests. ntdll: Adapt file tests on delete-on-close / delete disposition to Windows 10. https://gitlab.winehq.org/wine/wine/-/merge_requests/1231

3 5

[PATCH v4 0/9] MR1324: Draft: ntdll: Use a faster code path for unix calls.
by Rémi Bernon (＠rbernon) 17 Nov '22

17 Nov '22

-- v4: ntdll: Inline __wine_unix_call_fast in the dispatcher. winecrt0: Inline PE __wine_unix_call(_fast) function calls. ntdll: Avoid double indirection to get syscall_frame pointer. https://gitlab.winehq.org/wine/wine/-/merge_requests/1324

3 11

[PATCH 0/2] MR49: Always declare UAV images as typed if atomic ops occur.
by Conor McCarthy (＠cmccarthy) 17 Nov '22

17 Nov '22

Atomic ops on images with Unknown type will cause SPIR-V validation failure, and assertion failure in Mesa debug builds. D3D12 allows atomics on typed buffers, and this requires a distinction to be made between UAV reads and atomic ops. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/49

3 3

[PATCH v3 0/4] MR48: vkd3d-shader/hlsl: More miscelaneous fixes.
by Francisco Casas (＠fcasas) 17 Nov '22

17 Nov '22

Just a few miscellaneous fixes I think are simple enough to make it into the next version. -- v3: vkd3d-shader/hlsl: Revert expr_compatible_data_types() args names to "t1" and "t2". vkd3d-shader/hlsl: Don't produce a parse error on empty buffer_body. vkd3d-shader/hlsl: Check for non-static object references on resource stores. tests: Add missing entry for max.shader_test in Makefile.am https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/48

5 10

[PATCH 0/1] MR1400: dinput/tests: Get rid of pDirectInputCreateEx.
by Alex Henrie (＠alexhenrie) 17 Nov '22

17 Nov '22

DirectInputCreateEx is available on all versions of Windows since XP at least. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1400

4 3

[PATCH v3 0/1] MR1414: ntdll: Add integration with Linux FAT file attributes
by Joel Holdsworth (＠jhol) 17 Nov '22

17 Nov '22

On Linux, the FAT filesystem implementation allows DOS file attributes to be applied to files and queried through a family of ioctls. Note that these ioctls are not yet supported by the NTFS or CIFS drivers. Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> -- v3: ntdll: Add integration with Linux FAT file attributes https://gitlab.winehq.org/wine/wine/-/merge_requests/1414

2 1

[PATCH v3 0/8] MR1324: Draft: ntdll: Use a faster code path for unix calls.
by Rémi Bernon (＠rbernon) 17 Nov '22

17 Nov '22

-- v3: ntdll: Inline __wine_unix_call_fast in the dispatcher. winecrt0: Inline PE __wine_unix_call(_fast) function calls. ntdll: Only save non-volatile FPU registers for -nofpu syscalls. ntdll: Use -nofpu for NtQueryPerformanceCounter and NtYieldExecution syscall. opengl32: Use __wine_unix_call_fast instead of __wine_unix_call. ntdll: Introduce a new __wine_unix_call_fast syscall. winebuild: Introduce a new -nofpu syscall spec flag. ntdll: Use named labels for jumps in the syscall dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1324

2 8

[PATCH v2 0/1] MR1414: ntdll: Add integration with Linux FAT file attributes
by Joel Holdsworth (＠jhol) 17 Nov '22

17 Nov '22

On Linux, the FAT filesystem implementation allows DOS file attributes to be applied to files and queried through a family of ioctls. Note that these ioctls are not yet supported by the NTFS or CIFS drivers. Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> -- v2: ntdll: Add integration with Linux FAT file attributes https://gitlab.winehq.org/wine/wine/-/merge_requests/1414

2 1

[PATCH 0/2] MR1413: Mimic native behavior on compilands.
by eric pouech (＠epo) 17 Nov '22

17 Nov '22

Adjustements to mimic native behavior regarding compilands' handling. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1413

3 3

[PATCH 0/1] MR1409: vbscript: Handle index read access to array properties.
by Nikolay Sivov (＠nsivov) 17 Nov '22

17 Nov '22

Described by Jason Millard. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53867 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1409

3 2

[PATCH v2 0/2] MR1394: mshtml: Hide things that were removed in IE11
by Evan Tang (＠etang-cw) 17 Nov '22

17 Nov '22

Hides a bunch of functions that were removed in IE11 from IE11 mode -- v2: mshtml: Hide things that were removed in IE11 mshtml: Add tests for things removed in IE11 https://gitlab.winehq.org/wine/wine/-/merge_requests/1394

4 4

[PATCH 0/6] MR1415: winevulkan: Convert all structs with layout depending on pointer size.
by Jacek Caban (＠jacek) 17 Nov '22

17 Nov '22

This is the main remaining thing needed for wow64 thunk. My plan for wow64 thunks is a bit different than other modules. We usually use the same code for 32-bit and 64-bit builds, but have additional code for wow64. However, in winevulkan, we already have two separated code paths for 32-bit and 64-bit implementations and converting arguments is generally more involved than usually. My plan is to use the existing 32-bit thunks as wow64 thunks to avoid having three code paths. The price is that on plain 32-bit builds will do more conversions than strictly necessary, but it doesn't seem too bad. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1415

2 6

[PATCH v7 0/6] MR1297: gdiplus: Add GdipSetCustomLineCapBaseCap implementation.
by Bartosz Kosiorek (＠gang65) 17 Nov '22

17 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v7: gdiplus: fix shape of CustomLineCap created by GdipCreateAdjustableArrowCap. gdiplus: Add support for widen path with GpCustomLineCap. gdiplus: Move widen_open_figure function to be able to use it from add_anchor function. gdiplus: Add GdipSetCustomLineCapBaseInset implementation. gdiplus: Remove not used LineCustomCap parameter. gdiplus: Add GdipSetCustomLineCapBaseCap implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1297

2 7

[PATCH 0/1] MR1411: dwmapi: Fallback to 60Hz if the display frequency is invalid in get_display_frequency().
by Zhiyi Zhang (＠zhiyi) 17 Nov '22

17 Nov '22

DwmGetCompositionTimingInfo() may throw a zero division exception if the display reports a 0Hz frequency, which can happen when testing under Xephyr without -fakescreenfps option. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1411

3 2

[PATCH 0/1] MR1414: ntdll: Add integration with Linux FAT file attributes
by Joel Holdsworth (＠jhol) 17 Nov '22

17 Nov '22

On Linux, the FAT filesystem implementation allows DOS file attributes to be applied to files and queried through a family of ioctls. Note that these ioctls are not yet supported by the NTFS or CIFS drivers. Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1414

2 1

[PATCH 0/1] MR1412: dbghelp: Fix handling of BA_OP_ChangeCodeLength (PDB).
by eric pouech (＠epo) 17 Nov '22

17 Nov '22

This op is heavily used by clang with PDB debug info, while MSVC barely uses it. This fixes a bunch of problems when loading PDB files generated by clang (eg. the PDB files from wine-gecko). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1412

2 1

[PATCH 0/1] MR1408: msi/tests: Correct a couple of failure messages in test_msirecord.
by Alex Henrie (＠alexhenrie) 17 Nov '22

17 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1408

3 2

[PATCH 0/1] MR1407: msxml3: Remove unused function heap_strdupW.
by Alex Henrie (＠alexhenrie) 17 Nov '22

17 Nov '22

This function has not been used since commit 5b43c42c8832f3e6d0b70a54b01938f43b950647. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1407

3 2

[PATCH 0/1] MR1410: oleaut32/tests: Add a test for VT_NULL input for VarFormatDateTime().
by Nikolay Sivov (＠nsivov) 17 Nov '22

17 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1410

2 1

[PATCH 0/1] MR1395: dbghelp: Add SymAddrIncludeInlineTrace stub.
by Mohamad Al-Jaf (＠maljaf) 17 Nov '22

17 Nov '22

Football Manager 2023 Editor calls this function. The header already includes the prototype. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1395

3 2

[PATCH 0/4] MR1402: dpnet: Remove function heap_strdupW.
by Alex Henrie (＠alexhenrie) 17 Nov '22

17 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1402

3 5

[PATCH 0/1] MR1404: d2d1: Derive shared bitmap format from the source bitmap.
by Nikolay Sivov (＠nsivov) 17 Nov '22

17 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1404

3 2

[PATCH 0/1] MR1406: mstask: Use standard C functions for memory allocation in task.c.
by Alex Henrie (＠alexhenrie) 17 Nov '22

17 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1406

2 1

[PATCH 0/5] MR1405: msado15: Remove functions heap_realloc_zero and strdupW.
by Alex Henrie (＠alexhenrie) 17 Nov '22

17 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1405

2 5

[PATCH v2 0/2] MR1404: d2d1: Derive shared bitmap format from the source bitmap.
by Nikolay Sivov (＠nsivov) 17 Nov '22

17 Nov '22

-- v2: d2d1/tests: Use d2d error code name for unsupported pixel format error code. https://gitlab.winehq.org/wine/wine/-/merge_requests/1404

2 2

[PATCH 0/1] MR1401: ole32: Fix memory leak on error path in composite_get_(left|right)most (Coverity).
by Alex Henrie (＠alexhenrie) 17 Nov '22

17 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1401

3 2

[PATCH 0/2] MR1399: explorer: Use a valid taskbar position when the taskbar is hidden.
by Zhiyi Zhang (＠zhiyi) 17 Nov '22

17 Nov '22

Some applications use FindWindowA() with class Shell_TrayWnd to find the taskbar window on Windows. Then GetWindowRect() is called to get the taskbar window rectangle. Finally, the taskbar window rectangle is subtracted from the primary screen rectangle to calculate the work area. Without a valid taskbar window position, these applications end up getting an incorrect work area and going down the wrong path. So use the same position and size as the host system panel for explorer taskbar when it's hidden. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1399

3 3

[PATCH 0/1] MR1403: inetcomm: Use standard C functions for memory allocation in protocol.c.
by Alex Henrie (＠alexhenrie) 17 Nov '22

17 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1403

2 1

[PATCH 0/3] MR1398: setupapi, ntoskrnl: Set SPDRP_CONFIGFLAGS.
by Zebediah Figura (＠zfigura) 17 Nov '22

17 Nov '22

Logger Pro expects this field to be set on HID PnP devices. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1398

3 4

[PATCH v16 0/11] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 17 Nov '22

17 Nov '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. -- v16: include: Add a comment explaining why all kernel callbacks must be in user32. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

4 17

[PATCH 0/3] MR1397: setupapi: Fixes for buffer size handling in SetupDiGetDeviceInterfaceDetail().
by Zebediah Figura (＠zfigura) 17 Nov '22

17 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1397

3 4

[PATCH v2 0/9] MR1324: Draft: ntdll: Use a faster code path for unix calls.
by Rémi Bernon (＠rbernon) 17 Nov '22

17 Nov '22

-- v2: ntdll: Check non-volatile rflags and skip popfq when possible. ntdll: Use -nofpu for NtQueryPerformanceCounter syscall. ntdll: Inline __wine_unix_call_fast in the dispatcher. winecrt0: Inline PE __wine_unix_call(_fast) function calls. ntdll: Only save non-volatile FPU registers for -nofpu syscalls. opengl32: Use __wine_unix_call_fast instead of __wine_unix_call. ntdll: Introduce a new __wine_unix_call_fast syscall. winebuild: Introduce a new -nofpu syscall spec flag. ntdll: Use named labels for jumps in the syscall dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1324

3 10

[PATCH 0/1] MR1396: configure: On macOS, build the loader targeting 10.7 when preloader is used.
by Brendan Shanks (＠bshanks) 17 Nov '22

17 Nov '22

Building the loader targeting 10.7 (to generate an LC_UNIXTHREAD binary) seems to fix an issue in the Mac driver with 10.13 and earlier where window layers wouldn't update correctly. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52354 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1396

2 1

[PATCH 0/2] MR1340: d3dcompiler: Print message output with ERR().
by Zebediah Figura (＠zfigura) 16 Nov '22

16 Nov '22

Currently it's not obvious when the HLSL compiler fails, either due to a missing feature or incorrectly coded error check, which can unnecessarily complicate debugging. It's legal for well-behaved programs to try to compile invalid shaders, but that should be a rare enough case that it's worth printing it to Wine debug output regardless. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1340

3 8

[PATCH v8 0/2] MR914: ntoskrnl.exe: Implement various KeQuery* functions
by Etaash Mathamsetty (＠etaash.mathamsetty) 16 Nov '22

16 Nov '22

mrac tries to get function pointers for these functions using MmGetSystemRoutineAddress, I haven't seen them being used by it, but might as well implement it since they are very easy to implement. -- v8: ntoskrnl.exe: Implement KeQueryActiveProcessorCount. ntoskrnl.exe: implement KeQueryMaximumProcessorCount/Ex. https://gitlab.winehq.org/wine/wine/-/merge_requests/914

2 2

[PATCH v3 0/1] MR1393: ntoskrnl.exe: Add semi-stub for KeIpiGenericCall.
by Etaash Mathamsetty (＠etaash.mathamsetty) 16 Nov '22

16 Nov '22

fixes bug: https://bugs.winehq.org/show_bug.cgi?id=48989 -- v3: ntoskrnl.exe: Add semi-stub for KeIpiGenericCall. https://gitlab.winehq.org/wine/wine/-/merge_requests/1393

3 2

[PATCH 0/2] MR1394: mshtml: Hide things that were removed in IE11
by Evan Tang (＠etang-cw) 16 Nov '22

16 Nov '22

Hides a bunch of functions that were removed in IE11 from IE11 mode -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1394

2 2

[PATCH 0/14] MR38: vkd3d-shader/hlsl: Add field-level documentation to the most important structs in hlsl.h.
by Francisco Casas (＠fcasas) 16 Nov '22

16 Nov '22

I believe this information could be very useful for newcomers to the HLSL compiler. Documentation often needs to reference other parts of the code, so it can be a problem to update these references if the referenced code is modified. However, I think that documentation in the data definitions (as opposed to documentation inside the functions) is easier to maintain, since each data type is declared in a single place, to which one often keeps going back for reference, so it is less probable to forget to update a comment. Also, it opens up the possibility of explaining **what** things are, instead of **how they are used**, in some cases, avoiding these references to other places in the code. I can think on the following additional benefits: * Updates in these documentation comments, when the way a field is used changes, or when new fields are added, can help making future commits more readable. * Some IDEs display the comments above the field/struct declaration when the cursor is over an use of this field/struct. A hopefully not deceiving sketch: ![Hopefully not deceiving sketch.](/uploads/3f9e65a0dc091904e8267e23e58e37be/field_level_doc.png) -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/38

5 45

[PATCH v9 0/2] MR841: ntoskrnl.exe: processor change callback stubs
by Etaash Mathamsetty (＠etaash.mathamsetty) 16 Nov '22

16 Nov '22

required for mrac anti cheat -- v9: ntoskrnl.exe: Add KeDeregisterProcessorChangeCallback stub. ntoskrnl.exe: Add KeRegisterProcessorChangeCallback stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/841

2 2

Re: [PATCH v2 0/3] MR1389: winspool: Use GetJobW in GetJobA implementation - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1389

1 0

Re: [PATCH v3 0/2] MR1374: Create forward in kernel32 of MapViewOfFileFromApp and CreateFileMappingFromApp to kernelbase - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1374

1 0

Re: [PATCH v2 0/4] MR1391: vbscript: Implement Format* functions. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1391

1 0

Re: [PATCH v2 0/1] MR1390: winevulkan: Generate "in_ext" definition on demand - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1390

1 0

Re: [PATCH v2 0/1] MR1386: include/d3d11.idl: Add GUIDs for video decoder profiles. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1386

1 0

Re: [PATCH v3 0/2] MR1295: Enable compilation with long types in d3dx9_36/tests. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1295

1 0

Re: [PATCH v4 0/5] MR1365: msvcrt: add more *printf* implementations - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1365

1 0

Re: [PATCH v2 0/1] MR1385: vbscript: update parser to allow statements after ELSE without new line - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1385

1 0

Re: [PATCH v2 0/1] MR1388: msv1_0: Drop the ntlm_auth version check. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1388

1 0

Re: [PATCH v2 0/2] MR1387: ldap build fixes - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1387

1 0

Re: [PATCH v2 0/1] MR1382: httpapi: Use standard C functions for memory allocation. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1382

1 0

Re: [PATCH v3 0/1] MR1351: d3dx9/tests: Use standard C functions for memory allocation in mesh.c. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1351

1 0

Re: [PATCH v2 0/1] MR1381: localspl: Use the wcsdup function instead of reimplementing it. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1381

1 0

Re: [PATCH v2 0/1] MR1380: dpnet: Use standard C functions for memory allocation in address.c. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1380

1 0

Re: [PATCH v2 0/1] MR1376: ole32: Fix memory leak on error path in CompositeMonikerImpl_CommonPrefixWith (Coverity). - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1376

1 0

Re: [PATCH v2 0/1] MR1379: comdlg32: Use standard C functions for memory allocation in printdlg.c. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1379

1 0

Re: [PATCH v3 0/1] MR1378: sspicli: Use standard C functions for memory allocation. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1378

1 0

Re: [PATCH v2 0/1] MR1375: ole32: Correct warning message in composite_get_leftmost. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1375

1 0

Re: [PATCH v2 0/1] MR1383: inetcomm: Use standard C functions for memory allocation in mimeole.c. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1383

1 0

[PATCH 0/1] MR1393: ntoskrnl.exe: Add semi-stub for KeIpiGenericCall.
by Etaash Mathamsetty (＠etaash.mathamsetty) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1393

2 1

[PATCH 0/3] MR1389: winspool: Use GetJobW in GetJobA implementation
by Piotr Caban (＠piotr) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1389

3 4

[PATCH 0/1] MR1392: ntdll: Add native thread renaming for macOS.
by Brendan Shanks (＠bshanks) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1392

2 1

Re: [PATCH v6 0/4] MR1297: gdiplus: Add GdipSetCustomLineCapBaseCap implementation.
by Esme Povirk (＠madewokherd) 16 Nov '22

16 Nov '22

The arrowcap changes should be split into a separate patch. Moving the `widen_open_figure` function makes it hard to read the diff. If you must move it, please do that in a separate patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16060

1 0

[PATCH v2 0/4] MR1373: mshtml: Page-wide events implementation.
by Gabriel Ivăncescu (＠insn) 16 Nov '22

16 Nov '22

This implements some events related to document/window load and unload / visibility changes. The latter is related in that native partially implements it, and only sends it when it is minimized or restored from being minimized, not on navigation or anything else. The main issue for me is the visibilitychange patch. Since we don't control the container hwnd, and it can even be in another process, there is no way to be notified cleanly when it changes its minimization state. We can't subclass it either, as the tests show, it's not subclassed. I implemented it now using an internal timer that polls for that, since it was the least invasive and works in all cases, including other process hwnd. Hooks wouldn't be able to do that, and are also more invasive IMO. I'm hoping for better ideas, though. -- v2: mshtml: Implement pagehide event. mshtml: Implement unload event. mshtml: Implement pageshow event. mshtml: Add visibilitychange event stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1373

3 9

[PATCH 0/1] MR1382: httpapi: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 16 Nov '22

16 Nov '22

The big win here is getting rid of the reimplementation of wcsdup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1382

4 3

[PATCH 0/5] MR1384: winegstreamer: Fix some quartz transform issues.
by Anton Baskanov (＠baskanov) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1384

4 12

[PATCH 0/4] MR1391: vbscript: Implement Format* functions.
by Nikolay Sivov (＠nsivov) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1391

4 6

[PATCH 0/1] MR1390: winevulkan: Generate "in_ext" definition on demand
by Alexandros Frantzis (＠afrantzis) 16 Nov '22

16 Nov '22

There are cases in StructConversionFunction.definition where we will generate copy code for extension struct members, without emitting the definition of the "in_ext" variable used in the copy code. This issue is triggered by mismatches in the condition that guards the generation of the "in_ext" definition, and the condition(s) that govern the generation of the member copy code (e.g., in StructConversionFunction.member_needs_copy and VkMember.needs_conversion). In order to avoid such mismatches and the burden of having to keep the conditions in sync, this commit generates the definition on demand, by checking if it's actually needed by the member copy code. Signed-off-by: Alexandros Frantzis <alexandros.frantzis(a)collabora.com> -- Some more details in case a different solution becomes apparent. An example of the aforementioned issue can be triggered if we make VK_EXT_image_drm_format_modifier an UNEXPOSED extension in `make_vulkan`: ``` ../wine/dlls/winevulkan/vulkan_thunks.c: In function ‘convert_VkFormatProperties2_win32_to_host’: ../wine/dlls/winevulkan/vulkan_thunks.c:10214:119: error: ‘in_ext’ undeclared (first use in this function); did you mean ‘index’? 10214 | out_ext->pDrmFormatModifierProperties = convert_VkDrmFormatModifierPropertiesEXT_array_win32_to_host(ctx, in_ext->pDrmFormatModifierProperties, in_ext->drmFormatModifierCount); | ^~~~~~ | index ``` In this particular case the mismatch happens because for the `VkDrmFormatModifierPropertiesListEXT` (returnedonly=true) struct in the INPUT direction the current check doesn't emit `in_ext`: ``` if self.direction == Direction.OUTPUT or not ext.returnedonly: # Not triggered body += ident + "{0} *in_ext = ({0} *)in_header;\n".format(in_type) ``` but `self.member_needs_copy(ext, m)` below for the "pDrmFormatModifierProperties" member returns `True`, requiring `in_ext`. The flow is: ``` * self.member_needs_copy(ext, m) => True if m.name != "sType" and struct.returnedonly and not m.needs_conversion(self.conv, self.unwrap, Direction.INPUT, self.const): # Not triggered return False return True * m.needs_conversion(self.conv, self.unwrap, Direction.INPUT, self.const) => True # if pointer member needs output conversion, it also needs input conversion # to allocate the pointer if direction == Direction.INPUT and self.is_pointer() and \ self.needs_conversion(conv, unwrap, Direction.OUTPUT, struct_const): return True ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1390

3 2

[PATCH v6 0/2] MR1334: xmllite/writer: Handle surrogate pairs
by David Kahurani (＠kahurani) 16 Nov '22

16 Nov '22

Surrogates have to be written in pairs. Also, handle related errors Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v6: xmllite/writer: Handle surrogate pairs https://gitlab.winehq.org/wine/wine/-/merge_requests/1334

2 3

[PATCH v7 0/4] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) 16 Nov '22

16 Nov '22

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.or… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is used on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. On non-x86 Linux <= 4.2 and on other platforms the fallback path using APCs is used. -- v7: ntdll: Add thread_get_register_pointer_values-based fast path for NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based fast path to NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based fast path for NtFlushProcessWriteBuffers. ntdll: Implement NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

4 6

[PATCH 0/4] MR1373: mshtml: Page-wide events implementation.
by Gabriel Ivăncescu (＠insn) 16 Nov '22

16 Nov '22

This implements some events related to document/window load and unload / visibility changes. The latter is related in that native partially implements it, and only sends it when it is minimized or restored from being minimized, not on navigation or anything else. The main issue for me is the visibilitychange patch. Since we don't control the container hwnd, and it can even be in another process, there is no way to be notified cleanly when it changes its minimization state. We can't subclass it either, as the tests show, it's not subclassed. I implemented it now using an internal timer that polls for that, since it was the least invasive and works in all cases, including other process hwnd. Hooks wouldn't be able to do that, and are also more invasive IMO. I'm hoping for better ideas, though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1373

4 7

Re: [PATCH v3 0/5] MR1365: msvcrt: add more *printf* implementations
by Piotr Caban (＠piotr) 16 Nov '22

16 Nov '22

Please don't update MR after it was approved (unless there's a reason to do that, like e.g. you have found a bug, there are conflicts during rebase). It invalidates the review. Since it was a simple rebase the patch still looks good for me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1365#note_16031

1 0

[PATCH v2 0/2] MR1295: Enable compilation with long types in d3dx9_36/tests.
by eric pouech (＠epo) 16 Nov '22

16 Nov '22

-- v2: dlls/d3dx9_36/tests: Use correct integral type. d3dx9_36/tests: Introduce union to help passing float values in DWORD. https://gitlab.winehq.org/wine/wine/-/merge_requests/1295

3 4

[PATCH v2 0/2] MR1374: Create forward in kernel32 of MapViewOfFileFromApp and CreateFileMappingFromApp to kernelbase
by Santino Mazza (＠tati1454) 16 Nov '22

16 Nov '22

Some programs try to import these functions from kernel32.dll instead of kernelbase.dll -- v2: kernel32: Forward MapViewOfFileFromApp kernel32 to kernelbase. kernel32: Forward CreateFileMappingFromApp kernel32 to kernelbase. https://gitlab.winehq.org/wine/wine/-/merge_requests/1374

2 2

[PATCH v5 0/2] MR1334: xmllite/writer: Handle surrogate pairs
by David Kahurani (＠kahurani) 16 Nov '22

16 Nov '22

Surrogates have to be written in pairs. Also, handle related errors Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v5: xmllite/writer: Handle surrogate pairs xmllite/writer: Pass xmlwriteroutput directly. https://gitlab.winehq.org/wine/wine/-/merge_requests/1334

2 2

[PATCH 0/2] MR1374: Import MapViewOfFileFromApp and CreateFileMappingFromApp into kernel32
by Santino Mazza (＠tati1454) 16 Nov '22

16 Nov '22

Some programs try to import these functions from kernel32.dll instead of kernelbase.dll -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1374

4 7

[PATCH 0/1] MR1388: msv1_0: Drop the ntlm_auth version check.
by Hans Leidekker (＠hans) 16 Nov '22

16 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53932 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1388

2 1

[PATCH 0/1] MR1364: win32u: Correctly report count in GetRawInputBuffer
by Aric Stewart (＠aricstewart) 16 Nov '22

16 Nov '22

If rawinput_from_hardware_message generates an error then the number of packets handled may be less then the size of the buffer. Correctly report only the successfully processed packets to avoid using uninitialized data. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1364

4 5

[PATCH 0/2] MR1387: ldap build fixes
by Hans Leidekker (＠hans) 16 Nov '22

16 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53930 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1387

2 2

[PATCH v2 0/1] MR1351: d3dx9/tests: Use standard C functions for memory allocation in mesh.c.
by Alex Henrie (＠alexhenrie) 16 Nov '22

16 Nov '22

The big win here is getting rid of the reimplementation of strdup. -- v2: d3dx9/tests: Use standard C functions for memory allocation in mesh.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/1351

3 3

[PATCH 0/1] MR1386: include/d3d11.idl: Add GUIDs for video decoder profiles.
by Bernhard Kölbl (＠besentv) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1386

2 1

[PATCH 0/1] MR1385: vbscript: update parser to allow statements after ELSE without new line
by Jason Millard (＠jsm174) 16 Nov '22

16 Nov '22

This merge request allows for statements on the same line as ELSE: ``` Dim vrOption vrOption = 3 If vrOption = 1 Then Wscript.Echo "vroption is 1" ElseIf vrOption = 2 Then Wscript.Echo "vroption is 2" Else If vrOption = 3 Then Wscript.Echo "vroption is 3" End If End If ``` Fixes https://bugs.winehq.org/show_bug.cgi?id=53873 Combined effort from myself and Nikolay Sivov -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1385

4 3

[PATCH 0/1] MR1381: localspl: Use the wcsdup function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1381

4 3

Re: [PATCH v2 0/5] MR1365: msvcrt: add more *printf* implementations - approved
by Piotr Caban (＠piotr) 16 Nov '22

16 Nov '22

This merge request was approved by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1365

1 0

Re: [PATCH v2 0/5] MR1365: msvcrt: add more *printf* implementations
by Piotr Caban (＠piotr) 16 Nov '22

16 Nov '22

On Mon Nov 14 20:46:59 2022 +0000, Bartosz Kosiorek wrote: > Is `#if _MSVCR_VER<=120` necessary? It's not necessary for the dlls to work correctly. It makes dlls smaller (at least until some kind of link time optimization is enabled). It also speeds up compilation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1365#note_15998

1 0

2025

2024

2023

2022

wine-gitlab