- wine-gitlab - winehq.org

[PATCH 0/2] MR1353: user32: Add GetPointerTouchInfo(History) stubs.
by Rémi Bernon (＠rbernon) 14 Nov '22

14 Nov '22

Preventing Bloons TD 6 from crashing on touchscreen input. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1353

3 4

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Rémi Bernon (＠rbernon) 14 Nov '22

14 Nov '22

On Mon Nov 14 12:05:16 2022 +0000, Zebediah Figura wrote: > Side note that just occurs to me, we should probably add thread > descriptions for any new threads, though I don't mind deferring that. Good idea, done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15681

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Rémi Bernon (＠rbernon) 14 Nov '22

14 Nov '22

On Fri Nov 11 21:23:39 2022 +0000, Zebediah Figura wrote: > > First because it's how it's supposed to be. > I initially thought that we weren't actually running any visible > callbacks on these read threads, but I guess the allocation callbacks > are coming from here. Windows really spawns two threads for each stream? Sheesh. Yes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15679

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Rémi Bernon (＠rbernon) 14 Nov '22

14 Nov '22

On Fri Nov 11 21:26:14 2022 +0000, Zebediah Figura wrote: > I think we'd still need that GetStreamSelected() check, though, given > we're looping over all the streams here? I don't think we need to check it here anymore with the latest version. Deselected streams will never have pending read requests (or they will shortly complete it after deselection, with either error or a last sample). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15680

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Rémi Bernon (＠rbernon) 14 Nov '22

14 Nov '22

On Fri Nov 11 21:17:44 2022 +0000, Zebediah Figura wrote: > Hmm, I never tested selecting streams while running. If that's supposed > to work it may be better just to leave it as is. Yeah, starting / stopping threads dynamically didn't seem like a good idea and it's easier to check the correctness with all stream threads started on open / stopped on close. So instead I keep the thread running but only emit read requests to selected streams. When a stream is deselected, eventually dynamically, it will either fail its read request with `NS_E_NO_MORE_SAMPLES`, or returns a last sample if that happened before, but will then stop receiving read requests. When a stream is selected again, a read request will be emitted and it will resume reading. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15678

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Rémi Bernon (＠rbernon) 14 Nov '22

14 Nov '22

On Fri Nov 11 21:18:28 2022 +0000, Zebediah Figura wrote: > Yeah, if we need to do this to prevent a deadlock, that sounds to me > like something we need to solve on the sync reader side. I dropped it for now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15677

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Rémi Bernon (＠rbernon) 14 Nov '22

14 Nov '22

On Fri Nov 11 14:46:02 2022 +0000, Rémi Bernon wrote: > Sure, I'll rename running too. I didn't rename `reader->running` after all but I moved the flag to a separate local variable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15676

1 0

[PATCH v14 0/10] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 14 Nov '22

14 Nov '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. -- v14: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Route kernel callbacks through user32. winex11.drv: Pass a struct to x11drv_ime_set_result. winex11.drv: Pass a struct to x11drv_dnd_post_drop. winemac.drv: Route kernel callbacks through user32. wineandroid.drv: Route kernel callbacks through user32. opengl32: Route kernel callbacks through user32. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 11

[PATCH 0/1] MR1347: vbscript: add support for VT_DISPATCH in Global_TypeName
by Jason Millard (＠jsm174) 14 Nov '22

14 Nov '22

This adds support for returning the type name for VT_DISPATCH variants. Fixes https://bugs.winehq.org/show_bug.cgi?id=53868 Combined effort from myself and Nikolay Sivov -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1347

4 4

[PATCH 0/1] MR1354: server: Remove no-op raw_msg.foreground release.
by Rémi Bernon (＠rbernon) 14 Nov '22

14 Nov '22

It's previously initialized to NULL and never updated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1354

3 2

[PATCH 0/1] MR1352: include: Include limits.h in stdlib.h.
by Alex Henrie (＠alexhenrie) 14 Nov '22

14 Nov '22

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1352

4 3

[PATCH 0/1] MR1314: ntdll: Implement HeapCompatibilityInformation for Rtl(Query|Set)HeapInformation.
by Rémi Bernon (＠rbernon) 14 Nov '22

14 Nov '22

In preparation for a future LFH implementation. It's not very useful at the moment but it would help rebasing Proton too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1314

2 2

[PATCH v2 0/1] MR1349: user32: Use standard C functions for memory allocation in combo.c.
by Alex Henrie (＠alexhenrie) 14 Nov '22

14 Nov '22

The big win here is getting rid of the reimplementation of strdup. -- v2: user32: Use standard C functions for memory allocation in combo.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/1349

2 1

[PATCH 0/1] MR1349: user32: Use standard C functions for memory allocation in combo.c.
by Alex Henrie (＠alexhenrie) 14 Nov '22

14 Nov '22

The big win here is getting rid of the reimplementation of strdup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1349

3 2

[PATCH 0/3] MR1348: ws2_32: Add in[46]addr_* constants to static library.
by Alex Henrie (＠alexhenrie) 14 Nov '22

14 Nov '22

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1348

2 3

[PATCH v2 0/3] MR1343: windows.media: Add WinRT Closed Captioning interface.
by Mohamad Al-Jaf (＠maljaf) 13 Nov '22

13 Nov '22

This is my first time implementing an interface so thorough feedback would be appreciated. -- v2: windows.media: Implement IClosedCaptionPropertiesStatics interface. include/windowscontracts: Bump contractversion to 14. windows.media: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/1343

3 7

[PATCH v2 0/2] MR1156: Allow a loaded registry key to be loaded multiple times.
by Santino Mazza (＠tati1454) 13 Nov '22

13 Nov '22

This merge request is related to !820 -- v2: server: Allow a loaded key to be loaded multiple times. advapi32/tests: Test if a loaded key can be loaded multiple times. https://gitlab.winehq.org/wine/wine/-/merge_requests/1156

2 2

[PATCH v2 0/1] MR1315: ntdll: Add support for FreeBSD style extended attributes.
by Joel Holdsworth (＠jhol) 13 Nov '22

13 Nov '22

Co-authored-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> -- v2: ntdll: Add support for FreeBSD style extended attributes. https://gitlab.winehq.org/wine/wine/-/merge_requests/1315

3 3

[PATCH 0/3] MR1343: windows.media: Add WinRT Closed Captioning interface.
by Mohamad Al-Jaf (＠maljaf) 13 Nov '22

13 Nov '22

This is my first time implementing an interface so thorough feedback would be appreciated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1343

4 8

[PATCH 0/1] MR1315: ntdll: Add support for FreeBSD style extended attributes.
by Joel Holdsworth (＠jhol) 13 Nov '22

13 Nov '22

Co-authored-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1315

4 6

[PATCH 0/1] MR1342: ntdll: Use an acquire/release pair on the IOSB status.
by Zebediah Figura (＠zfigura) 13 Nov '22

13 Nov '22

Based on a patch by Jinoh Kang: https://gitlab.winehq.org/wine/wine/-/merge_requests/155 This patch simplifies the comment somewhat; I don't see it as necessary to fully explain the concept of memory barriers and acquire/release everywhere that they are used. In my opinion, it's necessary and also sufficient to explain why these specific places need an acquire/release pair, what that pair is protecting, and to cross-reference the parts of the pair with each other. I've also removed the IOSB aliasing patches. Personally I think that there's no harm in making our code more endianness-conscious, for things like Winelib, but on the other hand Windows never supported big-endian, and we've resisted adding support for architectures Windows doesn't support (and see also [1]). Since it's not clear to me they're desirable, and they're orthogonal to the purpose of this patch set, I've removed them; they can be submitted later if there is a favourable consensus. [1] https://www.winehq.org/pipermail/wine-devel/2021-July/191600.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1342

4 8

[PATCH 0/1] MR1346: cmd: Don't write outside of variable array.
by eric pouech (＠epo) 13 Nov '22

13 Nov '22

GCC 12.2 rightfully complains about an out-of-founds array access. This can possibly happen for unsupported variable names. This is a rudimentary fix (don't write outside of array), but current code will require more cudling (eg: native runs the loop for every parsed token even if the variable name isn't supported) while builtin stops parsing. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1346

3 2

[PATCH 0/1] MR1345: winedbg: Don't use invalid address mode in exception prolog.
by eric pouech (＠epo) 13 Nov '22

13 Nov '22

(Also removes a GCC 12.2 warning about printing NULL string) Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1345

2 1

[PATCH 0/1] MR1341: ntdll: Make the "not found" trace in nt_to_unix_file_name_no_root() less misleading.
by Zebediah Figura (＠zfigura) 13 Nov '22

13 Nov '22

unix_name is not guaranteed to be zero-terminated at this point. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1341

3 2

[PATCH 0/6] MR1298: winegstreamer: MPEG layer-3 decoder output media type enumeration and allocator properties.
by Anton Baskanov (＠baskanov) 13 Nov '22

13 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1298

4 8

[PATCH v4 0/2] MR1307: wined3d: Use the chunk allocator for GL element array buffers.
by Anton Baskanov (＠baskanov) 13 Nov '22

13 Nov '22

- v2: Specify the maximum allowed feature level when creating the device. - v3: Rebased. - v4: Use a flag to indicate that indirect draws won't be used. -- v4: wined3d: Use the chunk allocator for GL element array buffers. wined3d: Introduce a new flag to indicate that indirect draws won't be used. https://gitlab.winehq.org/wine/wine/-/merge_requests/1307

4 4

[PATCH v6 0/5] MR1249: uiautomationcore: Implement UiaFind.
by Connor McAdams (＠cmcadams) 12 Nov '22

12 Nov '22

-- v6: uiautomationcore: Add support for returning multiple HUIANODEs from UiaFind. uiautomationcore: Store traverse_uia_node_tree() results in a dynamic array. uiautomationcore: Add support for ExcludeRoot parameter in UiaFind. uiautomationcore: Partially implement UiaFind. uiautomationcore: Add UiaFind stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1249

3 10

[PATCH v3 0/1] MR1334: xmllite/writer: Handle surrogate pairs
by David Kahurani (＠kahurani) 12 Nov '22

12 Nov '22

Surrogates have to be written in pairs. Also, handle related errors Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v3: xmllite/writer: Handle surrogate pairs https://gitlab.winehq.org/wine/wine/-/merge_requests/1334

3 3

[PATCH v5 0/5] MR1249: uiautomationcore: Implement UiaFind.
by Connor McAdams (＠cmcadams) 12 Nov '22

12 Nov '22

-- v5: uiautomationcore: Add support for returning multiple HUIANODEs from UiaFind. uiautomationcore: Store traverse_uia_node_tree() results in a dynamic array. uiautomationcore: Add support for ExcludeRoot parameter in UiaFind. uiautomationcore: Partially implement UiaFind. uiautomationcore: Add UiaFind stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1249

3 8

[PATCH v2 0/1] MR1334: xmllite/writer: Handle surrogate pairs
by David Kahurani (＠kahurani) 12 Nov '22

12 Nov '22

Surrogates have to be written in pairs. Also, handle related errors Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v2: xmllite/writer: Handle surrogate pairs https://gitlab.winehq.org/wine/wine/-/merge_requests/1334

3 2

[PATCH v13 0/10] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 12 Nov '22

12 Nov '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. -- v13: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Route kernel callbacks through user32. winex11.drv: Pass a struct to x11drv_ime_set_result. winex11.drv: Pass a struct to x11drv_dnd_post_drop. winemac.drv: Route kernel callbacks through user32. wineandroid.drv: Route kernel callbacks through user32. opengl32: Route kernel callbacks through user32. winevulkan: Route kernel callbacks through user32. user32: Add NtUserDispatchCallback kernel callback. user.exe16: Move kernel callbacks to wow_callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 11

[PATCH v7 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) 12 Nov '22

12 Nov '22

The function is implemented by setting cache file pointer to fill read_buf. Consequently, when HTTPREQ_ReadFile is called, it will try reading data from cache after read_buf is depleted, before continuing reading from http stream. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=26570 -- v7: wininet: Partially implement InternetSetFilePointer wininet/tests: Add InternetSetFilePointer tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1268

3 6

[PATCH 0/7] MR1339: ntdll: Support partially releasing virtual memory.
by Paul Gofman (＠gofman) 12 Nov '22

12 Nov '22

The partial free is not supported from VirtualFree (we have a test for that) but NtFreeVirtualMemory supports it. The primary motivation behind these patches is the preparation for VM placeholders support. With those flags (MEM_RESERVE_PLACEHOLDER, MEM_PRESERVE_PLACEHOLDER, MEM_REPLACE_PLACEHOLDER and MEM_COALESCE_PLACEHOLDERS) views might be arbitrary split or joined with just page alignment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1339

2 7

[PATCH v4 0/5] MR1249: uiautomationcore: Implement UiaFind.
by Connor McAdams (＠cmcadams) 12 Nov '22

12 Nov '22

-- v4: uiautomationcore: Add support for returning multiple HUIANODEs from UiaFind. uiautomationcore: Store traverse_uia_node_tree() results in a dynamic array. uiautomationcore: Add support for ExcludeRoot parameter in UiaFind. uiautomationcore: Partially implement UiaFind. uiautomationcore: Add UiaFind stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1249

3 8

[PATCH v3 0/1] MR1331: mscoree: Add StrongNameTokenFromAssembly stub.
by Mohamad Al-Jaf (＠maljaf) 11 Nov '22

11 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53296 -- v3: mscoree: Add StrongNameTokenFromAssembly stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1331

3 3

[PATCH v3 0/5] MR1249: uiautomationcore: Implement UiaFind.
by Connor McAdams (＠cmcadams) 11 Nov '22

11 Nov '22

-- v3: uiautomationcore: Add support for returning multiple HUIANODEs from UiaFind. uiautomationcore: Store traverse_uia_node_tree() results in a dynamic array. uiautomationcore: Add support for ExcludeRoot parameter in UiaFind. uiautomationcore: Partially implement UiaFind. uiautomationcore: Add UiaFind stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1249

4 19

[PATCH 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Rémi Bernon (＠rbernon) 11 Nov '22

11 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311

4 37

Re: [PATCH v2 0/2] MR1330: ntdll: Support specified alignment in NtAllocateVirtualMemoryEx(). - approved
by Alexandre Julliard (＠julliard) 11 Nov '22

11 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1330

1 0

Re: [PATCH v2 0/3] MR1336: winevulkan: make_vulkan clean up - approved
by Alexandre Julliard (＠julliard) 11 Nov '22

11 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1336

1 0

Re: [PATCH v2 0/1] MR1328: vbscript: Add support for argument list in ReDim. - approved
by Alexandre Julliard (＠julliard) 11 Nov '22

11 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1328

1 0

Re: [PATCH v2 0/2] MR1329: winevulkan: Fix handling bitmasks and enums in needs_alignment. - approved
by Alexandre Julliard (＠julliard) 11 Nov '22

11 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1329

1 0

Re: [PATCH v2 0/1] MR1333: ntdll: Readd the missed initialization of the thread register on arm. - approved
by Alexandre Julliard (＠julliard) 11 Nov '22

11 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1333

1 0

[PATCH v2 0/1] MR1278: winegstreamer: Do not destroy condition variables when a thread is waiting on them.
by Giovanni Mascellani (＠giomasce) 11 Nov '22

11 Nov '22

It is possible that a stream is destroyed while another thread is waiting on event_empty_cond or event_cond. The waiting thread should have the opportunity to be rescheduled and exit the critical section before the condition variables and the mutex are destroyed. -- v2: winegstreamer: Do not destroy condition variables when a thread is waiting on them. https://gitlab.winehq.org/wine/wine/-/merge_requests/1278

5 15

[PATCH 0/2] MR1332: d3drm: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 11 Nov '22

11 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1332

4 4

[PATCH v2 0/1] MR1331: mscoree: Add StrongNameTokenFromAssembly stub.
by Mohamad Al-Jaf (＠maljaf) 11 Nov '22

11 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53296 -- v2: mscoree: Add StrongNameTokenFromAssembly stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1331

3 2

[PATCH 0/2] MR1338: msxml3: Escape special characters in xml nodes
by Evan Tang (＠etang-cw) 11 Nov '22

11 Nov '22

Allows the Adobe Photoshop Elements installer to get slightly further than before The `E_FAIL` check for switching to int while there's a non-integer string isn't needed for the installer and is just something I hit accidentally when trying to write the test cases. Should I leave it in? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1338

2 2

[PATCH v2 0/5] MR1249: uiautomationcore: Implement UiaFind.
by Connor McAdams (＠cmcadams) 11 Nov '22

11 Nov '22

-- v2: uiautomationcore: Add support for returning multiple HUIANODEs from UiaFind. uiautomationcore: Store traverse_uia_node_tree() results in a dynamic array. uiautomationcore: Add support for ExcludeRoot parameter in UiaFind. uiautomationcore: Partially implement UiaFind. uiautomationcore: Add UiaFind stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1249

3 28

[PATCH 0/4] MR1317: mshtml: HTMLDocumentObj fixes.
by Gabriel Ivăncescu (＠insn) 11 Nov '22

11 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1317

3 10

[PATCH 0/1] MR1337: vbscript: add support for redim lists
by Jason Millard (＠jsm174) 11 Nov '22

11 Nov '22

This adds support for having lists in redim statements. ``` Dim x, y Redim x(20), y(30) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1337

3 4

[PATCH v2 0/4] MR48: vkd3d-shader/hlsl: More miscelaneous fixes.
by Francisco Casas (＠fcasas) 11 Nov '22

11 Nov '22

Just a few miscellaneous fixes I think are simple enough to make it into the next version. -- v2: vkd3d-shader/hlsl: Revert expr_compatible_data_types() args names to "t1" and "t2". vkd3d-shader/hlsl: Don't produce a parse error on empty buffer_body. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/48

3 8

[PATCH 0/3] MR1336: winevulkan: make_vulkan clean up
by Jacek Caban (＠jacek) 11 Nov '22

11 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1336

2 3

[PATCH 0/1] MR1334: xmllite/writer: Handle surrogate pairs
by David Kahurani (＠kahurani) 11 Nov '22

11 Nov '22

Surrogates have to be written in pairs. Also, handle related errors Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1334

3 7

[PATCH 0/2] MR1329: winevulkan: Fix handling bitmasks and enums in needs_alignment.
by Georg Lehmann (＠DadSchoorse) 11 Nov '22

11 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1329

4 4

[PATCH 0/1] MR1328: vbscript: Add support for argument list in ReDim.
by Nikolay Sivov (＠nsivov) 11 Nov '22

11 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53782 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1328

4 3

[PATCH 0/1] MR1333: ntdll: Readd the missed initialization of the thread register on arm.
by Martin Storsjö (＠mstorsjo) 11 Nov '22

11 Nov '22

This was missed in d3a68e434e9b19ac35066ebf47a01cea0a19b7da. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1333

2 1

Re: [PATCH v2 0/3] MR1322: opengl32: Convert to PE.
by Alexandre Julliard (＠julliard) 11 Nov '22

11 Nov '22

> Why was this merged, knowing that it caused a significant performance drop across a wide range of games? Why was it necessary to not even wait for merge request 1324 to be finalized? Because it's going in the right direction, it would be good to have in 8.0, and we don't want to merge it at the last minute. The performance fixes can be merged up until code freeze (or even after, depending on how intrusive they are). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1322#note_14030

1 0

[PATCH 0/1] MR1331: mscoree: Add StrongNameTokenFromAssembly stub.
by Mohamad Al-Jaf (＠maljaf) 11 Nov '22

11 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53296 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1331

2 1

Re: [PATCH v2 0/3] MR1322: opengl32: Convert to PE.
by ammar sadaoui (＠aryma) 11 Nov '22

11 Nov '22

On Fri Nov 11 03:17:20 2022 +0000, Zebediah Figura wrote: > Why was this merged, knowing that it caused a significant performance > drop across a wide range of games? Why was it necessary to not even wait > for merge request 1324 to be finalized? I wonder did we real need this ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1322#note_14022

1 0

[PATCH 0/2] MR1330: ntdll: Support specified alignment in NtAllocateVirtualMemoryEx().
by Paul Gofman (＠gofman) 11 Nov '22

11 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1330

2 2

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Zhiyi Zhang (＠zhiyi) 11 Nov '22

11 Nov '22

On Thu Nov 10 22:06:15 2022 +0000, Alexandre Julliard wrote: > I've reverted it for now, until we can figure out why it's causing failures. Thanks, I will look into this. Sorry for the trouble. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_14020

1 0

Re: [PATCH v2 0/3] MR1322: opengl32: Convert to PE.
by Zebediah Figura (＠zfigura) 10 Nov '22

10 Nov '22

Why was this merged, knowing that it caused a significant performance drop across a wide range of games? Why was it necessary to not even wait for merge request 1324 to be finalized? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1322#note_13994

1 0

[PATCH 0/4] MR48: vkd3d-shader/hlsl: More miscelaneous fixes.
by Francisco Casas (＠fcasas) 10 Nov '22

10 Nov '22

Just a few miscellaneous fixes I think are simple enough to make it into the next version. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/48

2 4

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

On Thu Nov 10 16:40:43 2022 +0000, Rémi Bernon wrote: > It's for a MR that hasn't been rebased on top of latest HEAD and doesn't > contain this change. I've reverted it for now, until we can figure out why it's causing failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13991

1 0

Re: [PATCH v2 0/1] MR1327: d2d1/tests: Use correct flags constants with D3D11CreateDevice(). - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1327

1 0

Re: [PATCH v6 0/6] MR1025: ntdll: Support memory address requirements in NtAllocateVirtualMemoryEx() - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1025

1 0

Re: [PATCH v3 0/7] MR1312: ntdll: Implement heap user flags and fix GlobalHandle / LocalHandle with heap pointers. - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1312

1 0

Re: [PATCH v2 0/8] MR1323: winevulkan: Get rid of *_host types. - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1323

1 0

Re: [PATCH v2 0/3] MR1322: opengl32: Convert to PE. - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1322

1 0

Re: [PATCH v2 0/1] MR1316: riched20: Fix failing test in UTF8 locales. - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1316

1 0

Re: [PATCH v4 0/1] MR1188: ntoskrnl.exe: Implement KeInitializeGuardedMutex. - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1188

1 0

Re: [PATCH v2 0/2] MR1319: Implement MB_SYSTEMMODAL for message boxes - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1319

1 0

Re: [PATCH v5 0/2] MR352: cmd: Don't loop infinitely on NUL. - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/352

1 0

Re: [PATCH v2 0/1] MR1320: winemac.drv: Stop using deprecated kIOMasterPortDefault constant. - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1320

1 0

Re: [PATCH v2 0/1] MR1290: mscoree: Use standard C functions for memory allocation in assembly.c. - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1290

1 0

Re: [PATCH v12 0/6] MR42: vkd3d-shader/hlsl: Some fixes. - approved
by Alexandre Julliard (＠julliard) 10 Nov '22

10 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/42

1 0

[PATCH 0/1] MR1327: d2d1/tests: Use correct flags constants with D3D11CreateDevice().
by Nikolay Sivov (＠nsivov) 10 Nov '22

10 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1327

3 2

[PATCH v2 0/1] MR1250: Draft: win32u: Initialize the server's cursor position from the user driver's.
by Tim Clem (＠tclem) 10 Nov '22

10 Nov '22

The server's idea of the cursor position is never really initialized. Normally that's not a problem, since the first mouse movement and a number of other X events will update it. But in the case where the user never moves the mouse, it can remain out of sync. That manifests as `GetCursorPos` bouncing between the server's incorrect value and the real one from the user driver, depending on the age of the position on the server. I've marked this as a draft for two reasons: 1. I don't quite know where this belongs. We want to do it early in the lifespan of a user driver but after there's a desktop, so I've put it behind a `pthread_once` called from `get_desktop_window`. 2. I'm calling `NtUserSetCursorPos` to update the server, rather than a direct `set_cursor` request, because it contains some DPI logic. That has the side effect of potentially warping the cursor. That's not desirable or necessary, but it shouldn't be a problem. It's easily factored around if we want to avoid it. Any guidance would be greatly appreciated! -- v2: win32u: Initialize the server's cursor position from the user driver's. https://gitlab.winehq.org/wine/wine/-/merge_requests/1250

3 7

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Rémi Bernon (＠rbernon) 10 Nov '22

10 Nov '22

On Thu Nov 10 16:26:09 2022 +0000, Zhiyi Zhang wrote: > https://gitlab.winehq.org/epo/wine/-/jobs/4880 succeeds It's for a MR that hasn't been rebased on top of latest HEAD and doesn't contain this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13956

1 0

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Zhiyi Zhang (＠zhiyi) 10 Nov '22

10 Nov '22

On Thu Nov 10 15:24:19 2022 +0000, Zhiyi Zhang wrote: > Tahoma is available so it's probably not that. > In the last comment, I mentioned there are no failures I meant no msg.c > failures. On second look, I can reliably reproduce those win.c failures > on FVWM, going as far back as wine-7.10. https://gitlab.winehq.org/epo/wine/-/jobs/4880 succeeds -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13954

1 0

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Zhiyi Zhang (＠zhiyi) 10 Nov '22

10 Nov '22

On Thu Nov 10 14:20:00 2022 +0000, Rémi Bernon wrote: > Reverting that single commit fixes the Gitlab pipeline, see > https://gitlab.winehq.org/rbernon/wine/-/pipelines/4066 vs > https://gitlab.winehq.org/rbernon/wine/-/pipelines/4064. It's perhaps > something with missing fonts? Tahoma is available so it's probably not that. In the last comment, I mentioned there are no failures I meant no msg.c failures. On second look, I can reliably reproduce those win.c failures on FVWM, going as far back as wine-7.10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13949

1 0

[PATCH v2 0/7] MR1312: ntdll: Implement heap user flags and fix GlobalHandle / LocalHandle with heap pointers.
by Rémi Bernon (＠rbernon) 10 Nov '22

10 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53741 -- v2: ntdll: Implement RtlSetUserFlagsHeap. ntdll: Check block user flags in RtlGetUserInfoHeap. ntdll: Check block user flags in RtlSetUserValueHeap. ntdll: Store the user flags in the heap block flags. ntdll: Introduce a new heap block_set_flags helper. kernel32/tests: Test (Global|Local)Handle with heap allocated pointers. kernel32/tests: Test more Global/Local functions with invalid pointers. https://gitlab.winehq.org/wine/wine/-/merge_requests/1312

3 9

[PATCH 0/3] MR1322: opengl32: Convert to PE.
by Rémi Bernon (＠rbernon) 10 Nov '22

10 Nov '22

Performance hit measured on a few games (with esync and wined3d), CPU% is the time spent in the syscall dispatcher as measured with `perf top -K` while the game is running, the measured scene is usually right after starting a new game: * Brink (32-bit, GL, id Tech 4): 550 fps, 3% CPU -> 480 fps, 12% CPU * Shadow Warrior 2 (64-bit, d3d11): 75 fps, 2% CPU -> 50 fps, 20% CPU * Hat in Time (64-bit, d3d9, UE3): 220 fps, 5% CPU -> 215 fps, 10% CPU * Control (64-bit, d3d11): 25 fps, 0% CPU -> 25 fps, 3% CPU * Obduction (64-bit, d3d11, UE4): 85 fps, 30% CPU -> 80 fps, 30% CPU -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1322

4 8

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Rémi Bernon (＠rbernon) 10 Nov '22

10 Nov '22

On Thu Nov 10 14:15:17 2022 +0000, Zhiyi Zhang wrote: > It's hard to tell if it's caused by this commit. I can not reproduce > this with Ubuntu 22.10 GNOME 43. Then I switched to FVWM and > successfully reproduced the failures. However, just as when I tried to > bisect, all the failures are gone. I also tried to create a new prefix > with f7e1bb9(right before this commit), then apply this patch and rerun > the tests, but still no failures. After applying the patch, I manually > copied the new light.msstyles to the old prefix, no failures. Then > toggling the theming status or recreating the prefix with 9f3138b can > not reproduce those failures either. > Those failures also look unrelated to the theming changes. Reverting that single commit fixes the Gitlab pipeline, see https://gitlab.winehq.org/rbernon/wine/-/pipelines/4066 vs https://gitlab.winehq.org/rbernon/wine/-/pipelines/4064. It's perhaps something with missing fonts? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13944

1 0

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Zhiyi Zhang (＠zhiyi) 10 Nov '22

10 Nov '22

On Thu Nov 10 14:15:18 2022 +0000, Rémi Bernon wrote: > I believe this broke Gitlab CI, this is the only pipeline that failed > from yesterday, in user32, and it now fails with all MRs. It's hard to tell if it's caused by this commit. I can not reproduce this with Ubuntu 22.10 GNOME 43. Then I switched to FVWM and successfully reproduced the failures. However, just as when I tried to bisect, all the failures are gone. I also tried to create a new prefix with f7e1bb9(right before this commit), then apply this patch and rerun the tests, but still no failures. After applying the patch, I manually copied the new light.msstyles to the old prefix, no failures. Then toggling the theming status or recreating the prefix with 9f3138b can not reproduce those failures either. Those failures also look unrelated to the theming changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13939

1 0

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Rémi Bernon (＠rbernon) 10 Nov '22

10 Nov '22

I believe this broke Gitlab CI, this is the only pipeline that failed from yesterday, in user32, and it now fails with all MRs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13938

1 0

[PATCH 0/2] MR1324: Draft: ntdll: Use a faster code path for unix calls.
by Rémi Bernon (＠rbernon) 10 Nov '22

10 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1324

2 2

[PATCH v3 0/2] MR1307: wined3d: Use the chunk allocator for GL element array buffers.
by Anton Baskanov (＠baskanov) 10 Nov '22

10 Nov '22

v2: Specify the maximum allowed feature level when creating the device. v3: Rebased. -- v3: wined3d: Use the chunk allocator for GL element array buffers. wined3d: Specify the maximum allowed feature level when creating the device. https://gitlab.winehq.org/wine/wine/-/merge_requests/1307

4 4

[PATCH 0/8] MR1323: winevulkan: Get rid of *_host types.
by Jacek Caban (＠jacek) 10 Nov '22

10 Nov '22

This MR also contains a few fixes and missing conversions support. We no longer need 32-bit types outside vulkan_thunks.c, so we can default to host struct layouts and use `WINE_VK_HOST` in unixlib. This essentially means that vulkan.c is ready for wow64 (vulkan_thunks.c still needs more patches, mostly applying conversions to more types). Instead of defining *_host types, use local *32 types in generated thunks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1323

2 8

[PATCH v6 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) 10 Nov '22

10 Nov '22

The function is implemented by setting cache file pointer to fill read_buf. Consequently, when HTTPREQ_ReadFile is called, it will try reading data from cache after read_buf is depleted, before continuing reading from http stream. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=26570 -- v6: wininet: Partially implement InternetSetFilePointer https://gitlab.winehq.org/wine/wine/-/merge_requests/1268

3 7

[PATCH v2 0/2] MR1307: wined3d: Use the chunk allocator for GL element array buffers.
by Anton Baskanov (＠baskanov) 10 Nov '22

10 Nov '22

v2: Specify the maximum allowed feature level when creating the device. -- v2: wined3d: Use the chunk allocator for GL element array buffers. wined3d: Specify the maximum allowed feature level when creating the device. https://gitlab.winehq.org/wine/wine/-/merge_requests/1307

3 3

[PATCH 0/1] MR1316: riched20: Fix failing test in UTF8 locales.
by eric pouech (＠epo) 10 Nov '22

10 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52875 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1316

3 2

[PATCH 0/2] MR1319: Implement MB_SYSTEMMODAL for message boxes
by Santino Mazza (＠tati1454) 10 Nov '22

10 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1319

3 3

Re: [PATCH v4 0/2] MR352: cmd: Don't loop infinitely on NUL. - approved
by eric pouech (＠epo) 10 Nov '22

10 Nov '22

This merge request was approved by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/352

1 0

Re: [PATCH v3 0/7] MR1303: winevulkan: Convert struct chain conversions for all structs that need it.
by Jacek Caban (＠jacek) 09 Nov '22

09 Nov '22

On Wed Nov 9 23:47:19 2022 +0000, Georg Lehmann wrote: > Did you already report the various xml inconsistencies you found? We > should get them fixed and remove the hard coded workarounds when we > update the xml to a new enough version. Not yet, but I definitely agree that we should fix it in upstream xml instead. I keep finding them while reviewing generated code, so my plan was to report it once my work is more complete. There is still more code that will need to be generated for wow64. I have one more fixup in my tree, but I'm not yet sure if that list is complete. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1303#note_13912

1 0

Re: [PATCH v3 0/7] MR1303: winevulkan: Convert struct chain conversions for all structs that need it.
by Georg Lehmann (＠DadSchoorse) 09 Nov '22

09 Nov '22

Did you already report the various xml inconsistencies you found? We should get them fixed and remove the hard coded workarounds when we update the xml to a new enough version. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1303#note_13904

1 0

[PATCH 0/1] MR1290: mscoree: Use standard C functions for memory allocation in assembly.c.
by Alex Henrie (＠alexhenrie) 09 Nov '22

09 Nov '22

The big win here is getting rid of the reimplementation of wcsdup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1290

3 2

[PATCH 0/1] MR1320: winemac.drv: Stop using deprecated kIOMasterPortDefault constant.
by Brendan Shanks (＠bshanks) 09 Nov '22

09 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1320

3 2

Re: [PATCH v4 0/3] MR1302: wow64: Handle regions extending pass the address limit in NtQueryVirtualMemory. - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1302

1 0

Re: [PATCH v2 0/1] MR1318: ntdll: Write ret_len with the right size in user_mode_callback_return on arm64 - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1318

1 0

Re: [PATCH v2 0/1] MR1308: ntdll: Fix incorrectly sized mov in user_mode_callback_return. - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1308

1 0

2025

2024

2023

2022

wine-gitlab