- wine-gitlab - winehq.org

Re: [PATCH v2 0/2] MR1266: d3d8, d3d9: Build without -DWINE_NO_LONG_TYPES. - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1266

1 0

Re: [PATCH v2 0/5] MR1131: wined3d: Dirty rect fixes. - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1131

1 0

Re: [PATCH v2 0/3] MR1313: Multi-arch support from Wine's build tree in dbghelp. - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1313

1 0

Re: [PATCH v2 0/1] MR1271: user32: Use NtUserSetWindowLongPtr() in set_dialog_proc(). - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1271

1 0

Re: [PATCH v2 0/2] MR1129: wined3d: Set the window state thread description only if it's actually a new thread. - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1129

1 0

Re: [PATCH v3 0/7] MR1303: winevulkan: Convert struct chain conversions for all structs that need it. - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1303

1 0

Re: [PATCH v2 0/5] MR1310: opengl32: Complete preparation for PE conversion. - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1310

1 0

Re: [PATCH v2 0/1] MR1309: netprofm: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1309

1 0

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics. - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304

1 0

Re: [PATCH v3 0/1] MR1272: include: Define PROPSHEETPAGE[AW]_V[1-4]. - approved
by Alexandre Julliard (＠julliard) 09 Nov '22

09 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1272

1 0

[PATCH v11 0/6] MR42: vkd3d-shader/hlsl: Some fixes.
by Francisco Casas (＠fcasas) 09 Nov '22

09 Nov '22

A mix of a miscellaneous fixes: * Fixes to failed asserts I have stumbled upon when implementing other features. * Checks required for properly supporting object components. * A couple of code improvements. -- v11: vkd3d-shader/hlsl: Use reg_size as component count when allocating a single register. vkd3d-shader/hlsl: Use the base type of the array elements in write_sm1_type(). vkd3d-shader/hlsl: Validate that statics don't contain both resources and numerics. vkd3d-shader/hlsl: Validate that extern structs don't contain objects SM < 5. vkd3d-shader/hlsl: Don't allocate object types as constant registers. vkd3d-shader/hlsl: Properly free new store node memory if init_deref() fails. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/42

4 8

[PATCH v5 0/6] MR1025: ntdll: Support memory address requirements in NtAllocateVirtualMemoryEx()
by Paul Gofman (＠gofman) 09 Nov '22

09 Nov '22

Various notes: - LowestStartingAddress is still unsupported; - Patch 5 ("wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent") is fixing existing WOW issue: NtAllocateVirtualMemoryEx() called from wow64 currently does not constraing the allocation to 32 bit address space (wow64_NtAllocateVirtualMemory() passes zero_bits for that). - I initially thought of using a single inter process APC but added a different one due to zero_bits handling which is easier to convert in the target process. -- v5: wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent. wow64: Support MEM_ADDRESS_REQUIREMENTS in wow64_NtAllocateVirtualMemoryEx(). ntdll/tests: Add tests for memory address requiements. ntdll: Support HighestEndingAddress in NtAllocateVirtualMemoryEx(). ntdll: Factor out allocate_virtual_memory(). ntdll: Pass limit instead of zero_bits to map_view(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1025

2 7

[PATCH v4 0/8] MR1025: ntdll: Support memory address requirements in NtAllocateVirtualMemoryEx()
by Paul Gofman (＠gofman) 09 Nov '22

09 Nov '22

Various notes: - LowestStartingAddress is still unsupported; - Patch 5 ("wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent") is fixing existing WOW issue: NtAllocateVirtualMemoryEx() called from wow64 currently does not constraing the allocation to 32 bit address space (wow64_NtAllocateVirtualMemory() passes zero_bits for that). - I initially thought of using a single inter process APC but added a different one due to zero_bits handling which is easier to convert in the target process. -- v4: ntdll: Support specified alignment in NtAllocateVirtualMemoryEx(). ntdll: Pass alignemnt mask to map_view(). wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent. wow64: Support MEM_ADDRESS_REQUIREMENTS in wow64_NtAllocateVirtualMemoryEx(). ntdll/tests: Add tests for memory address requiements. ntdll: Support HighestEndingAddress in NtAllocateVirtualMemoryEx(). ntdll: Factor out allocate_virtual_memory(). ntdll: Pass limit instead of zero_bits to map_view(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1025

5 18

[PATCH v5 0/4] MR1297: Draft: gdiplus: Add GdipSetCustomLineCapBaseCap implementation.
by Bartosz Kosiorek (＠gang65) 09 Nov '22

09 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v5: gdiplus: Add support for widen path with GpCustomLineCap. https://gitlab.winehq.org/wine/wine/-/merge_requests/1297

2 4

[PATCH v10 0/6] MR42: vkd3d-shader/hlsl: Some fixes.
by Francisco Casas (＠fcasas) 09 Nov '22

09 Nov '22

A mix of a miscellaneous fixes: * Fixes to failed asserts I have stumbled upon when implementing other features. * Checks required for properly supporting object components. * A couple of code improvements. -- v10: vkd3d-shader/hlsl: Use reg_size as component count when allocating a single register. vkd3d-shader/hlsl: Use the base type of the array elements in write_sm1_type(). vkd3d-shader/hlsl: Validate that statics don't contain both resources and numerics. vkd3d-shader/hlsl: Validate that extern structs don't contain objects SM < 5. vkd3d-shader/hlsl: Don't allocate object types as constant registers. vkd3d-shader/hlsl: Properly free new store node memory if init_deref() fails. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/42

2 7

[PATCH 0/1] MR1318: ntdll: Write ret_len with the right size in user_mode_callback_return on arm64
by Martin Storsjö (＠mstorsjo) 09 Nov '22

09 Nov '22

This fixes a regression since 4069a8b384c15a90a7af66636ec5650eeb53b391. This is the same fix as in !1308, but for arm64. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1318

3 2

Re: [PATCH v4 0/2] MR352: cmd: Don't loop infinitely on NUL.
by Arek Hiler (＠ivyl) 09 Nov '22

09 Nov '22

Just a rebase because it was sitting here for quite a while. I've included your changes from the linked bug the previous time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/352#note_13858

1 0

[PATCH 0/1] MR1308: ntdll: Fix incorrectly sized mov in user_mode_callback_return.
by Torge Matthies (＠tmatthies) 09 Nov '22

09 Nov '22

This caused non-interactible windows in my Wine builds, where in win32u `dispatch_win_proc_params` got inlined into `call_window_proc` and this mov overwrote the lower 32 bits of `result`, causing WM_NCHITTEST messages to always return 0 or 0xffffffff00000000 (correct result was -1 in that case). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1308

3 2

[PATCH v3 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 09 Nov '22

09 Nov '22

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v3: ntdll: Remove unnecessary signal_start_thread register spilling. ntdll: Remove unnecessary arch specific exit frame pointer. ntdll: Avoid calling pthread_exit on thread exit. ntdll: Create a pthread for the main thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

4 14

[PATCH v3 0/3] MR1302: wow64: Handle regions extending pass the address limit in NtQueryVirtualMemory.
by Tim Clem (＠tclem) 09 Nov '22

09 Nov '22

There are regions of virtual memory that start below the WoW user address limit but end beyond it (e.g. a large empty region between the end of 32-bit allocations and 64-bit ntdll). When queried from WoW via `NtQueryVirtualMemory(MemoryBasicInformation)`, the returned struct for such a region will have `BaseAddress + RegionSize` past the highest user address (or even worse - it may overflow 32 bits). These patches make WoW `NtQueryVirtualMemory` report a truncated size for such regions, so that they appear to end exactly at the highest user address. This fixes programs that, e.g., walk their address space using iterated calls to `VirtualQuery`. Also, make `MemoryRegionInformation` queries return `STATUS_INVALID_PARAMETER` when passed an address beyond the user address limit, like `MemoryBasicInformation` already does. -- v3: wow64: Truncate too-large regions from NtQueryVirtualMemory(MemoryRegionInformation). wow64: Return error from NtQueryVirtualMemory(MemoryRegionInformation) for a too-large address. wow64: Truncate too-large regions from NtQueryVirtualMemory(MemoryBasicInformation). https://gitlab.winehq.org/wine/wine/-/merge_requests/1302

2 3

[PATCH 0/1] MR1307: wined3d: Use the chunk allocator for GL element array buffers.
by Anton Baskanov (＠baskanov) 09 Nov '22

09 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1307

3 2

Re: [PATCH v9 0/6] MR42: vkd3d-shader/hlsl: Some fixes.
by Francisco Casas (＠fcasas) 09 Nov '22

09 Nov '22

Rebasing on top of master... -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/42#note_13842

1 0

Re: [PATCH v4 0/2] MR352: cmd: Don't loop infinitely on NUL.
by eric pouech (＠epo) 09 Nov '22

09 Nov '22

Hi @ivyl is it just a rebase or did you change other things ? (can't get a diff between the two, gitlab says more that 1000 files changed) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/352#note_13840

1 0

[PATCH v8 0/6] MR42: vkd3d-shader/hlsl: Some fixes.
by Francisco Casas (＠fcasas) 09 Nov '22

09 Nov '22

A mix of a miscellaneous fixes: * Fixes to failed asserts I have stumbled upon when implementing other features. * Checks required for properly supporting object components. * A couple of code improvements. -- v8: vkd3d-shader/hlsl: Use reg_size as component count when allocating a single register. vkd3d-shader/hlsl: Use the base type of the array elements in write_sm1_type(). vkd3d-shader/hlsl: Validate that statics don't contain both resources and numerics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/42

4 10

[PATCH 0/2] MR1266: d3d8, d3d9: Build without -DWINE_NO_LONG_TYPES.
by Zebediah Figura (＠zfigura) 09 Nov '22

09 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1266

3 3

[PATCH 0/5] MR1131: wined3d: Dirty rect fixes.
by Zebediah Figura (＠zfigura) 09 Nov '22

09 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1131

4 7

[PATCH 0/2] MR1129: wined3d: Set the window state thread description only if it's actually a new thread.
by Zebediah Figura (＠zfigura) 09 Nov '22

09 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1129

4 4

[PATCH v2 0/7] MR1303: winevulkan: Convert struct chain conversions for all structs that need it.
by Jacek Caban (＠jacek) 09 Nov '22

09 Nov '22

-- v2: winevulkan: Use generated thunks for VkPipelineCreationFeedback conversion. winevulkan: Convert struct chain conversions for all structs that need it. winevulkan: Use const types in conversion function declarations. winevulkan: Use generated thunks for vkGetImageSparseMemoryRequirements(2) conversion. winevulkan: Support pointer dynamic array lenghts. winevulkan: Store parent in VkVariable. winevulkan: Always fill output in fill_luid_property. https://gitlab.winehq.org/wine/wine/-/merge_requests/1303

2 7

[PATCH 0/8] MR1312: ntdll: Implement heap user flags and fix GlobalHandle / LocalHandle with heap pointers.
by Rémi Bernon (＠rbernon) 09 Nov '22

09 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53741 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1312

3 10

[PATCH 0/3] MR1313: Multi-arch support from Wine's build tree in dbghelp.
by eric pouech (＠epo) 09 Nov '22

09 Nov '22

Implement multi-arch support from Wine's build tree. (and code cleanup, helper introduction...) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1313

2 3

[PATCH 0/1] MR1271: user32: Use NtUserSetWindowLongPtr() in set_dialog_proc().
by Zhiyi Zhang (＠zhiyi) 09 Nov '22

09 Nov '22

Using NtUserSetWindowLong() truncates 64bit dialog procedure pointers to 32bit. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53631 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1271

4 3

[PATCH v4 0/22] MR1010: Draft: opengl32: Path towards wow64 support.
by Rémi Bernon (＠rbernon) 09 Nov '22

09 Nov '22

I was watching some random YouTube stream and then heard a voice telling me to do this. This can run wglgears on wow, though there's plenty of missing pieces which I don't have any idea how to fix (like buffer mapping, etc.). Opening it as a draft for now to show the whole thing, if it seems alright I'll send it in batches. -- v4: opengl32: Implement wow64 thunks for glMapBuffer (et al.). opengl32: Use manual win32 thunks for glMapBuffer (et al.). opengl32: Implement wow64 thunks for GLsizeiptr/GLintptr arrays. opengl32: Implement wow64 thunks for glFenceSync (et al.). opengl32: Implement wow64 thunks for input pointer arrays. opengl32: Implement wow64 thunk for wglGetPbufferDCARB. opengl32: Implement wow64 thunk for wglCreatePbufferARB. opengl32: Implement wow64 thunk for wglCreateContextAttribsARB. opengl32: Implement wow64 thunk for wglMakeCurrent (et al.). opengl32: Implement wow64 thunk for glGetString (et al.). opengl32: Implement wow64 thunk for wglGetProcAddress. opengl32: Generate stub wow64 params mapping. opengl32: Manually write glPathGlyphIndexRangeNV wow64 thunk. opengl32: Generate wow64 thunks. opengl32: Use RtlSetLastWin32Error instead of SetLastError. opengl32: Use msvcrt allocation functions. opengl32: Build with msvcrt. opengl32: Use ntdll registry functions to read disabled extensions. opengl32: Avoid recursively entering WGL critical section. opengl32: Split opengl_ext.h into private.h and unix_private.h. opengl32: Use glReserved1[0] and glReserved1[1] for draw and read DCs. opengl32: Avoid calling back the wglMakeCurrent win32 thunk. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/1010

1 1

[PATCH 0/5] MR1310: opengl32: Complete preparation for PE conversion.
by Rémi Bernon (＠rbernon) 09 Nov '22

09 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1310

2 5

[PATCH 0/1] MR1309: netprofm: Use CRT allocation functions.
by Hans Leidekker (＠hans) 09 Nov '22

09 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1309

2 1

[PATCH v2 0/1] MR1272: include: Define PROPSHEETPAGE[AW]_V[1-4].
by Alex Henrie (＠alexhenrie) 09 Nov '22

09 Nov '22

Needed to compile Tera Term. -- v2: include: Define PROPSHEETPAGE[AW]_V[1-4]. https://gitlab.winehq.org/wine/wine/-/merge_requests/1272

3 2

[PATCH 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Zhiyi Zhang (＠zhiyi) 09 Nov '22

09 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304

2 1

[PATCH 0/6] MR1303: winevulkan: Convert struct chain conversions for all structs that need it.
by Jacek Caban (＠jacek) 09 Nov '22

09 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1303

3 7

[PATCH v12 0/10] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 08 Nov '22

08 Nov '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. -- v12: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Route kernel callbacks through user32. winex11.drv: Pass a struct to x11drv_ime_set_result. winex11.drv: Pass a struct to x11drv_dnd_post_drop. winemac.drv: Route kernel callbacks through user32. wineandroid.drv: Route kernel callbacks through user32. opengl32: Do not store debug message callback in kernel callback table. winevulkan: Route kernel callbacks through user32. user32: Add NtUserDispatchCallback kernel callback. user.exe16: Move kernel callbacks to wow_callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 11

[PATCH 0/3] MR1302: wow64: Handle regions extending pass the address limit in NtQueryVirtualMemory.
by Tim Clem (＠tclem) 08 Nov '22

08 Nov '22

There are regions of virtual memory that start below the WoW user address limit but end beyond it (e.g. a large empty region between the end of 32-bit allocations and 64-bit ntdll). When queried from WoW via `NtQueryVirtualMemory(MemoryBasicInformation)`, the returned struct for such a region will have `BaseAddress + RegionSize` past the highest user address (or even worse - it may overflow 32 bits). These patches make WoW `NtQueryVirtualMemory` report a truncated size for such regions, so that they appear to end exactly at the highest user address. This fixes programs that, e.g., walk their address space using iterated calls to `VirtualQuery`. Also, make `MemoryRegionInformation` queries return `STATUS_INVALID_PARAMETER` when passed an address beyond the user address limit, like `MemoryBasicInformation` already does. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1302

2 3

Re: [PATCH v2 0/2] MR1300: ntdll: Fix Mac-specific warnings. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1300

1 0

Re: [PATCH v2 0/1] MR1299: ntdll: Fix runtime availability check for pthread_attr_set_qos_class_np. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1299

1 0

Re: [PATCH v3 0/3] MR1280: riched20: Don't send EN_CHANGE events during window creation - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1280

1 0

Re: [PATCH v3 0/5] MR1296: jscript/mshtml: Misc fixes and more info to the registry. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1296

1 0

Re: [PATCH v2 0/5] MR1048: winegstreamer: Allow wg_parser_stream_get_buffer to wait on all streams. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1048

1 0

Re: [PATCH v2 0/3] MR1288: vbscript: Fix a typo in Right() argument type check. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1288

1 0

Re: [PATCH v7 0/6] MR1001: winebuild: Reimplement dlltool for import lib and delay import lib generation. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1001

1 0

Re: [PATCH v2 0/1] MR1287: ws2_32/tests: Don't test protocol name in test_WSASocket(). - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1287

1 0

Re: [PATCH v5 0/8] MR1275: opengl32: Use the unixlib interface in more windows functions. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1275

1 0

Re: [PATCH v3 0/4] MR1286: secur32: Implement graceful secure connection shutdown. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1286

1 0

Re: [PATCH v7 0/3] MR574: mf: Improve session pause / restart handling. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/574

1 0

Re: [PATCH v2 0/1] MR1293: shell32: Improve timeout detection in shlexec tests. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1293

1 0

Re: [PATCH v2 0/1] MR1294: netprofm: Store a list manager pointer in the network object instead of... - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1294

1 0

Re: [PATCH v2 0/3] MR1292: uxtheme: Protect CloseThemeData() from invalid input. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1292

1 0

Re: [PATCH v4 0/5] MR1262: mf: Set output node media types in the media session. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1262

1 0

Re: [PATCH v2 0/1] MR1289: uuid: Add propkey.h. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1289

1 0

Re: [PATCH v2 0/1] MR1285: winealsa: Set name of internal threads. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1285

1 0

Re: [PATCH v2 0/1] MR1284: winepulse: Set name of internal threads. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1284

1 0

Re: [PATCH v2 0/1] MR1283: dsound: Set name of internal threads. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1283

1 0

Re: [PATCH v5 0/7] MR43: hlsl: Compute shaders. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/43

1 0

Re: [PATCH v3 0/6] MR45: Various dxbc/spirv refactoring. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/45

1 0

[PATCH 0/7] MR1301: Add ir50_32 video codec for winmm.
by Shaun Ren (＠shaunren) 08 Nov '22

08 Nov '22

This video codec is used by games such as Richman 4, and Zwei: The Arges Adventure. The decoder logic is based on code from the FFmpeg project. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1301

2 7

[PATCH v2 0/4] MR1297: Draft: gdiplus: Add GdipSetCustomLineCapBaseCap implementation.
by Bartosz Kosiorek (＠gang65) 08 Nov '22

08 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v2: gdiplus: Add support for widen path with GpCustomLineCap. gdiplus: Add GdipSetCustomLineCapBaseInset implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1297

3 5

[PATCH v11 0/10] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 08 Nov '22

08 Nov '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. -- v11: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Route kernel callbacks through user32. winex11.drv: Pass a struct to x11drv_ime_set_result. winex11.drv: Pass a struct to x11drv_dnd_post_drop. winemac.drv: Route kernel callbacks through user32. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 12

[PATCH 0/1] MR1299: ntdll: Fix runtime availability check for pthread_attr_set_qos_class_np.
by Brendan Shanks (＠bshanks) 08 Nov '22

08 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1299

3 2

[PATCH v2 0/3] MR1280: riched20: Don't send EN_CHANGE events during window creation
by Evan Tang (＠etang-cw) 08 Nov '22

08 Nov '22

Fixes an issue in GenoPro where existing data would be cleared whenever you went to edit it -- v2: riched20: Don't emit EN_CHANGE events during window creation riched20: Add test for EN_CHANGE events during window creation riched20: Move test class creation to a helper function https://gitlab.winehq.org/wine/wine/-/merge_requests/1280

4 5

[PATCH 0/2] MR1300: ntdll: Fix Mac-specific warnings.
by Brendan Shanks (＠bshanks) 08 Nov '22

08 Nov '22

Multiprocessing Services is very deprecated, it's hard to know if that call is still necessary or not but safer to keep it in (and suppress the warning). kIOMasterPortDefault was replaced with kIOMainPortDefault in Monterey but they're both equivalent to NULL/0 (using NULL triggers a warning though). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1300

2 2

[PATCH v2 0/5] MR1296: jscript/mshtml: Misc fixes and more info to the registry.
by Gabriel Ivăncescu (＠insn) 08 Nov '22

08 Nov '22

-- v2: mshtml: Add SVG and XHTML document information to the registry. include/mshtml: Add CLSID_XHTMLDocument and CLSID_SVGDocument. include/mshtml: Add IDOMParser interface, dispinterface, and coclass. jscript: Convert filetime to date properly using unsigned division. mshtml: Use nsIDOMDocument instead of nsIDOMHTMLDocument where possible. https://gitlab.winehq.org/wine/wine/-/merge_requests/1296

3 7

Re: [PATCH v2 0/1] MR1232: ntdll: Set the QoS class of the main Wine thread on macOS.
by Brendan Shanks (＠bshanks) 08 Nov '22

08 Nov '22

On Tue Nov 8 17:50:56 2022 +0000, Huw Davies wrote: > @bshanks this is producing a compiler warning here: > ``` > gcc -m32 -c -o dlls/ntdll/unix/loader.o dlls/ntdll/unix/loader.c > -Idlls/ntdll -Iinclude -D__WINESRC__ -DWINE_NO_LONG_TYPES \ > -D_NTSYSTEM_ -D_ACRTIMP= -DWINBASEAPI= -D_MSVCR_VER=0 > -DBINDIR=\"/usr/local/bin\" \ > -DSYSTEMDLLPATH=\"\" -DDLL_TO_BINDIR=\"`tools/makedep -R > /usr/local/lib/wine /usr/local/bin`\" \ > -DBIN_TO_DATADIR=\"`tools/makedep -R /usr/local/bin > /usr/local/share/wine`\" -DWINE_UNIX_LIB -Wall -pipe \ > -fno-stack-protector -fno-strict-aliasing > -Wdeclaration-after-statement -Wempty-body \ > -Wignored-qualifiers -Winit-self -Wno-pragma-pack -Wstrict-prototypes > -Wtype-limits -Wvla \ > -Wwrite-strings -Wpointer-arith -gdwarf-4 -fno-omit-frame-pointer > -fPIC \ > -fasynchronous-unwind-tables -O2 -g -Wno-deprecated-declarations > -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 > dlls/ntdll/unix/loader.c:2339:9: warning: address of function > 'pthread_attr_set_qos_class_np' will always evaluate to 'true' [-Wpointer-bool-conversion] > if (pthread_attr_set_qos_class_np) > ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > dlls/ntdll/unix/loader.c:2339:9: note: prefix with the address-of > operator to silence this warning > if (pthread_attr_set_qos_class_np) > ^ > & > 1 warning generated. > ``` > Why do we need the test? Ah I missed that, the check is needed to avoid crashing on 10.8 or 10.9 where `pthread_attr_set_qos_class_np` isn't present. I'll send a fix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1232#note_13742

1 0

[PATCH 0/5] MR1048: winegstreamer: Allow wg_parser_stream_get_buffer to wait on all streams.
by Rémi Bernon (＠rbernon) 08 Nov '22

08 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1048

5 25

[PATCH 0/5] MR1296: jscript/mshtml: Misc fixes and more info to the registry.
by Gabriel Ivăncescu (＠insn) 08 Nov '22

08 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1296

3 7

[PATCH 0/3] MR1288: vbscript: Fix a typo in Right() argument type check.
by Nikolay Sivov (＠nsivov) 08 Nov '22

08 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1288

3 4

[PATCH 0/4] MR1297: Draft: gdiplus: Add GdipSetCustomLineCapBaseCap implementation.
by Bartosz Kosiorek (＠gang65) 08 Nov '22

08 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297

2 7

Re: [PATCH v8 0/116] MR955: Release 7.0.1. - approved
by Alexandre Julliard (＠julliard) 08 Nov '22

08 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/955

1 0

[PATCH v6 0/6] MR1001: winebuild: Reimplement dlltool for import lib and delay import lib generation.
by Rémi Bernon (＠rbernon) 08 Nov '22

08 Nov '22

This is slightly different from dlltool but I think it should be compatible. The transition is done by first replacing dlltool with its bugs, and fixing them in separate changes. I based the ARM / AARCH64 implementation on the existing code around, but I have no idea if it is correct, and dlltool also doesn't include any delay load implementation for ARM. -- v6: winebuild: Put the delay import descriptor in data section. winebuild: Fix import hint value for symbols imported by name. winebuild: Implement delay import lib generation without dlltool. winebuild: Enable unwind tables by default in PE files. winebuild: Implement import lib generation without dlltool. winebuild: Introduce a new --without-dlltool winebuild flag. https://gitlab.winehq.org/wine/wine/-/merge_requests/1001

3 10

[PATCH v2 0/4] MR1286: secur32: Implement graceful secure connection shutdown.
by Paul Gofman (＠gofman) 08 Nov '22

08 Nov '22

... and fix output buffer allocation on the way. I am not aware of any app which strictly depends on the ApplyControlToken / connection shutdown to be implemented. Yet I saw a few games calling ApplyToken to perform the connection shutdown (similar to what is described in [1]). I once implemented that while debugging something and probably it makes some sense support secure connection shutdown once the app tries to do so (which as I understand is now recommended to do before closing socket). 1. https://learn.microsoft.com/en-us/windows/win32/secauthn/shutting-down-an-s… -- v2: secur32: Implement ApplyControlToken for SCHANNEL_SHUTDOWN. secur32: Add semi-stub for ApplyControlToken (schannel). secur32: Allocate buffer for either ISC_REQ_ALLOCATE_MEMORY or NULL output in schan_InitializeSecurityContextW(). secure32/tests: Add tests for ApplyControlToken (schannel). https://gitlab.winehq.org/wine/wine/-/merge_requests/1286

3 5

[PATCH v6 0/3] MR574: mf: Improve session pause / restart handling.
by Paul Gofman (＠gofman) 08 Nov '22

08 Nov '22

Patch 1. The tests on Windows show that when the timer callback is queued behind the clock time it is queued and executed quite soon with 0-15ms delay which corresponds to default timer granularity. The timeout tolerance in the test is quite bigger to avoid a flaky test. Wine currently may execute the callback right away or delay it indefinitely depending on the time difference and current system time. Patch 2. It turns out when the session is paused and then restarted and all the samples were delivered to sample grabber before restart, nothing is going to request the samples again when the session is restarted. I am attaching a test in a patch which hopefully confirms how that should work. I am not including that in the patches as the test involves delays (to make sure all the async events settle at certain points) and inherently flaky. Also, _ IMFStreamSink_GetEvent(stream, ...) in the test crashes on Win7 for some unknown reason. [0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch](/uploads/58c1738d48b3392e7ec430a0757210d0/0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch) -- v6: mf/samplegrabber: Handle samples receieved in paused state. mf/samplegrabber: Process samples in paused state in ignore_clock mode. mf: Handle timer time behind clock time in present_clock_schedule_timer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/574

4 6

[PATCH v3 0/5] MR1262: mf: Set source and output nodes media types in the media session.
by Bernhard Kölbl (＠besentv) 08 Nov '22

08 Nov '22

Supersedes: https://gitlab.winehq.org/wine/wine/-/merge_requests/789 This MR, with patches from Rémi should fix the no sound issue in media engine and also the black screen issue with MfPlayer.exe. -- v3: mf: Set media types for output nodes in the media session. mf: Assume same up and downstream media type for copier creation. mf/tests: Test for copier node in topology using evr. mf: Add some topology source node checks in IMFMediaSession_SetTopology. mf: Always enumerate branch source types for transform nodes. https://gitlab.winehq.org/wine/wine/-/merge_requests/1262

6 9

[PATCH 0/1] MR1294: netprofm: Store a list manager pointer in the network object instead of...
by Hans Leidekker (＠hans) 08 Nov '22

08 Nov '22

netprofm: Store a list manager pointer in the network object instead of creating a new list manager. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1294

2 1

[PATCH 0/1] MR1293: shell32: Improve timeout detection in shlexec tests.
by eric pouech (＠epo) 08 Nov '22

08 Nov '22

Some shlexec tests timeout on Windows10 (and generate errors as no action has been executed). Improve detection of timeout in child program (so that existing workaround in shell_execute_ex can be triggered). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1293

2 1

[PATCH 0/2] MR1166: ntdll: don't claim to have not found a library that is in place
by Konstantin Kharlamov (＠Hi-Angel) 08 Nov '22

08 Nov '22

When `import_dll` function gets `STATUS_DLL_NOT_FOUND` from `load_dll()`, it has no way of distinguishing whether it's a dependency for the dll wasn't found, or the dll itself is missing. That results in confusing ERR messages, where a dll is found, but wine claims it isn't. Fix this by moving the print to the actual place that is aware of whether it's the parent or the child dll haven't been found. Log before: 0024:err:module:import_dll Library lib2.dll (which is needed by L"Z:\\tmp\\lib1.dll") not found 0024:err:module:import_dll Library lib1.dll (which is needed by L"Z:\\tmp\\a.exe") not found Log after: 0024:err:module:load_dll Library L"lib2.dll" (which is needed by L"Z:\\tmp\\foo\\lib1.dll") not found 0024:err:module:import_dll Loading library lib2.dll (which is needed by L"Z:\\tmp\\foo\\lib1.dll") failed (error c0000135). 0024:err:module:import_dll Loading library lib1.dll (which is needed by L"Z:\\tmp\\foo\\a.exe") failed (error c0000135). -------- While it's just about prints, but it costed me hours of wandering *(because if I know where to find the dependency dll, but I see that the main dll is also "not found" despite being "right there", I have to research the latter problem that looks more complicated. But given enough resources applied, it then turns out to be a faux)*. As a fun fact, I am apparently not the only one to have stumbled upon. Here's a screenshot of a `#english` chat where I asked about a commit title correctness. It's the last place where you'd expect to find someone familiar with WINE, and yet here's a person that had to deal with that exact error as well: ![Screenshot_20221026_023411](/uploads/55552d7c335ef5ce0b507f61adacbb00/Screenshot_20221026_023411.png) So, I think it's kinda serious problem. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1166

4 13

[PATCH 0/3] MR1291: dwrite: fix get fontface frome cache is error.
by Jiajin Cui (＠jin-king1) 08 Nov '22

08 Nov '22

Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1291

4 9

Re: [PATCH v2 0/1] MR1232: ntdll: Set the QoS class of the main Wine thread on macOS.
by Huw Davies (＠huw) 08 Nov '22

08 Nov '22

@bshanks this is producing a compiler warning here: ``` gcc -m32 -c -o dlls/ntdll/unix/loader.o dlls/ntdll/unix/loader.c -Idlls/ntdll -Iinclude -D__WINESRC__ -DWINE_NO_LONG_TYPES \ -D_NTSYSTEM_ -D_ACRTIMP= -DWINBASEAPI= -D_MSVCR_VER=0 -DBINDIR=\"/usr/local/bin\" \ -DSYSTEMDLLPATH=\"\" -DDLL_TO_BINDIR=\"`tools/makedep -R /usr/local/lib/wine /usr/local/bin`\" \ -DBIN_TO_DATADIR=\"`tools/makedep -R /usr/local/bin /usr/local/share/wine`\" -DWINE_UNIX_LIB -Wall -pipe \ -fno-stack-protector -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body \ -Wignored-qualifiers -Winit-self -Wno-pragma-pack -Wstrict-prototypes -Wtype-limits -Wvla \ -Wwrite-strings -Wpointer-arith -gdwarf-4 -fno-omit-frame-pointer -fPIC \ -fasynchronous-unwind-tables -O2 -g -Wno-deprecated-declarations -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 dlls/ntdll/unix/loader.c:2339:9: warning: address of function 'pthread_attr_set_qos_class_np' will always evaluate to 'true' [-Wpointer-bool-conversion] if (pthread_attr_set_qos_class_np) ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ dlls/ntdll/unix/loader.c:2339:9: note: prefix with the address-of operator to silence this warning if (pthread_attr_set_qos_class_np) ^ & 1 warning generated. ``` Why do we need the test? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1232#note_13594

1 0

[PATCH 0/1] MR1289: uuid: Add propkey.h.
by Alex Henrie (＠alexhenrie) 08 Nov '22

08 Nov '22

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1289

4 3

Re: [PATCH v4 0/8] MR1275: opengl32: Use the unixlib interface in more windows functions.
by Rémi Bernon (＠rbernon) 08 Nov '22

08 Nov '22

Rebased and added a change for the macOS build that should solve the build failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1275#note_13590

1 0

[PATCH 0/1] MR1285: winealsa: Set name of internal threads.
by Brendan Shanks (＠bshanks) 08 Nov '22

08 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1285

3 2

[PATCH 0/1] MR1284: winepulse: Set name of internal threads.
by Brendan Shanks (＠bshanks) 08 Nov '22

08 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1284

3 2

[PATCH 0/1] MR1283: dsound: Set name of internal threads.
by Brendan Shanks (＠bshanks) 08 Nov '22

08 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1283

3 2

[PATCH 0/3] MR1280: riched20: Don't send EN_CHANGE events during window creation
by Evan Tang (＠etang-cw) 08 Nov '22

08 Nov '22

Fixes an issue in GenoPro where existing data would be cleared whenever you went to edit it -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1280

4 7

[PATCH 0/3] MR1292: uxtheme: Protect CloseThemeData() from invalid input.
by Zhiyi Zhang (＠zhiyi) 08 Nov '22

08 Nov '22

The first patch is from Dmitry. I asked him before sending it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1292

3 4

[PATCH 0/1] MR1255: gitlab: Run win64 tests instead of wow64.
by Rémi Bernon (＠rbernon) 08 Nov '22

08 Nov '22

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1241. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1255

4 4

[PATCH 0/1] MR1207: comctl32/edit: Prevent a use after free
by Mark Jansen (＠learn-more) 08 Nov '22

08 Nov '22

This was observed in ReactOS, when 'Debug Page Heap'[^1] was enabled: - Start renaming a file in a shell view - Cancel the renaming [^1]: DPH is modeled after 'Windows Page Heap Verification' -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1207

3 8

[PATCH v10 0/10] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 08 Nov '22

08 Nov '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. -- v10: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Route kernel callbacks through user32. winex11.drv: Pass a struct to x11drv_ime_set_result. winex11.drv: Pass a struct to x11drv_dnd_post_drop. winemac.drv: Route kernel callbacks through user32. wineandroid.drv: Route kernel callbacks through user32. opengl32: Do not store debug message callback in kernel callback table. winevulkan: Route kernel callbacks through user32. user32: Add NtUserDispatchCallback kernel callback. user.exe16: Move kernel callbacks to wow_callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 11

[PATCH v4 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) 08 Nov '22

08 Nov '22

The function is implemented by setting cache file pointer to fill read_buf. Consequently, when HTTPREQ_ReadFile is called, it will try reading data from cache after read_buf is depleted, before continuing reading from http stream. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=26570 -- v4: wininet: Partially implement InternetSetFilePointer wininet/tests: Add InternetSetFilePointer tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1268

3 3

[PATCH 0/4] MR1286: secur32: Implement graceful secure connection shutdown.
by Paul Gofman (＠gofman) 08 Nov '22

08 Nov '22

... and fix output buffer allocation on the way. I am not aware of any app which strictly depends on the ApplyControlToken / connection shutdown to be implemented. Yet I saw a few games calling ApplyToken to perform the connection shutdown (similar to what is described in [1]). I once implemented that while debugging something and probably it makes some sense support secure connection shutdown once the app tries to do so (which as I understand is now recommended to do before closing socket). 1. https://learn.microsoft.com/en-us/windows/win32/secauthn/shutting-down-an-s… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1286

3 5

[PATCH 0/1] MR1287: ws2_32/tests: Don't test protocol name in test_WSASocket().
by Paul Gofman (＠gofman) 08 Nov '22

08 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53893 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1287

3 2

[PATCH v2 0/11] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon (＠rbernon) 07 Nov '22

07 Nov '22

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v2: ntdll: Fix call_user_mode_callback cfi. ntdll: Tweak KeUserModeCallback to please Valgrind and GDB. ntdll: Introduce a new ntdll_dispatch_syscall helper. tools: Add suppressions from third party libraries. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. ntdll: Allocate a truly separate stack for the kernel stack. winebuild: Enable unwind tables by default in PE files. ntdll: Maintain a PE module link map and expose it to GDB. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

3 13

[PATCH 0/1] MR1282: ntoskrnl.exe: Implement ExInterlockedInsertTailList.
by Etaash Mathamsetty (＠etaash.mathamsetty) 07 Nov '22

07 Nov '22

I'm not exactly sure what is calling this function, but it's probably that anti virus I installed to test the KeInitializeGuardedMutex implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1282

2 1

[PATCH 0/1] MR1244: Draft: ntdll/tests: Test syscall SSE register save / restore strategy.
by Rémi Bernon (＠rbernon) 07 Nov '22

07 Nov '22

Showing that only non-volatile registers are reliably saved. Volatile registers are only saved by NtGetContextThread whenever it interrupts a thread in user space, and are otherwise returned from some previous, possibly outdated, state. @jacek Unless I'm missing something, I think this shows that we do not have to save the full context in syscalls in general, and instead only the non-volatile XMM registers? NtGetContextThread syscall still probably needs to save the full context and it should probably be using a specific code path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1244

5 8

Re: [PATCH v2 0/6] MR1158: winegstreamer: Add a skeleton MPEG layer-3 decoder filter. - approved
by Alexandre Julliard (＠julliard) 07 Nov '22

07 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1158

1 0

Re: [PATCH v2 0/1] MR1276: certutil: Add stub program. - approved
by Alexandre Julliard (＠julliard) 07 Nov '22

07 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1276

1 0

2025

2024

2023

2022

wine-gitlab