- wine-gitlab - winehq.org

[PATCH v2 0/6] MR7436: d3dx9: More changes to D3DXSaveSurfaceToFileInMemory().
by Connor McAdams (＠cmcadams) 04 Mar '25

04 Mar '25

This patch series reworks `D3DXSaveSurfaceToFileInMemory()` to use the new `d3dx_save_pixels_to_memory()` function. It also adds support for selecting a replacement pixel format when the image file format being saved to doesn't have direct support for the pixel format being saved. The code for calculating the best replacement format was inspired by the code in `check_texture_requirements()` in `d3dx9_36/texture.c`. This should fix WineHQ bug 51584, but I haven't tested that. -- v2: d3dx9: Add support for saving DIB files in d3dx_save_pixels_to_memory(). d3dx9: Add support for saving paletted pixel formats in d3dx_pixels_save_wic(). d3dx9: Add support for saving BMP files in d3dx_save_pixels_to_memory(). d3dx9: Add support for saving JPG files in d3dx_save_pixels_to_memory(). d3dx9: Add support for saving PNG files in d3dx_save_pixels_to_memory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7436

3 8

[PATCH 0/1] MR7475: winewayland: Ignore relative motion while pointer lock is deactivated.
by Attila Fidan (＠atticf) 04 Mar '25

04 Mar '25

If the lock is deactivated, mouselook won't work properly, and the user probably doesn't want mouselook to be active. For example: * if the user is making their compositor inhibit constraints to temporarily prevent applications from disrupting pointer movement. * if the keyboard is unfocused on the window, the lock is almost certainly deactivated. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56681 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7475

3 3

[PATCH 0/5] MR7483: wineps: Cleanups for the new core font metrics generation code.
by Alexandre Julliard (＠julliard) 04 Mar '25

04 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7483

4 7

[PATCH 0/1] MR7490: shell32: mark FOLDERID_UserProgramFiles as CSIDL_Type_User
by Tingzhong Luo (＠tzluo) 04 Mar '25

04 Mar '25

Fix the issue where some installers refuse to launch, due to `SHGetKnownFolderPath()` failing when called with `FOLDERID_UserProgramFiles`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7490

2 1

[PATCH 0/1] MR7489: netapi32: add stub level1 query of NetLocalGroupGetMembers
by Tingzhong Luo (＠tzluo) 04 Mar '25

04 Mar '25

Fix the installer refuses to launch due to query admin group failed via `NetLocalGroupGetMembers()` failed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7489

2 1

[PATCH 0/1] MR7488: include: Use wchar_t for platform types on PE targets.
by Jacek Caban (＠jacek) 04 Mar '25

04 Mar '25

`WINE_UNICODE_NATIVE` handles non-PE targets where appropriate, but on PE targets, we should always use `wchar_t`. This is particularly important for C++, where `wchar_t` is a distinct built-in type. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7488

2 1

Re: [PATCH v2 0/4] MR7468: win32u: Move opengl code to a dedicated source. - approved
by Huw Davies (＠huw) 04 Mar '25

04 Mar '25

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7468

1 0

Re: [PATCH v4 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7.
by Rémi Bernon (＠rbernon) 04 Mar '25

04 Mar '25

On Tue Mar 4 12:15:46 2025 +0000, Bernhard Übelacker wrote: > Sorry, this was not my intention. This line should make sure > `check_PropVariantToBSTR2` is never called with anything else than > `VT_R4`, but I have not considered this to be inside a `todo_wine` altogether. > I created !7487 to fix this. No worries, thanks for the fix :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7460#note_96759

1 0

Re: [PATCH v4 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7.
by Bernhard Übelacker (＠bernhardu) 04 Mar '25

04 Mar '25

On Tue Mar 4 12:15:46 2025 +0000, Rémi Bernon wrote: > This now causes a "Test succeeded inside todo block" test failure on linux. Sorry, this was not my intention. This line should make sure `check_PropVariantToBSTR2` is never called with anything else than `VT_R4`, but I have not considered this to be inside a `todo_wine` altogether. I created !7487 to fix this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7460#note_96755

1 0

[PATCH 0/1] MR7487: propsys/tests: Fix check_PropVariantToBSTR2.
by Bernhard Übelacker (＠bernhardu) 04 Mar '25

04 Mar '25

Cannot use always succeeding ok statement, because check_PropVariantToBSTR2 is used inside a todo_wine block. Followup to a1637b167f. This was intended to make sure check_PropVariantToBSTR2 is just called with `VT_R4`, but makes now more problems than good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7487

2 1

Re: [PATCH v7 0/8] MR7152: dxgi: Fix the frame latency waitable implementation.
by Giovanni Mascellani (＠giomasce) 04 Mar '25

04 Mar '25

On Tue Mar 4 11:59:46 2025 +0000, Rémi Bernon wrote: > Fwiw this broke the tests on windows, the pipeline was failing already here. Sorry, I didn't notice that. https://gitlab.winehq.org/wine/wine/-/merge_requests/7486 should fix it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7152#note_96749

1 0

[PATCH 0/3] MR7416: wined3d: Interpret Y'CbCr values as being from the reduced range.
by Elizabeth Figura (＠zfigura) 04 Mar '25

04 Mar '25

This is an adjustment of 7324. d3d9:visual already has a test that's relatively close to what a simplified version of the tests in 7324 looked like, so I made the few changes to expand that test to match and then ported it to ddraw. Implementation-wise, this removes the SD/HD difference (which only exists on NVidia and is not necessary to improve the mentioned application). It also removes the clamping of YUV values, which as the tests show is not correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7416

6 8

[PATCH v10 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Yuxuan Shui (＠yshui) 04 Mar '25

04 Mar '25

## Context This is a problem discovered when running "Max: The Curse of Brotherhood" under proton. This game writes 4MB a piece into `wg_transform`, which contains about 4 seconds of compressed video. `wg_transform` calls `gst_pad_push` in `transform_ProcessOutput`, which takes \~300ms (i.e. 20 frames @ 60fps) to decode this buffer of video. So the end result is the game hitches every 4 seconds while playing cut scene videos. Proton currently has a special case for this particular game, for which it breaks up the buffer into small chunks to avoid long blocks. This MR adopts that and applies it generally. One concern raised by @redmcg is: > The only issue I can think of is if there are any decoders which don't have a parser; then they might not know how to deal with an arbitrary 4096 byte buffer (the parser is generally responsible for taking arbitrary buffers and producing something the decoder can work with, for example: a full frame). So this MR only enables this strategy when there is a parser element. -- v10: winegstreamer: Avoid large buffer pushes in wg_transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/7288

3 3

[PATCH 0/1] MR7478: user32: Use the correct DPI in AdjustWindowRect(Ex) when DPI virtualization is active.
by Brendan Shanks (＠bshanks) 04 Mar '25

04 Mar '25

`AdjustWindowRect(Ex)` were using the system DPI even in non-DPI-aware applications, leading to some bizarre behavior. An easy test for this is to remove the DPI awareness from `winemine`'s manifest, set the system DPI to 192, then run `winemine` and click the smiley face. Every click on the smiley face will move the window up by ~30 pixels. A copy of ioquake3 with DPI awareness removed would also constantly enlarge its window vertically. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7478

3 2

[PATCH 0/1] MR7485: advapi32: Add CreateProcessWithLogonW() semi-stub.
by Dmitry Timoshkov (＠dmitry) 04 Mar '25

04 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7485

2 1

[PATCH 0/2] MR7484: wbemprox: Fix format string.
by Hans Leidekker (＠hans) 04 Mar '25

04 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7484

2 2

[PATCH 0/3] MR7482: Include defines
by Alistair Leslie-Hughes (＠alesliehughes) 04 Mar '25

04 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7482

3 4

[PATCH v6 0/1] MR7353: winewayland: Implement SetCursorPos via pointer lock.
by Attila Fidan (＠atticf) 04 Mar '25

04 Mar '25

There is no ([not yet?](https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requ…) dedicated protocol for requesting pointer warps, but it's possible to request one with `zwp_locked_pointer_v1.set_cursor_position_hint` which may be performed when the pointer is unlocked. The idea is to quickly lock/set position/unlock. This is used by SDL (in some cases: [SDL_MOUSE_EMULATE_WARP_WITH_RELATIVE](https://wiki.libsdl.org/SDL3/SDL_HINT…) and Xwayland. The limitation is/will be that the compositor will ignore requests to warp the pointer outside of surface bounds. What I'd like to have working is the auto cursor placement feature of some applications, where they just want to call SetCursorPos towards specific UI elements inside their single window, and usually they'll be unclipped and have a visible cursor while doing this. This patch also happens to allow mouselook to work in applications which use SetCursorPos for mouselook and aren't getting covered by the heuristics that turn on Wayland relative motion (for some reason the driver thinks the cursor is visible). Seems to affect Half-Life (GoldSrc) on my system. Though force enabling relative motion with an environment variable in a custom build or somehow improving the heuristics will also fix that. ~~A suface/pointer can only have one lock or confinement, and this implementation depends on the pointer lock. So if needed, I temporarily unlock/unconfine in order to do the warp then relock/reconfine. I modified `wayland_pointer_update_constraint` so I don't have to temporarily disable relative motion during this in case it's enabled. I think it's safe/a no-op to attempt pointer warps while using relative motion, as according to the protocol the warp will not generate a relative motion event, and while there will be a wl_pointer motion event, they're ignored while relative motion is being used.~~ -- v6: winewayland: Implement SetCursorPos via pointer lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/7353

3 4

[PATCH v5 0/7] MR7111: Draft: support building Wine with LTO
by Konstantin Demin (＠rockdrilla) 04 Mar '25

04 Mar '25

work is still in progress. todo: - ensure that all affected sources (i.e. C sources with any kind of assembly) are listed in either way for all architectures - test Wine built with LTO relevant bug reports: - https://bugs.winehq.org/show_bug.cgi?id=41712 - https://bugs.winehq.org/show_bug.cgi?id=51051 -- v5: LTO quirks makedep: support skipping/disabling LTO configure: enable building Wine with LTO makedep: support LTO builds winegcc: support LTO builds winebuild: support LTO builds tools: helper functions for LTO builds https://gitlab.winehq.org/wine/wine/-/merge_requests/7111

4 14

Re: [PATCH v2 0/4] MR7408: setupapi: Implement basic disk space list functions.
by Rémi Bernon (＠rbernon) 04 Mar '25

04 Mar '25

Fwiw the test fails with "diskspace.c:671: Test succeeded inside todo block: got len 1" on win64, and crashes on win32 (non-WOW) prefixes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7408#note_96728

1 0

Re: [PATCH v4 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7.
by Rémi Bernon (＠rbernon) 04 Mar '25

04 Mar '25

This now causes a "Test succeeded inside todo block" test failure on linux. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7460#note_96727

1 0

[PATCH v2 0/2] MR7465: winegstreamer: Validate the value of cbSize in aac decoder.
by Brendan McGrath (＠redmcg) 04 Mar '25

04 Mar '25

This MR fixes a mf:transform test that started failing as a result of MR !7417. It also adds new tests to mf:transform to test different values of `MF_MT_USER_DATA` against the aac decoder. It adds validation of `cbSize` to the aac decoder, which, in addition to fixing the previous test, allows some of these new tests to pass. But it does not validate the content of the user data (as the new tests seem to indicate Windows does). -- v2: winegstreamer: Validate the value of cbSize in aac decoder. mf/tests: Test different length user_data against aac decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/7465

3 4

[PATCH 0/3] MR7481: gdiplus headers changes
by Alistair Leslie-Hughes (＠alesliehughes) 04 Mar '25

04 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7481

2 3

[PATCH v4 0/6] MR7233: wineswmidi: Add SW Synth MIDI driver part 0.
by Anton Baskanov (＠baskanov) 04 Mar '25

04 Mar '25

-- v4: wineswmidi: Initialize DirectMusic when opening the device. https://gitlab.winehq.org/wine/wine/-/merge_requests/7233

2 8

[PATCH 0/5] MR7480: wined3d: Vulkan H.264 decode, part 1/3.
by Elizabeth Figura (＠zfigura) 04 Mar '25

04 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7480

2 5

[PATCH 0/1] MR7479: wow64win: fix the access exception when the lparam is an address larger than 2G.
by Jiajin Cui (＠jin-king1) 04 Mar '25

04 Mar '25

Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7479

2 1

[PATCH v4 0/8] MR7432: mp3dmod: Add future support for Float encoding and fix various discrepancies with Windows
by Brendan McGrath (＠redmcg) 04 Mar '25

04 Mar '25

This MR adds the ability to support float encoding (which will be used by the IMFTransform interface). It also adds tests and addresses a number of small discrepancies discovered between the Wine and native implementation. -- v4: mp3dmod: Ensure nChannels is greater than zero on input. mp3dmod/tests: Add test for nChannels = 0 on input. mp3dmod: Only allow 1/2 and 1/4 subsampling. mp3dmod: Return error if requested output format values don't agree. mp3dmod/tests: Test different output sample rates. mp3dmod: Add support for 32-bit sample size. mp3dmod/tests: Add test for 32-bit sample size. mp3dmod: Return S_OK in Allocate/Free Resources. https://gitlab.winehq.org/wine/wine/-/merge_requests/7432

3 10

[PATCH 0/1] MR3131: gdiplus: Fix gif shows misplaced.
by Jiajin Cui (＠jin-king1) 04 Mar '25

04 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54271 Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3131

3 6

[PATCH v32 0/1] MR7400: cmd: Allow any key to continue past DIR /P pauses.
by Joe Souza (＠JoeS209) 04 Mar '25

04 Mar '25

Current code requires entering a newline character in order to continue past DIR /P prompts. This change allows any key to be pressed instead. Code to handle this was similar to existing WCMD_pause() so we leveraged that code for this purpose as well. Key to the fix was the removal of ENABLE_LINE_INPUT from the console flags, and ENABLE_PROCESSED_INPUT was added in order to preserve the ability to abort the operation via Ctrl-C. -- v32: cmd: Allow any key to continue past DIR /P pauses. https://gitlab.winehq.org/wine/wine/-/merge_requests/7400

2 2

[PATCH v3 0/7] MR7432: mp3dmod: Add future support for Float encoding and fix various discrepancies with Windows
by Brendan McGrath (＠redmcg) 04 Mar '25

04 Mar '25

This MR adds the ability to support float encoding (which will be used by the IMFTransform interface). It also adds tests and addresses a number of small discrepancies discovered between the Wine and native implementation. -- v3: mp3dmod: Ensure nChannels is greater than zero on input. mp3dmod/tests: Add test for nChannels = 0 on input. https://gitlab.winehq.org/wine/wine/-/merge_requests/7432

3 9

[PATCH 0/1] MR7281: include: Prefer builtin atomics on x86 unless known broken.
by William Horvath (＠whrvt) 04 Mar '25

04 Mar '25

Clang presents as GCC 4.2.1, so it was always using the fallbacks for `InterlockedExchange{,Pointer}` on the non-PE side. The fix for the GCC `__atomic_*` bug linked in the comment for the `__WINE_ATOMIC_*` macros first appeared in GCC 8: https://github.com/gcc-mirror/gcc/commit/d8c40eff56f69877b33c697ded756d50fd… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7281

3 6

[PATCH v3 0/2] MR7119: ntdll, loader: Add __attribute__((used)) to a few symbols that shouldn't be discarded.
by William Horvath (＠whrvth) 04 Mar '25

04 Mar '25

These changes are enough to allow building the entirety of the native (ELF) side with `-flto`. -- v3: loader: Mark thread_ldt, thread_data, wld_start "used". ntdll: Mark call_init_thunk and abort_thread "used". https://gitlab.winehq.org/wine/wine/-/merge_requests/7119

4 5

Re: [PATCH v26 0/1] MR6884: Iphlpapi.dll: Included SendARP
by Thi Garlet (＠garlett) 03 Mar '25

03 Mar '25

On Mon Mar 3 23:25:58 2025 +0000, Huw Davies wrote: > It would be better to implement `SendARP()` in terms of `ResolveIpNetEntry2()`. > Further, `ResolveIpNetEntry2()` should likely use the `Nsi` functions to > retrieve the neighbour info from `nsiproxy`. I think I saw ResolveIpNetEntry2() function documentation in the past. Maybe because I could not find sources(help please), end up not using it. Or I asked somebody. Not sure. Does ResolveIpNetEntry2() need linux privileges ? Thanks -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6884#note_96714

1 0

[PATCH 0/1] MR7461: remove "Broken NVIDIA RandR detected" error line
by Andrey Zhukov (＠HP) 03 Mar '25

03 Mar '25

I am proposing to do something about the "Broken NVIDIA RandR detected" error line, i think that this error serves no good purpose. Motivation: * fallback Firstly, if wine merely switches to a fallback in case of a problem - that's not an error, that's an expected and handled issue that is successfully worked around. If there are potential issues with the workaround - that's what should be noted. Programs run with wine do work well (enough) when this "error" is present. I do understand that you can change certain settings to change the codepath so that this error to not appear, is this actually necessary to fix an actual problem? Sending someone on a path to fix this "error" when the program they're running is working perfectly well is not a great thing. * calling it an error More commonly, wine output is ignored when everything is running correctly, and only looked at when problems arise, so if you log an "error" around the time that a different issue happens it is reasonable to assume that the user will treat the error as the cause of the problem. So we end up with lots of threads like this: https://forum.winehq.org/viewtopic.php?t=32583 quote: "Please don't title a forum thread with:Broken NVIDIA RandR detected, falling back to RandR 1.0. **This is totally meaningless and does not provide any description - what-so-ever - of what the thread is about. ** Wine outputs this terminal message, for anyone using the Nvidia proprietary driver. Whether they have a crappy, ancient video card or a shiny new Geforce RTX 2080 Ti ! **I patch out this warning message, on my Gentoo wine ebuild's, because it is so annoying.** * error spam So it confuses inexperienced users very much. I shouldn't have to point out the search engine keyword irrelevancy. But even for experienced users (the quoted user uses gentoo), it is annoying enough to patch out. If the quoted example wasn't enough here's a random pastebin from 2022 i found removing the line: https://pastebin.com/6auSsL4B, and i've got at least one personal example of someone patching the error out. It is repeated just too frequently. Spam makes reading more important errors harder too. * recommending nouveau This line is in a codepath commonly used in games. Recommending nouveau to usually inexperienced linux users - gamers is a horrible idea. Don't get me wrong, i'm all for a free solution, i'd love for nouveau to be just as good, but it is simply not. For a user without a reasonable understanding of linux a messup with video drivers costs a complete reinstall. Mindshare of free software is probably out of scope for wine, but i'm sure we can agree there's some general value there. There is a wiki entry about this error: https://gitlab.winehq.org/wine/wine/-/wikis/FAQ#broken-nvidia-randr-detecte… It all generally makes sense, and if you read it carefully it does say "for users who do not need the proprietary driver", but for an inexperienced user that's an encouragement that assumes they do not in fact need the proprietary driver. Also if you do understand what RandR is you're likely to understand that a program not launching for example probably isn't related to the "error", though i think even a knowing user would still consider it a possibility. * keywords used The workaround described under that is of legitemate value, but i think the correlation between the "error" keywords and the actual problematic behavior is not great. If we wish to point the user towards the workaround the line should be something along the lines of "program starts fullscreen at low resolution". * code I am not a maintainer and am not experienced enough to just pick up a codebase like this, so i'll start off with admitting i don't really know the specifics of the code. But just by looking at it, the comment on line 511 in dlls/winex11.drv/xrandr.c says that the check that causes the "error" line to print just checks if the driver is nvidia? Isn't that not even checking the specific behavior that it supposedly doesn't implement? (if it was fixed since that code was written) Proposed solutions: Plain and simple - delete the line. This would solve all the problems mentioned above, perhaps with the exception of >keywords used. This pull request. Change the message type to debug or trace or similar. This would address >calling it an error Only print error on first use of function or in startup. This would address >error spam -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7461

4 5

[PATCH 0/6] MR7436: d3dx9: More changes to D3DXSaveSurfaceToFileInMemory().
by Connor McAdams (＠cmcadams) 03 Mar '25

03 Mar '25

This patch series reworks `D3DXSaveSurfaceToFileInMemory()` to use the new `d3dx_save_pixels_to_memory()` function. It also adds support for selecting a replacement pixel format when the image file format being saved to doesn't have direct support for the pixel format being saved. The code for calculating the best replacement format was inspired by the code in `check_texture_requirements()` in `d3dx9_36/texture.c`. This should fix WineHQ bug 51584, but I haven't tested that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7436

3 11

[PATCH v4 0/10] MR7407: windowscodecs: Implement query strings enumerator.
by Nikolay Sivov (＠nsivov) 03 Mar '25

03 Mar '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: windowscodecs: Implement GetPreferredVendorGUID(). windowscodecs/metadata: Implement GetClassID(). windowscodecs/tests: Add some tests for metadata handler GetClassID(). windowscodecs/metadata: Replicate original stream position when creating writer instances from readers. windowscodecs/metadata: Restore original stream position on GetStream(). windowscodecs/tests: Add some tests for stream position handling when nested readers are used. windowscodecs: Implement CreateQueryWriterFromReader(). windowscodecs/metadata: Do not decorate 'wstr' items with a type name in returned queries. windowscodecs/tests: Add some more tests for query enumeration. windowscodecs: Implement query strings enumerator. https://gitlab.winehq.org/wine/wine/-/merge_requests/7407

3 14

[PATCH v29 0/1] MR7400: cmd: Allow any key to continue past DIR /P pauses.
by Joe Souza (＠JoeS209) 03 Mar '25

03 Mar '25

Current code requires entering a newline character in order to continue past DIR /P prompts. This change allows any key to be pressed instead. Code to handle this was similar to existing WCMD_pause() so we leveraged that code for this purpose as well. Key to the fix was the removal of ENABLE_LINE_INPUT from the console flags, and ENABLE_PROCESSED_INPUT was added in order to preserve the ability to abort the operation via Ctrl-C. -- v29: cmd: Allow any key to continue past DIR /P pauses. https://gitlab.winehq.org/wine/wine/-/merge_requests/7400

2 1

Re: [PATCH v2 0/1] MR7477: include: Add some flags constants used in pipes API. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7477

1 0

Re: [PATCH v2 0/1] MR7476: ws2_32/tests: Allow WSAConnectByNameA test to fail with WSAEOPNOTSUPP. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7476

1 0

Re: [PATCH v3 0/1] MR7473: winetest: Avoid underflow when computing filtered output size. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7473

1 0

Re: [PATCH v3 0/1] MR7438: wbemprox: Add Manufacturer and Speed to Win32_PhysicalMemory. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7438

1 0

Re: [PATCH v4 0/1] MR7471: d2d1/tests: Adjust tolerance of a few float comparisons in windows 7. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7471

1 0

Re: [PATCH v2 0/5] MR7470: include: Add more declarations needed for LLVM libc++ - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7470

1 0

Re: [PATCH v3 0/1] MR7469: winegcc: Don't include host include paths when compiling with MSVCRT. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7469

1 0

Re: [PATCH v4 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459

1 0

Re: [PATCH v4 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7460

1 0

Re: [PATCH v2 0/1] MR7467: kernel32/tests: Work around Windows 7 issuing DllNotification even when loading with DONT_RESOLVE_DLL_REFERENCES - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7467

1 0

Re: [PATCH v2 0/4] MR7408: setupapi: Implement basic disk space list functions. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7408

1 0

Re: [PATCH v6 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

1 0

Re: [PATCH v2 0/1] MR7464: cryptnet: Uniform return value that is the same as _wfsopen. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7464

1 0

Re: [PATCH v2 0/1] MR7452: kernel32/tests: Fix thread handle leak in store_buffer_litmus_test - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7452

1 0

Re: [PATCH v2 0/4] MR7448: Use _NSGetExecutablePath to get the binary path on macOS - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7448

1 0

Re: [PATCH v2 0/3] MR7450: wbemprox: Get Win32_VideoController values from the registry. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7450

1 0

Re: [PATCH v2 0/3] MR7394: Remove pre-macOS 10.12 workarounds - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7394

1 0

Re: [PATCH v2 0/1] MR7444: make_unicode: Generate the PostScript builtin font metrics. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7444

1 0

Re: [PATCH v2 0/1] MR7454: msvcr120: Simplify feupdateenv implementation. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7454

1 0

Re: [PATCH v8 0/1] MR7369: include/security.h: Add definition of NEGOSSP_NAME - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7369

1 0

Re: [PATCH v4 0/2] MR7443: d2d1/tests: Add some tests for device context handling in the DC target. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7443

1 0

Re: [PATCH v3 0/1] MR7458: kernelbase/tests: Skip test if EnumSystemFirmwareTables is not available. - approved
by Alexandre Julliard (＠julliard) 03 Mar '25

03 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7458

1 0

[PATCH 0/2] MR7465: winegstreamer: Validate the value of cbSize in aac decoder.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

This MR fixes a mf:transform test that started failing as a result of MR !7417. It also adds new tests to mf:transform to test different values of `MF_MT_USER_DATA` against the aac decoder. It adds validation of `cbSize` to the aac decoder, which, in addition to fixing the previous test, allows some of these new tests to pass. But it does not validate the content of the user data (as the new tests seem to indicate Windows does). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7465

4 7

[PATCH v6 0/7] MR7422: winebus/dinput: Support arbitrary number of axes in the virtual PID descriptor
by Tomasz Pakuła (＠TomaszPakula) 03 Mar '25

03 Mar '25

Related Wine issue: https://bugs.winehq.org/show_bug.cgi?id=52714 I'm starting work on updating/extending Linux force feedback API and one of my goals is to expose the number and an array that contains the device's ffb-enabled axes. As I'm mainly working with USB PID driver, I already have a POC of obtaining this data. What prompted this is that currently Wine always creates virtual joysticks with two PID ffb axes. This causes issues with [Richard Burns Rally](https://github.com/ValveSoftware/Proton/issues/6702#issuecomment-267…, as this game incorrectly initializes a `CONSTANT_FORCE` effect with all the FFB axes that contain `DIDOI_FFACTUATOR` flag and then trying to update `cAxes` and `rgdwAxes` values which leads to `DIERR_INVALIDPARAM`. Now, this flag is set by wine while enumerating virtual device's axes and while `(axis index < FFB axes)`, flag is applied. This means, that every device which has FFB functionality and at least two axes, will report FFB on `X`, `Y`. While updated API would mean a lot of steering wheels would correctly report only 1 axis, a lot of USB PID wheels still include `X` and `Y` in their `AXES_ENABLE` and `DIRECTION` usages. This, again, would lead to broken FFB (in affected games). On Windows, there's a possibility of overwriting some joystick capabilities with registry entries, which ends up removing `DIDOI_FFACTUATOR` flag from a selected axis. This doesn't work in Wine. This MR allows Wine to add an arbitrary number (up to `PID_AXES_MAX`) of axes to the PID descriptor, based on the value of Haptic Axes from SDL or from Linux FF api in the future (I'm working on it). Additionally, to work around RBR and other games with similar, wrong FFB handling, I introduced a [hint](https://github.com/libsdl-org/SDL/issues/12341) to SDL that allows a dynamic overwrite of the number of haptic axes. For the Linux API, I'll figure out a nice way to override when the number of axes will be exposed. With these changes, I was able to successfully get force feedback on my Moza Racing R9 with all axes usable. With additional traces in the dinput code, I confirmed that with one axis defined in the PID descriptor, the game created a constant force effect with just one axis and `cAxes = 1`. -- v6: https://gitlab.winehq.org/wine/wine/-/merge_requests/7422

3 10

[PATCH v2 0/1] MR7438: Draft: wbemprox: Add and adjust some Win32_PhysicalMemory properties
by Tim Clem (＠tclem) 03 Mar '25

03 Mar '25

Needed for Infinity Nikki. -- v2: wbemprox: Add Manufacturer and Speed to Win32_PhysicalMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/7438

3 3

[PATCH v3 0/1] MR7471: d2d1/tests: Adjust tolerance of a few float comparisons in windows 7.
by Bernhard Übelacker (＠bernhardu) 03 Mar '25

03 Mar '25

Test d2d1:d2d1 shows a systematic failure with the windows 7 systems: https://test.winehq.org/data/patterns.html#d2d1:d2d1 This patch adds broken statements with a little less strict float comparisons. -- v3: d2d1/tests: Adjust tolerance of a few float comparisons in windows 7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7471

2 2

[PATCH v2 0/1] MR7471: d2d1/tests: Add broken to silence a few float comparisons in windows 7.
by Bernhard Übelacker (＠bernhardu) 03 Mar '25

03 Mar '25

Test d2d1:d2d1 shows a systematic failure with the windows 7 systems: https://test.winehq.org/data/patterns.html#d2d1:d2d1 This patch adds broken statements with a little less strict float comparisons. -- v2: d2d1/tests: Add broken to silence a few float comparisons in windows 7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7471

3 3

[PATCH 0/1] MR7476: ws2_32/tests: Allow WSAConnectByNameA test to fail with WSAEOPNOTSUPP.
by Bernhard Übelacker (＠bernhardu) 03 Mar '25

03 Mar '25

Test ws2_32:sock shows failures with old windows versions: https://test.winehq.org/data/patterns-tb-win.html#ws2_32:sock This patch just adds WSAEOPNOTSUPP to be an allowed failing return value. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7476

2 1

[PATCH 0/1] MR7477: include: Add some flags constants used in pipes API.
by Nikolay Sivov (＠nsivov) 03 Mar '25

03 Mar '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7477

2 1

[PATCH 0/1] MR7474: kernel32: SuspendThread() in Win9x mode should return 0 for current thread.
by Dmitry Timoshkov (＠dmitry) 03 Mar '25

03 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7474

2 1

[PATCH v2 0/1] MR7473: winetest: Avoid underflow when computing filtered output size.
by Rémi Bernon (＠rbernon) 03 Mar '25

03 Mar '25

-- v2: winetest: Avoid underflow when computing filtered output size. https://gitlab.winehq.org/wine/wine/-/merge_requests/7473

2 2

[PATCH 0/1] MR7473: winetest: Avoid underflow when computing filtered output size.
by Rémi Bernon (＠rbernon) 03 Mar '25

03 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7473

2 1

[PATCH v4 0/6] MR7472: winebth.sys part 6: Add support for device inquiry/scanning.
by Vibhav Pant (＠vibhavp) 03 Mar '25

03 Mar '25

-- v4: bluetoothapis/tests: Add tests for BluetoothFindNextDevice. bluetoothapis: Implement BluetoothFindNextDevice. bluetoothapis/tests: Add tests for BluetoothFindFirstDevice, BluetoothFindDeviceClose. bluetoothapis: Implement BluetoothFindFirstDevice and BluetoothFindDeviceClose. https://gitlab.winehq.org/wine/wine/-/merge_requests/7472

2 6

Re: [PATCH v2 0/4] MR7468: win32u: Move opengl code to a dedicated source.
by Rémi Bernon (＠rbernon) 03 Mar '25

03 Mar '25

v2: Fix macos build (hopefully). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7468#note_96590

1 0

Re: [PATCH v2 0/4] MR7468: win32u: Move opengl code to a dedicated source.
by Rémi Bernon (＠rbernon) 03 Mar '25

03 Mar '25

On Mon Mar 3 16:27:36 2025 +0000, Aida Jonikienė wrote: > Will the move include pbuffer handling too? As much as can be factored together. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7468#note_96588

1 0

[PATCH v3 0/6] MR7472: winebth.sys part 6: Add support for device inquiry/scanning.
by Vibhav Pant (＠vibhavp) 03 Mar '25

03 Mar '25

-- v3: bluetoothapis/tests: Add tests for BluetoothFindNextDevice. https://gitlab.winehq.org/wine/wine/-/merge_requests/7472

2 6

[PATCH 0/6] MR7472: winebth.sys part 6: Add support for device inquiry/scanning.
by Vibhav Pant (＠vibhavp) 03 Mar '25

03 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7472

2 6

[PATCH 0/5] MR7470: include: Add more declarations needed for LLVM libc++
by Jacek Caban (＠jacek) 03 Mar '25

03 Mar '25

Based on @rbernon's [branch](https://gitlab.winehq.org/rbernon/wine/-/tree/wip/libc++-fixes). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7470

4 8

[PATCH 0/4] MR7468: win32u: Move opengl code to a dedicated source.
by Rémi Bernon (＠rbernon) 03 Mar '25

03 Mar '25

The plan is to move as much GL code as possible to win32u, similarly to what's been done with vulkan. While I intend to keep the existing driver-specific GL backend (GLX, macos?), I win32u can use EGL more directly while delegating only the platform specific display and surface creation to the drivers. At the same time, it could also make it possible to use EGL for memory DCs too, as osmesa is being removed from Mesa3D main branch (still going to be present in a separate historical branch iiuc). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7468

3 5

[PATCH 0/1] MR7471: d2d1/tests: Add broken to silence a few float comparisons in windows 7.
by Bernhard Übelacker (＠bernhardu) 03 Mar '25

03 Mar '25

Test d2d1:d2d1 shows a systematic failure with the windows 7 systems: https://test.winehq.org/data/patterns.html#d2d1:d2d1 This patch adds broken statements with a little less strict float comparisons. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7471

3 2

[PATCH v2 0/1] MR7469: winegcc: Don't include host include paths when compiling with MSVCRT.
by Jacek Caban (＠jacek) 03 Mar '25

03 Mar '25

While some host includes may work, we can't assume they will. Additionally, they may interfere with the code being built. In my case, LLVM's libc++ build with winegcc was failing due to an [unexpected `__has_include`](https://github.com/llvm/llvm-project/blob/44607666b3429868bce9f0489715eb367d0e08f8/libcxx/include/__mbstate_t.h#L42). -- v2: winegcc: Don't include host include paths when compiling with MSVCRT. https://gitlab.winehq.org/wine/wine/-/merge_requests/7469

2 2

[PATCH 0/1] MR7469: winegcc: Don't include host include paths when compiling with MSVCRT.
by Jacek Caban (＠jacek) 03 Mar '25

03 Mar '25

While some host includes may work, we can't assume they will. Additionally, they may interfere with the code being built. In my case, LLVM's libc++ build with winegcc was failing due to an [unexpected `__has_include`](https://github.com/llvm/llvm-project/blob/44607666b3429868bce9f0489715eb367d0e08f8/libcxx/include/__mbstate_t.h#L42). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7469

3 2

[PATCH v3 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Dmitry Timoshkov (＠dmitry) 03 Mar '25

03 Mar '25

-- v3: windowscodecs: Make support for WICBitmapTransformRotate270 more explicit. https://gitlab.winehq.org/wine/wine/-/merge_requests/7459

3 3

[PATCH v3 0/10] MR7407: windowscodecs: Implement query strings enumerator.
by Nikolay Sivov (＠nsivov) 03 Mar '25

03 Mar '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: windowscodecs: Implement GetPreferredVendorGUID(). windowscodecs/metadata: Implement GetClassID(). windowscodecs/tests: Add some tests for metadata handler GetClassID(). windowscodecs/metadata: Replicate original stream position when creating writer instances from readers. windowscodecs/metadata: Restore original stream position on GetStream(). windowscodecs/tests: Add some tests for stream position handling when nested readers are used. https://gitlab.winehq.org/wine/wine/-/merge_requests/7407

2 10

Re: [PATCH v2 0/1] MR6805: winewayland: Fix surface scaling with HiDPI compositor.
by 小亨 (＠laichiaheng) 03 Mar '25

03 Mar '25

The icons and texts are too tiny in KDE Plasma 6 with 100% scaling on my 4K monitor, so I adjust it to 200%, and the window of my game just becomes 2x bigger, much bigger than my monitor. This doesn't make any sense! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6805#note_96557

1 0

[PATCH v3 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7.
by Bernhard Übelacker (＠bernhardu) 03 Mar '25

03 Mar '25

Tests show test propsys:propsys is failing for many Windows 7 machines. https://test.winehq.org/data/patterns-tb-win.html#propsys:propsys It looks like windows 7 processes VT_R4 like VT_R8. (`0.125f / 0x3e000000 (float/4 byte)` becomes `5.1392085562440189e-315 / 0x3e000000 (double/8 byte)`. Is this worth the effort to remove the failures from the test patterns page? -- v3: propsys/tests: Add broken for unexpected value in windows 7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7460

2 3

[PATCH 0/1] MR7467: kernel32/tests: Work around Windows 7 issuing DllNotification even when loading with DONT_RESOLVE_DLL_REFERENCES
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

Testbot result: https://testbot.winehq.org/JobDetails.pl?Key=151596 Fixes: 99e91f1c0fcb840b4840a4a3c2b079bad817b100 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57903 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7467

3 2

[PATCH v2 0/1] MR7451: dlls/shell32: Fix IUnknown::QueryInterface() to meet spec
by Edward OC (＠funfunctor) 03 Mar '25

03 Mar '25

The spec says if the passed pointer is NULL then return E_POINTER and not to just unconditionally deref then set NULL. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v2: dlls/shell32: Fix IUnknown::QueryInterface() to meet spec https://gitlab.winehq.org/wine/wine/-/merge_requests/7451

4 12

[PATCH v2 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7.
by Bernhard Übelacker (＠bernhardu) 03 Mar '25

03 Mar '25

Tests show test propsys:propsys is failing for many Windows 7 machines. https://test.winehq.org/data/patterns-tb-win.html#propsys:propsys It looks like windows 7 processes VT_R4 like VT_R8. (`0.125f / 0x3e000000 (float/4 byte)` becomes `5.1392085562440189e-315 / 0x3e000000 (double/8 byte)`. Is this worth the effort to remove the failures from the test patterns page? -- v2: propsys/tests: Add broken for unexpected value in windows 7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7460

3 4

Re: [PATCH v26 0/1] MR6884: Iphlpapi.dll: Included SendARP
by Huw Davies (＠huw) 03 Mar '25

03 Mar '25

It would be better to implement `SendARP()` in terms of `ResolveIpNetEntry2()`. Further, `ResolveIpNetEntry2()` should likely use the `Nsi` functions to retrieve the neighbour info from `nsiproxy`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6884#note_96536

1 0

[PATCH v4 0/6] MR7250: ntdll: Properly implement NtFlushProcessWriteBuffers (try 2).
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

Supersedes !741. On macOS 10.14+ `thread_get_register_pointer_values` is called on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_PRIVATE_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 and on other platforms it falls back to calling `NtGetContextThread()` on each thread. The fast path patches from @tmatthies are slightly modified in the following ways: 1. On unsupported platforms, the `try_*()` functions return `FALSE` instead of `0`. 2. `try_exp_membarrier()` is called first, then `try_mach_tgrpvs()`. --- Known applications fixed by this MR: - osu! (rhythm game) song selection menu stuttering - .NET CoreCLR GC - HotSpot JVM (-XX:+UseSystemMemoryBarrier) safepoints -- v4: kernel32/tests: Add a store buffering litmus test involving FlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/7250

3 8

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

On Mon Mar 3 11:04:01 2025 +0000, Jinoh Kang wrote: > My two cents: > This PR is a no-op change except for the test. While this PR improves > readability a little, I guess we could go further and handle flip > horz/vert flags in a more readable way if we want to go that direction? > (Otherwise just keeping the test should be fine too.) In any case, the commit message is misleading and should be reworded on commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96526

1 0

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

On Mon Mar 3 08:08:34 2025 +0000, Dmitry Timoshkov wrote: > It looks like you are right, new tests actually pass with current > implementation. Although the patch makes support for > WICBitmapTransformRotate270 more explicit I'm not opposed to leave the > code intact. I'm open to suggestions. My two cents: This PR is a no-op change except for the test. While this PR improves readability a little, I guess we could go further and handle flip horz/vert flags in a more readable way if we want to go that direction? (Otherwise just keeping the test should be fine too.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96525

1 0

[PATCH v5 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v5: winedmo: Call avformat_find_stream_info for the mp3 format. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 3

[PATCH v4 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v4: winedmo: Call avformat_find_stream_info for the mp3 format. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 2

Re: [PATCH v3 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

Brendan McGrath (@redmcg) commented about dlls/winedmo/unix_demuxer.c: > } > format = demuxer->ctx->iformat; > > - if ((params->duration = get_context_duration( demuxer->ctx )) == AV_NOPTS_VALUE) > + if ((params->duration = get_context_duration( demuxer->ctx )) == AV_NOPTS_VALUE || > + strstr( format->name, "mp3")) > { > if ((ret = avformat_find_stream_info( demuxer->ctx, NULL )) < 0) > { > ERR( "Failed to find stream info, error %s.\n", debugstr_averr(ret) ); > goto failed; > } > - params->duration = get_context_duration( demuxer->ctx ); > + if (params->duration == AV_NOPTS_VALUE) > + params->duration = get_context_duration( demuxer->ctx ); @rbernon I wasn't sure how harmless/harmful this assignment was, so I added a check just in case. If you think it's unnecessary I'll remove. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7439#note_96517

1 0

[PATCH v2 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v2: winedmo: Find mp3 stream info if channel data is missing. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 5

[PATCH v9 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Yuxuan Shui (＠yshui) 03 Mar '25

03 Mar '25

## Context This is a problem discovered when running "Max: The Curse of Brotherhood" under proton. This game writes 4MB a piece into `wg_transform`, which contains about 4 seconds of compressed video. `wg_transform` calls `gst_pad_push` in `transform_ProcessOutput`, which takes \~300ms (i.e. 20 frames @ 60fps) to decode this buffer of video. So the end result is the game hitches every 4 seconds while playing cut scene videos. Proton currently has a special case for this particular game, for which it breaks up the buffer into small chunks to avoid long blocks. This MR adopts that and applies it generally. One concern raised by @redmcg is: > The only issue I can think of is if there are any decoders which don't have a parser; then they might not know how to deal with an arbitrary 4096 byte buffer (the parser is generally responsible for taking arbitrary buffers and producing something the decoder can work with, for example: a full frame). So this MR only enables this strategy when there is a parser element. -- v9: winegstreamer: Avoid large buffer pushes in wg_transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/7288

3 4

[PATCH 0/2] MR7362: winex11.drv: Better detect and switch windows to managed.
by Paul Gofman (＠gofman) 03 Mar '25

03 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7362

4 8

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Dmitry Timoshkov (＠dmitry) 03 Mar '25

03 Mar '25

On Mon Mar 3 06:33:06 2025 +0000, Dmitry Timoshkov wrote: > The tests don't pass with existing code. It looks like you are right, new tests actually pass with current implementation. Although the patch makes support for WICBitmapTransformRotate270 more explicit I'm not opposed to leave the code intact. I'm open to suggestions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96507

1 0

[PATCH 0/1] MR7464: cryptnet: Uniform return value that is the same as _wfsopen.
by Haoyang Chen (＠chenhaoyang) 03 Mar '25

03 Mar '25

INVALID_HANDLE_VALUE is non-zero, and the caller may fail to handle the error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7464

3 2

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Dmitry Timoshkov (＠dmitry) 03 Mar '25

03 Mar '25

On Mon Mar 3 06:33:06 2025 +0000, Elizabeth Figura wrote: > Wait, isn't this already implemented? WICBitmapTransformRotate270 is the > bitwise OR of 90 and 180, and the code seems to take that into account, > am I missing something? The tests don't pass with existing code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96498

1 0

[PATCH 0/5] MR7466: mf: Fix some issues with seeking.
by Conor McCarthy (＠cmccarthy) 03 Mar '25

03 Mar '25

This fixes failure to play the prologue video in Planet of the Apes: Last Frontier, which unpauses by calling Start() with a location. The exact state leading to this issue does not occur in the Start() tests, and it's not clear how to reproduce it reliably. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7466

2 5

2025

2024

2023

2022

wine-gitlab