- wine-gitlab - winehq.org

[PATCH 0/1] MR1179: loader: Unbreak FreeBSD builds (ARRAY_SIZE undefined)
by Gerald Pfeifer (＠gerald) 28 Oct '22

28 Oct '22

Commit af996344a815baa1278d32181ddfda5e889a16d9 used ARRAY_SIZE in FreeBSD-specifc code which, alas, is not available here, so revert that change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1179

4 5

[PATCH v2 0/2] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) 28 Oct '22

28 Oct '22

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v3: Fix failed test. Don't know how to change the subject version number. -- v2: shell32: Add SHBindToFolderIDListParent tests. shell32: Implement SHBindToFolderIDListParent. https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 7

[PATCH v3 0/5] MR1172: jscript/mshtml: Misc improvements.
by Gabriel Ivăncescu (＠insn) 28 Oct '22

28 Oct '22

-- v3: mshtml: Implement document.mimeType. mshtml: Get rid of a EVENTID_LAST special case. mshtml: Allow null or undefined func in addEventListener. mshtml: Allow null or undefined listeners in attachEvent/detachEvent. jscript: Implement VariantChangeType for VT_DISPATCH and VT_UNKNOWN. https://gitlab.winehq.org/wine/wine/-/merge_requests/1172

3 6

[PATCH v2 0/2] MR333: kernelbase: Add QueryVirtualMemoryInformation().
by Nikolay Sivov (＠nsivov) 28 Oct '22

28 Oct '22

https://bugs.winehq.org/show_bug.cgi?id=53288 -- v2: kernelbase: Add QueryVirtualMemoryInformation(). ntdll: Partially implement MemoryRegionInformation query. https://gitlab.winehq.org/wine/wine/-/merge_requests/333

2 2

Re: [PATCH v2 0/5] MR1172: jscript/mshtml: Misc improvements.
by Gabriel Ivăncescu (＠insn) 28 Oct '22

28 Oct '22

So indeed attachEvent only does that when the ChangeType fails (no matter the error code). Getting the mime type thing correct is challenging, but at least I managed to have all tests pass. I think I got it for the most part, and it should be fine for us to do it like this, but I had to add one "special case" in the tests for the w1064v1809 testbot VM because, for whatever reason, it uses the .htm extension to lookup the name, while .html is specified in the database. The CLSID also does not work correctly for it, either (it would show "HTML Document" instead of "HTM file")... I don't think this quirk is worth replicating. Basically, first it looks up the Extension value in the database for that MIME type. If that is not found, or the extension lookup itself fails later or doesn't exist, it tries the CLSID from the database to obtain the ProgID. I also test it in scripts via external.getExpectedMimeType, even though it seems overkill for now, because it will be useful later when testing more doc mime types (XHR response as well, for instance) and from others (anchors, etc). So it will be useful to have. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1172#note_12385

1 0

[PATCH v8 0/1] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) 28 Oct '22

28 Oct '22

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v8: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 1

[PATCH v7 0/1] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) 28 Oct '22

28 Oct '22

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v7: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 1

[PATCH 0/2] MR1182: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (i386).
by Jinoh Kang (＠iamahuman) 28 Oct '22

28 Oct '22

This change is adding DWARF (CFI) unwind information to the hand-written assembly of the `__wine_syscall_dispatcher` function. This enables unwinding through the dispatcher from the Linux stack into (and through) the Windows stack. The general idea is that the `syscall_frame` struct contains the content of the callee-save registers before the function call (in particular the stack pointer and the return address). At any point of the execution, we have a pointer into the `syscall_frame` in $ebx, $ecx, $ebp, or $esp. For the CFI codes the general idea is that we are defining the computations of the callee-save registers based on the `syscall_frame` using DWARF’s `breg` instruction, rather than relative to CFA. cc/ @florian-kuebler -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1182

2 2

[PATCH v3 0/7] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 28 Oct '22

28 Oct '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. I don't know what to call this kind of callback, I just called it "user32 callback" for now because it's going through user32 but that's not really a good name. It also sadly necessitates a private \_\_wine export from user32, unless someone has a better idea for how to register the callbacks with user32. -- v3: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Convert kernel callbacks to user32 callbacks. winemac.drv: Convert kernel callbacks to user32 callbacks. wineandroid.drv: Convert kernel callbacks to user32 callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 9

[PATCH 0/1] MR1181: wpcap: Build pcap_address structure from IP_ADAPTER_UNICAST_ADDRESS.
by Hans Leidekker (＠hans) 28 Oct '22

28 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1181

3 2

[PATCH v2 0/3] MR1178: kernelbase: Forward some directory info classes in GetFileInformationByHandleEx().
by Nikolay Sivov (＠nsivov) 28 Oct '22

28 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53590 -- v2: kernelbase: Forward some more classes in GetFileInformationByHandleEx(). kernelbase: Make sure to provide a message for missing information classes in GetFileInformationByHandleEx(). kernelbase: Forward some directory info classes in GetFileInformationByHandleEx(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1178

2 3

[PATCH 0/7] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 28 Oct '22

28 Oct '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. I don't know what to call this kind of callback, I just called it "user32 callback" for now because it's going through user32 but that's not really a good name. It also sadly necessitates a private \_\_wine export from user32, unless someone has a better idea for how to register the callbacks with user32. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 8

[PATCH v2 0/7] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 28 Oct '22

28 Oct '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. I don't know what to call this kind of callback, I just called it "user32 callback" for now because it's going through user32 but that's not really a good name. It also sadly necessitates a private \_\_wine export from user32, unless someone has a better idea for how to register the callbacks with user32. -- v2: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Convert kernel callbacks to user32 callbacks. winemac.drv: Convert kernel callbacks to user32 callbacks. wineandroid.drv: Convert kernel callbacks to user32 callbacks. winevulkan: Convert kernel callbacks to user32 callbacks. user.exe16: Convert kernel callbacks to user32 callbacks. user32: Add user32 callback infrastructure. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

2 7

[PATCH v4 0/9] MR1177: msvcrt: implement much more localized functions
by Bartosz Kosiorek (＠gang65) 27 Oct '22

27 Oct '22

-- v4: msvcrt: Add _mbctokata_l implementation. msvcrt: Add _mbctohira_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1177

2 9

Re: [PATCH v8 0/2] MR1015: wpcap: Build devices in unixlib for find_all_devices
by Marc-Aurel Zent (＠marzent) 27 Oct '22

27 Oct '22

Yeah the commit above worked perfectly, didn't know even know you can do it like that on the PE side. Much nicer than the double calling and conversion of the Unix struct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1015#note_12353

1 0

Re: [PATCH v8 0/2] MR1015: wpcap: Build devices in unixlib for find_all_devices - closed
by Marc-Aurel Zent (＠marzent) 27 Oct '22

27 Oct '22

This merge request was closed by Marc-Aurel Zent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1015

1 0

[PATCH v2 0/3] MR1174: compstui: Add CPSFUNC_ADD_PFNPROPSHEETUI and CPSFUNC_ADD_PROPSHEETPAGE support.
by Piotr Caban (＠piotr) 27 Oct '22

27 Oct '22

-- v2: compstui: Test that callbacks are executed. https://gitlab.winehq.org/wine/wine/-/merge_requests/1174

2 4

[PATCH v3 0/7] MR1177: msvcrt: implement much more localized functions
by Bartosz Kosiorek (＠gang65) 27 Oct '22

27 Oct '22

-- v3: msvcrt: Add _mbctombb_l implementation. msvcrt: Add _mbcjmstojis_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1177

2 7

[PATCH 0/3] MR1174: compstui: Add CPSFUNC_ADD_PFNPROPSHEETUI and CPSFUNC_ADD_PROPSHEETPAGE support.
by Piotr Caban (＠piotr) 27 Oct '22

27 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1174

3 6

[PATCH v2 0/7] MR1177: msvcrt: implement much more localized functions
by Bartosz Kosiorek (＠gang65) 27 Oct '22

27 Oct '22

-- v2: msvcrt: Add _mbctombb_l implementation. msvcrt: Add _mbcjmstojis_l implementation. msvcrt: Add _mbcjistojms_l implementation. ucrtbase: Export more _o_* functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1177

2 7

[PATCH 0/8] MR1177: msvcrt: implement much more localized functions
by Bartosz Kosiorek (＠gang65) 27 Oct '22

27 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1177

3 10

[PATCH v2 0/3] MR1134: ntdll: Use local unwinding reimplementations for Unix libraries on ARM/ARM64
by Martin Storsjö (＠mstorsjo) 27 Oct '22

27 Oct '22

Currently, unwinding the unix libraries (or full ELF builds) requires having libunwind available. When starting up a wine environment, an exception of type `RPC_S_SERVER_UNAVAILABLE` gets thrown - and if libunwind isn't available, this breaks the startup. Thus, currently on ARM/ARM64, libunwind is essentially mandatory. Additionally, at least on ARM, libunwind seems brittle (commits in latest git master breaks the unwinding use cases in Wine, see e.g. https://github.com/libunwind/libunwind/pull/203#issuecomment-984126066. This MR tries to resolve all of this, by including the preexisting DWARF parser from x86_64 in the aarch64 version too. This bit was mostly quite straightforward. For ARM, libunwind has currently relied on DWARF debug info in the `.debug_frame` section, since Linux on ARM doesn't use DWARF for runtime unwinding. This MR adds ARM EHABI unwind opcodes where necessary, and adds a local reimplementation of an ARM EHABI/EXIDX/EXTBL unwinder, similar to the DWARF one. With these changes, unwinding on both ARM and ARM64 seems to work fine, even without libunwind. See the individual commit messages for more commentary on the decisions taken so far (I've tried to write up all relevant considerations there - it's a fair amount of commentery). A couple open questions: - So far, the shared DWARF code was put in a header, `dwarf.h`. Do you want to make this a proper standalone `.c` file too? - I wrote the ARM EHABI unwind code mostly with `stdint.h` types like `uint32_t`(as it's in the ntdll/unix directory anyway), but I can rewrite it with `DWORD` or similar if that's preferred. - The ARM EHABI opcodes are enabled for `defined(__arm__) && defined(__ELF__) && defined(__GNUC__) && !defined(__SEH__) && !defined(__ARM_DWARF_EH__)` - there's no define to check for for knowing it's used and enabled, but it has to be implicitly assumed if no other other unwind mechanism is signaled. - The `dl_iterate_phdr` function, used for finding the EXIDX section for locating ARM EHABI unwind info, is used within `#ifdef linux`. It might be available on other OSes too (like FreeBSD etc). Or should I go ahead and add a configure check for it? CC @julliard @rbernon @AndreRH -- v2: ntdll: Use the local dwarf implementation on arm64 ntdll: Add support for aarch64 in the dwarf implementation ntdll: Move the dwarf reading routines to a shareable header https://gitlab.winehq.org/wine/wine/-/merge_requests/1134

3 6

[PATCH 0/1] MR1178: kernelbase: Forward some directory info classes in GetFileInformationByHandleEx().
by Nikolay Sivov (＠nsivov) 27 Oct '22

27 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53590 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1178

2 1

[PATCH 0/5] MR1172: jscript/mshtml: Misc improvements.
by Gabriel Ivăncescu (＠insn) 27 Oct '22

27 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1172

4 13

[PATCH v3 0/9] MR36: hlsl: UAV loads and stores.
by Zebediah Figura (＠zfigura) 27 Oct '22

27 Oct '22

-- v3: vkd3d-shader/hlsl: Propagate copies for resource store instructions. vkd3d-shader/hlsl: Write SM4 UAV store instructions. vkd3d-shader/hlsl: Parse UAV stores. vkd3d-shader/hlsl: Implement typed UAV loads. vkd3d-shader/hlsl: Write SM4 UAV declarations. vkd3d-shader/hlsl: Allocate UAVs. tests: Add a test for storing to a UAV array. tests: Add more tests for UAV allocation. tests: Fix constructor declaration in the partial UAV write test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/36

5 12

[PATCH v10 0/3] MR1164: Draft: gdiplus: add initial CompoundLine support to fix application crash
by Bartosz Kosiorek (＠gang65) 27 Oct '22

27 Oct '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52196 -- v10: gdiplus: add GdipGetPenCompoundArray implementation gdiplus: add GdipGetPenCompoundCount implementation gdiplus: add GdipSetPenCompoundArray implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/1164

3 5

[PATCH v8 0/3] MR1164: Draft: gdiplus: add initial CompoundLine support to fix application crash
by Bartosz Kosiorek (＠gang65) 27 Oct '22

27 Oct '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52196 -- v8: gdiplus: add GdipGetPenCompoundArray implementation gdiplus: add GdipGetPenCompoundCount implementation gdiplus: add GdipSetPenCompoundArray implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/1164

3 5

Re: [PATCH v8 0/2] MR1015: wpcap: Build devices in unixlib for find_all_devices
by Hans Leidekker (＠hans) 27 Oct '22

27 Oct '22

Looking at this again I see another way to solve this. Instead of converting Unix pcap_address structures we can build them from the addresses returned by GetAdaptersAddresses(). Something like this: https://gitlab.winehq.org/hans/wine/-/commit/30113218d4d9fea4ec393a6b0d2d97… Does that work for you? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1015#note_12329

1 0

[PATCH 0/1] MR1176: maintainers: Update Microsoft C Runtime files list.
by Piotr Caban (＠piotr) 27 Oct '22

27 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1176

2 1

[PATCH v3 0/4] MR1157: win32u: Move DisplayConfigGetDeviceInfo from user32 and implement DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_NAME.
by Paul Gofman (＠gofman) 27 Oct '22

27 Oct '22

-- v3: win32u: Implement NtUserDisplayConfigGetDeviceInfo(DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_NAME). win32u: Store output id in monitors cache. win32u: Move NtUserDisplayConfigGetDeviceInfo implementation from user32. win32u: Store GPU luid in adapters cache. https://gitlab.winehq.org/wine/wine/-/merge_requests/1157

4 7

[PATCH v6 0/1] MR1145: kernelbase: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) 26 Oct '22

26 Oct '22

a hotfix for the recent release of Persona 5 Royal. -- v6: kernelbase: Implement various transacted file APIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/1145

5 4

[PATCH 0/1] MR1173: server: Only require THREAD_SET_LIMITED_INFORMATION access to set thread description.
by Brendan Shanks (＠bshanks) 26 Oct '22

26 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1173

2 1

Re: [PATCH v2 0/3] MR1171: uiautomationcore: Add support for more UiaConditions. - approved
by Alexandre Julliard (＠julliard) 26 Oct '22

26 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1171

1 0

Re: [PATCH v6 0/4] MR1159: msvcrt: add implementation for localized functions - approved
by Alexandre Julliard (＠julliard) 26 Oct '22

26 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1159

1 0

Re: [PATCH v2 0/1] MR1098: ntdll: Set native thread names on Linux when set with SetThreadDescription(). - approved
by Alexandre Julliard (＠julliard) 26 Oct '22

26 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1098

1 0

Re: [PATCH v2 0/1] MR1165: kernel32/tests: Workaround some broken Windows behavior in console tests. - approved
by Alexandre Julliard (＠julliard) 26 Oct '22

26 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1165

1 0

Re: [PATCH v2 0/1] MR1168: wbemprox: WQL string comparisons are case insensitive. - approved
by Alexandre Julliard (＠julliard) 26 Oct '22

26 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1168

1 0

Re: [PATCH v6 0/3] MR1070: Add more tests for \Device\NamedPipe, \Device\NamedPipe\, and exotic pipe names - approved
by Alexandre Julliard (＠julliard) 26 Oct '22

26 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1070

1 0

Re: [PATCH v4 0/4] MR1122: comctl32: property sheet improvements - approved
by Alexandre Julliard (＠julliard) 26 Oct '22

26 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1122

1 0

Re: [PATCH v2 0/3] MR40: vkd3d-shader/hlsl: Support complex implicit casts, complex explicit casts and complex broadcasts. (PART 3/3) - approved
by Alexandre Julliard (＠julliard) 26 Oct '22

26 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/40

1 0

[PATCH v4 0/7] MR1111: winsock: Always use Unix SO_REUSEADDR on TCP sockets.
by Paul Gofman (＠gofman) 26 Oct '22

26 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50955 The problem which this patchset aims to solve is (sometimes) huge timeout on TCP listening port availability on Linux after the listening socket was closed one or another way. By default, the listening port will also be blocked for the whole time accepted socket waits through lengthy timeouts (sometimes; most surely when the listening process with an active connection was force killed, but not limited to this condition). BSD SO_REUSEADDR socket option is aimed mainly to avoid that extra wait on binding already closed listening socket address. From [1]: "Indicates that the rules used in validating addresses supplied in a bind(2) call should allow reuse of local addresses. For AF_INET sockets this means that a socket may bind, except when there is an active listening socket bound to the address.". Unix SO_REUSEADDR does not really allow reusing address in the Winsock sense. It will just allow to ditch the timeout (which is always the case on Windows without any specific options). Unfortunately it is not the only effect of the option. It still won't allow listening on the address simultaneously (unlike Winsock SO_REUSEADDR which allows simultaneous listening), or binding to an address which is being listened. But it will allow to bind different sockets for the same address which is not the Winsock behaviour when Winsock SO_REUSEADDR is set. So the patchset enables SO_REUSEADDR on every TCP socket and introduces the bound address tracking which will allow to return an error from bind() when needed. Not related to this patchset, but Winsock SO_REUSEADDR is somewhat closer to BSD SO_REUSEPORT, although is different in a way that _REUSEPORT will load balance connections between listeners while with Winsock _REUSEADDR the connections will always go to the first listener. I hope that the bound addresses tracking introduced in these patches may be reused in the future. E. g., maybe it might be helpful on the way of implementing the todos introduced by my extended tests (those todos are not related to this patchset and exist both with and without it). 1. https://man7.org/linux/man-pages/man7/socket.7.html -- v4: ws2_32/tests: Also test bind to any together with loopback in a different order. https://gitlab.winehq.org/wine/wine/-/merge_requests/1111

3 9

[PATCH v3 0/7] MR1111: winsock: Always use Unix SO_REUSEADDR on TCP sockets.
by Paul Gofman (＠gofman) 26 Oct '22

26 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50955 The problem which this patchset aims to solve is (sometimes) huge timeout on TCP listening port availability on Linux after the listening socket was closed one or another way. By default, the listening port will also be blocked for the whole time accepted socket waits through lengthy timeouts (sometimes; most surely when the listening process with an active connection was force killed, but not limited to this condition). BSD SO_REUSEADDR socket option is aimed mainly to avoid that extra wait on binding already closed listening socket address. From [1]: "Indicates that the rules used in validating addresses supplied in a bind(2) call should allow reuse of local addresses. For AF_INET sockets this means that a socket may bind, except when there is an active listening socket bound to the address.". Unix SO_REUSEADDR does not really allow reusing address in the Winsock sense. It will just allow to ditch the timeout (which is always the case on Windows without any specific options). Unfortunately it is not the only effect of the option. It still won't allow listening on the address simultaneously (unlike Winsock SO_REUSEADDR which allows simultaneous listening), or binding to an address which is being listened. But it will allow to bind different sockets for the same address which is not the Winsock behaviour when Winsock SO_REUSEADDR is set. So the patchset enables SO_REUSEADDR on every TCP socket and introduces the bound address tracking which will allow to return an error from bind() when needed. Not related to this patchset, but Winsock SO_REUSEADDR is somewhat closer to BSD SO_REUSEPORT, although is different in a way that _REUSEPORT will load balance connections between listeners while with Winsock _REUSEADDR the connections will always go to the first listener. I hope that the bound addresses tracking introduced in these patches may be reused in the future. E. g., maybe it might be helpful on the way of implementing the todos introduced by my extended tests (those todos are not related to this patchset and exist both with and without it). 1. https://man7.org/linux/man-pages/man7/socket.7.html -- v3: ws2_32/tests: Also test bind to any together with loopback in a different order. server: Set Unix SO_REUSEADDR on all the TCP sockets. server: Track SO_REUSEADDR value. ntdll: Move SO_REUSEADDR handling to server. ws2_32/tests: Also test TCP6 in test_so_reuseaddr(). ws2_32/tests: Add tests for reusing address without SO_REUSEADDR. https://gitlab.winehq.org/wine/wine/-/merge_requests/1111

4 10

[PATCH v6 0/2] MR1015: wpcap: Convert Unix sockaddr to win32 before duplication
by Marc-Aurel Zent (＠marzent) 26 Oct '22

26 Oct '22

Interpreting the fist two bytes of the `sockaddr` struct as `sa_family` produces incorrect behaviour on macOS and (presumbly) BSD. This change uses both Unix and Windows socket headers to convert the libpcap provided sockaddr before duplicating it. This fixes sockaddr being always NULL on macOS/BSD and ipv6 addresses not working in general since `AF_INET6` differs on Windows(23), macOS(30) and Linux(10) For reference https://www.ibm.com/docs/en/i/7.3?topic=family-af-inet-address and this is from the <sys/socket.h> on macOS ``` /* * [XSI] Structure used by kernel to store most addresses. */ struct sockaddr { __uint8_t sa_len; /* total length */ sa_family_t sa_family; /* [XSI] address family */ char sa_data[14]; /* [XSI] addr value (actually larger) */ }; ``` -- v6: wpcap: Build devices in unixlib for find_all_devices. wpcap: Split device allocation and build in find_all_devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/1015

2 3

[PATCH 0/3] MR1171: uiautomationcore: Add support for more UiaConditions.
by Connor McAdams (＠cmcadams) 26 Oct '22

26 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1171

3 4

[PATCH 0/1] MR1170: wbemprox: Fix out-of-bounds access caused by codepoints above U+00FF.
by Jinoh Kang (＠iamahuman) 26 Oct '22

26 Oct '22

For now, assume all Unicode codepoints in range U+0100 - U+10FFFF constitute a valid identifier. Note that we already do that for range U+0080 - U+00FF. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1170

3 2

[PATCH v2 0/6] MR1111: winsock: Always use Unix SO_REUSEADDR on TCP sockets.
by Paul Gofman (＠gofman) 26 Oct '22

26 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50955 The problem which this patchset aims to solve is (sometimes) huge timeout on TCP listening port availability on Linux after the listening socket was closed one or another way. By default, the listening port will also be blocked for the whole time accepted socket waits through lengthy timeouts (sometimes; most surely when the listening process with an active connection was force killed, but not limited to this condition). BSD SO_REUSEADDR socket option is aimed mainly to avoid that extra wait on binding already closed listening socket address. From [1]: "Indicates that the rules used in validating addresses supplied in a bind(2) call should allow reuse of local addresses. For AF_INET sockets this means that a socket may bind, except when there is an active listening socket bound to the address.". Unix SO_REUSEADDR does not really allow reusing address in the Winsock sense. It will just allow to ditch the timeout (which is always the case on Windows without any specific options). Unfortunately it is not the only effect of the option. It still won't allow listening on the address simultaneously (unlike Winsock SO_REUSEADDR which allows simultaneous listening), or binding to an address which is being listened. But it will allow to bind different sockets for the same address which is not the Winsock behaviour when Winsock SO_REUSEADDR is set. So the patchset enables SO_REUSEADDR on every TCP socket and introduces the bound address tracking which will allow to return an error from bind() when needed. Not related to this patchset, but Winsock SO_REUSEADDR is somewhat closer to BSD SO_REUSEPORT, although is different in a way that _REUSEPORT will load balance connections between listeners while with Winsock _REUSEADDR the connections will always go to the first listener. I hope that the bound addresses tracking introduced in these patches may be reused in the future. E. g., maybe it might be helpful on the way of implementing the todos introduced by my extended tests (those todos are not related to this patchset and exist both with and without it). 1. https://man7.org/linux/man-pages/man7/socket.7.html -- v2: server: Set Unix SO_REUSEADDR on all the TCP sockets. server: Track SO_REUSEADDR value. ntdll: Move SO_REUSEADDR handling to server. ws2_32/tests: Also test TCP6 in test_so_reuseaddr(). ws2_32/tests: Add tests for reusing address without SO_REUSEADDR. ws2_32/tests: Make test_so_reuseaddr() more conclusive. https://gitlab.winehq.org/wine/wine/-/merge_requests/1111

3 8

[PATCH v2 0/3] MR1152: ntdll: Fixes for Overwatch 2.
by Torge Matthies (＠tmatthies) 26 Oct '22

26 Oct '22

Overwatch 2 doesn't like the win32u `-syscall` conversion that happened a while back, because it hooks KiUserCallbackDispatcher. This MR fixes it up to match what Overwatch 2 expects. -- v2: ntdll: Pass KiUserCallbackDispatcher parameters on stack. ntdll: Add 5-byte nop to start of KiUserCallbackDispatcher. ntdll: Align stack pointer when calling KiUserCallbackDispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1152

6 12

[PATCH v6 0/2] MR231: SetWindowPos() parent window exposure fixes (#53153)
by Jinoh Kang (＠iamahuman) 26 Oct '22

26 Oct '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v6: https://gitlab.winehq.org/wine/wine/-/merge_requests/231

3 4

[PATCH v2 0/4] MR1157: win32u: Move DisplayConfigGetDeviceInfo from user32 and implement DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_NAME.
by Paul Gofman (＠gofman) 26 Oct '22

26 Oct '22

-- v2: win32u: Implement NtUserDisplayConfigGetDeviceInfo(DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_NAME). win32u: Store output id in monitors cache. https://gitlab.winehq.org/wine/wine/-/merge_requests/1157

5 8

[PATCH v2 0/9] MR36: hlsl: UAV loads and stores.
by Zebediah Figura (＠zfigura) 26 Oct '22

26 Oct '22

-- v2: vkd3d-shader/hlsl: Propagate copies for resource store instructions. vkd3d-shader/hlsl: Write SM4 UAV store instructions. vkd3d-shader/hlsl: Parse UAV stores. vkd3d-shader/hlsl: Implement typed UAV loads. vkd3d-shader/hlsl: Write SM4 UAV declarations. vkd3d-shader/hlsl: Allocate UAVs. tests: Add a test for storing to a UAV array. tests: Add more tests for UAV allocation. tests: Fix constructor declaration in the partial UAV write test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/36

5 16

[PATCH 0/3] MR40: vkd3d-shader/hlsl: Support complex implicit casts, complex explicit casts and complex broadcasts. (PART 3/3)
by Francisco Casas (＠fcasas) 26 Oct '22

26 Oct '22

Just additional complex explicit casts tests. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/40

5 6

Re: [PATCH v5 0/4] MR1159: msvcrt: add implementation for localized functions - approved
by Piotr Caban (＠piotr) 26 Oct '22

26 Oct '22

This merge request was approved by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1159

1 0

[PATCH 0/3] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) 26 Oct '22

26 Oct '22

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v3: Fix failed test. Don't know how to change the subject version number. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 7

[PATCH v5 0/3] MR231: SetWindowPos() parent window exposure fixes (#53153)
by Jinoh Kang (＠iamahuman) 26 Oct '22

26 Oct '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v5: server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children. server: Redraw composited window child when its z-order changes. server: Correctly expose composited parent window and its child on position change. https://gitlab.winehq.org/wine/wine/-/merge_requests/231

3 4

[PATCH 0/1] MR1169: conhost/tests: Fix some conditions on tty test termination.
by eric pouech (＠epo) 26 Oct '22

26 Oct '22

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1169

2 1

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Matteo Bruni (＠Mystral) 26 Oct '22

26 Oct '22

On Wed Oct 19 09:55:18 2022 +0000, Patrick Hibbs wrote: > The same issue with strings occurs with Texture and shader types. > I.e. Paramater is rendered irretrievable. Calling it's relevant GetXXX() > function causes a crash if it's a scalar. Calling GetParamaterByName() > will return an invalid handle. Oh, interesting. GetParameterByName() failing afterwards is probably an indication that the SetRawValue() call overwrote parts of some internal data structure and broke the effect object to some degree. BTW, you're supposed to set texture parameters to a IDirect3DBaseTexture9 / IUnknown pointer (and similarly the value for a string parameter should probably be a string pointer rather than the string contents). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_12212

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Matteo Bruni (＠Mystral) 26 Oct '22

26 Oct '22

On Wed Oct 19 11:26:44 2022 +0000, Patrick Hibbs wrote: > Done in v3 of the patch. > Should I respond to all of these if I think it's been done? > Should I mark the thread resolved if I think it's been done, or is that > something the reviewer should do? Feel free to mark the threads that you think are done with as resolved (I think I can still reopen them if I happen to disagree) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_12213

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Matteo Bruni (＠Mystral) 26 Oct '22

26 Oct '22

On Wed Oct 19 09:48:02 2022 +0000, Patrick Hibbs wrote: > Actually it seems that the strings are rendered irretrievable by the > call to SetRawValue(). > Calling GetString() on a scalar string after the destruction causes a > crash in win10. While calling it with a string vector doesn't crash, but > returns D3DERR_INVALIDCALL instead. > I've updated the tests in v3 of the patch to check for this. Ah, that explains it I guess. Weird, but not too surprising. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_12211

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Matteo Bruni (＠Mystral) 26 Oct '22

26 Oct '22

On Wed Oct 19 11:23:25 2022 +0000, Patrick Hibbs wrote: > Sorry about the unexpected push, I'll be more careful next time. > With regards to the bool fixups, are we sure we want to just write the > raw data given to us? I ask because I've also noticed that SetRawValue() > has a tendency to promote datatypes when given a single value and a > vector / matrix paramater. I.e. float and int become a float4 and int4 > respectively for both vectors and matrices. (MSDN calls this behavior a > "cast.") This results in the next 3 values in the paramater's buffer > being set to zero. > Assuming SetRawValue() shouldn't fix the bool values itself, should it > also avoid fixing the ints and floats? If so, how should we indicate the > need for a fixup to other functions? There doesn't seem to be any > infrastructure to support that in wine currently. (We could abuse the > paramater block support for that, but see the speculation below.) > The float and int promotions were the reason I didn't clear the > paramater after each test. As doing so would cause us to miss the writes > to the next 3 values in the paramater. As they would already be set to > zero before the call. Should I still go ahead and clear the paramaters > after each test anyway? > As a dirty hack, I added a call to zero out the paramaters after each > test with a 4x4 matrix of zero ints in v3 of the test. That call is > commented out in the push, but if you enable it it will succeed for most > of the tests under win10. (I disabled it before I fixed the string test > crashes. So it may work fine now, I haven't checked.) I haven't tried > checking the paramaters after the current one for alterations. I was > going to put that in it's own set of tests. > This part is speculation but, if it is a valid use of SetRawValue() to > set adjacent paramaters regardless of type with one call, then the > entire set of paramaters for a given effect needs to be in the same > memory block. (Which seems to be not the case in wine, as there are > plenty of calls to heap_alloc() / heap_realloc() using the param->data > pointer in effect.c.) That would also imply that there is a specific > ordering of paramaters in memory as well. Which would need to be tested > for. If this behavior is combined with the bool assumption above, then > we'd also need to test for order of operations too. > Assuming all of that needs to be done, how do we split this up? Because > I have a feeling that this patchset is going to be rather large in > scope. (If all of the assumptions and speculation are true that is.) Unfortunately I keep being unable to reply promptly. Anyway... > With regards to the bool fixups, are we sure we want to just write the raw data given to us? I ask because I've also noticed that SetRawValue() has a tendency to promote datatypes when given a single value and a vector / matrix paramater. I.e. float and int become a float4 and int4 respectively for both vectors and matrices. (MSDN calls this behavior a "cast.") This results in the next 3 values in the paramater's buffer being set to zero. Is that what happens or is just the rest of the parameter being set to 0? > Assuming SetRawValue() shouldn't fix the bool values itself, should it also avoid fixing the ints and floats? How should they be fixed? I'm still assuming that SetRawValue() more or less does what it says i.e. it just sets the value of parameters by mere byte-for-byte copy, without any kind of conversion or fixup. Do we have evidence that's not the case? > The float and int promotions were the reason I didn't clear the paramater after each test. As doing so would cause us to miss the writes to the next 3 values in the paramater. As they would already be set to zero before the call. Should I still go ahead and clear the paramaters after each test anyway? It might make sense to clear them to a non-zero value (e.g. some variation of the usual 0xdeadbeef marker) to make those results more evident. > This part is speculation but, if it is a valid use of SetRawValue() to set adjacent paramaters regardless of type with one call, then the entire set of paramaters for a given effect needs to be in the same memory block. (Which seems to be not the case in wine, as there are plenty of calls to heap_alloc() / heap_realloc() using the param->data pointer in effect.c.) That would also imply that there is a specific ordering of paramaters in memory as well. Which would need to be tested for. If this behavior is combined with the bool assumption above, then we'd also need to test for order of operations too. Yes, that wouldn't quite work right away. It's fine to just add a FIXME() for straddling parameters for the time being, if it turns out that native actually supports that. Similarly for the test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_12210

1 0

[PATCH 0/2] MR12: vkd3d: Add Windows implementation of vkd3d_set_thread_name().
by Brendan Shanks (＠bshanks) 26 Oct '22

26 Oct '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/12

4 7

[PATCH 0/1] MR1168: wbemprox: WQL string comparisons are case insensitive.
by Hans Leidekker (＠hans) 26 Oct '22

26 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53832 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1168

2 1

[PATCH v9 0/10] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 26 Oct '22

26 Oct '22

Also unifies hidden file handling. Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v9: ntdll: Try to avoid requesting the file name for a handle. ntdll: Ensure that attributes are kept the same when renaming or hard-linking a file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

3 11

[PATCH 0/2] MR1156: Allow a loaded registry key to be loaded multiple times.
by Santino Mazza (＠tati1454) 26 Oct '22

26 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1156

4 4

[PATCH v8 0/10] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 26 Oct '22

26 Oct '22

Also unifies hidden file handling. Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v8: ntdll: Try to avoid requesting the file name for a handle. https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

3 12

[PATCH v7 0/10] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 26 Oct '22

26 Oct '22

Also unifies hidden file handling. Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v7: ntdll: Try to avoid requesting the file name for a handle. ntdll: Ensure that attributes are kept the same when renaming a file. ntdll: Set xattr in NtCreateFile if inferred and requested attributes don't match. ntdll: Only infer hidden attribute from file name if xattr is not present. ntdll: Handle hidden file names in fd_get_file_info. ntdll: Pass file path into fd_get_file_info if available. ntdll: Do not compute file attributes for info classes that don't need them. ntdll: Handle hidden file names inside get_file_info instead of after it. ntdll: Do not open-code hidden file handling in get_dir_data_entry. ntdll/tests: Add test for file attributes of files with names beginning with a dot. https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

3 11

[PATCH v7 0/3] MR1164: Draft: gdiplus: add initial CompoundLine support to fix application crash
by Bartosz Kosiorek (＠gang65) 26 Oct '22

26 Oct '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52196 -- v7: gdiplus: add GdipGetPenCompoundArray implementation gdiplus: add GdipGetPenCompoundCount implementation gdiplus: add GdipSetPenCompoundArray implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/1164

3 4

Re: [PATCH v6 0/9] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 26 Oct '22

26 Oct '22

forgot to rebase before push -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_12167

1 0

[PATCH v5 0/9] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 26 Oct '22

26 Oct '22

Also unifies hidden file handling. Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v5: ntdll: Ensure that attributes are kept the same when renaming a file. ntdll: Set xattr in NtCreateFile if inferred and requested attributes don't match. ntdll: Only infer hidden attribute from file name if xattr is not present. ntdll: Handle hidden file names in fd_get_file_info. ntdll: Pass file path into fd_get_file_info if available. ntdll: Do not compute file attributes for info classes that don't need them. ntdll: Handle hidden file names inside get_file_info instead of after it. https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

2 10

[PATCH v3 0/4] MR1122: comctl32: property sheet improvements
by Piotr Caban (＠piotr) 26 Oct '22

26 Oct '22

-- v3: comctl32: Add support for adding extra data in CreatePropertySheetPage. comctl32: Fix PROPSHEETPAGE[AW] structure content in messages and callbacks. comctl32: Don't use PROPSHEETPAGE structure to store internal HPROPSHEETPAGE data. comctl32: Create page if PROPSHEETPAGE was passed as HPROPSHEETPAGE to PropertySheetAW or PSM_INSERTPAGE. https://gitlab.winehq.org/wine/wine/-/merge_requests/1122

4 6

[PATCH v5 0/5] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) 26 Oct '22

26 Oct '22

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.or… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is used on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. On non-x86 Linux <= 4.2 and on other platforms the fallback path using APCs is used. -- v5: ntdll: Add thread_get_register_pointer_values-based fast path for NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

4 11

[PATCH v5 0/3] MR1070: Add more tests for \Device\NamedPipe, \Device\NamedPipe\, and exotic pipe names
by Jinoh Kang (＠iamahuman) 25 Oct '22

25 Oct '22

-- v5: ntdll/tests: Add more tests for \Device\NamedPipe and \Device\NamedPipe\. ntdll/tests: Add tests for pipe names. https://gitlab.winehq.org/wine/wine/-/merge_requests/1070

4 6

[PATCH v4 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 25 Oct '22

25 Oct '22

Also unifies hidden file handling. Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v4: ntdll: Ensure that attributes are kept the same when renaming a file. ntdll: Set xattr in NtCreateFile if inferred and requested attributes don't match. ntdll: Only infer hidden attribute from file name if xattr is not present. ntdll: Consistently handle dot files in file functions. ntdll: Do not open-code hidden file handling in get_dir_data_entry. ntdll/tests: Add test for file attributes of files with names beginning with a dot. https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

4 9

Re: [PATCH v4 0/3] MR1003: gdiplus: Use atomic write for releasing GpImage lock.
by Zebediah Figura (＠zfigura) 25 Oct '22

25 Oct '22

On Tue Oct 25 21:12:39 2022 +0000, Esme Povirk wrote: > There are two different kinds of "locking" going on here. There's > GdipLockBitmapBits, which isn't a locking mechanism at all but a way of > accessing bitmap data, and the mutex we have protecting Bitmap objects. > Also, error 7 is a gdiplus Status enum value named Win32Error, not a > win32 error code, so this isn't ERROR_ARENA_TRASHED. > This test case is entirely single-threaded, so it's not a race > condition. The mutex-lock isn't really involved. It seems like gdiplus > does not account for GdipImageRotateFlip being called while a bitmap is > bits-locked. I would guess that RotateFlip changes the location of the > image data, invalidating the state that UnlockBits needs to function > correctly. What "should" happen in this situation is probably that > GdipImageRotateFlip fails with WrongState, but it seems Windows doesn't > do that. > The patches here bring us closer to the (broken) Windows behavior, > although I'm really not sure how Wine will end up handling this > situation in practice. Ah, okay, I made a lot of assumptions, and didn't actually examine the test case. Sorry about that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1003#note_12127

1 0

Re: [PATCH v4 0/3] MR1003: gdiplus: Use atomic write for releasing GpImage lock.
by Esme Povirk (＠madewokherd) 25 Oct '22

25 Oct '22

On Tue Oct 25 21:03:54 2022 +0000, Zebediah Figura wrote: > That behaviour sounds an awful lot like gdiplus isn't thread-safe after > all. E.g. error 7 is ERROR_ARENA_TRASHED. Should this code really have a > lock at all? There are two different kinds of "locking" going on here. There's GdipLockBitmapBits, which isn't a locking mechanism at all but a way of accessing bitmap data, and the mutex we have protecting Bitmap objects. Also, error 7 is a gdiplus Status enum value named Win32Error, not a win32 error code, so this isn't ERROR_ARENA_TRASHED. This test case is entirely single-threaded, so it's not a race condition. The mutex-lock isn't really involved. It seems like gdiplus does not account for GdipImageRotateFlip being called while a bitmap is bits-locked. I would guess that RotateFlip changes the location of the image data, invalidating the state that UnlockBits needs to function correctly. What "should" happen in this situation is probably that GdipImageRotateFlip fails with WrongState, but it seems Windows doesn't do that. The patches here bring us closer to the (broken) Windows behavior, although I'm really not sure how Wine will end up handling this situation in practice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1003#note_12125

1 0

[PATCH v6 0/3] MR1164: Draft: gdiplus: add initial CompoundLine support to fix application crash
by Bartosz Kosiorek (＠gang65) 25 Oct '22

25 Oct '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52196 -- v6: gdiplus: add GdipGetPenCompoundArray implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/1164

4 5

Re: [PATCH v4 0/3] MR1003: gdiplus: Use atomic write for releasing GpImage lock.
by Zebediah Figura (＠zfigura) 25 Oct '22

25 Oct '22

On Sun Oct 23 20:06:50 2022 +0000, Esme Povirk wrote: > I think that behavior is strange enough that we shouldn't worry about > it, at least not until we see a real app doing this. Thank you for checking. That behaviour sounds an awful lot like gdiplus isn't thread-safe after all. E.g. error 7 is ERROR_ARENA_TRASHED. Should this code really have a lock at all? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1003#note_12119

1 0

[PATCH v5 0/3] MR1164: Draft: gdiplus: add initial CompoundLine support to fix application crash
by Bartosz Kosiorek (＠gang65) 25 Oct '22

25 Oct '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52196 -- v5: gdiplus: add GdipGetPenCompoundArray implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/1164

3 4

[PATCH v3 0/3] MR1164: Draft: gdiplus: add initial CompoundLine support to fix application crash
by Bartosz Kosiorek (＠gang65) 25 Oct '22

25 Oct '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52196 -- v3: gdiplus: add GdipGetPenCompoundArray implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/1164

3 4

[PATCH v5 0/115] MR955: Draft: Release 7.0.1.
by Michael Stefaniuc (＠mstefani) 25 Oct '22

25 Oct '22

This is wine-7.0.1-rc1, so not ready yet to merge. -- v5: Release 7.0.1. gitlab: Import the gitlab CI from the master branch (devel tree) winetest: Don't require an email if we have a URL. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/955

1 0

[PATCH v2 0/1] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Gabriel Ivăncescu (＠insn) 25 Oct '22

25 Oct '22

When we are clipping (due to fullscreen), certain operations are bugged (such as creating another window on top, grabbing the window during a size-move operation, changing mouse capture, etc) so we must temporarily unclip first. Seems unclipping it temporarily during such operation is enough to fix this. This probably wasn't very obvious in practice because most times "fullscreen" means a single non-resizeable window with no menus and so on (e.g. fullscreen games), but that's not always the case. -- v2: winex11.drv: Correctly handle clipping for fullscreen windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

3 2

Re: [PATCH v3 0/6] MR1150: uiautomationcore: Implement UiaGetUpdatedCache. - approved
by Alexandre Julliard (＠julliard) 25 Oct '22

25 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1150

1 0

Re: [PATCH v2 0/4] MR1163: mshtml: Last HTMLDocumentNode / HTMLDocumentObj split. - approved
by Alexandre Julliard (＠julliard) 25 Oct '22

25 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1163

1 0

Re: [PATCH v9 0/1] MR363: user32/tests: Test for window exposure behaviours. - approved
by Alexandre Julliard (＠julliard) 25 Oct '22

25 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/363

1 0

Re: [PATCH v3 0/1] MR1146: Update Wine Mono to 7.4.0. - approved
by Alexandre Julliard (＠julliard) 25 Oct '22

25 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1146

1 0

Re: [PATCH v2 0/2] MR1151: ntdll: Add some already implemented security descriptor exports. - approved
by Alexandre Julliard (＠julliard) 25 Oct '22

25 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1151

1 0

Re: [PATCH v2 0/5] MR1154: tools: Use ARRAY_SIZE instead of open coding it. - approved
by Alexandre Julliard (＠julliard) 25 Oct '22

25 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1154

1 0

Re: [PATCH v2 0/6] MR1155: misc Use ARRAY_SIZE instead of open coding it. - approved
by Alexandre Julliard (＠julliard) 25 Oct '22

25 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1155

1 0

Re: [PATCH v2 0/1] MR1160: d2d1: Test device context type in BindDC(). - approved
by Alexandre Julliard (＠julliard) 25 Oct '22

25 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1160

1 0

Re: [PATCH v2 0/1] MR1115: win32u: Write display modes to registry as binary blobs. - approved
by Alexandre Julliard (＠julliard) 25 Oct '22

25 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1115

1 0

Re: [PATCH v3 0/6] MR35: vkd3d-shader/hlsl: Support complex implicit casts, complex explicit casts and complex broadcasts. (PART 2/3 v2) - approved
by Alexandre Julliard (＠julliard) 25 Oct '22

25 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/35

1 0

Re: [PATCH v2 0/1] MR39: vkd3d-common: Add a Windows implementation of vkd3d_set_thread_name(). - approved
by Alexandre Julliard (＠julliard) 25 Oct '22

25 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/39

1 0

[PATCH v4 0/114] MR955: Draft: Release 7.0.1.
by Michael Stefaniuc (＠mstefani) 25 Oct '22

25 Oct '22

This is wine-7.0.1-rc1, so not ready yet to merge. -- v4: Release 7.0.1. gitlab: Import the gitlab CI from the master branch (devel tree) makefiles: Add install-test target to install winetest.exe. makedep: Make the handling of install rules more generic. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/955

1 0

[PATCH v2 0/6] MR1150: uiautomationcore: Implement UiaGetUpdatedCache.
by Connor McAdams (＠cmcadams) 25 Oct '22

25 Oct '22

Implement UiaGetUpdatedCache, as well as some UI Automation ConditionTypes. -- v2: uiautomationcore: Add support for ConditionType_Not conditions. uiautomationcore/tests: Add ConditionType_Property tests. uiautomationcore/tests: Add tests for boolean UIA ConditionTypes. uiautomationcore: Add basic UiaCondition support to UiaGetUpdatedCache. uiautomationcore: Implement UiaGetUpdatedCache. uiautomationcore: Add UiaGetUpdatedCache stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1150

3 8

[PATCH 0/4] MR1163: mshtml: Last HTMLDocumentNode / HTMLDocumentObj split.
by Gabriel Ivăncescu (＠insn) 25 Oct '22

25 Oct '22

This moves the last interface out (IDispatchEx) and gets rid of the remaining fields and the HTMLDocument structure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1163

3 5

[PATCH 0/1] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Gabriel Ivăncescu (＠insn) 25 Oct '22

25 Oct '22

When we are clipping (due to fullscreen), certain operations are bugged (such as creating another window on top, grabbing the window during a size-move operation, changing mouse capture, etc) so we must temporarily unclip first. Seems unclipping it temporarily during such operation is enough to fix this. This probably wasn't very obvious in practice because most times "fullscreen" means a single non-resizeable window with no menus and so on (e.g. fullscreen games), but that's not always the case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

3 4

[PATCH v4 0/4] MR1159: msvcrt: add implementation for localized functions
by Bartosz Kosiorek (＠gang65) 25 Oct '22

25 Oct '22

-- v4: msvcrt: fix error handling for strcpy_s msvcrt: fix error handling for strcat_s msvcrt: Add _mbsinc_l implementation. msvcrt: Add _ismbcsymbol_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1159

2 6

[PATCH 0/4] MR1157: win32u: Move DisplayConfigGetDeviceInfo from user32 and implement DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_NAME.
by Paul Gofman (＠gofman) 25 Oct '22

25 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1157

5 9

[PATCH v2 0/3] MR1164: Draft: gdiplus: add initial CompoundLine support to fix application crash
by Bartosz Kosiorek (＠gang65) 25 Oct '22

25 Oct '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52196 -- v2: gdiplus: add GdipGetPenCompoundArray implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/1164

3 4

[PATCH v3 0/6] MR1159: msvcrt: add implementation for localized functions
by Bartosz Kosiorek (＠gang65) 25 Oct '22

25 Oct '22

-- v3: msvcrt: fix error handling for strcpy_s msvcrt: fix error handling for strcat_s msvcrt: Add _mbsinc_l implementation. msvcrt: Add _ismbcsymbol_l implementation. msvcrt: fix error handling for _wgetcwd msvcrt: fix error handling for _getcwd https://gitlab.winehq.org/wine/wine/-/merge_requests/1159

4 9

[PATCH v8 0/1] MR363: user32/tests: Test for window exposure behaviours.
by Jinoh Kang (＠iamahuman) 25 Oct '22

25 Oct '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v8: user32/tests: Test for window exposure behaviours. https://gitlab.winehq.org/wine/wine/-/merge_requests/363

2 1

2025

2024

2023

2022

wine-gitlab