- wine-gitlab - winehq.org

[PATCH 0/3] MR1117: winex11.drv: Factor out id and primary adapter lookup.
by Rémi Bernon (＠rbernon) 21 Oct '22

21 Oct '22

Simplifying the code and avoiding the need to call back into win32u to get the primary adapter, for https://gitlab.winehq.org/wine/wine/-/merge_requests/551. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1117

3 7

[PATCH v13 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 21 Oct '22

21 Oct '22

-- v13: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. msvcrt: fix error handling for _mbscmp_l msvcrt: Add _mbclen_l implementation. msvcrt: Add _mbsicmp_l implementation. msvcrt: Add _mbschr_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH v12 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 21 Oct '22

21 Oct '22

-- v12: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. msvcrt: fix error handling for _mbscmp_l msvcrt: Add _mbclen_l implementation. msvcrt: Add _mbsicmp_l implementation. msvcrt: Add _mbschr_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH 0/5] MR1134: ntdll: Use local unwinding reimplementations for Unix libraries on ARM/ARM64
by Martin Storsjö (＠mstorsjo) 21 Oct '22

21 Oct '22

Currently, unwinding the unix libraries (or full ELF builds) requires having libunwind available. When starting up a wine environment, an exception of type `RPC_S_SERVER_UNAVAILABLE` gets thrown - and if libunwind isn't available, this breaks the startup. Thus, currently on ARM/ARM64, libunwind is essentially mandatory. Additionally, at least on ARM, libunwind seems brittle (commits in latest git master breaks the unwinding use cases in Wine, see e.g. https://github.com/libunwind/libunwind/pull/203#issuecomment-984126066. This MR tries to resolve all of this, by including the preexisting DWARF parser from x86_64 in the aarch64 version too. This bit was mostly quite straightforward. For ARM, libunwind has currently relied on DWARF debug info in the `.debug_frame` section, since Linux on ARM doesn't use DWARF for runtime unwinding. This MR adds ARM EHABI unwind opcodes where necessary, and adds a local reimplementation of an ARM EHABI/EXIDX/EXTBL unwinder, similar to the DWARF one. With these changes, unwinding on both ARM and ARM64 seems to work fine, even without libunwind. See the individual commit messages for more commentary on the decisions taken so far (I've tried to write up all relevant considerations there - it's a fair amount of commentery). A couple open questions: - So far, the shared DWARF code was put in a header, `dwarf.h`. Do you want to make this a proper standalone `.c` file too? - I wrote the ARM EHABI unwind code mostly with `stdint.h` types like `uint32_t`(as it's in the ntdll/unix directory anyway), but I can rewrite it with `DWORD` or similar if that's preferred. - The ARM EHABI opcodes are enabled for `defined(__arm__) && defined(__ELF__) && defined(__GNUC__) && !defined(__SEH__) && !defined(__ARM_DWARF_EH__)` - there's no define to check for for knowing it's used and enabled, but it has to be implicitly assumed if no other other unwind mechanism is signaled. - The `dl_iterate_phdr` function, used for finding the EXIDX section for locating ARM EHABI unwind info, is used within `#ifdef linux`. It might be available on other OSes too (like FreeBSD etc). Or should I go ahead and add a configure check for it? CC @julliard @rbernon @AndreRH -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1134

3 7

[PATCH 0/1] MR1128: msvcrt: Display message box in abort() in debug CRT only.
by Paul Gofman (＠gofman) 21 Oct '22

21 Oct '22

As far as my testing goes, the message box is never shown on Windows when abort() is called with retail runtime is used, regardless of error mode and abort behaviour. That is not the case with _assert which still can show a dialog even in release mode. It happens rather often that an app meets the error condition during the process exit and that goes silent on Windows while we display the abort dialog on app's exit. The test program below shows that (and the same behaviour is, e. g., with ucrtbase vs ucrtbased). ``` #include <windows.h> #include <stdio.h> #include <stdlib.h> void CDECL _set_app_type(int app_type); #define D(name) static typeof(name) *p_##name #define L(name) p_##name = (void *)GetProcAddress(hdll, #name); if (!p_##name) printf("NULL %s.\n", #name) D(abort); D(_set_app_type); D(_set_abort_behavior); D(_set_error_mode); int main(int argc, char *argv[]) { HMODULE hdll = LoadLibraryA("msvcrt.dll"); printf("hdll %p.\n", hdll); L(_set_app_type); if (!p__set_app_type) if (!(p__set_app_type = (void *)GetProcAddress(hdll, "__set_app_type"))) printf("NULL p__set_app_type.\n"); L(abort); L(_set_abort_behavior); L(_set_error_mode); p__set_app_type(2); if (p__set_abort_behavior) p__set_abort_behavior(_WRITE_ABORT_MSG, _WRITE_ABORT_MSG); p__set_error_mode(_OUT_TO_MSGBOX); p_abort(); } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1128

5 5

Re: [PATCH v9 0/1] MR1065: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64)
by Martin Storsjö (＠mstorsjo) 21 Oct '22

21 Oct '22

On Fri Oct 21 09:44:38 2022 +0000, Rémi Bernon wrote: > I suggested to do that so we can use these tokens in the macros, which > need to stringify their value for the `.cfi_escape` strings. Oh, I see - thanks, that makes sense. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1065#note_11683

1 0

[PATCH v11 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 21 Oct '22

21 Oct '22

-- v11: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. msvcrt: fix error handling for _mbscmp_l msvcrt: Add _mbclen_l implementation. msvcrt: Add _mbsicmp_l implementation. msvcrt: Add _mbschr_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

4 12

Re: [PATCH v9 0/1] MR1065: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64)
by Rémi Bernon (＠rbernon) 21 Oct '22

21 Oct '22

On Fri Oct 21 09:29:30 2022 +0000, Martin Storsjö wrote: > Out of curiosity - was there any specific reason for changing these > enums into defines (or was this maybe an artifact from how this patch > evolved from earlier forms)? I suggested to do that so we can use these tokens in the macros, which need to stringify their value for the `.cfi_escape` strings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1065#note_11674

1 0

Re: [PATCH v9 0/1] MR1065: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64)
by Martin Storsjö (＠mstorsjo) 21 Oct '22

21 Oct '22

Martin Storsjö (@mstorsjo) commented about dlls/ntdll/unix/signal_x86_64.c: > - DW_OP_xderef_size = 0x95, > - DW_OP_nop = 0x96, > - DW_OP_push_object_address = 0x97, > - DW_OP_call2 = 0x98, > - DW_OP_call4 = 0x99, > - DW_OP_call_ref = 0x9a, > - DW_OP_form_tls_address = 0x9b, > - DW_OP_call_frame_cfa = 0x9c, > - DW_OP_bit_piece = 0x9d, > - DW_OP_lo_user = 0xe0, > - DW_OP_hi_user = 0xff, > - DW_OP_GNU_push_tls_address = 0xe0, > - DW_OP_GNU_uninit = 0xf0, > - DW_OP_GNU_encoded_addr = 0xf1, > -}; > +#define DW_CFA_advance_loc 0x40 Out of curiosity - was there any specific reason for changing these enums into defines (or was this maybe an artifact from how this patch evolved from earlier forms)? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1065#note_11673

1 0

[PATCH 0/2] MR1133: Get rid of home grown allocator in DbgHelp.
by eric pouech (＠epo) 21 Oct '22

21 Oct '22

Replace DbgHelp's internal memory allocator with heap functions: - slight improvement in speed (~ 1 to 2 %) - ability to reallocate chunks -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1133

3 3

Re: [PATCH v2 0/5] MR1126: Spelling and trailing linefeed fixes.
by Jan Sikorski (＠jsikorski) 21 Oct '22

21 Oct '22

Jan Sikorski (@jsikorski) commented about dlls/dbghelp/dwarf.c: > } > > /* Dwarf tends to keep the structure of the C/C++ program, and emits DW_TAG_lexical_block > - * for every block in source program. > + * for every block the in source program. in the ;) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1126#note_11664

1 0

Re: [PATCH v2 0/1] MR1114: ntdll/tests: Force alignment of output structures.
by eric pouech (＠epo) 21 Oct '22

21 Oct '22

On Thu Oct 20 17:51:23 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 10/20/22 03:54, Eric Pouech wrote: > > From: Eric Pouech <eric.pouech(a)gmail.com> > > > > Some Windows version expect output to be aligned on 4 bytes. > > > > Notes (from i386 and x86_64 tests): > > - MSVC and Mingw/gcc don't layout the two variables (sdki, sdki_ex) > > the same way. > > - MSVC aligns each variable on 4-byte boundary, > > - MingW/GCC stores them in a 8-byte chunk, but starting from the > > end of the buffer: hence none of them is on a 4-byte boundary. > > > > So, fixing the alignment of variables is not sufficient to > > workaround the compilers' discrepancy on all source code. > > > > I didn't find a generic way to align on 4 bytes structures of size > > smaller than 4 bytes (apart from adding the DECLSPEC_ALIGN to > > each of the offending structures, likely not that many though). > > Ideas welcomed. > Should we put those structs in pshpack4/poppack in the header? (They > aren't defined anywhere publicly on Windows, so we can't compare there.) > ``` from the testbot results, it seems that only W8 and early versions of W10 return errors on pointers not aligned on 4-byte; newer versions of W10 happily handle calls with unaligned pointers so I considered that the "default" is to support non aligned access, but this requires adapting the tests to workaround limitations (not to say bug) in W8/early W10 versions rather than to put it inside the structure declaration -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1114#note_11659

1 0

[PATCH v2 0/1] MR14: include: Add missing types in vkd3d_d3d12.idl.
by Biswapriyo Nath (＠Biswa96) 21 Oct '22

21 Oct '22

-- v2: include: Add missing types in vkd3d_d3d12.idl. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/14

4 7

[PATCH v10 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 21 Oct '22

21 Oct '22

-- v10: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH v9 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 21 Oct '22

21 Oct '22

-- v9: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH v4 0/7] MR871: ntdll: Fill the IOSB only inside the if (alerted) block in multiple functions.
by Zebediah Figura (＠zfigura) 21 Oct '22

21 Oct '22

-- v4: ntdll: Fill the IOSB in sock_transmit() only inside the "if (alerted)" block. ntdll: Combine the "if (alerted)" blocks in sock_send(). ntdll: Fill the IOSB in sock_send() only inside the "if (alerted)" block. ntdll: Combine the "if (alerted)" blocks in sock_recv(). ntdll: Fill the IOSB in sock_recv() only inside the "if (alerted)" block. ntdll: The async handle passed to set_async_direct_result() cannot be NULL. ws2_32/tests: Add more tests for iosb contents while a recv is pending. https://gitlab.winehq.org/wine/wine/-/merge_requests/871

3 8

Re: [PATCH v3 0/1] MR1002: win32u: Fix data race in NtUserGetProcessDpiAwarenessContext. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1002

1 0

Re: [PATCH v2 0/1] MR996: ddraw/tests: Mark tests failing randomly on Windows as flaky. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/996

1 0

Re: [PATCH v3 0/1] MR1095: xinput1_3: Set thread name for hid_update_thread_proc. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1095

1 0

Re: [PATCH v2 0/5] MR1126: Spelling and trailing linefeed fixes. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1126

1 0

Re: [PATCH v2 0/1] MR1112: comctl32/tests: Use a toolbar with TBSTYLE_FLAT in toolbar visual tests. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1112

1 0

Re: [PATCH v2 0/1] MR1114: ntdll/tests: Force alignment of output structures. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1114

1 0

Re: [PATCH v3 0/1] MR1123: winetest: Let the get_subtests() caller report errors. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1123

1 0

Re: [PATCH v3 0/2] MR1113: include: Add _putenv_s. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1113

1 0

Re: [PATCH v2 0/1] MR1127: wintrust: Add a trailing linefeed to an ERR() message. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1127

1 0

Re: [PATCH v2 0/1] MR1124: oleaut32/tests: Fix test failing on UTF-8 locale. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1124

1 0

Re: [PATCH v3 0/1] MR1096: mmdevapi: Set the name of internal threads. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1096

1 0

Re: [PATCH v4 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1089

1 0

Re: [PATCH v2 0/3] MR1118: tests: Add dummy flaky test count. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1118

1 0

Re: [PATCH v9 0/1] MR1065: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64) - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1065

1 0

Re: [PATCH v8 0/1] MR839: ntoskrnl: Use LoadLibraryW for MmGetSystemRoutineAddress - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/839

1 0

Re: [PATCH v8 0/2] MR1016: ntoskrnl.exe: Implement IoCreateNotificationEvent - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1016

1 0

[PATCH v7 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 20 Oct '22

20 Oct '22

-- v7: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH v5 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 20 Oct '22

20 Oct '22

-- v5: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 8

[PATCH 0/1] MR1127: wintrust: Add a trailing linefeed to an ERR() message.
by Francois Gouget (＠fgouget) 20 Oct '22

20 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1127

3 2

[PATCH 0/5] MR1105: comctl32: preparation for HPROPSHEETPAGE structure layout changes
by Piotr Caban (＠piotr) 20 Oct '22

20 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1105

5 8

[PATCH 0/7] MR1125: mshtml: More HTMLDocumentNode / HTMLDocumentObj splitting.
by Gabriel Ivăncescu (＠insn) 20 Oct '22

20 Oct '22

This should move all of the remaining interfaces out of basedoc, except for IDispatchEx (and some fields will still remain); those will be for next MR. Because all of the remaining interfaces are in the `htmldoc.c` file, and they typically tend to just forward to the HTMLDocumentNode, I'm using some macros inspired by the HTMLWINDOW7_ONEVENT_PROPERTY_\* in `htmlwindow.c` to reduce duplication. The ones that are exceptions are implemented normally without macros. The first commit converts all of the non-IHTMLDocument\* interfaces because most of the methods are FIXMEs/unimplemented, so splitting it up isn't worth it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1125

4 9

[PATCH 0/1] MR996: ddraw/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 20 Oct '22

20 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/996

5 4

[PATCH v2 0/1] MR1002: win32u: Fix data race in NtUserGetProcessDpiAwarenessContext.
by Jinoh Kang (＠iamahuman) 20 Oct '22

20 Oct '22

-- v2: win32u: Fix data race in NtUserGetProcessDpiAwarenessContext. https://gitlab.winehq.org/wine/wine/-/merge_requests/1002

4 3

[PATCH 0/5] MR1126: Spelling and trailing linefeed fixes.
by Francois Gouget (＠fgouget) 20 Oct '22

20 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1126

3 6

[PATCH v2 0/1] MR1096: mmdevapi: Set the name of internal threads.
by Brendan Shanks (＠bshanks) 20 Oct '22

20 Oct '22

-- v2: mmdevapi: Set the name of internal threads. https://gitlab.winehq.org/wine/wine/-/merge_requests/1096

4 3

[PATCH 0/4] MR35: vkd3d-shader/hlsl: Support complex implicit casts, complex explicit casts and complex broadcasts. (PART 2/3 v2)
by Francisco Casas (＠fcasas) 20 Oct '22

20 Oct '22

Second version of !33, taking Zeb's suggestions. The refactoring allowed to encompass all remaining features of the patch series in these 4 patches. The remaining patches (PART 3/3) just contain additional tests: https://gitlab.winehq.org/fcasas/vkd3d/-/commits/complex_broadcasts_4/ -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/35

5 10

[PATCH v3 0/5] MR741: Draft: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) 20 Oct '22

20 Oct '22

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.or… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is used on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. On non-x86 Linux <= 4.2 and on other platforms the fallback path using APCs is used. -- v3: ntdll: Add thread_get_register_pointer_values-based fast path for NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based fast path to NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based fast path for NtFlushProcessWriteBuffers. ntdll: Make server_select a memory barrier. ntdll: Implement NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

5 13

[PATCH 0/1] MR1114: ntdll/tests: Force alignment of output structures.
by eric pouech (＠epo) 20 Oct '22

20 Oct '22

Some Windows version expect output to be aligned on 4 bytes. Notes (from i386 and x86_64 tests): - MSVC and Mingw/gcc don't layout the two variables (sdki, sdki_ex) the same way. - MSVC aligns each variable on 4-byte boundary, - MingW/GCC stores them in a 8-byte chunk, but starting from the end of the buffer: hence none of them is on a 4-byte boundary. So, fixing the alignment of variables is not sufficient to workaround the compilers' discrepancy on all source code. I didn't find a generic way to align on 4 bytes structures of size smaller than 4 bytes (apart from adding the DECLSPEC_ALIGN to each of the offending structures, likely not that many though). Ideas welcomed. Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=53684 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1114

3 2

[PATCH v2 0/2] MR1113: include: Add _putenv_s.
by Alex Henrie (＠alexhenrie) 20 Oct '22

20 Oct '22

Needed to compile Tera Term. -- v2: include: Add _putenv_s. msvcrt: Change return type of _putenv_s to errno_t. https://gitlab.winehq.org/wine/wine/-/merge_requests/1113

4 6

Re: [PATCH v2 0/1] MR1095: xinput1_3: Set thread name for hid_update_thread_proc. - approved
by Rémi Bernon (＠rbernon) 20 Oct '22

20 Oct '22

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1095

1 0

[PATCH v4 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 20 Oct '22

20 Oct '22

-- v4: msvcrt: Add _ismbslead_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

4 9

[PATCH 0/1] MR1112: comctl32/tests: Use a toolbar with TBSTYLE_FLAT in toolbar visual tests.
by Zhiyi Zhang (＠zhiyi) 20 Oct '22

20 Oct '22

Fix a test failure when theming is off. A toolbar without TBSTYLE_FLAT will fill its checked button background rectangle when theming is inactive, overwriting the checked pattern required for the test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1112

3 2

[PATCH v6 0/1] MR363: user32/tests: Test for window exposure behaviours.
by Jinoh Kang (＠iamahuman) 20 Oct '22

20 Oct '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v6: user32/tests: Test for window exposure behaviours. https://gitlab.winehq.org/wine/wine/-/merge_requests/363

4 6

[PATCH v2 0/1] MR1123: winetest: Let the get_subtests() caller report errors.
by Francois Gouget (＠fgouget) 20 Oct '22

20 Oct '22

-- v2: winetest: Let the get_subtests() caller report errors. https://gitlab.winehq.org/wine/wine/-/merge_requests/1123

3 3

[PATCH 0/2] MR1119: Add FSCTL_GET_REPARSE_POINT semi-stub and tests
by Joel Holdsworth (＠jhol) 20 Oct '22

20 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39627 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53439 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1119

3 4

[PATCH 0/1] MR1123: winetest: Let the get_subtests() caller report errors.
by Francois Gouget (＠fgouget) 20 Oct '22

20 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1123

3 2

[PATCH v3 0/6] MR1120: Draft: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 20 Oct '22

20 Oct '22

-- v3: msvcrt: Add _ismbslead_l implementation. msvcrt: Add _ismbstrail_l implementation. msvcrt: fix error handling for _mbscmp_l msvcrt: Add _mbclen_l implementation. msvcrt: Add _mbsicmp_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

Re: [PATCH v2 0/5] MR1078: mshtml: More HTMLDocumentNode / HTMLDocumentObj splitting.
by Gabriel Ivăncescu (＠insn) 20 Oct '22

20 Oct '22

Wait, I messed up. It modified the existing (merged) MR instead of creating a new one since I used same branch name by accident. Sorry about this. (New MR is !1125) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1078#note_11549

1 0

[PATCH 0/1] MR1096: mmdevapi: Set the name of internal threads.
by Brendan Shanks (＠bshanks) 20 Oct '22

20 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1096

4 4

[PATCH v2 0/6] MR1120: Draft: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 20 Oct '22

20 Oct '22

-- v2: msvcrt: Add _ismbslead_l implementation. msvcrt: Add _ismbstrail_l implementation. msvcrt: fix error handling for _mbscmp_l msvcrt: Add _mbclen_l implementation. msvcrt: Add _mbsicmp_l implementation. msvcrt: Add _mbschr_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH 0/1] MR1124: oleaut32/tests: Fix test failing on UTF-8 locale.
by eric pouech (＠epo) 20 Oct '22

20 Oct '22

Method decriptor's strings are internally stored in ANSI, and potentially converted from Unicode using current code page. Test was expecting loss in Unicode to ANSI conversion. Adapt test to also support loss-less conversion (that's the case when code page is UTF-8). Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=52873 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1124

2 1

[PATCH v4 0/12] MR966: server: Some fixes for the shared Software\Classes registry.
by Sven Baars (＠sbaars) 20 Oct '22

20 Oct '22

This seems to be more correct than what we previously had with fewer lines of code, so I like that. I still don't really like the extra flag I had to add for Nt{Create,Open}Key, but I couldn't find a way to make things work without it. I also checked that Windows doesn't use a similar flag (by iterating over all bit masks). -- v4: wine.inf: Put the Clients key in the right place. advapi32/tests: Copy Software\Classes tests from ntdll. ntdll/tests: Refactor the Software\Classes tests. ntdll/tests: Factor out the NtEnumerateKey() tests. kernelbase: Remove special Wow64 handling for HKEY_CLASSES_ROOT. kernelbase: Remove special Wow6432Node handling from RegCreateKeyEx(). kernelbase: Remove special Wow6432Node handling from RegOpenKeyEx(). server: Don't return the actual 32-bit Software\Classes key. ntdll/tests: Add some some Software\Classes query and enumerate tests. ntdll/tests: Test that NtCreateKeyEx() also recursively obtains the Wow6432Node parent. server: Recursively obtain the Wow6432Node parent. ntdll/tests: Add some Software\Classes subkey tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/966

4 16

[PATCH 0/6] MR1120: Draft: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 20 Oct '22

20 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

Re: [PATCH v2 0/1] MR1107: kernelbase: Avoid memory leaks in GetConsoleTitleW()
by Hugh McMaster (＠hmc) 20 Oct '22

20 Oct '22

On Thu Oct 20 13:10:51 2022 +0000, eric pouech wrote: > Hi Hugh, > IMO, this could be written without using 'goto' > for example > ``` > if (console_ioctl(...) && size >= sizeof(...)) > { > } > else size = 0; > HeapFree(...); > return size; > ``` Sure. That’s the merged version, which I think @julliard modified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1107#note_11523

1 0

[PATCH v8 0/1] MR1065: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64)
by Florian Kübler (＠florian-kuebler) 20 Oct '22

20 Oct '22

This change is adding DWARF (CFI) unwind information to the hand-written assembly of the `__wine_syscall_dispatcher` function. This enables unwinding through the dispatcher from the Linux stack into (and through) the Windows stack. The general idea is that the `syscall_frame` struct contains the content of the callee-save registers before the function call (in particular the stack pointer and the return address). At any point of the execution, we have a pointer into the `syscall_frame` in $rcx, $rbp or $rsp. For the CFI codes the general idea is that we are defining the computations of the callee-save registers based on the `syscall_frame` using DWARF’s `breg` instruction, rather than relative to CFA. This change adds a bunch of convenience macros, to (hopefully) improve readability of the CFI instructions. Note: Those change was used with great success for unwinding through the dispatcher using a modified LLDB shown in the [“how-wine-works-101”](https://werat.dev/blog/how-wine-works-101/) blog post as well as for in the [Orbit profiler](https://github.com/google/orbit), that has mixed-callstack unwinding support. Test: Inspect callstacks reported by the Orbit profiler while running some Windows targets using the modified wine, as well as verify debugging reports correct callstacks when stepping with our modified LLDB through the dispatcher itself (so that we are able to unwind through the dispatcher at any instruction). -- v8: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64) https://gitlab.winehq.org/wine/wine/-/merge_requests/1065

4 8

[PATCH 0/1] MR1055: gdi32: Don't stackoverflow if substitute doesn't change anything
by Fabian Maurer (＠DarkShadow44) 20 Oct '22

20 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53787 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1055

5 13

[PATCH v3 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei.
by Ziqing Hui (＠zhui) 20 Oct '22

20 Oct '22

More font links are added to avoid issues related to missing font links. Data comes from: https://testbot.winehq.org/JobDetails.pl?Key=125079 Test program in the tests above: [font_link_reg.c](/uploads/9d4a722450f0dd88344a2b098770aaa0/font_link_reg.c) -- v3: win32u: Add font links for MS Gothic. win32u: Add font links for MingLiU. win32u: Add font links for Microsoft JhengHei. win32u: Add locale_dependent member to struct system_link_reg. https://gitlab.winehq.org/wine/wine/-/merge_requests/1089

4 6

[PATCH 0/1] MR1113: include: Add _putenv_s.
by Alex Henrie (＠alexhenrie) 20 Oct '22

20 Oct '22

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1113

4 3

[PATCH 0/3] MR1118: tests: Add dummy flaky test count.
by Rémi Bernon (＠rbernon) 20 Oct '22

20 Oct '22

Fixes "Use of uninitialized value $Flaky" message in testbot reports. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1118

2 3

[PATCH 0/1] MR1092: nls: Explicitly specify locales that use native digits.
by Nikolay Sivov (＠nsivov) 20 Oct '22

20 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53770 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1092

4 4

Re: [PATCH v2 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei.
by Huw Davies (＠huw) 20 Oct '22

20 Oct '22

Huw Davies (@huw) commented about dlls/win32u/font.c: > + len = link_reg->link_jp_len; > + break; > + case 936: > + link = link_reg->link_sc; > + len = link_reg->link_sc_len; > + break; > + case 949: > + link = link_reg->link_kr; > + len = link_reg->link_kr_len; > + break; > + case 950: > + link = link_reg->link_tc; > + len = link_reg->link_tc_len; > + break; > + default: > + break; You should be able to remove the `default` label. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1089#note_11470

1 0

Re: [PATCH v2 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei.
by Huw Davies (＠huw) 20 Oct '22

20 Oct '22

Huw Davies (@huw) commented about dlls/win32u/font.c: > { > const struct system_link_reg *link_reg = &default_system_link[i]; > > - switch (ansi_cp.CodePage) > + link = link_reg->link_non_cjk; > + len = link_reg->link_non_cjk_len; > + > + if ((link_reg->locale_related)) You shouldn't need the inner brackets. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1089#note_11469

1 0

Re: [PATCH v2 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei.
by Huw Davies (＠huw) 20 Oct '22

20 Oct '22

Huw Davies (@huw) commented about dlls/win32u/font.c: > static const struct system_link_reg > { > const WCHAR *font_name; > + BOOL locale_related; How about `locale_dependent` ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1089#note_11468

1 0

[PATCH 0/1] MR1095: xinput1_3: Set thread name for hid_update_thread_proc.
by Brendan Shanks (＠bshanks) 20 Oct '22

20 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1095

4 3

[PATCH 0/4] MR1103: shell32: Remove strdupW function.
by Alex Henrie (＠alexhenrie) 20 Oct '22

20 Oct '22

I was really confused about whether strdupW or wcsdup is preferred in shell32. Since strdupW is deprecated, let's just get rid of it so that no one else has to wonder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1103

4 6

[PATCH v4 0/6] MR1007: l3codecx.ax/tests: Add some tests for MPEG layer-3 decoder.
by Anton Baskanov (＠baskanov) 20 Oct '22

20 Oct '22

Development branch: https://gitlab.winehq.org/baskanov/wine/-/commits/l3codecx/ v2: Removed l3codecx.ax stub dll. v3: Rebased. v4: Moved the tests to quartz/tests. -- v4: quartz/tests: Add tests for querying MPEG layer-3 decoder pin info. quartz/tests: Add tests for IBaseFilter_FindPin() on MPEG layer-3 decoder. quartz/tests: Add tests for IBaseFilter_EnumPins() on MPEG layer-3 decoder. quartz/tests: Test MPEG layer-3 decoder unconnected filter state. quartz/tests: Add tests for MPEG layer-3 decoder aggregation. quartz/tests: Add tests for MPEG layer-3 decoder interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/1007

3 8

[PATCH v7 0/1] MR839: ntoskrnl: Use LoadLibraryW for MmGetSystemRoutineAddress
by Etaash Mathamsetty (＠etaash.mathamsetty) 20 Oct '22

20 Oct '22

MmGetSystemRoutineAddress wasn't finding some functions in ntoskrnl and hal.dll, this patch fixes it required by mrac anti cheat (and various other drivers) -- v7: ntoskrnl.exe: use LoadLibraryW for MmGetSystemRoutineAddress. https://gitlab.winehq.org/wine/wine/-/merge_requests/839

3 2

[PATCH 0/3] MR33: vkd3d-shader/hlsl: Support complex implicit casts, complex explicit casts and complex broadcasts. (PART 2/3)
by Francisco Casas (＠fcasas) 20 Oct '22

20 Oct '22

Continuation of the patch series to support: * Complex broadcasts. * Complex implicit casts between component-wise equal types. * Complex explicit casts between component-wise compatible types. By Zeb's suggestion, I added tests for explicit casts between structs and vectors and arrays and vectors. This was helpful for catching special edge cases. I realized that the natural thing to do would be to also include tests for explicit casts between matrices and structs, matrices and arrays, and matrices and vectors. This made the patch series larger so I split it again (that's why this is PART 2/3). Following patches in: https://gitlab.winehq.org/fcasas/vkd3d/-/commits/complex_broadcasts_2/ -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/33

5 10

[PATCH v5 0/1] MR839: ntoskrnl: Use LoadLibraryW for MmGetSystemRoutineAddress
by Etaash Mathamsetty (＠etaash.mathamsetty) 20 Oct '22

20 Oct '22

MmGetSystemRoutineAddress wasn't finding some functions in ntoskrnl and hal.dll, this patch fixes it required by mrac anti cheat (and various other drivers) -- v5: ntoskrnl.exe: Use LoadLibraryW for MmGetSystemRoutineAddress. https://gitlab.winehq.org/wine/wine/-/merge_requests/839

3 2

[PATCH v7 0/2] MR1016: ntoskrnl.exe: Implement IoCreateNotificationEvent
by Etaash Mathamsetty (＠etaash.mathamsetty) 20 Oct '22

20 Oct '22

xigncode3 seems to use it -- v7: ntoskrnl.exe: Fix formatting in IoCreateSyncronizationEvent. ntoskrnl.exe: Implement IoCreateNotificationEvent. https://gitlab.winehq.org/wine/wine/-/merge_requests/1016

3 3

Re: [PATCH v2 0/1] MR1094: winedump: Handle NULL in get_unicode_str. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1094

1 0

Re: [PATCH v3 0/1] MR1102: uuid: Add devguid.h. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1102

1 0

Re: [PATCH v3 0/1] MR1097: ntdll: Fix build on systems without ENODATA - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1097

1 0

Re: [PATCH v2 0/1] MR1107: kernelbase: Avoid memory leaks in GetConsoleTitleW() - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1107

1 0

Re: [PATCH v4 0/1] MR1085: sapi: Implement ISpObjectToken OpenKey - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1085

1 0

Re: [PATCH v2 0/3] MR1091: Support block spreading across multiple address ranges. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1091

1 0

Re: [PATCH v2 0/1] MR1110: dbghelp: Silence some FIXME. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1110

1 0

Re: [PATCH v8 0/9] MR1090: msvcrt: implement missing CRT functions to fix ChessBase 14 crash - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1090

1 0

Re: [PATCH v2 0/5] MR1100: Comctl32 fixes - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1100

1 0

Re: [PATCH v3 0/1] MR1109: po: Update Traditional Chinese translation. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1109

1 0

Re: [PATCH v2 0/1] MR1101: include: Move strto[iu]max(_l) from stdlib.h to inttypes.h. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1101

1 0

Re: [PATCH v2 0/5] MR1105: comctl32: preparation for HPROPSHEETPAGE structure layout changes - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1105

1 0

Re: [PATCH v2 0/1] MR1104: crypt32: Only report Unimplemented decoder when not found in externall dll - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1104

1 0

Re: [PATCH v4 0/1] MR970: wined3d: Do not enforce map access for resources with WINED3D_RESOURCE_ACCESS_CPU. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/970

1 0

Re: [PATCH v2 0/2] MR1099: win32u: Use session BaseNamedObjects for display_device_init mutex. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1099

1 0

Re: [PATCH v2 0/1] MR1097: ntdll: Fix build on systems without ENODATA
by Erich Hoover (＠ehoover) 19 Oct '22

19 Oct '22

Is `ENOATTR` defined? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1097#note_11398

1 0

Re: [PATCH v5 0/2] MR1079: wininet/netprofm: Connectivity improvements. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1079

1 0

Re: [PATCH v2 0/5] MR1078: mshtml: Initial HTMLDocumentNode / HTMLDocumentObj split. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1078

1 0

Re: [PATCH v2 0/6] MR32: Lower modulus operations. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/32

1 0

Re: [PATCH v2 0/2] MR34: Root signature serialiser/deserialiser function pointer typedefs - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/34

1 0

Re: [PATCH v5 0/5] MR30: hlsl: Texture and UAV loads. - approved
by Alexandre Julliard (＠julliard) 19 Oct '22

19 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/30

1 0

[PATCH 0/1] MR1110: dbghelp: Silence some FIXME.
by eric pouech (＠epo) 19 Oct '22

19 Oct '22

In some 32bit modules, MingW/GCC generates in Dwarf debug information, a cfa address to be computed as: deref(register XX + offset) which is too complicated to be expressed through regular DbgHelp APIs. So silence the FIXME, and report a 'too complex' error (instead of 'internal'). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52790 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1110

3 2

[PATCH v3 0/1] MR970: wined3d: Do not enforce map access for resources with WINED3D_RESOURCE_ACCESS_CPU.
by Zebediah Figura (＠zfigura) 19 Oct '22

19 Oct '22

-- v3: wined3d: Do not enforce GL map access for resources with WINED3D_RESOURCE_ACCESS_CPU. https://gitlab.winehq.org/wine/wine/-/merge_requests/970

3 3

[PATCH 0/1] MR1109: po: Update Traditional Chinese translation.
by Chilung Chan (＠eason329) 19 Oct '22

19 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1109

3 2

2025

2024

2023

2022

wine-gitlab