- wine-gitlab - winehq.org

Re: [PATCH v3 0/1] MR1005: ntdll: Fix GetTempPathW() call passing wrong unit for the buffer size
by Davide Beatrici (＠davidebeatrici) 10 Oct '22

10 Oct '22

@julliard Shouldn't the prefix have been `ntdll/tests`, for consistency with the other commits? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1005#note_10219

1 0

[PATCH 0/1] MR994: gdi32/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 10 Oct '22

10 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/994

4 4

[PATCH 0/1] MR1003: gdiplus: Use atomic write for releasing GpImage lock.
by Jinoh Kang (＠iamahuman) 10 Oct '22

10 Oct '22

This fixes data race in ARM/ARM64 platforms, and prevents potential memory access reordering by the compiler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1003

6 13

Re: [PATCH v4 0/6] MR965: jscript/mshtml: Enumeration fixes. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/965

1 0

Re: [PATCH v5 0/4] MR951: ntdll: Add initial support for DOS file attributes (attempt 3) - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/951

1 0

Re: [PATCH v2 0/1] MR1018: conhost: Fix tests on ReadConsole with CONSOLE_READCONSOLE_CONTROL. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1018

1 0

Re: [PATCH v5 0/2] MR930: Add tests for GetConsoleTitle() and return correct title length - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/930

1 0

Re: [PATCH v2 0/1] MR1022: winevulkan: Use host Vulkan structures for private thunks arguments. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1022

1 0

Re: [PATCH v2 0/1] MR1021: include: Fix typos in NIN_BALLOON*. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1021

1 0

Re: [PATCH v2 0/1] MR1020: include: Fix typo in LR_VGACOLOR. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1020

1 0

Re: [PATCH v2 0/3] MR1014: wined3d: fixing a couple of integral types related issues. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1014

1 0

Re: [PATCH v2 0/3] MR987: d3d9/tests: Mark tests failing randomly on Windows as flaky. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/987

1 0

Re: [PATCH v2 0/3] MR1019: shell32: Add Active Desktop stub. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1019

1 0

Re: [PATCH v2 0/4] MR1013: Mostly cleanup - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1013

1 0

Re: [PATCH v3 0/2] MR1017: sapi: Implement ISpObjectToken GetId - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1017

1 0

Re: [PATCH v2 0/1] MR1012: xmllite/writer: properly validate DocType name - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1012

1 0

Re: [PATCH v3 0/1] MR1005: ntdll: Fix GetTempPathW() call passing wrong unit for the buffer size - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1005

1 0

Re: [PATCH v2 0/4] MR963: d3d8: Use a separate draw texture for managed resources. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/963

1 0

Re: [PATCH v2 0/1] MR973: mf: Avoid clearing media session command list while it is running. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/973

1 0

Re: [PATCH v2 0/1] MR1000: wintab32: Fix match_token to match XWayland devices - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1000

1 0

[PATCH 0/40] MR1010: Draft: opengl32: Path towards wow64 support.
by Rémi Bernon (＠rbernon) 10 Oct '22

10 Oct '22

I was watching some random YouTube stream and then heard a voice telling me to do this. This can run wglgears on wow, though there's plenty of missing pieces which I don't have any idea how to fix (like buffer mapping, etc.). Opening it as a draft for now to show the whole thing, if it seems alright I'll send it in batches. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/1010

5 10

Re: [PATCH v2 0/1] MR999: msdasql: Implement IRowsetInfo GetProperties - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/999

1 0

Re: [PATCH v2 0/1] MR998: wow64: Use the right SEH opcode in raise_exception on arm64 - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/998

1 0

Re: [PATCH v2 0/1] MR982: dpnet/tests: Mark tests failing randomly on Windows as flaky. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/982

1 0

Re: [PATCH v7 0/5] MR932: comctl32: propsheet tests - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/932

1 0

[PATCH 0/1] MR984: nsi/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 10 Oct '22

10 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/984

3 3

[PATCH 0/6] MR1025: ntdll: Support memory address requirements in NtAllocateVirtualMemoryEx()
by Paul Gofman (＠gofman) 10 Oct '22

10 Oct '22

Various notes: - LowestStartingAddress is still unsupported; - Patch 5 ("wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent") is fixing existing WOW issue: NtAllocateVirtualMemoryEx() called from wow64 currently does not constraing the allocation to 32 bit address space (wow64_NtAllocateVirtualMemory() passes zero_bits for that). - I initially thought of using a single inter process APC but added a different one due to zero_bits handling which is easier to convert in the target process. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1025

3 10

Re: [PATCH v5 0/5] MR23: Use our compiler to build shaders in demos. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/23

1 0

[PATCH 0/6] MR1008: include: Add wine/dir.h, for internal directory definitions.
by Davide Beatrici (＠davidebeatrici) 10 Oct '22

10 Oct '22

In order to reduce the amount of duplicates across the codebase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1008

4 12

[PATCH 0/3] MR1014: wined3d: fixing a couple of integral types related issues.
by eric pouech (＠epo) 10 Oct '22

10 Oct '22

Fixes inconsistent function (or function pointer) declation and implementation. (favoring non long types). Fixes errouneous format specifier in printf-like function for arguments of type DWORD_PTR (or SIZE_T or equiv). This serie could be a starting point for enabling long type compilation in wined3d. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1014

5 8

[PATCH v2 0/6] MR1007: l3codecx.ax/tests: Add some tests for MPEG layer-3 decoder.
by Anton Baskanov (＠baskanov) 10 Oct '22

10 Oct '22

Development branch: https://gitlab.winehq.org/baskanov/wine/-/commits/l3codecx/ v2: Removed l3codecx.ax stub dll. -- v2: l3codecx.ax/tests: Add tests for querying MPEG layer-3 decoder pin info. l3codecx.ax/tests: Add tests for IBaseFilter_FindPin() on MPEG layer-3 decoder. l3codecx.ax/tests: Add tests for IBaseFilter_EnumPins() on MPEG layer-3 decoder. l3codecx.ax/tests: Test MPEG layer-3 decoder unconnected filter state. l3codecx.ax/tests: Add tests for MPEG layer-3 decoder aggregation. l3codecx.ax/tests: Add tests for MPEG layer-3 decoder interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/1007

3 8

[PATCH 0/2] MR1023: xmllite/writer: Correctly partially duplicate a string
by David Kahurani (＠kahurani) 10 Oct '22

10 Oct '22

Currently, the code seems to copy an extra character than requested and does not terminate the string Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1023

4 6

[PATCH v2 0/1] MR1016: ntoskrnl.exe: Implement IoCreateNotificationEvent
by Etaash Mathamsetty (＠etaash.mathamsetty) 10 Oct '22

10 Oct '22

xigncode3 seems to use it -- v2: ntoskrnl.exe: Implement IoCreateNotificationEvent https://gitlab.winehq.org/wine/wine/-/merge_requests/1016

3 3

[PATCH 0/1] MR1018: conhost: Fix tests on ReadConsole with CONSOLE_READCONSOLE_CONTROL.
by eric pouech (＠epo) 10 Oct '22

10 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52648 The patch should fix the errors around line 1370 in conhost/tests/tty.c, but it doesn't fix other errors around line 1530 and 1550 which are completly unrelated to this change. So failures to be expected on the later. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1018

3 3

[PATCH v4 0/2] MR930: Add tests for GetConsoleTitle() and return correct title length
by Hugh McMaster (＠hmc) 10 Oct '22

10 Oct '22

-- v4: kernelbase: Return full title length from GetConsoleTitle() kernel32/tests: Add tests for GetConsoleTitle() https://gitlab.winehq.org/wine/wine/-/merge_requests/930

5 10

[PATCH 0/1] MR1022: winevulkan: Use host Vulkan structures for private thunks arguments.
by Jacek Caban (＠jacek) 10 Oct '22

10 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1022

2 1

[PATCH 0/1] MR992: imm32/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 10 Oct '22

10 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/992

4 3

[PATCH v2 0/5] MR965: jscript/mshtml: Enumeration fixes.
by Gabriel Ivăncescu (＠insn) 10 Oct '22

10 Oct '22

-- v2: mshtml: Enumerate document elements with name. mshtml: Do not enumerate internal dynamic props. mshtml: Fix enumerating first custom prop after builtins. jscript: Refill the props at end of enumeration in html mode and retry. jscript: Fill the builtin props for enumeration on prototypes as well. https://gitlab.winehq.org/wine/wine/-/merge_requests/965

4 10

[PATCH 0/1] MR1021: include: Fix typos in NIN_BALLOON*.
by Alex Henrie (＠alexhenrie) 10 Oct '22

10 Oct '22

Needed to compile Tera Term. [MinGW](https://sourceforge.net/p/mingw-w64/mingw-w64/ci/457544ce277c6081439… does not have the typos. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1021

2 1

[PATCH 0/1] MR1011: user32: Correctly detect and assign an int resource
by Alistair Leslie-Hughes (＠alesliehughes) 10 Oct '22

10 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53646 Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1011

4 3

[PATCH 0/3] MR956: Return focus window in swapchain desc from IDirect3DSwapChain9_GetPresentParameters() if hDeviceWindow is NULL.
by Paul Gofman (＠gofman) 10 Oct '22

10 Oct '22

PICO park depends on that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/956

5 6

[PATCH 0/1] MR1020: include: Fix typo in LR_VGACOLOR.
by Alex Henrie (＠alexhenrie) 10 Oct '22

10 Oct '22

Needed to compile Tera Term. Interestingly, [MinGW](https://sourceforge.net/p/mingw-w64/mingw-w64/ci/457544ce277c6081439… does not have the typo. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1020

2 1

[PATCH v2 0/5] MR25: vkd3d-shader/hlsl: Implement asuint() and completely move init_node() to hlsl.c.
by Zebediah Figura (＠zfigura) 10 Oct '22

10 Oct '22

-- v2: vkd3d-shader/hlsl: Pass a location pointer to init_node(). vkd3d-shader/hlsl: Use hlsl_new_expr() in add_expr(). vkd3d-shader/hlsl: Write SM4 reinterpret instructions. vkd3d-shader/hlsl: Parse the asuint() intrinsic. tests: Add a test for asuint(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/25

4 7

[PATCH 0/2] MR970: wined3d: Do not enforce map access for resources with WINED3D_RESOURCE_ACCESS_CPU.
by Zebediah Figura (＠zfigura) 10 Oct '22

10 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/970

4 4

[PATCH v3 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 10 Oct '22

10 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46012 Signed-off-by: Patrick Hibbs <hibbsncc1701(a)gmail.com> -- v3: d3dx9/tests: Implement tests for d3dx_effect_SetRawValue(). d3dx9: Implement d3dx_effect_SetRawValue https://gitlab.winehq.org/wine/wine/-/merge_requests/979

3 4

[PATCH 0/1] MR962: wined3d: Use a Wine debug channel for vkd3d debug output.
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/962

4 3

[PATCH v2 0/1] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 10 Oct '22

10 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46012 Signed-off-by: Patrick Hibbs <hibbsncc1701(a)gmail.com> -- v2: d3dx9: Implement d3dx_effect_SetRawValue https://gitlab.winehq.org/wine/wine/-/merge_requests/979

2 1

[PATCH 0/7] MR1007: Add some tests for l3codecx.ax
by Anton Baskanov (＠baskanov) 10 Oct '22

10 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1007

3 8

[PATCH 0/3] MR1019: shell32: Add Active Desktop stub.
by Nikolay Sivov (＠nsivov) 09 Oct '22

09 Oct '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1019

3 4

[PATCH 0/4] MR1013: Mostly cleanup
by eric pouech (＠epo) 09 Oct '22

09 Oct '22

clean up of code: - remove usage of wine_dbgstr_longlong() - remove some FIXME - remove stabs's only stuff clean up of mistake: - partially revert one of previous commits (messed up with the tests) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1013

3 6

[PATCH v2 0/2] MR1017: sapi: Implement ISpObjectToken GetId
by Alistair Leslie-Hughes (＠alesliehughes) 08 Oct '22

08 Oct '22

-- v2: sapi: Implement ISpObjectToken GetId sapi: Store the token id in ISpObjectToken SetId. https://gitlab.winehq.org/wine/wine/-/merge_requests/1017

2 2

[PATCH 0/2] MR1017: sapi: Implement ISpObjectToken GetId
by Alistair Leslie-Hughes (＠alesliehughes) 08 Oct '22

08 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1017

3 3

[PATCH 0/1] MR1016: ntoskrnl.exe: Implement IoCreateNotificationEvent
by Etaash Mathamsetty (＠etaash.mathamsetty) 08 Oct '22

08 Oct '22

xigncode3 seems to use it -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1016

2 1

[PATCH 0/1] MR1012: xmllite/writer: properly validate DocType name
by David Kahurani (＠kahurani) 07 Oct '22

07 Oct '22

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1012

3 2

[PATCH v3 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Alistair Leslie-Hughes (＠alesliehughes) 07 Oct '22

07 Oct '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v3: ntoskrnl.exe: Add FltBuildDefaultSecurityDescriptor test fltmgr.sys: Create import library fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor https://gitlab.winehq.org/wine/wine/-/merge_requests/414

3 4

[PATCH v2 0/1] MR1005: ntdll: fixed size passed to GetTempPathW
by Marcus Meissner (＠msmeissn) 06 Oct '22

06 Oct '22

Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> -- v2: ntdll: Fix GetTempPathW() call passing wrong unit for the buffer size https://gitlab.winehq.org/wine/wine/-/merge_requests/1005

4 4

Re: [PATCH 0/1] MR182: winex11: Use XKB key names to map key codes to scan codes.
by Timo Zuccarello (＠timozuccarello) 06 Oct '22

06 Oct '22

On Thu Oct 6 11:01:58 2022 +0000, Rémi Bernon wrote: > Well, I believe it is not necessary in general when using standard X > server, as I described in > <https://www.winehq.org/pipermail/wine-devel/2020-October/175561.html>, > but that doesn't cover more exotic use cases where the X scancodes > aren't fixed. > Like @julliard replied in that thread, when using VNC X server for > instance the scancodes aren't fixed anymore and we need that logic to > figure them out. The problem, in my opinion, comes from VNC simulating > incorrect scancodes, as it recomputes them from the VKey it received > (the protocol only sends VKey and and it then assumes its client > keyboard layout is US), but I agree that nothing in the X specification > guarantees that the scancodes are fixed and that it makes some sense to > do that kind of detection. > Maybe an acceptable solution would be to make that layout detection > optional, and configurable through a `winecfg` option, so that by > default we'd assume a standard X server with fixed scancodes, and > optionally we'd keep support for layout detection (or the other way > around but I think improving the most common case as a default would be better). I just went through the email thread (I'm still new to navigating pipermail/mailing list archives) and I see the point, although I don't think I can entirely grasp what VNC does. But the way I understand it is that even if we used XKB names for the scan codes as in this MR, those would be messed up just as well when using a VNC X server, as it maps backwards from vkeys to scan codes? In the XKB specification/documentation, "The key name links keys with similar functions or in similar positions on keyboards that report different scan codes", which gets me wondering how Windows actually handles exotic keyboards or rather what is common practice in the drivers for said exotic keyboards. In any case, I agree, I suppose optional layout detection would be the most compatible solution for now at least. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/182#note_10036

1 0

Re: [PATCH 0/1] MR182: winex11: Use XKB key names to map key codes to scan codes.
by Rémi Bernon (＠rbernon) 06 Oct '22

06 Oct '22

On Thu Oct 6 11:01:52 2022 +0000, Timo Zuccarello wrote: > After last day's discussion, I don't think anymore that it's necessary > to use XKB names to map to scancodes. @rbernon says the keycodes are > fixed across keyboard layouts and this seems to be the case for me as > well even with exotic and custom layouts. Rather something about the > keyboard layout detection may be broken and assigns incorrect scancodes. > I'll take another look at this and try to figure something out. Well, I believe it is not necessary in general when using standard X server, as I described in <https://www.winehq.org/pipermail/wine-devel/2020-October/175561.html>, but that doesn't cover more exotic use cases where the X scancodes aren't fixed. Like @julliard replied in that thread, when using VNC X server for instance the scancodes aren't fixed anymore and we need that logic to figure them out. The problem, in my opinion, comes from VNC simulating incorrect scancodes, as it recomputes them from the VKey it received (the protocol only sends VKey and and it then assumes its client keyboard layout is US), but I agree that nothing in the X specification guarantees that the scancodes are fixed and that it makes some sense to do that kind of detection. Maybe an acceptable solution would be to make that layout detection optional, and configurable through a `winecfg` option, so that by default we'd assume a standard X server with fixed scancodes, and optionally we'd keep support for layout detection (or the other way around but I think improving the most common case as a default would be better). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/182#note_10034

1 0

Re: [PATCH 0/1] MR182: winex11: Use XKB key names to map key codes to scan codes.
by Timo Zuccarello (＠timozuccarello) 06 Oct '22

06 Oct '22

After last day's discussion, I don't think anymore that it's necessary to use XKB names to map to scancodes. @rbernon says the keycodes are fixed across keyboard layouts and this seems to be the case for me as well even with exotic and custom layouts. Rather something about the keyboard layout detection may be broken and assigns incorrect scancodes. I'll take another look at this and try to figure something out. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/182#note_10032

1 0

Re: [PATCH 0/1] MR182: winex11: Use XKB key names to map key codes to scan codes. - closed
by Timo Zuccarello (＠timozuccarello) 06 Oct '22

06 Oct '22

This merge request was closed by Timo Zuccarello. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/182

1 0

[PATCH 0/1] MR1005: ntdll: fixed size passed to GetTempPathW
by Marcus Meissner (＠msmeissn) 06 Oct '22

06 Oct '22

Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1005

3 2

[PATCH 0/1] MR1009: winemenubuilder: Skip desktop integration for certain associations.
by Alex Henrie (＠alexhenrie) 06 Oct '22

06 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41275 A version of this patch has been in Wine Staging since March 2020. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1009

2 1

[PATCH 0/3] MR987: d3d9/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 05 Oct '22

05 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/987

4 5

[PATCH 0/2] MR981: dxgi/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 05 Oct '22

05 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/981

3 3

[PATCH 0/4] MR963: d3d8: Use a separate draw texture for managed resources.
by Zebediah Figura (＠zfigura) 05 Oct '22

05 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/963

3 5

[PATCH v5 0/2] MR1004: ntdll: Implement optional relative parameter of RtlDosPathNameToRelativeNtPathName_U_WithStatus
by Skryptonyte (＠Skryptonyte) 05 Oct '22

05 Oct '22

relative optional parameter will now be handled by setting the RelativeName of the relative struct to NT converted and collapsed relative path and the ContainingDirectory to an open handle of current working directory. CurDir is currently not implemented. -- v5: ntdll/tests: Tests for RtlDosPathNameToRelativeNtPathName_U_WithStatus ntdll: Implement handling of relative in RtlDosPathNameToRelativeNtPathName_U_WithStatus https://gitlab.winehq.org/wine/wine/-/merge_requests/1004

2 2

[PATCH v4 0/4] MR1004: ntdll: Implement optional relative parameter of RtlDosPathNameToRelativeNtPathName_U_WithStatus
by Skryptonyte (＠Skryptonyte) 05 Oct '22

05 Oct '22

relative optional parameter will now be handled by setting the RelativeName of the relative struct to NT converted and collapsed relative path and the ContainingDirectory to an open handle of current working directory. CurDir is currently not implemented. -- v4: ntdll/tests: Corrected and refactored tests https://gitlab.winehq.org/wine/wine/-/merge_requests/1004

4 8

[PATCH v4 0/4] MR951: ntdll: Add initial support for DOS file attributes (attempt 3)
by Joel Holdsworth (＠jhol) 04 Oct '22

04 Oct '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n… by Erich E. Hoover (@ehoover), and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These can implemented in various ways depending upon the capabilities of the operating system and the file system. However, this initial patch-set focusses on just one method: Samba-formatted Extended File Attributes. Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value, and this patch-set implements a compatible mechanism. Support for additional storage methods to increase operating system and filesystem compatibility is planned for later patch submissions. This effort is part of a larger project I have been working on to get Msys2 and Cygwin working properly on Wine. The absence of DOS fule attribute support prevents one of the modes that Cygwin and Msys2 can use to emulate symbolic links from working correctly, which causes the Cygwin installer to fail: https://bugs.winehq.org/show_bug.cgi?id=15679 See Also * https://bugs.winehq.org/show_bug.cgi?id=9158 -- v4: ntdll: Implement storing DOS attributes in NtCreateFile. ntdll: Implement retrieving DOS attributes in NtQueryInformationFile ntdll: Implement storing DOS attributes in NtSetInformationFile. ntdll: Implement retrieving DOS attributes in [fd_]get_file_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/951

6 9

[PATCH v5 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 04 Oct '22

04 Oct '22

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> -- v5: kernelbase: Call NtCancelSynchronousIoFile in CancelSynchronousIo. ntdll: Implement NtCancelSynchronousIoFile. ntdll: Add NtCancelSynchronousIoFile stub. kernel32/tests: Add tests for CancelSynchronousIo. https://gitlab.winehq.org/wine/wine/-/merge_requests/47

3 5

[PATCH v3 0/4] MR951: ntdll: Add initial support for DOS file attributes (attempt 3)
by Joel Holdsworth (＠jhol) 04 Oct '22

04 Oct '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n… by Erich E. Hoover (@ehoover), and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These can implemented in various ways depending upon the capabilities of the operating system and the file system. However, this initial patch-set focusses on just one method: Samba-formatted Extended File Attributes. Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value, and this patch-set implements a compatible mechanism. Support for additional storage methods to increase operating system and filesystem compatibility is planned for later patch submissions. This effort is part of a larger project I have been working on to get Msys2 and Cygwin working properly on Wine. The absence of DOS fule attribute support prevents one of the modes that Cygwin and Msys2 can use to emulate symbolic links from working correctly, which causes the Cygwin installer to fail: https://bugs.winehq.org/show_bug.cgi?id=15679 See Also * https://bugs.winehq.org/show_bug.cgi?id=9158 -- v3: ntdll: Implement storing DOS attributes in NtCreateFile. ntdll: Implement retrieving DOS attributes in NtQueryInformationFile ntdll: Implement storing DOS attributes in NtSetInformationFile. ntdll: Implement retrieving DOS attributes in [fd_]get_file_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/951

5 8

[PATCH v3 0/3] MR1004: ntdll: Implement optional relative parameter of RtlDosPathNameToRelativeNtPathName_U_WithStatus
by Skryptonyte (＠Skryptonyte) 04 Oct '22

04 Oct '22

relative optional parameter will now be handled by setting the RelativeName of the relative struct to NT converted and collapsed relative path and the ContainingDirectory to an open handle of current working directory. CurDir is currently not implemented. -- v3: ntdll/tests: Handle relative paths for windows 7 https://gitlab.winehq.org/wine/wine/-/merge_requests/1004

3 5

[PATCH v2 0/2] MR1004: ntdll: Implement optional relative parameter of RtlDosPathNameToRelativeNtPathName_U_WithStatus
by Skryptonyte (＠Skryptonyte) 04 Oct '22

04 Oct '22

relative optional parameter will now be handled by setting the RelativeName of the relative struct to NT converted and collapsed relative path and the ContainingDirectory to an open handle of current working directory. CurDir is currently not implemented. -- v2: ntdll: Implement handling of relative parameter for RtlDosPathNameToRelativeNtPathName_U_WithStatus ntdll/tests: Add tests to verify relative pathname and container directory filling. Also additional entries to test more relative pathname cases https://gitlab.winehq.org/wine/wine/-/merge_requests/1004

4 5

[PATCH v6 0/4] MR908: uiautomationcore: Add more nested node features.
by Connor McAdams (＠cmcadams) 04 Oct '22

04 Oct '22

Add the ability to disconnect nested node providers, and return element properties for nested nodes. -- v6: uiautomationcore: Add UIAutomationType_Element property support for nested node providers. https://gitlab.winehq.org/wine/wine/-/merge_requests/908

4 12

[PATCH 0/2] MR1004: ntdll: Implement optional relative parameter of RtlDosPathNameToRelativeNtPathName_U_WithStatus
by Skryptonyte (＠Skryptonyte) 04 Oct '22

04 Oct '22

relative optional parameter will now be handled by setting the RelativeName of the relative struct to NT converted and collapsed relative path and the ContainingDirectory to an open handle of current working directory. CurDir is currently not implemented. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1004

3 3

[PATCH 0/1] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 03 Oct '22

03 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46012 Signed-off-by: Patrick Hibbs <hibbsncc1701(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979

3 2

[PATCH 0/1] MR973: mf: Avoid clearing media session command list while it is running.
by Rémi Bernon (＠rbernon) 03 Oct '22

03 Oct '22

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/874, as it's fairly unrelated. This alone should fix mfmediaengine tests frequent crashes. They don't cause the test pipeline to fail, but they render the tests pretty much void. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/973

3 4

[PATCH v2 0/1] MR881: kernelbase: Fix reading stale information from IOSB.
by Jinoh Kang (＠iamahuman) 03 Oct '22

03 Oct '22

Ensure IOSB Information (InternalHigh) is loaded after Status (Internal) to avoid reading stale value from the Information (InternalHigh) field. -- v2: kernelbase: Fix reading stale information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/881

3 4

[PATCH v6 0/1] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) 03 Oct '22

03 Oct '22

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v6: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 2

[PATCH 0/1] MR1000: wintab32: Fix match_token to match XWayland devices
by John Chadwick (＠jchw) 03 Oct '22

03 Oct '22

XWayland tablet devices have the Wayland seat ID appended to the end of them, preceded by a colon. This prevents match_token from properly detecting XWayland devices and causes Wintab32 to fail to initialize. This change allows a matched token to end in a colon, and thus allows XWayland tablet devices to be detected correctly. Signed-off-by: John Chadwick <john(a)jchw.io> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1000

2 1

[PATCH 0/1] MR999: msdasql: Implement IRowsetInfo GetProperties
by Alistair Leslie-Hughes (＠alesliehughes) 03 Oct '22

03 Oct '22

The only way to actually set these properties is via the ICommandProperties interface found on ICommandText(eg rowset->caller). Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/999

2 1

[PATCH 0/3] MR965: jscript/mshtml: Enumeration fixes.
by Gabriel Ivăncescu (＠insn) 02 Oct '22

02 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/965

3 4

[PATCH 0/1] MR998: wow64: Use the right SEH opcode in raise_exception on arm64
by Martin Storsjö (＠mstorsjo) 02 Oct '22

02 Oct '22

On ARM and ARM64, each SEH opcode is supposed to map to exactly one instruction; the operation of writing x29+x30 with a stack offset with writeback is called ".seh_save_fplr_x". Using the right opcode would fix inconsistent unwinding if we would unwind from near the end of the prologue (which is implausible here). However, clang/LLVM might also get checking for mismatches between SEH opcodes and the prolog/epilog ranges (https://reviews.llvm.org/D131394), mainly to guard against inconsistencies in the unwind info generated by the compiler, but that would trigger on this handwritten function too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/998

2 1

[PATCH v6 0/5] MR932: comctl32: propsheet tests
by Piotr Caban (＠piotr) 02 Oct '22

02 Oct '22

-- v6: comctl32: Don't pass PROPSHEETPAGE to SetWindowSubclass in PROPSHEET_CreatePage. comctl32/tests: Test passing PropertySheetPage as HPROPSHEETPAGE. comctl32/tests: Add more PROPSHEETPAGE tests inside callback. comctl32/tests: Test passing extra data in PROPSHEETPAGE structure. comctl32/tests: Test PROPERTYSHEETPAGE passed in WM_INITDIALOG. https://gitlab.winehq.org/wine/wine/-/merge_requests/932

4 8

[PATCH 0/1] MR982: dpnet/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 01 Oct '22

01 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/982

3 2

[PATCH v4 0/5] MR23: Use our compiler to build shaders in demos.
by Giovanni Mascellani (＠giomasce) 01 Oct '22

01 Oct '22

-- v4: demos/gears: Recompile shaders with our compiler. demos/triangle: Recompile shaders with our compiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/23

3 7

[wine-gitlab] Re: [PATCH v2 0/2] MR389: Reset input buffer - approved
by Alexandre Julliard (＠julliard) 01 Oct '22

01 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/389

1 0

[PATCH v3 0/5] MR23: Use our compiler to build shaders in demos.
by Giovanni Mascellani (＠giomasce) 01 Oct '22

01 Oct '22

-- v3: demos/gears: Recompile shaders with our compiler. demos/triangle: Recompile shaders with our compiler. vkd3d-shader/hlsl: Write SM4 rsq instructions. vkd3d-shader/hlsl: Parse normalize intrinsic. tests: Test normalize() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/23

4 7

[PATCH 0/4] MR980: wintrust: Support WSS_GET_SECONDARY_SIG_COUNT in singature settings in WinVerifyTrust().
by Paul Gofman (＠gofman) 01 Oct '22

01 Oct '22

Nvidia's Streamline library depends on that (https://github.com/NVIDIAGameWorks/Streamline/). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/980

2 4

[PATCH 0/27] MR26: vkd3d-shader/hlsl: Broaden resources support (draft).
by Francisco Casas (＠fcasas) 01 Oct '22

01 Oct '22

This patch series has gotten quite big I don't expect this to be approved but I think it would be good if you review this approach so I start sending this patch series in fragments Because there are design decisions with long term effects Includes: * Many small fixes to corner cases I have stumbled upon. * For SM1, the tex2D and tex3D intrinsics, inferring generic samplers dimension from usage, writing sampler declarations, and writing sample instructions. * Support for arrays of resources for both SM1 and SM4. * Support for synthetic combined samplers for SM1 and synthetic separated samplers for SM4, considering that they can be arrays or members of other structs. All of this considering that the assignment of register indexes on allocation for each object component has to match match Some design changes are important in the long run Long reach of support to make sure this changes were in the right direction (I had to discard several approaches before reaching this one) Resource allocation is challenging because it is done at array level even if array is a member within a struct. because While I doubt this will be accepted quickly, I think it is a good thing Among the most complex things is ensuring that allocated I have tested with ps_3_0 and ps_5_0 These are some of the tests I have been running both for SM1 and SM4 (with -GeC) flag, so that the allocated registers matches the ones of the native compiler. [sm1-separated-samplers.hlsl](/uploads/5cfe4c4b64c208e3528c9b8e45959e0a/sm1-separated-samplers.hlsl) [sm1-separated-samplers-array.hlsl](/uploads/08734623aa930ec2f40f254824ffbb5b/sm1-separated-samplers-array.hlsl) [sm1-separated-samplers-2.hlsl](/uploads/32018666a2d4400f5fa8ec5f9edbac4d/sm1-separated-samplers-2.hlsl) [sm1-reserves-and-arrays.hlsl](/uploads/f8be8a59c818aea2ebc176d92b6de80d/sm1-reserves-and-arrays.hlsl) [sm1-reserves-and-dims.hlsl](/uploads/346087313ab21849ff20da3f9449b80f/sm1-reserves-and-dims.hlsl) [sm1-combined-order.hlsl](/uploads/4d77c5b68df1b365d4ec0a61d25e8d2d/sm1-combined-order.hlsl) [sm1-separated-and-combined-samplers.hlsl](/uploads/d9d337839642a29793358a86e31b8d40/sm1-separated-and-combined-samplers.hlsl) This patch series doesn't include these tests nor at automated way of testing them yet. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/26

1 2

Re: [PATCH v2 0/1] MR977: programs/winedbg: Enhance printing of variables or fields. - approved
by Alexandre Julliard (＠julliard) 30 Sep '22

30 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/977

1 0

Re: [PATCH v2 0/1] MR976: dbghelp: Expose local static variables' address. - approved
by Alexandre Julliard (＠julliard) 30 Sep '22

30 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/976

1 0

Re: [PATCH v2 0/1] MR975: dbgHelp: Remove address field from symt_compiland. - approved
by Alexandre Julliard (＠julliard) 30 Sep '22

30 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/975

1 0

Re: [PATCH v3 0/6] MR964: regedit: Avoid loading unnecessary modules. - approved
by Alexandre Julliard (＠julliard) 30 Sep '22

30 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/964

1 0

Re: [PATCH v2 0/8] MR972: mf/tests: Add some AAC and WMV encoder and decoder transform tests. - approved
by Alexandre Julliard (＠julliard) 30 Sep '22

30 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/972

1 0

Re: [PATCH v3 0/1] MR967: winevulkan: Introduce conversion_context and use it for conversion memory allocation. - approved
by Alexandre Julliard (＠julliard) 30 Sep '22

30 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/967

1 0

Re: [PATCH v3 0/1] MR968: crypt32: Set correct exponent length in decoded BCRYPT_RSAKEY_BLOB. - approved
by Alexandre Julliard (＠julliard) 30 Sep '22

30 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/968

1 0

[PATCH 0/1] MR977: programs/winedbg: Enhance printing of variables or fields.
by eric pouech (＠epo) 30 Sep '22

30 Sep '22

Prints 'int a[10]' (instead of 'int[10] a'). Ditto for variables/fields of type function pointer. And for pure type printing, no longer prints --none-- for arrays and function pointers. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/977

2 1

[PATCH 0/1] MR976: dbghelp: Expose local static variables' address.
by eric pouech (＠epo) 30 Sep '22

30 Sep '22

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/976

2 1

[PATCH 0/1] MR975: dbgHelp: Remove address field from symt_compiland.
by eric pouech (＠epo) 30 Sep '22

30 Sep '22

It's mostly always set at 0, and native dbghelp doesn't exposeit anyway. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/975

2 1

[PATCH v2 0/4] MR951: ntdll: Add initial support for DOS file attributes (attempt 3)
by Joel Holdsworth (＠jhol) 30 Sep '22

30 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n… by Erich E. Hoover (@ehoover), and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These can implemented in various ways depending upon the capabilities of the operating system and the file system. However, this initial patch-set focusses on just one method: Samba-formatted Extended File Attributes. Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value, and this patch-set implements a compatible mechanism. Support for additional storage methods to increase operating system and filesystem compatibility is planned for later patch submissions. This effort is part of a larger project I have been working on to get Msys2 and Cygwin working properly on Wine. The absence of DOS fule attribute support prevents one of the modes that Cygwin and Msys2 can use to emulate symbolic links from working correctly, which causes the Cygwin installer to fail: https://bugs.winehq.org/show_bug.cgi?id=15679 See Also * https://bugs.winehq.org/show_bug.cgi?id=9158 -- v2: ntdll: Implement storing DOS attributes in NtCreateFile. ntdll: Implement retrieving DOS attributes in NtQueryInformationFile ntdll: Implement storing DOS attributes in NtSetInformationFile. ntdll: Implement retrieving DOS attributes in [fd_]get_file_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/951

4 10

2025

2024

2023

2022

wine-gitlab