- wine-gitlab - winehq.org

[PATCH 0/1] MR974: vulkan-1/tests: Add keyed mutex timeout behavior tests.
by Derek Lesho (＠dlesho) 30 Sep '22

30 Sep '22

This extension isn't very well documented, particularly in regards to the behavior of the timeout values, so I think it makes sense to add tests since an Implementation would necessarily be done by winevulkan. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/974

2 1

Re: [PATCH v2 0/10] MR969: combase: CoMsgWaitForMultipleHandles message pump.
by Kevin Puetz (＠puetzk) 30 Sep '22

30 Sep '22

Fixed the `error: res undeclared` stuff, I had one line squashed into the wrong commit after all the splitting. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/969#note_9849

1 0

[PATCH v2 0/9] MR966: server: Some fixes for the shared Software\Classes registry.
by Sven Baars (＠sbaars) 30 Sep '22

30 Sep '22

This seems to be more correct than what we previously had with fewer lines of code, so I like that. I still don't really like the extra flag I had to add for Nt{Create,Open}Key, but I couldn't find a way to make things work without it. I also checked that Windows doesn't use a similar flag (by iterating over all bit masks). -- v2: ntdll/tests: Factor out the NtEnumerateKey() tests. kernelbase: Remove special Wow64 handling for HKEY_CLASSES_ROOT. kernelbase: Remove special Wow6432Node handling from RegCreateKeyEx(). kernelbase: Remove special Wow6432Node handling from RegOpenKeyEx(). server: Don't return the actual 32-bit Software\Classes key. ntdll/tests: Add some some Software\Classes query and enumerate tests. ntdll/tests: Test that NtCreateKeyEx() also recursively obtains the Wow6432Node parent. server: Recursively obtain the Wow6432Node parent. ntdll/tests: Add some Software\Classes subkey tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/966

3 10

[PATCH v3 0/6] MR874: mfmediaengine: Add tests to exhibit inverted video rendering.
by Rémi Bernon (＠rbernon) 30 Sep '22

30 Sep '22

This shows that media session samples are correctly oriented, but that mfmediaengine renders them upside down. -- v3: mfmediaengine: Remove vertical flipping of video frames. mfmediaengine/tests: Check IMFMediaEngine_TransferVideoFrames output orientation. mfmediaengine/tests: Pass a device and output format to create_media_engine. mf: Avoid clearing media session command list while it is running. mf/tests: Check sample grabber RGB / NV12 orientation. mf/tests: Factor test grabber callback implementations. https://gitlab.winehq.org/wine/wine/-/merge_requests/874

2 8

[PATCH 0/8] MR972: mf/tests: Add some AAC and WMV encoder and decoder transform tests.
by Rémi Bernon (＠rbernon) 30 Sep '22

30 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/972

2 8

[PATCH v2 0/1] MR968: crypt32: Set correct exponent length in decoded BCRYPT_RSAKEY_BLOB.
by Paul Gofman (＠gofman) 30 Sep '22

30 Sep '22

Nvidia's Streamline library depends on that (https://github.com/NVIDIAGameWorks/Streamline/). I modified an exponent value in tests to a non sensual one which has non-symmetric byte sequence so the byte order also gets tested. -- v2: crypt32: Set correct exponent length in decoded BCRYPT_RSAKEY_BLOB. https://gitlab.winehq.org/wine/wine/-/merge_requests/968

3 3

[PATCH v18 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 30 Sep '22

30 Sep '22

-- v18: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag https://gitlab.winehq.org/wine/wine/-/merge_requests/820

4 16

[PATCH 0/10] MR969: Draft: combase: CoMsgWaitForMultipleHandles message pump.
by Kevin Puetz (＠puetzk) 30 Sep '22

30 Sep '22

This sequence of patches fixes numerous corner cases in CoMsgWaitForMultipleHandles, particularly around the exact sequence in which signaled handles, windows messages, and APCs are considered and which "win" if more than one thing has happened at a time. This was previously submitted quite some time ago, and rejected as "Needs splitting": https://www.winehq.org/pipermail/wine-devel/2020-November/177529.html Sorry it has taken me so long to get back to this one, but here's an attempt to tease it apart into a number of smaller commits that each make smaller changes and add some of the new tests. Hopefully that makes it easier to follow which change fixes what. Apologies if the splitting is still a little tortured in places, since it re-thought all at once and then split apart, not developed in this order and then squashed. But hopefully this is more readable. Major fixes are: - closes a race condition with short/zero timeouts, in which it could reports RPC_S_PENDING without ever even checking the handles - cancellation via IMessageFilter::PendingMesage -> `PENDINGMSG_CANCELCALL` now actually exits the wait - makes sure not to pump additional messages after the handles have been signaled - don't use a MsgWait until after seeing that handles were not already signaled. This is mostly important to COWAIT_WAITALL. It's still not advisable to use COWAIT_WAITALL in an STA (for reasons all our favorite Microsoft Gurus have discussed: https://learn.microsoft.com/en-us/archive/blogs/larryosterman/things-you-sh… https://devblogs.microsoft.com/oldnewthing/20060127-17/?p=32493). But it gets fixed in passing as a consequence of the previous changes, and so there are some new conformance tests to show that the new behavior matches windows. There's also a some new `todo_wine` tests for spurious calls to IMessageFilter_MessagePending. This behavior has *not* changed, but I expanded the test coverage (unsuccessfully) hoping it would give me a hint about what should change. Since I still don't know what the rules should be, I left the new tests `todo_wine`. But maybe they'll be a useful hint someday. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/969

3 13

[PATCH 0/1] MR968: crypt32: Set correct exponent length in decoded BCRYPT_RSAKEY_BLOB.
by Paul Gofman (＠gofman) 29 Sep '22

29 Sep '22

Nvidia's Streamline library depends on that (https://github.com/NVIDIAGameWorks/Streamline/). I modified an exponent value in tests to a non sensual one which has non-symmetric byte sequence so the byte order also gets tested. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/968

2 1

[PATCH 0/5] MR25: vkd3d-shader/hlsl: Implement asuint() and completely move init_node() to hlsl.c.
by Zebediah Figura (＠zfigura) 29 Sep '22

29 Sep '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/25

4 7

[PATCH 0/1] MR967: winevulkan: Introduce conversion_context and use it for conversion memory allocation.
by Jacek Caban (＠jacek) 29 Sep '22

29 Sep '22

This simplifies the code as we don't need to worry about generating clean up functions for every conversion. It also makes allocations faster. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/967

3 2

Re: [PATCH v2 0/1] MR961: winegstreamer: Respect debug channels configuration for error output. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/961

1 0

Re: [PATCH v2 0/1] MR960: windowscodecs: Redirect TIFF debug output to the Wine debug functions. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/960

1 0

Re: [PATCH v2 0/1] MR958: vbscript: don't abort when trying to TRACE() functions with many arguments. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/958

1 0

Re: [PATCH v5 0/7] MR856: mshtml: url prop for Storage Events and improvements. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/856

1 0

Re: [PATCH v3 0/13] MR929: mf/tests: More MF transform test factorization and small fixes. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/929

1 0

Re: [PATCH v3 0/1] MR938: dbghelp: SymFromName* should first look in local context. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/938

1 0

Re: [PATCH v3 0/2] MR949: msdasql: Implement IColumnsInfo GetColumnInfo - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/949

1 0

Re: [PATCH v2 0/1] MR959: winevulkan: Update to VK spec version 1.3.230. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/959

1 0

Re: [PATCH v2 0/7] MR936: winegstreamer: Test and implement WM sync reader allocation methods. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/936

1 0

[PATCH 0/7] MR937: winegstreamer: Small refactor of wg_format video formats and major types.
by Rémi Bernon (＠rbernon) 29 Sep '22

29 Sep '22

I'm going to need to add a few more compressed formats, WMV which is straightforward, but also AAC (so MPEG v2/v4 audio), and I think wg_format could be cleaned up a bit like this beforehand. Then, AAC could either be added as a separate `AUDIO_MPEG4` format, or, with an version field, to the (renamed) `AUDIO_MPEG` format, though it doesn't share any of the current `AUDIO_MPEG1` properties. FWIW GStreamer caps is `audio/mpeg` for both, with an `mpegversion` that can be 1, 2 or 4. Could be very well added as `AUDIO_AAC` too, I don't really mind. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/937

3 11

[PATCH v2 0/13] MR929: mf/tests: More MF transform test factorization and small fixes.
by Rémi Bernon (＠rbernon) 29 Sep '22

29 Sep '22

-- v2: mf/tests: Factor IMFTransform_Get(Input|Output)StreamInfo checks together. winegstreamer: Stop requiring input type in H264 decoder GetInputStreamInfo. winegstreamer: Keep input / output stream info in struct h264_decoder. winegstreamer: Keep input / output stream info in struct wma_decoder. winegstreamer: Keep input / output stream info in struct video_processor. winegstreamer: Keep input / output stream info in struct resampler. winegstreamer: Keep input / output stream info in struct color_convert. winegstreamer: Remove FIXME / stub! from optional transform methods. mf/tests: Test miscellaneous and optional IMFTransform methods. winegstreamer: Return E_NOTIMPL from color_convert GetInputStreamAttributes. winegstreamer: Check Video Processor Get(OutputStream)Attributes pointers. winegstreamer: Implement WMA decoder GetStreamLimits / GetStreamCount. winegstreamer: Implement H264 decoder GetStreamLimits / GetStreamCount. https://gitlab.winehq.org/wine/wine/-/merge_requests/929

3 15

[PATCH v2 0/6] MR964: regedit: Avoid loading unnecessary modules.
by Rémi Bernon (＠rbernon) 29 Sep '22

29 Sep '22

This should speedup regedit tests from ~60s to ~4s. -- v2: regedit.exe: Add a direct import for shcore. regedit.exe: Call InitCommonControls after command-line has been processed. shcore: Use delay import for user32 and ole32. makedep: Link with imported libs before delay imported libs. makedep: Link default imports separately from direct imports. makedep: Add an import type parameter to add_import_libs. https://gitlab.winehq.org/wine/wine/-/merge_requests/964

2 7

[PATCH 0/5] MR23: Use our compiler to build shaders in demos.
by Giovanni Mascellani (＠giomasce) 29 Sep '22

29 Sep '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/23

3 6

[PATCH 0/1] MR961: winegstreamer: Respect debug channels configuration for error output.
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/961

5 4

[PATCH 0/4] MR964: regedit: Avoid loading unnecessary modules.
by Rémi Bernon (＠rbernon) 29 Sep '22

29 Sep '22

This should speedup regedit tests from ~60s to ~4s. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/964

3 5

[PATCH v4 0/7] MR856: mshtml: url prop for Storage Events and improvements.
by Gabriel Ivăncescu (＠insn) 29 Sep '22

29 Sep '22

-- v4: mshtml: Silence a FIXME when parameter is missing. mshtml: Allocate events via event type. mshtml: Expand event_info to include a special entry for EVENTID_LAST. mshtml: Use actual Gecko event type for MessageEvent and StorageEvent. mshtml: Implement url prop for StorageEvent. include/mshtml: Move some forward interface declarations to match Windows SDK. mshtml: Override document.URL's name when adding it from the mshtml typelib. https://gitlab.winehq.org/wine/wine/-/merge_requests/856

4 9

[PATCH 0/1] MR960: windowscodecs: Redirect TIFF debug output to the Wine debug functions.
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/960

3 2

[PATCH 0/1] MR959: winevulkan: Update to VK spec version 1.3.230.
by Georg Lehmann (＠DadSchoorse) 29 Sep '22

29 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/959

3 2

[PATCH 0/1] MR958: vbscript: don't abort when trying to TRACE() functions with many arguments.
by Kevin Puetz (＠puetzk) 29 Sep '22

29 Sep '22

__wine_dbg_output accumulates the output characters in a debug_info structure, flushing it when it encounters '\n'. If debug_info plus the new string exceed 1024 characters, append_output will print > wine_dbg_output: debugstr buffer overflow and then crash the process via abort(). wine_dbgstr_variant limits the length printed for any individual argument, but a function with multiple parameters can still plausibly exceed 1024. Fixed by formatting the TRACE for each argument on a separate line, as similar places (like oleaut32/typelib.c:dump_DispParms) do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/958

3 2

[PATCH v3 0/5] MR944: win32u: Make desktop resize logic asynchronous.
by Rémi Bernon (＠rbernon) 29 Sep '22

29 Sep '22

To avoid direct callbacks from display drivers to win32u while changing display settings. -- v3: winemac.drv: Resize desktop window on WM_DISPLAYCHANGE message. winex11.drv: Resize desktop window on WM_DISPLAYCHANGE message. win32u: Send WM_DISPLAYCHANGE message to the desktop window. winex11.drv: Send WM_X11DRV_CLIP_CURSOR_REQUEST message from the deskop. winex11.drv: Sync window positions in a WM_X11DRV_DESKTOP_RESIZED message. https://gitlab.winehq.org/wine/wine/-/merge_requests/944

3 11

[PATCH v5 0/5] MR932: comctl32: propsheet tests
by Piotr Caban (＠piotr) 29 Sep '22

29 Sep '22

-- v5: comctl32: Don't pass PROPSHEETPAGE to SetWindowSubclass in PROPSHEET_CreatePage. https://gitlab.winehq.org/wine/wine/-/merge_requests/932

3 7

[PATCH 0/4] MR951: ntdll: Add initial support for DOS file attributes (attempt 3)
by Joel Holdsworth (＠jhol) 29 Sep '22

29 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n… by Erich E. Hoover (@ehoover), and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These can implemented in various ways depending upon the capabilities of the operating system and the file system. However, this initial patch-set focusses on just one method: Samba-formatted Extended File Attributes. Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value, and this patch-set implements a compatible mechanism. Support for additional storage methods to increase operating system and filesystem compatibility is planned for later patch submissions. This effort is part of a larger project I have been working on to get Msys2 and Cygwin working properly on Wine. The absence of DOS fule attribute support prevents one of the modes that Cygwin and Msys2 can use to emulate symbolic links from working correctly, which causes the Cygwin installer to fail: https://bugs.winehq.org/show_bug.cgi?id=15679 See Also * https://bugs.winehq.org/show_bug.cgi?id=9158 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/951

7 18

[PATCH v4 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 29 Sep '22

29 Sep '22

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> -- v4: kernelbase: Call NtCancelSynchronousIoFile in CancelSynchronousIo. ntdll: Implement NtCancelSynchronousIoFile. ntdll: Add NtCancelSynchronousIoFile stub. kernel32/tests: Add tests for CancelSynchronousIo. https://gitlab.winehq.org/wine/wine/-/merge_requests/47

3 8

[PATCH 0/1] MR957: rpcrt4: MIDL_STUB_MESSAGE needs to keep a refcount on IRpcChannelBuffer.
by Kevin Puetz (＠puetzk) 28 Sep '22

28 Sep '22

It's possible for a proxy to be released during the middle of an Invoke. A specific scenario where this happened was a single-shot event sink which, upon receiving the event it was waiting for, would immediately call DispEventUnadvise. This removed the proxy pointing to that sink from the connection point's list of subscribers and released it. For such cases all state used to complete the Invoke must be owned by the __proxy_frame kept on the stack; after calling NdrProxySendReceive (which pumps STA messages and permits reentrancy), anything inside *This could be use-after-free. MIDL_STUB_MESSAGE already had its own IRPCChannelBuffer *pRpcChannelBuffer, but lacked its own refcount. When this does crash, the exception is caught by RpcTryFinally, but still leads to leaks since NdrProxyFreeBuffer wasn't able to call IRPCChannelBuffer::FreeBuffer. To fix this, StdProxy_GetChannel() now calls AddRef() when setting __proxy_frame::_StubMsg::pRpcChannelBuffer and NdrProxyFreeBuffer() calls the corresponding Release(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/957

2 1

[PATCH 0/7] MR936: winegstreamer: Test and implement WM sync reader allocation methods.
by Rémi Bernon (＠rbernon) 28 Sep '22

28 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/936

4 15

Re: [PATCH v2 0/1] MR954: tests: Print unhandled exception messages in colour. - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/954

1 0

Re: [PATCH v3 0/1] MR945: msi: Disable FS redirection for temporary file in cabinet_copy_file(). - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/945

1 0

Re: [PATCH v3 0/1] MR948: winegstreamer: Fix memory leak in get_available_media_type (Coverity). - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/948

1 0

Re: [PATCH v2 0/2] MR952: winevulkan: Separate 32-bit and 64-bit conversion functions. - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/952

1 0

Re: [PATCH v2 0/2] MR953: Fix test failures on Gitlab CI. - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/953

1 0

Re: [PATCH v2 0/5] MR950: Improvements in dbghelp support for global/static variables. - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/950

1 0

Re: [PATCH v3 0/1] MR935: widl: Generate "static inline" instead of "static FORCEINLINE" for COM inline wrappers. - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/935

1 0

Re: [PATCH v2 0/1] MR947: winex11.drv: Do not skip taskbar and pager for app window. - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/947

1 0

Re: [PATCH v3 0/1] MR24: include: Add missing vkd3d_shader_compile() transformations. - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/24

1 0

Re: [PATCH v2 0/4] MR22: vkd3d-shader/hlsl: Add and use constant node creation helpers. - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/22

1 0

[PATCH 0/2] MR953: Fix test failures on Gitlab CI.
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/953

5 7

[PATCH v2 0/1] MR945: msi: Disable FS redirection for temporary file in cabinet_copy_file().
by Paul Gofman (＠gofman) 28 Sep '22

28 Sep '22

When the destination file cannot be copied in 32 bit installer of 64 bit dlls (going to system32) temporary file attempted at system32 (as that is the destination directory) currently ends up in syswow64. When wineboot is later processing PendingFileRenameOperations the redirection of the source file is not performed (and there is no way to guess that the file was redirected). -- v2: msi: Disable FS redirection for temporary file in cabinet_copy_file(). https://gitlab.winehq.org/wine/wine/-/merge_requests/945

3 3

[PATCH v5 0/4] MR908: uiautomationcore: Add more nested node features.
by Connor McAdams (＠cmcadams) 28 Sep '22

28 Sep '22

Add the ability to disconnect nested node providers, and return element properties for nested nodes. -- v5: uiautomationcore: Add UIAutomationType_Element property support for nested node providers. uiautomationcore: Implement UiaDisconnectProvider. uiautomationcore: Track all HUIANODEs returned from the provider thread. uiautomationcore: Don't use nested node providers for same-thread HWNDs. https://gitlab.winehq.org/wine/wine/-/merge_requests/908

2 5

[PATCH 0/1] MR954: tests: Print unhandled exception messages in colour.
by Francois Gouget (＠fgouget) 28 Sep '22

28 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/954

2 1

[PATCH v2 0/1] MR948: winegstreamer: Fix memory leak in get_available_media_type (Coverity).
by Alex Henrie (＠alexhenrie) 28 Sep '22

28 Sep '22

-- v2: winegstreamer: Fix memory leak in get_available_media_type (Coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/948

3 2

[PATCH 0/1] MR948: winegstreamer: Fix memory leak in get_available_media_type (Coverity).
by Alex Henrie (＠alexhenrie) 28 Sep '22

28 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/948

3 4

[PATCH v3 0/2] MR930: Add tests for GetConsoleTitle() and return correct title length
by Hugh McMaster (＠hmc) 28 Sep '22

28 Sep '22

-- v3: kernelbase: Return full title length from GetConsoleTitle() kernel32/tests: Add tests for GetConsoleTitle() https://gitlab.winehq.org/wine/wine/-/merge_requests/930

4 7

[PATCH v2 0/1] MR24: include: Add missing vkd3d_shader_compile() transformations.
by Giovanni Mascellani (＠giomasce) 28 Sep '22

28 Sep '22

-- v2: include: Add missing vkd3d_shader_compile() transformations and chained structures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/24

3 2

[PATCH 0/4] MR22: vkd3d-shader/hlsl: Add and use constant node creation helpers.
by Zebediah Figura (＠zfigura) 28 Sep '22

28 Sep '22

Clean up the last few uses of init_node() outside of hlsl.c. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/22

4 6

[PATCH 0/1] MR24: include: Add missing vkd3d_shader_compile() transformations.
by Giovanni Mascellani (＠giomasce) 28 Sep '22

28 Sep '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/24

2 1

[PATCH 0/2] MR952: winevulkan: Separate 32-bit and 64-bit conversion functions.
by Jacek Caban (＠jacek) 28 Sep '22

28 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/952

2 2

[PATCH v2 0/5] MR23: Use our compiler to build shaders in demos.
by Giovanni Mascellani (＠giomasce) 28 Sep '22

28 Sep '22

-- v2: demos/gears: Recompile shaders with our compiler. demos/triangle: Recompile shaders with our compiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/23

2 5

[PATCH v6 0/4] MR946: ntdll: Add initial support for DOS file attributes
by Joel Holdsworth (＠jhol) 28 Sep '22

28 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n… by Erich E. Hoover (@ehoover), and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These can implemented in various ways depending upon the capabilities of the operating system and the file system. However, this initial patch-set focusses on just one method: Samba-formatted Extended File Attributes. Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value, and this patch-set implements a compatible mechanism. Support for additional storage methods to increase operating system and filesystem compatibility is planned for later patch submissions. This effort is part of a larger project I have been working on to get Msys2 and Cygwin working properly on Wine. The absence of DOS fule attribute support prevents one of the modes that Cygwin and Msys2 can use to emulate symbolic links from working correctly, which causes the Cygwin installer to fail: https://bugs.winehq.org/show_bug.cgi?id=9158 -- v6: ntdll: Implement storing DOS attributes in NtCreateFile. ntdll: Implement retrieving DOS attributes in NtQueryInformationFile ntdll: Implement storing DOS attributes in NtSetInformationFile. ntdll: Implement retrieving DOS attributes in [fd_]get_file_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/946

3 8

[PATCH 0/5] MR950: Improvements in dbghelp support for global/static variables.
by eric pouech (＠epo) 28 Sep '22

28 Sep '22

This series includes several improvements in DbgHelp for supporting (global / file static / function static) variables. In more details: - correct distinction and hierarchy attributes for the three kinds (Dwarf and PDB) - better filtering of PDB information + dropping invalid variable definitions from incremental linker (hence preventing their use instead of the valid ones) + keeping more wanted variables in case of collision (by address or by name) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/950

2 5

Re: [PATCH v7 0/6] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon (＠rbernon) 28 Sep '22

28 Sep '22

Sorry, I pushed to the wrong branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/551#note_9533

1 0

[PATCH v2 0/1] MR935: widl: Generate "static inline" instead of "static FORCEINLINE" for COM inline wrappers.
by Zebediah Figura (＠zfigura) 28 Sep '22

28 Sep '22

mingw-w64 defines __forceinline (and therefore FORCEINLINE) as "extern __inline__ __attribute__((__always_inline__,__gnu_inline__)). This means that COM inline wrappers specify multiple storage classes and hence cannot be compiled. Wine defines FORCEINLINE simply as "inline" (and uses "static" everywhere), so this is a non-issue for Wine. However, since Wine and mingw-w64 share the source code of widl and of most IDL headers, this patch changes the definition for both projects. There's no reason to force inlining here, especially since the wrappers need to be manually enabled, and we don't need to match PSDK semantics where these wrappers don't even exist. In practice, use "__inline__" instead of "inline" for GNU C targets, to preserve compatibility with C89 in mingw-w64 headers. -- v2: widl: Generate "static inline" instead of "static FORCEINLINE" for COM inline wrappers. https://gitlab.winehq.org/wine/wine/-/merge_requests/935

4 3

[PATCH v2 0/5] MR944: win32u: Make desktop resize logic asynchronous.
by Rémi Bernon (＠rbernon) 28 Sep '22

28 Sep '22

To avoid direct callbacks from display drivers to win32u while changing display settings. -- v2: winemac.drv: Resize desktop window on WM_DISPLAYCHANGE message. winex11.drv: Resize desktop window on WM_DISPLAYCHANGE message. win32u: Send WM_DISPLAYCHANGE message to the desktop window. winex11.drv: Send WM_X11DRV_CLIP_CURSOR_REQUEST message from the deskop. winex11.drv: Sync window positions in a WM_X11DRV_DESKTOP_RESIZED message. https://gitlab.winehq.org/wine/wine/-/merge_requests/944

3 9

[PATCH v2 0/1] MR938: dbghelp: SymFromName* should first look in local context.
by eric pouech (＠epo) 28 Sep '22

28 Sep '22

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- v2: dbghelp: SymFromName* should first look in local context. https://gitlab.winehq.org/wine/wine/-/merge_requests/938

2 2

[PATCH v2 0/5] MR932: cocmtl32: propsheet tests
by Piotr Caban (＠piotr) 28 Sep '22

28 Sep '22

-- v2: comtl32: Don't pass PROPSHEETPAGE to SetWindowSubclass in PROPSHEET_CreatePage. comctl32/tests: Test passing PropertySheetPage as HPROPSHEETPAGE. comctl32/tests: Add more PROPSHEETPAGE tests inside callback. comctl32/tests: Test passing extra data in PROPSHEETPAGE structure. comctl32/tests: Test PROPERTYSHEETPAGE passed in WM_INITDIALOG. https://gitlab.winehq.org/wine/wine/-/merge_requests/932

3 10

[PATCH v17 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 28 Sep '22

28 Sep '22

-- v17: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag server: Create \REGISTRY\A hive. ntdll: Rename NtLoadKeyEx parameters. ntdll: Pass filename to server in NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 6

[PATCH 0/1] MR945: msi: Disable FS redirection for temporary file in cabinet_copy_file().
by Paul Gofman (＠gofman) 28 Sep '22

28 Sep '22

When the destination file cannot be copied in 32 bit installer of 64 bit dlls (going to system32) temporary file attempted at system32 (as that is the destination directory) currently ends up in syswow64. When wineboot is later processing PendingFileRenameOperations the redirection of the source file is not performed (and there is no way to guess that the file was redirected). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/945

3 2

[PATCH 0/2] MR949: msdasql: Implement IColumnsInfo GetColumnInfo
by Alistair Leslie-Hughes (＠alesliehughes) 28 Sep '22

28 Sep '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/949

2 2

[PATCH 0/1] MR935: widl: Generate "static inline" instead of "static FORCEINLINE" for COM inline wrappers.
by Zebediah Figura (＠zfigura) 28 Sep '22

28 Sep '22

mingw-w64 defines __forceinline (and therefore FORCEINLINE) as "extern __inline__ __attribute__((__always_inline__,__gnu_inline__)). This means that COM inline wrappers specify multiple storage classes and hence cannot be compiled. Wine defines FORCEINLINE simply as "inline" (and uses "static" everywhere), so this is a non-issue for Wine. However, since Wine and mingw-w64 share the source code of widl and of most IDL headers, this patch changes the definition for both projects. There's no reason to force inlining here, especially since the wrappers need to be manually enabled, and we don't need to match PSDK semantics where these wrappers don't even exist. In practice, use "__inline__" instead of "inline" for GNU C targets, to preserve compatibility with C89 in mingw-w64 headers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/935

6 10

[PATCH 0/1] MR947: winex11.drv: Do not skip taskbar and pager for app window.
by Paul Gofman (＠gofman) 27 Sep '22

27 Sep '22

WS_EX_APPWINDOW is sort of the opposite to WS_EX_TOOLWINDOW and is supposed to force the window into taskbar. My testing on Windows shows that (WS_EX_TOOLWINDOW | WS_EX_APPWINDOW) windows are visible in both taskbar and task switcher. Some games use this combination of styles for their windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/947

2 1

[PATCH v5 0/4] MR946: ntdll: Add initial support for DOS file attributes
by Joel Holdsworth (＠jhol) 27 Sep '22

27 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n… by Erich E. Hoover (@ehoover), and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These can implemented in various ways depending upon the capabilities of the operating system and the file system. However, this initial patch-set focusses on just one method: Samba-formatted Extended File Attributes. Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value, and this patch-set implements a compatible mechanism. Support for additional storage methods to increase operating system and filesystem compatibility is planned for later patch submissions. This effort is part of a larger project I have been working on to get Msys2 and Cygwin working properly on Wine. The absence of DOS fule attribute support prevents one of the modes that Cygwin and Msys2 can use to emulate symbolic links from working correctly, which causes the Cygwin installer to fail: https://bugs.winehq.org/show_bug.cgi?id=9158 -- v5: ntdll: Implement storing DOS attributes in NtCreateFile. ntdll: Implement retrieving DOS attributes in NtQueryInformationFile ntdll: Implement storing DOS attributes in NtSetInformationFile. ntdll: Implement retrieving DOS attributes in [fd_]get_file_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/946

3 5

[PATCH v4 0/4] MR946: ntdll: Add initial support for DOS file attributes
by Joel Holdsworth (＠jhol) 27 Sep '22

27 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n… by Erich E. Hoover (@ehoover), and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These can implemented in various ways depending upon the capabilities of the operating system and the file system. However, this initial patch-set focusses on just one method: Samba-formatted Extended File Attributes. Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value, and this patch-set implements a compatible mechanism. Support for additional storage methods to increase operating system and filesystem compatibility is planned for later patch submissions. This effort is part of a larger project I have been working on to get Msys2 and Cygwin working properly on Wine. The absence of DOS fule attribute support prevents one of the modes that Cygwin and Msys2 can use to emulate symbolic links from working correctly, which causes the Cygwin installer to fail: https://bugs.winehq.org/show_bug.cgi?id=9158 -- v4: ntdll: Implement storing DOS attributes in NtCreateFile. ntdll: Implement retrieving DOS attributes in NtQueryInformationFile ntdll: Implement storing DOS attributes in NtSetInformationFile. ntdll: Implement retrieving DOS attributes in [fd_]get_file_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/946

4 6

[PATCH v3 0/4] MR946: ntdll: Add initial support for DOS file attributes
by Joel Holdsworth (＠jhol) 27 Sep '22

27 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n… by Erich E. Hoover (@ehoover), and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These can implemented in various ways depending upon the capabilities of the operating system and the file system. However, this initial patch-set focusses on just one method: Samba-formatted Extended File Attributes. Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value, and this patch-set implements a compatible mechanism. Support for additional storage methods to increase operating system and filesystem compatibility is planned for later patch submissions. This effort is part of a larger project I have been working on to get Msys2 and Cygwin working properly on Wine. The absence of DOS fule attribute support prevents one of the modes that Cygwin and Msys2 can use to emulate symbolic links from working correctly, which causes the Cygwin installer to fail: https://bugs.winehq.org/show_bug.cgi?id=9158 -- v3: ntdll: Implement storing DOS attributes in NtCreateFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/946

5 8

[PATCH v2 0/4] MR946: ntdll: Add initial support for DOS file attributes
by Joel Holdsworth (＠jhol) 27 Sep '22

27 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n… by Erich E. Hoover (@ehoover), and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These can implemented in various ways depending upon the capabilities of the operating system and the file system. However, this initial patch-set focusses on just one method: Samba-formatted Extended File Attributes. Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value, and this patch-set implements a compatible mechanism. Support for additional storage methods to increase operating system and filesystem compatibility is planned for later patch submissions. This effort is part of a larger project I have been working on to get Msys2 and Cygwin working properly on Wine. The absence of DOS fule attribute support prevents one of the modes that Cygwin and Msys2 can use to emulate symbolic links from working correctly, which causes the Cygwin installer to fail: https://bugs.winehq.org/show_bug.cgi?id=9158 -- v2: ntdll: Implement storing DOS attributes in NtCreateFile. ntdll: Implement retrieving DOS attributes in NtQueryInformationFile ntdll: Implement storing DOS attributes in NtSetInformationFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/946

6 9

Re: [PATCH v2 0/2] MR939: Dumping DBI hash information from PDB files. - approved
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/939

1 0

Re: [PATCH v2 0/1] MR941: winevulkan: Always use params to return Unix thunks result. - approved
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/941

1 0

Re: [PATCH v2 0/1] MR940: krnl386.exe16: Don't pass NULL to printf/%s). - approved
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/940

1 0

Re: [PATCH v2 0/1] MR903: ddraw: Add FPS tracing in ddraw_surface_update_frontbuffer(). - approved
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/903

1 0

Re: [PATCH v3 0/4] MR902: d3d9: Use a separate draw texture for managed resources. - approved
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/902

1 0

Re: [PATCH v2 0/1] MR933: wined3d: Set name of internal threads. - approved
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/933

1 0

Re: [PATCH v2 0/1] MR934: wininet: Set thread name for collect_connections_proc. - approved
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/934

1 0

Re: [PATCH v3 0/2] MR897: oleaut32: dereference VT_RECORD|VT_BYREF in place.
by Kevin Puetz (＠puetzk) 27 Sep '22

27 Sep '22

Ok, then I assume you'll revert it in today's push? We can abandon this MR, since the subject (my change to VariantCopyInd) is disproved anyway. I'll try to salvage the tests and open a separate MR for the discovered leak once I actually have a fix, but I think I'm going to prioritize finishing some other items first. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/897#note_9458

1 0

Re: [PATCH v4 0/4] MR908: uiautomationcore: Add more nested node features.
by Connor McAdams (＠cmcadams) 27 Sep '22

27 Sep '22

On Tue Sep 27 20:16:37 2022 +0000, Esme Povirk wrote: > I really don't think this needs to be a pointer. If there's going to be > at most 1 entry per uia_node, and it doesn't need to outlive the > uia_node, you can put the entry in there directly. > You can use list_init() when creating uia_node and list_empty() to check > if the entry is being used. (Though list_remove will leave the entry in > an invalid state, and you'll have to init it again if you want that > check to work afterwards.) That'd make sense. I guess we could also apply this to `node_map_list_entry`, and rather than have custom list entry structures for each, just use the `struct uia_node` structure to store the information we need instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/908#note_9457

1 0

Re: [PATCH v4 0/4] MR908: uiautomationcore: Add more nested node features.
by Esme Povirk (＠madewokherd) 27 Sep '22

27 Sep '22

Esme Povirk (@madewokherd) commented about dlls/uiautomationcore/uia_private.h: > > HWND hwnd; > BOOL nested_node; > + struct list *prov_thread_list_entry; I really don't think this needs to be a pointer. If there's going to be at most 1 entry per uia_node, and it doesn't need to outlive the uia_node, you can put the entry in there directly. You can use list_init() when creating uia_node and list_empty() to check if the entry is being used. (Though list_remove will leave the entry in an invalid state, and you'll have to init it again if you want that check to work afterwards.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/908#note_9455

1 0

[PATCH 0/4] MR946: ntdll: Add initial support for DOS file attributes
by Joel Holdsworth (＠jhol) 27 Sep '22

27 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n… by Erich E. Hoover (@ehoover), and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These can implemented in various ways depending upon the capabilities of the operating system and the file system. However, this initial patch-set focusses on just one method: Samba-formatted Extended File Attributes. Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value, and this patch-set implements a compatible mechanism. Support for additional storage methods to increase operating system and filesystem compatibility is planned for later patch submissions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/946

4 6

[PATCH 0/1] MR920: kernel32: Map system heap anywhere if the standard address is unavailable.
by Brendan Shanks (＠bshanks) 27 Sep '22

27 Sep '22

`mscomctl.ocx` (part of the VB6 common controls) calls `HeapCreate(0x04000000,1,0)`, that flag is the old and undocumented `HEAP_SHARED`. `HEAP_CreateSystemHeap()` tries to map memory at `0x80000000`, this fails on Wow64 (and probably should for all 32-bit platforms for non-LAA EXEs). As a workaround, map the memory anywhere if it fails at `0x80000000`. I wasn't able to find much documentation about `HEAP_SHARED`, it dates back to Win9x and I guess Wine may have needed it for some native DLLs. It's not clear whether modern Windows really implements any shared heap functionality any more, every 'shared' heap created returns a different pointer (even in the same process). Maybe Wine should remove the functionality too? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/920

3 2

Re: [PATCH v2 0/4] MR17: Various HLSL refactoring. - approved
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/17

1 0

Re: [PATCH v2 0/1] MR20: vkd3d-common: Tweak the WARN for VKD3D_ERROR_INVALID_SHADER. - approved
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/20

1 0

Re: [PATCH v2 0/1] MR21: vkd3d: Avoid an unused variable warning when building for Win32. - approved
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/21

1 0

Re: [PATCH v3 0/1] MR11: vkd3d: Add a macro to mark unreachable code. - approved
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/11

1 0

Re: [PATCH v2 0/8] MR924: ntdll: Add support for DOS file attributes - closed
by Joel Holdsworth (＠jhol) 27 Sep '22

27 Sep '22

This merge request was closed by Joel Holdsworth. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/924

1 0

[PATCH v2 0/1] MR942: ntdll: Unify get_file_info and fd_get_file_info.
by Joel Holdsworth (＠jhol) 27 Sep '22

27 Sep '22

In the ntdll file handling code, there are currently two duplicated file info setting functions: `get_file_info` and `fd_get_file_info`. One pasted on path strings, and the other based on file descriptors respectively. This patch set simplifies the code by unifying both functions into a single function ~~powered by `fstatat` instead of `lstat` and `fstat`~~. -- v2: ntdll: Unify get_file_info and fd_get_file_info. https://gitlab.winehq.org/wine/wine/-/merge_requests/942

4 7

[PATCH 0/4] MR943: uiautomationcore: Add more nested node features. (v2)
by Connor McAdams (＠cmcadams) 27 Sep '22

27 Sep '22

Changes since last MR: - Store list entry inside of `struct uia_node` instead of doing linear search for removal. - Replace `WARN` with `ERR` if provider thread shuts down with nodes still in the provider thread list. - Use `wine/rbtree.h` for looking up HUIANODEs by runtime ID. - Get rid of `struct uia_node *container_node` inside of `struct uia_provider`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/943

2 6

[PATCH 0/1] MR18: include: Use __MINGW_PRINTF_FORMAT when compiling with MinGW.
by Zebediah Figura (＠zfigura) 27 Sep '22

27 Sep '22

The default for MinGW is always ms_printf rather than gnu_printf, but if we are using ucrtbase or ANSI stdio, we want gnu_printf. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/18

4 3

[PATCH 0/1] MR19: maintainers: New file.
by Zebediah Figura (＠zfigura) 27 Sep '22

27 Sep '22

Based on the Wine maintainers file. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/19

4 3

[PATCH 0/5] MR944: win32u: Make desktop resize logic asynchronous.
by Rémi Bernon (＠rbernon) 27 Sep '22

27 Sep '22

To avoid direct callbacks from display drivers to win32u while changing display settings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/944

2 6

[PATCH v2 0/4] MR908: uiautomationcore: Add more nested node features.
by Connor McAdams (＠cmcadams) 27 Sep '22

27 Sep '22

Add the ability to disconnect nested node providers, and return element properties for nested nodes. -- v2: uiautomationcore: Add UIAutomationType_Element property support for nested node providers. uiautomationcore: Implement UiaDisconnectProvider. uiautomationcore: Track all HUIANODEs returned from the provider thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/908

3 13

[PATCH 0/1] MR942: ntdll: Unify get_file_info and fd_get_file_info.
by Joel Holdsworth (＠jhol) 27 Sep '22

27 Sep '22

In the ntdll file handling code, there are currently two duplicated file info setting functions: `get_file_info` and `fd_get_file_info`. One pasted on path strings, and the other based on file descriptors respectively. This patch set simplifies the code by unifying both functions into a single function powered by `fstatat` instead of `lstat` and `fstat`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/942

4 4

Re: [PATCH v2 0/8] MR924: ntdll: Add support for DOS file attributes
by Erich Hoover (＠ehoover) 27 Sep '22

27 Sep '22

> ... > > My gut is that if extended attributes are "universal enough" > (and usable enough), and we can easily implement DOS attributes over > them, modulo slight differences in the API, then there isn't really any > need to implement something truly portable. I could be wrong about this, > though. What platforms do you consider to be important here? I ask because the current implementation (without fallback) supports Linux, Mac OS, FreeBSD, and NetBSD. That seems to me to be the "important" ones. > > There is also the storage of [NT extended-attribute (EA)](https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/n…) values to consider, when we move toward a non-stub implementation of this feature. > > > > Perhaps it would be preferable to produce a design that can be encompass all these issues. The NTFS spec separates DOS Attributes (Flags) from Extended Attributes (EA). I would not recommend mixing the two, for fear of an accidental name collision. If you want to design a fallback mechanism that supports both of these features the same way, then I would suggest structuring it like so: ``` .WINE_METADATA/<filename>/<feature> ``` That way when a copy/move operation is performed on a file then it's easier to copy both features together. > I don't have a good read on this, personally. I suppose it at least > partly depends on whether NT extended attributes are used by any > program. I'm at least not aware of any usage? I am not aware of any non-MS usage, but it is documented. So, I would not be surprised if some copy protection mechanism does something with it our chooses to do so at some point in the future. I do know that the Single Instance Storage (SIS) minifilter driver uses an extended attribute to "back reference" the single instance files to find the duplicates/originals. > I think working out the design completely before submitting any patches > would probably be a good idea. > > ... If the OS list above is sufficient then I think we're covered, if we need a fallback implementation then this probably needs a little more thought. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/924#note_9410

1 0

[PATCH v16 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 27 Sep '22

27 Sep '22

-- v16: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 7

2025

2024

2023

2022

wine-gitlab