- wine-gitlab - winehq.org

[PATCH v5 0/6] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon (＠rbernon) 27 Sep '22

27 Sep '22

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- v5: win32u: Read mode from the registry if GetCurrentDisplaySettings fails. win32u: Write display settings to the registry in apply_display_settings. win32u: Lock display devices while applying display settings. win32u: Force update display cache after NtUserChangeDisplaySettingsEx. win32u: Introduce a new VirtualScreenRectChanged display driver callback. win32u: Add a BOOL force parameter to update_display_cache. https://gitlab.winehq.org/wine/wine/-/merge_requests/551

3 11

[PATCH v15 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 27 Sep '22

27 Sep '22

-- v15: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag server: Create \REGISTRY\A hive. ntdll: Rename NtLoadKeyEx parameters. ntdll: Pass filename to server in NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 7

[PATCH 0/1] MR941: winevulkan: Always use params to return Unix thunks result.
by Jacek Caban (＠jacek) 27 Sep '22

27 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/941

2 1

[PATCH v2 0/2] MR930: Add tests for GetConsoleTitle() and return correct title length
by Hugh McMaster (＠hmc) 27 Sep '22

27 Sep '22

-- v2: kernelbase: Return full title length from GetConsoleTitle() kernel32/tests: Add tests for GetConsoleTitle() https://gitlab.winehq.org/wine/wine/-/merge_requests/930

4 6

Re: [PATCH v2 0/1] MR11: vkd3d: Add a macro to mark unreachable code. - approved
by Henri Verbeet (＠hverbeet) 27 Sep '22

27 Sep '22

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/11

1 0

[PATCH 0/1] MR21: vkd3d: Avoid an unused variable warning when building for Win32.
by Zebediah Figura (＠zfigura) 27 Sep '22

27 Sep '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/21

3 2

[PATCH 0/1] MR20: vkd3d-common: Tweak the WARN for VKD3D_ERROR_INVALID_SHADER.
by Zebediah Figura (＠zfigura) 27 Sep '22

27 Sep '22

vkd3d-shader does not consume only bytecode anymore. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/20

3 2

[PATCH 0/4] MR17: Various HLSL refactoring.
by Zebediah Figura (＠zfigura) 27 Sep '22

27 Sep '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/17

3 5

[PATCH 0/1] MR933: wined3d: Set name of internal threads.
by Brendan Shanks (＠bshanks) 27 Sep '22

27 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/933

5 6

[PATCH 0/1] MR903: ddraw: Add FPS tracing in ddraw_surface_update_frontbuffer().
by Zebediah Figura (＠zfigura) 27 Sep '22

27 Sep '22

This usually doesn't go through the normal presentation paths. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/903

5 5

[PATCH v2 0/4] MR902: d3d9: Use a separate draw texture for managed resources.
by Zebediah Figura (＠zfigura) 27 Sep '22

27 Sep '22

-- v2: d3d9: Use a separate draw texture for managed resources. d3d9: Add reference counting helpers for textures. https://gitlab.winehq.org/wine/wine/-/merge_requests/902

3 5

[PATCH 0/1] MR940: krnl386.exe16: Don't pass NULL to printf/%s).
by eric pouech (＠epo) 27 Sep '22

27 Sep '22

GCC12.2 emits a warning here. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/940

2 1

[PATCH 0/2] MR939: Dumping DBI hash information from PDB files.
by eric pouech (＠epo) 27 Sep '22

27 Sep '22

i -- https://gitlab.winehq.org/wine/wine/-/merge_requests/939

2 2

[PATCH 0/1] MR938: dbghelp: SymFromName* should first look in local context.
by eric pouech (＠epo) 27 Sep '22

27 Sep '22

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/938

2 1

Re: [PATCH v3 0/2] MR897: oleaut32: dereference VT_RECORD|VT_BYREF in place.
by Alexandre Julliard (＠julliard) 27 Sep '22

27 Sep '22

> @julliard, did you intend merge this despite the failing conformance tests (see thread above from Marvin)? No, my mistake, sorry, it shouldn't have been merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/897#note_9350

1 0

[PATCH v3 0/8] MR871: ntdll: Fill the IOSB only inside the if (alerted) block in multiple functions.
by Zebediah Figura (＠zfigura) 27 Sep '22

27 Sep '22

-- v3: ntdll: Combine the "if (alerted)" blocks in sock_transmit(). ntdll: Fill the IOSB in sock_transmit() only inside the "if (alerted)" block. ntdll: Combine the "if (alerted)" blocks in sock_send(). ntdll: Fill the IOSB in sock_send() only inside the "if (alerted)" block. ntdll: Combine the "if (alerted)" blocks in sock_recv(). ntdll: Fill the IOSB in sock_recv() only inside the "if (alerted)" block. ntdll: The async handle passed to set_async_direct_result() cannot be NULL. ws2_32/tests: Add more tests for iosb contents while a recv is pending. https://gitlab.winehq.org/wine/wine/-/merge_requests/871

2 8

Re: [PATCH v2 0/1] MR11: vkd3d: Add a macro to mark unreachable code. - approved
by Zebediah Figura (＠zfigura) 27 Sep '22

27 Sep '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/11

1 0

Re: [PATCH v3 0/2] MR897: oleaut32: dereference VT_RECORD|VT_BYREF in place.
by Kevin Puetz (＠puetzk) 26 Sep '22

26 Sep '22

@julliard, did you intend merge this despite the failing conformance tests (see thread above from Marvin)? I still think the fix is "correct", i.e. this *should* workand windows is just buggy too - but the conformance tests certainly showed my fix is not really justified (since this doesn't work on windows either) and our use that led me to make this change was just getting lucky in a weird way and needs to be changed. I hadn't just closed it because I was going to eventually salvage the tests into a fix for the memleak they revealed. But I wasn't expecting you'd to accept it after Marvin shot me down... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/897#note_9337

1 0

Re: [PATCH v2 0/8] MR924: ntdll: Add support for DOS file attributes
by Joel Holdsworth (＠jhol) 26 Sep '22

26 Sep '22

On Mon Sep 26 19:51:22 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > Hello Joel, > I haven't looked at these patches in detail, largely because there's > still outstanding test failures, but I do have one high-level comment, > which is that I'd recommend starting with the basic implementation (i.e. > just the first four patches), and leave the rest for separate merge > requests. Since merge requests can only be applied as a whole I think it > makes sense to narrow this down to a more minimal set, and try to get > one thing done at a time. > ``` Hi Zebediah - thanks for taking a look. I don't mind narrowinging the commit series down. This patch set is mainly trying to get these attribute flags working: * `FILE_ATTRIBUTE_HIDDEN` * `FILE_ATTRIBUTE_SYSTEM` * `FILE_ATTRIBUTE_READONLY` (to a lesser extent - because this is already quite well represented by UNIX access permissions) The trouble is that while we want to seamlessly integrate with the underlying filesystems, the availability of different methods varies between operating systems and filesystems. This version of the patch set offers three strategies, and I found a two more possible methods that should be added today ([1](https://man7.org/linux/man-pages/man2/ioctl_iflags.2.html) [2](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/… ). The code attempts to store the flags by all available methods at once for a given file, and ORs the flags together from any available source, in the hopes we can deliver the most complete coverage to the user. However, because there is no fallback method, it is currenly not possible to guaruantee that the attributes will always be stored and retrieved correctly in all scenaries. If we only include the first four patches, the patch set will only support storage in Samba-formatted Extended File Attributes. If we unmark the associated test cases as `todo_wine`, the test will break on certain operating systems or certain mount flag choices. There is no support for Extended Attributes on FreeBSD or NetBSD, for example, and the MacOS Extended Atrribute APIs differ from the Linux ones. One approach is to fall back to using a `.dosattributes` directory when no other storage method is available, and store the attributes in files inside there. However, I didn't want to implement this functionality before having a conversation with the Wine project developers. I have been in conversation with @ehoover in the last couple of days concerning his work on Junction Points, which is a related topic to DOS attributes, and also causes issues for Msys2 in its own right. His strategy is to store the required metadata in a [`.REPARSE_POINT` hidden directory](https://github.com/wine-staging/wine-staging/blob/master/patches…. There is also the storage of [NT extended-attribute (EA)](https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/n…) values to consider, when we move toward a non-stub implementation of this feature. Perhaps it would be preferable to produce a design that can be encompass all these issues. Do we need to resolve this design question here and now? Or can we just proceed with Linux-only Extended Attributes in the short term? I think it would be good if we could get some feedback from the project maintainers on these questions. Do you have any thoughts? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/924#note_9292

2 1

Re: [PATCH v2 0/8] MR924: ntdll: Add support for DOS file attributes
by Erich Hoover (＠ehoover) 26 Sep '22

26 Sep '22

On Mon Sep 26 21:52:01 2022 +0000, Joel Holdsworth wrote: > That sounds like an nice easy path forward. > One practical question. How do I make the test case `todo_wine` in some > cases, an not in others? Do I just have to comment out the test? Or is > there a trick to indicate that inconsistency between plaforms is expected? Like this: ``` todo_wine_if (my_todo_flag) ok (returned_value == expected_value, "expected %x, got %x\n", expected_value, returned_value); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/924#note_9331

1 0

Re: [PATCH v2 0/8] MR924: ntdll: Add support for DOS file attributes
by Joel Holdsworth (＠jhol) 26 Sep '22

26 Sep '22

On Mon Sep 26 21:41:12 2022 +0000, Erich Hoover wrote: > @jhol I believe that @zfigura's suggestion to just merge the first four > patches is in-line with what AJ has previously said. If I had to > summarize his comments, I would say that they are to: > 1. move the code out of ports and into file (already done) > 2. submit the initial request for the support of one key platform > (Linux, first four patches) > 3. make sure the "key platform" support is extensible (already done) > 4. submit additional requests for each additional platform, one at a time > If you want to add a "fallback" behavior (which I think is reasonable), > then I would suggest that that be treated as an "additional platform" > after you have the initial support in place. Others might have a > different opinion. That sounds like an nice easy path forward. One practical question. How do I make the test case `todo_wine` in some cases, an not in others? Do I just have to comment out the test? Or is there a trick to indicate that inconsistency between plaforms is expected? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/924#note_9330

1 0

[PATCH 0/1] MR934: wininet: Set thread name for collect_connections_proc.
by Brendan Shanks (＠bshanks) 26 Sep '22

26 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/934

3 2

Re: [PATCH v2 0/8] MR924: ntdll: Add support for DOS file attributes
by Erich Hoover (＠ehoover) 26 Sep '22

26 Sep '22

On Mon Sep 26 20:25:30 2022 +0000, Joel Holdsworth wrote: > Hi Zebediah - thanks for taking a look. > I don't mind narrowinging the commit series down. > This patch set is mainly trying to get these attribute flags working: > * `FILE_ATTRIBUTE_HIDDEN` > * `FILE_ATTRIBUTE_SYSTEM` > * `FILE_ATTRIBUTE_READONLY` (to a lesser extent - because this is > already quite well represented by UNIX access permissions) > The trouble is that while we want to seamlessly integrate with the > underlying filesystems, the availability of different methods varies > between operating systems and filesystems. This version of the patch set > offers three strategies, and I found a two more possible methods that > should be added today > ([1](https://man7.org/linux/man-pages/man2/ioctl_iflags.2.html) > [2](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/… > ). > The code attempts to store the flags by all available methods at once > for a given file, and ORs the flags together from any available source, > in the hopes we can deliver the most complete coverage to the user. > However, because there is no fallback method, it is currenly not > possible to guaruantee that the attributes will always be stored and > retrieved correctly in all scenaries. > If we only include the first four patches, the patch set will only > support storage in Samba-formatted Extended File Attributes. If we > unmark the associated test cases as `todo_wine`, the test will break on > certain operating systems or certain mount flag choices. There is no > support for Extended Attributes on FreeBSD or NetBSD, for example, and > the MacOS Extended Atrribute APIs differ from the Linux ones. > One approach is to fall back to using a `.dosattributes` directory when > no other storage method is available, and store the attributes in files > inside there. However, I didn't want to implement this functionality > before having a conversation with the Wine project developers. > I have been in conversation with @ehoover in the last couple of days > concerning his work on Junction Points, which is a related topic to DOS > attributes, and also causes issues for Msys2 in its own right. His > strategy is to store the required metadata in a [`.REPARSE_POINT` hidden directory](https://github.com/wine-staging/wine-staging/blob/master/patches…. > There is also the storage of [NT extended-attribute > (EA)](https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/n…) > values to consider, when we move toward a non-stub implementation of > this feature. > Perhaps it would be preferable to produce a design that can be encompass > all these issues. > Do we need to resolve this design question here and now? Or can we just > proceed with Linux-only Extended Attributes in the short term? > I think it would be good if we could get some feedback from the project > maintainers on these questions. Do you have any thoughts? @jhol I believe that @zfigura's suggestion to just merge the first four patches is in-line with what AJ has previously said. If I had to summarize his comments, I would say that they are to: 1. move the code out of ports and into file (already done) 2. submit the initial request for the support of one key platform (Linux, first four patches) 3. make sure the "key platform" support is extensible (already done) 4. submit additional requests for each additional platform, one at a time If you want to add a "fallback" behavior (which I think is reasonable), then I would suggest that that be treated as an "additional platform" after you have the initial support in place. Others might have a different opinion. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/924#note_9327

1 0

Re: [PATCH v2 0/8] MR927: wmvcore: Use more IWMSyncReader methods in the async reader. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/927

1 0

Re: [PATCH v2 0/1] MR931: dbghelp: Fix local scope reset upon module unloading. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/931

1 0

Re: [PATCH v2 0/1] MR928: po: Update Dutch translation - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/928

1 0

Re: [PATCH v2 0/1] MR926: vulkan-1/tests: Fix test failures on llvmpipe. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/926

1 0

Re: [PATCH v2 0/1] MR917: rpcrt4: Set the name of internal threads. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/917

1 0

Re: [PATCH v2 0/1] MR918: ntdll: Set the name of internal thread pool threads. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/918

1 0

Re: [PATCH v10 0/1] MR734: tests: Make sure only one thread prints traces at a time. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/734

1 0

Re: [PATCH v2 0/1] MR922: odbc: SQLGetInfoW allow NULL parameter InfoValue. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/922

1 0

Re: [PATCH v3 0/2] MR897: oleaut32: dereference VT_RECORD|VT_BYREF in place. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/897

1 0

Re: [PATCH v6 0/2] MR898: scrrun: Fix FileSystemObject.OpenTextFile when writing to existing files. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/898

1 0

Re: [PATCH v2 0/1] MR925: light.msstyles: Use a darker color for inactive captions. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/925

1 0

Re: [PATCH v2 0/4] MR923: winevulkan: Separate 32-bit and 64-bit thunks implementation. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/923

1 0

Re: [PATCH v4 0/4] MR899: vbscript: Map known HRESULT values into their FACILITY_VBS counterparts. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/899

1 0

Re: [PATCH v2 0/1] MR921: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/921

1 0

Re: [PATCH v2 0/1] MR919: ntdll: Fix processor package mask in SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX structure. - approved
by Alexandre Julliard (＠julliard) 26 Sep '22

26 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/919

1 0

[PATCH 0/8] MR924: ntdll: Add support for DOS file attributes
by Joel Holdsworth (＠jhol) 26 Sep '22

26 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n…, and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These have been implemented in various ways depending upon the capabilities of the operating system and the file system. # Storage Methods ## FAT MSDOS file attributes * Linux: [`ioctl_fat(2)`](https://www.man7.org/linux/man-pages/man2/ioctl_fat.2.html) On Linux, the FAT filesystem implementation allows DOS file attributes to be applied to files and queried through a family of ioctls. Note that these ioctls are not yet supported by the NTFS or CIFS drivers. ## Extended File Attributes * Linux: [`xattr(7)`](https://www.man7.org/linux/man-pages/man7/xattr.7.html) * MacOS: [`getxattr(2)`](https://www.unix.com/man-page/osx/2/getxattr/), [`setxattr(2)`](https://www.unix.com/man-page/osx/2/setxattr/), [`removexattr(2)`](https://www.unix.com/man-page/osx/2/removexattr/) * FreeBSD, NetBSD: [`extattr(2)`](https://nixdoc.net/man-pages/FreeBSD/man2/extattr.2.html) Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value. Note that although FreeBSD and NetBSD support the extended attribute system calls, these are not currently implemented in the operating system, or supported in any of their filesystem drivers. ## BSD File Flags * MacOS: [`fchflags(2)`](https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/fchflags.2.html) * FreeBSD, NetBSD: [`fchflags(2)`](https://nixdoc.net/man-pages/FreeBSD/man2/fchflags.2.html) On some BSD-like operating systems including MacOS, FreeBSD and NetBSD, the `struct stat` structure contains the `st_flags` member can carry flags of which the following can be used to represent DOS attributes: * `UF_IMMUTABLE` can represent `FILE_ATTRIBUTE_READONLY` * `UF_HIDDEN` can reprent `FILE_ATTRIBUTE_HIDDEN` (not available on NetBSD) # Design The implementation is takes an opportunistic approach. It will attempt to store flags by any of the above mentioned methods, and will retrieve flags using any available method and will combine flags from multiple sources together. # See Also * https://bugs.winehq.org/show_bug.cgi?id=9158 * https://bugs.winehq.org/show_bug.cgi?id=15679 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/924

5 12

[PATCH 0/8] MR927: wmvcore: Use more IWMSyncReader methods in the async reader.
by Rémi Bernon (＠rbernon) 26 Sep '22

26 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/927

3 9

[PATCH 0/5] MR932: cocmtl32: propsheet tests
by Piotr Caban (＠piotr) 26 Sep '22

26 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/932

3 7

[PATCH v2 0/2] MR910: msvcrt: Implement dynamic string container
by Stefan Rentsch (＠restet) 26 Sep '22

26 Sep '22

Many code sections still use fixed-size arrays on stack - or even worse - `strcat` in combination with strings of unknown length. This MR/PR provides general purpose Wine-internal functions for safer string handling. The functions are currently header-only to not pollute msvcrt exports. The API was written for an upcoming shell32/shlexec patch (WIP) to properly fix possible stack corruptions due to out-of-bounds writes for unexpected long paths or URLs. This is a dynamic container inspired by C++ std::string / std::vector with wide/narrow conversion and formatted text. Growth factor = 2 for simplicity. Differences to `STRING`/`UNICODE_STRING` (`RtlCreateUnicodeString` and similar): * No USHORT length limitation * Actual dynamic resizable container * String formatting and conversion support * Short and consistent API naming New test added to msvcrt: `winestring` -- v2: Various improvements and fixes https://gitlab.winehq.org/wine/wine/-/merge_requests/910

4 7

[PATCH 0/1] MR931: dbghelp: Fix local scope reset upon module unloading.
by eric pouech (＠epo) 26 Sep '22

26 Sep '22

Change strategy for resetting local scope when unloading a module. Old strategy was keeping the local scoped symbol alive on some code path when unloading a module. This caused some bad behavior as we kept a pointer to a deleted object. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/931

2 1

[PATCH v4 0/6] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon (＠rbernon) 26 Sep '22

26 Sep '22

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- v4: win32u: Read mode from the registry if GetCurrentDisplaySettings fails. win32u: Write display settings to the registry in apply_display_settings. win32u: Lock display devices while applying display settings. win32u: Force update display cache after NtUserChangeDisplaySettingsEx. win32u: Introduce a new VirtualScreenRectChanged display driver callback. win32u: Add a BOOL force parameter to update_display_cache. https://gitlab.winehq.org/wine/wine/-/merge_requests/551

3 7

[PATCH v4 0/1] MR745: ntdll: Improve stub of NtQueryEaFile.
by Joel Holdsworth (＠jhol) 26 Sep '22

26 Sep '22

Based on a patch by Qian Hong. -- v4: ntdll: Improve stub of NtQueryEaFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/745

3 2

[PATCH v14 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 26 Sep '22

26 Sep '22

-- v14: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 8

[PATCH v2 0/6] MR874: mfmediaengine: Add tests to exhibit inverted video rendering.
by Rémi Bernon (＠rbernon) 26 Sep '22

26 Sep '22

This shows that media session samples are correctly oriented, but that mfmediaengine renders them upside down. -- v2: mfmediaengine: Remove vertical flipping of video frames. mfmediaengine/tests: Check IMFMediaEngine_TransferVideoFrames output orientation. mfmediaengine/tests: Pass a device and output format to create_media_engine. mf: Avoid clearing media session command list while it is running. mf/tests: Check sample grabber RGB / NV12 orientation. mf/tests: Factor test grabber callback implementations. https://gitlab.winehq.org/wine/wine/-/merge_requests/874

3 10

[PATCH 0/1] MR930: kernel32/tests: Add tests for GetConsoleTitle()
by Hugh McMaster (＠hmc) 26 Sep '22

26 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/930

2 1

[PATCH 0/12] MR929: mf/tests: More MF transform test factorization and small fixes.
by Rémi Bernon (＠rbernon) 26 Sep '22

26 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/929

3 13

[PATCH 0/1] MR928: po: Update Dutch translation
by Floris Renaud (＠jkfloris) 26 Sep '22

26 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/928

2 1

[PATCH 0/1] MR917: rpcrt4: Set the name of internal threads.
by Brendan Shanks (＠bshanks) 26 Sep '22

26 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/917

3 2

[PATCH 0/1] MR926: vulkan-1/tests: Fix test failures on llvmpipe.
by Zhiyi Zhang (＠zhiyi) 26 Sep '22

26 Sep '22

This happens because the llvmpipe virtual GPU is not in the RandR provider list when there is a hardware GPU driving the screen. So LUID for the llvmpipe is not generated in such cases. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52931 Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/926

2 1

[PATCH 0/1] MR925: light.msstyles: Use a darker color for inactive captions.
by Zhiyi Zhang (＠zhiyi) 26 Sep '22

26 Sep '22

Fix invisible disabled menu item text in Subtitle Workshop Classic 6.1.4. The application happens to use 0xF0F0F0 as the menu background and the inactive caption color to draw disabled menu item text. In Light theme, the inactive caption color is very close to 0xF0F0F0, thus causing the invisible text. So use a darker color for inactive captions to avoid this issue. The inactive caption text color is also adjusted accordingly. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53575 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/925

2 1

[PATCH v4 0/1] MR914: ntoskrnl.exe: Implement various KeQuery* functions
by Etaash Mathamsetty (＠etaash.mathamsetty) 25 Sep '22

25 Sep '22

mrac tries to get function pointers for these functions using MmGetSystemRoutineAddress, I haven't seen them being used by it, but might as well implement it since they are very easy to implement. -- v4: ntoskrnl.exe: Implement various KeQuery* functions https://gitlab.winehq.org/wine/wine/-/merge_requests/914

2 1

[PATCH v4 0/8] MR916: ntdll: Added support for DOS file attributes
by Joel Holdsworth (＠jhol) 25 Sep '22

25 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n…, and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These have been implemented in various ways depending upon the capabilities of the operating system and the file system. # Storage Methods ## FAT MSDOS file attributes * Linux: [`ioctl_fat(2)`](https://www.man7.org/linux/man-pages/man2/ioctl_fat.2.html) On Linux, the FAT filesystem implementation allows DOS file attributes to be applied to files and queried through a family of ioctls. Note that these ioctls are not yet supported by the NTFS or CIFS drivers. ## Extended File Attributes * Linux: [`xattr(7)`](https://www.man7.org/linux/man-pages/man7/xattr.7.html) * MacOS: [`getxattr(2)`](https://www.unix.com/man-page/osx/2/getxattr/), [`setxattr(2)`](https://www.unix.com/man-page/osx/2/setxattr/), [`removexattr(2)`](https://www.unix.com/man-page/osx/2/removexattr/) * FreeBSD, NetBSD: [`extattr(2)`](https://nixdoc.net/man-pages/FreeBSD/man2/extattr.2.html) Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value. Note that although FreeBSD and NetBSD support the extended attribute system calls, these are not currently implemented in the operating system, or supported in any of their filesystem drivers. ## BSD File Flags * MacOS: [`fchflags(2)`](https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/fchflags.2.html) * FreeBSD, NetBSD: [`fchflags(2)`](https://nixdoc.net/man-pages/FreeBSD/man2/fchflags.2.html) On some BSD-like operating systems including MacOS, FreeBSD and NetBSD, the `struct stat` structure contains the `st_flags` member can carry flags of which the following can be used to represent DOS attributes: * `UF_IMMUTABLE` can represent `FILE_ATTRIBUTE_READONLY` * `UF_HIDDEN` can reprent `FILE_ATTRIBUTE_HIDDEN` (not available on NetBSD) # Design The implementation is takes a permissive approach. It will attempt to store flags by any of the above mentioned methods, and will retrieve flags using any available method and will combine flags from multiple sources together. # See Also * https://bugs.winehq.org/show_bug.cgi?id=9158 * https://bugs.winehq.org/show_bug.cgi?id=15679 -- v4: ntdll: Added integration with MacOS/BSD st_flags ntdll: Add integration with Linux FAT file attributes ntdll: Add support for FreeBSD style extended attributes. ntdll: Add support for MacOS X style extended attributes. ntdll: Implement storing DOS attributes in NtCreateFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/916

4 11

[PATCH 0/4] MR923: winevulkan: Separate 32-bit and 64-bit thunks implementation.
by Jacek Caban (＠jacek) 25 Sep '22

25 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/923

2 4

[PATCH v3 0/4] MR899: vbscript: Map known HRESULT values into their FACILITY_VBS counterparts.
by Kevin Puetz (＠puetzk) 25 Sep '22

25 Sep '22

Map known HRESULT values into their FACILITY_VBS counterparts Unless the callee provided its own Description (e.g. via SetErrorInfo) VBscript maps certain well-known HRESULT values into its own error facility and messages, changing Err.Number and also setting Err.Source to itself (unless already provided, in which case it is left alone) e.g. if the invoked method returns E_NOINTERFACE, The VBScript Err object should show Err.Number: 0x1AE Err.Source: Microsoft VBScript runtime error Err.Description: Class doesn't support Automation Rather than the original HRESULT Err.Number: 0x80004002 -- v3: vbscript: do HRESULT->VBSERROR mapping for the whole EXCEPINFO at once. vbscript/tests: test throwException with Description but *not* Source. vbscript: only set EXCEPINFO strings for cases that map_hres translated. vbscript: Fix handling missing description in EXCEPINFO. https://gitlab.winehq.org/wine/wine/-/merge_requests/899

4 6

[PATCH 0/1] MR922: odbc: SQLGetInfoW allow NULL parameter InfoValue.
by Alistair Leslie-Hughes (＠alesliehughes) 24 Sep '22

24 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53714 MSDN states, a NULL InfoValue parameter will return as the length. unixODBC which we currently use, handles this scenario. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/922

2 1

[PATCH 0/1] MR910: msvcrt: Implement dynamic string container
by Stefan Rentsch (＠restet) 23 Sep '22

23 Sep '22

Many code sections still use fixed-size arrays on stack - or even worse - `strcat` in combination with strings of unknown length. This MR/PR provides general purpose Wine-internal functions for safer string handling. The functions are currently header-only to not pollute msvcrt exports. The API was written for an upcoming shell32/shlexec patch (WIP) to properly fix possible stack corruptions due to out-of-bounds writes for unexpected long paths or URLs. This is a dynamic container inspired by C++ std::string / std::vector with wide/narrow conversion and formatted text. Growth factor = 2 for simplicity. Differences to `STRING`/`UNICODE_STRING` (`RtlCreateUnicodeString` and similar): * No USHORT length limitation * Actual dynamic resizable container * String formatting and conversion support * Short and consistent API naming New test added to msvcrt: `winestring` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/910

5 7

[PATCH 0/1] MR16: vkd3d-shader/hlsl: Lower complex broadcasts.
by Francisco Casas (＠fcasas) 23 Sep '22

23 Sep '22

A rebase of the "Lower complex broadcasts" patch. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/16

4 6

[PATCH 0/1] MR921: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 23 Sep '22

23 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/921

3 2

Re: [PATCH v2 0/2] MR915: winevulkan: Use DECLSPEC_ALIGN instead of pshpack4.h. - approved
by Alexandre Julliard (＠julliard) 23 Sep '22

23 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/915

1 0

Re: [PATCH v4 0/7] MR844: win32u: Move display modes enumeration and WM_DISPLAYCHANGE out of graphics drivers. - approved
by Alexandre Julliard (＠julliard) 23 Sep '22

23 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/844

1 0

Re: [PATCH v3 0/1] MR900: notepad: Show goto dialog box. - approved
by Alexandre Julliard (＠julliard) 23 Sep '22

23 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/900

1 0

Re: [PATCH v2 0/1] MR913: winegstreamer: Avoid accessing NULL pointer if transform didn't provide a sample. - approved
by Alexandre Julliard (＠julliard) 23 Sep '22

23 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/913

1 0

Re: [PATCH v2 0/8] MR905: wmvcore: Use some sync reader methods from the async reader. - approved
by Alexandre Julliard (＠julliard) 23 Sep '22

23 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/905

1 0

Re: [PATCH v6 0/9] MR887: mf/tests: Improve MF transform output checks and dumps. - approved
by Alexandre Julliard (＠julliard) 23 Sep '22

23 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/887

1 0

[PATCH 0/1] MR919: ntdll: Fix processor package mask in SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX structure.
by Paul Gofman (＠gofman) 23 Sep '22

23 Sep '22

Fixes a regression introduced by commit 6aa437de6aa3549abd885c387ea79d18eb0eba56. logical_proc_info_add_by_id() updates the mask for cores belonging to package for already added RelationProcessorPackage. But now it updates it only for logical_proc_info and not logical_proc_info_ex structure by returning early when the package is found. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/919

2 1

[PATCH v9 0/1] MR734: tests: Make sure only one thread prints traces at a time.
by Francois Gouget (＠fgouget) 23 Sep '22

23 Sep '22

Some Wine tests are multi-threaded or start child processes which can result in traces and failure messages being garbled which prevents them from being recognized by continuous integration tools. So printing the tests messages is now serialized. Note that if a process crashes while holding the mutex, that mutex will be abandonned and not cause a deadlock. -- v9: tests: Make sure only one thread prints traces at a time. https://gitlab.winehq.org/wine/wine/-/merge_requests/734

2 2

[PATCH 0/1] MR918: ntdll: Set the name of internal thread pool threads.
by Brendan Shanks (＠bshanks) 23 Sep '22

23 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/918

2 1

[PATCH v2 0/2] MR897: oleauto: dereference VT_RECORD|VT_BYREF in place
by Kevin Puetz (＠puetzk) 23 Sep '22

23 Sep '22

VariantCopyInd allows pvargDest == pvargSrc in order to dereference in place To avoid confusing the source values and a partially-written destination, wine's implementation makes a shallow copy and uses that as pSrc. However, the call to VARIANT_CopyIRecordInfo did not use this, leading to it copying from the zeroed-out memory it just allocated. -- v2: oleaut32: dereference VT_RECORD|VT_BYREF in place. oleaut32/tests: get_test_recordinfo shouldn't point into a specific VARIANT. https://gitlab.winehq.org/wine/wine/-/merge_requests/897

3 6

[PATCH v3 0/8] MR916: ntdll: Added support for DOS file attributes
by Joel Holdsworth (＠jhol) 23 Sep '22

23 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n…, and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These have been implemented in various ways depending upon the capabilities of the operating system and the file system. # Storage Methods ## FAT MSDOS file attributes * Linux: [`ioctl_fat(2)`](https://www.man7.org/linux/man-pages/man2/ioctl_fat.2.html) On Linux, the FAT filesystem implementation allows DOS file attributes to be applied to files and queried through a family of ioctls. Note that these ioctls are not yet supported by the NTFS or CIFS drivers. ## Extended File Attributes * Linux: [`xattr(7)`](https://www.man7.org/linux/man-pages/man7/xattr.7.html) * MacOS: [`getxattr(2)`](https://www.unix.com/man-page/osx/2/getxattr/), [`setxattr(2)`](https://www.unix.com/man-page/osx/2/setxattr/), [`removexattr(2)`](https://www.unix.com/man-page/osx/2/removexattr/) * FreeBSD, NetBSD: [`extattr(2)`](https://nixdoc.net/man-pages/FreeBSD/man2/extattr.2.html) Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value. Note that although FreeBSD and NetBSD support the extended attribute system calls, these are not currently implemented in the operating system, or supported in any of their filesystem drivers. ## BSD File Flags * MacOS: [`fchflags(2)`](https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/fchflags.2.html) * FreeBSD, NetBSD: [`fchflags(2)`](https://nixdoc.net/man-pages/FreeBSD/man2/fchflags.2.html) On some BSD-like operating systems including MacOS, FreeBSD and NetBSD, the `struct stat` structure contains the `st_flags` member can carry flags of which the following can be used to represent DOS attributes: * `UF_IMMUTABLE` can represent `FILE_ATTRIBUTE_READONLY` * `UF_HIDDEN` can reprent `FILE_ATTRIBUTE_HIDDEN` (not available on NetBSD) # Design The implementation is takes a permissive approach. It will attempt to store flags by any of the above mentioned methods, and will retrieve flags using any available method and will combine flags from multiple sources together. # See Also * https://bugs.winehq.org/show_bug.cgi?id=9158 * https://bugs.winehq.org/show_bug.cgi?id=15679 -- v3: ntdll: Added integration with MacOS/BSD st_flags ntdll: Add integration with Linux FAT file attributes ntdll: Add support for FreeBSD style extended attributes. ntdll: Add support for MacOS X style extended attributes. ntdll: Implement storing DOS attributes in NtCreateFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/916

4 14

[PATCH v2 0/8] MR916: ntdll: Added support for DOS file attributes
by Joel Holdsworth (＠jhol) 23 Sep '22

23 Sep '22

This patch set is based upon patches from Wine Staging, and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These have been implemented in various ways depending upon the capabilities of the operating system and the file system. # Storage Methods ## FAT MSDOS file attributes * Linux: [`ioctl_fat(2)`](https://www.man7.org/linux/man-pages/man2/ioctl_fat.2.html) On Linux, the FAT filesystem implementation allows DOS file attributes to be applied to files and queried through a family of ioctls. Note that these ioctls are not yet supported by the NTFS or CIFS drivers. ## Extended File Attributes * Linux: [`xattr(7)`](https://www.man7.org/linux/man-pages/man7/xattr.7.html) * MacOS: [`getxattr(2)`](https://www.unix.com/man-page/osx/2/getxattr/), [`setxattr(2)`](https://www.unix.com/man-page/osx/2/setxattr/), [`removexattr(2)`](https://www.unix.com/man-page/osx/2/removexattr/) * FreeBSD, NetBSD: [`extattr(2)`](https://nixdoc.net/man-pages/FreeBSD/man2/extattr.2.html) Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value. Note that although FreeBSD and NetBSD support the extended attribute system calls, these are not currently implemented in the operating system, or supported in any of their filesystem drivers. ## BSD File Flags * MacOS: [`fchflags(2)`](https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/fchflags.2.html) * FreeBSD, NetBSD: [`fchflags(2)`](https://nixdoc.net/man-pages/FreeBSD/man2/fchflags.2.html) On some BSD-like operating systems including MacOS, FreeBSD and NetBSD, the `struct stat` structure contains the `st_flags` member can carry flags of which the following can be used to represent DOS attributes: * `UF_IMMUTABLE` can represent `FILE_ATTRIBUTE_READONLY` * `UF_HIDDEN` can reprent `FILE_ATTRIBUTE_HIDDEN` (not available on NetBSD) # Design The implementation is takes a permissive approach. It will attempt to store flags by any of the above mentioned methods, and will retrieve flags using any available method and will combine flags from multiple sources together. # See Also * https://bugs.winehq.org/show_bug.cgi?id=9158 * https://bugs.winehq.org/show_bug.cgi?id=15679 -- v2: ntdll: Added integration with MacOS/BSD st_flags https://gitlab.winehq.org/wine/wine/-/merge_requests/916

4 14

[PATCH v2 0/1] MR899: vbscript: Map known HRESULT values into their FACILITY_VBS counterparts.
by Kevin Puetz (＠puetzk) 23 Sep '22

23 Sep '22

Map known HRESULT values into their FACILITY_VBS counterparts Unless the callee provided its own Description (e.g. via SetErrorInfo) VBscript maps certain well-known HRESULT values into its own error facility and messages, changing Err.Number and also setting Err.Source to itself (unless already provided, in which case it is left alone) e.g. if the invoked method returns E_NOINTERFACE, The VBScript Err object should show Err.Number: 0x1AE Err.Source: Microsoft VBScript runtime error Err.Description: Class doesn't support Automation Rather than the original HRESULT Err.Number: 0x80004002 -- v2: vbscript: Map known HRESULT values into their FACILITY_VBS counterparts. https://gitlab.winehq.org/wine/wine/-/merge_requests/899

3 8

[PATCH 0/8] MR916: Added support for DOS file attributes
by Joel Holdsworth (＠jhol) 23 Sep '22

23 Sep '22

This patch set is based upon patches from Wine Staging, and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These have been implemented in various ways depending upon the capabilities of the operating system and the file system. # Storage Methods ## FAT MSDOS file attributes * Linux: [`ioctl_fat(2)`](https://www.man7.org/linux/man-pages/man2/ioctl_fat.2.html) On Linux, the FAT filesystem implementation allows DOS file attributes to be applied to files and queried through a family of ioctls. Note that these ioctls are not yet supported by the NTFS or CIFS drivers. ## Extended File Attributes * Linux: [`xattr(7)`](https://www.man7.org/linux/man-pages/man7/xattr.7.html) * MacOS: [`getxattr(2)`](https://www.unix.com/man-page/osx/2/getxattr/), [`setxattr(2)`](https://www.unix.com/man-page/osx/2/setxattr/), [`removexattr(2)`](https://www.unix.com/man-page/osx/2/removexattr/) * FreeBSD, NetBSD: [`extattr(2)`](https://nixdoc.net/man-pages/FreeBSD/man2/extattr.2.html) Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value. Note that although FreeBSD and NetBSD support the extended attribute system calls, these are not currently implemented in the operating system, or supported in any of their filesystem drivers. ## BSD File Flags * MacOS: [`fchflags(2)`](https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/fchflags.2.html) * FreeBSD, NetBSD: [`fchflags(2)`](https://nixdoc.net/man-pages/FreeBSD/man2/fchflags.2.html) On some BSD-like operating systems including MacOS, FreeBSD and NetBSD, the `struct stat` structure contains the `st_flags` member can carry flags of which the following can be used to represent DOS attributes: * `UF_HIDDEN` can reprent `FILE_ATTRIBUTE_HIDDEN` * `UF_IMMUTABLE` can represent `FILE_ATTRIBUTE_READONLY` (not available on NetBSD) # Design The implementation is takes a permissive approach. It will attempt to store flags by any of the above mentioned methods, and will retrieve flags using any available method and will combine flags from multiple sources together. # See Also * https://bugs.winehq.org/show_bug.cgi?id=9158 * https://bugs.winehq.org/show_bug.cgi?id=15679 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/916

4 14

[PATCH v13 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 23 Sep '22

23 Sep '22

-- v13: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag server: Create \REGISTRY\A hive. ntdll: Rename NtLoadKeyEx parameters. ntdll: Pass filename to server in NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 8

[PATCH v12 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 23 Sep '22

23 Sep '22

-- v12: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag server: Create \REGISTRY\A hive. ntdll: Rename NtLoadKeyEx parameters. ntdll: Pass filename to server in NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 17

[PATCH 0/2] MR915: winevulkan: Use DECLSPEC_ALIGN instead of pshpack4.h.
by Jacek Caban (＠jacek) 23 Sep '22

23 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/915

2 2

[PATCH v3 0/7] MR844: win32u: Move display modes enumeration and WM_DISPLAYCHANGE out of graphics drivers.
by Rémi Bernon (＠rbernon) 23 Sep '22

23 Sep '22

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/551. -- v3: win32u: Broadcast WM_DISPLAYCHANGE message on display settings change. win32u: Lock display devices mutex in find_adapter. win32u: Use find_adapter_device_by_(name|id) helpers in find_adapter. win32u: Factor out display_device lookup in separate helpers. winemac.drv: Stop using the cached_modes_mutex for get_default_bpp. win32u: Move enumeration of available modes out of graphics drivers. user32/tests: Cleanup sysparams WM_DISPLAYCHANGE tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/844

3 8

[PATCH v2 0/7] MR844: win32u: Move display modes enumeration and WM_DISPLAYCHANGE out of graphics drivers.
by Rémi Bernon (＠rbernon) 23 Sep '22

23 Sep '22

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/551. -- v2: win32u: Broadcast WM_DISPLAYCHANGE message on display settings change. win32u: Lock display devices mutex in find_adapter. win32u: Use find_adapter_device_by_(name|id) helpers in find_adapter. win32u: Factor out display_device lookup in separate helpers. winemac.drv: Move and lock cache static variables within get_default_bpp. win32u: Move enumeration of available modes out of graphics drivers. user32/tests: Cleanup sysparams WM_DISPLAYCHANGE tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/844

3 13

[PATCH v5 0/2] MR898: scrrun: Fix bugs in FileSystemObject text-file handling
by Kevin Puetz (＠puetzk) 23 Sep '22

23 Sep '22

Fix bugs in FileSystemObject text-file handling OpenTextFile(...,ForWriting,True) should either create a new file, or open and truncate an existing one OpenTextFile(...,ForAppending,?,True) should write a BOM if appending to an existing-but-empty file -- v5: scrrun: Fix FileSystemObject.OpenTextFile when writing to existing files. scrrun/tests: Introduce a test_file_contents helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/898

3 4

[PATCH v2 0/1] MR900: notepad: Show goto dialog box.
by Jacob Czekalla (＠Maaka00524) 23 Sep '22

23 Sep '22

-- v2: notepad: Show goto dialog box. https://gitlab.winehq.org/wine/wine/-/merge_requests/900

3 2

[PATCH v3 0/2] MR898: scrrun: Fix bugs in FileSystemObject text-file handling
by Kevin Puetz (＠puetzk) 23 Sep '22

23 Sep '22

Fix bugs in FileSystemObject text-file handling OpenTextFile(...,ForWriting,True) should either create a new file, or open and truncate an existing one OpenTextFile(...,ForAppending,?,True) should write a BOM if appending to an existing-but-empty file -- v3: scrrun: Fix bugs in FileSystemObject text-file handling scrrun/tests: Introduce a test_file_contents helper https://gitlab.winehq.org/wine/wine/-/merge_requests/898

2 2

[PATCH v3 0/8] MR856: mshtml: url prop for Storage Events and improvements.
by Gabriel Ivăncescu (＠insn) 22 Sep '22

22 Sep '22

-- v3: mshtml: Silence a FIXME when parameter is missing. mshtml: Create non-gecko events properly from type string. mshtml: Use actual event type to create the event instead of the event id. mshtml: Expand event_info to include a special entry for EVENTID_LAST. mshtml: Use actual Gecko event type for MessageEvent and StorageEvent. mshtml: Implement url prop for StorageEvent. include/mshtml: Move some forward interface declarations to match Windows SDK. mshtml: Override document.URL's name when adding it from the mshtml typelib. https://gitlab.winehq.org/wine/wine/-/merge_requests/856

4 14

[PATCH v2 0/1] MR914: ntoskrnl.exe: Implement various KeQuery* functions
by Etaash Mathamsetty (＠etaash.mathamsetty) 22 Sep '22

22 Sep '22

mrac tries to get function pointers for these functions using MmGetSystemRoutineAddress, I haven't seen them being used by it, but might as well implement it since they are very easy to implement. -- v2: ntoskrnl.exe: Implement various KeQuery* functions https://gitlab.winehq.org/wine/wine/-/merge_requests/914

2 2

[PATCH 0/1] MR913: winegstreamer: Avoid accessing NULL pointer if transform didn't provide a sample.
by Rémi Bernon (＠rbernon) 22 Sep '22

22 Sep '22

This can happen with asynchronous decoding, such as with the VA-API decodebin plugin for H264. This fixes the mf transform tests crashing when VA-API plugins are used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/913

3 2

[PATCH 0/8] MR905: wmvcore: Use some sync reader methods from the async reader.
by Rémi Bernon (＠rbernon) 22 Sep '22

22 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/905

3 9

Re: [PATCH v2 0/1] MR904: avifil32: Fix GCC 12.2 warning (-Warray-bounds). - approved
by Alexandre Julliard (＠julliard) 22 Sep '22

22 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/904

1 0

Re: [PATCH v2 0/2] MR911: Test for NtLoadKeyEx - approved
by Alexandre Julliard (＠julliard) 22 Sep '22

22 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/911

1 0

Re: [PATCH v6 0/2] MR907: secur32: Implement basic functionality for LsaGetLogonSessionData. - approved
by Alexandre Julliard (＠julliard) 22 Sep '22

22 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/907

1 0

Re: [PATCH v18 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread. - approved
by Alexandre Julliard (＠julliard) 22 Sep '22

22 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/852

1 0

[PATCH 0/1] MR914: ntoskrnl.exe: Implement various KeQuery* functions
by Etaash Mathamsetty (＠etaash.mathamsetty) 22 Sep '22

22 Sep '22

mrac tries to get function pointers for these functions using MmGetSystemRoutineAddress, I haven't seen them being used by it, but might as well implement it since they are very easy to implement. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/914

3 3

Re: [PATCH v2 0/4] MR15: Release 1.5. - approved
by Alexandre Julliard (＠julliard) 22 Sep '22

22 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/15

1 0

[PATCH v5 0/9] MR887: mf/tests: Improve MF transform output checks and dumps.
by Rémi Bernon (＠rbernon) 22 Sep '22

22 Sep '22

-- v5: mf/tests: Dump image samples with a BMP header and RGB data. mf/tests: Rename transform frame dumps to BMP. mf/tests: Check all produced output IMFSample at the same time. mf/tests: Factor IMFSample attributes checks in check_mf_sample. mf/tests: Factor IMFSample checks in a check_mf_sample helper. mf/tests: Introduce a new dump_mf_sample helper. mf/tests: Introduce a new load_resource helper. mf/tests: Factor IMFTransform_ProcessOutput checks together. mf/tests: Use separate variables for input / output samples. https://gitlab.winehq.org/wine/wine/-/merge_requests/887

3 11

[PATCH 0/2] MR911: Test for NtLoadKeyEx
by Santino Mazza (＠tati1454) 22 Sep '22

22 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/911

3 3

[PATCH v2 0/1] MR898: scrrun: Fix bugs in FileSystemObject text-file handling
by Kevin Puetz (＠puetzk) 22 Sep '22

22 Sep '22

Fix bugs in FileSystemObject text-file handling OpenTextFile(...,ForWriting,True) should either create a new file, or open and truncate an existing one OpenTextFile(...,ForAppending,?,True) should write a BOM if appending to an existing-but-empty file -- v2: scrrun: Fix bugs in FileSystemObject text-file handling https://gitlab.winehq.org/wine/wine/-/merge_requests/898

3 2

[PATCH v11 0/7] MR820: Implement application hives
by Santino Mazza (＠tati1454) 22 Sep '22

22 Sep '22

-- v11: kernelbase: Implement RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 9

[PATCH v5 0/2] MR907: secur32: Implement basic functionality for LsaGetLogonSessionData.
by Owen Rudge (＠orudge) 22 Sep '22

22 Sep '22

This basic implementation is sufficient to fix .NET applications that use System.Security.Principal.WindowsIdentity.AuthenticationType. -- v5: secur32: Implement basic functionality for LsaGetLogonSessionData. https://gitlab.winehq.org/wine/wine/-/merge_requests/907

3 4

[PATCH v4 0/2] MR907: secur32: Implement basic functionality for LsaGetLogonSessionData.
by Owen Rudge (＠orudge) 22 Sep '22

22 Sep '22

This basic implementation is sufficient to fix .NET applications that use System.Security.Principal.WindowsIdentity.AuthenticationType. -- v4: secur32: Implement basic functionality for LsaGetLogonSessionData. secur32/tests: Add tests for LsaGetLogonSessionData. https://gitlab.winehq.org/wine/wine/-/merge_requests/907

4 6

[PATCH v3 0/2] MR907: secur32: Implement basic functionality for LsaGetLogonSessionData.
by Owen Rudge (＠orudge) 22 Sep '22

22 Sep '22

This basic implementation is sufficient to fix .NET applications that use System.Security.Principal.WindowsIdentity.AuthenticationType. -- v3: secur32: Implement basic functionality for LsaGetLogonSessionData. secur32/tests: Add tests for LsaGetLogonSessionData. https://gitlab.winehq.org/wine/wine/-/merge_requests/907

3 3

2025

2024

2023

2022

wine-gitlab