- wine-gitlab - winehq.org

[PATCH v2 0/2] MR907: secur32: Implement basic functionality for LsaGetLogonSessionData.
by Owen Rudge (＠orudge) 22 Sep '22

22 Sep '22

This basic implementation is sufficient to fix .NET applications that use System.Security.Principal.WindowsIdentity.AuthenticationType. -- v2: secur32: Implement basic functionality for LsaGetLogonSessionData. https://gitlab.winehq.org/wine/wine/-/merge_requests/907

3 6

[PATCH 0/1] MR897: oleauto: dereference VT_RECORD|VT_BYREF in place
by Kevin Puetz (＠puetzk) 22 Sep '22

22 Sep '22

VariantCopyInd allows pvargDest == pvargSrc in order to dereference in place To avoid confusing the source values and a partially-written destination, wine's implementation makes a shallow copy and uses that as pSrc. However, the call to VARIANT_CopyIRecordInfo did not use this, leading to it copying from the zeroed-out memory it just allocated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/897

3 2

[PATCH 0/4] MR902: d3d9: Use a separate draw texture for managed resources.
by Zebediah Figura (＠zfigura) 22 Sep '22

22 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/902

4 6

[PATCH v2 0/1] MR848: ntoskrnl: KeIpiGenericCall semi-stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 22 Sep '22

22 Sep '22

fixes bug #48989 based on a patch that was made in that issue -- v2: ntoskrnl: KeIpiGenericCall semi-stub https://gitlab.winehq.org/wine/wine/-/merge_requests/848

2 4

[PATCH v17 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 21 Sep '22

21 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v17: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

2 5

[PATCH v16 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 21 Sep '22

21 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v16: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

3 5

Re: [PATCH v15 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 21 Sep '22

21 Sep '22

On Wed Sep 21 21:29:50 2022 +0000, Alexandre Julliard wrote: > > Code should be obvious, but question for the last commit: should I > open with `O_CLOEXEC` ? > Yes, you should. grep for O_CLOEXEC to see how this is handled in other > places when not supported. Makes sense. Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/852#note_9007

1 0

[PATCH 0/2] MR901: crypt32: Implement a couple of missing bits in string conversion functions.
by Paul Gofman (＠gofman) 21 Sep '22

21 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/901

5 5

Re: [PATCH v9 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx - approved
by Alexandre Julliard (＠julliard) 21 Sep '22

21 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/824

1 0

Re: [PATCH v2 0/2] MR909: Client cert failures - approved
by Alexandre Julliard (＠julliard) 21 Sep '22

21 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/909

1 0

Re: [PATCH v2 0/2] MR901: crypt32: Implement a couple of missing bits in string conversion functions. - approved
by Alexandre Julliard (＠julliard) 21 Sep '22

21 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/901

1 0

Re: [PATCH v2 0/3] MR866: d3d10core/tests, d3d11/tests: Fix test failures in test_pipeline_statistics_query(). - approved
by Alexandre Julliard (＠julliard) 21 Sep '22

21 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/866

1 0

[PATCH 0/4] MR908: uiautomationcore: Add more nested node features.
by Connor McAdams (＠cmcadams) 21 Sep '22

21 Sep '22

Add the ability to disconnect nested node providers, and return element properties for nested nodes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/908

2 5

Re: [PATCH v14 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Alexandre Julliard (＠julliard) 21 Sep '22

21 Sep '22

> Code should be obvious, but question for the last commit: should I open with `O_CLOEXEC` ? Yes, you should. grep for O_CLOEXEC to see how this is handled in other places when not supported. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/852#note_8992

1 0

[PATCH 0/2] MR909: Client cert failures
by Hans Leidekker (＠hans) 21 Sep '22

21 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/909

2 2

[PATCH v10 0/7] MR820: Implement application hives
by Santino Mazza (＠tati1454) 21 Sep '22

21 Sep '22

-- v10: kernelbase: Implement RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

2 8

[PATCH 0/7] MR906: msvcr: Implement _StructuredTaskCollection::_RunAndWait and the constructor
by Torge Matthies (＠tmatthies) 21 Sep '22

21 Sep '22

This implements the _RunAndWait member function and the constructor of the _StructuredTaskCollection, which enables the tests for that class to run. Also adds a throw of a missing_wait exception to the destructor when chores are scheduled and _RunAndWait was not called. Remaining stuff after this: - Task collection cancelling + IsCancelling function (next MR) - Cancellation token support (requires RE'ing the _CancellationTokenState class, currently in progress) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/906

2 8

[PATCH v9 0/7] MR820: Implement application hives
by Santino Mazza (＠tati1454) 21 Sep '22

21 Sep '22

-- v9: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag server: Create \REGISTRY\A hive. ntdll: Rename NtLoadKeyEx parameters. ntdll: Pass filename to server in NtLoadKeyEx. ntdll/test: Test for NtRegLoadKey roothandle parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 9

[PATCH v8 0/7] MR820: Implement application hives
by Santino Mazza (＠tati1454) 21 Sep '22

21 Sep '22

-- v8: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 11

[PATCH 0/2] MR907: secur32: Implement basic functionality for LsaGetLogonSessionData.
by Owen Rudge (＠orudge) 21 Sep '22

21 Sep '22

This basic implementation is sufficient to fix .NET applications that use System.Security.Principal.WindowsIdentity.AuthenticationType. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/907

3 3

[PATCH v4 0/11] MR887: mf/tests: Improve MF transform output checks and dumps.
by Rémi Bernon (＠rbernon) 21 Sep '22

21 Sep '22

-- v4: mf/tests: Dump image samples with a BMP header and RGB data. mf/tests: Rename transform frame dumps to BMP. mf/tests: Check all produced output IMFSample at the same time. mf/tests: Factor IMFSample attributes checks in check_mf_sample. mf/tests: Factor IMFSample checks in a check_mf_sample helper. mf/tests: Introduce a new dump_mf_sample helper. mf/tests: Introduce a new load_resource helper. mf/tests: Factor IMFTransform_ProcessOutput checks together. mf/tests: Use separate variables for input / output samples. mf: Validate sample copier ProcessOutput count parameter. winegstreamer: Avoid accessing NULL pointer if transform didn't provide a sample. https://gitlab.winehq.org/wine/wine/-/merge_requests/887

2 11

[PATCH 0/4] MR15: Release 1.5.
by Henri Verbeet (＠hverbeet) 21 Sep '22

21 Sep '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/15

3 5

[PATCH 0/3] MR866: d3d10core/tests, d3d11/tests: Fix test failures in test_pipeline_statistics_query().
by Zebediah Figura (＠zfigura) 21 Sep '22

21 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/866

4 5

[PATCH v3 0/10] MR887: mf/tests: Improve MF transform output checks and dumps.
by Rémi Bernon (＠rbernon) 21 Sep '22

21 Sep '22

-- v3: mf/tests: Dump image samples with a BMP header and RGB data. mf/tests: Rename transform frame dumps to BMP. mf/tests: Check all produced output IMFSample at the same time. mf/tests: Factor IMFSample attributes checks in check_mf_sample. mf/tests: Factor IMFSample checks in a check_mf_sample helper. mf/tests: Introduce a new dump_mf_sample helper. mf/tests: Introduce a new load_resource helper. mf/tests: Factor IMFTransform_ProcessOutput checks together. mf/tests: Use separate variables for input / output samples. mf: Validate sample copier ProcessOutput count parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/887

3 17

[PATCH v7 0/7] MR820: Implement application hives
by Santino Mazza (＠tati1454) 21 Sep '22

21 Sep '22

-- v7: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag server: Create \REGISTRY\A hive. ntdll: Rename NtLoadKeyEx parameters. ntdll: Pass filename to server in NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 8

[PATCH 0/1] MR904: avifil32: Fix GCC 12.2 warning (-Warray-bounds).
by eric pouech (＠epo) 21 Sep '22

21 Sep '22

Since struct _IAVIStreamImpl has a pointer to a WAVEFORMATEX, GCC 12.2 emits warning when dereferencing that pointer when the block has been allocated with sizeof(PCMWAVEFORMAT). The warning is fixed by always allocating with sizeof(WAVEFORMATEX). This will overallocate in case of a PCM stream. The alternative would have been to store in struct _IAVIStreamImpl a pointer to PCMWAVEFORMAT instead, and add the casting to a WAVEFORMATEX when needed. That would clutter the code IMO since most of the ACM APIs expect a LPWAVEFORMATEX. /home/eric/work/wine/dlls/avifil32/acmstream.c: In function 'AVIFILE_OpenCompressor': /home/eric/work/wine/dlls/avifil32/acmstream.c:105:24: warning: array subscript 'struct tWAVEFORMATEX[0]' is partly outside array bounds of 'unsigned char[16]' [-Warray-bounds] 105 | This->lpOutFormat->wFormatTag = WAVE_FORMAT_PCM; | ^~ /home/eric/work/wine/dlls/avifil32/acmstream.c:101:27: note: object of size 16 allocated by 'HeapAlloc' 101 | This->lpOutFormat = HeapAlloc(GetProcessHeap(), 0, This->cbOutFormat); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/904

2 1

[PATCH 0/1] MR900: notepad: Show goto dialog box.
by Jacob Czekalla (＠Maaka00524) 21 Sep '22

21 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/900

3 3

Re: [PATCH v2 0/1] MR842: ntdll: add system32/drivers to dll search path
by Etaash Mathamsetty (＠etaash.mathamsetty) 21 Sep '22

21 Sep '22

On Mon Sep 19 20:51:28 2022 +0000, Alexandre Julliard wrote: > This should be handled already by LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR. If > that doesn't work in your case you'll need to investigate why, but we > can't change the global search path for this. as far as I can tell LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR is for LoadLibrary not the private search_dll_file function in loader.c (which is where the problem originates from) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/842#note_8876

2 1

[PATCH 0/1] MR899: vbscript-disp_call-map_hres
by Kevin Puetz (＠puetzk) 20 Sep '22

20 Sep '22

Map known HRESULT values into their FACILITY_VBS counterparts Unless the callee provided its own Description (e.g. via SetErrorInfo) VBscript maps certain well-known HRESULT values into its own error facility and messages, changing Err.Number and also setting Err.Source to itself (unless already provided, in which case it is left alone) e.g. if the invoked method returns E_NOINTERFACE, The VBScript Err object should show Err.Number: 0x1AE Err.Source: Microsoft VBScript runtime error Err.Description: Class doesn't support Automation Rather than the original HRESULT Err.Number: 0x80004002 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/899

2 1

[PATCH 0/1] MR898: scrrun-OpenTextFile-create
by Kevin Puetz (＠puetzk) 20 Sep '22

20 Sep '22

Fix bugs in FileSystemObject text-file handling OpenTextFile(...,ForWriting,True) should either create a new file, or open and truncate an existing one OpenTextFile(...,ForAppending,?,True) should write a BOM if appending to an existing-but-empty file -- https://gitlab.winehq.org/wine/wine/-/merge_requests/898

2 1

Re: [PATCH v14 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 20 Sep '22

20 Sep '22

@julliard Is there something else I need to do to get this merged, or just wait? I am not sure. Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/852#note_8938

1 0

Re: [PATCH v2 0/1] MR896: ntdll: Fix ARM vs AMD64 typo - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/896

1 0

Re: [PATCH v3 0/1] MR885: win32u: Use allocator mechanism to allocate DC attributes - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/885

1 0

Re: [PATCH v2 0/3] MR894: Adsldp size limit - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/894

1 0

Re: [PATCH v3 0/3] MR880: winemac: WoW64 support - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/880

1 0

Re: [PATCH v2 0/3] MR893: cryptowinrt: Implement GenerateRandomNumber(). - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/893

1 0

Re: [PATCH v2 0/1] MR892: ntdll: Add a fast path for NtDeviceIoControlFile(INVALID_HANDLE_VALUE). - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/892

1 0

Re: [PATCH v4 0/6] MR846: uiautomationcore: Implement basic HWND based HUIANODE behavior. (v2) - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/846

1 0

Re: [PATCH v2 0/3] MR888: winegstreamer: Get rid of the wm_reader_ops callbacks. - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/888

1 0

Re: [PATCH v5 0/3] MR891: threadpoolwinrt: Initial implementation of RunAsync(). - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/891

1 0

Re: [PATCH v3 0/2] MR882: Use atomic write for releasing threadsafe_queue spin lock. - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/882

1 0

Re: [PATCH v2 0/1] MR840: ntoskrnl: KeSetTargetProcessorDpcEx stub - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/840

1 0

Re: [PATCH v2 0/3] MR836: msdasql: Implement ICommandProperties GetProperties - approved
by Alexandre Julliard (＠julliard) 20 Sep '22

20 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/836

1 0

[PATCH 0/1] MR896: ntdll: Fix ARM vs AMD64 typo
by André Zwing (＠AndreRH) 20 Sep '22

20 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/896

2 1

[PATCH v6 0/7] MR820: Implement roothandle parameter NtLoadKeyEx
by Santino Mazza (＠tati1454) 20 Sep '22

20 Sep '22

-- v6: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag server: Create \REGISTRY\A hive. ntdll: Rename NtLoadKeyEx parameters. ntdll: Pass filename to server in NtLoadKeyEx. ntdll/test: Test for NtRegLoadKey roothandle parameter. winnt.h: Define REG_APP_HIVE and REG_PROCESS_PRIVATE. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

4 16

[PATCH 0/3] MR894: Adsldp size limit
by Hans Leidekker (＠hans) 20 Sep '22

20 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/894

2 3

[PATCH v2 0/3] MR880: winemac: WoW64 support
by Jacek Caban (＠jacek) 20 Sep '22

20 Sep '22

-- v2: winemac: Implement wow64 thunks. https://gitlab.winehq.org/wine/wine/-/merge_requests/880

3 5

[PATCH 0/1] MR885: win32u: Use allocator mechanism to allocate DC attributes
by David Kahurani (＠kahurani) 20 Sep '22

20 Sep '22

DC attributes are not deallocated when free_dc_attr is called on them but are instead queued for reassignment. If we don't make use of the designated allocator to allocate DC attributes, we essentially keep adding memory to the queue indefinitely and, at the same time, not allowing room for reassignment. The above essentially leads to a leak which is quite noticeable in applications making use heavy use of gdiplus. https://bugs.winehq.org/show_bug.cgi?id=53645 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/885

4 3

[PATCH 0/3] MR893: cryptowinrt: Implement GenerateRandomNumber().
by Nikolay Sivov (＠nsivov) 20 Sep '22

20 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/893

2 3

[PATCH 0/2] MR14: include: Add missing APIs declaration in vkd3d_d3d12.idl.
by Biswapriyo Nath (＠Biswa96) 20 Sep '22

20 Sep '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/14

2 2

[PATCH 0/1] MR892: ntdll: Add a fast path for NtDeviceIoControlFile(INVALID_HANDLE_VALUE).
by Zebediah Figura (＠zfigura) 20 Sep '22

20 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53706 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/892

2 1

[PATCH v8 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx
by Etaash Mathamsetty (＠etaash.mathamsetty) 20 Sep '22

20 Sep '22

required by mrac anti-cheat -- v8: ntoskrnl: Implement KeGetCurrentProcessorNumberEx https://gitlab.winehq.org/wine/wine/-/merge_requests/824

2 1

[PATCH v3 0/6] MR846: uiautomationcore: Implement basic HWND based HUIANODE behavior. (v2)
by Connor McAdams (＠cmcadams) 19 Sep '22

19 Sep '22

Changes since prior MR: - Check if HWND is valid after sending `WM_GETOBJECT` and getting a 0 return value. - Block on thread calling `UiaNodeFromHandle()` rather than the marshaling thread. - Squash `IWineUiaNode::get_prop_val` commit into commit where it is actually used. -- v3: uiautomationcore: Add tests for UiaNodeFromHandle. uiautomationcore: Create UI Automation client thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/846

3 9

[PATCH v7 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx
by Etaash Mathamsetty (＠etaash.mathamsetty) 19 Sep '22

19 Sep '22

required by mrac anti-cheat -- v7: ntoskrnl: Implement KeGetCurrentProcessorNumberEx https://gitlab.winehq.org/wine/wine/-/merge_requests/824

2 1

Re: [PATCH v2 0/1] MR890: user32: Fix a memory allocation strategy. - approved
by Alexandre Julliard (＠julliard) 19 Sep '22

19 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/890

1 0

Re: [PATCH v2 0/1] MR889: msvcr100: Fix crash when setting scheduler in schedule_task_proc. - approved
by Alexandre Julliard (＠julliard) 19 Sep '22

19 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/889

1 0

Re: [PATCH v2 0/1] MR886: msvcp90: Fix indentation in concurrent_vector_alloc_segment function. - approved
by Alexandre Julliard (＠julliard) 19 Sep '22

19 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/886

1 0

Re: [PATCH v3 0/1] MR798: msvcrt: Fix strncmp return value. - approved
by Alexandre Julliard (＠julliard) 19 Sep '22

19 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/798

1 0

Re: [PATCH v2 0/1] MR884: ntdll: Add RtlDosPathNameToRelativeNtPathName_U. - approved
by Alexandre Julliard (＠julliard) 19 Sep '22

19 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/884

1 0

Re: [PATCH v2 0/3] MR883: kernelbase: Add OpenFileMappingFromApp(). - approved
by Alexandre Julliard (＠julliard) 19 Sep '22

19 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/883

1 0

Re: [PATCH v2 0/1] MR878: wininet: Use standard HTTP_ADD Flags - approved
by Alexandre Julliard (＠julliard) 19 Sep '22

19 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/878

1 0

Re: [PATCH v2 0/1] MR876: jscript: Fix GCC 12.2 warning. - approved
by Alexandre Julliard (＠julliard) 19 Sep '22

19 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/876

1 0

Re: [PATCH v2 0/1] MR879: oledb32/tests: Free returned property set memory - approved
by Alexandre Julliard (＠julliard) 19 Sep '22

19 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/879

1 0

Re: [PATCH v2 0/1] MR877: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 19 Sep '22

19 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/877

1 0

Re: [PATCH v2 0/3] MR13: tests: Various fixes. - approved
by Alexandre Julliard (＠julliard) 19 Sep '22

19 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/13

1 0

[PATCH 0/3] MR888: winegstreamer: Get rid of the wm_reader_ops callbacks.
by Rémi Bernon (＠rbernon) 19 Sep '22

19 Sep '22

Controlling lifetime from the sync / async reader side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/888

3 4

[PATCH v4 0/3] MR891: threadpoolwinrt: Initial implementation of RunAsync().
by Nikolay Sivov (＠nsivov) 19 Sep '22

19 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: threadpoolwinrt: Add initial implementation of RunAsync. threadpoolwinrt: Add a stub module. include: Add windows.system.threading.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/891

3 9

[PATCH v3 0/3] MR891: threadpoolwinrt: Initial implementation of RunAsync().
by Nikolay Sivov (＠nsivov) 19 Sep '22

19 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: threadpoolwinrt: Add initial implementation of RunAsync. https://gitlab.winehq.org/wine/wine/-/merge_requests/891

2 4

[PATCH v2 0/3] MR891: threadpoolwinrt: Initial implementation of RunAsync().
by Nikolay Sivov (＠nsivov) 19 Sep '22

19 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: threadpoolwinrt: Add initial implementation of RunAsync. threadpoolwinrt: Add a stub module. include: Add windows.system.threading.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/891

3 14

[PATCH v2 0/2] MR882: Use atomic write for releasing threadsafe_queue spin lock.
by Jinoh Kang (＠iamahuman) 19 Sep '22

19 Sep '22

This fixes data race in ARM/ARM64 platforms, and prevents potential memory access reordering by the compiler. -- v2: msvcp90: Use atomic write for releasing threadsafe_queue spin lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/882

3 5

[PATCH 0/1] MR890: user32: Fix a memory allocation strategy.
by Akihiro Sagawa (＠sgwaki) 19 Sep '22

19 Sep '22

Otherwise, the function allocates a heap memory when prev_size is enough. What is worse is that it returns the buffer untouched if the prev_size is insufficient. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53703 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/890

3 2

[PATCH v3 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 19 Sep '22

19 Sep '22

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> -- v3: kernelbase: Call NtCancelSynchronousIoFile in CancelSynchronousIo. ntdll: Partially implement NtCancelSynchronousIoFile. ntdll: Add NtCancelSynchronousIoFile stub. kernel32/tests: Add tests for CancelSynchronousIo. https://gitlab.winehq.org/wine/wine/-/merge_requests/47

5 17

[PATCH v2 0/10] MR887: mf/tests: Improve MF transform output checks and dumps.
by Rémi Bernon (＠rbernon) 19 Sep '22

19 Sep '22

-- v2: mf/tests: Dump image samples with a BMP header and RGB data. mf/tests: Rename transform frame dumps to BMP. mf/tests: Check all produced output IMFSample at the same time. mf/tests: Factor IMFSample attributes checks in check_mf_sample. mf/tests: Factor IMFSample checks in a check_mf_sample helper. mf/tests: Introduce a new dump_mf_sample helper. mf/tests: Introduce a new load_resource helper. mf/tests: Factor IMFTransform_ProcessOutput checks together. mf/tests: Use separate variables for input / output samples. mf: Validate sample copier ProcessOutput count parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/887

2 11

[PATCH 0/9] MR887: mf/tests: Improve MF transform output checks and dumps.
by Rémi Bernon (＠rbernon) 19 Sep '22

19 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/887

3 15

[PATCH 0/1] MR889: msvcr100: Fix crash when setting scheduler in schedule_task_proc.
by Piotr Caban (＠piotr) 19 Sep '22

19 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53672 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/889

3 3

[PATCH 0/3] MR13: tests: Various fixes.
by Zebediah Figura (＠zfigura) 19 Sep '22

19 Sep '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/13

3 4

[PATCH 0/5] MR874: mfmediaengine: Add tests to exhibit inverted video rendering.
by Rémi Bernon (＠rbernon) 19 Sep '22

19 Sep '22

This shows that media session samples are correctly oriented, but that mfmediaengine renders them upside down. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/874

4 13

[PATCH 0/1] MR886: msvcp90: Fix indentation in concurrent_vector_alloc_segment function.
by Piotr Caban (＠piotr) 19 Sep '22

19 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/886

2 1

[PATCH v2 0/1] MR798: msvcrt: Fix strncmp return value.
by Shaun Ren (＠shaunren) 19 Sep '22

19 Sep '22

Some programs, such as Final Fantasy IV (3D remake), expect strncmp to return exactly +/-1 when the strings are not equal. -- v2: msvcrt: Fix strncmp return value. https://gitlab.winehq.org/wine/wine/-/merge_requests/798

4 4

[PATCH 0/1] MR884: ntdll: Add RtlDosPathNameToRelativeNtPathName_U.
by Gijs Vermeulen (＠gverm) 18 Sep '22

18 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53700 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/884

2 1

[PATCH v2 0/5] MR856: mshtml: url prop for Storage Events and improvements.
by Gabriel Ivăncescu (＠insn) 18 Sep '22

18 Sep '22

-- v2: mshtml: Silence a FIXME when parameter is missing. mshtml: Create non-gecko events properly from type string. mshtml: Implement url prop for StorageEvent. include/mshtml: Move some forward interface declarations to match Windows SDK. mshtml: Override document.URL's name when adding it from the mshtml typelib. https://gitlab.winehq.org/wine/wine/-/merge_requests/856

3 8

[PATCH 0/3] MR883: kernelbase: Add OpenFileMappingFromApp().
by Nikolay Sivov (＠nsivov) 18 Sep '22

18 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/883

2 3

Re: [PATCH v5 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

> You should only call `NtGetCurrentProcessorNumber()` once. Otherwise, the processor number can change if the thread is preempted and then re-scheduled to another processor. This leads to inconsistent values between the return value and the `process_number->Number` output. It's not that `KeGetCurrentProcessorNumberEx()` will be highly useful, since the driver can't block scheduling by raising IRQL to DISPATCH_LEVEL. Still, it's better to at least return consistent values even if they are stale. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/824#note_8782

1 0

Re: [PATCH v5 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

Jinoh Kang (@iamahuman) commented about dlls/ntoskrnl.exe/ntoskrnl.c: > > +/*********************************************************************** > + * KeGetCurrentProcessorNumberEx (NTOSKRNL.EXE.@) > + */ > +ULONG WINAPI KeGetCurrentProcessorNumberEx(PPROCESSOR_NUMBER process_number) > +{ > + FIXME("%p semi-stub\n", process_number); > + > + if (process_number) > + { > + process_number->Group = 0; > + process_number->Reserved = 0; > + process_number->Number = NtGetCurrentProcessorNumber(); > + } > + > + return NtGetCurrentProcessorNumber(); You should only call `NtGetCurrentProcessorNumber()` once. Otherwise, the processor number can change if the thread is preempted and then re-scheduled to another processor. This leads to inconsistent values between the return value and the `process_number->Number` output. In general, you should treat `NtGetCurrentProcessorNumber()` as being volatile. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/824#note_8781

1 0

[PATCH 0/1] MR882: concrt140: Use atomic write for releasing threadsafe_queue spin lock.
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

This fixes data race in ARM/ARM64 platforms, and prevents potential memory access reordering by the compiler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/882

2 1

[PATCH 0/1] MR881: kernelbase: Fix reading stale information from IOSB.
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

Ensure IOSB Information (InternalHigh) is loaded after Status (Internal) to avoid reading stale value from the Information (InternalHigh) field. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/881

2 1

[PATCH v5 0/1] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v5: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 1

[PATCH v4 0/1] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v4: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 1

[PATCH 0/1] MR878: wininet: Use standard HTTP_ADD Flags
by Alistair Leslie-Hughes (＠alesliehughes) 18 Sep '22

18 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/878

3 2

[PATCH 0/1] MR876: jscript: Fix GCC 12.2 warning.
by eric pouech (＠epo) 18 Sep '22

18 Sep '22

When initializing a jsstr_inline_t with a len < 3, the size passed for the allocation is smaller then the size of the structure (as the later is rounded up to the alignment = 4 bytes). GCC 12.2 complains about this when dereferencing the pointer to the structure as the size passed for allocation is smaller than the size of the structure. The warning is fixed by using flexible array member in jsstr_inline_t. Given the rounding behavior in memory allocation, this should not change the size of allocated blocks. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/876

3 2

[PATCH 0/3] MR880: winemac: WoW64 support
by Jacek Caban (＠jacek) 18 Sep '22

18 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/880

2 3

[PATCH v12 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 18 Sep '22

18 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v12: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

3 6

[PATCH 0/1] MR879: oledb32/tests: Free returned property set memory
by Alistair Leslie-Hughes (＠alesliehughes) 18 Sep '22

18 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=36312 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/879

2 1

[PATCH v11 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 17 Sep '22

17 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v11: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

2 5

[PATCH v10 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 17 Sep '22

17 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v10: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

2 5

[PATCH v9 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 17 Sep '22

17 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v9: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) ntdll: Use pread in NtQueryVirtualMemory(MemoryWorkingSetExInformation) ntdll: Do not use hardcoded page shift in NtQueryVirtualMemory(MemoryWorkingSetExInformation) ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional page check https://gitlab.winehq.org/wine/wine/-/merge_requests/852

3 6

Re: [PATCH v8 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 17 Sep '22

17 Sep '22

On Sat Sep 17 17:00:54 2022 +0000, Witold Baryluk wrote: > Fixed. Good eye! Hmm. I pushed to my branch https://gitlab.winehq.org/baryluk/wine/-/commit/47f155ee2ec1da7a7f62ad1ca0c… , but this MR still shows the previous content of the branch. Weird. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/852#note_8745

1 0

Re: [PATCH v8 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 17 Sep '22

17 Sep '22

On Sat Sep 17 15:38:35 2022 +0000, Jinoh Kang wrote: > ```suggestion:-0+0 > if (pagemap_fd == -1 || > ``` Fixed. Good eye! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/852#note_8743

1 0

Re: [PATCH v8 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Jinoh Kang (＠iamahuman) 17 Sep '22

17 Sep '22

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/virtual.c: > get_committed_size( view, p->VirtualAddress, &vprot, VPROT_COMMITTED ) && > (vprot & VPROT_COMMITTED)) > { > - if (!f || fseek( f, ((UINT_PTR)p->VirtualAddress >> page_shift) * sizeof(pagemap), SEEK_SET ) == -1 || > - fread( &pagemap, sizeof(pagemap), 1, f ) != 1) > + if (pagemap_fd != -1 || ```suggestion:-0+0 if (pagemap_fd == -1 || ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/852#note_8741

1 0

[PATCH 0/1] MR877: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 17 Sep '22

17 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/877

2 1

2025

2024

2023

2022

wine-gitlab