- wine-gitlab - winehq.org

Re: [PATCH v3 0/1] MR867: ntdll: Check for failure from get_initial_environment(). - approved
by Alexandre Julliard (＠julliard) 16 Sep '22

16 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/867

1 0

Re: [PATCH v3 0/4] MR843: wmvcore: More wm async reader refactoring. - approved
by Alexandre Julliard (＠julliard) 16 Sep '22

16 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/843

1 0

Re: [PATCH v2 0/1] MR875: glu32: Fix GCC 12.2 warnings. - approved
by Alexandre Julliard (＠julliard) 16 Sep '22

16 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/875

1 0

Re: [PATCH v2 0/1] MR837: wininet: Clear cached credentials after the first failed attempt. - approved
by Alexandre Julliard (＠julliard) 16 Sep '22

16 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/837

1 0

Re: [PATCH v8 0/9] MR813: winecoreaudio: Switch to mmdevapi's unixlib.h. - approved
by Alexandre Julliard (＠julliard) 16 Sep '22

16 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/813

1 0

Re: [PATCH v2 0/1] MR873: xmllite/writer: Enable some more tests for WriteNode(). - approved
by Alexandre Julliard (＠julliard) 16 Sep '22

16 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/873

1 0

Re: [PATCH v3 0/1] MR822: ws2_32: Return a valid value for WSAIoctl SIO_IDEAL_SEND_BACKLOG_QUERY. - approved
by Alexandre Julliard (＠julliard) 16 Sep '22

16 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/822

1 0

Re: [PATCH v2 0/1] MR869: win32u: Copy directly into the union pointer in unpack_message(). - approved
by Alexandre Julliard (＠julliard) 16 Sep '22

16 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/869

1 0

Re: [PATCH v2 0/1] MR870: ntdll: Calculate the necessary length after calling snprintf() in SystemWineVersionInformation. - approved
by Alexandre Julliard (＠julliard) 16 Sep '22

16 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/870

1 0

Re: [PATCH v2 0/2] MR868: ntdll, libwine: Avoid comparing the result of pointer arithmetic to zero. - approved
by Alexandre Julliard (＠julliard) 16 Sep '22

16 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/868

1 0

Re: [PATCH v7 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 16 Sep '22

16 Sep '22

@zfigura @iamahuman This is my first wine patch, I am not familiar with wine review process, and I am not sure who should review this (bot didn't assign anybody), but I would appreciate a review. Code should be obvious, but question for the last commit: should I open with `O_CLOEXEC` ? I do not think so, but would be good to confirm. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/852#note_8713

1 0

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 16 Sep '22

16 Sep '22

On Fri Sep 16 15:29:32 2022 +0000, Gabriel Ivăncescu wrote: > It worked properly earlier likely because there were no conflicts. Use > git locally as normal instead of the web interface to do it. yes I know that, but when I clicked the rebase button the pipeline started failing for no reason, now I have to rebase locally which I understand -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8706

1 0

[PATCH 0/3] MR871: ntdll: Fill the IOSB only inside the if (alerted) block in multiple functions.
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/871

4 5

[PATCH v2 0/5] MR871: ntdll: Fill the IOSB only inside the if (alerted) block in multiple functions.
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

-- v2: ntdll: Fill the IOSB in sock_transmit() only inside the "if (alerted)" block. ntdll: Fill the IOSB in sock_send() only inside the "if (alerted)" block. ntdll: Fill the IOSB in sock_recv() only inside the "if (alerted)" block. ntdll: The async handle passed to set_async_direct_result() cannot be NULL. ws2_32/tests: Add more tests for iosb contents while a recv is pending. https://gitlab.winehq.org/wine/wine/-/merge_requests/871

2 5

[PATCH v2 0/1] MR867: ntdll: Check for failure from get_initial_environment().
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

Alternatively, since this is early in startup and we don't expect this malloc() to fail, we could simply remove the check from get_initial_environment() itself. -- v2: ntdll: Do not check for malloc() failure in get_initial_environment. https://gitlab.winehq.org/wine/wine/-/merge_requests/867

2 1

[PATCH v2 0/4] MR843: wmvcore: More wm async reader refactoring.
by Rémi Bernon (＠rbernon) 16 Sep '22

16 Sep '22

-- v2: winegstreamer: Check for already opened stream in wm_reader_open*. winegstreamer: Use a dedicated CS to serialize async reader commands. winegstreamer: Introduce a new async_reader_deliver_sample helper. winegstreamer: Wake thread when async reader user clock is modified. https://gitlab.winehq.org/wine/wine/-/merge_requests/843

3 7

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Gabriel Ivăncescu (＠insn) 16 Sep '22

16 Sep '22

On Fri Sep 16 15:03:29 2022 +0000, Etaash Mathamsetty wrote: > lol now another issue popped up, the rebase worked properly earlier > this gitlab is really weird, litterally nothing has worked correctly for me It worked properly earlier likely because there were no conflicts. Use git locally as normal instead of the web interface to do it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8699

1 0

Re: [PATCH v5 0/5] MR820: Implement roothandle parameter NtLoadKeyEx
by Santino Mazza (＠tati1454) 16 Sep '22

16 Sep '22

On Fri Sep 16 15:28:23 2022 +0000, Huw Davies wrote: > My Windows SDK has `REG_APP_HIVE` defined to 0x10. It also has > `REG_PROCESS_PRIVATE` as 0x20, which is presumably what > `REG_PROCESS_APPKEY` gets mapped to. > If the tests aren't going to work on Win 7, then skip them as soon as > the first call returns `STATUS_INVALID_PARAMETER_6`. > Since you've found that the key return is only available for an app key, > then I don't think it makes sense to split this MR up as I'd previously > suggested. That means we need the filename logic back in. > A couple of notes on that: When passing strings to the server, we > typically don't nul-terminate them and pass the length instead. Also, > there is logic there already that copes with loading and saving branches > i.e. the `save_branch_info` stuff. Have you looked into adapting that? Oh interesting, where do you find those headers in the windwos sdk? I've tried to find something like that but I'm always afraid of breaking the clean room guidelines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8698

1 0

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 16 Sep '22

16 Sep '22

On Thu Sep 15 22:27:44 2022 +0000, Bernhard Kölbl wrote: > > Rebase failed: Rebase locally, resolve all conflicts, then push the > branch. Try again. lol now another issue popped up, the rebase worked properly earlier this gitlab is really weird, litterally nothing has worked correctly for me -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8695

1 0

[PATCH 0/1] MR875: glu32: Fix GCC 12.2 warnings.
by eric pouech (＠epo) 16 Sep '22

16 Sep '22

GCC complains about writing 4x4 floats into a pointer to a float. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/875

2 1

Re: [PATCH v5 0/5] MR820: Implement roothandle parameter NtLoadKeyEx
by Huw Davies (＠huw) 16 Sep '22

16 Sep '22

My Windows SDK has `REG_APP_HIVE` defined to 0x10. It also has `REG_PROCESS_PRIVATE` as 0x20, which is presumably what `REG_PROCESS_APPKEY` gets mapped to. If the tests aren't going to work on Win 7, then skip them as soon as the first call returns `STATUS_INVALID_PARAMETER_6`. Since you've found that the key return is only available for an app key, then I don't think it makes sense to split this MR up as I'd previously suggested. That means we need the filename logic back in. A couple of notes on that: When passing strings to the server, we typically don't nul-terminate them and pass the length instead. Also, there is logic there already that copes with loading and saving branches i.e. the `save_branch_info` stuff. Have you looked into adapting that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8694

1 0

[PATCH 0/6] MR856: mshtml: url prop for Storage Events and improvements.
by Gabriel Ivăncescu (＠insn) 16 Sep '22

16 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/856

3 17

[PATCH 0/1] MR837: wininet: Clear cached credentials after the first failed attempt.
by Alistair Leslie-Hughes (＠alesliehughes) 16 Sep '22

16 Sep '22

Windows when using cached credentials will use them on the first challenge, if then a second 403 (ACCESS_DENIED) is received, the user is prompted again but this time with the password and save checkbox cleared. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/837

3 2

Re: [PATCH v5 0/5] MR820: Implement roothandle parameter NtLoadKeyEx
by Santino Mazza (＠tati1454) 16 Sep '22

16 Sep '22

On Fri Sep 16 01:12:18 2022 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=123494 > Your paranoid android. > === debian11 (32 bit report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > === debian11 (32 bit zh:CN report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > === debian11 (32 bit WoW report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > === debian11 (64 bit WoW report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > ``` This test report is from the other force push, now I fixed it with the last push. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8684

1 0

[PATCH v7 0/9] MR813: winecoreaudio: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) 16 Sep '22

16 Sep '22

-- v7: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. winecoreaudio: Switch to string as device identifier, to match other drivers. winecoreaudio: Fix RegEnumKeyExW() call passing wrong unit for the buffer size. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

3 11

[PATCH 0/1] MR873: xmllite/writer: Enable some more tests for WriteNode().
by Nikolay Sivov (＠nsivov) 16 Sep '22

16 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/873

2 1

[PATCH v6 0/8] MR813: winecoreaudio: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) 16 Sep '22

16 Sep '22

-- v6: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. winecoreaudio: Switch to string as device identifier, to match other drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

3 12

[PATCH 0/1] MR867: ntdll: Check for failure from get_initial_environment().
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

Alternatively, since this is early in startup and we don't expect this malloc() to fail, we could simply remove the check from get_initial_environment() itself. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/867

3 2

[PATCH 0/3] MR864: Fixing warnings now spit by GCC 12.2.
by eric pouech (＠epo) 16 Sep '22

16 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/864

3 6

[PATCH 0/1] MR872: winex11: Always initialize escape.drawable in X11DRV_GetDC().
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/872

2 1

[PATCH v2 0/1] MR822: ws2_32: Return a valid value for WSAIoctl SIO_IDEAL_SEND_BACKLOG_QUERY.
by Alistair Leslie-Hughes (＠alesliehughes) 16 Sep '22

16 Sep '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v2: ws2_32: Return a valid value for WSAIoctl SIO_IDEAL_SEND_BACKLOG_QUERY. https://gitlab.winehq.org/wine/wine/-/merge_requests/822

3 2

[PATCH 0/1] MR870: ntdll: Calculate the necessary length after calling snprintf() in SystemWineVersionInformation.
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

This is a gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96367 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/870

2 1

[PATCH 0/1] MR869: win32u: Copy directly into the union pointer in unpack_message().
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

This is a gcc bug; I've filed the following bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106904 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/869

2 1

[PATCH 0/2] MR868: ntdll, libwine: Avoid comparing the result of pointer arithmetic to zero.
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

It's not exactly clear to me why gcc warns about this (and it's hard to find reference for this specific flavor of -Waddress), but my understanding is that arithmetic on well-defined pointers will never yield NULL. Of course, we are not dealing with well-defined pointers here, but fortunately gcc does not complain if we cast to intptr_t first. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/868

2 2

[PATCH v5 0/8] MR813: winecoreaudio: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) 16 Sep '22

16 Sep '22

-- v5: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. winecoreaudio: Switch to string as device identifier, to match other drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

3 24

Re: [PATCH v3 0/2] MR827: winusb: Add WinUsb_Free stub.
by Mohamad Al-Jaf (＠maljaf) 16 Sep '22

16 Sep '22

On Fri Sep 16 02:11:42 2022 +0000, Huw Davies wrote: > Looks like the app calls `WinUsb_Free(NULL)` on startup. Thank you so much for the review! Yeah, it's quite strange that it calls it with a NULL parameter. What is the purpose of it? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/827#note_8654

1 0

[PATCH v4 0/5] MR820: Implement application hives in the registry
by Santino Mazza (＠tati1454) 16 Sep '22

16 Sep '22

-- v4: server: Create \REGISTRY\A hive. ntdll: Implement roothandle parameter for NtLoadKeyEx. ntdll: Rename key variable and file parameter. ntdll/test: Test for NtRegLoadKey roothandle parameter. winnt.h: Create definition for REG_LOAD_APP_KEY. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 7

[PATCH 0/5] MR843: wmvcore: More wm async reader refactoring.
by Rémi Bernon (＠rbernon) 15 Sep '22

15 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/843

3 9

[PATCH 0/1] MR754: wined3d: Pass a draw count of 1 to Vulkan indirect draw commands.
by Zebediah Figura (＠zfigura) 15 Sep '22

15 Sep '22

Spotted by Philip Rebohle. This fixes rendering in "Discovery Tour by Assassin's Creed: Ancient Egypt". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/754

5 7

[PATCH 0/1] MR765: wined3d: Do not create larger staging buffers than necessary in adapter_vk_copy_bo_address().
by Zebediah Figura (＠zfigura) 15 Sep '22

15 Sep '22

This greatly increases performance in "Discovery Tour by Assassin's Creed: Ancient Egypt". The application frequently performs small (< 1 kiB) uploads to a large (128 MiB) buffer. Without this patch, we will always create and destroy a new Vulkan memory allocation, and the Vulkan driver will waste time zeroing the entire allocation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/765

4 5

[PATCH 0/1] MR822: ws2_32: Return a valid value for WSAIoctl SIO_IDEAL_SEND_BACKLOG_QUERY.
by Alistair Leslie-Hughes (＠alesliehughes) 15 Sep '22

15 Sep '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/822

3 4

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Bernhard Kölbl (＠besentv) 15 Sep '22

15 Sep '22

> Rebase failed: Rebase locally, resolve all conflicts, then push the branch. Try again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8641

1 0

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 15 Sep '22

15 Sep '22

not sure why this started failing, all I did was click the rebase button in gitlab... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8640

1 0

Re: [PATCH v2 0/3] MR865: d3d10core/tests, d3d11/tests: Fix -Wstringop-overread warnings. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/865

1 0

Re: [PATCH v2 0/1] MR862: wined3d: Return bools from all return paths in wined3d_cs_map_upload_bo(). - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/862

1 0

Re: [PATCH v2 0/1] MR861: d3d11/tests: Move the is_warp_device() call out of the loop in check_format_support(). - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/861

1 0

Re: [PATCH v2 0/1] MR860: d3d11: Implement d3d11_input_layout_to_wined3d_declaration() on top of... - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/860

1 0

Re: [PATCH v2 0/1] MR859: d3d9/tests: The expected scissor rect after a reset is equal to the back-buffer dimensions. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/859

1 0

Re: [PATCH v2 0/1] MR858: wined3d: Destroy the Vulkan command pool after cleaning up resources. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/858

1 0

Re: [PATCH v2 0/1] MR857: wined3d: Fix the sub-resource index validation in wined3d_texture_update_overlay(). - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/857

1 0

Re: [PATCH v2 0/1] MR855: d2d1/tests: Skip subsequent todo tests for unsupported properties. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/855

1 0

Re: [PATCH v2 0/1] MR863: wininet/tests: Don't send two HTTP responses for a single request in server_thread. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/863

1 0

Re: [PATCH v3 0/2] MR827: winusb: Add WinUsb_Free stub. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/827

1 0

Re: [PATCH v2 0/1] MR854: winevulkan: Update to VK spec version 1.3.228. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/854

1 0

Re: [PATCH v3 0/11] MR849: xmllite/writer: Add initial implementation of WriteNode(). - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/849

1 0

Re: [PATCH v2 0/1] MR351: include: Define atomic read/write helpers for 32-bit integers. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/351

1 0

Re: [PATCH v2 0/1] MR853: kernelbase: Return system error codes in the ReadDirectoryChangesW() completion callback. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/853

1 0

Re: [PATCH v2 0/9] MR847: winegstreamer: Misc MF transform fixes and unifying. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/847

1 0

Re: [PATCH v2 0/1] MR851: po: Update Dutch translation - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/851

1 0

Re: [PATCH v2 0/4] MR850: server: Fix debug register getting/setting on macOS. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/850

1 0

[PATCH 0/3] MR865: d3d10core/tests, d3d11/tests: Fix -Wstringop-overread warnings.
by Zebediah Figura (＠zfigura) 15 Sep '22

15 Sep '22

This is a resend of merge request 864 with a few minor changes: * shorten functions to clear_rtv, and explicitly specify that the d3d10core version is clearing the backbuffer * remove unnecessary inline * fix spacing around asterisks -- https://gitlab.winehq.org/wine/wine/-/merge_requests/865

3 5

[PATCH 0/1] MR855: d2d1/tests: Skip subsequent todo tests for unsupported properties.
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/855

5 6

[PATCH 0/1] MR857: wined3d: Fix the sub-resource index validation in wined3d_texture_update_overlay().
by Henri Verbeet (＠hverbeet) 15 Sep '22

15 Sep '22

This condition accidentally got inverted when wined3d_texture_validate_sub_resource_idx() was introduced in commit 44d6f2adbcca119faebc095f3cfbeeafc50d04f3. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/857

3 2

[PATCH 0/1] MR858: wined3d: Destroy the Vulkan command pool after cleaning up resources.
by Henri Verbeet (＠hverbeet) 15 Sep '22

15 Sep '22

This fixes an issue exposed (but not caused) by commit e553be7e776282fea77b8b60304298d9de90bd8b. Calling vkFreeCommandBuffers() after the corresponding command pool was destroyed causes invalid memory accesses. Thanks to Jacek for pointing this out. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/858

3 2

[PATCH 0/1] MR859: d3d9/tests: The expected scissor rect after a reset is equal to the back-buffer dimensions.
by Henri Verbeet (＠hverbeet) 15 Sep '22

15 Sep '22

This appears to have gotten lost in commit 7623d0a6f585505302044beace53fb8ff81ae120. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/859

3 2

[PATCH 0/1] MR860: d3d11: Implement d3d11_input_layout_to_wined3d_declaration() on top of...
by Henri Verbeet (＠hverbeet) 15 Sep '22

15 Sep '22

d3d11: Implement d3d11_input_layout_to_wined3d_declaration() on top of vkd3d_shader_parse_input_signature(). This was originally prompted by the fact that wined3d_extract_shader_input_signature_from_dxbc() allocates elements with HeapAlloc(), but d3d11_input_layout_to_wined3d_declaration() attempts to free them with free(). That's a regression introduced by commit b951c37b8791ceb052c9e159ad7927f75a72d667. Since we're touching the code though, we may as well use vkd3d_shader_parse_input_signature(), and get rid of wined3d_extract_shader_input_signature_from_dxbc(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/860

3 2

[PATCH 0/1] MR861: d3d11/tests: Move the is_warp_device() call out of the loop in check_format_support().
by Henri Verbeet (＠hverbeet) 15 Sep '22

15 Sep '22

There's no point in querying this multiple times, it's not going to change. Perhaps more importantly, calling is_warp_device() inside a todo_wine block will cause "Test succeeded inside todo block: ..." messages from get_device_adapter_desc(). These appear to have been introduced by commit fcc276ecb1508d5217ec977ca530ee7d30d355b9. Arguably get_device_adapter_desc() shouldn't use ok() in the first place. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/861

3 2

[PATCH 0/1] MR862: wined3d: Return bools from all return paths in wined3d_cs_map_upload_bo().
by Henri Verbeet (＠hverbeet) 15 Sep '22

15 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/862

3 2

[PATCH v6 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 15 Sep '22

15 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v6: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) ntdll: Use pread in NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

2 6

[PATCH v5 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 15 Sep '22

15 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v5: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

3 5

[PATCH v4 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 15 Sep '22

15 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v4: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) ntdll: Use pread in NtQueryVirtualMemory(MemoryWorkingSetExInformation) ntdll: Do not use hardcoded page shift in NtQueryVirtualMemory(MemoryWorkingSetExInformation) ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional page check https://gitlab.winehq.org/wine/wine/-/merge_requests/852

3 5

[PATCH v3 0/1] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 15 Sep '22

15 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. Signed-off-by: Witold Baryluk's avatarWitold Baryluk <witold.baryluk(a)gmail.com> -- v3: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread. https://gitlab.winehq.org/wine/wine/-/merge_requests/852

2 1

[PATCH 0/1] MR863: wininet/tests: Don't send two HTTP responses for a single request in server_thread.
by Jacek Caban (＠jacek) 15 Sep '22

15 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/863

2 1

[PATCH v2 0/6] MR846: uiautomationcore: Implement basic HWND based HUIANODE behavior. (v2)
by Connor McAdams (＠cmcadams) 15 Sep '22

15 Sep '22

Changes since prior MR: - Check if HWND is valid after sending `WM_GETOBJECT` and getting a 0 return value. - Block on thread calling `UiaNodeFromHandle()` rather than the marshaling thread. - Squash `IWineUiaNode::get_prop_val` commit into commit where it is actually used. -- v2: uiautomationcore: Add tests for UiaNodeFromHandle. uiautomationcore: Create UI Automation client thread. uiautomationcore: Implement UiaNodeFromHandle. uiautomationcore: Shutdown provider thread when all returned nodes are released. uiautomationcore: Increment module reference count when starting provider thread. uiautomationcore: Implement UiaReturnRawElementProvider. https://gitlab.winehq.org/wine/wine/-/merge_requests/846

2 7

[PATCH 0/6] MR846: uiautomationcore: Implement basic HWND based HUIANODE behavior. (v2)
by Connor McAdams (＠cmcadams) 15 Sep '22

15 Sep '22

Changes since prior MR: - Check if HWND is valid after sending `WM_GETOBJECT` and getting a 0 return value. - Block on thread calling `UiaNodeFromHandle()` rather than the marshaling thread. - Squash `IWineUiaNode::get_prop_val` commit into commit where it is actually used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/846

3 15

Re: [PATCH v2 0/2] MR827: winusb: Add WinUsb_Free stub. - approved
by Huw Davies (＠huw) 15 Sep '22

15 Sep '22

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/827

1 0

Re: [PATCH v2 0/2] MR827: winusb: Add WinUsb_Free stub.
by Huw Davies (＠huw) 15 Sep '22

15 Sep '22

Looks like the app calls `WinUsb_Free(NULL)` on startup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/827#note_8508

1 0

[PATCH 0/1] MR854: winevulkan: Update to VK spec version 1.3.228.
by Georg Lehmann (＠DadSchoorse) 15 Sep '22

15 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/854

2 1

[PATCH v3 0/4] MR820: Implement application hives in the registry
by Santino Mazza (＠tati1454) 15 Sep '22

15 Sep '22

-- v3: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_LOAD_APP_KEY flag ntdll: Pass filename to server in NtLoadKeyEx. ntdll: Implement roothandle parameter for NtLoadKeyEx https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 7

[PATCH 0/6] MR844: win32u: Move display modes enumeration and WM_DISPLAYCHANGE out of graphics drivers.
by Rémi Bernon (＠rbernon) 15 Sep '22

15 Sep '22

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/551. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/844

3 19

[PATCH 0/1] MR851: po: Update Dutch translation
by Floris Renaud (＠jkfloris) 15 Sep '22

15 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/851

4 4

[PATCH v2 0/11] MR849: xmllite/writer: Add initial implementation of WriteNode().
by Nikolay Sivov (＠nsivov) 15 Sep '22

15 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: xmllite/writer: Implement WriteNodeShallow(). xmllite/writer: Handle empty local name in WriteAttributeString(). xmllite/tests: Add a test for IsEmptyElement() on attributes. xmllite/tests: Add some more tests for WriteStartElement(). xmllite/writer: Add initial implementation of WriteNode(). xmllite/writer: Implement WriteAttributes(). xmllite/writer: Close open tag on WriteProcessingInstruction(). xmllite/writer: Close open tag on WriteRaw(). xmllite/writer: Handle empty prefix and uri correctly in WriteStartElement(). xmllite/writer: Implement WriteWhitespace(). xmllite/reader: Improve xml declaration node parsing. https://gitlab.winehq.org/wine/wine/-/merge_requests/849

2 11

[PATCH 0/1] MR853: kernelbase: Return system error codes in the ReadDirectoryChangesW() completion callback.
by Zhiyi Zhang (＠zhiyi) 15 Sep '22

15 Sep '22

Return system error codes instead of NT status codes in the ReadDirectoryChangesW() completion callback. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/853

2 1

[PATCH v4 0/8] MR813: winecoreaudio: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) 15 Sep '22

15 Sep '22

-- v4: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. winecoreaudio: Switch to string as device identifier, to match other drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

2 10

Re: [PATCH v2 0/2] MR827: winusb: Add WinUsb_Free stub.
by Mohamad Al-Jaf (＠maljaf) 15 Sep '22

15 Sep '22

Not sure who to request review from for this MR. Can anyone with approval privileges please review it? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/827#note_8471

1 0

[PATCH 0/4] MR850: server: Fix debug register getting/setting on macOS.
by Brendan Shanks (＠bshanks) 14 Sep '22

14 Sep '22

- On macOS, add error reporting when getting/setting debug registers. - Also, as in ptrace.c, use context->machine to determine which context struct to read/write. - And when setting, ensure that the correct debug state flavor is used (needed for Wow64) The debug register tests should now pass on Mojave and Monterey, for 32- and 64-bit. Note that Rosetta 2 on Apple Silicon mostly doesn't emulate debug registers, and the tests fail there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/850

2 4

Re: [PATCH v4 0/1] MR804: mf: Assume maintainership of MF transforms. - approved
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/804

1 0

Re: [PATCH v7 0/8] MR795: mshtml: Implement Storage Events. - approved
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/795

1 0

Re: [PATCH v7 0/9] MR716: windows.devices.enumeration: Add DeviceWatcher class and IDeviceInformationStatics2 interface. - approved
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/716

1 0

Re: [PATCH v2 0/2] MR845: tests: urlmon and wininet fixes - approved
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/845

1 0

Re: [PATCH v14 0/2] MR787: notepad: Add status bar and goto line dialog - approved
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787

1 0

[PATCH 0/9] MR849: xmllite/writer: Add initial implementation of WriteNode().
by Nikolay Sivov (＠nsivov) 14 Sep '22

14 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/849

2 9

[PATCH 0/1] MR848: ntoskrnl: KeIpiGenericCall semi-stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 14 Sep '22

14 Sep '22

fixes bug #48989 based on a patch that was made in that issue -- https://gitlab.winehq.org/wine/wine/-/merge_requests/848

2 1

[PATCH 0/9] MR847: winegstreamer: Misc MF transform fixes and unifying.
by Rémi Bernon (＠rbernon) 14 Sep '22

14 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/847

2 9

[PATCH v3 0/1] MR804: mf: Assume maintainership of MF transforms.
by Rémi Bernon (＠rbernon) 14 Sep '22

14 Sep '22

-- v3: maintainers: Assume maintainership of MF transforms. https://gitlab.winehq.org/wine/wine/-/merge_requests/804

2 1

Re: [PATCH 0/1] MR351: include: Define atomic read/write helpers for 32-bit integers. - approved
by Zebediah Figura (＠zfigura) 14 Sep '22

14 Sep '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/351

1 0

[PATCH v6 0/8] MR795: mshtml: Implement Storage Events.
by Gabriel Ivăncescu (＠insn) 14 Sep '22

14 Sep '22

This implements sending StorageEvents to the same window/doc from where the storage change happened, which seems to be a thing on native IE. For some reason I was unable to have them actually sent to other windows, so that's not implemented since I've no idea how that even gets triggered to test it, and if it does it will probably be in a follow up MR, even though that's *supposed* to be the use of these events� localStorage sends for `onstoragecommit` on the doc that did the change, while sessionStorage sends for `onstorage` on the window and doc that did the change, depending on compat mode. Although the event sent to the document's `onstorage` seems to be a legacy/old-style event (as tests show). Tests are on the last patch since events have to be sent properly (else it hangs). -- v6: mshtml: Send StorageEvents to iframe windows properly. mshtml: Don't expose document.onstorage for IE9+ modes. mshtml/tests: Add tests for StorageEvents with parallel documents. mshtml: Send StorageEvents when removing an existing item. mshtml: Send StorageEvents when setting an item. mshtml: Implement StorageEvent and send it when clearing the storage. mshtml: Move the MessageEvent construction to a helper. include/mshtml: Add IDOMStorageEvent and DispDOMStorageEvent interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/795

4 11

[PATCH v6 0/9] MR716: windows.devices.enumeration: Add DeviceWatcher class and IDeviceInformationStatics2 interface.
by Julian Klemann (＠jklemann) 14 Sep '22

14 Sep '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53328 -- v6: windows.devices.enumeration/tests: Add test for Stopped DeviceWatcher event. windows.devices.enumeration: Implement Stopped handler for DeviceWatcher. windows.devices.enumeration: Add DeviceWatcher stub. windows.devices.enumeration: Add IDeviceInformationStatics2 stub. windows.devices.enumeration: Create private header file. windows.devices.enumeration: Replace STDMETHODCALLTYPE with WINAPI. include/windows.devices.enumeration: Define IDeviceInformationStatics2. include/windows.devices.enumeration: Update file to newer formatting. widl: Use "cinterface(IInspectable)" for IInspectable signature. https://gitlab.winehq.org/wine/wine/-/merge_requests/716

3 12

[PATCH v5 0/8] MR716: windows.devices.enumeration: Add DeviceWatcher class and IDeviceInformationStatics2 interface.
by Julian Klemann (＠jklemann) 14 Sep '22

14 Sep '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53328 -- v5: windows.devices.enumeration/tests: Add test for Stopped DeviceWatcher event. windows.devices.enumeration: Implement Stopped handler for DeviceWatcher. windows.devices.enumeration: Add DeviceWatcher stub. windows.devices.enumeration: Create private header file. windows.devices.enumeration: Add IDeviceInformationStatics2 interface. windows.devices.enumeration: Replace STDMETHODCALLTYPE with WINAPI. include/windows.devices.enumeration: Update file to newer formatting. widl: Use "cinterface(IInspectable)" for IInspectable signature. https://gitlab.winehq.org/wine/wine/-/merge_requests/716

3 18

[PATCH v2 0/6] MR832: uiautomationcore: Implement basic HWND based HUIANODE behavior.
by Connor McAdams (＠cmcadams) 14 Sep '22

14 Sep '22

This series has been split up more than the prior two, keeping the non-tests diffs below 200. Hopefully it's easier to review now. If not, please let me know and I can _try_ to split it further, but I'm not sure it can get much more split up than this. -- v2: uiautomationcore: Add tests for UiaNodeFromHandle. uiautomationcore: Create UI Automation client thread. uiautomationcore: Implement UiaNodeFromHandle. uiautomationcore: Shutdown provider thread when all returned nodes are released. uiautomationcore: Increment module reference count when starting provider thread. uiautomationcore: Implement UiaReturnRawElementProvider. https://gitlab.winehq.org/wine/wine/-/merge_requests/832

2 9

2025

2024

2023

2022

wine-gitlab