- wine-gitlab - winehq.org

[PATCH 0/2] MR845: tests: urlmon and wininet fixes
by Jacek Caban (＠jacek) 14 Sep '22

14 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/845

3 3

[PATCH 0/7] MR832: uiautomationcore: Implement basic HWND based HUIANODE behavior.
by Connor McAdams (＠cmcadams) 14 Sep '22

14 Sep '22

This series has been split up more than the prior two, keeping the non-tests diffs below 200. Hopefully it's easier to review now. If not, please let me know and I can _try_ to split it further, but I'm not sure it can get much more split up than this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/832

3 23

Re: [PATCH v4 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Henri Verbeet (＠hverbeet) 14 Sep '22

14 Sep '22

This [patch](/uploads/c1e4bf81d3bd864581162cfd244d6b3d/patch.diff) helps for me; I'll send it in, along with some other fixes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/814#note_8417

1 0

Re: [PATCH v2 0/2] MR820: Implement application hives in the registry
by Huw Davies (＠huw) 14 Sep '22

14 Sep '22

On Wed Sep 14 11:53:01 2022 +0000, Santino Mazza wrote: > Because it simplifies the implementation for saving the registry into > the file when NtClose get's called. If I want to keep the object handle > implementation the server should take control for closing the file > handle, and I don't like that idea so much, I think the caller should be > responsible for closing the objects it opens. Ok, let me look into that more. There are a couple more changes you could make in the meantime: - Split the `REG_LOAD_APP_KEY` logic and the return key logic into two commits. - Move the `NtClose()` outside of the `SERVER_START_REQ` block. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8415

1 0

Re: [PATCH v2 0/2] MR820: Implement application hives in the registry
by Santino Mazza (＠tati1454) 14 Sep '22

14 Sep '22

On Wed Sep 14 10:35:23 2022 +0000, Huw Davies wrote: > Why are you now sending the filename, rather than the file object > handle, to the server? Because it simplifies the implementation for saving the registry into the file when NtClose get's called. If I want to keep the object handle implementation the server should take control for closing the file handle, and I don't like that idea so much, I think the caller should be responsible for closing the objects it opens. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8405

1 0

Re: [PATCH v4 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Bernhard Kölbl (＠besentv) 14 Sep '22

14 Sep '22

On Wed Sep 14 10:36:44 2022 +0000, Alexandre Julliard wrote: > > I bisected the failure and it looks like it's caused instead by > 44d6f2adbcca119faebc095f3cfbeeafc50d04f3, from > https://gitlab.winehq.org/wine/wine/-/merge_requests/657. Reverting it > alone fixes it: > Ah sorry about that, reverting your MR fixed it for me but it's possible > that I screwed up the test. - Just a test message from E-Mail. - Am Mi., 14. Sept. 2022 um 11:05 Uhr schrieb Alexandre Julliard (@julliard) <gitlab(a)winehq.org>: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/814#note_8404

1 0

Re: [PATCH v2 0/2] MR820: Implement application hives in the registry
by Huw Davies (＠huw) 14 Sep '22

14 Sep '22

Huw Davies (@huw) commented about server/protocol.def: > > /* Load a registry branch from a file */ > @REQ(load_registry) > - obj_handle_t file; /* file to load from */ > + unsigned int flags; /* flags */ > + unsigned int access; /* wanted access rights */ > VARARG(objattr,object_attributes); /* object attributes */ > + VARARG(filename,string); /* file to load name */ Why are you now sending the filename, rather than the file object handle, to the server? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8403

1 0

Re: [PATCH v2 0/2] MR820: Implement application hives in the registry
by Huw Davies (＠huw) 14 Sep '22

14 Sep '22

Huw Davies (@huw) commented about dlls/advapi32/tests/registry.c: > /* Test simple key load */ > /* Check if the changes are saved */ > ret = RegLoadAppKeyA(hivefilepath, &appkey, KEY_READ | KEY_WRITE, 0, 0); > - ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", ret); > - ok(appkey != NULL, "got a null key\n"); > + todo_wine ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", ret); > + todo_wine ok(appkey != NULL, "got a null key\n"); I'd suggest swapping the order of these commits so that you don't end up having to flip-flop these `todo_wine`s. Also note that there's now no need to add the Signed-off-by tags. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8402

1 0

Re: [PATCH v4 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

> I bisected the failure and it looks like it's caused instead by 44d6f2adbcca119faebc095f3cfbeeafc50d04f3, from https://gitlab.winehq.org/wine/wine/-/merge_requests/657. Reverting it alone fixes it: Ah sorry about that, reverting your MR fixed it for me but it's possible that I screwed up the test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/814#note_8398

1 0

Re: [PATCH v2 0/1] MR842: ntdll: add system32/drivers to dll search path
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

This should be handled already by LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR. If that doesn't work in your case you'll need to investigate why, but we can't change the global search path for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/842#note_8397

1 0

Re: [PATCH v2 0/1] MR842: ntdll: add system32/drivers to dll search path - closed
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/842

1 0

Re: [PATCH v2 0/5] MR657: wined3d: Managed texture patches.
by Rémi Bernon (＠rbernon) 14 Sep '22

14 Sep '22

FWIW it looks like this broke ddraw tests, see https://gitlab.winehq.org/wine/wine/-/merge_requests/814#note_8392 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/657#note_8395

1 0

Re: [PATCH v4 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Rémi Bernon (＠rbernon) 14 Sep '22

14 Sep '22

1 0

[PATCH v13 0/2] MR787: notepad: Add status bar and goto line dialog
by Jacob Czekalla (＠Maaka00524) 14 Sep '22

14 Sep '22

Added a status bar to track line and column number Added a goto line dialog -- v13: notepad: Track and display line number and column. https://gitlab.winehq.org/wine/wine/-/merge_requests/787

3 3

Re: [PATCH v4 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

It turns out that it breaks the ddraw tests, could you please have a look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/814#note_8390

1 0

[PATCH v3 0/9] MR813: mmdevapi: Integrate winecoreaudio's additions in unixlib.h.
by Davide Beatrici (＠davidebeatrici) 14 Sep '22

14 Sep '22

-- v3: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "endpoint" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. winecoreaudio: Switch to string as device identifier, to match other drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

3 13

[PATCH v4 0/2] MR841: ntoskrnl: processor change callback stubs
by Etaash Mathamsetty (＠etaash.mathamsetty) 13 Sep '22

13 Sep '22

required for mrac anti cheat -- v4: ntoskrnl: KeDeregisterProcessorChangeCallback stub https://gitlab.winehq.org/wine/wine/-/merge_requests/841

3 3

Re: [PATCH v3 0/6] MR791: mf: Test AAC encoder / decoder presence, begin factoring some transform tests. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/791

1 0

Re: [PATCH v4 0/8] MR814: win32u: Avoid copies in display adapter settings logic. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/814

1 0

Re: [PATCH v2 0/3] MR838: Improvement for inline context debug information. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/838

1 0

Re: [PATCH v3 0/4] MR835: dwrite/layout: Improve trailing empty line metrics. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/835

1 0

Re: [PATCH v2 0/1] MR754: wined3d: Pass a draw count of 1 to Vulkan indirect draw commands. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/754

1 0

Re: [PATCH v2 0/5] MR657: wined3d: Managed texture patches. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/657

1 0

Re: [PATCH v2 0/1] MR765: wined3d: Do not create larger staging buffers than necessary in adapter_vk_copy_bo_address(). - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/765

1 0

Re: [PATCH v2 0/1] MR809: widl: Allow parameterized types in runtimeclass interfaces. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/809

1 0

Re: [PATCH v3 0/9] MR834: Bcrypt algorithm pseudo handles - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/834

1 0

Re: [PATCH v3 0/4] MR833: A few stubs for advapi perf functions. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/833

1 0

Re: [PATCH v3 0/9] MR803: winegstreamer: Refactor wm async reader clock. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/803

1 0

[PATCH 0/1] MR841: ntoskrnl: processor change callback stubs
by Etaash Mathamsetty (＠etaash.mathamsetty) 13 Sep '22

13 Sep '22

required for mrac anti cheat -- https://gitlab.winehq.org/wine/wine/-/merge_requests/841

2 1

[PATCH 0/1] MR839: ntoskrnl: fix bug with MmGetSystemRoutineAddress
by Etaash Mathamsetty (＠etaash.mathamsetty) 13 Sep '22

13 Sep '22

MmGetSystemRoutineAddress wasn't finding some functions in ntoskrnl and hal.dll, this patch fixes it required by mrac anti cheat -- https://gitlab.winehq.org/wine/wine/-/merge_requests/839

3 2

[PATCH 0/1] MR840: ntoskrnl: KeSetTargetProcessorDpcEx stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 13 Sep '22

13 Sep '22

required by mrac anti cheat -- https://gitlab.winehq.org/wine/wine/-/merge_requests/840

2 1

[PATCH v2 0/6] MR791: mf: Test AAC encoder / decoder presence, begin factoring some transform tests.
by Rémi Bernon (＠rbernon) 13 Sep '22

13 Sep '22

-- v2: mf/tests: Factor IMFTransform required attributes checks together. mf/tests: Test AAC decoder MFT presence and media types. mf/tests: Test AAC encoder MFT presence and media types. mf/tests: Split create_transform into check_(mft|dmo)_(enum|get_info). mf/tests: Add some winetest context to MFT tests. mf/tests: Split IMFTransform tests to transform.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/791

3 8

Re: [PATCH v5 0/1] MR826: wined3d: Add support for Renoir GPUs
by Henri Verbeet (＠hverbeet) 13 Sep '22

13 Sep '22

> As far as I can tell it was changed (perhaps inadvertently) by Mesa commit 0cb42c57c569443b0af8296dfff4da1e6ab241ef. Previously "AMD" string would be present in the renderer string for cases where there was no marketing name (i.e. Etaash's gpu would have a GL_RENDERER value beginning with "AMD RENOIR"). Looks plausible enough; ideally we'd get that fixed. > As far as I can tell, radeonsi has only ever reported a GL_VENDOR of "X.org" or (more recently) "AMD", so we've been relying on "AMD" being present in the renderer string. It's slightly worse, actually. Cards with a "marketing" name will have a renderer string like "Radeon RX Vega (VEGA10, ...)", so for these we'd depend on the "Radeon"/"FirePro" strings. If the vendor string now includes "AMD" we'd certainly want to use that; in that regard the original commit is fine. > It may also be a good idea to try matching the card vendor based on the PCI vendor first; I imagine that will remain a bit more stable against changes like this. Yes, I think that would be helpful. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/826#note_8323

2 1

[PATCH v6 0/1] MR777: ntoskrnl: MmAllocateContiguousMemorySpecifyCache semi-stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 13 Sep '22

13 Sep '22

This should help to get the nox android emulator to run fixes bug https://bugs.winehq.org/show_bug.cgi?id=46760 -- v6: ntoskrnl: MmAllocateContiguousMemorySpecifyCache semi-stub https://gitlab.winehq.org/wine/wine/-/merge_requests/777

4 5

Re: [PATCH v5 0/1] MR826: wined3d: Add support for Renoir GPUs
by Etaash Mathamsetty (＠etaash.mathamsetty) 13 Sep '22

13 Sep '22

On Tue Sep 13 15:10:00 2022 +0000, Henri Verbeet wrote: > > As far as I can tell it was changed (perhaps inadvertently) by Mesa > commit 0cb42c57c569443b0af8296dfff4da1e6ab241ef. Previously "AMD" string > would be present in the renderer string for cases where there was no > marketing name (i.e. Etaash's gpu would have a GL_RENDERER value > beginning with "AMD RENOIR"). > Looks plausible enough; ideally we'd get that fixed. > > As far as I can tell, radeonsi has only ever reported a GL_VENDOR of > "X.org" or (more recently) "AMD", so we've been relying on "AMD" being > present in the renderer string. > It's slightly worse, actually. Cards with a "marketing" name will have a > renderer string like "Radeon RX Vega (VEGA10, ...)", so for these we'd > depend on the "Radeon"/"FirePro" strings. If the vendor string now > includes "AMD" we'd certainly want to use that; in that regard the > original commit is fine. > > It may also be a good idea to try matching the card vendor based on > the PCI vendor first; I imagine that will remain a bit more stable > against changes like this. > Yes, I think that would be helpful. I modified the PR to use the PCI id yesterday, so there's no need to "guess" which card this is anymore, and it works as expected. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/826#note_8343

1 0

[PATCH v3 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Rémi Bernon (＠rbernon) 13 Sep '22

13 Sep '22

As well as a few other fixes for https://gitlab.winehq.org/wine/wine/-/merge_requests/551. -- v3: win32u: Introduce a new internal WINE_DM_UNSUPPORTED display flag. win32u: Pass adapter parameter to (read|write)_registry_settings. win32u: Avoid unnecessary copy of adapter path and device name. win32u: Avoid copying the modes array in NtUserChangeDisplaySettings. win32u: Introduce reference counting to struct adapter. win32u: Fill the local full_mode variable instead of using the modes array. win32u: Rename get_full_mode variables and avoid using devmode directly. wineandroid.drv: Add missing DM_DISPLAYORIENTATION flag on display mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/814

3 9

[PATCH 0/3] MR838: Improvement for inline context debug information.
by eric pouech (＠epo) 13 Sep '22

13 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/838

2 3

[PATCH v5 0/8] MR795: mshtml: Implement Storage Events.
by Gabriel Ivăncescu (＠insn) 13 Sep '22

13 Sep '22

This implements sending StorageEvents to the same window/doc from where the storage change happened, which seems to be a thing on native IE. For some reason I was unable to have them actually sent to other windows, so that's not implemented since I've no idea how that even gets triggered to test it, and if it does it will probably be in a follow up MR, even though that's *supposed* to be the use of these events�� localStorage sends for `onstoragecommit` on the doc that did the change, while sessionStorage sends for `onstorage` on the window and doc that did the change, depending on compat mode. Although the event sent to the document's `onstorage` seems to be a legacy/old-style event (as tests show). Tests are on the last patch since events have to be sent properly (else it hangs). -- v5: mshtml: Send StorageEvents to iframe windows properly. mshtml: Don't expose document.onstorage for IE9+ modes. mshtml/tests: Add tests for StorageEvents with parallel documents. mshtml: Send StorageEvents when removing an existing item. mshtml: Send StorageEvents when setting an item. mshtml: Implement StorageEvent and send it when clearing the storage. mshtml: Move the MessageEvent construction to a helper. include/mshtml: Add IDOMStorageEvent and DispDOMStorageEvent interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/795

4 23

[PATCH v12 0/3] MR787: notepad: Add status bar and goto line dialog
by Jacob Czekalla (＠Maaka00524) 13 Sep '22

13 Sep '22

Added a status bar to track line and column number Added a goto line dialog -- v12: notepad: Track and display line number and column. https://gitlab.winehq.org/wine/wine/-/merge_requests/787

3 4

[PATCH v11 0/2] MR787: notepad: Add status bar and goto line dialog
by Jacob Czekalla (＠Maaka00524) 13 Sep '22

13 Sep '22

Added a status bar to track line and column number Added a goto line dialog -- v11: notepad: Track and display line number and column. https://gitlab.winehq.org/wine/wine/-/merge_requests/787

3 4

[PATCH v2 0/4] MR835: dwrite/layout: Improve trailing empty line metrics.
by Nikolay Sivov (＠nsivov) 13 Sep '22

13 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: dwrite/layout: Limit text window passed to MapCharacters() to the range of characters to map. https://gitlab.winehq.org/wine/wine/-/merge_requests/835

2 4

[PATCH 0/5] MR657: wined3d: Managed texture patches.
by Zebediah Figura (＠zfigura) 13 Sep '22

13 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/657

6 12

Re: [PATCH v4 0/1] MR722: wined3d:Set desc.depth To TRUE For Unrecognized Depth Buffer Type
by Jan Sikorski (＠jsikorski) 13 Sep '22

13 Sep '22

What do the linked test results show? I assume you made those runs with the changed tests as in the patch. If so, it seems that this proposed behavior is correct for d3d8, but not for d3d9? If that's right, we should probably include this distinction in the implementation; and the d3d9 test should be changed to reflect actual behavior. As an aside, the commit could be improved in terms of style: Don't Capitalize Every Word, fix oddly placed whitespace, and drop the `<br>`. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/722#note_8315

1 0

[PATCH 0/1] MR688: ntdll: Introduce "WINEWOW64" environment variable, to enable new WoW64 behavior.
by Davide Beatrici (＠davidebeatrici) 13 Sep '22

13 Sep '22

https://www.winehq.org/pipermail/wine-devel/2022-April/213620.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/688

7 10

[PATCH 0/1] MR809: widl: Allow parameterized types in runtimeclass interfaces.
by Rémi Bernon (＠rbernon) 13 Sep '22

13 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/809

4 5

[PATCH 0/3] MR836: msdasql: Implement ICommandProperties GetProperties
by Alistair Leslie-Hughes (＠alesliehughes) 13 Sep '22

13 Sep '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/836

2 3

[PATCH v2 0/9] MR834: Bcrypt algorithm pseudo handles
by Hans Leidekker (＠hans) 13 Sep '22

13 Sep '22

-- v2: rsaenh: Use BCrypt algorithm pseudo-handles. ncrypt: Use BCrypt algorithm pseudo-handles. fusion: Use BCrypt algorithm pseudo-handles. dssenh: Use BCrypt algorithm pseudo-handles. crypt32: Use BCrypt algorithm pseudo-handles. appwiz.cpl: Use BCryptHash(). appwiz.cpl: Use BCrypt algorithm pseudo-handles. bcrypt: Rename mode_id to chain_mode. bcrypt: Add full support for algorithm pseudo-handles. https://gitlab.winehq.org/wine/wine/-/merge_requests/834

2 9

[PATCH 0/9] MR834: Bcrypt algorithm pseudo handles
by Hans Leidekker (＠hans) 13 Sep '22

13 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/834

3 11

[PATCH 0/4] MR835: dwrite/layout: Improve trailing empty line metrics.
by Nikolay Sivov (＠nsivov) 13 Sep '22

13 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/835

2 4

[PATCH 0/1] MR825: winex11.drv: optimize repeated ClipCursor calls
by Jan Klötzke (＠jkloetzke) 13 Sep '22

13 Sep '22

At least Doom 64 calls ClipCursor() with identical parameters repeatedly, which seems to cause a considerable overhead. Together with high polling rate mouse input this causes the game to almost freeze while the mouse is being moved. So if the clipping did not change we can bail out early because it will not cause any observable difference anyway. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46976 Signed-off-by: Jan Kl��tzke <jan(a)kloetzke.net> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/825

3 4

[PATCH v2 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Rémi Bernon (＠rbernon) 13 Sep '22

13 Sep '22

As well as a few other fixes for https://gitlab.winehq.org/wine/wine/-/merge_requests/551. -- v2: win32u: Introduce a new internal WINE_DM_UNSUPPORTED display flag. win32u: Rename (read|write)_registry_settings to adapter_(set|get)_default_mode. win32u: Avoid unnecessary copy of adapter path and device name. win32u: Avoid copying the modes array in NtUserChangeDisplaySettings. win32u: Introduce reference counting to struct adapter. win32u: Fill the local full_mode variable instead of using the modes array. win32u: Rename get_full_mode variables and avoid using devmode directly. wineandroid.drv: Add missing DM_DISPLAYORIENTATION flag on display mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/814

3 11

[PATCH v9 0/2] MR787: notepad: Add status bar and goto line dialog
by Jacob Czekalla (＠Maaka00524) 13 Sep '22

13 Sep '22

Added a status bar to track line and column number Added a goto line dialog -- v9: notepad: Track and display line number and column. https://gitlab.winehq.org/wine/wine/-/merge_requests/787

2 2

[PATCH 0/4] MR833: A few stubs for advapi perf functions.
by Paul Gofman (＠gofman) 13 Sep '22

13 Sep '22

Used by Red Dead Redemption 2 after latest update. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/833

4 6

[PATCH v2 0/4] MR833: A few stubs for advapi perf functions.
by Paul Gofman (＠gofman) 13 Sep '22

13 Sep '22

Used by Red Dead Redemption 2 after latest update. -- v2: advapi32: Add stub for PerfQueryCounterData(). advapi32: Add stub for PerfAddCounters(). https://gitlab.winehq.org/wine/wine/-/merge_requests/833

2 4

[PATCH 0/2] MR820: Implement application hives in the registry
by Santino Mazza (＠tati1454) 13 Sep '22

13 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/820

4 8

[PATCH v2 0/1] MR826: wined3d: Fix bug with AMD gl vendor returning Nvidia
by Etaash Mathamsetty (＠etaash.mathamsetty) 12 Sep '22

12 Sep '22

Due to me updating to mesa-git, the gl vendor string got changed and now wine thinks it's an nvidia card, so this patch fixes it -- v2: wined3d: Fix bug with AMD gl vendor returning nvidia https://gitlab.winehq.org/wine/wine/-/merge_requests/826

4 8

[PATCH v4 0/1] MR826: wined3d: Fix bug with AMD gl vendor returning Nvidia
by Etaash Mathamsetty (＠etaash.mathamsetty) 12 Sep '22

12 Sep '22

Due to me updating to mesa-git, the gl vendor string got changed and now wine thinks it's an nvidia card, so this patch fixes it -- v4: wined3d: Add support for renoir graphics https://gitlab.winehq.org/wine/wine/-/merge_requests/826

2 2

[PATCH v4 0/8] MR795: mshtml: Implement Storage Events.
by Gabriel Ivăncescu (＠insn) 12 Sep '22

12 Sep '22

This implements sending StorageEvents to the same window/doc from where the storage change happened, which seems to be a thing on native IE. For some reason I was unable to have them actually sent to other windows, so that's not implemented since I've no idea how that even gets triggered to test it, and if it does it will probably be in a follow up MR, even though that's *supposed* to be the use of these events�� localStorage sends for `onstoragecommit` on the doc that did the change, while sessionStorage sends for `onstorage` on the window and doc that did the change, depending on compat mode. Although the event sent to the document's `onstorage` seems to be a legacy/old-style event (as tests show). Tests are on the last patch since events have to be sent properly (else it hangs). -- v4: mshtml: Send StorageEvents to iframe windows properly. mshtml: Don't expose document.onstorage for IE9+ modes. mshtml/tests: Add tests for StorageEvents with parallel documents. mshtml: Send StorageEvents when removing an existing item. mshtml: Send StorageEvents when setting an item. mshtml: Implement StorageEvent and send it when clearing the storage. mshtml: Move the MessageEvent construction to a helper. include/mshtml: Add IDOMStorageEvent and DispDOMStorageEvent interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/795

3 13

[PATCH v2 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx
by Etaash Mathamsetty (＠etaash.mathamsetty) 12 Sep '22

12 Sep '22

required by mrac anti-cheat -- v2: ntoskrnl: Implement KeGetCurrentProcessorNumberEx https://gitlab.winehq.org/wine/wine/-/merge_requests/824

3 3

Re: [PATCH v2 0/1] MR831: dwrite/layout: Use same logic for mapping both non-visual and visual runs. - approved
by Alexandre Julliard (＠julliard) 12 Sep '22

12 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/831

1 0

Re: [PATCH v2 0/1] MR823: dbghelp: Add SymSrvGetFileIndexInfo stub. - approved
by Alexandre Julliard (＠julliard) 12 Sep '22

12 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/823

1 0

Re: [PATCH v2 0/5] MR818: Hardening debug info support. - approved
by Alexandre Julliard (＠julliard) 12 Sep '22

12 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/818

1 0

Re: [PATCH v2 0/1] MR828: bcrypt: Support setting BCRYPT_CHAIN_MODE_CFB on keys. - approved
by Alexandre Julliard (＠julliard) 12 Sep '22

12 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/828

1 0

Re: [PATCH v4 0/1] MR808: d2d1/tests: Mark some more failing tests as todo. - approved
by Alexandre Julliard (＠julliard) 12 Sep '22

12 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/808

1 0

Re: [PATCH v2 0/1] MR829: webservices/tests: Mark tests that fail on 64-bit as todo. - approved
by Alexandre Julliard (＠julliard) 12 Sep '22

12 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/829

1 0

Re: [PATCH v2 0/1] MR819: oleaut32: Check that the 32/64 syskind matches when getting a typelib from the cache. - approved
by Alexandre Julliard (＠julliard) 12 Sep '22

12 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/819

1 0

[PATCH v2 0/9] MR803: winegstreamer: Refactor wm async reader clock.
by Rémi Bernon (＠rbernon) 12 Sep '22

12 Sep '22

-- v2: winegstreamer: Request the wm_reader stream only when necessary. winegstreamer: Introduce a new async_reader_wait_pts helper. winegstreamer: Factor async_reader waits using async_reader_get_wait_timeout. winegstreamer: Check whether the reader is still running before user time. winegstreamer: Keep start time in the async_reader struct. winegstreamer: Implement async reader asynchronous seeking. winegstreamer: Unconditionally assign new context for ASYNC_OP_START. winegstreamer: Wrap async reader op new_context in a union. wmvcore/tests: Add some tests starting WM reader with NULL context. https://gitlab.winehq.org/wine/wine/-/merge_requests/803

4 11

[PATCH v3 0/3] MR801: uiautomationcore: Implement basic HWND based HUIANODE behavior.
by Connor McAdams (＠cmcadams) 12 Sep '22

12 Sep '22

Hopefully this patch series is easier to review than the last one. -- v3: uiautomationcore: Implement UiaNodeFromHandle. https://gitlab.winehq.org/wine/wine/-/merge_requests/801

2 6

[PATCH v3 0/1] MR808: d2d1/tests: Mark some more failing tests as todo.
by Alexandre Julliard (＠julliard) 12 Sep '22

12 Sep '22

-- v3: d2d1/tests: Adjust geometry to make tests pass on all devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/808

3 3

[PATCH 0/1] MR831: dwrite/layout: Use same logic for mapping both non-visual and visual runs.
by Nikolay Sivov (＠nsivov) 12 Sep '22

12 Sep '22

Both non-visual and visual runs go through fallback mapping process, and could end up with hard coded default at the end if fallback was insufficient. Visual runs are using custom fallback and then the system one, non-visual ones are using only system fallback. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/831

2 1

[PATCH 0/7] MR830: ntdll DOS file attributes
by Joel Holdsworth (＠jhol) 12 Sep '22

12 Sep '22

Patches from wine-staging Fixes: #9158 Support for DOS hidden/system file attributes Fixes: #15679 cygwin symlinks not working in wine -- https://gitlab.winehq.org/wine/wine/-/merge_requests/830

6 18

[PATCH v2 0/3] MR811: d2d1: Save render target type and usage.
by Zhiyi Zhang (＠zhiyi) 12 Sep '22

12 Sep '22

So that d2d_device_context_IsSupported() can know what type and usage a render target is created for. -- v2: d2d1: Implement d2d_device_context_IsSupported(). d2d1: Save render target type and usage. d2d1/tests: Test d2d_device_context_IsSupported(). https://gitlab.winehq.org/wine/wine/-/merge_requests/811

3 5

[PATCH v7 0/2] MR787: notepad: Add status bar and goto line dialog
by Jacob Czekalla (＠Maaka00524) 12 Sep '22

12 Sep '22

Added a status bar to track line and column number Added a goto line dialog -- v7: notepad: Track and display line number and column. notepad: Show status bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/787

3 7

[PATCH v2 0/1] MR808: d2d1/tests: Mark some more failing tests as todo.
by Alexandre Julliard (＠julliard) 12 Sep '22

12 Sep '22

-- v2: d2d1/tests: Mark some more tests that fail on NVidia devices as todo. https://gitlab.winehq.org/wine/wine/-/merge_requests/808

5 8

[PATCH v3 0/6] MR795: mshtml: Implement Storage Events.
by Gabriel Ivăncescu (＠insn) 12 Sep '22

12 Sep '22

This implements sending StorageEvents to the same window/doc from where the storage change happened, which seems to be a thing on native IE. For some reason I was unable to have them actually sent to other windows, so that's not implemented since I've no idea how that even gets triggered to test it, and if it does it will probably be in a follow up MR, even though that's *supposed* to be the use of these events�� localStorage sends for `onstoragecommit` on the doc that did the change, while sessionStorage sends for `onstorage` on the window and doc that did the change, depending on compat mode. Although the event sent to the document's `onstorage` seems to be a legacy/old-style event (as tests show). Tests are on the last patch since events have to be sent properly (else it hangs). -- v3: mshtml/tests: Add tests for StorageEvents. mshtml: Send StorageEvents when removing an existing item. mshtml: Send StorageEvents when setting an item. mshtml: Implement StorageEvent and send it when clearing the storage. mshtml: Move the MessageEvent construction to a helper. include: Add IDOMStorageEvent and DispDOMStorageEvent interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/795

4 20

[PATCH 0/1] MR829: webservices/tests: Mark tests that fail on 64-bit as todo.
by Alexandre Julliard (＠julliard) 12 Sep '22

12 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/829

3 2

[PATCH v2 0/10] MR813: mmdevapi: Integrate winecoreaudio's additions in unixlib.h.
by Davide Beatrici (＠davidebeatrici) 12 Sep '22

12 Sep '22

-- v2: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_mix_format_params" struct to mmdevapi's. winecoreaudio: Adapt "is_format_supported_params" struct to mmdevapi's. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "endpoint" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

3 12

[PATCH 0/1] MR828: bcrypt: Support setting BCRYPT_CHAIN_MODE_CFB on keys.
by Hans Leidekker (＠hans) 12 Sep '22

12 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/828

2 1

Re: [PATCH v2 0/5] MR169: user32/tests: Cleanup some tests. - closed
by Rémi Bernon (＠rbernon) 12 Sep '22

12 Sep '22

This merge request was closed by R��mi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/169

1 0

[PATCH 0/1] MR819: oleaut32: Check that the 32/64 syskind matches when getting a typelib from the cache.
by Alexandre Julliard (＠julliard) 12 Sep '22

12 Sep '22

Fixes test failures on 64-bit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/819

3 2

[PATCH 0/5] MR502: winusb: Add WinUsb_Free stub.
by Mohamad Al-Jaf (＠maljaf) 12 Sep '22

12 Sep '22

The program REVELPROG_IS runs with this patchset. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52677 Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/502

3 10

[PATCH 0/2] MR827: winusb: Add WinUsb_Free stub.
by Mohamad Al-Jaf (＠maljaf) 12 Sep '22

12 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52677 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/827

2 2

[PATCH v17 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 12 Sep '22

12 Sep '22

this gets the YSDrv service to start successfully (with the MmAllocateContiguousMemorySpecifyCache semi-stub) this service is used by the nox android emulator -- v17: ntoskrnl: Add KeInsertQueueDpc stub https://gitlab.winehq.org/wine/wine/-/merge_requests/778

2 1

[PATCH 0/1] MR826: wined3d: Fix bug with AMD gl vendor returning Nvidia
by Etaash Mathamsetty (＠etaash.mathamsetty) 12 Sep '22

12 Sep '22

Due to me updating to mesa-git, the gl vendor string got changed and now wine thinks it's an nvidia card, so this patch fixes it -- https://gitlab.winehq.org/wine/wine/-/merge_requests/826

2 1

[PATCH 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx
by Etaash Mathamsetty (＠etaash.mathamsetty) 11 Sep '22

11 Sep '22

required by mrac anti-cheat -- https://gitlab.winehq.org/wine/wine/-/merge_requests/824

2 1

[PATCH v16 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 11 Sep '22

11 Sep '22

this gets the YSDrv service to start successfully (with the MmAllocateContiguousMemorySpecifyCache semi-stub) this service is used by the nox android emulator -- v16: Add KeInsertQueueDpc stub https://gitlab.winehq.org/wine/wine/-/merge_requests/778

2 1

[PATCH 0/1] MR823: dbghelp: Add SymSrvGetFileIndexInfo stub.
by Gijs Vermeulen (＠gverm) 11 Sep '22

11 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48600 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/823

2 1

[PATCH v3 0/2] MR821: Fix integer overflow bug in RtlUniform which has been fixed in Windows since Vista
by Jinoh Kang (＠iamahuman) 11 Sep '22

11 Sep '22

This MR accomplishes two things: 1. It removes unused obsolete tests for Windows XP or earlier. 2. It synchronizes RtlUniform so that it matches that of Windows Vista or later. -- v3: ntdll: Fix integer overflow in RtlUniform. ntdll/tests: Update test_RtlUniform to match Windows Vista or later. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 2

[PATCH v2 0/2] MR821: Fix integer overflow bug in RtlUniform which has been fixed in Windows since Vista
by Jinoh Kang (＠iamahuman) 11 Sep '22

11 Sep '22

This MR accomplishes two things: 1. It removes unused obsolete tests for Windows XP or earlier. 2. It synchronizes RtlUniform so that it matches that of Windows Vista or later. -- v2: ntdll: Fix integer overflow in RtlUniform. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 2

[PATCH 0/2] MR821: Fix integer overflow bug in RtlUniform which has been fixed in Windows since Vista
by Jinoh Kang (＠iamahuman) 10 Sep '22

10 Sep '22

This MR accomplishes two things: 1. It removes unused obsolete tests for Windows XP or earlier. 2. It synchronizes RtlUniform so that it matches that of Windows Vista or later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 2

Re: [PATCH v3 0/1] MR816: ping: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 09 Sep '22

09 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/816

1 0

Re: [PATCH v7 0/2] MR810: Create NtLoadKeyEx function - approved
by Alexandre Julliard (＠julliard) 09 Sep '22

09 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/810

1 0

Re: [PATCH v3 0/1] MR815: dwrite: Set initial justification value for default shaper. - approved
by Alexandre Julliard (＠julliard) 09 Sep '22

09 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/815

1 0

Re: [PATCH v7 0/1] MR812: bcrypt: Add basic support for pseudo-handles - approved
by Alexandre Julliard (＠julliard) 09 Sep '22

09 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/812

1 0

Re: [PATCH v3 0/1] MR817: msidb: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 09 Sep '22

09 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/817

1 0

[PATCH v6 0/2] MR810: Create NtLoadKeyEx function
by Santino Mazza (＠tati1454) 09 Sep '22

09 Sep '22

-- v6: ntdll: Move NtLoadKey implementation to NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/810

2 3

Re: [PATCH v5 0/2] MR810: Create NtLoadKeyEx function
by Etaash Mathamsetty (＠etaash.mathamsetty) 09 Sep '22

09 Sep '22

Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/ntdll/unix/registry.c: > * NtLoadKey (NTDLL.@) > */ > NTSTATUS WINAPI NtLoadKey( const OBJECT_ATTRIBUTES *attr, OBJECT_ATTRIBUTES *file ) > +{ > + TRACE( "(%p,%p\n)", attr, file ); Small Issue: The \n should be after the parenthesis -- https://gitlab.winehq.org/wine/wine/-/merge_requests/810#note_8142

1 0

[PATCH 0/5] MR818: Hardening debug info support.
by eric pouech (＠epo) 09 Sep '22

09 Sep '22

Various improvements in debug info support (mainly hardening of erroneous data files), and some minor fixes to dbghelp. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/818

2 5

Re: [PATCH v5 0/2] MR810: Create NtLoadKeyEx function - approved
by Huw Davies (＠huw) 09 Sep '22

09 Sep '22

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/810

1 0

Re: [PATCH v5 0/2] MR810: Create NtLoadKeyEx function
by Huw Davies (＠huw) 09 Sep '22

09 Sep '22

> Interesting, I think julliard fixed it with the latest commits. Could you rebase with them and push an update? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/810#note_8131

1 0

2025

2024

2023

2022

wine-gitlab