- wine-gitlab - winehq.org

[PATCH v3 0/2] MR810: Create NtLoadKeyEx function
by Santino Mazza (＠tati1454) 09 Sep '22

09 Sep '22

-- v3: ntdll: Move NtLoadKey implementation to NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/810

2 2

Re: [PATCH v2 0/2] MR810: Create NtLoadKeyEx function
by Santino Mazza (＠tati1454) 09 Sep '22

09 Sep '22

On Thu Sep 8 22:31:20 2022 +0000, Etaash Mathamsetty wrote: > yeah I have had the same issue numerous times, it's really annoying, for > the time being I would just squash the commits (that are built on top of > upstream, not the upstream ones themselves), it usually fixes the problem Interesting, I think julliard fixed it with the latest commits. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/810#note_8121

1 0

[PATCH 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Rémi Bernon (＠rbernon) 09 Sep '22

09 Sep '22

As well as a few other fixes for https://gitlab.winehq.org/wine/wine/-/merge_requests/551. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/814

2 9

[PATCH v5 0/1] MR812: bcrypt: Add basic support for pseudo-handles
by Christopher Denton (＠cdenton) 09 Sep '22

09 Sep '22

Support constant values for algorithm handles in `BCryptGenRandom` and make no attempt to dereference such handles (which would cause "Unhandled page fault on read access"). MSDN Documentation: https://docs.microsoft.com/en-us/windows/win32/seccng/cng-algorithm-pseudo-… --- Values of any constants are taken from this [MIT licensed](https://github.com/microsoft/windows-rs/blob/0debb1200c23f588def4… repository: https://github.com/microsoft/windows-rs I used a Python script to examine the pseudo-handles: ```python import re handles = [] p = re.compile('pub const (BCRYPT_[A-Z0-9_]+_ALG_HANDLE): BCRYPT_ALG_HANDLE = ([0-9]+)u32 as _;') with open('crates/libs/sys/src/Windows/Win32/Security/Cryptography/mod.rs') as f: t = f.read() for match in p.finditer(t): name = match.group(1) value = int(match.group(2)) handles.append((name, value)) handles.sort(key=lambda x: x[1]) for (name, value) in handles: print(f"{value:>3}\t{hex(value):>5}\t{bin(value):>12}\t{name}") ``` Output: ```text 1 0x1 0b1 BCRYPT_MD2_ALG_HANDLE 17 0x11 0b10001 BCRYPT_MD4_ALG_HANDLE 33 0x21 0b100001 BCRYPT_MD5_ALG_HANDLE 49 0x31 0b110001 BCRYPT_SHA1_ALG_HANDLE 65 0x41 0b1000001 BCRYPT_SHA256_ALG_HANDLE 81 0x51 0b1010001 BCRYPT_SHA384_ALG_HANDLE 97 0x61 0b1100001 BCRYPT_SHA512_ALG_HANDLE 113 0x71 0b1110001 BCRYPT_RC4_ALG_HANDLE 129 0x81 0b10000001 BCRYPT_RNG_ALG_HANDLE 145 0x91 0b10010001 BCRYPT_HMAC_MD5_ALG_HANDLE 161 0xa1 0b10100001 BCRYPT_HMAC_SHA1_ALG_HANDLE 177 0xb1 0b10110001 BCRYPT_HMAC_SHA256_ALG_HANDLE 193 0xc1 0b11000001 BCRYPT_HMAC_SHA384_ALG_HANDLE 209 0xd1 0b11010001 BCRYPT_HMAC_SHA512_ALG_HANDLE 225 0xe1 0b11100001 BCRYPT_RSA_ALG_HANDLE 241 0xf1 0b11110001 BCRYPT_ECDSA_ALG_HANDLE 257 0x101 0b100000001 BCRYPT_AES_CMAC_ALG_HANDLE 273 0x111 0b100010001 BCRYPT_AES_GMAC_ALG_HANDLE 289 0x121 0b100100001 BCRYPT_HMAC_MD2_ALG_HANDLE 305 0x131 0b100110001 BCRYPT_HMAC_MD4_ALG_HANDLE 321 0x141 0b101000001 BCRYPT_3DES_CBC_ALG_HANDLE 337 0x151 0b101010001 BCRYPT_3DES_ECB_ALG_HANDLE 353 0x161 0b101100001 BCRYPT_3DES_CFB_ALG_HANDLE 369 0x171 0b101110001 BCRYPT_3DES_112_CBC_ALG_HANDLE 385 0x181 0b110000001 BCRYPT_3DES_112_ECB_ALG_HANDLE 401 0x191 0b110010001 BCRYPT_3DES_112_CFB_ALG_HANDLE 417 0x1a1 0b110100001 BCRYPT_AES_CBC_ALG_HANDLE 433 0x1b1 0b110110001 BCRYPT_AES_ECB_ALG_HANDLE 449 0x1c1 0b111000001 BCRYPT_AES_CFB_ALG_HANDLE 465 0x1d1 0b111010001 BCRYPT_AES_CCM_ALG_HANDLE 481 0x1e1 0b111100001 BCRYPT_AES_GCM_ALG_HANDLE 497 0x1f1 0b111110001 BCRYPT_DES_CBC_ALG_HANDLE 513 0x201 0b1000000001 BCRYPT_DES_ECB_ALG_HANDLE 529 0x211 0b1000010001 BCRYPT_DES_CFB_ALG_HANDLE 545 0x221 0b1000100001 BCRYPT_DESX_CBC_ALG_HANDLE 561 0x231 0b1000110001 BCRYPT_DESX_ECB_ALG_HANDLE 577 0x241 0b1001000001 BCRYPT_DESX_CFB_ALG_HANDLE 593 0x251 0b1001010001 BCRYPT_RC2_CBC_ALG_HANDLE 609 0x261 0b1001100001 BCRYPT_RC2_ECB_ALG_HANDLE 625 0x271 0b1001110001 BCRYPT_RC2_CFB_ALG_HANDLE 641 0x281 0b1010000001 BCRYPT_DH_ALG_HANDLE 657 0x291 0b1010010001 BCRYPT_ECDH_ALG_HANDLE 673 0x2a1 0b1010100001 BCRYPT_ECDH_P256_ALG_HANDLE 689 0x2b1 0b1010110001 BCRYPT_ECDH_P384_ALG_HANDLE 705 0x2c1 0b1011000001 BCRYPT_ECDH_P521_ALG_HANDLE 721 0x2d1 0b1011010001 BCRYPT_DSA_ALG_HANDLE 737 0x2e1 0b1011100001 BCRYPT_ECDSA_P256_ALG_HANDLE 753 0x2f1 0b1011110001 BCRYPT_ECDSA_P384_ALG_HANDLE 769 0x301 0b1100000001 BCRYPT_ECDSA_P521_ALG_HANDLE 785 0x311 0b1100010001 BCRYPT_RSA_SIGN_ALG_HANDLE 801 0x321 0b1100100001 BCRYPT_CAPI_KDF_ALG_HANDLE 817 0x331 0b1100110001 BCRYPT_PBKDF2_ALG_HANDLE 833 0x341 0b1101000001 BCRYPT_SP800108_CTR_HMAC_ALG_HANDLE 849 0x351 0b1101010001 BCRYPT_SP80056A_CONCAT_ALG_HANDLE 865 0x361 0b1101100001 BCRYPT_TLS1_1_KDF_ALG_HANDLE 881 0x371 0b1101110001 BCRYPT_TLS1_2_KDF_ALG_HANDLE 897 0x381 0b1110000001 BCRYPT_XTS_AES_ALG_HANDLE 913 0x391 0b1110010001 BCRYPT_HKDF_ALG_HANDLE 929 0x3a1 0b1110100001 BCRYPT_CHACHA20_POLY1305_ALG_HANDLE ``` -- v5: bcrypt: Add basic support for pseudo-handles https://gitlab.winehq.org/wine/wine/-/merge_requests/812

4 4

[PATCH 0/1] MR817: msidb: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 09 Sep '22

09 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/817

2 1

[PATCH 0/1] MR816: ping: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 09 Sep '22

09 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/816

2 1

[PATCH 0/1] MR815: dwrite: Set initial justification value for default shaper.
by Nikolay Sivov (＠nsivov) 09 Sep '22

09 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/815

2 1

[PATCH 0/10] MR813: mmdevapi: Integrate winecoreaudio's additions in unixlib.h.
by Davide Beatrici (＠davidebeatrici) 09 Sep '22

09 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/813

3 21

Re: [PATCH v2 0/2] MR810: Create NtLoadKeyEx function
by Huw Davies (＠huw) 09 Sep '22

09 Sep '22

Huw Davies (@huw) commented about dlls/ntdll/unix/registry.c: > UNICODE_STRING nt_name; > OBJECT_ATTRIBUTES new_attr = *file; > > - TRACE("(%p,%p)\n", attr, file); > + TRACE( "(%p,%p,0x%x,%p,%p,0x%x,%p,%p)\n", attr, file, flags, trustkey, event, access, roothandle, iostatus ); > Some kind of `FIXME()` if any of the (as yet) unsupported params are non-zero would be good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/810#note_8102

1 0

Re: [PATCH v2 0/2] MR810: Create NtLoadKeyEx function
by Huw Davies (＠huw) 09 Sep '22

09 Sep '22

Huw Davies (@huw) commented about dlls/ntdll/unix/registry.c: > */ > NTSTATUS WINAPI NtLoadKey( const OBJECT_ATTRIBUTES *attr, OBJECT_ATTRIBUTES *file ) > +{ > + TRACE( "(%p,%p\n)", attr, file ); > + return NtLoadKeyEx( attr, file, 0, 0, 0, 0, NULL, NULL ); > +} > + > +/****************************************************************************** > + * NtLoadKey2 (NTDLL.@) > + */ > +NTSTATUS WINAPI NtLoadKey2( const OBJECT_ATTRIBUTES *attr, OBJECT_ATTRIBUTES *file, ULONG flags ) > +{ > + if (flags) FIXME( "unhandled flag %x\n", flags ); > + return NtLoadKey( attr, file ); > +} > + It probably makes more sense to forward this to `NtLoadKeyEx()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/810#note_8101

1 0

[PATCH 0/5] MR811: d2d1: Save render target type and usage.
by Zhiyi Zhang (＠zhiyi) 09 Sep '22

09 Sep '22

So that d2d_device_context_IsSupported() can know what type and usage a render target is created for. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/811

3 6

Re: [PATCH v8 0/3] MR600: wine{alsa,pulse}: Merge unixlib.h, move it into mmdevapi
by Davide Beatrici (＠davidebeatrici) 09 Sep '22

09 Sep '22

On Fri Sep 9 07:30:45 2022 +0000, Davide Beatrici wrote: > This was supposed to remain `UINT32`, I got confused by the variable's name. > `BOOL` is basically the same data type, but it should only be used for flags. > `BOOLEAN` would be better for that though, as it's single-byte. Fixed in !813. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/600#note_8092

1 0

[PATCH v4 0/1] MR812: bcrypt: Add basic support for pseudo-handles
by Christopher Denton (＠cdenton) 09 Sep '22

09 Sep '22

Support constant values for algorithm handles in `BCryptGenRandom` and make no attempt to dereference such handles (which would cause "Unhandled page fault on read access"). MSDN Documentation: https://docs.microsoft.com/en-us/windows/win32/seccng/cng-algorithm-pseudo-… --- Values of any constants are taken from this [MIT licensed](https://github.com/microsoft/windows-rs/blob/0debb1200c23f588def4… repository: https://github.com/microsoft/windows-rs I used a Python script to examine the pseudo-handles: ```python import re handles = [] p = re.compile('pub const (BCRYPT_[A-Z0-9_]+_ALG_HANDLE): BCRYPT_ALG_HANDLE = ([0-9]+)u32 as _;') with open('crates/libs/sys/src/Windows/Win32/Security/Cryptography/mod.rs') as f: t = f.read() for match in p.finditer(t): name = match.group(1) value = int(match.group(2)) handles.append((name, value)) handles.sort(key=lambda x: x[1]) for (name, value) in handles: print(f"{value:>3}\t{hex(value):>5}\t{bin(value):>12}\t{name}") ``` Output: ```text 1 0x1 0b1 BCRYPT_MD2_ALG_HANDLE 17 0x11 0b10001 BCRYPT_MD4_ALG_HANDLE 33 0x21 0b100001 BCRYPT_MD5_ALG_HANDLE 49 0x31 0b110001 BCRYPT_SHA1_ALG_HANDLE 65 0x41 0b1000001 BCRYPT_SHA256_ALG_HANDLE 81 0x51 0b1010001 BCRYPT_SHA384_ALG_HANDLE 97 0x61 0b1100001 BCRYPT_SHA512_ALG_HANDLE 113 0x71 0b1110001 BCRYPT_RC4_ALG_HANDLE 129 0x81 0b10000001 BCRYPT_RNG_ALG_HANDLE 145 0x91 0b10010001 BCRYPT_HMAC_MD5_ALG_HANDLE 161 0xa1 0b10100001 BCRYPT_HMAC_SHA1_ALG_HANDLE 177 0xb1 0b10110001 BCRYPT_HMAC_SHA256_ALG_HANDLE 193 0xc1 0b11000001 BCRYPT_HMAC_SHA384_ALG_HANDLE 209 0xd1 0b11010001 BCRYPT_HMAC_SHA512_ALG_HANDLE 225 0xe1 0b11100001 BCRYPT_RSA_ALG_HANDLE 241 0xf1 0b11110001 BCRYPT_ECDSA_ALG_HANDLE 257 0x101 0b100000001 BCRYPT_AES_CMAC_ALG_HANDLE 273 0x111 0b100010001 BCRYPT_AES_GMAC_ALG_HANDLE 289 0x121 0b100100001 BCRYPT_HMAC_MD2_ALG_HANDLE 305 0x131 0b100110001 BCRYPT_HMAC_MD4_ALG_HANDLE 321 0x141 0b101000001 BCRYPT_3DES_CBC_ALG_HANDLE 337 0x151 0b101010001 BCRYPT_3DES_ECB_ALG_HANDLE 353 0x161 0b101100001 BCRYPT_3DES_CFB_ALG_HANDLE 369 0x171 0b101110001 BCRYPT_3DES_112_CBC_ALG_HANDLE 385 0x181 0b110000001 BCRYPT_3DES_112_ECB_ALG_HANDLE 401 0x191 0b110010001 BCRYPT_3DES_112_CFB_ALG_HANDLE 417 0x1a1 0b110100001 BCRYPT_AES_CBC_ALG_HANDLE 433 0x1b1 0b110110001 BCRYPT_AES_ECB_ALG_HANDLE 449 0x1c1 0b111000001 BCRYPT_AES_CFB_ALG_HANDLE 465 0x1d1 0b111010001 BCRYPT_AES_CCM_ALG_HANDLE 481 0x1e1 0b111100001 BCRYPT_AES_GCM_ALG_HANDLE 497 0x1f1 0b111110001 BCRYPT_DES_CBC_ALG_HANDLE 513 0x201 0b1000000001 BCRYPT_DES_ECB_ALG_HANDLE 529 0x211 0b1000010001 BCRYPT_DES_CFB_ALG_HANDLE 545 0x221 0b1000100001 BCRYPT_DESX_CBC_ALG_HANDLE 561 0x231 0b1000110001 BCRYPT_DESX_ECB_ALG_HANDLE 577 0x241 0b1001000001 BCRYPT_DESX_CFB_ALG_HANDLE 593 0x251 0b1001010001 BCRYPT_RC2_CBC_ALG_HANDLE 609 0x261 0b1001100001 BCRYPT_RC2_ECB_ALG_HANDLE 625 0x271 0b1001110001 BCRYPT_RC2_CFB_ALG_HANDLE 641 0x281 0b1010000001 BCRYPT_DH_ALG_HANDLE 657 0x291 0b1010010001 BCRYPT_ECDH_ALG_HANDLE 673 0x2a1 0b1010100001 BCRYPT_ECDH_P256_ALG_HANDLE 689 0x2b1 0b1010110001 BCRYPT_ECDH_P384_ALG_HANDLE 705 0x2c1 0b1011000001 BCRYPT_ECDH_P521_ALG_HANDLE 721 0x2d1 0b1011010001 BCRYPT_DSA_ALG_HANDLE 737 0x2e1 0b1011100001 BCRYPT_ECDSA_P256_ALG_HANDLE 753 0x2f1 0b1011110001 BCRYPT_ECDSA_P384_ALG_HANDLE 769 0x301 0b1100000001 BCRYPT_ECDSA_P521_ALG_HANDLE 785 0x311 0b1100010001 BCRYPT_RSA_SIGN_ALG_HANDLE 801 0x321 0b1100100001 BCRYPT_CAPI_KDF_ALG_HANDLE 817 0x331 0b1100110001 BCRYPT_PBKDF2_ALG_HANDLE 833 0x341 0b1101000001 BCRYPT_SP800108_CTR_HMAC_ALG_HANDLE 849 0x351 0b1101010001 BCRYPT_SP80056A_CONCAT_ALG_HANDLE 865 0x361 0b1101100001 BCRYPT_TLS1_1_KDF_ALG_HANDLE 881 0x371 0b1101110001 BCRYPT_TLS1_2_KDF_ALG_HANDLE 897 0x381 0b1110000001 BCRYPT_XTS_AES_ALG_HANDLE 913 0x391 0b1110010001 BCRYPT_HKDF_ALG_HANDLE 929 0x3a1 0b1110100001 BCRYPT_CHACHA20_POLY1305_ALG_HANDLE ``` -- v4: bcrypt: Add basic support for pseudo-handles https://gitlab.winehq.org/wine/wine/-/merge_requests/812

2 1

[PATCH v3 0/1] MR812: bcrypt: Add basic support for pseudo-handles
by Christopher Denton (＠cdenton) 09 Sep '22

09 Sep '22

Support constant values for algorithm handles in `BCryptGenRandom` and make no attempt to dereference such handles (which would cause "Unhandled page fault on read access"). MSDN Documentation: https://docs.microsoft.com/en-us/windows/win32/seccng/cng-algorithm-pseudo-… --- Values of any constants are taken from this [MIT licensed](https://github.com/microsoft/windows-rs/blob/0debb1200c23f588def4… repository: https://github.com/microsoft/windows-rs I used a Python script to examine the pseudo-handles: ```python import re handles = [] p = re.compile('pub const (BCRYPT_[A-Z0-9_]+_ALG_HANDLE): BCRYPT_ALG_HANDLE = ([0-9]+)u32 as _;') with open('crates/libs/sys/src/Windows/Win32/Security/Cryptography/mod.rs') as f: t = f.read() for match in p.finditer(t): name = match.group(1) value = int(match.group(2)) handles.append((name, value)) handles.sort(key=lambda x: x[1]) for (name, value) in handles: print(f"{value:>3}\t{hex(value):>5}\t{bin(value):>12}\t{name}") ``` Output: ```text 1 0x1 0b1 BCRYPT_MD2_ALG_HANDLE 17 0x11 0b10001 BCRYPT_MD4_ALG_HANDLE 33 0x21 0b100001 BCRYPT_MD5_ALG_HANDLE 49 0x31 0b110001 BCRYPT_SHA1_ALG_HANDLE 65 0x41 0b1000001 BCRYPT_SHA256_ALG_HANDLE 81 0x51 0b1010001 BCRYPT_SHA384_ALG_HANDLE 97 0x61 0b1100001 BCRYPT_SHA512_ALG_HANDLE 113 0x71 0b1110001 BCRYPT_RC4_ALG_HANDLE 129 0x81 0b10000001 BCRYPT_RNG_ALG_HANDLE 145 0x91 0b10010001 BCRYPT_HMAC_MD5_ALG_HANDLE 161 0xa1 0b10100001 BCRYPT_HMAC_SHA1_ALG_HANDLE 177 0xb1 0b10110001 BCRYPT_HMAC_SHA256_ALG_HANDLE 193 0xc1 0b11000001 BCRYPT_HMAC_SHA384_ALG_HANDLE 209 0xd1 0b11010001 BCRYPT_HMAC_SHA512_ALG_HANDLE 225 0xe1 0b11100001 BCRYPT_RSA_ALG_HANDLE 241 0xf1 0b11110001 BCRYPT_ECDSA_ALG_HANDLE 257 0x101 0b100000001 BCRYPT_AES_CMAC_ALG_HANDLE 273 0x111 0b100010001 BCRYPT_AES_GMAC_ALG_HANDLE 289 0x121 0b100100001 BCRYPT_HMAC_MD2_ALG_HANDLE 305 0x131 0b100110001 BCRYPT_HMAC_MD4_ALG_HANDLE 321 0x141 0b101000001 BCRYPT_3DES_CBC_ALG_HANDLE 337 0x151 0b101010001 BCRYPT_3DES_ECB_ALG_HANDLE 353 0x161 0b101100001 BCRYPT_3DES_CFB_ALG_HANDLE 369 0x171 0b101110001 BCRYPT_3DES_112_CBC_ALG_HANDLE 385 0x181 0b110000001 BCRYPT_3DES_112_ECB_ALG_HANDLE 401 0x191 0b110010001 BCRYPT_3DES_112_CFB_ALG_HANDLE 417 0x1a1 0b110100001 BCRYPT_AES_CBC_ALG_HANDLE 433 0x1b1 0b110110001 BCRYPT_AES_ECB_ALG_HANDLE 449 0x1c1 0b111000001 BCRYPT_AES_CFB_ALG_HANDLE 465 0x1d1 0b111010001 BCRYPT_AES_CCM_ALG_HANDLE 481 0x1e1 0b111100001 BCRYPT_AES_GCM_ALG_HANDLE 497 0x1f1 0b111110001 BCRYPT_DES_CBC_ALG_HANDLE 513 0x201 0b1000000001 BCRYPT_DES_ECB_ALG_HANDLE 529 0x211 0b1000010001 BCRYPT_DES_CFB_ALG_HANDLE 545 0x221 0b1000100001 BCRYPT_DESX_CBC_ALG_HANDLE 561 0x231 0b1000110001 BCRYPT_DESX_ECB_ALG_HANDLE 577 0x241 0b1001000001 BCRYPT_DESX_CFB_ALG_HANDLE 593 0x251 0b1001010001 BCRYPT_RC2_CBC_ALG_HANDLE 609 0x261 0b1001100001 BCRYPT_RC2_ECB_ALG_HANDLE 625 0x271 0b1001110001 BCRYPT_RC2_CFB_ALG_HANDLE 641 0x281 0b1010000001 BCRYPT_DH_ALG_HANDLE 657 0x291 0b1010010001 BCRYPT_ECDH_ALG_HANDLE 673 0x2a1 0b1010100001 BCRYPT_ECDH_P256_ALG_HANDLE 689 0x2b1 0b1010110001 BCRYPT_ECDH_P384_ALG_HANDLE 705 0x2c1 0b1011000001 BCRYPT_ECDH_P521_ALG_HANDLE 721 0x2d1 0b1011010001 BCRYPT_DSA_ALG_HANDLE 737 0x2e1 0b1011100001 BCRYPT_ECDSA_P256_ALG_HANDLE 753 0x2f1 0b1011110001 BCRYPT_ECDSA_P384_ALG_HANDLE 769 0x301 0b1100000001 BCRYPT_ECDSA_P521_ALG_HANDLE 785 0x311 0b1100010001 BCRYPT_RSA_SIGN_ALG_HANDLE 801 0x321 0b1100100001 BCRYPT_CAPI_KDF_ALG_HANDLE 817 0x331 0b1100110001 BCRYPT_PBKDF2_ALG_HANDLE 833 0x341 0b1101000001 BCRYPT_SP800108_CTR_HMAC_ALG_HANDLE 849 0x351 0b1101010001 BCRYPT_SP80056A_CONCAT_ALG_HANDLE 865 0x361 0b1101100001 BCRYPT_TLS1_1_KDF_ALG_HANDLE 881 0x371 0b1101110001 BCRYPT_TLS1_2_KDF_ALG_HANDLE 897 0x381 0b1110000001 BCRYPT_XTS_AES_ALG_HANDLE 913 0x391 0b1110010001 BCRYPT_HKDF_ALG_HANDLE 929 0x3a1 0b1110100001 BCRYPT_CHACHA20_POLY1305_ALG_HANDLE ``` -- v3: bcrypt: Add basic support for pseudo-handles https://gitlab.winehq.org/wine/wine/-/merge_requests/812

3 4

Re: [PATCH v2 0/1] MR812: bcrypt: Add basic support for pseudo-handles
by Nikolay Sivov (＠nsivov) 09 Sep '22

09 Sep '22

There is a whole bunch of those in SDK, no need for windows-rs in this case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/812#note_8080

1 0

[PATCH v6 0/2] MR787: notepad: Add status bar and goto line dialog
by Jacob Czekalla (＠Maaka00524) 09 Sep '22

09 Sep '22

Added a status bar to track line and column number Added a goto line dialog -- v6: Track and display line number and column. https://gitlab.winehq.org/wine/wine/-/merge_requests/787

3 10

Re: [PATCH v8 0/3] MR600: wine{alsa,pulse}: Merge unixlib.h, move it into mmdevapi
by Davide Beatrici (＠davidebeatrici) 09 Sep '22

09 Sep '22

Davide Beatrici (@davidebeatrici) commented about dlls/mmdevapi/unixlib.h: > struct release_capture_buffer_params > { > stream_handle stream; > - UINT32 done; > + BOOL done; This was supposed to remain `UINT32`, I got confused by the variable's name. `BOOL` is basically the same data type, but it should only be used for flags. `BOOLEAN` would be better for that though, as it's single-byte. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/600#note_8068

1 0

[PATCH v5 0/2] MR787: notepad: Add status bar and goto line dialog
by Jacob Czekalla (＠Maaka00524) 09 Sep '22

09 Sep '22

Added a status bar to track line and column number Added a goto line dialog -- v5: notepad: Track and display line number and column. notepad: Show status bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/787

3 3

[PATCH v8 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 09 Sep '22

09 Sep '22

this gets the YSDrv service to start successfully (with the MmAllocateContiguousMemorySpecifyCache semi-stub) this service is used by the nox android emulator -- v8: add KeInsertQueueDpc stub https://gitlab.winehq.org/wine/wine/-/merge_requests/778

2 2

Re: [PATCH v2 0/2] MR810: Create NtLoadKeyEx function
by Etaash Mathamsetty (＠etaash.mathamsetty) 08 Sep '22

08 Sep '22

On Thu Sep 8 22:30:41 2022 +0000, Santino Mazza wrote: > Are the pipelines working correctly? I think it leaves some files > modified and it fails when rebasing to the next commit. yeah I have had the same issue numerous times, it's really annoying, for the time being I would just squash the commits (that are built on top of upstream, not the upstream ones themselves), it usually fixes the problem -- https://gitlab.winehq.org/wine/wine/-/merge_requests/810#note_8044

1 0

Re: [PATCH v2 0/2] MR810: Create NtLoadKeyEx function
by Santino Mazza (＠tati1454) 08 Sep '22

08 Sep '22

Are the pipelines working correctly? I think it leaves some files modified and it fails when rebasing to the next commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/810#note_8041

1 0

[PATCH 0/2] MR810: Create NtLoadKeyEx function
by Santino Mazza (＠tati1454) 08 Sep '22

08 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/810

2 2

Re: [PATCH v2 0/1] MR807: urlmon/tests: Fix race condition in abort test. - approved
by Alexandre Julliard (＠julliard) 08 Sep '22

08 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/807

1 0

Re: [PATCH v2 0/1] MR802: wow64: Don't re-enter cpu_simulate() from exception filter. - approved
by Alexandre Julliard (＠julliard) 08 Sep '22

08 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/802

1 0

Re: [PATCH v13 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey. - approved
by Alexandre Julliard (＠julliard) 08 Sep '22

08 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/766

1 0

Re: [PATCH v2 0/1] MR806: dwrite/tests: Add some tests for glyph justification values. - approved
by Alexandre Julliard (＠julliard) 08 Sep '22

08 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/806

1 0

Re: [PATCH v2 0/1] MR805: dssenh: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '22

08 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/805

1 0

Re: [PATCH v3 0/7] MR799: wineoss: Switch to mmdevapi's unixlib.h. - approved
by Alexandre Julliard (＠julliard) 08 Sep '22

08 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/799

1 0

[PATCH 0/5] MR803: winegstreamer: Refactor wm async reader clock.
by Rémi Bernon (＠rbernon) 08 Sep '22

08 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/803

3 9

[PATCH v3 0/1] MR752: Draft: winecrt0: run C++ object destructors in DLL_PROCESS_DETACH.
by Kevin Puetz (＠puetzk) 08 Sep '22

08 Sep '22

Run C++ global/static destructors during DLL_PROCESS_DETACH while other other dllimport functions they may want to call are still viable. While windows imposes many restrictions on what may be done in such destructors (given that the run inside the loader lock), there are lots of legal and useful kernel32 functions like DestroyCriticalSection, DeleteAtom, TlsFree, etc that are both useful and legal. Currently this does not work for builtin modules because all the Win32 structures are discarded well before NtUnmapViewOfSection finally does the dlllose. Even for a winelib .dll.so module, it would be preferable for destructors to execute during process_detach (before wine tears down the MODREF and detaches dependant dlls), rather than be left until after the last NtUnmapViewOfSection (when we finally reach dlclose) Therefore, winegcc now always uses the DllMainCRTStartup entry point unless you specify your own --entry=func. Previously it did this only for PE modules using msvcrt. Making this default consistent matches cl.exe, which also always defaults to _DllMainCRTStartup unless overridden by /entry:foo https://docs.microsoft.com/en-us/cpp/build/reference/entry-entry-point-symb… The ELF version of winecrt0.a now provides a DllMainCRTStartup which, per the Itanium ABI that is in practice what is used by gcc and clang, performs this this destruction by calling __cxa_finalize(&__dso_handle).. This libc function is required to be idempotent, so it's OK that dlclose still calls it again later (there will just be no further work to do). Multiple calls to __cxa_finalize shall not result in calling termination function entries multiple times; the implementation may either remove entries or mark them finished. https://itanium-cxx-abi.github.io/cxx-abi/abi.html#dso-dtor-runtime-api This has two main effects; it moves ELF destructors earlier (before imports are unmapped), and it moves them inside the Nt loader lock. Being earlier was the intended goal, and moving them inside the lock seems fine. Any Win32 API calls in destructors are just being subjected to the same lock hierarchy rules as usual on windows (MSVC also runs destructors from DllMainCrtStartup) https://docs.microsoft.com/en-us/cpp/build/run-time-library-behavior?view=m… And any purely-ELF destructors that happen to also run earlier should never call functions exported from wine (and thus don't care about ntdll's locks). -- v3: winecrt0: run C++ object destructors during module unload. https://gitlab.winehq.org/wine/wine/-/merge_requests/752

3 4

[PATCH 0/1] MR808: d2d1/tests: Mark some more failing tests as todo.
by Alexandre Julliard (＠julliard) 08 Sep '22

08 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/808

3 3

[PATCH 0/1] MR807: urlmon/tests: Fix race condition in abort test.
by Alexandre Julliard (＠julliard) 08 Sep '22

08 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/807

3 2

[PATCH v12 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 08 Sep '22

08 Sep '22

-- v12: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 2

[PATCH v11 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 08 Sep '22

08 Sep '22

-- v11: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 2

[PATCH 0/1] MR806: dwrite/tests: Add some tests for glyph justification values.
by Nikolay Sivov (＠nsivov) 08 Sep '22

08 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/806

2 1

[PATCH v10 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 08 Sep '22

08 Sep '22

-- v10: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 2

[PATCH v9 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 08 Sep '22

08 Sep '22

-- v9: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 5

[PATCH 0/1] MR805: dssenh: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 08 Sep '22

08 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/805

2 1

Re: [PATCH v2 0/2] MR804: mf: Assume maintainership of MF transforms. - approved
by Nikolay Sivov (＠nsivov) 08 Sep '22

08 Sep '22

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/804

1 0

[PATCH 0/2] MR804: mf: Assume maintainership of MF transforms.
by Rémi Bernon (＠rbernon) 08 Sep '22

08 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/804

3 3

[PATCH v2 0/7] MR799: wineoss: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) 08 Sep '22

08 Sep '22

Follow-up to !600. -- v2: wineoss: Switch to mmdevapi's unixlib.h. wineoss: Adapt "get_position_params" struct to mmdevapi's. wineoss: Adapt "get_frequency_params" struct to mmdevapi's. wineoss: Adapt "create_stream_params" struct to mmdevapi's. wineoss: Adapt "test_connect_params" struct to mmdevapi's. wineoss: Drop "oss_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate wineoss's additions in unixlib.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/799

3 8

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Nikolay Sivov (＠nsivov) 08 Sep '22

08 Sep '22

Nikolay Sivov (@nsivov) commented about programs/notepad/main.c: > + wchar_t statusTxt[25]; > + int lineIndex; > + DWORD selStart; > + DWORD selEnd; > + > + SendMessageW(Globals.hEdit,EM_GETSEL , (WPARAM)&selStart,(LPARAM)&selEnd); > + if(selStart == selEnd) > + Globals.trackedSel = selStart; > + if(selStart < Globals.trackedSel) > + currentCol = selStart; > + else > + currentCol = selEnd; > + currentLine = SendMessageW(Globals.hEdit,EM_LINEFROMCHAR,currentCol,0); > + lineIndex = SendMessageW(Globals.hEdit,EM_LINEINDEX, currentLine,0); > + > + swprintf(statusTxt,25,L"Ln %ld, Col %ld",currentLine+1,(currentCol+1) - lineIndex); Status bar message text should also be localized. You can find examples of how it's done in other modules - it would be using LoadStringW(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7984

1 0

[PATCH 0/3] MR698: d2d1: Implement transform graph.
by Ziqing Hui (＠zhui) 08 Sep '22

08 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/698

3 9

[PATCH 0/7] MR799: wineoss: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) 07 Sep '22

07 Sep '22

Follow-up to !600. --- The version check logic is removed because redundant. `SNDCTL_SYSINFO` was introduced in OSS 4.0: [oss4white.pdf](/uploads/e85c3196b611560db849cfac9e158bd2/oss4white.pdf) The `ioctl()` call fails with OSS 3.x. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/799

3 9

[PATCH 0/1] MR802: wow64: Don't re-enter cpu_simulate() from exception filter.
by Brendan Shanks (＠bshanks) 07 Sep '22

07 Sep '22

This avoids an eventual stack overflow in exception-heavy applications. Important note: when using the experimental Wow64 support on Linux, this change causes a crash during exception handling when unix_funcs->unwind_builtin_dll is called. The call in dll/ntdll/signal_x86_64.c virtual_unwind() to unix_funcs->unwind_builtin_dll() should be commented out and replaced with 'status = STATUS_UNSUCCESSFUL;'. This is along the same lines as needing to comment out the unix_funcs->init_builtin_dll() call for Wow64. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/802

2 1

Re: [PATCH v2 0/7] MR767: rpcrt4, msvcrt: Add SEH annotations to some functions. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/767

1 0

Re: [PATCH v3 0/1] MR774: msvcp140: Add _ExceptionHolder::ReportUnhandledError stub. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/774

1 0

Re: [PATCH v2 0/1] MR779: msvcrt: Fix the spelling of a comment. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/779

1 0

Re: [PATCH v3 0/2] MR796: include/test.h: Don't use strcasecmp. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/796

1 0

Re: [PATCH v2 0/1] MR800: crypt32/tests: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/800

1 0

Re: [PATCH v2 0/2] MR797: ddraw/tests: Avoid picking a large mode on Win10 in test_coop_level_mode_set_enum_cb. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/797

1 0

Re: [PATCH v3 0/1] MR784: wined3d: Tell vkd3d_shader about dual source blending. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/784

1 0

Re: [PATCH v3 0/8] MR695: winegstreamer: Initial fixes and refactor of the WM async reader. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/695

1 0

[PATCH v2 0/3] MR801: uiautomationcore: Implement basic HWND based HUIANODE behavior.
by Connor McAdams (＠cmcadams) 07 Sep '22

07 Sep '22

Hopefully this patch series is easier to review than the last one. -- v2: uiautomationcore: Implement UiaNodeFromHandle. uiautomationcore: Add get_prop_val method to IWineUiaNode. uiautomationcore: Implement UiaReturnRawElementProvider. https://gitlab.winehq.org/wine/wine/-/merge_requests/801

2 4

[PATCH 0/7] MR767: rpcrt4, msvcrt: Add SEH annotations to some functions.
by Zebediah Figura (＠zfigura) 07 Sep '22

07 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/767

3 8

[PATCH v2 0/1] MR774: msvcp140: Add _ExceptionHolder::ReportUnhandledError stub.
by Gijs Vermeulen (＠gverm) 07 Sep '22

07 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53614 Signed-off-by: Gijs Vermeulen <gverm(a)inuits.eu> -- v2: msvcp140: Add _ExceptionHolder::ReportUnhandledError stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/774

3 2

[PATCH 0/1] MR779: msvcrt: Fix the spelling of a comment.
by Francois Gouget (＠fgouget) 07 Sep '22

07 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/779

4 3

[PATCH 0/3] MR801: uiautomationcore: Implement basic HWND based HUIANODE behavior.
by Connor McAdams (＠cmcadams) 07 Sep '22

07 Sep '22

Hopefully this patch series is easier to review than the last one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/801

2 3

[PATCH v3 0/3] MR793: uiautomationcore: Implement HWND based HUIANODEs.
by Connor McAdams (＠cmcadams) 07 Sep '22

07 Sep '22

-- v3: uiautomationcore: Implement UiaDisconnectProvider. uiautomationcore: Implement UiaNodeFromHandle. uiautomationcore: Implement UiaReturnRawElementProvider. https://gitlab.winehq.org/wine/wine/-/merge_requests/793

3 7

[PATCH v8 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 07 Sep '22

07 Sep '22

-- v8: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

2 1

[PATCH v7 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 07 Sep '22

07 Sep '22

-- v7: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 2

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/notepad.rc: > MENUITEM "&Search next\tF3", CMD_SEARCH_NEXT > MENUITEM "&Replace...\tCtrl+H", CMD_REPLACE > } > +POPUP "&View" > +{ > + MENUITEM "&Status Bar", CMD_SBAR > + } Another trailing space after `"&View"` and a space before the `}`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7878

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/main.c: > + > +VOID UpdateStatusBar(VOID) > +{ > + int currentLine; > + int currentCol = -1; > + wchar_t statusTxt[25]; > + int lineIndex; > + DWORD selStart; > + DWORD selEnd; > + > + SendMessageW(Globals.hEdit,EM_GETSEL , (WPARAM)&selStart,(LPARAM)&selEnd); > + if(selStart == selEnd) > + Globals.trackedSel = selStart; > + if(selStart < Globals.trackedSel) > + currentCol = selStart; > + else And this has a trailing space after the `else`. There are other instances below as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7877

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/main.c: > + CheckMenuItem(GetMenu(Globals.hMainWnd),CMD_SBAR, > + MF_BYCOMMAND | (Globals.bStatusBar ? MF_CHECKED : MF_UNCHECKED)); > + GetClientRect(Globals.hMainWnd, &rc); > + ShowWindow(Globals.hStatusBar,Globals.bStatusBar); > + SendMessageW(Globals.hMainWnd,WM_SIZE,0,MAKELPARAM(rc.right,rc.bottom)); > +} > + > +VOID UpdateStatusBar(VOID) > +{ > + int currentLine; > + int currentCol = -1; > + wchar_t statusTxt[25]; > + int lineIndex; > + DWORD selStart; > + DWORD selEnd; > + This line contains 4 spaces. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7876

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/main.c: > } > } > > +LRESULT CALLBACK EDIT_CallBackProc(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam) > +{ > + switch (msg) > + { > + case WM_KEYDOWN: > + UpdateStatusBar(); > + break; > + case WM_KEYUP: > + UpdateStatusBar(); > + break; > + case WM_MBUTTONDOWN: > + UpdateStatusBar(); > + break; This could all be simplifed: ```c case WM_KEYDOWN: case WM_KEYUP: case WM_MBUTTONDOWN: ... UpdateStatusBar(); break; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7875

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/main.c: > return dpi; > } > > +VOID ToggleStatusBar(VOID) > +{ > + RECT rc; > + > + Globals.bStatusBar = !Globals.bStatusBar; > + CheckMenuItem(GetMenu(Globals.hMainWnd),CMD_SBAR, > + MF_BYCOMMAND | (Globals.bStatusBar ? MF_CHECKED : MF_UNCHECKED)); > + GetClientRect(Globals.hMainWnd, &rc); > + ShowWindow(Globals.hStatusBar,Globals.bStatusBar); > + SendMessageW(Globals.hMainWnd,WM_SIZE,0,MAKELPARAM(rc.right,rc.bottom)); Again, call your newly added helper function instead of sending `WM_SIZE`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7874

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/main.c: > return dpi; > } > > +VOID ToggleStatusBar(VOID) `static` (as the function isn't used outside the file). Also, and I know it not the case in this file, but let's use `void` rather than `VOID`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7873

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/dialog.c: > Globals.bWrapLongLines = !Globals.bWrapLongLines; > CheckMenuItem(GetMenu(Globals.hMainWnd), CMD_WRAP, > MF_BYCOMMAND | (Globals.bWrapLongLines ? MF_CHECKED : MF_UNCHECKED)); > + SendMessageW(Globals.hMainWnd,WM_SIZE,0,MAKELPARAM(rc.right,rc.bottom)); This looks hacky. You probably want to move the code that you're adding to the main window's WM_SIZE handler to a helper function and call that directly from here. Also, and this applies throughout, please leave a space after each comma. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7872

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Generally I think this MR should be split into two separate ones. That'll give us a chance to get the status bar work in before we worry about the goto dialog box. So, just concentrating on the status bar commit, I'd start off by splitting that into two commits. First add the code that creates and displays the status bar (it doesn't need to display any text at this point). Then add a second commit that updates the status bar with line / col info. As @besentv mentioned, the commit messages are still not quite there - we terminate the subject with a period. I'll comment on some of the code below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7869

1 0

[PATCH v2 0/2] MR796: include/test.h: Don't use strcasecmp.
by Stefan Dösinger (＠stefan) 07 Sep '22

07 Sep '22

Fixes building tests in Visual Studio with msvc's own crt headers. --- This follows patches in other places that replaced it first with _strnicmp(a, b, -1), and later with _stricmp(a, b), because _strnicmp with size=-1 raises a runtime error. -- v2: test.h: Don't use \e. include/test.h: Don't use strcasecmp. https://gitlab.winehq.org/wine/wine/-/merge_requests/796

2 2

[PATCH v6 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 07 Sep '22

07 Sep '22

-- v6: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 3

Re: [PATCH v3 0/1] MR794: evr/filter: Initial implementation of sample rendering.
by Nikolay Sivov (＠nsivov) 07 Sep '22

07 Sep '22

On Tue Sep 6 20:28:13 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 9/6/22 09:12, Nikolay Sivov wrote: > > +static HRESULT evr_get_service(void *unk, REFGUID service, REFIID > riid, void **obj) > > +{ > > + IMFGetService *gs; > > + HRESULT hr; > > + > > + if (SUCCEEDED(hr = IUnknown_QueryInterface((IUnknown *)unk, > &IID_IMFGetService, (void **)&gs))) > > + { > > + hr = IMFGetService_GetService(gs, service, riid, obj); > > + IMFGetService_Release(gs); > > + } > > + > > + return hr; > > +} > > + > Isn't this MFGetService()? > (It also isn't really evr-specific, so I'd be inclined to omit the evr_ > prefix, but that's a rather minor quibble.) > ``` Yes, it is, but I don't want to link to mf.dll just for that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/794#note_7860

1 0

[PATCH 0/1] MR800: crypt32/tests: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 07 Sep '22

07 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/800

2 1

[PATCH v3 0/7] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon (＠rbernon) 07 Sep '22

07 Sep '22

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- v3: win32u: Return DISP_CHANGE_SUCCESSFUL from nulldrv_ChangeDisplaySettingsEx. win32u: Read current display settings from the registry if GetCurrentDisplaySettings fails. win32u: Write current display settings to the registry in apply_display_settings. win32u: Force update display cache after NtUserChangeDisplaySettingsEx. win32u: Introduce a new VirtualScreenRectChanged display driver callback. win32u: Broadcast WM_DISPLAYCHANGE message on display settings change. win32u: Move enumeration of available modes out of graphics drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/551

4 24

[PATCH 0/2] MR798: msvcrt: Fix strncmp return value.
by Shaun Ren (＠shaunren) 06 Sep '22

06 Sep '22

Some programs, such as Final Fantasy IV (3D remake), expect strncmp to return exactly +/-1 when the strings are not equal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/798

3 3

Re: [PATCH v3 0/6] MR788: winevulkan: Move dispatchable handles allocation to PE code. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/788

1 0

Re: [PATCH v2 0/4] MR792: include: Add some more MFT / DMO class ids and WMV media type ids. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/792

1 0

Re: [PATCH v3 0/1] MR794: evr/filter: Initial implementation of sample rendering. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/794

1 0

Re: [PATCH v2 0/2] MR790: scrrun: Store full path in folder object. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/790

1 0

Re: [PATCH v3 0/3] MR783: dwrite: Handle higher planes when setting DWRITE_SCRIPT_SHAPES_NO_VISUAL. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/783

1 0

Re: [PATCH v6 0/1] MR772: tests: Allow marking unreliable tests as flaky. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/772

1 0

[PATCH 0/2] MR797: ddraw/tests: Avoid picking a large mode on Win10 in test_coop_level_mode_set_enum_cb.
by Stefan Dösinger (＠stefan) 06 Sep '22

06 Sep '22

--- Example test failure: http://test.winehq.org/data/c1db36686c7adb1f117e2aeecbd024949fc1e6ae/win21H… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/797

4 5

[PATCH v2 0/1] MR794: evr/filter: Initial implementation of sample rendering.
by Nikolay Sivov (＠nsivov) 06 Sep '22

06 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: evr/filter: Initial implementation of sample rendering. https://gitlab.winehq.org/wine/wine/-/merge_requests/794

3 2

[PATCH 0/1] MR782: evr/filter: Notify mixer and presenter on state changes.
by Nikolay Sivov (＠nsivov) 06 Sep '22

06 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/782

3 2

[PATCH v2 0/1] MR784: wined3d: Tell vkd3d_shader about dual source blending.
by Stefan Dösinger (＠stefan) 06 Sep '22

06 Sep '22

Dual source blending implies an additional shader output, which needs to be declared. This improves WoT on high graphics settings on MoltenVK. -- v2: wined3d: Tell vkd3d_shader about dual source blending. https://gitlab.winehq.org/wine/wine/-/merge_requests/784

3 3

[PATCH v2 0/8] MR695: winegstreamer: Initial fixes and refactor of the WM async reader.
by Rémi Bernon (＠rbernon) 06 Sep '22

06 Sep '22

This includes some fixes for obvious mistakes as well as initial cleanup of the WM async reader, in preparation for implementing proper threading support. I'm planning on doing some more refactoring first, ultimately implementing the async reader on top of the sync reader, and removing the need for a private interface. I've checked that it can indeed work on Windows too, and it'll make the code simpler overall. -- v2: winegstreamer: Query IWMReaderCallbackAdvanced interface in Open. winegstreamer: Avoid waiting for callback thread on allocation failure. winegstreamer: Release callback and context in async_reader_close. winegstreamer: Move open_stream / close_stream helpers around. winegstreamer: Leave async reader callback_cs on calloc error. winegstreamer: Leave WM reader CS on invalid output format. winegstreamer: Avoid leaking async ops on release or multiple close. winegstreamer: Rename async reader stream_thread to callback_thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/695

3 10

[PATCH v2 0/6] MR788: winevulkan: Move dispatchable handles allocation to PE code.
by Jacek Caban (＠jacek) 06 Sep '22

06 Sep '22

Instead of leaking "kernel" pointers. -- v2: winevulkan: Separate PE and Unix VkCommandBuffer structs. winevulkan: Wrap VkCommandPool on PE side. winevulkan: Separate PE and Unix VkPhysicalDevice strucrts. winevulkan: Separate PE and Unix VkInstance structs. winevulkan: Separate PE and Unix VkQueue structs. winevulkan: Separate PE and Unix VkDevice structs. https://gitlab.winehq.org/wine/wine/-/merge_requests/788

2 7

Re: [PATCH v22 0/4] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens (＠tobi.goergens) 06 Sep '22

06 Sep '22

On Wed Aug 10 18:46:02 2022 +0000, Tobias G��rgens wrote: > All commits build now and tests run through fine. > What do I need to do next? > Is there still anything I should change? Hey there, I'd really like to get this through, I just need to know what's missing/what I should do next :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/564#note_7627

2 1

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Bernhard Kölbl (＠besentv) 06 Sep '22

06 Sep '22

On Tue Sep 6 15:11:41 2022 +0000, Jacob Czekalla wrote: > They should be good now. Thanks. Not quite, please refer to: https://wiki.winehq.org/Submitting_Patches#The_commit_message -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7814

1 0

[PATCH v4 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 06 Sep '22

06 Sep '22

-- v4: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 5

[PATCH 0/6] MR788: winevulkan: Move dispatchable handles allocation to PE code.
by Jacek Caban (＠jacek) 06 Sep '22

06 Sep '22

Instead of leaking "kernel" pointers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/788

3 7

[PATCH 0/2] MR796: include/test.h: Don't use strcasecmp.
by Stefan Dösinger (＠stefan) 06 Sep '22

06 Sep '22

Fixes building tests in Visual Studio with msvc's own crt headers. --- This follows patches in other places that replaced it first with _strnicmp(a, b, -1), and later with _stricmp(a, b), because _strnicmp with size=-1 raises a runtime error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/796

3 3

[PATCH v2 0/6] MR795: mshtml: Implement Storage Events.
by Gabriel Ivăncescu (＠insn) 06 Sep '22

06 Sep '22

This implements sending StorageEvents to the same window/doc from where the storage change happened, which seems to be a thing on native IE. For some reason I was unable to have them actually sent to other windows, so that's not implemented since I've no idea how that even gets triggered to test it, and if it does it will probably be in a follow up MR, even though that's *supposed* to be the use of these events�� localStorage sends for `onstoragecommit` on the doc that did the change, while sessionStorage sends for `onstorage` on the window and doc that did the change, depending on compat mode. Although the event sent to the document's `onstorage` seems to be a legacy/old-style event (as tests show). Tests are on the last patch since events have to be sent properly (else it hangs). -- v2: mshtml/tests: Add tests for StorageEvents. mshtml: Send StorageEvents when removing an existing item. mshtml: Send StorageEvents when setting an item. mshtml: Implement StorageEvent and send it when clearing the storage. mshtml: Move the MessageEvent construction to a helper. include: Add IDOMStorageEvent and DispDOMStorageEvent interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/795

3 8

[PATCH 0/6] MR795: mshtml: Implement Storage Events.
by Gabriel Ivăncescu (＠insn) 06 Sep '22

06 Sep '22

This implements sending StorageEvents to the same window/doc from where the storage change happened, which seems to be a thing on native IE. For some reason I was unable to have them actually sent to other windows, so that's not implemented since I've no idea how that even gets triggered to test it, and if it does it will probably be in a follow up MR, even though that's *supposed* to be the use of these events�� localStorage sends for `onstoragecommit` on the doc that did the change, while sessionStorage sends for `onstorage` on the window and doc that did the change, depending on compat mode. Although the event sent to the document's `onstorage` seems to be a legacy/old-style event (as tests show). Tests are on the last patch since events have to be sent properly (else it hangs). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/795

3 7

[PATCH v3 0/2] MR787: notepad: Add status bar and goto line dialog
by Jacob Czekalla (＠Maaka00524) 06 Sep '22

06 Sep '22

Added a status bar to track line and column number Added a goto line dialog -- v3: notepad: Added goto dialog function notepad: Added status bar to track line number and column https://gitlab.winehq.org/wine/wine/-/merge_requests/787

2 3

[PATCH v2 0/3] MR793: uiautomationcore: Implement HWND based HUIANODEs.
by Connor McAdams (＠cmcadams) 06 Sep '22

06 Sep '22

-- v2: uiautomationcore: Implement UiaDisconnectProvider. uiautomationcore: Implement UiaNodeFromHandle. https://gitlab.winehq.org/wine/wine/-/merge_requests/793

2 4

[PATCH 0/3] MR793: uiautomationcore: Implement HWND based HUIANODEs.
by Connor McAdams (＠cmcadams) 06 Sep '22

06 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/793

2 3

Re: [PATCH v2 0/2] MR787: notepad: Add status bar and goto line dialog
by Bernhard Kölbl (＠besentv) 06 Sep '22

06 Sep '22

The commit messages aren't conforming to what we usually have, so those need a change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7783

1 0

[PATCH 0/11] MR791: mf: Test AAC encoder / decoder presence, begin factoring some transform tests.
by Rémi Bernon (＠rbernon) 06 Sep '22

06 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/791

3 17

[PATCH 0/4] MR792: include: Add some more MFT / DMO class ids and WMV media type ids.
by Rémi Bernon (＠rbernon) 06 Sep '22

06 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/792

2 4

2025

2024

2023

2022

wine-gitlab