- wine-gitlab - winehq.org

[PATCH 0/2] MR790: scrrun: Store full path in folder object.
by Robert Wilhelm (＠sloper42) 06 Sep '22

06 Sep '22

We should store full path in folder object similar like we already do for file object. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/790

3 3

[PATCH v5 0/5] MR729: windows.media.speech: Initial recognition session work.
by Bernhard Kölbl (＠besentv) 06 Sep '22

06 Sep '22

-- v5: windows.media.speech: Implement a worker thread for the recognition session. https://gitlab.winehq.org/wine/wine/-/merge_requests/729

3 14

[PATCH v2 0/3] MR783: dwrite: Handle higher planes when setting DWRITE_SCRIPT_SHAPES_NO_VISUAL.
by Nikolay Sivov (＠nsivov) 06 Sep '22

06 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: dwrite: Handle higher planes characters in line breaking logic. dwrite/bidi: Prepare for characters above BMP. dwrite: Handle higher planes when setting DWRITE_SCRIPT_SHAPES_NO_VISUAL. https://gitlab.winehq.org/wine/wine/-/merge_requests/783

2 3

[PATCH v4 0/1] MR777: ntoskrnl: MmAllocateContiguousMemorySpecifyCache semi-stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 06 Sep '22

06 Sep '22

This should help to get the nox android emulator to run fixes bug https://bugs.winehq.org/show_bug.cgi?id=46760 -- v4: MmAllocateContiguousMemorySpecifyCache semi-stub https://gitlab.winehq.org/wine/wine/-/merge_requests/777

3 4

[PATCH v5 0/1] MR772: tests: Allow marking unreliable tests as flaky.
by Francois Gouget (＠fgouget) 05 Sep '22

05 Sep '22

-- v5: tests: Allow marking unreliable tests as flaky. https://gitlab.winehq.org/wine/wine/-/merge_requests/772

2 1

Re: [PATCH v5 0/1] MR775: comctl32: Support passing bitmap and icon resource ID as a string when creating static control. - approved
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/775

1 0

Re: [PATCH v2 0/1] MR780: mshtml: Add trailing linefeeds to a couple of FIXME() messages. - approved
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/780

1 0

Re: [PATCH v5 0/2] MR726: msvfw32: Use window name to determine if window is created using MCIWndCreate. - approved
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/726

1 0

Re: [PATCH v3 0/4] MR786: Add data for high planes in Unicode tables - approved
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/786

1 0

Re: [PATCH v4 0/1] MR785: po: Update German translation. - approved
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/785

1 0

Re: [PATCH v2 0/1] MR782: evr/filter: Notify mixer and presenter on state changes. - approved
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/782

1 0

Re: [PATCH v2 0/1] MR781: winex11.drv: Use #ifdef to check config.h macros. - approved
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/781

1 0

Re: [PATCH v2 0/1] MR759: include/wine/test.h: Enable ANSI support in console for WINETEST_COLOR. - approved
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/759

1 0

Re: [PATCH v5 0/8] MR711: mf: Add some media session event tests for SetTopology and media type initialization. - approved
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/711

1 0

Re: [PATCH v2 0/1] MR763: windowscodecs/tests: Clean up after running test expected to fail. - approved
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/763

1 0

[PATCH v4 0/1] MR775: comctl32: Support passing bitmap and icon resource ID as a string when creating static control.
by Lorenzo Ferrillo (＠llde) 05 Sep '22

05 Sep '22

Follow Up of Merge request !693 by Jacek Caban. That pull request changed properly the static control of user32, but didn't address the comctl32 static control. Fix an issue of TES4:Oblivion Construction Set, reported by me in the Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=53581#c5 after the merge request fixed the reported CS crash. Signed-off-by: Lorenzo Ferrillo [lorenzofersteam@live.it](mailto:lorenzofersteam@live.it) -- v4: comctl32: Support passing bitmap and icon resource ID as a string when creating static control. https://gitlab.winehq.org/wine/wine/-/merge_requests/775

3 3

[PATCH v3 0/2] MR777: ntoskrnl: MmAllocateContiguousMemorySpecifyCache semi-stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 05 Sep '22

05 Sep '22

This should help to get the nox android emulator to run fixes bug https://bugs.winehq.org/show_bug.cgi?id=46760 -- v3: Apply 1 suggestion(s) to 1 file(s) https://gitlab.winehq.org/wine/wine/-/merge_requests/777

4 4

[PATCH 0/1] MR780: mshtml: Add trailing linefeeds to a couple of FIXME() messages.
by Francois Gouget (＠fgouget) 05 Sep '22

05 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/780

3 2

[PATCH v2 0/4] MR786: Add data for high planes in Unicode tables
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

-- v2: unicode: Add data for high Unicode planes to the Arabic shaping table. https://gitlab.winehq.org/wine/wine/-/merge_requests/786

2 5

[PATCH v3 0/1] MR775: comctl32: Support passing bitmap and icon resource ID as a string when creating static control.
by Lorenzo Ferrillo (＠llde) 05 Sep '22

05 Sep '22

Follow Up of Merge request !693 by Jacek Caban. That pull request changed properly the static control of user32, but didn't address the comctl32 static control. Fix an issue of TES4:Oblivion Construction Set, reported by me in the Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=53581#c5 after the merge request fixed the reported CS crash. Signed-off-by: Lorenzo Ferrillo [lorenzofersteam@live.it](mailto:lorenzofersteam@live.it) -- v3: comctl32: Support passing bitmap and icon resource ID as a string when creating static control. https://gitlab.winehq.org/wine/wine/-/merge_requests/775

3 9

[PATCH v2 0/1] MR777: ntoskrnl: MmAllocateContiguousMemorySpecifyCache semi-stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 05 Sep '22

05 Sep '22

This should help to get the nox android emulator to run fixes bug https://bugs.winehq.org/show_bug.cgi?id=46760 -- v2: MmAllocateContiguousMemorySpecifyCache semi-stub https://gitlab.winehq.org/wine/wine/-/merge_requests/777

3 2

[PATCH v4 0/2] MR726: msvfw32: Use string comparison to determine class name equality.
by Alexandros Frantzis (＠afrantzis) 05 Sep '22

05 Sep '22

The current version of the code incorrectly assumes that the lpszClass member of CREATESTRUCT passed with WM_CREATE will point to the same memory used for the CreateWindowEx class name parameter, and uses a pointer comparison to check for class name equality. As a side effect of commit e41c255be6ba66d1eec7affe674b8cc7699226b8 "win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the CREATESTRUCT lpszClass member started pointing to different memory, breaking the current implementation of MCIWND_Create(). This commit fixes the problem by performing a proper, case-insensitive string comparison to determine class name equality. Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53578 -- v4: msvfw32: Use window name to determine if window is created using MCIWndCreate. msvfw32: Test window creation with filename. https://gitlab.winehq.org/wine/wine/-/merge_requests/726

4 4

[PATCH 0/7] MR786: Add data for high planes in Unicode tables
by Alexandre Julliard (＠julliard) 05 Sep '22

05 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/786

4 9

[PATCH 0/3] MR783: dwrite: Handle higher planes when setting DWRITE_SCRIPT_SHAPES_NO_VISUAL.
by Nikolay Sivov (＠nsivov) 05 Sep '22

05 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/783

2 4

[PATCH 0/1] MR776: msvfw32: Test window creation with filename.
by eric pouech (＠epo) 05 Sep '22

05 Sep '22

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/776

2 3

[PATCH v3 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 05 Sep '22

05 Sep '22

-- v3: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 5

[PATCH v3 0/1] MR726: msvfw32: Use string comparison to determine class name equality.
by Alexandros Frantzis (＠afrantzis) 05 Sep '22

05 Sep '22

The current version of the code incorrectly assumes that the lpszClass member of CREATESTRUCT passed with WM_CREATE will point to the same memory used for the CreateWindowEx class name parameter, and uses a pointer comparison to check for class name equality. As a side effect of commit e41c255be6ba66d1eec7affe674b8cc7699226b8 "win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the CREATESTRUCT lpszClass member started pointing to different memory, breaking the current implementation of MCIWND_Create(). This commit fixes the problem by performing a proper, case-insensitive string comparison to determine class name equality. Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53578 -- v3: msvfw32: Use string comparison to determine class name equality. https://gitlab.winehq.org/wine/wine/-/merge_requests/726

4 14

[PATCH v3 0/1] MR785: po: Update German translation.
by Julian Rüger (＠jrueger) 05 Sep '22

05 Sep '22

None -- v3: po: Update German translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/785

2 1

[PATCH 0/1] MR785: po: Update German translation.
by Julian Rüger (＠jrueger) 05 Sep '22

05 Sep '22

None -- https://gitlab.winehq.org/wine/wine/-/merge_requests/785

2 1

[PATCH 0/1] MR784: wined3d: Tell vkd3d_shader about dual source blending.
by Stefan Dösinger (＠stefan) 05 Sep '22

05 Sep '22

Dual source blending implies an additional shader output, which needs to be declared. This improves WoT on high graphics settings on MoltenVK. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/784

2 2

[PATCH 0/1] MR781: winex11.drv: Use #ifdef to check config.h macros.
by Francois Gouget (＠fgouget) 05 Sep '22

05 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/781

2 1

Re: [PATCH v2 0/2] MR764: tests: Allow marking unreliable tests as flaky. - closed
by Francois Gouget (＠fgouget) 05 Sep '22

05 Sep '22

This merge request was closed by Francois Gouget. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/764

1 0

[PATCH v4 0/1] MR772: tests: Allow marking unreliable tests as flaky.
by Francois Gouget (＠fgouget) 05 Sep '22

05 Sep '22

-- v4: tests: Allow marking unreliable tests as flaky. https://gitlab.winehq.org/wine/wine/-/merge_requests/772

2 2

[PATCH v2 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 04 Sep '22

04 Sep '22

-- v2: advapi32/test: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 5

[PATCH 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 04 Sep '22

04 Sep '22

this gets the YSDrv service to start successfully (with the MmAllocateContiguousMemorySpecifyCache semi-stub) this service is used by the nox android emulator -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778

2 1

[PATCH 0/2] MR777: ntoskrnl: MmAllocateContiguousMemorySpecifyCache semi-stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 04 Sep '22

04 Sep '22

This should help to get the nox android emulator to run fixes bug https://bugs.winehq.org/show_bug.cgi?id=46760 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/777

2 2

[PATCH v2 0/1] MR775: comctl32: Support passing bitmap and icon resource ID as a string when creating static control.
by Lorenzo Ferrillo (＠llde) 04 Sep '22

04 Sep '22

Follow Up of Merge request !693 by Jacek Caban. That pull request changed properly the static control of user32, but didn't address the comctl32 static control. Fix an issue of TES4:Oblivion Construction Set, reported by me in the Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=53581#c5 after the merge request fixed the reported CS crash. Signed-off-by: Lorenzo Ferrillo [lorenzofersteam@live.it](mailto:lorenzofersteam@live.it) -- v2: comctl32: Support passing bitmap and icon resource ID as a string when creating static control. https://gitlab.winehq.org/wine/wine/-/merge_requests/775

2 2

[PATCH v2 0/5] MR741: Draft: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) 04 Sep '22

04 Sep '22

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.or… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. On non-x86 Linux 4.3-4.13 `membarrier(MEMBARRIER_CMD_SHARED, ...)` is used. On non-x86 Linux <= 4.2 and on other platforms the fallback path using APCs is used. -- v2: ntdll: Add thread_get_register_pointer_values-based fast path for NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based fast path to NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based fast path for NtFlushProcessWriteBuffers. ntdll: Make server_select a memory barrier. ntdll: Implement NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

3 13

[PATCH 0/1] MR775: comctl32: Support passing bitmap and icon resource ID as a string when creating static control.
by Lorenzo Ferrillo (＠llde) 04 Sep '22

04 Sep '22

Follow Up of Merge request !693 by Jacek Caban. That pull request changed properly the static control of user32, but didn't address the comctl32 static control. Fix an issue of TES4:Oblivion Construction Set, reported by me in the Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=53581#c5 after the merge request fixed the reported CS crash. Signed-off-by: Lorenzo Ferrillo [lorenzofersteam@live.it](mailto:lorenzofersteam@live.it) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/775

3 4

Re: [PATCH v8 0/1] MR721: ntoskrnl: Implement cmp instruction with opcode 0x83
by Etaash Mathamsetty (＠etaash.mathamsetty) 03 Sep '22

03 Sep '22

On Sat Sep 3 17:53:35 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 9/3/22 12:48, Etaash Mathamsetty (@etaash.mathamsetty) wrote: > > On Sat Sep 3 17:43:11 2022 +0000, **** wrote: > >> Zebediah Figura replied on the mailing list: > >> \`\`\` > >> On 9/3/22 12:22, Etaash Mathamsetty (@etaash.mathamsetty) wrote: > >>> This instruction only needs to compare 1 byte, since it's imm8 is just > >> an 8 bit number (unless I am wrong) > >> The 0x83 family is an arithmetic operation between a sign-extended > >> immediate byte and a 2/4/8-byte register or memory location. The > >> equivalent 1-byte comparison is 0x80 or 0x82 (they are duplicates). > >> \`\`\` > > the comparison is between a signed byte and a 2/4/8 byte > register/memory location, how am I supposed to compare more than 1 byte? > > > As stated, the immediate byte should be sign-extended to the appropriate > length. > ``` Do you have any info on how to set these other flags? `OF, PF, AF, SF` I can't find much info about it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/721#note_7623

2 1

Re: [PATCH v8 0/1] MR721: ntoskrnl: Implement cmp instruction with opcode 0x83
by Etaash Mathamsetty (＠etaash.mathamsetty) 03 Sep '22

03 Sep '22

Seems like I messed something up, and so I had to reset the whole tree and patch in v2. Sorry about that -- https://gitlab.winehq.org/wine/wine/-/merge_requests/721#note_7622

1 0

[PATCH v4 0/8] MR711: mf: Add some media session event tests for SetTopology and media type initialization.
by Rémi Bernon (＠rbernon) 03 Sep '22

03 Sep '22

-- v4: mf/tests: Test that IMFMediaSession_SetTopology sets output nodes media types. mf/tests: Test that IMFTopoLoader_Load sets transform nodes media types. mf/tests: Test that IMFTopoLoader_Load doesn't set output nodes media types. mf/tests: Test some IMFMediaSession_SetTopology error cases. mf/tests: Add helpers to wait and check media session events. mf/tests: Allocate test callbacks dynamically and check refcounts. mf/tests: Keep a presentation descriptor in the test source. mf/tests: Move and split some helper code around. https://gitlab.winehq.org/wine/wine/-/merge_requests/711

3 10

[PATCH 0/1] MR763: windowscodecs/tests: Clean up after running test expected to fail.
by Matteo Bruni (＠Mystral) 03 Sep '22

03 Sep '22

Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/763

3 2

[PATCH v3 0/1] MR721: ntoskrnl: Implement cmp instruction with opcode 0x83
by Etaash Mathamsetty (＠etaash.mathamsetty) 03 Sep '22

03 Sep '22

Required for vgk.sys (vanguard anti-cheat) -- v3: parent 7546b4a63d437c2f7f8673cae9341d358f84f1a5 https://gitlab.winehq.org/wine/wine/-/merge_requests/721

3 6

[PATCH 0/3] MR10: Move Wine headers to a wine/ subdirectory
by Alexandre Julliard (＠julliard) 03 Sep '22

03 Sep '22

This reduces the diff with the Wine bundled version. It should also make it clearer that these are Wine headers that should ideally be changed upstream first and then re-imported. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/10

4 11

[PATCH 0/1] MR774: msvcp140: Add _ExceptionHolder::ReportUnhandledError stub.
by Gijs Vermeulen (＠gverm) 02 Sep '22

02 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53614 Signed-off-by: Gijs Vermeulen <gverm(a)inuits.eu> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/774

2 1

Re: [PATCH v3 0/2] MR758: d3d10: Handle invalid arguments for effect creation. - approved
by Alexandre Julliard (＠julliard) 02 Sep '22

02 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/758

1 0

Re: [PATCH v2 0/1] MR773: dwrite: Fix spans length reported by AnalyzeScript() for characters above BMP. - approved
by Alexandre Julliard (＠julliard) 02 Sep '22

02 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/773

1 0

Re: [PATCH v12 0/6] MR576: win32u: Move display placement logic out of graphics drivers. - approved
by Alexandre Julliard (＠julliard) 02 Sep '22

02 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/576

1 0

Re: [PATCH v7 0/4] MR607: mf: Fix session command handling and SESSION_CMD_END. - approved
by Alexandre Julliard (＠julliard) 02 Sep '22

02 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/607

1 0

Re: [PATCH v2 0/1] MR770: wmiutils: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 02 Sep '22

02 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/770

1 0

Re: [PATCH v2 0/1] MR769: prntvpt: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 02 Sep '22

02 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/769

1 0

Re: [PATCH v2 0/2] MR768: Update Finnish translation - approved
by Alexandre Julliard (＠julliard) 02 Sep '22

02 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/768

1 0

[PATCH 0/1] MR741: Draft: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) 02 Sep '22

02 Sep '22

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.or… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On Linux 4.16+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.15 `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. On non-x86 Linux 4.3+ `membarrier(MEMBARRIER_CMD_SHARED, ...)` is used. On Linux <= 4.2 and on other platforms the fallback path using APCs is used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/741

4 8

[PATCH v2 0/2] MR758: d3d10: Handle invalid arguments for effect creation.
by Ziqing Hui (＠zhui) 02 Sep '22

02 Sep '22

-- v2: d3d10: Handle invalid arguments for effect creation. d3d10/tests: Test NULL device for D3D10CreateEffectFromMemory and D3D10CreateEffectPoolFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/758

3 4

[PATCH 0/1] MR773: dwrite: Fix spans length reported by AnalyzeScript() for characters above BMP.
by Nikolay Sivov (＠nsivov) 02 Sep '22

02 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/773

2 1

[PATCH v3 0/1] MR772: tests: Allow marking unreliable tests as flaky.
by Francois Gouget (＠fgouget) 02 Sep '22

02 Sep '22

-- v3: tests: Allow marking unreliable tests as flaky. https://gitlab.winehq.org/wine/wine/-/merge_requests/772

3 3

Re: [PATCH v2 0/1] MR772: tests: Allow marking unreliable tests as flaky.
by Huw Davies (＠huw) 02 Sep '22

02 Sep '22

Huw Davies (@huw) commented about include/wine/test.h: > va_end(valist); > } > > +void winetest_start_flaky( int is_flaky ) > +{ > + struct tls_data *data = get_tls_data(); > + data->flaky_level = (data->flaky_level << 1) | (is_flaky != 0); > + data->flaky_do_loop=1; Could we have spaces on either side of the '=', just like the lines above? I realise this is copied from the 'todo' functions, but still. Similarly, two instances below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/772#note_7560

1 0

[PATCH v11 0/6] MR576: win32u: Move display placement logic out of graphics drivers.
by Rémi Bernon (＠rbernon) 02 Sep '22

02 Sep '22

In preparation for nulldrv display modes support. -- v11: win32u: Move display placement logic out of graphics drivers. winemac.drv: Remove unnecessary display mode flags checks. winex11.drv: Remove unnecessary display mode flags checks. win32u: Move full display mode lookup out of graphics drivers. win32u: Support interlaced and stretched display modes. win32u: Sort adapter display modes after reading from the registry. https://gitlab.winehq.org/wine/wine/-/merge_requests/576

4 8

[PATCH v6 0/4] MR607: mf: Fix session command handling and SESSION_CMD_END.
by Rémi Bernon (＠rbernon) 02 Sep '22

02 Sep '22

-- v6: mf: Notify quality manager of topology change in session_set_topology. mf: Use the SESSION_FLAG_PENDING_COMMAND to delay further commands. mf: Delay media session command processing when presentation is ending. mf: Use a dedicated interface for sample allocator ready callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/607

3 7

[PATCH v3 0/8] MR711: mf: Add some media session event tests for SetTopology and media type initialization.
by Rémi Bernon (＠rbernon) 02 Sep '22

02 Sep '22

-- v3: mf: Initialize output media types when binding session output nodes. mf/tests: Test that IMFMediaSession_SetTopology should set media types. mf/tests: Test some IMFMediaSession_SetTopology error cases. mf/tests: Test that IMFTopoLoader_Load doesn't call SetCurrentMediaType. mf/tests: Add helpers to wait and check media session events. mf/tests: Allocate test callbacks dynamically and check refcounts. mf/tests: Keep a presentation descriptor in the test source. mf/tests: Move and split some helper code around. https://gitlab.winehq.org/wine/wine/-/merge_requests/711

3 10

[PATCH 0/1] MR772: tests: Allow marking unreliable tests as flaky.
by Francois Gouget (＠fgouget) 02 Sep '22

02 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/772

2 2

[PATCH 0/1] MR770: wmiutils: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 02 Sep '22

02 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/770

3 2

[PATCH 0/1] MR769: prntvpt: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 02 Sep '22

02 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/769

2 1

[PATCH 0/2] MR768: Update Finnish translation
by Lauri Kenttä (＠lauri.kentta) 02 Sep '22

02 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/768

2 2

[PATCH v5 0/3] MR607: mf: Fix session command handling and SESSION_CMD_END.
by Rémi Bernon (＠rbernon) 01 Sep '22

01 Sep '22

-- v5: mf: Remove command from the command list on execution. mf: Delay media session command processing when presentation is ending. mf: Use a dedicated interface for sample allocator ready callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/607

2 4

[PATCH 0/2] MR764: tests: Allow marking unreliable tests as flaky.
by Francois Gouget (＠fgouget) 01 Sep '22

01 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/764

5 9

Re: [PATCH v3 0/4] MR710: Fixes for volume size information retrieval - approved
by Alexandre Julliard (＠julliard) 01 Sep '22

01 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/710

1 0

Re: [PATCH v3 0/5] MR731: mshtml: Implement props forwarding for Storage. - approved
by Alexandre Julliard (＠julliard) 01 Sep '22

01 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/731

1 0

Re: [PATCH v2 0/2] MR762: winevulkan: Update to VK spec version 1.3.226. - approved
by Alexandre Julliard (＠julliard) 01 Sep '22

01 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/762

1 0

Re: [PATCH v3 0/1] MR724: d3dx10/tests: Test block compressed texture data which has more than one block line. - approved
by Alexandre Julliard (＠julliard) 01 Sep '22

01 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/724

1 0

Re: [PATCH v2 0/2] MR761: msvcrt: Use size_t for the size in wcsdup(). - approved
by Alexandre Julliard (＠julliard) 01 Sep '22

01 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/761

1 0

Re: [PATCH v2 0/1] MR756: win32u: Only cache font glyph metrics from GGO_METRICS. - approved
by Alexandre Julliard (＠julliard) 01 Sep '22

01 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/756

1 0

Re: [PATCH v2 0/1] MR760: wbemdisp: Use wcsdup() instead of internal helper. - approved
by Alexandre Julliard (＠julliard) 01 Sep '22

01 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/760

1 0

Re: [PATCH v4 0/1] MR730: user32: Implement DefRawInputProc. - approved
by Alexandre Julliard (＠julliard) 01 Sep '22

01 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/730

1 0

Re: [PATCH v3 0/5] MR755: uxtheme: Do not draw parent background even if scrollbar arrows and thumb are transparent. - approved
by Alexandre Julliard (＠julliard) 01 Sep '22

01 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/755

1 0

Re: [PATCH v2 0/1] MR757: dwrite: Handle variation selectors 17-256 in MapCharacters(). - approved
by Alexandre Julliard (＠julliard) 01 Sep '22

01 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/757

1 0

[PATCH 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 01 Sep '22

01 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 2

[PATCH v2 0/5] MR731: mshtml: Implement props forwarding for Storage.
by Gabriel Ivăncescu (＠insn) 01 Sep '22

01 Sep '22

This implements props access to the underlying items in the storage, which is supported on native (although quirky). Unlike most normal props, the underlying storage for the props is asynchronous, so it can disappear or appear at any point, so they have to be re-checked as needed. The props themselves just map a name to a DISPID, but other than that, DISP_E_MEMBERNOTFOUND can return even after a successful GetDispID for example, even if GetDispID already checked for the item (which it has to, for e.g. (x in y) check). It also contains some fixes for enumerating props, which are needed now because these props also have to be enumerated. They are custom props, so it's needed to have GetMemberName work for them. And since they are asynchronous it makes it even more complicated when enumerating. -- v2: mshtml: Implement props enumeration for Storage. mshtml: Implement GetMemberName for custom props. mshtml: Do not enumerate hidden builtin props. mshtml: Implement deleting props for Storage. mshtml: Implement props for Storage by forwarding to the underlying storage. https://gitlab.winehq.org/wine/wine/-/merge_requests/731

4 8

[PATCH v2 0/1] MR752: winecrt0: run C++ object destructors in DLL_PROCESS_DETACH.
by Kevin Puetz (＠puetzk) 01 Sep '22

01 Sep '22

Run C++ global/static destructors during DLL_PROCESS_DETACH while other other dllimport functions they may want to call are still viable. While windows imposes many restrictions on what may be done in such destructors (given that the run inside the loader lock), there are lots of legal and useful kernel32 functions like DestroyCriticalSection, DeleteAtom, TlsFree, etc that are both useful and legal. Currently this does not work for builtin modules because all the Win32 structures are discarded well before NtUnmapViewOfSection finally does the dlllose. Even for a winelib .dll.so module, it would be preferable for destructors to execute during process_detach (before wine tears down the MODREF and detaches dependant dlls), rather than be left until after the last NtUnmapViewOfSection (when we finally reach dlclose) Therefore, winegcc now always uses the DllMainCRTStartup entry point unless you specify your own --entry=func. Previously it did this only for PE modules using msvcrt. Making this default consistent matches cl.exe, which also always defaults to _DllMainCRTStartup unless overridden by /entry:foo https://docs.microsoft.com/en-us/cpp/build/reference/entry-entry-point-symb… The ELF version of winecrt0.a now provides a DllMainCRTStartup which, per the Itanium ABI that is in practice what is used by gcc and clang, performs this this destruction by calling __cxa_finalize(&__dso_handle).. This libc function is required to be idempotent, so it's OK that dlclose still calls it again later (there will just be no further work to do). Multiple calls to __cxa_finalize shall not result in calling termination function entries multiple times; the implementation may either remove entries or mark them finished. https://itanium-cxx-abi.github.io/cxx-abi/abi.html#dso-dtor-runtime-api This has two main effects; it moves ELF destructors earlier (before imports are unmapped), and it moves them inside the Nt loader lock. Being earlier was the intended goal, and moving them inside the lock seems fine. Any Win32 API calls in destructors are just being subjected to the same lock hierarchy rules as usual on windows (MSVC also runs destructors from DllMainCrtStartup) https://docs.microsoft.com/en-us/cpp/build/run-time-library-behavior?view=m… And any purely-ELF destructors that happen to also run earlier should never call functions exported from wine (and thus don't care about ntdll's locks). -- v2: winecrt0: run C++ object destructors in DLL_PROCESS_DETACH. https://gitlab.winehq.org/wine/wine/-/merge_requests/752

2 4

[PATCH v3 0/5] MR729: windows.media.speech: Initial recognition session work.
by Bernhard Kölbl (＠besentv) 01 Sep '22

01 Sep '22

-- v3: windows.media.speech: Implement a worker thread for the recognition session. https://gitlab.winehq.org/wine/wine/-/merge_requests/729

3 7

[PATCH v7 0/8] MR717: Implement application hives in the registry
by Santino Mazza (＠tati1454) 01 Sep '22

01 Sep '22

Initial implementation for registry application hives, this is a step forward to get Visual Studio to run. :-) -- v7: server: save app hive into it's file when closing handle. server/registry: pass file name instead of file handle to server. kernelbase: Implement RegLoadAppKey. ntdll: Initial implementation for application hives. ntdll: Move NtLoadKey implementation to NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/717

3 12

[PATCH 0/2] MR762: winevulkan: Update to VK spec version 1.3.226.
by Georg Lehmann (＠DadSchoorse) 01 Sep '22

01 Sep '22

Not trivial this time because VK_NV_mesh_shader now aliases 64bit enum values that are only later defined by VK_EXT_mesh_shader. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/762

2 2

[PATCH 0/3] MR758: d3d10: Test D3D10CreateEffectFromMemory.
by Ziqing Hui (＠zhui) 01 Sep '22

01 Sep '22

The test results show that data passed to D3D10CreateEffectFromMemory won't be modified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/758

4 7

[PATCH v2 0/1] MR724: d3dx10/tests: Test block compressed texture data which has more than one block line.
by Ziqing Hui (＠zhui) 01 Sep '22

01 Sep '22

-- v2: d3dx10/tests: Test block compressed texture data which has more than one block line. https://gitlab.winehq.org/wine/wine/-/merge_requests/724

3 4

[PATCH 0/2] MR761: msvcrt: Use size_t for the size in wcsdup().
by Nikolay Sivov (＠nsivov) 01 Sep '22

01 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/761

3 3

[PATCH 0/1] MR756: win32u: Only cache font glyph metrics from GGO_METRICS.
by Zhiyi Zhang (＠zhiyi) 01 Sep '22

01 Sep '22

Fonts loaded with GGO_BITMAP may report different font metrics than that with GGO_METRICS. If the font metrics from GGO_BITMAP are used and later getting font metrics with GGO_METRICS or vice versa, the font metric difference may cause UI glitchs. Fix Steam installer next button text moving to the left for 1 pixel when hovered on Mac and Wine is built with FreeType > 2.8.0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/756

3 2

[PATCH v10 0/6] MR576: win32u: Move display placement logic out of graphics drivers.
by Rémi Bernon (＠rbernon) 01 Sep '22

01 Sep '22

In preparation for nulldrv display modes support. -- v10: win32u: Move display placement logic out of graphics drivers. winemac.drv: Remove unnecessary display mode flags checks. win32u: Support interlaced and stretched display modes. winex11.drv: Remove unnecessary display mode flags checks. win32u: Move full display mode lookup out of graphics drivers. win32u: Sort adapter display modes after reading from the registry. https://gitlab.winehq.org/wine/wine/-/merge_requests/576

3 11

[PATCH 0/1] MR760: wbemdisp: Use wcsdup() instead of internal helper.
by Nikolay Sivov (＠nsivov) 01 Sep '22

01 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/760

3 2

[PATCH v5 0/1] MR734: tests: Make sure only one thread prints traces at a time.
by Francois Gouget (＠fgouget) 01 Sep '22

01 Sep '22

Some Wine tests are multi-threaded or start child processes which can result in traces and failure messages being garbled which prevents them from being recognized by continuous integration tools. So printing the tests messages is now serialized. Note that if a process crashes while holding the mutex, that mutex will be abandonned and not cause a deadlock. -- v5: tests: Make sure only one thread prints traces at a time. https://gitlab.winehq.org/wine/wine/-/merge_requests/734

2 2

[PATCH v3 0/1] MR730: user32: Implement DefRawInputProc.
by Andrey Gusev (＠agusev) 01 Sep '22

01 Sep '22

-- v3: user32: Implement DefRawInputProc. https://gitlab.winehq.org/wine/wine/-/merge_requests/730

4 4

[PATCH 0/1] MR759: include/wine/test.h: Enable ANSI support in console for WINETEST_COLOR.
by eric pouech (＠epo) 01 Sep '22

01 Sep '22

This lets WINETEST_COLOR works under Windows console (at least, on recent versions where ANSI support is available). (Keeping logic: + "auto": emit ANSI sequences only when output is capable of + "1": always use ANSI sequences ) Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/759

2 1

[PATCH v2 0/5] MR755: uxtheme: Do not draw parent background even if scrollbar arrows and thumb are transparent.
by Zhiyi Zhang (＠zhiyi) 01 Sep '22

01 Sep '22

This is confirmed by the tests in test_scrollbar() and manual tests on XP. Even though scrollbar arrows and thumb are in fact transparent, DrawThemeParentBackground() is not called to paint the parent background, leaving the transparent area untouched. On Windows, even if the scrollbar arrows are reported to be transparent, the bitmaps for arrow parts in the stock themes are in fact opaque. Fix Ice Cream Calculator slow scrolling after 4cb229a because the WM_PRINTCLIENT handling in the application is slow. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53337 -- v2: comctl32/datetime: Do not paint parent background when painting arrows. uxtheme: Do not draw parent background even if scrollbar arrows and thumb are transparent. uxtheme: Use the brush from WM_CTLCOLORSCROLLBAR to paint SB_CTL scrollbar tracks if present. comctl32/tests: Add themed scrollbar background tests. uxtheme/tests: Add theme tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/755

2 5

[PATCH 0/1] MR757: dwrite: Handle variation selectors 17-256 in MapCharacters().
by Nikolay Sivov (＠nsivov) 01 Sep '22

01 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/757

2 1

Re: [PATCH v5 0/6] MR697: Implement d3dx10 effect creation for compiled shader.
by Ziqing Hui (＠zhui) 01 Sep '22

01 Sep '22

On Sat Aug 27 11:18:20 2022 +0000, Matteo Bruni wrote: > Nah, let's just keep this as it is now, no reason to make everything > more complicated. > I guess this is just something peculiar to fx_4_0 effects, surprised > that I never encountered it before. I'll do some further digging locally. I found that in d3d10/tests/effect.c: create_effect(): > /* > * Don't use sizeof(data), use data[6] as size, > * because the DWORD data[] has only complete DWORDs and > * so it could happen that there are padded bytes at the end. > * > * The fx size (data[6]) could be up to 3 BYTEs smaller > * than the sizeof(data). > */ Maybe we could do something like this? Use DWORDs to store shader code. And pass data[6] to size argument. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/697#note_7431

1 0

[PATCH 0/4] MR755: uxtheme: Do not draw parent background even if scrollbar arrows and thumb are transparent.
by Zhiyi Zhang (＠zhiyi) 01 Sep '22

01 Sep '22

This is confirmed by the tests in test_scrollbar() and manual tests on XP. Even though scrollbar arrows and thumb are in fact transparent, DrawThemeParentBackground() is not called to paint the parent background, leaving the transparent area untouched. On Windows, even if the scrollbar arrows are reported to be transparent, the bitmaps for arrow parts in the stock themes are in fact opaque. Fix Ice Cream Calculator slow scrolling after 4cb229a because the WM_PRINTCLIENT handling in the application is slow. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53337 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/755

3 5

[PATCH v13 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) 01 Sep '22

01 Sep '22

Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button. Updated bitmaps in comctl32 and SVG files for history icons. My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338. -- v13: comdlg32: Add missing controls to the common item dialog, only affecting the implementation comdlg32: Add missing controls and their functionality to IFileDialog, or the common item dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/672

3 4

[PATCH v2 0/5] MR729: windows.media.speech: Initial recognition session work.
by Bernhard Kölbl (＠besentv) 31 Aug '22

31 Aug '22

-- v2: windows.media.speech: Implement a worker thread for the recognition session. windows.media.speech/tests: Test the recognizer state. windows.media.speech: Return IAsyncAction from session_PauseAsync. windows.media.speech: Return IAsyncAction from session_StopAsync. https://gitlab.winehq.org/wine/wine/-/merge_requests/729

3 6

[PATCH v6 0/8] MR717: Implement application hives in the registry
by Santino Mazza (＠tati1454) 31 Aug '22

31 Aug '22

Initial implementation for registry application hives, this is a step forward to get Visual Studio to run. :-) -- v6: server: save app hive into it's file when closing handle. server/registry: pass file name instead of file handle to server. kernelbase: Implement RegLoadAppKey. ntdll: Initial implementation for application hives. ntdll: Move NtLoadKey implementation to NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/717

3 10

Re: [PATCH v5 0/6] MR697: Implement d3dx10 effect creation for compiled shader. - approved
by Alexandre Julliard (＠julliard) 31 Aug '22

31 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/697

1 0

2025

2024

2023

2022

wine-gitlab