- wine-gitlab - winehq.org

[PATCH v5 0/7] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) 08 Jul '22

08 Jul '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v5: scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). scrrun: Check that source is directory in MoveFolder. https://gitlab.winehq.org/wine/wine/-/merge_requests/391

3 9

[PATCH 0/3] MR405: winegstreamer: More wg_transform fixes for CoD: BO3, Mortal Kombat 11 and Shadow Warrior.
by Rémi Bernon (＠rbernon) 08 Jul '22

08 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/405

2 4

[PATCH 0/3] MR406: win32u: Introduce new add_modes device manager callback.
by Rémi Bernon (＠rbernon) 08 Jul '22

08 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/406

3 5

[PATCH 0/1] MR404: mscms: Merge the profile and transform handle tables.
by Hans Leidekker (＠hans) 08 Jul '22

08 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/404

2 1

Re: [PATCH 0/4] MR388: d2d1: Introduce D2DERR_NOT_FOUND.
by Nikolay Sivov (＠nsivov) 08 Jul '22

08 Jul '22

On Fri Jul 8 04:21:30 2022 +0000, Ziqing Hui wrote: > I didn't checkout the SDK header files though. If it's not in SDK, we shouldn't have it in public headers either. There is an equivalent E_NOT_SET macro that you can use, and if D2DERR one appears in SDK at some point we'll switch to it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/388#note_3597

1 0

Re: [PATCH 0/4] MR388: d2d1: Introduce D2DERR_NOT_FOUND.
by Nikolay Sivov (＠nsivov) 08 Jul '22

08 Jul '22

Nikolay Sivov (@nsivov) commented about dlls/d2d1/d2d1_private.h: > void d2d_factory_register_effect(struct d2d_factory *factory, > struct d2d_effect_registration *effect) DECLSPEC_HIDDEN; > > +struct d2d_offset_transform > +{ > + ID2D1OffsetTransform ID2D1OffsetTransform_iface; > + LONG refcount; > + D2D1_POINT_2L offset; > +}; > + Do we need a separate structure for each type of node? Maybe we could have a structure similar to d2d_brush. My understanding is it's not possible to have user-defined node types. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/388#note_3596

1 0

[PATCH 0/2] MR403: ddraw/tests: Build without -DWINE_NO_LONG_TYPES.
by Zebediah Figura (＠zfigura) 08 Jul '22

08 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/403

2 2

[PATCH 0/2] MR402: http.sys: Add support for relative URLs.
by Julian Klemann (＠jklemann) 08 Jul '22

08 Jul '22

The queue with the most specific path should be the one to receive the request. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/402

3 3

Re: [PATCH 0/4] MR388: d2d1: Introduce D2DERR_NOT_FOUND.
by Ziqing Hui (＠zhui) 08 Jul '22

08 Jul '22

On Fri Jul 8 04:20:45 2022 +0000, Ziqing Hui wrote: > MS doc: https://docs.microsoft.com/en-us/windows/win32/api/d2d1effectauthor/nf-d2d1… > "Return value" part says: > | D2DERR_NOT_FOUND = (HRESULT_FROM_WIN32(ERROR_NOT_FOUND)) | Direct2D > could not locate the specified node. I didn't checkout the SDK header files thought. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/388#note_3592

1 0

Re: [PATCH 0/4] MR388: d2d1: Introduce D2DERR_NOT_FOUND.
by Ziqing Hui (＠zhui) 08 Jul '22

08 Jul '22

On Thu Jul 7 06:56:42 2022 +0000, Nikolay Sivov wrote: > I don't see in 10.0.2200.0 SDK. Where does it come from? MS doc: https://docs.microsoft.com/en-us/windows/win32/api/d2d1effectauthor/nf-d2d1… "Return value" part says: | D2DERR_NOT_FOUND = (HRESULT_FROM_WIN32(ERROR_NOT_FOUND)) | Direct2D could not locate the specified node. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/388#note_3591

1 0

[PATCH v4 0/4] MR375: ntdll: Fixes for runtime 64-bit shift functions.
by Zebediah Figura (＠zfigura) 08 Jul '22

08 Jul '22

Based on <https://source.winehq.org/patches/data/238821> by Zhao Yi. -- v4: ntdll: Correctly handle shift greater than the type width in 64-bit shift functions. ntdll: Avoid depending on compiler support for 64-bit shift functions. ntdll/tests: Add tests for runtime 64-bit shift functions. ntdll: Fix the calling convention for runtime 64-bit shift functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/375

2 4

Re: [PATCH v2 0/1] MR401: wbemprox: Provide more accurate system information - approved
by Alexandre Julliard (＠julliard) 07 Jul '22

07 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/401

1 0

Re: [PATCH v2 0/1] MR397: regedit: Replace heap_x*() functions with malloc(), realloc() and free() - approved
by Alexandre Julliard (＠julliard) 07 Jul '22

07 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/397

1 0

Re: [PATCH v2 0/1] MR381: mciqtz32: Fix thread handle leak if a second play. - approved
by Alexandre Julliard (＠julliard) 07 Jul '22

07 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/381

1 0

Re: [PATCH v3 0/2] MR394: d3d8/tests: Build without -DWINE_NO_LONG_TYPES. - approved
by Alexandre Julliard (＠julliard) 07 Jul '22

07 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/394

1 0

[PATCH v3 0/4] MR358: atl: Avoid NULL pointer reference in AtlComModuleGetClassObject().
by Zhiyi Zhang (＠zhiyi) 07 Jul '22

07 Jul '22

Fix crash in CAXA CAD when clicking component library. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- v3: atl: Avoid NULL pointer reference in AtlComModuleRevokeClassObjects(). atl: Avoid NULL pointer reference in AtlComModuleRegisterClassObjects(). atl: Avoid NULL pointer reference in AtlComModuleGetClassObject(). atl110: Add importlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/358

3 5

Re: [PATCH v2 0/2] MR382: widl: Fix missing support for struct / union parameterized type replacement. - approved
by Alexandre Julliard (＠julliard) 07 Jul '22

07 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/382

1 0

Re: [PATCH v2 0/1] MR379: wined3d: Don't transition GENERAL layouts for blits. - approved
by Alexandre Julliard (＠julliard) 07 Jul '22

07 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/379

1 0

Re: [PATCH v2 0/2] MR396: dinput/tests: Fix reported test failures. - approved
by Alexandre Julliard (＠julliard) 07 Jul '22

07 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/396

1 0

Re: [PATCH v3 0/4] MR395: win32u: Move reading and writing mode from registry out of graphics drivers. - approved
by Alexandre Julliard (＠julliard) 07 Jul '22

07 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/395

1 0

[PATCH v7 0/3] MR302: winegstreamer: Some wg_transform H264 fixes for Mortal Kombat 11 and Yakuza 4.
by Rémi Bernon (＠rbernon) 07 Jul '22

07 Jul '22

-- v7: winegstreamer: Use an atomic queue for wg_transform input buffers. winegstreamer: Release requested samples if they are too small. mf/tests: Add todo_wine for newer FFmpeg versions. https://gitlab.winehq.org/wine/wine/-/merge_requests/302

3 4

[PATCH v4 0/7] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) 07 Jul '22

07 Jul '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v4: scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). scrrun: Check that source is directory in MoveFolder. scrrun: Check for non-existant source in MoveFolder. scrrun: Test MoveFolder with already existing destination. scrrun: Check for null and empty arguments in MoveFolder. scrrun: Implement MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

2 8

[PATCH 0/1] MR401: wbemprox: Provide more accurate system information
by SmallJoker (＠SmallJoker) 07 Jul '22

07 Jul '22

This re-uses existing functions from Win32_ComputerSystemProduct to provide more accurate values, which are helpful to system overview applications. How to test: `wmic.exe computersystem GET Manufacturer` Previously discussed with davidebeatrici, 2022-07-02 in #winehackers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/401

3 2

Re: [PATCH 0/1] MR381: mciqtz32: Fix thread handle leak if a second play. - approved
by Zebediah Figura (＠zfigura) 07 Jul '22

07 Jul '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/381

1 0

[wine-gitlab] [PATCH v3 0/7] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) 07 Jul '22

07 Jul '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v3: scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

3 12

[PATCH v2 0/1] MR398: xactengine3_7/tests: Test notifications when loading a wave bank.
by Giovanni Mascellani (＠giomasce) 07 Jul '22

07 Jul '22

"The King of Fighters '98 Ultimate Match Final Edition" depends on this behavior. At least, the build I have is; it seems other builds are not. Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com> -- v2: xactengine3_7/tests: Test notifications when loading a wave bank. https://gitlab.winehq.org/wine/wine/-/merge_requests/398

2 1

Re: [PATCH v2 0/4] MR358: atl: Avoid NULL pointer reference in AtlComModuleGetClassObject(). - approved
by Jacek Caban (＠jacek) 07 Jul '22

07 Jul '22

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/358

1 0

[wine-gitlab] [PATCH 0/1] MR398: xactengine3_7/tests: Test notifications when loading a wave bank.
by Giovanni Mascellani (＠giomasce) 07 Jul '22

07 Jul '22

"The King of Fighters '98 Ultimate Match Final Edition" depends on this behavior. At least, the build I have is; it seems other builds are not. Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/398

2 1

[wine-gitlab] [PATCH 0/1] MR397: regedit: Replace heap_x*() functions with malloc(), realloc() and free()
by Hugh McMaster (＠hmc) 07 Jul '22

07 Jul '22

Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/397

2 1

[wine-gitlab] [PATCH v3 0/4] MR375: ntdll: Fixes for runtime 64-bit shift functions.
by Zebediah Figura (＠zfigura) 07 Jul '22

07 Jul '22

Based on <https://source.winehq.org/patches/data/238821> by Zhao Yi. -- v3: ntdll: Correctly handle shift greater than the type width in 64-bit shift functions. ntdll: Avoid depending on compiler support for 64-bit shift functions. ntdll/tests: Add tests for runtime 64-bit shift functions. ntdll: Fix the calling convention for runtime 64-bit shift functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/375

3 6

[wine-gitlab] Re: [PATCH 0/1] MR379: wined3d: Don't transition GENERAL layouts for blits. - approved
by Jan Sikorski (＠jsikorski) 07 Jul '22

07 Jul '22

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/379

1 0

[wine-gitlab] [PATCH v2 0/7] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) 07 Jul '22

07 Jul '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v2: scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

2 7

[wine-gitlab] Re: [PATCH 0/7] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) 07 Jul '22

07 Jul '22

On Thu Jul 7 06:09:46 2022 +0000, Chip Davis wrote: > What about `'/'`? I know that's a valid separator to the Win32 API. Is > it one to this API? Thanks. '/' is indeed a valid separator. I will create new MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/391#note_3523

1 0

[wine-gitlab] [PATCH v2 0/4] MR395: win32u: Move reading and writing mode from registry out of graphics drivers.
by Rémi Bernon (＠rbernon) 07 Jul '22

07 Jul '22

What was initially in https://gitlab.winehq.org/wine/wine/-/merge_requests/355, with the test failures hopefully fixed. -- v2: win32u: Move writing mode to registry out of graphics drivers. win32u: Move NtUserChangeDisplaySettings mode validation to a separate helper. win32u: Move reading mode from registry out of graphics drivers. win32u: Fix NtUserChangeDisplaySettings comment. https://gitlab.winehq.org/wine/wine/-/merge_requests/395

3 5

[wine-gitlab] [PATCH 0/3] MR395: win32u: Move reading and writing mode from registry out of graphics drivers.
by Rémi Bernon (＠rbernon) 07 Jul '22

07 Jul '22

What was initially in https://gitlab.winehq.org/wine/wine/-/merge_requests/355, with the test failures hopefully fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/395

3 6

[wine-gitlab] Re: [PATCH v6 0/3] MR302: winegstreamer: Some wg_transform H264 fixes for Mortal Kombat 11 and Yakuza 4. - approved
by Nikolay Sivov (＠nsivov) 07 Jul '22

07 Jul '22

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/302

1 0

[wine-gitlab] [PATCH v2 0/2] MR360: Draft: winepulse.drv: add support for containerId property from sysfs path
by Claire (＠ClearlyClaire) 07 Jul '22

07 Jul '22

Some games with support for the haptic feedback and speaker features of the Sony DualSense controller select the controller's audio output by filtering on the ContainerId IMMDevice property to find one that matches the controller's HID's. This MR, together with !359, adds support for exposing such a ContainerId to applications. I marked this MR as a draft because I understand that the way the ��guid�� is generated is far from ideal. Furthermore, I will need to map from sysfs to container Id in other components as well (`winebus` for the HID device, and possibly `winealsa` and other audio drivers), so moving that part elsewhere would make sense. However, I think I will need help with those tasks. -- v2: winepulse: Add support for containerId property from sysfs path winepulse: Store PulseAudio device's sysfs path when available https://gitlab.winehq.org/wine/wine/-/merge_requests/360

2 2

[wine-gitlab] Re: [PATCH 0/4] MR388: d2d1: Introduce D2DERR_NOT_FOUND.
by Nikolay Sivov (＠nsivov) 07 Jul '22

07 Jul '22

Nikolay Sivov (@nsivov) commented about include/d2derr.h: > #ifndef __WINE_D2DERR_H > #define __WINE_D2DERR_H > > +#define D2DERR_NOT_FOUND HRESULT_FROM_WIN32(ERROR_NOT_FOUND) I don't see in 10.0.2200.0 SDK. Where does it come from? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/388#note_3514

1 0

[wine-gitlab] [PATCH 0/2] MR396: dinput/tests: Fix reported test failures.
by Rémi Bernon (＠rbernon) 07 Jul '22

07 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/396

2 2

[wine-gitlab] Re: [PATCH 0/7] MR391: scrrun: Implement MoveFolder().
by Chip Davis (＠cdavis5e) 07 Jul '22

07 Jul '22

Chip Davis (@cdavis5e) commented about dlls/scrrun/filesystem.c: > if((attrs == INVALID_FILE_ATTRIBUTES) || !(attrs & FILE_ATTRIBUTE_DIRECTORY)) > return CTL_E_PATHNOTFOUND; > > + _wsplitpath(source, src_drive, src_dir, file_name, file_ext); > + len = lstrlenW(destination); > + > + if (destination[len-1] == '\\') { What about `'/'`? I know that's a valid separator to the Win32 API. Is it one to this API? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/391#note_3508

1 0

[wine-gitlab] [PATCH 0/2] MR394: d3d8/tests: Build without -DWINE_NO_LONG_TYPES.
by Zebediah Figura (＠zfigura) 07 Jul '22

07 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/394

2 2

[wine-gitlab] Re: [PATCH v3 0/1] MR367: oleaut32 fix - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/367

1 0

[wine-gitlab] [PATCH v3 0/3] MR392: regedit: Code clean-up and invalid read fix
by Hugh McMaster (＠hmc) 06 Jul '22

06 Jul '22

-- v3: regedit: Directly use RegQueryValueExW() instead of a helper function. regedit: Correctly calculate REG_MULTI_SZ size before reading from the buffer. regedit: Remove unneeded valueDataLen override for DWORD values. https://gitlab.winehq.org/wine/wine/-/merge_requests/392

3 4

[wine-gitlab] Re: [PATCH v8 0/3] MR355: win32u: Move more display mode logic out of graphics drivers. - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/355

1 0

[wine-gitlab] Re: [PATCH v15 0/8] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/337

1 0

[wine-gitlab] Re: [PATCH v2 0/2] MR387: uxtheme/tests: Add more GetThemePartSize() tests in different DPI. - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/387

1 0

[wine-gitlab] Re: [PATCH v2 0/1] MR390: secur32: Validate input buffers in schan_InitializeSecurityContextW(). - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/390

1 0

[wine-gitlab] Re: [PATCH v2 0/2] MR386: d3d9/tests: Build without -DWINE_NO_LONG_TYPES. - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/386

1 0

[wine-gitlab] Re: [PATCH 0/3] MR393: wmvcore: Asynchronous reader state transitions.
by Rémi Bernon (＠rbernon) 06 Jul '22

06 Jul '22

I'll have a look at the time failures, I was seeing them locally but not on the testbot run so I assumed they were flukes caused by some decoder differences, looks like it may be something else after all. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/393#note_3477

1 0

[wine-gitlab] Re: [PATCH v6 0/7] MR140: qasf: More ASF reader filter implementation.
by Rémi Bernon (＠rbernon) 06 Jul '22

06 Jul '22

On Wed Jul 6 17:52:44 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 7/6/22 05:08, R��mi Bernon (@rbernon) wrote: > >> So yes, we could not block in IWMReader::Stop(), but that's not > >> ultimately going to help anything. We do still need to wait for the > >> streaming thread to stop at some point. > > > > Well we could then call `Stop` and wait for the WMT_STOPPED callback > notification with a condition variable, releasing the filter_cs so the > callbacks are free to enter it to make the thread-safety obviously correct. > Unfortunately we can't release the filter CS while waiting for the > thread to stop. We need to protect the whole operation. > ``` I opened https://gitlab.winehq.org/wine/wine/-/merge_requests/393#note_3473 to make WM async reader state transitions asynchronous, so that we can then do the right thing here and wait for the callback notifications while entering the CS and avoiding the deadlock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/140#note_3475

1 0

2025

2024

2023

2022

wine-gitlab