- wine-gitlab - winehq.org

Re: [PATCH v2 0/4] MR503: server: Properly implement AFD_POLL_RESET. - approved
by Alexandre Julliard (＠julliard) 25 Jul '22

25 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/503

1 0

[PATCH 0/3] MR523: ntdll: Fixup the RtlWalkHeap entry pointer before subheap lookup.
by Rémi Bernon (＠rbernon) 25 Jul '22

25 Jul '22

This should do the same thing as https://gitlab.winehq.org/wine/wine/-/merge_requests/425. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/523

3 4

Re: [PATCH v2 0/1] MR1: vkd3d-shader: Initialize counter_var_info unconditionally. - approved
by Alexandre Julliard (＠julliard) 25 Jul '22

25 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1

1 0

[PATCH 0/1] MR518: d3drm: Fix components of palette when loading texture from 8-bit BMP file.
by Jeffrey Smith (＠whydoubt) 25 Jul '22

25 Jul '22

Previous fix took care of palette created from 24bpp BMP. I found that loading the palette from a 8bpp BMP also needed fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/518

3 2

[PATCH 0/1] MR517: xactengine3_7: Remove Entry after FAudio Destroyed call
by Alistair Leslie-Hughes (＠alesliehughes) 25 Jul '22

25 Jul '22

FACTWaveBank_Destroy will invoke the callback which we attempt to lookup the wavebank. The callback must have a pointer, help states it isn't valid but still points to the wavebank that was destroyed. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/517

3 2

[PATCH 0/3] MR524: dwrite: Add a few more fallback ranges.
by Nikolay Sivov (＠nsivov) 25 Jul '22

25 Jul '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/524

2 4

[PATCH v2 0/10] MR487: mshtml events improvements
by Gabriel Ivăncescu (＠insn) 25 Jul '22

25 Jul '22

Some notes for the loaded/total props for ProgressEvent: they are todo_wine for loadend initially because wine-gecko is never informed of OnProgress, but the last commit fixes this. It's placed last so that its effects can be shown. Also, if it wasn't deferred until OnDataAvailable, it would assume it's for uploading state, because it's OnStartRequest on gecko's XHR that changes the state... -- v2: mshtml: Inform Gecko of progress done via OnProgress. mshtml: Implement ProgressEvent's total prop. mshtml: Implement ProgressEvent's loaded prop. mshtml: Implement ProgressEvent's lengthComputable prop. mshtml: Fix copy-paste mistake in test message. mshtml: Remove FIXME comment from MessageEvent in event_types. mshtml: Allocate Keyboard events via the types table. mshtml: Allocate Mouse events via the types table. mshtml: Allocate UI events via the types table. mshtml: Use a table to construct the different event types by their interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/487

3 15

[PATCH v3 0/7] MR507: dinput: Properly expose dials.
by Arek Hiler (＠ivyl) 25 Jul '22

25 Jul '22

Throttle that comes with Thrustmaster T16000M FCS has a dial that doesn't work / is usassignable in many games (e.g. Elite Dangerous). Returning correct GUID and name would be enough but it breaks the tests due to some quirks of the default format so that is also fixed. -- v3: dinput/tests: Test GetObjectInfo() with three sliders and a proper format. https://gitlab.winehq.org/wine/wine/-/merge_requests/507

3 8

[PATCH v3 0/1] MR477: d3drm/tests: Show Clear sets background color
by Alistair Leslie-Hughes (＠alesliehughes) 25 Jul '22

25 Jul '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v3: d3drm/tests: Show Clear sets background color https://gitlab.winehq.org/wine/wine/-/merge_requests/477

4 3

[PATCH v2 0/7] MR507: dinput: Properly expose dials.
by Arek Hiler (＠ivyl) 25 Jul '22

25 Jul '22

Throttle that comes with Thrustmaster T16000M FCS has a dial that doesn't work / is usassignable in many games (e.g. Elite Dangerous). Returning correct GUID and name would be enough but it breaks the tests due to some quirks of the default format so that is also fixed. -- v2: dinput/tests: Test GetObjectInfo() with three sliders and a proper format. dinput/tests: Assert that we can't get info about the third slider with c_dfDIJoystick2. dinput: Use GUID_Slider type for dials. dinput: Enumerate user format object forwards. dinput/tests: Use helper for checking device object instances. dinput: Get rid of unused parameter in match_device_object. dinput: Set correct object names for dials and sliders. https://gitlab.winehq.org/wine/wine/-/merge_requests/507

3 9

[PATCH v4 0/2] MR289: d3drm: Implement IDirect3DRMFrame2::SetSceneBackgroundImage
by Alistair Leslie-Hughes (＠alesliehughes) 25 Jul '22

25 Jul '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v4: d3drm: Implement IDirect3DRMViewport Render d3drm: Implement IDirect3DRMFrame{1/2/3}::SetSceneBackgroundImage https://gitlab.winehq.org/wine/wine/-/merge_requests/289

3 5

[PATCH 0/3] MR522: regedit: Further clean-ups for modifying registry value data
by Hugh McMaster (＠hmc) 25 Jul '22

25 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/522

2 3

[PATCH 0/8] MR507: dinput: Properly expose dials.
by Arek Hiler (＠ivyl) 25 Jul '22

25 Jul '22

Throttle that comes with Thrustmaster T16000M FCS has a dial that doesn't work / is usassignable in many games (e.g. Elite Dangerous). Returning correct GUID and name would be enough but it breaks the tests due to some quirks of the default format so that is also fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/507

3 14

[PATCH 0/1] MR1: vkd3d-shader: Initialize counter_var_info unconditionally.
by Stefan Dösinger (＠stefan) 25 Jul '22

25 Jul '22

--- It is only set if certain shader properties are met, and Visual Studio rightfully complains that we read an uninitialized variable later. Maybe resource_symbol.info.resource.uav_counter_array is never used later on, but it still is bad style to propagate uninitialized values. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1

3 2

[PATCH v11 0/5] MR432: Add support for SPDRP_BASE_CONTAINERID by querying drivers with BusQueryContainerID
by Claire (＠ClearlyClaire) 25 Jul '22

25 Jul '22

This is the hidclass/ntoskrnl/setupapi counterpart to !359. As with that merge request, implementing `BusQueryContainerID` in the bus driver is left out and will be addressed in a different MR. I believe this is useful to expose the Container ID no matter how those end up being assigned by the bus driver. -- v11: ntoskrnl: Set device ContainerID from driver. hidclass: Expose ContainerID from underlying driver. hidclass: Improve error handling in get_device_id. ntoskrnl/tests: Add test for getting SPDRP_BASE_CONTAINERID from PnP driver. setupapi: Add support for SPDRP_BASE_CONTAINERID. https://gitlab.winehq.org/wine/wine/-/merge_requests/432

3 6

[PATCH 0/2] MR485: riched20: Ensure that cursor is visible when selecting text.
by Santino Mazza (＠tati1454) 25 Jul '22

25 Jul '22

This mr fixes https://bugs.winehq.org/show_bug.cgi?id=40444 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/485

3 3

[PATCH 0/2] MR494: Let programs/winedbg use CRT allocation functions
by eric pouech (＠epo) 25 Jul '22

25 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/494

3 4

[PATCH 0/3] MR510: uiautomationcore: Add support for more UI Automation property types.
by Connor McAdams (＠cmcadams) 25 Jul '22

25 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/510

3 4

[PATCH 0/7] MR519: win32u: syscall conversion
by Jacek Caban (＠jacek) 25 Jul '22

25 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/519

3 8

[PATCH v10 0/7] MR432: Add support for SPDRP_BASE_CONTAINERID by querying drivers with BusQueryContainerID
by Claire (＠ClearlyClaire) 25 Jul '22

25 Jul '22

This is the hidclass/ntoskrnl/setupapi counterpart to !359. As with that merge request, implementing `BusQueryContainerID` in the bus driver is left out and will be addressed in a different MR. I believe this is useful to expose the Container ID no matter how those end up being assigned by the bus driver. -- v10: ntoskrnl: Set device ContainerID from driver hidclass: Expose ContainerID hidclass: Copy device ContainerID to child devices hidclass: Copy ContainerID from underlying driver in driver_add_device hidclass: Improve error handling in get_device_id ntoskrnl/tests: Add test for getting SPDRP_BASE_CONTAINERID from PnP driver setupapi: Add support for SPDRP_BASE_CONTAINERID https://gitlab.winehq.org/wine/wine/-/merge_requests/432

4 12

[PATCH 0/3] MR484: Misc tweaks for the tests
by Francois Gouget (＠fgouget) 25 Jul '22

25 Jul '22

Signed-off-by: Francois Gouget <fgouget(a)free.fr> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/484

3 4

[PATCH 0/5] MR520: include: Allow printing test failure messages in color.
by Zebediah Figura (＠zfigura) 25 Jul '22

25 Jul '22

Gated behind a boolean environment variable WINETEST_COLOR for the moment (default off). I've experimented with this locally for a while, and I've found it helps me immensely when looking for a specific kind of message. Too often failure or succeeded-inside-todo messages get buried among todo messages, WINEDEBUG output, or (in the case of some badly written test units) trace() output, but this has also helped me check whether there are any todo and skip messages, in cases where I want to make sure that one or the other doesn't show up. I'm quite open to bikeshedding :-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/520

3 5

[PATCH v2 0/2] MR500: ntdll: Allow changes to DEP flags under Wow64.
by Brendan Shanks (＠bshanks) 24 Jul '22

24 Jul '22

Under Wow64, disabling no-exec (done at the bottom of `alloc_module`) was failing. Fixes crashes in games using older Steam DRM (where the EXE entry point is in a '.bind' section which is not marked executable) -- v2: wow64: Allow setting NtSetInformationProcess(ProcessExecuteFlags). ntdll: Allow changes to DEP flags under Wow64. https://gitlab.winehq.org/wine/wine/-/merge_requests/500

2 2

Re: [PATCH v4 0/1] MR105: winegstreamer: reintroduce flushing for wg_parser - closed
by Alexandre Julliard (＠julliard) 23 Jul '22

23 Jul '22

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/105

1 0

Re: [PATCH v4 0/1] MR105: winegstreamer: reintroduce flushing for wg_parser
by Alexandre Julliard (＠julliard) 23 Jul '22

23 Jul '22

I'd suggest filing a bug for this, if there isn't one already. A merge request is not the right place for that kind of information. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/105#note_4805

1 0

Re: [PATCH v4 0/1] MR105: winegstreamer: reintroduce flushing for wg_parser
by zlice (＠zlice) 23 Jul '22

23 Jul '22

Just an update, 7.13 compile times almost halved, awesome! But audio studder is worse, sat for almost a minute loading a save file. Patching with this makes everything smooth again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/105#note_4804

1 0

[PATCH 0/1] MR515: webservices: Handle in/out parameters properly in WsCall.
by Shaun Ren (＠shaunren) 23 Jul '22

23 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/515

2 1

Re: [PATCH v2 0/1] MR514: user32: Remove some dead code from unpack_dde_message() (Coverity). - approved
by Alexandre Julliard (＠julliard) 22 Jul '22

22 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/514

1 0

Re: [PATCH v2 0/1] MR513: win32u: Remove some dead code from get_scroll_range() helper (Coverity). - approved
by Alexandre Julliard (＠julliard) 22 Jul '22

22 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/513

1 0

Re: [PATCH v2 0/1] MR512: d2d1/tests: Add a missing return value test (Coverity). - approved
by Alexandre Julliard (＠julliard) 22 Jul '22

22 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/512

1 0

Re: [PATCH v2 0/1] MR501: wined3d: Redirect vkd3d log output to the Unix stderr. - approved
by Alexandre Julliard (＠julliard) 22 Jul '22

22 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/501

1 0

Re: [PATCH v3 0/3] MR495: wined3d: Do not try to unmap already unmapped BOs. - approved
by Alexandre Julliard (＠julliard) 22 Jul '22

22 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/495

1 0

Re: [PATCH v2 0/1] MR506: d3d11: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 22 Jul '22

22 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/506

1 0

Re: [PATCH v2 0/10] MR505: dwrite: Improvements to font fallback implementation. - approved
by Alexandre Julliard (＠julliard) 22 Jul '22

22 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/505

1 0

Re: [PATCH v2 0/9] MR508: win32u: syscall conversion - approved
by Alexandre Julliard (＠julliard) 22 Jul '22

22 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/508

1 0

[PATCH v6 0/5] MR464: Implement _StructuredTaskCollection::_Schedule{,_loc}
by Torge Matthies (＠tmatthies) 22 Jul '22

22 Jul '22

- Based on !463 - _RunAndWait and exception handling implemented in later commits @piotr -- v6: msvcr100: Implement _StructuredTaskCollection::_Schedule and _Schedule_loc. msvcr100: Factor out the mapping of a context to a scheduler. msvcr100: Cache one Context instance. msvcr100: Factor out EXCEPTION_RECORD to exception_ptr conversion. msvcr100: Move exception_ptr functions to a separate file. https://gitlab.winehq.org/wine/wine/-/merge_requests/464

3 14

[PATCH 0/1] MR514: user32: Remove some dead code from unpack_dde_message() (Coverity).
by Nikolay Sivov (＠nsivov) 22 Jul '22

22 Jul '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/514

2 1

[PATCH 0/1] MR513: win32u: Remove some dead code from get_scroll_range() helper (Coverity).
by Nikolay Sivov (＠nsivov) 22 Jul '22

22 Jul '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/513

2 1

[PATCH 0/1] MR512: d2d1/tests: Add a missing return value test (Coverity).
by Nikolay Sivov (＠nsivov) 22 Jul '22

22 Jul '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/512

2 2

[PATCH 0/3] MR511: webservices: Support error strings and faults in error.
by Shaun Ren (＠shaunren) 22 Jul '22

22 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/511

2 3

[PATCH 0/1] MR506: d3d11: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 22 Jul '22

22 Jul '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/506

3 2

[PATCH 0/1] MR500: ntdll: Allow changes to DEP flags under Wow64.
by Brendan Shanks (＠bshanks) 22 Jul '22

22 Jul '22

Under Wow64, disabling no-exec (done at the bottom of `alloc_module`) was failing. Fixes crashes in games using older Steam DRM (where the EXE entry point is in a '.bind' section which is not marked executable) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/500

4 4

[PATCH 0/10] MR505: dwrite: Improvements to font fallback implementation.
by Nikolay Sivov (＠nsivov) 22 Jul '22

22 Jul '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/505

2 11

[PATCH v2 0/1] MR499: Draft: server: Allow cancelling alerted asyncs.
by Jinoh Kang (＠iamahuman) 22 Jul '22

22 Jul '22

-- v2: server: Allow cancelling alerted asyncs. https://gitlab.winehq.org/wine/wine/-/merge_requests/499

3 2

[PATCH 0/1] MR509: winevulkan: Fill LUID info in VkPhysicalDeviceVulkan11Properties.
by Philip Rebohle (＠doitsujin) 22 Jul '22

22 Jul '22

Signed-off-by: Philip Rebohle <philip.rebohle(a)tu-dortmund.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/509

2 1

[PATCH 0/9] MR508: win32u: syscall conversion
by Jacek Caban (＠jacek) 22 Jul '22

22 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/508

3 10

[PATCH v5 0/5] MR464: Implement _StructuredTaskCollection::_Schedule{,_loc}
by Torge Matthies (＠tmatthies) 22 Jul '22

22 Jul '22

- Based on !463 - _RunAndWait and exception handling implemented in later commits @piotr -- v5: msvcr100: Implement _StructuredTaskCollection::_Schedule and _Schedule_loc. msvcr100: Factor out the mapping of a context to a scheduler. msvcr100: Cache one Context instance. msvcr100: Factor out EXCEPTION_RECORD to exception_ptr conversion. msvcr100: Move exception_ptr functions to a separate file. https://gitlab.winehq.org/wine/wine/-/merge_requests/464

2 5

[PATCH v4 0/5] MR464: Implement _StructuredTaskCollection::_Schedule{,_loc}
by Torge Matthies (＠tmatthies) 22 Jul '22

22 Jul '22

- Based on !463 - _RunAndWait and exception handling implemented in later commits @piotr -- v4: msvcr100: Implement _StructuredTaskCollection::_Schedule and _Schedule_loc. msvcr100: Factor out the mapping of a context to a scheduler. msvcr100: Cache one Context instance. msvcr100: Factor out EXCEPTION_RECORD to exception_ptr conversion. msvcr100: Move exception_ptr functions to a separate file. https://gitlab.winehq.org/wine/wine/-/merge_requests/464

2 5

[PATCH 0/4] MR503: server: Properly implement AFD_POLL_RESET.
by Zebediah Figura (＠zfigura) 22 Jul '22

22 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/503

2 4

[PATCH 0/5] MR438: winusb: Add WinUsb_Free stub.
by Mohamad Al-Jaf (＠maljaf) 22 Jul '22

22 Jul '22

The program REVELPROG_IS runs with this patchset. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/438

2 10

Re: [PATCH v2 0/4] MR497: regedit: Use 'struct edit_params' when reading registry values and modifying data - approved
by Alexandre Julliard (＠julliard) 21 Jul '22

21 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/497

1 0

Re: [PATCH v3 0/9] MR493: win32u: exception handling improvements and syscall conversion - approved
by Alexandre Julliard (＠julliard) 21 Jul '22

21 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/493

1 0

Re: [PATCH v2 0/6] MR488: uiautomationcore: Add support for retrieving properties from HUIANODEs. - approved
by Alexandre Julliard (＠julliard) 21 Jul '22

21 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/488

1 0

Re: [PATCH v2 0/4] MR496: server: Try to improve error handling. - approved
by Alexandre Julliard (＠julliard) 21 Jul '22

21 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/496

1 0

Re: [PATCH v3 0/2] MR486: d3drm: Fix components of palette built when loading texture from file. - approved
by Alexandre Julliard (＠julliard) 21 Jul '22

21 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/486

1 0

[PATCH 0/1] MR501: wined3d: Redirect vkd3d log output to the Unix stderr.
by Zebediah Figura (＠zfigura) 21 Jul '22

21 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/501

2 1

[PATCH 0/8] MR492: Enhancements for C++ symbols undecoration
by eric pouech (＠epo) 21 Jul '22

21 Jul '22

This series implements a couple of enhancements to symbol undecoration in msvcrt: - more C++ constructs are correctly supported (pointer to member, constructors/destructors from template class, non-type function pointer template parameter...) - some internal cleanups & simplification (most of them based on revamped helper to build up the undecorated C++ symbols) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/492

3 20

[PATCH v2 0/3] MR495: wined3d: Do not try to unmap already unmapped BOs.
by Zebediah Figura (＠zfigura) 21 Jul '22

21 Jul '22

This will silently succeed, and incorrectly unmap chunks which are still in use. v2: Add bug link. -- v2: wined3d: Assert that the BO is mapped in unmap functions. wined3d: Do not try to unmap already unmapped BOs in wined3d_texture_update_sub_resource(). wined3d: Do not try to unmap already unmapped BOs in wined3d_buffer_update_sub_resource(). https://gitlab.winehq.org/wine/wine/-/merge_requests/495

2 3

[PATCH 0/1] MR499: Draft: server: Allow cancelling alerted asyncs.
by Jinoh Kang (＠iamahuman) 21 Jul '22

21 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/499

2 1

[PATCH 0/9] MR487: mshtml events improvements
by Gabriel Ivăncescu (＠insn) 21 Jul '22

21 Jul '22

Some notes for the loaded/total props for ProgressEvent: they are todo_wine for `loadend` because wine-gecko returns them as 0 instead of their actual values. This is an issue in wine-gecko's nsXMLHttpRequest where OnProgress never gets called in some cases (such as our tests in xhr.js), so it needs a fix on gecko side. [This MR](https://gitlab.winehq.org/wine/wine-gecko/-/merge_requests/7) in wine-gecko solves that issue (the first commit), but it needs to remain todo_wine until next release. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/487

4 15

[PATCH 0/4] MR497: regedit: Use 'struct edit_params' when reading registry values and modifying data
by Hugh McMaster (＠hmc) 21 Jul '22

21 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/497

2 4

[PATCH v2 0/9] MR493: win32u: exception handling improvements and syscall conversion
by Jacek Caban (＠jacek) 21 Jul '22

21 Jul '22

win32u is mostly ready for using syscall interface (for functions not taking HDC as an argument), but using client callbacks from syscalls will affect ability to unwind exceptions in a number of cases. On Windows, depending on kernel version, there are three different behaviors: (1) On 32-bit Windows kernels unwinding works across client callbacks. (2) On early 64-bit Windows kernels exceptions from client callbacks are filtered and ignored. (3) On recent Windows kernels exceptions from client callbacks are treated as unhandled exceptions. (1) is tempting because that's closest to how our pre-syscall code works. I prototyped that and I think we could make it work, but it's an additional complication to syscall interface that didn't really feel worth comparing to other options. ntdll part of this MR implements (2). I think we would ideally use (3) instead, but it's much more risky (and syscall conversion seems risky enough on its own). Microsoft incrementally transitioned from (2) to (3) with some compatibility mitigations involved. On top of that, some user32 calls that have win32u counterpars are still unwindable, unlike win32u variants. For example, DispatchMessageW behaves identical to NtUserDispatchMessage, except that it allow unwinding through the call, which suggests that the final call to window proc is done directly by user32, without kernel->client callback. SendMessage is also sometimes unwindable, but only when doing trivial winproc calls (but things like installing hook change that). -- v2: win32u: Get rid of no longer needed NtUserSetCallbacks. win32u: Use syscall interface for NtUserMessageCall and NtUserTrackPopupMenuEx. win32u: Use syscall interface for NtUserMsgWaitForMultipleObjectsEx. win32u/tests: Add tests for catching exceptions from timer proc. win32u: Use syscall interface for NtUserDispatchMessage. ntdll: Suppress callback exceptions in KiUserCallbackDispatcher. win32u: Avoid using client callbacks for NtUserSendMessage. win32u: Remove no longer needed NtUserDispatchMessageA. user32: Avoid using NtUserDispatchMessage in DispatchMessage. https://gitlab.winehq.org/wine/wine/-/merge_requests/493

2 10

[PATCH 0/6] MR488: uiautomationcore: Add support for retrieving properties from HUIANODEs.
by Connor McAdams (＠cmcadams) 21 Jul '22

21 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/488

3 9

[PATCH v7 0/8] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) 21 Jul '22

21 Jul '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v7: scrrun: Move directories only in MoveFolder(). scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

3 11

[PATCH 0/4] MR496: server: Try to improve error handling.
by Zebediah Figura (＠zfigura) 20 Jul '22

20 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/496

2 4

Re: [PATCH v2 0/4] MR491: server: Various socket patches. - approved
by Alexandre Julliard (＠julliard) 20 Jul '22

20 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/491

1 0

Re: [PATCH v4 0/1] MR489: jscript: return ParseProcedureText when compile fails. - approved
by Alexandre Julliard (＠julliard) 20 Jul '22

20 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/489

1 0

Re: [PATCH v3 0/3] MR490: include: Add IMediaParamInfo definition. - approved
by Alexandre Julliard (＠julliard) 20 Jul '22

20 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/490

1 0

Re: [PATCH v3 0/5] MR481: server: Use the token owner instead of the token user for default object owner. - approved
by Alexandre Julliard (＠julliard) 20 Jul '22

20 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/481

1 0

Re: [PATCH v2 0/2] MR486: d3drm: Fix components of palette built when loading texture from file. - approved
by Zebediah Figura (＠zfigura) 20 Jul '22

20 Jul '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/486

1 0

[PATCH 0/9] MR493: win32u: exception handling improvements and syscall conversion
by Jacek Caban (＠jacek) 20 Jul '22

20 Jul '22

win32u is mostly ready for using syscall interface (for functions not taking HDC as an argument), but using client callbacks from syscalls will affect ability to unwind exceptions in a number of cases. On Windows, depending on kernel version, there are three different behaviors: (1) On 32-bit Windows kernels unwinding works across client callbacks. (2) On early 64-bit Windows kernels exceptions from client callbacks are filtered and ignored. (3) On recent Windows kernels exceptions from client callbacks are treated as unhandled exceptions. (1) is tempting because that's closest to how our pre-syscall code works. I prototyped that and I think we could make it work, but it's an additional complication to syscall interface that didn't really feel worth comparing to other options. ntdll part of this MR implements (2). I think we would ideally use (3) instead, but it's much more risky (and syscall conversion seems risky enough on its own). Microsoft incrementally transitioned from (2) to (3) with some compatibility mitigations involved. On top of that, some user32 calls that have win32u counterpars are still unwindable, unlike win32u variants. For example, DispatchMessageW behaves identical to NtUserDispatchMessage, except that it allow unwinding through the call, which suggests that the final call to window proc is done directly by user32, without kernel->client callback. SendMessage is also sometimes unwindable, but only when doing trivial winproc calls (but things like installing hook change that). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/493

4 11

[PATCH 0/3] MR495: wined3d: Do not try to unmap already unmapped BOs.
by Zebediah Figura (＠zfigura) 20 Jul '22

20 Jul '22

This will silently succeed, and incorrectly unmap chunks which are still in use. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/495

2 3

Re: [PATCH v3 0/1] MR489: jscript: return ParseProcedureText when compile fails. - approved
by Jacek Caban (＠jacek) 20 Jul '22

20 Jul '22

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/489

1 0

[PATCH v2 0/3] MR490: include: Add IMediaParamInfo definition.
by Zhiyi Zhang (＠zhiyi) 20 Jul '22

20 Jul '22

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- v2: dsdmo: Add IMediaParamInfo stub interface. dsdmo/tests: Add IMediaParamInfo tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/490

3 4

[PATCH v2 0/1] MR352: cmd: Don't loop infinitely on NUL.
by Arek Hiler (＠ivyl) 20 Jul '22

20 Jul '22

-- v2: cmd: Don't loop infinitely on NUL. https://gitlab.winehq.org/wine/wine/-/merge_requests/352

3 5

[PATCH v2 0/5] MR481: server: Use the token owner instead of the token user for default object owner.
by Jinoh Kang (＠iamahuman) 20 Jul '22

20 Jul '22

This fixes Amazon Games not launching due to pipe client identity check in https://github.com/dotnet/runtime/blob/371905898f2c036cc30d662e8a6df162a219…. -- v2: server: Use the token owner instead of the token user for default object owner. advapi32/tests: Test that the token default DACL uses token owner instead of token user. advapi32/tests: Test that default object group match the token primary group. advapi32/tests: Test that default object owner match the token owner. advapi32/tests: Check that each ACE is ACCESS_ALLOWED_ACE in the default DACL. https://gitlab.winehq.org/wine/wine/-/merge_requests/481

2 6

[PATCH v3 0/3] MR418: mfplat: Support and test YV12, I410 and IYUV image formats.
by Giovanni Mascellani (＠giomasce) 20 Jul '22

20 Jul '22

-- v3: mfplat/tests: Merge and reorganize image format tests. mfplat/buffer: Support YV12, I420 and IYUV image formats. mfplat/tests: Mark some tests as broken on Win 8 and 10 v1507. https://gitlab.winehq.org/wine/wine/-/merge_requests/418

2 3

[PATCH 0/3] MR490: include: Add IMediaParamInfo definition.
by Zhiyi Zhang (＠zhiyi) 20 Jul '22

20 Jul '22

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/490

3 4

[PATCH 0/4] MR491: server: Various socket patches.
by Zebediah Figura (＠zfigura) 20 Jul '22

20 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/491

2 4

[PATCH 0/1] MR489: jscript: return ParseProcedureText when compile fails.
by Santino Mazza (＠tati1454) 20 Jul '22

20 Jul '22

This prevents crashes when there is an invalid script inside a tag property. Because ParseProcedureText calls release_bytecode without checking if compile_script failed, "code" is not set, and this leads to a crash when release_bytecode tries to access it. To reproduce the bug you can create an html file and create a tag with a property having invalid JS in it. For example: ``` <script onerror="alert("></script> ``` Then you just open this file with iexplore. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/489

2 1

[PATCH v9 0/7] MR432: Add support for SPDRP_BASE_CONTAINERID by querying drivers with BusQueryContainerID
by Claire (＠ClearlyClaire) 19 Jul '22

19 Jul '22

This is the hidclass/ntoskrnl/setupapi counterpart to !359. As with that merge request, implementing `BusQueryContainerID` in the bus driver is left out and will be addressed in a different MR. I believe this is useful to expose the Container ID no matter how those end up being assigned by the bus driver. -- v9: ntoskrnl: Set device ContainerID from driver hidclass: Expose ContainerID hidclass: Copy device ContainerID to child devices hidclass: Copy ContainerID from underlying driver in driver_add_device hidclass: Improve error handling in get_device_id ntoskrnl/tests: Add test for getting SPDRP_BASE_CONTAINERID from PnP driver setupapi: Add support for SPDRP_BASE_CONTAINERID https://gitlab.winehq.org/wine/wine/-/merge_requests/432

3 12

Re: [PATCH v2 0/3] MR353: shell32 improvements (fix $* wrongly quoted, allow file extensions as classname and verb "runas" to work) - approved
by Alexandre Julliard (＠julliard) 19 Jul '22

19 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/353

1 0

Re: [PATCH v2 0/3] MR457: ntdll/tests: Add RtlFirstFreeAce tests - approved
by Alexandre Julliard (＠julliard) 19 Jul '22

19 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/457

1 0

Re: [PATCH v2 0/5] MR472: server: Do not set connectionless sockets into the CONNECTING or CONNECTED state. - approved
by Alexandre Julliard (＠julliard) 19 Jul '22

19 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/472

1 0

Re: [PATCH v3 0/5] MR471: uiautomationcore: Implement Property ID GUIDs and UiaNodeFromProvider. - approved
by Alexandre Julliard (＠julliard) 19 Jul '22

19 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/471

1 0

[PATCH 0/1] MR400: shell32: Fix handling of very long URLs
by SmallJoker (＠SmallJoker) 19 Jul '22

19 Jul '22

Move from stack to heap allocations where needed to avoid out-of-bounds writes resulting in stack corruptions caused by strcpy/strcat and alike. Tested using `wine shell32_test.exe.so shlexec` (64-bit only). Expected output: `0020:shlexec: 1724 tests executed (43 marked as todo, 0 failures), 0 skipped.` This change is based on https://www.winehq.org/pipermail/wine-devel/2021-May/187791.html and fixes some of the missing bounds checks in this file. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/400

2 3

[PATCH 0/2] MR486: d3drm: Fix components of palette built when loading texture from file.
by Jeffrey Smith (＠whydoubt) 19 Jul '22

19 Jul '22

IDirect3DTexture::InitFromFile attempts to create a palette-based image, but currently it is flipping the red and blue components of the palette. This MR fixes this in both test and code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/486

2 2

Testing the encoding of the mailman list
by Jeremy White 19 Jul '22

19 Jul '22

Hi all, Please ignore; I'm just puzzled by a behavior of the gitlabtomail script, and want to isolate where blame goes. That is, MR485 came through with charset of ascii and I felt it should have been utf-8. I'm sure it's my fault, just need to figure out *how* I screwed up. Cheers, Jeremy

1 0

[PATCH v2 0/1] MR477: d3drm/tests: Show Clear sets background color
by Alistair Leslie-Hughes (＠alesliehughes) 19 Jul '22

19 Jul '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v2: d3drm/tests: Show Clear sets background color https://gitlab.winehq.org/wine/wine/-/merge_requests/477

3 3

[PATCH v6 0/2] MR419: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.
by Giovanni Mascellani (＠giomasce) 19 Jul '22

19 Jul '22

-- v6: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows. user32/tests: Check that message-only windows ignore WS_EX_TOPMOST. https://gitlab.winehq.org/wine/wine/-/merge_requests/419

2 3

[PATCH v2 0/5] MR471: uiautomationcore: Implement Property ID GUIDs and UiaNodeFromProvider.
by Connor McAdams (＠cmcadams) 19 Jul '22

19 Jul '22

These patches are the beginning of adding support for the UI Automation client API. -- v2: uiautomationcore: Implement UiaNodeRelease. uiautomationcore: Implement UiaNodeFromProvider. uiautomationcore: Add stub UiaGetPropertyValue implementation. uiautomationcore: Implement UiaLookupId for AutomationIdentifierType_Property GUIDs. https://gitlab.winehq.org/wine/wine/-/merge_requests/471

3 7

Re: [PATCH v2 0/5] MR478: Assorted spelling fixes - approved
by Alexandre Julliard (＠julliard) 18 Jul '22

18 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/478

1 0

Re: [PATCH v2 0/2] MR479: advapi32:registry and urlmon:url tweaks - approved
by Alexandre Julliard (＠julliard) 18 Jul '22

18 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/479

1 0

[PATCH v2 0/1] MR460: shell32: Return stub bitmap in IShellItemImageFactory::GetImage. (#52673)
by Jinoh Kang (＠iamahuman) 18 Jul '22

18 Jul '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52673 -- v2: shell32: Return stub bitmap in IShellItemImageFactory::GetImage. https://gitlab.winehq.org/wine/wine/-/merge_requests/460

3 2

Re: [PATCH v8 0/3] MR398: xactengine3_7/tests: Test notifications when loading a wave bank. - approved
by Alexandre Julliard (＠julliard) 18 Jul '22

18 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/398

1 0

Re: [PATCH v3 0/2] MR455: rpcrt4/tests: Add I_RpcBindingInqLocalClientPID() tests. - approved
by Alexandre Julliard (＠julliard) 18 Jul '22

18 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/455

1 0

Re: [PATCH v2 0/1] MR480: kernel32/tests: Test deletion of synchronization objects after handle close. - approved
by Alexandre Julliard (＠julliard) 18 Jul '22

18 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/480

1 0

Re: [PATCH v2 0/3] MR473: Minor Task Scheduler improvements - approved
by Alexandre Julliard (＠julliard) 18 Jul '22

18 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/473

1 0

Re: [PATCH v2 0/1] MR476: advapi32/tests: Add tests for GetTokenInformation TokenOwner. - approved
by Alexandre Julliard (＠julliard) 18 Jul '22

18 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/476

1 0

Re: [PATCH v4 0/5] MR470: Enhance C++ undecoration - approved
by Alexandre Julliard (＠julliard) 18 Jul '22

18 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/470

1 0

2025

2024

2023

2022

wine-gitlab