- wine-gitlab - winehq.org

[PATCH v2 0/1] MR8179: crypt32: Fix invalid access of list head.
by Yuxuan Shui (＠yshui) 30 May '25

30 May '25

At the end of LIST_FOR_EACH_ENTRY, assuming no matches are found, `provider` will point to the list head, not NULL, as a result we call IsEqualGUID on invalid memory. -- v2: crypt32: Fix invalid access of list head. https://gitlab.winehq.org/wine/wine/-/merge_requests/8179

2 1

[PATCH v4 0/2] MR7920: winecoreaudio: revert unix_set_volumes
by Ada Ahmed (＠yretenai) 30 May '25

30 May '25

I was able to replicate the issue seen in [Bug 58113](https://bugs.winehq.org/show_bug.cgi?id=58113) on my M1. The issue stems from the usage of AudioDevicePropertyVolumeScalar, which the audio driver for the M1 does not support (at least so it appears.) Using AudioObjectIsPropertySettable allows for fast checking for this situation, including preemptively disabling main channel audio if it appears to be unsupported. -- v4: winecoreaudio: quality improvements Revert "winecoreaudio: Implement per-channel volume control." https://gitlab.winehq.org/wine/wine/-/merge_requests/7920

2 3

[PATCH v6 0/3] MR8095: server: Update full window invalidate rect with window resize.
by Rémi Bernon (＠rbernon) 30 May '25

30 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58210 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38975 Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/8013 -- v6: server: Update fill window invalidate rect with window resize. server: Pass NULL as child region if region is NULL. https://gitlab.winehq.org/wine/wine/-/merge_requests/8095

4 8

[PATCH 0/1] MR8178: user32: Fix the number of characters processed by DrawTextExW.
by JiangYi Chen (＠meshine) 30 May '25

30 May '25

@alexhenrie @zhiyi Description: When flags does not include DT_CALCRECT, since len is calculated in the middle, it will be reduced to zero. Resulting in the length of the processed string that is finally returned to zero and the non-processing string length is unchanged. But some application taking the non-processing string length to zero as the loop end condition. The test case's merge request number is 8177. Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8178

2 1

[PATCH 0/1] MR8177: user32/tests: Add tests for DrawTextExW.
by JiangYi Chen (＠meshine) 30 May '25

30 May '25

@alexhenrie @zhiyi The corresponding Windows test demo is as follows: [test_DrawTextExW.exe](/uploads/ff1eafc9c58ac03b598699a93136484c/test_DrawTextExW.exe) [test_DrawTextExW.c](/uploads/a41719a33c2ee0e057c911933bf55180/test_DrawTextExW.c) Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: I64052ba8aa8161ad83c1811d642aedbe462ef5ea -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8177

2 1

[PATCH v2 0/2] MR8172: mfreadwrite: Fix media type output when video processor is used.
by Brendan McGrath (＠redmcg) 30 May '25

30 May '25

This is required to fix video playback in Crashlands 2 on Proton 10. -- v2: mfreadwrite: Fix media type output when video processor is used. mfreadwrite/tests: Check DEFAULT_STRIDE is not always present. https://gitlab.winehq.org/wine/wine/-/merge_requests/8172

2 3

[PATCH v3 0/2] MR7920: winecoreaudio: revert unix_set_volumes
by Ada Ahmed (＠yretenai) 29 May '25

29 May '25

I was able to replicate the issue seen in [Bug 58113](https://bugs.winehq.org/show_bug.cgi?id=58113) on my M1. The issue stems from the usage of AudioDevicePropertyVolumeScalar, which the audio driver for the M1 does not support (at least so it appears.) Using AudioObjectIsPropertySettable allows for fast checking for this situation, including preemptively disabling main channel audio if it appears to be unsupported. -- v3: winecoreaudio: Fixed outdated params, improvements Revert "winecoreaudio: Implement per-channel volume control." https://gitlab.winehq.org/wine/wine/-/merge_requests/7920

3 4

Re: [PATCH v3 0/2] MR7880: combase: Fix refcount leak fix in apartment_hostobject
by Kevin Puetz (＠puetzk) 29 May '25

29 May '25

On Tue Apr 22 19:17:10 2025 +0000, Kevin Puetz wrote: > Yes, but not as rebased to master (we're quite a bit behind, so I just > ran things through testbot.winehq.org before submitting rather than > doing a full local build of 10.6). I'll mark as draft for now and do > some more testing... Ok, my apologies that this took so long to get back to. The fix was sound, but the test was completely flawed and I'm not sure how it seemed to work the first time. The key problem is that, since the whole scenario involves a hostapartment, the class factory will be a proxy. And to keep cross-thread traffic down, proxies keep their own refcount, with the proxy owning a single refcount to the stub, which owns a single refcount to the real implementing object. So observing the refcount of the proxy could never have shown whether the actual implementation had been leaked. So now the test instead checks the way we observed the problem in real life - we put a "real" CLSID in to testlib.dll, and notice that the existence of any external refcounts on the class factory object has caused testlib.dll's DllCanUnloadNow to return S_FALSE. So now the compobj test I added seems OK ole32:compobj start dlls/ole32/tests/compobj.c ole32:compobj:0c0c done (0) in 2s 1498B However, pipeline is still showing VM failure on mac > no IP address found, is your VM running And a failure on linux-32, not in the test I changed: > ole32:clipboard:0bf8 done (0) in 0s 5076B > ole32:compobj start dlls/ole32/tests/compobj.c which is where my new test is - the failure is later > ole32:marshal start dlls/ole32/tests/marshal.c > marshal.c:4214:0.026 Test failed: got 0 > marshal.c:4223:0.027 Test failed: Number of locks should be 0, but actually is 2 These marshal.c failures seem to be present in other PRs too (including ones that merged last night), so I assume they are unrelated... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7880#note_104932

1 0

[PATCH 0/1] MR8134: d3d10/tests: Compile more test effects from sources.
by Nikolay Sivov (＠nsivov) 29 May '25

29 May '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8134

3 4

[PATCH 0/1] MR8147: d3dx9/tests: Add an effect compiler test for accessing functions.
by Nikolay Sivov (＠nsivov) 29 May '25

29 May '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8147

3 2

[PATCH 0/2] MR8175: mf: Clear pending MFT stream requests when flushing.
by Charlotte Pabst (＠CharlottePabst) 29 May '25

29 May '25

Before this, stopping and restarting the media session could cause MFT streams to get stuck in the "already pending" state, which would lead to no more samples getting delivered. This also reverts 18c0dd7390b354d2e505e54cd3f3f9b08226b265, my previous attempt to fix the problem which for some reason seemed to help - but with the new fix, it does not make any difference. The reverted commit is faulty since the Flush() method - which is called at session Stop, but runs after sample_grabber_set_state - already releases pending items, while processing markers immediately. Sorry for the trouble. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8175

2 2

[PATCH v2 0/5] MR8174: winebth.sys part 12: Introduce support for Low Energy GATT services
by Vibhav Pant (＠vibhavp) 29 May '25

29 May '25

Generic ATTribute Profile (GATT) is a protocol used by BLE devices for data exchange. Broadly, every LE device contains one or more GATT services, with each service having multiple characteristics, which contain the actual piece of data to be exchanged. The Win32 BLE api is defined in [`bluetoothleapis.h`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/), and operates on `HANDLE`s to PDOs created by the driver to remote devices and services, using the `GUID_BLUETOOTHLE_DEVICE_INTERFACE` and `GUID_BLUETOOTH_GATT_SERVICE_DEVICE_INTERFACE` class interfaces respectively. This MR introduces initial support for accessing GATT services on LE devices by: * Creating PDOs for remote devices that we discover GATT services on, and enabling `GUID_BLUETOOTHLE_DEVICE_INTERFACE` for them. * Because the driver also creates PDOs for bluetooth radios, a tagged union is used to distinguish between device extension values to dispatch IOCTL and PnP IRPs appropriately. * Enumerate through all `org.bluez.GattService1` objects on BlueZ, and store them on the PE driver inside the associated devices. * Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES for device PDOs. * Use the newly added IOCTL to implement [`BluetoothGATTGetServices`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/nf-bluetoothleapis-bluetoothgattgetservices). -- v2: bluetoothapis/tests: Add tests for BluetoothGATTGetServices. bluetoothapis: Implement BluetoothGATTGetServices. winebth.sys: Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES. winebth.sys: Store a list of GATT services discovered on LE devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/8174

2 5

[PATCH v2 0/1] MR8141: gdiplus: Add check of type parameter to be positive (ASan).
by Bernhard Übelacker (＠bernhardu) 29 May '25

29 May '25

Function GdipGetImageAttributesAdjustedPalette gets [called with type = -1](https://gitlab.winehq.org/wine/wine/-/blob/22af42ac22279e6c0c671f033661f95c1761b4bb/dlls/gdiplus/tests/image.c?page=6#L5649) and therefore accesses several arrays at index -1. This patch adds a helper which additionally checks for `type >= ColorAdjustTypeDefault`. <details> <summary>ASan output</summary> ``` ================================================================= ==gdiplus_test.exe==308==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7f21342c57f8 at pc 0x6ffffadfd25b bp 0x7ffffe1ff750 sp 0x7ffffe1ff798 READ of size 4 at 0x7f21342c57f8 thread T0 #0 0x6ffffadfd25a in apply_image_attributes .../dlls/gdiplus/graphics.c:929:41 #1 0x6ffffae5c2f2 in GdipGetImageAttributesAdjustedPalette .../dlls/gdiplus/imageattributes.c:123:5 #2 0x000140084b59 in test_getadjustedpalette .../dlls/gdiplus/tests/image.c:5649:12 #3 0x000140062be6 in func_image .../dlls/gdiplus/tests/image.c:6719:5 #4 0x0001400c9132 in run_test .../include/wine/test.h:765:5 #5 0x0001400c8b50 in main .../include/wine/test.h:884:12 #6 0x0001400cad3a in mainCRTStartup .../dlls/msvcrt/crt_main.c:60:11 #7 0x6fffffc45aa0 in BaseThreadInitThunk .../dlls/kernel32/thread.c:61:24 #8 0x6fffffdcc776 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004c776) 0x7f21342c57f8 is located 144 bytes after 1256-byte region [0x7f21342c5280,0x7f21342c5768) freed by thread T0 here: #0 0x6ffffe88aab1 in free C:/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan\asan_malloc_win.cpp:71:3 #1 0x6ffffae5c21d in GdipDisposeImageAttributes .../dlls/gdiplus/imageattributes.c:109:5 #2 0x000140083598 in test_colorkey .../dlls/gdiplus/tests/image.c:3709:5 #3 0x000140062bd7 in func_image .../dlls/gdiplus/tests/image.c:6716:5 #4 0x0001400c9132 in run_test .../include/wine/test.h:765:5 #5 0x0001400c8b50 in main .../include/wine/test.h:884:12 #6 0x0001400cad3a in mainCRTStartup .../dlls/msvcrt/crt_main.c:60:11 #7 0x6fffffc45aa0 in BaseThreadInitThunk .../dlls/kernel32/thread.c:61:24 #8 0x6fffffdcc776 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004c776) previously allocated by thread T0 here: #0 0x6ffffe88ace6 in calloc C:/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan\asan_malloc_win.cpp:91:3 #1 0x6ffffae5c0fc in GdipCreateImageAttributes .../dlls/gdiplus/imageattributes.c:87:18 #2 0x000140082bf9 in test_colorkey .../dlls/gdiplus/tests/image.c:3629:12 #3 0x000140062bd7 in func_image .../dlls/gdiplus/tests/image.c:6716:5 #4 0x0001400c9132 in run_test .../include/wine/test.h:765:5 #5 0x0001400c8b50 in main .../include/wine/test.h:884:12 #6 0x0001400cad3a in mainCRTStartup .../dlls/msvcrt/crt_main.c:60:11 #7 0x6fffffc45aa0 in BaseThreadInitThunk .../dlls/kernel32/thread.c:61:24 #8 0x6fffffdcc776 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004c776) SUMMARY: AddressSanitizer: heap-buffer-overflow .../dlls/gdiplus/graphics.c:929:41 in apply_image_attributes Shadow bytes around the buggy address: 0x7f21342c5500: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f21342c5580: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f21342c5600: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f21342c5680: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f21342c5700: fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa =>0x7f21342c5780: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa[fa] 0x7f21342c5800: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x7f21342c5880: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7f21342c5900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7f21342c5980: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7f21342c5a00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==gdiplus_test.exe==308==ABORTING ``` </details> -- v2: gdiplus: Add check of type parameter to be positive (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/8141

3 4

[PATCH 0/2] MR8165: comctl32/listview: Fix lbutton item selection with Shift+Ctrl.
by Nikolay Sivov (＠nsivov) 29 May '25

29 May '25

Visual testing shows that using Shift+Ctrl adds to the selection, which is what existing code already does. The problem is that it updates selection mark when it shouldn't. And the bigger problem of course is that it's using static variable for state. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8165

3 3

[PATCH v6 0/4] MR6783: winegstreamer: Fix memory/resource leaks in media sources.
by Conor McCarthy (＠cmccarthy) 29 May '25

29 May '25

Streams hold a reference to the source, but this reference should not be taken until `Start()` is called because freeing the media source depends on release in `Shutdown()` of the stream's reference to the source. We could create the streams in `media_source_create()` and take source refs for them in `Start()`, but that's potentially confusing and fragile. Streams can persist after the media source is destroyed. In that case, they cannot access the source object and it should be released and set to null. Windows behaviour is to release references to the source in `Shutdown()`. If we don't do this and a buggy app were to leak a stream object, the media source object would also leak and `wg_parser_destroy()` would not be called. -- v6: winegstreamer: Release stream references to the media source in Shutdown(). winegstreamer: Do not create MF stream objects until the media source is started. mfplat/tests: Test video stream release after media source release. mfplat/tests: Add more media source refcount checks. https://gitlab.winehq.org/wine/wine/-/merge_requests/6783

2 5

[PATCH 0/1] MR8173: xmllite/tests: Add more writer tests.
by Nikolay Sivov (＠nsivov) 29 May '25

29 May '25

Split up from !2928. Implementation to follow at a later time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8173

2 2

[PATCH 0/1] MR8172: mfreadwrite: Fix stride in media type ouput.
by Brendan McGrath (＠redmcg) 29 May '25

29 May '25

This is required to fix video playback in Crashlands 2 on Proton 10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8172

3 2

[PATCH v3 0/1] MR7360: mshtml: Try to guess the charset on streams with no BOM.
by Gabriel Ivăncescu (＠insn) 29 May '25

29 May '25

-- v3: mshtml: Try to guess the charset on streams with no BOM. https://gitlab.winehq.org/wine/wine/-/merge_requests/7360

3 4

[PATCH v6 0/2] MR4812: user32: Fix the number of characters processed by DrawTextExW.
by JiangYi Chen (＠meshine) 29 May '25

29 May '25

Description: When flags does not include DT_CALCRECT, since len is calculated in the middle, it will be reduced to zero. Resulting in the length of the processed string that is finally returned to zero and the non-processing string length is unchanged. But some application taking the non-processing string length to zero as the loop end condition. Log: Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: Icc0f250f5f4faba1bee8326fc911a4fc9cd7c012 -- v6: user32: Fix the number of characters processed by DrawTextExW. user32/tests: Add tests for DrawTextExW. https://gitlab.winehq.org/wine/wine/-/merge_requests/4812

3 5

[PATCH v5 0/4] MR8034: winegstreamer: Call wg_format_get_max_size() to get the video decoder output sample size.
by Conor McCarthy (＠cmccarthy) 29 May '25

29 May '25

Windows uses a smaller alignment than gstreamer for some formats, for example NV12. This means we cannot use MFCalculateImageSize() to get the output sample size. Commit 7b79e3a87b1e switched to calling it instead of GetOutputStreamInfo() to fix some game bugs. -- v5: winegstreamer: Call wg_format_get_max_size() to get the video decoder output sample size. winegstreamer: Do not pass a sample size to wg_transform_read_mf(). mf/tests: Add a video processor NV12 test with a width alignment of 2. mfplat/tests: Add NV12 650 x 850 to image_size_tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/8034

2 4

[PATCH v6 0/29] MR7226: ntdll: Implement in-process synchronization via the Linux "ntsync" driver.
by Elizabeth Figura (＠zfigura) 28 May '25

28 May '25

This introduces a faster implementation of signal and wait operations on NT events, semaphores, and mutexes, which improves performance to native levels for a wide variety of games and other applications. The goal here is similar to the long-standing out-of-tree "esync" and "fsync" patch sets, but without the flaws that make those patch sets not upstreamable. The Linux "ntsync" driver is not currently released. It has been accepted into the trunk Linux tree for 6.14, so barring any extraordinary circumstances, the API is frozen and it will be released in its current form in about 2 months. Since it has passed all relevant reviewers on the kernel side, and the API is all but released, it seems there is no reason any more not to submit the Wine side to match. Some important notes: * This patch set does *not* include any way to disable ntsync support, since that kind of configuration often seems to be dispreferred where not necessary. In essence, ntsync should just work everywhere. Probably the easiest way to effectively disable ntsync, for the purposes of testing, is to chmod the /dev/ntsync device to prevent its being opened. Regardless, a Wine switch to disable ntsync can be added simply enough. Note that it should probably not take the form of a registry key, however, since it needs to be easily accessible from the server itself. * It is, generally speaking, not possible for only some objects, or some processes, to have backing ntsync objects, while others use the old server path. The esync/fsync patch sets explicitly protected against this by making sure every process had a consistent view of whether esync was enabled. This is not provided here, since no switch is provided to toggle ntsync, and it should not be possible to get into such an inconsistent state without gross misconfiguration. * Similarly, no diagnostic messages are provided to note that ntsync is in use, or not in use. These messages are part of esync/fsync, as well as part of ntsync "testing" trees unofficially distributed. However, if ntsync is working correctly, no message should be necessary. The basic structure is: * Each type of server object which can be waited on by the client (including events, semaphores, mutexes, but also other types such as processes, files) must store an "inproc_sync" object. This "inproc_sync" object is a full server object (note that this differs from esync/fsync). A vector and server request is introduced to retrieve an NT handle to this object from an arbitrary NT handle. Since the actual ntsync objects are simply distinct file descriptions, we then call get_handle_fd from the client to retrieve an fd to the object, and then perform ioctls on it. * Objects signaled by the server (processes, files, etc) perform ntsync ioctls on that object. The backing object in all such cases is simply an event. * Signal and wait operations on the client side attempt to defer to an "inproc_\*" function, falling back to the server implementation if it returns STATUS_NOT_IMPLEMENTED. This mirrors how in-process synchronization objects (critical sections, SRW locks, etc) used to be implemented—attempting to use an architecture-specific "fast_\*" function and falling back if it returned STATUS_NOT_IMPLEMENTED. * The inproc_sync handles, once retrieved, are cached per-process. This caching takes a similar form to the fd cache. It does not reuse the same infrastructure, however. The primary reason for this is that the fd cache is designed to fit within a 64-bit value and uses 64-bit atomic operations to ensure consistency. However, we need to store more than 64 bits of information. [We also need to modify them after caching, in order to correctly implement handle closing—see below.] The secondary reason is that retrieving the ntsync fd from the inproc_sync handle itself uses the fd cache. * In order to keep the Linux driver simple, it does not implement access flags (EVENT_MODIFY_STATE etc.) Instead, the flags are cached locally and validated there. This too mirrors the fd cache. Note that this means that a malicious process can now modify objects it should not be able modify—which is less true than it is with wineserver—but this is no different from the way other objects (notably fds) are handled, and would require manual syscalls. * In order to achieve correct behaviour related to closing objects while they are used, this patch set essentially relies on refcounting. This is broadly true of the server as well, but because we need to avoid server calls when performing object operations, significantly more care must be taken. In particular, because waits need to be interruptable by signals and then be restarted, we need the backing ntsync object to remain valid until all users are done with it. On a process level, this is achieved by letting multiple processes own handles to the underlying inproc_sync server object. On a thread level, multiple simultaneous calls need to refcount the process's local handle. This refcount is stored in the sync object cache. When it reaches zero, the cache is cleared. Punting this behaviour to the Linux driver would have introduced a great deal more complexity, which is best kept in userspace and out of the kernel. * The cache is, as such, treated as a cache. The penultimate commit, which introduces client support but does not yet cache the objects, effectively illustrates this by never actually caching anything, and retrieving a new NT handle and fd every time. * Certain waits, on internal handles (such as async, startup_info, completion), are delegated to the server even when ntsync is used. Those server objects do not create an underlying ntsync object. -- v6: ntdll: Cache in-process synchronization objects. ntdll: Use server_wait_for_object() when waiting on only the queue object. ntdll: Use in-process synchronization objects. ntdll: Introduce a helper to wait on an internal server handle. server: Allow creating an event object for client-side user APC signaling. server: Introduce select_inproc_queue and unselect_inproc_queue requests. server: Add a request to retrieve the in-process synchronization object from a handle. server: Create in-process synchronization objects for fd-based objects. server: Create in-process synchronization objects for timers. server: Create in-process synchronization objects for threads. server: Create in-process synchronization objects for message queues. server: Create in-process synchronization objects for jobs. server: Create in-process synchronization objects for processes. server: Create in-process synchronization objects for keyed events. server: Create in-process synchronization objects for device managers. server: Create in-process synchronization objects for debug objects. server: Create in-process synchronization objects for console outputs. server: Create in-process synchronization objects for console inputs. server: Create in-process synchronization objects for screen buffers. server: Create in-process synchronization objects for console servers. server: Create in-process synchronization objects for consoles. server: Create in-process synchronization objects for completion ports. server: Create in-process synchronization objects for mutexes. server: Create in-process synchronization objects for semaphores. server: Create in-process synchronization objects for events. server: Add an object operation to retrieve an in-process synchronization object. ntdll: Retrieve and cache an ntsync device in wait calls. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7226

7 10

[PATCH 0/1] MR8167: xmllite/tests: Fix out-of-bound read.
by Yuxuan Shui (＠yshui) 28 May '25

28 May '25

IXmlWriter doesn't write a NUL terminator into the stream, therefore formatting it with %s results in out-of-bound read. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8167

3 2

[PATCH v9 0/3] MR7064: ntdll: Check for invalid GS base in the 64-bit segv_handler.
by William Horvath (＠whrvt) 28 May '25

28 May '25

Adapted from [check_invalid_gs](https://gitlab.winehq.org/wine/wine/-/blob/d7a7cae2e2d1ad… in signal_i386.c. This prevents crashing when the %gs register is manipulated, such as in 32-bit code on "new-style" WoW64. "Exertus: Darkness Approaches" is a 32-bit game that triggers this crash (on WoW64), which can be downloaded from the Bugzilla page's attachments. For another example, [test.c](https://bugs.winehq.org/attachment.cgi?id=77444) can reproduce it, courtesy of Fabian Maurer from the Bugzilla comments. This will crash whether it's compiled as 32-bit or 64-bit, while it works fine on Windows. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57444 -- v9: ntdll/tests: Re-enable a previously crashing test. ntdll: Check for invalid gs_base in the 64-bit segv_handler. ntdll/tests: Add an exception test for accessing a modified %gs on x86_64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7064

2 3

Re: [PATCH v2 0/3] MR8091: wined3d/spirv: Implement some extra shader parameters. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8091

1 0

Re: [PATCH v2 0/1] MR8092: wined3d/vk: Use an XY11 fixup for 2-channel SNORM formats. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8092

1 0

Re: [PATCH v3 0/4] MR8059: dxgi: Implement subresource surface support. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8059

1 0

Re: [PATCH v2 0/4] MR8077: Add newer d3d11 device interface stubs. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8077

1 0

Re: [PATCH v2 0/1] MR8168: ntdll: Fix out-of-bound read in RtlIpv6AddressToStringExA. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8168

1 0

Re: [PATCH v3 0/1] MR8162: kernel32/tests: Don't import NtCompareObjects on Windows 7. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8162

1 0

Re: [PATCH v2 0/1] MR8164: pdh: Add stub for PdhGetRawCounterArrayW{A,W}. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8164

1 0

Re: [PATCH v4 0/3] MR7748: ucrtbase: Add cexp() implementation. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7748

1 0

Re: [PATCH v2 0/5] MR8160: amstream: Improve DDSURFACEDESC to AM_MEDIA_TYPE conversion, part 2/2. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8160

1 0

Re: [PATCH v4 0/1] MR8159: mf: Release pending items when sample grabber is stopped. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8159

1 0

Re: [PATCH v2 0/1] MR8161: winex11: Listen for ConfigureNotify events on the virtual desktop. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8161

1 0

Re: [PATCH v14 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices. - approved
by Alexandre Julliard (＠julliard) 28 May '25

28 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

1 0

[PATCH v2 0/5] MR8061: win32u: Read window dpi_context from the shared memory.
by Rémi Bernon (＠rbernon) 28 May '25

28 May '25

-- v2: win32u: Read window dpi_context from the shared memory. win32u: Pass id and offset separately to find_shared_session_object. server: Move window dpi_context to the shared memory. server: Allocate shared memory objects for windows. server: Fix shared object offset when additional blocks are allocated. https://gitlab.winehq.org/wine/wine/-/merge_requests/8061

3 7

[PATCH v4 0/12] MR8148: opengl32: Implement wglShareLists directly.
by Rémi Bernon (＠rbernon) 28 May '25

28 May '25

-- v4: win32u: Drop now unused wglShareLists entry points. opengl32: Implement wglShareLists by copying after recreation. win32u: Drop now unused wglCopyContext entry points. opengl32/tests: Add more tests with wglCopyContext after usage. opengl32: Implement wglCopyContext with tracked attributes. opengl32: Track a subset of the context attributes. opengl32: Track current context attributes changes. opengl32/tests: Test wglShareLists with modified contexts. opengl32: Generate args loading / locking for wrapped functions. opengl32: Use cached attributes to detect legacy contexts. opengl32: Cache context creation attributes. opengl32: Simplify wglMake(Context)Current control flow. https://gitlab.winehq.org/wine/wine/-/merge_requests/8148

2 13

[PATCH 0/3] MR8091: wined3d/spirv: Implement some extra shader parameters.
by Elizabeth Figura (＠zfigura) 28 May '25

28 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8091

3 4

[PATCH 0/1] MR8092: wined3d/vk: Use an XY11 fixup for 2-channel SNORM formats.
by Elizabeth Figura (＠zfigura) 28 May '25

28 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8092

3 2

[PATCH v2 0/4] MR8059: dxgi: Implement subresource surface support.
by Zhiyi Zhang (＠zhiyi) 28 May '25

28 May '25

For React Native. -- v2: dxgi: Implement subresource surface support. https://gitlab.winehq.org/wine/wine/-/merge_requests/8059

4 7

[PATCH 0/4] MR8077: Add newer d3d11 device interface stubs.
by Zhiyi Zhang (＠zhiyi) 28 May '25

28 May '25

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8077

4 6

[PATCH v3 0/8] MR8148: opengl32: Implement wglShareLists directly.
by Rémi Bernon (＠rbernon) 28 May '25

28 May '25

-- v3: win32u: Drop now unnecessary wglShareList entries. opengl32: Implement wglShareLists semi-stub directly. opengl32: Track whether current opengl context has been used. opengl32: Move GL internal TEB offsets to wine/opengl_driver.h. opengl32: Generate args loading / locking for wrapped functions. opengl32: Use cached attributes to detect legacy contexts. opengl32: Cache context creation attributes. opengl32: Simplify wglMake(Context)Current control flow. https://gitlab.winehq.org/wine/wine/-/merge_requests/8148

2 10

[PATCH v13 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 28 May '25

28 May '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v13: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. bluetoothapis: Use a wizard GUI to respond to pairing requests if an authentication callback is not registered. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

3 5

[PATCH v5 0/3] MR8166: taskschd: Implements IRegisteredTaskCollection get_Count and get_Item
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Count and get_Item along with a test for both. When making the tests individually they were very similar so I merged them into one test function as per feedback. -- v5: taskschd/regtask: Implements IRegisteredTaskCollection get_Count(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8166

2 3

[PATCH v4 0/3] MR8166: taskschd: Implements IRegisteredTaskCollection get_Count and get_Item
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Count and get_Item along with a test for both. When making the tests individually they were very similar so I merged them into one test function as per feedback. -- v4: taskschd/regtask: Implements IRegisteredTaskCollection get_Count(). taskschd/regtask: Implements IRegisteredTaskCollection get_Item(). taskschd/tests: Adds a test for IRegisteredTaskCollection get_Item and get_Count. https://gitlab.winehq.org/wine/wine/-/merge_requests/8166

3 4

[PATCH 0/1] MR8163: dmime: Fix use-after-free after performance_CloseDown.
by Yuxuan Shui (＠yshui) 28 May '25

28 May '25

IDirectMusicPerformance8 holds references to music ports in channel_blocks. These ports must outlive their parent IDirectMusic, because in synth_port_Release, they remove themselves from their parent. performance_CloseDown releases the IDirectMusic, but doesn't release its ports. So when these ports are later released in performance_Release, they uses the already freed IDirectMusic. Found by ASan. stacktrace ([post-processed](https://gitlab.winehq.org/yshui/wine-symbolizer)): ``` 016c:0170:err:asan:asan_report ASan: read of 4 bytes at 00007E1C0BFF8518, caller 00006FFFFDE2B9C2 (__asan_report_load4, ../dlls/asan_dynamic_thunk/thunk.c:1020,1) 016c:0170:err:asan:asan_report stacktrace: 016c:0170:err:asan:asan_report 00006FFFFDE2B9C2 (__asan_report_load4, ../dlls/asan_dynamic_thunk/thunk.c:1020,1) 016c:0170:err:asan:asan_report 00006FFFFDE144BC (dmusic_remove_port, ../dlls/dmusic/dmusic.c:312,10) 016c:0170:err:asan:asan_report 00006FFFFDE21A99 (synth_port_Release, ../dlls/dmusic/port.c:129,9) 016c:0170:err:asan:asan_report 00006FFFFE20B88A (channel_block_free, ../dlls/dmime/performance.c:271,28 <- rb_postorder, ../include/wine/rbtree.h:170,46 <- rb_destroy, ../include/wine/rbtree.h:188,19 <- performance_Release, ../dlls/dmime/performance.c:450,5) 016c:0170:err:asan:asan_report 00007FFFFE002FFA (test_COM_audiopath, ../dlls/dmime/tests/dmime.c:972,5 <- func_dmime, ../dlls/dmime/tests/dmime.c:5201,5) 016c:0170:err:asan:asan_report 00007FFFFE082CDD (run_test, ../include/wine/test.h:765,5) 016c:0170:err:asan:asan_report 00007FFFFE082598 (main, ../include/wine/test.h:0,0) 016c:0170:err:asan:asan_report 00007FFFFE08C44F (mainCRTStartup, ../dlls/msvcrt/crt_main.c:60,11) 016c:0170:err:asan:asan_report 00006FFFFF9DD502 (BaseThreadInitThunk, ../dlls/kernel32/thread.c:61,24) 016c:0170:err:asan:asan_report 00006FFFFFC4DC3F (longjmp_regs) 016c:0170:err:asan:asan_report info: 016c:0170:err:asan:asan_report heap-use-after-free, addr 00007E1C0BFF8518 016c:0170:err:asan:asan_report allocated user region: [00007E1C0BFF84F0, 00007E1C0BFF8530) 64 016c:0170:err:asan:asan_report allocated by 19e3 016c:0170:err:asan:asan_report 00006FFFFDE14885 (music_create, ../dlls/dmusic/dmusic.c:587,20) 016c:0170:err:asan:asan_report 00006FFFFDE18853 (ClassFactory_CreateInstance, ../dlls/dmusic/dmusic_main.c:94,9) 016c:0170:err:asan:asan_report 00006FFFFC925ECF (IClassFactory_CreateInstance, include/unknwn.h:245,12 <- CoCreateInstanceEx, ../dlls/combase/combase.c:1890,10) 016c:0170:err:asan:asan_report 00006FFFFC924F61 (CoCreateInstance, ../dlls/combase/combase.c:1679,10) 016c:0170:err:asan:asan_report 00006FFFFE20BE48 (performance_init_dmusic, ../dlls/dmime/performance.c:480,9 <- performance_Init, ../dlls/dmime/performance.c:535,14) 016c:0170:err:asan:asan_report 00006FFFFE211CB9 (performance_InitAudio, ../dlls/dmime/performance.c:1537,9) 016c:0170:err:asan:asan_report 00007FFFFE001949 (test_COM_audiopath, ../dlls/dmime/tests/dmime.c:906,10 <- func_dmime, ../dlls/dmime/tests/dmime.c:5201,5) 016c:0170:err:asan:asan_report 00007FFFFE082CDD (run_test, ../include/wine/test.h:765,5) 016c:0170:err:asan:asan_report 00007FFFFE082598 (main, ../include/wine/test.h:0,0) 016c:0170:err:asan:asan_report 00007FFFFE08C44F (mainCRTStartup, ../dlls/msvcrt/crt_main.c:60,11) 016c:0170:err:asan:asan_report 00006FFFFF9DD502 (BaseThreadInitThunk, ../dlls/kernel32/thread.c:61,24) 016c:0170:err:asan:asan_report 00006FFFFFC4DC3F (longjmp_regs) 016c:0170:err:asan:asan_report freed by 3390 016c:0170:err:asan:asan_report 00006FFFFDE15DC4 (IDirectMusic8Impl_Release, ../dlls/dmusic/dmusic.c:203,5) 016c:0170:err:asan:asan_report 00006FFFFE21158C (performance_CloseDown, ../dlls/dmime/performance.c:1469,9) 016c:0170:err:asan:asan_report 00007FFFFE002FB7 (test_COM_audiopath, ../dlls/dmime/tests/dmime.c:971,5 <- func_dmime, ../dlls/dmime/tests/dmime.c:5201,5) 016c:0170:err:asan:asan_report 00007FFFFE082CDD (run_test, ../include/wine/test.h:765,5) 016c:0170:err:asan:asan_report 00007FFFFE082598 (main, ../include/wine/test.h:0,0) 016c:0170:err:asan:asan_report 00007FFFFE08C44F (mainCRTStartup, ../dlls/msvcrt/crt_main.c:60,11) 016c:0170:err:asan:asan_report 00006FFFFF9DD502 (BaseThreadInitThunk, ../dlls/kernel32/thread.c:61,24) 016c:0170:err:asan:asan_report 00006FFFFFC4DC3F (longjmp_regs) 016c:0170:trace:module:LdrShutdownProcess () ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8163

3 4

[PATCH 0/1] MR8168: ntdll: Fix out-of-bound read in RtlIpv6AddressToStringExA.
by Yuxuan Shui (＠yshui) 28 May '25

28 May '25

Bound check was performed after the array access, resulting in out-of-bound read of IN6_ADDR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8168

2 1

[PATCH v3 0/3] MR8166: Draft: taskschd: Implements IRegisteredTaskCollection get_Count and get_Item
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Count and get_Item along with a test for both. When making the tests individually they were very similar so I merged them into one test function as per feedback. -- v3: taskschd/regtask: Implements IRegisteredTaskCollection get_Count(). taskschd/regtask: Implements IRegisteredTaskCollection get_Item(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8166

3 4

[PATCH v2 0/3] MR8166: Draft: taskschd: Implements IRegisteredTaskCollection get_Count and get_Item
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Count and get_Item along with a test for both. When making the tests individually they were very similar so I merged them into one test function as per feedback. -- v2: taskschd/regtask: Implements IRegisteredTaskCollection get_Count(). taskschd/regtask: Implements IRegisteredTaskCollection get_Item(). taskschd/tests: Adds a test for IRegisteredTaskCollection get_Item and get_Count. https://gitlab.winehq.org/wine/wine/-/merge_requests/8166

2 4

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) 28 May '25

28 May '25

On Wed May 28 03:08:52 2025 +0000, Yongjie Yao wrote: > ok. The Windows 10 tests are still failing. Could you investigate that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_104812

1 0

[PATCH 0/3] MR8166: taskschd: Implements IRegisteredTaskCollection get_Count and get_Item
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Count and get_Item along with a test for both. When making the tests individually they were very similar so I merged them into one test function as per feedback. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8166

3 10

Re: [PATCH 0/1] MR8158: dmime: Parse and ignore MIDI key signature meta events.
by Michael Stefaniuc (＠mstefani) 28 May '25

28 May '25

Test failures are not DMusic related and Mab build is "script failure". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8158#note_104682

1 0

Re: [PATCH v2 0/5] MR8150: mshtml: Implement ownerElement prop for attribute nodes + misc. - approved
by Jacek Caban (＠jacek) 28 May '25

28 May '25

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8150

1 0

[PATCH 0/5] MR8150: mshtml: Implement ownerElement prop for attribute nodes + misc.
by Gabriel Ivăncescu (＠insn) 28 May '25

28 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8150

3 7

[PATCH v2 0/1] MR8162: kernel32/tests: Don't import NtCompareObjects on Windows 7.
by Alfred Agrell (＠Alcaro) 28 May '25

28 May '25

@epo regression from !8136 -- v2: kernel32/tests: Don't import NtCompareObjects before Windows 10. https://gitlab.winehq.org/wine/wine/-/merge_requests/8162

2 1

[PATCH 0/2] MR8121: taskschd: Implements IRegisteredTaskCollection get_Count().
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Count() -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8121

2 3

[PATCH v3 0/2] MR8122: Draft: taskschd: Implements IRegisteredTaskCollection get_Item().
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Item(). -- v3: taskschd/regtask: Implements IRegisteredTaskCollection get_Item(). taskschd/tests: Adds a test for IRegisteredTaskCollection get_Item(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8122

3 7

Re: [PATCH 0/1] MR8162: kernel32/tests: Don't import NtCompareObjects on Windows 7.
by eric pouech (＠epo) 28 May '25

28 May '25

thanks for taking care of this 1) from pattern page Rémi pointed out, failures to get export also exist in Win8, so your patch title should be modified accordingly 2) testing for skip_nt on top of test_FreeConsoleStd(void) alongside pVerifyConsoleIoHandle should workaround the Win7 failures the rest LGTM -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8162#note_104799

1 0

Re: [PATCH v2 0/3] MR8056: d3dx9: Properly decode sub 8bpp indexed images.
by Connor McAdams (＠cmcadams) 28 May '25

28 May '25

On Fri May 23 16:23:37 2025 +0000, Matteo Bruni wrote: > Out of curiosity, what happens with BMP? It's just unsupported for BMP for some reason, there's a test in surface.c for it: ``` hr = D3DXGetImageInfoFromFileInMemory(bmp_2bpp, sizeof(bmp_2bpp), &info); ok(hr == D3DXERR_INVALIDDATA, "D3DXGetImageInfoFromFileInMemory returned %#lx, expected %#x\n", hr, D3DXERR_INVALIDDATA); ``` Which explains why we had all the other WIC indexed formats _except_ for 2bpp in our `wic_pixel_formats` table :) Seems odd to support 1bpp and 4bpp but not 2bpp, but :man_shrugging: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8056#note_104797

1 0

[PATCH v2 0/1] MR7360: mshtml: Try to guess the charset on streams with no BOM.
by Gabriel Ivăncescu (＠insn) 28 May '25

28 May '25

-- v2: mshtml: Try to guess the charset on streams with no BOM. https://gitlab.winehq.org/wine/wine/-/merge_requests/7360

4 6

[PATCH v3 0/3] MR7748: ucrtbase: Add cexp() implementation.
by Daniel Lehman (＠dlehman25) 28 May '25

28 May '25

will have followup with cexpf and others -- v3: msvcr120: Add cexp() implementation. libs/musl: Pass math_error callback to exp. msvcr120/tests: Test exp. https://gitlab.winehq.org/wine/wine/-/merge_requests/7748

3 4

[PATCH 0/1] MR8164: pdh: Add stub for PdhGetRawCounterArrayW{A,W}.
by Louis Lenders (＠xe) 28 May '25

28 May '25

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=58285 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8164

2 1

Re: [PATCH 0/1] MR8162: kernel32/tests: Don't import NtCompareObjects on Windows 7.
by Alfred Agrell (＠Alcaro) 28 May '25

28 May '25

Testbot run: https://testbot.winehq.org/JobDetails.pl?Key=158450 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8162#note_104789

1 0

Re: [PATCH v2 0/3] MR8136: Fix interaction between FreeConsole() and CRT std streams.
by Alfred Agrell (＠Alcaro) 28 May '25

28 May '25

On Wed May 28 09:59:53 2025 +0000, Alfred Agrell wrote: > Correct, it's NtCompareObjects Filed !8162 to fix that -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8136#note_104787

1 0

Re: [PATCH v2 0/3] MR8136: Fix interaction between FreeConsole() and CRT std streams.
by Alfred Agrell (＠Alcaro) 28 May '25

28 May '25

On Wed May 28 09:59:53 2025 +0000, Rémi Bernon wrote: > I think this introduced an import (not sure which one but that's the > only recent change to the tests) that's missing from every windows > version < 10, causing the entire kernel32 tests to be skipped on those > windows versions. https://test.winehq.org/data/patterns.html#kernel32:change Correct, it's NtCompareObjects -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8136#note_104784

1 0

[PATCH v3 0/1] MR8159: mf: Release pending items when sample grabber is stopped.
by Charlotte Pabst (＠CharlottePabst) 28 May '25

28 May '25

Before this, if the grabber is stopped while items are pending and then restarted, it would stop delivering any items because it does not start the timer while the pending item list is non-empty. -- v3: mf: Release pending items when sample grabber is stopped. https://gitlab.winehq.org/wine/wine/-/merge_requests/8159

3 3

Re: [PATCH v2 0/3] MR8136: Fix interaction between FreeConsole() and CRT std streams.
by Rémi Bernon (＠rbernon) 28 May '25

28 May '25

I think this introduced an import (not sure which one but that's the only recent change to the tests) that's missing from every windows version < 10, causing the entire kernel32 tests to be skipped on those windows versions. https://test.winehq.org/data/patterns.html#kernel32:change -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8136#note_104781

1 0

Re: [PATCH v9 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) 28 May '25

28 May '25

On Thu May 22 10:02:19 2025 +0000, Zhiyi Zhang wrote: > test-win10-21h2-32 and test-win10-21h2-64 are still failing. Try a rebase. ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_104767

1 0

[PATCH v27 0/9] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 27 May '25

27 May '25

Follow-up of !2786, which appears to have been abandoned. # Execute minimal test case 1. in dlls/ws2_32/tests/sock.c wrap all calls to test functions after `Init()` until `test_afunix()` with #if 0 ... #endif 2. checkout wine into ~/src/wine 3. build into ~/src/wine-build 4. run `(cd ~/src/wine-build; WINEPREFIX=~/src/wine/.wine ../wine/tools/runtest -q -P wine -T . -M ws2_32.dll -p dlls/ws2_32/tests/i386-windows/ws2_32_test.exe sock)` # How to debug wineserver Since `wineserver` runs in the background, simple calls to printf() will show nothing when the test case is executed. A workaround is to open a file and call fprintf() to write debug messages to this file, which can then be inspected. -- v27: ws2_32: Add note in bind() for AF_UNIX sockets ws2_32/tests: In tests for AF_UNIX sockets print actual directory used ws2_32/tests: In AF_UNIX socket tests always print used path in case of errors ws2_32/tests: Add test for AF_UNIX sockets server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

3 9

Re: [PATCH v26 0/9] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 27 May '25

27 May '25

On Tue May 27 23:02:23 2025 +0000, Ralf Habacker wrote: > The changes for adapting the current directory are currently relevant > for socket names with relative or unspecified paths, which can cause > problems anyway, see https://gitlab.freedesktop.org/dbus/dbus/-/merge_requests/391#note_2914230. > In order to make progress with the current implementation, the use of > relative paths is excluded for the time being. At https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_104753 it is mentioned that if the specified path is too long, it is necessary to change the current directory. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_104758

1 0

Re: [PATCH v26 0/9] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 27 May '25

27 May '25

On Tue May 27 22:59:45 2025 +0000, Ralf Habacker wrote: > here also See https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_104753 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_104757

1 0

Re: [PATCH v26 0/9] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 27 May '25

27 May '25

On Tue May 27 22:59:37 2025 +0000, Ralf Habacker wrote: > This should be changed. See https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_104753 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_104756

1 0

Re: [PATCH v26 0/9] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 27 May '25

27 May '25

On Tue May 27 22:59:28 2025 +0000, Ralf Habacker wrote: > chdir() is also used here. see https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_104753 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_104755

1 0

Re: [PATCH v26 0/9] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 27 May '25

27 May '25

On Tue May 27 22:59:21 2025 +0000, Ralf Habacker wrote: > Here the working directory is also changed, which needs to be reviewed. see https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_104753 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_104754

1 0

Re: [PATCH v26 0/9] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 27 May '25

27 May '25

On Tue May 27 22:59:07 2025 +0000, Ralf Habacker wrote: > At https://gitlab.winehq.org/wine/wine/-/merge_requests/7519 it is > pointed out that changing the working directory may not be a good idea, > so it should be checked whether this can be avoided. The change of the current directory was added to deal with the sun_path length limitation of the address passed to bind, see e.g. at https://unix.stackexchange.com/questions/367008/why-is-socket-path-length-l…. It could only be avoided if the resulting unix path is < 108 characters. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_104753

1 0

[PATCH 0/5] MR8160: amstream: Improve DDSURFACEDESC to AM_MEDIA_TYPE conversion, part 2/2.
by Elizabeth Figura (＠zfigura) 27 May '25

27 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8160

2 5

[PATCH v11 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 27 May '25

27 May '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v11: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. bluetoothapis: Use a wizard GUI to respond to pairing requests if an authentication callback is not registered. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

4 10

Re: [PATCH v2 0/2] MR8133: user32/tests: Make a couple of SetForegroundWindow tests more reliable. - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8133

1 0

Re: [PATCH v2 0/1] MR8158: dmime: Parse and ignore MIDI key signature meta events. - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8158

1 0

Re: [PATCH v2 0/1] MR8156: winedump: Also dump the Culture column of the Assembly table. - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8156

1 0

Re: [PATCH v3 0/5] MR8150: mshtml: Implement ownerElement prop for attribute nodes + misc. - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8150

1 0

Re: [PATCH v2 0/1] MR7682: ntdll: Implement RtlCreateServiceSid - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7682

1 0

Re: [PATCH v4 0/1] MR8043: ntdll: Align records retrieved by SystemProcessInformation. - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8043

1 0

Re: [PATCH v2 0/1] MR8140: pdh: Add stub for PdhEnumObjects{A,W}. - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8140

1 0

Re: [PATCH v2 0/1] MR8139: user32: Add stub for SetProcessLaunchForegroundPolicy. - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8139

1 0

Re: [PATCH v2 0/1] MR8154: winex11: Wait for decoration change side effects before changing focus. - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8154

1 0

Re: [PATCH v2 0/1] MR8155: winex11: Don't expect an event from config requests while window is unmapped. - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8155

1 0

Re: [PATCH v2 0/3] MR8157: winex11: Fix window config requests with embedded windows. - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8157

1 0

Re: [PATCH v2 0/1] MR8151: ntdll: Avoid excessive committed range scan in NtProtectVirtualMemory(). - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8151

1 0

Re: [PATCH v2 0/7] MR8153: Implement IReference<T> - part 2 - approved
by Alexandre Julliard (＠julliard) 27 May '25

27 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8153

1 0

Re: [PATCH 0/1] MR8159: mf: Release pending items when sample grabber is stopped.
by Nikolay Sivov (＠nsivov) 27 May '25

27 May '25

Nikolay Sivov (@nsivov) commented about dlls/mf/samplegrabber.c: > { > if (state == SINK_STATE_STOPPED) > { > + struct scheduled_item *item, *next_item; > + > sample_grabber_cancel_timer(grabber); > release_samples(grabber); > grabber->sample_count = MAX_SAMPLE_QUEUE_LENGTH; > + > + LIST_FOR_EACH_ENTRY_SAFE(item, next_item, &grabber->items, struct scheduled_item, entry) > + { > + stream_release_pending_item(item); > + } > } There is a helper sample_grabber_release_pending_items() for that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8159#note_104703

1 0

[PATCH v10 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 27 May '25

27 May '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v10: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. bluetoothapis: Use a wizard GUI to respond to pairing requests if an authentication callback is not registered. bluetoothapis: Implement BluetoothAuthenticateDeviceEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

2 4

[PATCH v2 0/3] MR7748: ucrtbase: Add cexp() implementation.
by Daniel Lehman (＠dlehman25) 27 May '25

27 May '25

will have followup with cexpf and others -- v2: msvcr120: Add cexp() implementation. libs/musl: Pass math_error callback to exp. msvcr120/tests: Test exp. https://gitlab.winehq.org/wine/wine/-/merge_requests/7748

3 7

[PATCH 0/3] MR8157: winex11: Fix window config requests with embedded windows.
by Rémi Bernon (＠rbernon) 27 May '25

27 May '25

Which got broken by the delaying mechanism in !8079. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8157

2 3

[PATCH 0/1] MR8156: winedump: Also dump the Culture column of the Assembly table.
by Hans Leidekker (＠hans) 27 May '25

27 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8156

2 1

[PATCH 0/1] MR8155: winex11: Don't expect an event from config requests while window is unmapped.
by Rémi Bernon (＠rbernon) 27 May '25

27 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58277 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8155

2 1

Re: [PATCH v17 0/1] MR6199: winewayland: Fix release_all_keys's modifier filtering.
by Yuri Hérouard (＠yurih) 27 May '25

27 May '25

On Tue May 27 08:53:30 2025 +0000, Alexandros Frantzis wrote: > Hi @yurih, the current code excludes VK_MENU/SHIFT/CONTROL, but not in > order to filter modifier keys, but because these are inferred keys: they > don't corresponding to a specific physical key and their state is set > based on the state other keys (i.e., the left/right specific variants). > > Also, there's issues with extended scan code (for example my keyboard > arrows) that aren't released, though it also happens with winex11. > Hmm, I see releases for the key arrows on my keyboard :/ (i.e., > VK_LEFT/RIGHT/...), not sure what's different here. My keyboard is a french azerty keyboard, the down arrow key scan code is e0 50. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6199#note_104647

1 0

Re: [PATCH v17 0/1] MR6199: winewayland: Fix release_all_keys's modifier filtering.
by Alexandros Frantzis (＠afrantzis) 27 May '25

27 May '25

On Sun May 25 15:34:38 2025 +0000, Yuri Hérouard wrote: > Yes it does indeed fix the alt menu mode without my patch. Though I > don't think I understood clearly what you meant, as Alt is already > filtered (VK_MENU), I just added the left and right keys as they are > among the returned keyboard state and are not filtered, making Alt > released anyway. You plan to remove the modifier's filtering altogether ? > Also, there's issues with extended scan code (for example my keyboard > arrows) that aren't released, though it also happens with winex11. Hi @yurih, the current code excludes VK_MENU/SHIFT/CONTROL, but not in order to filter modifier keys, but because these are inferred keys: they don't corresponding to a specific physical key and their state is set based on the state other keys (i.e., the left/right specific variants). > Also, there's issues with extended scan code (for example my keyboard arrows) that aren't released, though it also happens with winex11. Hmm, I see releases for the key arrows on my keyboard :/ (i.e., VK_LEFT/RIGHT/...), not sure what's different here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6199#note_104643

1 0

[PATCH v9 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 27 May '25

27 May '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v9: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. bluetoothapis: Use a wizard GUI to respond to pairing requests if an authentication callback is not registered. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

4 7

[PATCH 0/1] MR8135: winnt: fix maximum support logical cores
by Herman Semenov (＠GermanAizek) 27 May '25

27 May '25

2 issues is closed: - it also fixes spam in logs that maximum value 64 has been exceeded, and (AMD Threadreapers and modern 32 core cpu) have become more accessible - most software does not use all logical cores by default, and many server boards cannot fully run software -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8135

4 4

2025

2024

2023

2022

wine-gitlab