- wine-gitlab - winehq.org

[PATCH 0/1] MR7298: user32/combo: Select all contexts when focused, and vice versa still.
by Haoyang Chen (＠chenhaoyang) 10 Feb '25

10 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=4405 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7298

2 1

[PATCH 0/6] MR7296: Splay tree part 6.
by Zhiyi Zhang (＠zhiyi) 10 Feb '25

10 Feb '25

For React Native. This marks the end of the series. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7296

2 6

[PATCH v4 0/3] MR7173: rtworkq: Support putting work on RTWQ_CALLBACK_QUEUE_UNDEFINED.
by Conor McCarthy (＠cmccarthy) 09 Feb '25

09 Feb '25

-- v4: rtworkq: Support putting work on RTWQ_CALLBACK_QUEUE_UNDEFINED. rtworkq/tests: Add a test for putting work on RTWQ_CALLBACK_QUEUE_UNDEFINED. https://gitlab.winehq.org/wine/wine/-/merge_requests/7173

4 6

[PATCH 0/1] MR7294: wbemprox: Fix a memory leak (Coverity).
by Zhiyi Zhang (＠zhiyi) 09 Feb '25

09 Feb '25

ret will be allocated later at line 3295. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7294

3 4

[PATCH 0/1] MR7293: prntvpt: Add a missing return (Coverity).
by Zhiyi Zhang (＠zhiyi) 09 Feb '25

09 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7293

2 1

[PATCH v18 0/23] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 09 Feb '25

09 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v18: dlls/oleaut32: Validate TLB_QueryInterface() params dlls/oleaut32: Fix QueryInterface() to meet spec dlls/shell32: Fix IUnknown::QueryInterface() to meet spec dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND dlls/oleaut32: Validate arguments in ITypeLibComp interface This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH v17 0/23] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 09 Feb '25

09 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v17: dlls/oleaut32: Validate TLB_QueryInterface() params dlls/oleaut32: Fix QueryInterface() to meet spec dlls/shell32: Fix IUnknown::QueryInterface() to meet spec dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND dlls/oleaut32: Validate arguments in ITypeLibComp interface This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH v16 0/23] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 09 Feb '25

09 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v16: dlls/oleaut32: Validate TLB_QueryInterface() params dlls/oleaut32: Fix QueryInterface() to meet spec This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH 0/1] MR7292: include: Add UI Automation Style ID definitions.
by Biswapriyo Nath (＠Biswa96) 09 Feb '25

09 Feb '25

Required for https://github.com/mozilla/gecko-dev/commit/8a253fd1ef00cdcbb052eedd9d2dda7… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7292

2 1

[PATCH 0/1] MR6740: include: Add windows.graphics.directx.direct3d11.interop.h
by Biswapriyo Nath (＠Biswa96) 09 Feb '25

09 Feb '25

Required for https://webrtc.googlesource.com/src/+/2aad81259ef832172d65aeaba6401fee857a0… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6740

3 4

[PATCH v15 0/22] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 09 Feb '25

09 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v15: dlls/oleaut32: Fix QueryInterface() to meet spec dlls/shell32: Fix IUnknown::QueryInterface() to meet spec dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND dlls/oleaut32: Validate arguments in ITypeLibComp interface This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH v14 0/22] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 09 Feb '25

09 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v14: dlls/oleaut32: Fix QueryInterface() to meet spec dlls/shell32: Fix IUnknown::QueryInterface() to meet spec This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH v13 0/21] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 08 Feb '25

08 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v13: dlls/oleaut32: Fix return value on ITypeComp_fnBindType dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH v12 0/22] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 08 Feb '25

08 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v12: dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Consistently use GetTypeInfoCount() dlls/oleaut32: Fix return value on ITypeComp_fnBindType This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH v17 0/1] MR6884: Iphlpapi.dll: Included SendARP
by Thi Garlet (＠garlett) 08 Feb '25

08 Feb '25

Returns MAC address by: - search local interfaces, or - send UDP packed that does not need linux privilege, then search local cache solve https://bugs.winehq.org/show_bug.cgi?id=9418 files updated - /dlls/iphlpapi/iphlpapi_main.c - /dlls/iphlpapi/tests/iphlpapi.c -- v17: iphlpapi.c: Add SendARP https://gitlab.winehq.org/wine/wine/-/merge_requests/6884

2 1

[PATCH v4 0/1] MR7289: scrrun: implement ITextStream::WriteBlankLines().
by Damjan Jovanovic (＠dj) 08 Feb '25

08 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57810 Closes #57810 -- v4: scrrun: implement ITextStream::WriteBlankLines(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7289

2 2

[PATCH v3 0/1] MR7289: scrrun: implement ITextStream::WriteBlankLines().
by Damjan Jovanovic (＠dj) 08 Feb '25

08 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57810 Closes #57810 -- v3: scrrun: implement ITextStream::WriteBlankLines(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7289

3 6

[PATCH v2 0/1] MR7289: scrrun: implement ITextStream::WriteBlankLines().
by Damjan Jovanovic (＠dj) 08 Feb '25

08 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57810 Closes #57810 -- v2: scrrun: implement ITextStream::WriteBlankLines(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7289

3 5

[PATCH 0/4] MR7287: ntdll: Avoid using current_modref.
by Jacek Caban (＠jacek) 08 Feb '25

08 Feb '25

This is a cleanup in preparation for !7. Originally, !7 extended the use of `current_modref`, but I think we could avoid that with a more direct approach. Most of these changes are no-ops. For the relay handler, we no longer treat `GetProcAddress` calls inside `DllMain` as coming from a loaded DLL. I believe this was more of a side effect of how the code was structured rather than an intentional behavior that needs to be preserved. One more use of `current_modref` remains, which will be removed by !7. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7287

3 5

[PATCH 0/1] MR7291: maintainers: Add myself to the scrrun.dll section.
by Nikolay Sivov (＠nsivov) 08 Feb '25

08 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7291

2 1

[PATCH 0/1] MR7289: scrrun: implement ITextStream::WriteBlankLines().
by Damjan Jovanovic (＠dj) 08 Feb '25

08 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57810 Closes #57810 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7289

3 3

[PATCH v11 0/19] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 08 Feb '25

08 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v11: dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND dlls/oleaut32: Validate arguments in ITypeLibComp interface dlls/oleaut32: Validate arguments in ITypeComp interface This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH v10 0/19] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 08 Feb '25

08 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v10: dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND dlls/oleaut32: Validate arguments in ITypeLibComp interface dlls/oleaut32: Validate arguments in ITypeComp interface dlls/oleaut32: Consistently use TLB_get_bstr() dlls/oleaut32: Invert if stmt for clarity This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH v9 0/19] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 08 Feb '25

08 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v9: dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND dlls/oleaut32: Validate arguments in ITypeLibComp interface dlls/oleaut32: Validate arguments in ITypeComp interface dlls/oleaut32: Consistently use TLB_get_bstr() dlls/oleaut32: Invert if stmt for clarity dlls/oleaut32: Fix nonsensical memory access in ITypeLib2_Constructor_SLTG() This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH v8 0/14] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 08 Feb '25

08 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v8: dlls/oleaut32: Fix nonsensical memory access in ITypeLib2_Constructor_SLTG() https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

3 15

[PATCH v2 0/7] MR7275: windowscodecs: Implement CreateMetadataWriter().
by Nikolay Sivov (＠nsivov) 07 Feb '25

07 Feb '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: windowscodecs/metadata: Implement SetValue(). windowscodecs/tests: Add an item enumeration test for the App1 reader. windowscodecs/metadata: Add initial implementation of CreateMetadataWriterFromReader(). windowscodecs: Filter options in CreateMetadataWriter(). windowscodecs/metadata: Add a stub for WICApp1MetadataWriter. windowscodecs/metadata: Create nested writer instances when loading IFD data. windowscodecs: Implement CreateMetadataWriter(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7275

3 9

[PATCH 0/1] MR7285: urlmon/tests: Use wide character string literals.
by Alex Henrie (＠alexhenrie) 07 Feb '25

07 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7285

3 2

[PATCH v7 0/14] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 07 Feb '25

07 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v7: dlls/oleaut32: Fix nonsensical memory access in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Avoid ptr arithmetic in MSFT_DoVars() dlls/oleaut32: Avoid ptr arithmetic in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Shink down ITypeLibComp_fnBind() verbosity some dlls/oleaut32: ptr_size should be a ULONG dlls/oleaut32: Scope indexer to loops in fn[Is|Find]Name() dlls/oleaut32: Factor out TLB_get_funcparams_by_name() dlls/oleaut32: Factor out TLB_get_funcdesc_by_name() dlls/oleaut32: Validate args of ITypeLib2_fnIsName() dlls/oleaut32: fn(Is|Find)Name should set szNameBuf with correct case dlls/oleaut32: Use consistent param identifiers in fnFindName dlls/oleaut32: Mostly mirror fnFindName impl in typelib.c dlls/oleaut32: Use common and correct identifiers in typelib.c dlls/oleaut32: Consistently use lstrcmpiW() while looking for names https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 14

Re: [PATCH v5 0/2] MR7230: dmime: Fix loading and default soundfont collection. - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7230

1 0

Re: [PATCH v2 0/2] MR7280: gdiplus/tests: Extend a GdipGetPathGradientBlend() test with excessive output buffer size. - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7280

1 0

Re: [PATCH v18 0/4] MR4551: Server-side thread priorities implementation (Part 1) - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4551

1 0

Re: [PATCH v2 0/6] MR7284: Splay tree part 5 - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7284

1 0

Re: [PATCH v4 0/2] MR7283: documentation: Mac OS X became macOS from 10.12 - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7283

1 0

Re: [PATCH v2 0/2] MR7282: winemac: Fix issues found with Main Thread Checker - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7282

1 0

[PATCH v6 0/15] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 07 Feb '25

07 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v6: dlls/oleaut32: Fix nonsensical memory access in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Avoid ptr arithmetic in MSFT_DoVars() dlls/oleaut32: Avoid ptr arithmetic in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Fix GetRefTypeInfo() test dlls/oleaut32: Shink down ITypeLibComp_fnBind() verbosity some dlls/oleaut32: ptr_size should be a ULONG https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 15

[PATCH v4 0/2] MR7230: dmime: Fix loading and default soundfont collection.
by Yuxuan Shui (＠yshui) 07 Feb '25

07 Feb '25

* * * BTW I did try to create tests to make sure we connect collection the same way Windows does it. Problem is `GUID_ConnectToDLSCollection` is not gettable. Then I tried to create a `IDirectMusicPerformance` implementation and intercept `DownloadInstrument`. Interestingly Windows `IDirectMusicSegment::Download` doesn't call `DownloadInstrument` at all, instead it downloads instruments through a private, undocumented interface. So there seems to be no way to test this. -- v4: dmimi: Connect default collection to MIDI bandtrack. dmime: Handle IStream EOF correctly in MIDI parser. https://gitlab.winehq.org/wine/wine/-/merge_requests/7230

3 3

Re: [PATCH v5 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 07 Feb '25

07 Feb '25

On Fri Feb 7 20:18:51 2025 +0000, Nikolay Sivov wrote: > What this needs first is tests, and then fixes would could normally > touch more than just absolute minimum, like having some helpers etc. But > only renaming local variables is not something we normally do. Yes, three tests are fixed if you review. > absolute minimum That is why commits have been split up to make things trivially clear. > But only renaming local variables is not something we normally do. Except it isn't just renaming variables if you actually looked it over. No offense but this attitude to new contributions explains a lot about why this code is so horrifically inconsistent and in disrepair. There are multiple buffer overflows and deref of invalid ptr's, both of which controllable by the user and other subtle bugs. A few have been addressed here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7286#note_94040

1 0

[PATCH 0/2] MR7280: gdiplus/tests: Extend a GdipGetPathGradientBlend() test with excessive output buffer size.
by Nikolay Sivov (＠nsivov) 07 Feb '25

07 Feb '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7280

3 3

[PATCH v9 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 07 Feb '25

07 Feb '25

This fixes https://bugs.winehq.org/show_bug.cgi?id=52094. For reference, here's how current_modref is being passed around (before this patch): ```mermaid graph TB fii["fixup_imports_ilonly (directly sets current_modref)"] fi["fixup_imports (directly sets current_modref)"] pa["process_attach (directly sets current_modref)"] ld[load_dll] id["import_dll (directly uses current_modref)"] bin["build_import_name (directly uses current_modref)"] foe["find_ordinal_export (uses current_modref for relay)"] ffe["find_forwarded_export (directly uses current_modref)"] fne[find_named_export] MI[MODULE_InitDLL] fii --> ld fi --> id pa --> MI -.-> DllMain id --> bin id --> ld id --> foe id --> fne --> foe --> ffe --> foe ffe --> fne ffe --> bin style DllMain color:red; ``` -- v9: ntdll: Properly track refcount with forwarded exports. ntdll: Don't re-add a module dependency if it already exists. https://gitlab.winehq.org/wine/wine/-/merge_requests/7

3 10

Re: [PATCH v4 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Nikolay Sivov (＠nsivov) 07 Feb '25

07 Feb '25

What this needs first is tests, and then fixes would could normally touch more than just absolute minimum, like having some helpers etc. But only renaming local variables is not something we normally do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7286#note_94017

1 0

[PATCH v3 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 07 Feb '25

07 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v3: dlls/oleaut32: Scope indexer to loops in fn[Is|Find]Name() dlls/oleaut32: Factor out TLB_get_funcparams_by_name() dlls/oleaut32: Factor out TLB_get_funcdesc_by_name() dlls/oleaut32: Validate args of ITypeLib2_fnIsName() dlls/oleaut32: fn(Is|Find)Name should set szNameBuf with correct case dlls/oleaut32: Use consistent param identifiers in fnFindName dlls/oleaut32: Mostly mirror fnFindName impl in typelib.c https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 9

[PATCH v3 0/2] MR7230: dmime: Fix loading and default soundfont collection.
by Yuxuan Shui (＠yshui) 07 Feb '25

07 Feb '25

* * * BTW I did try to create tests to make sure we connect collection the same way Windows does it. Problem is `GUID_ConnectToDLSCollection` is not gettable. Then I tried to create a `IDirectMusicPerformance` implementation and intercept `DownloadInstrument`. Interestingly Windows `IDirectMusicSegment::Download` doesn't call `DownloadInstrument` at all, instead it downloads instruments through a private, undocumented interface. So there seems to be no way to test this. -- v3: dmimi: Connect default collection to MIDI bandtrack. dmime: Handle IStream EOF correctly in MIDI parser. https://gitlab.winehq.org/wine/wine/-/merge_requests/7230

4 7

[PATCH v2 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 07 Feb '25

07 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v2: dlls/oleaut32: Scope indexer to loops in fn[Is|Find]Name() dlls/oleaut32: Factor out TLB_get_funcparams_by_name() https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 9

[PATCH 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 07 Feb '25

07 Feb '25

Make both method calls; Consistently written with parameter names as per spec. Fix parameter validation to be consistent with spec. Fix szNameBuf parameter semantics as per spec. Fix szNameBuf casing str search as per spec. Factor out common code into TLB_ helpers vastly improves readability. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 9

[PATCH 0/6] MR7284: Splay tree part 5
by Zhiyi Zhang (＠zhiyi) 07 Feb '25

07 Feb '25

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7284

2 6

[PATCH v3 0/2] MR7283: documentation: Mac OS X became macOS from 10.12
by Dean M Greer (＠Gcenx) 07 Feb '25

07 Feb '25

-- v3: readme: Update mac info section https://gitlab.winehq.org/wine/wine/-/merge_requests/7283

2 3

Re: [PATCH v2 0/1] MR7283: documentation: Mac OS X became macOS from 10.12
by Alfred Agrell (＠Alcaro) 07 Feb '25

07 Feb '25

Alfred Agrell (@Alcaro) commented about README.md: > Make sure you have the USER_LDT, SYSVSHM, SYSVSEM, and SYSVMSG options > turned on in your kernel. > > **Mac OS X info**: Not gonna update this one? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7283#note_93987

1 0

[PATCH 0/1] MR7283: documentation: Mac OS X became macOS from 10.12
by Dean M Greer (＠Gcenx) 07 Feb '25

07 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7283

2 1

[PATCH v4 0/4] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu (＠insn) 06 Feb '25

06 Feb '25

-- v4: server: When renaming, only fstat the source once. server: Remove source when renaming to a hardlink of itself. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

3 13

[PATCH 0/2] MR7282: winemac: Fix issues found with Main Thread Checker
by Brendan Shanks (＠bshanks) 06 Feb '25

06 Feb '25

Fix 3 calls to AppKit that were not being done from the main thread, found using Apple's [Main Thread Checker](https://developer.apple.com/documentation/xcode/diagnosing-memory-…. I used it with Wine by dlopen()ing `/Applications/Xcode.app/Contents/Developer/usr/lib/libMainThreadChecker.dylib` in `macdrv_init()`, commenting out the `SIGABRT` handler in `signal_x86_64.c`, and setting `MTC_CRASH_ON_REPORT=1` so the process will `abort()` and eventually generate a crash log+backtrace. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7282

3 3

Re: [PATCH v2 0/1] MR7267: explorerframe: Return S_OK in more ITaskbarList3 functions. - approved
by Alexandre Julliard (＠julliard) 06 Feb '25

06 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7267

1 0

Re: [PATCH v2 0/1] MR7271: wineboot: Add dummy entry for SystemBiosDate - approved
by Alexandre Julliard (＠julliard) 06 Feb '25

06 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7271

1 0

Re: [PATCH v2 0/1] MR7276: jscript: Fix JSON.stringify for arrays longer than 10. - approved
by Alexandre Julliard (＠julliard) 06 Feb '25

06 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7276

1 0

Re: [PATCH v2 0/1] MR7278: winhttp: Check for the end of the text when stripping trailing newlines from headers (ASan). - approved
by Alexandre Julliard (＠julliard) 06 Feb '25

06 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7278

1 0

Re: [PATCH v2 0/1] MR7277: winewayland: Round the Wayland refresh rate to calculate the win32 display frequency. - approved
by Alexandre Julliard (＠julliard) 06 Feb '25

06 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7277

1 0

Re: [PATCH v2 0/1] MR7274: hhctrl: Make "Select Topic" window title translatable. - approved
by Alexandre Julliard (＠julliard) 06 Feb '25

06 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7274

1 0

Re: [PATCH v2 0/5] MR7273: Splay tree part 4 - approved
by Alexandre Julliard (＠julliard) 06 Feb '25

06 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7273

1 0

Re: [PATCH v3 0/4] MR7183: gdi32: Fix 64 bit EMREXTCREATEPEN. - approved
by Alexandre Julliard (＠julliard) 06 Feb '25

06 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7183

1 0

[PATCH 0/1] MR7258: winebuild: Make binaries without spec file reproduceable
by Fabian Maurer (＠DarkShadow44) 06 Feb '25

06 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41342 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7258

3 4

[PATCH 0/7] MR7275: windowscodecs: Implement CreateMetadataWriter().
by Nikolay Sivov (＠nsivov) 06 Feb '25

06 Feb '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7275

3 13

[PATCH v2 0/2] MR7230: dmime: Fix loading and default soundfont collection.
by Yuxuan Shui (＠yshui) 06 Feb '25

06 Feb '25

* * * BTW I did try to create tests to make sure we connect collection the same way Windows does it. Problem is `GUID_ConnectToDLSCollection` is not gettable. Then I tried to create a `IDirectMusicPerformance` implementation and intercept `DownloadInstrument`. Interestingly Windows `IDirectMusicSegment::Download` doesn't call `DownloadInstrument` at all, instead it downloads instruments through a private, undocumented interface. So there seems to be no way to test this. -- v2: dmimi: Connect default collection to MIDI bandtrack. dmime: Handle IStream EOF correctly in MIDI parser. https://gitlab.winehq.org/wine/wine/-/merge_requests/7230

5 12

[PATCH v8 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 06 Feb '25

06 Feb '25

This fixes https://bugs.winehq.org/show_bug.cgi?id=52094. -- v8: ntdll: Properly track refcount with forwarded exports. ntdll: Don't re-add a module dependency if it already exists. ntdll: Remove some unnecessary NULL checks for current_importer. ntdll: Set export forwarder DLL as the dynamic importer in LdrGetProcedureAddress(). ntdll: Wrap current_modref variable in a new structure. https://gitlab.winehq.org/wine/wine/-/merge_requests/7

4 15

[PATCH 0/1] MR7276: jscript: Fix JSON.stringify for arrays longer than 10.
by Arek Hiler (＠ivyl) 06 Feb '25

06 Feb '25

We've been passing `ARRAY_SIZE()` (equal to 16 in this case) as a radix to _itow(). This has caused us trying to get "a" instead of "10", etc. which resulted in unexpected nulls being interspersed in long arrays as well as the arrays being cut short. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7276

3 3

[PATCH 0/1] MR7278: winhttp: Check for the end of the text when stripping trailing newlines from headers (ASan).
by Nikolay Sivov (＠nsivov) 06 Feb '25

06 Feb '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7278

3 2

[PATCH 0/3] MR7241: winewayland: Basic input method support.
by Attila Fidan (＠atticf) 06 Feb '25

06 Feb '25

This MR tries to implement the SetIMECompositionRect user driver function and partially the WINE_IME_POST_UPDATE message call. It requires support for zwp_text_input_v3 from the compositor. It supports submitting committed text to the win32 side and notifying the compositor about the area of the text cursor rectangle. This doesn't add support for embedded pre-edit because I couldn't immediately get it to appear. Either I did something incorrect, or it has something to do with Wayland. On X11, the pre-edit appears completely separated to the application window and doesn't move with it, which doesn't seem to be compatible with Wayland. If Windows has the surrounding text feature, it does not seem possible to support it here with the provided interface. The IME is always enabled on the focused surface, like on X11. If Windows has a facility that applications can use to say that it does or does not accept text entry at certain parts of the UI, it does not seem possible to support it here with the provided interface. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7241

4 7

[PATCH v4 0/2] MR7115: Added support of case FileAllocationInformation in SetFileInformationByHandle
by Stéphane Bacri (＠fr33z00) 06 Feb '25

06 Feb '25

This MR intends to add support for the case FileAllocationInformation in function SetFileInformationByHandle of library kernelbase.dll. The code is based on my understanding of [MS documentation](https://learn.microsoft.com/en-us/windows-hardware/drivers/d… No test was added, because other cases that could have helped doing so (FileEndOfFileInformation) do not have neither. -- v4: Used posix_fallocate in place of ftruncate + added related test Merge remote-tracking branch 'main/master' into setFileInformationByHandle https://gitlab.winehq.org/wine/wine/-/merge_requests/7115

4 9

[PATCH 0/1] MR7277: winewayland: Round the Wayland refresh rate to calculate the win32 display frequency.
by Alexandros Frantzis (＠afrantzis) 06 Feb '25

06 Feb '25

Round the Wayland refresh rate instead of floor-ing it, to report a more accurate win32 display frequency. This can slightly improve FPS values in games that use the reported display frequency to drive their rendering. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56542 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7277

2 1

[PATCH v12 0/3] MR7052: vbscript: implement Join()
by Francis De Brabandere (＠francisdb) 06 Feb '25

06 Feb '25

closes https://bugs.winehq.org/show_bug.cgi?id=56464 -- v12: clean up created strings https://gitlab.winehq.org/wine/wine/-/merge_requests/7052

2 4

[PATCH v11 0/2] MR7052: vbscript: implement Join()
by Francis De Brabandere (＠francisdb) 06 Feb '25

06 Feb '25

closes https://bugs.winehq.org/show_bug.cgi?id=56464 -- v11: also set len if we have an existing string https://gitlab.winehq.org/wine/wine/-/merge_requests/7052

2 2

[PATCH v12 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 06 Feb '25

06 Feb '25

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v12: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour ntdll: Test updated NtQueryDirectoryFile mask reset behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

4 5

Re: [PATCH v26 0/2] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows - approved
by eric pouech (＠epo) 06 Feb '25

06 Feb '25

This merge request was approved by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131

1 0

[PATCH v2 0/4] MR7183: gdi32: Fix 64 bit EMREXTCREATEPEN.
by Stefan Dösinger (＠stefan) 06 Feb '25

06 Feb '25

-- v2: gdi32/tests: Add an EMREXTCREATEPEN test. gdi32: EMREXTCREATEPEN contains a 32 bit EXTLOGPEN. gdi32: Set EMREXTCREATEPEN offBmi and offBits. gdi32: Windows adds an extra 4 bytes to EMREXTCREATEPEN. https://gitlab.winehq.org/wine/wine/-/merge_requests/7183

3 6

[PATCH v25 0/2] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 06 Feb '25

06 Feb '25

"DIR /o" (no order specifier after /o) hasn't functioned the same as it does on Windows. This change makes the functionality of /o by itself equivalent to behavior on Windows. -- v25: programs/cmd: Cleanup DIR /O logic and remove @todo_wine@ from working tests. programs/cmd/tests: Add tests for command DIR /O. https://gitlab.winehq.org/wine/wine/-/merge_requests/7131

2 2

[PATCH 0/1] MR7274: hhctrl: Make "Select Topic" window title translatable.
by Alex Henrie (＠alexhenrie) 06 Feb '25

06 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57738 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7274

2 1

[PATCH 0/5] MR7273: Splay tree part 4
by Zhiyi Zhang (＠zhiyi) 06 Feb '25

06 Feb '25

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7273

2 5

[PATCH 0/1] MR7227: winex11.drv: Choose alpha-enabled xrender format for argb drawables.
by Paul Gofman (＠gofman) 05 Feb '25

05 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7227

4 22

Re: [PATCH v2 0/1] MR7269: imm32: Always validate the IME UI window when painting. - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7269

1 0

Re: [PATCH v2 0/1] MR7270: ntdll: Zero terminate return string for NtQueryInformationProcess( ProcessImageFileName[Win32] ). - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7270

1 0

Re: [PATCH v3 0/1] MR7268: ntdll: Fix syscall_cfa offset in user_mode_abort_thread for ARM64. - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7268

1 0

Re: [PATCH v2 0/1] MR7266: light.msstyles: Use light blue as hot tracking color instead of grey. - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7266

1 0

Re: [PATCH v2 0/1] MR7265: winhttp: Accept server response without status text. - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7265

1 0

Re: [PATCH v5 0/3] MR7255: winex11.drv: Choose alpha-enabled xrender format for argb drawables. (alt) - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7255

1 0

Re: [PATCH v2 0/3] MR7259: windows.networking.connectivity: Add IConnectionProfile2 stubs - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7259

1 0

Re: [PATCH v4 0/10] MR7254: windowscodecs: Move component info registry key cleanup to a common failure path. - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7254

1 0

Re: [PATCH v2 0/6] MR7261: Splay tree part 3 - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7261

1 0

Re: [PATCH v2 0/1] MR7263: hhctrl: Fix window class name in HH_CreateHelpWindow. - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7263

1 0

Re: [PATCH v2 0/1] MR7264: prntvpt: Use Windows 10 version numbers. - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7264

1 0

Re: [PATCH v2 0/3] MR7222: wined3d: Housekeeping for NV12 support. - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7222

1 0

Re: [PATCH v3 0/4] MR7260: wined3d: Clean up some FFP settings a bit. - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7260

1 0

Re: [PATCH v3 0/1] MR7262: ieframe: Use wide character string literals. - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7262

1 0

[PATCH 0/25] MR7226: ntdll: Implement in-process synchronization via the Linux "ntsync" driver.
by Elizabeth Figura (＠zfigura) 05 Feb '25

05 Feb '25

This introduces a faster implementation of signal and wait operations on NT events, semaphores, and mutexes, which improves performance to native levels for a wide variety of games and other applications. The goal here is similar to the long-standing out-of-tree "esync" and "fsync" patch sets, but without the flaws that make those patch sets not upstreamable. The Linux "ntsync" driver is not currently released. It has been accepted into the trunk Linux tree for 6.14, so barring any extraordinary circumstances, the API is frozen and it will be released in its current form in about 2 months. Since it has passed all relevant reviewers on the kernel side, and the API is all but released, it seems there is no reason any more not to submit the Wine side to match. Some important notes: * This patch set does *not* include any way to disable ntsync support, since that kind of configuration often seems to be dispreferred where not necessary. In essence, ntsync should just work everywhere. Probably the easiest way to effectively disable ntsync, for the purposes of testing, is to chmod the /dev/ntsync device to prevent its being opened. Regardless, a Wine switch to disable ntsync can be added simply enough. Note that it should probably not take the form of a registry key, however, since it needs to be easily accessible from the server itself. * It is, generally speaking, not possible for only some objects, or some processes, to have backing ntsync objects, while others use the old server path. The esync/fsync patch sets explicitly protected against this by making sure every process had a consistent view of whether esync was enabled. This is not provided here, since no switch is provided to toggle ntsync, and it should not be possible to get into such an inconsistent state without gross misconfiguration. * Similarly, no diagnostic messages are provided to note that ntsync is in use, or not in use. These messages are part of esync/fsync, as well as part of ntsync "testing" trees unofficially distributed. However, if ntsync is working correctly, no message should be necessary. The basic structure is: * Each type of server object which can be waited on by the client (including events, semaphores, mutexes, but also other types such as processes, files) must store an "inproc_sync" object. This "inproc_sync" object is a full server object (note that this differs from esync/fsync). A vector and server request is introduced to retrieve an NT handle to this object from an arbitrary NT handle. Since the actual ntsync objects are simply distinct file descriptions, we then call get_handle_fd from the client to retrieve an fd to the object, and then perform ioctls on it. * Objects signaled by the server (processes, files, etc) perform ntsync ioctls on that object. The backing object in all such cases is simply an event. * Signal and wait operations on the client side attempt to defer to an "inproc_*" function, falling back to the server implementation if it returns STATUS_NOT_IMPLEMENTED. This mirrors how in-process synchronization objects (critical sections, SRW locks, etc) used to be implemented—attempting to use an architecture-specific "fast_*" function and falling back if it returned STATUS_NOT_IMPLEMENTED. * The inproc_sync handles, once retrieved, are cached per-process. This caching takes a similar form to the fd cache. It does not reuse the same infrastructure, however. The primary reason for this is that the fd cache is designed to fit within a 64-bit value and uses 64-bit atomic operations to ensure consistency. However, we need to store more than 64 bits of information. [We also need to modify them after caching, in order to correctly implement handle closing—see below.] The secondary reason is that retrieving the ntsync fd from the inproc_sync handle itself uses the fd cache. * In order to keep the Linux driver simple, it does not implement access flags (EVENT_MODIFY_STATE etc.) Instead, the flags are cached locally and validated there. This too mirrors the fd cache. Note that this means that a malicious process can now modify objects it should not be able modify—which is less true than it is with wineserver—but this is no different from the way other objects (notably fds) are handled, and would require manual syscalls. * In order to achieve correct behaviour related to closing objects while they are used, this patch set essentially relies on refcounting. This is broadly true of the server as well, but because we need to avoid server calls when performing object operations, significantly more care must be taken. In particular, because waits need to be interruptable by signals and then be restarted, we need the backing ntsync object to remain valid until all users are done with it. On a process level, this is achieved by letting multiple processes own handles to the underlying inproc_sync server object. On a thread level, multiple simultaneous calls need to refcount the process's local handle. This refcount is stored in the sync object cache. When it reaches zero, the cache is cleared. Punting this behaviour to the Linux driver would have introduced a great deal more complexity, which is best kept in userspace and out of the kernel. * The cache is, as such, treated as a cache. The penultimate commit, which introduces client support but does not yet cache the objects, effectively illustrates this by never actually caching anything, and retrieving a new NT handle and fd every time. * Certain waits, on internal handles (such as async, startup_info, completion), are delegated to the server even when ntsync is used. Those server objects do not create an underlying ntsync object. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7226

8 34

Re: [PATCH v3 0/3] MR7256: ntdll: monotonic_counter and NtQuerySystemTime performance improvements on macOS.
by Brendan Shanks (＠bshanks) 05 Feb '25

05 Feb '25

On Tue Feb 4 22:24:37 2025 +0000, Marc-Aurel Zent wrote: > Indeed, but this commit essentially inlines the call to > `__commpage_gettimeofday()` inside `gettimeofday()`, wheres the latter > still incurs of overhead of 23 CPU cycles before calling into > `__commpage_gettimeofday()`, if I counted correctly. > It actually does more than inlining though, `gettimeofday()`, will do a > syscall if `__commpage_gettimeofday()` fails, and use that value instead. > This can happen rarely (about 1 in a million in my testing), probably > when page time values that are updated asynchronously from the kernel > are read simultaneously. > As the commit is right now, it effectively tries to read from the > commpage *twice*, making that chance of doing a syscall astronomically low. > Also it is still measurably faster to use `__commpage_gettimeofday()` > directly (benchmarked at 10000000 iterations through Rosetta): > ``` > clock_gettime() Duration: 0.290506 seconds > gettimeofday() Duration: 0.233024 seconds > __commpage_gettimeofday() Duration: 0.217468 seconds > ``` IMO, this feels like a micro-optimization that isn't worth the complexity and risk to save 23 cycles per call. If it makes a meaningful difference in a game benchmark it could be worth it, but otherwise it feels better to chase bigger gains. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7256#note_93758

1 0

[PATCH v23 0/2] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 05 Feb '25

05 Feb '25

"DIR /o" (no order specifier after /o) hasn't functioned the same as it does on Windows. This change makes the functionality of /o by itself equivalent to behavior on Windows. -- v23: programs/cmd: Cleanup DIR /O logic and remove @todo_wine@ from working tests. programs/cmd/tests: Add tests for command DIR /O. https://gitlab.winehq.org/wine/wine/-/merge_requests/7131

2 3

[PATCH 0/1] MR7271: wineboot: Add dummy entry for SystemBiosDate
by Sebastian Scheibner (＠sebastian) 05 Feb '25

05 Feb '25

The software Helicon Filter 5 crashes at startup when it tries to query the registry entry `SystemBiosDate` under `HKEY_LOCAL_MACHINE\Hardware\Description\System`, which doesn't exist in the wine registry. That part of the registry is volatile, so the workaround of just adding that key is short lived. In this commit I just added a dummy date (01/01/70) for simplicity, not sure if that's ok? There's code in wineboot.c which sets the actual BIOS date into the `BIOSReleaseDate` key. That could potentially be used, but it has a different format: 01/01/1970 (four digits for the year instead of two) I've found no official documentation of the `SystemBiosDate` key. The only place I've found is in an example on this page: https://learn.microsoft.com/en-us/windows-hardware/drivers/debuggercmds/-reg <details><summary>Wine log from startup crash when querying SystemBiosDate</summary> <pre> 0024:Call advapi32.RegOpenKeyExA(80000002,00810cdc "HARDWARE\\DESCRIPTION\\System",00000000,00020019,00e6fb68) ret=00440607 0024:Call ntdll.RtlRunOnceExecuteOnce(7b69ec60,7b65bad0,00000000,00000000) ret=7b6106d9 0024:Ret ntdll.RtlRunOnceExecuteOnce() retval=00000000 ret=7b6106d9 0024:Call ntdll.wcscpy(00e6f9ac,7b69ec94 L"") ret=7b60ce6b 0024:Ret ntdll.wcscpy() retval=00e6f9ac ret=7b60ce6b 0024:Call ntdll.RtlInitAnsiString(00e6fadc,00810cdc "HARDWARE\\DESCRIPTION\\System") ret=7b62f0bc 0024:Ret ntdll.RtlInitAnsiString() retval=0000001c ret=7b62f0bc 0024:Call ntdll.RtlAnsiStringToUnicodeString(7ffc2bf8,00e6fadc,00000000) ret=7b62f0e1 0024:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=7b62f0e1 0024:Call ntdll.NtOpenKeyEx(00e6fb68,00020019,00e6f9a8,00000000) ret=7b65e875 0024:Ret ntdll.NtOpenKeyEx() retval=00000000 ret=7b65e875 0024:Call ntdll.RtlNtStatusToDosError(00000000) ret=7b62f0f1 0024:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=7b62f0f1 0024:Ret advapi32.RegOpenKeyExA() retval=00000000 ret=00440607 0024:Call advapi32.RegQueryValueExA(000000f8,00810cc4 "SystemBiosDate",00000000,00e6fb58,00000000,00e6fb74) ret=00440c43 0024:Call ntdll.RtlInitAnsiString(00e6f9b0,00810cc4 "SystemBiosDate") ret=7b6305f6 0024:Ret ntdll.RtlInitAnsiString() retval=0000000f ret=7b6305f6 0024:Call ntdll.RtlAnsiStringToUnicodeString(00e6f9b8,00e6f9b0,00000001) ret=7b630614 0024:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=7b630614 0024:Call ntdll.NtQueryValueKey(000000f8,00e6f9b8,00000002,00e6f9c0,00000100,00e6f9a8) ret=7b630695 0024:Ret ntdll.NtQueryValueKey() retval=c0000034 ret=7b630695 0024:Call ntdll.RtlFreeUnicodeString(00e6f9b8) ret=7b6306c0 0024:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=7b6306c0 0024:Call ntdll.RtlNtStatusToDosError(c0000034) ret=7b6306d2 0024:Ret ntdll.RtlNtStatusToDosError() retval=00000002 ret=7b6306d2 0024:Ret advapi32.RegQueryValueExA() retval=00000002 ret=00440c43 0024:Call advapi32.RegCloseKey(000000f8) ret=00440433 0024:Call ntdll.NtClose(000000f8) ret=7b628979 0024:Ret ntdll.NtClose() retval=00000000 ret=7b628979 0024:Call ntdll.RtlNtStatusToDosError(00000000) ret=7bcebd50 0024:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=7bcebd50 0024:Ret advapi32.RegCloseKey() retval=00000000 ret=00440433 0024:Call user32.LoadStringA(00400000,0000fff0,00e6eb54,00001000) ret=0040879f 0024:Call ntdll.LdrFindResource_U(00400000,00e6ea4c,00000003,00e6ea38) ret=7b5fbb3b 0024:Ret ntdll.LdrFindResource_U() retval=00000000 ret=7b5fbb3b 0024:Call ntdll.LdrAccessResource(00400000,00b033e0,00e6eac0,00000000) ret=7b6148f6 0024:Ret ntdll.LdrAccessResource() retval=00000000 ret=7b6148f6 0024:Ret user32.LoadStringA() retval=00000021 ret=0040879f 0024:Call KERNEL32.RaiseException(0eedfade,00000001,00000007,00e6fb88) ret=00417362 0024:trace:seh:dispatch_exception code=eedfade (unknown) flags=1 addr=7B627448 0024:trace:seh:dispatch_exception info[0]=00417362 0024:trace:seh:dispatch_exception info[1]=02B80430 0024:trace:seh:dispatch_exception info[2]=0041625C 0024:trace:seh:dispatch_exception info[3]=00E6FBB8 0024:trace:seh:dispatch_exception info[4]=00000000 0024:trace:seh:dispatch_exception info[5]=00E6FDF8 0024:trace:seh:dispatch_exception info[6]=00E6FBA4 0024:trace:seh:dispatch_exception eip=7b627448 esp=00e6fae0 ebp=00e6fb38 eflags=00000246 0024:trace:seh:dispatch_exception eax=00e6fae0 ebx=00000018 ecx=00e6faf4 edx=00e6fb88 0024:trace:seh:dispatch_exception esi=00e6fdf8 edi=00e6fb50 cs=0023 ds=002b es=002b fs=0063 gs=006b ss=002b 0024:trace:seh:call_seh_handlers calling handler at 00810CAC code=eedfade flags=1 0024:trace:seh:call_seh_handlers handler at 00810CAC returned 1 0024:trace:seh:call_seh_handlers calling handler at 00874F3A code=eedfade flags=1 0024:trace:seh:call_seh_handlers handler at 00874F3A returned 1 0024:trace:seh:call_seh_handlers calling handler at 0096B5C7 code=eedfade flags=1 0024:trace:seh:call_seh_handlers handler at 0096B5C7 returned 1 0024:trace:seh:call_seh_handlers calling handler at 004059FC code=eedfade flags=1 0024:Call KERNEL32.UnhandledExceptionFilter(00e6ef18) ret=00405a20 0024:Call ntdll.NtQueryInformationProcess(ffffffff,0000000c,00e6ee84,00000004,00000000) ret=7b602304 0024:Ret ntdll.NtQueryInformationProcess() retval=00000000 ret=7b602304 0024:Call ntdll.NtCreateEvent(00e6eeac,001f0003,00e6eeb0,00000000,00000000) ret=7b642f85 0024:Ret ntdll.NtCreateEvent() retval=00000000 ret=7b642f85 wine: Unhandled exception 0x0eedfade in thread 24 at address 7B627448 (thread 0024), starting debugger... </pre> </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7271

2 1

[PATCH 0/1] MR7270: ntdll: Zero terminate return string for NtQueryInformationProcess( ProcessImageFileName[Win32] ).
by Paul Gofman (＠gofman) 05 Feb '25

05 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7270

2 1

[PATCH v3 0/4] MR7251: TLS slots alignment.
by eric pouech (＠epo) 05 Feb '25

05 Feb '25

This MR enforces alignment of TLS slots as described in PE file. -- v3: ntdll: Let layout of TLS vector be closer to native. ntdll: Enforce the alignment of TLS directory entries. kernel32: Add test for TLS memory layout. kernel32/tests: Add a test about TLS slot alignment. https://gitlab.winehq.org/wine/wine/-/merge_requests/7251

3 5

[PATCH 0/1] MR7269: imm32: Always validate the IME UI window when painting.
by Tim Clem (＠tclem) 05 Feb '25

05 Feb '25

Even when there is no context. Prevents a storm of WM_PAINTs if the window is somehow shown in that case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7269

3 2

Re: [PATCH v17 0/4] MR4551: Server-side thread priorities implementation (Part 1)
by Marc-Aurel Zent (＠mzent) 05 Feb '25

05 Feb '25

Rebased and seems to be still working fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4551#note_93740

1 0

[PATCH v2 0/1] MR7268: ntdll: Fix syscall_cfa offset in user_mode_abort_thread for ARM64.
by Jinoh Kang (＠iamahuman) 05 Feb '25

05 Feb '25

Otherwise sending ^C to a running ARM64 process crashes it randomly. Note that 0x110 is prev_frame, the field that immediately precedes syscall_cfa. Fixes: ca79629b3e436c8799281319dd313249bf05b9b5 -- v2: ntdll: Fix syscall_cfa offset in user_mode_abort_thread for ARM64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7268

2 1

[PATCH 0/1] MR7268: ntdll: Fix syscall_cfa offset in user_mode_abort_thread.
by Jinoh Kang (＠iamahuman) 05 Feb '25

05 Feb '25

Otherwise sending ^C to a running ARM64 process crashes it randomly. Note that 0x110 is prev_frame, the field that immediately precedes syscall_cfa. Fixes: ca79629b3e436c8799281319dd313249bf05b9b5 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7268

2 1

2025

2024

2023

2022

wine-gitlab