- wine-gitlab - winehq.org

[PATCH 0/1] MR7374: wine.inf: Add VC runtime version key.
by Bernhard Kölbl (＠besentv) 19 Feb '25

19 Feb '25

The Unreal engine bootstrapper relies on this to detect VC presence since version 5.3. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7374

4 4

[PATCH v2 0/5] MR7370: Draft: winex11: Pass fullscreen flag to is_window_managed.
by Rémi Bernon (＠rbernon) 19 Feb '25

19 Feb '25

Instead of checking for monitor rect. Similar purpose as https://gitlab.winehq.org/wine/wine/-/merge_requests/7362 -- v2: winewayland: Pass fullscreen flag to is_window_managed. winex11: Pass fullscreen flag to is_window_managed. winex11: Check managed window changes in WindowPosChanged. winex11: Request managed window changes asynchronously. winex11: Initialize window managed flag in create_whole_window. https://gitlab.winehq.org/wine/wine/-/merge_requests/7370

2 7

[PATCH 0/1] MR7372: winegstreamer: Fix a compiler warning with GStreamer 1.18 or lower.
by Sven Baars (＠sbaars) 19 Feb '25

19 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7372

3 2

[PATCH 0/1] MR7373: win32u: Fix an uninitialized variable warning on GCC 10.
by Sven Baars (＠sbaars) 19 Feb '25

19 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7373

3 2

[PATCH 0/5] MR7370: winex11: Pass fullscreen flag to is_window_managed.
by Rémi Bernon (＠rbernon) 19 Feb '25

19 Feb '25

Instead of checking for monitor rect. Similar purpose as https://gitlab.winehq.org/wine/wine/-/merge_requests/7362 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7370

2 6

Re: [PATCH 0/1] MR7369: include/security.h: Add definition of NEGOSSP_NAME
by Nikolay Sivov (＠nsivov) 19 Feb '25

19 Feb '25

Looks like gitlab fails to apply due to utf-8 in committer name. It's probably the easiest to change that to English, and also please change single line comment style to /**/ . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7369#note_95161

1 0

[PATCH v4 0/1] MR7339: ntdll: implement create_logical_proc_info on FreeBSD.
by Damjan Jovanovic (＠dj) 19 Feb '25

19 Feb '25

Add Expat as a dependency, and use it to parse the XML returned from FreeBSD's kern.sched.topology_spec sysctl. -- v4: ntdll: implement create_logical_proc_info on FreeBSD. https://gitlab.winehq.org/wine/wine/-/merge_requests/7339

3 5

[PATCH 0/1] MR7364: msxml3: Use wide character string literals.
by Alex Henrie (＠alexhenrie) 19 Feb '25

19 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7364

3 2

Re: [PATCH v7 0/2] MR5238: krnl386, mmsystem: Simulate a hardware interrupt in MMSYSTDRV_Callback3216.
by Alexandre Julliard (＠julliard) 19 Feb '25

19 Feb '25

Please don't add Wine-specific exports. You could simply pass a new flag to WOWCallback16Ex. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5238#note_95142

1 0

[PATCH 0/1] MR7357: rpcrt4: Avoid unsigned overflows in buffer validation.
by Jacek Caban (＠jacek) 19 Feb '25

19 Feb '25

Fixes Clang 20 `-Wtautological-compare` warnings. Based on patch by William Horvath. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7357

4 3

[PATCH 0/4] MR7272: wined3d: NV12 textures, part 1/2.
by Elizabeth Figura (＠zfigura) 19 Feb '25

19 Feb '25

The first 4 patches of a 12-patch series. The remaining 8 can be browsed here: https://gitlab.winehq.org/zfigura/wine/-/commits/dxvaup ending in "d3d11/tests: Extend NV12 tests." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7272

3 5

[PATCH 0/3] MR7182: winex11: Keep track and use expected window focus time on WM_STATE changes.
by Rémi Bernon (＠rbernon) 19 Feb '25

19 Feb '25

This is an attempt at improving X11 focus handling, and will most importantly be useful to later better handle dynamic window decoration changes on any mutter-based window manager. These window managers do a little dance in that case, unmapping/mapping the window every time decoration are added/removed, and we often get confused by the focus events it triggers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7182

3 6

[PATCH v2 0/2] MR7313: wined3d: Fix blitting from CLEARED in the Vulkan renderer.
by Elizabeth Figura (＠zfigura) 19 Feb '25

19 Feb '25

This broke after d58e917e2cb36c6ffcb259356c06171d8f6d4dcc in some situations, since it resulted in us calling wined3d_texture_download_from_texture() with CLEARED location. The latter was not aware of CLEARED and incorrectly assumed the source texture was in TEXTURE_SRGB. -- v2: wined3d: Explicitly check for BUFFER/SYSMEM before calling wined3d_texture_download_from_texture(). wined3d: Propagate a CLEARED location when blitting. https://gitlab.winehq.org/wine/wine/-/merge_requests/7313

3 3

[PATCH 0/1] MR7361: configure.ac,tools/makedep: (re)introduce wine wrapper script in build tree.
by eric pouech (＠epo) 19 Feb '25

19 Feb '25

commit cb87d40cd4a8837826ea76efc91371ab09eb9d63 removed the ability (from the inside the tools/wine-wrapper) to have some local settings (per build tree) where one can adapt environment for launching wine this MR allows at configure time to specify an (external) wine wrapper to use for a given build tree Signed-off-by: Eric Pouech epouech(a)codeweavers.com -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7361

3 5

[PATCH 0/2] MR7366: mf: Add tests and fixes to correct usage with a new WMV decoder MFT.
by Brendan McGrath (＠redmcg) 19 Feb '25

19 Feb '25

The Microsoft WMV decoder has a bug/feature where orientation of the first output type determines the orientation for all subsequent RGB output types. If the transform is created new, then the orientation is determined by the value of the MF_MT_DEFAULT_STRIDE. This MR adds tests for that behavior and implements it in Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7366

2 2

[PATCH v2 0/5] MR7317: Server-side thread priorities implementation (Part 2)
by Marc-Aurel Zent (＠mzent) 19 Feb '25

19 Feb '25

This adds Mach thread priority support (both in the application and realtime band) and recalculates thread priorities when the process priority changes. Part 3, which is still a bit WIP deals with implementing priority boosts (for main threads and threads which are processing window messages), effectively fully replacing https://gitlab.winehq.org/wine/wine/-/merge_requests/1232. Currently the implementation in this MR already technically overrides what https://gitlab.winehq.org/wine/wine/-/… [View More]

5 11

[PATCH v2 0/11] MR7244: mfplat: Fix some memory leaks.
by Conor McCarthy (＠cmccarthy) 19 Feb '25

19 Feb '25

Goes atop !7174 -- v2: rtworkq: Do not cancel pending callbacks when closing a thread pool. rtworkq/tests: Test queue shutdown with pending items. https://gitlab.winehq.org/wine/wine/-/merge_requests/7244

4 22

[PATCH 0/8] MR7350: windowscodecs/tests: Add some tests for default metadata item set.
by Nikolay Sivov (＠nsivov) 19 Feb '25

19 Feb '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7350

3 12

[PATCH v28 0/33] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 19 Feb '25

19 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v28: dlls/oleaut32: Read in the hashmap data while loading typelib This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of … [View More]

1 0

Re: [PATCH v2 0/1] MR7340: winegstreamer: Implement IWMSyncReader2::GetMaxOutputSampleSize. - approved
by Alexandre Julliard (＠julliard) 18 Feb '25

18 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7340

1 0

Re: [PATCH v2 0/2] MR7358: quartz: Fix for stream position setting after receiving EOS. - approved
by Alexandre Julliard (＠julliard) 18 Feb '25

18 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7358

1 0

Re: [PATCH v2 0/1] MR7359: winewayland: Don't crash on text input done events without focus. - approved
by Alexandre Julliard (＠julliard) 18 Feb '25

18 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7359

1 0

Re: [PATCH v5 0/5] MR7347: ntdll: Avoid process_attach() even indirectly if loaded with `DONT_RESOLVE_DLL_REFERENCES` - approved
by Alexandre Julliard (＠julliard) 18 Feb '25

18 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7347

1 0

Re: [PATCH v6 0/3] MR7237: include: Fix ReadNoFence64 on i386. - approved
by Alexandre Julliard (＠julliard) 18 Feb '25

18 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7237

1 0

Re: [PATCH v2 0/7] MR7354: win32u: Improve modeset emulation virtual mode list. - approved
by Alexandre Julliard (＠julliard) 18 Feb '25

18 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7354

1 0

Re: [PATCH v3 0/5] MR7334: oleaut32: Fix logic for deciding whether type description follows the name. - approved
by Alexandre Julliard (＠julliard) 18 Feb '25

18 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7334

1 0

Re: [PATCH v2 0/2] MR7349: win32u, winex11: Sort vulkan devices. - approved
by Alexandre Julliard (＠julliard) 18 Feb '25

18 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7349

1 0

Re: [PATCH v2 0/1] MR7348: winecoreaudio: Avoid duplicate Program Change or Channel Aftertouch MIDI messages. - approved
by Alexandre Julliard (＠julliard) 18 Feb '25

18 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7348

1 0

Re: [PATCH v4 0/1] MR7179: wined3d: Add some DXT format mappings in the Vulkan renderer. - approved
by Alexandre Julliard (＠julliard) 18 Feb '25

18 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7179

1 0

[PATCH v16 0/8] MR7216: winebth.sys part 3: Introduce IOCTL_WINBTH_RADIO_SET_FLAG
by Vibhav Pant (＠vibhavp) 18 Feb '25

18 Feb '25

The Windows Bluetooth stack uses private IOCTLs in order to set the [discoverability](https://learn.microsoft.com/en-us/windows/win32/api/blueto… and [connectability](https://learn.microsoft.com/en-us/windows/win32/api/bluetoo… status of a local radio. This MR introduces the wine-specific IOCTL `IOCTL_WINBTH_RADIO_SET_FLAG` for the same purpose, as most applications seem to the Win32 API itself for these operations. -- v16: bluetoothapis: Implement BluetoothEnableDiscovery. … [View More]

3 11

[PATCH v15 0/8] MR7216: winebth.sys part 3: Introduce IOCTL_WINBTH_RADIO_SET_FLAG
by Vibhav Pant (＠vibhavp) 18 Feb '25

18 Feb '25

The Windows Bluetooth stack uses private IOCTLs in order to set the [discoverability](https://learn.microsoft.com/en-us/windows/win32/api/blueto… and [connectability](https://learn.microsoft.com/en-us/windows/win32/api/bluetoo… status of a local radio. This MR introduces the wine-specific IOCTL `IOCTL_WINBTH_RADIO_SET_FLAG` for the same purpose, as most applications seem to the Win32 API itself for these operations. -- v15: bluetoothapis: Implement BluetoothEnableDiscovery. … [View More]

2 8

[PATCH v14 0/8] MR7216: winebth.sys part 3: Introduce IOCTL_WINBTH_RADIO_SET_FLAG
by Vibhav Pant (＠vibhavp) 18 Feb '25

18 Feb '25

The Windows Bluetooth stack uses private IOCTLs in order to set the [discoverability](https://learn.microsoft.com/en-us/windows/win32/api/blueto… and [connectability](https://learn.microsoft.com/en-us/windows/win32/api/bluetoo… status of a local radio. This MR introduces the wine-specific IOCTL `IOCTL_WINBTH_RADIO_SET_FLAG` for the same purpose, as most applications seem to the Win32 API itself for these operations. -- v14: bluetoothapis: Implement BluetoothEnableDiscovery. … [View More]

2 9

[PATCH v13 0/8] MR7216: winebth.sys part 3: Introduce IOCTL_WINBTH_RADIO_SET_FLAG
by Vibhav Pant (＠vibhavp) 18 Feb '25

18 Feb '25

The Windows Bluetooth stack uses private IOCTLs in order to set the [discoverability](https://learn.microsoft.com/en-us/windows/win32/api/blueto… and [connectability](https://learn.microsoft.com/en-us/windows/win32/api/bluetoo… status of a local radio. This MR introduces the wine-specific IOCTL `IOCTL_WINBTH_RADIO_SET_FLAG` for the same purpose, as most applications seem to the Win32 API itself for these operations. -- v13: bluetoothapis: Implement BluetoothEnableDiscovery. … [View More]

3 11

[PATCH 0/1] MR7340: winegstreamer: Implement IWMSyncReader2::GetMaxOutputSampleSize.
by Gijs Vermeulen (＠gverm) 18 Feb '25

18 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57323 Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7340

3 2

[PATCH 0/2] MR7358: quartz: Fix for stream position setting after receiving EOS.
by Connor McAdams (＠cmcadams) 18 Feb '25

18 Feb '25

Fixes a bug where music on the radio in Fallout 3 is silent. Upon receiving EOS, the game resets the position of the stream and then calls `IMediaControl_Run()` without calling `IMediaControl_Stop()`. In wine, this results in the `got_ec_complete` variable being uncleared, and the stream position is stuck at end of stream. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7358

3 3

[PATCH 0/1] MR7360: mshtml: Try to guess the charset on streams with no BOM.
by Gabriel Ivăncescu (＠insn) 18 Feb '25

18 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7360

2 1

[PATCH 0/1] MR7359: winewayland: Don't crash on text input done events without focus.
by Alexandros Frantzis (＠afrantzis) 18 Feb '25

18 Feb '25

Some compositors (e.g., kwin) will send a done event for every commit, regardless of the focus state of the text input. This behavior is arguably(?) out of spec, but otherwise harmless, so just ignore the new state in such cases. -- To reproduce (without the fix) simple open notepad under kwin and change the focus do a different window. The root cause of this is that kwin is responding to the disable&commit we perform on text_input leave. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7359

2 2

[PATCH v4 0/1] MR7231: rpcrt4: Change some buffer wrap checks to satisfy Clang 20.
by William Horvath (＠whrvt) 18 Feb '25

18 Feb '25

Soon-to-be-released Clang 20 introduced a [`-Wtautological-compare`](https://github.com/llvm/llvm-project/commit/6d34cfac53b993a6cdf3d6669e017eac3a2296c8) warning which these checks trigger. Update them in a similar fashion to the example shown in the [Clang doc](https://github.com/llvm/llvm-project/blob/release/20.x/clang/docs/Rele… (see "To avoid pointer addition overflow..."). -- v4: rpcrt4: Pointer arithmetic fixes (-Wtautological-compare). https://gitlab.winehq.org/wine/wine/-/merge_requests/7231

3 5

[PATCH 0/4] MR7332: mfreadwrite: Add tests for writer.
by Ziqing Hui (＠zhui) 18 Feb '25

18 Feb '25

This is the refactoring of the tests in !7160. I submit a new seperate MR because I want to get the tests upstreamed first, otherwise making changes to tests patches needs rebasing the implementation patches. So plz review the tests MR first. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7332

3 6

[PATCH v2 0/1] MR7352: winewayland: Request warp to win32 position on pointer unlock.
by Attila Fidan (＠atticf) 18 Feb '25

18 Feb '25

If a surface is being clipped and hides the cursor, drawing its own one, winewayland constrains using a pointer lock and enables Wayland relative motion. If the application decides to stop drawing its own cursor and make the cursor visible, winewayland will disable relative motion and pointer lock, and enable pointer confinement. The user will perceive a pointer jump from the win32/application drawn cursor to where the Wayland pointer is after being unlocked and an absolute motion event is … [View More]

3 3

[PATCH 0/7] MR7354: win32u: Improve modeset emulation virtual mode list.
by Rémi Bernon (＠rbernon) 18 Feb '25

18 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7354

2 7

[PATCH v2 0/5] MR7334: oleaut32: Fix logic for deciding whether type description follows the name.
by Dmitry Timoshkov (＠dmitry) 18 Feb '25

18 Feb '25

-- v2: oleaut32: Add support for decoding SLTG variable help strings. oleaut32: Add support for decoding SLTG function help strings. oleaut32: Implement decoding of SLTG help strings. oleaut32: 'typekind' is the last field of SLTG_OtherTypeInfo structure. oleaut32: Fix logic for deciding whether type description follows the name. https://gitlab.winehq.org/wine/wine/-/merge_requests/7334

3 8

Re: [PATCH v6 0/6] MR7174: rtworkq: Fix handling of platform startup and lock counts.
by Nikolay Sivov (＠nsivov) 18 Feb '25

18 Feb '25

On Tue Feb 18 06:30:29 2025 +0000, Conor McCarthy wrote: > No problem to do that if 11 commits are ok. Not a problem for me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7174#note_94986

1 0

[PATCH 0/2] MR7142: win32u: Reset surface clip region if it matches the visible rect.
by Rémi Bernon (＠rbernon) 18 Feb '25

18 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57665 With an empty clipping region, when the window is being shown, the Expose event we receive is ignored by `expose_window_surface`, assuming there's no redraw necessary. If a clipping region is set, we call `NtUserRedrawWindow` with `RDW_ERASE` which clears the window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7142

2 3

[PATCH 0/1] MR7257: winex11: Get rid of x11drv_win_data use_alpha flag.
by Rémi Bernon (＠rbernon) 18 Feb '25

18 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7257

2 2

[PATCH v3 0/2] MR7157: winex11: Only erase the desktop window pixels on expose events.
by Rémi Bernon (＠rbernon) 18 Feb '25

18 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57665 --- The issue is that The Medium launcher uses a dialog window procedure, and implements its background by doing a StretchBlt call on WM_PAINT in the dialog procedure call, which happens before the window message loop. It then itself calls InvalidateRect(hwnd, NULL, 0), which queues a WM_PAINT as well but with only the RDW_INVALIDATE flag. Next, when the window message loop is executed, the WM_PAINT message is being processed as it … [View More]

2 3

[PATCH 0/5] MR7334: oleaut32: Fix logic for deciding whether type description follows the name.
by Dmitry Timoshkov (＠dmitry) 18 Feb '25

18 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7334

3 7

[PATCH v4 0/5] MR7347: ntdll: Avoid process_attach() even indirectly if loaded with `DONT_RESOLVE_DLL_REFERENCES`
by Jinoh Kang (＠iamahuman) 18 Feb '25

18 Feb '25

This cleans up `LDR_DONT_RESOLVE_REFS` checks in preparation for !7. -- v4: ntdlll: Remove redundant LDR_DONT_RESOLVE_REFS checks before calling process_attach(). ntdll: Skip DLL initialization and ldr notification entirely if DONT_RESOLVE_DLL_REFERENCES is set. kernel32/tests: Test for unexpected loader notification for import dependency loaded with DONT_RESOLVE_DLL_REFERENCES. https://gitlab.winehq.org/wine/wine/-/merge_requests/7347

3 7

[PATCH 0/1] MR7353: winewayland: Implement SetCursorPos via pointer lock.
by Attila Fidan (＠atticf) 18 Feb '25

18 Feb '25

There is no ([not yet?](https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requ…) dedicated protocol for requesting pointer warps, but it's possible to request one with `zwp_locked_pointer_v1.set_cursor_position_hint` which may be performed when the pointer is unlocked. The idea is to quickly lock/set position/unlock. This is used by SDL (in some cases: [SDL_MOUSE_EMULATE_WARP_WITH_RELATIVE](https://wiki.libsdl.org/SDL3/SDL_HINT…) and Xwayland. The limitation is/will be that the … [View More]

2 1

[PATCH 0/1] MR7352: winewayland: Request warp to win32 position on pointer unlock.
by Attila Fidan (＠atticf) 18 Feb '25

18 Feb '25

If a surface is being clipped and hides the cursor, drawing its own one, winewayland constrains using a pointer lock and enables Wayland relative motion. If the application decides to stop drawing its own cursor and make the cursor visible, winewayland will disable relative motion and pointer lock, and enable pointer confinement. The user will perceive a pointer jump from the win32/application drawn cursor to where the Wayland pointer is after being unlocked and an absolute motion event is … [View More]

2 1

[PATCH 0/2] MR7349: win32u, winex11: Sort vulkan devices.
by Paul Gofman (＠gofman) 18 Feb '25

18 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7349

3 5

Re: [PATCH v16 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C. - approved
by eric pouech (＠epo) 18 Feb '25

18 Feb '25

This merge request was approved by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322

1 0

[PATCH v3 0/2] MR7345: server: Add order for registry value.
by Haoyang Chen (＠chenhaoyang) 18 Feb '25

18 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=9314 -- v3: server: Store the order for registry value. https://gitlab.winehq.org/wine/wine/-/merge_requests/7345

2 2

[PATCH v2 0/2] MR7345: server: Add order for registry value.
by Haoyang Chen (＠chenhaoyang) 18 Feb '25

18 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=9314 -- v2: server: Store the order for registry value. https://gitlab.winehq.org/wine/wine/-/merge_requests/7345

2 2

[PATCH 0/1] MR7345: server: Add order for registry value.
by Haoyang Chen (＠chenhaoyang) 18 Feb '25

18 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=9314 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7345

3 3

[PATCH 0/1] MR7348: winecoreaudio: Avoid duplicate Program Change or Channel Aftertouch MIDI messages.
by Brendan Shanks (＠bshanks) 18 Feb '25

18 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57805 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7348

3 2

Re: [PATCH v6 0/6] MR7174: rtworkq: Fix handling of platform startup and lock counts.
by Conor McCarthy (＠cmccarthy) 18 Feb '25

18 Feb '25

On Tue Feb 18 06:30:29 2025 +0000, Nikolay Sivov wrote: > I knew I commented on these changes before, but then I found it was > !7244. Could we merge those, or what's the plan? No problem to do that if 11 commits are ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7174#note_94962

1 0

[PATCH v5 0/6] MR7174: rtworkq: Fix handling of platform startup and lock counts.
by Conor McCarthy (＠cmccarthy) 18 Feb '25

18 Feb '25

Startup and lock counts in native Windows are separate, and the lock count does not decrease when an async result is freed if the platform has been started. -- v5: rtworkq: Introduce an async result object cache. rtworkq: Introduce a platform startup count. rtworkq/tests: Test work queue. mfplat/tests: Test platform startup and lock counts. mfplat/tests: Test mixing of MF platform functions with their Rtwq equivalents. https://gitlab.winehq.org/wine/wine/-/merge_requests/7174

2 6

[PATCH v3 0/1] MR7339: ntdll: implement create_logical_proc_info on FreeBSD.
by Damjan Jovanovic (＠dj) 18 Feb '25

18 Feb '25

Port the XML parser from dlls/ntdll/actctx.c to ASCII and use it to parse the XML returned from FreeBSD's kern.sched.topology_spec sysctl. -- v3: ntdll: implement create_logical_proc_info on FreeBSD. https://gitlab.winehq.org/wine/wine/-/merge_requests/7339

3 3

[PATCH v2 0/2] MR7342: Implement D3D11_FEATURE_D3D9_SIMPLE_INSTANCING_SUPPORT feature check.
by Zhiyi Zhang (＠zhiyi) 18 Feb '25

18 Feb '25

For React Native. -- v2: d3d11: Implement D3D11_FEATURE_D3D9_SIMPLE_INSTANCING_SUPPORT feature check. https://gitlab.winehq.org/wine/wine/-/merge_requests/7342

2 4

[PATCH v3 0/1] MR7179: wined3d: Add some DXT format mappings in the Vulkan renderer.
by Aida Jonikienė (＠DodoGTA) 18 Feb '25

18 Feb '25

This removes some texture errors when using Himavant. -- v3: wined3d: Add DXT format mappings in the Vulkan renderer. https://gitlab.winehq.org/wine/wine/-/merge_requests/7179

4 4

[PATCH v3 0/5] MR7347: ntdll: Avoid process_attach() even indirectly if loaded with `DONT_RESOLVE_DLL_REFERENCES`
by Jinoh Kang (＠iamahuman) 17 Feb '25

17 Feb '25

This cleans up `LDR_DONT_RESOLVE_REFS` checks in preparation for !7. -- v3: ntdlll: Remove redundant LDR_DONT_RESOLVE_REFS checks before calling process_attach(). ntdll: Skip DLL initialization and ldr notification entirely if DONT_RESOLVE_DLL_REFERENCES is set. kernel32/tests: Test for unexpected loader notification for import dependency loaded with DONT_RESOLVE_DLL_REFERENCES. kernel32/tests: Test for unexpected LDR_PROCESS_ATTACHED flag in import dependency loaded with … [View More]

2 6

[PATCH 0/5] MR4894: setupapi: implement CM_Locate_DevNode
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Feb '25

17 Feb '25

This api is used by libxess on intel GPUs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4894

3 8

Re: [PATCH v8 0/2] MR7060: scrrun/tests: Add drive_get_path test
by Quinn Rafferty (＠ramleejo) 17 Feb '25

17 Feb '25

On Wed Jan 1 16:32:32 2025 +0000, Nikolay Sivov wrote: > @alexhenrie is it possible to create a drive without a letter? Regarding > wine supporting only drives with assigned letters, I don't think it > matters that much if it turns out to be easy to return a correct path. > IDrive has separate properties for paths and letters, so maybe there is > a reason for that. My understanding is that the way to query all available drives is via DriveCollection. Due to this I changed the … [View More]

1 0

[PATCH v4 0/2] MR7238: winebus,mmdevapi: implement audio device container id
by Harald Sitter (＠sitter) 17 Feb '25

17 Feb '25

This is a bit convoluted because of the amount of pieces involved. I'll try to untangle things a bit. The container id is meant to be globally unique and stable. We therefore need a suitable amount of stable entropy that we can feed into a hash function to get a stable and unique output. This happens in winebus. The corner stone of hash inputs is the linux device topology (sysfs path) obtained via udev. Along with all other possible data we feed this into a hash function to obtain our … [View More]

2 3

Re: [PATCH v3 0/2] MR7341: shdocvw: Remove two functions. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7341

1 0

Re: [PATCH v2 0/1] MR7346: msvcrt/tests: Add missing parameter pmode to _open call (ASan). - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7346

1 0

Re: [PATCH v3 0/2] MR7343: Add some d2d effect stubs. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7343

1 0

Re: [PATCH v4 0/14] MR7329: windowscodecs/tests: Add some query tests with the Unknown reader. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7329

1 0

Re: [PATCH v11 0/4] MR7241: winewayland: Basic input method support. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7241

1 0

Re: [PATCH v2 0/2] MR7338: Add FlushProcessWriteBuffers() tests - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7338

1 0

Re: [PATCH v2 0/5] MR7195: setuapi: Implement a few cfgmgr functions. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7195

1 0

Re: [PATCH v3 0/1] MR7210: setupapi: Use wide character string literals. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7210

1 0

[PATCH v2 0/5] MR7347: ntdll: Avoid attach even as dependency if loaded with `DONT_RESOLVE_DLL_REFERENCES`
by Jinoh Kang (＠iamahuman) 17 Feb '25

17 Feb '25

This cleans up `LDR_DONT_RESOLVE_REFS` checks in preparation for !7. -- v2: ntdlll: Remove redundant LDR_DONT_RESOLVE_REFS checks before calling process_attach(). ntdll: Skip DLL initialization and ldr notification entirely if DONT_RESOLVE_DLL_REFERENCES is set. kernel32/tests: Test for unexpected loader notification for import dependency loaded with DONT_RESOLVE_DLL_REFERENCES. kernel32/tests: Test for unexpected LDR_PROCESS_ATTACHED flag in import dependency loaded with … [View More]

3 6

[PATCH v13 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 17 Feb '25

17 Feb '25

Allow the user to press Ctrl-C to abort lengthy DIR (or DIR /p, etc.) operations. -- v13: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C. https://gitlab.winehq.org/wine/wine/-/merge_requests/7322

2 2

Re: [PATCH v12 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 17 Feb '25

17 Feb '25

On Mon Feb 17 19:22:08 2025 +0000, eric pouech wrote: > thanks for taking the time to update your patch > unfortunately, it fails on wine regression test > the attached patch should solve this > [patch.ctrlc](/uploads/84ae84d1c5cf3d3dfc19904c673bc906/patch.ctrlc) > also, any reason you changed the ctrl event for and automatic reset? > actually, I was puzzled with the previous versions with a manual reset > (my first guess would have been to implement it with an automatic … [View More]

1 0

[PATCH v3 0/1] MR7231: rpcrt4: Change some buffer wrap checks to satisfy Clang 20.
by William Horvath (＠whrvt) 17 Feb '25

17 Feb '25

Soon-to-be-released Clang 20 introduced a [`-Wtautological-compare`](https://github.com/llvm/llvm-project/commit/6d34cfac53b993a6cdf3d6669e017eac3a2296c8) warning which these checks trigger. Update them in a similar fashion to the example shown in the [Clang doc](https://github.com/llvm/llvm-project/blob/release/20.x/clang/docs/Rele… (see "To avoid pointer addition overflow..."). -- v3: rpcrt4: Pointer arithmetic fixes (-Wtautological-compare). https://gitlab.winehq.org/wine/wine/-/merge_requests/7231

2 2

Re: [PATCH v2 0/2] MR7341: shdocvw: Remove two functions.
by Elizabeth Figura (＠zfigura) 17 Feb '25

17 Feb '25

v2: Fix authorship... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7341#note_94888

1 0

[PATCH 0/5] MR7347: ntdll: Avoid attach even as dependency if loaded with `DONT_RESOLVE_DLL_REFERENCES`
by Jinoh Kang (＠iamahuman) 17 Feb '25

17 Feb '25

This cleans up `LDR_DONT_RESOLVE_REFS` checks in preparation for !7. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7347

2 5

Re: [PATCH v12 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by eric pouech (＠epo) 17 Feb '25

17 Feb '25

thanks for taking the time to update your patch unfortunately, it fails on wine regression test the attached patch should solve this [patch.ctrlc](/uploads/84ae84d1c5cf3d3dfc19904c673bc906/patch.ctrlc) also, any reason you changed the ctrl event for and automatic reset? actually, I was puzzled with the previous versions with a manual reset (my first guess would have been to implement it with an automatic reset) I tried things like '(dir /s \\\* || echo aaaaa) && dir \*' (and … [View More]

1 0

[PATCH 0/5] MR7317: Server-side thread priorities implementation (Part 2)
by Marc-Aurel Zent (＠mzent) 17 Feb '25

17 Feb '25

This adds Mach thread priority support (both in the application and realtime band) and recalculates thread priorities when the process priority changes. Part 3, which is still a bit WIP deals with implementing priority boosts (for main threads and threads which are processing window messages), effectively fully replacing https://gitlab.winehq.org/wine/wine/-/merge_requests/1232. Currently the implementation in this MR already technically overrides what https://gitlab.winehq.org/wine/wine/-/… [View More]

3 9

[PATCH 0/1] MR7346: msvcrt/tests: Add missing parameter pmode to _open call (ASan).
by Bernhard Übelacker (＠bernhardu) 17 Feb '25

17 Feb '25

Documentation states pmode argument is needed when _O_CREAT is used. ``` dlls/msvcrt/tests/i386-windows/msvcrt_test.exe misc ================================================================= ==544==ERROR: AddressSanitizer: stack-buffer-underflow on address 0x0031e7c0 at pc 0x7a1ed844 bp 0x0031e734 sp 0x0031e730 READ of size 4 at 0x0031e7c0 thread T0 0234:fixme:msvcrt:_set_abort_behavior _WRITE_CALL_REPORTFAULT unhandled 0234:fixme:file:server_get_file_info Unsupported info class e #0 … [View More]0x7a1ed843 in _open .../wine/dlls/msvcrt/file.c:2663:13 #1 0x00482c05 in test__popen .../wine/dlls/msvcrt/tests/misc.c:367:10 #2 0x00482c05 in func_misc .../wine/dlls/msvcrt/tests/misc.c:767:5 #3 0x0052909e in run_test .../wine/include/wine/test.h:765:5 #4 0x0052909e in main .../wine/include/wine/test.h:884:12 #5 0x0052ae2b in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #6 0x7bb8ea3f in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b80ea3f) #7 0x7bd0ce82 in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc0ce82) #8 0x7bd404e4 in call_thread_func .../wine/dlls/ntdll\signal_i386.c:524:9 Address 0x0031e7c0 is located in stack of thread T0 at offset 0 in frame #0 0x0047f73f in func_misc .../wine/dlls/msvcrt/tests/misc.c:742 This frame has 15 object(s): [16, 20) 'num.i' (line 682) [32, 36) 'ctx.i' (line 684) [48, 52) 'key.i' (line 685) [64, 464) 'tab.i' (line 440) [528, 1048) 'small_sort.i' (line 442) [1184, 1704) 'small_sort2.i' (line 442) [1840, 2360) 'quick_sort.i' (line 442) [2496, 3520) 'buf.i270' (line 362) [3648, 3652) 'out.i115' (line 260) [3664, 3668) 'out.i91' (line 235) [3680, 3936) 'buf.i53' (line 189) [4000, 4104) 'out.i' (line 158) [4144, 4148) 'rand.i' (line 77) [4160, 5184) 'buf.i' (line 347) [5312, 5316) 'arg_v' (line 744) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-underflow .../wine/dlls/msvcrt/file.c:2663:13 in _open Shadow bytes around the buggy address: 0x0031e500: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0031e580: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0031e600: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0031e680: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0031e700: 00 00 00 00 00 00 00 00 f1 f1 04 f3 00 00 00 00 =>0x0031e780: 00 00 00 00 00 00 00 00[f1]f1 f8 f2 f8 f2 f8 f2 0x0031e800: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x0031e880: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x0031e900: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x0031e980: f8 f8 f2 f2 f2 f2 f2 f2 f2 f2 f8 f8 f8 f8 f8 f8 0x0031ea00: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==544==ABORTING ``` Today I was not able to get ASan triggered on this, but I guess this may be related to me using currently `-O1` instead of previously `-O2` and some more different compile options. But I thought this might still worth submitting. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7346 [View Less]

3 2

[PATCH v2 0/1] MR7231: rpcrt4, winedbg, winevulkan: Various small fixes for Clang 20 + -Werror.
by William Horvath (＠whrvth) 17 Feb '25

17 Feb '25

I don't think these are serious problems, but Clang 20's defaults (from llvm-mingw nightly) were resulting in build failures with `--enable-werror` due to `-Wtautological-compare` and `-Wunused-function`. I hope that the buffer wrap checking is somewhat idiomatic/standard. If necessary, I can split off the winevulkan change, but it seems minor enough to be grouped in this MR. -- v2: rpcrt4: Pointer arithmetic fixes (-Wtautological-compare). https://gitlab.winehq.org/wine/wine/-/merge_requests/7231

5 5

[PATCH v2 0/2] MR7343: Add some d2d effect stubs.
by Zhiyi Zhang (＠zhiyi) 17 Feb '25

17 Feb '25

For React Native. -- v2: d2d1: Add D2D1Flood effect stub. d2d1: Add D2D1ColorMatrix effect stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/7343

3 3

[PATCH 0/2] MR7343: Add some d2d effects.
by Zhiyi Zhang (＠zhiyi) 17 Feb '25

17 Feb '25

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7343

3 3

[PATCH 0/2] MR7342: Implement D3D11_FEATURE_D3D9_SIMPLE_INSTANCING_SUPPORT feature check.
by Zhiyi Zhang (＠zhiyi) 17 Feb '25

17 Feb '25

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7342

2 2

[PATCH 0/2] MR7341: shdocvw: Remove two functions.
by Elizabeth Figura (＠zfigura) 17 Feb '25

17 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7341

2 2

[PATCH v12 0/7] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 17 Feb '25

17 Feb '25

This fixes https://bugs.winehq.org/show_bug.cgi?id=52094. For reference, here's how current_modref is being passed around (before this patch): ```mermaid graph TB fii["fixup_imports_ilonly (directly sets current_modref)"] fi["fixup_imports (directly sets current_modref)"] pa["process_attach (directly sets current_modref)"] ld[… [View More]

4 15

[PATCH v3 0/2] MR5360: gdiplus: Check for empty height in bonding box calculation
by James McDonnell (＠ElementalWarrior) 16 Feb '25

16 Feb '25

This resolves the issue in StudioTax where the bounding box dimensions is reported as 0. Because the height is less than 0, the check for height in GdipAddPathRectangle fails, and the X and Y coordinates of the points is never set. I am fairly ignorant of this code, this seems like a good approach, however I am happy for guidance from others more familiar in how gdiplus works. -- v3: gdiplus: Fix text height calculation when exceeding rect gdiplus: Check for NoClip in text height … [View More]

3 6

[PATCH v3 0/14] MR7329: windowscodecs/tests: Add some query tests with the Unknown reader.
by Nikolay Sivov (＠nsivov) 16 Feb '25

16 Feb '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: windowscodecs: Implement CreateQueryWriter(). windowscodecs/metadata: Base returned query handlers on metadata handlers. windowscodecs/metadata: Return query writer object from GetMetadataByName() when block writer is used. windowscodecs/metadata: Handle empty items in queries. windowscodecs/metadata: Use separate helpers to parse query items. windowscodecs/metadata: Add a helper to parse query … [View More]

3 17

Re: [PATCH v12 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 16 Feb '25

16 Feb '25

OK, once again I think I've resolved all raised issues here with the latest submitted changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322#note_94847

1 0

Re: [PATCH v2 0/1] MR7339: ntdll: implement create_logical_proc_info on FreeBSD.
by Nikolay Sivov (＠nsivov) 16 Feb '25

16 Feb '25

On Sun Feb 16 17:41:01 2025 +0000, Brendan Shanks wrote: > Another possibility is to use `libbsdxml`, a renamed expat that FreeBSD > includes (although the man page says that “The libbsdxml library is > intended to be used within the FreeBSD base system only. Use of the > libbsdxml library for other purposes is not supported and discouraged.” > But expat’s API is quite stable, and avahi also has the option to use bsdxml.) > Otherwise, maybe just depend on a system-installed … [View More]

1 0

Re: [PATCH v10 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 16 Feb '25

16 Feb '25

On Sun Feb 16 16:38:40 2025 +0000, eric pouech wrote: > this likely could be folded in code line 510, by inserting between 510 & 511: > if (return_code != NO_ERROR) dirStack = NULL; Thank you. I knew this was non-optimal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322#note_94834

1 0

Re: [PATCH v10 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 16 Feb '25

16 Feb '25

On Sun Feb 16 16:37:29 2025 +0000, eric pouech wrote: > actually, we could (later on) have other values as return code... > so IMO this should rather be written as: > `if (return_code != NO_ERROR || (num_empty && !num_with_data))` > ` errorlevel = ERROR_INVALID_FUNCTION;` > `else` > ` errorlevel = NO_ERROR;` Thank you. I was hoping for clarification on this one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322#note_94833

1 0

Re: [PATCH v10 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 16 Feb '25

16 Feb '25

On Sun Feb 16 16:38:49 2025 +0000, eric pouech wrote: > nitpick: IMO it's more readable to return a RETURN_CODE, and pass a > DIRECTORY_STACK\*\* to update the pointer (you likely did it this way to > minimize change, but let's take the opportunity of a change to sanitize > a bit the current spaghetti code) It is *always* my philosophy to minimize changes to existing, working code. Some projects emphasize this. I also come from a working assumption, perhaps erroneously, that … [View More]

1 0

Re: [PATCH v10 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 16 Feb '25

16 Feb '25

On Sun Feb 16 17:01:28 2025 +0000, eric pouech wrote: > globally it looks better > a couple of stylistic remarks, but you need to go further for not using > errorlevel inside the function and its helper > perhaps, it's worthwhile to split the patch in two: > * first one to no longer use error level internally, adapt > list_directory prototype... (in the details, it's fine to use return > errorlevel = ERROR\_\* while parsing the arguments in case of error, but > when this … [View More]

1 0

[PATCH v3 0/26] MR7226: ntdll: Implement in-process synchronization via the Linux "ntsync" driver.
by Elizabeth Figura (＠zfigura) 16 Feb '25

16 Feb '25

This introduces a faster implementation of signal and wait operations on NT events, semaphores, and mutexes, which improves performance to native levels for a wide variety of games and other applications. The goal here is similar to the long-standing out-of-tree "esync" and "fsync" patch sets, but without the flaws that make those patch sets not upstreamable. The Linux "ntsync" driver is not currently released. It has been accepted into the trunk Linux tree for 6.14, so barring any … [View More]extraordinary circumstances, the API is frozen and it will be released in its current form in about 2 months. Since it has passed all relevant reviewers on the kernel side, and the API is all but released, it seems there is no reason any more not to submit the Wine side to match. Some important notes: * This patch set does *not* include any way to disable ntsync support, since that kind of configuration often seems to be dispreferred where not necessary. In essence, ntsync should just work everywhere. Probably the easiest way to effectively disable ntsync, for the purposes of testing, is to chmod the /dev/ntsync device to prevent its being opened. Regardless, a Wine switch to disable ntsync can be added simply enough. Note that it should probably not take the form of a registry key, however, since it needs to be easily accessible from the server itself. * It is, generally speaking, not possible for only some objects, or some processes, to have backing ntsync objects, while others use the old server path. The esync/fsync patch sets explicitly protected against this by making sure every process had a consistent view of whether esync was enabled. This is not provided here, since no switch is provided to toggle ntsync, and it should not be possible to get into such an inconsistent state without gross misconfiguration. * Similarly, no diagnostic messages are provided to note that ntsync is in use, or not in use. These messages are part of esync/fsync, as well as part of ntsync "testing" trees unofficially distributed. However, if ntsync is working correctly, no message should be necessary. The basic structure is: * Each type of server object which can be waited on by the client (including events, semaphores, mutexes, but also other types such as processes, files) must store an "inproc_sync" object. This "inproc_sync" object is a full server object (note that this differs from esync/fsync). A vector and server request is introduced to retrieve an NT handle to this object from an arbitrary NT handle. Since the actual ntsync objects are simply distinct file descriptions, we then call get_handle_fd from the client to retrieve an fd to the object, and then perform ioctls on it. * Objects signaled by the server (processes, files, etc) perform ntsync ioctls on that object. The backing object in all such cases is simply an event. * Signal and wait operations on the client side attempt to defer to an "inproc_\*" function, falling back to the server implementation if it returns STATUS_NOT_IMPLEMENTED. This mirrors how in-process synchronization objects (critical sections, SRW locks, etc) used to be implemented—attempting to use an architecture-specific "fast_\*" function and falling back if it returned STATUS_NOT_IMPLEMENTED. * The inproc_sync handles, once retrieved, are cached per-process. This caching takes a similar form to the fd cache. It does not reuse the same infrastructure, however. The primary reason for this is that the fd cache is designed to fit within a 64-bit value and uses 64-bit atomic operations to ensure consistency. However, we need to store more than 64 bits of information. [We also need to modify them after caching, in order to correctly implement handle closing—see below.] The secondary reason is that retrieving the ntsync fd from the inproc_sync handle itself uses the fd cache. * In order to keep the Linux driver simple, it does not implement access flags (EVENT_MODIFY_STATE etc.) Instead, the flags are cached locally and validated there. This too mirrors the fd cache. Note that this means that a malicious process can now modify objects it should not be able modify—which is less true than it is with wineserver—but this is no different from the way other objects (notably fds) are handled, and would require manual syscalls. * In order to achieve correct behaviour related to closing objects while they are used, this patch set essentially relies on refcounting. This is broadly true of the server as well, but because we need to avoid server calls when performing object operations, significantly more care must be taken. In particular, because waits need to be interruptable by signals and then be restarted, we need the backing ntsync object to remain valid until all users are done with it. On a process level, this is achieved by letting multiple processes own handles to the underlying inproc_sync server object. On a thread level, multiple simultaneous calls need to refcount the process's local handle. This refcount is stored in the sync object cache. When it reaches zero, the cache is cleared. Punting this behaviour to the Linux driver would have introduced a great deal more complexity, which is best kept in userspace and out of the kernel. * The cache is, as such, treated as a cache. The penultimate commit, which introduces client support but does not yet cache the objects, effectively illustrates this by never actually caching anything, and retrieving a new NT handle and fd every time. * Certain waits, on internal handles (such as async, startup_info, completion), are delegated to the server even when ntsync is used. Those server objects do not create an underlying ntsync object. -- v3: ntdll: Cache in-process synchronization objects. ntdll: Use server_wait_for_object() when waiting on only the queue object. ntdll: Use in-process synchronization objects. ntdll: Introduce a helper to wait on an internal server handle. server: Allow creating an event object for client-side user APC signaling. server: Introduce select_inproc_queue and unselect_inproc_queue requests. server: Add a request to retrieve the in-process synchronization object from a handle. server: Create in-process synchronization objects for fd-based objects. server: Create in-process synchronization objects for timers. server: Create in-process synchronization objects for threads. server: Create in-process synchronization objects for message queues. server: Create in-process synchronization objects for jobs. server: Create in-process synchronization objects for processes. server: Create in-process synchronization objects for keyed events. server: Create in-process synchronization objects for device managers. server: Create in-process synchronization objects for debug objects. server: Create in-process synchronization objects for console servers. server: Create in-process synchronization objects for consoles. server: Create in-process synchronization objects for completion ports. server: Create in-process synchronization objects for mutexes. server: Create in-process synchronization objects for semaphores. server: Create in-process synchronization objects for events. server: Add an object operation to retrieve an in-process synchronization object. ntdll: Retrieve and cache an ntsync device in wait calls. ntdll: Add stub functions for in-process synchronization. ntdll: Add some traces to synchronization methods. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7226 [View Less]

10 26

Re: [PATCH v10 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 16 Feb '25

16 Feb '25

On Sun Feb 16 16:37:14 2025 +0000, eric pouech wrote: > this shouldn't set errorlevel but return_code > and likely using ERROR_FILE_NOT_FOUND to mark that listing was empty My head is starting to spin here. That is existing code that I haven't touched. I'll fix along with the other issues though... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322#note_94829

1 0

[PATCH v2 0/1] MR5213: Fix Cyberpunk 2077 spawning only one dispatcher thread in FreeBSD
by Katharine Chui (＠katharinechui) 16 Feb '25

16 Feb '25

Normally Cyberpunk 2077 spawns #cpu_threads of dispatcher threads. However with Freebsd, since create_logical_proc_info was a stub, the game would instead spawn a single dispatcher thread, causing the game to just crawl. Working around the issue by adding a barebone implementation of create_logical_proc_info for FreeBSD so that the game would at least get a thread count through ntdll. -- v2: Fix Cyberpunk 2077 spawning only one dispatcher thread in FreeBSD https://gitlab.winehq.org/wine/wine/-/merge_requests/5213

4 4

Re: [PATCH v2 0/1] MR7339: ntdll: implement create_logical_proc_info on FreeBSD.
by Brendan Shanks (＠bshanks) 16 Feb '25

16 Feb '25

Another possibility is to use `libbsdxml`, a renamed expat that FreeBSD includes (although the man page says that “The libbsdxml library is intended to be used within the FreeBSD base system only. Use of the libbsdxml library for other purposes is not supported and discouraged.” But expat’s API is quite stable, and avahi also has the option to use bsdxml.) Otherwise, maybe just depend on a system-installed expat or libxml2 on FreeBSD? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7339#note_94826

1 0

2025

2024

2023

2022

wine-gitlab