- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR7136: winex11.drv: Fix display name in X11DRV_UpdateDisplayDevices(). - approved
by Alexandre Julliard (＠julliard) 13 Jan '25

13 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7136

1 0

Re: [PATCH v2 0/1] MR7107: gdi32: Avoid crashing when tracing NULL xform. - approved
by Alexandre Julliard (＠julliard) 13 Jan '25

13 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7107

1 0

[PATCH 0/1] MR7141: winex11: Always blit offscreen over any other onscreen clients.
by Rémi Bernon (＠rbernon) 13 Jan '25

13 Jan '25

Since we're checking the child window clipping rules it is possible that a toplevel window also has an onscreen client window, for instance if the window wasn't created with WS_CLIPCHILDREN. The last window to present between the parent and its children should be visible. GDI blits always happen over the toplevel window, and we need to use IncludeInferiors to make sure it goes through any onscreen client window that is otherwise hiding the toplevel pixels. It should be safe to use that flag wrt other child windows, as we also set the clipping region to exclude the area that should be obscured by any sibling. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57661 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7141

2 1

[PATCH v3 0/4] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu (＠insn) 13 Jan '25

13 Jan '25

-- v3: server: When renaming, only fstat the source once. server: Remove source when renaming to a hardlink of itself. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

3 13

[PATCH 0/1] MR7140: winex11: Adjust requested visible rect relative to the previous position.
by Rémi Bernon (＠rbernon) 13 Jan '25

13 Jan '25

When the window manager moves windows offscreen, the Win32 config is explicitly kept out of sync. We need to handle that case when the Win32 config changes, to avoid forcefully moving the windows back on screen. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57652 Since 895ca2eda64f506b936999cdd8f14e224eef6a7f the window position might be out of sync between Win32 and X if the X window manager has moved it offscreen. Then b936f7426e33508538f48f7d20e7d7cb47cc1f32 ignored size and position changes, trying to avoid triggering requests that would force the X window position to match the Win32 state. However, the X visible rect might change on window style adjustments, and not from a application-requested size change, and we need to request these changes to the X server. The SWP flags should be handled in win32u already and the window rect position and size should not have changed if SWP_NOSIZE | SWP_NOMOVE were set by the application. What we need to do is to mind that the X window position might be out of sync, and adjust the request to take the eventual offscreen position into account. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7140

3 4

[PATCH v2 0/1] MR7139: configure: Use per-architecture cross flags if they are provided.
by Rémi Bernon (＠rbernon) 13 Jan '25

13 Jan '25

If `<arch>_CFLAGS`/`<arch>_LDFLAGS` are passed to configure they are ignored and replaced with the default flags. This prefers the user-provided flags if any, and falls back to `CROSSCFLAGS` / `CROSSLDLAGS` then to the default flags. -- v2: configure: Use per-architecture cross flags if they are provided. https://gitlab.winehq.org/wine/wine/-/merge_requests/7139

2 1

[PATCH 0/1] MR7128: msi: Fix a spelling error in the name of MigrateFeatureStates.
by Elizabeth Figura (＠zfigura) 13 Jan '25

13 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7128

4 5

[PATCH 0/2] MR7127: msi: Set features to absent if advertising is disallowed.
by Elizabeth Figura (＠zfigura) 13 Jan '25

13 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7127

3 3

[PATCH v2 0/5] MR7137: sapi: Implement most ISpStream methods.
by Shaun Ren (＠shaunren) 13 Jan '25

13 Jan '25

Needed for Diablo 4's screen reader. -- v2: sapi: Implement IStream methods for SpStream. sapi: Implement ISpStream::GetFormat. sapi: Implement ISpStream::Close. sapi: Implement ISpStream::Set/GetBaseStream. https://gitlab.winehq.org/wine/wine/-/merge_requests/7137

2 5

[PATCH 0/5] MR7137: sapi: Implement most ISpStream methods.
by Shaun Ren (＠shaunren) 13 Jan '25

13 Jan '25

Needed for Diablo 4's screen reader. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7137

2 5

Re: [PATCH v2 0/1] MR7124: mfmediaengine: Fix maths in scaling check.
by Brendan McGrath (＠redmcg) 12 Jan '25

12 Jan '25

On Sun Jan 12 20:25:27 2025 +0000, Nikolay Sivov wrote: > Do we need this intersection check at all? I believe we do. The code in `media_engine_transfer_d3d11` performs a `CopySubresourceRegion` directly to the application supplied texture, which only supports copy; it doesn't support any stretch. So `media_engine_transfer_d3d11` is used as an optimisation for when the application supplied texture has the same (or larger) dimensions as the output sample from the MF pipeline. This check ensures we fallback when stretching is required. The fallback writes to a media engine supplied texture, that is then applied to a quad that can be stretched (before being written to the application texture). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7124#note_91816

1 0

[PATCH 0/1] MR7107: gdi32: Avoid crashing when tracing NULL xform.
by Rémi Bernon (＠rbernon) 12 Jan '25

12 Jan '25

Fixes 8375e6c86e0a01f670e48a666088fafff53e39d8 Fixing gdiplus tests crashes in the nightly CI run. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7107

3 2

[PATCH 0/1] MR7136: winex11.drv: Fix display name in X11DRV_UpdateDisplayDevices().
by Zhiyi Zhang (＠zhiyi) 12 Jan '25

12 Jan '25

For example, when GPU 1 has adapter 1 and GPU 2 has adapter 2, without this fix, the `adapter` variable in the for loop is always zero when forming GDI display names \\.\DISPLAY* because these two adapters are on different GPUs. Thus "\\.\DISPLAY1" is incorrectly passed to xrandr14_get_id() for the second adapter and eventually gets the wrong current display mode for the second adapter. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57610 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7136

4 5

[PATCH 0/1] MR7126: winex11: Fixup monitor / display mode inconsistencies.
by Rémi Bernon (＠rbernon) 12 Jan '25

12 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57610 This is a simple workaround to fix the regression. The issue seems to be residing in inconsistent values returned by XRandR, and arguably a host driver bug, but it probably could be better fixed by enumerating the XRandR tree only on startup and when it is updated, but this would be a much larger change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7126

3 3

[PATCH 0/2] MR7110: Draft: win32u: Update current modes relative to the primary source.
by Rémi Bernon (＠rbernon) 12 Jan '25

12 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57610 This attempt to fix a regression which is caused by XRandR enumerated output/crtc changing during the display device initial enumeration. The user setup uses an external display and somehow XRandR enumerates the first (non-primary) monitor and its mode without being able to find a primary output/crtc (and uses that first monitor position as primary as fallback). Then, when the second (primary) monitor and its modes are enumerated it actually finds it and uses its as it should. This results in both monitor modes being positioned at 0x0, which breaks various things later on. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7110

3 4

[PATCH 0/1] MR7135: gdiplus/tests: Fix use-after-free of a graphics object (ASan).
by Nikolay Sivov (＠nsivov) 12 Jan '25

12 Jan '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7135

2 2

[PATCH 0/1] MR7134: kernel32/tests: Avoid stack-buffer-overflow in get_com_dir_size. (ASan)
by Nikolay Sivov (＠nsivov) 12 Jan '25

12 Jan '25

Function gets called with Magic == 0xdead, which causes the test to use the 64-bit path, which results in this buffer overflow. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7134

2 1

[PATCH 0/2] MR7133: gdiplus: Fix some path functions not starting a new figure.
by Esme Povirk (＠madewokherd) 11 Jan '25

11 Jan '25

Found by Mono's System.Drawing tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7133

3 3

[PATCH 0/1] MR7132: gdiplus/tests: Trace locked bitmap data on failure.
by Esme Povirk (＠madewokherd) 11 Jan '25

11 Jan '25

For debugging test failures like this one: https://test.winehq.org/data/8331e7db0d540656a047f415184a30df5acbc3f9/linux… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7132

2 1

[PATCH v2 0/1] MR7055: appwiz.cpl: Account for unicode characters in XDG_CACHE_HOME.
by Esme Povirk (＠madewokherd) 11 Jan '25

11 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57338 -- v2: appwiz.cpl: Account for unicode characters in XDG_CACHE_HOME. https://gitlab.winehq.org/wine/wine/-/merge_requests/7055

2 2

Re: [PATCH v4 0/1] MR7091: windowscodecs: Make values returned from CanConvert consistent - approved
by Esme Povirk (＠madewokherd) 11 Jan '25

11 Jan '25

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7091

1 0

Re: [PATCH v2 0/0] MR7130: (INVALID) - closed
by Jinoh Kang (＠iamahuman) 11 Jan '25

11 Jan '25

This merge request was closed by Jinoh Kang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7130

1 0

Re: [PATCH v2 0/7] MR6911: Draft: ntdll: Add WaitCompletionPacket.
by Jinoh Kang (＠iamahuman) 11 Jan '25

11 Jan '25

Jinoh Kang (@iamahuman) commented about server/thread.c: > + { > + struct wait_completion_packet *packet; > + > + LIST_FOR_EACH_ENTRY( packet, &obj->wait_completion_packet_queue, struct wait_completion_packet, entry ) > + { > + list_remove( &packet->entry ); > + release_object( packet->target ); > + packet->in_object_packet_queue = 0; > + packet->target = NULL; > + > + add_completion( packet->completion, packet->ckey, packet->cvalue, packet->status, > + packet->information, packet ); > + packet->in_completion_queue = 1; > + } > + } > + General advice: you should try not to leak implementation details of certain object (wait completion packet) into other types of objects. For example, if this piece of code is still to be preserved, you should move this into a helper completion.c, declare as extern in object.h (or file.h), and call that. That way, you don't have to define the entire `struct wait_completion_packet` in a shared header file. If this were factored into a helper, a simple forward declaration would have sufficed in the `file.h` side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6911#note_91785

1 0

[PATCH 0/1] MR7129: ntoskrnl.exe: Fix IRQL mismatch between cancel spin lock acquire and release.
by Jinoh Kang (＠iamahuman) 11 Jan '25

11 Jan '25

Use the irql assigned by IoAcquireCancelSpinLock, not the (yet-to-be-assigned) irp->CancelIrql. This is for readability. No semantic change is expected with unmodified ntoskrnl.exe/hal.dll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7129

3 2

[PATCH v2 0/1] MR7129: ntoskrnl.exe: Fix IRQL mismatch between cancel spin lock acquire and release.
by Jinoh Kang (＠iamahuman) 11 Jan '25

11 Jan '25

Use the irql assigned by IoAcquireCancelSpinLock, not the (yet-to-be-assigned) irp->CancelIrql. This is for readability. Since IoReleaseCancelSpinLock() ignores the IRQL argument anyway, no semantic change is expected with unmodified ntoskrnl.exe/hal.dll. -- v2: ntoskrnl.exe: Fix IRQL mismatch between cancel spin lock acquire and release. https://gitlab.winehq.org/wine/wine/-/merge_requests/7129

2 1

Re: [PATCH v2 0/1] MR7124: mfmediaengine: Fix maths in scaling check. - approved
by Alexandre Julliard (＠julliard) 10 Jan '25

10 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7124

1 0

Re: [PATCH v2 0/4] MR7057: Draft: amstream: Stop stream while running CreateSample. Feedback needed. :-)
by Santino Mazza (＠tati) 10 Jan '25

10 Jan '25

On Sat Dec 21 08:41:22 2024 +0000, Anton Baskanov wrote: > The correct way to fix this is to implement a custom allocator like it > is done in the native AMDirectDrawStream. This will allow changing the > format on the fly without stopping the stream. But it of course requires > much more work, including adding format change support to decoders. Thanks for the feedback! I started reading about dynamic format changing and dynamic reconnecting from your comment, so now I have a better idea on how to continue with this. :-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7057#note_91771

1 0

[PATCH v3 0/1] MR7108: tools: Add manual-run job for new-style wow64.
by Jinoh Kang (＠iamahuman) 10 Jan '25

10 Jan '25

The new job is only triggered when a developer manually starts it. Before run, it initially appears as a "skipped" job when the pipeline starts. -- v3: tools: Add manual-run job for new-style wow64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7108

3 2

[PATCH v6 0/3] MR6891: cmd: Use CD /D to change directory in POPD (same as PUSHD).
by huangqinjin (＠huangqinjin) 10 Jan '25

10 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57137 -- v6: cmd: Set =C: environment variable if POPD succeeds (same as PUSHD). cmd: Refactor CD command. cmd/tests: Add tests for POPD with directory that no longer exists. https://gitlab.winehq.org/wine/wine/-/merge_requests/6891

3 4

[PATCH 0/1] MR7124: mfmediaengine: Fix maths in scaling check.
by Brendan McGrath (＠redmcg) 10 Jan '25

10 Jan '25

This fixes a bug introduced in commit 7868484f04680c17cf56265c4cc0cb2319959a94. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7124

4 4

[PATCH 0/4] MR7125: mfreadwrite/tests: Add some tests.
by Ziqing Hui (＠zhui) 10 Jan '25

10 Jan '25

I have some local patches which implements more of the writer. I'm going to submit a new MR once they are ready. Now just submit the tests MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7125

3 5

[PATCH v3 0/1] MR7091: windowscodecs: Make values returned from CanConvert consistent
by Jeffrey Smith (＠whydoubt) 10 Jan '25

10 Jan '25

Any time CanConvert returns FALSE for the output parameter, also return an appropriate failing result code. This also adds tests for CanConvert. -- v3: windowscodecs: Make values returned from CanConvert consistent https://gitlab.winehq.org/wine/wine/-/merge_requests/7091

2 1

[PATCH 0/1] MR7123: ntdll: Detect kernel support before using ARM64 ID regs.
by Billy Laws (＠bylaws) 09 Jan '25

09 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7123

2 1

[PATCH v5 0/147] MR7098: Draft: Fighting with tests for 9.0.1
by Michael Stefaniuc (＠mstefani) 09 Jan '25

09 Jan '25

No reviews required.\ This is just to get the test results as seen by gitlab.\ MR will be cancelled afterwards. -- v5: secur32/tests: Update expected results for the new test.winehq.org server. wininet/tests: Update certificate for the new test.winehq.org server. dnsapi/tests: Update DNS names for the new test.winehq.org server. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7098

1 0

Re: [PATCH v3 0/1] MR7010: mf: Do not clean up a session op if it was submitted to a work queue. - approved
by Alexandre Julliard (＠julliard) 09 Jan '25

09 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7010

1 0

Re: [PATCH v3 0/1] MR7116: winex11: Respect swp_flags when syncing window position. - approved
by Alexandre Julliard (＠julliard) 09 Jan '25

09 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7116

1 0

Re: [PATCH v3 0/1] MR7122: quartz/dsoundrender: Restart the render thread when clearing EOS in dsound_render_sink_end_flush(). - approved
by Alexandre Julliard (＠julliard) 09 Jan '25

09 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7122

1 0

Re: [PATCH v3 0/1] MR7120: vbscript: remove trailing semicolon in parser - approved
by Alexandre Julliard (＠julliard) 09 Jan '25

09 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7120

1 0

Re: [PATCH v2 0/2] MR7118: rsaenh: CPGenKey() shouldn't generate RC4 key salt if not requested. - approved
by Alexandre Julliard (＠julliard) 09 Jan '25

09 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7118

1 0

[PATCH v2 0/1] MR7116: winex11: Respect swp_flags when syncing window position.
by Gabriel Ivăncescu (＠insn) 09 Jan '25

09 Jan '25

-- v2: winex11: Respect swp_flags when syncing window position. https://gitlab.winehq.org/wine/wine/-/merge_requests/7116

3 5

[PATCH v2 0/1] MR7010: mf: Do not clean up a session op if it was submitted to a work queue.
by Conor McCarthy (＠cmccarthy) 09 Jan '25

09 Jan '25

Fixes a regression introduced by 500470029b67a2a07b68e4ce8a134c6819b9b838 -- v2: mf: Do not clean up a session op if it was submitted to a work queue. https://gitlab.winehq.org/wine/wine/-/merge_requests/7010

4 5

[PATCH v2 0/1] MR7122: quartz/dsoundrender: Restart the render thread when clearing EOS in dsound_render_sink_end_flush().
by Connor McAdams (＠cmcadams) 09 Jan '25

09 Jan '25

This fixes the hang mentioned in https://bugs.winehq.org/show_bug.cgi?id=57632 introduced by e6b8e9ee20937f12dbf19145a9f2ca1ca3364da3. That bug also mentions the radio being silent, that's unrelated to the hang should probably be a separate bug. -- v2: quartz/dsoundrender: Restart the render thread when clearing EOS in dsound_render_sink_end_flush(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7122

4 4

[PATCH 0/1] MR7122: quartz/dsoundrender: Restart the render thread when clearing EOS in dsound_render_sink_end_flush().
by Connor McAdams (＠cmcadams) 09 Jan '25

09 Jan '25

This fixes the hang mentioned in https://bugs.winehq.org/show_bug.cgi?id=57632 introduced by e6b8e9ee20937f12dbf19145a9f2ca1ca3364da3. That bug also mentions the radio being silent, that's unrelated to the hang should probably be a separate bug. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7122

4 3

[PATCH v3 0/6] MR7117: crypt32: Some fixes for verify_ssl_policy().
by Paul Gofman (＠gofman) 09 Jan '25

09 Jan '25

-- v3: crypt32: Favour CERT_CHAIN_POLICY_IGNORE_WRONG_USAGE_FLAG in verify_ssl_policy(). crypt32: Only mind end certificate when checking revocation status in verify_ssl_policy(). crypt32: Favour CERT_CHAIN_POLICY_IGNORE_END_REV_UNKNOWN_FLAG in verify_ssl_policy(). crypt32: Check CERT_TRUST_REVOCATION_STATUS_UNKNOWN instead of CERT_TRUST_IS_OFFLINE_REVOCATION in verify_ssl_policy(). crypt32: Fix some error codes in verify_ssl_policy(). crypt32/tests: Add more tests for VerifyCertChainPolicy(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7117

3 8

[PATCH 0/1] MR7116: winex11: Respect swp_flags when syncing window position.
by Gabriel Ivăncescu (＠insn) 09 Jan '25

09 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7116

3 3

[PATCH v2 0/6] MR7117: crypt32: Some fixes for verify_ssl_policy().
by Paul Gofman (＠gofman) 09 Jan '25

09 Jan '25

-- v2: crypt32: Favour CERT_CHAIN_POLICY_IGNORE_WRONG_USAGE_FLAG in verify_ssl_policy(). crypt32: Only mind end certificate when checking revocation status in verify_ssl_policy(). crypt32: Favour CERT_CHAIN_POLICY_IGNORE_END_REV_UNKNOWN_FLAG in verify_ssl_policy(). crypt32: Check CERT_TRUST_REVOCATION_STATUS_UNKNOWN instead of CERT_TRUST_IS_OFFLINE_REVOCATION in verify_ssl_policy(). crypt32: Fix some error codes in verify_ssl_policy(). crypt32/tests: Add more tests for VerifyCertChainPolicy(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7117

3 7

[PATCH 0/1] MR7113: kernelbase: Ignore cli/sti priviledged instruction exceptions on WOW64.
by Rémi Bernon (＠rbernon) 09 Jan '25

09 Jan '25

International Rally Championship executes cli on startup and sti on exit, this currently crashes as an exception is thrown and isn't handled by the game. The ntdll:exception tests show that an exception is thrown on x86_64, i386 and WOW64 mode, however the game also runs fine when executed in a Windows 10 64bit VM (with 640x480 16bpp compatibility mode). It crashes when run in a Windows 8 32bit VM, so possibly something WOW64 related swallows the exception. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57381 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7113

4 8

[PATCH 0/6] MR7117: crypt32: Some fixes for verify_ssl_policy().
by Paul Gofman (＠gofman) 09 Jan '25

09 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7117

4 10

[PATCH 0/1] MR7121: winex11: Allow Withdrawn requests to override Iconic <-> Normal transitions.
by Rémi Bernon (＠rbernon) 09 Jan '25

09 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57650 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7121

2 2

[PATCH v5 0/1] MR7052: vbscript: implement Join()
by Francis De Brabandere (＠francisdb) 09 Jan '25

09 Jan '25

closes https://bugs.winehq.org/show_bug.cgi?id=56464 -- v5: vbscript: implement Join() https://gitlab.winehq.org/wine/wine/-/merge_requests/7052

3 2

[PATCH 0/2] MR7119: ntdll, loader: Add __attribute__((used)) to a few symbols that shouldn't be discarded.
by William Horvath (＠whrvth) 09 Jan '25

09 Jan '25

These changes are enough to allow building the entirety of the native (ELF) side with `-flto`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7119

3 3

[PATCH 0/2] MR7118: rsaenh: CPGenKey() shouldn't generate RC4 key salt if not requested.
by Dmitry Timoshkov (＠dmitry) 09 Jan '25

09 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57566 Hopefully safe enough to be accepted during code freeze. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7118

3 3

[PATCH v4 0/144] MR7098: Draft: Fighting with tests for 9.0.1
by Michael Stefaniuc (＠mstefani) 08 Jan '25

08 Jan '25

No reviews required.\ This is just to get the test results as seen by gitlab.\ MR will be cancelled afterwards. -- v4: winhttp: Always return result at once if available in WinHttpReadData(). winhttp: Always return result at once if available in WinHttpQueryDataAvailable(). user32/tests: Fix some sysparams results on recent Windows. user32/tests: Fix cursoricon tests on recent Windows versions. urlmon/tests: Skip test if ftp connection fails. crypt32/tests: Fix a test failure. wininet: Parse multi-token Connection strings for Keep-Alive. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7098

1 0

Re: [PATCH v4 0/4] MR7058: programs/cmd: Skip trailing white spaces in FOR's option. - approved
by Alexandre Julliard (＠julliard) 08 Jan '25

08 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7058

1 0

Re: [PATCH v9 0/2] MR7049: vbscript: fix Mid() empty and null handling - approved
by Alexandre Julliard (＠julliard) 08 Jan '25

08 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7049

1 0

Re: [PATCH v2 0/2] MR7114: rsaenh/tests: Add some RC4 tests. - approved
by Alexandre Julliard (＠julliard) 08 Jan '25

08 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7114

1 0

Re: [PATCH v3 0/2] MR7094: winex11.drv: Flush before blitting offscreen drawable in wglFlush() and wglFinish(). - approved
by Alexandre Julliard (＠julliard) 08 Jan '25

08 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7094

1 0

Re: [PATCH v4 0/1] MR7054: gdiplus: Use font linking only for missing glyphs. - approved
by Alexandre Julliard (＠julliard) 08 Jan '25

08 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7054

1 0

[PATCH 0/4] MR7112: crypt32, cryptnet: OCSP revocation check improvements.
by Paul Gofman (＠gofman) 08 Jan '25

08 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7112

4 12

Re: [PATCH v8 0/2] MR7049: vbscript: fix Mid() empty and null handling
by Jacek Caban (＠jacek) 08 Jan '25

08 Jan '25

On Wed Jan 8 18:15:02 2025 +0000, Francis De Brabandere wrote: > @jacek split up and don't think any of the test failures is related. > What's up with all these flaky tests anyway? Yeah, our CI is not perfect. No need to worry if they are not related to your changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7049#note_91661

1 0

Re: [PATCH v8 0/2] MR7049: vbscript: fix Mid() empty and null handling - approved
by Jacek Caban (＠jacek) 08 Jan '25

08 Jan '25

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7049

1 0

[PATCH v14 0/2] MR7070: Draft: vbscript: redim without dim
by Francis De Brabandere (＠francisdb) 08 Jan '25

08 Jan '25

fixes https://bugs.winehq.org/show_bug.cgi?id=53767 -- v14: vbscript: trying test the compile error https://gitlab.winehq.org/wine/wine/-/merge_requests/7070

3 3

[PATCH 0/2] MR7114: rsaenh/tests: Add some RC4 tests.
by Dmitry Timoshkov (＠dmitry) 08 Jan '25

08 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7114

2 2

Re: [PATCH v8 0/2] MR7049: vbscript: fix Mid() empty and null handling
by Francis De Brabandere (＠francisdb) 08 Jan '25

08 Jan '25

@jacek split up and don't think any of the test failures is related. What's up with all these flaky tests anyway? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7049#note_91648

1 0

[PATCH v3 0/4] MR7058: programs/cmd: Skip trailing white spaces in FOR's option.
by eric pouech (＠epo) 08 Jan '25

08 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57570 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v3: programs/cmd: Don't return syntax error code on empty lines. programs/cmd: Fix some CALL errorlevel propagation. programs/cmd: Skip trailing white spaces in FOR's option. programs/cmd: Add more tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/7058

2 5

[PATCH v13 0/1] MR7070: Draft: vbscript: redim without dim
by Francis De Brabandere (＠francisdb) 08 Jan '25

08 Jan '25

fixes https://bugs.winehq.org/show_bug.cgi?id=53767 -- v13: vbscript: redim without dim https://gitlab.winehq.org/wine/wine/-/merge_requests/7070

2 1

[PATCH v7 0/2] MR7049: vbscript: fix Mid() empty and null handling
by Francis De Brabandere (＠francisdb) 08 Jan '25

08 Jan '25

Fixes https://bugs.winehq.org/show_bug.cgi?id=57563 -- v7: vbscript: fix Mid() empty and null handling vbscript: refactor Mid() error tests https://gitlab.winehq.org/wine/wine/-/merge_requests/7049

2 2

[PATCH v12 0/2] MR7070: Draft: vbscript: redim without dim
by Francis De Brabandere (＠francisdb) 08 Jan '25

08 Jan '25

fixes https://bugs.winehq.org/show_bug.cgi?id=53767 -- v12: vbscript: fix Mid() empty and null handling vbscript: refactor Mid() error tests https://gitlab.winehq.org/wine/wine/-/merge_requests/7070

3 3

[PATCH v11 0/1] MR7070: Draft: vbscript: redim without dim
by Francis De Brabandere (＠francisdb) 08 Jan '25

08 Jan '25

fixes https://bugs.winehq.org/show_bug.cgi?id=53767 -- v11: vbscript: redim without dim https://gitlab.winehq.org/wine/wine/-/merge_requests/7070

2 1

Re: [PATCH v10 0/1] MR7070: Draft: vbscript: redim without dim
by Francis De Brabandere (＠francisdb) 08 Jan '25

08 Jan '25

@jacek Is there a place where compiler error tests can be added. Making sure that certain things throw compile errors instead of runtime errors? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7070#note_91639

1 0

[PATCH v9 0/1] MR7070: Draft: vbscript: redim without dim
by Francis De Brabandere (＠francisdb) 08 Jan '25

08 Jan '25

fixes https://bugs.winehq.org/show_bug.cgi?id=53767 -- v9: vbscript: redim without dim https://gitlab.winehq.org/wine/wine/-/merge_requests/7070

2 1

[PATCH v2 0/1] MR7091: windowscodecs: Make values returned from CanConvert consistent
by Jeffrey Smith (＠whydoubt) 08 Jan '25

08 Jan '25

Any time CanConvert returns FALSE for the output parameter, also return an appropriate failing result code. This also adds tests for CanConvert. -- v2: windowscodecs: Make values returned from CanConvert consistent https://gitlab.winehq.org/wine/wine/-/merge_requests/7091

4 8

[PATCH v3 0/137] MR7098: Draft: Fighting with tests for 9.0.1
by Michael Stefaniuc (＠mstefani) 08 Jan '25

08 Jan '25

No reviews required.\ This is just to get the test results as seen by gitlab.\ MR will be cancelled afterwards. -- v3: wininet/tests: Update issuer check for winehq.org certificate. user32/tests: Add flaky_wine to some SetActiveWindow tests. urlmon/tests: Expect "Upgrade, Keep-Alive" connection string. urlmon/tests: Fix a test that fails after WineHQ updates. secur32/tests: Mark some test results as broken on old Windows versions. imm32/tests: Add todo_himc to some ImmTranslateMessage expected calls. dnsapi/tests: Update tests for winehq.org DNS changes. gitlab: Do not run the build script on each commit. gitlab: Remove make -j options. gitlab: Update configuration for the new Mac runner. gitlab: Add 'build' tag on Linux build jobs. secur32/tests: Update the tests to expect HTTP/2 headers. secur32/tests: Update count for new winehq.org certificate. secur32/tests: Switch to TLS 1.2 for connections to test.winehq.org. secur32: Handle GNUTLS_MAC_AEAD. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7098

1 0

[PATCH 0/2] MR7111: Draft: support building Wine with LTO
by Konstantin Demin (＠rockdrilla) 07 Jan '25

07 Jan '25

work is still in progress. todo: - ensure that all affected sources (i.e. C sources with any kind of assembly) are listed in either way for all architectures - test Wine built with LTO -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7111

4 6

Re: [PATCH v3 0/3] MR7037: ddraw: Clear sysmem textures on the CPU. - approved
by Alexandre Julliard (＠julliard) 07 Jan '25

07 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7037

1 0

Re: [PATCH v5 0/3] MR7056: ddraw: Correctly apply state on multiple devices. - approved
by Alexandre Julliard (＠julliard) 07 Jan '25

07 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7056

1 0

Re: [PATCH v3 0/2] MR7079: ddraw: Invalidate the window when the primary surface is released. - approved
by Alexandre Julliard (＠julliard) 07 Jan '25

07 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7079

1 0

Re: [PATCH v4 0/1] MR7106: winex11: Use the win32 client rect in needs_client_window_clipping. - approved
by Alexandre Julliard (＠julliard) 07 Jan '25

07 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7106

1 0

Re: [PATCH v5 0/2] MR7088: win32u: Use a color table with default palette for 8bpp window surfaces. - approved
by Alexandre Julliard (＠julliard) 07 Jan '25

07 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7088

1 0

Re: [PATCH v2 0/2] MR7105: wineboot: Fix crashes/undefined behavior on older (pre-SMBIOS 3.0) Intel Macs - approved
by Alexandre Julliard (＠julliard) 07 Jan '25

07 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7105

1 0

[PATCH v3 0/1] MR7054: gdiplus: Use font linking only for missing glyphs.
by Esme Povirk (＠madewokherd) 07 Jan '25

07 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57076 I don't know if this is how native does it, but it makes intuitive sense to me that if we have a glyph in the requested font, we should use it, and this fixes the bug in question. This should avoid the possibility of regression in cases where font linking isn't needed. There is a possibility of regression in corner cases handled better by the earlier version of font linking. -- v3: gdiplus: Use font linking only for missing glyphs. https://gitlab.winehq.org/wine/wine/-/merge_requests/7054

2 2

[PATCH v2 0/1] MR7054: gdiplus: Use font linking only for missing glyphs.
by Esme Povirk (＠madewokherd) 07 Jan '25

07 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57076 I don't know if this is how native does it, but it makes intuitive sense to me that if we have a glyph in the requested font, we should use it, and this fixes the bug in question. This should avoid the possibility of regression in cases where font linking isn't needed. There is a possibility of regression in corner cases handled better by the earlier version of font linking. -- v2: gdiplus: Use font linking only for missing glyphs. https://gitlab.winehq.org/wine/wine/-/merge_requests/7054

2 1

[PATCH 0/1] MR7054: gdiplus: Use font linking only for missing glyphs.
by Esme Povirk (＠madewokherd) 07 Jan '25

07 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57076 I don't know if this is how native does it, but it makes intuitive sense to me that if we have a glyph in the requested font, we should use it, and this fixes the bug in question. This should avoid the possibility of regression in cases where font linking isn't needed. There is a possibility of regression in corner cases handled better by the earlier version of font linking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7054

3 7

[PATCH v2 0/2] MR7094: winex11.drv: Flush before blitting offscreen drawable in wglFlush() and wglFinish().
by Paul Gofman (＠gofman) 07 Jan '25

07 Jan '25

-- v2: winex11.drv: Call glFinish() when presenting offscreen drawable from wglFlush. winex11.drv: Flush display when presenting offcreen drawable from wglFlush / wglFinish. https://gitlab.winehq.org/wine/wine/-/merge_requests/7094

4 15

[PATCH v3 0/14] MR7063: win32u: More fixes for arcs.
by Elizabeth Figura (＠zfigura) 07 Jan '25

07 Jan '25

This time including some regression tests. -- v3: win32u: Emit a rectangle for 1-pixel ellipses. win32u: Normalize the ellipse width/height in dibdrv_RoundRect(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7063

4 18

Re: [PATCH v2 0/1] MR7058: programs/cmd: Skip trailing white spaces in FOR's option.
by Alexandre Julliard (＠julliard) 07 Jan '25

07 Jan '25

A test case would be nice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7058#note_91576

1 0

Re: [PATCH v2 0/1] MR7058: programs/cmd: Skip trailing white spaces in FOR's option.
by eric pouech (＠epo) 07 Jan '25

07 Jan '25

@julliard anything wrong with this patch? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7058#note_91575

1 0

[PATCH 0/1] MR7108: tools: Add manual-run job for new-style wow64.
by Jinoh Kang (＠iamahuman) 07 Jan '25

07 Jan '25

The new job is only triggered when a developer manually starts it. Before run, it initially appears as a "skipped" job when the pipeline starts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7108

2 1

[PATCH v2 0/2] MR7079: ddraw: Invalidate the window when the primary surface is released.
by Anton Baskanov (＠baskanov) 07 Jan '25

07 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57599 -- v2: ddraw: Invalidate the window when the primary surface is released. ddraw/tests: Test that releasing a primary surface invalidates the window. https://gitlab.winehq.org/wine/wine/-/merge_requests/7079

4 6

[PATCH v4 0/3] MR7056: ddraw: Correctly apply state on multiple devices.
by Paul Gofman (＠gofman) 07 Jan '25

07 Jan '25

-- v4: ddraw: Correctly apply state when multiple devices are used. ddraw: Factor out d3d_device_apply_state(). ddraw/test: Test state application on multiple devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/7056

5 8

[PATCH v2 0/3] MR7037: ddraw: Clear sysmem textures on the CPU.
by Elizabeth Figura (＠zfigura) 07 Jan '25

07 Jan '25

-- v2: ddraw: Clear sysmem textures on the CPU. https://gitlab.winehq.org/wine/wine/-/merge_requests/7037

4 6

[PATCH v3 0/1] MR7106: winex11: Use the win32 client rect in needs_client_window_clipping.
by William Horvath (＠whrvth) 07 Jan '25

07 Jan '25

After the change to move the sync_gl_drawable call outside the win_data mutex in 54d82ed4, the X11 client rect used for determining whether we need to composite/clip the drawable can be out of sync with the win32 side. This would result in offscreening when unnecessary and vice-versa. -- v3: winex11: Use the win32 client rect in needs_client_window_clipping. https://gitlab.winehq.org/wine/wine/-/merge_requests/7106

3 2

[PATCH v2 0/1] MR7106: winex11: Update window pos before syncing gl drawable.
by William Horvath (＠whrvth) 07 Jan '25

07 Jan '25

Otherwise, the client rect in [needs_client_window_clipping](https://gitlab.winehq.org/wine/wine/-/blob/3f… is outdated, which can result in offscreening when it's not necessary or vice-versa. This keeps the intention of 54d82ed4d5483f7569871219acc485b3cb5a224e while restoring the previous behavior. -- v2: winex11: Use the win32 client rect in needs_client_window_clipping. https://gitlab.winehq.org/wine/wine/-/merge_requests/7106

3 6

[PATCH v4 0/2] MR7088: win32u: Use a color table with default palette for 8bpp window surfaces.
by Rémi Bernon (＠rbernon) 07 Jan '25

07 Jan '25

NtGdiCreateDIBSection will allocate a color table for 8bpp bitmap anyway and if biClrUsed isn't set, we will later fail any color lookup. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57584 -- v4: winex11: Always fill the window surface color info. win32u: Initialize dibdrv info from the surface color bitmap. https://gitlab.winehq.org/wine/wine/-/merge_requests/7088

2 3

Re: [PATCH v3 0/2] MR7088: win32u: Use a color table with default palette for 8bpp window surfaces.
by Rémi Bernon (＠rbernon) 07 Jan '25

07 Jan '25

v3: Use the surface bitmap directly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7088#note_91553

1 0

[PATCH 0/1] MR7106: winex11: Update window pos before syncing gl drawable.
by William Horvath (＠whrvth) 07 Jan '25

07 Jan '25

Otherwise, the client rect in [needs_client_window_clipping](https://gitlab.winehq.org/wine/wine/-/blob/3f… is outdated, which can result in offscreening when it's not necessary or vice-versa. This keeps the intention of 54d82ed4d5483f7569871219acc485b3cb5a224e while restoring the previous behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7106

4 3

[PATCH v3 0/1] MR7082: ntdll: Return an error if count is zero in NtRemoveIoCompletionEx.
by Alex Henrie (＠alexhenrie) 07 Jan '25

07 Jan '25

Without this check, the return value is undefined. -- v3: ntdll: Return an error if count is zero in NtRemoveIoCompletionEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/7082

2 2

[PATCH v2 0/1] MR7068: vbscript: class single line multivar
by Francis De Brabandere (＠francisdb) 06 Jan '25

06 Jan '25

closes https://bugs.winehq.org/show_bug.cgi?id=53644 * This applies the patch [provided by](https://bugs.winehq.org/show_bug.cgi?id=53644) @sloper42 and adds tests. * I left a TODO for accessing class variables of type array for a later mr. -- v2: vbscript: class single line multivar https://gitlab.winehq.org/wine/wine/-/merge_requests/7068

3 3

Re: [PATCH v3 0/10] MR7101: win32u: Revert transformed arc support. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7101

1 0

Re: [PATCH v2 0/2] MR7102: winex11: Map mouse/touch event coordinates even without a hwnd. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7102

1 0

2025

2024

2023

2022

wine-gitlab