- wine-gitlab - winehq.org

Re: [PATCH v7 0/85] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Piotr Caban (＠piotr) 29 Jan '25

29 Jan '25

I have cleaned up the patches and created !7225 since I can't push to your branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109#note_93216

1 0

Re: [PATCH v7 0/85] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf - closed
by Piotr Caban (＠piotr) 29 Jan '25

29 Jan '25

This merge request was closed by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109

1 0

Re: [PATCH v2 0/5] MR7225: msvcr120: Add _FCbuild, cimag, cimags and crealf implementation. - approved
by Piotr Caban (＠piotr) 29 Jan '25

29 Jan '25

This merge request was approved by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7225

1 0

Re: [PATCH v8 0/1] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 29 Jan '25

29 Jan '25

OK, I just submitted an updated change. I spent a lot of time yesterday and today getting the logic right, testing various /O options, side by side with Windows. This looks right to me. I did abstain from cleaning up the use of the global variables. This change at least does not add any. Cleaning those up will be an exercise for (another person at) another time. Let me know what you think of the change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_93212

1 0

[PATCH 0/5] MR7225: msvcr120: Add _FCbuild, cimag, cimags and crealf implementation.
by Piotr Caban (＠piotr) 29 Jan '25

29 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7225

4 6

[PATCH 0/1] MR7220: winex11.drv: Update window shape before putting surface image.
by Paul Gofman (＠gofman) 29 Jan '25

29 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7220

4 7

[PATCH v2 0/1] MR7223: urlmon: Make security zone names and descriptions translatable.
by Alex Henrie (＠alexhenrie) 29 Jan '25

29 Jan '25

GetZoneAttributes ignores the names and descriptions in the registry for the first five zones. Do the same in Wine. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=27245 Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/7084 -- v2: urlmon: Make security zone names and descriptions translatable. https://gitlab.winehq.org/wine/wine/-/merge_requests/7223

3 2

[PATCH v4 0/4] MR7216: winebth.sys part 3: Introduce IOCTLs related to radio discoverability, connectability and device inquiry.
by Vibhav Pant (＠vibhavp) 29 Jan '25

29 Jan '25

The Windows Bluetooth stack uses private IOCTLs in order to set the [discoverability](https://learn.microsoft.com/en-us/windows/win32/api/blueto… and [connectability](https://learn.microsoft.com/en-us/windows/win32/api/bluetoo… status of a local radio, and to start/stop the device inquiry procedure. This MR introduces 3 wine-specific IOCTL codes for the same purposes, as most applications seem to the Win32 API itself for these operations: * IOCTL_WINBTH_RADIO_SET_FLAG * … [View More]

3 5

[PATCH v5 0/4] MR7216: winebth.sys part 3: Introduce IOCTLs related to radio discoverability, connectability and device inquiry.
by Vibhav Pant (＠vibhavp) 29 Jan '25

29 Jan '25

The Windows Bluetooth stack uses private IOCTLs in order to set the [discoverability](https://learn.microsoft.com/en-us/windows/win32/api/blueto… and [connectability](https://learn.microsoft.com/en-us/windows/win32/api/bluetoo… status of a local radio, and to start/stop the device inquiry procedure. This MR introduces 3 wine-specific IOCTL codes for the same purposes, as most applications seem to the Win32 API itself for these operations: * IOCTL_WINBTH_RADIO_SET_FLAG * … [View More]

2 4

Re: [PATCH v8 0/2] MR5633: win32u: Use the first vertical alternates table regardless of script.
by Akihiro Sagawa (＠sgwaki) 29 Jan '25

29 Jan '25

On Wed Jan 29 12:14:33 2025 +0000, Huw Davies wrote: > Looks good. By the time it was ready, it was too late in the release cycle. I can see why. Thanks for reviewing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5633#note_93190

1 0

Re: [PATCH v7 0/85] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Stéphane Bacri (＠fr33z00) 29 Jan '25

29 Jan '25

@piotr The build-linux stage is still complaining about email, and I can't figure out why. I checked, and all my commits where done with the config set correctly. I merged changes from wine/master, so, now, everything is up to date. I'm wondering if I should close this MR and create a new one. Can you make an advice? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109#note_93189

1 0

[PATCH v6 0/85] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Stéphane Bacri (＠fr33z00) 29 Jan '25

29 Jan '25

This MR intends to add the complex numbers related functions: * cimag * _FCbuild * crealf * cimagf These functions are defined in dlls/msvcr120/math.c and mapped in dlls/msvcr120/msvcr120.spec and dlls/ucrbase/ucrbase.spec. The related tests were added in dlls/mscr120/tests/msvcr120.c and result were checked. -- v6: fixed msvcr120_app spec Revert "fixed msvcr120_app spec" because of missing user info winex11: Attach currently active Vulkan onscreen surface in … [View More]vulkan_surface_update_offscreen(). win32u: Don't invalidate existing Vulkan surface when a new one is created for window. win32u: Check for NULL hwnd before calling vulkan_surface_presented() driver callback. win32u: Nullify surface hwnd when detaching Vulkan surface. winex11: Allow Withdrawn requests to override Iconic <-> Normal transitions. include: Add signbit declarations for c++. dinput: Clamp FFB effect report value to the field range. dinput/tests: Add more tests for force feedback. win32u: Implement NtUserPostQuitMessage(). win32u: Implement NtUserMessageBeep(). win32u: Implement NtUserEnumClipboardFormats(). win32u: Implement NtUserCreateMenu() and NtUserCreatePopupMenu(). win32u: Implement NtUserGetThreadState(). win32u: Implement NtUserReleaseCapture(). win32u: Implement NtUserDestroyCaret(). hhctrl: Use wide character string literals. cryptui: Use wide character string literals. ntdll: Fix the return value of NtDelayExecution. ntdll/tests: Add tests for NtDelayExecution and Sleep(Ex). sapi: Remove some unnecessary traces. sapi: Implement IStream methods for SpStream. sapi: Implement ISpStream::GetFormat. sapi: Implement ISpStream::Close. sapi: Implement ISpStream::Set/GetBaseStream. sapi: Adding missing interfaces for SpStream. include: Use flexible array-member in some structure declarations. include: Add a couple of definitions to mscvpdb.h. include: Add some new definitions for dbghelp.h. win32u: Use the first vertical alternates table regardless of script. gdi32/tests: Add tests for script-independent vertical glyph lookup. wineps: Use simple strings for glyph names. wineps: Remove some unused AFM values. wineps: Don't parse the glyph name or encoding when loading AFM files. wineps: Don't store the glyph name or encoding for individual glyphs. user32/tests: Add tests for WM_COPYDATA. win32u: Allocate a separate user buffer when packing a large WM_COPYDATA message for user32. wintypes: Stub of IRandomAccessStreamReferenceStatics interface. wintypes: Stub of Windows.Storage.Streams.RandomAccessStreamReference runtimeclass. wintypes: Return S_OK from data_writer_activation_factory_ActivateInstance(). wintypes: Stub of Windows.Storage.Streams.DataWriter runtimeclass. wintypes: Reimplement Windows.Foundation.Metadata.{ApiInformation,PropertyValue} separately. wintypes/tests: Add interface tests. include: Don't import .idl when DO_NO_IMPORTS is defined. shlwapi: Use wide character string literals. winhlp32: Use wide character string literals. tapi32: Use wide character string literals. hhctrl: Fix spelling of "local" in OnTopicChange. ntdll/tests: Add RtlRealSuccessor() tests. ntdll: Implement RtlRealSuccessor(). ntdll/tests: Add RtlRealPredecessor() tests. ntdll: Implement RtlRealPredecessor(). wine.inf: Pass command line arguments to msiexec. wined3d: Add Nvidia RTX40xx series desktop models data. wined3d: Add Nvidia RTX30xx series desktop models data. prntvpt: Implement writing PageImageableSize capabilities. prntvpt: Implement writing PageMediaSize capabilities. wined3d/spirv: Implement alpha test. wined3d: Feed alpha ref through a push constant buffer. wined3d/glsl: Move legacy alpha test to shader_glsl_apply_draw_state(). wined3d/spirv: Implement flat shading. wined3d: Use ps_compile_args in shader_spirv_compile_arguments. wined3d: Bind the right push constant buffers when FFP is toggled. ole32: Set property storage clsid on creation. ole32: Fix IPropertyStorage::ReadMultiple return value when some properties are missing. ole32: Add support for reading VT_R4 property. secur32: Update max token size for Negotiate. kerberos: Update sizes to match modern implementations. propsys: Remove FIXME() from PropVariantChangeType(). kernel32/tests: Match the value in the debug message the test condition. crypt32: Don't assert in Context_Release() on invalid refcount. crypt32/tests: Add a test for deleting and adding certs during enumeration. crypt32: Only remove cert from mem store list when deleting it. crypt32: Release existing cert context in add_cert_to_store(). crypt32: Don't try to release zero-refcount context in MemStore_addContext(). crypt32: Factor out memstore_free_context() function. crypt32: Release cert context in CertDeleteCertificateFromStore(). msvcp140: Fix field order in _Mtx_t. msvcp140/tests: Add more tests for _Mtx_t. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7109 [View Less]

1 0

Re: [PATCH v7 0/0] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by eric pouech (＠epo) 29 Jan '25

29 Jan '25

On Wed Jan 29 09:48:53 2025 +0000, Joe Souza wrote: > After spending some time looking at the existing code, I find that it's > not that far off from working properly. It correctly allows for > multiple options to be specified on the command line, and correctly > handles the exclusive options (i.e. of /N, /E, /S, /D, it correctly > allows only one of these to take effect). What it gets wrong is that in > Windows, the first of the exclusive options encountered takes > … [View More]

1 0

[PATCH 0/2] MR7224: wbemprox: Implement Win32_PnPEntity.Service.
by Hans Leidekker (＠hans) 29 Jan '25

29 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7224

3 3

[PATCH 0/1] MR7218: crypt32/tests: Avoid use after free in testEmptyStore().
by Paul Gofman (＠gofman) 29 Jan '25

29 Jan '25

Which is use after free since commit 278437b266ed97cebb8e1c14be6cfa2c4f440f07. Thanks Bernhard Übelacker for spotting this (based on ASan validation). For a general case I'd say we can have some tests intentionally doing use after free but it is not needed here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7218

3 3

[PATCH 0/8] MR7215: crypt32: Improve support for CMSGs.
by Dmitry Timoshkov (＠dmitry) 29 Jan '25

29 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7215

3 9

[PATCH 0/1] MR7223: urlmon: Make security zone names and descriptions translatable.
by Alex Henrie (＠alexhenrie) 29 Jan '25

29 Jan '25

GetZoneAttributes ignores the names and descriptions in the registry for the first five zones. Do the same in Wine. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=27245 Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/7084 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7223

3 2

[PATCH 0/1] MR7207: d3d9: Fix IUnknown delegation in IDirect3DDevice9On12.
by Elizabeth Figura (＠zfigura) 29 Jan '25

29 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7207

4 3

[PATCH 0/1] MR7084: inetcpl: Make security zone names and descriptions translatable.
by Alex Henrie (＠alexhenrie) 29 Jan '25

29 Jan '25

Windows ignores the names and descriptions in the registry when populating the Security tab in Internet Options. Do the same in Wine. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=27245 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7084

4 6

[PATCH v7 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 29 Jan '25

29 Jan '25

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, … [View More]

5 19

[PATCH v2 0/1] MR7221: ieframe: Add IShellWindows stub implementation.
by Helix Graziani (＠TornadoCookie) 29 Jan '25

29 Jan '25

-- v2: ieframe: Add IShellWindows stub implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/7221

3 3

[PATCH 0/1] MR7221: ieframe: Add IShellWindows stub implementation.
by Helix Graziani (＠TornadoCookie) 29 Jan '25

29 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7221

3 2

Re: [PATCH v3 0/7] MR3909: winewayland.drv: part 7: Basic window management
by Dominic Hayes - Feren OS Dev (＠dominichayesferen) 29 Jan '25

29 Jan '25

I know it's been a year, but I'm not sure where else would be best to ask this, so: Are there plans to support XDG_DECORATION in WINE ~11, and will it prefer SSDs on the application-side? Aside from that, for those who have to deal with the CSD titlebars, is there any desire to upgrade the CSDs from Windows Classic to Windows Basic CSDs? All the textures for Windows Basic exist in Windows XP msstyles, afterall, given Windows Basic derivatives from Windows XP's window manager afterall, and … [View More]

1 0

[PATCH v2 0/1] MR7172: win32u: Implement a couple of syscalls.
by Paul Gofman (＠gofman) 28 Jan '25

28 Jan '25

-- v2: win32u: Implement NtUserGetCurrentInputMessageSource(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7172

3 2

Re: [PATCH v3 0/4] MR7219: win32u, winex11.drv: Fix multiple Vulkan surfaces handling. - approved
by Alexandre Julliard (＠julliard) 28 Jan '25

28 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7219

1 0

Re: [PATCH v3 0/1] MR7121: winex11: Allow Withdrawn requests to override Iconic <-> Normal transitions. - approved
by Alexandre Julliard (＠julliard) 28 Jan '25

28 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7121

1 0

Re: [PATCH v2 0/1] MR7043: include: Add signbit declarations for c++. - approved
by Alexandre Julliard (＠julliard) 28 Jan '25

28 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7043

1 0

Re: [PATCH v2 0/2] MR7217: dinput: Clamp FFB effect report value to the field range. - approved
by Alexandre Julliard (＠julliard) 28 Jan '25

28 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7217

1 0

Re: [PATCH v2 0/1] MR7209: hhctrl: Use wide character string literals. - approved
by Alexandre Julliard (＠julliard) 28 Jan '25

28 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7209

1 0

Re: [PATCH v2 0/1] MR7208: cryptui: Use wide character string literals. - approved
by Alexandre Julliard (＠julliard) 28 Jan '25

28 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7208

1 0

Re: [PATCH v13 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution. - approved
by Alexandre Julliard (＠julliard) 28 Jan '25

28 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7169

1 0

[PATCH v2 0/4] MR7219: win32u, winex11.drv: Fix multiple Vulkan surfaces handling.
by Paul Gofman (＠gofman) 28 Jan '25

28 Jan '25

-- v2: winex11.drv: Attach currently active Vulkan onscreen surface in vulkan_surface_update_offscreen(). win32u: Don't invalidate existing Vulkan surface when a new one is created for window. win32u: Check for NULL hwnd before calling vulkan_surface_presented() driver callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/7219

4 7

[PATCH 0/4] MR7219: win32u, winex11.drv: Fix multiple Vulkan surfaces handling.
by Paul Gofman (＠gofman) 28 Jan '25

28 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7219

4 11

Re: [PATCH v6 0/0] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 28 Jan '25

28 Jan '25

After spending some time looking at the existing code, I find that it's not that far off from working properly. It correctly allows for multiple options to be specified on the command line, and correctly handles the exclusive options (i.e. of /N, /E, /S, /T, it correctly allows only one of these to take effect). What it gets wrong is that in Windows, the first of the exclusive options encountered takes precedence, where in current Wine code, it's the last exclusive option encountered that … [View More]

1 0

[PATCH v3 0/1] MR7158: wine.inf.in: Add UBR key
by Etaash Mathamsetty (＠etaash.mathamsetty) 28 Jan '25

28 Jan '25

Required by Logitech G Hub -- v3: wine.inf.in: Add UBR key. https://gitlab.winehq.org/wine/wine/-/merge_requests/7158

4 3

Re: [PATCH v2 0/3] MR7213: mountmgr: Set more registry values for serial and parport devices.
by Hans Leidekker (＠hans) 28 Jan '25

28 Jan '25

Right, GPUs and monitors. I don't think it's that much of a hack considering that we're already setting registry values here but I'll look into a PnP function driver. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7213#note_93083

1 0

Re: [PATCH v2 0/3] MR7213: mountmgr: Set more registry values for serial and parport devices.
by Elizabeth Figura (＠zfigura) 28 Jan '25

28 Jan '25

> We don't do that for all devices and it's not clear to me what we would gain by doing so. Well, it'd be significantly more correct. That often counts for a lot. As far as I can think of, the only devices for which we don't use the PnP architecture, and instead perform this kind of hack, are the GPU devices. That's because they're kind of tied to the explorer process rather than being able to be enumerated from winedevice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7213#note_93082

1 0

Re: [PATCH v2 0/3] MR7213: mountmgr: Set more registry values for serial and parport devices.
by Hans Leidekker (＠hans) 28 Jan '25

28 Jan '25

We don't do that for all devices and it's not clear to me what we would gain by doing so. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7213#note_93076

1 0

Re: [PATCH v2 0/3] MR7213: mountmgr: Set more registry values for serial and parport devices.
by Elizabeth Figura (＠zfigura) 28 Jan '25

28 Jan '25

Should we implement this the proper way, with an actual PNP function driver? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7213#note_93074

1 0

[PATCH 0/2] MR7217: dinput: Clamp FFB effect report value to the field range.
by Rémi Bernon (＠rbernon) 28 Jan '25

28 Jan '25

Superseding https://gitlab.winehq.org/wine/wine/-/merge_requests/7161 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7217

3 4

[PATCH v3 0/4] MR7216: winebth.sys part 3: Introduce IOCTLs related to radio discoverability, connectability and device inquiry.
by Vibhav Pant (＠vibhavp) 28 Jan '25

28 Jan '25

The Windows Bluetooth stack uses private IOCTLs in order to set the [discoverability](https://learn.microsoft.com/en-us/windows/win32/api/blueto… and [connectability](https://learn.microsoft.com/en-us/windows/win32/api/bluetoo… status of a local radio, and to start/stop the device inquiry procedure. This MR introduces 3 wine-specific IOCTL codes for the same purposes, as most applications seem to the Win32 API itself for these operations: * IOCTL_WINBTH_RADIO_SET_FLAG * … [View More]

2 4

Re: [PATCH v6 0/2] MR7161: dinput: Clamp FFB effect report value to the field range.
by Rémi Bernon (＠rbernon) 28 Jan '25

28 Jan '25

Thank you! I opened !7217 with a couple of minor tweaks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7161#note_93069

1 0

Re: [PATCH v6 0/2] MR7161: dinput: Clamp FFB effect report value to the field range. - closed
by Rémi Bernon (＠rbernon) 28 Jan '25

28 Jan '25

This merge request was closed by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7161

1 0

[PATCH 0/4] MR7216: winebth.sys part 3: Introduce IOCTLs related to radio discoverability, connectability and device inquiry.
by Vibhav Pant (＠vibhavp) 28 Jan '25

28 Jan '25

The Windows Bluetooth stack uses private IOCTLs in order to set the [discoverability](https://learn.microsoft.com/en-us/windows/win32/api/blueto… and [connectability](https://learn.microsoft.com/en-us/windows/win32/api/bluetoo… status of a local radio, and to start/stop the device inquiry procedure. This MR introduces 3 wine-specific IOCTL codes for the same purposes, as most applications seem to the Win32 API itself for these operations: * IOCTL_WINBTH_RADIO_SET_FLAG * … [View More]

2 4

Re: [PATCH v5 0/5] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Stéphane Bacri (＠fr33z00) 28 Jan '25

28 Jan '25

@piotr I shall admit I'm a bit confused by the fork way of working and the wine CI. I previously made some rebase, but now, when I click on the rebase button, nothing happens. I didn't want to bother you before the windows build pipelines were successful, but your offer is welcomed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109#note_93055

1 0

Re: [PATCH v5 0/5] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Piotr Caban (＠piotr) 28 Jan '25

28 Jan '25

The patches needs to be rebased on top of current master. You will also need to merge the patches/reverts and get rid of the merges. I have requested access to your repository if you need help with that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109#note_93054

1 0

Re: [PATCH v5 0/5] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Stéphane Bacri (＠fr33z00) 28 Jan '25

28 Jan '25

On Mon Jan 27 21:05:00 2025 +0000, Alexandre Julliard wrote: > Actually _Cbuild has the same problem, but it's less obvious since it > will break only on non-x86 platforms. Hello. Thanks for the clarification! => Change of Cbuild then. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109#note_93053

1 0

[PATCH 0/1] MR7214: Fixed signature of Cbuild and FCbuild
by Stéphane Bacri (＠fr33z00) 28 Jan '25

28 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7214

3 3

[PATCH 0/3] MR7213: mountmgr: Set more registry values for serial and parport devices.
by Hans Leidekker (＠hans) 28 Jan '25

28 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57645 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7213

3 4

[PATCH 0/1] MR7210: setupapi: Use wide character string literals.
by Alex Henrie (＠alexhenrie) 28 Jan '25

28 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7210

3 2

[PATCH 0/1] MR7208: cryptui: Use wide character string literals.
by Alex Henrie (＠alexhenrie) 28 Jan '25

28 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7208

3 2

[PATCH 0/1] MR7209: hhctrl: Use wide character string literals.
by Alex Henrie (＠alexhenrie) 28 Jan '25

28 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7209

2 1

[PATCH v4 0/1] MR7068: vbscript: class single line multivar
by Francis De Brabandere (＠francisdb) 27 Jan '25

27 Jan '25

closes https://bugs.winehq.org/show_bug.cgi?id=53644 * This applies the patch [provided by](https://bugs.winehq.org/show_bug.cgi?id=53644) @sloper42 and adds tests. * I left a TODO for accessing class variables of type array for a later mr. -- v4: vbscript: class single line multivar https://gitlab.winehq.org/wine/wine/-/merge_requests/7068

4 4

[PATCH v6 0/1] MR7052: vbscript: implement Join()
by Francis De Brabandere (＠francisdb) 27 Jan '25

27 Jan '25

closes https://bugs.winehq.org/show_bug.cgi?id=56464 -- v6: vbscript: implement Join() https://gitlab.winehq.org/wine/wine/-/merge_requests/7052

4 7

[PATCH 0/1] MR7184: vbscript: Correct resource text for VBSE_PARAMETER_NOT_OPTIONAL
by Alistair Leslie-Hughes (＠alesliehughes) 27 Jan '25

27 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7184

4 3

Re: [PATCH v2 0/1] MR7138: sapi: Remove some unnecessary traces. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7138

1 0

Re: [PATCH v4 0/5] MR7137: sapi: Implement most ISpStream methods. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7137

1 0

Re: [PATCH v2 0/3] MR7206: Update some include headers regarding debug information. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7206

1 0

Re: [PATCH v8 0/2] MR5633: win32u: Use the first vertical alternates table regardless of script. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5633

1 0

Re: [PATCH v2 0/2] MR7189: win32u: Allocate a separate user buffer when packing a large WM_COPYDATA message for user32. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7189

1 0

Re: [PATCH v2 0/7] MR7187: wintypes: Add stub of Windows.Storage.Streams.{DataWriter,RandomAccessStreamReference} runtimeclass. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7187

1 0

Re: [PATCH v2 0/1] MR7202: shlwapi: Use wide character string literals. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7202

1 0

Re: [PATCH v2 0/1] MR7200: winhlp32: Use wide character string literals. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7200

1 0

Re: [PATCH v2 0/1] MR7199: tapi32: Use wide character string literals. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7199

1 0

Re: [PATCH v2 0/1] MR7198: hhctrl: Fix spelling of "local" in OnTopicChange. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7198

1 0

Re: [PATCH v2 0/4] MR7185: Splay tree part 2 - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7185

1 0

Re: [PATCH v2 0/1] MR7188: wine.inf: Pass command line arguments to msiexec. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7188

1 0

Re: [PATCH v5 0/2] MR7171: wined3d: Add Nvidia RTX30xx and RTX40xx series desktop models data. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7171

1 0

Re: [PATCH v2 0/2] MR7191: prntvpt: Implement writing PageMediaSize capabilities. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7191

1 0

Re: [PATCH v2 0/6] MR7186: wined3d/spirv: Implement flat shading and alpha test. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7186

1 0

Re: [PATCH v2 0/3] MR7192: ole32: Property storage improvements. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7192

1 0

Re: [PATCH v2 0/2] MR7190: kerberos: Update sizes to match modern implementations. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7190

1 0

Re: [PATCH v2 0/1] MR7197: propsys: Remove FIXME() from PropVariantChangeType(). - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7197

1 0

Re: [PATCH v2 0/1] MR7201: kernel32/tests: Match the value in the debug message the test condition. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7201

1 0

Re: [PATCH v6 0/7] MR7193: crypt32: A refcount fix and cert enumeraton improvement. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7193

1 0

Re: [PATCH v3 0/2] MR7196: msvcp140: Fix field order in _Mtx_t. - approved
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7196

1 0

Re: [PATCH v4 0/4] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Alexandre Julliard (＠julliard) 27 Jan '25

27 Jan '25

On Mon Jan 27 21:05:00 2025 +0000, Stéphane Bacri wrote: > Hello, Piotr. > Thanks for your review and comments. However, I'm unsure the issue is > there (and I have no other clue, because no window machine nor VM). I > agree that [MS > documentation](https://learn.microsoft.com/en-us/cpp/c-runtime-library/refe… > defines the signature you mention, but it is the same for _Cbuild, and I > used it as a template. I could have suspected the entries crealf(int64) > & … [View More]

1 0

Re: [PATCH v4 0/4] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Stéphane Bacri (＠fr33z00) 27 Jan '25

27 Jan '25

Hello, Piotr. Thanks for your review and comments. However, I'm unsure the issue is there (and I have no other clue, because no window machine nor VM). I agree that [MS documentation](https://learn.microsoft.com/en-us/cpp/c-runtime-library/refe… defines the signature you mention, but it is the same for _Cbuild, and I used it as a template. I could have suspected the entries crealf(int64) & cimagf(int64) to be the cause if it had been a 32 vs 64 bit issue. But I don't understand why the … [View More]

1 0

[PATCH v12 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution.
by William Horvath (＠whrvth) 27 Jan '25

27 Jan '25

The key change is to never return STATUS_TIMEOUT, and to instead return the result of NtYieldExecution() if zero timeout was passed, or STATUS_SUCCESS otherwise. An overview of the correct values for each combination, copied from the test commit: - Non-alertable, zero timeout: STATUS_SUCCESS or STATUS_NO_YIELD_PERFORMED - Non-alertable, non-zero timeout: STATUS_SUCCESS - Alertable, zero timeout: STATUS_SUCCESS, STATUS_NO_YIELD_PERFORMED, or STATUS_USER_APC - Alertable, non-zero timeout: … [View More]

3 4

[PATCH v11 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution.
by William Horvath (＠whrvth) 27 Jan '25

27 Jan '25

The key change is to never return STATUS_TIMEOUT, and to instead return the result of NtYieldExecution() if zero timeout was passed, or STATUS_SUCCESS otherwise. An overview of the correct values for each combination, copied from the test commit: - Non-alertable, zero timeout: STATUS_SUCCESS or STATUS_NO_YIELD_PERFORMED - Non-alertable, non-zero timeout: STATUS_SUCCESS - Alertable, zero timeout: STATUS_SUCCESS, STATUS_NO_YIELD_PERFORMED, or STATUS_USER_APC - Alertable, non-zero timeout: … [View More]

3 10

[PATCH v2 0/4] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) 27 Jan '25

27 Jan '25

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v2: dlls/oleaut32: Add DeleteTypeInfo() base-cases in typelib.c https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

5 8

[PATCH 0/3] MR7206: Update some include headers regarding debug information.
by eric pouech (＠epo) 27 Jan '25

27 Jan '25

Mostly adding a couple of missing bits. Regarding the 32-bit KDHELP structure definition: - I checked against some SDK:s back to 2000, and the overall size of this structure hasn't changed ever since (some fields have been added with decreasing Reserved array size) - so it's really Wine's header which were missing these fields not the callers -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7206

3 4

[PATCH v10 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution.
by William Horvath (＠whrvth) 27 Jan '25

27 Jan '25

The key change is to never return STATUS_TIMEOUT, and to instead return the result of NtYieldExecution() if zero timeout was passed, or STATUS_SUCCESS otherwise. An overview of the correct values for each combination, copied from the test commit: - Non-alertable, zero timeout: STATUS_SUCCESS or STATUS_NO_YIELD_PERFORMED - Non-alertable, non-zero timeout: STATUS_SUCCESS - Alertable, zero timeout: STATUS_SUCCESS, STATUS_NO_YIELD_PERFORMED, or STATUS_USER_APC - Alertable, non-zero timeout: … [View More]

4 8

[PATCH 0/1] MR7138: sapi: Remove some unnecessary traces.
by Shaun Ren (＠shaunren) 27 Jan '25

27 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7138

3 2

[PATCH v3 0/5] MR7137: sapi: Implement most ISpStream methods.
by Shaun Ren (＠shaunren) 27 Jan '25

27 Jan '25

Needed for Diablo 4's screen reader. -- v3: sapi: Implement IStream methods for SpStream. sapi: Implement ISpStream::GetFormat. https://gitlab.winehq.org/wine/wine/-/merge_requests/7137

4 7

Re: [PATCH v7 0/2] MR5633: win32u: Use the first vertical alternates table regardless of script.
by Huw Davies (＠huw) 27 Jan '25

27 Jan '25

On Mon Jan 27 16:37:50 2025 +0000, Akihiro Sagawa wrote: > @huw, I have been waiting for your review for several months. Do you > have any concerns? Looks good. By the time it was ready, it was too late in the release cycle. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5633#note_92949

1 0

Re: [PATCH v7 0/2] MR5633: win32u: Use the first vertical alternates table regardless of script. - approved
by Huw Davies (＠huw) 27 Jan '25

27 Jan '25

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5633

1 0

[PATCH v9 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution.
by William Horvath (＠whrvth) 27 Jan '25

27 Jan '25

The key change is to never return STATUS_TIMEOUT, and to instead return the result of NtYieldExecution() if zero timeout was passed, or STATUS_SUCCESS otherwise. An overview of the correct values for each combination, copied from the test commit: - Non-alertable, zero timeout: STATUS_SUCCESS or STATUS_NO_YIELD_PERFORMED - Non-alertable, non-zero timeout: STATUS_SUCCESS - Alertable, zero timeout: STATUS_SUCCESS, STATUS_NO_YIELD_PERFORMED, or STATUS_USER_APC - Alertable, non-zero timeout: … [View More]

4 6

[PATCH v8 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution.
by William Horvath (＠whrvth) 27 Jan '25

27 Jan '25

The key change is to never return STATUS_TIMEOUT, and to instead return the result of NtYieldExecution() if zero timeout was passed, or STATUS_SUCCESS otherwise. An overview of the correct values for each combination, copied from the test commit: - Non-alertable, zero timeout: STATUS_SUCCESS or STATUS_NO_YIELD_PERFORMED - Non-alertable, non-zero timeout: STATUS_SUCCESS - Alertable, zero timeout: STATUS_SUCCESS, STATUS_NO_YIELD_PERFORMED, or STATUS_USER_APC - Alertable, non-zero timeout: … [View More]

4 7

[PATCH v3 0/2] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Stéphane Bacri (＠fr33z00) 27 Jan '25

27 Jan '25

This MR intends to add the complex numbers related functions: * cimag * _FCbuild * crealf * cimagf These functions are defined in dlls/msvcr120/math.c and mapped in dlls/msvcr120/msvcr120.spec and dlls/ucrbase/ucrbase.spec. The related tests were added in dlls/mscr120/tests/msvcr120.c and result were checked. -- v3: fixed msvcr120_app spec https://gitlab.winehq.org/wine/wine/-/merge_requests/7109

3 3

[PATCH v2 0/2] MR7196: msvcp140: Fix field order in _Mtx_t.
by Daniel Lehman (＠dlehman25) 27 Jan '25

27 Jan '25

recent vs2022 upgrade bypasses _Mtx_init* calls -- v2: msvcp140: Fix field order in _Mtx_t. msvcp140/tests: Add more tests for _Mtx_t. https://gitlab.winehq.org/wine/wine/-/merge_requests/7196

4 4

[PATCH 0/3] MR7204: Fix running arm+arm64 in old wow64 mode
by Martin Storsjö (＠mstorsjo) 27 Jan '25

27 Jan '25

This allows using one single wineprefix, one wineserver and one single wine executable for running both arm and arm64 executables. This setup actually has worked earlier; Ubuntu 22.04 packages Wine 6.0, where the wine32 + wine64 packages together end up working this way. However, since Wine 6.0, a couple of refactorings has broken this setup along the way; reinstate this way of working. The new wow64 mode probably won't work on arm, as it's not easily possible to switch between 32 and 64 bit … [View More]

2 3

[PATCH v5 0/7] MR7193: crypt32: A refcount fix and cert enumeraton improvement.
by Paul Gofman (＠gofman) 27 Jan '25

27 Jan '25

-- v5: crypt32: Don't assert in Context_Release() on invalid refcount. crypt32/tests: Add a test for deleting and adding certs during enumeration. crypt32: Only remove cert from mem store list when deleting it. https://gitlab.winehq.org/wine/wine/-/merge_requests/7193

4 9

[PATCH 0/4] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) 27 Jan '25

27 Jan '25

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

3 5

[PATCH 0/1] MR7202: shlwapi: Use wide character string literals.
by Alex Henrie (＠alexhenrie) 27 Jan '25

27 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7202

2 1

[PATCH 0/14] MR7194: Use fixed length to print possibly unterminated buffers. (ASan)
by Bernhard Übelacker (＠bernhardu) 26 Jan '25

26 Jan '25

Recently I am experimenting with an ASan instrumented Wine build (Details [here](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2024-12-29/RE…), which was showing some issues when running the confirmance tests. One issue seems to be `ok` statements, which if I understand it right, do evaluate the condition inside the `winetest_ok` function. Unfortunately at that time e.g. `debugstr_w(buf)` as parameters to the `ok` statement got already executed. This leads in some places to … [View More]overrunning these buffers, especially those which initialize the whole buffer with e.g. `memset(dst, 0xcc, ...`. This patches replace e.g. `debugstr_w(buf)` by their length limiting variant `debugstr_wn(buf, ARRAY_SIZE(buf))`. Following is the example output of the `win32u:win32u` test: ``` wine dlls/win32u/tests/i386-windows/win32u_test.exe win32u ================================================================= ==2640==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x005cf650 at pc 0x0042d112 bp 0x005cdf34 sp 0x005cdf30 READ of size 2 at 0x005cf650 thread T0 #0 0x0042d111 in wine_dbgstr_wn .../wine/include/wine/debug.h:263:30 #1 0x0040394a in debugstr_w .../wine/include/wine/debug.h:522:65 #2 0x0040394a in test_class .../wine/dlls/win32u/tests/win32u.c:269:41 #3 0x0040394a in func_win32u .../wine/dlls/win32u/tests/win32u.c:2548:5 #4 0x00436849 in run_test .../wine/include/wine/test.h:765:5 #5 0x00436260 in main .../wine/include/wine/test.h #6 0x00437f0b in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #7 0x7877ea3f in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b80ea3f) #8 0x788fce82 in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc0ce82) #9 0x789304b4 in call_thread_func .../wine/dlls/ntdll\signal_i386.c:524:9 Address 0x005cf650 is located in stack of thread T0 at offset 5296 in frame #0 0x0040100f in func_win32u .../wine/dlls/win32u/tests/win32u.c:2518 This frame has 37 object(s): [16, 100) 'source_name.i' (line 1291) [144, 184) 'cls.i675' (line 2031) [224, 264) 'cls.i638' (line 1349) [304, 564) 'path.i' (line 1350) [640, 656) 'pi.i' (line 1351) [672, 740) 'startup.i' (line 1352) [784, 812) 'msg.i639' (line 1353) [848, 876) 'msg.i615' (line 1271) [912, 940) 'msg.i' (line 1220) [976, 1024) 'item.i' (line 1143) [1056, 2080) 'buf.i537' (line 1088) [2208, 2216) 'callback_params.i' (line 1024) [2240, 2252) 'smp.i' (line 1028) [2272, 2312) 'cls.i440' (line 1029) [2352, 2872) 'module.i' (line 891) [3008, 3528) 'res_buf.i' (line 891) [3664, 3672) 'module_str.i' (line 892) [3696, 3704) 'res_str.i' (line 892) [3728, 4752) 'bmp_bits.i' (line 893) [4880, 4884) 'width.i' (line 894) [4896, 4900) 'height.i' (line 894) [4912, 4916) 'rate.i' (line 895) [4928, 4932) 'steps.i' (line 895) [4944, 4964) 'info.i348' (line 898) [5008, 5012) 'ret_size.i' (line 752) [5024, 5056) 'buf.i234' (line 415) [5088, 5100) 'himc.i' (line 415) [5120, 5124) 'size.i' (line 417) [5136, 5144) 'name.i' (line 180) [5168, 5296) 'buf.i173' (line 181) <== Memory access at offset 5296 overflows this variable [5328, 5368) 'cls.i' (line 182) [5408, 5412) 'count.i' (line 123) [5424, 6264) 'info.i' (line 71) [6400, 6436) 'mdi.i' (line 1389) [6480, 6680) 'bufW.i' (line 1390) [6752, 6852) 'buf.i' (line 1391) [6896, 6900) 'argv' (line 2519) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/include/wine/debug.h:263:30 in wine_dbgstr_wn Shadow bytes around the buggy address: 0x005cf380: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x005cf400: f8 f8 f8 f8 f8 f8 f2 f2 f2 f2 f2 f2 f2 f2 f2 f2 0x005cf480: f2 f2 f2 f2 f2 f2 f8 f2 f8 f2 f8 f2 f8 f2 f8 f8 0x005cf500: f8 f2 f2 f2 f2 f2 f8 f2 f8 f8 f8 f8 f2 f2 f2 f2 0x005cf580: f8 f8 f2 f2 f8 f2 00 f2 f2 f2 00 00 00 00 00 00 =>0x005cf600: 00 00 00 00 00 00 00 00 00 00[f2]f2 f2 f2 00 00 0x005cf680: 00 00 00 f2 f2 f2 f2 f2 f8 f2 f8 f8 f8 f8 f8 f8 0x005cf700: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x005cf780: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x005cf800: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x005cf880: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==2640==ABORTING ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7194 [View Less]

6 24

[PATCH 0/1] MR7201: kernel32/tests: Match the value in the debug message the test condition.
by Bernhard Übelacker (＠bernhardu) 26 Jan '25

26 Jan '25

Recently I am experimenting with an ASan instrumented Wine build (Details [here](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2024-12-29/RE…), which was showing some issues when running the confirmance tests. ASan got triggered on this `lstrlenW( dst )` because it seems the NormalizeString function does not add a termination if the length of the source string does not include the terminating character. Because the `ok` statements condition contains `lstrlenW( ptest->expected[i] )… [View More]` I assume that value is also expected to get printed if the test would fail. ``` ASAN_OPTIONS="allocator_may_return_null=1:halt_on_error=0" wine dlls/kernel32/tests/x86_64-windows/kernel32_test.exe locale ================================================================= ==640==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1dd420 at pc 0x000140117178 bp 0x7ffffe1dd0d0 sp 0x7ffffe1dd118 READ of size 2 at 0x7ffffe1dd420 thread T0 0800:fixme:file:server_get_file_info Unsupported info class e #0 0x000140117177 in lstrlenW .../wine/include/winbase.h:2921:12 #1 0x00014010d76e in test_NormalizeString .../wine/dlls/kernel32/tests/locale.c:7401:54 #2 0x0001400f0e4c in func_locale .../wine/dlls/kernel32/tests/locale.c:8725:3 #3 0x0001401e6c5e in run_test .../wine/include/wine/test.h:765:5 #4 0x0001401e67a1 in main .../wine/include/wine/test.h:884:12 #5 0x0001401e8113 in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #6 0x6fffffc455ee in BaseThreadInitThunk .../wine/dlls/kernel32/thread.c:61:24 #7 0x6fffffdcaaea in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004aaea) Address 0x7ffffe1dd420 is located in stack of thread T0 at offset 544 in frame #0 0x00014010d13f in test_NormalizeString .../wine/dlls/kernel32/tests/locale.c:7212 This frame has 8 object(s): [32, 544) 'dst' (line 7358) <== Memory access at offset 544 overflows this variable [608, 609) 'ret' (line 7359) [624, 628) 'dstlen' (line 7361) [640, 1664) 'buffer' (line 7620) [1792, 1798) 'str745' (line 7621) [1824, 1888) 'srcW' (line 7621) [1920, 1984) 'dstW' (line 7621) [2016, 2272) 'resW' (line 7621) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/include/winbase.h:2921:12 in lstrlenW Shadow bytes around the buggy address: 0x7ffffe1dd180: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1dd200: f1 f1 f1 f1 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1dd280: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1dd300: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1dd380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 =>0x7ffffe1dd400: 00 00 00 00[f2]f2 f2 f2 f2 f2 f2 f2 01 f2 04 f2 0x7ffffe1dd480: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x7ffffe1dd500: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x7ffffe1dd580: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x7ffffe1dd600: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x7ffffe1dd680: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==640==ABORTING ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7201 [View Less]

2 1

[PATCH v3 0/2] MR7161: dinput: Clamp FFB effect report value to the field range.
by Oleg Makarenko (＠JacKeTUs) 26 Jan '25

26 Jan '25

If application sends out-of-range values for FFB effects, they become -1, which is undesireable, when -1 is in the physical range of the field and being sent to the device. This patch fixes it, clamping values to the field range. Clamping was earlier implemented [here](https://gitlab.winehq.org/wine/wine/-/blob/wine-6.19/dlls/dinput/effe… in 6.19. Windows does this clamping silently, and doesn't fail `SetParameters` call when values is out of range. Affected application is Assetto Corsa EVO, … [View More]

3 3

Re: [PATCH v4 0/2] MR7161: dinput: Clamp FFB effect report value to the field range.
by Oleg Makarenko (＠JacKeTUs) 26 Jan '25

26 Jan '25

Added Constant Force tests, with out-of-bounds Magnitude levels. Also updated Condition Effect tests, now includes Saturation field being out-of-bounds. Tests are passing on Windows. That required modifying test HID descriptor, to include new effect type (Constant) and usage (Magnitude). Now we have an option to not clamp specific fields, specifically - Saturation ones. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7161#note_92866

1 0

[PATCH 0/1] MR7199: tapi32: Use wide character string literals.
by Alex Henrie (＠alexhenrie) 26 Jan '25

26 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7199

3 2

2025

2024

2023

2022