- wine-gitlab - winehq.org

[PATCH 0/1] MR6872: threadpoolwinrt: Associate work items with the appropriate TP_CALLBACK_ENVIRON.
by Vibhav Pant (＠vibhavp) 21 Nov '24

21 Nov '24

Otherwise, all work items queued via `RunAsync` run on the global thread pool, not utilizing the thread pool initialized in `pool_init_once`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6872

4 3

[PATCH v2 0/1] MR6735: msxml3: Undo removal of xmlThrDefTreeIndentString
by Fabian Maurer (＠DarkShadow44) 21 Nov '24

21 Nov '24

Fixes regression by 9d34c44d8464722c333fdde5313b341504d3ea44. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57325 Not sure why this was removed, but it breaks the office installer. If this is not the right course of action, please tell me and I'll try to find a different solution. -- v2: msxml3: Undo removal of xmlThrDefTreeIndentString https://gitlab.winehq.org/wine/wine/-/merge_requests/6735

4 4

[PATCH 0/2] MR6876: d2d1/tests: Add some tests for WIC target formats.
by Nikolay Sivov (＠nsivov) 21 Nov '24

21 Nov '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6876

4 5

[PATCH 0/2] MR6875: mshtml: Set the name of the non-function constructors to the same as the object.
by Gabriel Ivăncescu (＠insn) 21 Nov '24

21 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6875

2 2

[PATCH v3 0/8] MR6874: windows.devices.enumeration: Add a basic implementation for DeviceInformationStatics::FindAllAsync().
by Vibhav Pant (＠vibhavp) 21 Nov '24

21 Nov '24

The basic `FindAllAsync()` method returns a collection of `DeviceInformation` objects representing all device interfaces on the system. This MR adds a basic implementation of this method, and the associated `IDeviceInformation` and `DeviceInformationCollection` objects it returns. For `IDeviceInformation`, this MR only implements the `Id()` method, which returns the symbolic link for the registered interface. -- v3: windows.devices.enumeration: Implement IIterable<IDeviceInformation *> for DeviceInformationCollection. windows.devices.enumeration: Implement IndexOf() and GetMany() for DeviceInformationCollection. windows.devices.enumeration: Create IDeviceInformation objects from all present device interfaces. windows.devices.enumeration: Add a stubbed IDeviceInformation implementation for device interfaces. windows.devices.enumeration: Add a stubbed implementation for FindAllAsync() and DeviceInformationCollection. windows.devices.enumeration/tests: Add conformance tests for IIterable and IIterator interfaces in DeviceInformationCollection. windows.devices.enumeration/tests: Add conformance tests for GetMany() and IndexOf() methods in DeviceInformationCollection. https://gitlab.winehq.org/wine/wine/-/merge_requests/6874

3 9

[PATCH 0/8] MR6874: windows.devices.enumeration: Add a basic implementation for DeviceInformationStatics::FindAllAsync().
by Vibhav Pant (＠vibhavp) 21 Nov '24

21 Nov '24

The basic `FindAllAsync()` method returns a collection of `DeviceInformation` objects representing all device interfaces on the system. This MR adds a basic implementation of this method, and the associated `IDeviceInformation` and `DeviceInformationCollection` objects it returns. For `IDeviceInformation`, this MR only implements the `Id()` method, which returns the symbolic link for the registered interface. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6874

3 9

[PATCH 0/1] MR6873: dsound: Fix SetNotificationPositions at end of nonlooping buffer
by Alfred Agrell (＠Alcaro) 21 Nov '24

21 Nov '24

https://store.steampowered.com/app/345610/The_Fruit_of_Grisaia/ likes to call IDirectSoundNotify::SetNotificationPositions with position two bytes before the end of the buffer, then play it nonlooping. If Wine doesn't feel like delivering these notifications, the Quit Game button on the title screen screws up. The game also likes to lock up during scene transitions in Wine/Proton, which I strongly suspect (but haven't confirmed) has the same root cause. (I haven't found a reliable repro for the lockups.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6873

3 2

[PATCH v7 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 21 Nov '24

21 Nov '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options -- v7: timeout: add minimal test suite https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

3 3

[PATCH v6 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 21 Nov '24

21 Nov '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options -- v6: timeout: add minimal test suite https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

3 3

[PATCH v6 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Elias Norberg (＠elias) 21 Nov '24

21 Nov '24

Add support for generating SHA-256 hashes via CryptCATAdminCalcHashFromFileHandle2, which in turn requires CryptCATAdminAcquireContext2 in order to be able to specify the hashing algorithm. -- v6: wintrust/tests: Add CryptCATAdminCalcHashFromFileHandle2() tests wintrust: Implement CryptCATAdminCalcHashFromFileHandle2() wintrust/tests: Add CryptCATAdminAcquireContext2() tests wintrust: Implement CryptCATAdminAcquireContext2() https://gitlab.winehq.org/wine/wine/-/merge_requests/6835

4 7

[PATCH 0/1] MR6871: winevulkan: Update to VK spec version 1.3.302.
by Georg Lehmann (＠DadSchoorse) 21 Nov '24

21 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6871

3 2

[PATCH v5 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 21 Nov '24

21 Nov '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options -- v5: timeout: add minimal test suite timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

3 3

[PATCH v2 0/6] MR6846: Draft: winex11: Misc tweaks to the emulated display mode support.
by Rémi Bernon (＠rbernon) 21 Nov '24

21 Nov '24

This fixes window size being broken when dragged over multiple monitors with different scales and adds support for padded fullscreen windows when physical display mode aspect ratio doesn't match the emulated one. -- v2: winex11: Update the Win32 window state outside of event handlers. user32/tests: Workaround a FVWM maximized window state bug. winex11: Delay window config request when restoring from fullscreen/maximized. winex11: Avoid sending WM_WINDOWPOSCHANGING when applying window manager config. winex11: Generate GravityNotify events instead of ConfigureNotify. winex11: Introduce a new get_window_state_updates helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/6846

2 7

[PATCH v4 0/1] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 21 Nov '24

21 Nov '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options -- v4: timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

4 7

[PATCH v5 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Elias Norberg (＠elias) 21 Nov '24

21 Nov '24

Add support for generating SHA-256 hashes via CryptCATAdminCalcHashFromFileHandle2, which in turn requires CryptCATAdminAcquireContext2 in order to be able to specify the hashing algorithm. -- v5: wintrust/tests: Add CryptCATAdminCalcHashFromFileHandle2() tests wintrust: Implement CryptCATAdminCalcHashFromFileHandle2() wintrust/tests: Add CryptCATAdminAcquireContext2() tests wintrust: Implement CryptCATAdminAcquireContext2() https://gitlab.winehq.org/wine/wine/-/merge_requests/6835

4 6

[PATCH v2 0/1] MR6523: wtsapi32: Handle WTSSessionInfo class in WTSQuerySessionInformationW().
by Pétur Runólfsson (＠petur) 21 Nov '24

21 Nov '24

-- v2: wtsapi32: Handle WTSSessionInfo class in WTSQuerySessionInformationW(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6523

3 4

[PATCH 0/1] MR6870: threadpoolwinrt: Fix potential NULL dereference in QueryInterface for IAsyncAction.
by Vibhav Pant (＠vibhavp) 21 Nov '24

21 Nov '24

Fix a potential NULL dereference if `QueryInterface` gets called with an unsupported IID. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6870

4 3

[PATCH v3 0/1] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 21 Nov '24

21 Nov '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options -- v3: timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

3 2

[PATCH v9 0/2] MR6059: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned.
by Brendan McGrath (＠redmcg) 21 Nov '24

21 Nov '24

Send INVALIDATEMEDIATYPE to allow the transform type to be set before retrying PROCESSINPUTNOTIFY. -- v9: mf: Send MEError when IMFStreamSink_ProcessSample fails. https://gitlab.winehq.org/wine/wine/-/merge_requests/6059

4 5

[PATCH 0/1] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 21 Nov '24

21 Nov '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

4 3

Re: [PATCH v2 0/1] MR6869: timeout: Windows 10 introduce the timeout command
by Hans Leidekker (＠hans) 21 Nov '24

21 Nov '24

Hans Leidekker (@hans) commented about configure.ac: > WINE_CONFIG_MAKEFILE(programs/wusa) > WINE_CONFIG_MAKEFILE(programs/xcopy) > WINE_CONFIG_MAKEFILE(programs/xcopy/tests) > +WINE_CONFIG_MAKEFILE(programs/timeout) Please keep these sorted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6869#note_88274

1 0

Re: [PATCH v2 0/1] MR6869: timeout: Windows 10 introduce the timeout command
by Zhiyi Zhang (＠zhiyi) 21 Nov '24

21 Nov '24

Could you tell us what application needs this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6869#note_88273

1 0

[PATCH v2 0/3] MR6830: icmui: Add SetupColorMatchingW() stub.
by Mohamad Al-Jaf (＠maljaf) 21 Nov '24

21 Nov '24

Needed by ProSelect. -- v2: icmui/tests: Add some SetupColorMatchingW() tests. icmui: Add SetupColorMatchingW() stub. icmui: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/6830

4 7

[PATCH 0/2] MR6868: win32u: Fix a couple of raw monitor DPI issues.
by Rémi Bernon (＠rbernon) 21 Nov '24

21 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6868

2 2

[PATCH v9 0/6] MR6640: propsys: Support converting to BSTR for PropVariantToVariant.
by Ziqing Hui (＠zhui) 21 Nov '24

21 Nov '24

This is based on top of !6526, will mark ready after !6526 is merged. -- v9: propsys: Support converting to BSTR for PropVariantToVariant. propsys: Use debugstr_variant for the trace in VariantToPropVariant. propsys: Implement PropVariantToBSTR. propsys/tests: Test truncating for PropVariantToString. propsys/tests: Test PropVariantToBSTR. propsys: Add PropVariantToBSTR stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/6640

4 11

[PATCH v4 0/2] MR6787: wineps.drv: Use locale aware variants _sprintf_l and _sscanf_l. (ASan)
by Bernhard Übelacker (＠bernhardu) 21 Nov '24

21 Nov '24

The pointer in tmplocale gets freed in the second setlocale call. Therefore ASan triggers when trying to restore the locale the the already freed pointer in tmplocale in the third call to setlocale. This appeared with a notepad.exe built with (a yet patched) llvm-mingw with ASan enabled, when opening the Printer Setup dialog. The stack traces seem to have utilized an in the wineprefix installed LLVM/llvm-symbolizer.exe. ``` wine64 notepad_asan.exe ================================================================= ==300==ERROR: AddressSanitizer: heap-use-after-free on address 0x7eeab5c60290 at pc 0x6ffffa80279f bp 0x7ffffe1fb570 sp 0x7ffffe1fb5b0 READ of size 2 at 0x7eeab5c60290 thread T0 0130:fixme:dbghelp:elf_search_auxv can't find symbol in module #0 0x6ffffa80279e in strchr+0x28e (C:\x86_64\libclang_rt.asan_dynamic-x86_64.dll+0x18004279e) #1 0x6ffffeb1666c in locale_to_sname Z:\home\bernhard\wine\dlls\msvcrt\locale.c:351 #2 0x6ffffeb16ce5 in create_locinfo Z:\home\bernhard\wine\dlls\msvcrt\locale.c:1357 #3 0x6ffffeb1a170 in setlocale Z:\home\bernhard\wine\dlls\msvcrt\locale.c:2054 #4 0x6ffffa1bf8c9 in PSDRV_ParsePPD Z:\home\bernhard\wine\dlls\wineps.drv\ppd.c:890 #5 0x6ffffa1bc0b7 in PSDRV_FindPrinterInfo Z:\home\bernhard\wine\dlls\wineps.drv\init.c:575 #6 0x6ffffa1b66b1 in DrvDocumentPropertySheets Z:\home\bernhard\wine\dlls\wineps.drv\driver.c:491 #7 0x6ffffc60b314 in DocumentPropertiesW Z:\home\bernhard\wine\dlls\winspool.drv\info.c:1854 #8 0x6ffffc611f97 in OpenPrinter2W Z:\home\bernhard\wine\dlls\winspool.drv\info.c:2057 #9 0x6ffffd666153 in PRINTDLG_ChangePrinterW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:1298 #10 0x6ffffd66786d in PRINTDLG_WMInitDialogW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:1660 #11 0x6ffffd667987 in PrintDlgProcW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:2126 #12 0x6ffffdc08d48 in call_dialog_proc Z:\home\bernhard\wine\dlls\user32\winproc.c:129 #13 0x6ffffdc0b13b in WINPROC_CallDlgProcW Z:\home\bernhard\wine\dlls\user32\winproc.c:948 #14 0x6ffffdbcf528 in USER_DefDlgProc Z:\home\bernhard\wine\dlls\user32\defdlg.c:372 #15 0x6ffffdbcf7b4 in DefDlgProcW Z:\home\bernhard\wine\dlls\user32\defdlg.c:438 #16 0x6ffffdc08c2a in call_window_proc Z:\home\bernhard\wine\dlls\user32\winproc.c:108 #17 0x6ffffdc0ac43 in dispatch_win_proc_params Z:\home\bernhard\wine\dlls\user32\winproc.c:725 #18 0x6ffffdbf179c in dispatch_send_message Z:\home\bernhard\wine\dlls\user32\message.c:580 #19 0x6ffffdbf32ee in SendMessageW Z:\home\bernhard\wine\dlls\user32\message.c:599 #20 0x6ffffdbd2d1a in DIALOG_CreateIndirect Z:\home\bernhard\wine\dlls\user32\dialog.c:676 #21 0x6ffffdbd4d1c in DialogBoxIndirectParamW Z:\home\bernhard\wine\dlls\user32\dialog.c:899 #22 0x6ffffd6692a7 in PrintDlgW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:2546 #23 0x000140007f9b in DIALOG_FilePrinterSetup Z:\home\bernhard\wine\programs\notepad\dialog.c:1019 #24 0x00014000e118 in NOTEPAD_WndProc Z:\home\bernhard\wine\programs\notepad\main.c:640 #25 0x6ffffdc08c2a in call_window_proc Z:\home\bernhard\wine\dlls\user32\winproc.c:108 #26 0x6ffffdc0ac43 in dispatch_win_proc_params Z:\home\bernhard\wine\dlls\user32\winproc.c:725 #27 0x6ffffdbf1850 in dispatch_message Z:\home\bernhard\wine\dlls\user32\message.c:854 #28 0x6ffffdbf3afc in DispatchMessageW Z:\home\bernhard\wine\dlls\user32\message.c:940 #29 0x00014000c4ef in WinMain Z:\home\bernhard\wine\programs\notepad\main.c:888 #30 0x00014000ea3e in main+0x20e (C:\x86_64\notepad.exe_asan.exe+0x14000ea3e) #31 0x00014000e75a in mainCRTStartup Z:\home\bernhard\wine\dlls\msvcrt\crt_main.c:58 #32 0x6fffffa98d58 in BaseThreadInitThunk Z:\home\bernhard\wine\dlls\kernel32\thread.c:61 #33 0x6fffffc95afa (C:\windows\system32\ntdll.dll+0x170055afa) 0x7eeab5c60290 is located 0 bytes inside of 2-byte region [0x7eeab5c60290,0x7eeab5c60292) freed by thread T0 here: #0 0x6ffffa809ff1 in free+0x81 (C:\x86_64\libclang_rt.asan_dynamic-x86_64.dll+0x180049ff1) #1 0x6ffffeb1563c in free_locinfo Z:\home\bernhard\wine\dlls\msvcrt\locale.c:1071 #2 0x6ffffeb1591a in update_thread_locale Z:\home\bernhard\wine\dlls\msvcrt\locale.c:611 #3 0x6ffffeb1a301 in setlocale Z:\home\bernhard\wine\dlls\msvcrt\locale.c:2085 #4 0x6ffffa1bf890 in PSDRV_ParsePPD Z:\home\bernhard\wine\dlls\wineps.drv\ppd.c:887 #5 0x6ffffa1bc0b7 in PSDRV_FindPrinterInfo Z:\home\bernhard\wine\dlls\wineps.drv\init.c:575 #6 0x6ffffa1b66b1 in DrvDocumentPropertySheets Z:\home\bernhard\wine\dlls\wineps.drv\driver.c:491 #7 0x6ffffc60b314 in DocumentPropertiesW Z:\home\bernhard\wine\dlls\winspool.drv\info.c:1854 #8 0x6ffffc611f97 in OpenPrinter2W Z:\home\bernhard\wine\dlls\winspool.drv\info.c:2057 #9 0x6ffffd666153 in PRINTDLG_ChangePrinterW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:1298 #10 0x6ffffd66786d in PRINTDLG_WMInitDialogW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:1660 #11 0x6ffffd667987 in PrintDlgProcW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:2126 #12 0x6ffffdc08d48 in call_dialog_proc Z:\home\bernhard\wine\dlls\user32\winproc.c:129 #13 0x6ffffdc0b13b in WINPROC_CallDlgProcW Z:\home\bernhard\wine\dlls\user32\winproc.c:948 #14 0x6ffffdbcf528 in USER_DefDlgProc Z:\home\bernhard\wine\dlls\user32\defdlg.c:372 #15 0x6ffffdbcf7b4 in DefDlgProcW Z:\home\bernhard\wine\dlls\user32\defdlg.c:438 #16 0x6ffffdc08c2a in call_window_proc Z:\home\bernhard\wine\dlls\user32\winproc.c:108 #17 0x6ffffdc0ac43 in dispatch_win_proc_params Z:\home\bernhard\wine\dlls\user32\winproc.c:725 #18 0x6ffffdbf179c in dispatch_send_message Z:\home\bernhard\wine\dlls\user32\message.c:580 #19 0x6ffffdbf32ee in SendMessageW Z:\home\bernhard\wine\dlls\user32\message.c:599 #20 0x6ffffdbd2d1a in DIALOG_CreateIndirect Z:\home\bernhard\wine\dlls\user32\dialog.c:676 #21 0x6ffffdbd4d1c in DialogBoxIndirectParamW Z:\home\bernhard\wine\dlls\user32\dialog.c:899 #22 0x6ffffd6692a7 in PrintDlgW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:2546 #23 0x000140007f9b in DIALOG_FilePrinterSetup Z:\home\bernhard\wine\programs\notepad\dialog.c:1019 #24 0x00014000e118 in NOTEPAD_WndProc Z:\home\bernhard\wine\programs\notepad\main.c:640 #25 0x6ffffdc08c2a in call_window_proc Z:\home\bernhard\wine\dlls\user32\winproc.c:108 #26 0x6ffffdc0ac43 in dispatch_win_proc_params Z:\home\bernhard\wine\dlls\user32\winproc.c:725 #27 0x6ffffdbf1850 in dispatch_message Z:\home\bernhard\wine\dlls\user32\message.c:854 previously allocated by thread T0 here: #0 0x6ffffa80a111 in malloc+0x81 (C:\x86_64\libclang_rt.asan_dynamic-x86_64.dll+0x18004a111) #1 0x6ffffeb154f9 in init_category_name Z:\home\bernhard\wine\dlls\msvcrt\locale.c:474 #2 0x6ffffeb18ad9 in create_locinfo Z:\home\bernhard\wine\dlls\msvcrt\locale.c:1930 #3 0x6ffffeb1a170 in setlocale Z:\home\bernhard\wine\dlls\msvcrt\locale.c:2054 #4 0x6ffffa1bf8c9 in PSDRV_ParsePPD Z:\home\bernhard\wine\dlls\wineps.drv\ppd.c:890 #5 0x6ffffa1bc0b7 in PSDRV_FindPrinterInfo Z:\home\bernhard\wine\dlls\wineps.drv\init.c:575 #6 0x6ffffa1b66b1 in DrvDocumentPropertySheets Z:\home\bernhard\wine\dlls\wineps.drv\driver.c:491 #7 0x6ffffc60b314 in DocumentPropertiesW Z:\home\bernhard\wine\dlls\winspool.drv\info.c:1854 #8 0x6ffffc611f97 in OpenPrinter2W Z:\home\bernhard\wine\dlls\winspool.drv\info.c:2057 #9 0x6ffffd666153 in PRINTDLG_ChangePrinterW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:1298 #10 0x6ffffd66786d in PRINTDLG_WMInitDialogW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:1660 #11 0x6ffffd667987 in PrintDlgProcW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:2126 #12 0x6ffffdc08d48 in call_dialog_proc Z:\home\bernhard\wine\dlls\user32\winproc.c:129 #13 0x6ffffdc0b13b in WINPROC_CallDlgProcW Z:\home\bernhard\wine\dlls\user32\winproc.c:948 #14 0x6ffffdbcf528 in USER_DefDlgProc Z:\home\bernhard\wine\dlls\user32\defdlg.c:372 #15 0x6ffffdbcf7b4 in DefDlgProcW Z:\home\bernhard\wine\dlls\user32\defdlg.c:438 #16 0x6ffffdc08c2a in call_window_proc Z:\home\bernhard\wine\dlls\user32\winproc.c:108 #17 0x6ffffdc0ac43 in dispatch_win_proc_params Z:\home\bernhard\wine\dlls\user32\winproc.c:725 #18 0x6ffffdbf179c in dispatch_send_message Z:\home\bernhard\wine\dlls\user32\message.c:580 #19 0x6ffffdbf32ee in SendMessageW Z:\home\bernhard\wine\dlls\user32\message.c:599 #20 0x6ffffdbd2d1a in DIALOG_CreateIndirect Z:\home\bernhard\wine\dlls\user32\dialog.c:676 #21 0x6ffffdbd4d1c in DialogBoxIndirectParamW Z:\home\bernhard\wine\dlls\user32\dialog.c:899 #22 0x6ffffd6692a7 in PrintDlgW Z:\home\bernhard\wine\dlls\comdlg32\printdlg.c:2546 #23 0x000140007f9b in DIALOG_FilePrinterSetup Z:\home\bernhard\wine\programs\notepad\dialog.c:1019 #24 0x00014000e118 in NOTEPAD_WndProc Z:\home\bernhard\wine\programs\notepad\main.c:640 #25 0x6ffffdc08c2a in call_window_proc Z:\home\bernhard\wine\dlls\user32\winproc.c:108 #26 0x6ffffdc0ac43 in dispatch_win_proc_params Z:\home\bernhard\wine\dlls\user32\winproc.c:725 #27 0x6ffffdbf1850 in dispatch_message Z:\home\bernhard\wine\dlls\user32\message.c:854 SUMMARY: AddressSanitizer: heap-use-after-free Z:\home\bernhard\wine\dlls\msvcrt\locale.c:351 in locale_to_sname Shadow bytes around the buggy address: 0x7eeab5c60000: fa fa 00 00 fa fa 00 06 fa fa 00 fa fa fa 00 00 0x7eeab5c60080: fa fa fd fa fa fa fd fa fa fa fd fa fa fa fd fa 0x7eeab5c60100: fa fa fd fa fa fa fd fa fa fa fd fa fa fa fd fa 0x7eeab5c60180: fa fa fd fa fa fa fd fa fa fa fd fa fa fa fd fa 0x7eeab5c60200: fa fa fd fa fa fa fd fa fa fa fd fa fa fa fd fa =>0x7eeab5c60280: fa fa[fd]fa fa fa fd fa fa fa fd fa fa fa fd fa 0x7eeab5c60300: fa fa 02 fa fa fa 04 fa fa fa 02 fa fa fa 04 fa 0x7eeab5c60380: fa fa 02 fa fa fa 04 fa fa fa 02 fa fa fa 04 fa 0x7eeab5c60400: fa fa 02 fa fa fa 04 fa fa fa 00 fa fa fa fd fd 0x7eeab5c60480: fa fa fd fd fa fa fd fd fa fa fd fd fa fa fd fd 0x7eeab5c60500: fa fa fd fd fa fa fd fd fa fa fd fd fa fa fd fd Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==300==ABORTING ``` -- v4: wineps.drv: Use locale aware variants _sprintf_l and _sscanf_l. (ASan) stdio.h: Add ucrt _sprintf_l declaration. https://gitlab.winehq.org/wine/wine/-/merge_requests/6787

3 3

[PATCH 0/1] MR6867: kernel32: Add GetCurrentPackageInfo() stub.
by Zhiyi Zhang (＠zhiyi) 21 Nov '24

21 Nov '24

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6867

3 2

[PATCH 0/1] MR6735: msxml3: Undo removal of xmlThrDefTreeIndentString
by Fabian Maurer (＠DarkShadow44) 21 Nov '24

21 Nov '24

Fixes regression by 9d34c44d8464722c333fdde5313b341504d3ea44. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57325 Not sure why this was removed, but it breaks the office installer. If this is not the right course of action, please tell me and I'll try to find a different solution. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6735

7 21

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) 21 Nov '24

21 Nov '24

Thanks, looks good overall. Could you address the minor issues I pointed out? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88258

1 0

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) 21 Nov '24

21 Nov '24

Hans Leidekker (@hans) commented about dlls/wintrust/tests/crypt.c: > DeleteFileA(temp); > } > > +static void test_calchash2(void) > +{ Please merge added tests with test_calchash(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88257

1 0

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) 21 Nov '24

21 Nov '24

Hans Leidekker (@hans) commented about dlls/wintrust/crypt.c: > + ALG_ID alg; > + const WCHAR *providerName; > + DWORD providerType; > > - TRACE("%p %s %lx\n", catAdmin, debugstr_guid(sys), dwFlags); > + TRACE("%p %s %s %p %lx\n", catAdmin, debugstr_guid(sys), debugstr_w(algorithm), policy, dwFlags); > > if (!catAdmin || dwFlags) > { > SetLastError(ERROR_INVALID_PARAMETER); > return FALSE; > } > + > + if (policy != NULL) { > + FIXME("strong policy parameter is unimplemented\n"); > + } Please put opening braces on a new line like in the rest of the file. Here you can omit the braces. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88256

1 0

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) 21 Nov '24

21 Nov '24

Hans Leidekker (@hans) commented about dlls/wintrust/crypt.c: > -/*********************************************************************** > - * CryptCATAdminCalcHashFromFileHandle (WINTRUST.@) > - */ > -BOOL WINAPI CryptCATAdminCalcHashFromFileHandle(HANDLE hFile, DWORD *pcbHash, BYTE *pbHash, DWORD dwFlags) > +static BOOL catadmin_calc_hash_from_filehandle(HCATADMIN catAdmin, HANDLE hFile, DWORD *pcbHash, > + BYTE *pbHash, DWORD dwFlags) > { > BOOL ret = FALSE; > - > - TRACE("%p %p %p %lx\n", hFile, pcbHash, pbHash, dwFlags); > + struct catadmin *ca = catAdmin; > + ALG_ID alg = CALG_SHA1; > + const WCHAR *providerName = MS_DEF_PROV_W; > + DWORD providerType = PROV_RSA_FULL; > + DWORD hashLength = 20; > No need to initialize hashLength here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88255

1 0

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) 21 Nov '24

21 Nov '24

Hans Leidekker (@hans) commented about dlls/wintrust/crypt.c: > + ALG_ID alg = CALG_SHA1; > + const WCHAR *providerName = MS_DEF_PROV_W; > + DWORD providerType = PROV_RSA_FULL; > + DWORD hashLength = 20; > > if (!hFile || !pcbHash || dwFlags) > { > SetLastError(ERROR_INVALID_PARAMETER); > return FALSE; > } > - if (*pcbHash < 20) > - { > - *pcbHash = 20; > + > + if (ca && ca->magic == CATADMIN_MAGIC) { > + alg = ca->alg; Magic is already checked in CryptCATAdminCalcHashFromFileHandle2() so this check is redundant. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88254

1 0

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) 21 Nov '24

21 Nov '24

Hans Leidekker (@hans) commented about dlls/wintrust/tests/crypt.c: > } > } > > +static void test_context2(void) > +{ > + BOOL ret; There's no need to duplicate these tests since CryptCATAdminAcquireContext() is forwarded to CryptCATAdminAcquireContext2(). Please merge added test with test_context(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88253

1 0

Re: [PATCH v2 0/1] MR5792: server: Avoid calling set_event from within msg_queue_add_queue.
by Rémi Bernon (＠rbernon) 21 Nov '24

21 Nov '24

On Thu Nov 21 08:59:44 2024 +0000, Elizabeth Figura wrote: > What was the reason for this change? See https://gitlab.winehq.org/wine/wine/-/merge_requests/5789#note_72349 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5792#note_88247

1 0

[PATCH v9 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused
by Fabian Maurer (＠DarkShadow44) 21 Nov '24

21 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109 -- v9: user32: Send parent BN_CLICKED notification when a radio button get focused. user32/tests: Add tests for radio button WM_SETFOCUS. comctl32: Send parent BN_CLICKED notification when a radio button get focused. comctl32/tests: Add tests for radio button WM_SETFOCUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

4 8

[PATCH v8 0/2] MR6059: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned.
by Brendan McGrath (＠redmcg) 21 Nov '24

21 Nov '24

Send INVALIDATEMEDIATYPE to allow the transform type to be set before retrying PROCESSINPUTNOTIFY. -- v8: mf: Send MEError when IMFStreamSink_ProcessSample fails. mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned. https://gitlab.winehq.org/wine/wine/-/merge_requests/6059

3 3

Re: [PATCH v5 0/6] MR6850: mshtml: Expose the props properly for Node prototype chain. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6850

1 0

Re: [PATCH v2 0/3] MR6845: server: Set overlapped fd to signaled after setting completion information. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6845

1 0

Re: [PATCH v2 0/1] MR6862: win32u: Print the correct index when source_enum_display_settings() fails. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6862

1 0

Re: [PATCH v4 0/2] MR4392: server: Don't crash when opening null path with a console handle as RootDirectory. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4392

1 0

Re: [PATCH v3 0/1] MR6864: mshtml: Don't use cycle collection for nsChannel. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6864

1 0

Re: [PATCH v2 0/1] MR6865: jscript: Don't use bool as a variable name. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6865

1 0

Re: [PATCH v2 0/1] MR6856: msi: Don't use bool as a variable name. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6856

1 0

Re: [PATCH v2 0/1] MR6839: msi: Also set x64 properties for arm64 hosts. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6839

1 0

Re: [PATCH v2 0/1] MR6834: iphlpapi: Sort adapters by route metric in GetAdaptersAddresses(). - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6834

1 0

Re: [PATCH v2 0/2] MR6857: dxva2: Stub DXVAHD_CreateDevice(). - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6857

1 0

Re: [PATCH v2 0/2] MR6861: nls: Set alpha bit on some Thai and Mongolian codes. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6861

1 0

Re: [PATCH v2 0/8] MR6860: dplayx: GROUPDATACHANGED handling and UNICODE support in EnumConnections() and EnumSessions(). - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6860

1 0

Re: [PATCH v2 0/1] MR6853: windowscodecs/tests: Always use a format string in winetest_push_context calls. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6853

1 0

Re: [PATCH v2 0/1] MR5792: server: Avoid calling set_event from within msg_queue_add_queue.
by Elizabeth Figura (＠zfigura) 20 Nov '24

20 Nov '24

What was the reason for this change? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5792#note_88204

1 0

[PATCH v4 0/6] MR6850: mshtml: Expose the props properly for Node prototype chain.
by Gabriel Ivăncescu (＠insn) 20 Nov '24

20 Nov '24

This is just nodes for now. The tests in the last patch may seem a bit overkill now, but it will be used for all the other prototypes, so they'll only need extra entries in the array/table, making it way simpler and less redundant. -- v4: mshtml: Don't expose swapNode from NodePrototype. mshtml: Don't expose replaceNode from NodePrototype. mshtml: Don't expose removeNode from NodePrototype. mshtml: Expose ownerDocument from NodePrototype. mshtml/tests: Add initial tests for prototype chain props. mshtml: Enumerate all own builtin props from host object's NextProperty. https://gitlab.winehq.org/wine/wine/-/merge_requests/6850

3 7

[PATCH v3 0/6] MR6850: mshtml: Expose the props properly for Node prototype chain.
by Gabriel Ivăncescu (＠insn) 20 Nov '24

20 Nov '24

This is just nodes for now. The tests in the last patch may seem a bit overkill now, but it will be used for all the other prototypes, so they'll only need extra entries in the array/table, making it way simpler and less redundant. -- v3: mshtml: Don't expose swapNode from NodePrototype. mshtml: Don't expose replaceNode from NodePrototype. mshtml: Don't expose removeNode from NodePrototype. mshtml: Expose ownerDocument from NodePrototype. mshtml/tests: Add initial tests for prototype chain props. mshtml: Enumerate all own builtin props from host object's NextProperty. https://gitlab.winehq.org/wine/wine/-/merge_requests/6850

3 7

[PATCH 0/1] MR6865: jscript: Don't use bool as a variable name.
by Gerald Pfeifer (＠gerald) 20 Nov '24

20 Nov '24

This is a reserved identifier in C23 and would break with GCC 15 moving to -std=gnu23 (which is C23 plus extensions). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6865

4 3

[PATCH v3 0/2] MR4392: server: Don't crash when opening null path with a console handle as RootDirectory.
by Jinoh Kang (＠iamahuman) 20 Nov '24

20 Nov '24

Preparatory patch for revival of https://gitlab.winehq.org/wine/wine/-/merge_requests/498. -- v3: server: Don't crash when opening null path with a console server as RootDirectory. server: Don't crash when opening null path with a console handle as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/4392

3 3

[PATCH v2 0/1] MR6864: mshtml: Don't use cycle collection for nsChannel.
by Gabriel Ivăncescu (＠insn) 20 Nov '24

20 Nov '24

Tested and doesn't seem to be leaking anything extra. -- v2: mshtml: Don't use cycle collection for nsChannel. https://gitlab.winehq.org/wine/wine/-/merge_requests/6864

3 2

[PATCH 0/1] MR6864: mshtml: Don't use cycle collection for nsChannel.
by Gabriel Ivăncescu (＠insn) 20 Nov '24

20 Nov '24

Tested and doesn't seem to be leaking anything extra. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6864

2 1

Re: [PATCH v3 0/3] MR5970: win32u: Use the thread message queue shared memory in peek_message.
by sagi trashbin (＠trashbin) 20 Nov '24

20 Nov '24

Does the new throttling mechanism introduce input lag? Testing with a simple SDL2 app polling for events, input delay is 9.8ms averaged over 100 clicks, but native application build is only 1.05ms. I implemented the mechanism used before with 200 message count and the input lag is only 1.2ms, but I suppose in real game there would be a big CPU usage spike -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5970#note_88177

1 0

[PATCH 0/1] MR6859: mshtml: Copy POST data in BindStatusCallback_GetBindInfo().
by Paul Gofman (＠gofman) 20 Nov '24

20 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6859

5 12

Re: [PATCH v7 0/2] MR6059: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned.
by Nikolay Sivov (＠nsivov) 20 Nov '24

20 Nov '24

Nikolay Sivov (@nsivov) commented about dlls/mf/evr.c: > } > > if (SUCCEEDED(IMFTransform_ProcessInput(stream->parent->mixer, stream->id, sample, 0))) > - IMFVideoPresenter_ProcessMessage(stream->parent->presenter, MFVP_MESSAGE_PROCESSINPUTNOTIFY, 0); > + { > + while (hr == S_OK && (hr = IMFVideoPresenter_ProcessMessage(stream->parent->presenter, MFVP_MESSAGE_PROCESSINPUTNOTIFY, 0)) == MF_E_TRANSFORM_TYPE_NOT_SET) > + hr = IMFVideoPresenter_ProcessMessage(stream->parent->presenter, MFVP_MESSAGE_INVALIDATEMEDIATYPE, 0); > + } If it works like that, sure. But could we turn "hr == S_OK" to a loop break condition, after ProcessMessage. Or simply as "if ((hr == ProcessMessage()) != S_OK) break;. I think that would be more readable and easy to follow. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6059#note_88170

1 0

[PATCH v8 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused
by Fabian Maurer (＠DarkShadow44) 20 Nov '24

20 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109 -- v8: user32: Send parent BN_CLICKED notification when a radio button get focused. user32/tests: Add tests for radio button WM_SETFOCUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

4 7

[PATCH v5 0/5] MR6783: winegstreamer: Fix memory/resource leaks in media sources.
by Conor McCarthy (＠cmccarthy) 20 Nov '24

20 Nov '24

Streams hold a reference to the source, but this reference should not be taken until `Start()` is called because freeing the media source depends on release in `Shutdown()` of the stream's reference to the source. We could create the streams in `media_source_create()` and take source refs for them in `Start()`, but that's potentially confusing and fragile. Streams can persist after the media source is destroyed. In that case, they cannot access the source object and it should be released and set to null. Windows behaviour is to release references to the source in `Shutdown()`. If we don't do this and a buggy app were to leak a stream object, the media source object would also leak and `wg_parser_destroy()` would not be called. -- v5: winegstreamer: Release stream references to the media source in Shutdown(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6783

5 11

[PATCH v12 0/3] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 20 Nov '24

20 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_pa…) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- v12: comctl32/toolbar: Forward WM_NOTIFY CBEN_ENDEDITW. comctl32: Move WM_NOTIFY unicode to ansi conversion code from pager.c to commctrl.c. comctl32/tests: Test WM_NOTIFY CBEN_ENDEDITW conversion and forwarding in toolbar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6737

3 4

[PATCH v11 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 20 Nov '24

20 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_pa…) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- v11: comctl32/toolbar: Forward WM_NOTIFY CBEN_ENDEDITW. comctl32/tests: Test WM_NOTIFY CBEN_ENDEDITW conversion and forwarding in toolbar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6737

4 10

[PATCH 0/1] MR6856: msi: Don't use bool as a variable name.
by Gerald Pfeifer (＠gerald) 20 Nov '24

20 Nov '24

This is a reserved identifier in C23 and would break with GCC 15 moving to -std=gnu23 (based on C23). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6856

4 3

[PATCH 0/1] MR6839: msi: Also set x64 properties for arm64 hosts.
by Billy Laws (＠bylaws) 20 Nov '24

20 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6839

4 4

[PATCH 0/1] MR6838: msi: Dynamically determine supported package architectures.
by Billy Laws (＠bylaws) 20 Nov '24

20 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6838

4 4

[PATCH 0/5] MR6863: winex11: Use more of the new state tracker and make initial window properties changes asynchronous too.
by Rémi Bernon (＠rbernon) 20 Nov '24

20 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6863

2 5

Re: [PATCH v3 0/2] MR6787: wineps.drv: Use locale aware variants _sprintf_l and _sscanf_l. (ASan)
by Bernhard Übelacker (＠bernhardu) 20 Nov '24

20 Nov '24

On Wed Nov 20 10:02:28 2024 +0000, Huw Davies wrote: > @bernhardu, I'd requested access to your repo so that I could make some > cosmetic changes to the commit. Hello Huw, sorry, did not realize this needs an action from my side, just confirmed it now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6787#note_88137

1 0

[PATCH 0/1] MR6862: win32u: Print the correct index when source_enum_display_settings() fails.
by Zhiyi Zhang (＠zhiyi) 20 Nov '24

20 Nov '24

When source_enum_display_settings() fails to find a display mode because the index is out of range, the index number in the log is always 0 because the same variable is decreased in the for loop to find the display mode, giving the impression that it fails to find the first display mode. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6862

3 2

[PATCH v5 0/3] MR4794: comctl32/combo: Add tests for keypresses showing search functionality
by Fabian Maurer (＠DarkShadow44) 20 Nov '24

20 Nov '24

In preparation to fix https://bugs.winehq.org/show_bug.cgi?id=56104 and https://bugs.winehq.org/show_bug.cgi?id=42898 -- v5: comctl32/listbox: Add tests for keypresses showing search functionality. comctl32/combo: Add tests for keypresses showing search functionality. comctl32/listbox: Close a few leaked window handles. https://gitlab.winehq.org/wine/wine/-/merge_requests/4794

4 6

Re: [PATCH v3 0/2] MR6787: wineps.drv: Use locale aware variants _sprintf_l and _sscanf_l. (ASan)
by Huw Davies (＠huw) 20 Nov '24

20 Nov '24

@bernhardu, I'd requested access to your repo so that I could make some cosmetic changes to the commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6787#note_88134

1 0

[PATCH 0/1] MR6834: iphlpapi: Sort adapters by route metric in GetAdaptersAddresses().
by Hans Leidekker (＠hans) 20 Nov '24

20 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56790 Manual tests modifying metrics confirm that GetAdaptersAddresses() sorts the list using the lower of ipv4 and ipv6 metrics, low to high. The order in which NsiAllocateAndGetTable(NSI_NDIS_IFINFO_TABLE) returns adapters is not affected by route metric. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6834

4 3

[PATCH 0/2] MR6861: nls: Set alpha bit on some Thai and Mongolian codes.
by Daniel Lehman (＠dlehman25) 20 Nov '24

20 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6861

3 3

[PATCH v15 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Mohamad Al-Jaf (＠maljaf) 20 Nov '24

20 Nov '24

Needed by Orbiter Space Flight Simulator and Train Simulator Classic. -- v15: d3d9/tests: Add Direct3DCreate9On12() tests. d3d9: Implement Direct3DCreate9On12(). include: Add d3d9on12.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/4915

3 5

[PATCH 0/8] MR6860: dplayx: GROUPDATACHANGED handling and UNICODE support in EnumConnections() and EnumSessions().
by Anton Baskanov (＠baskanov) 20 Nov '24

20 Nov '24

With these changes it is now possible to join and play GTA 2 multiplayer sessions created by native dplay. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6860

4 10

[PATCH 0/2] MR6857: dxva2: Stub DXVAHD_CreateDevice().
by Elizabeth Figura (＠zfigura) 20 Nov '24

20 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6857

3 3

[PATCH 0/1] MR6853: windowscodecs/tests: Always use a format string in winetest_push_context calls.
by Jacek Caban (＠jacek) 19 Nov '24

19 Nov '24

Fixes -Wformat-security on Clang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6853

3 2

Re: [PATCH v10 0/3] MR6744: dlls/setupapi: Implement SetupDiGetDevicePropertyKeys - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6744

1 0

Re: [PATCH v2 0/1] MR6854: ntdll: Use proper format string for ULONG type. - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6854

1 0

Re: [PATCH v2 0/1] MR6851: configure: Preserve original CFLAGS when adding LLVM flags. - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6851

1 0

Re: [PATCH v3 0/2] MR6840: jscript: Handle star and opt operators while matching global regex properly. - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6840

1 0

Re: [PATCH v3 0/1] MR6847: evr: Use D3DCREATE_MULTITHREADED device creation flag. - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6847

1 0

Re: [PATCH v2 0/1] MR6821: d3d9/tests: Flush events after minimizing and restoring focus window. - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6821

1 0

Re: [PATCH v3 0/1] MR6806: wined3d: Allow reusing current GL context without a current RT. - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6806

1 0

Re: [PATCH v2 0/1] MR6211: wined3d: Fix a memory leak. - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6211

1 0

Re: [PATCH v2 0/1] MR1443: include: enum insted of macros for options flag in pathcch - closed
by Nikolay Sivov (＠nsivov) 19 Nov '24

19 Nov '24

This merge request was closed by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1443

1 0

Re: [PATCH v2 0/1] MR1443: include: enum insted of macros for options flag in pathcch
by Nikolay Sivov (＠nsivov) 19 Nov '24

19 Nov '24

Merged in !6837. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1443#note_88095

1 0

Re: [PATCH v2 0/8] MR6813: wined3d: FFP HLSL shaders, part 1/3. - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6813

1 0

Re: [PATCH v3 0/1] MR6842: ieframe: Add IERefreshElevationPolicy stub - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6842

1 0

Re: [PATCH v3 0/1] MR1421: include: add c++ header guards in pathcch - closed
by Nikolay Sivov (＠nsivov) 19 Nov '24

19 Nov '24

This merge request was closed by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1421

1 0

Re: [PATCH v3 0/1] MR1421: include: add c++ header guards in pathcch
by Nikolay Sivov (＠nsivov) 19 Nov '24

19 Nov '24

This is now merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1421#note_88090

1 0

Re: [PATCH v2 0/7] MR6844: dplayx: Group player handling for SUPERENUMPLAYERSREPLY and a more complete AddPlayerToGroup() implementation. - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6844

1 0

Re: [PATCH v4 0/2] MR6827: msi: Fix MsiSummaryInfoPersist not saving data to disk - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6827

1 0

Re: [PATCH v3 0/1] MR6843: opengl: Avoid inifinite recursion in bezier_approximate() in case of degraded curve. - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6843

1 0

Re: [PATCH v2 0/1] MR6836: dpwsockx: Avoid using true as a variable name - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6836

1 0

Re: [PATCH v2 0/2] MR6837: include: Add cpp header guard to the pathcch.h - approved
by Alexandre Julliard (＠julliard) 19 Nov '24

19 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6837

1 0

[PATCH 0/5] MR6850: mshtml: Expose the props properly for Node prototype chain.
by Gabriel Ivăncescu (＠insn) 19 Nov '24

19 Nov '24

This is just nodes for now. The tests in the last patch may seem a bit overkill now, but it will be used for all the other prototypes, so they'll only need extra entries in the array/table, making it way simpler and less redundant. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6850

3 21

[PATCH 0/1] MR6854: ntdll: Use proper format string for ULONG type.
by Jacek Caban (＠jacek) 19 Nov '24

19 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6854

3 2

[PATCH v14 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Mohamad Al-Jaf (＠maljaf) 19 Nov '24

19 Nov '24

Needed by Orbiter Space Flight Simulator and Train Simulator Classic. -- v14: d3d9/tests: Add Direct3DCreate9On12() tests. d3d9: Implement Direct3DCreate9On12(). include: Add d3d9on12.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/4915

4 7

2025

2024

2023

2022

wine-gitlab