- wine-gitlab - winehq.org

[PATCH v19 0/7] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 05 Nov '24

05 Nov '24

-- v19: wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

3 8

[PATCH v17 0/7] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 05 Nov '24

05 Nov '24

-- v17: wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. wintypes: Add stubs for IMap<HSTRING, IInspectable *>, IObservableMap<HSTRING, IInspectable *>, IIterable<IKeyValuePair<HSTRING, IInspectable *>> to PropertySet implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

3 8

[PATCH v16 0/9] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 05 Nov '24

05 Nov '24

-- v16: wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

3 10

[PATCH v15 0/9] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 05 Nov '24

05 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the `IWinePropertySetImpl` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v15: wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation wintypes: Add IObservableMap<HSTRING, IInspectable *> and stubs to PropertySet implementation. wintypes: Add IMap<HSTRING, IInspectable *> stubs to PropertySet implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

3 12

[PATCH v14 0/8] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 05 Nov '24

05 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the `IWinePropertySetImpl` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v14: https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

3 9

[PATCH v13 0/17] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 05 Nov '24

05 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the `IWinePropertySetImpl` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v13: wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). wintypes: Invoke MapChanged event handlers from PropertySet on insertion. wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. wintypes: Implement IMap methods HasKey, get_Count, Remove, GetView for PropertySet. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

2 2

[PATCH v12 0/18] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 05 Nov '24

05 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the `IWinePropertySetImpl` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v12: wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). wintypes: Invoke MapChanged event handlers from PropertySet on insertion. wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. wintypes: Implement IMap method GetView() for PropertySet. wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. wintypes: Implement IMap method Clear() for PropertySet. wintypes: Implement IMap methods Insert() and Lookup() for PropertySet. wintypes: Implement adding/removing IMapChangedEventHandlers for IObservableMap<HSTRING, IInspectable *>. wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. wintypes: Add IObservableMap<HSTRING, IInspectable *> and IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

[PATCH v11 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 05 Nov '24

05 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the `IWinePropertySetImpl` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v11: wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). wintypes: Invoke MapChanged event handlers from PropertySet on insertion. wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. wintypes: Implement IMap method GetView() for PropertySet. wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. wintypes: Implement IMap method Clear() for PropertySet. wintypes: Implement IMap methods Insert() and Lookup() for PropertySet. wintypes: Implement adding/removing IMapChangedEventHandlers for IObservableMap<HSTRING, IInspectable *>. wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. wintypes: Add IObservableMap<HSTRING, IInspectable *> stubs to PropertySet implementation. wintypes: Add IMap<HSTRING, IInspectable *> stubs to PropertySet implementation. wintypes: Add stub for Windows.Foundation.Collections.PropertySet. wintypes/test: Add conformance tests for Windows.Foundation.Collections.PropertySet. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 2

[PATCH v4 0/4] MR6767: WriteProcessMemory() without PROCESS_QUERY_INFORMATION access right.
by eric pouech (＠epo) 05 Nov '24

05 Nov '24

This is an alternate solution to MR 6761 [1] (actually is based on comment in that MR). WriteProcessMemory() should succeed when process handle doesn't have PROCESS_QUERY_INFORMATION access right set (test attached). Plus some additional cleanup in test for ReadProcessMemory(). Feedback from Proton says that this patch solves the reported game issue. [1] https://gitlab.winehq.org/wine/wine/-/merge_requests/6761 -- v4: server: Amend process rights mapping. advapi32: Test some other cases of process access rights mapping. advapi32/tests: Fix typo in manifest constant. kernel32/tests: Don't hardcode page size in buffer size. https://gitlab.winehq.org/wine/wine/-/merge_requests/6767

4 9

[PATCH v3 0/4] MR6767: WriteProcessMemory() without PROCESS_QUERY_INFORMATION access right.
by eric pouech (＠epo) 05 Nov '24

05 Nov '24

This is an alternate solution to MR 6761 [1] (actually is based on comment in that MR). WriteProcessMemory() should succeed when process handle doesn't have PROCESS_QUERY_INFORMATION access right set (test attached). Plus some additional cleanup in test for ReadProcessMemory(). Feedback from Proton says that this patch solves the reported game issue. [1] https://gitlab.winehq.org/wine/wine/-/merge_requests/6761 -- v3: server: Amend process rights mapping. advapi32: Test some other cases of process access rights mapping. advapi32/tests: Fix typo in manifest constant. kernel32/tests: Don't hardcode page size in buffer size. https://gitlab.winehq.org/wine/wine/-/merge_requests/6767

3 6

[PATCH v2 0/3] MR6767: WriteProcessMemory() without PROCESS_QUERY_INFORMATION access right.
by eric pouech (＠epo) 05 Nov '24

05 Nov '24

This is an alternate solution to MR 6761 [1] (actually is based on comment in that MR). WriteProcessMemory() should succeed when process handle doesn't have PROCESS_QUERY_INFORMATION access right set (test attached). Plus some additional cleanup in test for ReadProcessMemory(). Feedback from Proton says that this patch solves the reported game issue. [1] https://gitlab.winehq.org/wine/wine/-/merge_requests/6761 -- v2: server: Amend process rights mapping. ntdll/tests: Add tests for NtQueryVirtualMemory. kernel32/tests: Don't hardcode page size in buffer size. https://gitlab.winehq.org/wine/wine/-/merge_requests/6767

4 6

[PATCH 0/2] MR6775: user32: Add EnableMouseInPointerForThread() stub.
by Zhiyi Zhang (＠zhiyi) 05 Nov '24

05 Nov '24

React Native apps use user32.2561. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6775

3 3

[PATCH 0/2] MR6774: ntdll: Implement NtSetIoCompletionEx().
by Zhiyi Zhang (＠zhiyi) 05 Nov '24

05 Nov '24

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6774

3 3

[PATCH v10 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 05 Nov '24

05 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the `IWinePropertySetImpl` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v10: dlls/wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. dlls/wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). dlls/wintypes: Invoke MapChanged event handlers from PropertySet on insertion. dlls/wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. dlls/wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. dlls/wintypes: Implement IMap method GetView() for PropertySet. dlls/wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

[PATCH 0/6] MR6773: iertutil: Add iertutil.dll.
by Zhiyi Zhang (＠zhiyi) 05 Nov '24

05 Nov '24

Use raw URI as absolute URI for now. To make it fully compliant with RFC 3986 and 3987, we need to implement a parser and reconstruct the absolute URI from parts. For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6773

2 6

[PATCH v8 0/3] MR4579: websocket: Add some stub functions.
by Vijay Kiran Kamuju (＠infyquest) 05 Nov '24

05 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54623 -- v8: websocket: Add stub for WebSocketDeleteHandle. websocket: Add stub for WebSocketAbortHandle. websocket: Add stub for WebCreateClientHandle. https://gitlab.winehq.org/wine/wine/-/merge_requests/4579

3 4

[PATCH 0/5] MR6771: dplayx: Send() implementation.
by Anton Baskanov (＠baskanov) 05 Nov '24

05 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6771

4 7

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 05 Nov '24

05 Nov '24

On Mon Nov 4 22:04:51 2024 +0000, Alanas wrote: > handling is simpler if toolbar thinks parent wants unicode notifications > `nmhdr->hwndFrom` is not accessed and no overwriting `nmhdr->code` > (tested all `nmhdr->code`s): > - https://bugs.winehq.org/attachment.cgi?id=77361&action=edit > - https://bugs.winehq.org/attachment.cgi?id=77363&action=edit For Unicode notification conversions, you might want to take a look at 76f8ea75 and d7dcfe03. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86593

1 0

Re: [PATCH v9 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Zhiyi Zhang (＠zhiyi) 05 Nov '24

05 Nov '24

You can remove `dlls/` from `dlls/wintypes` in the commit message subjects. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_86592

1 0

Re: [PATCH v9 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Zhiyi Zhang (＠zhiyi) 05 Nov '24

05 Nov '24

Please keep merge requests small and each commit atomic, ~5 patches or so for an MR would be best. Each MR should ideally have its corresponding tests. That will help with the reviewing. Note that there are CI build failures. You will need to address that as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_86591

1 0

[PATCH v8 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 05 Nov '24

05 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the \``IWinePropertySetImpl`\` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v8: dlls/wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. dlls/wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). dlls/wintypes: Invoke MapChanged event handlers from PropertySet on insertion. dlls/wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. dlls/wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. dlls/wintypes: Implement IMap method GetView() for PropertySet. dlls/wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. dlls/wintypes: Implement IMap method Clear() for PropertySet. dlls/wintypes: Implement IMap methods Insert() and Lookup() for PropertySet. dlls/wintypes: Implement adding/removing IMapChangedEventHandlers for IObservableMap<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. dlls/wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. dlls/wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. dlls/wintypes: Add IObservableMap<HSTRING, IInspectable *> stubs to PropertySet implementation. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

Re: [PATCH v11 0/2] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Chunhao Hung (＠otakuxtom) 05 Nov '24

05 Nov '24

This cause wineserver crash after merged, revert those two commit will fix the crash -- https://gitlab.winehq.org/wine/wine/-/merge_requests/498#note_86577

1 0

[PATCH v2 0/1] MR6481: dplayx: Merge IDirectPlayLobby3A into IDirectPlayLobby3
by Alistair Leslie-Hughes (＠alesliehughes) 05 Nov '24

05 Nov '24

Use the unicode interface by default and return the same value as before this change. There are a few locations, that called W->A. It will return the same value as before for the Ansi version but the unicode one will now report an error. -- v2: dplayx: Merge IDirectPlayLobby3A into IDirectPlayLobby3 https://gitlab.winehq.org/wine/wine/-/merge_requests/6481

3 2

[PATCH 0/1] MR6769: mountmgr.sys: Stub StorageDeviceSeekPenaltyProperty query.
by Paul Gofman (＠gofman) 04 Nov '24

04 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6769

2 2

Re: [PATCH v11 0/2] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Joel Holdsworth (＠jhol) 04 Nov '24

04 Nov '24

:tada: :tada: :tada: Big step forward for Msys2 support! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/498#note_86567

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 04 Nov '24

04 Nov '24

On Mon Nov 4 18:51:22 2024 +0000, Alanas wrote: > > In your winehq test, 0xffff0000u seems like a special value. > No, you can replace it with `0u` and get same (except addresses) output > but `foo5.exe` runs very slow. handling is simpler if toolbar thinks parent wants unicode notifications `nmhdr->hwndFrom` is not accessed and no overwriting `nmhdr->code` (tested all `nmhdr->code`s): - https://bugs.winehq.org/attachment.cgi?id=77361&action=edit - https://bugs.winehq.org/attachment.cgi?id=77363&action=edit -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86566

1 0

[PATCH v32 0/5] MR6621: winebth.sys part 1: Introduce Bluetooth driver.
by Vibhav Pant (＠vibhavp) 04 Nov '24

04 Nov '24

This MR is the first of multiples MRs adding support for the Bluetooth stack API in Wine: 1. The winebth.sys driver, which talks to BlueZ and implements several key IOCTLs for communicating with Bluetooth devices and radios. 2. A bthserv service, which is responsible for keeping track of the authentication agent, and relaying authentication requests and responses to and from the driver. 3. Userspace APIs (bluetoothapis.dll, bthprops.cpl, Windows.Devices.Bluetooth, etc). winebth.sys is split into two "sub" drivers: `winebth.sys`: The main entrypoint, loaded by winedevice. It listens for changes to Bluetooth devices and radios and authentication events on BlueZ, passing them on the bthenum. It also handles most IOCTL operations on Bluetooth radio PDOs. `bthenum`: Responsible for creating nodes for discovered Bluetooth devices and associated services. It also tries to validate any IOCTLs relating to bluetooth devices before passing them to winebth.sys. (Not in this MR, likely in part 2) The unix code is split between dbus.c, unixlib.c and winebluetooth.c, where winebluetooth is a simple wrapper around unixlib for the sake of organization. -- v32: dlls/winebth.sys: Register and enable BTHPORT_DEVICE and BLUETOOTH_RADIO interfaces for radio PDOs. dlls/winebth.sys: Derive a unique hardware ID for radio PDOs from their corresponding BlueZ object path. dlls/winebth.sys: Create radio PDOs from the list of org.bluez.Adapter1 objects on BlueZ. dlls/winebth.sys: Add a basic unixlib stub using DBus. dlls/winebth.sys: Add base winebth.sys driver. https://gitlab.winehq.org/wine/wine/-/merge_requests/6621

2 5

Re: [PATCH v2 0/1] MR6768: ntdll: Do not queue completion for a synchronous file. - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6768

1 0

Re: [PATCH v2 0/3] MR6763: dplayx fixes - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6763

1 0

Re: [PATCH v11 0/2] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105) - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/498

1 0

Re: [PATCH v2 0/1] MR6765: winegcc: Skip --no-default-config in find_libgcc. - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6765

1 0

Re: [PATCH v2 0/1] MR6764: kernelbase: Add undocumented EXTENDED_FLAGS to process attribute list. - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6764

1 0

Re: [PATCH v4 0/1] MR6738: include: Add missing defines and enums for IDragSourceHelper2. - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6738

1 0

Re: [PATCH v7 0/3] MR6739: apphelp: Add PermLayer related functions. - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6739

1 0

Re: [PATCH v3 0/5] MR6743: win32u: Use MDT_RAW_DPI in the drivers 1/2. - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6743

1 0

Re: [PATCH v2 0/1] MR6757: include: Annotate PFN_CMSG_ALLOC with __WINE_ALLOC_SIZE. - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6757

1 0

Re: [PATCH v2 0/4] MR6751: dplayx: Misc fixes and CREATEPLAYER handling. - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6751

1 0

Re: [PATCH v2 0/6] MR6758: d3dx9: PNG/JPG file handling changes. - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6758

1 0

[PATCH v4 0/2] MR6734: wbemprox: Add property "ExecutablePath" to Win32_Process
by Fabian Maurer (＠DarkShadow44) 04 Nov '24

04 Nov '24

-- v4: wbemprox: Add property "ExecutablePath" to Win32_Process wbemprox/tests: Add test for Win32_Process querying "ExecutablePath" propery https://gitlab.winehq.org/wine/wine/-/merge_requests/6734

3 5

[PATCH 0/3] MR6767: WriteProcessMemory() without PROCESS_QUERY_INFORMATION access right.
by eric pouech (＠epo) 04 Nov '24

04 Nov '24

This is an alternate solution to MR 6761 [1] (actually is based on comment in that MR). WriteProcessMemory() should succeed when process handle doesn't have PROCESS_QUERY_INFORMATION access right set (test attached). Plus some additional cleanup in test for ReadProcessMemory(). Feedback from Proton says that this patch solves the reported game issue. [1] https://gitlab.winehq.org/wine/wine/-/merge_requests/6761 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6767

3 4

[PATCH v5 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 04 Nov '24

04 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the \``IWinePropertySetImpl`\` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v5: dlls/wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. dlls/wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). dlls/wintypes: Invoke MapChanged event handlers from PropertySet on insertion. dlls/wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. dlls/wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. dlls/wintypes: Implement IMap method GetView() for PropertySet. dlls/wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. dlls/wintypes: Implement IMap method Clear() for PropertySet. dlls/wintypes: Implement IMap methods Insert() and Lookup() for PropertySet. dlls/wintypes: Implement adding/removing IMapChangedEventHandlers for IObservableMap<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. dlls/wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. dlls/wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. dlls/wintypes: Add IObservableMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add IMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add stub for Windows.Foundation.Collections.PropertySet. dlls/wintypes/test: Add conformance tests for Windows.Foundation.Collections.PropertySet. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

[PATCH 0/1] MR6768: ntdll: Do not queue completion for a synchronous file.
by Elizabeth Figura (＠zfigura) 04 Nov '24

04 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6768

3 2

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 04 Nov '24

04 Nov '24

> In your winehq test, 0xffff0000u seems like a special value. No, you can replace it with `0u` and get same (except addresses) output but `foo5.exe` runs very slow. TODO: `foo5.c` UTF-16 port -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86530

1 0

[PATCH v4 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 04 Nov '24

04 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the \``IWinePropertySetImpl`\` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v4: dlls/wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. dlls/wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). dlls/wintypes: Invoke MapChanged event handlers from PropertySet on insertion. dlls/wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. dlls/wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. dlls/wintypes: Implement IMap method GetView() for PropertySet. dlls/wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. dlls/wintypes: Implement IMap method Clear() for PropertySet. dlls/wintypes: Implement IMap methods Insert() and Lookup() for PropertySet. dlls/wintypes: Implement adding/removing IMapChangedEventHandlers for IObservableMap<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. dlls/wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. dlls/wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. dlls/wintypes: Add IObservableMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add IMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add stub for Windows.Foundation.Collections.PropertySet. dlls/wintypes/test: Add conformance tests for Windows.Foundation.Collections.PropertySet. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

[PATCH v2 0/7] MR6752: include: More fixes to build libc++.
by Rémi Bernon (＠rbernon) 04 Nov '24

04 Nov '24

-- v2: include: Fix wmemchr C++ warning. include: Fix InlineIsEqualGUID C++ warning. include: Add some _BitScanForward(64) declarations in intrin.h. include: Add a __shiftright128 intrinsic definition. include: Add a _umul128 intrinsic definition. include: Move FILE_DISPOSITION_INFO after DeleteFile(A|W). include: Add a MB_CUR_MAX definition in ctype.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/6752

3 11

[PATCH v3 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 04 Nov '24

04 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the \``IWinePropertySetImpl`\` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v3: dlls/wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. dlls/wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). dlls/wintypes: Invoke MapChanged event handlers from PropertySet on insertion. dlls/wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. dlls/wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. dlls/wintypes: Implement IMap method GetView() for PropertySet. dlls/wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. dlls/wintypes: Implement IMap method Clear() for PropertySet. dlls/wintypes: Implement IMap methods Insert() and Lookup() for PropertySet. dlls/wintypes: Implement adding/removing IMapChangedEventHandlers for IObservableMap<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. dlls/wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. dlls/wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. dlls/wintypes: Add IObservableMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add IMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add stub for Windows.Foundation.Collections.PropertySet. dlls/wintypes/test: Add conformance tests for Windows.Foundation.Collections.PropertySet. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

[PATCH v2 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 04 Nov '24

04 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, this could be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v2: dlls/wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. dlls/wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). dlls/wintypes: Invoke MapChanged event handlers from PropertySet on insertion. dlls/wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. dlls/wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. dlls/wintypes: Implement IMap method GetView() for PropertySet. dlls/wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. dlls/wintypes: Implement IMap method Clear() for PropertySet. dlls/wintypes: Implement IMap methods Insert() and Lookup() for PropertySet. dlls/wintypes: Implement adding/removing IMapChangedEventHandlers for IObservableMap<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. dlls/wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. dlls/wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. dlls/wintypes: Add IObservableMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add IMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add stub for Windows.Foundation.Collections.PropertySet. dlls/wintypes/test: Add conformance tests for Windows.Foundation.Collections.PropertySet. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

[PATCH 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 04 Nov '24

04 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, this could be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 04 Nov '24

04 Nov '24

On Sat Nov 2 19:49:00 2024 +0000, Alanas wrote: > > With this change, unhandled notifications are all forwarded to > hwndNotify and I worry that it might not be the case. > Yes, windows does have more handled notifications. > There are notifications that don't get forwarded. > There are notifications that `nmhdr->code` overwritten and get forwarded. > Not all notifications have `nmhdr->code` that is equal to a macro in > mingw-w64's > [commctrl.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82… > and [prsht.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82693…. > See https://bugs.winehq.org/attachment.cgi?id=77351&action=edit and https://bugs.winehq.org/attachment.cgi?id=77352&action=edit. I think we can probably return 0 for the range used by common controls and then forward the rest to hwndNotify. The range doesn't have to be exact. For example, the smallest notification code is LVN_FIRST (0U-100U) and the largest is TRBN_LAST (0u-1519u). So we can probably return 0 for LVN_FIRST ~ TRBN_LAST. The more exact range can be found using a loop. In your winehq test, 0xffff0000u seems like a special value. So maybe exclude 0xffff0000u~0xffffffffu also works? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86499

1 0

[PATCH 0/1] MR6765: winegcc: Skip --no-default-config in find_libgcc.
by Jacek Caban (＠jacek) 04 Nov '24

04 Nov '24

The default config provides a valid way of defining the default compiler’s libgcc (or its equivalent). Future llvm-mingw will use it instead of shell wrappers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6765

2 1

[PATCH 0/1] MR6764: kernelbase: Add undocumented EXTENDED_FLAGS to process attribute list.
by eric pouech (＠epo) 04 Nov '24

04 Nov '24

Let the sub-process be created, without implementing any additional behavior from these flags. Native cmd.exe uses this flag when spawning itself again for handling builtin commands inside a pipe. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6764

2 1

[PATCH 0/3] MR6763: dplayx fixes
by Alistair Leslie-Hughes (＠alesliehughes) 04 Nov '24

04 Nov '24

This patchset does includes a patch from another patchset, which I'll rebase once this one is accepted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6763

3 4

[PATCH 0/4] MR6733: Mfplat HTTP byte stream implementation
by Torge Matthies (＠tmatthies) 03 Nov '24

03 Nov '24

This has been tested with VRChat in Proton, and with one change to `IMFMediaEngine` and some small changes to winegstreamer it is able to play YouTube videos in Unity video player based players. The AVPro based players have many more issues, because that API uses YouTube's HLS files instead of the direct MP4 links, and new media source would need many fixes to be able to play HLS correctly. Which it isn't supposed to do anyway since that's the `IMFMediaEngine`'s job. There are some things that I did not implement: - `IMFByteStreamBuffering::SetBufferingParams`, the parameters don't have any obvious effect on the functionality of the byte stream or the HTTP requests it makes. It's probably not used by anything anyway. - How much data has to be pre-buffered before it considers buffering to be complete and sends `MEBufferingStopped`. I didn't put much time into this and just chose 64 KiB. - Persistent caching of downloaded data; Native seems to be able to omit redownloading data it has previously downloaded before by using the `If-Modified-Since` header. This seems like more work and unnecessary complexity than it's worth. - Mapping of all the WinHTTP errors to HRESULTs; HTTP status codes are handled, as well as the most common `ERROR_WINHTTP_*` values, but anything else just goes through `HRESULT_FROM_WIN32`. I don't even know how to trigger most of the WinHTTP errors; It's probably fine, the most important info is just that there has been an error anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6733

4 39

Re: [PATCH v3 0/2] MR6584: wintab32: Improve wow64 support
by John Chadwick (＠jchw) 02 Nov '24

02 Nov '24

FWIW, as far as I'm concerned, this or a similar patch should probably still be merged, to fix the wow64 stub. It basically just comes down to the approach to fix it. If anyone gets a chance to look at this let me know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6584#note_86467

1 0

[PATCH v4 0/1] MR6285: shell32: Allow FindExecutables to find unix files.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Nov '24

02 Nov '24

This fixes one of the regression with ShellExecute when using a full patch and an executable without an extension. -- v4: shell32: Allow FindExecutables to find unix files. https://gitlab.winehq.org/wine/wine/-/merge_requests/6285

2 1

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 02 Nov '24

02 Nov '24

On Sat Nov 2 08:52:23 2024 +0000, Zhiyi Zhang wrote: > This `else` branch should never get executed because only the > test_WM_NOTIFY() test sends a WM_NOTIFY with TEST_WM_NOTIFY_CODE. So you > can delete this branch. `else` branch will be executed if WM_NOTIFY message gets forwarded twice by buggy non-test code -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86464

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 02 Nov '24

02 Nov '24

> With this change, unhandled notifications are all forwarded to hwndNotify and I worry that it might not be the case. Yes, windows does have more handled notifications. There are notifications that don't get forwarded. There are notifications that `nmhdr->code` overwritten and get forwarded. Not all notifications have `nmhdr->code` that is equal to a macro in mingw-w64's [commctrl.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82… and [prsht.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82693…. See https://bugs.winehq.org/attachment.cgi?id=77351&action=edit and https://bugs.winehq.org/attachment.cgi?id=77352&action=edit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86463

1 0

[PATCH 0/2] MR6759: kernelbase: Make trailing slashes in CreateFileW set ERROR_PATH_NOT_FOUND
by Fabian Maurer (＠DarkShadow44) 02 Nov '24

02 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57376 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6759

4 4

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 02 Nov '24

02 Nov '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/toolbar.c: > return 0; > > default: With this change, unhandled notifications are all forwarded to hwndNotify and I worry that it might not be the case. Please add tests for [pager notification codes](https://learn.microsoft.com/en-us/windows/win32/controls/bumper-page… and [tooltips notification codes](https://learn.microsoft.com/en-us/windows/win32/controls/bumper-tool…. Also add a TRACE() when forwarding notifications to hwndNotify. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86461

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 02 Nov '24

02 Nov '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > } > } > > return TRUE; Please add a dot at the end of the commit subject. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86460

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 02 Nov '24

02 Nov '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > return 0; > } > + case TEST_WM_NOTIFY_CODE: > + if (expecting_test_WM_NOTIFY) > + { > + ok(hdr == &test_WM_NOTIFY_nmhdr, "Got unexpected header.\n"); > + ok(wParam == TEST_WM_NOTIFY_IDFROM, "Got unexpected wParam 0x%Ix.\n", wParam); > + } > + else This `else` branch should never get executed because only the test_WM_NOTIFY() test sends a WM_NOTIFY with TEST_WM_NOTIFY_CODE. So you can delete this branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86459

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 02 Nov '24

02 Nov '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define TEST_WM_NOTIFY_IDFROM 0xabcd0002 > +#define TEST_WM_NOTIFY_CODE 0xabcd0003 > +#define TEST_WM_NOTIFY_RETURN 0xabcd0004 > +static BOOL expecting_test_WM_NOTIFY; > +static const NMHDR test_WM_NOTIFY_nmhdr = > +{ > + /* .hwndFrom should not be accessed */ > + .hwndFrom = (HWND)0xabcd0001, Let's add a TEST_WM_NOTIFY_HWND as well for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86458

1 0

[PATCH 0/4] MR6663: Draft: Placed-allocation-callback solution for wow64 GL memory mappings
by Derek Lesho (＠dlesho) 02 Nov '24

02 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6663

6 9

[PATCH 0/4] MR6751: dplayx: Misc fixes and CREATEPLAYER handling.
by Anton Baskanov (＠baskanov) 01 Nov '24

01 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6751

4 6

[PATCH 0/6] MR6758: d3dx9: PNG/JPG file handling changes.
by Connor McAdams (＠cmcadams) 01 Nov '24

01 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6758

3 7

[PATCH v10 0/2] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) 01 Nov '24

01 Nov '24

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. --- **Note**: `subpath->str` may look hacky, but it's used to indicate trailing `\\`[^bks] and existing code already does it too: - `server/directory.c` checks `name->str`[^dir] to test if this is the last component. This is evident by the fact that changing it to `name->len` will lead to major regression. - `server/registry.c` has similar lookup logic.[^reg1][^reg2] [^bks]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^dir]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^reg1]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> [^reg2]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> -- v10: server: Implement more FSCTLs on \Device\NamedPipe and \Device\NamedPipe\. server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/498

2 3

[PATCH 0/1] MR6757: include: Annotate PFN_CMSG_ALLOC with __WINE_ALLOC_SIZE.
by Alex Henrie (＠alexhenrie) 01 Nov '24

01 Nov '24

To match [PFN_CRYPT_ALLOC](https://gitlab.winehq.org/alexhenrie/wine/-/blob/3a736901c… and get better warnings when compiling with `-fanalyzer`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6757

2 1

Re: [PATCH v3 0/2] MR6581: win32u: Implement drawing transformed arcs.
by Haoyang Chen (＠chenhaoyang) 01 Nov '24

01 Nov '24

Hi, if ellipse_width/ellipse_height is less than 2, it will assert at solid_pen_lines( dlls/win32u/dibdrv/objects.c +812). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6581#note_86430

1 0

[PATCH 0/1] MR6755: Draft: wined3d: Metal renderer
by Isaac Marovitz (＠IsaacMarovitz) 31 Oct '24

31 Oct '24

Mostly just boilerplate while I figure out how to best approach the Objective-C <-> C mess this will require. It likely won't go anywhere but I figured I would share. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6755

3 2

Re: [PATCH v3 0/4] MR6746: d3dx9: Introduce d3dx_pixel_format_id enumeration. - approved
by Alexandre Julliard (＠julliard) 31 Oct '24

31 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6746

1 0

Re: [PATCH v2 0/2] MR6749: Stubs for the FTDI USB D2XX drivers. - approved
by Alexandre Julliard (＠julliard) 31 Oct '24

31 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6749

1 0

Re: [PATCH v2 0/7] MR6753: dataexchange: Make core_dragdrop_manager_add_TargetRequested() return S_OK. - approved
by Alexandre Julliard (＠julliard) 31 Oct '24

31 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6753

1 0

Re: [PATCH v4 0/4] MR6722: win32u: Yet more arc fixes. - approved
by Alexandre Julliard (＠julliard) 31 Oct '24

31 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6722

1 0

Re: [PATCH v31 0/5] MR6621: winebth.sys part 1: Introduce Bluetooth driver. - approved
by Elizabeth Figura (＠zfigura) 31 Oct '24

31 Oct '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6621

1 0

[PATCH v2 0/4] MR6746: d3dx9: Introduce d3dx_pixel_format_id enumeration.
by Connor McAdams (＠cmcadams) 31 Oct '24

31 Oct '24

This MR contains a set of patches that move away from using `D3DFORMAT` inside of `struct d3dx_image`. This will allow us to support formats that do not have a direct mapping to `D3DFORMAT`, and eventually once we share code with d3dx10/d3dx11 formats that do not have a direct mapping to `DXGI_FORMAT`. I've pushed a branch [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/UPSTREAM/d3dx9-new-fmt… containing patches that actually use this new internal format system in practice. I would've included those in this MR, but that seemed like it'd make for a rather large MR. Hopefully splitting it this way makes it easier to review. :) -- v2: d3dx9: Use the d3dx_pixel_format_id enumeration inside of the WIC pixel format lookup structure. d3dx9: Use the d3dx_pixel_format_id enumeration inside of the DDS pixel format lookup structure. https://gitlab.winehq.org/wine/wine/-/merge_requests/6746

3 6

[PATCH 0/4] MR6746: d3dx9: Introduce d3dx_pixel_format_id enumeration.
by Connor McAdams (＠cmcadams) 31 Oct '24

31 Oct '24

This MR contains a set of patches that move away from using `D3DFORMAT` inside of `struct d3dx_image`. This will allow us to support formats that do not have a direct mapping to `D3DFORMAT`, and eventually once we share code with d3dx10/d3dx11 formats that do not have a direct mapping to `DXGI_FORMAT`. I've pushed a branch [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/UPSTREAM/d3dx9-new-fmt… containing patches that actually use this new internal format system in practice. I would've included those in this MR, but that seemed like it'd make for a rather large MR. Hopefully splitting it this way makes it easier to review. :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6746

3 9

[PATCH v6 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 31 Oct '24

31 Oct '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_pa…) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- v6: comctl32/toolbar: forward unhandled WM_NOTIFY comctl32/tests: Test WM_NOTIFY forwarding for toolbars. https://gitlab.winehq.org/wine/wine/-/merge_requests/6737

2 7

[PATCH v3 0/2] MR6734: wbemprox: Add property "ExecutablePath" to Win32_Process
by Fabian Maurer (＠DarkShadow44) 31 Oct '24

31 Oct '24

I added a new test method, please tell me if I should merge that into an existing one, but as far as I understood, there is no tests for the querying yet. -- v3: wbemprox: Add property "ExecutablePath" to Win32_Process wbemprox/tests: Add test for Win32_Process querying "ExecutablePath" propery https://gitlab.winehq.org/wine/wine/-/merge_requests/6734

4 10

[PATCH 0/7] MR6752: include: More fixes to build libc++.
by Rémi Bernon (＠rbernon) 31 Oct '24

31 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6752

3 10

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

On Thu Oct 31 10:21:42 2024 +0000, Alanas wrote: > do `ok`s in > ```c > case forward_test_code: > if (forward_test) > { > ok(hdr == &forward_test_nmhdr, "Got unexpected header.\n"); > ok(wParam == forward_test_idFrom, "Got unexpected wParam > 0x%Ix.\n", wParam); > } > else > { > ok(FALSE, "Got unexpected WM_NOTIFY.\n"); > } > forward_test = FALSE; > return forward_test_return; > ``` > need to be replaced with `todo_wine ok`? > they get passed 1 in first argument in windows and never run in wine > without editing `dlls/comctl32/toolbar.c` If these ok() in parent_wnd_notify() don't have failures before your fix, then you don't need to add todo_wines in parent_wnd_notify(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86364

1 0

[PATCH v3 0/4] MR6722: win32u: Yet more arc fixes.
by Elizabeth Figura (＠zfigura) 31 Oct '24

31 Oct '24

-- v3: win32u: Forward to Rectangle() if the ellipse width or height is zero. https://gitlab.winehq.org/wine/wine/-/merge_requests/6722

3 6

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 31 Oct '24

31 Oct '24

On Thu Oct 31 09:39:11 2024 +0000, Zhiyi Zhang wrote: > Put the todo_wine before each ok() statement in test_WM_NOTIFY() instead. do `ok`s in ```c case forward_test_code: if (forward_test) { ok(hdr == &forward_test_nmhdr, "Got unexpected header.\n"); ok(wParam == forward_test_idFrom, "Got unexpected wParam 0x%Ix.\n", wParam); } else { ok(FALSE, "Got unexpected WM_NOTIFY.\n"); } forward_test = FALSE; return forward_test_return; ``` need to be replaced with `todo_wine ok`? they get passed 1 in first argument in windows and never run in wine without editing `dlls/comctl32/toolbar.c` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86362

1 0

[PATCH v2 0/5] MR6743: win32u: Use MDT_RAW_DPI in the drivers 1/2.
by Rémi Bernon (＠rbernon) 31 Oct '24

31 Oct '24

This starts using MDT_RAW_DPI in the drivers, and provides the necessary raw/virt monitor information to wineserver. For now, this should not change much, as MDT_RAW_DPI is still the same as MDT_DEFAULT_DPI, but later it will return the DPI of the physical mode while MDT_DEFAULT_DPI will return a DPI for the possibly virtualized current display mode. -- v2: server: Use the monitor infos to compute the virtual screen rect. win32u: Inform wineserver about the winstation monitors. win32u: Move some monitor info getter code around. win32u: Use MDT_RAW_DPI monitor DPI type in the drivers. win32u: Implement get_win_monitor_dpi. https://gitlab.winehq.org/wine/wine/-/merge_requests/6743

3 7

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > test_drawtext_flags(); > test_imagelist(); > test_BTNS_SEP(); > + todo_wine test_WM_NOTIFY(); Put the todo_wine before each ok() statement in test_WM_NOTIFY() instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86359

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > DestroyWindow(hwnd); > } > > +static void test_WM_NOTIFY(void) > +{ > + HWND toolbar = NULL; > + LRESULT ret; Let's put a new line after variable declarations. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86358

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 > +#define forward_test_code 0xabcd0003 > +#define forward_test_return 0xabcd0004 > +static _Bool forward_test; > +static const NMHDR forward_test_nmhdr = { Rename forward_test_nmhdr to test_WM_NOTIFY_forwarding_nmhdr. And put the `{` on a newline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86357

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 > +#define forward_test_code 0xabcd0003 > +#define forward_test_return 0xabcd0004 > +static _Bool forward_test; We usually use the win32 BOOL instead of _Bool. And let's rename the variable to test_WM_NOTIFY_forwarding. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86356

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 Let's use capitals for these definitions. For example, WM_NOTIFY_FORWARD_ID, WM_NOTIFY_FORWARD_HWND, WM_NOTIFY_FORWARD_CODE, and WM_NOTIFY_FORWARD_RETURN. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86355

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > Let's rename the patch subject to "comctl32/tests: Test WM_NOTIFY forwarding for toolbars." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86354

1 0

[PATCH 0/7] MR6753: dataexchange: Make core_dragdrop_manager_add_TargetRequested() return S_OK.
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

React Native applications checks the return value from core_dragdrop_manager_add_TargetRequested(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6753

2 7

[PATCH 0/2] MR6750: user32/edit: multiple edits control also can set passwords.
by Haoyang Chen (＠chenhaoyang) 31 Oct '24

31 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6750

2 2

Re: [PATCH v2 0/1] MR6748: include: Move ISAXXMLFilter interface to after base ISAXXMLReader - approved
by Alexandre Julliard (＠julliard) 30 Oct '24

30 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6748

1 0

Re: [PATCH v2 0/3] MR6747: include: Add windows.applicationmodel.datatransfer.dragdrop.idl. - approved
by Alexandre Julliard (＠julliard) 30 Oct '24

30 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6747

1 0

Re: [PATCH v35 0/2] MR4661: gdiplus: Implement Gdiplus GetParameterSize - approved
by Alexandre Julliard (＠julliard) 30 Oct '24

30 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

1 0

Re: [PATCH v2 0/7] MR6745: include: More fixes to build libc++. - approved
by Alexandre Julliard (＠julliard) 30 Oct '24

30 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6745

1 0

Re: [PATCH v2 0/5] MR6711: dplayx: CreatePlayer() part 3. - approved
by Alexandre Julliard (＠julliard) 30 Oct '24

30 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6711

1 0

Re: [PATCH v2 0/3] MR6741: include: Add DBGUID_DBSQL define - approved
by Alexandre Julliard (＠julliard) 30 Oct '24

30 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6741

1 0

Re: [PATCH v8 0/1] MR6708: win32u: Sync cursor position on window position change. - approved
by Alexandre Julliard (＠julliard) 30 Oct '24

30 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6708

1 0

[PATCH 0/2] MR6749: Stubs for the FTDI USB D2XX drivers.
by Elizabeth Figura (＠zfigura) 30 Oct '24

30 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6749

3 3

[PATCH 0/1] MR6748: include: Move ISAXXMLFilter interface to after base ISAXXMLReader
by Alistair Leslie-Hughes (＠alesliehughes) 30 Oct '24

30 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6748

3 2

2025

2024

2023

2022

wine-gitlab