- wine-gitlab - winehq.org

[PATCH 0/4] MR6658: ddraw: Some fixes for SwapTextureHandles().
by Paul Gofman (＠gofman) 17 Oct '24

17 Oct '24

First of all it fixes a regression introduced by 5a7ff3b45c78784dca0a465d9e21483f72bce6e5 when surface handles were moved to global table but SwapTextureHandles was left behind (https://bugs.winehq.org/show_bug.cgi?id=57300). Then, I am fixing a couple of more issues with this function spotted on the way. I did some initial testing of SwapTextures across devices and that looks messy, device on which the swap is performed influences the outcome in some not immediately obvious way. I omitted the investigation of that because multiple 3d devices in ddraw is already a very exotic use case and I think we are unlikely to meet the usage of SwapTextures across multiple devices. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6658

4 8

Re: [PATCH v3 0/7] MR6672: winetest: Implement JUnit report output mode. - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6672

1 0

Re: [PATCH v3 0/3] MR6673: d3dx9: Move targa decoding into d3dx9, part 1. - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6673

1 0

Re: [PATCH v3 0/1] MR6620: comctl32: Implement WM_GETOBJECT for buttons. - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6620

1 0

Re: [PATCH v2 0/1] MR6684: win32u: Avoid crashing when creating a new layered window surface. - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6684

1 0

Re: [PATCH v2 0/1] MR6683: win32u: Use parent-relative coordinates for old window rectangles. - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6683

1 0

Re: [PATCH v4 0/1] MR6648: winex11: Properly handle minimized windows in update_net_wm_fullscreen_monitors(). - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6648

1 0

Re: [PATCH v3 0/6] MR6682: winex11: More drag'n'drop PE side code cleanup. - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6682

1 0

Re: [PATCH v2 0/1] MR6669: windowscodecs: Implement 48bppRGB -> 64bppRGBA conversion. - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6669

1 0

[PATCH 0/1] MR6238: comdlg32: Add `const' qualifier
by Ruslan Garipov (＠ruslangaripov) 16 Oct '24

16 Oct '24

No functional changes intended. Please, review. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6238

4 5

[PATCH v2 0/4] MR6602: win32u: Always launch explorer for the desktop with a default token.
by Tim Clem (＠tclem) 16 Oct '24

16 Oct '24

Testing on Windows shows that the owner of GetDesktopWindow() always has a default admin token with `TokenElevationTypeDefault`, no matter the token of the process/thread that is responsible for creating it. We've had issues in this area in the past - 99e2fad1 was a case where it was important that explorer not inherit the token of the *process* spawning it, but instead the token of the *thread*. This patch keeps that app working, since now explorer will get a default token regardless. In addition to the privilege issues from 99e2fad1, it is a relatively common pattern to duplicate the token of the owner of GetDesktopWindow to acquire a default token. -- v2: services: Apply a default admin token to the process. ntdll: Count default-elevation admin tokens as elevated from NtQueryInformationToken(TokenElevation). Revert "win32u: Create explorer with the thread effective access token." explorer: Apply a default admin token when running for the desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/6602

3 6

[PATCH v2 0/3] MR6673: d3dx9: Move targa decoding into d3dx9, part 1.
by Connor McAdams (＠cmcadams) 16 Oct '24

16 Oct '24

This is the first set of patches to move targa decoding out of WIC and into d3dx9. The eventual goal is to add support for saving targa files. I've pushed a branch with the rest of the patches for decoding the image [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/WIP/d3dx9-targa-decode… if extra context would help. I split this into two parts to make review a little less overwhelming. :) -- v2: d3dx9: Use d3dx9 to get image information for targa files. d3dx9/tests: Add TGA header image info tests. d3dx9: Do not use WIC to detect image file format. https://gitlab.winehq.org/wine/wine/-/merge_requests/6673

4 9

[PATCH 0/1] MR6674: xml2: Import upstream release 2.12.8.
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6674

4 10

[PATCH 0/3] MR6673: d3dx9: Move targa decoding into d3dx9, part 1.
by Connor McAdams (＠cmcadams) 16 Oct '24

16 Oct '24

This is the first set of patches to move targa decoding out of WIC and into d3dx9. The eventual goal is to add support for saving targa files. I've pushed a branch with the rest of the patches for decoding the image [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/WIP/d3dx9-targa-decode… if extra context would help. I split this into two parts to make review a little less overwhelming. :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6673

3 15

[PATCH 0/1] MR6684: win32u: Avoid crashing when creating a new layered window surface.
by Rémi Bernon (＠rbernon) 16 Oct '24

16 Oct '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57311 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6684

2 1

[PATCH v2 0/7] MR6672: winetest: Implement JUnit report output mode.
by Rémi Bernon (＠rbernon) 16 Oct '24

16 Oct '24

For Gitlab to detect and report the failing tests directly on the MR front page. This has the disadvantage of making the test job output more silent, but the results are still available as artifacts (in JUnit XML format), which hopefully should be enough if we need to have a better look at it. The tests standard output is included in the reports too. I believe it would also show some failure statistics that could help deciding on whether a test is regularly failing or not, but I wasn't able to really test that it does. In order to help it doing it, it also implements hashing of test sources to generate test IDs that are more stable than `source:line`, although it could be done later. All the succeeding (and todo) tests are grouped together and reported as once, as they would otherwise be split into individual success lines in the Gitlab UI, which would make it unnecessary large. Only failures and skipped tests are reported as individual entries. -- v2: gitlab: Use winetest JUnit output mode. winetest: Implement JUnit report output mode. winetest: Introduce some test report helpers. winetest: Pass output file handle to xprintf. winetest: Always use a temporary file for test output. winetest: Add printf attributes to xprintf. winetest: Add printf attributes to strmake. https://gitlab.winehq.org/wine/wine/-/merge_requests/6672

2 8

[PATCH 0/3] MR6680: msvcp140: Use current locale to convert path in _Fiopen.
by Daniel Lehman (＠dlehman25) 16 Oct '24

16 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6680

4 5

[PATCH v2 0/1] MR6620: comctl32: Implement WM_GETOBJECT for buttons.
by Esme Povirk (＠madewokherd) 16 Oct '24

16 Oct '24

-- v2: comctl32: Implement WM_GETOBJECT for buttons. https://gitlab.winehq.org/wine/wine/-/merge_requests/6620

5 5

[PATCH 0/1] MR6683: win32u: Use parent-relative coordinates for old window rectangles.
by Rémi Bernon (＠rbernon) 16 Oct '24

16 Oct '24

Since 4e06b87633ec7e04822ad4f4854df7ae43f0d7e0, we are moving the window rects, which is in screen coordinates for the old rects, because invalidate_dce expects it, but in parent coordinates for the new rects. This makes the old and new rectangles to be consistently using parent-relative coordinates, fixing some broken window bits copy with child windows. Fixes 4e06b87633ec7e04822ad4f4854df7ae43f0d7e0 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6683

2 1

Re: [PATCH v2 0/17] MR4332: Remove DECLSPEC_HIDDEN usage from various DLL's.
by Alistair Leslie-Hughes (＠alesliehughes) 16 Oct '24

16 Oct '24

Since the DLLs are now real windows dll, the attribute not is required. This attribute stopped these private functions from being exposed in the Unix libraries. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4332#note_85119

1 0

[PATCH v3 0/1] MR6648: winex11: Properly handle minimized windows in update_net_wm_fullscreen_monitors().
by Aida Jonikienė (＠DodoGTA) 16 Oct '24

16 Oct '24

This prevents a "Failed to get xinerama fullscreen monitor indices." error when minimizing a fullscreen window. -- v3: winex11: Properly handle minimized windows in update_net_wm_fullscreen_monitors(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6648

3 3

Re: [PATCH v2 0/17] MR4332: Remove DECLSPEC_HIDDEN usage from various DLL's.
by David Kahurani (＠ReDress) 16 Oct '24

16 Oct '24

When you bring up issues on MRs that already gotten merged, that really isn't very nice -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4332#note_85116

1 0

Re: [PATCH v2 0/17] MR4332: Remove DECLSPEC_HIDDEN usage from various DLL's.
by Ruslan Garipov (＠ruslangaripov) 16 Oct '24

16 Oct '24

@alesliehughes Sorry for bothering, but could you please explain a motivation behind this and next similar patches/requests removing the `DECLSPEC_HIDDEN` attribute from functions? I just can't understand why they exist. And no Wine-related mailing list gave me an answer... Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4332#note_85109

1 0

[PATCH v2 0/1] MR6648: winex11: Properly handle minimized windows in update_net_wm_fullscreen_monitors().
by Aida Jonikienė (＠DodoGTA) 16 Oct '24

16 Oct '24

This prevents a "Failed to get xinerama fullscreen monitor indices." error when minimizing a fullscreen window. -- v2: winex11: Properly handle minimized windows in update_net_wm_fullscreen_monitors(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6648

3 3

[PATCH v2 0/6] MR6682: winex11: More drag'n'drop PE side code cleanup.
by Rémi Bernon (＠rbernon) 16 Oct '24

16 Oct '24

-- v2: winex11: Get rid of X11DRV_XDND_HasHDROP helper. winex11: Use a custom IEnumFORMATETC interface implementation. winex11: Clear the XDND data object on drop event. winex11: Get rid of X11DRV_XDND_SendDropFiles helper. winex11: Assume that PostMessageW WM_DROPFILES succeeds. winex11: Only enter the CS to get a reference on the data object. https://gitlab.winehq.org/wine/wine/-/merge_requests/6682

2 6

[PATCH 0/6] MR6682: winex11: More drag'n'drop PE side code cleanup.
by Rémi Bernon (＠rbernon) 16 Oct '24

16 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6682

2 6

[PATCH 0/1] MR6669: windowscodecs: Implement 48bppRGB -> 64bppRGBA conversion.
by Paul Gofman (＠gofman) 15 Oct '24

15 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6669

3 3

Re: [PATCH v3 0/1] MR6676: conhost: Start input thread in IOCTL_CONDRV_GET_INPUT_INFO ioctl. - approved
by Alexandre Julliard (＠julliard) 15 Oct '24

15 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6676

1 0

Re: [PATCH v2 0/1] MR6677: advapi32: Don't trace password in CreateProcessWithLogonW stub. - approved
by Alexandre Julliard (＠julliard) 15 Oct '24

15 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6677

1 0

Re: [PATCH v2 0/3] MR6675: win32u: Adjust the valid rects to handle visible rect changes when moving surface bits. - approved
by Alexandre Julliard (＠julliard) 15 Oct '24

15 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6675

1 0

Re: [PATCH v3 0/6] MR6671: winex11: Initial refactoring of XDND code. - approved
by Alexandre Julliard (＠julliard) 15 Oct '24

15 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6671

1 0

Re: [PATCH v2 0/1] MR6667: explorer: Support the NoDesktop registry setting. - approved
by Alexandre Julliard (＠julliard) 15 Oct '24

15 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6667

1 0

Re: [PATCH v2 0/1] MR6665: winebus: Allow any free device index to be reused immediately. - approved
by Alexandre Julliard (＠julliard) 15 Oct '24

15 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6665

1 0

Re: [PATCH v2 0/5] MR6670: dplayx: CreatePlayer() part 1. - approved
by Alexandre Julliard (＠julliard) 15 Oct '24

15 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6670

1 0

[PATCH 0/6] MR6672: winetest: Implement JUnit report output mode.
by Rémi Bernon (＠rbernon) 15 Oct '24

15 Oct '24

For Gitlab to detect and report the failing tests directly on the MR front page. This has the disadvantage of making the test job output more silent, but the results are still available as artifacts (in JUnit XML format), which hopefully should be enough if we need to have a better look at it. The tests standard output is included in the reports too. I believe it would also show some failure statistics that could help deciding on whether a test is regularly failing or not, but I wasn't able to really test that it does. In order to help it doing it, it also implements hashing of test sources to generate test IDs that are more stable than `source:line`, although it could be done later. All the succeeding (and todo) tests are grouped together and reported as once, as they would otherwise be split into individual success lines in the Gitlab UI, which would make it unnecessary large. Only failures and skipped tests are reported as individual entries. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6672

3 9

[PATCH v2 0/1] MR6676: conhost: Start input thread in IOCTL_CONDRV_GET_INPUT_INFO ioctl.
by Piotr Caban (＠piotr) 15 Oct '24

15 Oct '24

-- v2: conhost: Start input thread for GetNumberOfConsoleInputEvents. https://gitlab.winehq.org/wine/wine/-/merge_requests/6676

2 2

[PATCH v5 0/2] MR6553: ntdll: make GetDriveType prioritize mount managers' config
by Robert Ayrapetyan (＠rayrapetyan) 15 Oct '24

15 Oct '24

The current implementation of the GetDriveTypeW/A function relies on native system calls (such as fstatfs() in Linux) to determine the actual type of the drive, disregarding any configuration set through the mounts manager (wincfg). This patch changes the priority, giving precedence to the mounts manager configuration, making the user responsible for mapping drives. System calls will only be used if the drive is not explicitly configured by the user. I acknowledge that this is a breaking change, but I believe it enforces the correct behavior for GetDriveType. Resolves: https://forum.winehq.org/viewtopic.php?t=38909 -- v5: fix: support custom cdrom labels https://gitlab.winehq.org/wine/wine/-/merge_requests/6553

2 2

[PATCH 0/1] MR6676: conhost: Start input thread in IOCTL_CONDRV_GET_INPUT_INFO ioctl.
by Piotr Caban (＠piotr) 15 Oct '24

15 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6676

4 4

[PATCH 0/1] MR6677: advapi32: Don't trace password in CreateProcessWithLogonW stub.
by Piotr Caban (＠piotr) 15 Oct '24

15 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6677

2 1

[PATCH 0/3] MR6675: win32u: Adjust the valid rects to handle visible rect changes when moving surface bits.
by Rémi Bernon (＠rbernon) 15 Oct '24

15 Oct '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57302 The blamed commit in the bug isn't the right one, but it indeed triggers a regression because the increased window surface rounding value prevents the surface from being recreated, and the move_window_bits code path is then used instead of move_window_bits_surface. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6675

2 3

[PATCH v3 0/1] MR6661: winegstreamer: Use wmaversion = 4 for MFAudioFormat_WMAudio_Lossless.
by Rémi Bernon (＠rbernon) 15 Oct '24

15 Oct '24

Patch by Attila Fidan. Fixes: 9192b3b724d90788f7a1682b3f9eedb7bf363e22 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57294 -- v3: winegstreamer: Use wmaversion = 4 for MFAudioFormat_WMAudio_Lossless. https://gitlab.winehq.org/wine/wine/-/merge_requests/6661

2 1

[PATCH v2 0/6] MR6671: winex11: Initial refactoring of XDND code.
by Rémi Bernon (＠rbernon) 15 Oct '24

15 Oct '24

In preparation for moving the PE side DND code to win32u/user32 and factoring it between drivers. -- v2: winex11: Allocate the XDND data object dynamically. winex11: Use IDataObject to get CF_HDROP format for WM_DROPFILES. winex11: Cleanup variable names in X11DRV_XDND_SendDropFiles. winex11: Use the IDataObject interface to check for CF_HDROP format. winex11: Cleanup XDND IDataObject methods and variables. winex11: Move the XDND IDataObject implementation around. https://gitlab.winehq.org/wine/wine/-/merge_requests/6671

2 6

[PATCH 0/6] MR6671: winex11: Initial refactoring of XDND code.
by Rémi Bernon (＠rbernon) 15 Oct '24

15 Oct '24

In preparation for moving the PE side DND code to win32u/user32 and factoring it between drivers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6671

2 6

[PATCH 0/1] MR6667: explorer: Support the NoDesktop registry setting.
by Alex Henrie (＠alexhenrie) 15 Oct '24

15 Oct '24

Setting NoDesktop to a nonzero value hides all desktop icons on Windows. (It also disables the context menu on the desktop, but since Wine doesn't have one, that doesn't matter.) Supporting the same option on Wine would be useful in controlled environments that have a virtual desktop but the user is not supposed to interact with it. Strangely, although HKCU overrides HKLM for NoTrayItemsDisplay on Windows, the reverse is true of NoDesktop. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6667

4 3

[PATCH 0/1] MR6665: winebus: Allow any free device index to be reused immediately.
by Alex Henrie (＠alexhenrie) 15 Oct '24

15 Oct '24

Cars: Mater National Championship expects that when two identical controllers are connected and then the first controller is unplugged and plugged back in, it gets the same device index that it had before. If it gets a different index, the controller does not work until the game is restarted. As it stands without this patch, when the last device in the list is unplugged, its index becomes available for reuse, but if the last device is never unplugged, none of the indexes of the other devices formerly in the list can be reused. It doesn't make sense to make all index reuse depend on the last device. Instead, let's keep the device list sorted by index and reuse any free index immediately. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6665

4 3

[PATCH 0/1] MR5276: musl: Fix limiting the float precision in intermediates.
by Martin Storsjö (＠mstorsjo) 15 Oct '24

15 Oct '24

musl itself expects to be configured to compile with either -ffloat-store or -fexcess-precision=standard - but when imported into Wine, those flags aren't used. This seems to be essential for getting reasonable precision from some math functions such as exp2() - without the expected precision truncation, the output value of exp2() can be off by as much as 0.2% in some cases. As Wine doesn't build the musl sources with those flags, use volatile to force storing/reloading floats in order to limit their intermediate precision, as musl expects. Only do this on i386 where this is known be required. This fixes https://bugs.winehq.org/show_bug.cgi?id=56372. Apparently this issue only appears when compiled with GCC; with Clang, this already works as expected. Signed-off-by: Martin Storsjö <martin(a)martin.st> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5276

4 6

[PATCH 0/5] MR6670: dplayx: CreatePlayer() part 1.
by Anton Baskanov (＠baskanov) 15 Oct '24

15 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6670

4 7

Re: [PATCH v2 0/6] MR6659: dplayx: ADDFORWARD handling. - approved
by Alexandre Julliard (＠julliard) 14 Oct '24

14 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6659

1 0

Re: [PATCH v2 0/1] MR6664: mshtml: Make sure disp_invoke is called before locking the document mode. - approved
by Alexandre Julliard (＠julliard) 14 Oct '24

14 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6664

1 0

Re: [PATCH v2 0/1] MR6668: musl: Fix limiting the float precision in intermediates. - approved
by Alexandre Julliard (＠julliard) 14 Oct '24

14 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6668

1 0

Re: [PATCH v2 0/1] MR6660: winedmo: Check and guard libavcodec/bsf.h inclusion. - approved
by Alexandre Julliard (＠julliard) 14 Oct '24

14 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6660

1 0

Re: [PATCH v3 0/5] MR6653: d3dx9: More DDS pixel format handling changes. - approved
by Alexandre Julliard (＠julliard) 14 Oct '24

14 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6653

1 0

[PATCH 0/6] MR6659: dplayx: ADDFORWARD handling.
by Anton Baskanov (＠baskanov) 14 Oct '24

14 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6659

4 8

[PATCH 0/1] MR6668: musl: Fix limiting the float precision in intermediates.
by Piotr Caban (＠piotr) 14 Oct '24

14 Oct '24

I'm not sure if it's the best way of fixing the bug. I was trying to set compilation options to workaround the problem but it didn't work well (probably due to my limited knowledge in this area). The patch was originally sent in !5276. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6668

3 3

[PATCH 0/1] MR6664: mshtml: Make sure disp_invoke is called before locking the document mode.
by Gabriel Ivăncescu (＠insn) 14 Oct '24

14 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6664

3 4

[PATCH 0/1] MR6648: winex11: Properly handle minimized windows in xinerama_get_fullscreen_monitors().
by Aida Jonikienė (＠DodoGTA) 14 Oct '24

14 Oct '24

This prevents a "Failed to get xinerama fullscreen monitor indices." error when minimizing a fullscreen window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6648

3 3

[PATCH v2 0/5] MR6653: d3dx9: More DDS pixel format handling changes.
by Connor McAdams (＠cmcadams) 14 Oct '24

14 Oct '24

This is my last set of patches changing DDS pixel format handling. -- v2: d3dx9: Add support for more DDS pixel formats. d3dx9: Rework conversion to/from D3DFORMAT from/to DDS pixel format. d3dx9: Validate the size of DDS files containing packed pixel formats. d3dx9/tests: Add file size validation tests for DDS files containing packed pixel formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/6653

2 6

[PATCH v7 0/8] MR6649: Draft: winex11: Replace foreign windows with a driver-only host window tracking.
by Rémi Bernon (＠rbernon) 14 Oct '24

14 Oct '24

Making all the windows handled by the driver to be either GL/VK client surfaces, or top-level windows. This avoids leaking host windows into the Win32 space, and makes it possible to get rid of some remaining NtUserMapWindowPoints in `map_event_coords` for mouse input. -- v7: winex11: Get rid of the now unnecessary foreign windows. winex11: Generate relative ConfigureNotify on parent ConfigureNotify events. winex11: Use the new host windows to register foreign window events. winex11: Keep track of the host windows children window rects. winex11: Keep track of the host windows relative rects. winex11: Keep track of the host window children of interest. winex11: Create host windows recursively up to root_window. winex11: Introduce a new struct host_window for host-only windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/6649

2 9

[PATCH v2 0/1] MR6662: win32u/zibdrv: Round get_arc_max_points() value to a multiple of 4.
by Aida Jonikienė (＠DodoGTA) 13 Oct '24

13 Oct '24

This seems like a weird solution to me (so I'm not sure if the tests pass) -- v2: win32u/dibdrv: Round get_arc_max_points() value to a multiple of 4. https://gitlab.winehq.org/wine/wine/-/merge_requests/6662

3 4

[PATCH v12 0/9] MR6621: winebth.sys part 1: Introduce Bluetooth driver.
by Vibhav Pant (＠vibhavp) 13 Oct '24

13 Oct '24

This MR is the first of multiples MRs adding support for the Bluetooth stack API in Wine: 1. The winebth.sys driver, which talks to BlueZ and implements several key IOCTLs for communicating with Bluetooth devices and radios. 2. A bthserv service, which is responsible for keeping track of the authentication agent, and relaying authentication requests and responses to and from the driver. 3. Userspace APIs (bluetoothapis.dll, bthprops.cpl, Windows.Devices.Bluetooth, etc). winebth.sys is split into two "sub" drivers: `winebth.sys`: The main entrypoint, loaded by winedevice. It listens for changes to Bluetooth devices and radios and authentication events on BlueZ, passing them on the bthenum. It also handles most IOCTL operations on Bluetooth radio PDOs. `bthenum`: Responsible for creating nodes for discovered Bluetooth devices and associated services. It also tries to validate any IOCTLs relating to bluetooth devices before passing them to winebth.sys. (Not in this MR, likely in part 2) The unix code is split between dbus.c, unixlib.c and winebluetooth.c, where winebluetooth is a simple wrapper around unixlib for the sake of organization. -- v12: dlls/winebth.sys: Update radio PDO properties on receiving PropertiesChanged for an org.bluez.Adapter1 object. dlls/winebth.sys: Remove the corresponding radio PDO on receiving InterfacesRemoved for a org.bluez.Adapter1 object. dlls/winebth.sys: Create new radio PDOs on receiving InterfacesAdded for objects that implement org.bluez.Adapter1. dlls/winebth.sys: Set radio PDO properties from the device's corresponding org.bluez.Adapter1 object properties. dlls/winebth.sys: Register and enable BTHPORT_DEVICE and BLUETOOTH_RADIO interfaces for radio PDOs. dlls/winebth.sys: Derive a unique hardware ID for radio PDOs from their corresponding BlueZ object path. dlls/winebth.sys: Create radio PDOs from the list of org.bluez.Adapter1 objects on BlueZ. dlls/winebth.sys: Add a basic unixlib stub using DBus. dlls/winebth.sys: Add base winebth.sys driver. https://gitlab.winehq.org/wine/wine/-/merge_requests/6621

3 11

[PATCH v13 0/9] MR6621: winebth.sys part 1: Introduce Bluetooth driver.
by Vibhav Pant (＠vibhavp) 13 Oct '24

13 Oct '24

This MR is the first of multiples MRs adding support for the Bluetooth stack API in Wine: 1. The winebth.sys driver, which talks to BlueZ and implements several key IOCTLs for communicating with Bluetooth devices and radios. 2. A bthserv service, which is responsible for keeping track of the authentication agent, and relaying authentication requests and responses to and from the driver. 3. Userspace APIs (bluetoothapis.dll, bthprops.cpl, Windows.Devices.Bluetooth, etc). winebth.sys is split into two "sub" drivers: `winebth.sys`: The main entrypoint, loaded by winedevice. It listens for changes to Bluetooth devices and radios and authentication events on BlueZ, passing them on the bthenum. It also handles most IOCTL operations on Bluetooth radio PDOs. `bthenum`: Responsible for creating nodes for discovered Bluetooth devices and associated services. It also tries to validate any IOCTLs relating to bluetooth devices before passing them to winebth.sys. (Not in this MR, likely in part 2) The unix code is split between dbus.c, unixlib.c and winebluetooth.c, where winebluetooth is a simple wrapper around unixlib for the sake of organization. -- v13: dlls/winebth.sys: Update radio PDO properties on receiving PropertiesChanged for an org.bluez.Adapter1 object. dlls/winebth.sys: Remove the corresponding radio PDO on receiving InterfacesRemoved for a org.bluez.Adapter1 object. dlls/winebth.sys: Create new radio PDOs on receiving InterfacesAdded for objects that implement org.bluez.Adapter1. dlls/winebth.sys: Set radio PDO properties from the device's corresponding org.bluez.Adapter1 object properties. dlls/winebth.sys: Register and enable BTHPORT_DEVICE and BLUETOOTH_RADIO interfaces for radio PDOs. dlls/winebth.sys: Derive a unique hardware ID for radio PDOs from their corresponding BlueZ object path. dlls/winebth.sys: Create radio PDOs from the list of org.bluez.Adapter1 objects on BlueZ. https://gitlab.winehq.org/wine/wine/-/merge_requests/6621

2 9

[PATCH 0/1] MR6662: win32u/zibdrv: Round get_arc_max_points() value to a multiple of 4.
by Aida Jonikienė (＠DodoGTA) 13 Oct '24

13 Oct '24

This seems like a weird solution to me (so I'm not sure if the tests pass) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6662

3 3

Re: [PATCH v44 0/7] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Vijay Kiran Kamuju (＠infyquest) 13 Oct '24

13 Oct '24

Any updates on this series? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_84854

1 0

[PATCH v11 0/30] MR6621: winebth.sys: Introduce Bluetooth driver.
by Vibhav Pant (＠vibhavp) 13 Oct '24

13 Oct '24

This MR is the first of at least three MRs adding support for the Bluetooth stack API in Wine: 1. The winebth.sys driver, which talks to BlueZ and implements several key IOCTLs for communicating with Bluetooth devices and radios. 2. A bthserv service, which is responsible for keeping track of the authentication agent, and relaying authentication requests and responses to and from the driver. 3. Userspace APIs (bluetoothapis.dll, bthprops.cpl, Windows.Devices.Bluetooth, etc). winebth.sys is split into two "sub" drivers: `winebth.sys`: The main entrypoint, loaded by winedevice. It listens for changes to Bluetooth devices and radios and authentication events on BlueZ, passing them on the bthenum. It also handles most IOCTL operations on Bluetooth radio PDOs. `bthenum`: Responsible for creating nodes for discovered Bluetooth devices and associated services. It also tries to validate any IOCTLs relating to bluetooth devices before passing them to winebth.sys. The unix code is split between dbus.c, unixlib.c and winebluetooth.c, where winebluetooth is a simple wrapper around unixlib for the sake of organization. -- v11: dlls/winebth.sys: Implement IOCTL_WINEBTH_DEVICE_START_PAIR. dlls/winebth.sys: Implement IOCTL command IOCTL_BTH_DISCONNECT_DEVICE. dlls/winebth.sys: Add support for RequestAuthorization requests from BlueZ. dlls/winebth.sys: Add support for RequestPasskey requests from BlueZ. dlls/winebth.sys: Add support for DisplayPasskey requests from BlueZ. dlls/winebth.sys: Add support for AuthorizeService requests from BlueZ. dlls/winebth.sys: Add support for DisplayPinCode requests from BlueZ. dlls/winebth.sys: Add support for RequestPinCode requests from BlueZ. dlls/winebth.sys: Add support for RequestConfirmation requests from BlueZ. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6621

2 1

[PATCH v10 0/1] MR5523: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW().
by Vijay Kiran Kamuju (＠infyquest) 12 Oct '24

12 Oct '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56007 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56576 -- v10: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5523

2 1

Re: [PATCH v6 0/1] MR5357: d3dcompiler: Add D3DX11CreateThreadPump stub.
by Vijay Kiran Kamuju (＠infyquest) 12 Oct '24

12 Oct '24

On Thu Mar 21 07:01:57 2024 +0000, Vijay Kiran Kamuju wrote: > I will initially only add the ID3X11ThreadPump interface stubs and the > D3DX11CreateThreadPump function, so that once the common code steps are > further advanced, we can fill in the interface functions. Have not seen the unification work, except for the pixel format changes. Is there more work done in proton tree? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5357#note_84832

1 0

Re: [PATCH v2 0/7] MR5930: win32u: Factor surface rect computation out of the drivers.
by Fabian Maurer (＠DarkShadow44) 12 Oct '24

12 Oct '24

This created a regression, see https://bugs.winehq.org/show_bug.cgi?id=57302 Could you please take a look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5930#note_84830

1 0

[PATCH 0/1] MR6661: winegstreamer: Use wmaversion = 4 for MFAudioFormat_WMAudio_Lossless.
by Rémi Bernon (＠rbernon) 12 Oct '24

12 Oct '24

Patch by Attila Fidan. Fixes: 9192b3b724d90788f7a1682b3f9eedb7bf363e22 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57294 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6661

3 2

[PATCH 0/1] MR6660: winedmo: Check and guard libavcodec/bsf.h inclusion.
by Rémi Bernon (＠rbernon) 12 Oct '24

12 Oct '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57269 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6660

2 1

[PATCH v6 0/8] MR6649: Draft: winex11: Replace foreign windows with a driver-only host window tracking.
by Rémi Bernon (＠rbernon) 12 Oct '24

12 Oct '24

Making all the windows handled by the driver to be either GL/VK client surfaces, or top-level windows. This avoids leaking host windows into the Win32 space, and makes it possible to get rid of some remaining NtUserMapWindowPoints in `map_event_coords` for mouse input. -- v6: winex11: Get rid of the now unnecessary foreign windows. winex11: Generate relative ConfigureNotify on parent ConfigureNotify events. winex11: Use the new host windows to register foreign window events. winex11: Keep track of the host windows children window rects. winex11: Keep track of the host windows relative rects. winex11: Keep track of the host window children of interest. winex11: Create host windows recursively up to root_window. winex11: Introduce a new struct host_window for host-only windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/6649

2 8

[PATCH 0/5] MR6653: d3dx9: More DDS pixel format handling changes.
by Connor McAdams (＠cmcadams) 12 Oct '24

12 Oct '24

This is my last set of patches changing DDS pixel format handling. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6653

4 9

Re: [PATCH v2 0/6] MR6594: include: Add Windows.ApplicationModel.DesignMode runtime class.
by Zhiyi Zhang (＠zhiyi) 12 Oct '24

12 Oct '24

On Sat Oct 12 05:37:25 2024 +0000, Biswapriyo Nath wrote: > This line caused an issue in downstream projects, see > https://github.com/msys2/MINGW-packages/issues/22160. Would you like to > look into that? I am not sure if that is expected. I don't think this is a bug in Wine. Native headers have both `Windows.Foundation.IReference<BYTE>` and `Windows.Foundation.IReference<boolean>` and no conflicts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6594#note_84816

1 0

Re: [PATCH v2 0/6] MR6594: include: Add Windows.ApplicationModel.DesignMode runtime class.
by Biswapriyo Nath (＠Biswa96) 12 Oct '24

12 Oct '24

Biswapriyo Nath (@Biswa96) commented about include/windows.foundation.idl: > interface Windows.Foundation.IReference<BYTE>; > - interface Windows.Foundation.IReference<INT32>; > interface Windows.Foundation.IReference<DOUBLE>; > interface Windows.Foundation.IReference<FLOAT>; > + interface Windows.Foundation.IReference<GUID>; > + interface Windows.Foundation.IReference<INT16>; > + interface Windows.Foundation.IReference<INT32>; > + interface Windows.Foundation.IReference<INT64>; > interface Windows.Foundation.IReference<UINT32>; > interface Windows.Foundation.IReference<UINT64>; > interface Windows.Foundation.IReference<Windows.Foundation.DateTime>; > + interface Windows.Foundation.IReference<Windows.Foundation.Point>; > + interface Windows.Foundation.IReference<Windows.Foundation.Rect>; > + interface Windows.Foundation.IReference<Windows.Foundation.Size>; > + interface Windows.Foundation.IReference<Windows.Foundation.TimeSpan>; > + interface Windows.Foundation.IReference<boolean>; This line caused an issue in downstream projects, see https://github.com/msys2/MINGW-packages/issues/22160. Would you like to look into that? I am not sure if that is expected. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6594#note_84815

1 0

Re: [PATCH v3 0/24] MR6651: Create occitan translation
by Aida Jonikienė (＠DodoGTA) 12 Oct '24

12 Oct '24

If you have trouble using `git`, then worst case I can make a new MR with the squashed commits (but you should consider reading the Git documentation first: https://git-scm.com/book) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6651#note_84814

1 0

Re: [PATCH v3 0/2] MR6581: win32u: Implement drawing transformed arcs.
by Fabian Maurer (＠DarkShadow44) 11 Oct '24

11 Oct '24

This created a regression: https://bugs.winehq.org/show_bug.cgi?id=57296 Would you mind taking a look? (I'd just add you on CC in bugzilla, but I'm unable to). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6581#note_84807

1 0

Re: [PATCH v3 0/2] MR6657: comdlg32: Fix buffer overflow when current_filter is longer than MAX_PATH. - approved
by Alexandre Julliard (＠julliard) 11 Oct '24

11 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6657

1 0

Re: [PATCH v4 0/1] MR6656: win32u: Avoid leaking window data on thread detach. - approved
by Alexandre Julliard (＠julliard) 11 Oct '24

11 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6656

1 0

Re: [PATCH v4 0/1] MR6644: msvcrt: Initialize locale data in new threads. - approved
by Alexandre Julliard (＠julliard) 11 Oct '24

11 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6644

1 0

Re: [PATCH v3 0/1] MR6646: dplayx/tests: Correct Enum tests. - approved
by Alexandre Julliard (＠julliard) 11 Oct '24

11 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6646

1 0

Re: [PATCH v2 0/1] MR6652: msvcp90/tests: Add tests for int in num_put. - approved
by Alexandre Julliard (＠julliard) 11 Oct '24

11 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6652

1 0

[PATCH v2 0/24] MR6651: Create occitan translation
by joan-lucì Labòrda (＠joanluc) 11 Oct '24

11 Oct '24

Create occitan translation - add documentation/README-oc.md - add po/oc.po - update po/Makefile.in adding line ' oc.po \' -- v2: Update README-oc.md This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6651

4 5

[PATCH v5 0/8] MR6649: Draft: winex11: Replace foreign windows with a driver-only host window tracking.
by Rémi Bernon (＠rbernon) 11 Oct '24

11 Oct '24

Making all the windows handled by the driver to be either GL/VK client surfaces, or top-level windows. This avoids leaking host windows into the Win32 space, and makes it possible to get rid of some remaining NtUserMapWindowPoints in `map_event_coords` for mouse input. -- v5: winex11: Get rid of the now unnecessary foreign windows. winex11: Generate relative ConfigureNotify on parent ConfigureNotify events. winex11: Use the new host windows to register foreign window events. winex11: Keep track of the host windows children window rects. winex11: Keep track of the host windows relative rects. winex11: Keep track of the host window children of interest. winex11: Create host windows recursively up to root_window. winex11: Introduce a new struct host_window for host-only windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/6649

2 9

[PATCH v2 0/2] MR6657: comdlg32: Fix buffer overflow when current_filter is longer than MAX_PATH.
by Charlotte Pabst (＠CharlottePabst) 11 Oct '24

11 Oct '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57293 Without this change, the tests segfault due to a buffer overflow. Note: This bug was surfaced but not caused by b5cbb5562ca1aaf023a588bdc6ccb89220637fc4. Before b5cbb5562ca1aaf023a588bdc6ccb89220637fc4, the savedlg test segfaults while the opendlg test does not. After it, both segfault. -- v2: comdlg32/tests: Add tests for itemdlg filters longer than MAX_PATH. https://gitlab.winehq.org/wine/wine/-/merge_requests/6657

3 3

[PATCH v3 0/1] MR6656: win32u: Avoid leaking window data on thread detach.
by Rémi Bernon (＠rbernon) 11 Oct '24

11 Oct '24

Should help https://gitlab.winehq.org/wine/wine/-/merge_requests/6649 as well, to avoid leaking parent window either. -- v3: win32u: Notify the drivers of destroyed windows on thread detach. https://gitlab.winehq.org/wine/wine/-/merge_requests/6656

2 2

[PATCH v3 0/1] MR6644: Draft: msvcrt: Initialize locale data in new threads.
by Bernhard Übelacker (＠bernhardu) 11 Oct '24

11 Oct '24

This attempts to initialize the thread data more like in the mainthread, which does in msvcrt_init_locale a call to _setmbcp, which finally fills the cached_locale member of the thread data. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57250 -- v3: msvcrt: Initialize locale data in new threads. https://gitlab.winehq.org/wine/wine/-/merge_requests/6644

3 6

[PATCH v2 0/2] MR6656: winex11: Avoid leaking window data on thread detach.
by Rémi Bernon (＠rbernon) 11 Oct '24

11 Oct '24

Should help https://gitlab.winehq.org/wine/wine/-/merge_requests/6649 as well, to avoid leaking parent window either. -- v2: winex11: Avoid leaking window data on thread detach. winex11: Destroy the window data outside of the global window lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/6656

2 4

[PATCH v4 0/8] MR6649: Draft: winex11: Replace foreign windows with a driver-only host window tracking.
by Rémi Bernon (＠rbernon) 11 Oct '24

11 Oct '24

Making all the windows handled by the driver to be either GL/VK client surfaces, or top-level windows. This avoids leaking host windows into the Win32 space, and makes it possible to get rid of some remaining NtUserMapWindowPoints in `map_event_coords` for mouse input. -- v4: winex11: Get rid of the now unnecessary foreign windows. winex11: Generate relative ConfigureNotify on parent ConfigureNotify events. winex11: Use the new host windows to register foreign window events. winex11: Keep track of the host windows children window rects. winex11: Keep track of the host windows relative rects. winex11: Keep track of the host window children of interest. winex11: Create host windows recursively up to root_window. winex11: Introduce a new struct host_window for host-only windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/6649

2 8

[PATCH 0/1] MR6652: msvcp90/tests: Add tests for int in num_put.
by Daniel Lehman (＠dlehman25) 11 Oct '24

11 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6652

3 2

[PATCH 0/1] MR6654: d3dx11: Add D3DX11CreateThreadPump() stub.
by Aida Jonikienė (＠DodoGTA) 11 Oct '24

11 Oct '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56176 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6654

2 3

[PATCH v3 0/8] MR6649: Draft: winex11: Replace foreign windows with a driver-only host window tracking.
by Rémi Bernon (＠rbernon) 11 Oct '24

11 Oct '24

Making all the windows handled by the driver to be either GL/VK client surfaces, or top-level windows. This avoids leaking host windows into the Win32 space, and makes it possible to get rid of some remaining NtUserMapWindowPoints in `map_event_coords` for mouse input. -- v3: winex11: Get rid of the now unnecessary foreign windows. winex11: Generate relative ConfigureNotify on parent ConfigureNotify events. winex11: Use the new host windows to register foreign window events. winex11: Keep track of the host windows children window rects. winex11: Keep track of the host windows relative rects. winex11: Keep track of the host window children of interest. winex11: Create host windows recursively up to root_window. winex11: Introduce a new struct host_window for host-only windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/6649

2 10

[PATCH v2 0/8] MR6649: Draft: winex11: Replace foreign windows with a driver-only host window tracking.
by Rémi Bernon (＠rbernon) 11 Oct '24

11 Oct '24

Making all the windows handled by the driver to be either GL/VK client surfaces, or top-level windows. This avoids leaking host windows into the Win32 space, and makes it possible to get rid of some remaining NtUserMapWindowPoints in `map_event_coords` for mouse input. -- v2: winex11: Get rid of the now unnecessary foreign windows. winex11: Generate relative ConfigureNotify on parent ConfigureNotify events. winex11: Use the new host windows to register foreign window events. winex11: Keep track of the host windows children window rects. winex11: Keep track of the host windows relative rects. winex11: Keep track of the host window children of interest. winex11: Create host windows recursively up to root_window. winex11: Introduce a new struct host_window for host-only windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/6649

2 8

[PATCH 0/3] MR6622: msvcp90: Exclude sign from count in num_put.
by Daniel Lehman (＠dlehman25) 11 Oct '24

11 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6622

4 8

[PATCH v3 0/6] MR6640: propsys: Support converting to BSTR for PropVariantToVariant.
by Ziqing Hui (＠zhui) 11 Oct '24

11 Oct '24

This is based on top of !6526, will mark ready after !6526 is merged. -- v3: propsys: Support converting to BSTR for PropVariantToVariant. propsys: Use debugstr_variant for the trace in VariantToPropVariant. propsys: Implement PropVariantToBSTR. propsys/tests: Test truncating for PropVariantToString. propsys/tests: Test PropVariantToBSTR. propsys: Add PropVariantToBSTR stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/6640

3 8

Re: [PATCH v5 0/6] MR6618: jscript: Allow ES5 keywords in identifiers. - approved
by Alexandre Julliard (＠julliard) 10 Oct '24

10 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6618

1 0

Re: [PATCH v5 0/6] MR6639: shlwapi: Fix a few things in wnsprintf() format handling. - approved
by Alexandre Julliard (＠julliard) 10 Oct '24

10 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6639

1 0

Re: [PATCH v5 0/3] MR6603: win32u: Support QDC_VIRTUAL_MODE_AWARE QueryDisplayConfig flag. - approved
by Alexandre Julliard (＠julliard) 10 Oct '24

10 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6603

1 0

Re: [PATCH v2 0/3] MR6647: winemac: Use SetIMECompositionRect to keep track of IME position. - approved
by Alexandre Julliard (＠julliard) 10 Oct '24

10 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6647

1 0

Re: [PATCH v3 0/1] MR6635: mlang: Check handle validity in IMLangFontLink_GetFontCodePages. - approved
by Alexandre Julliard (＠julliard) 10 Oct '24

10 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6635

1 0

Re: [PATCH v2 0/5] MR6645: dplayx: Test fixes and a test for ADDFORWARD handling. - approved
by Alexandre Julliard (＠julliard) 10 Oct '24

10 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6645

1 0

[PATCH v2 0/1] MR6646: dplayx/tests: Correct Enum tests.
by Alistair Leslie-Hughes (＠alesliehughes) 10 Oct '24

10 Oct '24

The EnumAddressTypes tests wasn't actually calling the enum function. The code within the test_EnumAddressTypes function appear to be setup for calling EnumAddresses, so added a test for this scenario as well. -- v2: dplayx/tests: Correct Enum tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/6646

3 2

2025

2024

2023

2022

wine-gitlab